--- Log opened Fri May 12 00:00:32 2017
20170512 00:03:29-!- grzywacz [~karol@wesnoth/developer/grzywacz] has quit [Remote host closed the connection]
20170512 00:03:33< celticminstrel> Okay, I'll risk it then.
20170512 00:03:40-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170512 00:06:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170512 00:08:21-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Ping timeout: 272 seconds]
20170512 00:08:45-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Read error: Connection reset by peer]
20170512 00:10:02-!- gfgtdf [~chatzilla@x4e363516.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 53.0.2/20170504105526]]
20170512 00:31:30-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170512 01:16:31< mattsc> celticminstrel: I’ve checked quite a few of the MAI test scenarios and they all work and behave as expected
20170512 01:16:46< celticminstrel> Good to know.
20170512 01:19:10-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Read error: Connection reset by peer]
20170512 01:21:09-!- atarocch [~atarocch@93.68.196.58] has quit [Remote host closed the connection]
20170512 01:48:07-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170512 01:58:50< mattsc> celticminstrel: I am lost.  The wesnoth.synchronize_choice thing …
20170512 01:59:10< mattsc> How would I use this inside the AI code to, for example, put a unit on the map?
20170512 01:59:38< mattsc> So that it then also gets executed in a replay, I mean.
20170512 01:59:41-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170512 01:59:55-!- irker280 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170512 02:00:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170512 02:00:50< mattsc> I need something in the AI code that gets put into the replay, and that only happens for the ai.* functions, does it not?
20170512 02:00:58< celticminstrel> So are you confused about how to put the unit on the map, or how to make it work in a replay? I think it probably can't work in a replay...
20170512 02:01:36< mattsc> The latter - which is the whole point of ai.synced_command …
20170512 02:01:41< celticminstrel> I see.
20170512 02:02:08< mattsc> E.g. in SotBE synced_command, the ships unload units which then take part in the fighting.
20170512 02:02:22< mattsc> *SotBE:Black_Flag
20170512 02:02:34< mattsc> If that doesn’t happen in the replay, that’s kind of a problem ...
20170512 02:02:45< celticminstrel> Hmm.
20170512 02:03:06< celticminstrel> I wonder what else people use synced_command for.
20170512 02:03:27< mattsc> Well, that’s the purpose for which we introduced it back in the day.
20170512 02:03:40< celticminstrel> For putting units on the map?
20170512 02:04:05< mattsc> Or having the AI do things that are not covered by the other ai.* functions
20170512 02:04:13< mattsc> Do things = change the gamestate
20170512 02:04:36< mattsc> And yes, the specific example was, in fact, that scenario in SotBE, IIRC
20170512 02:05:12< celticminstrel> I think maybe the ideal way of doing this would be to deprecate ai.synced_command and add a wesnoth.synced_commands table (maybe name it differently) which works similarly to wesnoth.wml_actions...
20170512 02:05:48< mattsc> celticminstrel: that’s fine by me; I have no personal feelings about ai.synced_command.
20170512 02:06:32< celticminstrel> That could still have problems in a replay if you distribute it, mind you; to be replay-safe you'd probably want to avoid loading additional synced commands via dofile or require.
20170512 02:08:19 * celticminstrel looks at the list of current synced commands... recruit, recall... oh hey, disband.
20170512 02:08:31< mattsc> disband?
20170512 02:08:46< celticminstrel> Dismissing a unit from the recall list.
20170512 02:09:04< celticminstrel> Apparently fire_event is a synced command. Huh.
20170512 02:09:08< mattsc> Right.  I meant, that’s an AI command?
20170512 02:09:16< celticminstrel> No, it's a synced command.
20170512 02:09:29< mattsc> Ah, ok.
20170512 02:09:43< celticminstrel> Which means it's a valid tag in a replay or in [do_command] IIUC.
20170512 02:11:06< celticminstrel> Others that probably are meaningless to AI include auto_shroud, update_shroud, debug_unit, debug_create_unit, debug_lua, ... huh.
20170512 02:13:52< celticminstrel> debug_lua is practically the same as lua_ai plus a debug announcement.
20170512 02:14:42< mattsc> The nice thing of ai.synced_command is that you can have the AI do pretty much anything in a synced way — even though as far as I know it is only used in two places, and only to put units on the map
20170512 02:14:55< mattsc> I doubt that it is used much in UMC, but you never know
20170512 02:14:56< celticminstrel> The rest of the synced commands after that are various debug commands.
20170512 02:15:37< mattsc> I did noticed that killing and changing units in debug mode now shows up in the replays.  That’s nice.
20170512 02:16:08< celticminstrel> I don't like how ai.synced_command takes a code string as its argument, but without something of equivalent power to replace it, I think it can't be removed.
20170512 02:16:30< mattsc> Agreed - on both points.
20170512 02:23:34 * celticminstrel poke vultraz_iOS 
20170512 02:23:58-!- irker350 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170512 02:23:58< irker350> wesnoth: Celtic Minstrel wesnoth:master 307754884c91 / src/editor/palette/ (item_palette.cpp terrain_palettes.cpp unit_palette.cpp): Some minor reformatting of editor palette code https://github.com/wesnoth/wesnoth/commit/307754884c915e7e23c3ab84781302e550fc4bb6
20170512 02:23:58< irker350> wesnoth: Celtic Minstrel wesnoth:master 308ad7de099f / / (6 files in 3 dirs): Improve editor groups interface https://github.com/wesnoth/wesnoth/commit/308ad7de099f5d99b53be3719f37fe2d0e796beb
20170512 02:25:21< vultraz_iOS> Yes?
20170512 02:25:31< vultraz_iOS> I'm heading out
20170512 02:25:38 * celticminstrel points at the commit.
20170512 02:25:51< vultraz_iOS> I like
20170512 02:26:06< celticminstrel> If you feel like it you could bump up core+campaigns to the new syntax.
20170512 02:26:12< vultraz_iOS> Will have to look fully later
20170512 02:26:19< vultraz_iOS> New syntax?
20170512 02:26:20< vultraz_iOS> Ah
20170512 02:26:35< vultraz_iOS> I see
20170512 02:26:38< vultraz_iOS> Alright
20170512 02:26:46< vultraz_iOS> Later though
20170512 02:27:15< celticminstrel> editor_group -> terrain_group and [race]editor_icon
20170512 02:56:48< mattsc> celticminstrel: I looked at the ai_helper directional functions, and the only one that could be replaced by the new wesnoth.map functions is this one:
20170512 02:56:50< mattsc> https://github.com/wesnoth/wesnoth/blob/master/data/ai/lua/ai_helper.lua#L585
20170512 02:57:28< mattsc> Given that that’s a two-liner and that it is an additional example of how to use the more general functions (with the two before it), I’d prefer to keep that.
20170512 02:58:48< celticminstrel> get_direction_index can't be replaced?
20170512 02:59:57< mattsc> No.
20170512 03:00:20< mattsc> Did you look at what it does?  Specifically what the ’n’ accomplishes?
20170512 03:00:56< mattsc> It’s not just the 6 hex directions.  It does this for an arbitrary number of directions, as shown in the three uses of it below.
20170512 03:01:38< celticminstrel> Ah.
20170512 03:01:52< celticminstrel> I looked but didn't exactly comprehend. >_>
20170512 03:03:18< mattsc> No worries  :)
20170512 03:07:56< pydsigner> celticminstrel: just saw your bump of the CC issue, I am working on that
20170512 03:08:07< pydsigner> (sorry my inbox is still overwhelmed with GNA stuff)
20170512 03:08:10< celticminstrel> CC?
20170512 03:08:16< pydsigner> Creative Commons
20170512 03:08:21< celticminstrel> Oh this is pydsigner not mattsc talking. >_>
20170512 03:08:44< pydsigner> The slightly less good-looking mattsc 
20170512 03:25:39< mattsc> Uh …  You got a pretty inaccurate view of me, it seems.  ;-)
20170512 03:28:54< celticminstrel> More like it's just difficult to see orange text on purple background, and I just assumed the speaker hadn't changed. >_>
20170512 03:33:11< mattsc> Actually, I was reacting to pydsigner’s last comment with that.
20170512 03:33:32< celticminstrel> Maybe I was too. >_>
20170512 03:33:55< mattsc> Ah.
20170512 03:49:46-!- Kwandulin [~Kwandulin@p200300760F6D80A7BD3C0A077C9E43A9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170512 04:02:19< celticminstrel> FTR, DeFender1031, square parenthetical split is used for sounds too, not just in animations but anywhere sounds can be used.
20170512 04:03:02< celticminstrel> So I guess you could write eg [sound]sound=quake-[1~5].wav and it would randomly pick one of five quake sounds.
20170512 04:49:32-!- celticminstrel is now known as celmin|sleep
20170512 04:50:11-!- Kwandulin [~Kwandulin@p200300760F6D80A7BD3C0A077C9E43A9.dip0.t-ipconnect.de] has quit [Quit: [endlevel] result=novictorynodefeatjustquit [/endlevel]]
20170512 05:20:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170512 05:25:05-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170512 05:25:22-!- irker350 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170512 05:26:50< vultraz_iOS> i have been sucked into another random refactor :|
20170512 05:27:28< celmin|sleep> XD
20170512 05:38:45-!- elias [~allefant@allegro/developer/allefant] has quit [Quit: WeeChat 1.4]
20170512 05:42:20-!- allefant [~allefant@allegro/developer/allefant] has joined #wesnoth-dev
20170512 05:59:35-!- celmin|sleep [~celmin@unaffiliated/celticminstrel] has quit [Read error: Connection reset by peer]
20170512 06:00:34-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170512 06:04:12-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Remote host closed the connection]
20170512 06:18:18-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170512 06:18:26-!- celticminstrel is now known as celmin|sleep
20170512 06:34:54-!- JyrkiVesterinen [~JyrkiVest@85-76-66-132-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170512 06:39:54-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170512 06:40:01-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170512 06:41:18< JyrkiVesterinen> mattsc: Regarding AI determinism, the AI is definitely nondeterministic if units have high enough HP for Monte Carlo damage prediction to kick in.
20170512 06:41:55< JyrkiVesterinen> Monte Carlo simulation is nondeterministic by nature. There isn't any guarantee that it would return the same result for two equally good/bad battles.
20170512 06:43:34-!- atarocch [~atarocch@natmobil.fk.se] has joined #wesnoth-dev
20170512 07:07:56-!- grzywacz [~karol@wesnoth/developer/grzywacz] has joined #wesnoth-dev
20170512 07:08:57-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170512 07:12:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170512 07:54:05-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170512 07:58:25-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Read error: Connection reset by peer]
20170512 08:01:58-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20170512 08:48:32< DeFender1031> celmin|sleep, Not sure that best fit would be detrimental there either. Weird to use, sure, but not detrimental.
20170512 08:57:13-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170512 09:01:15-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170512 09:46:05-!- JyrkiVesterinen [~JyrkiVest@85-76-66-132-nat.elisa-mobile.fi] has quit [Quit: .]
20170512 10:17:33-!- atarocch [~atarocch@natmobil.fk.se] has quit [Remote host closed the connection]
20170512 10:25:13-!- JyrkiVesterinen [~JyrkiVest@85-76-66-132-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170512 10:29:59-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170512 10:33:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170512 10:44:31-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Read error: Connection reset by peer]
20170512 10:58:46-!- atarocch [~atarocch@2.43.255.80] has joined #wesnoth-dev
20170512 11:06:55-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170512 11:20:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170512 11:21:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170512 11:32:14-!- atarocch [~atarocch@2.43.255.80] has quit [Remote host closed the connection]
20170512 11:50:52-!- clavi [~clavi@v22017034422546657.goodsrv.de] has quit [Quit: ZNC - http://znc.in]
20170512 11:54:15-!- clavi [~clavi@v22017034422546657.goodsrv.de] has joined #wesnoth-dev
20170512 12:21:19-!- Kwandulin [~Kwandulin@p200300760F6D80FB695D4FBFD7877D99.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170512 12:39:51< mattsc> JyrkiVesterinen: yeah, good point
20170512 13:20:50-!- DeFender1031 [~DeFender1@46-116-209-76.bb.netvision.net.il] has quit [Remote host closed the connection]
20170512 13:21:09-!- DeFender1031 [~DeFender1@46-116-209-76.bb.netvision.net.il] has joined #wesnoth-dev
20170512 13:23:04< wedge009> vultraz_iOS: celticminstrel: We had contacts from Spanish and Lithuanian translators, I think concerned about a release happening so soon after Secrets of the Ancients was added. https://www.wesnoth.org/gettext/index.php?package=wesnoth-sota&order=trans&version=master shows only three other translations submitted for SotA.
20170512 13:23:21< wedge009> 1:44:27 am - zookeeper: 194 Non-digested Members of Wesnoth-dev, 48 Digested Members of Wesnoth-dev
20170512 13:23:51< wedge009> What does digested mean in this context? I had a terrifying mental image of half-eaten Wesnoth members...
20170512 13:24:43< zookeeper> digested presumably means they only get a mail once per week/month/something with all the posts in it, instead of immediately one mail per post.
20170512 13:25:07< vultraz_iOS> you can do that? O_O
20170512 13:25:39< zookeeper> well that's what i've learned to expect digest to usually mean in these kinds of contexts
20170512 13:25:44< wedge009> Right, I just realised it's in the context of message digests. Shouldn't make verbs from nouns... x.x
20170512 13:26:48< zookeeper> of course, i'm not definitively saying there is _not_ a necrophage involved
20170512 13:27:46< wedge009> Heh.
20170512 13:27:59< DeFender1031> hahahahahahahaha
20170512 13:28:19< DeFender1031> Yeah, that should be "members using digest" as opposed to, well...
20170512 13:29:11< DeFender1031> Though I do like the idea of having the more annoying members digested...
20170512 13:29:24 * wedge009 runs away
20170512 13:31:23< zookeeper> *bite.ogg*
20170512 14:02:27-!- allefant is now known as elias
20170512 14:21:17< celmin|sleep> DeFender1031: Well, best fit there would in principle make some sounds more frequent than others in a sound source, I guess?
20170512 14:31:20-!- JyrkiVesterinen [~JyrkiVest@85-76-66-132-nat.elisa-mobile.fi] has quit [Quit: .]
20170512 14:37:07-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20170512 15:00:52-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20170512 15:04:53< DeFender1031> celmin|sleep, yeah. Not terrible, just weird.
20170512 15:05:40-!- celmin|sleep is now known as celticminstrel
20170512 15:06:34< celticminstrel> Best fit wouldn't come into play in the specific example I mentioned, mind you.
20170512 15:07:34< celticminstrel> Actually, I think I'd expect cartesian product rather than best fit in this case...
20170512 15:11:47< celticminstrel> Like if you wrote sound=[small,large]-quake-[1~5].wav I'd expect it to expand to small-quake-1.wav,small-quake-2.wav,small-quake-3.wav,small-quake-4.wav,small-quake-5.wav,large-quake-1.wav,large-quake-2.wav,large-quake-3.wav,large-quake-4.wav,large-quake-5.wav
20170512 15:12:09< celticminstrel> Making it similar to glob braces.
20170512 15:25:04< vultraz_iOS> will we be able to do the release as scheduled?
20170512 15:25:13< celticminstrel> You're asking me?
20170512 15:25:34< celticminstrel> I'll say that I know no reasons why we can't.
20170512 15:27:17< vultraz_iOS> any chance for a fix to https://github.com/wesnoth/wesnoth/issues/1683 beforethen?
20170512 15:27:20< vultraz_iOS> before then*
20170512 15:27:31< matthiaskrgr> :( 
20170512 15:27:36-!- Appleman1234 [~quassel@pl1428.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170512 15:27:42< celticminstrel> I haven't looked into that issue at all.
20170512 15:28:18< celticminstrel> Maybe I can look into it today.
20170512 15:28:36< vultraz_iOS> matthiaskrgr: you need to stop pressing the storyscreen button so fast ;_;
20170512 15:28:44< matthiaskrgr> :X
20170512 15:28:48< matthiaskrgr> sorry
20170512 15:30:57< celticminstrel> That's just an aesthetic bug though, right? So it shouldn't be a blocker if I understand correctly.
20170512 15:31:26< matthiaskrgr> yeah, it just looks a bit odd
20170512 15:31:42< matthiaskrgr> well, the text could become hard to read technically, depending on the background and resolution
20170512 15:32:05< celticminstrel> Does it not fix itself once you stop clicking?
20170512 15:32:56-!- irker572 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170512 15:32:56< irker572> wesnoth: Charles Dang wesnoth:master 0e7866db2d99 / data/lua/wml/kill.lua: Possible for fix #1683 https://github.com/wesnoth/wesnoth/commit/0e7866db2d99f42bc737f7760bb451358551446b
20170512 15:33:27< matthiaskrgr> it fades back to normal when click again 
20170512 15:33:35< vultraz_iOS> dammit
20170512 15:33:38< celticminstrel> You probably shouldn't be auto-closing issues when you're not certain... although I don't know why you're not certain here?
20170512 15:33:44< vultraz_iOS> accidentally closed the bug 
20170512 15:33:49< vultraz_iOS> meant to type 'fix for'
20170512 15:34:03< celticminstrel> Well, that wouldn't trigger auto-close.
20170512 15:34:06< vultraz_iOS> anyway,, im pretty certain that's the cause
20170512 15:34:10< celticminstrel> I think?
20170512 15:34:32< celticminstrel> AFAIK it has to be exactly "fix(es)? #\d+" to auto-close.
20170512 15:34:44< celticminstrel> But yeah, if it's documented as event_context, then that's definitely the cause.
20170512 15:35:44< vultraz_iOS> now back to refactoring variable_info
20170512 15:36:06< celticminstrel> :(
20170512 15:39:34< vultraz_iOS> just wanted to simplify it's metastructure and now I'm stuck refactoring all the things
20170512 15:40:22< celticminstrel> You should probably put that on hold until Monday.
20170512 15:40:31< vultraz_iOS> probably
20170512 15:41:24< vultraz_iOS> oh huh there's a noexcept operator too
20170512 15:42:00< celticminstrel> Like if(noexcept(expression))?
20170512 15:42:38< vultraz_iOS> "The noexcept operator performs a compile-time check that returns true if an expression is declared to not throw any exceptions."
20170512 15:43:36-!- JyrkiVesterinen [~JyrkiVest@87-100-189-153.bb.dnainternet.fi] has joined #wesnoth-dev
20170512 15:46:13< DeFender1031> celticminstrel, I need to go now, but cartesian won't be backwards compatible in the case where the lengths match. If there are no places that have more than one set of brackets, that's probably fine, but if there are, then it's something we'll need to think about. I do like the idea in theory though.
20170512 15:46:18< DeFender1031> TTY next week.
20170512 15:46:21-!- DeFender1031 [~DeFender1@46-116-209-76.bb.netvision.net.il] has quit [Quit: I'm not back now.]
20170512 15:48:37< JyrkiVesterinen> One example where the C++ standard library uses the noexcept operator is when a vector reallocates its storage.
20170512 15:49:00< JyrkiVesterinen> If there is a noexcept move operator, the vector will move the elements from the old buffer to the new one.
20170512 15:49:12< JyrkiVesterinen> If there isn't, then it tries to copy them.
20170512 15:49:32< JyrkiVesterinen> And if even copying isn't possible, then the last resort is a throwing move constructor.
20170512 15:50:02 * celticminstrel assumes you mean move constructor, not operator.
20170512 15:50:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170512 15:50:51< JyrkiVesterinen> In particular, this kind of implementation means that functions which make the vector larger (say, emplace_back()) have a strong exception guarantee if there is *either* a copy constructor *or* a non-throwing move constructor.
20170512 15:51:42< JyrkiVesterinen> In other words, if an exception is thrown at any point, the operation doesn't have any effect (or its effects are rolled back).
20170512 15:51:53< JyrkiVesterinen> Except if it needs to use the throwing move constructor.
20170512 16:12:53-!- Kwandulin2 [~Kwandulin@p5DDD3425.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170512 16:15:49-!- Kwandulin [~Kwandulin@p200300760F6D80FB695D4FBFD7877D99.dip0.t-ipconnect.de] has quit [Ping timeout: 255 seconds]
20170512 17:08:27-!- APic [apic@apic.name] has quit [Ping timeout: 240 seconds]
20170512 17:11:58-!- gfgtdf [~chatzilla@x4e363516.dyn.telefonica.de] has joined #wesnoth-dev
20170512 17:12:03-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170512 17:12:17< gfgtdf> celticminstrel: fire_event sycned command is used by the wml menu items
20170512 17:12:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170512 17:12:44< gfgtdf> celticminstrel: it doesnt sem to support wml prameters, otherwise it'd be enough to replace ai.scyned_command
20170512 17:13:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170512 17:13:18< celticminstrel> WML parameters?
20170512 17:13:38-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170512 17:14:00< gfgtdf> pass  wml tag as parmeters, sicne events have no peameters concept
20170512 17:14:04< gfgtdf> 20170512 02:14:42< mattsc> The nice thing of ai.synced_command is that you can have the AI do pretty much anything in a synced way — even though as far as I know it is only used in two places, and only to put units on the map
20170512 17:14:33< gfgtdf> mattsc: this is exaclty the problem, specailyl since if you know how human can also use this in mp.
20170512 17:14:33-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Read error: Connection reset by peer]
20170512 17:14:47< celticminstrel> IIRC events have two config parameters (normally only used to pass through weapons for attack events).
20170512 17:14:51-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170512 17:16:13< celticminstrel> gfgtdf: I dunno, maybe [lua_ai] could be an error if executed by a human-controlled side?
20170512 17:16:57< gfgtdf> celticminstrel: hmm i think that'd be an impovement im still note sure whetehr it'D make it 100% safe
20170512 17:17:12< mattsc> gfgtdf: I understand that, I was just saying that that was the motivation.  And there are some things a couple AIs do that are not otherwise possible (or at least are very awkward to do otherwise).
20170512 17:17:27< celticminstrel> I do think the ability to register custom synced commands is cleaner, though.
20170512 17:18:28-!- APic [apic@apic.name] has joined #wesnoth-dev
20170512 17:21:40< gfgtdf> celticminstrel: hmm uit seelms liek wml/lua has no direct acces to queued_event::data though
20170512 17:22:08< celticminstrel> gfgtdf: You mean in wesnoth.current.event_context. or are you talking about something else?
20170512 17:22:21< gfgtdf> celticminstrel: yes i'm talking about that
20170512 17:28:42< celticminstrel> gfgtdf: Well, it does give partial access to it.
20170512 17:29:18< gfgtdf> celticminstrel: i see oynl acees to the first/second memebers not to a  gerneral data table
20170512 17:29:27< celticminstrel> That's why I said partial.
20170512 17:29:58< celticminstrel> Why is it stored in "first" and "second" tags?
20170512 17:30:28< gfgtdf> celticminstrel: don't know ut how woudl you ahev done it ?
20170512 17:30:54< celticminstrel> If you changed the internals to use "weapon" and "second_weapon" tags, then the code at game_lua_kernel.cpp:1352 could simply copy the data config and add the name, id, x1, x2, y1, y2 members.
20170512 17:31:59< gfgtdf> celticminstrel: ye i guess that coudl easily be done. probabyl that config was invented before that lua interface
20170512 17:32:01< celticminstrel> ie, change line 1353 to "config cfg = ev.data" and remove lines 1356-61.
20170512 17:32:15< celticminstrel> Probably.
20170512 17:34:27< celticminstrel> BTW gfgtdf, when are you going to merge your config refactor?
20170512 17:35:07< gfgtdf> celticminstrel: my msvc doesnt start so it'll probabyl take a while i codul try to do with without it if someone else depends on it
20170512 17:35:50< celticminstrel> Huh?
20170512 17:36:16< gfgtdf> celticminstrel: was that a question or an epression of beeing suprised?
20170512 17:36:20< celticminstrel> Are you not merging because you're not sure it compiles on MSVC?
20170512 17:36:34< celticminstrel> It was an expression of confusion.
20170512 17:37:33< gfgtdf> celticminstrel: no my personal msvc installation complains of license beeeing ran out, but that's silly since i've ben using it since for more thna  a year now and i registerd it and it never complained.
20170512 17:39:45< celticminstrel> So how does this mean you can't merge it?
20170512 17:40:28< gfgtdf> celticminstrel: i could edit those file with normal text editor, but it'd be a little more work.
20170512 17:40:55< celticminstrel> So it's not finished?
20170512 17:41:39< gfgtdf> celticminstrel: the last commit needs updating in the source_list files (whcih i'd do with a normal teteditor anyway) but it also has mergign clicts in config.cpp
20170512 17:41:51< celticminstrel> I see.
20170512 17:42:05< celticminstrel> Well, I guess we can put it off until after the release at least.
20170512 17:42:26< celticminstrel> I wanted to try some stuff in config too but was waiting on that before doing anything.
20170512 17:42:37-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170512 17:53:45< gfgtdf> hmm ok i'l mtry to edito those files with a texrt editor
20170512 17:55:57< celticminstrel> (I'm also hopeful that the refactor will allow including config.hpp in fewer places.)
20170512 17:59:20< gfgtdf> celticminstrel: ok just poshed it it's likeley to still hav erros though
20170512 18:07:23< gfgtdf> celticminstrel: you think that we can mark #1042 as fixed scine mp does havea  replay_last_turn function? form the deicussion it realyl looks liek that bug was filed with mp in mind
20170512 18:20:35-!- Kwandulin2 [~Kwandulin@p5DDD3425.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170512 18:30:13< celticminstrel> Is replay_last_turn something that can be invoked from the menu on your turn, for example?
20170512 18:31:11< celticminstrel> Initially I wasn't clear on what they were asking for, but now I think it's simply a way to be away from the computer while it's not their turn and then be able to see what they missed when they get back - similar to the effect of opening a menu to prevent animations.
20170512 18:32:31-!- Kwandulin [~Kwandulin@p200300760F6D80FB994ADB139A1E2C88.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170512 18:33:39-!- irker572 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170512 18:34:35< gfgtdf> celticminstrel: in 1.13 in mp when you click  the 'go back to turn x' (which load the autosaves) i'll silently load these saves and repaly the game until the currrent position. (whieol staying connected)
20170512 18:34:38< gfgtdf> while*
20170512 18:35:26< celticminstrel> That sounds a bit terrible.
20170512 18:35:40< gfgtdf> celticminstrel: how ?
20170512 18:35:56< celticminstrel> Because a) it changes the meaning of the autosaves menu and b) it won't work in single-player mode.
20170512 18:36:26< gfgtdf> celticminstrel: you cannot load saves in mp games anyway
20170512 18:36:36< gfgtdf> and how is not working in singelplayer terrible?
20170512 18:37:26< celticminstrel> You don't think the function to "replay from turn X" would be useful also in singleplayer?
20170512 18:37:28< celticminstrel> I think it would be.
20170512 18:38:16< gfgtdf> celticminstrel: well it's mostly to be able to go afk while other players  are thinking. The ai is usually rather fast so teh demand is not really there
20170512 18:38:47< celticminstrel> But the implementation is there, so why not expose it to singleplayer too?
20170512 18:39:00< celticminstrel> Or is there a reason why it can't work in singleplayer?
20170512 18:39:15< gfgtdf> celticminstrel: i guess it coudl also work in sp, you juyt have to add teh ui
20170512 18:40:25< celticminstrel> So if you jump back one turn with this feature, does it replay starting from when you last ended your turn?
20170512 18:40:43< celticminstrel> Or does it replay your last turn as well?
20170512 18:41:05< gfgtdf> celticminstrel: it start from the position when teh autosave was done, so it includes you last turn.
20170512 18:41:16< gfgtdf> the 'implementation' is here: https://github.com/wesnoth/wesnoth/blob/master/src/hotkey/hotkey_handler_sp.cpp#L304
20170512 18:43:14< gfgtdf> one coudl probaby impove tat code with a make_shared and a std::move
20170512 18:43:25< gfgtdf> that*
20170512 18:44:09< celticminstrel> reset_gamestate_exception, huh.
20170512 18:52:02-!- Kwandulin [~Kwandulin@p200300760F6D80FB994ADB139A1E2C88.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170512 18:53:26< celticminstrel> Hmm. Theoretically is it possible that someone a) opens a modal dialog, b) opens a modeless dialog, c) closes the modal dialog, d) closes the modeless dialog?
20170512 18:53:35< celticminstrel> The order being the important thing.
20170512 18:53:47-!- sevu [~Shiki@141.39.226.226] has joined #wesnoth-dev
20170512 18:53:48< celticminstrel> ie, can we assume that, at the time a modal dialog is closed, there are no modeless dialogs open?
20170512 18:54:17< celticminstrel> And also, could there be a situation where we'd want a modeless dialog to stay open after a modal dialog was closed?
20170512 18:54:37-!- Kwandulin [~Kwandulin@p200300760F6D80FB994ADB139A1E2C88.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170512 18:58:14< celticminstrel> AFAIK the only things we currently need modeless dialogs for are tooltips and the floating textbox (chat, etc).
20170512 18:58:23< celticminstrel> (They're not used for the latter yet, though.)
20170512 18:59:23< celticminstrel> \o/
20170512 18:59:34< celticminstrel> I got the blinking text cursor only in the front window!
20170512 18:59:55< celticminstrel> So does anyone have opinions as to whether the text cursor in the unfocused window should be visible?
20170512 19:00:19< celticminstrel> There are three options: 1) Visible 2) Invisible 3) Whatever it was at the moment the second window was opened.
20170512 19:01:13< JyrkiVesterinen> I'd prefer invisible.
20170512 19:01:50-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20170512 19:07:27< celticminstrel> Oh actually, is it bad if it disappears when a tooltip is visible?
20170512 19:12:24< celticminstrel> Oh, I think vultraz_iOS completely messed up the window stack for modeless dialogs.
20170512 19:12:37< celticminstrel> Fortunately in a way that doesn't break anything though. I think.
20170512 19:12:57< celticminstrel> Basically the modeless window is, in general, not on the window stack when it's open.
20170512 19:13:10< celticminstrel> Should it be?
20170512 19:13:28-!- shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20170512 19:13:28-!- sevu [~Shiki@141.39.226.226] has quit [Disconnected by services]
20170512 19:13:39< celticminstrel> I can either remove the window stack code from modeless_dialog, or fix it by moving the pop to hide().
20170512 19:20:59< celticminstrel> Any opinions here, Jyrki?
20170512 19:21:26< JyrkiVesterinen> I think modeless windows shouldn't be counted in the window stack.
20170512 19:21:46-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170512 19:21:46< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release Charles Dang 0e7866d: Possible for fix #1683 Failed
20170512 19:21:46< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-334
20170512 19:21:51-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170512 19:22:47< celticminstrel> Hmm.
20170512 19:24:03< celticminstrel> I think what I'll do is only include modeless windows that allow interaction, which excludes tooltips but would include the hypothetical GUI2 floating textbox and thus allow it to also have a blinking cursor.
20170512 19:24:24-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Read error: Connection reset by peer]
20170512 19:24:59< JyrkiVesterinen> That sounds good to me. :)
20170512 19:26:43-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170512 19:26:43< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug Charles Dang 0e7866d: Possible for fix #1683 Failed
20170512 19:26:43< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-334
20170512 19:26:48-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170512 19:29:25< celticminstrel> There seems to have been intent to have tooltops automatically close themselves after a delay...
20170512 19:29:35< celticminstrel> ^tooltips
20170512 19:34:29-!- irker889 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170512 19:34:29< irker889> wesnoth: Celtic Minstrel wesnoth:master cbc4af1a201d / changelog data/gui/widget/text_box_default.cfg src/gui/widgets/text_box_base.cpp: Add blinking text cursor to focused textbox https://github.com/wesnoth/wesnoth/commit/cbc4af1a201d6358519113922cd7901da893f00b
20170512 19:34:31< irker889> wesnoth: Celtic Minstrel wesnoth:master a1f481f539f5 / src/gui/dialogs/modeless_dialog.cpp: Fix window stack for modeless dialogs https://github.com/wesnoth/wesnoth/commit/a1f481f539f5a8cf38e589057db1a27732353220
20170512 19:34:33< irker889> wesnoth: Celtic Minstrel wesnoth:master 640e28f731f3 / src/gui/widgets/text_box_base.cpp: Don't update the textbox canvas if the cursor alpha didn't change https://github.com/wesnoth/wesnoth/commit/640e28f731f3606a032d9b52a42ce6caf1a9087f
20170512 19:34:57< celticminstrel> gfgtdf: I thought you said you pushed something to PR 1010, but I don't see anything new there?
20170512 19:35:19< celticminstrel> Oh, it was force-pushed sometime in the last 24 hours though.
20170512 19:36:27< celticminstrel> gfgtdf: You still didn't remove "struct config_clear_state" though.
20170512 19:41:33< celticminstrel> vultraz_iOS: Just checking, but there will be a 1.13.9, right?
20170512 19:45:18< gfgtdf> celticminstrel: sure there'll be
20170512 19:45:45-!- shiki [~Shiki@141.39.226.226] has quit [Ping timeout: 240 seconds]
20170512 19:45:49< celticminstrel> 'kay, I'm starting to assign things to it then.
20170512 19:46:52< celticminstrel> JyrkiVesterinen: Do you plan to merge PR 1028 before Sunday?
20170512 19:47:10< JyrkiVesterinen> No, I don't.
20170512 19:47:28< JyrkiVesterinen> I'd like to replace my custom string_view implementation with Boost's.
20170512 19:47:36< celticminstrel> pydsigner, vultraz_iOS, will the CC stuff be ready by Sunday?
20170512 19:47:50< JyrkiVesterinen> And that would require aquileia/external to have Boost string_view in all branches.
20170512 19:48:06< JyrkiVesterinen> IIRC, it has string_view in all branches except VC14 at the moment.
20170512 19:48:08-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170512 19:48:55< JyrkiVesterinen> I can try rebuilding Boost myself and sending a pull request to aquileia/external, but it wouldn't be in time for me to have time to finish PR1028 this week.
20170512 19:49:24< celticminstrel> Hmm, PR 992 should probably be merged... but it's untested...
20170512 19:49:54< celticminstrel> I don't know any reason why we can't merge PR 995.
20170512 19:50:48-!- shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20170512 19:57:12< irker889> wesnoth: Celtic Minstrel wesnoth:login_save_crypt 9365538b3b7a / / (29 files in 10 dirs): Don't store the user's password in plaintext in the prefs file https://github.com/wesnoth/wesnoth/commit/9365538b3b7aa7b48ac64990f3996d60ce11297c
20170512 19:57:14< irker889> wesnoth: Celtic Minstrel wesnoth:login_save_crypt c9191c98122d / / (22 files in 9 dirs): Add OpenSSL's libcrypto as a dependency https://github.com/wesnoth/wesnoth/commit/c9191c98122d97310eddae041a9fd3496cd5b894
20170512 19:57:16< irker889> wesnoth: Celtic Minstrel wesnoth:login_save_crypt 894ee4364397 / src/preferences/credentials.cpp: Use RC4 cipher for encrypting the password data. https://github.com/wesnoth/wesnoth/commit/894ee43643976199cf410cd2970550f6edb5fa76
20170512 19:57:18< irker889> wesnoth: Celtic Minstrel wesnoth:login_save_crypt ebe360dfa5e8 / src/preferences/credentials.cpp: Use RAII for all that zero-filling https://github.com/wesnoth/wesnoth/commit/ebe360dfa5e8f51496d0dda47c5928103829f967
20170512 20:03:24-!- JyrkiVesterinen [~JyrkiVest@87-100-189-153.bb.dnainternet.fi] has quit [Quit: .]
20170512 20:04:43-!- mjs-de [~mjs-de@x5ce371da.dyn.telefonica.de] has joined #wesnoth-dev
20170512 20:21:58-!- shiki [~Shiki@141.39.226.226] has quit [Ping timeout: 260 seconds]
20170512 20:26:28< pydsigner> celticminstrel: I'll have it tonight or it will have to wait until next week
20170512 20:28:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170512 20:28:48-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170512 20:29:11-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Read error: Connection reset by peer]
20170512 20:29:11-!- shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20170512 20:29:26-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170512 21:01:38-!- shiki [~Shiki@141.39.226.226] has quit [Ping timeout: 260 seconds]
20170512 21:09:31-!- grzywacz [~karol@wesnoth/developer/grzywacz] has quit [Remote host closed the connection]
20170512 21:11:18-!- Kwandulin [~Kwandulin@p200300760F6D80FB994ADB139A1E2C88.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170512 21:11:47-!- gfgtdf [~chatzilla@x4e363516.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 53.0.2/20170504105526]]
20170512 21:18:28-!- sevu [~Shiki@141.39.226.226] has joined #wesnoth-dev
20170512 21:18:54< celticminstrel> Just FTR, I added a "stable" label to be used on issues that only affect the current stable version, and started applying it to some issues.
20170512 21:21:06< matthiaskrgr> stable label, it rhymes ! 
20170512 21:21:41< irker889> wesnoth: Celtic Minstrel wesnoth:master 41d0a6b3d827 / data/lua/wml-flow.lua: Fix #1688 https://github.com/wesnoth/wesnoth/commit/41d0a6b3d827c1f241bf5194fe6e2b4f9e484dc6
20170512 21:22:35< matthiaskrgr> oooooooh
20170512 21:22:46< matthiaskrgr> it looks like I can use gdb on an asan-instrumented binary!!
20170512 21:22:48< matthiaskrgr> :O 
20170512 21:22:52< matthiaskrgr> amazin!
20170512 21:22:56< matthiaskrgr> I don't even need to recompile
20170512 21:24:45< matthiaskrgr> hmm, so gfgtdf wasnted me to add a breakpoint to some file...
20170512 21:26:24< matthiaskrgr> if I can find the log .... 
20170512 21:28:20< matthiaskrgr> oh it was mentioned on github, not irc :)
20170512 21:49:56-!- shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20170512 21:49:56-!- sevu [~Shiki@141.39.226.226] has quit [Disconnected by services]
20170512 21:53:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170512 21:54:51-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170512 22:05:50-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 255 seconds]
20170512 22:22:10-!- shiki [~Shiki@141.39.226.226] has quit [Ping timeout: 240 seconds]
20170512 22:23:11-!- shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20170512 22:23:29< matthiaskrgr> celticminstrel: are you still awake?  
20170512 22:23:51< celticminstrel> Maybe.
20170512 22:24:00< matthiaskrgr> I think your "Fix window stack for modeless dialogs" broke the build for me ( https://github.com/wesnoth/wesnoth/issues/1689 ) 
20170512 22:24:05< celticminstrel> Oh yeah, there was a warning about that.
20170512 22:24:14< celticminstrel> And I forgot to fix it.
20170512 22:24:19< matthiaskrgr> :| 
20170512 22:24:30< celticminstrel> I guess just removing the & should work.
20170512 22:25:04< celticminstrel> So auto instead of auto&
20170512 22:25:40< matthiaskrgr> yeah looks like it 
20170512 22:25:50< matthiaskrgr> unless there are other problems in later files, too 
20170512 22:26:08< celticminstrel> I wouldn't expect any.
20170512 22:26:11< matthiaskrgr> ok
20170512 22:26:25< irker889> wesnoth: Celtic Minstrel wesnoth:master e57a94fc8dfc / src/gui/dialogs/modeless_dialog.cpp: Fix #1689 https://github.com/wesnoth/wesnoth/commit/e57a94fc8dfcdd6e9e1f2059c3b10357cc323bdd
20170512 22:27:00< matthiaskrgr> thank you
20170512 22:27:27 * matthiaskrgr goes back to watching the compiler do compily stuff 
20170512 22:32:06< celticminstrel> C4239 should probably be treated as an error... I could add it to global.hpp but not sure if that's really reliable (might not be included everywhere).
20170512 22:47:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170512 22:48:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170512 22:53:39-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170512 22:53:55-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170512 22:55:15-!- shiki [~Shiki@141.39.226.226] has quit [Ping timeout: 240 seconds]
20170512 22:56:23-!- Greg-Bog_ [~greg_bogg@c-73-37-6-51.hsd1.or.comcast.net] has joined #wesnoth-dev
20170512 22:56:37-!- Greg-Bog_ [~greg_bogg@c-73-37-6-51.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170512 22:56:55-!- Greg-Bog_ [~greg_bogg@c-73-37-6-51.hsd1.or.comcast.net] has joined #wesnoth-dev
20170512 22:57:14-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170512 22:57:28-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170512 23:11:53-!- mjs-de [~mjs-de@x5ce371da.dyn.telefonica.de] has quit [Remote host closed the connection]
20170512 23:25:15-!- sevu [~Shiki@p548565DC.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170512 23:29:51-!- travis-ci [~travis-ci@54.81.49.60] has joined #wesnoth-dev
20170512 23:29:52< travis-ci> wesnoth/wesnoth#13840 (master - e57a94f : Celtic Minstrel): The build was fixed.
20170512 23:29:52< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/231739193
20170512 23:29:52-!- travis-ci [~travis-ci@54.81.49.60] has left #wesnoth-dev []
20170512 23:40:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170512 23:41:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
--- Log closed Sat May 13 00:00:06 2017