--- Log opened Sun May 14 00:00:23 2017
20170514 00:02:57-!- grzywacz [~karol@wesnoth/developer/grzywacz] has quit [Ping timeout: 240 seconds]
20170514 00:14:39< loonycyborg> vultraz_iOS: release tarball is uploaded
20170514 00:17:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170514 00:18:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170514 00:21:55-!- gfgtdf [~chatzilla@x4e369b93.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 53.0.2/20170504105526]]
20170514 00:31:07-!- sevu [~Shiki@p54854FAF.dip0.t-ipconnect.de] has quit [Quit: Verlassend]
20170514 00:57:40-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dd9a:4a64:e1f:c3a4] has quit [Remote host closed the connection]
20170514 00:59:18-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170514 01:07:02-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has quit [Quit: "The highest possible stage in moral culture is when we recognize that we ought to control our thoughts." - Charles Darwin]
20170514 01:08:20-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has joined #wesnoth-dev
20170514 01:12:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170514 01:13:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170514 01:20:18-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170514 01:22:40-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dd9a:4a64:e1f:c3a4] has joined #wesnoth-dev
20170514 01:35:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170514 01:50:36-!- trewe [~trewe@2001:8a0:d121:cd01:c41e:df24:b7ea:a075] has quit [Quit: quit]
20170514 02:12:13-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170514 02:44:24-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dd9a:4a64:e1f:c3a4] has quit [Remote host closed the connection]
20170514 02:48:21-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170514 02:55:34-!- irker340 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170514 03:09:34< celticminstrel> So many Lua/WML changes to make sure are documented... X_X
20170514 03:09:55< celticminstrel> I think I did document most of the added Lua API stuff and new WML tags already...
20170514 03:13:37< celticminstrel> Oh, I probably should've passed primary_attack and secondary_attack when firing the event, huh?
20170514 03:13:48< celticminstrel> (In [kill].)
20170514 03:24:45< celticminstrel> I wonder how out-of-date this is. https://wiki.wesnoth.org/GameConfigWML
20170514 03:24:52< celticminstrel> For example...
20170514 03:25:14< celticminstrel> moved_ball_image - is that still a thing? Given the orb colours customization, it seems it likely isn't?
20170514 03:25:37< celticminstrel> Also I'm pretty sure there's something about the logo image that hasn't been added there.
20170514 03:44:58-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170514 03:50:20-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Ping timeout: 240 seconds]
20170514 04:54:00< pydsigner> Oh bother
20170514 04:54:00-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170514 04:54:00< celticminstrel> Hmm?
20170514 04:54:00< pydsigner> Has anyone else encountered the MP game creation screen not fitting the screen properly until a window resize event is sent?
20170514 04:54:00< celticminstrel> I don't recall seeing something like that...
20170514 04:54:20< pydsigner> http://i.imgur.com/74FROhY.png
20170514 04:55:18< pydsigner> I think it's because the game res is set for a 1920x1200 screen but I'm currently using a 1920x1080 screen
20170514 04:56:10< pydsigner> But other things seem to respond correctly and, if I let the window expand to the size it thinks it has and then shrink back down, the problem goes away
20170514 04:57:04< celticminstrel> Huh...
20170514 04:58:04< pydsigner> Yeah.
20170514 04:58:09< pydsigner> Edge case, but annoying.
20170514 04:59:31< pydsigner> Huh that's odd, this time when I started the mp screen I didn't have the problem
20170514 04:59:41< pydsigner> Unlike the prior two wesnoth launches
20170514 05:03:03-!- irker377 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170514 05:03:03< irker377> wesnoth: Daniel Foerster wesnoth:anl-recruitment 9e03299777b8 / data/multiplayer/scenarios/4p_A_New_Land.cfg: Improved ANL recruitment setup https://github.com/wesnoth/wesnoth/commit/9e03299777b82eb0c92d8ccfa9f5132edfa186a5
20170514 05:04:22< pydsigner> celticminstrel: I think this commit should resolve any lingering complaints anyone may have had due to the original fix
20170514 05:04:33< celticminstrel> [set_recruit] was a thing?
20170514 05:04:55< pydsigner> Pretty sure it's been a thing for a long while
20170514 05:05:00< celticminstrel> Is the intent to append to or replace the normal recruit list?
20170514 05:05:05< pydsigner> Replace
20170514 05:05:18< pydsigner> Otherwise you'd use [allow_recruit]
20170514 05:05:18< celticminstrel> And [allow_recruit] appends, right?
20170514 05:05:21< celticminstrel> Okay.
20170514 05:05:40< celticminstrel> Ah, it is documented.
20170514 05:05:46< pydsigner> An existing example of [set_recruit], I believe, is in HttT
20170514 05:06:06< pydsigner> If you visit the Three Sisters instead of Muff Malal
20170514 05:08:48-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dd9a:4a64:e1f:c3a4] has joined #wesnoth-dev
20170514 05:08:49< pydsigner> Anyways, it's been a long day, I'm off
20170514 05:09:13< pydsigner> Wasn't planning on fixing that bug but I actually read the issue emails today instead of marking them all read...
20170514 05:09:58< celticminstrel> Oh wow.
20170514 05:15:40-!- Kwandulin [~Kwandulin@p200300760F6D80F5ED512C1789685CDE.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170514 05:27:31-!- The_Unforgiven [~quassel@2601:40a:c300:b721:9016:ae42:4acb:4b43] has joined #wesnoth-dev
20170514 05:27:31-!- The_Unforgiven [~quassel@2601:40a:c300:b721:9016:ae42:4acb:4b43] has quit [Changing host]
20170514 05:27:31-!- The_Unforgiven [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20170514 05:27:37-!- The_Unforgiven [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Read error: Connection reset by peer]
20170514 05:39:12< Kwandulin> Does share_vision=all even work? Doesn't seem to . . .
20170514 05:39:25< Kwandulin> In the [side] tag
20170514 05:39:26-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170514 05:50:04-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170514 05:50:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170514 06:20:17-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dd9a:4a64:e1f:c3a4] has quit [Remote host closed the connection]
20170514 06:22:53< vultraz_iOS> announcement draft up
20170514 06:24:08< celticminstrel> Maybe I'll edit that then instead of RELEASE_NOTES.
20170514 06:24:15< celticminstrel> (Also, why am I still awake again?)
20170514 06:27:44< shadowm> 1.14 Beta 1, not 1.14.0 Beta 1.
20170514 06:28:48< vultraz_iOS> got it.
20170514 06:29:29< shadowm> Are you going to want the 1.14 add-ons server instance set up befoooooooooooo
20170514 06:29:57< shadowm> I guess I should've asked that before the release since the port number default is hardcoded.
20170514 06:30:59< shadowm> Start thinking exactly when you'll want the 1.14 add-ons server instance set up.
20170514 06:31:09< vultraz_iOS> hmmm
20170514 06:31:25< vultraz_iOS> how about around next release?
20170514 06:31:45< shadowm> I have a feeling your feature freeze policy is going to be softer than 1.12's this time around.
20170514 06:31:58< vultraz_iOS> yes.
20170514 06:32:04< shadowm> S I G H .
20170514 06:32:32< shadowm> I highly recommend waiting until RC 1 in that case.
20170514 06:32:35< shadowm> (BEFORE TAGGING IT.)
20170514 06:33:46< shadowm> Just... try to not move strings around too much or some of your translators may ragequit.
20170514 06:34:04< shadowm> You probably don't want to do that, especially given that for this cycle they need to work on a whole new campaign.
20170514 06:34:22< celticminstrel> I was wondering, does the 1.13 addons server morph into the 1.14 addons server, or is the 1.14 addons server a new instance?
20170514 06:34:29< shadowm> New instance with new port number.
20170514 06:34:34< shadowm> Clean slate.
20170514 06:34:44< celticminstrel> I see.
20170514 06:34:52< vultraz_iOS> good.
20170514 06:35:05< shadowm> Also, translating a campaign from scratch is a big deal, in case you haven't realized that.
20170514 06:35:18< celticminstrel> ^
20170514 06:35:37< vultraz_iOS> which reminds me, I still need to write the 1.14 announcement...
20170514 06:35:38< shadowm> Speaking as a former translator who had to work almost 24/7 on a couple of campaigns for 1.8 (?).
20170514 06:35:55< celticminstrel> Already a 1.14 announcement?
20170514 06:36:04< vultraz_iOS> I need to begin work.
20170514 06:36:11< shadowm> Good luck with that. Good night.
20170514 06:36:16< celticminstrel> Bye shadowm 
20170514 06:36:18< vultraz_iOS> Stable announcements are always long.
20170514 06:36:21< vultraz_iOS> (bye shadowm)
20170514 06:36:53< celticminstrel> Try not to make the feature freeze policy too soft, vultraz_iOS.
20170514 06:37:00< celticminstrel> It exists for a reason after all.
20170514 06:37:16< celticminstrel> Definitely no more refactoring after RC1.
20170514 06:37:20< celticminstrel> Not even a little.
20170514 06:39:13< vultraz_iOS> I'm thinking... one more beta release?
20170514 06:39:27< vultraz_iOS> or do you think we should move right to RC.
20170514 06:39:34< vultraz_iOS> i think there's still a bunch of stuff to fix
20170514 06:39:56< celticminstrel> Well, there are a few significant feature PRs still open, so it seems reasonable to me to have another beta release.
20170514 06:40:07< vultraz_iOS> alright
20170514 06:40:15< vultraz_iOS> then let's do a freeze after that?
20170514 06:40:35< celticminstrel> That's probably fine?
20170514 06:41:11< celticminstrel> I guess it means that I'd have to get the addons manifest thing done before then if I want it to be in 1.14.
20170514 06:42:14< celticminstrel> Might not make it... particularly since I keep putting it off...
20170514 06:43:54-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170514 06:45:56-!- celticminstrel is now known as celmin|sleep
20170514 07:34:09< zookeeper> celmin|sleep, "though the behaviour is slightly surprising" <- well, that's how it should work so not very surprising i think
20170514 07:45:19< celmin|sleep> ???
20170514 07:48:48< zookeeper> well if the intent is to evaluate the variables when the dialog is shown, then what you described is the way it should work
20170514 07:49:35< celmin|sleep> Well...
20170514 07:49:56< celmin|sleep> It was surprising compared to the result with delayed_variable_substitution, I guess?
20170514 07:50:35< celmin|sleep> I set the variable first in the start event and then set the objectives. Then I set the variable again in the side turn event.
20170514 07:51:27< celmin|sleep> With delayed_variable_substitution=yes, the first value of the variable was shown when the objectives auto-showed, but the second value was used when I showed then with Ctrl+J.
20170514 07:51:45< celmin|sleep> But with delayed_variable_substitution=no and $|, the second value was used both times.
20170514 07:51:58< zookeeper> oh, i see
20170514 07:52:33< zookeeper> ok, yes, it is surprising :p
20170514 07:52:39< celmin|sleep> (When I moved the second setting later in a move event, of course I got the first value of the variable in the auto-show.)
20170514 07:53:24< zookeeper> do you know what causes the difference?
20170514 07:54:01< celmin|sleep> Well, with delayed_variable_substitution=no, the $|var substitutes to $var which is then dumped into the raw objectives string.
20170514 07:54:20< celmin|sleep> And variables are substituted into the raw objectives string whenever the objectives are shown.
20170514 07:54:43< celmin|sleep> With delayed_variable_substitution=yes, the substitution occurs when [show_objectives] is called.
20170514 07:55:12< celmin|sleep> This happens automatically when you press Ctrl+J, but I think it doesn't happen automatically when the objectives are auto-shown because they've changed.
20170514 07:56:46< zookeeper> right. not easy to fix?
20170514 07:57:29< zookeeper> i mean it's not a terribly inconsistency, but i can imagine it being difficult to figure out sometime later when someone inadvertently trips on it
20170514 07:57:34< zookeeper> s/terribly/terrible
20170514 07:57:58< celmin|sleep> Not sure if it's easy to fix.
20170514 07:58:28< celmin|sleep> Technically I think [show_objectives] actually works by marking the objectives as changed so that they auto-show.
20170514 07:58:38< celmin|sleep> Whether or not they've actually changed.
20170514 07:59:20< celmin|sleep> I didn't think it was a big issue though since I wouldn't expect people to be altering the variables that control objectives many times within a single turn...
20170514 08:02:30< zookeeper> well, yeah, it's unlikely to cause an actual problem
20170514 08:14:46< celmin|sleep> Oooh, I just realized, I think Lua dialogs aren't put on the window stack...
20170514 08:15:02< celmin|sleep> Unless vultraz_iOS added that to scoped_dialog?
20170514 08:26:01-!- mjs-de [~mjs-de@x5ce4c044.dyn.telefonica.de] has joined #wesnoth-dev
20170514 08:51:01-!- grzywacz [~karol@163.172.154.146] has joined #wesnoth-dev
20170514 09:04:16< irker377> wesnoth: ln-zookeeper wesnoth:master 9b9a720a32d8 / data/core/terrain-graphics.cfg: Fixed mountain blend-from-chasm layer problem; should fix issue #1574 https://github.com/wesnoth/wesnoth/commit/9b9a720a32d882fbc7e9dcc473a7db5a05b4529b
20170514 09:07:58-!- JyrkiVesterinen [~JyrkiVest@87-92-5-30.bb.dnainternet.fi] has joined #wesnoth-dev
20170514 09:08:27-!- grzywacz [~karol@163.172.154.146] has quit [Ping timeout: 240 seconds]
20170514 09:12:56< vultraz_iOS> celmin|sleep: i did not
20170514 10:17:49-!- JyrkiVesterinen [~JyrkiVest@87-92-5-30.bb.dnainternet.fi] has quit [Quit: .]
20170514 10:25:21-!- Kwandulin [~Kwandulin@p200300760F6D80F5ED512C1789685CDE.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170514 10:37:25-!- gfgtdf [~chatzilla@x4e32b5e7.dyn.telefonica.de] has joined #wesnoth-dev
20170514 10:41:58-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit []
20170514 10:42:24-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170514 10:47:36< irker377> wesnoth: gfgtdf wesnoth:master b572928e264f / src/teambuilder.cpp: fix [side]type="" https://github.com/wesnoth/wesnoth/commit/b572928e264f3ab026a84997183a254e3b98a48c
20170514 10:58:27< vultraz_iOS> gfgtdf: added details about the variable info pr
20170514 11:00:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170514 11:08:58-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170514 11:09:04-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170514 11:09:26< gfgtdf> ok
20170514 11:44:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170514 11:45:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170514 12:10:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170514 12:10:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170514 12:16:25-!- JyrkiVesterinen [~JyrkiVest@87-92-5-30.bb.dnainternet.fi] has joined #wesnoth-dev
20170514 12:25:32-!- gfgtdf [~chatzilla@x4e32b5e7.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 53.0.2/20170504105526]]
20170514 12:28:07< loonycyborg> vultraz_iOS: windows installer uploaded too
20170514 12:39:47-!- sevu [~Shiki@141.39.226.226] has joined #wesnoth-dev
20170514 12:44:03-!- Kwandulin [~Kwandulin@p200300760F6D8004C447787CB8A8520C.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170514 12:49:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170514 12:51:19-!- sevu [~Shiki@141.39.226.226] has quit [Remote host closed the connection]
20170514 12:57:02< celmin|sleep> Rhonda, any idea what this is about? https://github.com/wesnoth/wesnoth/issues/1700
20170514 12:58:00-!- sevu [~Shiki@141.39.226.226] has joined #wesnoth-dev
20170514 13:01:29< JyrkiVesterinen> I answered the bug report and pointed out that https://forums.wesnoth.org/ (with an S) works fine.
20170514 13:01:50< celmin|sleep> Oh. Why does forum.wesnoth.org exist, then?
20170514 13:03:32< JyrkiVesterinen> I don't know.
20170514 13:03:38-!- grzywacz [~karol@163.172.154.146] has joined #wesnoth-dev
20170514 13:06:30-!- celmin|sleep is now known as celticminstrel
20170514 13:07:52-!- sevu [~Shiki@141.39.226.226] has quit [Ping timeout: 260 seconds]
20170514 13:09:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170514 13:38:03-!- horrowind [~Thunderbi@x4db45e47.dyn.telefonica.de] has joined #wesnoth-dev
20170514 13:47:05-!- horrowind1 [~Thunderbi@x4db45e47.dyn.telefonica.de] has joined #wesnoth-dev
20170514 13:47:59-!- irker377 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170514 13:48:43-!- horrowind [~Thunderbi@x4db45e47.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170514 13:48:43-!- horrowind1 is now known as horrowind
20170514 13:56:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170514 13:56:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170514 13:59:21< celticminstrel> Is it just me or are unit weapons no longer listed in dialogs?
20170514 13:59:27< celticminstrel> Recruit, recall, create.
20170514 13:59:44-!- horrowind1 [~Thunderbi@77.180.94.71] has joined #wesnoth-dev
20170514 14:01:38-!- horrowind [~Thunderbi@x4db45e47.dyn.telefonica.de] has quit [Ping timeout: 255 seconds]
20170514 14:01:38-!- horrowind1 is now known as horrowind
20170514 14:07:20< zookeeper> celticminstrel, they're there for me
20170514 14:07:39< celticminstrel> Oh good.
20170514 14:08:12< celticminstrel> Must be my local changes then.
20170514 14:09:37< vultraz_iOS> can't test, my variable info stuff is broken
20170514 14:10:00< vultraz_iOS> probably this returning value of temporary thing
20170514 14:13:34-!- horrowind1 [~Thunderbi@x4db45e47.dyn.telefonica.de] has joined #wesnoth-dev
20170514 14:15:40-!- horrowind [~Thunderbi@77.180.94.71] has quit [Ping timeout: 240 seconds]
20170514 14:15:40-!- horrowind1 is now known as horrowind
20170514 14:17:23< pydsigner> celticminstrel: I think a lot of people expect forum. rather than forums.
20170514 14:21:29< JyrkiVesterinen> The bug reporter said that they found a link to f.w.o via Google.
20170514 14:36:29-!- mjs-de [~mjs-de@x5ce4c044.dyn.telefonica.de] has quit [Remote host closed the connection]
20170514 14:37:16-!- irker016 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170514 14:37:16< irker016> wesnoth: Celtic Minstrel wesnoth:master 72b98ad7e13c / / (3 files in 2 dirs): Unit Preview Pane: Remove a relic of an older implementation https://github.com/wesnoth/wesnoth/commit/72b98ad7e13cdd031d85d6e0b5e069f08dd9e47d
20170514 14:37:16< irker016> wesnoth: Celtic Minstrel wesnoth:master 3a183cca3ae3 / src/gui/widgets/unit_preview_pane.cpp: Unit Preview Pane: Fix a non-translatable string https://github.com/wesnoth/wesnoth/commit/3a183cca3ae36555ae2e3914b8707c82be1fc526
20170514 14:37:17< irker016> wesnoth: Celtic Minstrel wesnoth:master f24a0307b950 / src/gui/widgets/unit_preview_pane.cpp: Unit Preview Pane: Make minimal definitions work for unit types https://github.com/wesnoth/wesnoth/commit/f24a0307b950fbb5d3ddfe314b54b71232387572
20170514 14:43:08-!- horrowind1 [~Thunderbi@x4db45e47.dyn.telefonica.de] has joined #wesnoth-dev
20170514 14:45:18-!- horrowind [~Thunderbi@x4db45e47.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170514 14:45:18-!- horrowind1 is now known as horrowind
20170514 14:48:27< celticminstrel> Does anyone know a way to get the currently-active widget?
20170514 14:50:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170514 14:51:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170514 14:54:20< vultraz_iOS> what do you mean
20170514 14:54:42< celticminstrel> What was the way to activate a textbox again.
20170514 14:55:08< vultraz_iOS> keyboard capture?
20170514 14:55:29< celticminstrel> Is that the normal way or the way that also lets you use the arrow keys to navigate a list at the same time?
20170514 14:55:48< vultraz_iOS> i think you want add to keyboard chain then
20170514 14:56:04< celticminstrel> Um, I didn't say which of the two I want.
20170514 14:56:37< celticminstrel> What I actually want is to figure out which widget currently has the keyboard captured.
20170514 14:56:43< vultraz_iOS> uhhh
20170514 14:56:47< vultraz_iOS> look in the dispatcher or something
20170514 14:56:50< vultraz_iOS> i dunno
20170514 14:57:05< vultraz_iOS> there might be a method
20170514 14:57:44< vultraz_iOS> btw what were those commits for?
20170514 14:58:01< celticminstrel> I guess just cleanup?
20170514 14:58:14< celticminstrel> I started trying to make faction select show unit details, but that didn't work out.
20170514 14:58:26< celticminstrel> So I just pushed the other stuff.
20170514 15:05:12-!- horrowind1 [~Thunderbi@x4db45e47.dyn.telefonica.de] has joined #wesnoth-dev
20170514 15:07:25-!- horrowind [~Thunderbi@x4db45e47.dyn.telefonica.de] has quit [Ping timeout: 255 seconds]
20170514 15:07:26-!- horrowind1 is now known as horrowind
20170514 15:11:24< shadowm> vultraz, celticminstrel: We have a wesnoth/website repo. Perhaps consider directing people there for posting website-related "bugs"?
20170514 15:11:32< shadowm> (tbh I'm not a fan of either approach.)
20170514 15:12:19< shadowm> (Primary issue is that, for example, I cannot assign Rhonda to this "bug" because she's not part of the dev team and might not even have a GitHub account for all I know.)
20170514 15:18:38< shadowm> (To clarify, I mean the dev team in there. She's considered a developer otherwise.)
20170514 15:20:55-!- horrowind1 [~Thunderbi@x4db45e47.dyn.telefonica.de] has joined #wesnoth-dev
20170514 15:22:22-!- horrowind [~Thunderbi@x4db45e47.dyn.telefonica.de] has quit [Ping timeout: 246 seconds]
20170514 15:22:22-!- horrowind1 is now known as horrowind
20170514 15:24:35-!- mjs-de [~mjs-de@x5ce4c044.dyn.telefonica.de] has joined #wesnoth-dev
20170514 15:33:07< pydsigner> I'd agree that issues should be on the respective repo
20170514 15:36:29-!- horrowind1 [~Thunderbi@x4db45e47.dyn.telefonica.de] has joined #wesnoth-dev
20170514 15:38:08-!- horrowind [~Thunderbi@x4db45e47.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170514 15:38:08-!- horrowind1 is now known as horrowind
20170514 15:38:43< zookeeper> unless that means they'd tend to get missed or forgotten because mostly people work with the wesnoth/wesnoth repo. maybe everyone who currently might want to deal with website issues is already subscribed to wesnoth/website, but it's naturally quite a bit more occluded from potential new people than wesnoth/wesnoth.
20170514 15:43:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170514 15:44:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170514 15:45:12< shadowm> I really don't understand your argument, zookeeper. People can be told to subscribe to either repo as needed.
20170514 15:47:07< zookeeper> not an argument, just a consideration. new people looking for stuff to do will probably miss the website repo, and most of the time no one will even remember to mention it as a secondary wesnoth-related repo.
20170514 15:47:44< zookeeper> if for some mysterious reason i'd have to choose, i'd probably still agree that website issues should be on the website repo, regardless.
20170514 15:49:17< shadowm> How can new people looking for stuff to do help with website issues if they don't have access to the server?
20170514 15:49:57< shadowm> (Which is something incredibly unlikely to change as long as we value our users' privacy and safety.)
20170514 15:56:07-!- horrowind1 [~Thunderbi@x4db45e47.dyn.telefonica.de] has joined #wesnoth-dev
20170514 15:57:55< vultraz_iOS> celticminstrel: PR #1697 is ready for you to look at.
20170514 15:58:02< vultraz_iOS> might add one or two more things but the substance is there.
20170514 15:58:11-!- horrowind [~Thunderbi@x4db45e47.dyn.telefonica.de] has quit [Ping timeout: 255 seconds]
20170514 15:58:11-!- horrowind1 is now known as horrowind
20170514 15:58:50-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dd9a:4a64:e1f:c3a4] has joined #wesnoth-dev
20170514 16:09:56-!- Kwandulin [~Kwandulin@p200300760F6D8004C447787CB8A8520C.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170514 16:15:36-!- horrowind1 [~Thunderbi@x4db45e47.dyn.telefonica.de] has joined #wesnoth-dev
20170514 16:17:05-!- horrowind [~Thunderbi@x4db45e47.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170514 16:17:05-!- horrowind1 is now known as horrowind
20170514 16:17:41< celticminstrel> Anyone feel like implementing the sound source tool in the editor?
20170514 16:22:23< vultraz_iOS> nope
20170514 16:24:07< celticminstrel> Should probably be done before 1.14. Kinda looks bad to have it labelled "Not Implemented Yet".
20170514 16:25:30< shadowm> There's a second option. It's called removing any evidence that the tool was intended to exist.
20170514 16:25:55< celticminstrel> True.
20170514 16:26:28< celticminstrel> I opened an issue for it, but the second option is still valid.
20170514 16:26:30< shadowm> Somebody claimed that this wasn't possible when I last brought it up because of the way the UI theme works but I'm sure it doesn't take much to replace the button with a blank-looking thing.
20170514 16:27:02< celticminstrel> I would think it'd be possible also to replace it with a different button. Perhaps one of the ones along the top could be moved to the side.
20170514 16:29:46-!- horrowind1 [~Thunderbi@x4db45e47.dyn.telefonica.de] has joined #wesnoth-dev
20170514 16:31:58-!- horrowind [~Thunderbi@x4db45e47.dyn.telefonica.de] has quit [Ping timeout: 268 seconds]
20170514 16:31:58-!- horrowind1 is now known as horrowind
20170514 16:37:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170514 16:37:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170514 16:38:15< celticminstrel> Ugh, whyyyy does the window double-register its keydown handler...
20170514 16:38:36< celticminstrel> I'm pretty sure that's the only reason my tab-between-fields implementation is not working.
20170514 16:38:50< celticminstrel> (Because there's only two fields in my test dialog and one tab press counts as two.)
20170514 16:40:12< JyrkiVesterinen> I finally got around to rebuilding Boost. :)
20170514 16:40:14< JyrkiVesterinen> https://github.com/aquileia/external/pull/12
20170514 16:40:16< JyrkiVesterinen> https://github.com/aquileia/external/pull/13
20170514 16:40:18< JyrkiVesterinen> https://github.com/aquileia/external/pull/14
20170514 16:40:43< JyrkiVesterinen> Man, Boost update commits can get absolutely massive...
20170514 16:40:45< JyrkiVesterinen> "Showing 5,856 changed files with 1,144,655 additions and 1,125,973 deletions."
20170514 16:43:25< celticminstrel> And setting halt doesn't help.
20170514 16:43:29-!- horrowind1 [~Thunderbi@x4db45e47.dyn.telefonica.de] has joined #wesnoth-dev
20170514 16:45:23< vultraz_iOS> i thinkyou might have run into a bug?
20170514 16:45:43< vultraz_iOS> IIRC you can't halt execution of a queue or something
20170514 16:46:15-!- horrowind [~Thunderbi@x4db45e47.dyn.telefonica.de] has quit [Ping timeout: 272 seconds]
20170514 16:46:15-!- horrowind1 is now known as horrowind
20170514 16:53:59-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dd9a:4a64:e1f:c3a4] has quit [Remote host closed the connection]
20170514 17:01:18-!- Kwandulin [~Kwandulin@p200300760F6D8004C447787CB8A8520C.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170514 17:06:48-!- horrowind1 [~Thunderbi@x4db45e47.dyn.telefonica.de] has joined #wesnoth-dev
20170514 17:09:05-!- horrowind [~Thunderbi@x4db45e47.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170514 17:09:05-!- horrowind1 is now known as horrowind
20170514 17:11:31< celticminstrel> I think the problem is that it's registered in two different queues?
20170514 17:17:52< Rhonda> shadowm: I do have an account on github. It's called rhonda. :)
20170514 17:19:20< shadowm> Rhonda: Do you want vultraz_iOS to add you to the dev team so we can assign issues to you, etc.?
20170514 17:21:57-!- horrowind1 [~Thunderbi@77.180.94.71] has joined #wesnoth-dev
20170514 17:23:46-!- horrowind [~Thunderbi@x4db45e47.dyn.telefonica.de] has quit [Ping timeout: 268 seconds]
20170514 17:23:46-!- horrowind1 is now known as horrowind
20170514 17:29:35< Rhonda> shadowm: If it's not too many issues, why not. :)
20170514 17:38:23-!- irker016 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170514 17:38:27 * celticminstrel pokes vultraz_iOS 
20170514 17:38:33-!- horrowind1 [~Thunderbi@x4db45e47.dyn.telefonica.de] has joined #wesnoth-dev
20170514 17:39:56< vultraz_iOS> I'm asleep
20170514 17:40:20< celticminstrel> :(
20170514 17:40:40-!- horrowind [~Thunderbi@77.180.94.71] has quit [Ping timeout: 240 seconds]
20170514 17:40:40-!- horrowind1 is now known as horrowind
20170514 17:45:11< celticminstrel> I wonder if it'll work to just not register it twice.
20170514 17:50:12< celticminstrel> Tabbing works if I don't register the keydown handler twice, but not sure if that breaks other things.
20170514 17:50:12-!- horrowind1 [~Thunderbi@x4db45e47.dyn.telefonica.de] has joined #wesnoth-dev
20170514 17:51:35-!- horrowind [~Thunderbi@x4db45e47.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170514 17:51:36-!- horrowind1 is now known as horrowind
20170514 17:52:39< celticminstrel> https://github.com/wesnoth/wesnoth/commit/b86142a4ce14203f67c76d766c1170b9c286a9a7
20170514 17:52:47< celticminstrel> So basically...
20170514 17:53:11< celticminstrel> It seems like maybe it's needed when the window contains only a label but wants to close with spacebar or something?
20170514 17:53:18< shadowm> Rhonda: Added you. I believe you should've been sent via email an invite which you must accept first.
20170514 17:53:38< celticminstrel> In fact, [message] should count among these...
20170514 17:53:51< celticminstrel> So I should be able to test easily.
20170514 17:53:57< shadowm> Oh wait, I hadn't actually added you, now you should have the invite.
20170514 17:54:00< celticminstrel> Also [objectives] for that matter.
20170514 17:54:09< shadowm> Stupid millenial web UIs.
20170514 17:58:15-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170514 17:59:38< celticminstrel> So if I don't register it twice, objectives can't be closed with the keyboard. That's not good.
20170514 18:00:34< Rhonda> Subject: [GitHub] Ignacio R. Morelle has invited you to join the Battle for
20170514 18:01:18< celticminstrel> The above commit suggests a fix, but how to do it is not obvious...
20170514 18:03:37-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170514 18:04:21-!- TC03 [~quassel@london.acm.jhu.edu] has joined #wesnoth-dev
20170514 18:08:34-!- yaiyan [~yaiyan@46.101.48.31] has joined #wesnoth-dev
20170514 18:09:27-!- Netsplit *.net <-> *.split quits: Ieuan, stikonas, new_one, TC02
20170514 18:16:14-!- horrowind1 [~Thunderbi@x4db45e47.dyn.telefonica.de] has joined #wesnoth-dev
20170514 18:16:28-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170514 18:16:59-!- Netsplit over, joins: new_one
20170514 18:18:27-!- horrowind [~Thunderbi@x4db45e47.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170514 18:18:27-!- horrowind1 is now known as horrowind
20170514 18:23:41-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170514 18:24:05< celticminstrel> Okay, tabbing between fields works now. The only problem is that each dialog with fields needs to manually set up the list of fields to tab through.
20170514 18:24:14-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dd9a:4a64:e1f:c3a4] has joined #wesnoth-dev
20170514 18:28:29-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dd9a:4a64:e1f:c3a4] has quit [Ping timeout: 255 seconds]
20170514 18:30:21-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170514 18:30:21< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release Celtic Minstrel f24a030: Unit Preview Pane: Make minimal definitions work for unit types Failed
20170514 18:30:21< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-336
20170514 18:30:25-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170514 18:32:53-!- Kwandulin [~Kwandulin@p200300760F6D8004C447787CB8A8520C.dip0.t-ipconnect.de] has quit [Quit: [endlevel] result=novictorynodefeatjustquit [/endlevel]]
20170514 18:33:46-!- Kwandulin [~Kwandulin@p200300760F6D8004C447787CB8A8520C.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170514 18:34:12-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170514 18:34:12< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug Celtic Minstrel f24a030: Unit Preview Pane: Make minimal definitions work for unit types Failed
20170514 18:34:12< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-336
20170514 18:34:16-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170514 18:36:32-!- horrowind1 [~Thunderbi@x4db45e47.dyn.telefonica.de] has joined #wesnoth-dev
20170514 18:38:28-!- horrowind [~Thunderbi@x4db45e47.dyn.telefonica.de] has quit [Ping timeout: 255 seconds]
20170514 18:38:29-!- horrowind1 is now known as horrowind
20170514 18:53:23-!- Kwandulin2 [~Kwandulin@p200300760F6D8004C447787CB8A8520C.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170514 18:55:55-!- Kwandulin [~Kwandulin@p200300760F6D8004C447787CB8A8520C.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20170514 18:58:12-!- horrowind1 [~Thunderbi@x4db45e47.dyn.telefonica.de] has joined #wesnoth-dev
20170514 18:59:43-!- horrowind [~Thunderbi@x4db45e47.dyn.telefonica.de] has quit [Ping timeout: 246 seconds]
20170514 18:59:43-!- horrowind1 is now known as horrowind
20170514 19:07:23-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dd9a:4a64:e1f:c3a4] has joined #wesnoth-dev
20170514 19:10:31-!- stikonas_ is now known as stikonas
20170514 19:11:12-!- horrowind1 [~Thunderbi@x4db45e47.dyn.telefonica.de] has joined #wesnoth-dev
20170514 19:13:27-!- horrowind [~Thunderbi@x4db45e47.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170514 19:13:28-!- horrowind1 is now known as horrowind
20170514 19:16:56-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dd9a:4a64:e1f:c3a4] has quit [Remote host closed the connection]
20170514 19:17:28-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dd9a:4a64:e1f:c3a4] has joined #wesnoth-dev
20170514 19:21:46-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dd9a:4a64:e1f:c3a4] has quit [Ping timeout: 246 seconds]
20170514 19:24:02-!- horrowind1 [~Thunderbi@x4db45e47.dyn.telefonica.de] has joined #wesnoth-dev
20170514 19:25:52-!- horrowind [~Thunderbi@x4db45e47.dyn.telefonica.de] has quit [Ping timeout: 268 seconds]
20170514 19:25:52-!- horrowind1 is now known as horrowind
20170514 19:26:55-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dd9a:4a64:e1f:c3a4] has joined #wesnoth-dev
20170514 19:27:42< celticminstrel> Uhhh... why is the schedule editor available even when you're editing a normal map?
20170514 19:28:14< zookeeper> lets you see how the map looks under different ToD lighting?
20170514 19:29:14-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dd9a:4a64:e1f:c3a4] has quit [Remote host closed the connection]
20170514 19:32:21-!- JyrkiVesterinen [~JyrkiVest@87-92-5-30.bb.dnainternet.fi] has quit [Quit: .]
20170514 19:34:41-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dd9a:4a64:e1f:c3a4] has joined #wesnoth-dev
20170514 19:37:10< shadowm> Rhonda: You need to accept the invite btw.
20170514 19:38:02-!- horrowind1 [~Thunderbi@x4db45e47.dyn.telefonica.de] has joined #wesnoth-dev
20170514 19:40:40-!- horrowind [~Thunderbi@x4db45e47.dyn.telefonica.de] has quit [Ping timeout: 268 seconds]
20170514 19:40:40-!- horrowind1 is now known as horrowind
20170514 19:44:19-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Read error: Connection reset by peer]
20170514 19:45:09-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170514 19:50:44-!- Kwandulin2 [~Kwandulin@p200300760F6D8004C447787CB8A8520C.dip0.t-ipconnect.de] has quit [Quit: [endlevel] result=novictorynodefeatjustquit [/endlevel]]
20170514 19:53:10-!- horrowind1 [~Thunderbi@x4db45e47.dyn.telefonica.de] has joined #wesnoth-dev
20170514 19:54:57-!- horrowind [~Thunderbi@x4db45e47.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170514 19:54:57-!- horrowind1 is now known as horrowind
20170514 20:08:34-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dd9a:4a64:e1f:c3a4] has quit [Remote host closed the connection]
20170514 20:09:22-!- irker613 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170514 20:09:22< irker613> wesnoth: Celtic Minstrel wesnoth:master 38774f4dd423 / / (13 files in 6 dirs): Implement tabbing between fields in GUI2 dialogs https://github.com/wesnoth/wesnoth/commit/38774f4dd423bff7b89356370b17114fd5edebd9
20170514 20:09:22< irker613> wesnoth: Celtic Minstrel wesnoth:master d53125e09d2b / src/gui/dialogs/editor/ (edit_scenario.cpp edit_side.cpp): Fix last field (instead of first) being initially selected in some dialogs https://github.com/wesnoth/wesnoth/commit/d53125e09d2b1c8a7a3fe30b164defdb9a966a75
20170514 20:15:35-!- prkc [~prkc@catv-80-98-135-58.catv.broadband.hu] has quit [Ping timeout: 255 seconds]
20170514 20:20:17-!- horrowind1 [~Thunderbi@x4db45e47.dyn.telefonica.de] has joined #wesnoth-dev
20170514 20:21:43-!- horrowind [~Thunderbi@x4db45e47.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170514 20:21:43-!- horrowind1 is now known as horrowind
20170514 20:28:38-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev
20170514 20:41:08-!- mjs-de [~mjs-de@x5ce4c044.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170514 21:07:09< Rhonda> shadowm: have done that now
20170514 21:14:32-!- horrowind1 [~Thunderbi@x4db45e47.dyn.telefonica.de] has joined #wesnoth-dev
20170514 21:15:48-!- horrowind1 [~Thunderbi@x4db45e47.dyn.telefonica.de] has quit [Client Quit]
20170514 21:15:57-!- horrowind [~Thunderbi@x4db45e47.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170514 21:39:33-!- Ivanovic_ [~ivanovic@p4FC534A6.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170514 21:41:29-!- higgins [~higgins@68.ip-149-56-14.net] has joined #wesnoth-dev
20170514 21:42:05-!- atarocch [~atarocch@93.56.160.28] has quit [Remote host closed the connection]
20170514 21:42:31-!- nurupo_ [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20170514 21:42:54-!- esr1 [~esr@71.162.243.5] has joined #wesnoth-dev
20170514 21:42:56-!- irker613 [~irker@uruz.ai0867.net] has quit [Ping timeout: 268 seconds]
20170514 21:42:57-!- higgins` [~higgins@68.ip-149-56-14.net] has quit [Ping timeout: 268 seconds]
20170514 21:43:05-!- Ivanovic [~ivanovic@p4FC534A6.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170514 21:43:08-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Ping timeout: 268 seconds]
20170514 21:43:18-!- esr [~esr@wesnoth/developer/esr] has quit [Ping timeout: 268 seconds]
20170514 21:43:23-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dd9a:4a64:e1f:c3a4] has joined #wesnoth-dev
20170514 21:43:26-!- nurupo_ is now known as nurupo
20170514 21:43:30-!- Ivanovic_ is now known as Ivanovic
20170514 21:48:18< vultraz_iOS> wow
20170514 21:48:30< vultraz_iOS> w/ virtual specifiers: 25.91 mb
20170514 21:48:33< vultraz_iOS> w/o: 25.79 MB
20170514 21:48:50< celticminstrel> ?
20170514 21:49:14< vultraz_iOS> celticminstrel: i removed the virtual specifiers from my pr
20170514 21:52:50< celticminstrel> Okay, so where exactly were these virtual specifiers?
20170514 21:53:05< vultraz_iOS> any inheriting from info_visitor_base
20170514 21:53:18< vultraz_iOS> anything
20170514 21:53:23< celticminstrel> Which file was that again?
20170514 21:53:38< vultraz_iOS> private
20170514 21:53:57< celticminstrel> Okay, so...
20170514 21:54:07< celticminstrel> DEFAULTHANDLER declares them virtual already.
20170514 21:54:12< celticminstrel> Or are you saying you removed that too?
20170514 21:54:23< vultraz_iOS> i added that
20170514 21:54:26< vultraz_iOS> and now removedit locally
20170514 21:54:30< celticminstrel> Okay.
20170514 21:55:21< vultraz_iOS> (random: cannot wait until we support c++14 and I can use all the type trait template aliases)
20170514 21:55:53< celticminstrel> I don't think that's really something worth waiting for?
20170514 21:56:12< celticminstrel> So where are all these subclasses used?
20170514 21:56:44< vultraz_iOS> with apply_visitor in the main cp
20170514 21:58:31< celticminstrel> Okay yeah, it doesn't rely on polymorphic behaviour.
20170514 21:58:47< celticminstrel> It always has an instance of the subclass, never a pointer to the superclass that actually points to a subclass.
20170514 21:58:58< celticminstrel> So you don't actually need virtual.
20170514 21:59:24< celticminstrel> The base class serves only to provide a default implementation of each function.
20170514 21:59:24< vultraz_iOS> I see
20170514 22:00:37< vultraz_iOS> does 'using namespace' matter if its public or private
20170514 22:01:06< celticminstrel> I don't see why it would matter.
20170514 22:03:57-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170514 22:05:27< vultraz_iOS> "using namespase X; is called a using directive and it can appear only in namespace and function scope, but not class scope."
20170514 22:05:29< vultraz_iOS> :(
20170514 22:06:01< vultraz_iOS> ok ya know what
20170514 22:06:18< vultraz_iOS> I'll just wrap the entire thing in another namespace and declare variable_info_implementation an inline namespace
20170514 22:06:37-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has quit [Ping timeout: 246 seconds]
20170514 22:07:10-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20170514 22:07:12-!- SeamusFD [~SeamusFD@75-120-56-85.dyn.centurytel.net] has joined #wesnoth-dev
20170514 22:08:38-!- SeamusFD [~SeamusFD@75-120-56-85.dyn.centurytel.net] has quit [Client Quit]
20170514 22:09:53< vultraz_iOS> celticminstrel: what would you name the master namespace?
20170514 22:10:23< celticminstrel> No inline namespaces. MSVC 2013 doesn't support them.
20170514 22:12:05< vultraz_iOS> OH COME ON
20170514 22:12:21< vultraz_iOS> ARE YOU FUCKING KDDING ME
20170514 22:12:26< vultraz_iOS> ;_;
20170514 22:12:33< celticminstrel> I googled it to make sure before saying anything.
20170514 22:12:39< celticminstrel> (I actually didn't realize they were C++11.)
20170514 22:14:52< vultraz_iOS> Ugggh.
20170514 22:15:38< celticminstrel> Hmm, I suppose you could put variable_info itself into the implementation namespace.
20170514 22:15:55< celticminstrel> Then import it into the regular namespace with "usign variable_info;"
20170514 22:16:32< vultraz_iOS> Or maybe I could declare the alias in the detail file
20170514 22:17:05< celticminstrel> That still won't localize it.
20170514 22:17:16< celticminstrel> Since the detail file is included by the main file.
20170514 22:39:28-!- gfgtdf [~chatzilla@x4e32b5e7.dyn.telefonica.de] has joined #wesnoth-dev
20170514 22:40:06< gfgtdf> celticminstrel: my config refaceor pr is passes traivs and will  be merged once after i rename the last commit. Any opinions on it?
20170514 22:42:48< celticminstrel> I don't have any particular comments on it.
20170514 22:50:49-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dd9a:4a64:e1f:c3a4] has quit [Remote host closed the connection]
20170514 22:51:51-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dd9a:4a64:e1f:c3a4] has joined #wesnoth-dev
20170514 23:01:03< vultraz_iOS> i don't really want to put variable_info inside the impl namespace
20170514 23:01:04< vultraz_iOS> :/
20170514 23:01:38< gfgtdf>  vultraz_iOS why woudl you do that ?
20170514 23:01:54< vultraz_iOS> trying to localzlize the namespace typedef
20170514 23:02:11< celticminstrel> He seems to be trying to find a way to not have to use the full variable_info_implementation namespace name when using the things in that namespace.
20170514 23:02:37< celticminstrel> I pointed out that that would be one way to do so, coupled with adding a using statement to import only variable_info into the main namespace.
20170514 23:02:42< vultraz_iOS> ah fuck it, I'll just specify it in the header and use 'using namespace' in the cpp
20170514 23:05:57< vultraz_iOS> gfgtdf: btw the reason i moved the exception to the detail header was i need to throw it from there :|
20170514 23:08:55< vultraz_iOS> and ill move maybe_const out of the details namespace
20170514 23:09:27< celticminstrel> ???
20170514 23:10:31< vultraz_iOS> or, no
20170514 23:36:58-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dd9a:4a64:e1f:c3a4] has quit [Remote host closed the connection]
20170514 23:43:45< vultraz_iOS> heh
20170514 23:43:54< vultraz_iOS> i appear to have found a way to crash my compiler o_o
20170514 23:44:55< vultraz_iOS> was testing if using worked on types without an alias - ie, import - (using typename as_scalar_visitor::result_t;) and the compiler crashes :P bad tdmgcc.
20170514 23:45:05-!- grzywacz [~karol@163.172.154.146] has quit [Remote host closed the connection]
20170514 23:45:30< celticminstrel> "using as_scalar_visitor::result_t" should work.
20170514 23:45:49< celticminstrel> Not quite sure if it works when as_scalar_visitor is a class or struct; definitely works if it's a namespace.
20170514 23:46:06< celticminstrel> You don't need the "typename".
20170514 23:50:45-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170514 23:56:21-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170514 23:59:45-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
--- Log closed Mon May 15 00:00:35 2017