--- Log opened Mon May 15 00:00:35 2017
20170515 00:14:36-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170515 00:23:15-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Ping timeout: 245 seconds]
20170515 00:23:56-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170515 00:24:27-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dd9a:4a64:e1f:c3a4] has joined #wesnoth-dev
20170515 00:28:06-!- irker525 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170515 00:28:06< irker525> wesnoth: gfgtdf wesnoth:master e7d2108ba68f / src/config.cpp: deploy a range for https://github.com/wesnoth/wesnoth/commit/e7d2108ba68fc5d79037cd869eff2ea243a65f08
20170515 00:28:08< irker525> wesnoth: gfgtdf wesnoth:master b6e398fdb1a7 / src/ (config.cpp config.hpp): fix configs member variables not following our naming convention https://github.com/wesnoth/wesnoth/commit/b6e398fdb1a7fde15e6c6941c0d21a9eb5bd2ed9
20170515 00:28:10< irker525> wesnoth: gfgtdf wesnoth:master d06e9c30b2ea / src/ (config.cpp config.hpp): use unique_ptr in config::child_map https://github.com/wesnoth/wesnoth/commit/d06e9c30b2eacfaa23f39aa43496f52582f03c15
20170515 00:28:12< irker525> wesnoth: gfgtdf wesnoth:master 13b00f73ffb8 / / (5 files in 2 dirs): move config::attribte_value out of config.?pp https://github.com/wesnoth/wesnoth/commit/13b00f73ffb8b86b4ab00b29ee7d05c56e5fbf04
20170515 00:28:14< irker525> wesnoth: gfgtdf wesnoth:master 514ec83ada45 / src/config.cpp: remvoe now unused config_clear_state https://github.com/wesnoth/wesnoth/commit/514ec83ada4547e958fb488233dc89c09f8a0bd3
20170515 00:28:16< irker525> wesnoth: gfgtdf wesnoth:master 4f888e20730f / / (5 files in 2 dirs): Merge pull request #1010 from gfgtdf/config_refactor https://github.com/wesnoth/wesnoth/commit/4f888e20730f80ce47d1b21385ee304cfc826f7e
20170515 00:30:15< celticminstrel> gfgtdf: Any opinion on where config_variable_set should be declared?
20170515 00:30:39< celticminstrel> With variable_info, or with vconfig, or with config
20170515 00:31:33< gfgtdf> celticminstrel: well it currently seems ot be  helper struct for saved_game::load_mod? so i'D just keepo it there
20170515 00:31:59< celticminstrel> But I want to use it in lua_kernel_base too.
20170515 00:32:24< celticminstrel> Did you think I'd ask if I didn't have an actual reason for moving it to a header? >_>
20170515 00:32:34< gfgtdf> celticminstrel: hmm to implemente lua_vgetterxt  ?
20170515 00:32:39< celticminstrel> Basically.
20170515 00:34:06< gfgtdf> celticminstrel: i'd parobably define it on variable_info, but you coudl also add a new file, i mena it'll probably only need the header file right?
20170515 00:34:28< celticminstrel> A whole new header for that tiny class? >_>
20170515 00:35:18< gfgtdf> celticminstrel: i don't see why not. for seaching it's sureley easier if the config_variable_set class is defeind in config_variable_set .hpp
20170515 00:35:56< celticminstrel> So you don't think it should be in config.hpp then?
20170515 00:36:03< celticminstrel> That's where the base class is declared.
20170515 00:57:54-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dd9a:4a64:e1f:c3a4] has quit [Remote host closed the connection]
20170515 01:07:00< gfgtdf> celticminstrel: i't make config.hpp somehow  dependent on variable_info since config_variable_set  uses that class.
20170515 01:07:15< celticminstrel> Ah, right.
20170515 01:13:28-!- gfgtdf [~chatzilla@x4e32b5e7.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 53.0.2/20170504105526]]
20170515 02:18:39-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dd9a:4a64:e1f:c3a4] has joined #wesnoth-dev
20170515 02:23:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170515 02:25:19-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dd9a:4a64:e1f:c3a4] has quit [Remote host closed the connection]
20170515 02:27:34-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dd9a:4a64:e1f:c3a4] has joined #wesnoth-dev
20170515 02:35:56-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170515 02:38:23-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Read error: Connection reset by peer]
20170515 02:39:00-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170515 02:43:45-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170515 03:04:35-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dd9a:4a64:e1f:c3a4] has quit [Remote host closed the connection]
20170515 03:29:09-!- irker525 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170515 03:30:38-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Read error: Connection reset by peer]
20170515 03:43:08-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dd9a:4a64:e1f:c3a4] has joined #wesnoth-dev
20170515 04:05:03-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170515 04:11:44-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dd9a:4a64:e1f:c3a4] has quit [Remote host closed the connection]
20170515 04:17:14< vultraz_iOS> celticminstrel: https://github.com/wesnoth/wesnoth/pull/1697/commits/2b42fc1c91f624d1fa6e0f8d8f0a20f69a353fb3
20170515 04:17:23< vultraz_iOS> addressed feedback
20170515 04:17:45< celticminstrel> You're lucky I'm still awake.
20170515 04:18:43< celticminstrel> "instantiated", not "specialized".
20170515 04:18:51< vultraz_iOS> I see
20170515 04:19:07< celticminstrel> "specialized" is when you provide a completely separate implementation for a given set of template arguments.
20170515 04:19:12< vultraz_iOS> ahh
20170515 04:19:17< vultraz_iOS> ok, will fix
20170515 04:20:05< celticminstrel> Lines 125 and 128 - looks like you wrote "of" instead of "if"?
20170515 04:20:24< vultraz_iOS> indeed
20170515 04:20:25< celticminstrel> Is it nonexistent or nonexistant? Isn't it the former?
20170515 04:21:01< vultraz_iOS> yup
20170515 04:21:18< celticminstrel> The comment on 134-5 isn't really accurate AFACTI,pretty sure you could use const_clone without that const.
20170515 04:21:56< celticminstrel> Because either way you're specializing maybe_const on vi_policy_const or something, right?
20170515 04:22:41< celticminstrel> private line 93 has trailing whitespace.
20170515 04:22:54< celticminstrel> Oh, I see.
20170515 04:22:58< celticminstrel> It's a macro definition.
20170515 04:23:09< celticminstrel> Okay, never mind then.
20170515 04:24:17< celticminstrel> I don't think you need the typename keyword in all those visitor functions, either... though I could be mistaken...
20170515 04:24:43< celticminstrel> Actually, does it need to be qualified at all? Isn't param_t visible from the superclass?
20170515 04:25:06< vultraz_iOS> IIRC it isn't
20170515 04:25:09< vultraz_iOS> but i can try
20170515 04:25:29< celticminstrel> Generally you only need typename when you have something of the form X<Y>::Z
20170515 04:25:40-!- JyrkiVesterinen [~jyrki@87-100-249-164.bb.dnainternet.fi] has joined #wesnoth-dev
20170515 04:26:15< celticminstrel> Since those are not of the form X<Y>::Z, I don't think typename is needed.
20170515 04:26:30< vultraz_iOS> gimme a sec
20170515 04:29:19< vultraz_iOS> nope
20170515 04:29:24< vultraz_iOS> it says it's not a type for some reason
20170515 04:29:34< celticminstrel> Okay...
20170515 04:29:35< vultraz_iOS> I dunno why
20170515 04:29:48< celticminstrel> Let me look again quickly...
20170515 04:30:29< celticminstrel> So param_t is defined in info_visitor_base.
20170515 04:30:51< vultraz_iOS> yes
20170515 04:31:00< celticminstrel> get_variable_key_visitor is then derived from info_visitor_base.
20170515 04:31:08< vultraz_iOS> depending on the macro argument
20170515 04:31:27< celticminstrel> Huh?
20170515 04:31:31< celticminstrel> What macro?
20170515 04:31:39< vultraz_iOS> template
20170515 04:31:39< vultraz_iOS> sorry
20170515 04:32:07< celticminstrel> Right, it's derived from info_visitor_base<void, variable_info_state<V>>
20170515 04:32:34< celticminstrel> ...
20170515 04:32:43-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Ping timeout: 258 seconds]
20170515 04:33:03< celticminstrel> Is the problem that it's also a template, so it can't know for sure that param_t exists in all possible instantiations of info_visitor_base?
20170515 04:33:22< vultraz_iOS> uhhh
20170515 04:33:26< vultraz_iOS> I don't know?
20170515 04:33:34< celticminstrel> I think that might be it.
20170515 04:33:49< vultraz_iOS> not really much you can do about that
20170515 04:33:55< celticminstrel> If get_variable_key_visitor were not a template, it should be fine to just write "void from_named(param_t state)"
20170515 04:34:18< celticminstrel> In any case, I think it might look a little cleaner if you import param_t once and then just write the above.
20170515 04:34:37< celticminstrel> ie, "using param_t = typename get_variable_key_visitor<V, void>::param_t" or whatever.
20170515 04:35:00< celticminstrel> But up to you, I guess.
20170515 04:35:41< celticminstrel> (Once per visitor, that is.)
20170515 04:36:07< vultraz_iOS> funny thing about the visitors
20170515 04:36:17< vultraz_iOS> most of the time the templates don't actually do anything
20170515 04:36:25< celticminstrel> I think perhaps lines 203-7 of private could be replaced with a single using declaration.
20170515 04:36:42< celticminstrel> "using info_visitor_const::from_temporary"
20170515 04:36:55< celticminstrel> Not sure if you'd need to also include the template arguments.
20170515 04:37:18< celticminstrel> But again this doesn't really matter (assuming that even works), so if you can't be bothered, then it's not a problem.
20170515 04:40:15< vultraz_iOS> it doesnt
20170515 04:41:29< celticminstrel> Well. I suppose if gfgtdf had no further objections, then I see no further objections other than the little things I mentioned earlier about documentation.
20170515 04:42:07< celticminstrel> Hopefully I can then push wesnoth.format() tomorrow evening, possibly along with the other config work I wanted to try (if I can get it to work).
20170515 04:44:34< celticminstrel> We have seven blocker issues.
20170515 04:44:52-!- deathisundead [~quassel@c-73-144-114-234.hsd1.mi.comcast.net] has joined #wesnoth-dev
20170515 04:44:52-!- deathisundead [~quassel@c-73-144-114-234.hsd1.mi.comcast.net] has quit [Changing host]
20170515 04:44:52-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20170515 04:45:07< celticminstrel> But most of them I don't even know what they're about. :S
20170515 04:50:14< vultraz_iOS> oh hey, i was just doing the typdef wrong
20170515 04:50:14< celticminstrel> Probably the only blocker I could do anything about would be the tiling options.
20170515 04:50:14< celticminstrel> At least on my own.
20170515 04:50:14< vultraz_iOS> i had been trying to see if i could eliminate the template param from the visitors, though
20170515 04:50:14< vultraz_iOS> don't see how, though
20170515 04:50:14< vultraz_iOS> all it really does is get "passed" to variable_info_state to determine if it holds a const config or a config.
20170515 04:51:29< celticminstrel> vultraz_iOS: Oh yeah, it was recommended to move the exception back to variable_info.hpp.
20170515 04:51:39< vultraz_iOS> but anything still requires a template parameter
20170515 04:51:46< vultraz_iOS> celticminstrel: I keep telling everyone I can't :|
20170515 04:51:55< celticminstrel> False.
20170515 04:51:57< vultraz_iOS> I throw it once from the detail file so it needs to be there
20170515 04:52:04< celticminstrel> I even posted a way for you to do it.
20170515 04:52:10< vultraz_iOS> you did?
20170515 04:52:13< celticminstrel> Yes.
20170515 04:52:31< vultraz_iOS> "(What I mean is that if you had a variable holding a pointer to an incomplete type, you could probably throw that.)"
20170515 04:52:34< vultraz_iOS> that?
20170515 04:52:39< celticminstrel> No. Include variable_info_detail.hpp in variable_info.hpp after the declaration of the exception.
20170515 04:52:49< celticminstrel> I'll link the comment in a moment.
20170515 04:53:20< celticminstrel> https://github.com/wesnoth/wesnoth/pull/1697#discussion_r116395184
20170515 04:54:38< vultraz_iOS> oh i didnt see that
20170515 04:55:08< vultraz_iOS> how does that work?
20170515 04:55:30< vultraz_iOS> ohhh
20170515 04:55:31< vultraz_iOS> ok
20170515 04:55:32< vultraz_iOS> i get it
20170515 04:55:43< vultraz_iOS> clever
20170515 04:55:53< celticminstrel> Including a file merely substitutes its contents at the location of the include statement.
20170515 04:56:19< celticminstrel> That's why using file-static variables or anonymous namespaces in a header won't localize things to the file they're in.
20170515 04:56:30< celticminstrel> Because the file you see them in is not the file the compiler sees them in.
20170515 04:57:17< celticminstrel> I don't see any way to strip the template parameters from the visitors, either.
20170515 04:57:54-!- Kwandulin [~Kwandulin@p200300760F6D8004657165791D78E001.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170515 04:58:17< celticminstrel> BTW, don't forget to remove WIP from the PR title before merging it.
20170515 04:59:07< vultraz_iOS> yup
20170515 04:59:10< vultraz_iOS> need to squash
20170515 04:59:38< celticminstrel> Whichever merge mode you're using, still rename the PR first.
20170515 05:10:59-!- Kwandulin [~Kwandulin@p200300760F6D8004657165791D78E001.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170515 05:30:23< vultraz_iOS> ok pr all rebased
20170515 05:30:26< vultraz_iOS> er
20170515 05:30:32< vultraz_iOS> squashed
20170515 05:31:13< vultraz_iOS> gonna wait on a last travis run
20170515 05:31:16< vultraz_iOS> then merge
20170515 05:41:11-!- celticminstrel is now known as celmin|sleep
20170515 06:05:39-!- JyrkiVesterinen [~jyrki@87-100-249-164.bb.dnainternet.fi] has quit [Quit: .]
20170515 06:20:21-!- mjs-de [~mjs-de@x4db5a63d.dyn.telefonica.de] has joined #wesnoth-dev
20170515 06:26:42-!- mjs-de [~mjs-de@x4db5a63d.dyn.telefonica.de] has quit [Remote host closed the connection]
20170515 06:33:46-!- irker595 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170515 06:33:46< irker595> wesnoth: Charles Dang wesnoth:master cdaa588edaaa / src/ (4 files): Refactor variable_info implementation https://github.com/wesnoth/wesnoth/commit/cdaa588edaaa87cf5a2899a985575712e8cbf5d2
20170515 06:33:49< irker595> wesnoth: Charles Dang wesnoth:master 08cd81401f2a / src/variable_info_private.hpp: Variable Info: convert uses of C-style cast https://github.com/wesnoth/wesnoth/commit/08cd81401f2a3a2a153fccfba60dc52d9122cf66
20170515 06:34:27-!- JyrkiVesterinen [~JyrkiVest@85-76-66-132-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170515 06:36:22< irker595> wesnoth: Charles Dang wesnoth:master f497b02ad91b / projectfiles/CodeBlocks/wesnoth.cbp: Updated CB projectfile https://github.com/wesnoth/wesnoth/commit/f497b02ad91b917a0814d1d2b9893dfc14d333c2
20170515 07:12:20< irker595> wesnoth: Charles Dang wesnoth:master 3fce91a8fa8f / src/utils/type_trait_aliases.hpp: Added file of type trait aliases for traits we use https://github.com/wesnoth/wesnoth/commit/3fce91a8fa8fd9ef8871ef96b759e1c91c5b4265
20170515 07:12:55< irker595> wesnoth: Charles Dang wesnoth:master 07791257bcba / projectfiles/CodeBlocks/wesnoth.cbp: Updated CB projectfile https://github.com/wesnoth/wesnoth/commit/07791257bcba7eed4df86d0d7760a9914670cc86
20170515 07:41:10-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170515 07:50:44-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170515 07:59:44-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Read error: Connection reset by peer]
20170515 08:05:10-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170515 08:28:41-!- grzywacz [~karol@wesnoth/developer/grzywacz] has joined #wesnoth-dev
20170515 08:29:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170515 09:01:48-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Ping timeout: 252 seconds]
20170515 09:07:32-!- atarocch [~atarocch@37.176.169.94] has joined #wesnoth-dev
20170515 09:12:29-!- JyrkiVesterinen [~JyrkiVest@85-76-66-132-nat.elisa-mobile.fi] has quit [Quit: .]
20170515 09:16:11-!- grzywacz [~karol@wesnoth/developer/grzywacz] has quit [Read error: Connection reset by peer]
20170515 09:37:59< irker595> wesnoth: Wedge009 wesnoth:master 4d84f0835449 / projectfiles/VC12/ (4 files): Update VC projects for 13b00f73, cdaa588e, and 3fce91a8. https://github.com/wesnoth/wesnoth/commit/4d84f0835449fb8855acf1d74bb5d41869d49dc3
20170515 09:43:14-!- JyrkiVesterinen [~JyrkiVest@85-76-66-132-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170515 09:46:33-!- atarocch [~atarocch@37.176.169.94] has quit [Ping timeout: 272 seconds]
20170515 09:51:48< irker595> wesnoth: Charles Dang wesnoth:master 7e3b91ef8c99 / src/utils/type_trait_aliases.hpp: Fixup compilation of type trait aliases https://github.com/wesnoth/wesnoth/commit/7e3b91ef8c9901f46d8382438c7b0e1ba5fc7d9e
20170515 09:59:35< irker595> wesnoth: Charles Dang wesnoth:master 723297efedcd / src/utils/const_clone.hpp: Added alias templates for const_clone https://github.com/wesnoth/wesnoth/commit/723297efedcd9888e66374b68bc78ac780f009f8
20170515 10:00:36-!- gfgtdf [~chatzilla@x4e32b0ac.dyn.telefonica.de] has joined #wesnoth-dev
20170515 10:46:31-!- atarocch [~atarocch@37.176.169.94] has joined #wesnoth-dev
20170515 10:58:16-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has quit [Ping timeout: 268 seconds]
20170515 10:59:43-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170515 11:14:41-!- grzywacz [~karol@wesnoth/developer/grzywacz] has joined #wesnoth-dev
20170515 11:58:33-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Ping timeout: 252 seconds]
20170515 12:59:41-!- irker595 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170515 13:11:46-!- zookeeper_ [zookeeper@37.35.31.211] has joined #wesnoth-dev
20170515 13:14:10-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20170515 13:24:34-!- zookeeper_ is now known as zookeeper
20170515 13:24:36-!- zookeeper [zookeeper@37.35.31.211] has quit [Changing host]
20170515 13:24:36-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170515 14:17:10< gfgtdf> im wondering do we plan to remove complability for msvc 2013 and gcc 4 with wesnoth 1.15 ?
20170515 14:17:17< vultraz_iOS> yes
20170515 14:17:47< gfgtdf> ok
20170515 14:18:56< gfgtdf> vultraz_iOS: i thought about using string_view in variable_info and i think it won't work until config.hpp always uses it too.
20170515 14:22:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170515 14:22:16< gfgtdf> vultraz_iOS: i
20170515 14:44:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170515 14:55:07-!- Kwandulin [~Kwandulin@p5DDD3425.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170515 14:57:18-!- JyrkiVesterinen [~JyrkiVest@85-76-66-132-nat.elisa-mobile.fi] has quit [Quit: .]
20170515 15:03:32-!- irker714 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170515 15:03:32< irker714> wesnoth: Charles Dang wesnoth:master 01d59074eb90 / src/utils/type_trait_aliases.hpp: Fixups to type trait aliases https://github.com/wesnoth/wesnoth/commit/01d59074eb9093919dc2d10482891e3130e0b449
20170515 15:07:45-!- Kwandulin [~Kwandulin@p5DDD3425.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170515 15:13:25-!- Kwandulin [~Kwandulin@p200300760F6D80FD3571F9634933C979.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170515 15:41:09-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170515 15:45:08-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170515 15:46:09-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170515 16:16:44< irker714> wesnoth: Charles Dang wesnoth:master 70d37c4389d7 / src/utils/type_trait_aliases.hpp: Fixup 01d5907 to satisfy the preprocessor gods https://github.com/wesnoth/wesnoth/commit/70d37c4389d7d434aaaa74197372b1b5ef156d5d
20170515 16:16:47< irker714> wesnoth: Charles Dang wesnoth:master 4d17fa12cfa4 / src/ (11 files in 6 dirs): Deployed type trait aliases https://github.com/wesnoth/wesnoth/commit/4d17fa12cfa4b5ac09ec1c0fb560b26af1e76737
20170515 16:16:50< irker714> wesnoth: Charles Dang wesnoth:master 849860a0bb74 / src/ (8 files in 4 dirs): Deployed const_clone alias templates https://github.com/wesnoth/wesnoth/commit/849860a0bb74d69f824390520d25f27ebfa18f0f
20170515 16:33:18-!- JyrkiVesterinen [~jyrki@89.166.127.194] has joined #wesnoth-dev
20170515 16:36:44-!- Kwandulin [~Kwandulin@p200300760F6D80FD3571F9634933C979.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170515 16:42:23-!- gfgtdf [~chatzilla@x4e32b0ac.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 53.0.2/20170504105526]]
20170515 16:46:27-!- atarocch [~atarocch@37.176.169.94] has quit [Ping timeout: 240 seconds]
20170515 16:49:12-!- yaiyan is now known as Ieuan
20170515 17:04:02-!- Kwandulin [~Kwandulin@p200300760F6D80FD3571F9634933C979.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170515 17:19:35-!- atarocch [~atarocch@37.176.169.94] has joined #wesnoth-dev
20170515 17:21:39-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170515 17:24:27-!- atarocch [~atarocch@37.176.169.94] has quit [Ping timeout: 240 seconds]
20170515 18:06:21-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev
20170515 18:08:48< irker714> wesnoth: Charles Dang wesnoth:master 9eb28eb70d14 / src/scripting/push_check.hpp: Simplify a few custom type traits https://github.com/wesnoth/wesnoth/commit/9eb28eb70d146bfa2e002b2eec539e8d5908b03a
20170515 18:34:52-!- sevu [~Shiki@p54856CF0.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170515 19:16:02-!- atarocch [~atarocch@93.56.160.28] has joined #wesnoth-dev
20170515 19:20:37-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170515 19:20:37< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release Charles Dang 849860a: Deployed const_clone alias templates Failed
20170515 19:20:37< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-337
20170515 19:20:42-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170515 19:21:41< JyrkiVesterinen> c:\projects\wesnoth\src\config_attribute_value.hpp(176): warning C4346: 'std::is_base_of<enum_tag,T>::value': dependent name is not a type (compiling source file ..\..\src\config.cpp) [C:\projects\wesnoth\projectfiles\VC14\wesnothlib.vcxproj]
20170515 19:21:42< JyrkiVesterinen>   c:\projects\wesnoth\src\config_attribute_value.hpp(176): note: prefix with 'typename' to indicate a type (compiling source file ..\..\src\config.cpp)
20170515 19:21:43< JyrkiVesterinen> c:\projects\wesnoth\src\config_attribute_value.hpp(176): error C2143: syntax error: missing ';' before '=' (compiling source file ..\..\src\config.cpp) [C:\projects\wesnoth\projectfiles\VC14\wesnothlib.vcxproj]
20170515 19:21:54< JyrkiVesterinen> Caused by vultraz's refactoring.
20170515 19:23:10< vultraz_iOS> ;_;
20170515 19:25:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170515 19:27:17-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170515 19:27:17< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug Charles Dang 849860a: Deployed const_clone alias templates Failed
20170515 19:27:17< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-337
20170515 19:27:22-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170515 19:32:10-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Quit: Leaving]
20170515 19:34:24-!- Kwandulin [~Kwandulin@p200300760F6D80FD3571F9634933C979.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170515 19:37:56-!- gfgtdf [~chatzilla@x4e32b0ac.dyn.telefonica.de] has joined #wesnoth-dev
20170515 19:38:43< vultraz_iOS> gfgtdf: do you get build failure locally?
20170515 19:41:02< gfgtdf> vultraz_iOS: did currntly don't build locally 
20170515 19:42:32< gfgtdf> vultraz_iOS: but appveyor seems to fail
20170515 19:42:43< gfgtdf> vultraz_iOS: so probably i would
20170515 19:43:12< vultraz_iOS> av has been failing for weeks
20170515 19:43:15< vultraz_iOS> tho
20170515 19:44:00< JyrkiVesterinen> Yes, but newer Boost was merged to aquileia/external today.
20170515 19:44:20< vultraz_iOS> hm ok
20170515 19:44:24< JyrkiVesterinen> Lack of string_view in that repository, which my PR fixed, was the previous problem.
20170515 19:45:07< gfgtdf> vultraz_iOS: curently coimplains for example about https://github.com/wesnoth/wesnoth/blob/master/src/config_attribute_value.hpp#L176
20170515 19:45:14< vultraz_iOS> yes
20170515 19:45:18< vultraz_iOS> but there's no reason for that i can see
20170515 19:47:58< irker714> wesnoth: Charles Dang wesnoth:master 96ea0eb6b97c / src/ (45 files in 16 dirs): Removed trailing tabs and whitespaces from C++ source https://github.com/wesnoth/wesnoth/commit/96ea0eb6b97cc558d7a20d6feef30a513e538944
20170515 19:48:01< gfgtdf> c:\projects\wesnoth\src\config_attribute_value.hpp(176): error C2143: syntax error: missing ';' before '='
20170515 19:48:40< JyrkiVesterinen> That "syntax error" seems to be caused by the compiler misinterpreting the syntax.
20170515 19:49:02< JyrkiVesterinen> And the preceding warning claims that a typename keyword is missing, which would explain it.
20170515 19:49:30< JyrkiVesterinen> Anyway, this is shooting in the dark as long as I don't have access to the compiler myself (I'm on GNU/Linux right now).
20170515 19:49:55< JyrkiVesterinen> I can investigate this tomorrow if other developers don't do it first.
20170515 19:51:02-!- sevu [~Shiki@p54856CF0.dip0.t-ipconnect.de] has quit [Quit: Verlassend]
20170515 19:51:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170515 20:02:17< vultraz_iOS> huh
20170515 20:02:21< vultraz_iOS> so this is a thing https://files.wesnoth.org/wip_images/recruit-dialog-rewrite/
20170515 20:02:39< vultraz_iOS> early mordante concepts, im guessing
20170515 20:09:09< shadowm> That looks more like the thing fabi did and then was reverted by mordante.
20170515 20:09:38< vultraz_iOS> oh?
20170515 20:09:41< vultraz_iOS> tell me more
20170515 20:09:50< shadowm> Can't.
20170515 20:09:56-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170515 20:10:16< shadowm> I'm just fairly positive it ended up looking exactly like that before being binned.
20170515 20:11:01< vultraz_iOS> interesting
20170515 20:16:10-!- sevu [~Shiki@141.57.63.75] has joined #wesnoth-dev
20170515 20:20:52< vultraz_iOS> sevu: did you receive the invite to the gh org?
20170515 20:26:00< sevu> yes, thanks :) I  accepted
20170515 20:26:52< sevu> vultraz_iOS ^
20170515 20:26:59< vultraz_iOS> great :)
20170515 20:27:39< sevu> indeed
20170515 20:28:35-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Remote host closed the connection]
20170515 20:29:41< sevu> btw, how do you usually check the irclogs, to see if someone wrote you? 
20170515 20:29:54< vultraz_iOS> irclogs.wesnoth.org
20170515 20:30:25< vultraz_iOS> but if you switch to Discord, you won't have to check logs since you'll always know if someone pinged you :)
20170515 20:30:31< Rhonda> celmin|sleep: fixed
20170515 20:32:16< sevu> hmmm maybe ^^
20170515 20:32:55 * Rhonda . o O ( I also always know if someone pinged you, and I'm not on discord … )
20170515 20:34:48< JyrkiVesterinen> Rhonda: that doesn't work if someone pings you when you're offline.
20170515 20:34:48< sevu> how you know? So far I'm checking the logs with ctrl+f .. 
20170515 20:35:03< JyrkiVesterinen> Whereas it works in Discord because it stores logs server-side.
20170515 20:37:25< Rhonda> JyrkiVesterinen: What's this offline thing you are talking about?
20170515 20:39:03< vultraz_iOS> xD
20170515 20:39:04 * JyrkiVesterinen is assuming that you're always online and posted that in jest.
20170515 20:43:06< sevu> hmmm, there's an option to show messages similar to irc in discord ...
20170515 20:44:53-!- JyrkiVesterinen [~jyrki@89.166.127.194] has quit [Quit: Going to bed]
20170515 20:49:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20170515 20:50:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170515 21:06:55-!- grzywacz [~karol@wesnoth/developer/grzywacz] has quit [Ping timeout: 268 seconds]
20170515 21:13:34-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20170515 21:29:07-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has quit [Ping timeout: 268 seconds]
20170515 21:36:53< SigurdFD> was that thing with a [not] being inefficent ever fixed?
20170515 22:05:50-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Read error: Connection reset by peer]
20170515 22:10:00-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170515 22:15:40-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170515 22:27:39-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170515 22:44:21< gfgtdf> SigurdFD: what exactly do you mean ?
20170515 22:44:34-!- esr1 is now known as esr
20170515 22:46:04< vultraz_iOS> no i think that still needs to be fixed
20170515 22:47:55< matthiaskrgr> is it [not] fixed yet? :> 
20170515 22:48:12-!- irker714 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170515 22:52:43-!- sevu [~Shiki@141.57.63.75] has quit [Quit: Verlassend]
20170515 22:57:20< vultraz_iOS> :|
20170515 23:24:16< SigurdFD> :D
20170515 23:25:59< SigurdFD> gfgtdf: there was something a while back about use of the [not] tag in conditionals taking sigificantly longer than other conditionals
20170515 23:26:15< SigurdFD> as far as processing time
20170515 23:31:48-!- sevu [~Shiki@p54856CF0.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170515 23:37:10-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170515 23:56:24< celmin|sleep> So no-one updated the MSVC project yet?
--- Log closed Tue May 16 00:00:23 2017