--- Log opened Tue May 16 00:00:23 2017
20170516 00:01:42-!- celmin|sleep is now known as celticminstrel
20170516 00:07:33-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170516 00:11:57< celticminstrel> Seems like this guy never got to it, Maybe someone else could address the issue? https://forums.wesnoth.org/viewtopic.php?f=10&t=44923
20170516 00:12:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 246 seconds]
20170516 00:13:18< celticminstrel> Basically just remove static, redeclare it extern in wesnoth.cpp, and set it in main().
20170516 00:16:02-!- Jetrel_ [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has joined #wesnoth-dev
20170516 00:16:33-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has quit [Read error: Connection reset by peer]
20170516 00:28:03< celticminstrel> TBH, I think all the type traits alias changes should just be reverted. The advantage of the aliases is tiny (negligible IMO), and the attempt to add it has just caused problems. Mind you, I think it's easily solvable without reverting them, but...
20170516 00:29:19< celticminstrel> Basically it's adding a layer of compatibility for minimal gain. Why bother?
20170516 00:29:33 * celticminstrel prods vultraz_iOS for comments.
20170516 00:41:02-!- gfgtdf [~chatzilla@x4e32b0ac.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 53.0.2/20170504105526]]
20170516 00:44:21< celticminstrel> Actually, if I don't get a reply by the time I feel ready to push, I'll probably just revert it myself.
20170516 00:44:31< celticminstrel> Mainly because I've now reverted it locally just so that I can build.
20170516 01:33:19< vultraz_iOS> celticminstrel: why revert
20170516 01:33:49< celticminstrel> Because even if fixing it is easy (which I'm not quite sure about anymore), reverting is even easier.
20170516 01:34:15< vultraz_iOS> what's the problem, though.
20170516 01:34:50< vultraz_iOS> as far as I can see there's nothing overtly wrong with the code :|
20170516 01:34:52< celticminstrel> The problem is it doesn't compile.
20170516 01:35:05< celticminstrel> I think you misunderstand "using qualified::name".
20170516 01:35:11< celticminstrel> Possibly I did too, mind you.
20170516 01:35:56< vultraz_iOS> you used it before
20170516 01:36:00< vultraz_iOS> using std::put_time
20170516 01:36:40< celticminstrel> Well, put_time isn't a templated though IIRC. That might have something to do with it.
20170516 01:37:10< vultraz_iOS> possibly
20170516 01:38:23-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 260 seconds]
20170516 01:40:14-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20170516 01:44:08< vultraz_iOS> whatever, if you want to revert it go ahead
20170516 01:44:32< vultraz_iOS> just don't revert the non-related changes to push_check.hpp
20170516 01:44:43< vultraz_iOS> and you can decide what to do with the const_clone aliases
20170516 01:45:00< celticminstrel> I have no idea what the changes to push_check.hpp are.
20170516 01:45:06< vultraz_iOS> .....
20170516 01:45:16< celticminstrel> But I suppose I can try cherry-picking that commit and see if it works out.
20170516 01:59:23< celticminstrel> If someone else fixes it before I push, I won't revert it. IIRC Jyrki said he might look at it.
20170516 02:00:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170516 02:05:45-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170516 02:38:28-!- Jetrel_ [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has quit [Ping timeout: 246 seconds]
20170516 02:40:18-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has joined #wesnoth-dev
20170516 02:51:43-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has quit []
20170516 03:08:01-!- sevu [~Shiki@p54856CF0.dip0.t-ipconnect.de] has quit [Disconnected by services]
20170516 03:08:01-!- shiki [~Shiki@p54855B6A.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170516 03:10:02< shadowm> zookeeper: You probably got the PM for the MP Mods group but I'm reminding you to check it anyway.
20170516 03:10:34-!- shiki [~Shiki@p54855B6A.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20170516 04:16:55-!- Kwandulin [~Kwandulin@p200300760F6D80FD3571F9634933C979.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170516 04:32:40-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has quit [Read error: Connection reset by peer]
20170516 04:33:10-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has joined #wesnoth-dev
20170516 05:04:03-!- JyrkiVesterinen [~JyrkiVest@87-100-149-105.bb.dnainternet.fi] has joined #wesnoth-dev
20170516 05:43:25-!- grzywacz [~karol@163.172.154.146] has joined #wesnoth-dev
20170516 05:45:04-!- grzywacz [~karol@163.172.154.146] has quit [Changing host]
20170516 05:45:04-!- grzywacz [~karol@wesnoth/developer/grzywacz] has joined #wesnoth-dev
20170516 05:48:37-!- celticminstrel is now known as celmin|sleep
20170516 05:49:19-!- atarocch [~atarocch@93.56.160.28] has quit [Ping timeout: 246 seconds]
20170516 05:56:51-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has quit [Read error: Connection reset by peer]
20170516 05:56:57-!- Jetrel_ [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has joined #wesnoth-dev
20170516 05:58:36-!- irker873 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170516 05:58:36< irker873> wesnoth: Celtic Minstrel wesnoth:master 238c1750453e / data/lua/wml/endlevel.lua: Probable fix for [endlevel] music issue (#1704) https://github.com/wesnoth/wesnoth/commit/238c1750453e2bbc9ad56879597817ce5fbe64cd
20170516 06:07:57-!- JyrkiVesterinen [~JyrkiVest@87-100-149-105.bb.dnainternet.fi] has quit [Quit: .]
20170516 06:09:02-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170516 06:13:54-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 268 seconds]
20170516 06:25:57-!- atarocch [~atarocch@37.159.48.29] has joined #wesnoth-dev
20170516 06:28:00-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170516 06:30:54< zookeeper> celmin|sleep, are "type traits alias changes" something i should have an opinion on?
20170516 06:47:45-!- JyrkiVesterinen [~JyrkiVest@85-76-66-132-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170516 06:53:15-!- Jetrel_ [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has quit [Read error: Connection reset by peer]
20170516 06:53:29-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has joined #wesnoth-dev
20170516 06:59:11-!- atarocch [~atarocch@37.159.48.29] has quit [Ping timeout: 240 seconds]
20170516 07:28:37-!- atarocch [~atarocch@37.159.48.29] has joined #wesnoth-dev
20170516 07:33:54-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170516 07:40:13-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170516 07:57:19-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170516 08:01:43-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 255 seconds]
20170516 08:41:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170516 09:02:22-!- JyrkiVesterinen [~JyrkiVest@85-76-66-132-nat.elisa-mobile.fi] has quit [Quit: .]
20170516 09:13:48-!- grzywacz [~karol@wesnoth/developer/grzywacz] has quit [Ping timeout: 240 seconds]
20170516 09:26:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170516 09:26:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170516 09:33:58-!- JyrkiVesterinen [~JyrkiVest@85-76-66-132-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170516 09:39:15-!- deekay [~deekayish@ip-94.124.0.122.s.net.pl] has joined #wesnoth-dev
20170516 09:45:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170516 09:49:41-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170516 10:18:42-!- Kwandulin [~Kwandulin@p200300760F6D80FD3571F9634933C979.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170516 10:19:00-!- irker873 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170516 10:20:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170516 10:21:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170516 10:29:05-!- Duthlet [~Duthlet@dslb-188-106-026-111.188.106.pools.vodafone-ip.de] has joined #wesnoth-dev
20170516 10:43:39-!- grzywacz [~karol@wesnoth/developer/grzywacz] has joined #wesnoth-dev
20170516 11:02:28-!- Kwandulin [~Kwandulin@p200300760F6D80FD3571F9634933C979.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170516 11:07:58-!- deekay [~deekayish@ip-94.124.0.122.s.net.pl] has quit [Quit: This computer has gone to sleep]
20170516 11:13:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170516 11:13:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170516 11:16:23-!- gfgtdf [~chatzilla@x4e32b16a.dyn.telefonica.de] has joined #wesnoth-dev
20170516 11:26:16-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Ping timeout: 252 seconds]
20170516 11:29:42-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev
20170516 11:30:51-!- deekay [~deekayish@ip-94.124.0.122.s.net.pl] has joined #wesnoth-dev
20170516 11:34:01-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170516 11:43:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 258 seconds]
20170516 11:47:56-!- deekay [~deekayish@ip-94.124.0.122.s.net.pl] has quit [Quit: This computer has gone to sleep]
20170516 12:01:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170516 12:17:16-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has quit [Ping timeout: 260 seconds]
20170516 12:21:08-!- Duthlet [~Duthlet@dslb-188-106-026-111.188.106.pools.vodafone-ip.de] has quit [Ping timeout: 240 seconds]
20170516 12:24:30-!- Kwandulin [~Kwandulin@p200300760F6D80FD3571F9634933C979.dip0.t-ipconnect.de] has quit [Ping timeout: 245 seconds]
20170516 12:32:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170516 12:33:40-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev
20170516 12:52:38-!- deekay [~deekayish@public-gprs366969.centertel.pl] has joined #wesnoth-dev
20170516 13:10:00-!- gfgtdf [~chatzilla@x4e32b16a.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170516 13:15:19-!- gfgtdf [~chatzilla@x50ab6d79.dyn.telefonica.de] has joined #wesnoth-dev
20170516 13:35:41-!- Bonobo [~Bonobo@2001:44b8:254:3200:50c5:7c95:a4cf:25e5] has joined #wesnoth-dev
20170516 13:56:07-!- ggeneral [~ggeneral@48.175.47.77.pptp.ntu-kpi.kiev.ua] has joined #wesnoth-dev
20170516 14:00:26-!- Kwandulin [~Kwandulin@p200300760F6D80F5A10027639636B8F6.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170516 14:05:09-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has quit [Ping timeout: 272 seconds]
20170516 14:13:55-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has quit [Ping timeout: 246 seconds]
20170516 14:15:08-!- Appleman1234 [~quassel@pl1428.ag1212.nttpc.ne.jp] has quit [Read error: Connection reset by peer]
20170516 14:16:40-!- ggeneral [~ggeneral@48.175.47.77.pptp.ntu-kpi.kiev.ua] has left #wesnoth-dev []
20170516 14:27:40-!- JyrkiVesterinen [~JyrkiVest@85-76-66-132-nat.elisa-mobile.fi] has quit [Quit: .]
20170516 14:29:43-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev
20170516 14:35:41-!- deekay [~deekayish@public-gprs366969.centertel.pl] has quit [Quit: This computer has gone to sleep]
20170516 14:42:45-!- Duthlet [~Duthlet@dslb-188-106-026-111.188.106.pools.vodafone-ip.de] has joined #wesnoth-dev
20170516 14:45:47-!- Bonobo [~Bonobo@2001:44b8:254:3200:50c5:7c95:a4cf:25e5] has quit [Quit: Leaving]
20170516 14:48:24-!- gfgtdf [~chatzilla@x50ab6d79.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 53.0.2/20170504105526]]
20170516 14:51:27-!- deekay [~deekayish@public-gprs366969.centertel.pl] has joined #wesnoth-dev
20170516 15:08:50-!- Appleman1234 [~quassel@pl1428.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170516 15:17:15-!- nore [~ncourant@sas.eleves.ens.fr] has quit [Read error: Connection reset by peer]
20170516 15:20:42-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170516 15:21:45-!- nore [~ncourant@sas.eleves.ens.fr] has joined #wesnoth-dev
20170516 15:43:54-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170516 15:49:18-!- JyrkiVesterinen [~JyrkiVest@89-166-111-220.bb.dnainternet.fi] has joined #wesnoth-dev
20170516 15:58:56< JyrkiVesterinen> OK, I think I know why Visual Studio builds are failing.
20170516 15:59:19< JyrkiVesterinen> utils/type_trait_aliases.hpp is in a wrong VS project. It should be in wesnothlib, not wesnoth.
20170516 15:59:40< JyrkiVesterinen> As a result, attempting to use it from within wesnothlib fails.
20170516 15:59:47< JyrkiVesterinen> I'll try moving it to wesnothlib.
20170516 16:00:02-!- Duthlet [~Duthlet@dslb-188-106-026-111.188.106.pools.vodafone-ip.de] has quit [Ping timeout: 240 seconds]
20170516 16:04:39-!- Duthlet [~Duthlet@dslb-188-106-026-111.188.106.pools.vodafone-ip.de] has joined #wesnoth-dev
20170516 16:06:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170516 16:10:43-!- deekay [~deekayish@public-gprs366969.centertel.pl] has quit [Quit: This computer has gone to sleep]
20170516 16:15:10< JyrkiVesterinen> Hmm, that alone doesn't fix it.
20170516 16:15:24< JyrkiVesterinen> I get slightly different errors:
20170516 16:15:32< JyrkiVesterinen> 1>i:\battle for wesnoth\wesnoth\src\config_attribute_value.hpp(176): error C2039: 'enable_if_t<,Venum_tag::_base_of,T,AAVconfig_attribute_value>' : is not a member of 'utils' (..\..\src\config.cpp)
20170516 16:18:06< JyrkiVesterinen> As an experiment, using std::enable_if_t directly works. Maybe I need alias templateshere...
20170516 16:28:39-!- sevu [~Shiki@141.57.63.75] has joined #wesnoth-dev
20170516 16:30:36-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170516 16:33:36-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170516 16:38:27< JyrkiVesterinen> Using alias templates gets me further, but then some implementations of lexical_caster get multiply defined, as if enable_if_t always passes.
20170516 16:38:43< JyrkiVesterinen> Again, using std::enable_if_t directly fixes it.
20170516 16:38:57< JyrkiVesterinen> I guess I'll need to look at preprocessed source next...
20170516 16:41:06-!- Kwandulin [~Kwandulin@p200300760F6D80F5A10027639636B8F6.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170516 16:42:44< JyrkiVesterinen> Now investigating version.i: 3,5 MB, 230 000 lines. :|
20170516 16:45:05< JyrkiVesterinen> Well, it's not very useful, because this preprocessed source is made *before* template instantiation.
20170516 16:50:16-!- atarocch [~atarocch@37.159.48.29] has quit [Ping timeout: 260 seconds]
20170516 16:53:58-!- nore [~ncourant@sas.eleves.ens.fr] has quit [Remote host closed the connection]
20170516 16:54:15-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170516 16:54:16-!- nore [~ncourant@sas.eleves.ens.fr] has joined #wesnoth-dev
20170516 16:54:41-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170516 16:54:45-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170516 16:55:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170516 16:55:33-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Read error: Connection reset by peer]
20170516 16:55:57-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170516 16:59:47-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170516 17:03:27-!- mjs-de [~mjs-de@x5ce4c08a.dyn.telefonica.de] has joined #wesnoth-dev
20170516 17:04:22< JyrkiVesterinen> Hmm.. I wonder if the problem is lack of support for expression SFINAE. I'll check if it's any better with VS2017.
20170516 17:13:48-!- Kwandulin [~Kwandulin@p200300760F6D80F5A10027639636B8F6.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170516 17:19:41< JyrkiVesterinen> It builds with VS2017.
20170516 17:19:53< JyrkiVesterinen> So, it seems the problem is lack of expression SFINAE.
20170516 17:20:09< JyrkiVesterinen> VS2015 gained partial support in Update 1.
20170516 17:20:22< JyrkiVesterinen> Next, I'll need to figure out what to do with VS2013...
20170516 17:21:22-!- atarocch [~atarocch@37.159.48.29] has joined #wesnoth-dev
20170516 17:22:17-!- deekay [~deekayish@public-gprs366969.centertel.pl] has joined #wesnoth-dev
20170516 17:27:55< JyrkiVesterinen> Okay, the manual implementations work with VS2013, so I can simply use them.
20170516 17:46:45-!- deekay [~deekayish@public-gprs366969.centertel.pl] has quit [Quit: This computer has gone to sleep]
20170516 17:54:27-!- sevu [~Shiki@141.57.63.75] has quit [Remote host closed the connection]
20170516 17:58:40-!- atarocch [~atarocch@37.159.48.29] has quit [Ping timeout: 240 seconds]
20170516 18:03:22-!- deekay [~deekayish@public-gprs366969.centertel.pl] has joined #wesnoth-dev
20170516 18:08:43-!- irker307 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170516 18:08:43< irker307> wesnoth: Jyrki Vesterinen wesnoth:master fb8506dbacd9 / / (5 files in 2 dirs): Fix build with Visual Studio https://github.com/wesnoth/wesnoth/commit/fb8506dbacd987c21fc00ca3ab3daefb94a48649
20170516 18:11:01-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has quit [Ping timeout: 240 seconds]
20170516 18:15:01-!- deekay [~deekayish@public-gprs366969.centertel.pl] has quit [Quit: This computer has gone to sleep]
20170516 18:22:04-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170516 18:22:04< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release Celtic Minstrel 238c175: Probable fix for [endlevel] music issue (#1704) Failed
20170516 18:22:04< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-341
20170516 18:22:08-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170516 18:27:11-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev
20170516 18:33:59-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170516 18:33:59< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug Celtic Minstrel 238c175: Probable fix for [endlevel] music issue (#1704) Failed
20170516 18:33:59< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-341
20170516 18:34:03-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170516 18:41:15-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170516 18:41:15< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release Celtic Minstrel 238c175: Probable fix for [endlevel] music issue (#1704) Failed
20170516 18:41:15< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-339
20170516 18:41:19-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170516 18:42:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170516 18:48:02-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170516 18:48:02< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug Celtic Minstrel 238c175: Probable fix for [endlevel] music issue (#1704) Failed
20170516 18:48:02< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-339
20170516 18:48:06-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170516 18:54:03-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170516 19:22:11-!- deekay [~deekayish@public-gprs366969.centertel.pl] has joined #wesnoth-dev
20170516 19:30:43-!- JyrkiVesterinen [~JyrkiVest@89-166-111-220.bb.dnainternet.fi] has quit [Quit: .]
20170516 19:32:27-!- Kwandulin [~Kwandulin@p200300760F6D80F5A10027639636B8F6.dip0.t-ipconnect.de] has quit [Quit: [endlevel] result=novictorynodefeatjustquit [/endlevel]]
20170516 19:36:43-!- atarocch [~atarocch@93.56.160.28] has joined #wesnoth-dev
20170516 19:40:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170516 19:49:15-!- nore [~ncourant@sas.eleves.ens.fr] has quit [Remote host closed the connection]
20170516 19:49:45-!- nore [~ncourant@sas.eleves.ens.fr] has joined #wesnoth-dev
20170516 19:56:37-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.]
20170516 19:56:54-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170516 20:01:55-!- deekay [~deekayish@public-gprs366969.centertel.pl] has quit [Quit: Leaving]
20170516 20:28:39-!- grzywacz [~karol@wesnoth/developer/grzywacz] has quit [Ping timeout: 260 seconds]
20170516 20:58:00-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170516 21:24:55-!- mjs-de [~mjs-de@x5ce4c08a.dyn.telefonica.de] has quit [Remote host closed the connection]
20170516 21:44:29-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has quit [Ping timeout: 246 seconds]
20170516 21:51:40-!- gfgtdf [~chatzilla@x50ab6d79.dyn.telefonica.de] has joined #wesnoth-dev
20170516 22:08:00-!- irker307 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170516 22:12:58-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170516 22:20:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170516 22:20:19-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170516 22:54:41< vultraz_iOS> celmin|sleep: we still have 0 release notes for the release
20170516 23:06:46-!- louis94 [~~louis94@95.129-200-80.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20170516 23:06:51< gfgtdf> vultraz_iOS: maybe we shodul all https://github.com/wesnoth/wesnoth/issues/1704 to known bugs since it will break all campagn that use [endlevel] music= (in other scnearios than the last)
20170516 23:07:50< vultraz_iOS> I'll add it
20170516 23:19:45< gfgtdf> vultraz_iOS: other than that i'd just go through the changelog and see whetrhthere are changes worth adding , sureley we can hvae a section for the most imporatn wml/lua additions, maybe we could also note the new storyscreen.
20170516 23:20:14< gfgtdf> vultraz_iOS: and ofc we shodul note all complabitly breaking changes
20170516 23:21:15< gfgtdf> vultraz_iOS: for example: '[unit]placement=name is now [unit]location_id=name' also, isnt this the rease that reverted FOREACH to use [while] again(or was that already i th epreviosl release)?
20170516 23:25:43< vultraz_iOS> was it?
20170516 23:28:28< vultraz_iOS> didn't celmin also do other changes to placement?
20170516 23:30:28< vultraz_iOS> oh yeah
20170516 23:30:34< vultraz_iOS> command key was reverted to ; too
20170516 23:44:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170516 23:45:08-!- Duthlet [~Duthlet@dslb-188-106-026-111.188.106.pools.vodafone-ip.de] has quit [Quit: leaving]
20170516 23:45:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170516 23:52:40< celmin|sleep> Oh yeah, I forgot to edit the RELEASE_NOTES post... o.o
20170516 23:53:12< celmin|sleep> I did do other changes to placement. The following values are deprecated: map_overwrite, map_passable. leader_passable.
20170516 23:55:35< celmin|sleep> And Jyrki fixed that, I see. I guess I'll unrevert locally and pull it.
--- Log closed Wed May 17 00:00:04 2017