--- Log opened Sat May 20 00:00:31 2017
20170520 00:01:07-!- louis94 [~~louis94@95.129-200-80.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 240 seconds]
20170520 00:02:50-!- celmin|sleep is now known as celticminstrel
20170520 00:07:27< celticminstrel> ...wait, the announcement still isn't posted? :|
20170520 00:25:07-!- bumba [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Read error: Connection reset by peer]
20170520 00:25:13-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170520 00:27:41< vultraz_iOS> celticminstrel: now it is
20170520 00:28:07-!- vultraz_iOS changed the topic of #wesnoth-dev to: Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Discord Server: https://discord.gg/tSmJS2E | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20170520 00:41:20-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170520 00:44:37-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170520 00:46:10-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Ping timeout: 246 seconds]
20170520 00:47:17-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Read error: Connection reset by peer]
20170520 00:47:49-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170520 00:56:43< celticminstrel> vultraz_iOS: Is that random line break before "does not mean" intentional?
20170520 00:57:03< vultraz_iOS> what?
20170520 00:57:11< celticminstrel> In the paragraph about licensing.
20170520 00:57:22< vultraz_iOS> fixed
20170520 00:57:48< celticminstrel> I would've just fixed it, but I figured I should check in case it was intentional.
20170520 01:19:43-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170520 01:20:42-!- shadowm [~ignacio@wesnoth/developer/shadowm] has left #wesnoth-dev []
20170520 01:26:37-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:2883:5ba7:abb6:90d7] has joined #wesnoth-dev
20170520 01:31:27-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:2883:5ba7:abb6:90d7] has quit [Ping timeout: 260 seconds]
20170520 01:51:53-!- irker968 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170520 01:55:06-!- gfgtdf_ [~chatzilla@x50ab6cb3.dyn.telefonica.de] has joined #wesnoth-dev
20170520 01:57:58-!- gfgtdf [~chatzilla@x4e3690a5.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170520 01:58:00-!- gfgtdf_ is now known as gfgtdf
20170520 02:12:14-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:2883:5ba7:abb6:90d7] has joined #wesnoth-dev
20170520 02:16:41-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:2883:5ba7:abb6:90d7] has quit [Remote host closed the connection]
20170520 02:17:17-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:2883:5ba7:abb6:90d7] has joined #wesnoth-dev
20170520 02:21:22-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:2883:5ba7:abb6:90d7] has quit [Ping timeout: 246 seconds]
20170520 02:24:43-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20170520 02:25:10-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170520 02:49:19-!- gfgtdf [~chatzilla@x50ab6cb3.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 53.0.2/20170504105526]]
20170520 03:36:44-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170520 04:09:47-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170520 04:10:22-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:2883:5ba7:abb6:90d7] has joined #wesnoth-dev
20170520 04:14:36-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:2883:5ba7:abb6:90d7] has quit [Ping timeout: 240 seconds]
20170520 04:35:03-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170520 04:57:26-!- Kwandulin [~Kwandulin@p200300760F6D80597C5240E1DB9DA146.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170520 05:08:34-!- celticminstrel is now known as celmin_of_nod
20170520 05:11:04-!- JyrkiVesterinen [~JyrkiVest@87-100-205-108.bb.dnainternet.fi] has joined #wesnoth-dev
20170520 06:20:52< Kwandulin> Uff, the new storyscreen stuff is so smooth
20170520 06:23:48< Kwandulin> It seems to bug, when repeatedly clicking on the left and right arrow: https://www.dropbox.com/s/e2kx5uj66ylekan/storyscreen..jpg?dl=0
20170520 06:25:19< Kwandulin> Wouldn't something like the storyscreen text fade in/fade out be suitable for the ingame [message]s?
20170520 06:46:06-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170520 06:57:19-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170520 07:00:05< zookeeper> Kwandulin, it'd have to be a much faster fade i think, and it'd have to allow dismissing the message while the fade-in is still playing. whether that's easily doable or not, i don't know.
20170520 07:02:48< zookeeper> uh, anyone on OSX who could try reproducing this? https://forums.wesnoth.org/viewtopic.php?p=612789#p612789
20170520 07:09:07< zookeeper> not the standing animation thing, but more like the spear/javelin thing. sounds very dubious to me.
20170520 07:48:08-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170520 08:00:35-!- JyrkiVesterinen [~JyrkiVest@87-100-205-108.bb.dnainternet.fi] has quit [Quit: .]
20170520 08:56:12-!- JyrkiVesterinen [~JyrkiVest@87-100-205-108.bb.dnainternet.fi] has joined #wesnoth-dev
20170520 10:11:13-!- irker155 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170520 10:11:13< irker155> wesnoth: Charles Dang wesnoth:master 1005843c523a / src/ (game_events/manager.hpp game_state.cpp): Game Events/Manager: restrict public access of internals https://github.com/wesnoth/wesnoth/commit/1005843c523a3d2f09de613dcf1150d6eac9c58f
20170520 10:11:16< irker155> wesnoth: Charles Dang wesnoth:master be665e29f111 / src/game_events/ (manager.cpp manager.hpp menu_item.cpp pump.cpp): Game Events/Manager: added function to encapsulate iteration-by-id interface https://github.com/wesnoth/wesnoth/commit/be665e29f111ad6c8ef1e8410a08608a405554cc
20170520 10:11:51-!- mjs-de [~mjs-de@x4e31d462.dyn.telefonica.de] has joined #wesnoth-dev
20170520 10:14:27< irker155> wesnoth: Charles Dang wesnoth:master 4b2518483a96 / src/game_events/ (menu_item.cpp pump.cpp): Fixup be665e29f111 (capture by reference) https://github.com/wesnoth/wesnoth/commit/4b2518483a968402d61581ae26967b54230a4228
20170520 10:52:36-!- JyrkiVesterinen [~JyrkiVest@87-100-205-108.bb.dnainternet.fi] has quit [Quit: .]
20170520 11:45:14-!- JyrkiVesterinen [~JyrkiVest@87-100-205-108.bb.dnainternet.fi] has joined #wesnoth-dev
20170520 11:58:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170520 12:24:50-!- Kwandulin2 [~Kwandulin@p200300760F6D807A4D2379FF42A171CC.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170520 12:24:58-!- Kwandulin [~Kwandulin@p200300760F6D80597C5240E1DB9DA146.dip0.t-ipconnect.de] has quit [Ping timeout: 255 seconds]
20170520 12:53:09< irker155> wesnoth: Nils Kneuper wesnoth:master 14f22785a64d / / (7 files in 6 dirs): updated British English translation https://github.com/wesnoth/wesnoth/commit/14f22785a64df056975e1ae29e35e4a1fbdca460
20170520 12:53:11< irker155> wesnoth: Nils Kneuper wesnoth:master d14ef5a74361 / / (8 files in 7 dirs): updated Italian translation https://github.com/wesnoth/wesnoth/commit/d14ef5a7436103fde39a727e2e62bcf3b2152730
20170520 13:27:21-!- mjs-de [~mjs-de@x4e31d462.dyn.telefonica.de] has quit [Remote host closed the connection]
20170520 13:39:25< celmin_of_nod> I assume the storyscreen bug Kwandulin2 mentioned is the same one matthiaskrgr reported?
20170520 13:43:10< celmin_of_nod> zookeeper: Any objections the The_Gnat's new price change proposals?
20170520 13:43:33< Kwandulin2> Yes it is
20170520 14:04:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170520 14:11:08-!- Kwandulin2 [~Kwandulin@p200300760F6D807A4D2379FF42A171CC.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170520 14:59:17-!- mjs-de [~mjs-de@x4e31d462.dyn.telefonica.de] has joined #wesnoth-dev
20170520 15:09:28-!- Kwandulin [~Kwandulin@p200300760F6D807A4D2379FF42A171CC.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170520 15:10:36< zookeeper> celmin_of_nod, nope
20170520 15:20:54< vultraz_iOS> celmin_of_nod: could you finalize that music fix so we can post the patch?
20170520 15:30:19-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:2883:5ba7:abb6:90d7] has joined #wesnoth-dev
20170520 15:32:53< irker155> wesnoth: Jyrki Vesterinen wesnoth:large-gui-canvas 18a2d8bbf7b8 / / (4 files in 2 dirs): Copy string_view implementation from Boost https://github.com/wesnoth/wesnoth/commit/18a2d8bbf7b845fdb4b16953020aa7fddbef381c
20170520 15:33:09< JyrkiVesterinen> gfgtdf: ^
20170520 15:57:15-!- elias is now known as allefant
20170520 15:57:57-!- allefant is now known as elias
20170520 16:26:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170520 16:28:22-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:2883:5ba7:abb6:90d7] has quit [Remote host closed the connection]
20170520 16:32:01-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170520 16:32:01< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release Nils Kneuper d14ef5a: updated Italian translation Failed
20170520 16:32:01< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-345
20170520 16:32:06-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170520 16:46:11-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170520 16:46:11< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug Nils Kneuper d14ef5a: updated Italian translation Failed
20170520 16:46:11< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-345
20170520 16:46:15-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170520 17:03:37-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170520 17:03:37< Appveyor> The Battle for Wesnoth (Visual Studio 2017) - Release Nils Kneuper d14ef5a: updated Italian translation Failed
20170520 17:03:37< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-28
20170520 17:03:41-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170520 17:04:41-!- celmin_of_nod is now known as celticminstrel
20170520 17:17:14< irker155> wesnoth: Jyrki Vesterinen wesnoth:master a1be82f4996c / src/game_events/manager.hpp: Fix build with Visual Studio https://github.com/wesnoth/wesnoth/commit/a1be82f4996c3bd5359013d0609f338736450a9e
20170520 17:19:59-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170520 17:19:59< Appveyor> The Battle for Wesnoth (Visual Studio 2017) - Debug Nils Kneuper d14ef5a: updated Italian translation Failed
20170520 17:19:59< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-28
20170520 17:20:03-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170520 17:23:47< celticminstrel> gfgtdf, do you really think we should copy the Boost string_view header into Wesnoth? Any chances that that would cause problems if your Boost version differs from the version the header was copied fron?
20170520 17:24:21< celticminstrel> Also, why isn't irker reporting my commits...
20170520 17:26:26< irker155> wesnoth: Celtic Minstrel wesnoth:master 3d5528f950c7 / data/lua/wml/endlevel.lua: Proper fix for [endlevel] music issue (#1704) https://github.com/wesnoth/wesnoth/commit/3d5528f950c76c71697e52a69dfe7264c24afb3c
20170520 17:26:28< irker155> wesnoth: Celtic Minstrel wesnoth:master bcb00f787fff / data/core/units/ (5 files in 3 dirs): Tweak a few more L3/L4 unit costs (suggested by The_Gnat) https://github.com/wesnoth/wesnoth/commit/bcb00f787fffd54336380ffb31fd672f05dc8b0b
20170520 17:31:29< Ivanovic> is it known that building right now is broken with boost-1.63.0 ?
20170520 17:32:46< JyrkiVesterinen> No.
20170520 17:32:55< JyrkiVesterinen> Also, I just built it with 1.64 myself.
20170520 17:33:04< JyrkiVesterinen> Without any problems.
20170520 17:33:06< Ivanovic> at least for me it fails building over here with 1.63.0 due to linking erros with boost regex
20170520 17:33:22< Ivanovic> for both 1.12 as well as master
20170520 17:33:25< JyrkiVesterinen> Have you tried a clean rebuild?
20170520 17:33:42< Ivanovic> works nicely with boost 1.62.0
20170520 17:33:46< Ivanovic> of course i have
20170520 17:33:55< Ivanovic> happens both with cmake as well as scons
20170520 17:34:22< JyrkiVesterinen> Hmm, strange. I don't really get why it would work with 1.62 and 1.64 but fail with 1.63. :/
20170520 17:34:26< Ivanovic> using gcc (Gentoo 6.3.0 p1.0) 6.3.0
20170520 17:34:45< JyrkiVesterinen> I'm using MSVC, so maybe it's a GCC-specific problem...
20170520 17:35:07< Ivanovic> i had to do a reset of the build environment anyway, due to switching the gcc version
20170520 17:36:11< irker155> wesnoth: Nils Kneuper wesnoth:master d41396ac32a2 / CMakeLists.txt: bump version requirements for boost to meet INSTALL.md https://github.com/wesnoth/wesnoth/commit/d41396ac32a2d923efcc97716cae14c8af158ff9
20170520 17:36:38-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170520 17:36:38< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release Nils Kneuper d14ef5a: updated Italian translation Failed
20170520 17:36:38< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-343
20170520 17:36:42-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170520 17:45:39< Ivanovic> switching to 1.62.0-r1 (gentoo patch level 1), both master as well as 1.12.x branch build nicely again
20170520 17:46:42< vultraz_iOS> what is the error?
20170520 17:47:07< Ivanovic> https://pastebin.com/vtkzMXEc
20170520 17:47:43< Ivanovic> completely same environment, just rolled back boost version from 1.63.0 to 1.62.0-r1 makes it build+link normal again
20170520 17:48:13-!- DeFender1031 [~DeFender1@46-116-209-76.bb.netvision.net.il] has joined #wesnoth-dev
20170520 17:49:22< Ivanovic> using scons (just added -j6 as param, rest default): https://pastebin.com/AMx2NEFk
20170520 17:50:20< loonycyborg> Ivanovic: can you add the command line too just in case?
20170520 17:50:28< loonycyborg> anyway that looks like an abi conflict
20170520 17:50:39< loonycyborg> cxx11 or something
20170520 17:50:40< Ivanovic> which commandline?
20170520 17:50:49< loonycyborg> linker command line
20170520 17:51:08-!- heirecka [~heirecka@exherbo/developer/heirecka] has quit [Ping timeout: 240 seconds]
20170520 17:52:00< Ivanovic> added some more lines to the scons paste: https://pastebin.com/WAF0pRdy
20170520 17:52:01-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev
20170520 17:52:03< loonycyborg> gentoo could have easily fucked up with packaging in gcc-6
20170520 17:52:13< Ivanovic> sure, they could
20170520 17:52:23< Ivanovic> especially since i just did the switch from 5.8 to 6
20170520 17:52:34< loonycyborg> last time I tried using 6.3 I got error about missing stdio.h or something along those lines
20170520 17:52:43< loonycyborg> so I went back to gcc-5
20170520 17:53:04-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170520 17:53:04< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug Nils Kneuper d14ef5a: updated Italian translation Failed
20170520 17:53:04< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-343
20170520 17:53:06< Ivanovic> wesnoth was the only package having issues (so far)
20170520 17:53:08-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170520 17:54:00< loonycyborg> yes, I got it from wesnoth
20170520 17:54:12< loonycyborg> gcc-6 still wasn't the compiler the system is built with
20170520 17:54:33< Ivanovic> true, i could run an emerge -e system
20170520 17:54:36< loonycyborg> I just chose it with gcc-config and got really silly compiler error when trying to use it
20170520 17:55:21< Ivanovic> and afterwards switch to 1.63.0 again to crosscheck if it still causes issues
20170520 18:02:41-!- gfgtdf [~chatzilla@x50ab6cb3.dyn.telefonica.de] has joined #wesnoth-dev
20170520 18:23:01< gfgtdf> celticminstrel: i want ot make an addon with the fix for #1704  (copy the endlevle file to that addon) any opinion on it ?
20170520 18:36:43< irker155> wesnoth: Charles Dang wesnoth:master c04e289c7353 / src/game_events/ (handlers.cpp handlers.hpp manager.hpp manager_impl.hpp): Game Events: more formatting and doc cleanup https://github.com/wesnoth/wesnoth/commit/c04e289c7353d109fdb8ac3e9cec16758bbe935a
20170520 18:38:31< loonycyborg> Ivanovic: wesnoth builds fine for me with boost 1.63
20170520 18:38:43< Ivanovic> which compiler?
20170520 18:38:46< loonycyborg> gcc is 5.4 though
20170520 18:38:54< Ivanovic> might be the combination of 6.3 with 1.63 then?
20170520 18:39:02< loonycyborg> probably
20170520 18:39:13< loonycyborg> you still have older compiler installed?
20170520 18:39:25< Ivanovic> nope, removed it already
20170520 18:40:10< loonycyborg> last time I tried 6.3 I got really silly error, but there was already an update since then
20170520 18:40:34< celticminstrel> gfgtdf: Well, not sure why you're asking me...
20170520 18:40:35< Ivanovic> i'm, currently running an emerge -e system and afterwards an emerge -e world
20170520 18:40:46< Ivanovic> afterwards i will switch to the latest boost again and retry
20170520 18:40:50< celticminstrel> gfgtdf: Did you see my question about string_view?
20170520 18:41:10< gfgtdf> celticminstrel: becasue you authored that fix, so you could know someting that i don't
20170520 18:41:14< gfgtdf> celticminstrel: no i didn't
20170520 18:41:32< celticminstrel> gfgtdf: The fix is pure Lua, so it should work on 1.13.8.
20170520 18:44:31< gfgtdf> celticminstrel: well in the worse case we can to some fixes to it, (manualy macro expansion (in particular BOOST_CXX14_CONSTEXPR))
20170520 18:47:12< gfgtdf> celticminstrel: actaully 9i think this needs to be done, but i can do that.
20170520 18:54:07< gfgtdf> hmm whe  i try to upload my addon it tells me 'if you continue your .pbl file will be unrecoverably lost'
20170520 18:56:40< gfgtdf> wait, it seems liek doubleckicking on an uploadable addons does not upload it but tries to install from the server , is this  aknown 1.13.7 bug ?
20170520 18:57:51< JyrkiVesterinen> Yes. That indeed happens in 1.13.7.
20170520 18:57:57< JyrkiVesterinen> I fixed it for 1.13.8.
20170520 18:59:14< gfgtdf> ok thx
20170520 19:05:07-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170520 19:05:13-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170520 19:11:53< loonycyborg> Ivanovic: https://gist.github.com/loonycyborg/6010c503f2074421b7d59e964d6b9d3e
20170520 19:12:01< loonycyborg> still getting this with 6.3
20170520 19:25:42-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170520 19:25:48-!- janebot [~Gambot@grickit.us] has joined #wesnoth-dev
20170520 19:25:58-!- janebot [~Gambot@grickit.us] has quit [Changing host]
20170520 19:25:58-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170520 19:32:36< vultraz_iOS> celticminstrel: https://github.com/wesnoth/wesnoth/pull/1713 alright to merge?
20170520 19:35:45< celticminstrel> vultraz_iOS: I was going to merge it immediately, but then I noticed he seems to have added a header, which is weird.
20170520 19:36:06< celticminstrel> I commented on it, but apparently accidentally clicked start review instead of add single comment.
20170520 19:36:56< vultraz_iOS> alright
20170520 19:37:11< vultraz_iOS> BTW, for 1.13.9 someone needs to fix the [not] performance regression
20170520 19:37:15< vultraz_iOS> s/regression/issue
20170520 19:37:34-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:2883:5ba7:abb6:90d7] has joined #wesnoth-dev
20170520 19:38:41< celticminstrel> I have no idea what you're talking about. Create/reference an issue?
20170520 19:39:07< vultraz_iOS> uhhh https://github.com/wesnoth/wesnoth/issues/1706 maybe
20170520 19:39:19< vultraz_iOS> the thing where terrain filters take a long time with [not]
20170520 19:41:29< celticminstrel> vultraz_iOS: From the comments, I don't see how that's related?
20170520 19:41:36< vultraz_iOS> ok not that then
20170520 19:41:42< vultraz_iOS> nevermind
20170520 19:41:50< vultraz_iOS> but you know the thing
20170520 19:41:52< vultraz_iOS> the bug
20170520 19:41:54< celticminstrel> If you create/find an issue, assign it to 1.13.9.
20170520 19:41:55< vultraz_iOS> with terrain filters
20170520 19:42:04< vultraz_iOS> gfgtdf knows what i mean
20170520 19:42:13< celticminstrel> Then get gfgtdf to create/find an issue.
20170520 19:42:21< celticminstrel> And assign it to the milestone.
20170520 19:47:53< gfgtdf> i don't know more thna this: 
20170520 19:48:00< gfgtdf> 20170515 21:36:53< SigurdFD> was that thing with a [not] being inefficent ever fixed?
20170520 19:48:05< gfgtdf> 20170515 22:44:21< gfgtdf> SigurdFD: what exactly do you mean ?
20170520 19:48:11< gfgtdf> 20170515 23:25:59< SigurdFD> gfgtdf: there was something a while back about use of the [not] tag in conditionals taking sigificantly longer than other conditionals
20170520 19:48:23< gfgtdf> that's all i know
20170520 19:50:20< Kwandulin> mattsc might know more about it: https://forums.wesnoth.org/viewtopic.php?p=611088#p611088
20170520 19:52:30< vultraz_iOS> gah
20170520 19:52:49< vultraz_iOS> i looked at the code in terrain filter and found that not was fetching all locations and removing the differences from the result
20170520 19:54:16< gfgtdf> ye but i think it did the same in 1.1 aswell
20170520 19:54:59< vultraz_iOS> and?
20170520 19:55:04< vultraz_iOS> it's bad
20170520 19:55:40< gfgtdf> so this cannot be the reason for  a perofrmance regression compared to 1.12
20170520 19:55:51< vultraz_iOS> still bad!
20170520 19:55:54< gfgtdf> 1.12 i meant
20170520 19:56:02< gfgtdf> but it probably aplies to 1.1 aswell
20170520 19:58:07< gfgtdf> vultraz_iOS: well i guess in some cases that bvahviiour coudl be faster than the more notural 'compare the [not] filter against all found locations' implmtation
20170520 19:58:29< gfgtdf> vultraz_iOS: for example in [not] find_in= varname [/not]
20170520 19:59:30-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:2883:5ba7:abb6:90d7] has quit [Remote host closed the connection]
20170520 19:59:33< gfgtdf> becasue tehn it can parse the variable varname directly intoa  location set and use that
20170520 20:00:03-!- JyrkiVesterinen [~JyrkiVest@87-100-205-108.bb.dnainternet.fi] has quit [Quit: .]
20170520 20:00:44< gfgtdf> vultraz_iOS: do you want to fix the 'that not was fetching all locations and removing the differences from the result' issue or shoudl i do it?
20170520 20:01:16-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170520 20:01:31< vultraz_iOS> which one?
20170520 20:04:13< gfgtdf> oh maybe the main reason why [not] currently fetches all location is that it needs to handle 'radius'
20170520 20:05:22-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170520 20:06:36-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170520 20:20:41< Ivanovic> loonycyborg: interesting
20170520 20:21:02< Ivanovic> i started emerge -e system and it is progressing well so far
20170520 20:21:04< Ivanovic> Emerging (372 of 390)
20170520 20:21:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170520 20:22:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170520 20:23:29-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170520 20:24:17< vultraz_iOS> gfgtdf: is there any reason this cannot come after calling run_wml_action which would prevent the copying of the config https://github.com/wesnoth/wesnoth/blob/master/src/game_events/handlers.cpp#L123-L129
20170520 20:37:15< Soliton> https://wiki.wesnoth.org/NotSoEasyCoding#Passphrase_hashing  this is done, right?
20170520 20:38:35< vultraz_iOS> celticminstrel did that yes
20170520 20:39:58< gfgtdf> vultraz_iOS: hmm not 100% sure but i think it's before in case that te event tried to fire itself , like [event] name=a [fire_event] name=a
20170520 20:39:58-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170520 20:40:24< vultraz_iOS> i see
20170520 20:41:23< gfgtdf> vultraz_iOS: mabe we coudl just copy 'handler_p' since it is a shared pointer to this, at the beginning of that function
20170520 20:41:38< gfgtdf> vultraz_iOS: but i somehwo remember that i tied that already and tht it for some reason failed
20170520 20:42:08< vultraz_iOS> because of the way handler_list is implemented
20170520 20:42:37< vultraz_iOS> or maybe not
20170520 20:42:53< vultraz_iOS> perhaps it's because then you'd only be invalidating the local variable
20170520 20:42:58< vultraz_iOS> meaning the parent event still exists
20170520 20:45:38< gfgtdf> vultraz_iOS: i think it's becasue that code uses weak_ptr::expired() to check wheterh an event is erased , so that having a local shared_ptr to that object will make auotmaticalyl preven tit from expireing
20170520 20:46:40< gfgtdf> vultraz_iOS: this coudl be fixed by havign a new bool event_handler::disabled member and use that when for an additional check.
20170520 20:48:51-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170520 20:52:32< celticminstrel> Soliton, vultraz_iOS: I think shadowm did that actually.
20170520 20:53:25< irker155> wesnoth: Charles Dang wesnoth:master 79ffbbe9b4da / src/ (21 files in 6 dirs): Game Events: include manager in pump header to avoid having its include in so ma https://github.com/wesnoth/wesnoth/commit/79ffbbe9b4da8f18de4a597f54d32828122f94aa
20170520 20:53:47< celticminstrel> But maybe ask him to be sure.
20170520 20:54:19< vultraz_iOS> "Generic tab_container widget"
20170520 20:54:23< vultraz_iOS> oh yeah i wanted to do this...
20170520 20:55:07< vultraz_iOS> we need to update this page
20170520 20:55:09< celticminstrel> It could be a composite widget using stacked_widget and a horizontal_listbox?
20170520 20:55:10< vultraz_iOS> remove the SDL2 stuff
20170520 20:55:13< celticminstrel> Or maybe even grid_listbox.
20170520 20:58:14< vultraz_iOS> the problem was forwarding the data
20170520 21:02:57< vultraz_iOS> hm
20170520 21:03:05< vultraz_iOS> maybe i should have done that commit the other way round
20170520 21:03:07< vultraz_iOS> around
20170520 21:32:26-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170520 21:40:00-!- sevu [~Shiki@p54854243.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170520 22:13:01-!- Kwandulin [~Kwandulin@p200300760F6D807A4D2379FF42A171CC.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170520 22:16:07-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Read error: Connection reset by peer]
20170520 22:20:41-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170520 22:26:36-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20170520 22:45:47-!- mjs-de [~mjs-de@x4e31d462.dyn.telefonica.de] has quit [Ping timeout: 268 seconds]
20170520 22:55:04< irker155> wesnoth: Charles Dang wesnoth:master a25f3d39f039 / src/game_events/ (pump.cpp pump.hpp): Game Events: reformatted pump code https://github.com/wesnoth/wesnoth/commit/a25f3d39f0394f385d626b753588e0007ebf428e
20170520 23:00:40< gfgtdf> vultraz_iOS: see https://github.com/wesnoth/wesnoth/issues/1709#issuecomment-302903128
20170520 23:01:01< gfgtdf> vultraz_iOS: your comit to use std::put_time seems to have borken translations
20170520 23:01:34< vultraz_iOS> god DAMMIT
20170520 23:02:13-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170520 23:02:23-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20170520 23:03:22< vultraz_iOS> i don't know why, though
20170520 23:03:25< vultraz_iOS> imbue is called
20170520 23:04:05< celticminstrel> Is that true?
20170520 23:04:11< celticminstrel> That it broke translations.
20170520 23:04:21< celticminstrel> Did someone do a bisect or something and prove it was that commit?
20170520 23:04:30< vultraz_iOS> well if he forcibly uses the boost path it works
20170520 23:04:46< celticminstrel> Also, why do I hear people (including gfgtdf) say it actually does work?
20170520 23:05:36< gfgtdf> celticminstrel: i'm using the offical windows release, probably it has HAVE_PUT_TIME = 0, loonycyborg might know exactly.
20170520 23:06:02< vultraz_iOS> I hate crap like this
20170520 23:07:22< loonycyborg> translations broken how exactly?
20170520 23:07:39< vultraz_iOS> if the std::put_time path is called
20170520 23:08:10< vultraz_iOS> hmm
20170520 23:08:30< vultraz_iOS> I wonder if it has to do with the fact that the format_string is marked translatable in format_time_summary
20170520 23:09:27< vultraz_iOS> prettyy sure they shouldn't be
20170520 23:10:26< gfgtdf> loonycyborg: dates are not trsnlated as observed at https://github.com/wesnoth/wesnoth/issues/1709
20170520 23:11:10< loonycyborg> anyway I didn't do any intentional changes wrt time localization
20170520 23:12:01< gfgtdf> loonycyborg: which gcc version do the releases use ?
20170520 23:12:12< loonycyborg> so if there are differences in official binary then they would be caused either by using mingw
20170520 23:12:23< gfgtdf> loonycyborg: the code has, '#define HAVE_PUT_TIME (__GNUC__ >= 5)'
20170520 23:12:24< loonycyborg> or using different boost.locale settings
20170520 23:12:44< gfgtdf> loonycyborg: no the officail release works, but sevus buid doesn't
20170520 23:13:04< gfgtdf> build*
20170520 23:13:13< loonycyborg> not sure
20170520 23:13:25< loonycyborg> need to double check
20170520 23:16:05-!- stikonas_ is now known as stikonas
20170520 23:17:17< loonycyborg> gfgtdf: 5.1.0
20170520 23:18:42< gfgtdf> loonycyborg: hmm interesting.
20170520 23:18:57< gfgtdf> so it would use HAVE_PUT_TIME
20170520 23:19:33< gfgtdf> loonycyborg: thx
20170520 23:46:07-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 260 seconds]
--- Log closed Sun May 21 00:00:58 2017