--- Log opened Sun May 21 00:00:58 2017
20170521 00:14:55-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170521 00:15:07-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Client Quit]
20170521 00:24:54< vultraz_iOS> I wonder why forward_list doesn't have erase
20170521 00:24:58< vultraz_iOS> but does have erase_after
20170521 00:26:03< vultraz_iOS> seems weird
20170521 00:26:51< celticminstrel> Is SFINAE broken in MSVC 2013 or do I just not understand how it's supposed to work?
20170521 00:27:10< vultraz_iOS> ?
20170521 00:27:45< celticminstrel> It's trying to use my varargs template as the copy constructor even though that can't work.
20170521 00:28:35< celticminstrel> Seemingly because the argument is config& instead of const config&.
20170521 00:28:43< celticminstrel> (Or config&&)
20170521 00:30:56< vultraz_iOS> well jyrki did say 2013 had some SFINAE problems
20170521 00:36:16< celticminstrel> Okay so the syntax is config{key, value, key, value, key, value, tag, config{...}, tag, config{...}} etc.
20170521 00:36:21< celticminstrel> Acceptable?
20170521 00:36:50< celticminstrel> (I got past the SFINAE issue by making the first argument not a template argument, since it's known it has to be a string no matter what.)
20170521 00:41:08< gfgtdf> celticminstrel: i'd expect a std::map-like syntax (config{{key, value}, {key, value}, {key, value}, {tag, config{...}}, {tag, config{...}}} )
20170521 00:41:50< celticminstrel> TBH that's probably not significantly more difficult... vultraz?
20170521 00:44:07< vultraz_iOS> i'd expect a map like syntax
20170521 00:44:10< vultraz_iOS> it's clearer to read
20170521 00:56:05-!- gfgtdf [~chatzilla@x50ab6cb3.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20170521 01:09:43< irker155> wesnoth: Celtic Minstrel wesnoth:variadic_config_ctor 999ae9661388 / src/ (config.cpp config.hpp): Implement variadic initializer list for config class https://github.com/wesnoth/wesnoth/commit/999ae9661388840326b2e849b7517b8a25891494
20170521 01:09:44< celticminstrel> Maybe someone can help me figure out why that doesn't work. ^
20170521 01:09:45< irker155> wesnoth: Celtic Minstrel wesnoth:variadic_config_ctor a43a5283e62c / src/ (config.cpp config.hpp): Make syntax more map-like (not working yet) https://github.com/wesnoth/wesnoth/commit/a43a5283e62c226812aee43b8e0909889f37c1b5
20170521 01:09:50< celticminstrel> Sorry, that one ^
20170521 01:10:09< celticminstrel> The first one does work. Half-inclined to just use it instead of the broken second one.
20170521 01:10:16< celticminstrel> (Would be interesting if it passed Travis though.)
20170521 01:11:05< vultraz_iOS> ok, i have a replacement for handler_list
20170521 01:11:20< vultraz_iOS> I've made the change as least invasive as possible
20170521 01:11:27< celticminstrel> You're going to just ignore my recommendation and push it anyway, aren't you.
20170521 01:11:27< vultraz_iOS> will push to branch for review
20170521 01:11:33< celticminstrel> Hmm, okay.
20170521 01:17:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170521 01:18:26< irker155> wesnoth: Charles Dang wesnoth:event_handler_list_refactor 865be6d6b267 / src/game_events/ (6 files): Game Events: throw out custom handler_list implementation https://github.com/wesnoth/wesnoth/commit/865be6d6b267852a13446439e517c1fb34ccb0f7
20170521 01:18:52-!- sevu [~Shiki@p54854243.dip0.t-ipconnect.de] has quit [Quit: Verlassend]
20170521 01:19:07< vultraz_iOS> going to make it a pr so it can get reviews
20170521 01:24:06< vultraz_iOS> celticminstrel: why would i push such a thing directly to master, anyway
20170521 01:39:59-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170521 02:02:12-!- gfgtdf [~chatzilla@x4e3639c0.dyn.telefonica.de] has joined #wesnoth-dev
20170521 02:02:28< gfgtdf> vultraz_iOS: i'm quite sute that  Ja-MiT isn't active anymore
20170521 02:03:16< vultraz_iOS> gfgtdf: he commented on https://github.com/wesnoth/wesnoth/commit/3f584e2435eaf9a7a4b90c2dc34e18ffc7eaa943#commitcomment-19788070 recently 
20170521 02:03:28< vultraz_iOS> 15 days ago in fact
20170521 02:03:43< gfgtdf> oh really
20170521 02:04:21< vultraz_iOS> ya
20170521 02:04:50< vultraz_iOS> since we've been discussing it and he implemented handler_list originally i wanted his feedback
20170521 02:04:59< vultraz_iOS> tbh my code almost seems too simple
20170521 02:10:22< celticminstrel> vultraz_iOS: I dunno why you would push such a thing directly to master.
20170521 02:10:42< celticminstrel> vultraz_iOS, gfgtdf Pretty sure Ja-MiT is indeed inactive, his recent comment notwithstanding.
20170521 02:15:38-!- gfgtdf [~chatzilla@x4e3639c0.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 53.0.2/20170504105526]]
20170521 02:16:05< celticminstrel> Also vultraz_iOS: The reason forward_list has erase_after instead of erase is because of how erase works.
20170521 02:16:15< celticminstrel> The erase function removes the pointed-to element from the list.
20170521 02:16:44< celticminstrel> For a singly-linked list, this operation is impossible, because for all intents and purposes, a pointer to an element in the list is equivalent to a list that begins at that element.
20170521 02:17:37< celticminstrel> Removing an element from a doubly-linked list is basically...
20170521 02:18:10< celticminstrel> p->prev->next = p->next; p->next->prev = p->prev.
20170521 02:18:20< celticminstrel> But a singly-linked list has no prev.
20170521 02:18:55< celticminstrel> So you can't remove the current element, but you can remove the next element with p->next = p->next->next.
20170521 02:19:45-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170521 02:20:46< celticminstrel> (p in this example is an instance of template<typename T> struct node {T val; node* next; node* prev;}; for a doubly-linked list.)
20170521 02:21:37< vultraz_iOS> i see
20170521 02:23:16< celticminstrel> I don't think there are many reasons to use forward_list, at least in Wesnoth.
20170521 02:49:06-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:2883:5ba7:abb6:90d7] has joined #wesnoth-dev
20170521 02:59:15-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:2883:5ba7:abb6:90d7] has quit [Remote host closed the connection]
20170521 03:20:57-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170521 03:22:40-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170521 03:39:03< celticminstrel> BTW vultraz_iOS, if the implementation needs back-insertion but does not need front-insertion, then it totally could've been a forward_list. (I wouldn't do that anyway, but it could be done.)
20170521 03:39:41< vultraz_iOS> yes, that is so.
20170521 03:40:48< celticminstrel> Every time I see remove_if I think "That's not right! Oh wait it's list::remove_if not std::remove_if".
20170521 03:41:00< vultraz_iOS> indeed
20170521 03:42:08< celticminstrel> So I assume you tested that events still fire and everything? :P
20170521 03:43:13< celticminstrel> And that it's still safe for an event to remove itself?
20170521 03:43:25< celticminstrel> (Which is the default behaviour even.)
20170521 03:45:00< vultraz_iOS> i did, but only to the extent of launching DiD and recruiting a WC to see if the event fired
20170521 03:45:08< vultraz_iOS> I can play around in the test scenario a bit
20170521 03:45:14< vultraz_iOS> see that nothing explodes
20170521 03:45:28< celticminstrel> TBH I'm not sure what would be sufficient testing, but if you have time, then sure.
20170521 03:45:50< vultraz_iOS> I assume you have no objection to the substance of the commit?
20170521 03:46:15< celticminstrel> Well, I didn't look super-closely, but nothing seemed obviously out-of-place.
20170521 03:46:48< celticminstrel> Something bugs me about lock_ptr but that's just stylistic.
20170521 03:48:22< vultraz_iOS> ill wait and see what tad and possibly jamit say
20170521 03:49:20< vultraz_iOS> what puzzles me is that jamit seemed to make it sound like using an std::list would somehow be overly complicated
20170521 03:49:35< vultraz_iOS> yet that seems not to be so
20170521 03:50:04< celticminstrel> Unless there's something you're missing.
20170521 03:50:11< vultraz_iOS> indeed
20170521 03:50:30< celticminstrel> On the other hand, when that was written, it was C++03, right?
20170521 03:50:41< celticminstrel> Although it did have Boost...
20170521 03:51:07< celticminstrel> I didn't look at the deleted code, was it already using weak_ptr internally?
20170521 03:51:26< vultraz_iOS> yes
20170521 03:51:43< celticminstrel> Still, it's theoretically possible that the language standard version makes a difference.
20170521 03:51:43< vultraz_iOS> it was originally using boost::weak_ptr when it was added in 2014.
20170521 03:53:17< vultraz_iOS> well travis is not happy
20170521 03:53:28< vultraz_iOS> let
20170521 03:53:31< vultraz_iOS> s see why..
20170521 03:53:34< celticminstrel> That reminds me, I was going to see if Travis liked the config thing.
20170521 03:53:59< vultraz_iOS> no
20170521 03:54:18< celticminstrel> Maybe its error messages will be more enlightening than MSVC's? >_>
20170521 03:54:46< vultraz_iOS> well yours failed almost immediately
20170521 03:54:52< celticminstrel> The opposite, apparently.
20170521 03:54:57< celticminstrel> Less enlightening.
20170521 03:55:27< vultraz_iOS> two tests failed..
20170521 03:55:30< vultraz_iOS> on my branch
20170521 03:55:38< celticminstrel> Oh right, ambiguous thingamabob.
20170521 03:55:46< vultraz_iOS> urecruit_facing_enemy_two  and urecruit_facing_leader 
20170521 03:57:09< vultraz_iOS> wat
20170521 03:57:11< vultraz_iOS> 20170521 02:29:56 warning wml: The following conditional test failed:
20170521 03:57:12< vultraz_iOS> 	[variable]
20170521 03:57:12< vultraz_iOS> 		equals=n
20170521 03:57:12< vultraz_iOS> 		name=unit.facing
20170521 03:57:12< vultraz_iOS> 	[/variable]
20170521 03:57:12< vultraz_iOS> 	Note: The variable unit.facing currently has the value "s".
20170521 03:57:32< vultraz_iOS> how is this related to my changes at all..
20170521 03:57:48< vultraz_iOS> well, there is a25f3d3 which i didn't run travis ons ince it was just formatting
20170521 03:57:56< vultraz_iOS> don't see how that could have caused it
20170521 03:59:45< vultraz_iOS> i see...
20170521 04:00:01< vultraz_iOS> well..
20170521 04:00:03< vultraz_iOS> hm
20170521 04:00:50< vultraz_iOS> where is this test..
20170521 04:02:55< irker155> wesnoth: Celtic Minstrel wesnoth:variadic_config_ctor ccc96e785f07 / src/config.hpp: Fixup for ambiguities https://github.com/wesnoth/wesnoth/commit/ccc96e785f07139fe990082518189652ca2b784c
20170521 04:03:39< vultraz_iOS> ok found it
20170521 04:03:54< vultraz_iOS> i could see how my change might have affected this, but in which case i'd have expected them all to fail
20170521 04:08:10< vultraz_iOS> ok yeah it's something weird in my change
20170521 04:08:34< celticminstrel> Link?
20170521 04:09:54< vultraz_iOS> the contents of the variable are the ones that are supposed to be next turn
20170521 04:10:24< vultraz_iOS> so ie you have name=side 1 turn 2 refresh checking for n and name=side 1 turn 3 refresh checking for s but in the former case he's already s
20170521 04:10:44< vultraz_iOS> ;_;
20170521 04:11:00< celticminstrel> I meant link to the thing you think could have affected it.
20170521 04:12:45< vultraz_iOS> wellll... not sure
20170521 04:13:12< vultraz_iOS> though just to eliminate something
20170521 04:13:14< vultraz_iOS> is 
20170521 04:13:14< vultraz_iOS> var_ptr = *++var_it_;
20170521 04:13:18< vultraz_iOS> different from
20170521 04:13:22< vultraz_iOS> var_ptr = lock_ptr(var_list_, ++var_it_);
20170521 04:13:36< vultraz_iOS> (ie, will the iter be bumped first in both cases?)
20170521 04:14:27< celticminstrel> By "first" you mean "before dereferencing"?
20170521 04:14:42< vultraz_iOS> yes
20170521 04:15:01< celticminstrel> Obviously. All subexpressions are fully evaluated before executing an expression.
20170521 04:15:13< vultraz_iOS> alright
20170521 04:15:16< vultraz_iOS> good
20170521 04:15:17< vultraz_iOS> not that, then
20170521 04:15:35< celticminstrel> In this case, it's "all function arguments (and the function itself) are evaluated before calling the function".
20170521 04:15:51< vultraz_iOS> hmm
20170521 04:15:57< vultraz_iOS> actually, i have one other idea
20170521 04:16:11< vultraz_iOS> certain iterators are assigned in the ctor list
20170521 04:16:20< vultraz_iOS> for manager::iteration
20170521 04:16:25< vultraz_iOS> then the handler lists are cleaned up
20170521 04:16:25< celticminstrel> ?
20170521 04:16:37< vultraz_iOS> it's *possible* that invalidates some iterators?
20170521 04:17:08< celticminstrel> IIRC, the only thing that invalidates a list iterator is removing the element it points to from the list.
20170521 04:17:24< vultraz_iOS> yes
20170521 04:17:43< celticminstrel> ...I wonder if a list iterator is effectively just a pointer to a node...
20170521 04:17:43< vultraz_iOS> wonder why all the other facing tests passed..
20170521 04:18:43< vultraz_iOS> that's the weird thing
20170521 04:18:47< vultraz_iOS> all the other facing tests passed
20170521 04:19:09< vultraz_iOS> i doubt it's a travis fluke, though
20170521 04:24:56< vultraz_iOS> ya know what
20170521 04:25:03< vultraz_iOS> i will restart the build to eliminate the possibility
20170521 04:25:11< celticminstrel> Good, good.
20170521 04:25:28< vultraz_iOS> *scientific method intensifies*
20170521 04:25:32< celticminstrel> (Mind you, if it's a Travis fluke, the fluke could still happen twice. >_> )
20170521 04:27:14< vultraz_iOS> Actually just realized since it's on all builds it's not a fluke. Derp.
20170521 04:28:10< vultraz_iOS> yup,same issues
20170521 04:34:45< vultraz_iOS> Actually I have another idea
20170521 04:34:51< vultraz_iOS> Hm..
20170521 04:35:26< vultraz_iOS> Could it be the index variables get out of sync?
20170521 04:36:07< vultraz_iOS> Since the smart list ensured the handlers were never actually removed if you did something by index it would maintain order... I think
20170521 04:36:23< vultraz_iOS> Ponder ponder...
20170521 04:37:26< vultraz_iOS> I shall have to look at this
20170521 05:04:56-!- JyrkiVesterinen [~JyrkiVest@87-100-192-247.bb.dnainternet.fi] has joined #wesnoth-dev
20170521 05:31:02< JyrkiVesterinen> 20170521 00:26:51< celticminstrel> Is SFINAE broken in MSVC 2013 or do I just not understand how it's supposed to work?
20170521 05:31:28< JyrkiVesterinen> A subset of SFINAE, called "expression SFINAE", isn't implemented in VS2013 and VS2015 RTM.
20170521 05:32:05< JyrkiVesterinen> VS2015 Update 1 and VS2017 don't have a full expression SFINAE implementation either. They have just enough to get STL to build.
20170521 05:33:12< JyrkiVesterinen> See http://stackoverflow.com/questions/12654067/what-is-expression-sfinae
20170521 05:33:16< celticminstrel> Somewhat related: Do you know why this gives C2440 "cannot convert from initializer_list to config; no constructor could take the source type, or constructor overload resolution was ambiguous"? https://github.com/wesnoth/wesnoth/commit/a43a5283e62c226812aee43b8e0909889f37c1b5
20170521 05:34:41< JyrkiVesterinen> Instead of trying to figure that out, I have a suggestion: why not just add a constructor from std::initializer_list?
20170521 05:35:04< celticminstrel> Isn't that impossible?
20170521 05:35:20< celticminstrel> std::initializer_list is homogenous, while this is heterogeneous.
20170521 05:36:06< celticminstrel> If I can't get that commit to work though, I'm inclined to go with the version from the previous commit.
20170521 05:36:38< celticminstrel> But vultraz_iOS and gfgtdf both said they'd prefer a map-like syntax.
20170521 05:46:01< JyrkiVesterinen> Okay, I think you essentially answered your own question.
20170521 05:46:08< JyrkiVesterinen> C++11, §8.5.4.5:
20170521 05:46:11< JyrkiVesterinen> "An object of type std::initializer_list<E> is constructed from an initializer list as if the implementation
20170521 05:46:11< JyrkiVesterinen> allocated an array of N elements of type E, where N is the number of elements in the initializer list."
20170521 05:46:41< JyrkiVesterinen> List initialization *always* creates an initializer list, even if the constructor doesn't take such a parameter.
20170521 05:47:16< JyrkiVesterinen> Which means that types used in list initialization can't be heterogeneous.
20170521 05:47:31< celticminstrel> But pair{a, b} works just fine.
20170521 05:48:48< celticminstrel> And so does the parent commit of that one.
20170521 05:49:11< celticminstrel> Where config{...} is clearlt equivalent to config(...)
20170521 05:49:15< celticminstrel> ^clearly
20170521 05:52:13-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170521 05:52:34< JyrkiVesterinen> Hmm. You're right. pair<A, B> = {a, b} would be list initialization, but pair<A, B>{a, b} isn't.
20170521 05:55:03< JyrkiVesterinen> Try changing the constructor to this:
20170521 05:55:23< JyrkiVesterinen> explicit config(std::pair<const char*, T>&&... args);
20170521 05:55:54-!- Kwandulin [~Kwandulin@p200300760F6D807A4D2379FF42A171CC.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170521 05:55:54< JyrkiVesterinen> I think you may not be getting implicit conversion from const char* to boost::string_view.
20170521 05:57:08< celticminstrel> Doesn't help. :(
20170521 05:58:22< JyrkiVesterinen> Hm. Next thing that comes to my mind is whether the parameter pack is unpacked properly, i.e. whether T means a different type for each parameter or not.
20170521 05:59:28< JyrkiVesterinen> You could also attempt to specify the types explicitly:
20170521 05:59:39< celticminstrel> Hm?
20170521 05:59:43< JyrkiVesterinen> config cfg1<int>{{"key", 5}};
20170521 05:59:47< celticminstrel> Oh.
20170521 06:03:02< celticminstrel> I see what you're suggesting, but not sure how to make it work since AFAIK there's no way to pass explicit template arguments to a template constructor.
20170521 06:07:21< JyrkiVesterinen> I have run out of ideas. :| I think it would be best to just return to the earlier syntax.
20170521 06:26:40< Kwandulin> Whee, when accidently putting a [message] in a prestart event, Wesnoth stops working
20170521 06:26:49< celticminstrel> Oh my.
20170521 06:43:32-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170521 06:52:53< celticminstrel> Kwandulin: What about a message during setup?
20170521 06:53:06< celticminstrel> ie from a [lua] tag directly within [scenario]
20170521 06:53:07< zookeeper> that doesn't seem to happen with my build that's a week-and-a-half old.
20170521 06:53:30< celticminstrel> zookeeper: The [message] thing?
20170521 06:53:43< zookeeper> of course
20170521 06:53:48< celticminstrel> What commit?
20170521 06:53:56< zookeeper> what?
20170521 06:54:05< celticminstrel> What commit is your build on?
20170521 06:54:16< celticminstrel> "git describe HEAD" for example.
20170521 06:54:23< celticminstrel> Or was it rev-parse.
20170521 06:54:33< celticminstrel> "git rev-parse HEAD"
20170521 06:54:52< celticminstrel> RIght, describe is the opposite IIRC; given a hash, output a ref-name if it exists.
20170521 06:55:12< zookeeper> i wouldn't know how to check.
20170521 06:55:30< celticminstrel> Git can tell you.
20170521 06:55:46< celticminstrel> I don't know if you use command-line or a client; if the latter, look at the commit log.
20170521 06:55:56< zookeeper> it can't tell me what commit my unversioned binary file just happens to be built from
20170521 06:56:05< celticminstrel> Hmm?
20170521 06:56:13< Kwandulin> Mhh, right, doesn't seems like it is [message], must be something out from a bigger wml block. I
20170521 06:56:16< Kwandulin> I'll check
20170521 06:56:37< celticminstrel> You're saying that the build is on a copy of wesnoth outside version control?
20170521 06:56:58< zookeeper> ...no, i'm saying that obviously git doesn't know which commit my wesnoth.exe was built from over a week ago
20170521 06:57:09< celticminstrel> Ohhh, I get it.
20170521 06:57:13< Kwandulin> Must be [animate_unit] then
20170521 06:57:20< celticminstrel> Can Wesnoth itself tell you, like in the version dialog?
20170521 06:57:25< zookeeper> nah, i checked
20170521 06:57:39< celticminstrel> Ah, okay.
20170521 06:57:45< celticminstrel> Oh well?
20170521 06:58:17< celticminstrel> Kwandulin: So what happened, did it just crash?
20170521 06:58:31< Kwandulin> Stops reacting
20170521 06:59:07< Kwandulin> Pressing escape works after like 10 seconds
20170521 06:59:14< celticminstrel> Hmm.
20170521 07:01:09< celticminstrel> So you can escape back to menu?
20170521 07:01:15< celticminstrel> But if you wait, nothing happens?
20170521 07:01:34< celticminstrel> (Though I'd understand if you don't want to try waiting.)
20170521 07:02:02< celticminstrel> If it's [animate_unit] I wonder if it could be related to the "animation never stops" hang that I accidentally introduced locally awhile back.
20170521 07:02:32< celticminstrel> But, ideally I guess [animate_unit] should know not to function during prestart... not quite sure if that's possible.
20170521 07:02:50-!- celticminstrel is now known as celmin|sleep
20170521 07:04:15< Kwandulin> If I wait, nothing happens. That's how it looks like: https://www.dropbox.com/s/cp5dh001spb5ccu/animate.png?dl=0
20170521 07:04:35< Kwandulin> It looks like it is not loading, the loading bar doesn't move
20170521 07:04:58< Kwandulin> And if I tab out of BfW, I can't enter it again
20170521 07:27:09-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170521 07:49:58-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170521 07:51:18< irker155> wesnoth: Charles Dang wesnoth:event_handler_list_refactor f07fd319b8b1 / src/game_events/manager.cpp: test a thing https://github.com/wesnoth/wesnoth/commit/f07fd319b8b18599e5f97edab010f01067669755
20170521 07:53:12-!- Appleman1234 [~quassel@pl22492.ag1212.nttpc.ne.jp] has quit [Read error: Connection reset by peer]
20170521 07:55:51-!- Appleman1234 [~quassel@pl22492.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170521 08:39:57-!- Kwandulin [~Kwandulin@p200300760F6D807A4D2379FF42A171CC.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170521 08:49:01-!- mjs-de [~mjs-de@x4db5d39c.dyn.telefonica.de] has joined #wesnoth-dev
20170521 08:52:06< vultraz_iOS> interesting
20170521 08:52:36< vultraz_iOS> travis passes now
20170521 08:52:42< vultraz_iOS> my suspicions were correct
20170521 08:56:35< vultraz_iOS> indexes are off.
20170521 09:16:10-!- Kwandulin [~Kwandulin@p200300760F6D807A4D2379FF42A171CC.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170521 09:19:48-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Ping timeout: 260 seconds]
20170521 09:25:59-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170521 09:38:53-!- mjs-de [~mjs-de@x4db5d39c.dyn.telefonica.de] has quit [Ping timeout: 272 seconds]
20170521 09:39:43-!- mjs-de [~mjs-de@x4db5d39c.dyn.telefonica.de] has joined #wesnoth-dev
20170521 09:46:23-!- JyrkiVesterinen [~JyrkiVest@87-100-192-247.bb.dnainternet.fi] has quit [Quit: .]
20170521 10:04:17< vultraz_iOS> ok, so I can either correct the indexes or remove the indexes
20170521 10:18:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170521 10:51:38-!- irker155 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170521 10:52:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170521 10:52:30-!- mjs-de [~mjs-de@x4db5d39c.dyn.telefonica.de] has quit [Remote host closed the connection]
20170521 10:52:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170521 10:54:17-!- sevu [~Shiki@p54856219.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170521 11:18:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170521 11:19:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170521 11:34:18-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170521 11:43:52-!- abruanese [U2FsdGVkX1@ma.sdf.org] has quit [Read error: Connection reset by peer]
20170521 11:48:47-!- sevu [~Shiki@p54856219.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20170521 11:48:57-!- JyrkiVesterinen [~JyrkiVest@87-100-192-247.bb.dnainternet.fi] has joined #wesnoth-dev
20170521 12:13:32-!- Duthlet [~Duthlet@dslb-188-106-028-224.188.106.pools.vodafone-ip.de] has joined #wesnoth-dev
20170521 12:14:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170521 12:14:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170521 12:24:32-!- Kwandulin [~Kwandulin@p200300760F6D807A4D2379FF42A171CC.dip0.t-ipconnect.de] has quit [Ping timeout: 245 seconds]
20170521 12:26:04-!- ggeneral [~ggeneral@48.175.47.77.pptp.ntu-kpi.kiev.ua] has joined #wesnoth-dev
20170521 12:30:57-!- Kwandulin [~Kwandulin@2003:76:f6d:8011:1425:3f76:3ad3:5556] has joined #wesnoth-dev
20170521 12:50:10-!- sevu [~Shiki@141.57.63.75] has joined #wesnoth-dev
20170521 13:02:02-!- louis94 [~~louis94@95.129-200-80.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20170521 13:05:10-!- Kwandulin [~Kwandulin@2003:76:f6d:8011:1425:3f76:3ad3:5556] has quit [Read error: Connection reset by peer]
20170521 13:08:50-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20170521 13:19:05-!- louis94 [~~louis94@95.129-200-80.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 240 seconds]
20170521 13:23:46-!- louis94 [~~louis94@95.129-200-80.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20170521 13:33:31-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20170521 13:51:05-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170521 13:53:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 246 seconds]
20170521 14:05:17-!- celmin|sleep is now known as celticminstrel
20170521 14:09:54< vultraz_iOS> hmmmmmm
20170521 14:10:00< vultraz_iOS> ok it's not the indexes per-se..
20170521 14:10:30< celticminstrel> Frankly, I suggest you stop working on this (for now) and go work on actually fixing some bugs.
20170521 14:12:49< vultraz_iOS> ahhh
20170521 14:12:53< vultraz_iOS> *of course*
20170521 14:13:20< vultraz_iOS> yes, this is a major design flaw.
20170521 14:14:00-!- sevu [~Shiki@141.57.63.75] has quit [Remote host closed the connection]
20170521 14:14:37-!- sevu [~Shiki@141.57.63.75] has joined #wesnoth-dev
20170521 14:16:15-!- Kwandulin [~Kwandulin@p200300760F6D801114253F763AD35556.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170521 14:19:41-!- louis94 [~~louis94@95.129-200-80.adsl-dyn.isp.belgacom.be] has quit [Quit: Konversation terminated!]
20170521 14:26:05-!- sevu [~Shiki@141.57.63.75] has quit [Quit: Verlassend]
20170521 14:29:30< celticminstrel> Especially since you're running up against unexpected difficulties, vultraz_iOS, I suggest just dropping it for the time being.
20170521 14:29:39< vultraz_iOS> I have two solutions
20170521 14:29:50< celticminstrel> Yeah, so?
20170521 14:30:30< vultraz_iOS> a "proper" solution which would be more invasive and offer more possibility for breakage or a "it just works" solution that (should) Just Work.
20170521 14:31:19< vultraz_iOS> basically, just remove the cleanup code
20170521 14:31:24-!- irker979 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170521 14:31:24< irker979> wesnoth: Charles Dang wesnoth:event_handler_list_refactor f96918b2a14a / src/game_events/manager.cpp: Re-add validation check https://github.com/wesnoth/wesnoth/commit/f96918b2a14a900f00b79c36c98d221a68bfa275
20170521 14:31:45< celticminstrel> I think you're entirely missing the point.
20170521 14:31:54< celticminstrel> Okay, so about the config initializer...
20170521 14:32:07< celticminstrel> I can't figure out how to make the map-like syntax work.
20170521 14:32:13< vultraz_iOS> I see
20170521 14:33:14< irker979> wesnoth: Charles Dang wesnoth:master d9293c03bee4 / src/.clang-format: Clang Format: added SpaceAfterTemplateKeyword (disabled) https://github.com/wesnoth/wesnoth/commit/d9293c03bee446c9831a60c2869334204e4725d4
20170521 14:33:39< vultraz_iOS> celticminstrel: what was the other syntax again?
20170521 14:34:18< celticminstrel> config{"key1", value1, "key2", value2, "tag", config{...}, ...}
20170521 14:34:29< vultraz_iOS> I see
20170521 14:34:30< celticminstrel> Though you can use parentheses instead of braces if you prefer.
20170521 14:34:49< vultraz_iOS> eh, it's acceptable enough
20170521 14:34:52< vultraz_iOS> deploy it
20170521 14:34:54< celticminstrel> Okay.
20170521 14:35:09< celticminstrel> Want me to use braces or parentheses?
20170521 14:36:19< vultraz_iOS> parens might look cleaner but braces make it clear it's initializer list-like, so...
20170521 14:36:23< vultraz_iOS> probably braces
20170521 14:36:44< vultraz_iOS> (probably should use config { instead of config{ , though)
20170521 14:37:39< celticminstrel> Well, I prefer not having the space there, but if you prefer having it I'll try to remember.
20170521 14:37:56< vultraz_iOS> i assume you're converting config_of?
20170521 14:38:02< celticminstrel> Presumably.
20170521 14:40:26< vultraz_iOS> (reason I suggest T { is I've been writing it that way in most places so it's more consistent) 
20170521 14:41:12< vultraz_iOS> anyway, i think il put this events thing aside for awhile
20170521 14:42:51-!- deathisundead [~quassel@c-73-144-114-234.hsd1.mi.comcast.net] has joined #wesnoth-dev
20170521 14:42:51-!- deathisundead [~quassel@c-73-144-114-234.hsd1.mi.comcast.net] has quit [Changing host]
20170521 14:42:53-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20170521 14:44:50-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170521 14:45:03-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170521 14:48:21< celticminstrel> I wonder if we should have a Mac CMake build.
20170521 14:48:32-!- ggeneral [~ggeneral@48.175.47.77.pptp.ntu-kpi.kiev.ua] has left #wesnoth-dev []
20170521 14:48:44< celticminstrel> The only problem with adding more Mac builds is that they take longer than the Linux builds.
20170521 14:55:45< vultraz_iOS> don't know why we have so many linux builds
20170521 14:56:01-!- sevu [~Shiki@p54856219.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170521 15:01:20< irker979> wesnoth: Severin Glöckner wesnoth:master a278ad4c0a6d / data/core/ (13 files in 2 dirs): Instead of having the south set of images for the wail animation being upside-do https://github.com/wesnoth/wesnoth/commit/a278ad4c0a6d32e505b164ac2b864b4f4bf57f4d
20170521 15:03:21< celticminstrel> ...huh? I thought I said that Mac CMake PR can be merged when Travis passes, but I don't see that in the log.
20170521 15:03:30< celticminstrel> vultraz_iOS: ^
20170521 15:03:57< celticminstrel> Did I say it somewhere else?
20170521 15:04:35< celticminstrel> Anyway, I guess the reason for the number of Linux builds is to test both build systems with both compilers.
20170521 15:04:58< celticminstrel> So by that argument, there should be two more Mac builds.
20170521 15:06:24< vultraz_iOS> did you?
20170521 15:06:26< vultraz_iOS> i don't remember
20170521 15:06:35< celticminstrel> Well I'm saying it now.
20170521 15:35:07< Ivanovic> loonycyborg: after a full system rebuild wesnoth does build with boost-1.63
20170521 15:35:10< Ivanovic> strange one...
20170521 15:46:04-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170521 15:46:36-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170521 15:46:39< loonycyborg> Ivanovic: probably gcc-config mechanism failed in this instance somehow..
20170521 15:54:10-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:f1b1:b8bc:4adc:79da] has joined #wesnoth-dev
20170521 16:18:03-!- Duthlet [~Duthlet@dslb-188-106-028-224.188.106.pools.vodafone-ip.de] has quit [Quit: leaving]
20170521 16:18:59-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:f1b1:b8bc:4adc:79da] has quit [Remote host closed the connection]
20170521 16:21:02-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:f1b1:b8bc:4adc:79da] has joined #wesnoth-dev
20170521 16:25:22-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:f1b1:b8bc:4adc:79da] has quit [Ping timeout: 245 seconds]
20170521 16:38:37-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170521 16:39:09-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170521 16:44:42-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev
20170521 17:22:46-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:f1b1:b8bc:4adc:79da] has joined #wesnoth-dev
20170521 17:28:38-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:f1b1:b8bc:4adc:79da] has quit [Ping timeout: 255 seconds]
20170521 17:31:10-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170521 17:31:18< celticminstrel> Just FTR, I've already addressed the things tamanegi mentioned in the release thread.
20170521 17:31:42-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170521 17:36:00-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has quit [Quit: Leaving]
20170521 17:40:53< vultraz_iOS> i feel strangely unmotivated to work on anything :|
20170521 17:41:21< celticminstrel> Oh my.
20170521 17:41:40< zookeeper> sounds like my usual day :>
20170521 17:43:37< vultraz_iOS> part of the reason I've been working on the event stuff. Can't feel motivated to do much else.
20170521 17:44:04< vultraz_iOS> even though I should be working on refactoring the dependency manager to fix that bug in mp create
20170521 17:48:06-!- trewe [~trewe@bl20-16-53.dsl.telepac.pt] has joined #wesnoth-dev
20170521 18:01:24-!- irker979 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170521 18:23:44-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170521 18:24:16-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170521 18:34:48-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170521 18:43:18-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Ping timeout: 260 seconds]
20170521 18:45:49-!- Appleman1234 [~quassel@pl22492.ag1212.nttpc.ne.jp] has quit [Ping timeout: 268 seconds]
20170521 18:46:24< celticminstrel> So when passing to a function, you need config { ... }
20170521 18:46:31< celticminstrel> It won't work with just { ... }
20170521 18:53:14-!- Appleman1234 [~quassel@pl22492.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170521 18:56:22-!- gfgtdf [~chatzilla@x4e3639c0.dyn.telefonica.de] has joined #wesnoth-dev
20170521 18:59:39-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:f1b1:b8bc:4adc:79da] has joined #wesnoth-dev
20170521 19:01:58< vultraz_iOS> celticminstrel: addon manifest!
20170521 19:02:16< celticminstrel> Oh, right.
20170521 19:02:19< vultraz_iOS> :|
20170521 19:02:33< celticminstrel> BTW, there's at least one other major feature needed.
20170521 19:02:45< celticminstrel> #1712
20170521 19:03:16< celticminstrel> We also need to check if Steam cloud support requires anything other than telling Steam where the saves are stored.
20170521 19:03:21-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:f1b1:b8bc:4adc:79da] has quit [Remote host closed the connection]
20170521 19:05:09-!- heirecka [~heirecka@exherbo/developer/heirecka] has quit [Excess Flood]
20170521 19:06:09-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170521 19:07:03< vultraz_iOS> plus, I thought we agreed feature freeze would be after next release
20170521 19:08:19-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev
20170521 19:08:42< vultraz_iOS> remember?
20170521 19:08:52< celticminstrel> I think feature freeze is at RC stage, but refactors are not features.
20170521 19:10:00-!- sevu [~Shiki@p54856219.dip0.t-ipconnect.de] has quit [Quit: Verlassend]
20170521 19:19:09< vultraz_iOS> that aside
20170521 19:19:17< vultraz_iOS> why is no one commenting on the actual changes :|
20170521 19:20:16< celticminstrel> Well, I don't really have anything to say on the actual changes, so...
20170521 19:21:07< vultraz_iOS> specifically tad
20170521 19:28:22-!- Appleman1234 [~quassel@pl22492.ag1212.nttpc.ne.jp] has quit [Ping timeout: 268 seconds]
20170521 19:30:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170521 19:31:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20170521 19:31:48-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170521 19:31:48-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20170521 19:32:06-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170521 19:38:28-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170521 19:38:41-!- sevu [~Shiki@141.57.63.75] has joined #wesnoth-dev
20170521 19:39:00-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170521 19:47:17-!- Appleman1234 [~quassel@pl22492.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170521 19:53:45-!- irker093 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170521 19:53:45< irker093> wesnoth: LINE wesnoth:master 5138696292df / src/CMakeLists.txt: fix cmake compile error on macOS (#1713) https://github.com/wesnoth/wesnoth/commit/5138696292df4d3e3c5189a4302801a261e45ee9
20170521 20:02:49-!- Greg-Bog_ [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170521 20:05:35-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Ping timeout: 240 seconds]
20170521 20:10:33-!- Appleman1234 [~quassel@pl22492.ag1212.nttpc.ne.jp] has quit [Remote host closed the connection]
20170521 20:10:36-!- abruanese [U2FsdGVkX1@ma.sdf.org] has joined #wesnoth-dev
20170521 20:13:18-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170521 20:13:18-!- Greg-Bog_ [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170521 20:16:46-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170521 20:17:03-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170521 20:27:17-!- Kwandulin [~Kwandulin@p200300760F6D801114253F763AD35556.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170521 20:27:54< irker093> wesnoth: Celtic Minstrel wesnoth:master 3b276ff39a54 / src/config.hpp: Implement variadic initializer list for config class https://github.com/wesnoth/wesnoth/commit/3b276ff39a541d6cb9a9831711ee4af9ceec50cd
20170521 20:27:56< irker093> wesnoth: Celtic Minstrel wesnoth:master 96ca0b026e7b / / (56 files in 22 dirs): Replace config_of with new variadic config constructor https://github.com/wesnoth/wesnoth/commit/96ca0b026e7b73474204346343d3d28f7a374a24
20170521 20:28:12< celticminstrel> gfgtdf: Do you think that can replace configr_of too?
20170521 20:32:19< celticminstrel> Oh right, I was going to add an insert function so that cfg.insert(key, value) is equivalent to cfg[key] = value except without first default-initializing the attribute.
20170521 20:34:21-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Ping timeout: 268 seconds]
20170521 20:34:55-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170521 20:39:06-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170521 20:39:40-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170521 20:42:01-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170521 20:42:28< celticminstrel> vultraz_iOS, gfgtdf: Do you want to try porting [recall] to Lua?
20170521 20:42:33-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170521 20:43:57-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Ping timeout: 240 seconds]
20170521 20:46:27< gfgtdf> celticminstrel: hmm you didn't use a list-like syntax
20170521 20:46:38< celticminstrel> gfgtdf: See the IRC logs for the discussion.
20170521 20:46:46< celticminstrel> tl;dr I couldn't get it to work.
20170521 20:54:22< gfgtdf> celticminstrel: hmm ok
20170521 20:54:29-!- JyrkiVesterinen [~JyrkiVest@87-100-192-247.bb.dnainternet.fi] has quit [Quit: .]
20170521 20:54:46-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has quit [Quit: "The highest possible stage in moral culture is when we recognize that we ought to control our thoughts." - Charles Darwin]
20170521 20:55:15< celticminstrel> Could've been an MSVC issue, not that that makes any difference.
20170521 20:56:34-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has joined #wesnoth-dev
20170521 20:57:50< gfgtdf> celticminstrel: 'template<typename... T> explicit config (std::pair<std::string, T>&&... args)' didn't work ?
20170521 20:58:53< celticminstrel> gfgtdf: I tried that with const char* rather than std::string and that didn't work.
20170521 20:58:59< celticminstrel> That's what you suggested earlier.
20170521 20:59:16< celticminstrel> gfgtdf: The branch is still on the repo if you want to take a look.
20170521 20:59:40< gfgtdf>  celticminstrel ye i meant const char*
20170521 20:59:43< gfgtdf> celticminstrel: hmm
20170521 21:02:58-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170521 21:07:23-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Ping timeout: 260 seconds]
20170521 21:11:03-!- trewe [~trewe@bl20-16-53.dsl.telepac.pt] has quit [Quit: quit]
20170521 21:17:42< gfgtdf> celticminstrel: i currently don't indend to work on orting [recall]
20170521 21:18:02< gfgtdf> celticminstrel: ye i see no wqya to implement the list like syntax ten eigher
20170521 21:18:18< celticminstrel> Do you think I can replace configr_of?
20170521 21:19:15< gfgtdf> celticminstrel: configr_of is currently not really used. the intention of  configr_of is to crearea  config-like structure that holds onlyreferences to coinfigs (instead of copying them)
20170521 21:19:57< gfgtdf> celticminstrel: this is currently onyl used in the send network data functionbut not really needed
20170521 21:20:11< celticminstrel> That sounds like a yes?
20170521 21:20:47< gfgtdf> celticminstrel: i don't see how exaclt ou want to 'replace' it, the config ctor does still copy its arguments
20170521 21:22:17< celticminstrel> I think it potentially moves them, but maybe that's still not what you want.
20170521 21:22:27< celticminstrel> So you're saying I can't replace it?
20170521 21:23:37< gfgtdf> celticminstrel: not with the config ctor, you could ofc change the syntax of configr_of to match the other one.
20170521 21:24:51< gfgtdf> celticminstrel: you could just change that functions that currently take a configr_of  to take just a 'const config&'. It shouldn't make a difference, i change it back then from const config& to configr_of to prepare some changes of the newwork code, but then i didn't get to do them
20170521 21:33:43-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170521 21:34:15-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170521 22:02:02-!- Appleman1234 [~quassel@pl22492.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170521 22:15:26-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170521 22:17:23-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds]
20170521 22:18:44-!- stikonas_ is now known as stikonas
20170521 22:26:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170521 22:26:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170521 23:24:28-!- ancestral [~anonymous@63-231-152-92.mpls.qwest.net] has joined #wesnoth-dev
20170521 23:55:20-!- sevu [~Shiki@141.57.63.75] has quit [Remote host closed the connection]
20170521 23:58:52< celticminstrel> vultraz_iOS: Thinking about colour-coding numbers in trait descriptions. What colours do you think should be used?
20170521 23:59:01< vultraz_iOS> ???
20170521 23:59:21< celticminstrel> So that you can tell at a glance (by the colour) whether it gives a bonus or a penalty.
--- Log closed Mon May 22 00:00:13 2017