--- Log opened Mon May 22 00:00:13 2017
20170522 00:00:37< celticminstrel> Maybe the same colours that are used for colour-coding attacks with active modifiers...?
20170522 00:03:09< vultraz_iOS> sure
20170522 00:06:31< irker093> wesnoth: Charles Dang wesnoth:master 1707070d6f72 / src/ (config.cpp config_attribute_value.cpp): Reformat config and config attribute code https://github.com/wesnoth/wesnoth/commit/1707070d6f72dde2c4f068aa66940cb01225f11d
20170522 00:06:34< irker093> wesnoth: Charles Dang wesnoth:master 932677d36eb7 / src/config.cpp: Config: more range-for https://github.com/wesnoth/wesnoth/commit/932677d36eb7e4722e4081a2ebf0fc61ef6eae17
20170522 00:06:43< celticminstrel> :(
20170522 00:06:56< vultraz_iOS> R E F O R M A T T I N G
20170522 00:07:13< celticminstrel> But I had changes pending to config.hpp!
20170522 00:07:32< vultraz_iOS> I only changed the cpp
20170522 00:07:33< celticminstrel> Oh, you only touched the cpp?
20170522 00:07:53< vultraz_iOS> yes
20170522 00:07:54< celticminstrel> Okay, that should be fine then. IIRC the changes were removing an unncessary namespace qualifier and adding a new templated method.
20170522 00:08:14< celticminstrel> So nothing cpp IOW.
20170522 00:08:33< celticminstrel> Still need to rebase, but TBH that's not a bad thing; I needed to rebase anyway for fixups.
20170522 00:09:51< celticminstrel> You know, I wonder if we should refactor unit_preview_pane to rely on reports.cpp...
20170522 00:09:57< celticminstrel> At least when showing a specific unit.
20170522 00:10:22< vultraz_iOS> reports.cpp is so mennu
20170522 00:10:24< vultraz_iOS> ...
20170522 00:10:27< vultraz_iOS> messy
20170522 00:10:50< celticminstrel> Sure it's messy, but it's also (at least partly) responsible for the ability to customize the sidebar with Lua.
20170522 00:11:02< celticminstrel> So we can't just drop it when the game UI becomes GUI2.
20170522 00:11:30< vultraz_iOS> needs
20170522 00:11:35< vultraz_iOS> R E F A C T O R I N G 
20170522 00:11:53< celticminstrel> Not now.
20170522 00:11:58< celticminstrel> Don't even start that.
20170522 00:15:18< celticminstrel> ...eh? I'm confused, why does this use hp_color? :|
20170522 00:16:18< vultraz_iOS> that's a color range based on percentage
20170522 00:32:05< celticminstrel> I know...
20170522 00:35:51< vultraz_iOS> that just happens to be called hp color
20170522 00:37:07-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:80df:8f4f:7ac:670f] has joined #wesnoth-dev
20170522 00:37:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170522 00:39:10-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Ping timeout: 268 seconds]
20170522 00:39:18-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170522 00:47:34< vultraz_iOS> SO MUCH TO DO
20170522 00:51:31< vultraz_iOS> need to rewrite the dependecy manager
20170522 00:51:34< vultraz_iOS> dependency 
20170522 00:51:39-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:80df:8f4f:7ac:670f] has quit [Remote host closed the connection]
20170522 00:52:22-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170522 00:58:47-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170522 01:06:49< irker093> wesnoth: Charles Dang wesnoth:master a40f0d248edc / src/tests/utils/play_scenario.cpp: Cleaned up a stray include from 96ca0b0 https://github.com/wesnoth/wesnoth/commit/a40f0d248edc47034d3cabf8b1ef25dd4bf42773
20170522 01:08:05< celticminstrel> Eh? How the heck did I miss that when I built the entire game? :|
20170522 01:10:40< vultraz_iOS> tests
20170522 01:12:38-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20170522 01:16:47< celticminstrel> Oh. For the tests I only built the specific files that actually referenced config_of, rather than the full test suite.
20170522 01:16:47-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 260 seconds]
20170522 01:16:48-!- wedge010 is now known as wedge009
20170522 01:17:03< celticminstrel> So I guess I missed that one because it included it but didn't use it.
20170522 01:26:09< gfgtdf> hmm that file seems t be emty
20170522 01:26:31< celticminstrel> Oh wow, you're right. o.o
20170522 01:27:09< gfgtdf> it seems like that ce was remve with te sl2 transitin.
20170522 01:27:35< celticminstrel> Because it was no longer needed or because it was too much work to port?
20170522 01:27:37< gfgtdf> (this time it's my keybar that's brken, nt me)
20170522 01:28:01< gfgtdf> celticminstrel: i n't knw, i n't see any reasn why that wul be sl2 incmatible
20170522 01:28:27< vultraz_iOS> remove file/
20170522 01:28:27< vultraz_iOS> ?
20170522 01:28:28< celticminstrel> Maybe you should try using the onscreen keyboard if your physical one is broken.
20170522 01:28:43< gfgtdf> celticminstrel: this is the riginal file cntent: https://github.com/wesnoth/wesnoth/blob/6e3aa0836ee72dc0295b79e2c238a95cc413244a/src/tests/utils/play_scenario.cpp
20170522 01:29:17-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170522 01:31:27< celticminstrel> gfgtdf: Used by test_formula_ai.cpp.
20170522 01:31:38< gfgtdf> hmm it seems t be sening a ctrl+q t the rgramm that's why it nee t use sl ce.
20170522 01:31:41< celticminstrel> Which I'm assuming was also removed with the SDL2 transition.
20170522 01:32:08< celticminstrel> gfgtdf: I suspect the test could be reinstated using the WML test framework.
20170522 01:32:15< celticminstrel> But not sure.
20170522 01:33:15< celticminstrel> Maybe it could be just reinstated normally too.
20170522 01:36:24< celticminstrel> There's several things that were removed that perhaps shouldn't've been: https://github.com/wesnoth/wesnoth/commit/358bd1235f07d8d577bdb2bb0b4aafcff2e93093#diff-49a7fc6564eaea3b9f5e5c59516b460b
20170522 01:40:22-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170522 01:48:59-!- gfgtdf [~chatzilla@x4e3639c0.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 53.0.2/20170504105526]]
20170522 01:52:11-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170522 01:55:50< vultraz_iOS> celticminstrel: if you're changing config.hpp might as well change config::error to inherit from std::exception not boost::exception
20170522 01:59:39< celticminstrel> ...seriously?
20170522 02:01:34< vultraz_iOS> what?
20170522 02:03:15< celticminstrel> I'm just shocked to hear that that's even an issue.
20170522 02:03:52< celticminstrel> Hmm, for the trait tooltips, maybe I should just do red for penalty and green for bonus?
20170522 02:04:27< celticminstrel> BTW, is there anything you've found yourself wanting in config that I could add while I'm at it?
20170522 02:05:22-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170522 02:05:42< vultraz_iOS> uhhhhhhhhhhhhhhhhhhhhhhh
20170522 02:06:27< celticminstrel> And regarding the first question, is there any specific shades or should I just use "red" and "green".
20170522 02:07:13< vultraz_iOS> uhhhh
20170522 02:07:14< vultraz_iOS> latter
20170522 02:09:09< vultraz_iOS> (did you not merge the password encryption?)
20170522 02:09:51< celticminstrel> What made you think I merged it?
20170522 02:10:29< vultraz_iOS> i dunno
20170522 02:10:44< vultraz_iOS> mendela effect
20170522 02:12:33< celticminstrel> I think maybe I should add a utility function for formatting a translatable list.
20170522 02:13:06< vultraz_iOS> ah yes
20170522 02:13:20< celticminstrel> Well, the first SO result doesn't even have an answer. :(
20170522 02:13:23< vultraz_iOS> celticminstrel: at some pointed i had wanted the ability to fill a stl container from a child range
20170522 02:13:47< celticminstrel> vultraz_iOS: So uh... child_range() -> vector<config>?
20170522 02:14:13< vultraz_iOS> uhhh... I guess.
20170522 02:14:21< celticminstrel> That's easy. auto ran = cfg.child_range("tag"); vector<config> list(ran.begin(), ran.end());
20170522 02:14:34< vultraz_iOS> I see
20170522 02:14:53< vultraz_iOS> alright then
20170522 02:16:10< celticminstrel> This seems useful. http://stackoverflow.com/a/38536666/1502810
20170522 02:17:36< irker093> wesnoth: Charles Dang wesnoth:master 2f4f0d03c5e0 / src/ (4 files in 3 dirs): Deployed a few more cases of vector::emplace_back and deque::emplace_back https://github.com/wesnoth/wesnoth/commit/2f4f0d03c5e0a7a45b236dd5ba8582080423c1f6
20170522 02:18:01< celticminstrel> Any deque::emplace_front?
20170522 02:18:06< celticminstrel> Or even list::emplace_front I guess.
20170522 02:18:14< celticminstrel> Or even list::emplace_back I suppose.
20170522 02:18:59< vultraz_iOS> ermeghard
20170522 02:19:01< vultraz_iOS> :o
20170522 02:19:07< celticminstrel> ...what?
20170522 02:19:14< celticminstrel> Did I say something bad?
20170522 02:19:14< vultraz_iOS> more things to deploy \o/
20170522 02:19:29< celticminstrel> Did you not know insert_front / emplace_front existed?
20170522 02:19:35< celticminstrel> I dunno if they're used though.
20170522 02:20:04< vultraz_iOS> didn't think of it
20170522 02:21:05< celticminstrel> Anything else you've found yourself wanting in config?
20170522 02:22:04< irker093> wesnoth: Charles Dang wesnoth:master 336aad778068 / src/actions/heal.cpp: Deployed a lone list::emplace_front https://github.com/wesnoth/wesnoth/commit/336aad7780689f09383decc7f4449537a82e3bf8
20170522 02:22:16< celticminstrel> BTW, what's Wesnoth's stance on the serial comma?
20170522 02:22:29< vultraz_iOS> dont think we have one
20170522 02:22:54< celticminstrel> Sounds like you're not sure.
20170522 02:23:07< vultraz_iOS> can't think of any more config features right now
20170522 02:24:26< pydsigner> Konrad, Delfador, and Kalenz are three important characters in Heir to the Throne.
20170522 02:24:45< celticminstrel> [citation needed]
20170522 02:25:44< pydsigner> Lol
20170522 02:27:40< pydsigner> The impostor Konrad leads an army of outlaws, dwarves, and elves against the rightful but tyrannical Queen Asheviere.
20170522 02:27:50< pydsigner> Happy now?
20170522 02:28:00< celticminstrel> That looks like an actual quote from HTTT.
20170522 02:28:40< celticminstrel> vultraz_iOS: Can you please fix the missing images in the widescreen theme?
20170522 02:28:42< pydsigner> Nah, HttT completely sugars the whole parentage reveal
20170522 02:29:13< celticminstrel> If you're not getting these lines from an actual scenario, then where are you getting them from?
20170522 02:30:53< pydsigner> I... made them up?
20170522 02:32:17< celticminstrel> Well, that's not very helpful then.
20170522 02:33:57< pydsigner> I'll go look for something actual
20170522 02:45:14< pydsigner> Legend of Wesmere: "This is the story of Kalenz, Landar, and of the Elves in the first days of the humans in Wesnoth."
20170522 02:45:53< pydsigner> Liberty: "reckless, cocky, and eager to explore."
20170522 02:46:12< celticminstrel> Okay.
20170522 02:46:28< pydsigner> Secrets of the Ancients: "An offer of learning, adventure, and escape from this town."
20170522 02:46:41-!- sevu [~Shiki@p54856219.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170522 02:51:01< pydsigner> Oh lol
20170522 02:51:16< pydsigner> "Konrad, Defador, and Kalenz swiftly rode east"
20170522 02:51:26< pydsigner> I even got the order right lol
20170522 02:51:58< pydsigner> However, it's not one fixed style
20170522 02:52:05-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:80df:8f4f:7ac:670f] has joined #wesnoth-dev
20170522 02:52:26-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:80df:8f4f:7ac:670f] has quit [Remote host closed the connection]
20170522 02:52:27< pydsigner> Northern Rebirth: "This is a place of unimaginable splendor, glory, and transcendence"
20170522 02:52:38< pydsigner> Although that's in an unplayable scenario
20170522 02:53:00< pydsigner> And... uh, isn't even internally consistent
20170522 02:53:18< pydsigner> Even in that very dialog bit
20170522 02:54:51< pydsigner> celticminstrel: Yeah basically we can pick one
20170522 02:54:57< pydsigner> Because no-one has been consistent
20170522 02:55:05< pydsigner> I prefer the use of the comma, however.
20170522 02:55:05-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170522 02:56:23< celticminstrel> It's also totally possible for en_US to use no serial comma and en_GB to use a serial comma (or vice versa).
20170522 02:58:00< pydsigner> It's also actually a rather minor issue
20170522 02:58:07< pydsigner> I made a regex to look for usage
20170522 02:58:46< pydsigner> And there only 250 total results, mostly false positives.
20170522 02:59:55< celticminstrel> FTR vultraz_iOS, config::error inherits from both std::exception and boost::exception, and the latter is in no way equivalent to the former (though I'm not entirely sure what it does).
20170522 03:00:13< vultraz_iOS> i see
20170522 03:07:27< irker093> wesnoth: Charles Dang wesnoth:master 57d825d11405 / src/ (commandline_options.cpp scripting/game_lua_kernel.cpp): Avoid some temporary tuples https://github.com/wesnoth/wesnoth/commit/57d825d1140542580b1b81cf59d04b16173324ce
20170522 03:12:21-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170522 03:20:58< irker093> wesnoth: Charles Dang wesnoth:master 8a1f292222fe / src/gui/dialogs/ (story_viewer.cpp story_viewer.hpp): Story Viewer: fix stack background disappearing when pressing Next when fading i https://github.com/wesnoth/wesnoth/commit/8a1f292222feee68d44ebb5b2a3ce4458fe7334c
20170522 03:22:23-!- shiki [~Shiki@p54855408.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170522 03:22:23-!- sevu [~Shiki@p54856219.dip0.t-ipconnect.de] has quit [Disconnected by services]
20170522 03:33:10< vultraz_iOS> celticminstrel: if i wanted to move these swap_grid functions into a single file would you think it should be in widgets/ or auxiliary/?
20170522 03:34:02< celticminstrel> Why are you putting [ci skip] in code change commits? Don't do that.
20170522 03:34:20< celticminstrel> If it's a purely formatting change, sure. Otherwise, if it touches code, there's no reason to skip ci.
20170522 03:34:58< celticminstrel> [May 21@10:28:39pm] celticminstrel: vultraz_iOS: Can you please fix the missing images in the widescreen theme?
20170522 03:35:06< vultraz_iOS> alright
20170522 03:35:10< vultraz_iOS> well
20170522 03:35:13< celticminstrel> Also I don't know what you're talking about on the swap_grids.
20170522 03:35:33< vultraz_iOS> do you think a utility header used by widgets should be in widgets/
20170522 03:35:47< celticminstrel> I think there's precedent for it? Not 100% sure though.
20170522 03:35:55< vultraz_iOS> well group is in widgets
20170522 03:35:57< celticminstrel> Oh yeah, I guess things like group count.
20170522 03:36:03< vultraz_iOS> but I think I'm going to move that to aux
20170522 03:36:33< celticminstrel> Actually I've been thinking maybe it should be promoted to a real widget.
20170522 03:36:55< vultraz_iOS> wat
20170522 03:37:10< celticminstrel> Because when a group is focused, I think the expectation is to be able to navigate through the options using the arrow keys.
20170522 03:37:33< celticminstrel> Mind you, I'm not sure if all its use cases would work as a widget...
20170522 03:38:19< celticminstrel> Maybe the same effect could be achieved by always wrapping groups in a listbox?
20170522 03:38:35< celticminstrel> A listbox with the toggle_button at root, rather than having a toggle_panel.
20170522 03:38:58< celticminstrel> Maybe I'll experiment with this.
20170522 03:39:19< vultraz_iOS> I...what?
20170522 03:39:34< celticminstrel> ...what part of what I said is unclear?
20170522 03:40:08< vultraz_iOS> I see
20170522 03:41:10< vultraz_iOS> hmm
20170522 03:41:18< vultraz_iOS> maybe this should just go in helper.*pp
20170522 03:41:25-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170522 03:48:15-!- shiki [~Shiki@p54855408.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20170522 03:50:48< irker093> wesnoth: Charles Dang wesnoth:master 246ea98dd93b / / (8 files in 3 dirs): GUI2: moved common swap_grid util function into new widget_helpers file https://github.com/wesnoth/wesnoth/commit/246ea98dd93bb36c56d5a99e1a45395d587700c6
20170522 03:51:33< vultraz_iOS> decided to keep helper.*pp for general purpose things
20170522 03:55:30< vultraz_iOS> timotei: are you going to continue maintaining the UMC IDE?
20170522 03:55:33-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170522 03:55:56 * celticminstrel notes that some commits were added to it relatively recently.
20170522 03:56:43< celticminstrel> Merged three PRs on Oct 31, to be precise.
20170522 03:57:03< celticminstrel> ^two PRa
20170522 03:57:32< vultraz_iOS> i see
20170522 04:05:15< irker093> wesnoth: Ignacio R. Morelle wesnoth:master 5ed8dc384701 / src/ (build_info.cpp build_info.hpp gui/dialogs/game_version.cpp): gui2/game_version: Move report text generator to game_config ns for general use https://github.com/wesnoth/wesnoth/commit/5ed8dc3847012cec05d634f3794dc725e54699ef
20170522 04:05:18< irker093> wesnoth: Ignacio R. Morelle wesnoth:master 98883d0d0cf9 / / (4 files in 2 dirs): Add new --report/-R switch to generate an info dump for bug reports https://github.com/wesnoth/wesnoth/commit/98883d0d0cf961a35943c055f7f3afaaf8a5f764
20170522 04:05:21< irker093> wesnoth: Ignacio R. Morelle wesnoth:master 71408850c67c / changelog: Update changelog https://github.com/wesnoth/wesnoth/commit/71408850c67cd89615f2a6d01c5909cb68424973
20170522 04:06:52< celticminstrel> Yay manpage updates.
20170522 04:07:02-!- sevu [~Shiki@p54855408.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170522 04:35:10< irker093> wesnoth: Celtic Minstrel wesnoth:master 75357087e83f / src/config.hpp: Small refinement of 3b276ff https://github.com/wesnoth/wesnoth/commit/75357087e83fad8205d1e69f7b98a9f2d0019b3c
20170522 04:35:12< irker093> wesnoth: Celtic Minstrel wesnoth:master 1299998a6f8d / src/units/unit.cpp: Fix erroneous "unknown attribute discarded" warnings for new [unit] keys https://github.com/wesnoth/wesnoth/commit/1299998a6f8d9b4100a5f52091db5a9d28b12d05
20170522 04:35:14< irker093> wesnoth: Celtic Minstrel wesnoth:master a141de5e53c5 / src/ (gui/dialogs/story_viewer.hpp storyscreen/controller.hpp): Address potential crash if a storyscreen has no showable parts https://github.com/wesnoth/wesnoth/commit/a141de5e53c5ea9be314506f9e841d3439b8c79e
20170522 04:35:16< irker093> wesnoth: Celtic Minstrel wesnoth:master c0e694083452 / src/scripting/game_lua_kernel.cpp: Prevent [modify_ai][ai] from cluttering AI config with empty stages https://github.com/wesnoth/wesnoth/commit/c0e694083452a46a1991dc3c771fdb4e3c630bdd
20170522 04:35:18< irker093> wesnoth: Celtic Minstrel wesnoth:master 6048eb8a8063 / src/scripting/ (lua_kernel_base.cpp lua_kernel_base.hpp): Add wesnoth.kernel_type() to detect the class of the current Lua kernel https://github.com/wesnoth/wesnoth/commit/6048eb8a80635c20308c5ab0811564018d5ffd01
20170522 04:35:20< irker093> wesnoth: Celtic Minstrel wesnoth:master 021d9653c58c / src/formula/string_utils.hpp: Use variadic macros for VGETTEXT/VNGETTEXT to allow embedding map literals in th https://github.com/wesnoth/wesnoth/commit/021d9653c58cf510b0198527a124dde351462fb0
20170522 04:35:22< irker093> wesnoth: Celtic Minstrel wesnoth:master 2cc7ec4bde03 / src/ (formula/string_utils.cpp formula/string_utils.hpp scripting/lua_kernel_base.cpp): Add API function for formatting lists https://github.com/wesnoth/wesnoth/commit/2cc7ec4bde0371a4bfb0683b6d88b97d7dbaf2be
20170522 04:35:24< irker093> wesnoth: Celtic Minstrel wesnoth:master c6bdcb0f53b6 / src/ (gui/widgets/multimenu_button.cpp units/attack_type.cpp units/unit.cpp): Deploy format_conjunct_list https://github.com/wesnoth/wesnoth/commit/c6bdcb0f53b66a2d0f8a7a284b5c56ce0962b17f
20170522 04:35:26< irker093> wesnoth: Celtic Minstrel wesnoth:master c8e631685384 / src/units/ (attack_type.cpp unit.cpp): Colour-code modifiers in trait description tooltips https://github.com/wesnoth/wesnoth/commit/c8e631685384d4255c5bf5e9c45c805b13d7902d
20170522 04:35:28< irker093> wesnoth: Celtic Minstrel wesnoth:master 081ed8241687 / src/gui/widgets/unit_preview_pane.cpp: Unit preview pane: use more span_color() where possible https://github.com/wesnoth/wesnoth/commit/081ed82416876b6cf851c89b91d8e1cf9f602199
20170522 04:36:22< celticminstrel> Just FTR, I wasn't planning on taking responsibility for merging the login_save_crypt branch, unless multiple people explicitly ask me to.
20170522 04:37:26-!- JyrkiVesterinen [~jyrki@87-100-197-44.bb.dnainternet.fi] has joined #wesnoth-dev
20170522 04:37:56-!- ancestral [~anonymous@63-231-152-92.mpls.qwest.net] has quit [Quit: ancestral]
20170522 04:44:14< celticminstrel> Why am I not receiving notifications on some issues...
20170522 05:04:55< vultraz_iOS> wall of changes :o
20170522 05:04:55< vultraz_iOS> good work
20170522 05:06:45< celticminstrel> Some of those were things from the release thread.
20170522 05:07:26< vultraz_iOS> indeed
20170522 05:18:21-!- Appleman1234 [~quassel@pl22492.ag1212.nttpc.ne.jp] has quit [Remote host closed the connection]
20170522 05:20:53< JyrkiVesterinen> celticminstrel: I can merge login_save_crypt in the evening.
20170522 05:21:07< celticminstrel> Okay, sure.
20170522 05:21:18< celticminstrel> Needs to be done manually since there are conflicts.
20170522 05:22:04< celticminstrel> (I'm not too keen on using GitHub's resolve conflicts tool for a PR that isn't going to be squashed, as it works by merging master into the PR.)
20170522 05:22:37< JyrkiVesterinen> Same here. If there are conflicts, I merge with command-line Git.
20170522 05:24:26< vultraz_iOS> GOT IT.
20170522 05:25:07< vultraz_iOS> ah, well
20170522 05:25:11< vultraz_iOS> re-got it, actually
20170522 05:27:24< celticminstrel> ?
20170522 05:28:11-!- Appleman1234 [~quassel@pl22492.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170522 05:29:20-!- Appleman1234_ [~quassel@pl22492.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170522 05:29:44-!- Appleman1234_ [~quassel@pl22492.ag1212.nttpc.ne.jp] has quit [Client Quit]
20170522 05:33:16< vultraz_iOS> was just looking again at https://github.com/wesnoth/wesnoth/issues/1568
20170522 05:43:41< celticminstrel> Is that related to the + issue reported in the release thread?
20170522 05:45:02< vultraz_iOS> well, to the attack predictions thing at least
20170522 05:45:07< celticminstrel> ???
20170522 05:45:22< vultraz_iOS> the text in AP
20170522 05:45:24< celticminstrel> I'm talking about how + is hard to distinguish from -
20170522 05:45:32< vultraz_iOS> that possibly too
20170522 05:48:12< celticminstrel> Any idea why terrain defense and movement cost don't display right when not in-game?
20170522 05:48:20< vultraz_iOS> no idea
20170522 05:55:23< celticminstrel> Wonder what that issues that doofus is complaining about... something to do with the recall list?
20170522 05:55:28< celticminstrel> ^issue is
20170522 05:56:04-!- JyrkiVesterinen [~jyrki@87-100-197-44.bb.dnainternet.fi] has quit [Quit: .]
20170522 06:02:08-!- Kwandulin [~Kwandulin@p200300760F6D801114253F763AD35556.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170522 06:15:03< celticminstrel> vultraz_iOS: You broke it.
20170522 06:15:16< vultraz_iOS> what did?
20170522 06:15:19< vultraz_iOS> what broke?
20170522 06:15:22< vultraz_iOS> how was it broken?
20170522 06:15:25< celticminstrel> 246ea98dd93b gives link errors.
20170522 06:15:40< vultraz_iOS> new file
20170522 06:15:41< vultraz_iOS> update proj
20170522 06:15:48< celticminstrel> :(
20170522 06:18:45< celticminstrel> vultraz_iOS: Oh yeah, you should scan through the credits and see if there's anyone who should be bumped up from Misc.
20170522 06:32:43-!- sevu [~Shiki@p54855408.dip0.t-ipconnect.de] has quit [Quit: Verlassend]
20170522 06:33:49< vultraz_iOS> hm
20170522 06:34:01< vultraz_iOS> once again i have come back to the "fix" of disabling alpha blending for text
20170522 06:34:16< vultraz_iOS> i seem to recall aginor telling me we do want alpha blending for text
20170522 06:34:21< vultraz_iOS> not sure why we would want alpha blending for text
20170522 06:34:33< celticminstrel> Because it's anti-aliased, duh.
20170522 06:34:46< celticminstrel> If you want to disable alpha blending and anti-aliasing, that would work.
20170522 06:34:57< celticminstrel> Though it would look a little pixellated probably.
20170522 06:34:57-!- JyrkiVesterinen [~JyrkiVest@85-76-66-132-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170522 06:36:22< vultraz_iOS> it looks fine with blending disabled tho?
20170522 06:36:35< vultraz_iOS> https://1drv.ms/i/s!As9hRC_GxjKKpXLB2GIkZMrTq0Pg
20170522 06:36:49< vultraz_iOS> (ignore the buttons. that's the unfortuate side effect that would have to be fixed)
20170522 06:38:15< vultraz_iOS> but seriously, tho, it doesn't seem to destroy aa
20170522 06:38:19< vultraz_iOS> so what's the issue
20170522 06:39:03< celticminstrel> The [about]images key doesn't seem to be used, huh.
20170522 06:39:08< celticminstrel> At least in about.cfg.
20170522 06:41:13-!- JyrkiVesterinen [~JyrkiVest@85-76-66-132-nat.elisa-mobile.fi] has quit [Remote host closed the connection]
20170522 06:41:38-!- JyrkiVesterinen [~JyrkiVest@85-76-66-132-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170522 06:41:44< vultraz_iOS> celticminstrel: oh yeah, i never re-implemented use of all available images in the end credits
20170522 06:42:08< celticminstrel> Is the basic mechanism implemented at least?
20170522 06:43:24< vultraz_iOS> To show images? Yes
20170522 06:43:37< vultraz_iOS> And the list of images is loaded in
20170522 06:44:16< vultraz_iOS> Just needs a mechanism to change them after a specific scroll duration
20170522 06:44:33< celticminstrel> ...why does parenthetical split default to a null character as separator?
20170522 06:46:39< celticminstrel> Oh uh... that gives a completely different split effect.
20170522 06:46:48< celticminstrel> Why is it not a separate function. :|
20170522 06:48:22< celticminstrel> Why can campaigns have credits but eras and modifications can't?
20170522 06:48:59-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170522 07:04:15< zookeeper> celticminstrel, is the "then the [kill] tag kills everyone when the id filter uses a non-existing variable" thing caused by the lua porting?
20170522 07:04:48< celticminstrel> Well, I think that was mentioned too, but it's not the one I was thinking about.
20170522 07:05:39< zookeeper> uh. what? i was asking if you know whether it's caused by the lua porting.
20170522 07:05:45< celticminstrel> Oh.
20170522 07:06:06< zookeeper> i don't even know if it's a change or if it's always been that way
20170522 07:06:21< celticminstrel> I doubt it? I'd expect it to be caused by something in filters - like considering an empty id key to be equivalent to a non-existent key.
20170522 07:06:47< celticminstrel> Which probably shouldn't happen TBH...
20170522 07:07:03< celticminstrel> id= should match no-one because no-one has an empty ID.
20170522 07:10:31< zookeeper> doesn't happen in 1.12
20170522 07:10:35< zookeeper> (no one gets killed)
20170522 07:13:00< zookeeper> so, yeah, certainly a regression.
20170522 07:14:07< celticminstrel> Is there an issue number?
20170522 07:14:18< zookeeper> it happens with 1.13.5 too, which is before the [kill] porting
20170522 07:14:22< zookeeper> no
20170522 07:32:54< celticminstrel> I changed .empty() to .blank() which will probably fix it.
20170522 07:33:08-!- celticminstrel is now known as celmin|sleep
20170522 07:35:53-!- irker093 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170522 08:36:34< grzywacz> damn, compiling wesnoth on my modest 4GB machine has gotten hard, gcc often gets into gigabytes, so make -j3 is out of question ;s
20170522 08:46:57< loonycyborg> Good thing I got 8Gb now
20170522 08:47:14< JyrkiVesterinen> Good thing I have 32GB. :P
20170522 08:47:17< loonycyborg> with 4Gb I always got thrashing when compiling with chrome running
20170522 08:47:29< loonycyborg> so the point is
20170522 08:47:38< loonycyborg> try closing chrome :P
20170522 08:55:03-!- DDR [~david@ec2.happyspork.com] has quit [Ping timeout: 260 seconds]
20170522 08:59:04-!- DDR [~david@ec2.happyspork.com] has joined #wesnoth-dev
20170522 09:05:59-!- JyrkiVesterinen [~JyrkiVest@85-76-66-132-nat.elisa-mobile.fi] has quit [Quit: Lunch]
20170522 09:30:55< grzywacz> loonycyborg: yeah, I did that :D
20170522 09:33:45-!- JyrkiVesterinen [~JyrkiVest@85-76-66-132-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170522 10:01:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170522 10:24:04< vultraz_iOS> good thing I have 16 GB
20170522 10:24:35< JyrkiVesterinen> You're late. ;)
20170522 10:24:50< vultraz_iOS> i was at dinner :P
20170522 10:26:02-!- Duthlet [~Duthlet@dslb-188-106-028-224.188.106.pools.vodafone-ip.de] has joined #wesnoth-dev
20170522 10:30:01< grzywacz> Has anything changed in the translation flow since the old days? Or is it still 'translate the .po's and send them to a maintainer'?
20170522 10:30:52< JyrkiVesterinen> The translation flow is still the same.
20170522 10:31:46< grzywacz> Is there anyone in charge of the Polish one?
20170522 10:33:00< JyrkiVesterinen> Here's the info in the wiki (in Polish): https://wiki.wesnoth.org/PolishTranslation
20170522 10:35:29< grzywacz> good point, thanks
20170522 11:13:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170522 11:34:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170522 11:34:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20170522 11:54:45-!- Kwandulin [~Kwandulin@p200300760F6D801114253F763AD35556.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170522 12:12:01-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170522 13:18:57-!- atarocch [~atarocch@46.29.219.219] has quit [Ping timeout: 240 seconds]
20170522 13:23:26-!- Kwandulin [~Kwandulin@p200300760F6D807968058356DAE4A116.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170522 13:27:09-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170522 14:18:58-!- celmin|sleep is now known as celticminstrel
20170522 14:20:06-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170522 14:20:53< celticminstrel> Oh yeah, has anyone else gotten this? When the Lua console is open you need to press escape twice to close it.
20170522 14:24:23-!- irker190 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170522 14:24:23< irker190> wesnoth: mattsc wesnoth:master 451e22ddda6d / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update Xcode project https://github.com/wesnoth/wesnoth/commit/451e22ddda6dd433ed1ffcfe37eb17fc618a25ba
20170522 14:25:11< celticminstrel> Also https://forums.wesnoth.org/viewtopic.php?f=58&t=44792
20170522 14:26:56< celticminstrel> DeFender1031: ^
20170522 14:28:40< DeFender1031> celticminstrel, happy post of the beast!
20170522 14:29:06< celticminstrel> I'm linking it because I bumped it.
20170522 14:29:33< DeFender1031> I know. I just noticed that it's your 666th post.
20170522 14:29:41< DeFender1031> Hence, "post of the beast"
20170522 14:29:58< celticminstrel> Oh, hwh.
20170522 14:30:04< celticminstrel> ^heh
20170522 14:30:27< celticminstrel> Though the actual 666th post is in the release thread.
20170522 14:30:56< DeFender1031> Whatever, "Celtic_Minstrel     Developer     Posts: 666"
20170522 14:31:12 * celticminstrel shrug.
20170522 14:32:20< DeFender1031> Anyway, I'm not sure what you're asking in the post.
20170522 14:32:36< DeFender1031> (About the location of the new stuff, that I get, but not the technical question.)
20170522 14:33:31< celticminstrel> The set_X_metatable functions apply a metatable to the table they are passed.
20170522 14:33:58< celticminstrel> The metatable sets __metatable so that getmetatable() returns a string instead of the metatable.
20170522 14:34:31< celticminstrel> I don't intend to preserve this behaviour.
20170522 14:34:47< celticminstrel> Instead I want to just offer a table that already has the metatable set.
20170522 14:35:24< celticminstrel> So for example you could do "local T = wml.tag" instead of "local T = helper.set_wml_tag_metatable{}".
20170522 14:35:34-!- JyrkiVesterinen [~JyrkiVest@85-76-66-132-nat.elisa-mobile.fi] has quit [Quit: .]
20170522 14:35:56< DeFender1031> right.
20170522 14:36:02< DeFender1031> that makes sense
20170522 14:36:04< celticminstrel> But if that's the canonical form, how to implement helper.set_X_metatable?
20170522 14:36:34< DeFender1031> ah
20170522 14:36:35< celticminstrel> It's in a different file, so it won't have access to the actual metatable (unless I duplicate it).
20170522 14:36:48< DeFender1031> Or include that file...
20170522 14:37:04< celticminstrel> Well, it's local in that file, so including it is irrelevant.
20170522 14:45:31< DeFender1031> Could you implement the metatable function in terms of wml.tag?
20170522 15:01:15< celticminstrel> Other than ignoring the passed table and returning wml.tag, I don't think so.
20170522 15:01:28< celticminstrel> Unless I removed __metatable from the metatable.
20170522 15:07:40< DeFender1031> hmm
20170522 15:08:06< DeFender1031> how much would it break to just ignore the table and return wml.tag?
20170522 15:08:27< DeFender1031> I doubt anyone is doing anything with th metatable that is funcitonally different from just using wml.tag
20170522 15:08:31< celticminstrel> It wouldn't break typical use-cases.
20170522 15:08:59< DeFender1031> It's certainly not 100% backwards-compatible, but I find it hard to imagine anyone doing anything that it wouldn't cover.
20170522 15:09:02< celticminstrel> I don't know if anyone does unusual things with set_X_metatable that it would break, but if they did such things the returned table probably wouldn't have worked quite as expected anyway.
20170522 15:09:34< DeFender1031> anyway, you can't set the metatable to return stuff from wml.tag
20170522 15:09:36< DeFender1031> ?
20170522 15:10:08< celticminstrel> ?
20170522 15:29:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170522 15:30:54< celticminstrel> DeFender1031: So, about getting all the variables there's basically the proxy way and the non-proxy way. The latter would probably be wml.variable.get_all; the former could be wml.variable.all or all_proxy or proxy_all.
20170522 15:31:34< celticminstrel> Or proxy
20170522 15:32:07< DeFender1031> can't the metatable being assigned to the passed table be set to wml.tag?
20170522 15:32:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20170522 15:33:02< celticminstrel> Yes?
20170522 15:33:11< celticminstrel> Obviously that's what I'm doing.
20170522 15:33:29< celticminstrel> The metatable is local to the file (core.lua), so helper.lua won't have any access to it.
20170522 15:36:36< DeFender1031> I'm saying to use wml.tag as the metatable that helper.lua's set_tag_metatable assigns to the passed table.
20170522 15:37:04< DeFender1031> Whereas wml.tag itself has a metatable to the actual tags assigned to it.
20170522 15:37:12< celticminstrel> I guess I could create a "proxy" metatable that defers all access to wml.tag.
20170522 15:37:18< DeFender1031> It'll be a double-indirected metatable, but it should still work, no?
20170522 15:37:25< celticminstrel> Yeah, I think so.
20170522 15:37:26< DeFender1031> yeah, that's what I mean.
20170522 15:37:49< DeFender1031> So basically, you imlement wml.tag PROPERLY, and then have this weird double-redirect for the old stuff for back-compat.
20170522 15:38:36< DeFender1031> That way, the new stuff has no dependency on the back-compat, which can then be deprecated and ultimately discarded with no effect to the new API.
20170522 15:41:54< celticminstrel> And what about the question about naming choice I just asked?
20170522 15:51:56< celticminstrel> BTW I'm using "wml.tostring" for "wesnoth.debug".
20170522 15:55:15-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170522 15:57:10-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170522 15:57:18-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170522 15:57:46< celticminstrel> DeFender1031: Still here? ^
20170522 16:03:17-!- Duthlet [~Duthlet@dslb-188-106-028-224.188.106.pools.vodafone-ip.de] has quit [Quit: leaving]
20170522 16:05:52 * celticminstrel was waiting for someone to update the MSVC project before I push anything else. >_>
20170522 16:14:22-!- sevu [~Shiki@141.57.63.75] has joined #wesnoth-dev
20170522 16:16:26-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170522 16:17:16-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170522 16:17:48-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170522 16:18:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170522 16:19:21-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170522 16:19:21-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Read error: Connection reset by peer]
20170522 16:23:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170522 16:24:08-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170522 16:24:10-!- Kwandulin [~Kwandulin@p200300760F6D807968058356DAE4A116.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170522 16:50:08< grzywacz> hm.... the issue tracker on github seems to be full of really weird and old stuff that's still marked as open ;)
20170522 16:55:42-!- JyrkiVesterinen [~jyrki@89-166-106-94.bb.dnainternet.fi] has joined #wesnoth-dev
20170522 16:58:02< celticminstrel> grzywacz: Yeah, there are some things that should probably be closed, but no-one has gone through it in detail yet.
20170522 16:58:12< celticminstrel> There's even an open issue about this. :P
20170522 16:59:35-!- Kwandulin [~Kwandulin@p200300760F6D807968058356DAE4A116.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170522 17:03:44< sevu> maybe we can release 1.14 with a bug count lower than 500 :P
20170522 17:04:07< celticminstrel> Most of the issues aren't bugs, actually.
20170522 17:04:21-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170522 17:04:21< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release mattsc 451e22d: Update Xcode project Failed
20170522 17:04:21< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-347
20170522 17:04:26-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170522 17:05:02< sevu> yeah, mostly old things which have been discussed or nobody really knows how it is
20170522 17:05:17< celticminstrel> Mostly feature requests.
20170522 17:05:28-!- clavi [~clavi@v22017034422546657.goodsrv.de] has quit [Quit: ZNC - http://znc.in]
20170522 17:06:09-!- clavi [~clavi@v22017034422546657.goodsrv.de] has joined #wesnoth-dev
20170522 17:06:47< Soliton> i'd expect old entries to have been looked at by multiple people and there being a good reason that they're still open.
20170522 17:09:47< celticminstrel> Possibly.
20170522 17:11:32< irker190> wesnoth: Celtic Minstrel wesnoth:master 9365538b3b7a / / (29 files in 10 dirs): Don't store the user's password in plaintext in the prefs file https://github.com/wesnoth/wesnoth/commit/9365538b3b7aa7b48ac64990f3996d60ce11297c
20170522 17:11:34< irker190> wesnoth: Celtic Minstrel wesnoth:master c9191c98122d / / (22 files in 9 dirs): Add OpenSSL's libcrypto as a dependency https://github.com/wesnoth/wesnoth/commit/c9191c98122d97310eddae041a9fd3496cd5b894
20170522 17:11:36< irker190> wesnoth: Celtic Minstrel wesnoth:master 894ee4364397 / src/preferences/credentials.cpp: Use RC4 cipher for encrypting the password data. https://github.com/wesnoth/wesnoth/commit/894ee43643976199cf410cd2970550f6edb5fa76
20170522 17:11:38< irker190> wesnoth: Celtic Minstrel wesnoth:master ebe360dfa5e8 / src/preferences/credentials.cpp: Use RAII for all that zero-filling https://github.com/wesnoth/wesnoth/commit/ebe360dfa5e8f51496d0dda47c5928103829f967
20170522 17:11:40< irker190> wesnoth: Jyrki Vesterinen wesnoth:master 56433d12a3a2 / / (48 files in 15 dirs): Merge branch 'login_save_crypt' https://github.com/wesnoth/wesnoth/commit/56433d12a3a2c8eae923a34ca472b5dd7bfdd45c
20170522 17:13:30-!- clavi [~clavi@v22017034422546657.goodsrv.de] has quit [Quit: ZNC - http://znc.in]
20170522 17:14:56-!- clavi [~clavi@v22017034422546657.goodsrv.de] has joined #wesnoth-dev
20170522 17:17:56< celticminstrel> JyrkiVesterinen: I also just merged https://github.com/aquileia/external/pull/11
20170522 17:19:23< celticminstrel> Though that's only for 2013.
20170522 17:19:58< JyrkiVesterinen> Hmm. If other developer don't have time to build libcrypto with VS2015 and VS2017, I guess I can do it.
20170522 17:20:12< JyrkiVesterinen> But someone else would then need to merge my pull requests.
20170522 17:20:21< celticminstrel> I think I downloaded that from somewhere actually.
20170522 17:20:34< celticminstrel> I don't remember, it was awhile ago.
20170522 17:21:25< celticminstrel> wedge009 apparently confirmed that MSVC 2017 works with the exact same libs.
20170522 17:21:50< celticminstrel> On the other hand, they are a year or two old, but I don't expect that to be a serious problem as long as they're not used for releases.
20170522 17:22:06< celticminstrel> (And releases are currently built in MinGW, so...)
20170522 17:22:25< irker190> wesnoth: Jyrki Vesterinen wesnoth:master 5b2ae4c853fa / changelog players_changelog: Update changelog for PR #990 https://github.com/wesnoth/wesnoth/commit/5b2ae4c853fa11119dadb4850437335dc893eb36
20170522 17:22:32< celticminstrel> Oh right.
20170522 17:37:48-!- louis94 [~~louis94@95.129-200-80.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20170522 17:47:52-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170522 17:47:52< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug mattsc 451e22d: Update Xcode project Failed
20170522 17:47:52< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-347
20170522 17:47:55-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170522 17:53:36< grzywacz> celticminstrel: :D
20170522 17:53:44< celticminstrel> ?
20170522 17:54:04< grzywacz> The issue about there being so many issues thing.
20170522 17:54:07< grzywacz> I smiled. :)
20170522 17:54:18< grzywacz> Most of these feature requests should be closed. ;)
20170522 17:59:56< celticminstrel> If you have a github account, feel free to comment on them all and explain why. Or if there's a huge number of them, you could comment on the issue about cleaning up ported issues and list them all with a brief reasoning. Or you could do that in here if you prefer.
20170522 18:05:25-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170522 18:08:03-!- Kwandulin [~Kwandulin@p200300760F6D807968058356DAE4A116.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170522 18:16:47-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170522 18:16:47< Appveyor> The Battle for Wesnoth (Visual Studio 2017) - Release mattsc 451e22d: Update Xcode project Failed
20170522 18:16:47< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-30
20170522 18:16:51-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170522 18:21:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170522 18:32:02-!- Appleman1234 [~quassel@pl22492.ag1212.nttpc.ne.jp] has quit [Ping timeout: 245 seconds]
20170522 18:32:20-!- mjs-de [~mjs-de@x4e359681.dyn.telefonica.de] has joined #wesnoth-dev
20170522 18:42:27< zookeeper> Ravana_, what makes you think the book poster is a spammer?
20170522 18:42:38-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170522 18:42:38< Appveyor> The Battle for Wesnoth (Visual Studio 2017) - Debug mattsc 451e22d: Update Xcode project Failed
20170522 18:42:38< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-30
20170522 18:42:43-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170522 18:42:55< zookeeper> oh wait nevermind
20170522 18:42:59< zookeeper> i didn't notice the link first
20170522 18:47:43-!- gfgtdf [~chatzilla@x4e3639c0.dyn.telefonica.de] has joined #wesnoth-dev
20170522 18:58:50-!- atarocch [~atarocch@212.205.113.117] has joined #wesnoth-dev
20170522 19:03:07< DeFender1031> celticminstrel, back now. What's your question?
20170522 19:03:09< Ravana_> indeed, if it were book link, I would have let it be even
20170522 19:03:13< Ravana_> but some game
20170522 19:03:26< celticminstrel> [May 22@11:30:54am] celticminstrel: DeFender1031: So, about getting all the variables there's basically the proxy way and the non-proxy way. The latter would probably be wml.variable.get_all; the former could be wml.variable.all or all_proxy or proxy_all.
20170522 19:03:27< celticminstrel> [May 22@11:31:34am] celticminstrel: Or proxy
20170522 19:06:54< DeFender1031> what's the difference between them and why have both?
20170522 19:07:22-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170522 19:07:22< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release mattsc 451e22d: Update Xcode project Failed
20170522 19:07:22< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-345
20170522 19:07:26-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170522 19:07:36< celticminstrel> Well, wesnoth.get_all_vars returns a copy as a config but would allow arbitrary manipulations of the contents.
20170522 19:08:43< celticminstrel> The proxy either only works for scalar variables or requires proxy["my_variables[5].value"] syntax for nonscalars, if I recall correctly.
20170522 19:08:50< celticminstrel> (I could be wrong though.)
20170522 19:09:06< DeFender1031> hmm...
20170522 19:09:13< DeFender1031> gimme a bit, I'm being called for dinner.
20170522 19:09:15< celticminstrel> But at least for scalar variables it's more convenient because you can just fetch and assign as if it were a normal table.
20170522 19:09:18< DeFender1031> I'll give it some thought.
20170522 19:09:30< DeFender1031> Also, if you could verify that last point, that may factor into a proper name.
20170522 19:26:32< celticminstrel> gfgtdf, DeFender1031: So, apparently wesnoth.get_variable("some_container", false) returns an empty table. What's the point of this? Is there any point?
20170522 19:26:57< celticminstrel> (That's probably also be the default behaviour if you don't explicitly pass true.)
20170522 19:28:38< gfgtdf> celticminstrel: i don'T reall underand if there is any empty wml container 'some_container' thi is exactly what i'd epect
20170522 19:29:03< celticminstrel> gfgtdf: No, I mean it always returns an empty table regardless of what's actually in $some_container.
20170522 19:29:09< gfgtdf> celticminstrel: : i don't reall underand. If there is any empty wml container called 'some_container' this is exactly what i'd epect
20170522 19:29:11< gfgtdf> celticminstrel: hm ok
20170522 19:29:44< gfgtdf> celticminstrel: so even if it caontins data the retunred cteable is empty?
20170522 19:29:49< gfgtdf> table*
20170522 19:29:51< celticminstrel> Yes.
20170522 19:30:40< gfgtdf> celticminstrel: this soud unlikley, in particular it'd mena that the implemetation of [unstore_unit] and other tagas woudl _never_ work as exprected
20170522 19:30:46< vultraz_iOS> ok, where do i get the open ssl
20170522 19:31:07< celticminstrel> Somewhere! :O
20170522 19:31:45< gfgtdf> celticminstrel: whihc is sometihng we would have noticed i think.
20170522 19:31:46-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170522 19:31:46< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug mattsc 451e22d: Update Xcode project Failed
20170522 19:31:46< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-345
20170522 19:31:50-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170522 19:31:54< celticminstrel> Just google "openssl mingw binaries" or something?
20170522 19:32:35< vultraz_iOS> oh, it needs binaries...
20170522 19:33:18< celticminstrel> Or you can build it yourself.
20170522 19:33:30< celticminstrel> gfgtdf: Looking at [unstore_unit], I see what you mean...
20170522 19:34:08< celticminstrel> gfgtdf: But look at lua_common.cpp:864
20170522 19:34:29< celticminstrel> If that's not what that does, then what does it do?
20170522 19:34:57< celticminstrel> Note that this is called from intf_getvariable, so the second thing on the stack is presumed to be the second argument to wesnoth.get_variable.
20170522 19:35:02< gfgtdf> at last the this shodul th scond parmtr shodl dfatl to r so that by default it creates the whole table.
20170522 19:35:50< vultraz_iOS> well definitely looks like i need todo more than download the source
20170522 19:35:50< vultraz_iOS> :P
20170522 19:36:08< celticminstrel> vultraz_iOS: Well, obviously. You need a dll.
20170522 19:36:37< celticminstrel> gfgtdf: Do you see anything that makes it look like it defaults to true?
20170522 19:36:46< vultraz_iOS> how has JyrkiVesterinen build?
20170522 19:36:55< gfgtdf> celticminstrel: excpt the wiki entry, no i don't
20170522 19:37:36< celticminstrel> Hmm.
20170522 19:37:54< celticminstrel> That description makes it sound like it means the opposite of what I thought.
20170522 19:38:05< JyrkiVesterinen> vultraz_iOS: Please rephrase.
20170522 19:38:15< vultraz_iOS> built*
20170522 19:38:33< JyrkiVesterinen> I haven't built OpenSSL myself.
20170522 19:38:54< vultraz_iOS> ah
20170522 19:39:03< vultraz_iOS> then where might i acquire it
20170522 19:39:09< JyrkiVesterinen> I verified that master compiles with login_save_crypt merged... on GNU/Linux, where I already have the necessary libraries and headers installed.
20170522 19:39:19< vultraz_iOS> I see
20170522 19:39:23< celticminstrel> Would the binaries that work with MSVC work with GCC?
20170522 19:39:35< vultraz_iOS> So we both have yet to figure out how to build it on windows
20170522 19:39:36< celticminstrel> I suppose it's unlikely even for a C library?
20170522 19:39:58< celticminstrel> vultraz_iOS: aquileia/external already has it on the VC12 branch..
20170522 19:40:03< gfgtdf> celticminstrel: this code https://github.com/wesnoth/wesnoth/blob/1.13.8/data/multiplayer/scenarios/2p_Dark_Forecast.lua#L251 also assumes that it creates the whole table. And i'm quite sure i tested that code back wne  i wrote it
20170522 19:40:12< celticminstrel> So in theory the next MSVC 2013 build should pass.
20170522 19:40:32< vultraz_iOS> i see
20170522 19:40:38< JyrkiVesterinen> I think the VS project needs to be updated first.
20170522 19:40:42< celticminstrel> gfgtdf: So it sounds like passing true is supposed to enable the behaviour of returning an empty table, but I can't see how that works from the code.
20170522 19:40:46< vultraz_iOS> well i could take this opportunity to switch to MSVC :P
20170522 19:40:49< celticminstrel> JyrkiVesterinen: I was building on MSVC, so I doubt that?
20170522 19:41:06< celticminstrel> Oh, wait.
20170522 19:41:08< vultraz_iOS> the project was already updated i think
20170522 19:41:16< celticminstrel> That's assuming that I push my local changes too.
20170522 19:41:30< celticminstrel> Because it's still missing widget_helpers.cpp on master.
20170522 19:41:36< JyrkiVesterinen> Did anyone update the project for https://github.com/wesnoth/wesnoth/commit/246ea98dd93bb36c56d5a99e1a45395d587700c6 ?
20170522 19:42:06< celticminstrel> I did but haven't pushed it yet.
20170522 19:44:33< gfgtdf> celticminstrel: just tested (on 1.13.7) and it seem to work as expected: 
20170522 19:44:35< gfgtdf> wesnoth.set_variable("a.a.a.a", 6); print(#wesnoth.get_variable("a"))
20170522 19:44:38< gfgtdf> prints '1'
20170522 19:45:15< DeFender1031> celticminstrel, something like wml.variable.all and wml.variable.all_as_proxy?
20170522 19:46:24< gfgtdf> hm i think i see how it works
20170522 19:46:43< gfgtdf> (or worked)
20170522 19:47:19< celticminstrel> DeFender1031: Well, the proxy is a table but the other is a function.
20170522 19:47:31< gfgtdf> celticminstrel: when the second parmaters is not given then the thing at position #2 is actually the table that was pushed at the line above, so luaW_toboolean(L, 2) returns tue
20170522 19:47:52< celticminstrel> Aha.
20170522 19:48:05< gfgtdf> celticminstrel: this table i mean: https://github.com/wesnoth/wesnoth/blob/master/src/scripting/lua_common.cpp#L863
20170522 19:48:17< gfgtdf> celticminstrel: but this doesnt explain your error unless you ahev changes that code
20170522 19:48:29< celticminstrel> So does wesnoth.get_variable("a", true) not give an empty table?
20170522 19:48:56< celticminstrel> What about passing false instead of true?
20170522 19:49:02< celticminstrel> I think that would do it.
20170522 19:49:16< celticminstrel> IOW it sounds like the implementation was broken right from the start...
20170522 19:50:13-!- louis94 [~~louis94@95.129-200-80.adsl-dyn.isp.belgacom.be] has quit [Remote host closed the connection]
20170522 19:50:27< gfgtdf> in 1.13.7 you onyl get an empty table qwhen you explicitly pass false as the second argument.
20170522 19:50:40-!- louis94 [~~louis94@95.129-200-80.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20170522 19:50:52< celticminstrel> Yeah okay, so it was indeed broken from the start.
20170522 19:50:57< celticminstrel> Should I fix it or remove it?
20170522 19:54:15< gfgtdf> celticminstrel: the secodn argument is currently only used by 'helper.set_wml_var_metatable'
20170522 19:54:41< celticminstrel> DeFender1031: So basically the proxy is a little "weak". proxy[name] is equivalent to wesnoth.get_variable(name) and proxy[name] = val is equivalent to wesnoth.set_variable(name, val), except that on get it returns a new proxy for containers rather than returning the actual container.
20170522 19:55:06< celticminstrel> You cannot do eg proxy.some_container[5].some_value to access the variable $some_container[5].some_value
20170522 19:55:23< celticminstrel> gfgtdf: Yeah, so fixing it would mean changing it to false there, probably.
20170522 19:55:42< celticminstrel> ...I suppose instead of moving it to core I could implement a new, better variable proxy system..,
20170522 19:56:12< gfgtdf> celticminstrel: probably as an optimisation beasue that code just want to know whether a vriable is a container or a asalar.
20170522 19:56:52< gfgtdf> celticminstrel: ye i don't realyl care what you do to the secodn arugment,argeument, i doubt anyone other code than set_wml_var_metatable uses it.
20170522 20:00:16< gfgtdf> celticminstrel: if you want to implement set_wml_var_metatabl diffetntly you can also remove the second argeument.
20170522 20:19:57< celticminstrel> gfgtdf: Do you know if it's possible to have two variables by the same name, one a scalar and one a container?
20170522 20:20:18< celticminstrel> I know the WML config format allows this, but not sure if the variable system does too.
20170522 20:20:40< vultraz_iOS> JyrkiVesterinen: https://wiki.openssl.org/index.php/Binaries
20170522 20:22:08< gfgtdf> celticminstrel: i think it is possible to do set_varaible("a", {});set_varaible("a", 9) and then both will be in the gamedata::variables wml object.
20170522 20:22:24< gfgtdf> celticminstrel: not sure what you'll get when you do get_variable("a") then.
20170522 20:22:40< celticminstrel> get_variable favours scalars.
20170522 20:23:09< gfgtdf> hm ok
20170522 20:23:10< celticminstrel> But in theory you'd still be able to access the container version through eg get_variable("a.val"), I think.
20170522 20:23:11-!- irker190 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170522 20:23:16< celticminstrel> I'll try it out.
20170522 20:32:45< vultraz_iOS> god dammit
20170522 20:32:58< vultraz_iOS> it looks like we've regressed since .7 :|
20170522 20:33:19< celticminstrel> ?
20170522 20:33:39-!- gfgtdf [~chatzilla@x4e3639c0.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 53.0.3/20170518000419]]
20170522 20:35:27< vultraz_iOS> https://forums.wesnoth.org/viewtopic.php?p=612899#p612899
20170522 20:35:32< vultraz_iOS> REGRESSION
20170522 20:36:34-!- vultraz_iOS changed the topic of #wesnoth-dev to: Emergency 1.13.9 scheduled for as soon as we get these bugs fixed | Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Discord Server: https://discord.gg/tSmJS2E | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20170522 20:36:43< matthiaskrgr> D: 
20170522 20:41:48< celticminstrel> It's kind of nice to hear that I'm not the only one getting the crash in the file dialog though.
20170522 20:42:07< vultraz_iOS> but what is the cause!
20170522 20:42:33< celticminstrel> It's actually possible that it's ancestral's fault.
20170522 20:42:45< celticminstrel> When I investigated it, I didn't find anything that made sense.
20170522 20:42:58< celticminstrel> Which leads me to wonder if it's a case of incompatible binaries or something.
20170522 20:43:17< vultraz_iOS> im not sure why that guy is getting menu errors though
20170522 20:43:26< vultraz_iOS> stuff displays fine in master for me :/
20170522 20:43:44< celticminstrel> Same here.
20170522 20:44:05< celticminstrel> Oh, I can test the menu thing.
20170522 20:44:11< celticminstrel> Well, on Windows though.
20170522 20:44:26< celticminstrel> Maybe I should get a Mac build going again at some point, too.
20170522 20:45:26< vultraz_iOS> and there's that image quality bug
20170522 20:45:33< vultraz_iOS> absolutely 0 ideahow to fix that
20170522 20:46:02< celticminstrel> It doesn't find any Japanese fonts, but the menu isn't showing in English if I switch to Japanese anyway.
20170522 20:46:34< vultraz_iOS> ;_;
20170522 20:46:38< vultraz_iOS> we broke shit
20170522 20:46:44< celticminstrel> Actually, does he even have the translations?
20170522 20:46:54< celticminstrel> Did ancestral include the translations in the 1.13.8 bundle?
20170522 20:47:02< celticminstrel> He did post having some problem with them.
20170522 20:47:07< vultraz_iOS> im not sure
20170522 20:47:08< vultraz_iOS> ill check
20170522 20:47:32< vultraz_iOS> but in which case, fallback text is broken
20170522 20:47:43< celticminstrel> If by checking you mean asking him, sure.
20170522 20:47:48< celticminstrel> What? No?
20170522 20:47:53< celticminstrel> What are you talking about?
20170522 20:48:11< celticminstrel> Fallback in the event of missing translations is to show the English, which is clearly what happens in his screenshot.
20170522 20:48:19< vultraz_iOS> uh
20170522 20:48:20< vultraz_iOS> no?
20170522 20:48:32< celticminstrel> Yes? "Terrain Description" for example.
20170522 20:48:34< vultraz_iOS> all three custom menu items have no text!
20170522 20:48:44< celticminstrel> That's probably a separate issue.
20170522 20:49:22 * vultraz_iOS curses 
20170522 20:49:34< vultraz_iOS> SO MANY BUGS
20170522 20:49:48< celticminstrel> The "image quality" as he calls it should probably be a 1.14 blocker.
20170522 20:50:08< vultraz_iOS> that randomly appeared between 1.13.4 and 5 i think
20170522 20:50:16< vultraz_iOS> but i have no idea what caused it or how to fix it
20170522 20:50:19< vultraz_iOS> it's impossible
20170522 20:50:32< celticminstrel> Like I said, it should probably be a blocker.
20170522 20:50:43< vultraz_iOS> but it's impossible to fix
20170522 20:50:46< celticminstrel> So?
20170522 20:50:51< celticminstrel> Well.
20170522 20:50:56< zookeeper> what, the alpha scaling bug?
20170522 20:50:57< celticminstrel> Nothing is impossible to fix.
20170522 20:51:10< celticminstrel> zookeeper: https://forums.wesnoth.org/download/file.php?id=75663
20170522 20:51:13< vultraz_iOS> it's a bug in the implementation of the linear scaling algorithm 
20170522 20:51:18-!- Appleman1234 [~quassel@pl22492.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170522 20:51:23< zookeeper> celticminstrel, that's what i said
20170522 20:51:37< celticminstrel> vultraz_iOS: Okay, so fix the linear scaling algorithm? :P
20170522 20:51:45< vultraz_iOS> :|
20170522 20:52:01< vultraz_iOS> yes, let me get my resident expert on linear scaling algorithms 
20170522 20:52:35< vultraz_iOS> plus, i can't do anything right now since i can't build
20170522 20:52:36< vultraz_iOS> at all
20170522 20:52:52< celticminstrel> The binaries from that link earlier should work, though?
20170522 20:53:37< sevu> vultraz_iOS, with image quality bug, maybe it's an image with alpha? If so, there are plenty of bug reports with alpha scaling
20170522 20:53:49< vultraz_iOS> yes
20170522 20:53:54< vultraz_iOS> it's exactly that
20170522 20:53:59< vultraz_iOS> but god knows how to fix it
20170522 20:54:06-!- mjs-de [~mjs-de@x4e359681.dyn.telefonica.de] has quit [Remote host closed the connection]
20170522 20:54:28< zookeeper> well where's the code for it?
20170522 20:55:34< celticminstrel> vultraz_iOS, zookeeper, do you know any specific places where it happens in mainline content?
20170522 20:55:38< vultraz_iOS> scale_surface in sdl/utils.cpp:255
20170522 20:55:43< vultraz_iOS> celticminstrel: help :|
20170522 20:55:47< vultraz_iOS> with the Mage of Light 
20170522 20:55:53< celticminstrel> Okay.
20170522 20:56:48< vultraz_iOS> celticminstrel: i assume i want OSSL 1.1.0... lite or regular? 32 bit or 64 bit?
20170522 20:57:08< vultraz_iOS> ah, regular
20170522 20:57:20< celticminstrel> 32/64 should probably match your GCC.
20170522 20:57:22< vultraz_iOS> and im guessing 32 since wesnoth isn't 64 bt
20170522 20:57:27< celticminstrel> No idea on lite vs regular.
20170522 20:57:36< celticminstrel> You specifically need libcrypto.
20170522 20:57:43< celticminstrel> (Or it might be libeay.)
20170522 20:58:00< celticminstrel> (At least, it is in my version.)
20170522 20:59:26-!- midzer [~quassel@2001:41d0:a:2255::1] has quit [Remote host closed the connection]
20170522 20:59:28< vultraz_iOS> this is an installer tho
20170522 20:59:58< celticminstrel> Hmm.
20170522 21:00:02-!- midzer [~quassel@2001:41d0:a:2255::1] has joined #wesnoth-dev
20170522 21:02:15-!- midzer [~quassel@2001:41d0:a:2255::1] has quit [Remote host closed the connection]
20170522 21:02:19< celticminstrel> vultraz_iOS: FTR, "Light" probably excludes MD5 (since it's deprecated) which would be a problem for us.
20170522 21:02:41< vultraz_iOS> regular is recommended for development i t says
20170522 21:03:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 255 seconds]
20170522 21:04:09< celticminstrel> I assume it'll install dlls somewhere and you might have to move/copy them to the place that GCC looks (or set up your project to make GCC look where they actually are).
20170522 21:04:17< celticminstrel> (dlls and headers)
20170522 21:04:55-!- louis94 [~~louis94@95.129-200-80.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 258 seconds]
20170522 21:10:48-!- sevu [~Shiki@141.57.63.75] has quit [Ping timeout: 240 seconds]
20170522 21:11:04-!- sevu [~Shiki@141.57.63.75] has joined #wesnoth-dev
20170522 21:13:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170522 21:14:09-!- JyrkiVesterinen [~jyrki@89-166-106-94.bb.dnainternet.fi] has quit [Quit: .]
20170522 21:32:19-!- irker410 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170522 21:32:19< irker410> wesnoth: Celtic Minstrel wesnoth:master 80a87d0b4970 / projectfiles/VC12/ (wesnoth.vcxproj wesnoth.vcxproj.filters): Update MSVC project https://github.com/wesnoth/wesnoth/commit/80a87d0b4970684ecff2a667bab97ee72047cccf
20170522 21:32:19< irker410> wesnoth: Celtic Minstrel wesnoth:master 39dad27260d6 / data/lua/wml/modify_side.lua src/scripting/game_lua_kernel.cpp: [modify_side][ai] with ai_algorithm now replaces the AI (fixes #1216) https://github.com/wesnoth/wesnoth/commit/39dad27260d6b9b9f07c9a53139c9003f7566758
20170522 21:32:20< irker410> wesnoth: Celtic Minstrel wesnoth:master e741655138d3 / src/game_config_manager.cpp: Deploy a set and range-for https://github.com/wesnoth/wesnoth/commit/e741655138d33e60d23cabd4ca7cb5a2d00dea79
20170522 21:32:21< irker410> wesnoth: Celtic Minstrel wesnoth:master 238d70ee22bc / data/core/_main.cfg data/core/about.cfg data/core/about_i18n.cfg src/about.cpp: Allow grouping credits with [credits_group] (except in [campaign]) https://github.com/wesnoth/wesnoth/commit/238d70ee22bcfaaaa22bb31ceebe6d8b478e3a7b
20170522 21:32:22< irker410> wesnoth: Celtic Minstrel wesnoth:master 89e6aeee1627 / src/units/filter.cpp: Standard Unit Filter: Make "id=" match no units https://github.com/wesnoth/wesnoth/commit/89e6aeee1627217ead8923f1a11c632d671ec53c
20170522 21:32:23< irker410> wesnoth: Celtic Minstrel wesnoth:master bdb16867ee14 / src/gui/dialogs/end_credits.cpp: Small cleanup of end credits display for 238d70ee22 https://github.com/wesnoth/wesnoth/commit/bdb16867ee1429709a2577594d6c0c133904ef8e
20170522 21:32:25< irker410> wesnoth: Celtic Minstrel wesnoth:master b1e4b83014fc / data/core/about_i18n.cfg src/gui/dialogs/end_credits.cpp: Sort translation team credits by localized language name (closes #1104) https://github.com/wesnoth/wesnoth/commit/b1e4b83014fccc8fc3255d47f058771156755441
20170522 21:32:27< irker410> wesnoth: Celtic Minstrel wesnoth:master c0f926e2ed76 / data/lua/ (core.lua helper.lua): Move all WML and variable manipulator functions into new wml table https://github.com/wesnoth/wesnoth/commit/c0f926e2ed7614aaa9b45d71eecabdd7a04e4add
20170522 21:32:29< irker410> wesnoth: Celtic Minstrel wesnoth:master 8492e8d63946 / data/lua/helper.lua: Use standard deprecation mechanism for helper.distance_between https://github.com/wesnoth/wesnoth/commit/8492e8d639469bd8b691f0fc98cefb28783456f7
20170522 21:32:31< irker410> wesnoth: Celtic Minstrel wesnoth:master 30caf6149a74 / data/lua/helper.lua: Show Lua deprecation warnings to chat only in debug mode, but always log them to https://github.com/wesnoth/wesnoth/commit/30caf6149a74705e34b4d35188f1468150dd0655
20170522 21:32:33< irker410> wesnoth: Celtic Minstrel wesnoth:master c480e5c98990 / changelog: Update changelog https://github.com/wesnoth/wesnoth/commit/c480e5c989908a30c85b5bb694d9126e9ad16a3b
20170522 21:32:35< irker410> wesnoth: Celtic Minstrel wesnoth:master b63ee4863243 / data/core/ (about.cfg about_i18n.cfg): No idea why that was there, but it shouldn't be sorted with the languages https://github.com/wesnoth/wesnoth/commit/b63ee4863243494b72bfc7e7723745a83fb11dbc
20170522 21:32:37< irker410> wesnoth: Celtic Minstrel wesnoth:master c67d524cedc7 / data/lua/wml/kill.lua: Fix [kill] not affecting recall list units https://github.com/wesnoth/wesnoth/commit/c67d524cedc7e668c0996c5cb6fc3d2e5ba4198e
20170522 21:32:39< irker410> wesnoth: Celtic Minstrel wesnoth:master 9f0c677d02c8 / data/lua/core.lua src/scripting/lua_common.cpp: Remove the optional second argument to wesnoth.get_variable https://github.com/wesnoth/wesnoth/commit/9f0c677d02c89a81cc960f9277a0bc40f1a5805e
20170522 21:33:33< celticminstrel> Thinking of adding wml.var.is_scalar and wml.var.is_container.
20170522 21:34:12< celticminstrel> Also, someone should now mass-replace wesnoth/helper functions with wml functions.
20170522 21:34:47< celticminstrel> (Also [editor_group] with [terrain_group] or something.)
20170522 21:59:58< sevu> do_not_list does hide the units in the list for placing them in debug mode
20170522 22:00:16< sevu> Does someone remember when it got introduced? Asking because I would like to update the wiki
20170522 22:02:08< zookeeper> vultraz_iOS, so what's the problem with scaling the images using an algorithm that doesn't do that weird alpha thing?
20170522 22:03:17< zookeeper> it's not like we don't have them.
20170522 22:03:53< zookeeper> i don't understand the complex mess of various scaling functions + the scaling preference options, and how they interact and what gets used in which situation etc
20170522 22:06:32< zookeeper> from what i can gather, scale_surface is supposed to do bilinear interpolation, but cbeck added that alpha thresholding thing (which causes the problem) because of some issue with the hex selector.
20170522 22:07:24< zookeeper> so... is the alpha thresholding still actually needed for anything? has anyone checked that?
20170522 22:10:33< zookeeper> correction: he disabled the alpha thresholding in d73a1172 but then it was added back in 5f967950
20170522 22:12:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170522 22:12:43< zookeeper> and then vultraz removed the old function in 4af0e815
20170522 22:12:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170522 22:14:13< zookeeper> i have no more time for it tonight but i don't see why anyone would call it impossible to sort out. there's a special alpha thresholding thing for some purpose, no one apparently knows if it's actually needed, and we have also functional code without it that works as one would expect.
20170522 22:17:33< vultraz_iOS> zookeeper: because other algorithms produce the wrong result
20170522 22:18:00< vultraz_iOS> zookeeper: for example, if you scale portraits with NN, the result is rather... rough
20170522 22:18:05< vultraz_iOS> you'd have to look at it to see what i mean
20170522 22:18:16< vultraz_iOS> but NN is best for pixel scaling
20170522 22:18:19< zookeeper> dude, no one said anything about NN
20170522 22:18:51< vultraz_iOS> you did :|
20170522 22:19:03< vultraz_iOS> you asked about alternate scaling methods
20170522 22:19:10< vultraz_iOS> so I'm saying why we can't use the other ones
20170522 22:19:32< vultraz_iOS> obviously we can't use XBRZ either.
20170522 22:19:37< zookeeper> good grief
20170522 22:20:40< vultraz_iOS> ...
20170522 22:20:50< vultraz_iOS> then what the hell DID you want to hear
20170522 22:21:49< zookeeper> since i no longer believe that you know what the problem actually is, i guess nothing :>
20170522 22:22:02< vultraz_iOS> .......
20170522 22:22:03< vultraz_iOS> ffs
20170522 22:23:17< zookeeper> scale_surface_legacy did not have the weird thing. scale_surface has the weird thing. do we need to have the weird thing?
20170522 22:23:44< vultraz_iOS> scale_surface_legacy doesn't exist
20170522 22:23:51< zookeeper> thanks, captain obvious
20170522 22:24:23< vultraz_iOS> FFS
20170522 22:24:29< vultraz_iOS> cut the attitude.
20170522 22:25:03< vultraz_iOS> Why can't we ever just discuss an issue without you pulling some passive-aggressive crap on me.
20170522 22:25:41< zookeeper> i'm not a zen master
20170522 22:28:14< zookeeper> the relevant question is, do we need the alpha thresholding for anything?
20170522 22:28:55< zookeeper> because if we don't, remove it. if we do need it, then don't use it unless necessary.
20170522 22:29:20< vultraz_iOS> I don't know.
20170522 22:29:31< zookeeper> all right then, neither do i
20170522 22:31:41< zookeeper> but that's where my approximately 10 minutes of looking into the problem (compile times excluded) led me
20170522 22:36:08-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 246 seconds]
20170522 22:45:23-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170522 22:46:05< vultraz_iOS> celticminstrel: ok, is there now a new credentials folder in userdata?
20170522 22:51:15< vultraz_iOS> celticminstrel: do i need libcrypto or libssl or both?
20170522 22:55:26< vultraz_iOS> looks like i only need libcrypto
20170522 23:03:29< vultraz_iOS> oh, it's a credentials file
20170522 23:03:40< irker410> wesnoth: Charles Dang wesnoth:master 922cc201bc4d / projectfiles/CodeBlocks/wesnoth.cbp: Updated CB projectfile https://github.com/wesnoth/wesnoth/commit/922cc201bc4dc8613addac3f0f992bd9a05bca70
20170522 23:04:31< vultraz_iOS> celticminstrel: why does a new credentials file have a single 'p' in it.
20170522 23:04:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170522 23:05:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170522 23:07:20< irker410> wesnoth: Charles Dang wesnoth:master 2f7165d0612b / data/gui/window/ (mp_login.cfg preferences/05_multiplayer.cfg): GUI2: update prompts about saving passwords https://github.com/wesnoth/wesnoth/commit/2f7165d0612bd7c06166b512901a59beb6067330
20170522 23:25:08< celticminstrel> Who knows!
20170522 23:25:41< irker410> wesnoth: Charles Dang wesnoth:master d0a36ec41ccc / src/ (sdl/utils.cpp video.cpp): Replace SDL_SWSURFACE with 0 as per SDL2 recommendations https://github.com/wesnoth/wesnoth/commit/d0a36ec41cccd17b419140a4976929c62b4f80dd
20170522 23:27:32< celticminstrel> "p" is probably what you (non-generic you) get from encrypting a string consisting solely of the record separator (formfeed).
20170522 23:28:10< vultraz_iOS> i see
20170522 23:30:37-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170522 23:51:13< vultraz_iOS> is there a difference between T operator*(); and operator T*();?
--- Log closed Tue May 23 00:00:35 2017