--- Log opened Sat May 27 00:00:04 2017
20170527 00:01:59-!- Appleman1234 [~quassel@pl22492.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170527 00:02:17-!- Appleman1234 [~quassel@pl22492.ag1212.nttpc.ne.jp] has quit [Client Quit]
20170527 00:05:10-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170527 00:11:43< celmin|sleep> Whee, building Boost with clang 4.
20170527 00:11:55< celmin|sleep> Tooooooons of waenings.
20170527 00:11:59< celmin|sleep> ^warnings
20170527 00:13:22< matthiaskrgr> hmm
20170527 00:13:35< matthiaskrgr> oh wait, boost, not wesnoth
20170527 00:13:55< matthiaskrgr> btw does testrunner crash for you?
20170527 00:14:35< matthiaskrgr> I'm getting this, not sure if its some kind of clang related bug or wesnoth bug  https://pastebin.com/BWXNwGgS  
20170527 00:14:43< matthiaskrgr> haven't tried clean rebuild though
20170527 00:18:31< celmin|sleep> I haven't been able to run it since I switched to working primarily on Windows.
20170527 00:19:21< matthiaskrgr> :(
20170527 00:19:50< celmin|sleep> If I get a working Mac build again, or if someone can add Boost.Test to aquileia/external for VC12, then I'll try it.
20170527 00:20:00< matthiaskrgr> huh, boost compiles with gcc aktough I set export CC=clang 
20170527 00:20:37< celmin|sleep> Just noticed Boost is skipping mpi. No idea what that is, probably doesn't matter.
20170527 00:21:39< matthiaskrgr> gn
20170527 00:23:24-!- irker819 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170527 00:23:24< irker819> wesnoth: Matthias Krüger wesnoth:master 4d28f268bfd8 / src/scripting/game_lua_kernel.hpp: fix -Winconsistent-missing-override warnings by clang. (#1719) https://github.com/wesnoth/wesnoth/commit/4d28f268bfd83a8d87dd810dc7873d050f49b20f
20170527 00:28:04-!- celmin|sleep is now known as celticminstrel
20170527 00:28:27< vultraz_iOS> matthiaskrgr: I'll fix
20170527 00:29:01< celticminstrel> The null pointer access?
20170527 00:29:07< celticminstrel> I guess I'll close that log then.
20170527 00:29:20< celticminstrel> (I left it open to "get to it later". >_> )
20170527 00:29:37< celticminstrel> Well, okay, four separate null pointer accesses, I guess.
20170527 00:29:50< vultraz_iOS> four?
20170527 00:29:51< vultraz_iOS> well then
20170527 00:31:51< celticminstrel> ...it gives the line numbers right there, four of them so...
20170527 00:38:07-!- Appleman1234 [~quassel@pl22492.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170527 00:38:15-!- Appleman1234 [~quassel@pl22492.ag1212.nttpc.ne.jp] has quit [Read error: Connection reset by peer]
20170527 00:38:35-!- Appleman1234 [~quassel@pl22492.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170527 00:42:40< irker819> wesnoth: Charles Dang wesnoth:master 762db98da1a8 / src/ (7 files in 2 dirs): Moved clear_screen to CVideo and made use of it instead of calling sdl::window:: https://github.com/wesnoth/wesnoth/commit/762db98da1a8ba18a288b09f7a70432a786a7d29
20170527 00:42:51< vultraz_iOS> should fix
20170527 00:50:24< irker819> wesnoth: Celtic Minstrel wesnoth:master 646bedb08811 / data/lua/helper.lua: Reverse the Lua API deprecations for the time being. https://github.com/wesnoth/wesnoth/commit/646bedb088116d3c4d091efd72a1f1a14d27a38a
20170527 00:52:48< celticminstrel> vultraz_iOS: So what about the three in src/sdl/window.cpp? Are they covered by that too?
20170527 00:52:58< vultraz_iOS> should be
20170527 00:53:02< vultraz_iOS> well, maybe not
20170527 00:53:03< vultraz_iOS> I'll see
20170527 00:56:22< celticminstrel> Looks like there's a small regression with AMLAs?
20170527 00:57:59< vultraz_iOS> probably a very simple thing
20170527 01:00:36< vultraz_iOS> celticminstrel: https://hg.icculus.org/icculus/steamshim/file/tip/README.txt
20170527 01:00:41< vultraz_iOS> useful?
20170527 01:05:26< celticminstrel> Maybe, but I probably wouldn't consider making use of it until after 1.14. Achievements, stats, etc aren't really essential Steam features. The essential features are cloud support and login integration, both of which (IIUC) can be done without the Steamworks API.
20170527 01:05:30< vultraz_iOS> as for the alma thing it's possibly if (advance["always_display"]) should have  .to_bool
20170527 01:05:57< celticminstrel> I'd expect that to implicitly convert to bool.
20170527 01:06:04< vultraz_iOS> then i dunno
20170527 01:06:15< vultraz_iOS> thecode looks correct otherwise
20170527 01:08:00< celticminstrel> Leaving out to_bool() would probably result in the compiler choosing to call operator int() which calls to_int().
20170527 01:11:06-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170527 01:15:20-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Ping timeout: 246 seconds]
20170527 01:16:22< celticminstrel> Oh yeah, vultraz_iOS 
20170527 01:16:30< celticminstrel> When are you going to go through the credits.
20170527 01:17:08< vultraz_iOS> uhhh
20170527 01:17:10< vultraz_iOS> not sure
20170527 01:17:15< vultraz_iOS> closer to 1.14 probaby
20170527 01:17:17-!- Bonobo [~Bonobo@2001:44b8:254:3200:fc4d:6695:7a81:4cdf] has joined #wesnoth-dev
20170527 01:17:40< celticminstrel> As long as you don't release 1.14 without having done so.
20170527 01:19:27-!- RatArmy_ [~ratarmy@om126212240067.14.openmobile.ne.jp] has quit [Ping timeout: 260 seconds]
20170527 01:23:48< celticminstrel> Did ancestral not push the notifications fix and project update yet? Could you poke him about it?
20170527 01:24:11< vultraz_iOS> i didnt see him push anything
20170527 01:24:39< celticminstrel> He said he'd push it yesterday IIRC.
20170527 01:26:40-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20170527 01:28:56-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170527 02:02:46-!- travis-ci [~travis-ci@ec2-54-166-84-225.compute-1.amazonaws.com] has joined #wesnoth-dev
20170527 02:02:47< travis-ci> wesnoth/wesnoth#13983 (master - 4d28f26 : Matthias Krüger): The build has errored.
20170527 02:02:47< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/236569666
20170527 02:02:47-!- travis-ci [~travis-ci@ec2-54-166-84-225.compute-1.amazonaws.com] has left #wesnoth-dev []
20170527 02:54:03-!- travis-ci [~travis-ci@ec2-54-166-84-225.compute-1.amazonaws.com] has joined #wesnoth-dev
20170527 02:54:04< travis-ci> wesnoth/wesnoth#13984 (master - 762db98 : Charles Dang): The build has errored.
20170527 02:54:04< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/236572454
20170527 02:54:04-!- travis-ci [~travis-ci@ec2-54-166-84-225.compute-1.amazonaws.com] has left #wesnoth-dev []
20170527 02:57:42< vultraz_iOS> celticminstrel: looks like tests are fine except for the lua warnings
20170527 02:59:13< celticminstrel> Which should be gone now.
20170527 03:02:01< vultraz_iOS> sweet
20170527 03:11:09-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20170527 03:21:12-!- Appleman1234 [~quassel@pl22492.ag1212.nttpc.ne.jp] has quit [Remote host closed the connection]
20170527 03:23:23< SigurdFD> Thanks all for the assistance with libcrypto. I got it working.
20170527 03:23:33< SigurdFD> Used version linked at the bottom of: http://www.blogcompiler.com/2011/12/21/openssl-for-windows/
20170527 03:23:35< celticminstrel> \o/
20170527 03:23:37< SigurdFD> It originally had the same error as my try with 0.9.8h yesterday "src\hash.cpp:20:25: fatal error: openssl/sha.h: No such file or directory"
20170527 03:23:52< SigurdFD> but I fixed it by putting a copy of the openssl directory with all the includes inside wesnoth/src
20170527 03:25:30< celticminstrel> Uh. Okay then.
20170527 03:25:36-!- Appleman1234 [~quassel@pl22492.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170527 03:26:02< celticminstrel> I mean, sure it would work, but that's really not where it should go...
20170527 03:26:46< celticminstrel> Well... if you don't feel like digging further, you should probably at least add it in your .git/exclude so that you don't accidentally commit it one day.
20170527 03:26:48< SigurdFD> yeah, but I don't know how I would tell it to look elsewhere
20170527 03:27:08< SigurdFD> I did, thanks for mentioning
20170527 03:27:19< SigurdFD> maybe I'll dig at it later on
20170527 03:29:24-!- travis-ci [~travis-ci@ec2-54-145-193-192.compute-1.amazonaws.com] has joined #wesnoth-dev
20170527 03:29:25< travis-ci> wesnoth/wesnoth#13985 (master - 646bedb : Celtic Minstrel): The build passed.
20170527 03:29:25< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/236573225
20170527 03:29:25-!- travis-ci [~travis-ci@ec2-54-145-193-192.compute-1.amazonaws.com] has left #wesnoth-dev []
20170527 03:41:32< shadowm> https://forums.wesnoth.org/viewtopic.php?p=613126#p613126
20170527 03:41:42< shadowm> loonycyborg or vultraz_iOS.
20170527 04:49:09-!- Kwandulin [~Kwandulin@p200300760F6D80337118F18185305EB0.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170527 04:53:27-!- RatArmy_ [~ratarmy@om126212084132.11.openmobile.ne.jp] has joined #wesnoth-dev
20170527 05:02:50< irker819> wesnoth: Charles Dang wesnoth:master 515f450432cd / src/gui/widgets/styled_widget.cpp: GUI2/Styled Widget: use move schematics to greatly reduce the amount of canvas c https://github.com/wesnoth/wesnoth/commit/515f450432cda01d4c79dd1b7b546af191584450
20170527 05:25:21-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has quit []
20170527 05:38:10-!- RatArmy_ [~ratarmy@om126212084132.11.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170527 06:10:36-!- Jetrel [~Jetrel@c-73-228-139-39.hsd1.mn.comcast.net] has quit [Quit: "The highest possible stage in moral culture is when we recognize that we ought to control our thoughts." - Charles Darwin]
20170527 06:11:42-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has joined #wesnoth-dev
20170527 06:38:35-!- RatArmy_ [~ratarmy@om126212084132.11.openmobile.ne.jp] has joined #wesnoth-dev
20170527 06:45:09-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170527 06:54:10-!- RatArmy_ [~ratarmy@om126212084132.11.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170527 07:33:56-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 258 seconds]
20170527 07:35:35-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170527 08:09:20-!- RatArmy_ [~ratarmy@om126211112027.13.openmobile.ne.jp] has joined #wesnoth-dev
20170527 08:12:42< loonycyborg> shadowm: the wiki thinks that tarball sums should go into releases/
20170527 08:12:48< loonycyborg> while they're in root dir
20170527 08:12:54< loonycyborg> for like forever
20170527 08:29:16-!- RatArmy_ [~ratarmy@om126211112027.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170527 08:29:41-!- RatArmy_ [~ratarmy@om126211112027.13.openmobile.ne.jp] has joined #wesnoth-dev
20170527 08:49:06-!- RatArmy_ [~ratarmy@om126211112027.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170527 08:52:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170527 09:09:40-!- RatArmy_ [~ratarmy@om126211112027.13.openmobile.ne.jp] has joined #wesnoth-dev
20170527 09:18:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170527 09:59:34-!- RatArmy_ [~ratarmy@om126211112027.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170527 10:17:19-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170527 10:23:07-!- Kwandulin [~Kwandulin@p200300760F6D80337118F18185305EB0.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170527 10:24:10-!- RatArmy_ [~ratarmy@om126211112027.13.openmobile.ne.jp] has joined #wesnoth-dev
20170527 10:40:40-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170527 10:43:09-!- RatArmy_ [~ratarmy@om126211112027.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170527 10:51:39-!- RatArmy_ [~ratarmy@om126211112027.13.openmobile.ne.jp] has joined #wesnoth-dev
20170527 11:10:48-!- RatArmy_ [~ratarmy@om126211112027.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170527 11:10:58-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has quit [Ping timeout: 240 seconds]
20170527 11:24:27-!- prkc [~prkc@catv-80-98-103-2.catv.broadband.hu] has joined #wesnoth-dev
20170527 11:24:38-!- RatArmy_ [~ratarmy@om126211112027.13.openmobile.ne.jp] has joined #wesnoth-dev
20170527 11:52:13-!- irker819 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170527 12:06:22-!- Kwandulin [~Kwandulin@p200300760F6D80337118F18185305EB0.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170527 12:23:05-!- Kwandulin2 [~Kwandulin@p200300760F6D807B51A16BF2083253D6.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170527 12:26:01-!- Kwandulin [~Kwandulin@p200300760F6D80337118F18185305EB0.dip0.t-ipconnect.de] has quit [Ping timeout: 272 seconds]
20170527 12:29:30-!- RatArmy_ [~ratarmy@om126211112027.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170527 12:32:08-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Write error: Broken pipe]
20170527 12:32:16-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Excess Flood]
20170527 12:32:17-!- Ivanovic [~ivanovic@p4FC534A6.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170527 12:33:10-!- RatArmy_ [~ratarmy@om126211112027.13.openmobile.ne.jp] has joined #wesnoth-dev
20170527 12:33:31-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20170527 12:39:22-!- Bonobo [~Bonobo@2001:44b8:254:3200:fc4d:6695:7a81:4cdf] has quit [Ping timeout: 246 seconds]
20170527 13:16:43-!- irker028 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170527 13:16:43< irker028> wesnoth: loonycyborg wesnoth:master 059fdf0ad415 / src/server/ (send_receive_wml_helpers.ipp simple_wml.cpp simple_wml.hpp): Made simple_wml's document size limit configurable https://github.com/wesnoth/wesnoth/commit/059fdf0ad415a5fb5ac7e4503d1429b32348f72a
20170527 13:16:43< irker028> wesnoth: loonycyborg wesnoth:master b0af2f848c3a / src/campaign_server/ (campaign_server.cpp campaign_server.hpp): Made document size limit settable via campaignd's config file https://github.com/wesnoth/wesnoth/commit/b0af2f848c3ad46ba54780cd20de9651bead0aec
20170527 13:39:36-!- Kwandulin2 [~Kwandulin@p200300760F6D807B51A16BF2083253D6.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170527 13:53:47-!- Appleman1234 [~quassel@pl22492.ag1212.nttpc.ne.jp] has quit [Remote host closed the connection]
20170527 14:49:45-!- Kwandulin [~Kwandulin@p200300760F6D807B51A16BF2083253D6.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170527 15:05:46-!- Appleman1234 [~quassel@pl22492.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170527 15:07:19-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170527 15:21:59-!- louis94 [~~louis94@95.129-200-80.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20170527 15:27:42-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:c83b:89b0:e80f:cb3b] has joined #wesnoth-dev
20170527 15:31:51-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:c83b:89b0:e80f:cb3b] has quit [Read error: Connection reset by peer]
20170527 15:32:25-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170527 15:35:20-!- louis94 [~~louis94@95.129-200-80.adsl-dyn.isp.belgacom.be] has quit [Quit: Konversation terminated!]
20170527 15:35:34-!- louis94 [~~louis94@95.129-200-80.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20170527 15:36:24-!- louis94 [~~louis94@95.129-200-80.adsl-dyn.isp.belgacom.be] has quit [Client Quit]
20170527 15:45:29-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170527 15:56:00-!- RatArmy_ [~ratarmy@om126211112027.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170527 16:03:10-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Read error: Connection reset by peer]
20170527 16:08:36-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170527 16:17:05-!- irker028 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170527 16:19:53-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170527 16:24:40-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170527 16:33:36-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170527 16:37:28< shadowm> loonycyborg: Move them to releases/. I told you this when I set up the new wiki template, I'm fairly sure.
20170527 16:37:49< loonycyborg> oh
20170527 16:37:55< loonycyborg> probably I forgot
20170527 16:40:43< loonycyborg> moved
20170527 16:45:06-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170527 16:45:39-!- irker542 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170527 16:45:39< irker542> wesnoth: Ignacio R. Morelle wesnoth:master 1b8dcbb2b6b7 / src/campaign_server/campaign_server.hpp: campaignd: Make default upload limit actually 100 MiB https://github.com/wesnoth/wesnoth/commit/1b8dcbb2b6b72ada56f1e7731e8e3d6c0f9ee4be
20170527 16:56:10-!- prkc [~prkc@catv-80-98-103-2.catv.broadband.hu] has quit [Ping timeout: 268 seconds]
20170527 16:56:27-!- atarocch [~atarocch@93.56.160.28] has quit [Ping timeout: 240 seconds]
20170527 16:56:59-!- atarocch [~atarocch@93.56.160.28] has joined #wesnoth-dev
20170527 17:01:40-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170527 17:03:28-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Ping timeout: 240 seconds]
20170527 17:25:49-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170527 17:27:42-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170527 17:32:12-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170527 17:47:24-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev
20170527 17:55:47-!- DeFender1031 [~DeFender1@46-116-209-76.bb.netvision.net.il] has joined #wesnoth-dev
20170527 18:00:12-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170527 18:04:42-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has quit [Ping timeout: 240 seconds]
20170527 18:06:32-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev
20170527 18:07:07-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170527 18:27:59< vultraz_iOS> celticminstrel: there is a noticeable performance increase
20170527 18:28:23< celticminstrel> That's missing the point.
20170527 18:28:53< vultraz_iOS> and i already profiled the number of canvases constructed 
20170527 18:28:57< vultraz_iOS> you saw the numbers :|
20170527 18:29:21< celticminstrel> Define "profile".
20170527 18:29:32< celticminstrel> Did it involve calculating timings?
20170527 18:29:40< vultraz_iOS> No timings
20170527 18:29:47< vultraz_iOS> would be rather hard
20170527 18:30:08< celticminstrel> Why do you say that?
20170527 18:31:48< vultraz_iOS> well, I suppose I could have measured the time it takes to create a single canvas and multiplied that by 807
20170527 18:32:10< celticminstrel> Why would it be rather hard?
20170527 18:32:31< celticminstrel> If you want to time construction of an object...
20170527 18:32:51< vultraz_iOS> i was thinking i needed to add logging everywhere it was created in order to time it
20170527 18:34:30< celticminstrel> ... I think something like this should work. https://pastebin.com/dXi8aLi1
20170527 18:34:37< celticminstrel> Though that's assuming it has no base classs.
20170527 18:35:14< celticminstrel> If it has base classes, I think you'd need to move the ticks_start bit to the first base class but leave the ticks_end bit in the class you're measuring.
20170527 18:36:29< celticminstrel> If on the other hand you just want to log the process of creating a dialog, it should suffice to add the logging around that particular dialog.
20170527 18:36:39< celticminstrel> ^time
20170527 18:36:52< celticminstrel> ("time" replacing "log")
20170527 18:37:33< vultraz_iOS> alright, i set up a scenario to log the creation time of a single canvas
20170527 18:38:42-!- Kwandulin [~Kwandulin@p200300760F6D807B51A16BF2083253D6.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170527 18:38:48< vultraz_iOS> looks like I was wrong about expense. < 1 MS.
20170527 18:38:55< celticminstrel> (Just FTR, you shouldn't assume that the creation time of a canvas is constant. It could depend on input.)
20170527 18:39:22< vultraz_iOS> no, a canvas takes no arguments
20170527 18:39:39< celticminstrel> (Also, when profiling, you should generally run it 1000 or more times and take the average.)
20170527 18:40:34< vultraz_iOS> looks like it always prints out as 0 MS
20170527 18:41:17< celticminstrel> [May 27@2:39:22pm] vultraz_iOS: no, a canvas takes no arguments
20170527 18:41:18< celticminstrel> Don't you think you're measuring the wrong constructor?
20170527 18:41:31< celticminstrel> You were talking about copies, so you need the copy constructor, right?
20170527 18:41:40< vultraz_iOS> ah, that too
20170527 18:43:45-!- DeFender1031 [~DeFender1@46-116-209-76.bb.netvision.net.il] has quit [Quit: I'm not back now.]
20170527 18:46:43< vultraz_iOS> huh
20170527 18:46:48< vultraz_iOS> for some reason this isn't compiling
20170527 18:46:49< vultraz_iOS> oh well
20170527 18:47:04< vultraz_iOS> also i just realized this is a default-initialized canvas
20170527 18:47:12< vultraz_iOS> the other canvas were initialized with shape data
20170527 18:47:18< vultraz_iOS> that would also affect time
20170527 18:47:19-!- DeFender1031 [~DeFender1@46-116-209-76.bb.netvision.net.il] has joined #wesnoth-dev
20170527 18:48:18< celticminstrel> Yup.
20170527 19:02:27-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20170527 19:03:47-!- Kwandulin [~Kwandulin@p200300760F6D807B51A16BF2083253D6.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170527 19:08:27-!- Bonobo [~Bonobo@2001:44b8:254:3200:74b9:afb1:ccf4:807] has joined #wesnoth-dev
20170527 19:12:12-!- Appleman1234 [~quassel@pl22492.ag1212.nttpc.ne.jp] has quit [Ping timeout: 260 seconds]
20170527 19:12:32< vultraz_iOS> celticminstrel: are we leaving in the whiteboard?
20170527 19:12:34< vultraz_iOS> for 1.14
20170527 19:13:57-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:c83b:89b0:e80f:cb3b] has joined #wesnoth-dev
20170527 19:15:23< celticminstrel> I dunno. Does it work without crashing?
20170527 19:17:01< celticminstrel> And with full functionality? IIRC there were problems with either "suppose dead" or "recruit",
20170527 19:17:08< celticminstrel> BTW, did you poke ancestral yet?
20170527 19:18:38< Ravana_> if keeping it, I would suggest changing its default hotkey to something less likely to be unintentionally used
20170527 19:22:55< celticminstrel> I propose adopting this or something similar. https://forums.wesnoth.org/viewtopic.php?f=31&t=41525
20170527 19:24:53-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:c83b:89b0:e80f:cb3b] has quit [Remote host closed the connection]
20170527 19:26:19< vultraz_iOS> celticminstrel: not yet
20170527 19:28:17< vultraz_iOS> i have now done so
20170527 19:28:57< irker542> wesnoth: Charles Dang wesnoth:master 81d5fed52646 / src/gui/widgets/settings.cpp: GUI2/Settings: range-for https://github.com/wesnoth/wesnoth/commit/81d5fed5264609b5271c3fd6a4c7e17afa8fa4e4
20170527 19:29:00< irker542> wesnoth: Charles Dang wesnoth:master cee80a52f1c7 / src/gui/widgets/settings.cpp: GUI2/Settings: formatting update https://github.com/wesnoth/wesnoth/commit/cee80a52f1c7c3d62c0017ed122b44af57332172
20170527 19:34:07-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170527 19:36:27-!- RatArmy_ [~ratarmy@om126200120232.15.openmobile.ne.jp] has joined #wesnoth-dev
20170527 19:38:38-!- sevu [~Shiki@p54856218.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170527 19:46:12-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:c83b:89b0:e80f:cb3b] has joined #wesnoth-dev
20170527 19:54:28-!- Ivanovic [~ivanovic@p4FC534A6.dip0.t-ipconnect.de] has quit [Quit: Disconnecting from stoned server.]
20170527 19:54:44-!- Ivanovic [~ivanovic@p4FC534A6.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170527 20:06:08-!- boucman [~rosen@wesnoth/developer/boucman] has left #wesnoth-dev []
20170527 20:08:01-!- Appleman1234 [~quassel@pl22492.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170527 20:10:12-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:c83b:89b0:e80f:cb3b] has quit [Remote host closed the connection]
20170527 20:11:40-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170527 20:12:28-!- Kwandulin [~Kwandulin@p200300760F6D807B51A16BF2083253D6.dip0.t-ipconnect.de] has quit [Quit: [endlevel] result=novictorynodefeatjustquit [/endlevel]]
20170527 20:13:12-!- RatArmy_ [~ratarmy@om126200120232.15.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170527 20:36:04-!- travis-ci [~travis-ci@ec2-54-158-63-3.compute-1.amazonaws.com] has joined #wesnoth-dev
20170527 20:36:05< travis-ci> wesnoth/wesnoth#13989 (master - cee80a5 : Charles Dang): The build has errored.
20170527 20:36:05< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/236737608
20170527 20:36:05-!- travis-ci [~travis-ci@ec2-54-158-63-3.compute-1.amazonaws.com] has left #wesnoth-dev []
20170527 20:40:20-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20170527 20:43:34-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 255 seconds]
20170527 21:06:09-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170527 21:07:54< vultraz_iOS> celticminstrel: [string "-- join.lua --..."]:98: attempt to call a nil value (field 'chat')
20170527 21:07:57< vultraz_iOS> one build one
20170527 21:07:59< vultraz_iOS> only
20170527 21:08:06< celticminstrel> ?
20170527 21:08:12< vultraz_iOS> in tests
20170527 21:13:56-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170527 21:22:04-!- RatArmy_ [~ratarmy@om126212248169.14.openmobile.ne.jp] has joined #wesnoth-dev
20170527 22:29:40-!- irker542 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170527 22:41:01-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 255 seconds]
20170527 22:44:03-!- RatArmy_ [~ratarmy@om126212248169.14.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170527 22:59:12-!- RatArmy_ [~ratarmy@om126212248169.14.openmobile.ne.jp] has joined #wesnoth-dev
20170527 23:02:03-!- RatArmy_ [~ratarmy@om126212248169.14.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170527 23:02:09-!- RatArmy_ [~ratarmy@om126212248169.14.openmobile.ne.jp] has joined #wesnoth-dev
20170527 23:08:36-!- RatArmy_ [~ratarmy@om126212248169.14.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170527 23:29:07-!- Ivanovic [~ivanovic@p4FC534A6.dip0.t-ipconnect.de] has quit [Changing host]
20170527 23:29:07-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20170527 23:29:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170527 23:44:49< vultraz_iOS> celticminstrel: 
20170527 23:44:51< vultraz_iOS> "Yes I did, but I haven’t pushed out a new package containing that patch(edited)
20170527 23:44:51< vultraz_iOS> Does that fix the crashing issue?"
20170527 23:44:57< vultraz_iOS> - ancestral
20170527 23:46:07-!- Bonobo [~Bonobo@2001:44b8:254:3200:74b9:afb1:ccf4:807] has quit [Ping timeout: 260 seconds]
20170527 23:51:07-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170527 23:51:13-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170527 23:53:39-!- sevu [~Shiki@p54856218.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20170527 23:54:37< celticminstrel> vultraz_iOS: ???
20170527 23:54:47< vultraz_iOS> you asked me to ask ancestral
20170527 23:54:50< vultraz_iOS> if he pushed the thing
20170527 23:54:56< celticminstrel> Yes, to master.
20170527 23:55:06< celticminstrel> I don't see any commits from him, did I miss them?
20170527 23:55:38< celticminstrel> The notifications patch is unrelated to the crash BTW.
20170527 23:55:40< vultraz_iOS> will ask
20170527 23:56:24< celticminstrel> I'd like him to push the notifications patch and (separately) his XCode project update to master.
20170527 23:57:09< celticminstrel> Should I talk in #wesnoth instead so that he can see on Discord? I don't mind doing that sometimes.
20170527 23:57:27< vultraz_iOS> I don't think messages sent via the bot ping
20170527 23:57:43< vultraz_iOS> you could join discord and talk to him directly :|
20170527 23:57:50< vultraz_iOS> (though he's not there right now)
20170527 23:57:50< celticminstrel> I imagine they do if you @them.
--- Log closed Sun May 28 00:00:03 2017