--- Log opened Thu Jun 01 00:00:41 2017
20170601 00:03:23-!- gfgtdf [~chatzilla@x4e3635e3.dyn.telefonica.de] has joined #wesnoth-dev
20170601 00:10:47< vultraz_iOS> celticminstrel: we concluded we needed two functions, right?
20170601 00:11:28< celticminstrel> Yeah, I think so.
20170601 00:11:49< vultraz_iOS> blah
20170601 00:11:55< vultraz_iOS> i feel lazy now
20170601 00:13:13< celticminstrel> Then revert? :P
20170601 00:15:42< celticminstrel> That's the lazy route.
20170601 00:19:06< vultraz_iOS> https://www.irccloud.com/pastebin/pQGypheu/
20170601 00:19:09< vultraz_iOS> this alright?
20170601 00:21:09< celticminstrel> As long as you don't remove that if < 0 check.
20170601 00:21:19< celticminstrel> <= I mean
20170601 00:21:30< vultraz_iOS> should be == 0 now
20170601 00:21:37< celticminstrel> Sure.
20170601 00:23:21-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170601 00:31:06< irker380> wesnoth: Charles Dang wesnoth:master 14c6d534ea5a / src/ (5 files in 4 dirs): Fixup 9faf17747 https://github.com/wesnoth/wesnoth/commit/14c6d534ea5a3628c752685d94b9f099c8b04ef6
20170601 00:31:10< vultraz_iOS> celticminstrel: ^
20170601 00:37:59-!- RatArmy_ [~ratarmy@om126204160001.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170601 00:39:10-!- RatArmy_ [~ratarmy@om126204160001.6.openmobile.ne.jp] has joined #wesnoth-dev
20170601 00:53:05-!- Bonobo [~Bonobo@2001:44b8:254:3200:48f7:4879:d3ae:dfa4] has joined #wesnoth-dev
20170601 01:00:44< shadowm> Just FYI Forum Moderators (the ones with green names, not those shoddy red-colored discount mods we get shipped from overseas sweatshops) can now ban people.
20170601 01:01:18< shadowm> So if you can't find a Forum Administrator to deal with a spambot, a Forum Moderator is the second best thing.
20170601 01:05:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170601 01:10:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170601 01:14:32< irker380> wesnoth: sigurdfdragon wesnoth:master d5d297818c58 / data/campaigns/Secrets_of_the_Ancients/scenarios/ (16_The_Mage.cfg 17_Mortality.cfg 20_North_Knalga.cfg): SotA: Clear variables when no longer needed https://github.com/wesnoth/wesnoth/commit/d5d297818c582a72e107310dfd848a624e98c607
20170601 01:42:40-!- gfgtdf_ [~chatzilla@x4e368fb3.dyn.telefonica.de] has joined #wesnoth-dev
20170601 01:43:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170601 01:44:37-!- gfgtdf [~chatzilla@x4e3635e3.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170601 01:44:50-!- gfgtdf_ is now known as gfgtdf
20170601 01:51:47-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170601 01:51:54-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170601 02:14:16-!- RatArmy_ [~ratarmy@om126204160001.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170601 02:31:02-!- RatArmy_ [~ratarmy@om126204160001.6.openmobile.ne.jp] has joined #wesnoth-dev
20170601 02:38:07-!- gfgtdf [~chatzilla@x4e368fb3.dyn.telefonica.de] has quit [Remote host closed the connection]
20170601 02:47:39-!- RatArmy_ [~ratarmy@om126204160001.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170601 02:57:01-!- RatArmy_ [~ratarmy@om126204160001.6.openmobile.ne.jp] has joined #wesnoth-dev
20170601 02:59:25-!- RatArmy_ [~ratarmy@om126204160001.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170601 03:06:22-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has quit []
20170601 03:49:01-!- celticminstrel is now known as celmin|sleep
20170601 03:52:22-!- RatArmy_ [~ratarmy@om126204160001.6.openmobile.ne.jp] has joined #wesnoth-dev
20170601 03:55:08-!- RatArmy_ [~ratarmy@om126204160001.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170601 03:55:57-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20170601 04:12:42-!- Kwandulin [~Kwandulin@p200300760F42AA86C05498A166111D6B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170601 04:15:41-!- irker380 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170601 04:16:23-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Ping timeout: 240 seconds]
20170601 04:17:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170601 04:22:29-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 255 seconds]
20170601 04:50:50-!- aeth_ is now known as aeth
20170601 05:00:30-!- RatArmy_ [~ratarmy@om126211126141.13.openmobile.ne.jp] has joined #wesnoth-dev
20170601 05:05:10-!- RatArmy_ [~ratarmy@om126211126141.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170601 05:08:26-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has quit [Read error: Connection reset by peer]
20170601 05:08:32-!- Jetrel_ [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has joined #wesnoth-dev
20170601 05:22:20-!- RatArmy_ [~ratarmy@om126211126141.13.openmobile.ne.jp] has joined #wesnoth-dev
20170601 05:29:24-!- RatArmy_ [~ratarmy@om126211126141.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170601 05:38:39-!- RatArmy_ [~ratarmy@om126211126141.13.openmobile.ne.jp] has joined #wesnoth-dev
20170601 05:43:28-!- RatArmy_ [~ratarmy@om126211126141.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170601 05:44:44-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20170601 05:53:02-!- Jollacz [~sailfish@93.157.158.220] has joined #wesnoth-dev
20170601 06:05:35-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Ping timeout: 240 seconds]
20170601 06:06:13-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170601 06:10:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170601 06:26:21-!- RatArmy_ [~ratarmy@om126211126141.13.openmobile.ne.jp] has joined #wesnoth-dev
20170601 06:29:12-!- RatArmy_ [~ratarmy@om126211126141.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170601 06:31:29-!- RatArmy_ [~ratarmy@om126211126141.13.openmobile.ne.jp] has joined #wesnoth-dev
20170601 06:37:31-!- atarocch [~atarocch@93.56.160.28] has joined #wesnoth-dev
20170601 06:41:33-!- RatArmy_ [~ratarmy@om126211126141.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170601 06:44:50-!- Kwandulin [~Kwandulin@p200300760F42AA86C05498A166111D6B.dip0.t-ipconnect.de] has quit [Quit: [endlevel] result=novictorynodefeatjustquit [/endlevel]]
20170601 06:45:01-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 245 seconds]
20170601 06:49:34-!- JyrkiVesterinen [~JyrkiVest@85-76-66-132-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170601 07:01:33-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170601 07:10:11-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170601 07:10:43-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170601 07:10:52-!- RatArmy_ [~ratarmy@om126211126141.13.openmobile.ne.jp] has joined #wesnoth-dev
20170601 07:15:17-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 255 seconds]
20170601 07:24:44< zookeeper> what the f...
20170601 07:28:27< zookeeper> why does the HttT:SoE thief-spawning village capture event trigger _3_ times? -.-
20170601 07:28:34-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170601 07:29:25< zookeeper> it's nice that you get 12 thieves instead of 4, but...
20170601 07:30:43< zookeeper> oh, wow. of course.
20170601 07:31:21< zookeeper> some of the thieves spawn onto a village, triggering the event again, which is apparently possible because the original event hasn't yet finished so it's still triggerable even though it's first_time_only=yes
20170601 07:31:23-!- RatArmy_ [~ratarmy@om126211126141.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170601 07:32:09< zookeeper> i'd expect that's a recent change in behavior
20170601 07:34:43< zookeeper> indeed, it doesn't happen in 1.12 (which was expected because of course we'd know if it did)
20170601 07:36:05-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20170601 07:36:39< zookeeper> a-ah, no it's actually tad's fault
20170601 07:37:01< zookeeper> it used to be a moveto event, with which the re-triggering didn't happen
20170601 07:39:21< Soliton> still sounds like a bug that first_time_only events can be triggered more than once.
20170601 07:39:51< zookeeper> yeah
20170601 07:42:14< vultraz_iOS> hey don't look at me
20170601 07:43:12< zookeeper> hey, for once i wasn't :p
20170601 07:48:49-!- Jetrel_ [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has quit [Quit: "The highest possible stage in moral culture is when we recognize that we ought to control our thoughts." - Charles Darwin]
20170601 07:49:05-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Ping timeout: 240 seconds]
20170601 07:49:47-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has joined #wesnoth-dev
20170601 07:54:34-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170601 07:58:48-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170601 07:59:00-!- Jollacz [~sailfish@93.157.158.220] has quit [Ping timeout: 260 seconds]
20170601 08:06:14-!- irker466 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170601 08:06:14< irker466> wesnoth: ln-zookeeper wesnoth:master 2d13860baa92 / data/campaigns/Heir_To_The_Throne/scenarios/06_The_Siege_of_Elensefar.cfg: HttT S06: Reverted d6f7de91 and 9b364d25 due to major bugs they caused https://github.com/wesnoth/wesnoth/commit/2d13860baa928ffcfcef922371d36fde6e94eaac
20170601 08:06:16< zookeeper> kids, don't refactor without testing.
20170601 08:08:15< zookeeper> eh, slightly mistaken description and commit references.
20170601 08:13:40< irker466> wesnoth: ln-zookeeper wesnoth:master 1e870bcb87ac / data/campaigns/Heir_To_The_Throne/scenarios/06_The_Siege_of_Elensefar.cfg: HttT S06: Fixed 0594ebd1 to use a moveto event instead https://github.com/wesnoth/wesnoth/commit/1e870bcb87ac8e932b56e1f9641bd35de8f4dcf1
20170601 08:16:39< vultraz_iOS> you should still fix the bug
20170601 08:17:10< vultraz_iOS> or couldn't you have used [remove_event]
20170601 08:19:13< zookeeper> yes, someone possibly should still fix the bug
20170601 08:19:48< zookeeper> and yes i might have been able to fix the problem in many different ways
20170601 08:21:02< zookeeper> right now i'm wondering why do you get one loyal thief more if you choose to have them reinforce you.
20170601 08:21:31< zookeeper> 3 from the ford, 4 from the city. that's not very nice.
20170601 08:27:43< vultraz_iOS> makes sense though
20170601 08:27:47< vultraz_iOS> they're more friendly :P
20170601 08:50:22< Ravana_> I see that wesnoth -p alone does not collect all core macro definitions, but if I first run it with --preprocess-output-macros, and then --preprocess-input-macros, then it works
20170601 08:55:39-!- JyrkiVesterinen [~JyrkiVest@85-76-66-132-nat.elisa-mobile.fi] has quit [Quit: .]
20170601 09:08:53-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170601 09:22:10-!- Duthlet [~Duthlet@dslb-188-105-125-191.188.105.pools.vodafone-ip.de] has joined #wesnoth-dev
20170601 09:26:06-!- JyrkiVesterinen [~JyrkiVest@85-76-66-132-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170601 09:26:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170601 09:42:50-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170601 09:47:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170601 09:55:16-!- RatArmy_ [~ratarmy@om126211124061.13.openmobile.ne.jp] has joined #wesnoth-dev
20170601 09:57:24-!- RatArmy_ [~ratarmy@om126211124061.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170601 10:01:12-!- Kwandulin [~Kwandulin@p200300760F42AA86C05498A166111D6B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170601 10:39:26-!- RatArmy_ [~ratarmy@om126211124061.13.openmobile.ne.jp] has joined #wesnoth-dev
20170601 10:49:13-!- RatArmy_ [~ratarmy@om126211124061.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170601 11:08:25-!- Kwandulin [~Kwandulin@p200300760F42AA86C05498A166111D6B.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170601 11:18:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170601 11:31:10-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170601 11:35:28-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 255 seconds]
20170601 11:47:28-!- Jollacz [~sailfish@93.157.158.220] has joined #wesnoth-dev
20170601 11:47:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170601 12:00:02-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 260 seconds]
20170601 12:06:14-!- irker466 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170601 12:23:44-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170601 12:25:15< zookeeper> sigh. if i create a [unit] then it obeys whatever facing= i give it. but if i create it atx,y=recall,recall and then [recall] it, it always gets facing=n
20170601 12:29:40-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 260 seconds]
20170601 12:36:12-!- Jollacz [~sailfish@93.157.158.220] has quit [Ping timeout: 260 seconds]
20170601 12:36:33-!- Jollacz [~sailfish@93.157.158.220] has joined #wesnoth-dev
20170601 13:11:21< zookeeper> okay, so... when a unit is [recall]ed, it's set to face towards the nearest enemy (or if there is none, then towards the center of the map) and there's no way to override that.
20170601 13:13:23-!- Appleman1234 [~quassel@pl40388.ag1212.nttpc.ne.jp] has quit [Ping timeout: 240 seconds]
20170601 13:19:26-!- irker298 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170601 13:19:26< irker298> wesnoth: ln-zookeeper wesnoth:master c618bf10f5d7 / data/campaigns/Heir_To_The_Throne/scenarios/06_The_Siege_of_Elensefar.cfg: HttT S06: Defined starting facings for the thieves https://github.com/wesnoth/wesnoth/commit/c618bf10f5d742f345f8d4c13985cc75583afcfa
20170601 13:22:57 * zookeeper runs into the first occurrence of wanting/needing to look up an old gna patch discussion
20170601 13:23:02< zookeeper> good thing that i got them
20170601 13:28:07< Soliton> what format are those?
20170601 13:29:20< zookeeper> xml
20170601 13:29:52< Soliton> we could put them somewhere on wesnoth.org, at least as a file download.
20170601 13:30:05< zookeeper> yeah, certainly
20170601 13:30:38-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170601 13:31:23< zookeeper> gee, darth fool, "changed AMLA to use macros" doesn't quite describe this... https://github.com/wesnoth/wesnoth/commit/53922cff#diff-b75046f0f2223f235191da9d6a545bc5
20170601 13:32:05< zookeeper> i was just looking into why there are AI parameters for targeting/protecting kalenz in the first HttT scenario
20170601 13:32:14< zookeeper> looks like it's been there for a while :p
20170601 13:35:57-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 240 seconds]
20170601 13:37:51< zookeeper> Soliton, wanna upload it somewhere if i hand you the file?
20170601 13:38:01< Soliton> sure.
20170601 13:38:13-!- Appleman1234 [~quassel@pl40388.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170601 13:39:27< zookeeper> great. it doesn't include attachments, of course, just everything else.
20170601 13:39:38< Soliton> btw, afair darth fool was the one trying to get the AI to play through HttT by itself.
20170601 13:40:12< zookeeper> maybe, but kalenz still wasn't going to make an appearance in the first scenario, i imagine :p
20170601 13:40:15< Soliton> so i'm guessing those AI parameters where supposed to aid in that.
20170601 13:40:36< Soliton> yeah, no idea about that.
20170601 13:46:25-!- Bonobo [~Bonobo@2001:44b8:254:3200:48f7:4879:d3ae:dfa4] has quit [Ping timeout: 246 seconds]
20170601 13:48:23-!- Jollacz [~sailfish@93.157.158.220] has quit [Ping timeout: 240 seconds]
20170601 14:01:22< Soliton> so the gna patch export xml is now available on files.wesnoth.org if anyone is interested.
20170601 14:02:15< Soliton> or if anyone has a better idea where to put it...
20170601 14:04:14< Soliton> (there are private patches in there but i doubt there is any reason for any of those to remain private.)
20170601 14:04:29< zookeeper> if someone needs to look at some old patch discussion, then maybe they'll think to ask here, and then maybe someone will remember that the file is there... :p
20170601 14:05:37< zookeeper> yeah all the private issues don't seem to really have anything private in them
20170601 14:25:12-!- JyrkiVesterinen [~JyrkiVest@85-76-66-132-nat.elisa-mobile.fi] has quit [Quit: .]
20170601 14:30:08-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170601 14:32:59-!- travis-ci [~travis-ci@ec2-54-224-31-172.compute-1.amazonaws.com] has joined #wesnoth-dev
20170601 14:33:00< travis-ci> wesnoth/wesnoth#14043 (master - c618bf1 : ln-zookeeper): The build has errored.
20170601 14:33:00< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/238340214
20170601 14:33:00-!- travis-ci [~travis-ci@ec2-54-224-31-172.compute-1.amazonaws.com] has left #wesnoth-dev []
20170601 14:43:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170601 14:44:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170601 14:45:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20170601 14:46:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170601 14:47:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170601 14:49:13-!- Kwandulin [~Kwandulin@p200300760F42AA86C05498A166111D6B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170601 14:58:19-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170601 15:02:32-!- gfgtdf [~chatzilla@x4e36ae00.dyn.telefonica.de] has joined #wesnoth-dev
20170601 15:02:41< gfgtdf> zookeeper: what exactly was fixed by 1e870bcb87ac8e932b56e1f9641bd35de8f4dcf1 ?
20170601 15:04:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170601 15:09:28-!- Kwandulin [~Kwandulin@p200300760F42AA86C05498A166111D6B.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170601 15:10:09-!- Kwandulin [~Kwandulin@p200300760F42AA86C05498A166111D6B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170601 15:10:27< Ravana_> does 1.13.1+ [set_menu_item] synced=no work 1) when it is not the players turn, 2) for observers?
20170601 15:11:18< zookeeper> gfgtdf, when it used a capture event, the placement of the thieves re-triggered that event (because when you place a unit on a village, it captures it), whereas a moveto event won't
20170601 15:12:39< zookeeper> gfgtdf, so the engine bug that remains is that apparently even a first_time_only=yes event can be fired several times, as long as it happens before the first instance of that event has finished
20170601 15:12:54< zookeeper> for example, a capture event which places a unit on a village, triggering the capture event again, etc
20170601 15:19:31< gfgtdf> Ravana_: it shoudl work for both, but you can use flters to disable it.
20170601 15:19:40< Ravana_> thanks
20170601 15:20:37< gfgtdf> zookeeper: hmm ye that sounds liek an engine bug
20170601 15:35:50-!- mjs-de [~mjs-de@x4e3122f3.dyn.telefonica.de] has joined #wesnoth-dev
20170601 15:59:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170601 16:03:41-!- JyrkiVesterinen [~JyrkiVest@89-166-125-107.bb.dnainternet.fi] has joined #wesnoth-dev
20170601 16:13:01-!- RatArmy_ [~ratarmy@om126211124061.13.openmobile.ne.jp] has joined #wesnoth-dev
20170601 16:20:25-!- irker298 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170601 16:31:35-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170601 16:32:05-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170601 16:32:18-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170601 16:32:33-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170601 16:41:47-!- Kwandulin [~Kwandulin@p200300760F42AA86C05498A166111D6B.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170601 16:51:57-!- RatArmy_ [~ratarmy@om126211124061.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170601 16:55:52-!- RatArmy_ [~ratarmy@om126211124061.13.openmobile.ne.jp] has joined #wesnoth-dev
20170601 16:57:40< gfgtdf> zookeeper: hmm usually this code https://github.com/wesnoth/wesnoth/blob/master/src/game_events/handlers.cpp#L122 shoudl 'disable' this event before executing the handler to recursive executionof first_time only events shouldn't be possible
20170601 17:00:56< gfgtdf> zookeeper: ok quite sure this commit borke it be665e29f111ad6c8ef1e8410a08608a405554cc
20170601 17:01:05< gfgtdf> vultraz: please fix that ^
20170601 17:01:23< gfgtdf> https://github.com/wesnoth/wesnoth/commit/be665e29f111ad6c8ef1e8410a08608a405554cc *
20170601 17:01:25< zookeeper> <vultraz_iOS> hey don't look at me
20170601 17:16:29-!- Kwandulin [~Kwandulin@p200300760F42AA86C05498A166111D6B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170601 17:27:54-!- RatArmy_ [~ratarmy@om126211124061.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170601 17:36:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170601 17:42:13-!- Duthlet [~Duthlet@dslb-188-105-125-191.188.105.pools.vodafone-ip.de] has quit [Quit: leaving]
20170601 18:16:22-!- Kwandulin2 [~Kwandulin@p200300760F42AAAF196E91179970D17B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170601 18:17:46-!- Kwandulin [~Kwandulin@p200300760F42AA86C05498A166111D6B.dip0.t-ipconnect.de] has quit [Ping timeout: 255 seconds]
20170601 18:22:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170601 18:28:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170601 18:34:24-!- Kwandulin [~Kwandulin@p200300760F42AAAF196E91179970D17B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170601 18:34:47-!- Kwandulin2 [~Kwandulin@p200300760F42AAAF196E91179970D17B.dip0.t-ipconnect.de] has quit [Ping timeout: 255 seconds]
20170601 18:57:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170601 18:58:03-!- janebot_ [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170601 18:58:03-!- janebot_ is now known as janebot
20170601 18:59:05-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170601 19:03:10-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 246 seconds]
20170601 19:05:50-!- horrowind [~Thunderbi@p2003008E6C6171DB964452FFFE0220ED.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170601 19:09:55< Ravana_> what is the _main.cfg.plain file about when using wesnoth -p? Its over 200 MB, so I can't really analyse it, but seems that it has huge amount of line feed symbols
20170601 19:12:12< zookeeper> wesnoth --help is mighty useless, at least on my own master build. i run it (from a command prompt), and it just pops up _another_ command prompt which closes immediately after the output is done. -.-
20170601 19:15:01< Ravana_> with 1.13.8 it exits current process, but starts new one in same console
20170601 19:16:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170601 19:22:36< JyrkiVesterinen> zookeeper: The cause is that Wesnoth restarts itself on startup if OpenMP is enabled.
20170601 19:22:37< JyrkiVesterinen> https://github.com/wesnoth/wesnoth/blob/master/src/wesnoth.cpp#L979-L1004
20170601 19:22:46< JyrkiVesterinen> OpenMP is enabled by default in MSVC builds.
20170601 19:28:40-!- irker200 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170601 19:28:40< irker200> wesnoth: Nils Kneuper wesnoth:master 96263bf54002 / po/ (6 files in 6 dirs): updated British English translation https://github.com/wesnoth/wesnoth/commit/96263bf540029a743dba92d378b8dc4576f963e8
20170601 19:29:52< zookeeper> JyrkiVesterinen, i see. yet this brings me no relief :p
20170601 19:35:49-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170601 19:55:37-!- Kwandulin [~Kwandulin@p200300760F42AAAF196E91179970D17B.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170601 19:55:51< gfgtdf> zookeeper: what is the problem?
20170601 19:56:05< gfgtdf> vultraz_iOS: you saw the discussion eariler?
20170601 19:56:21< vultraz_iOS> whta?
20170601 19:56:29< zookeeper> gfgtdf, with wesnoth --help? well, nothing besides what was already said
20170601 19:56:37< gfgtdf> <zookeeper> gfgtdf, so the engine bug that remains is that apparently even a first_time_only=yes event can be fired several times, as long as it happens before the first instance of that event has finished
20170601 19:56:38< zookeeper> i just tried to check what -p is supposed to do
20170601 19:56:56< gfgtdf> <gfgtdf> zookeeper: ok quite sure this commit borke it https://github.com/wesnoth/wesnoth/commit/be665e29f111ad6c8ef1e8410a08608a405554cc
20170601 19:57:08< gfgtdf> vultraz_iOS: ^
20170601 19:58:25-!- mjs-de [~mjs-de@x4e3122f3.dyn.telefonica.de] has quit [Remote host closed the connection]
20170601 19:58:26< vultraz_iOS> oh ffs
20170601 19:58:39< vultraz_iOS> why would THAT break it
20170601 19:59:26< gfgtdf> becasue execute_on_events coped the pointer to that handler object.
20170601 19:59:31< gfgtdf> copies*
20170601 19:59:49< vultraz_iOS> i changed that in the next commit
20170601 20:00:52< vultraz_iOS> at least im pretty sure i did
20170601 20:01:18< JyrkiVesterinen> https://github.com/wesnoth/wesnoth/commit/4b2518483a968402d61581ae26967b54230a4228
20170601 20:01:29< vultraz_iOS> yeah that
20170601 20:01:31< vultraz_iOS> thanks
20170601 20:01:39< JyrkiVesterinen> You changed the lambda to capture local variables by reference, but the handler_ptr is still copied.
20170601 20:01:40< gfgtdf> vultraz_iOS: no the opbject i mean is not captured it is in the parameterlist of that lambda . 
20170601 20:01:52< gfgtdf> what JyrkiVesterinen said.
20170601 20:02:13< vultraz_iOS> I see
20170601 20:03:30< gfgtdf> vultraz_iOS: that said it's obviously silly that copying a pointer changes behaviour here, but fixing that one shoudl be delayed to after the stable release
20170601 20:03:59< vultraz_iOS> right, you said the code relies on refcounts so it doesn't work if it creates too many
20170601 20:05:58< vultraz_iOS> can you just change it to a reference
20170601 20:06:26< gfgtdf> vultraz_iOS: i can, but i cannot build/test it.
20170601 20:10:41< gfgtdf> vultraz_iOS: shoudl i do that or will you do it?
20170601 20:11:13< vultraz_iOS> Working on a branch right now could you do it ?
20170601 20:12:45< gfgtdf> hm k
20170601 20:35:02-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has joined #wesnoth-dev
20170601 20:47:59< zookeeper> celmin|sleep, i'm going to tentatively suspect the [object] porting to lua as the cause of issue #1746. but when testing please do remove the $unit reference from message= _ "Should $unit.name| attempt to pick up the armor?" first, since that might _also_ break it.
20170601 20:50:53< zookeeper> namely, the problem is that apparently the unstoring in [then] overwrites the object's effects, which shouldn't happen if $unit is stored only the first time it's referenced. except it does, even when i remove the abovementioned $unit reference.
20170601 20:52:19-!- travis-ci [~travis-ci@ec2-54-224-31-172.compute-1.amazonaws.com] has joined #wesnoth-dev
20170601 20:52:20< travis-ci> wesnoth/wesnoth#14044 (master - 96263bf : Nils Kneuper): The build passed.
20170601 20:52:20< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/238474923
20170601 20:52:20-!- travis-ci [~travis-ci@ec2-54-224-31-172.compute-1.amazonaws.com] has left #wesnoth-dev []
20170601 20:55:15< gfgtdf> zookeeper: that $unit in message beeing the casue seems auite likeley to me
20170601 20:55:26< zookeeper> as said i already tested without it
20170601 20:55:36< gfgtdf> zookeeper: specialyl sicne it was added in 1.13.6
20170601 20:57:10-!- RatArmy_ [~ratarmy@om126212088142.11.openmobile.ne.jp] has joined #wesnoth-dev
20170601 21:00:44< zookeeper> wow, what. when i also remove the [message] in the [then] block, that fixes it
20170601 21:01:12< zookeeper> or possibly it was changing it to a narrator message
20170601 21:02:34-!- JyrkiVesterinen [~JyrkiVest@89-166-125-107.bb.dnainternet.fi] has quit [Quit: .]
20170601 21:02:48< gfgtdf> zookeeper: ok that makes sense aswell
20170601 21:03:11-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170601 21:03:21< zookeeper> gfgtdf, how?
20170601 21:03:40< gfgtdf> zookeeper: the point is, that the _whole_[object]_ gets added to the unit, including nested [then] tags, and the tags are evalulated before beeing added
20170601 21:03:59< zookeeper> a-ha
20170601 21:04:17< gfgtdf> zookeeper: so when adding the [object] to the unit, it evalulates all nested variables inclusing tohse in [then]
20170601 21:04:28< zookeeper> so $unit gets stored when adding the object, so when [then] gets executed, $unit contains the unit before the object was applied. urgh.
20170601 21:04:43-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170601 21:04:45< gfgtdf> zookeeper: ye
20170601 21:04:55< zookeeper> but we can still blame celmin, no? :p
20170601 21:05:05-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170601 21:05:48< gfgtdf> i don't think we can, the bahviour was probably the same when this was still c++ code.
20170601 21:06:06< zookeeper> right. i'll do a quick test with 1.12...
20170601 21:07:27< gfgtdf> zookeeper: i think the best fix is probably not to use [object] and to do a manual [if] instead, this also has the advantage of not cluttering the unit wit the [else] wml.
20170601 21:08:16< gfgtdf> maybe you can [modyfy_unit][trait] instad of the manul unstoring
20170601 21:08:23< gfgtdf> or both together
20170601 21:08:47< zookeeper> yep
20170601 21:09:17< zookeeper> indeed, same problem in 1.12 if i add a $unit reference
20170601 21:09:20< zookeeper> wow
20170601 21:10:29< gfgtdf> axualyl i like neigher  [modify_unit] nor [object] actionwml. guess i'd use lua anyways.
20170601 21:21:31< zookeeper> i guess one could argue that the [then] contents shouldn't cause anything until after the object has been applied, but apparently that hasn't really been specified anywhere so i'll just workaround it
20170601 21:45:40< shadowm> Ravana_: _main.cfg.plain is the raw text that the preprocessor emits for the parser IIRC.
20170601 21:46:50< shadowm> That means it contains some internal directives that do not normally crop up in standard WML and are also normally escaped by the preprocessor (so the only places where you could abuse them are basically .pbl files and saves, where there's no point).
20170601 21:50:36-!- RatArmy_ [~ratarmy@om126212088142.11.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170601 21:53:32-!- Jollacz [~sailfish@93.157.158.220] has joined #wesnoth-dev
20170601 22:04:43-!- RatArmy_ [~ratarmy@om126212088142.11.openmobile.ne.jp] has joined #wesnoth-dev
20170601 22:10:10< irker200> wesnoth: ln-zookeeper wesnoth:master 24eb4bcd4ff7 / data/campaigns/Heir_To_The_Throne/utils/httt_utils.cfg: HttT S19b: Fixed void armor breakage introduced in ef641d6e https://github.com/wesnoth/wesnoth/commit/24eb4bcd4ff740ed21ee1247c4a3e8894c73b382
20170601 22:11:22< zookeeper> so why are bugs supposed to now be closed immediately when fixed?
20170601 22:16:53< matthiaskrgr> lol, why would you not close a ticket that has been fixed? 
20170601 22:18:03< zookeeper> for whatever reason that was the practise we used on gna
20170601 22:18:25< matthiaskrgr> so legacy™ reasons? :D 
20170601 22:19:22< zookeeper> i dunno, the reason for that could have been pretty nifty and modern
20170601 22:19:57< matthiaskrgr> it makes sorta sense for tickets that have been reported for a previous reasons
20170601 22:20:17< matthiaskrgr> to close when the new version that contains the fix for old version bug is released
20170601 22:20:37< matthiaskrgr> but it doesn't make sense for bugs that appeared in the devel version
20170601 22:20:48< matthiaskrgr> and differencianting between those sounds like a major PITA imo 
20170601 22:21:10< matthiaskrgr> and you'd have to somehow keep track of all fixed-but-not-closed tickets and close them at every release 
20170601 22:21:13< matthiaskrgr> ugh
20170601 22:21:26< zookeeper> that's how it went
20170601 22:21:37< zookeeper> hence my question
20170601 22:22:25< matthiaskrgr> you can somehow add a version tag to a GH issue
20170601 22:22:48< matthiaskrgr> like here https://github.com/wesnoth/wesnoth/issues/1704  
20170601 22:23:16< matthiaskrgr> I assume that would make the most sense if you want to not totally get rid of the old procedure
20170601 22:23:26< matthiaskrgr> but I dunno how it is itended to be :)
20170601 22:27:37< matthiaskrgr> I think there was some "migration from github" meta-ticket, maybe it says something about it 
20170601 22:32:22-!- TheJJ [~rofl@ipbcc36896.dynamic.kabel-deutschland.de] has quit [Ping timeout: 240 seconds]
20170601 22:38:07-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170601 22:41:06-!- TheJJ [~rofl@ipbcc36896.dynamic.kabel-deutschland.de] has joined #wesnoth-dev
20170601 23:04:39-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170601 23:10:42< loonycyborg> on gna we had following policy: when we fix bug we set its state to fixed but don't close, and close on next release
20170601 23:10:59< loonycyborg> I don't think github has states though
20170601 23:11:18-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 268 seconds]
20170601 23:12:35-!- Greg-Boggs [~greg_bogg@c-73-37-6-51.hsd1.or.comcast.net] has joined #wesnoth-dev
20170601 23:16:53-!- RatArmy_ [~ratarmy@om126212088142.11.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170601 23:19:05-!- TheJJ [~rofl@ipbcc36896.dynamic.kabel-deutschland.de] has quit [Ping timeout: 240 seconds]
20170601 23:19:24-!- TheJJ [~rofl@ipbcc36896.dynamic.kabel-deutschland.de] has joined #wesnoth-dev
20170601 23:23:03< zookeeper> loonycyborg, labels would do the same thing
20170601 23:23:33< loonycyborg> but I'm not sure that having label "fixed" would be considered a sound github practice
20170601 23:24:04< zookeeper> i wouldn't know
20170601 23:30:29-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170601 23:31:09-!- Bonobo [~Bonobo@2001:44b8:254:3200:f002:81da:361c:e00f] has joined #wesnoth-dev
20170601 23:34:39-!- Greg-Boggs [~greg_bogg@c-73-37-6-51.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170601 23:35:11-!- Greg-Boggs [~greg_bogg@c-73-37-6-51.hsd1.or.comcast.net] has joined #wesnoth-dev
20170601 23:36:23-!- Greg-Boggs [~greg_bogg@c-73-37-6-51.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170601 23:36:40-!- Greg-Boggs [~greg_bogg@c-73-37-6-51.hsd1.or.comcast.net] has joined #wesnoth-dev
20170601 23:38:36-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170601 23:42:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170601 23:43:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170601 23:44:23-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 255 seconds]
--- Log closed Fri Jun 02 00:00:43 2017