--- Log opened Wed Jun 07 00:00:49 2017
20170607 00:24:32-!- ancestral [~anonymous@63-231-152-92.mpls.qwest.net] has quit [Quit: ancestral]
20170607 00:26:23-!- celmin|sleep is now known as celticminstrel
20170607 00:45:26-!- Bonobo [~Bonobo@2001:44b8:254:3200:4405:dbb1:6380:8103] has joined #wesnoth-dev
20170607 00:52:41-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170607 01:05:35-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Read error: Connection reset by peer]
20170607 02:32:24-!- JyrkiVesterinen [~JyrkiVest@87-100-191-198.bb.dnainternet.fi] has joined #wesnoth-dev
20170607 02:52:28-!- irker099 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170607 03:18:02-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170607 03:37:42-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20170607 03:39:57-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 240 seconds]
20170607 03:40:57-!- irker875 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170607 03:40:57< irker875> wesnoth: Jyrki Vesterinen wesnoth:master 4c0f4c315467 / src/ (gui/core/event/dispatcher_private.hpp tests/gui/fire_event.cpp): Attempted fix for GUI2 event firing test failures https://github.com/wesnoth/wesnoth/commit/4c0f4c31546719c0a5fefa6973e32f0494a62f00
20170607 03:40:57< irker875> wesnoth: Jyrki Vesterinen wesnoth:master bb9ee94e4b80 / changelog players_changelog: Adjust changelog for commit 315f8496b61db8347b694e2efadfe6ff9ccc7702 https://github.com/wesnoth/wesnoth/commit/bb9ee94e4b8008f9988ea78ebf18ac974966c406
20170607 03:49:16-!- Kwandulin [~Kwandulin@p200300760F3201E63D03431A87BCABC3.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170607 03:52:27-!- bumba [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 260 seconds]
20170607 03:58:03-!- Appleman1234 [~quassel@z190230.ppp.asahi-net.or.jp] has quit [Ping timeout: 260 seconds]
20170607 04:10:10-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170607 04:10:19-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170607 04:20:39-!- moongazer [~moongazer@59.95.138.217] has joined #wesnoth-dev
20170607 04:38:40-!- Kwandulin [~Kwandulin@p200300760F3201E63D03431A87BCABC3.dip0.t-ipconnect.de] has quit [Quit: [endlevel]]
20170607 04:42:12-!- travis-ci [~travis-ci@ec2-54-87-92-45.compute-1.amazonaws.com] has joined #wesnoth-dev
20170607 04:42:13< travis-ci> wesnoth/wesnoth#14109 (master - bb9ee94 : Jyrki Vesterinen): The build was fixed.
20170607 04:42:13< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/240213935
20170607 04:42:13-!- travis-ci [~travis-ci@ec2-54-87-92-45.compute-1.amazonaws.com] has left #wesnoth-dev []
20170607 04:43:23< vultraz_iOS> \ o /
20170607 04:49:43< moongazer> Wesnoth takes forever to build on my old pc:(
20170607 04:49:55< moongazer> Each tiny change takes an infinite amount of time
20170607 04:50:08< matthiaskrgr> it's when they change a header file 
20170607 04:50:18< matthiaskrgr> you need to almost always rebuild the entire game :c 
20170607 04:50:31< moongazer> No
20170607 04:50:38< moongazer> matthiaskrgr, I am solving an issue
20170607 04:51:51< moongazer> My notebook hangs when I build wesnoth
20170607 04:51:52< moongazer> lol
20170607 04:53:48< matthiaskrgr> oO
20170607 04:55:22< moongazer> Hey
20170607 04:55:32< moongazer> I need a few saved games to test my changes
20170607 04:55:35< moongazer> Any links?
20170607 05:00:56< vultraz_iOS> what kind?
20170607 05:02:05-!- JyrkiVesterinen [~JyrkiVest@87-100-191-198.bb.dnainternet.fi] has quit [Quit: .]
20170607 05:03:41< moongazer> vultraz_iOS, Any sort of saves for a campgain
20170607 05:03:54< vultraz_iOS> hm..
20170607 05:03:58< vultraz_iOS> i don't think i have any good ones handy
20170607 05:06:57< moongazer> Like for heir to the throne? Do you have that
20170607 05:07:06< moongazer> Even 3 or 4 turns will od
20170607 05:07:07-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170607 05:07:08< moongazer> *do
20170607 05:07:15< moongazer> vultraz_iOS, ?
20170607 05:07:36< vultraz_iOS> sorry, i don't :(
20170607 05:07:44< vultraz_iOS> i haven't played much
20170607 05:07:44< DeFender1031> can't you just play three or four turns and then save it yourself?
20170607 05:07:46< vultraz_iOS> only developed :P
20170607 05:08:02< vultraz_iOS> (plus I'm working on something right now which means I can't play since the entire map isn't drawing)
20170607 05:09:27< vultraz_iOS> but yeah, what DeFender1031 said
20170607 05:10:58< moongazer> DeFender1031, really, know
20170607 05:10:59< moongazer> *no
20170607 05:18:41< moongazer> Okay I did just that
20170607 05:22:27< moongazer> waiting now
20170607 05:23:45< moongazer> vultraz_iOS, I have made changes
20170607 05:24:17< moongazer> how do I submit them. My forked repo is not up to date with the main wesnoth branch
20170607 05:25:52< vultraz_iOS> force push to your repo
20170607 05:25:54< vultraz_iOS> with the changes
20170607 05:25:59< vultraz_iOS> then open a pull request
20170607 05:26:35< moongazer> alright
20170607 05:26:49< moongazer> Woohoo
20170607 05:26:56< moongazer> I learnt about git diff files
20170607 05:37:06< moongazer> vultraz_iOS, I have a doubt regarding the source code
20170607 05:37:38< vultraz_iOS> ?
20170607 05:38:15-!- JyrkiVesterinen [~JyrkiVest@85-76-49-23-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170607 05:39:10-!- Bonobo [~Bonobo@2001:44b8:254:3200:4405:dbb1:6380:8103] has quit [Ping timeout: 240 seconds]
20170607 05:39:38-!- Bonobo [~Bonobo@2001:44b8:254:3200:4405:dbb1:6380:8103] has joined #wesnoth-dev
20170607 05:40:39< moongazer> vultraz_iOS, I am attempting to do this: https://github.com/wesnoth/wesnoth/issues/1738
20170607 05:41:04< vultraz_iOS> as i expected
20170607 05:41:18< moongazer> vultraz_iOS, yes?
20170607 05:41:26< moongazer> Are you unhappy?
20170607 05:41:28< vultraz_iOS> what problems are you having?
20170607 05:42:30< moongazer> I am on the file src/gui/dialogues/unit_recall.cpp and src/gui/widgets/listbox.hpp
20170607 05:42:56< moongazer> I am unable to discover how exactly the dialogue and the sorting options connect
20170607 05:45:31< vultraz_iOS> well, here's where the sorting options are registered
20170607 05:45:32< vultraz_iOS> https://github.com/wesnoth/wesnoth/blob/master/src/gui/dialogs/unit_recall.cpp#L240-L246
20170607 05:46:00< vultraz_iOS> the internals are rather complicated
20170607 05:46:45< vultraz_iOS> (the sorting options correspond to the order of the buttons in the header)
20170607 05:46:59< vultraz_iOS> (the header of the dialog, where you select options, that is)
20170607 05:47:49< moongazer> I know that the sorting options are registered there/
20170607 05:48:07< moongazer> I am exploring the internals, the widgets
20170607 05:48:10< vultraz_iOS> ah
20170607 05:48:15< vultraz_iOS> well as i said
20170607 05:48:19< vultraz_iOS> rather complicated
20170607 05:48:19< moongazer> listbox.hpp and listbox.cpp that is
20170607 05:48:25< moongazer> I can understand it
20170607 05:48:27< vultraz_iOS> you want something in generator_private.hpp
20170607 05:49:22< JyrkiVesterinen> You don't really need to understand how the internals work here.
20170607 05:49:55< JyrkiVesterinen> The important part is that the lambda returns a variable, like an integer or a string, and the list items are sorted according to those variables.
20170607 05:50:16< JyrkiVesterinen> For example, the current sorting by level:
20170607 05:50:17< JyrkiVesterinen> list.register_sorting_option(2, [this](const int i) { return recall_list_[i]->level(); });
20170607 05:51:00< JyrkiVesterinen> (The lambda is allowed to return anything that can be compared. In this case I suggest returning a float.)
20170607 05:51:19< moongazer> That is fine
20170607 05:51:50< moongazer> I want to know how to sort it by default, considering not binding it to the gui options
20170607 05:52:12< vultraz_iOS> sort it by default?
20170607 05:52:14< moongazer> vultraz_iOS, '(the sorting options correspond to the order of the buttons in the header)' which statement does this binding
20170607 05:52:18< moongazer> vultraz_iOS, yes
20170607 05:52:27< vultraz_iOS> you mean have it sorted when you open the dialog?
20170607 05:53:26< moongazer> Or rather, sort something by default without having an toggle option for the user
20170607 05:53:49< JyrkiVesterinen> How about binding it to the level header, and making sorting by that heading the default via listbox::set_active_sorting_option()?
20170607 05:53:49< vultraz_iOS> if you want sorting independent of user input you need to sort the data before constructing the list 
20170607 05:54:22< vultraz_iOS> if you want a sorting option selected by default you need set_active_sorting_option
20170607 05:54:34< vultraz_iOS> which I actually noticed a small issue with recently i need to fix..
20170607 05:55:32< moongazer> The easy way out would be to use experience_to_advance() instead of experience
20170607 05:55:33< moongazer> hmmm
20170607 05:56:45< moongazer> vultraz_iOS, how is the sort carried out. in register_sorting_option, the thing is that do the numbers 0, 1, 2, 3.. have any significance apart from the order corresponding to the gui buttons?
20170607 05:57:12< moongazer> or is it that sort first by trait '0', then '1' then 2 and so on
20170607 05:57:13-!- Appleman1234 [~quassel@z190230.ppp.asahi-net.or.jp] has joined #wesnoth-dev
20170607 05:58:46< vultraz_iOS> Ok, so how it works is the header has a bunch of buttons
20170607 05:58:53< vultraz_iOS> each one has an id like sort_0, sort_1, etc
20170607 05:59:04< moongazer> file?
20170607 05:59:13< vultraz_iOS> it doesn't matter for your purposes
20170607 05:59:36< vultraz_iOS> suffice to say register_sorting_option(num corresponds to the button with sort_num
20170607 05:59:57< moongazer> okay, continue what you were saying
20170607 06:00:20< vultraz_iOS> but if you're really interested the buttons are here https://github.com/wesnoth/wesnoth/blob/master/data/gui/window/unit_recall.cfg#L11-L93
20170607 06:01:48< moongazer> vultraz_iOS, okay
20170607 06:02:09< vultraz_iOS> but really you don't need to touch that
20170607 06:02:33< moongazer> How do I sort 'by default' then. Since register_sorting_option is always associated with a button
20170607 06:02:44< vultraz_iOS> set_active_sorting_option
20170607 06:03:09< vultraz_iOS> but again
20170607 06:03:37< vultraz_iOS> if you want to sort the data independently of any sorting option you need to sort the data before constructing the list 
20170607 06:08:20< moongazer> https://github.com/wesnoth/wesnoth/blob/master/src/gui/dialogs/unit_recall.cpp#L183 Like at this line before the for loop?
20170607 06:09:27< JyrkiVesterinen> Yes, there.
20170607 06:09:33< moongazer> vultraz_iOS, But set_active_sorting_option cannot be used before register_sorting_option, right?
20170607 06:10:01< vultraz_iOS> Right
20170607 06:10:56< moongazer> So even there I would have to do that
20170607 06:11:30< moongazer> Would it not mess up something later?
20170607 06:12:49< JyrkiVesterinen> Sorting the recall list manually won't mess up anything, the game doesn't rely on it being in any certain order.
20170607 06:20:54< moongazer> I think I shouuld change something instead of just talking
20170607 06:27:18< moongazer> I made the change
20170607 06:27:33< moongazer> But I am confused with post::show
20170607 06:27:46< moongazer> *unit_recall::post_show
20170607 06:28:26-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:9dd7:a72f:ca19:fdbf] has joined #wesnoth-dev
20170607 06:29:47< moongazer> vultraz_iOS, ?
20170607 06:30:15< vultraz_iOS> What about it!
20170607 06:30:20< vultraz_iOS> ?*
20170607 06:30:21< vultraz_iOS> Sorry
20170607 06:30:53< moongazer> vultraz_iOS, When I dismiss a unit, I want the default sort to apply again
20170607 06:31:19< vultraz_iOS> In post_show the last selected sorting option is saved so it can be used again when the dialog is next opened
20170607 06:32:17< JyrkiVesterinen> When dismissing units, most players will want to retain the sort option they have selected.
20170607 06:32:53< moongazer> JyrkiVesterinen, Ah! I totally missed that. It would be annoying for them to repeatedly sort it!
20170607 06:32:59-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:9dd7:a72f:ca19:fdbf] has quit [Ping timeout: 260 seconds]
20170607 06:32:59< moongazer> Got it
20170607 06:35:45-!- Kwandulin [~Kwandulin@p200300760F3201E6B07355E3D665E4EF.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170607 06:39:01-!- Kwandulin [~Kwandulin@p200300760F3201E6B07355E3D665E4EF.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170607 06:40:16-!- Kwandulin [~Kwandulin@p200300760F3201E6B07355E3D665E4EF.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170607 06:42:05-!- atarocch [~atarocch@93.56.160.28] has joined #wesnoth-dev
20170607 06:42:46-!- irker875 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170607 06:52:00-!- moongazer [~moongazer@59.95.138.217] has quit [Ping timeout: 255 seconds]
20170607 07:24:36-!- moongazer [~moongazer@2405:204:91a3:6861:dcd:7df8:1a4:3299] has joined #wesnoth-dev
20170607 07:25:02-!- moongazer [~moongazer@2405:204:91a3:6861:dcd:7df8:1a4:3299] has quit [Max SendQ exceeded]
20170607 07:40:04-!- universecoder [312300e8@gateway/web/freenode/ip.49.35.0.232] has joined #wesnoth-dev
20170607 07:40:26< universecoder> hi it's me moongazer, vultraz_iOS 
20170607 07:40:37< universecoder> I have submitted a pull request
20170607 07:40:51< vultraz_iOS> we'll take a look
20170607 07:40:52< vultraz_iOS> thanks :)
20170607 07:42:19< universecoder> vultraz_iOS: https://github.com/wesnoth/wesnoth/pull/1760
20170607 07:42:48< universecoder> (I know it's silly, but I am excited since it is my first pull request)
20170607 07:43:28< vultraz_iOS> hmmmmmmmmmmmm
20170607 07:43:49< vultraz_iOS> how come you're registering sorting options twice?
20170607 07:44:03< universecoder> vultraz_iOS: you said I could do it? 
20170607 07:44:17< universecoder> vultraz_iOS: that it won't matter
20170607 07:44:23< vultraz_iOS> hmm
20170607 07:44:28< vultraz_iOS> I think you may have misunderstood me
20170607 07:44:37< vultraz_iOS> what exactly is that first sort meant to do?
20170607 07:44:39< vultraz_iOS> pre-sort the list?
20170607 07:45:10< vultraz_iOS> if so, that won't work
20170607 07:45:15< vultraz_iOS> you need to sort the recall_list_ container itself
20170607 07:46:02< vultraz_iOS> using std::sort
20170607 07:46:23< universecoder> vultraz_iOS: But it did work
20170607 07:46:23< universecoder> I tested it
20170607 07:46:29< universecoder> By playing a game
20170607 07:46:39< vultraz_iOS> hmmm
20170607 07:46:44< vultraz_iOS> we'll have to look at this further
20170607 07:47:01< vultraz_iOS> (again,I can't right now myself since im working on something else)
20170607 07:49:28< universecoder> vultraz_iOS: is anyone else with your expertise available?
20170607 07:49:38< vultraz_iOS> jyrki and celticminstrel 
20170607 07:49:41< vultraz_iOS> celticminstrel
20170607 07:49:48< universecoder> poke celticminstrel 
20170607 07:50:02< JyrkiVesterinen> I'm currently writing a PR review in GitHub. (About to reject.)
20170607 07:50:20< universecoder> vultraz_iOS: if I use std::sort, then I would have to make a comparison function, ok
20170607 07:53:11< JyrkiVesterinen> Review is up.
20170607 07:54:46< vultraz_iOS> thanks jyrki
20170607 07:55:28< universecoder> JyrkiVesterinen: ok. I am reading it
20170607 08:03:35-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Ping timeout: 240 seconds]
20170607 08:08:25-!- Bonobo [~Bonobo@2001:44b8:254:3200:4405:dbb1:6380:8103] has quit [Ping timeout: 246 seconds]
20170607 08:09:08-!- Bonobo [~Bonobo@2001:44b8:254:3200:c7a:8f77:3d0a:d507] has joined #wesnoth-dev
20170607 08:13:24-!- universecoder [312300e8@gateway/web/freenode/ip.49.35.0.232] has quit [Quit: Page closed]
20170607 08:17:59-!- universecoder [312300e8@gateway/web/freenode/ip.49.35.0.232] has joined #wesnoth-dev
20170607 08:21:56< universecoder> I am doing it again now
20170607 08:40:03< universecoder> JyrkiVesterinen: Hi. I created a function compare, but while passing it to std::sort(), I get the error:  error: invalid use of non-static member function
20170607 08:42:42-!- Kwandulin [~Kwandulin@p200300760F3201E6B07355E3D665E4EF.dip0.t-ipconnect.de] has quit [Ping timeout: 260 seconds]
20170607 08:42:51< universecoder> vultraz_iOS: ?
20170607 08:43:35< Soliton> so make it a static member function or no member function at all.
20170607 08:43:59< vultraz_iOS> Yeah, you could just specify it static
20170607 08:44:20< universecoder> vultraz_iOS: that results in a pile of C++ STL errors
20170607 08:45:23< Soliton> nobody will be able to help you with no code and not even actual error messages.
20170607 08:46:19< JyrkiVesterinen> The code is here: https://github.com/wesnoth/wesnoth/pull/1760/files
20170607 08:46:38< JyrkiVesterinen> Except I'm not sure _how_ universecoder "specifies it static".
20170607 08:47:25< universecoder> JyrkiVesterinen: no that is not the code
20170607 08:47:40< universecoder> JyrkiVesterinen: the code is on my pc
20170607 08:48:01< universecoder> I will pastebin the git diff file
20170607 08:49:22< universecoder> JyrkiVesterinen: That is not even syntactically correct
20170607 08:49:42< universecoder> and does not compile
20170607 08:49:52< universecoder> There is a colon instead of a ::
20170607 08:50:28< JyrkiVesterinen> Oh. I see. Almost impossible to spot with naked eye unless you're actively looking.
20170607 08:51:24< JyrkiVesterinen> A request: please don't even push code if it doesn't compile. Reviewing broken code wastes my time.
20170607 08:51:39< JyrkiVesterinen> With Git you can commit without pushing, if necessary.
20170607 08:53:24< universecoder> JyrkiVesterinen: Sorry. 
20170607 08:53:30< universecoder> Really sorry
20170607 08:53:40< universecoder> I did it by mistake
20170607 08:57:34< universecoder> JyrkiVesterinen: https://paste.ofcode.org/hMaHNDiLJ8Ct4FEufmpUPQ
20170607 08:59:10< JyrkiVesterinen> The function isn't marked static. You need to mark it as static in unit_recall.hpp.
20170607 09:01:02-!- Appleman1234 [~quassel@z190230.ppp.asahi-net.or.jp] has quit [Ping timeout: 268 seconds]
20170607 09:01:18< JyrkiVesterinen> A couple smaller things: when you pass unit_recall_default_compare to std::sort() within the unit_recall class, you don't need to explicitly specify the class name.
20170607 09:01:41< JyrkiVesterinen> And space between parameters is missing in line 14 of your diff.
20170607 09:02:32< universecoder> JyrkiVesterinen: ok
20170607 09:02:33< universecoder> https://paste.ofcode.org/pXb7BvQzQcJPpEzumh8u5Z
20170607 09:06:58< universecoder> That is the error message when the return type of the function is static bool
20170607 09:08:00< JyrkiVesterinen> According to it, you're still missing the second colon in unit_recall.cpp line 149.
20170607 09:08:14< JyrkiVesterinen> Add it, and try to compile again.
20170607 09:10:57< JyrkiVesterinen> I'm going to lunch now. I'll go back online within an hour.
20170607 09:10:59-!- JyrkiVesterinen [~JyrkiVest@85-76-49-23-nat.elisa-mobile.fi] has quit [Quit: .]
20170607 09:18:44< universecoder> https://paste.ofcode.org/XjavdTHMGGSBqaPU6kWVAr
20170607 09:18:48< universecoder> Someone check this
20170607 09:22:20< Soliton> invalid initialization of reference of type ‘const unit&’ from expression of type ‘boost::intrusive_ptr<const unit>’
20170607 09:23:04< Soliton> change your function to take the correct type.
20170607 09:23:46< Soliton> there is a unit_const_ptr typedef you can use.
20170607 09:24:40< universecoder> When I am not using static, the compiler asks me to use static
20170607 09:24:52< universecoder> unit_const_ptr hmm
20170607 09:25:03< universecoder> Can you tell me what the problem was, Soliton 
20170607 09:27:03-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20170607 09:28:43< Soliton> first of all the compiler did not ask you to do anything. it tells you when you do something wrong but since it has no idea what you're trying to do it can almost never tell you how to fix it.
20170607 09:28:54-!- Appleman1234 [~quassel@z190230.ppp.asahi-net.or.jp] has joined #wesnoth-dev
20170607 09:29:12< universecoder> Soliton: ok
20170607 09:29:29< Soliton> in the case above it told you that you're function is called with different arguments then what it's declared as.
20170607 09:29:37< Soliton> your*
20170607 09:30:28< universecoder> Huh?
20170607 09:30:45< universecoder> Let me check
20170607 09:31:43< universecoder> It's the same
20170607 09:32:11< Soliton> what is the same?
20170607 09:32:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170607 09:33:39< universecoder> WHOA
20170607 09:33:40< universecoder> Ha
20170607 09:33:45< universecoder> It isn't the same
20170607 09:33:48< universecoder> Thanks
20170607 09:33:50< universecoder> ...
20170607 09:36:30-!- JyrkiVesterinen [~JyrkiVest@85-76-49-23-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170607 09:46:53< universecoder> JyrkiVesterinen: https://paste.ofcode.org/jVdjMeUNazC5ba2EZu5xUT
20170607 09:50:55< JyrkiVesterinen> You should only use the "static" keyword in unit_recall.h, not unit_recall.cpp.
20170607 09:51:20< JyrkiVesterinen> The keyword means different things in function declaration (.h) and definition (.cpp).
20170607 09:52:01< JyrkiVesterinen> Aside: just write "const_unit_ptr first, const_unit_ptr second".
20170607 09:52:12< universecoder> JyrkiVesterinen: why?
20170607 09:52:25< JyrkiVesterinen> Pointers are small, there is no point in passing them by reference.
20170607 09:52:29< universecoder> Right, I don't need a reference to a pointer
20170607 09:52:37< universecoder> I can just pass it directly:)
20170607 09:52:48< JyrkiVesterinen> (In fact, a reference to pointer is slower because it means double indirection.)
20170607 09:56:57< DeFender1031> the only time you want to pass a reference to a pointer is if you're changing where the pointer points and you want that change reflected in the caller's scope. (Then again, if that's what you need, you should probably be using some form of encapsulation instead...)
20170607 09:57:50< JyrkiVesterinen> Even in that situation I'd use a pointer to pointer instead. I dislike mixing pointers and references.
20170607 09:58:09< DeFender1031> that too.
20170607 09:58:41< universecoder> JyrkiVesterinen: mixing pointers and regerences is confusing for me
20170607 10:00:11< universecoder> JyrkiVesterinen: You said that the static keyword has a different meaning for a member function when declared and a different meaning when defined? What is it?]
20170607 10:00:40< JyrkiVesterinen> In declaration, it marks the function static. A static function is called without an instance of the class.
20170607 10:01:12< JyrkiVesterinen> In the definition, the keyword means static linkage. A statically linked function can't be accessed from any other .cpp file.
20170607 10:01:27< JyrkiVesterinen> (That's somewhat inaccurate way to put it, but mostly true.)
20170607 10:02:17< universecoder> I see
20170607 10:17:41-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20170607 10:40:40< universecoder> JyrkiVesterinen: It is done now, it is compiling and works as intended. I also followed the coding standards you mentioned
20170607 10:43:13< JyrkiVesterinen> It looks fine now. :) As I said, I'll test it myself in the evening.
20170607 10:46:04< universecoder> Yayyyy
20170607 10:46:08< universecoder> I am so happy:)
20170607 10:47:51< universecoder> JyrkiVesterinen: Give me something else
20170607 10:47:56< universecoder> Maybe multiple things now
20170607 10:47:59< universecoder> Quick
20170607 10:49:58< JyrkiVesterinen> Don't demand me for speed. I'm a volunteer, and I'm not obligated to do anything.
20170607 10:50:50< universecoder> No, I am not asking you to do anything
20170607 10:51:01< universecoder> Just asking for a few more issues I could fix
20170607 10:52:12< JyrkiVesterinen> Right... just don't say "quick". It's only going to irritate me.
20170607 10:53:02< universecoder> Sorry, didn't realize that
20170607 10:53:03< universecoder> What do you do, by the way?
20170607 10:53:33< JyrkiVesterinen> In the Wesnoth project? Miscellaneous tasks, mostly bug fixes.
20170607 10:54:31< universecoder> I mean, normally
20170607 10:54:52< JyrkiVesterinen> Professionally, I'm a mobile game programmer.
20170607 10:55:16< universecoder> JyrkiVesterinen: wow
20170607 10:56:47-!- universecoder_ [75cb7df3@gateway/web/freenode/ip.117.203.125.243] has joined #wesnoth-dev
20170607 11:00:04-!- universecoder [312300e8@gateway/web/freenode/ip.49.35.0.232] has quit [Ping timeout: 260 seconds]
20170607 11:01:00-!- Kwandulin [~Kwandulin@p200300760F3201E6B07355E3D665E4EF.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170607 11:03:09-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Read error: Connection reset by peer]
20170607 11:10:15-!- Kwandulin [~Kwandulin@p200300760F3201E6B07355E3D665E4EF.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170607 11:11:36-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20170607 11:11:46-!- Appleman1234 [~quassel@z190230.ppp.asahi-net.or.jp] has quit [Ping timeout: 240 seconds]
20170607 11:11:46-!- atarocch [~atarocch@93.56.160.28] has quit [Ping timeout: 268 seconds]
20170607 11:17:02-!- Appleman1234 [~quassel@z190230.ppp.asahi-net.or.jp] has joined #wesnoth-dev
20170607 11:17:34-!- universecoder_ [75cb7df3@gateway/web/freenode/ip.117.203.125.243] has quit [Ping timeout: 260 seconds]
20170607 11:23:21-!- universecoder [312302a7@gateway/web/freenode/ip.49.35.2.167] has joined #wesnoth-dev
20170607 11:23:32< universecoder> I got disconnected
20170607 11:23:51< universecoder> JyrkiVesterinen: vultraz_iOS : What about this: https://github.com/wesnoth/wesnoth/issues/1653
20170607 11:24:44< JyrkiVesterinen> Hmm, yes, it looks reasonably easy to fix.
20170607 11:26:45< universecoder> JyrkiVesterinen: woohoo
20170607 11:27:29< universecoder> Is src/preferences the relevant directory?
20170607 11:31:37-!- RatArmy_ [~ratarmy@om126237120131.9.openmobile.ne.jp] has joined #wesnoth-dev
20170607 11:32:01< JyrkiVesterinen> Yes.
20170607 11:32:52< universecoder> JyrkiVesterinen: Anything else I need to know? Where is the GUI for this?
20170607 11:33:51< JyrkiVesterinen> C++: https://github.com/wesnoth/wesnoth/blob/bb9ee94e4b8008f9988ea78ebf18ac974966c406/src/gui/dialogs/preferences_dialog.cpp
20170607 11:34:16< JyrkiVesterinen> WML: https://github.com/wesnoth/wesnoth/blob/bb9ee94e4b8008f9988ea78ebf18ac974966c406/data/gui/window/preferences/03_display.cfg
20170607 11:35:23< JyrkiVesterinen> I don't know where the animation code itself is, but you can search where the relevant preference is referenced.
20170607 11:35:35< universecoder> Aren't /wesnoth/src/units/animation* files relevant?
20170607 11:35:45< JyrkiVesterinen> I think so.
20170607 11:40:47< universecoder> How did you people come up with the Wesnoth Markup Language?
20170607 11:41:30< JyrkiVesterinen> I myself don't know it very well, I only joined the project about an year ago.
20170607 11:42:35< universecoder> Ok
20170607 11:45:01-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Read error: Connection reset by peer]
20170607 11:45:54< JyrkiVesterinen> From what I have heard, I think it mostly has to do with the age of the project. The project was founded in 2003: back then, XML was all the rage, and no one had heard of JSON.
20170607 11:46:49< JyrkiVesterinen> XML has significant issues which are acknowledged today. AFAIK, Dave (the founder of the project) wasn't happy with XML and therefore decided to create his own markup language.
20170607 11:47:00< JyrkiVesterinen> Not that WML is much better, to be honest...
20170607 11:50:29< universecoder> But it looks awesome
20170607 12:03:59-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170607 12:18:01< universecoder> JyrkiVesterinen: I am now on src/units/animation_component.hpp
20170607 12:18:09< universecoder> JyrkiVesterinen: I am confused now
20170607 12:21:19-!- atarocch [atarocch@nat/redhat/x-pqixlgkjdzvgighs] has joined #wesnoth-dev
20170607 12:21:33< JyrkiVesterinen> About what?
20170607 12:34:14< universecoder> Why does it happen only when the unit is clicked?
20170607 12:39:00-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170607 12:39:39< JyrkiVesterinen> universecoder: This function is called when the player clicks any hex: https://github.com/wesnoth/wesnoth/blob/master/src/mouse_events.cpp#L678
20170607 12:40:19< JyrkiVesterinen> Try to figure out yourself where, exactly, that code ends up resetting the unit animation.
20170607 12:40:33< JyrkiVesterinen> With the help of a debugger, I recommend.
20170607 12:47:24-!- universecoder [312302a7@gateway/web/freenode/ip.49.35.2.167] has quit [Ping timeout: 260 seconds]
20170607 12:50:09< vultraz_iOS> I tried fixing that bug, ftr
20170607 12:50:12< vultraz_iOS> it doesn't seem simple
20170607 12:50:19< vultraz_iOS> but i might have missed something obvious
20170607 12:52:07-!- universecoder [312300a2@gateway/web/freenode/ip.49.35.0.162] has joined #wesnoth-dev
20170607 12:56:25< universecoder> JyrkiVesterinen: got disconnected
20170607 12:56:31< universecoder> What were you saying?
20170607 12:56:43< vultraz_iOS> "universecoder: This function is called when the player clicks any hex: https://github.com/wesnoth/wesnoth/blob/master/src/mouse_events.cpp#L678
20170607 12:56:43< vultraz_iOS> 11:40 PM Try to figure out yourself where, exactly, that code ends up resetting the unit animation.
20170607 12:56:43< vultraz_iOS> 11:40 PM With the help of a debugger, I recommend."
20170607 12:56:48< vultraz_iOS> that's what he said before you left
20170607 12:57:50< Soliton> Logs: http://irclogs.wesnoth.org
20170607 12:57:51< zookeeper> the channel topic links to the irclogs you can use to check what people said when you were offline.
20170607 12:58:01< zookeeper> yes, that :p
20170607 13:01:49< universecoder> aight
20170607 13:18:48-!- Bonobo [~Bonobo@2001:44b8:254:3200:c7a:8f77:3d0a:d507] has quit [Ping timeout: 240 seconds]
20170607 13:20:39-!- universecoder [312300a2@gateway/web/freenode/ip.49.35.0.162] has quit [Ping timeout: 260 seconds]
20170607 13:42:42-!- universecoder [312315d6@gateway/web/freenode/ip.49.35.21.214] has joined #wesnoth-dev
20170607 13:56:25-!- JyrkiVesterinen [~JyrkiVest@85-76-49-23-nat.elisa-mobile.fi] has quit [Quit: Going home]
20170607 14:08:30-!- RatArmy_ [~ratarmy@om126237120131.9.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170607 14:13:27-!- Appleman1234 [~quassel@z190230.ppp.asahi-net.or.jp] has quit [Ping timeout: 255 seconds]
20170607 14:21:45-!- RatArmy_ [~ratarmy@om126237120131.9.openmobile.ne.jp] has joined #wesnoth-dev
20170607 14:31:49-!- universecoder [312315d6@gateway/web/freenode/ip.49.35.21.214] has quit [Ping timeout: 260 seconds]
20170607 14:34:36-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Read error: Connection reset by peer]
20170607 14:34:51-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20170607 14:39:18-!- RatArmy_ [~ratarmy@om126237120131.9.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170607 15:19:32-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:8993:aa44:11bc:492f] has joined #wesnoth-dev
20170607 15:35:46-!- atarocch [atarocch@nat/redhat/x-pqixlgkjdzvgighs] has quit [Ping timeout: 240 seconds]
20170607 15:50:10-!- JyrkiVesterinen [~JyrkiVest@78-27-123-115.bb.dnainternet.fi] has joined #wesnoth-dev
20170607 15:53:52-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:8993:aa44:11bc:492f] has quit [Remote host closed the connection]
20170607 15:56:46-!- universecoder [31231522@gateway/web/freenode/ip.49.35.21.34] has joined #wesnoth-dev
20170607 16:03:38-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170607 16:12:44-!- universecoder [31231522@gateway/web/freenode/ip.49.35.21.34] has quit [Ping timeout: 260 seconds]
20170607 16:12:48-!- atarocch [~atarocch@37.180.92.37] has joined #wesnoth-dev
20170607 16:12:56-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170607 16:29:24-!- Kwandulin [~Kwandulin@p200300760F3201D6253E9357BE79E489.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170607 16:35:05-!- atarocch [~atarocch@37.180.92.37] has quit [Ping timeout: 240 seconds]
20170607 16:42:44-!- gfgtdf [~chatzilla@x4e36332a.dyn.telefonica.de] has joined #wesnoth-dev
20170607 16:46:26-!- universecoder [31231522@gateway/web/freenode/ip.49.35.21.34] has joined #wesnoth-dev
20170607 16:47:38-!- irker397 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170607 16:47:38< irker397> wesnoth: Charles Dang wesnoth:accelerated_rendering 083f8fba761f / src/gui/core/canvas.cpp: GUI2/Canvas: disable surface manip w/ accelerated rendering for stretch resize m https://github.com/wesnoth/wesnoth/commit/083f8fba761f99067f76981b5b3a07c847559e95
20170607 16:47:41< irker397> wesnoth: Charles Dang wesnoth:accelerated_rendering a59bd9d54c38 / src/sdl/render_utils.hpp: Fixed raii renderer rect setters https://github.com/wesnoth/wesnoth/commit/a59bd9d54c38113df1871986e31a8e583fcdea33
20170607 16:47:44< irker397> wesnoth: Charles Dang wesnoth:accelerated_rendering 3e57888945da / src/ (display.cpp sdl/utils.cpp sdl/utils.hpp): Enabled drawing of minimap in-game https://github.com/wesnoth/wesnoth/commit/3e57888945dadcc5fbf12e677731c85e12bfe14b
20170607 16:47:47< irker397> wesnoth: Charles Dang wesnoth:accelerated_rendering ebf6c33eb796 / src/ (7 files in 4 dirs): Moved GUI2's per-frame drawing trigger to global scope https://github.com/wesnoth/wesnoth/commit/ebf6c33eb796f4cfd27d3c15a2035b9fc344782a
20170607 16:48:56< JyrkiVesterinen> universecoder: You asked for a save file earlier to be able to test the recall list.
20170607 16:49:01< JyrkiVesterinen> Here is a save of mine: https://drive.google.com/open?id=0B0P8wSxAPApzaThtVWJNc3ZkSms
20170607 16:49:12< JyrkiVesterinen> (I couldn't send it earlier because I was at work.)
20170607 16:49:59< JyrkiVesterinen> Also, you probably already saw that I tested your sorting implementation and found it to be badly broken.
20170607 16:52:15< universecoder> JyrkiVesterinen: oh:(
20170607 16:52:19< universecoder> yeah I saw it
20170607 16:53:02< vultraz_iOS> also, im not sure having that function be static in the class is the best option?
20170607 16:53:13< vultraz_iOS> it's not really useful on its own
20170607 16:55:36< universecoder> vultraz_iOS: What is another workaround?
20170607 16:55:52< universecoder> I thinking I am wasting the time of the developers:(
20170607 16:55:58< vultraz_iOS> you could make it static in the cpp file
20170607 16:56:15< JyrkiVesterinen> Or a lambda. It's short enough for that.
20170607 16:56:46< vultraz_iOS> ^
20170607 16:58:30< JyrkiVesterinen> "Wasting time" is sort of true, I could have solved issue #1738 in five minutes. I have already spent more than that reviewing your code and trying to help you.
20170607 16:58:50< JyrkiVesterinen> Still, you're trying to help, and I feel it would be outright rude if I "stole" that task from you.
20170607 17:00:53-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:8993:aa44:11bc:492f] has joined #wesnoth-dev
20170607 17:03:22< Soliton> it'd be good to put more effort into testing a solution you come up with so at least it works right. then others can help work out implementation details.
20170607 17:05:24< JyrkiVesterinen> Yeah, universecoder couldn't properly test his code because he didn't have save files. I assume he hasn't played the game much at all.
20170607 17:05:43< JyrkiVesterinen> Actually, I also decided to join the project before I had played Wesnoth at all myself.
20170607 17:06:01< Soliton> that should be fairly easy to rectify. :-)
20170607 17:06:16< JyrkiVesterinen> But, I went on to play the game (the The South Guard campaign) before I started development.
20170607 17:06:21< JyrkiVesterinen> (Took me half an  year.)
20170607 17:07:02< JyrkiVesterinen> That's where the above save file is from, too. (No need to tell me that I suck at this game. :P)
20170607 17:07:28< vultraz_iOS> half a year? O_O
20170607 17:07:32< universecoder> JyrkiVesterinen: I have played approximately 40 campgains
20170607 17:07:45< universecoder> JyrkiVesterinen: I have none right now
20170607 17:08:09< zookeeper> 40 campaigns, huh? well, that sure is a lot.
20170607 17:08:10< JyrkiVesterinen> vultraz_iOS: I was also playing other games at the time, it wasn't exclusively Wesnoth. That's the main reason why it took so long.
20170607 17:08:21< vultraz_iOS> ah
20170607 17:08:23< vultraz_iOS> Witcher?
20170607 17:08:44< universecoder> JyrkiVesterinen: You think that I should just stop then?
20170607 17:08:56< JyrkiVesterinen> Mainly GTAV, if I recall correctly.
20170607 17:09:43< JyrkiVesterinen> universecoder: Well, if you become a better programmer, I can imagine that you would be useful to the project. :)
20170607 17:09:44< universecoder> JyrkiVesterinen: I was playing Crysis 2 and Crysis 3
20170607 17:10:02< universecoder> JyrkiVesterinen: Trust me I will. Just be patient with me initially
20170607 17:10:23< JyrkiVesterinen> In particular, it would definitely help if you tested your code before having us review it.
20170607 17:10:37< JyrkiVesterinen> Quite strange that you don't have savefiles if you have played 40 campaigns.
20170607 17:10:39< vultraz_iOS> *once again is reminded of when I asked zookeeper if _main.cfg was a folder*
20170607 17:10:54< vultraz_iOS> *or when I asked jyrki "what is true && false" *
20170607 17:10:55< vultraz_iOS> :|
20170607 17:11:17< universecoder> JyrkiVesterinen: That was my pc
20170607 17:11:32< universecoder> JyrkiVesterinen: I am on a really old laptop right now
20170607 17:11:54< zookeeper> vultraz_iOS, everyone has once been a little vultlet
20170607 17:12:00-!- atarocch [~atarocch@93.56.160.32] has joined #wesnoth-dev
20170607 17:12:51< JyrkiVesterinen> And there are methods of generating test data even if you don't have existing savefiles.
20170607 17:13:08-!- gfgtdf [~chatzilla@x4e36332a.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 53.0.3/20170518000419]]
20170607 17:13:29< JyrkiVesterinen> For the recall list, you could recruit a bunch of units and then use a debug command to continue to the next scenario.
20170607 17:13:52< JyrkiVesterinen> (Although that wouldn't give them any XP, so you'd need to figure something out for that...)
20170607 17:14:41< universecoder> JyrkiVesterinen: That's why I didn't use the debug command
20170607 17:15:01< universecoder> For the XP I would have to make them fight
20170607 17:15:15< universecoder> Which would take time
20170607 17:15:26< zookeeper> or use :unit experience=34
20170607 17:15:50< zookeeper> (which of course would be tedious if you need a lot of units with XP)
20170607 17:26:18-!- tommd [~tommd@glacier.galois.com] has joined #wesnoth-dev
20170607 17:26:36< tommd> As stated in #wesnoth, I desire to apply a static analysis tool to wesnoth.
20170607 17:27:13< tommd> This desire is largely a desire to not apply the tool to the typical demonstration code bases such as embedded systems and loop in something a little surprising.
20170607 17:27:44< tommd> A main issue is that I do not know the wesnoth code base nor can I quickly decide on a function's pre and post conditions.  I'm curious if anyone here has suggestions.
20170607 17:28:13< universecoder> tommd: What is a static analysis tool?
20170607 17:28:32< tommd> Under the covers, it is SAW
20170607 17:28:40< tommd> https://saw.galois.com/
20170607 17:29:17-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:8993:aa44:11bc:492f] has quit [Remote host closed the connection]
20170607 17:29:43< universecoder> tommd: nice
20170607 17:51:06-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170607 17:58:26< universecoder> JyrkiVesterinen: https://paste.ofcode.org/gDPmwcuXKrd8DL8EXntSq5 Is this good? Tested properly this time
20170607 18:00:33< JyrkiVesterinen> I'd use "else" in lines 5 and 8.
20170607 18:00:40< JyrkiVesterinen> Other than that, it looks fine.
20170607 18:02:42< universecoder> JyrkiVesterinen: https://paste.ofcode.org/hp5rHbQChZrUijdC7HCfbh
20170607 18:04:10< JyrkiVesterinen> That looks OK to me.
20170607 18:04:39-!- Kwandulin [~Kwandulin@p200300760F3201D6253E9357BE79E489.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170607 18:05:33-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170607 18:05:44< universecoder> JyrkiVesterinen: which one is better in your opinion?
20170607 18:05:46< universecoder> JyrkiVesterinen: https://paste.ofcode.org/U5x8637kq7gkMWHCrVNNbn
20170607 18:06:19< JyrkiVesterinen> The one you just linked.
20170607 18:06:35< JyrkiVesterinen> (Which is the one I recommended all along, and roughly how I would have done it.)
20170607 18:06:57< JyrkiVesterinen> In particular, it addresses gfgtdf's concern.
20170607 18:07:18< vultraz_iOS> do put the lamda on its own line though
20170607 18:07:23< vultraz_iOS> lambda
20170607 18:07:33< JyrkiVesterinen> (But the operator should be subtraction and not addition.)
20170607 18:08:24< universecoder> JyrkiVesterinen: Why subtraction?
20170607 18:08:33< universecoder> JyrkiVesterinen: And how would you have done this?
20170607 18:09:12< JyrkiVesterinen> Right now your implementation sorts to the top the units which have the highest level and are *furthest away from level-up*.
20170607 18:09:30< JyrkiVesterinen> Of course, you want units *closest to level-up* to top.
20170607 18:09:43-!- Kwandulin [~Kwandulin@p200300760F3201D6253E9357BE79E489.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170607 18:09:44< universecoder> JyrkiVesterinen: yikes
20170607 18:10:42< JyrkiVesterinen> list.register_sorting_option(2, [this](const int i) { return recall_list_[i]->level() - recall_list_[i]->experience_to_advance() / 1000.0; });
20170607 18:10:52< JyrkiVesterinen> I'd have used division instead of multiplication.
20170607 18:11:02< JyrkiVesterinen> No special reason, it's just what came to my mind.
20170607 18:11:30< universecoder> Is mul ok too
20170607 18:11:38< universecoder> Well time for another pull request
20170607 18:11:39< JyrkiVesterinen> Yes, it's fine.
20170607 18:18:26-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170607 18:18:41-!- universecoder is now known as moongazer
20170607 18:24:50-!- Kwandulin [~Kwandulin@p200300760F3201D6253E9357BE79E489.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20170607 18:34:44-!- horrowind [~Thunderbi@p2003008E6C7D985F964452FFFE0220ED.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170607 18:46:41< shadowm>  Any help with this would be appreciated: https://github.com/wesnoth/wesnoth/issues/1761
20170607 18:48:05< vultraz_iOS> *pings loonycyborg and celticminstrel *
20170607 18:48:28-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170607 18:49:39< shadowm> celtic already declined to consider it.
20170607 18:50:05< vultraz_iOS> I see
20170607 18:50:29< loonycyborg> shadowm: I didn't write that forum_user_handler code. I can look into it though
20170607 18:51:23< vultraz_iOS> shadowm: have you looked at this? https://www.phpbb.com/community/viewtopic.php?f=461&t=2288631
20170607 18:52:42< loonycyborg> can you force phpbb to use old hashing maybe? 
20170607 18:54:20< moongazer> JyrkiVesterinen: Done
20170607 18:54:28< moongazer> JyrkiVesterinen: By the way, what time is it there now?
20170607 18:54:38< JyrkiVesterinen> It's 21:54 here.
20170607 18:58:42< shadowm> loonycyborg: I know who wrote it, he's not been around for 7 years approx.
20170607 18:59:07< shadowm> loonycyborg: I don't know of any way to do that and I wouldn't do it anyway.
20170607 19:00:16< shadowm> vultraz_iOS: How the fuck did you manage to find that after I spent hours searching for information to no avail.
20170607 19:00:34< vultraz_iOS> I googled "phpbb password hashing algorithm"
20170607 19:00:53< moongazer> JyrkiVesterinen: I am beginning to understand how 'tiny' things are important
20170607 19:01:14< vultraz_iOS> saw a 2015 post under "more results" for posts on their forum
20170607 19:01:26< JyrkiVesterinen> I'm actually even more strict with my own code.
20170607 19:05:19< vultraz_iOS> shadowm: is it useful?
20170607 19:08:32< moongazer> JyrkiVesterinen: Did it again. This is totally different from coding at college.
20170607 19:09:15-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170607 19:09:57< JyrkiVesterinen> Yeah, programming education doesn't really give a good picture of collaborating in a project.
20170607 19:10:51< moongazer> JyrkiVesterinen: hmm
20170607 19:11:25< JyrkiVesterinen> Especially in a project that cares about code quality and doesn't just accept everything. (The sad truth is that there are many, many software projects with absolutely horrible code. Mostly resulting from programmers and management who just don't care.)
20170607 19:11:56< JyrkiVesterinen> (Some examples: https://www.reddit.com/r/programminghorror/ )
20170607 19:13:06< moongazer> JyrkiVesterinen: I know. I have seen horrible code 
20170607 19:16:45-!- mjs-de [~mjs-de@x4db5cf8c.dyn.telefonica.de] has joined #wesnoth-dev
20170607 19:22:19-!- moongazer [31231522@gateway/web/freenode/ip.49.35.21.34] has quit [Ping timeout: 260 seconds]
20170607 19:22:26-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170607 19:28:14-!- universecoder [75de2e87@gateway/web/freenode/ip.117.222.46.135] has joined #wesnoth-dev
20170607 19:28:25< universecoder> JyrkiVesterinen: What vultraz_iOS told me is contradictory to what you are saying
20170607 19:28:49< vultraz_iOS> what did i tell you that is contradictory?
20170607 19:30:23< JyrkiVesterinen> What I wrote in GitHub: "Your custom sorting code is redundant. The listbox sorts the units by level by default, which overrides the order you set here. Please remove the custom sorting code, and only retain the change to the lambda in line 242."
20170607 19:31:33< universecoder> vultraz_iOS: That I had to use std::sort and change the default sorting order'
20170607 19:31:38< vultraz_iOS> ok just to clarify something
20170607 19:31:45< vultraz_iOS> are universecoder and moongazer different people
20170607 19:31:52< JyrkiVesterinen> No.
20170607 19:32:23< universecoder> vultraz_iOS: My irc client is damaged
20170607 19:32:28< universecoder> vultraz_iOS: lol
20170607 19:32:51< shadowm> Could you stick to a single nick to avoid confusing people?
20170607 19:35:58< universecoder> shadowm: maybe universecoder
20170607 19:36:07< universecoder> Gotta update ##chessprogramming
20170607 19:36:09< JyrkiVesterinen> universecoder: pre-sorting the list with std::sort() is useful only if the listbox doesn't sort the items by any heading by default.
20170607 19:36:30< JyrkiVesterinen> Which is *not* the case in the unit recall dialog. That dialog sorts by level by default.
20170607 19:36:49< JyrkiVesterinen> I guess that vultraz didn't check if the dialog sorts by default.
20170607 19:37:38< vultraz_iOS> I did.
20170607 19:38:18< vultraz_iOS> I think what I said still stands  pre-sorting the data is good if you want to keep that sort independent for any user input
20170607 19:38:26< vultraz_iOS> s/for/of
20170607 19:38:51< JyrkiVesterinen> But the listbox overrides the sorting order even if the user doesn't give any input...
20170607 19:39:35< vultraz_iOS> no, the default sorting option only *selects* a sorting option
20170607 19:39:42< vultraz_iOS> you can "undo" it by just deselcting it
20170607 19:39:46< vultraz_iOS> deselecting 
20170607 19:40:05 * JyrkiVesterinen launches Wesnoth to check 
20170607 19:41:48< JyrkiVesterinen> Huh. Indeed. Our listboxes allow the player to return to the default order.
20170607 19:42:41-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170607 19:42:49< JyrkiVesterinen> I didn't quite expect that. I don't recall seeing even a single listbox anywhere else that has a completely "unsorted" state.
20170607 19:43:30< vultraz_iOS> there usually isn't
20170607 19:43:39< JyrkiVesterinen> I deleted the comment requesting the removal of the custom sorting code. (However, I'm not going to merge the PR as long as the integer underflow is there.)
20170607 19:43:51< vultraz_iOS> hotkeys is one, however
20170607 19:44:10< vultraz_iOS> the default sorting over is, well, nothing at all
20170607 19:44:15< JyrkiVesterinen> I mean "in any other program / operating system / game".
20170607 19:44:34< vultraz_iOS> oh
20170607 19:46:20< universecoder> Oh god
20170607 19:48:41< shadowm> vultraz_iOS: I'll tell you whether it's helpful or not later. It does contain some useful information (namely, that the hashing algorithm selection is part of the hash itself) that might help, but I suspect in the end I'm still going to need someone else (e.g. loonycyborg) to write the code for me because I have zero experience with hashing.
20170607 19:49:03< shadowm> I *hope* only server-side changes are required.
20170607 19:49:30-!- irker397 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170607 19:55:12< universecoder> How many of you are professional game developers?
20170607 19:56:04< JyrkiVesterinen> I think I'm the only one.
20170607 19:56:30< universecoder> May I ask where you work, if you don't mind?
20170607 19:59:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170607 20:00:39< universecoder> JyrkiVesterinen: done
20170607 20:06:01< JyrkiVesterinen> Verified to work correctly.
20170607 20:06:21< JyrkiVesterinen> You still need to restore the tab indentation.
20170607 20:07:59< universecoder> JyrkiVesterinen: done
20170607 20:08:34-!- irker094 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170607 20:08:34< irker094> wesnoth: Pranav Deshpande wesnoth:master 9628109666e5 / src/gui/dialogs/ (unit_recall.cpp unit_recall.hpp): Issue #1738: Changed unit_recall dialogue box  (#1760) https://github.com/wesnoth/wesnoth/commit/9628109666e5c91633b8d70682063a975a8679ff
20170607 20:08:40< JyrkiVesterinen> Merged. :)
20170607 20:13:55< universecoder> JyrkiVesterinen: Thank you
20170607 20:17:28< universecoder> JyrkiVesterinen: Now on to the other task
20170607 20:17:29< universecoder> un
20170607 20:17:32< universecoder> *um
20170607 20:19:16< irker094> wesnoth: Jyrki Vesterinen wesnoth:master 365a8fcc913c / data/core/about.cfg: Add @universecoder to credits https://github.com/wesnoth/wesnoth/commit/365a8fcc913cac94a64d206d0144b28e206669c6
20170607 20:19:18< irker094> wesnoth: Jyrki Vesterinen wesnoth:master 5a6203bc33f6 / changelog players_changelog: Changelog entry for the implementation of #1738 https://github.com/wesnoth/wesnoth/commit/5a6203bc33f632068d8ea028330bbc03964a07d9
20170607 20:20:56< universecoder> So that is how it functions!
20170607 20:21:07< universecoder> You immediately updated the documentation as well
20170607 20:22:00< JyrkiVesterinen> Sometimes contributors are asked to do those things themselves... but I felt it would be easier for me to just do them myself.
20170607 20:23:44< universecoder> JyrkiVesterinen: You could've asked me. Next time; maybe
20170607 20:23:51< universecoder> Well onto the other task
20170607 20:24:19< JyrkiVesterinen> You can add changelog entries for your future changes if you find them notable enough.
20170607 20:24:42-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170607 20:24:43< JyrkiVesterinen> (Personally, as a developer, I add changes to the changelog fairly aggressively.)
20170607 20:24:57-!- Appleman1234 [~quassel@z190230.ppp.asahi-net.or.jp] has joined #wesnoth-dev
20170607 20:26:59-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:8993:aa44:11bc:492f] has joined #wesnoth-dev
20170607 20:31:01< universecoder> JyrkiVesterinen: I believe that's a good thing
20170607 20:31:28-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:8993:aa44:11bc:492f] has quit [Ping timeout: 246 seconds]
20170607 20:31:50< JyrkiVesterinen> Well, my view is that other developers omit changes too often. :P
20170607 20:34:04< DeFender1031> I have the best idea ever! The changelog should just be a list of ever commit message since the previous version! That way nothing is omitted and everyone's happy! It's brilliant! There's absolutely no flaw with this idea whatsoever!
20170607 20:34:13< DeFender1031> every*
20170607 20:34:58< universecoder> DeFender1031: I don't think so
20170607 20:36:14< JyrkiVesterinen> universecoder: https://media4.giphy.com/media/HVZYTlVgE908o/giphy.gif
20170607 20:37:33< universecoder> JyrkiVesterinen: Please clarify
20170607 20:39:18< JyrkiVesterinen> "You missed the joke".
20170607 20:39:29< universecoder> LOL
20170607 20:39:35< universecoder> xD
20170607 20:40:52< universecoder> JyrkiVesterinen: Why is Lua so important for game programmers?
20170607 20:41:20< JyrkiVesterinen> What do you mean "so important"?
20170607 20:41:48< tommd> important ~ common?
20170607 20:41:53< JyrkiVesterinen> It is often used for scripting in games, but it's not an absolute requirement (and besides, it's easy to learn).
20170607 20:42:48< universecoder> tommd: 
20170607 20:42:51< universecoder> yes
20170607 20:43:28-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170607 20:43:29< JyrkiVesterinen> The main reasons why games often use Lua is that its interpreter and standard library are small (usage of disk space is low, Lua isn't a problem even on mobile), its performance is quite good for a scripting language, and its design is very elegant (I like Lua myself).
20170607 20:43:52< universecoder> I see
20170607 20:43:58< universecoder> I want to learn Lua.
20170607 20:44:12< universecoder> What else should I learn to be a game programmer?
20170607 20:45:20< JyrkiVesterinen> The main languages for game programming are C++ (desktop/console) and C# (mobile).
20170607 20:45:51< universecoder> github.com/universecoder/Horus-Chess-Engine
20170607 20:45:56< universecoder> Check this out'
20170607 20:47:49< universecoder> JyrkiVesterinen: src/game_display.cpp. What do we mean by unit invalidation
20170607 20:47:50< universecoder> ?
20170607 20:48:05< JyrkiVesterinen> Ah, chess programming. It's quite interesting in my opinion as well.
20170607 20:48:22< JyrkiVesterinen> I have my own chess game project (but I have stopped maintaining it).
20170607 20:48:23< JyrkiVesterinen> https://project-invincible.sourceforge.io/
20170607 20:48:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170607 20:49:39< universecoder> JyrkiVesterinen: I made only the engine. Interfacing with the xboard GUI is simpler
20170607 20:49:51< universecoder> JyrkiVesterinen: I can't use your site
20170607 20:50:07< universecoder> But for importantly, the game_display.cpp file
20170607 20:50:09< JyrkiVesterinen> Indeed it is. I have implemented the XBoard protocol as well.
20170607 20:50:22< JyrkiVesterinen> A much faster process than the custom UI.
20170607 20:51:10< JyrkiVesterinen> Unit invalidation: the sidebar shows info about the selected and/or hovered unit.
20170607 20:51:36< JyrkiVesterinen> invalidate_unit() needs to be called whenever that info changes (for example, when the player hovers a different unit).
20170607 20:55:41< universecoder> JyrkiVesterinen: https://pastebin.com/gHysgZh5 Something silly from my beginner days of coding
20170607 21:00:57-!- JyrkiVesterinen [~JyrkiVest@78-27-123-115.bb.dnainternet.fi] has quit [Quit: Going to bed]
20170607 21:09:50< universecoder> vultraz_iOS: Look at src/game_display.cpp . Which function draws the UNITS? celticminstrel 
20170607 21:09:53< universecoder> you too
20170607 21:21:10-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:8993:aa44:11bc:492f] has joined #wesnoth-dev
20170607 21:22:51-!- RatArmy_ [~ratarmy@om126211117116.13.openmobile.ne.jp] has joined #wesnoth-dev
20170607 21:25:28-!- DeFender [~DeFender1@46-116-209-76.bb.netvision.net.il] has joined #wesnoth-dev
20170607 21:26:48-!- AI0867_ [~ai@wesnoth/developer/ai0867] has joined #wesnoth-dev
20170607 21:29:23-!- clavi [~clavi@v22017034422546657.goodsrv.de] has quit [Ping timeout: 240 seconds]
20170607 21:29:24-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Ping timeout: 240 seconds]
20170607 21:29:24-!- esr [~esr@wesnoth/developer/esr] has quit [Ping timeout: 240 seconds]
20170607 21:29:40-!- AI0867 [~ai@wesnoth/developer/ai0867] has quit [Ping timeout: 240 seconds]
20170607 21:29:40-!- Elsi [~Elsi@luwin.ulrar.net] has quit [Ping timeout: 240 seconds]
20170607 21:29:40-!- DeFender1031 [~DeFender1@46-116-209-76.bb.netvision.net.il] has quit [Ping timeout: 240 seconds]
20170607 21:30:15-!- Elsi [~Elsi@luwin.ulrar.net] has joined #wesnoth-dev
20170607 21:30:17-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170607 21:30:47-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev
20170607 21:30:47-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has quit [Changing host]
20170607 21:30:47-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev
20170607 21:36:59-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:8993:aa44:11bc:492f] has quit [Remote host closed the connection]
20170607 21:37:39-!- universecoder [75de2e87@gateway/web/freenode/ip.117.222.46.135] has quit [Ping timeout: 260 seconds]
20170607 21:38:41-!- clavi [~clavi@v22017034422546657.goodsrv.de] has joined #wesnoth-dev
20170607 21:38:47-!- RatArmy_ [~ratarmy@om126211117116.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170607 21:40:08-!- mjs-de [~mjs-de@x4db5cf8c.dyn.telefonica.de] has quit [Remote host closed the connection]
20170607 21:41:30-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:8993:aa44:11bc:492f] has joined #wesnoth-dev
20170607 22:01:31-!- atarocch [~atarocch@93.56.160.32] has quit [Ping timeout: 258 seconds]
20170607 22:04:45-!- travis-ci [~travis-ci@ec2-23-20-181-151.compute-1.amazonaws.com] has joined #wesnoth-dev
20170607 22:04:46< travis-ci> wesnoth/wesnoth#14119 (master - 9628109 : Pranav Deshpande): The build has errored.
20170607 22:04:46< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/240525155
20170607 22:04:46-!- travis-ci [~travis-ci@ec2-23-20-181-151.compute-1.amazonaws.com] has left #wesnoth-dev []
20170607 22:04:52-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:8993:aa44:11bc:492f] has quit [Remote host closed the connection]
20170607 22:05:12-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:8993:aa44:11bc:492f] has joined #wesnoth-dev
20170607 22:11:39-!- RatArmy_ [~ratarmy@om126211117116.13.openmobile.ne.jp] has joined #wesnoth-dev
20170607 22:24:04-!- horrowind [~Thunderbi@p2003008E6C7D985F964452FFFE0220ED.dip0.t-ipconnect.de] has quit [Quit: horrowind]
20170607 22:28:50-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:8993:aa44:11bc:492f] has quit [Remote host closed the connection]
20170607 22:31:58-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit []
20170607 22:37:35< irker094> wesnoth: gfgtdf wesnoth:master 5d5982c8a762 / src/gui/dialogs/unit_recall.cpp: don't assume < 1000 xp in the recall dialog. https://github.com/wesnoth/wesnoth/commit/5d5982c8a76267b8b0a351cad5871b973487af0f
20170607 22:37:53-!- gfgtdf [~chatzilla@x4e36332a.dyn.telefonica.de] has joined #wesnoth-dev
20170607 22:40:23< gfgtdf> i'm unable to assign the ^ otkey to the lua console as it was in 1.13.7 is the a known issue?
20170607 22:40:23-!- RatArmy_ [~ratarmy@om126211117116.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170607 22:48:13-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20170607 22:51:28-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20170607 22:55:40-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170607 22:59:34-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170607 23:02:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170607 23:10:12< shadowm> So the hash prefix is now $2y$ instead of $H$.
20170607 23:10:34< shadowm> Which means that it's bcrypt instead of salted MD5.
20170607 23:12:27< gfgtdf> is there an option to log verything except gui2 suff? as in --log-debug=all --log_warn=gui , does that work ?
20170607 23:12:46< vultraz_iOS> not sure
20170607 23:12:56< vultraz_iOS> you could use the logging advanced preference
20170607 23:15:39< gfgtdf> hmm no it seems like the commandline optionsl are processes independed on their order so you cannot overwrite a --log-debug with a --log-error
20170607 23:16:59< shadowm> vultraz_iOS: Yes, the link was useful insofar I can provide more information for the bug report.
20170607 23:17:16< vultraz_iOS> good, good
20170607 23:18:09< vultraz_iOS> I have been helpful
20170607 23:18:57< gfgtdf> vultraz_iOS: the loag game dialog in 1.13.8 seem to always display 100 gold for replay saves.
20170607 23:19:11< vultraz_iOS> shrug
20170607 23:19:21< vultraz_iOS> probably the value recorded for replays
20170607 23:23:54< irker094> wesnoth: sigurdfdragon wesnoth:master b26cb7aa284b / data/campaigns/Secrets_of_the_Ancients/scenarios/01_Slipping_Away.cfg: SotA S1: Simplify sentence https://github.com/wesnoth/wesnoth/commit/b26cb7aa284b5a5d5b51697aba58836f809b049c
20170607 23:25:40-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Ping timeout: 260 seconds]
20170607 23:38:31-!- Bonobo [~Bonobo@2001:44b8:254:3200:d971:f22c:a203:7da1] has joined #wesnoth-dev
20170607 23:41:31-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170607 23:42:04-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170607 23:46:42-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Ping timeout: 245 seconds]
20170607 23:49:34-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20170607 23:52:13-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:8993:aa44:11bc:492f] has joined #wesnoth-dev
20170607 23:59:54-!- travis-ci [~travis-ci@ec2-23-20-181-151.compute-1.amazonaws.com] has joined #wesnoth-dev
20170607 23:59:56< travis-ci> wesnoth/wesnoth#14121 (master - 5d5982c : gfgtdf): The build passed.
20170607 23:59:56< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/240577028
20170607 23:59:56-!- travis-ci [~travis-ci@ec2-23-20-181-151.compute-1.amazonaws.com] has left #wesnoth-dev []
--- Log closed Thu Jun 08 00:00:51 2017