--- Log opened Thu Jun 08 00:00:51 2017
20170608 00:13:28-!- Bonobo [~Bonobo@2001:44b8:254:3200:d971:f22c:a203:7da1] has quit [Ping timeout: 240 seconds]
20170608 00:13:52-!- Bonobo [~Bonobo@202.142.36.117] has joined #wesnoth-dev
20170608 00:20:31< celticminstrel> shadowm: Um, I'm quite sure client-side changes will be required. The current client can only manage MD5 hashes.
20170608 00:20:49< celticminstrel> And it is the client that does the hashing.
20170608 00:22:45-!- tommd [~tommd@glacier.galois.com] has quit [Ping timeout: 240 seconds]
20170608 00:24:55-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20170608 00:25:24-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170608 00:26:28< celticminstrel> ...in fact it wouldn't surprise me if server-side changes aren't required... but I haven't looked at the server side of this before, so I dunno.
20170608 00:29:34< shadowm> That is extremely unfortunate.
20170608 00:30:00< shadowm> In fact, it is so unfortunate, its unfortunateness can only be properly conveyed using scientific notation with powers of 10.
20170608 00:30:15< shadowm> Any ideas?
20170608 00:32:15< celticminstrel> Well, I can say that the client-side handling is in src/game_initialization_multiplayer.cpp and probably just needs to be extended to know about another type of hash (which would also need to be added to src/hash.?pp).
20170608 00:32:22< shadowm> celtic.
20170608 00:33:05< shadowm> I can't patch existing clients.
20170608 00:33:45< celticminstrel> I was kinda assuming you'd have to make another 1.12.x release...
20170608 00:34:08< shadowm> And then what? Are people going to use it?
20170608 00:34:17< celticminstrel> No idea?
20170608 00:34:23< shadowm> The answer is no?
20170608 00:34:33< shadowm> Linux distributions are the hardest to deal with.
20170608 00:35:14< celticminstrel> I don't have any ideas on letting 1.12 users still log in.
20170608 00:35:37< vultraz_iOS> then we just don't
20170608 00:35:58< celticminstrel> Are the forums already updated?
20170608 00:36:08< shadowm> Did you read the bug report?
20170608 00:36:39< celticminstrel> It sounds like they aren't.
20170608 00:37:09< shadowm> I have two choices:
20170608 00:37:29< gfgtdf> shadowm: it's possible that teh client has an option not to hash it's password, see the if here https://github.com/wesnoth/wesnoth/blob/1.12/src/multiplayer.cpp#L287 so if we can figureout to how to switch to the 'else' path we can do the hashing on the server
20170608 00:38:03< shadowm> 1) force phpBB to keep using salted MD5 and possibly have to deal with the consequences at a later time
20170608 00:38:18< shadowm> 2) not upgrade phpBB and possibly have to deal with the consequences at a later time
20170608 00:38:51< vultraz_iOS> or just upgrade, deal with it, and warn users of past versions that they can no longer login and need to upgrade
20170608 00:39:09< shadowm> vultraz_iOS, I am no longer release manager, so the person dealing with it is you.
20170608 00:39:24< vultraz_iOS> 1.12 will be EOL soon anyway.
20170608 00:39:31< celticminstrel> "soon"
20170608 00:39:33< vultraz_iOS> As of RC1
20170608 00:39:35< shadowm> And 1.13.x is a broken pile of crap.
20170608 00:39:47< shadowm> I can keep waiting, sure.
20170608 00:39:55< shadowm> Less work for me.
20170608 00:40:14< vultraz_iOS> I'm just saying I'm not against making a few users upgrade
20170608 00:40:52< shadowm> "A few."
20170608 00:41:08< shadowm> Look, I didn't self-assign the bug report for a reason.
20170608 00:41:37< shadowm> You figure out how to deal with this crap and tell me when I can pull the switch and do the upgrade without having to look at Wesnoth's codebase.
20170608 00:42:48< shadowm> Preferably figure out a future-proof solution that doesn't involve the client having special knowledge about the server's particular choice of user handler or its implementation.
20170608 00:44:14< shadowm> Also remember that you yourself agree that making authentication mandatory would help with preventing certain kinds of incidents in the future.
20170608 00:48:05< vultraz_iOS> alright
20170608 00:49:30-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:8993:aa44:11bc:492f] has quit [Remote host closed the connection]
20170608 00:51:17-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Ping timeout: 246 seconds]
20170608 01:03:10-!- gfgtdf_ [~chatzilla@x4e32b659.dyn.telefonica.de] has joined #wesnoth-dev
20170608 01:04:56-!- gfgtdf [~chatzilla@x4e36332a.dyn.telefonica.de] has quit [Ping timeout: 246 seconds]
20170608 01:05:05-!- gfgtdf_ is now known as gfgtdf
20170608 01:47:32-!- gfgtdf [~chatzilla@x4e32b659.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 53.0.3/20170518000419]]
20170608 02:24:02-!- irker094 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170608 02:40:29-!- Appleman1234 [~quassel@z190230.ppp.asahi-net.or.jp] has quit [Ping timeout: 246 seconds]
20170608 03:13:11< celticminstrel> So no-one has anything to say on PR 1758... :(
20170608 04:16:46-!- celticminstrel is now known as celmin|sleep
20170608 04:34:51-!- JyrkiVesterinen [~JyrkiVest@87-100-227-158.bb.dnainternet.fi] has joined #wesnoth-dev
20170608 04:51:16-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has quit []
20170608 05:06:52-!- moongazer [~moongazer@117.203.121.65] has joined #wesnoth-dev
20170608 05:15:08-!- Appleman1234 [~quassel@z190230.ppp.asahi-net.or.jp] has joined #wesnoth-dev
20170608 05:25:26< moongazer> HI
20170608 05:25:32< moongazer> Help with code required
20170608 05:28:56-!- ancestral [~anonymous@75-161-194-247.mpls.qwest.net] has joined #wesnoth-dev
20170608 05:41:37-!- ancestral [~anonymous@75-161-194-247.mpls.qwest.net] has quit [Quit: ancestral]
20170608 05:50:08< vultraz_iOS> what do you need
20170608 05:54:35-!- irker593 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170608 05:54:35< irker593> wesnoth: Charles Dang wesnoth:accelerated_rendering fa1524456283 / src/image.cpp: Fixup texture cache https://github.com/wesnoth/wesnoth/commit/fa1524456283ca3bc53b53d58b31184aba8ddaf0
20170608 05:55:26-!- ancestral [~anonymous@75-161-194-247.mpls.qwest.net] has joined #wesnoth-dev
20170608 05:59:31-!- moongazer [~moongazer@117.203.121.65] has quit [Ping timeout: 246 seconds]
20170608 06:00:28-!- JyrkiVesterinen [~JyrkiVest@87-100-227-158.bb.dnainternet.fi] has quit [Quit: .]
20170608 06:07:15-!- universecoder [3b5f88fb@gateway/web/freenode/ip.59.95.136.251] has joined #wesnoth-dev
20170608 06:08:03< universecoder> vultraz_iOS: Yes. 2 questions: 1. Why did the build of #1760 fail? It's correct, the other commits done after it are passing as well
20170608 06:08:15< universecoder> 2. I found it myself....
20170608 06:09:23< vultraz_iOS> universecoder: the PR was merged before the travis run could cimplete
20170608 06:09:24< vultraz_iOS> complete*
20170608 06:10:30< universecoder> vultraz_iOS: Ah I see
20170608 06:10:33< universecoder> lol
20170608 06:10:56< universecoder> vultraz_iOS: Also the std::sort thing was raised on github again
20170608 06:10:58< universecoder> I told hij
20170608 06:11:02< universecoder> *him
20170608 06:16:51< universecoder> vultraz_iOS: Currently I am doing this: https://github.com/wesnoth/wesnoth/issues/1653
20170608 06:16:55-!- atarocch [~atarocch@93.56.160.29] has joined #wesnoth-dev
20170608 06:17:01< universecoder> atarocch: hi
20170608 06:24:02< universecoder> vultraz_iOS: I have a doubt!! The files src/game_display.cpp and src/display.cpp are so similar
20170608 06:24:17< vultraz_iOS> it's rather complex, yes
20170608 06:26:02< universecoder> Can you explain it to me
20170608 06:26:40< vultraz_iOS> not exactly
20170608 06:26:46< vultraz_iOS> it's a big mess
20170608 06:26:57< vultraz_iOS> if you have a specific question, though, i could probably answer it
20170608 06:27:09< universecoder> Um
20170608 06:27:20< universecoder> I can understand it
20170608 06:28:02< universecoder> I think I got it
20170608 06:28:14< universecoder> display is the "STATIC" display
20170608 06:28:27< universecoder> game display is when the stuff is moving around
20170608 06:28:32< universecoder> AM I RIGHT
20170608 06:29:35< vultraz_iOS> kinda
20170608 06:29:39< vultraz_iOS> display is the base class
20170608 06:29:49< vultraz_iOS> game_display as the stuff displayed in the game
20170608 06:33:02< universecoder> ahaa
20170608 06:33:59< universecoder> My hypothesis is right
20170608 06:34:01< universecoder> hmmmm
20170608 06:35:58< atarocch> universecoder, hi
20170608 06:36:16< universecoder> atarocch: what do you do
20170608 06:36:47< atarocch> universecoder, in life or specifically for wesnoth? :D
20170608 06:37:14< atarocch> atarocch, I'm here mainly because I maintain the ArchLinux AUR package for wesnoth devel
20170608 06:37:19< atarocch> universecoder, 
20170608 06:37:27-!- ancestral [~anonymous@75-161-194-247.mpls.qwest.net] has quit [Quit: ancestral]
20170608 06:37:28-!- JyrkiVesterinen [~JyrkiVest@85-76-49-23-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170608 06:37:33< universecoder> atarocch: Why are you talking to yourself lol
20170608 06:37:39-!- Appleman1234 [~quassel@z190230.ppp.asahi-net.or.jp] has quit [Remote host closed the connection]
20170608 06:37:55< universecoder> vultraz_iOS: Why do you call it unit invalidation?
20170608 06:38:11< atarocch> universecoder, :D
20170608 06:38:24< universecoder> atarocch: both life and wesnoth
20170608 06:38:29< universecoder> if life != wesnoth
20170608 06:38:31-!- ancestral [~anonymous@75-161-194-247.mpls.qwest.net] has joined #wesnoth-dev
20170608 06:38:54< vultraz_iOS> it has to do with how our drawing system is set up
20170608 06:39:39< vultraz_iOS> invalidate, if i remember correctly, just means redraw a bunch of things 
20170608 06:39:40< vultraz_iOS> in this case
20170608 06:39:42< vultraz_iOS> i think
20170608 06:39:57< vultraz_iOS> but for the record i did try doing that when i attempted to fix that bug and couldn't get it to work
20170608 06:40:22< atarocch> universecoder, there was a time when life != wesnoth evaluated to false; but was long time ago :D
20170608 06:40:45< universecoder> vultraz_iOS: what bug?
20170608 06:40:58< vultraz_iOS> the bug you're working on
20170608 06:41:05< universecoder> vultraz_iOS: I think I am onto this one though
20170608 06:44:38< vultraz_iOS> oh? that's good
20170608 06:45:59-!- universecoder [3b5f88fb@gateway/web/freenode/ip.59.95.136.251] has quit [Ping timeout: 260 seconds]
20170608 06:51:23-!- universecoder [3b5f88fb@gateway/web/freenode/ip.59.95.136.251] has joined #wesnoth-dev
20170608 06:53:01< universecoder> I need a new power manager asap
20170608 06:57:05< universecoder> vultraz_iOS: What does register_bool do
20170608 06:57:44< vultraz_iOS> it sets up a "field" that manages a widget in a dialog
20170608 06:57:54< vultraz_iOS> why?
20170608 06:58:16-!- Appleman1234 [~quassel@z190230.ppp.asahi-net.or.jp] has joined #wesnoth-dev
20170608 06:58:38< universecoder> I don't understand you
20170608 06:58:47< universecoder> Why is the 4th parameter a function
20170608 06:59:07< vultraz_iOS> it's a callback
20170608 06:59:20< vultraz_iOS> ie, select option do this
20170608 07:01:47-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170608 07:02:59< universecoder> what is the display::get_singleton method?
20170608 07:04:49< vultraz_iOS> returns the display singleton
20170608 07:04:57< vultraz_iOS> there is only one display object created 
20170608 07:05:09< vultraz_iOS> so you can use that without pushing a display reference around
20170608 07:12:41-!- universecoder_ [312317ab@gateway/web/freenode/ip.49.35.23.171] has joined #wesnoth-dev
20170608 07:14:34-!- universecoder [3b5f88fb@gateway/web/freenode/ip.59.95.136.251] has quit [Ping timeout: 260 seconds]
20170608 07:32:44< universecoder_> vultraz_iOS: I am totally lost
20170608 07:33:23< universecoder_> vultraz_iOS: Is there any documentation?
20170608 07:34:00< vultraz_iOS> Not really
20170608 07:34:03< universecoder_> vultraz_iOS: Ofcourse there is
20170608 07:34:11< universecoder_> https://wiki.wesnoth.org/HackingWesnoth
20170608 07:34:18< universecoder_> I have read this
20170608 07:35:04< universecoder_> vultraz_iOS: What are your suggestions to solve this?
20170608 07:35:20< vultraz_iOS> I don't know
20170608 07:35:26< vultraz_iOS> I tried to fix it myself and couldn't
20170608 07:35:37< universecoder_> unit->anim_comp().set_selecting(); 
20170608 07:35:55< universecoder_> in mouse_events.cpp triggers the thing when clicked by mouse
20170608 07:36:18< universecoder_> or if we comment this out movement can trigger it
20170608 07:36:34< universecoder_> I can't trace the register_bool trail
20170608 07:37:01< universecoder_> We could get a 'cheap fix' but that's not what we want
20170608 07:48:45< vultraz_iOS> ignore register_bool
20170608 07:48:48< vultraz_iOS> it has to do with the UI
20170608 07:48:55< vultraz_iOS> and adds a callback for clicking on the appropriate button
20170608 07:50:44-!- universecoder_ [312317ab@gateway/web/freenode/ip.49.35.23.171] has quit [Ping timeout: 260 seconds]
20170608 08:12:59-!- atarocch [~atarocch@93.56.160.29] has quit [Ping timeout: 246 seconds]
20170608 08:19:05-!- Appleman1234 [~quassel@z190230.ppp.asahi-net.or.jp] has quit [Ping timeout: 240 seconds]
20170608 08:20:02-!- universecoder [3b5f88fb@gateway/web/freenode/ip.59.95.136.251] has joined #wesnoth-dev
20170608 08:20:57< universecoder> Suggest me a few other bugs
20170608 08:21:06< universecoder> JyrkiVesterinen: ...
20170608 08:22:25< universecoder> vultraz_iOS: ..
20170608 08:26:23-!- lobby [~wesnoth@wesnoth/bot/lobby] has joined #wesnoth-dev
20170608 08:26:23-!- Topic for #wesnoth-dev: Emergency 1.13.9 scheduled for as soon as we get these bugs fixed | Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Discord Server: https://discord.gg/tSmJS2E | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20170608 08:26:23-!- Topic set by vultraz_iOS [uid24821@wesnoth/developer/vultraz] [Mon May 22 20:36:35 2017]
20170608 08:26:23[Users #wesnoth-dev]
20170608 08:26:23[ aeth         ] [ clavi          ] [ Greg_Boggs[m]] [ JyrkiVesterinen] [ Polsaker ] [ tomreyn      ] 
20170608 08:26:23[ AI0867_      ] [ crimson_penguin] [ grzywacz     ] [ lobby          ] [ pydsigner] [ universecoder] 
20170608 08:26:23[ aidanhs      ] [ DDR            ] [ heirecka     ] [ loonycyborg    ] [ Ravana_  ] [ vincent_c    ] 
20170608 08:26:23[ Alkenrinnstet] [ DeFender       ] [ higgins      ] [ matthiaskrgr   ] [ Rhonda   ] [ vultraz_iOS  ] 
20170608 08:26:23[ ancestral    ] [ elias          ] [ Ieuan        ] [ midzer         ] [ shadowm  ] [ zookeeper    ] 
20170608 08:26:23[ APic         ] [ EliDupree      ] [ irker593     ] [ minzbonbon     ] [ Soliton  ] 
20170608 08:26:23[ atarocch     ] [ Elsi           ] [ Ivanovic     ] [ new_one        ] [ TC01     ] 
20170608 08:26:23[ Bonobo       ] [ Elvish_Hunter  ] [ iwaim__      ] [ nore           ] [ TC02     ] 
20170608 08:26:23[ celmin|sleep ] [ esr            ] [ janebot      ] [ nurupo         ] [ TheJJ    ] 
20170608 08:26:23[ ChipmunkV[m] ] [ Gambit         ] [ Jetrel_bot   ] [ oldlaptop      ] [ timotei_ ] 
20170608 08:26:23-!- Irssi: #wesnoth-dev: Total of 55 nicks [0 ops, 0 halfops, 0 voices, 55 normal]
20170608 08:26:26-!- Channel #wesnoth-dev created Tue Jan 27 05:28:41 2009
20170608 08:27:14-!- Irssi: Join to #wesnoth-dev was synced in 58 secs
20170608 08:28:31< vultraz_iOS> Just look st the list
20170608 08:28:32< vultraz_iOS> At
20170608 08:28:36< vultraz_iOS> And pick one
20170608 08:33:10< loonycyborg> vultraz_iOS: currently I think we should do the following about the forum logins
20170608 08:33:42< loonycyborg> update both 1.12 and 1.13 to use new hashes
20170608 08:34:10< loonycyborg> and synchronize next 1.13 release with forum upgrade
20170608 08:34:45< loonycyborg> note that users who didn't log into forums would still have old hashes
20170608 08:35:01< loonycyborg> and for them old clients will work
20170608 08:35:37< loonycyborg> users of new clients and servers with old hash would get error message telling them to log to forums again
20170608 08:35:49< loonycyborg> which will be the right way to update the hash
20170608 08:35:49-!- ancestral [~anonymous@75-161-194-247.mpls.qwest.net] has quit [Quit: ancestral]
20170608 08:37:10< loonycyborg> and server will need update too 
20170608 08:37:33< loonycyborg> because it deems all hashes without $H$ prefix invalid
20170608 08:40:38< loonycyborg> not sure if it's feasible to make it able to validate both kinds of hashes actually
20170608 08:41:44< loonycyborg> shadowm: what you think about the above? :P
20170608 08:43:48< loonycyborg> celmin|sleep: would using bcrypt obsolete our own salting?
20170608 08:46:03< loonycyborg> https://github.com/wesnoth/wesnoth/blob/master/src/server/forum_user_handler.cpp#L64
20170608 08:46:42< loonycyborg> like it's screwing around with salts, seeds and peppers and I don't fully understand what exactly it's doing
20170608 08:50:23 * DeFender read only the last line and briefly wondered why the dev channel had suddenly turned into a cooking show.
20170608 08:51:32< JyrkiVesterinen> :D
20170608 08:52:29< loonycyborg> The only difference is that you can't eat hashes :P
20170608 08:53:50< DeFender> loonycyborg, I beg to differ: https://en.wikipedia.org/wiki/Hash_browns
20170608 08:54:26< DeFender> also, https://en.wikipedia.org/wiki/Hash_brownies
20170608 08:54:34-!- irker593 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170608 08:55:36< loonycyborg> looks tasty
20170608 08:59:01-!- JyrkiVesterinen [~JyrkiVest@85-76-49-23-nat.elisa-mobile.fi] has quit [Quit: Lunch]
20170608 09:07:00-!- Appleman1234 [~quassel@z190230.ppp.asahi-net.or.jp] has joined #wesnoth-dev
20170608 09:09:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170608 09:22:08< universecoder> vultraz_iOS: I picked the one even you were not able to solve...
20170608 09:26:53-!- JyrkiVesterinen [~JyrkiVest@85-76-49-23-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170608 09:27:21< universecoder> JyrkiVesterinen: Help me out a bit
20170608 09:28:14< JyrkiVesterinen> Well, I can try to help you as long as it's just "a bit".
20170608 09:28:18< JyrkiVesterinen> What do you need?
20170608 09:29:29< universecoder> I have to be as specific as I can; wait a second
20170608 09:31:03< universecoder> JyrkiVesterinen: preferences_dialog.cpp
20170608 09:31:33< universecoder> JyrkiVesterinen: When we register all these boolean values, which is the function that checks for all this
20170608 09:32:05< JyrkiVesterinen> What do you mean "checks for all this"?
20170608 09:33:36< universecoder> JyrkiVesterinen: Something somewhere must be repeatedly checking the values of these variables to change the dynamics of the game(sound, animations, etc
20170608 09:34:24< JyrkiVesterinen> No, that is *not* done. Wesnoth does *not* poll for the values of preferences.
20170608 09:34:32< JyrkiVesterinen> Instead, it's event-driven.
20170608 09:35:05< JyrkiVesterinen> For example, this function is called when the player turns music on or off: https://github.com/wesnoth/wesnoth/blob/b26cb7aa284b5a5d5b51697aba58836f809b049c/src/preferences/general.cpp#L685-L704
20170608 10:07:48< universecoder> JyrkiVesterinen: https://github.com/wesnoth/wesnoth/blob/b26cb7aa284b5a5d5b51697aba58836f809b049c/src/preferences/general.cpp#L962
20170608 10:07:59< universecoder> also 967
20170608 10:08:07< universecoder> Why the 2 different functions for everything?
20170608 10:08:55< JyrkiVesterinen> One function returns the value of the preference.
20170608 10:09:03< JyrkiVesterinen> The other is called when the player changes it.
20170608 10:12:21< universecoder> JyrkiVesterinen: So it functions like a toggle switch
20170608 10:17:37< universecoder> JyrkiVesterinen: where is the set function defined? I can't find it using search
20170608 10:18:04< JyrkiVesterinen> The set function is defined in line 967.
20170608 10:18:56< universecoder> I mean -- > set("unit_standing_animations", value); <-- This set function, not set_show_standing...
20170608 10:20:47< JyrkiVesterinen> That function is defined there:
20170608 10:20:48< JyrkiVesterinen> https://github.com/wesnoth/wesnoth/blob/b26cb7aa284b5a5d5b51697aba58836f809b049c/src/preferences/general.cpp#L180
20170608 10:22:24< Soliton> the functions with toggle in their name function like a toggle switch. the normal set functions just set the given value.
20170608 10:37:33-!- JyrkiVesterinen [~JyrkiVest@85-76-49-23-nat.elisa-mobile.fi] has quit [Quit: Rebooting]
20170608 10:37:34-!- universecoder [3b5f88fb@gateway/web/freenode/ip.59.95.136.251] has quit [Ping timeout: 260 seconds]
20170608 10:39:41-!- JyrkiVesterinen [~JyrkiVest@85-76-49-23-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170608 10:54:00-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170608 11:08:04-!- RatArmy_ [~ratarmy@om126212252094.14.openmobile.ne.jp] has joined #wesnoth-dev
20170608 11:09:58-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170608 11:22:13-!- universecoder_ [31230d60@gateway/web/freenode/ip.49.35.13.96] has joined #wesnoth-dev
20170608 11:41:37< universecoder_> How do I use gdb with wesnoth?
20170608 11:42:14< JyrkiVesterinen> Like with any other program.
20170608 11:49:46-!- RatArmy_ [~ratarmy@om126212252094.14.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170608 12:07:33< universecoder_> What are .tpp files?!
20170608 12:09:37< JyrkiVesterinen> It's just a custom file extension we use for few files which contain templates.
20170608 12:09:52< JyrkiVesterinen> You may consider it equivalent to .hpp.
20170608 12:17:47< celmin|sleep> loonycyborg: I have no idea if bcrypt would obsolete our salting.
20170608 12:18:06< loonycyborg> I've read up more of it
20170608 12:18:17< loonycyborg> seems salt is part of password hash string
20170608 12:18:27< universecoder_> celmin|sleep: you are supposed to be sleeping
20170608 12:18:35< celmin|sleep> universecoder_: Liiiiiies.
20170608 12:18:37< loonycyborg> and is featured both in md5 and bcrypt based password hashes
20170608 12:18:47< celmin|sleep> In actual fact I just woke up.
20170608 12:19:01< universecoder_> lol
20170608 12:38:57-!- Bonobo [~Bonobo@202.142.36.117] has quit [Ping timeout: 240 seconds]
20170608 12:56:24-!- universecoder_ [31230d60@gateway/web/freenode/ip.49.35.13.96] has quit [Ping timeout: 260 seconds]
20170608 13:21:51-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Ping timeout: 276 seconds]
20170608 13:42:09-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170608 14:29:46-!- JyrkiVesterinen [~JyrkiVest@85-76-49-23-nat.elisa-mobile.fi] has quit [Quit: .]
20170608 14:35:56-!- irker019 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170608 14:35:56< irker019> wesnoth: loonycyborg wesnoth:1.12 72fe6a38a069 / scons/sdl.py: scons: fix out-of-tree builds without using python's operator % https://github.com/wesnoth/wesnoth/commit/72fe6a38a06920aa24e4cfcc15e5a16bb5165ff9
20170608 15:05:12-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Read error: Connection reset by peer]
20170608 15:21:48-!- Appleman1234 [~quassel@z190230.ppp.asahi-net.or.jp] has quit [Ping timeout: 240 seconds]
20170608 15:39:55-!- ancestral [~anonymous@75-161-194-247.mpls.qwest.net] has joined #wesnoth-dev
20170608 15:51:30-!- Kwandulin [~Kwandulin@p200300760F3201AF3551D4330555D911.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170608 15:53:23-!- ancestral [~anonymous@75-161-194-247.mpls.qwest.net] has quit [Quit: ancestral]
20170608 15:58:54-!- tommd [~tommd@glacier.galois.com] has joined #wesnoth-dev
20170608 16:21:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170608 16:27:32-!- JyrkiVesterinen [~JyrkiVest@87-100-212-234.bb.dnainternet.fi] has joined #wesnoth-dev
20170608 16:43:20-!- Kwandulin [~Kwandulin@p200300760F3201AF3551D4330555D911.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170608 17:13:07-!- mjs-de [~mjs-de@x4db6b547.dyn.telefonica.de] has joined #wesnoth-dev
20170608 17:17:40-!- moongazer [~moongazer@117.198.80.100] has joined #wesnoth-dev
20170608 17:23:49< irker019> wesnoth: Jyrki Vesterinen wesnoth:master 58e8f8284b1e / src/gui/dialogs/unit_recall.cpp: Stop pre-sorting the unit recall list https://github.com/wesnoth/wesnoth/commit/58e8f8284b1e17613e278d3dacba25a7aebfc1fb
20170608 17:35:52-!- gfgtdf [~chatzilla@x4e36aa31.dyn.telefonica.de] has joined #wesnoth-dev
20170608 17:44:46< moongazer> JyrkiVesterinen, hmm. but the sorting function is still useful:)
20170608 17:45:11< JyrkiVesterinen> Yes. It's still called, and therefore I didn't remove it-
20170608 17:52:46< moongazer> JyrkiVesterinen, thanks to gfgtdf 
20170608 17:56:59-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170608 18:07:05-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170608 18:16:29-!- Kwandulin [~Kwandulin@p200300760F3201AF3551D4330555D911.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170608 18:38:01-!- moongazer [~moongazer@117.198.80.100] has quit [Ping timeout: 255 seconds]
20170608 18:38:32-!- moongazer [~moongazer@117.198.80.100] has joined #wesnoth-dev
20170608 18:54:18-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170608 18:55:04-!- Kwandulin [~Kwandulin@p200300760F3201AF3551D4330555D911.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170608 19:11:06-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170608 19:32:37-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170608 19:35:22-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Read error: Connection reset by peer]
20170608 19:36:15-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170608 19:36:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 246 seconds]
20170608 19:39:50< irker019> wesnoth: Jyrki Vesterinen wesnoth:master 93be1487fac7 / src/attack_prediction.cpp: Teach damage prediction that level-up heals poison and slow https://github.com/wesnoth/wesnoth/commit/93be1487fac79406c30c71e5b2a79e43ca722770
20170608 19:41:37< zookeeper> JyrkiVesterinen, not a simple fix, eh? O.O
20170608 19:42:03< JyrkiVesterinen> Yeah... getting the math right was quite a challenge.
20170608 19:46:17< zookeeper> i would have expected it to just require removing some consideration for poison... somewhere
20170608 19:46:40< DeFender> me too...
20170608 19:50:50-!- gfgtdf [~chatzilla@x4e36aa31.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20170608 19:51:08-!- gfgtdf [~chatzilla@x4e369883.dyn.telefonica.de] has joined #wesnoth-dev
20170608 19:51:55< zookeeper> i take it that choose_attacker_weapon() chooses the default weapon via better_combat() which ends up using the attack prediction code which assigns some weight to poison, so there was no dedicated default weapon picking logic where the poison consideration could have been skipped?
20170608 19:52:16< zookeeper> at least that's my impression from browsing the code a bit
20170608 19:53:14< zookeeper> umm... or maybe not
20170608 19:53:34< zookeeper> i guess i'm just confused
20170608 19:54:16< JyrkiVesterinen> Your impression is correct.
20170608 19:54:32< JyrkiVesterinen> Attack prediction code provides the chance to be poisoned.
20170608 19:55:03< JyrkiVesterinen> And better_combat() uses poison as an important criterion.
20170608 19:56:13< JyrkiVesterinen> It would be possible to write dedicated logic for weapon picking, but IMHO the only correct solution is that attack prediction should give the correct poisoning probability.
20170608 19:56:52< zookeeper> all right
20170608 20:01:29-!- moongazer [~moongazer@117.198.80.100] has quit [Ping timeout: 260 seconds]
20170608 20:05:23-!- RatArmy_ [~ratarmy@om126234113055.16.openmobile.ne.jp] has joined #wesnoth-dev
20170608 20:06:02-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170608 20:06:05< DeFender> meaning ending poison probability, rather than the probability that a poisoning will occur...
20170608 20:06:54< DeFender> it'd also be interesting to have it cover cases like unit with 100 health and 3 points to level up fighting a level two unit (meaning that even if poisoned, it'll full-heal after the NEXT battle.)
20170608 20:07:04< DeFender> but that's probably nontrivial.
20170608 20:07:12< JyrkiVesterinen> What attack prediction returns is the probability that *the unit is poisoned after the battle*.
20170608 20:07:39< JyrkiVesterinen> It takes into account both the possibility of poisoning and (now) healing.
20170608 20:08:55< JyrkiVesterinen> Your example case could theoretically for AI. It can predict multiple battles for the same unit in a row.
20170608 20:09:40< JyrkiVesterinen> However, attack prediction machinery doesn't keep track of cumulative XP, so it doesn't actually work.
20170608 20:09:56-!- Appleman1234 [~quassel@z190230.ppp.asahi-net.or.jp] has joined #wesnoth-dev
20170608 20:17:34-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170608 20:17:52-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170608 20:32:09-!- lobby_ [~wesnoth@wesnoth/bot/lobby] has joined #wesnoth-dev
20170608 20:32:09-!- Topic for #wesnoth-dev: Emergency 1.13.9 scheduled for as soon as we get these bugs fixed | Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Discord Server: https://discord.gg/tSmJS2E | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20170608 20:32:09-!- Topic set by vultraz_iOS [uid24821@wesnoth/developer/vultraz] [Mon May 22 20:36:34 2017]
20170608 20:32:09[Users #wesnoth-dev]
20170608 20:32:09[ aeth        ] [ crimson_penguin ] [ gfgtdf       ] [ janebot        ] [ nore     ] [ stikonas   ] 
20170608 20:32:09[ AI0867_     ] [ DDR             ] [ Greg-Boggs   ] [ Jetrel_bot     ] [ nurupo   ] [ TC01       ] 
20170608 20:32:09[ aidanhs     ] [ DeFender        ] [ Greg_Boggs[m]] [ JyrkiVesterinen] [ oldlaptop] [ TC02       ] 
20170608 20:32:09[ APic        ] [ DoctorFender1031] [ grzywacz     ] [ lobby_         ] [ Polsaker ] [ TheJJ      ] 
20170608 20:32:09[ Appleman1234] [ elias           ] [ heirecka     ] [ loonycyborg    ] [ pydsigner] [ timotei_   ] 
20170608 20:32:09[ atarocch    ] [ EliDupree       ] [ higgins      ] [ matthiaskrgr   ] [ RatArmy_ ] [ tommd      ] 
20170608 20:32:09[ bumbadadabum] [ Elsi            ] [ Ieuan        ] [ midzer         ] [ Ravana_  ] [ tomreyn    ] 
20170608 20:32:09[ celmin|sleep] [ Elvish_Hunter   ] [ irker019     ] [ minzbonbon     ] [ Rhonda   ] [ vincent_c  ] 
20170608 20:32:09[ ChipmunkV[m]] [ esr             ] [ Ivanovic     ] [ mjs-de         ] [ shadowm  ] [ vultraz_iOS] 
20170608 20:32:09[ clavi       ] [ Gambit          ] [ iwaim__      ] [ new_one        ] [ Soliton  ] [ zookeeper  ] 
20170608 20:32:09-!- Irssi: #wesnoth-dev: Total of 60 nicks [0 ops, 0 halfops, 0 voices, 60 normal]
20170608 20:32:13-!- Channel #wesnoth-dev created Tue Jan 27 05:28:41 2009
20170608 20:33:06-!- Irssi: Join to #wesnoth-dev was synced in 67 secs
20170608 20:37:19-!- DeFender [~DeFender1@46-116-209-76.bb.netvision.net.il] has quit [Ping timeout: 260 seconds]
20170608 20:41:39-!- RatArmy_ [~ratarmy@om126234113055.16.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170608 21:05:02-!- JyrkiVesterinen [~JyrkiVest@87-100-212-234.bb.dnainternet.fi] has quit [Quit: .]
20170608 21:14:51-!- ancestral [~anonymous@8.42.164.21] has joined #wesnoth-dev
20170608 21:19:42-!- mjs-de [~mjs-de@x4db6b547.dyn.telefonica.de] has quit [Remote host closed the connection]
20170608 21:30:50-!- travis-ci [~travis-ci@ec2-54-146-11-29.compute-1.amazonaws.com] has joined #wesnoth-dev
20170608 21:30:51< travis-ci> wesnoth/wesnoth#14127 (master - 93be148 : Jyrki Vesterinen): The build was broken.
20170608 21:30:51< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/240927541
20170608 21:30:51-!- travis-ci [~travis-ci@ec2-54-146-11-29.compute-1.amazonaws.com] has left #wesnoth-dev []
20170608 21:33:35-!- atarocch [~atarocch@93.56.160.29] has quit [Ping timeout: 240 seconds]
20170608 21:44:00-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170608 21:55:55-!- ancestral [~anonymous@8.42.164.21] has quit [Quit: ancestral]
20170608 22:05:59-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 246 seconds]
20170608 22:34:47-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20170608 22:46:43-!- irker019 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170608 23:51:39-!- Appleman1234 [~quassel@z190230.ppp.asahi-net.or.jp] has quit [Remote host closed the connection]
--- Log closed Fri Jun 09 00:00:52 2017