--- Log opened Wed Jul 19 00:00:44 2017
20170719 00:08:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170719 00:09:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170719 00:12:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 255 seconds]
20170719 00:41:23-!- celmin [~celticmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170719 00:42:08-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170719 00:45:59-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20170719 00:46:34-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 255 seconds]
20170719 00:46:47-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170719 01:01:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170719 01:01:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170719 01:33:22-!- irker952 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170719 01:54:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170719 01:55:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170719 01:57:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20170719 02:22:23-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20170719 03:20:56-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!]
20170719 03:45:25-!- irker437 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170719 03:45:25< irker437> wesnoth: Ignacio R. Morelle website:master 5c830eb7ecfa / gettext.wesnoth.org/ (config.php functions.php grab-stats.php index.lang.php index.php langs.php): gettext.wesnoth.org: General code cleanup and forward compatibility https://github.com/wesnoth/website/commit/5c830eb7ecfa8c967e585867d3ff82990dcc5e52
20170719 03:51:35< shadowm>   6 files changed, 1127 insertions(+), 967 deletions(-)
20170719 03:51:39< shadowm>   rewrite gettext.wesnoth.org/config.php (72%)
20170719 03:51:44< shadowm>   rewrite gettext.wesnoth.org/functions.php (79%)
20170719 03:51:48< shadowm>   rewrite gettext.wesnoth.org/index.lang.php (86%)
20170719 03:51:52< shadowm>   rewrite gettext.wesnoth.org/index.php (91%)
20170719 03:51:56< shadowm>   rewrite gettext.wesnoth.org/langs.php (99%)
20170719 03:52:13< shadowm> And that doesn't even solve the greatest underlying issue with the code structure.
20170719 03:53:34< celticminstrel> I'm almost afraid to ask, but what's the greatest underlying issue with the code structure?
20170719 03:53:45< shadowm> Repetitiveness and overuse of magic array subscripts.
20170719 03:53:57< celticminstrel> Oh fuuuuuuun.
20170719 03:54:21-!- Kwandulin [~Kwandulin@p200300760F12B3BAF0E8EB542633B1E5.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170719 03:54:39< shadowm> Should've rewritten it years ago when we switched servers and couldn't get gettext.wesnoth.org to run anymore due to the short tags.
20170719 04:26:55-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20170719 04:27:00-!- crimson_penguin [~ben@wesnoth/developer/crimsonpenguin] has quit [Ping timeout: 240 seconds]
20170719 04:30:40-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170719 04:30:46-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Client Quit]
20170719 04:55:29< irker437> wesnoth: Charles Dang wesnoth:accelerated_rendering 65949873c393 / src/ (display.cpp display.hpp): Display: avoid unnecessarily (potentially) creating millions of temp vectors https://github.com/wesnoth/wesnoth/commit/65949873c393eaeeef8a28d0b65fe6d27ac4a44b
20170719 04:55:32< irker437> wesnoth: Charles Dang wesnoth:accelerated_rendering 10ed114c531a / src/units/ (map.cpp map.hpp): Unit Map: added has_unit_at helper function https://github.com/wesnoth/wesnoth/commit/10ed114c531ad4e01e59b681561d607e6b7fad3e
20170719 04:55:35< irker437> wesnoth: Charles Dang wesnoth:accelerated_rendering b7260f60c73b / src/actions/vision.cpp: Comment out an unused parameter https://github.com/wesnoth/wesnoth/commit/b7260f60c73be02b83aec16f38f5e3650fcac3fe
20170719 04:55:38< irker437> wesnoth: Charles Dang wesnoth:accelerated_rendering 0427a5547bd4 / src/ (floating_label.cpp floating_label.hpp): Added RAII helper struct to manage a floating label's lifetime https://github.com/wesnoth/wesnoth/commit/0427a5547bd45fdaa60850c955b15707246a477a
20170719 04:55:41< irker437> wesnoth: Charles Dang wesnoth:accelerated_rendering 85b8718d8195 / src/ (8 files in 2 dirs): Another large batch of progress, primarily in game_display https://github.com/wesnoth/wesnoth/commit/85b8718d819530d23d7a4e84ae0694184b333db6
20170719 04:55:44< irker437> wesnoth: Charles Dang wesnoth:accelerated_rendering a57fa95600d7 / src/display.cpp: Display: simplified a few things https://github.com/wesnoth/wesnoth/commit/a57fa95600d7b8a8247ef9cba9ae0216890fd40f
20170719 04:57:05-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170719 04:57:22< vultraz_iOS> PROGRESS
20170719 05:01:31-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 246 seconds]
20170719 05:08:26-!- Kwandulin [~Kwandulin@p200300760F12B3BAF0E8EB542633B1E5.dip0.t-ipconnect.de] has quit [Quit: [endlevel]]
20170719 05:38:30-!- travis-ci [~travis-ci@ec2-54-198-244-248.compute-1.amazonaws.com] has joined #wesnoth-dev
20170719 05:38:31< travis-ci> wesnoth/wesnoth#14446 (accelerated_rendering - a57fa95 : Charles Dang): The build is still failing.
20170719 05:38:31< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/255122963
20170719 05:38:31-!- travis-ci [~travis-ci@ec2-54-198-244-248.compute-1.amazonaws.com] has left #wesnoth-dev []
20170719 05:55:25< irker437> wesnoth: Ignacio R. Morelle wesmere:master 5ee967dc8a25 / wesmere/sass/forums.scss: sass/forums: Increase centerbox max width by 20em https://github.com/wesnoth/wesmere/commit/5ee967dc8a259418b8f415762236a3ec9f035364
20170719 05:57:43< shadowm> Since I don't feel like bumping the CSS version number for a tiny thing like that you'll have to just refresh instead.
20170719 06:21:26-!- Bonobo [~Bonobo@203.63.51.218] has quit [Read error: Connection reset by peer]
20170719 06:22:54-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20170719 06:24:13-!- Bonobo [~Bonobo@203.63.51.218] has joined #wesnoth-dev
20170719 06:45:03-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170719 06:45:21-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170719 06:49:35-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170719 07:40:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170719 07:44:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170719 08:42:33< Ravana_> gfgtdf: why WML for https://github.com/wesnoth/wesnoth/issues/1129
20170719 09:24:00-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170719 09:26:31-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20170719 09:26:56-!- Duthlet [~Duthlet@dslb-188-101-088-243.188.101.pools.vodafone-ip.de] has joined #wesnoth-dev
20170719 09:27:35-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Client Quit]
20170719 09:28:21-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170719 09:32:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170719 09:35:13-!- irker437 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170719 09:36:06-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170719 09:58:15< Coffee_irc> success!
20170719 09:58:29< Coffee_irc> finally solved https://github.com/wesnoth/wesnoth/issues/1565
20170719 09:58:55< Coffee_irc> long standing bug with animations
20170719 10:00:16< Coffee_irc> just have to remove all the std::couts in my code and will commit the fix :P
20170719 10:07:06-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170719 10:17:55< zookeeper> yay \o/
20170719 10:37:25-!- irker463 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170719 10:37:25< irker463> wesnoth: David Mikos wesnoth:master ecb51029d751 / / (6 files in 3 dirs): Fix for jumpy movements in bug #1565 https://github.com/wesnoth/wesnoth/commit/ecb51029d75153eab311513e91c95246c59c9787
20170719 10:38:11< Coffee_irc> and done
20170719 10:39:04< JyrkiVesterinen> Thank you! :)
20170719 10:40:38< Coffee_irc> you are welcome
20170719 10:41:44< Coffee_irc> combine this with accelerated rendering and a LUA engine fix and it should be pretty good
20170719 10:51:43< vultraz_iOS> \o/
20170719 10:51:52< Coffee_irc> there's more to do :P
20170719 10:52:03< vultraz_iOS> what more?
20170719 10:52:16< Coffee_irc> there's a lua thing that gfgtdf is working on
20170719 10:52:28< Coffee_irc> it causes the animations to not progress properly on movement
20170719 10:52:41< Coffee_irc> but the jumpiness should be fixed
20170719 10:53:50< Coffee_irc> there are a variety of bugs that seemed to have crept into 1.13.x
20170719 10:55:42< Coffee_irc> I notice that when you click and drag on a menu item it doesn't respond as a click
20170719 10:55:57< vultraz_iOS> That's expected
20170719 10:55:59< Coffee_irc> and other things like the planning mode crashing
20170719 10:56:10< Coffee_irc> yeah, all normal stuff before a new release
20170719 10:56:24< vultraz_iOS> No I mean it shouldn't respond as a click then
20170719 10:56:39< Coffee_irc> even if you slightly drag?
20170719 10:56:42< Coffee_irc> say 1px?
20170719 10:57:10< vultraz_iOS> Hmm
20170719 10:57:21< Coffee_irc> I think it should act as a left click
20170719 10:58:11< JyrkiVesterinen> Hmm. On desktop, it's easy enough to click without accidentally moving the mouse slightly.
20170719 10:58:18< JyrkiVesterinen> Not so on mobile (iOS/Android).
20170719 10:58:24< Coffee_irc> I find I am doing it quite regularly
20170719 10:58:34< Coffee_irc> and I am on a desktop
20170719 10:58:49< zookeeper> i accidentally drag instead of click all the time. often it leads to annoying things happening via drag-and-drop.
20170719 10:59:09< Coffee_irc> but there's supposed to be a few px before a drag is started
20170719 10:59:22< Coffee_irc> a bit of leaway
20170719 10:59:35< Coffee_irc> like when you go to resize a window
20170719 10:59:37< zookeeper> (i think drag-and-drop should usually have some time/distance threshold to prevent accidents)
20170719 10:59:49< Coffee_irc> you should be able to click within say 3px of the actual border
20170719 11:00:25< Coffee_irc> at the moment there is no threshold as far as I see
20170719 11:07:06< irker463> wesnoth: gfgtdf wesnoth:master 4c1976db28df / src/ (map_command_handler.hpp menu_events.cpp): remove unused 'assert_existence' function https://github.com/wesnoth/wesnoth/commit/4c1976db28dfc5c3bcc6f09925c7dca0af037a6f
20170719 11:11:06< Coffee_irc> funnily enough I can't replicate this although I had this problem only a couple of minutes ago
20170719 11:11:28< Coffee_irc> click/drag is fine again for me
20170719 11:25:12-!- Coffee_irc [~david@203.63.51.218] has quit [Remote host closed the connection]
20170719 11:26:45-!- Coffee_irc [~david@203.63.51.218] has joined #wesnoth-dev
20170719 11:32:52-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170719 11:36:12-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170719 11:46:49-!- travis-ci [~travis-ci@ec2-54-144-98-113.compute-1.amazonaws.com] has joined #wesnoth-dev
20170719 11:46:50< travis-ci> gfgtdf/wesnoth#885 (master - 4c1976d : gfgtdf): The build has errored.
20170719 11:46:50< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/255215365
20170719 11:46:50-!- travis-ci [~travis-ci@ec2-54-144-98-113.compute-1.amazonaws.com] has left #wesnoth-dev []
20170719 12:03:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170719 12:12:16-!- travis-ci [~travis-ci@ec2-54-166-152-142.compute-1.amazonaws.com] has joined #wesnoth-dev
20170719 12:12:18< travis-ci> wesnoth/wesnoth#14448 (master - 4c1976d : gfgtdf): The build has errored.
20170719 12:12:18< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/255215290
20170719 12:12:18-!- travis-ci [~travis-ci@ec2-54-166-152-142.compute-1.amazonaws.com] has left #wesnoth-dev []
20170719 12:13:19-!- gfgtdf [~chatzilla@x4e36a172.dyn.telefonica.de] has joined #wesnoth-dev
20170719 12:13:44< gfgtdf> Ravana_: removed, probably ment another report
20170719 12:15:17< gfgtdf> the 'Lua thing' is actually unrelated to lua, it's just that the movement code has a bad way to detect whether the unit had changed
20170719 12:19:15< Coffee_irc> hi gfgtdf
20170719 12:19:25< Coffee_irc> glad you are taking this on :D
20170719 12:19:26< gfgtdf> Coffee_irc: hi
20170719 12:20:03< gfgtdf> Coffee_irc: about #1843 what is your exact&literal  commanline command that doesn't work now ?
20170719 12:20:09< Coffee_irc> I put a commit in earlier that solves most of the movement issues
20170719 12:20:29< gfgtdf> Coffee_irc: ye i saw
20170719 12:20:46< Coffee_irc> ./wesnoth --multiplayer --debug --scenario=multiplayer_Aethermaw_test
20170719 12:21:13< gfgtdf> Coffee_irc: and multiplayer_Aethermaw_test is from an addon ?
20170719 12:21:15< Coffee_irc> I just made a mp scenario (for the movement bug fixing) that I wanted to launch from the command line
20170719 12:21:36< Coffee_irc> copied from regular Aethermaw and I removed the second player
20170719 12:21:57< Coffee_irc> so I could see the unit position and such without any other units present
20170719 12:21:58< gfgtdf> Coffee_irc: and you are sure that it'S caued by that commit? Since that one shodul really only apply to [scenario]s  not to [multiplayer]s
20170719 12:22:23< Coffee_irc> it was around that time (at least 1 of 3 commits only)
20170719 12:23:26< celticminstrel> I wish people would assign tags when they create their issues.
20170719 12:24:00< Coffee_irc> and adding the allow_new_game tag then solved it for me
20170719 12:24:06< Coffee_irc> so I'm pretty sure it was that commit
20170719 12:24:42< gfgtdf> Coffee_irc: and if you now remove allow_new_game it then won't work ?
20170719 12:24:51< Coffee_irc> yes
20170719 12:25:24< Coffee_irc> I can start through the menus in game, but not the command line
20170719 12:26:03< gfgtdf> Coffee_irc: does the normal multiplayer_Aethermaw work ?
20170719 12:26:22< gfgtdf> Coffee_irc: from commandline
20170719 12:26:38< Coffee_irc> it does
20170719 12:26:40< celticminstrel> You mean if you remove allow_new_game from it?
20170719 12:26:43< celticminstrel> Or just as it is?
20170719 12:27:24< Coffee_irc> allow_new_game isn't set
20170719 12:27:27< Coffee_irc> in the regular one
20170719 12:27:27< gfgtdf> the dfautl doesn'T ahve allow_new_game in it
20170719 12:27:34< gfgtdf> doesn't
20170719 12:28:32< gfgtdf> Coffee_irc: and you tested that your custom scenario does stop working of you remvoe allow_new_game =yes from it after it worked with allow_new_game =yes  in it?
20170719 12:28:34< Coffee_irc> neither have it, but the regular Aethermaw works from the command line
20170719 12:30:02< Coffee_irc> ok
20170719 12:30:21< Coffee_irc> now it works when I remove the line about allow_new_game
20170719 12:30:30< Coffee_irc> did you make a change?
20170719 12:31:21< gfgtdf> Coffee_irc: no i didnt't
20170719 12:31:53< gfgtdf> Coffee_irc: i tink you probably just forgot to sae the editor when you tested or similar when you tested it the first time.
20170719 12:31:54< Coffee_irc> well, maybe it was my error then
20170719 12:32:16< Coffee_irc> oh well, it all works
20170719 12:35:32< Coffee_irc> feel free to close the bug report I submitted
20170719 12:36:15< Coffee_irc> I swear I need to make the change to the cfg file to get it to work from the command line, but I have been busy with other things a lot lately also
20170719 12:37:12-!- gfgtdf [~chatzilla@x4e36a172.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20170719 12:39:54-!- gfgtdf [~chatzilla@x4e36a172.dyn.telefonica.de] has joined #wesnoth-dev
20170719 12:40:26< DeFender1031> vultraz_iOS, hooray for PROGRESS!
20170719 12:41:48< celticminstrel> ?
20170719 12:44:09< DeFender1031> celticminstrel, I was responding to: <vultraz_iOS> PROGRESS
20170719 12:44:19< celticminstrel> Oh.
20170719 12:44:31< celticminstrel> I wonder what kind of progress.
20170719 12:44:42< DeFender1031> celticminstrel, Re. "I wish people would assign tags when they create their issues.": We can't. Only devs can tag issues.
20170719 12:44:57< celticminstrel> You can't, sure, but Coffee_irc and gfgtdf can.
20170719 12:45:12< DeFender1031> Then "people" is too broad.
20170719 12:45:20< celticminstrel> I suppose it is.
20170719 12:46:14 * Coffee_irc *er hmm*
20170719 12:46:18< Coffee_irc> I at least put bug numbers in code comments
20170719 12:46:27< Coffee_irc> so am not feeling too bad about that :P
20170719 12:46:43< celticminstrel> Bug numbers in code comments? Huh, okay...
20170719 12:47:16< celticminstrel> So you did. Huh, I didn't notice.
20170719 12:47:25< Coffee_irc> like where code does obscure stuff that through modifications in the future could lead to issues easily
20170719 12:48:06< Coffee_irc> you got to start somewhere, ey
20170719 12:48:25< Coffee_irc> like google https://www.youtube.com/watch?v=gn4nRCC9TwQ
20170719 12:48:32< JyrkiVesterinen> I think having bug number in code comment is a good idea if it's otherwise unclear why the code does something.
20170719 12:48:47< JyrkiVesterinen> Such as in Coffee's commit today.
20170719 12:52:47-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20170719 12:53:32-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170719 12:53:43-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170719 12:54:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170719 12:56:11-!- Bonobo [~Bonobo@203.63.51.218] has quit [Ping timeout: 268 seconds]
20170719 12:56:20-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Client Quit]
20170719 13:18:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170719 13:18:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170719 13:48:01-!- Coffee_irc [~david@203.63.51.218] has quit [Quit: Konversation terminated!]
20170719 14:09:15-!- irker463 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170719 14:16:06-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170719 14:18:50-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20170719 14:41:30-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170719 14:41:36-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170719 14:53:10-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20170719 14:55:29-!- RatArmy_ [~ratarmy@om126161117028.8.openmobile.ne.jp] has quit [Ping timeout: 248 seconds]
20170719 15:06:53-!- RatArmy_ [~ratarmy@om126161117028.8.openmobile.ne.jp] has joined #wesnoth-dev
20170719 15:21:57-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170719 15:25:35-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170719 15:39:16-!- Kwandulin [~Kwandulin@p200300760F12B3BAF93CF094FCA237F7.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170719 15:42:44-!- atarocch [~atarocch@93.56.160.37] has quit [Ping timeout: 260 seconds]
20170719 15:43:06-!- atarocch [~atarocch@93.56.160.37] has joined #wesnoth-dev
20170719 15:49:25-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170719 15:49:33-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170719 16:04:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170719 16:27:17-!- TadCarlucci [~lundberg@74.193.219.119] has joined #wesnoth-dev
20170719 16:29:18< TadCarlucci> On current master HEAD I get a clean compile on windows but on Linux using both scons and cmake I get a boat-load of linker errors suggesting I recompile with -fPIC .. Googling suggests doing just that, so I'm trying it. But does anyone have any idea why this would suddenly (past week or so) appear?
20170719 16:32:09-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170719 16:33:51< vultraz_iOS> not that I know of
20170719 16:36:15< vultraz_iOS> best way is to just check the commit log
20170719 16:36:21< vultraz_iOS> see if anything jumps out
20170719 16:40:36< TadCarlucci> Did that.  BTW, looks like adding -fPIC the trick. Maybe it's not a commit but something about my system being at the most-current for the toolsets.
20170719 16:42:45< TadCarlucci> Frankly, I don't see why one would not want Position Independant Code .. except for certain hardware application .. maybe g++ and/or clang made a recent change.
20170719 16:46:41< TadCarlucci> As I dig around on Google I'm thinking maybe a -fPIC library was added and that is causing the errors to propagate. This concerns me, so, now that I am back to a working build, maybe I should roll back a couple weeks and see if it works there (without -fPIC) and, if so, do a bisect to see if I can find where it broke.
20170719 17:20:15-!- TadCarlucci [~lundberg@74.193.219.119] has quit [Quit: Leaving]
20170719 17:42:54-!- Duthlet [~Duthlet@dslb-188-101-088-243.188.101.pools.vodafone-ip.de] has quit [Quit: leaving]
20170719 18:16:33-!- mjs-de [~mjs-de@x4e35b5d5.dyn.telefonica.de] has joined #wesnoth-dev
20170719 18:27:12-!- Kwandulin [~Kwandulin@p200300760F12B3BAF93CF094FCA237F7.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170719 18:35:07-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Read error: Connection timed out]
20170719 18:35:47-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170719 18:42:50-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170719 18:43:38-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170719 18:52:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170719 18:58:48-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170719 19:05:11-!- Kwandulin [~Kwandulin@p200300760F12B3BAF93CF094FCA237F7.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170719 19:11:51-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170719 19:12:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170719 19:12:28-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170719 19:12:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170719 19:13:32-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170719 19:42:35-!- gfgtdf [~chatzilla@x4e36a172.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 54.0.1/20170628075643]]
20170719 19:45:28< vultraz_iOS> damn, there's no one around...
20170719 19:54:04< DeFender1031> Huh?
20170719 19:54:22< DeFender1031> I'm around...
20170719 19:57:12-!- irker064 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170719 19:57:12< irker064> wesnoth: Charles Dang wesnoth:accelerated_rendering 31a124dc90e5 / src/sdl/texture.cpp: SDL/Texture: avoid unnecessary shared_ptr creation https://github.com/wesnoth/wesnoth/commit/31a124dc90e5df5c83a0fb10a0a03440f735af19
20170719 19:58:15< vultraz_iOS> I was going to ask if using operator= in the previous context resulted in a bunch of temp shared_ptrs but on further consideration the answer is obviously yes.
20170719 19:58:22< vultraz_iOS> was being confused by rvales for a sec
20170719 19:58:30< DeFender1031> I see.
20170719 19:58:31-!- tinyurl_comSLASH [~ycpm5ry3@199.189.106.247] has joined #wesnoth-dev
20170719 19:59:04-!- tinyurl_comSLASH [~ycpm5ry3@199.189.106.247] has left #wesnoth-dev []
20170719 19:59:31< vultraz_iOS> or even with  texture_(make_texture_ptr(txt)) - i forgot that was a copy constructor 
20170719 20:21:11-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20170719 20:29:37-!- Kwandulin [~Kwandulin@p200300760F12B3BAF93CF094FCA237F7.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170719 21:18:44-!- mjs-de [~mjs-de@x4e35b5d5.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170719 21:29:57-!- travis-ci [~travis-ci@ec2-54-157-240-86.compute-1.amazonaws.com] has joined #wesnoth-dev
20170719 21:29:58< travis-ci> wesnoth/wesnoth#14451 (accelerated_rendering - 31a124d : Charles Dang): The build has errored.
20170719 21:29:58< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/255403969
20170719 21:29:58-!- travis-ci [~travis-ci@ec2-54-157-240-86.compute-1.amazonaws.com] has left #wesnoth-dev []
20170719 22:03:36-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.]
20170719 22:03:48-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170719 22:23:29-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 248 seconds]
20170719 22:32:54-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170719 22:33:05-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170719 22:33:21-!- Coffee_irc [~david@203.63.51.218] has joined #wesnoth-dev
20170719 22:38:10-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170719 22:56:11< irker064> wesnoth: David Mikos wesnoth:master e1e336a46c07 / data/campaigns/tutorial/ (7 files in 2 dirs): Add new princess attack animation to tutorial from HttT https://github.com/wesnoth/wesnoth/commit/e1e336a46c074d33fe4b286de687f48219c41f3e
20170719 23:04:27-!- gfgtdf [~chatzilla@x4e36a172.dyn.telefonica.de] has joined #wesnoth-dev
20170719 23:07:45< gfgtdf> coping shared ptrs like that is no problem, the value returned by make_texture_ptr is a rvalue so shared_ptr::shared_ptr(shared_ptr&&) is called which has no overhead.
20170719 23:09:46< gfgtdf> vultraz_iOS: the main performance issue is shared ptrs comes from updating the refcount, (which is done in some threadsafe way that requires thread mutexes/locks instead of just doing '++*refcount')
20170719 23:17:28< vultraz_iOS> gfgtdf: but doesn't creating a temp ptr mean the refcount is bumped and then dropped?
20170719 23:19:51< vultraz_iOS> gfgtdf: ie refcount would be 1, 2, 1
20170719 23:23:01< vultraz_iOS> gfgtdf: could i increase performance by using a weak_ptr for textures already in the main cache?
20170719 23:23:29< vultraz_iOS> singalen suggested an atomic ptr but idk how those work
20170719 23:25:06< vultraz_iOS> refcount bumps seem to be a major resource hit since they're created so frequently 
20170719 23:25:11< vultraz_iOS> `texure` objects
20170719 23:25:12< vultraz_iOS> that is
20170719 23:25:37< vultraz_iOS> texture*
20170719 23:25:44< vultraz_iOS> so I need this class to be as efficient as possible
20170719 23:26:28< vultraz_iOS> gfgtdf: thoughts?
20170719 23:40:03-!- Bonobo [~Bonobo@203.63.51.218] has joined #wesnoth-dev
20170719 23:46:08< gfgtdf> vultraz_iOS: no the refcount wouldn't get increases, since shared_ptr::shared_ptr(shared_ptr&&) or shared_ptr::operator=(shared_ptr&&) does basically a swap, there is never more than one pointer pointing to it
20170719 23:48:31< vultraz_iOS> oh
20170719 23:50:18< gfgtdf> vultraz_iOS: i am not sure whewtehr weak_pointer would incrase perfoamnce, i think weak pointer also somhow increase a refcount, i don't know how exactly weak_pointers are implemented but my guess would be that it basicalyl has a 2 refcounts, once for weak and one for normal shared pointers
20170719 23:59:57< vultraz_iOS> what about atomic ptr?
--- Log closed Thu Jul 20 00:00:22 2017