--- Log opened Tue Jul 25 00:00:26 2017
--- Day changed Tue Jul 25 2017
20170725 00:00:26< DeFender1031> gfgtdf, you're missing my point.
20170725 00:00:50< DeFender1031> gfgtdf, the point is to not suddenly change the default behavior on people without a deprecation period.
20170725 00:01:12< DeFender1031> oh, wait, I misread.
20170725 00:01:20< DeFender1031> And it seems you misunderstood what I meant.
20170725 00:02:11< DeFender1031> By "switch it" I meant "the behavior completely" not "what the default is"
20170725 00:02:35< DeFender1031> I don't think that once the old behavior has been deprecated, it should still be available.
20170725 00:04:08-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170725 00:04:19< celticminstrel> I see,
20170725 00:06:10< DeFender1031> celticminstrel, what do you see?
20170725 00:06:18< DeFender1031> The future?
20170725 00:06:18< celticminstrel> Responding to shadowm.
20170725 00:06:26< DeFender1031> The meaning of it all?
20170725 00:06:34< celticminstrel> Meh.
20170725 00:06:38< DeFender1031> Are you having a vision from the Prophets?
20170725 00:06:44< DeFender1031> :P
20170725 00:07:00< celticminstrel> Depends, are the prophets made of spaghetti? >_>
20170725 00:07:49 * celticminstrel pokes vultraz_iOS 
20170725 00:10:40< DeFender1031> No, but the profits are.
20170725 00:10:51< irker733> wesnoth: Ignacio R. Morelle wesmere:master b5f211d842e2 / wesmere/bin/htmlpost: htmlpost: Fix-up previous commit https://github.com/wesnoth/wesmere/commit/b5f211d842e2bbbea3ae68a6e6b8094c4cb4fb57
20170725 00:10:53< irker733> wesnoth: Ignacio R. Morelle wesmere:master c824e439adf8 / wesmere/bin/htmlpost: htmlpost: Substitute includes as text, not regex substitution expressions https://github.com/wesnoth/wesmere/commit/c824e439adf81aea4cf19c5a3ea9625d9e28da22
20170725 00:13:38-!- Bonobo [~Bonobo@61.68.206.22] has joined #wesnoth-dev
20170725 00:13:42< vultraz_iOS> celticminstrel: what?
20170725 00:13:53< celticminstrel> Where's your fix for 1733?
20170725 00:15:04< vultraz_iOS> What?
20170725 00:15:05< vultraz_iOS> What is 1733
20170725 00:15:14< celticminstrel> Issue number
20170725 00:15:18< celticminstrel> Illegal tile on map
20170725 00:16:07< vultraz_iOS> The part you could backport to master is keeping a gamemap smart ptr that's reset when terrain data is set instead of every draw cycle
20170725 00:16:27< celticminstrel> ...eh?
20170725 00:16:45< celticminstrel> How can that fix it?
20170725 00:16:49< vultraz_iOS> Sigh
20170725 00:16:53< vultraz_iOS> .....
20170725 00:17:15< vultraz_iOS> The error comes from the gamemap ctor
20170725 00:17:22< gfgtdf> Still it's a false positive error since it's expected that the enigne doesn't have any tiles at that point. Making it just appear less often isn't enough.
20170725 00:17:56< gfgtdf> just remove the errormessage i'd say or make is DBG_CF instead.
20170725 00:18:10< vultraz_iOS> We can change the error message
20170725 00:18:18< vultraz_iOS> Easily
20170725 00:18:23< irker733> wesnoth: Ignacio R. Morelle wesmere:master 7b0d646b7610 / static/docroot/addons/index.xml: static: A little more emphasis on the most relevant add-on server instances https://github.com/wesnoth/wesmere/commit/7b0d646b7610c9ee5b6d74a472b7114ea18ee10f
20170725 00:18:40< vultraz_iOS> Point is attempting to create the gamemap object energy draw cycle meant the error was constantly spammed
20170725 00:18:44< vultraz_iOS> Now it appears once
20170725 00:18:53< celticminstrel> Not once per invalid tile?
20170725 00:19:00< vultraz_iOS> No
20170725 00:19:08< vultraz_iOS> It was never once per invalid tile
20170725 00:19:43< gfgtdf> vultraz_iOS: so currently it parses the gamemap again at every draw cycle?
20170725 00:20:01< vultraz_iOS> If you port to master *please* copy as much from a_r as possible to save me effort when I rebase
20170725 00:20:01< vultraz_iOS> gfgtdf: yes
20170725 00:20:10< shadowm> :\
20170725 00:20:11< gfgtdf> vultraz_iOS: unrelated to this bug, that sounds like something that coudl slow wesnoth down.
20170725 00:20:17< vultraz_iOS> Keep in mind this is just the gui2 minimal
20170725 00:20:24< vultraz_iOS> Minimap
20170725 00:20:28< vultraz_iOS> Not the in-game one
20170725 00:20:33< vultraz_iOS> That functions diffrently
20170725 00:20:34< celticminstrel> I see.
20170725 00:20:41< vultraz_iOS> Bc there's already a gamemap
20170725 00:21:03< celticminstrel> Well, if I were going to backport something from a_r I'd need to find it first.
20170725 00:21:06-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170725 00:21:34< shadowm> Even if it's just the minimap, that sounds horribly inefficient.
20170725 00:21:53< vultraz_iOS> celticminstrel: https://github.com/wesnoth/wesnoth/commit/7c462efc2e9a1f4c8328119c0a7091b197cfd6de
20170725 00:22:00< shadowm> Consider a 200x200 map (the maximum Wesnoth *officially* supports and yes, there are people crazy enough to make that kind of maps and you can't convince them otherwise).
20170725 00:22:04< vultraz_iOS> plus fixes in https://github.com/wesnoth/wesnoth/commit/09cfb83d08140af219c0afc959f6bbde5467eac9
20170725 00:22:12< shadowm> That'd be 40,000 tiles.
20170725 00:22:41< vultraz_iOS> that's why my change keeps the gamemap in the widget object and only resets it when the terrain data changes
20170725 00:22:41< DeFender1031> shadowm, one man's "crazy" is another's "awesome"
20170725 00:25:37-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds]
20170725 00:26:46< irker733> wesnoth: Ignacio R. Morelle wesnoth:master 8f60f69eb4ca / data/tools/addon_manager/html.py: wam: Move add-ons web tip below the downloads explanation text https://github.com/wesnoth/wesnoth/commit/8f60f69eb4cad14200abc88195179cf361698218
20170725 00:41:46< celticminstrel> And then there's the people who make maps larger than 200x200...
20170725 00:43:52< DeFender1031> *couchaethcough*
20170725 00:44:14< DeFender1031> To be fair though, it really is a beautiful piece of work.
20170725 00:45:58< DeFender1031> Or, to be clear, I think enormous maps are wonderful, and I don't think it's unreasonable for people to make them or want them, and I think that every effort should be made to have the game perform efficiently so that creators are not limited from creaating such maps if they want to.
20170725 00:45:59< celticminstrel> Is it my imagination or does that commit have lots of stuff not directly related to the fix for illegal tile spamming.
20170725 00:47:01< shadowm> DeFender1031: Color me unsurprised.
20170725 00:47:14< celticminstrel> Oh I see, the map loader gives up at the first illegal tile.
20170725 00:47:29< celticminstrel> Can't we just make it substitute something default instead and keep going?
20170725 00:47:36< DeFender1031> shadowm, what do you mean?
20170725 00:47:57< DeFender1031> celticminstrel, what would that default be?
20170725 00:48:04< celticminstrel> Probably basic grass.
20170725 00:48:07< celticminstrel> Either that or void.
20170725 00:48:36< DeFender1031> either is probably wrong in most cases though.
20170725 00:48:50< celticminstrel> Well, nothing you'd pick would be right in most cases.
20170725 00:49:11< DeFender1031> right. which leaves giving up on error.
20170725 00:49:45< celticminstrel> But if it gives up on the first tile, and you have a hundred invalid tiles, then you may need to load the map a hundred times before you can fix them all.
20170725 00:50:24< DeFender1031> likely most of the invalid tiles will be the same type, which can be fixed with a s+r
20170725 00:50:34< celticminstrel> True.
20170725 00:52:20< DeFender1031> on the other hand, if it's being loaded in the map editor, there could be a special case for "unknown tile" which just sticks a hex similar to the "image not found" hex, but with text that says "unknown terrain" instead.
20170725 00:52:42< DeFender1031> in-game, it should probably just error out.
20170725 00:53:26< DeFender1031> but in the editor, it could be loaded with the unknown tile, which could then be edited over.
20170725 00:53:55< vultraz_iOS> "Is it my imagination or does that commit have lots of stuff not directly related to the fix for illegal tile spamming."
20170725 00:53:56< vultraz_iOS> celticminstrel: yes
20170725 00:54:05< vultraz_iOS> because that's a side effect
20170725 00:54:08< vultraz_iOS> not the purpose
20170725 00:55:14< celticminstrel> Definitely in the editor, yeah.
20170725 01:00:31< DeFender1031> celticminstrel, I'd also say that turning on the hex codes would still show whatever the invalid hex code is, and that the paint bucket tool would still paint only adjacent stuff with the same hex code (so using the tool on an unknown hex type with a different type next to it would not paint the adjacent one)
20170725 01:01:26< DeFender1031> simply put, it should just give some very simple default terrain graphics to unknown hex codes and work exactly the same otherwise.
20170725 01:02:02< celticminstrel> Something like a red hex with a question mark seems like it would be good.
20170725 01:05:26< DeFender1031> Doesn't really matter, so long as it grabs your attention and makes it clear that it's not actually supposed to be there.
20170725 01:05:32< DeFender1031> though, one thing to consider.
20170725 01:05:52< DeFender1031> it should also either be semitransparent or not cover the entire hex
20170725 01:06:06< DeFender1031> so that an unknown overlay on top of a real terrain can still be seen.
20170725 01:06:16< DeFender1031> (and so you know it's an overlay)
20170725 01:06:50< DeFender1031> or perhaps it gets ~O(50%) if it's an overlay...
20170725 01:06:53< DeFender1031> or something
20170725 01:07:00< celticminstrel> Oh, good point.
20170725 01:13:36< vultraz_iOS> celticminstrel: will you backport the change to move the gamemap member to the class?
20170725 01:13:44< vultraz_iOS> yes or no
20170725 01:13:56< celticminstrel> Probably not.
20170725 01:14:03< vultraz_iOS> alright
20170725 01:14:09< vultraz_iOS> then don't
20170725 01:14:21< vultraz_iOS> I might do it, then
20170725 01:14:26< celticminstrel> 'kay
20170725 01:15:35< vultraz_iOS> now
20170725 01:15:44< vultraz_iOS> what do you have lined up for 1.13.9
20170725 01:15:46< vultraz_iOS> specificaly
20170725 01:15:49< vultraz_iOS> specifically 
20170725 01:16:27< celticminstrel> I don't really have anything lined up at the moment.
20170725 01:17:28< celticminstrel> I guess maybe fixing the widescreen theme.
20170725 01:17:35< vultraz_iOS> I said we didn't need that
20170725 01:18:13< vultraz_iOS> you have 9 open bugs assigned to you: https://github.com/wesnoth/wesnoth/issues?q=is%3Aopen+is%3Aissue+assignee%3ACelticMinstrel+label%3Abug
20170725 01:18:23< celticminstrel> You said we didn't need it because you're scrapping ThemeWML, which would make sense if ThemeWML is going to be removed in 1.14, but I was assuming that that wouldn't be happening since Jyrki figured out the performance bottleneck.
20170725 01:18:34< vultraz_iOS> ....
20170725 01:18:46< vultraz_iOS> do you pay attention when I talk :|
20170725 01:18:52< vultraz_iOS> I said it's bad UX design so not worth it anyway
20170725 01:19:04< celticminstrel> That's not really an argument against it.
20170725 01:19:29< vultraz_iOS> why not?
20170725 01:19:47< celticminstrel> Okay, so anything to do with help can be considered postponed... and the ready for testing ones are probably fixed already, so that leaves...
20170725 01:20:01< vultraz_iOS> postpone 1771
20170725 01:20:18< celticminstrel> 1771, 1272, and 1254, and maybe 1209 and 1167.
20170725 01:20:47< celticminstrel> And "bad UX" is not an argument against it because it also gives information that's unavailable in other themes.
20170725 01:20:55< vultraz_iOS> ......
20170725 01:21:31< celticminstrel> "bad UX" isn't an argument for removing a theme in general.
20170725 01:21:36-!- Bonobo [~Bonobo@61.68.206.22] has quit [Ping timeout: 260 seconds]
20170725 01:21:42< celticminstrel> If it's "bad UX", then fix it so it's not "bad UX".
20170725 01:21:43< vultraz_iOS> of course it is!
20170725 01:21:49< celticminstrel> Don't remove it. Fix it.
20170725 01:21:52< DeFender1031> how about a compromise? you fix it my changing the UX to be better?
20170725 01:22:20< celticminstrel> I'm willing to do this, but first I want to fix it to be properly functional.
20170725 01:22:22< DeFender1031> For example, instead of having another sidebar at the opposite end of the screen, have it on the same end?
20170725 01:22:29< vultraz_iOS> well that's even worse
20170725 01:22:32-!- Bonobo [~Bonobo@61.68.206.22] has joined #wesnoth-dev
20170725 01:22:36< DeFender1031> ...
20170725 01:22:43< DeFender1031> how is that even worse?
20170725 01:22:48< vultraz_iOS> and I told you
20170725 01:23:01< celticminstrel> I don't know what kind of changes would make it not "bad UX" though, so I'd need some help deciding what to do there.
20170725 01:23:04< vultraz_iOS> *ancestral has some changes pending that would make the bar (IIRC) even wider*
20170725 01:23:09< vultraz_iOS> do you want that increase compunded?
20170725 01:23:16< celticminstrel> Bar?
20170725 01:23:18< vultraz_iOS> compounded*
20170725 01:23:20< vultraz_iOS> THE SIDEBAR
20170725 01:23:35< celticminstrel> It should be fine.
20170725 01:23:45< celticminstrel> If it's wide enough, the sidebars could be combined, too.
20170725 01:23:51< vultraz_iOS> I'm sorry, but can you stop acting like I'm talking martian when I say something obvious
20170725 01:23:54-!- gfgtdf_ [~chatzilla@x4e363b7f.dyn.telefonica.de] has joined #wesnoth-dev
20170725 01:23:58< vultraz_iOS> We're talking about the sidebar
20170725 01:24:00< vultraz_iOS> I say the bar
20170725 01:24:03< celticminstrel> The left sidebar probably doesn't need to be as wide as the right one in any case.
20170725 01:24:03< vultraz_iOS> and you ask what bar
20170725 01:24:11< celticminstrel> Well, you could've meant the status bar.
20170725 01:24:31< vultraz_iOS> *wider*
20170725 01:24:43< vultraz_iOS> how would the status bar become wider
20170725 01:24:44< celticminstrel> Fine.
20170725 01:25:40< celticminstrel> So what about having the selected unit in the top half and the hovered unit in the bottom half?
20170725 01:25:42< vultraz_iOS> and you could still even ask "the sidebar?" or something, instead of acting like I'm blithering/
20170725 01:25:45< celticminstrel> Then move the map and ToD to the left.
20170725 01:26:02-!- gfgtdf [~chatzilla@x4e369c3d.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170725 01:26:04-!- gfgtdf_ is now known as gfgtdf
20170725 01:26:04< celticminstrel> (Or move the units to the left and leave map and ToD and terrain where they are.)
20170725 01:26:17< vultraz_iOS> I'd love to have a floating minimap but I'm told that would obscure the map
20170725 01:26:47< celticminstrel> Floating minimap would be cool, but not if it obscures the map in a way that's impossible to see beneath.
20170725 01:27:00< vultraz_iOS> it could be semi -transparent
20170725 01:27:20< celticminstrel> That doesn't really help.
20170725 01:27:49< celticminstrel> You can't really see effectively through something that's semi-transparent (aka translucent).
20170725 01:28:00< celticminstrel> To see through effectively it'd need to be fully transparent.
20170725 01:28:06< vultraz_iOS> a better solution would be some sort of popup that appears when you hover over a unit while another is selected 
20170725 01:28:08< celticminstrel> (And no that does not imply invisible.)
20170725 01:28:27< celticminstrel> Well, that's outside the scope of the theme though, I think.
20170725 01:28:35< vultraz_iOS> obviously
20170725 01:28:43< vultraz_iOS> the design of the theme is flawed
20170725 01:29:35< celticminstrel> If you say so.
20170725 01:30:26< celticminstrel> Anyway, I don't have any particular plans ATM besides the widescreen theme.
20170725 01:30:44< celticminstrel> I suppose I could also remove the unitbox theme at the same time, if you want.
20170725 01:31:13< celticminstrel> It wasn't finished and doesn't work properly and even went so far as to write new semi-duplicate C++ reports just to get it to work.
20170725 01:31:35< celticminstrel> I think the idea is good though.
20170725 01:32:19< celticminstrel> And the images for it did look nice.
20170725 01:32:51< celticminstrel> Though they did take up rather a lot of space, and not using the normal ToD images is a major disadvantage.
20170725 01:35:04< celticminstrel> Out of curiosity, did ancestral plan to show the profile image in the sidebar?
20170725 01:35:32< irker733> wesnoth: Ignacio R. Morelle wesnoth:master 9a7ef678ffeb / data/tools/addon_manager/ (html.py style.css): wam: More styling work https://github.com/wesnoth/wesnoth/commit/9a7ef678ffeb18b3db76849359c672d4597f9100
20170725 01:35:35< irker733> wesnoth: Ignacio R. Morelle wesnoth:master 79a294471f35 / data/tools/addon_manager/html.py: wam: Add a hidden copy of the add-on name for sorting purposes https://github.com/wesnoth/wesnoth/commit/79a294471f3579995191ffc76d3239794a244a46
20170725 01:47:18< vultraz_iOS> no
20170725 01:47:22< vultraz_iOS> not anymore
20170725 01:53:51< irker733> wesnoth: Ignacio R. Morelle wesnoth:master a6422335133c / data/tools/addon_manager/style.css: wam: Fix add-on description tooltip's text alignment https://github.com/wesnoth/wesnoth/commit/a6422335133c3b4abda92c67a3d0ddf4e4f194af
20170725 01:53:54< irker733> wesnoth: Ignacio R. Morelle wesnoth:master cf0a389e6fc0 / data/tools/addon_manager/style.css: wam: Fix indentation https://github.com/wesnoth/wesnoth/commit/cf0a389e6fc00b5a59e9b2b691164ac43c309ebf
20170725 02:13:12-!- travis-ci [~travis-ci@ec2-54-157-1-72.compute-1.amazonaws.com] has joined #wesnoth-dev
20170725 02:13:13< travis-ci> wesnoth/wesnoth#14517 (master - 8f60f69 : Ignacio R. Morelle): The build has errored.
20170725 02:13:13< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/257120112
20170725 02:13:13-!- travis-ci [~travis-ci@ec2-54-157-1-72.compute-1.amazonaws.com] has left #wesnoth-dev []
20170725 02:18:00-!- gfgtdf [~chatzilla@x4e363b7f.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 54.0.1/20170628075643]]
20170725 02:34:26< irker733> wesnoth: Ignacio R. Morelle wesnoth:master 4ec6ef173406 / data/tools/addon_manager/style.css: wam: Left-align the whole tooltip, not just the contents https://github.com/wesnoth/wesnoth/commit/4ec6ef17340679c2b6c4ef851f083afad6b235e7
20170725 02:48:10< irker733> wesnoth: Ignacio R. Morelle wesnoth:master ad2de1b9185f / data/tools/addon_manager/html.py: wam: Remove icons' alt-text https://github.com/wesnoth/wesnoth/commit/ad2de1b9185f1ecc699ea6f3cd7bc6c0fd2d997d
20170725 02:57:13-!- travis-ci [~travis-ci@ec2-54-158-175-55.compute-1.amazonaws.com] has joined #wesnoth-dev
20170725 02:57:14< travis-ci> wesnoth/wesnoth#14518 (master - 79a2944 : Ignacio R. Morelle): The build has errored.
20170725 02:57:14< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/257134182
20170725 02:57:14-!- travis-ci [~travis-ci@ec2-54-158-175-55.compute-1.amazonaws.com] has left #wesnoth-dev []
20170725 03:42:33-!- travis-ci [~travis-ci@ec2-54-145-14-195.compute-1.amazonaws.com] has joined #wesnoth-dev
20170725 03:42:34< travis-ci> wesnoth/wesnoth#14519 (master - cf0a389 : Ignacio R. Morelle): The build has errored.
20170725 03:42:34< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/257137380
20170725 03:42:34-!- travis-ci [~travis-ci@ec2-54-145-14-195.compute-1.amazonaws.com] has left #wesnoth-dev []
20170725 04:10:34-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20170725 04:30:41-!- travis-ci [~travis-ci@ec2-54-158-175-55.compute-1.amazonaws.com] has joined #wesnoth-dev
20170725 04:30:42< travis-ci> wesnoth/wesnoth#14520 (master - 4ec6ef1 : Ignacio R. Morelle): The build has errored.
20170725 04:30:42< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/257143757
20170725 04:30:42-!- travis-ci [~travis-ci@ec2-54-158-175-55.compute-1.amazonaws.com] has left #wesnoth-dev []
20170725 04:49:44< irker733> wesnoth: Ignacio R. Morelle wesmere:master 3ad5002834a7 / wesmere/sass/forums.scss: sass/forums: Add extra rules for subsilver2/wesnoth and AcidTech https://github.com/wesnoth/wesmere/commit/3ad5002834a71dc95fba67181dbee1fad34b8373
20170725 05:20:34-!- travis-ci [~travis-ci@ec2-54-157-1-72.compute-1.amazonaws.com] has joined #wesnoth-dev
20170725 05:20:35< travis-ci> wesnoth/wesnoth#14521 (master - ad2de1b : Ignacio R. Morelle): The build has errored.
20170725 05:20:35< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/257145833
20170725 05:20:35-!- travis-ci [~travis-ci@ec2-54-157-1-72.compute-1.amazonaws.com] has left #wesnoth-dev []
20170725 06:21:26-!- EliDupree2 [~quassel@2604:a880:400:d0::9bb:2001] has quit [Quit: No Ping reply in 180 seconds.]
20170725 06:23:11-!- EliDupree [~quassel@2604:a880:400:d0::9bb:2001] has joined #wesnoth-dev
20170725 06:27:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170725 06:31:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20170725 06:31:46-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170725 06:39:23-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170725 06:40:10-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 276 seconds]
20170725 06:42:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20170725 06:43:36-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20170725 06:47:19-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170725 06:59:53< irker733> wesnoth: Ignacio R. Morelle wesnoth:master 9cb25b7b0dbb / data/tools/addon_manager/html.py: wam: Hardcode special cases for the 1.9 and trunk add-ons server names https://github.com/wesnoth/wesnoth/commit/9cb25b7b0dbbe679d8590556d80b560b316fac2d
20170725 07:02:20< irker733> wesnoth: Ignacio R. Morelle wesnoth:master 23df35f4714e / data/tools/addon_manager/html.py: wam: Not the right time of day to write Python https://github.com/wesnoth/wesnoth/commit/23df35f4714eb12d689e6e3a88ac5b3ca781ec68
20170725 07:10:15< DeFender1031> IS there a right time of day for python? :P
20170725 07:11:17< vultraz_iOS> The right time of day to write python is the time when it is the right time to write python.
20170725 07:44:13-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170725 07:44:19-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170725 08:16:22-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170725 08:16:29-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170725 08:17:04-!- travis-ci [~travis-ci@ec2-54-158-175-55.compute-1.amazonaws.com] has joined #wesnoth-dev
20170725 08:17:05< travis-ci> wesnoth/wesnoth#14522 (master - 9cb25b7 : Ignacio R. Morelle): The build has errored.
20170725 08:17:05< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/257188369
20170725 08:17:05-!- travis-ci [~travis-ci@ec2-54-158-175-55.compute-1.amazonaws.com] has left #wesnoth-dev []
20170725 08:17:55 * shadowm punches travis in the face.
20170725 08:18:10< shadowm> No-one ever reminds me to use the [ci skip] thingy.
20170725 08:20:19-!- Duthlet [~Duthlet@dslb-188-101-088-243.188.101.pools.vodafone-ip.de] has joined #wesnoth-dev
20170725 08:39:49< irker733> wesnoth: ln-zookeeper wesnoth:master 9ff528b6f303 / data/campaigns/Under_the_Burning_Suns/units/quenoth/ (Champion.cfg Flanker.cfg Ranger.cfg Sun_Shyde.cfg): UtBS: A few Quenoth unit balancing changes https://github.com/wesnoth/wesnoth/commit/9ff528b6f3035d5956760bc421013937c943da32
20170725 08:50:56-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20170725 08:56:30-!- Coffee_irc [~david@61.68.206.22] has joined #wesnoth-dev
20170725 09:00:48-!- travis-ci [~travis-ci@ec2-54-157-1-72.compute-1.amazonaws.com] has joined #wesnoth-dev
20170725 09:00:49< travis-ci> wesnoth/wesnoth#14523 (master - 23df35f : Ignacio R. Morelle): The build has errored.
20170725 09:00:49< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/257188922
20170725 09:00:49-!- travis-ci [~travis-ci@ec2-54-157-1-72.compute-1.amazonaws.com] has left #wesnoth-dev []
20170725 10:02:18-!- travis-ci [~travis-ci@ec2-54-145-14-195.compute-1.amazonaws.com] has joined #wesnoth-dev
20170725 10:02:19< travis-ci> wesnoth/wesnoth#14524 (master - 9ff528b : ln-zookeeper): The build has errored.
20170725 10:02:19< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/257215035
20170725 10:02:19-!- travis-ci [~travis-ci@ec2-54-145-14-195.compute-1.amazonaws.com] has left #wesnoth-dev []
20170725 11:10:32-!- timotei_ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 260 seconds]
20170725 11:13:56< irker733> wesnoth: David Mikos wesnoth:master b5641d8e3ccc / changelog src/whiteboard/manager.cpp: Fixed whiteboard crash on delete with multiple moves (bug #1842) https://github.com/wesnoth/wesnoth/commit/b5641d8e3ccc1c4e88f32e97939e461a80ff95bf
20170725 11:16:54-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20170725 11:27:02-!- gfgtdf [~chatzilla@x4e363b7f.dyn.telefonica.de] has joined #wesnoth-dev
20170725 11:55:23-!- Kwandulin [~Kwandulin@p200300760F12B39C2C3A872E53E95CDE.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170725 12:07:48-!- Coffee_irc [~david@61.68.206.22] has quit [Quit: Konversation terminated!]
20170725 12:17:28< zookeeper> what's this? https://forums.wesnoth.org/viewtopic.php?f=6&t=46606
20170725 12:18:03< JyrkiVesterinen> Troll?
20170725 12:18:50 * zookeeper blinks
20170725 12:18:51< zookeeper> https://bbs.archlinux.org/viewtopic.php?pid=40979
20170725 12:18:58< zookeeper> clever bot :>
20170725 12:19:30< gfgtdf> JyrkiVesterinen: the unit test still crashes
20170725 12:19:43< JyrkiVesterinen> Right. Probably a spambot strategy to send a "normal" message first and start spamming later.
20170725 12:20:01< JyrkiVesterinen> gfgtdf: Yes, I know. The segfault that celmin introduces is still there.
20170725 12:20:09< JyrkiVesterinen> *introduced
20170725 12:20:48< zookeeper> JyrkiVesterinen, i meant taking the post contents from another forum. usually they just copy posts from earlier up the same thread.
20170725 12:21:31< JyrkiVesterinen> Yes, I understood what you meant. I have seen bots copying posts beforew (but not from other forums, like here).
20170725 12:22:30< zookeeper> right
20170725 12:23:40-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170725 12:25:12 * zookeeper feels sad about banning such a magnificent specimen
20170725 12:28:00-!- Bonobo [~Bonobo@61.68.206.22] has quit [Ping timeout: 260 seconds]
20170725 12:32:52-!- travis-ci [~travis-ci@ec2-54-158-175-55.compute-1.amazonaws.com] has joined #wesnoth-dev
20170725 12:32:53< travis-ci> wesnoth/wesnoth#14525 (master - b5641d8 : David Mikos): The build has errored.
20170725 12:32:53< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/257261081
20170725 12:32:53-!- travis-ci [~travis-ci@ec2-54-158-175-55.compute-1.amazonaws.com] has left #wesnoth-dev []
20170725 12:33:45< zookeeper> gfgtdf, you typoed it as [cance_action] in a few places
20170725 12:35:21< celticminstrel> ...uhh. Why is the WML tags sidebar broken? (Or is it just me again?)
20170725 12:35:26< celticminstrel> https://wiki.wesnoth.org/ReferenceWML
20170725 12:36:08< zookeeper> works for me
20170725 12:36:21< celticminstrel> :|
20170725 12:37:18< celticminstrel> Force-refreshing isn't working...
20170725 12:37:28< celticminstrel> I feel like somehow I'm just missing a stylesheet though...
20170725 12:37:31< celticminstrel> OH
20170725 12:38:40< celticminstrel> It's because I'm not using the Wesnoth theme.
20170725 12:38:44< celticminstrel> Wesmere, whatever.
20170725 12:40:00< celticminstrel> Hmm. Wesmere looks a lot better than Glamdrol, so I could switch to it, but it'd also be nice if shadowm could inject that extra stylesheet for all themes.
20170725 12:40:55< celticminstrel> Also, the search box does not appear to give suggestions like it does in Monobook.
20170725 12:41:27-!- Kwandulin [~Kwandulin@p200300760F12B39C2C3A872E53E95CDE.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170725 12:42:33< celticminstrel> For now I'll switch it to the Wesmere theme, I guess. IIRC part of the reason for not using Glamdrol was that it hid away the maintenance functions.
20170725 12:44:04< celticminstrel> I feel like there should be some sort of highlighting on the toolbar to indicate what you're looking at (content, discussion, history, etc), but other than that, the theme looks pretty good.
20170725 12:44:28-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20170725 12:46:21< gfgtdf> celticminstrel: you saw JyrkiVesterinens nte eariler about tests crashing ?
20170725 12:46:30< celticminstrel> No?
20170725 12:47:35< JyrkiVesterinen> I initially caused the unit tests to fail (divide by zero), but later one of your commits caused them to segfault.
20170725 12:47:43< JyrkiVesterinen> 20170724 19:52:03< JyrkiVesterinen> celticminstrel: it looks like the segfault was introduced in one of your commits - b499080, 7df0da5, 40319fe or e85b429.
20170725 12:47:57< JyrkiVesterinen> I have fixed the divide-by-zero, but the segfault is still there.
20170725 12:49:16< celticminstrel> Okay, it can't be 285b429 or 7df0da5 because they only touch WML.
20170725 12:49:40< celticminstrel> Doesn't look like it could be 40319fe.
20170725 12:49:53< celticminstrel> That leaves b499080, which is mostly Vultraz.
20170725 12:50:55< celticminstrel> Though I suppose it's possible that my bit (in display.hpp) is the culprit, as that's clearly not protected against null pointer access.
20170725 12:51:09< celticminstrel> I can't look at it right now since I have to go.
20170725 12:51:24< JyrkiVesterinen> I quickly tried to look at it in GDB, and it looks like stack corruption.
20170725 12:51:42< JyrkiVesterinen> GDB was unable to give me a backtrace ("cannot access memory").
20170725 12:51:55-!- travis-ci [~travis-ci@ec2-54-145-14-195.compute-1.amazonaws.com] has joined #wesnoth-dev
20170725 12:51:56< travis-ci> gfgtdf/wesnoth#904 (c_action - 7cd6a69 : gfgtdf): The build failed.
20170725 12:51:56< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/257281944
20170725 12:51:56-!- travis-ci [~travis-ci@ec2-54-145-14-195.compute-1.amazonaws.com] has left #wesnoth-dev []
20170725 12:54:18< celticminstrel> Stack corruption, huh... does that suggest not display.hpp? Not sure...
20170725 12:55:21-!- celticminstrel is now known as celmin|away
20170725 12:55:43< celmin|away> It could still be, because I think the SDL call takes a pointer to memory in which to store info...
20170725 12:58:30< matthiaskrgr> is it on master?
20170725 12:58:34< matthiaskrgr> I can have a look with asan 
20170725 12:58:37< JyrkiVesterinen> Yes.
20170725 12:58:38< matthiaskrgr> just need to build first 
20170725 13:09:29-!- travis-ci [~travis-ci@ec2-54-158-175-55.compute-1.amazonaws.com] has joined #wesnoth-dev
20170725 13:09:30< travis-ci> gfgtdf/wesnoth#905 (c_action - a7bcf28 : gfgtdf): The build failed.
20170725 13:09:30< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/257289364
20170725 13:09:30-!- travis-ci [~travis-ci@ec2-54-158-175-55.compute-1.amazonaws.com] has left #wesnoth-dev []
20170725 13:25:40< matthiaskrgr> right
20170725 13:26:23< matthiaskrgr> https://pastebin.com/9NmwXa7W  
20170725 13:26:45< matthiaskrgr> bbiab
20170725 13:32:25< gfgtdf> matthiaskrgr: youd you please try again with "disable_loadingscreen_animation=yes" in your preferences file  ?
20170725 13:32:41-!- zookeeper_ [zookeeper@37.35.31.211] has joined #wesnoth-dev
20170725 13:32:46< gfgtdf> could*
20170725 13:32:48< JyrkiVesterinen> Hmm. That log seems to be about a different problem. Mere heap use-after-free shouldn't break GDB's backtrace function (or result in a segfault, unless the OS has unmapped the page).
20170725 13:33:38< gfgtdf> the report says also "while reporting a bug found another one. Ignoring."
20170725 13:34:12< JyrkiVesterinen> Indeed. It might be ignoring the actual problem while it reports something unrelated. :/
20170725 13:34:22< matthiaskrgr> AddressSanitizer: nested bug in the same thread, aborting.
20170725 13:34:23< matthiaskrgr> heh
20170725 13:34:26< matthiaskrgr> never seen this before
20170725 13:35:00-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has quit [Read error: Connection reset by peer]
20170725 13:35:22< matthiaskrgr> https://pastebin.com/RZ5eJXwA 
20170725 13:36:18< gfgtdf> ye that sounds more liek the bug we were talking about although we shodul sureley also fix the other one.
20170725 13:36:46< gfgtdf> matthiaskrgr: that was with disable_loadingscreen_animation=yes ?
20170725 13:36:56< matthiaskrgr> yes
20170725 13:37:11< matthiaskrgr> I just put it as first line in the preference file
20170725 13:38:04< gfgtdf> hmm it still has the 'while reporting a bug found another one' line though
20170725 13:38:59< JyrkiVesterinen> And it's still a heap use-after-free, and doesn't involve code that commit b499080 touched.
20170725 13:39:33< matthiaskrgr> https://pastebin.com/EU0VW0Pd 
20170725 13:39:39< matthiaskrgr> there seems to be some kind of threading problem
20170725 13:40:00< matthiaskrgr> output gets awfully mangled sometimes
20170725 13:46:48-!- Kwandulin [~Kwandulin@p200300760F12B39C2C88A6BA0E7E8E15.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170725 13:46:59< irker733> wesnoth: gfgtdf wesnoth:master c6fa56ecdbad / src/gui/core/timer.cpp: make gui2 timers more robust against threading issues. https://github.com/wesnoth/wesnoth/commit/c6fa56ecdbad90c971e5868d4acbf71bb653db09
20170725 13:47:11< gfgtdf> matthiaskrgr: please try with that ^
20170725 13:50:12< matthiaskrgr> https://pastebin.com/gj0YJ0C8 
20170725 13:53:32< gfgtdf> that loosk like  without disable_loadingscreen_animation=yes 
20170725 13:53:39< gfgtdf> matthiaskrgr: pleasew try with disable_loadingscreen_animation=yes 
20170725 13:54:47< matthiaskrgr> it is on >:/ 
20170725 13:55:20< matthiaskrgr> I mean, I have the flag 
20170725 13:55:39< matthiaskrgr> wait
20170725 13:56:30< matthiaskrgr> does wesnoth reset it? o.O
20170725 13:57:09< gfgtdf> matthiaskrgr: possible, but i'd be suprised if it did
20170725 13:57:14< matthiaskrgr> https://pastebin.com/4d6i2WDF  
20170725 13:57:32< matthiaskrgr> oh it sorted it 
20170725 13:57:37< matthiaskrgr> so the line was no longer at the top 
20170725 13:57:47< matthiaskrgr> or something like that 
20170725 13:58:41< gfgtdf> hmm it still looks liek without disable_loadingscreen_animation=yes, i mean disable_loadingscreen_animation=yes  should disable all the threadong stuff in the loadingscreen. 
20170725 13:58:43< matthiaskrgr> yeah, when I start and end the game, it resaves config and sorts all the entrys
20170725 14:03:10< gfgtdf> matthiaskrgr: so you are 100% sure the last entry is with disable_loadingscreen_animation=yes ?
20170725 14:03:18< gfgtdf> the last output*
20170725 14:12:31< gfgtdf> matthiaskrgr: if yes, then there is probably something wrong  with the code that checks for that setting, if you still have  time, yould you please test with changing this line https://github.com/wesnoth/wesnoth/blob/master/src/gui/dialogs/loading_screen.cpp#L217 from `const bool use_loadingscreen_animation = !preferences::disable_loadingscreen_animation();` to just `const bool use_loadingscreen_a
20170725 14:12:33< gfgtdf> nimation = false;`
20170725 14:13:20-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20170725 14:15:45-!- zookeeper_ is now known as zookeeper
20170725 14:15:48-!- zookeeper [zookeeper@37.35.31.211] has quit [Changing host]
20170725 14:15:48-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170725 14:22:01-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170725 14:52:02-!- travis-ci [~travis-ci@ec2-54-145-14-195.compute-1.amazonaws.com] has joined #wesnoth-dev
20170725 14:52:03< travis-ci> gfgtdf/wesnoth#907 (c_action - 9cc0b49 : gfgtdf): The build is still failing.
20170725 14:52:03< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/257326168
20170725 14:52:03-!- travis-ci [~travis-ci@ec2-54-145-14-195.compute-1.amazonaws.com] has left #wesnoth-dev []
20170725 14:57:03< matthiaskrgr> gfgtdf: looks like that fixes the crash
20170725 14:57:11< matthiaskrgr> but I'm not sure if it still runs any test cases that way
20170725 14:57:24< gfgtdf> matthiaskrgr: changin that cpp file ?
20170725 14:57:35< matthiaskrgr> since it only takes 2 seconds to run even with O0 + asan + ubsan :o
20170725 14:57:40< matthiaskrgr> yes
20170725 14:58:19< gfgtdf> matthiaskrgr: and no crashes / errors at all ?
20170725 14:58:38< matthiaskrgr> nothing
20170725 14:58:39< gfgtdf> matthiaskrgr: did it produce some king of outut ?
20170725 14:58:51< matthiaskrgr> no
20170725 14:59:23< matthiaskrgr> besides the asan reports of leaks in third party libs with missing debug symbols 
20170725 15:01:28< gfgtdf> hmm actually chaging that one c++ liek shodul have exactly the same effect as using disable_loadingscreen_animation=yes, since preferences::disable_loadingscreen_animation() simply returns prefs["disable_loadingscreen_animation"].to_bool(false)
20170725 15:05:09< gfgtdf> i mean the previosuyl reported problem crash is a crash that can only happen if the application closed in a unusual way. so the 'closed in a unusual way' think shodul still be there
20170725 15:09:17< gfgtdf> matthiaskrgr: can you maybe use a 'debug on break' feute to list me all execptions with stacktraces that are thrown during exeution ?
20170725 15:10:19< gfgtdf> hmm have to go now
20170725 15:10:20-!- gfgtdf [~chatzilla@x4e363b7f.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 54.0.1/20170628075643]]
20170725 15:18:00< matthiaskrgr> hm, not sure if this helps in any way :/  https://pastebin.com/kS6f2CcZ 
20170725 15:41:34-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170725 15:44:07< JyrkiVesterinen> matthiaskrgr: the unit test executable should produce output. Your modified version apparently doesn't even run the tests.
20170725 15:49:50-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: Rebooting]
20170725 15:51:04-!- Kwandulin [~Kwandulin@p200300760F12B39C2C88A6BA0E7E8E15.dip0.t-ipconnect.de] has quit [Ping timeout: 255 seconds]
20170725 15:51:57-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170725 16:07:51-!- APic [apic@apic.name] has quit [Ping timeout: 260 seconds]
20170725 16:08:32-!- APic [apic@apic.name] has joined #wesnoth-dev
20170725 16:08:51-!- Kwandulin [~Kwandulin@p200300760F5F2D6C95C0CB105B109BA7.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170725 16:10:11-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170725 16:14:53-!- mjs-de [~mjs-de@x5ce34b0f.dyn.telefonica.de] has joined #wesnoth-dev
20170725 16:17:08-!- clavi [~clavi@v22017034422546657.goodsrv.de] has quit [Ping timeout: 260 seconds]
20170725 16:23:50-!- clavi [~clavi@v22017034422546657.goodsrv.de] has joined #wesnoth-dev
20170725 16:24:20-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170725 16:29:22-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170725 16:29:28-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170725 16:36:37-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170725 16:59:35< JyrkiVesterinen> celmin|away: the author of https://github.com/wesnoth/wesnoth/pull/1858 asked in Discord about why that PR hasn't been accepted/rejected yet.
20170725 17:03:00-!- irker733 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170725 17:11:42< vultraz_iOS> we have a lot of PRs that should be merged
20170725 17:30:41< DeFender1031> "the unit test executable should produce output. Your modified version apparently doesn't even run the tests." Well, that's one way to ensure that no unit tests fail...
20170725 17:55:21-!- horrowind [~Thunderbi@p2003008E6C0B265E964452FFFE0220ED.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170725 18:02:58-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170725 18:05:53-!- gfgtdf [~chatzilla@x4e363b7f.dyn.telefonica.de] has joined #wesnoth-dev
20170725 18:06:59< vultraz_iOS> The test never fails... if you never run the test
20170725 18:07:25< vultraz_iOS> Running the test leads to a test failure. Therefor running the test is the problem :P
20170725 18:39:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170725 18:43:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20170725 19:03:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170725 19:05:59< DeFender1031> exactly my point.
20170725 19:07:34-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170725 19:11:20-!- irker851 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170725 19:11:20< irker851> wesnoth: gfgtdf wesnoth:master 8e3dd056c879 / src/pathfind/pathfind.cpp: fix #1473: cannot step on hexes with high (#1850) https://github.com/wesnoth/wesnoth/commit/8e3dd056c87998b227166f0a3fb717ae9ecc0447
20170725 19:19:08< irker851> wesnoth: gfgtdf wesnoth:master 974f09178c04 / src/ (game_events/pump.cpp game_events/pump.hpp scripting/game_lua_kernel.cpp): rename context_mutated -> undo_disabled https://github.com/wesnoth/wesnoth/commit/974f09178c046ee61929d8ad431ed755578efbae
20170725 19:19:10< irker851> wesnoth: gfgtdf wesnoth:master 821e27c34f22 / / (15 files in 5 dirs): add [cancel_action] implements #1427 https://github.com/wesnoth/wesnoth/commit/821e27c34f222c72d1cb02100370e0f7df2a75c2
20170725 19:19:12< irker851> wesnoth: gfgtdf wesnoth:master ac38604f944a / src/actions/move.cpp: format move.cpp code https://github.com/wesnoth/wesnoth/commit/ac38604f944ad55f751a29a647c5915602f94160
20170725 19:19:14< irker851> wesnoth: gfgtdf wesnoth:master e859c1da002a / data/ (5 files in 4 dirs): update mainline for [cancel_action] https://github.com/wesnoth/wesnoth/commit/e859c1da002a00b31d53fd9584b6a008323961db
20170725 19:34:30-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170725 19:38:54< irker851> wesnoth: gfgtdf wesnoth:master d822210719d0 / changelog: Update changelog https://github.com/wesnoth/wesnoth/commit/d822210719d028cc117f4dc9d977ff7107673926
20170725 19:41:10< irker851> wesnoth: gfgtdf wesnoth:master 3a9344f3076c / RELEASE_NOTES: Update RELEASE_NOTES https://github.com/wesnoth/wesnoth/commit/3a9344f3076c4ba3fa9220b8a73aaa41506be3da
20170725 19:45:46< irker851> wesnoth: gfgtdf wesnoth:master 6a7541b6df4d / RELEASE_NOTES: Update RELEASE_NOTES https://github.com/wesnoth/wesnoth/commit/6a7541b6df4d37b2f1a88acacdb3883c9b99830b
20170725 19:48:02-!- Kwandulin [~Kwandulin@p200300760F5F2D6C95C0CB105B109BA7.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170725 20:03:01-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170725 20:03:01< Appveyor> The Battle for Wesnoth (Visual Studio 2017) - Release gfgtdf 6a7541b: Update RELEASE_NOTES Failed
20170725 20:03:01< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-103
20170725 20:03:05-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170725 20:04:56< irker851> wesnoth: gfgtdf wesnoth:master d973dbae6c8f / src/actions/move.cpp: fixup ac38604f944 https://github.com/wesnoth/wesnoth/commit/d973dbae6c8f4dfcc1970e301b3a899126d98a22
20170725 20:18:36-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170725 20:22:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170725 20:40:43-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170725 21:07:46-!- travis-ci [~travis-ci@ec2-54-158-175-55.compute-1.amazonaws.com] has joined #wesnoth-dev
20170725 21:07:47< travis-ci> wesnoth/wesnoth#14532 (master - 8e3dd05 : gfgtdf): The build has errored.
20170725 21:07:48< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/257441292
20170725 21:07:48-!- travis-ci [~travis-ci@ec2-54-158-175-55.compute-1.amazonaws.com] has left #wesnoth-dev []
20170725 21:09:01-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170725 21:09:35-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170725 21:11:57-!- Jetrel_bot [~Jetrel@ec2.happyspork.com] has quit [Ping timeout: 260 seconds]
20170725 21:14:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170725 21:18:18-!- Jetrel_bot [~Jetrel@ec2.happyspork.com] has joined #wesnoth-dev
20170725 21:21:39-!- horrowind [~Thunderbi@p2003008E6C0B265E964452FFFE0220ED.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20170725 21:21:56-!- horrowind [~Thunderbi@p2003008E6C0B265E964452FFFE0220ED.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170725 21:22:28-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170725 21:31:37-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170725 21:39:07-!- horrowind [~Thunderbi@p2003008E6C0B265E964452FFFE0220ED.dip0.t-ipconnect.de] has quit [Ping timeout: 276 seconds]
20170725 21:42:58-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170725 21:53:43< vultraz_iOS> zookeeper: please merge https://github.com/wesnoth/wesnoth/pull/1851 and https://github.com/wesnoth/wesnoth/pull/1839
20170725 21:53:51< vultraz_iOS> if you deem them suitable
20170725 21:54:24< zookeeper> i will
20170725 21:54:45< vultraz_iOS> celmin|away: please deal with the following PRs:
20170725 21:54:47< vultraz_iOS> * https://github.com/wesnoth/wesnoth/pull/1725
20170725 21:55:05< vultraz_iOS> * https://github.com/wesnoth/wesnoth/pull/1793
20170725 21:55:10< vultraz_iOS> * https://github.com/wesnoth/wesnoth/pull/1799
20170725 21:55:36< vultraz_iOS> * https://github.com/wesnoth/wesnoth/pull/1811
20170725 21:55:46< vultraz_iOS> * https://github.com/wesnoth/wesnoth/pull/1824
20170725 21:56:10< vultraz_iOS> * https://github.com/wesnoth/wesnoth/pull/1858
20170725 21:56:30< vultraz_iOS> either merge or disacrd
20170725 21:56:52< vultraz_iOS> celmin|away: and don't say "eh maybe possibly". I'm tasking you with dealing with them.
20170725 21:56:59< vultraz_iOS> Not asking.
20170725 21:59:13< vultraz_iOS> If you aren't the right person to deal with one or you feel one is not finished, assign it to the right person or leave a note asking for updates and *let me known you have done so*
20170725 22:04:31-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170725 22:05:50-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170725 22:25:13-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170725 22:26:05-!- travis-ci [~travis-ci@ec2-54-158-175-55.compute-1.amazonaws.com] has joined #wesnoth-dev
20170725 22:26:06< travis-ci> wesnoth/wesnoth#14538 (master - d973dba : gfgtdf): The build has errored.
20170725 22:26:06< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/257459612
20170725 22:26:06-!- travis-ci [~travis-ci@ec2-54-158-175-55.compute-1.amazonaws.com] has left #wesnoth-dev []
20170725 22:28:32-!- Duthlet [~Duthlet@dslb-188-101-088-243.188.101.pools.vodafone-ip.de] has quit [Quit: leaving]
20170725 22:31:27-!- Bonobo [~Bonobo@61.68.206.22] has joined #wesnoth-dev
20170725 23:05:44-!- irker851 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170725 23:07:31-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170725 23:09:16-!- Bonobo [~Bonobo@61.68.206.22] has quit [Ping timeout: 268 seconds]
20170725 23:15:37-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170725 23:17:13-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170725 23:30:25-!- gfgtdf [~chatzilla@x4e363b7f.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 54.0.1/20170628075643]]
20170725 23:34:38-!- Bonobo [~Bonobo@129.127.113.184] has joined #wesnoth-dev
20170725 23:37:47-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds]
20170725 23:44:22-!- Bonobo [~Bonobo@129.127.113.184] has quit [Ping timeout: 240 seconds]
20170725 23:56:32-!- irker368 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170725 23:56:32< irker368> wesnoth: Sofartin wesnoth:master fd77dd8115c1 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Add revision info inside macOS releases. (#1858) https://github.com/wesnoth/wesnoth/commit/fd77dd8115c144b9334755fbb38b1d3719ae7b2d
20170725 23:56:49< irker368> wesnoth: Gregory A Lundberg wesnoth:master 5c4db6afded5 / src/sdl/utils.cpp: Fix variable hides variable (#1824) https://github.com/wesnoth/wesnoth/commit/5c4db6afded5d34dc62feb77edec5bb51b548e2d
20170725 23:57:15-!- deep-book-gk_ [~1wm_su@101-170.furanet.com] has joined #wesnoth-dev
20170725 23:57:33-!- deep-book-gk_ [~1wm_su@101-170.furanet.com] has left #wesnoth-dev []
20170725 23:57:40< irker368> wesnoth: Gregory A Lundberg wesnoth:master 4b39f14af4f9 / src/CMakeLists.txt: Fix Lua for CMake with clang https://github.com/wesnoth/wesnoth/commit/4b39f14af4f9b5530e7482da329e33e3a407128b
20170725 23:57:42< irker368> wesnoth: Gregory A Lundberg wesnoth:master d30b6f6438fc / src/CMakeLists.txt: Suppress clang pedantic warning in Lua https://github.com/wesnoth/wesnoth/commit/d30b6f6438fc6d3f60e1ce3364900116fb7f9976
20170725 23:57:44< irker368> wesnoth: Gregory A Lundberg wesnoth:master 23e972cba8a5 / src/lexical_cast.hpp: Correct lexical_cast for long double implicit conversion https://github.com/wesnoth/wesnoth/commit/23e972cba8a5103dd9ec3ee3ea4c1de04236dad1
20170725 23:57:46< irker368> wesnoth: Gregory A Lundberg wesnoth:master ea0053997e94 / src/ (9 files in 6 dirs): Remove unneeded ; at end of functions https://github.com/wesnoth/wesnoth/commit/ea0053997e94fe7fffd7d83c78cf0b1b2333ee7f
20170725 23:57:48< irker368> wesnoth: Gregory A Lundberg wesnoth:master 37510d9c5f11 / src/image_modifications.cpp: Use explicit cast to double instead of implicit conversion https://github.com/wesnoth/wesnoth/commit/37510d9c5f115aeaeddf0fbfd8188127fc453cfc
20170725 23:57:50< irker368> wesnoth: Gregory A Lundberg wesnoth:master 78764f854764 / src/lexical_cast.hpp: Suppress warning about possibly uninitialized by initializing https://github.com/wesnoth/wesnoth/commit/78764f85476418fccda6466a02409fa719daed48
20170725 23:57:52< irker368> wesnoth: Gregory A Lundberg wesnoth:master 8953f2aa0f7d / src/scripting/ (game_lua_kernel.cpp lua_audio.cpp): Correct float/double literal causing implicit conversion https://github.com/wesnoth/wesnoth/commit/8953f2aa0f7d7f559ff4a8acb5fe1fb049e8c16b
20170725 23:57:54< irker368> wesnoth: Gregory A Lundberg wesnoth:master 383530383ac5 / src/CMakeLists.txt: Fix campaignd missing libcrypto for CMake/clang https://github.com/wesnoth/wesnoth/commit/383530383ac53156d3a7f93cb626f6ece1ba6d68
20170725 23:57:56< irker368> wesnoth: Gregory A Lundberg wesnoth:master e5d678b69f89 / src/ (34 files in 17 dirs): Correct documentation comments for pedantic clang https://github.com/wesnoth/wesnoth/commit/e5d678b69f89ca97caffa00f24a50c016a9687bb
20170725 23:57:58< irker368> wesnoth: Celtic Minstrel wesnoth:master f1fe86ab5f89 / src/ (48 files in 20 dirs): Merge pull request #1811 from GregoryLundberg/GL_CMake_clang https://github.com/wesnoth/wesnoth/commit/f1fe86ab5f890bcde696a119247264377deeb3ee
20170725 23:58:28< irker368> wesnoth: Matthias Krüger wesnoth:master 5f7771acd4ae / src/gui/dialogs/wml_message.cpp: wml_message: fix possible nullpointer dereference. https://github.com/wesnoth/wesnoth/commit/5f7771acd4ae359b15a14686b033d04e4709bc5c
20170725 23:58:30< irker368> wesnoth: Matthias Krüger wesnoth:master 163749337984 / src/ai/configuration.hpp: ai/configuration.hpp: parse_side_config(): make arguments in declaration and def https://github.com/wesnoth/wesnoth/commit/163749337984eb4392b6da2234185391a8c8cdd1
20170725 23:58:32< irker368> wesnoth: Celtic Minstrel wesnoth:master cca277634311 / src/ (ai/configuration.hpp gui/dialogs/wml_message.cpp): Merge pull request #1799 from matthiaskrgr/cppcheck https://github.com/wesnoth/wesnoth/commit/cca277634311add76d5506cc1c7499db25f386e5
20170725 23:59:32< DeFender1031> https://i.imgflip.com/1t2o3i.jpg
--- Log closed Wed Jul 26 00:00:53 2017