--- Log opened Thu Jul 27 00:00:40 2017
--- Day changed Thu Jul 27 2017
20170727 00:00:40-!- Greg-Boggs [~greg_bogg@c-73-37-6-51.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170727 00:07:56-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170727 00:12:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170727 00:15:18-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170727 00:41:41-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170727 00:59:07< celticminstrel> So, I have two new bug reports that I want to look into before 1.13.9
20170727 01:21:09-!- gfgtdf_ [~chatzilla@x4e32b09a.dyn.telefonica.de] has joined #wesnoth-dev
20170727 01:22:51-!- gfgtdf [~chatzilla@x4e3694f2.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170727 01:23:03-!- gfgtdf_ is now known as gfgtdf
20170727 01:35:15-!- Bonobo [~Bonobo@129.127.113.188] has joined #wesnoth-dev
20170727 01:44:33< gfgtdf> celticminstrel: does that include #1855 ?
20170727 01:47:03-!- gfgtdf [~chatzilla@x4e32b09a.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20170727 01:47:42-!- gfgtdf [~chatzilla@x4e32b09a.dyn.telefonica.de] has joined #wesnoth-dev
20170727 01:53:56< celticminstrel> Not sure.
20170727 01:54:04< celticminstrel> One does involve hotkeys though.
20170727 01:54:23< celticminstrel> I suspect it wouldn't help with 1855, however...
20170727 02:04:31< gfgtdf> celticminstrel: what is the reason for the strnlen check in c274e6569d01b988d58a8215075b3f5c536cbc47 in the first place ?
20170727 02:07:04< gfgtdf> celticminstrel: i mean it clearly disables hotkeys whose keays are non-ascii characters which is obviously bad
20170727 02:08:03< celticminstrel> There seem to still be a few issues with hotkeys.
20170727 02:08:15< celticminstrel> I just discovered you can't bind to the numeric keypad. (And fixed it.)
20170727 02:08:42< celticminstrel> Then there's 1855, and also I suspect that there could be problems with the IME inappropriately grabbing input.
20170727 02:08:57< celticminstrel> And finally there's 1864.
20170727 02:11:17< celticminstrel> Unrelatedly, we really need to fix 1677.
20170727 02:11:28< celticminstrel> We have 13 blockers ATM.
20170727 02:11:32< celticminstrel> https://github.com/wesnoth/wesnoth/labels/blocker
20170727 02:13:43< celticminstrel> I can't even remember the reason for the strnlen check. Would it cause problems to instead use unicode::size?
20170727 02:14:16< celticminstrel> Roughly speaking, I think the idea was "if the string is of length 1, then it might be a hotkey".
20170727 02:14:28< celticminstrel> But I don't remember what the reason was for excluding non-ASCII characters.
20170727 02:15:00< celticminstrel> Given that there exist non-Latin keyboards (I assume!), it seems illogical to exclude non-ASCII characters from being hotkeys.
20170727 02:15:48< gfgtdf> celticminstrel: also i just tested and even in latest master the lua console shows twice
20170727 02:15:55< celticminstrel> :(
20170727 02:16:10< gfgtdf> celticminstrel: when i press "^" once, nothign happens, when i press it twice the lua consoel appears twice.,
20170727 02:16:24-!- irker875 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170727 02:16:24< irker875> wesnoth: Gregory A Lundberg wesnoth:master d89558b61139 / src/ (ai/configuration.hpp game_events/pump.cpp): Corrections for clang autodoc comments (#1862) https://github.com/wesnoth/wesnoth/commit/d89558b6113939b9442b6224f65b80eaf0ba72ad
20170727 02:16:30< celticminstrel> Urgh.
20170727 02:17:16< gfgtdf> celticminstrel: i can also press thing like "^" and then "f" in that cast it first shows the lau console then the fomula console, the problem is that presing just ^ shows nothing.
20170727 02:17:21< irker875> wesnoth: Celtic Minstrel wesnoth:master 4ce40f599253 / src/units/abilities.cpp: WFL: Allow access to gamestate functions in ability formulas https://github.com/wesnoth/wesnoth/commit/4ce40f5992537c440650807b1837cfa4c7ea427c
20170727 02:17:22< gfgtdf> case*
20170727 02:17:23< irker875> wesnoth: Celtic Minstrel wesnoth:master ce74fe433097 / src/scripting/lua_audio.cpp: Attempt to fix a crash in [music] (#1861) https://github.com/wesnoth/wesnoth/commit/ce74fe433097d250a738638b2cbe3ca878d59783
20170727 02:17:25< irker875> wesnoth: Celtic Minstrel wesnoth:master 382c469949ba / src/ (gui/dialogs/hotkey_bind.cpp key.cpp): Fix inability to bind numeric keypad keys https://github.com/wesnoth/wesnoth/commit/382c469949bace7df2e5b8102c924c50fbdc8119
20170727 02:18:08< celticminstrel> gfgtdf: Wait, is ^ a deadkey in your keylayout?
20170727 02:19:11< gfgtdf> googeling deadkey
20170727 02:19:27< gfgtdf> celticminstrel: yes probably
20170727 02:19:43< celticminstrel> Then perhaps this is a case of IME inappropriately grabbing input like I mentioned earlier.
20170727 02:19:53< gfgtdf> celticminstrel: is used to generate letters liek ê, î  or ô
20170727 02:19:58< celticminstrel> Yeah, okay.
20170727 02:20:07< gfgtdf> celticminstrel: afaik these are french
20170727 02:20:14< celticminstrel> They can be, sure.
20170727 02:20:50< celticminstrel> So if you press ^ followed by any other key, the Lua console will open?
20170727 02:21:49< gfgtdf> celticminstrel: depending on the key, if i press for xaple ^ + i it won't (since a î will be generated in textinput), but for ^ + f it will since "^f" is generated in textinput
20170727 02:21:55< gfgtdf> example
20170727 02:22:08< celticminstrel> So any non-vowel key?
20170727 02:22:46< gfgtdf> celticminstrel: i'd guess so but i didnt' test them all and i also don't speak french.
20170727 02:22:48< celticminstrel> Hmm, but the problem then is probably that we don't receive a TEXTINPUT at all... only TEXTEDITING...
20170727 02:24:38< gfgtdf> i have to sleep now.
20170727 02:24:42-!- gfgtdf [~chatzilla@x4e32b09a.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 54.0.1/20170628075643]]
20170727 02:29:41-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170727 02:33:58-!- Bonobo [~Bonobo@129.127.113.188] has quit [Ping timeout: 276 seconds]
20170727 02:35:01< irker875> wesnoth: Celtic Minstrel wesnoth:master ac063ce8e76c / src/controller_base.cpp: Try not to allow IME to intercept hotkeys https://github.com/wesnoth/wesnoth/commit/ac063ce8e76c1c0257f4a0fd7efdca49d331bf21
20170727 02:44:56< celticminstrel> Hm, I think I roughly know how to fix 1864, just need to work out the details...
20170727 02:45:22< celticminstrel> Basically, any hotkey that's triggered by a TEXTINPUT should auto-up after half a second or so.
20170727 02:45:44< celticminstrel> But if it's received again in that time, it resets the timer.
20170727 02:46:38< vultraz_iOS> why does this have to be so complicated :(
20170727 02:47:26-!- horrowind [~Thunderbi@p2003008E6C0B26D7964452FFFE0220ED.dip0.t-ipconnect.de] has quit [Quit: horrowind]
20170727 02:48:19< celticminstrel> Because we're using TEXTINPUT for something it wasn't designed for.
20170727 02:49:31< vultraz_iOS> then why can't we not
20170727 02:51:32< vultraz_iOS> why do we need to use something incorrectly
20170727 02:52:02< irker875> wesnoth: Celtic Minstrel wesnoth:fix_1855 6ad37868e77c / src/hotkey/command_executor.cpp: Use UTF8 length to decide if a TEXTINPUT is a hotkey (should fix #1855) https://github.com/wesnoth/wesnoth/commit/6ad37868e77cf4d91fd6cd06fa287518cdefaa15
20170727 02:53:00< vultraz_iOS> *pokes celticminstrel *
20170727 02:53:21< celticminstrel> We can't not use TEXTINPUT because the alternative is like using a screwdriver to hammer in a nail.
20170727 02:53:33< vultraz_iOS> what?
20170727 02:53:37< celticminstrel> It doesn't do what we need, basically.
20170727 02:53:54< vultraz_iOS> Explain this, because I don't really understand it
20170727 02:53:56< celticminstrel> It's too basic, and seems to be slightly wrong to boot.
20170727 02:53:58< vultraz_iOS> What do we want to do
20170727 02:54:19< celticminstrel> We want the hotkeys shown in the interface to match the key the user actually presses.
20170727 02:54:35< vultraz_iOS> ok
20170727 02:54:44< vultraz_iOS> and why is that a problem?
20170727 02:54:55< celticminstrel> So, if they have an AZERTY keyboard, then when they assign Z as a hotkey the interface should show it as Z, not W.
20170727 02:55:07< celticminstrel> (AZERTY keyboards swap Z and W relative to QWERTY.)
20170727 02:55:19< vultraz_iOS> Ok, so we want keycodes.
20170727 02:55:35< celticminstrel> No, because the keycode for that Z is the same as the keycode for a QWERTY W.
20170727 02:55:50< celticminstrel> The letter keys are assigned codes based on their position, not their value, for some reason.
20170727 02:56:02< vultraz_iOS> "Keycodes are meant to be layout-dependent. Think of this as "the user pressed the key that is labelled 'Q' on a specific keyboard.""
20170727 02:56:19< vultraz_iOS> "Scancodes are meant to be layout-independent. Think of this as "the user pressed the Q key as it would be on a US QWERTY keyboard" regardless of whether this is actually a European keyboard or a Dvorak keyboard or whatever. The scancode is always the same key position."
20170727 02:56:25< celticminstrel> Hmm.
20170727 02:56:47< celticminstrel> Maybe I'm wrong about the reasoning then.
20170727 02:56:52< vultraz_iOS> keycodes = value, scancode = position
20170727 02:57:07< celticminstrel> I think you'd have to ask Aginor.
20170727 02:57:19< celticminstrel> Or maybe Jyrki might know, I guess.
20170727 02:57:23< vultraz_iOS> Aginor is gone
20170727 02:57:29< celticminstrel> Or look things up in the logs.
20170727 02:58:02< vultraz_iOS> "In example, if you pressed the key that's two keys to the right of CAPS LOCK on a US QWERTY keyboard, it'll report a scancode of SDL_SCANCODE_S and a keycode of SDLK_S. The same key on a Dvorak keyboard, will report a scancode of SDL_SCANCODE_S and a keycode of SDLK_O."
20170727 02:58:21< celticminstrel> Uh. That's A, not S.
20170727 02:58:30< celticminstrel> Oh, two keys, nevermind.
20170727 02:58:30< vultraz_iOS> TWO keys right
20170727 02:58:59< celticminstrel> So scancodes are obviously wrong, but ISTR that there was a problem with keycodes, too.
20170727 02:59:08< celticminstrel> Maybe the handling of the shift key?
20170727 02:59:33< celticminstrel> If you use keycodes, you have no choice but to represent : as shift+;
20170727 02:59:49< celticminstrel> Which may not be : on all keyboards.
20170727 03:00:05< celticminstrel> Actually, I think this was indeed the reasoning...
20170727 03:01:30< vultraz_iOS> heh
20170727 03:01:38< vultraz_iOS> forums seem to support use of TEXTINPUT..
20170727 03:01:40< vultraz_iOS> https://discourse.libsdl.org/t/sdl-2-how-to-read-shift-x-keys/21238
20170727 03:08:16< celticminstrel> I think, if it were solely up to me, I'd just forsake TEXTINPUT and just write : as shift+; (with the altered implication that that gives for alternate keyboard layouts), but we've put enough effort into the TEXTINPUT solution that it'd be a shame to just scrap it right away. >_>
20170727 03:08:28< celticminstrel> Plus IIRC some people complained about that.
20170727 03:09:00< celticminstrel> RANDOM! Any thoughts on this? https://forums.wesnoth.org/viewtopic.php?f=12&t=46099&sid=ab7da626032c10183ab6b6be0c1f0fe9
20170727 03:09:05< celticminstrel> cc\ zookeeper
20170727 03:09:42< celticminstrel> (Anyone know if the game already tracks what level(s) you beat a campaign on? If so, that might be really easy to do.)
20170727 03:20:51-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20170727 03:28:21-!- travis-ci [~travis-ci@ec2-54-204-122-90.compute-1.amazonaws.com] has joined #wesnoth-dev
20170727 03:28:22< travis-ci> wesnoth/wesnoth#14558 (master - d89558b : Gregory A Lundberg): The build has errored.
20170727 03:28:22< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/257980055
20170727 03:28:22-!- travis-ci [~travis-ci@ec2-54-204-122-90.compute-1.amazonaws.com] has left #wesnoth-dev []
20170727 03:42:08-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170727 03:46:41-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds]
20170727 03:48:20< celticminstrel> Hmm, there are two problems with Travis... a crash in unit tests on one of the builds, and an error in most builds that causes them to time out...
20170727 03:49:15< vultraz_iOS> why is the crash is there
20170727 03:49:22< celticminstrel> ?
20170727 03:49:29< vultraz_iOS> in travis
20170727 03:49:42< celticminstrel> I have no idea?
20170727 03:50:53< vultraz_iOS> master passed at https://travis-ci.org/wesnoth/wesnoth/builds/255461723
20170727 03:51:06< vultraz_iOS> started failing https://travis-ci.org/wesnoth/wesnoth/builds/256361964
20170727 03:52:27< vultraz_iOS> got better in https://travis-ci.org/wesnoth/wesnoth/builds/256677035
20170727 03:57:34< celticminstrel> Did the issue someone poked me about yesterday get fixed?
20170727 03:58:41< celticminstrel> Or wait, not yesterday, it was the 25th.
20170727 03:59:03< celticminstrel> If not, that's probably the crash? As for the build error, I dunno.
20170727 03:59:11< celticminstrel> Anyway, good night.
20170727 04:02:10-!- Coffee_irc [~david@61.68.206.22] has quit [Ping timeout: 240 seconds]
20170727 04:03:16-!- Coffee_irc [~david@202.168.58.116] has joined #wesnoth-dev
20170727 04:04:37< vultraz_iOS> celticminstrel: issue?
20170727 04:04:52< celticminstrel> Something about a segfault? Ask Jyrki or something.
20170727 04:05:14< celticminstrel> Potentially caused by my backport of that thing from a_r.
20170727 04:05:20< celticminstrel> Not sure though.
20170727 04:06:03< vultraz_iOS> oh yeah
20170727 04:06:04< vultraz_iOS> i fixed that
20170727 04:06:07-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170727 04:06:10< celticminstrel> ...wait what?
20170727 04:06:12< vultraz_iOS> talk of the devil
20170727 04:06:24< vultraz_iOS> celticminstrel: he said it might fix the crash but it didn't
20170727 04:06:31< celticminstrel> Fixed what?
20170727 04:06:37< vultraz_iOS> the bad backport
20170727 04:06:39< vultraz_iOS> from a_r
20170727 04:08:29< celticminstrel> ...oh hey, you backported a ton of commits today.
20170727 04:08:34< irker875> wesnoth: Ignacio R. Morelle wesmere:master c69a0e8e90ac / wesmere/js/ (retina.js retina.min.js): home: Retina image selection needs to take into account /-prefixed paths https://github.com/wesnoth/wesmere/commit/c69a0e8e90acb3f62a4f0c1e943c13ff6c708e1b
20170727 04:08:46< vultraz_iOS> celticminstrel: i did
20170727 04:13:12< vultraz_iOS> celticminstrel: they were commits that weren't really a_r exclusive
20170727 04:14:04< celticminstrel> We should have a discussion sometime about markup syntax.
20170727 04:14:13< celticminstrel> Something that works for both Help and normal text.
20170727 04:14:33< vultraz_iOS> why can pango not be used for help
20170727 04:14:40-!- travis-ci [~travis-ci@ec2-54-196-59-18.compute-1.amazonaws.com] has joined #wesnoth-dev
20170727 04:14:41< travis-ci> wesnoth/wesnoth#14560 (master - ac063ce : Celtic Minstrel): The build failed.
20170727 04:14:41< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/257983126
20170727 04:14:41-!- travis-ci [~travis-ci@ec2-54-196-59-18.compute-1.amazonaws.com] has left #wesnoth-dev []
20170727 04:14:44< celticminstrel> Well, it could be, but it's also insufficient for help.
20170727 04:14:52< vultraz_iOS> why?
20170727 04:15:04< celticminstrel> Because it doesn't support tab stops, arbitrary links, or inline images.
20170727 04:15:27< vultraz_iOS> images are rather out of scope of text formatting
20170727 04:15:35< celticminstrel> Not in help they're not.
20170727 04:15:45< vultraz_iOS> .....................................................
20170727 04:16:01< celticminstrel> So ideally what you need is to have "general markup syntax" and then "help markup syntax" which is a superset of the former.
20170727 04:16:04< JyrkiVesterinen> celticminstrel: Indeed, : is not Shift+; on all keyboards. On a Finnish keyboard it's Shift+.
20170727 04:16:05< vultraz_iOS> The implication here is we should separate them.
20170727 04:16:22< celticminstrel> You can't separate them and still allow inline images.
20170727 04:16:30< celticminstrel> You can separate them if you only want floating images.
20170727 04:16:37< celticminstrel> But IIRC the help uses both.
20170727 04:16:43< celticminstrel> And there's really no reason for it not to.
20170727 04:16:54-!- travis-ci [~travis-ci@ec2-54-204-122-90.compute-1.amazonaws.com] has joined #wesnoth-dev
20170727 04:16:55< travis-ci> wesnoth/wesnoth#14559 (master - 382c469 : Celtic Minstrel): The build has errored.
20170727 04:16:55< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/257980205
20170727 04:16:55-!- travis-ci [~travis-ci@ec2-54-204-122-90.compute-1.amazonaws.com] has left #wesnoth-dev []
20170727 04:17:52< vultraz_iOS> what??
20170727 04:18:06< celticminstrel> What are you so confused about?
20170727 04:18:21< celticminstrel> Help pages need inline and floating images AFAIK.
20170727 04:18:31< celticminstrel> Nothing complicated about this.
20170727 04:18:44< celticminstrel> ISTR that pango even has facilities to allow text to wrap around an image.
20170727 04:19:05< celticminstrel> Implying we can do it with the libraries we're using.
20170727 04:19:08< vultraz_iOS> why can't you separate them and still have inline images
20170727 04:19:15< celticminstrel> Because inline images are mixed into the text.
20170727 04:19:27< vultraz_iOS> of course they are >_<
20170727 04:19:37< celticminstrel> So they need to be laid out as part of the text.
20170727 04:20:02< celticminstrel> So of course you want the markup for them to be part of the text, right?
20170727 04:20:07< vultraz_iOS> i guess
20170727 04:20:15< vultraz_iOS> but forget it for now
20170727 04:20:19< celticminstrel> I mean, you could use some reference system if you wanted, but that would only change the syntax, not the implementation.
20170727 04:20:26< vultraz_iOS> we are not doing the help browser before 1.14
20170727 04:20:36< celticminstrel> I was planning to, but gave up, so yeah.
20170727 04:21:06< vultraz_iOS> and for 1.15 we're going to significantly redesign it
20170727 04:21:29< celticminstrel> Yeah, uh... pretty sure a "significant redesign" isn't going to change anything I said.
20170727 04:22:23< celticminstrel> Redesigning it doesn't change the requirements.
20170727 04:22:32< vultraz_iOS> We shall see
20170727 04:22:40< celticminstrel> It's help. It needs images.
20170727 04:22:44< vultraz_iOS> Can you stop being so pessimistic for once?
20170727 04:22:49< celticminstrel> It probably needs inline images. It definitely needs floating images.
20170727 04:22:53< celticminstrel> ......
20170727 04:22:56< celticminstrel> Pessimistic?
20170727 04:23:11< celticminstrel> I'm not being pessimistic. What the heck are you talking about.
20170727 04:23:30< vultraz_iOS> you're assuming everything will be as difficult as possible
20170727 04:23:49< celticminstrel> I haven't really made any statements about difficulty, have I?
20170727 04:24:24< celticminstrel> I've said "this is what help needs" and also "I'm pretty sure this is possible with pango", so if anything shouldn't you be calling it optimistic?
20170727 04:24:54< vultraz_iOS> It's not feeling pessamistic 
20170727 04:24:56< vultraz_iOS> er
20170727 04:24:58< vultraz_iOS> optamictc
20170727 04:25:00< vultraz_iOS> opatimsic
20170727 04:25:02< vultraz_iOS> FUCKING
20170727 04:25:03< vultraz_iOS> pkpofjep
20170727 04:25:07< celticminstrel> As for difficulty, I wouldn't expect it to be easy, but nor would I expect it to be prohibitively hard. However, I'm not commenting on difficulty because I don't really know enough about Pango.
20170727 04:25:07< shadowm> vultraz.
20170727 04:25:10< vultraz_iOS> OPTIMISTIC  
20170727 04:25:20< shadowm> celtic is saying that if you want to have a help system, you need to have inline images.
20170727 04:25:22< vultraz_iOS> i can't typo
20170727 04:25:33< shadowm> That's not being pessimistic, that's just pointing out a fact.
20170727 04:25:36< celticminstrel> ^
20170727 04:25:51< vultraz_iOS> alright, apologies
20170727 04:26:03< celticminstrel> Anyway, I really need to get to bed.
20170727 04:26:06< vultraz_iOS> but really, a redesign might not have inline images
20170727 04:26:08< vultraz_iOS> I don't know
20170727 04:26:11< celticminstrel> I doubt it.
20170727 04:26:15< vultraz_iOS> because I haven't drafted it
20170727 04:26:19< vultraz_iOS> and plus,you want to get rid of pango
20170727 04:26:24< vultraz_iOS> why would you advocate more pango
20170727 04:26:28< celticminstrel> But even if it doesn't have inline images, it would still have floating ones, right?
20170727 04:26:31< shadowm> I can't see how you'd avoid having inline images without hardcoding every single page in the GUI2 config.
20170727 04:26:49< celticminstrel> Well, I don't like Pango, but it's what we're using, so I'm commenting on its ability to do what we need.
20170727 04:27:11< celticminstrel> If we can replace Pango with something of equivalent power, great! I'm not expecting this to happen, though.
20170727 04:27:27< JyrkiVesterinen> Get rid of Pango? Pango is very useful for all kinds of text layout stuff, including RTL text and, well, floating images.
20170727 04:27:38< celticminstrel> "wanting to get rid of pango" and "advocating getting rid of pango" are not the same in any case.
20170727 04:28:34< celticminstrel> My objections to Pango are mainly ... I guess stylistic and also the huge dependency chain it brings in that nothing else uses.
20170727 04:29:16< celticminstrel> These aren't things I could point to as arguments for its removal, unless there's an equivalent alternate library available, and even then it'd probably need more than just that.
20170727 04:29:35< JyrkiVesterinen> Fair enough. (But I'm still strongly in favor of keeping Pango.)
20170727 04:29:40< celticminstrel> (Okay, pango+cairo+harfbuzz all use it, but they're pretty much one unit anyway.)
20170727 04:30:17< celticminstrel> Well, I'm not advocating for its removal.
20170727 04:31:52< celticminstrel> Anyway, good night.
20170727 04:32:03-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20170727 04:32:34-!- travis-ci [~travis-ci@ec2-54-204-122-90.compute-1.amazonaws.com] has joined #wesnoth-dev
20170727 04:32:35< travis-ci> wesnoth/wesnoth#14561 (fix_1855 - ac063ce : Celtic Minstrel): The build failed.
20170727 04:32:35< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/257983839
20170727 04:32:35-!- travis-ci [~travis-ci@ec2-54-204-122-90.compute-1.amazonaws.com] has left #wesnoth-dev []
20170727 04:38:44-!- Bonobo [~Bonobo@129.127.113.188] has joined #wesnoth-dev
20170727 04:39:48-!- travis-ci [~travis-ci@ec2-184-72-184-96.compute-1.amazonaws.com] has joined #wesnoth-dev
20170727 04:39:49< travis-ci> wesnoth/wesnoth#14562 (fix_1855 - 6ad3786 : Celtic Minstrel): The build failed.
20170727 04:39:49< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/257986000
20170727 04:39:49-!- travis-ci [~travis-ci@ec2-184-72-184-96.compute-1.amazonaws.com] has left #wesnoth-dev []
20170727 05:08:42-!- Kwandulin [~Kwandulin@p200300760F5F2D15BC28FCFF07A9F187.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170727 05:13:13-!- Bonobo [~Bonobo@129.127.113.188] has quit [Ping timeout: 276 seconds]
20170727 05:30:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170727 05:35:19-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 276 seconds]
20170727 05:43:00-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170727 06:01:56-!- horrowind [~Thunderbi@p2003008E6C0B261F964452FFFE0220ED.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170727 06:27:48-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20170727 06:53:49-!- Bonobo [~Bonobo@202.168.58.116] has joined #wesnoth-dev
20170727 06:59:18-!- horrowind [~Thunderbi@p2003008E6C0B261F964452FFFE0220ED.dip0.t-ipconnect.de] has quit [Quit: horrowind]
20170727 07:03:54-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170727 07:10:26-!- irker875 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170727 07:18:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170727 07:20:03-!- clavi [~clavi@v22017034422546657.goodsrv.de] has quit [Quit: ZNC - http://znc.in]
20170727 07:22:56-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 255 seconds]
20170727 07:24:58-!- clavi [~clavi@v22017034422546657.goodsrv.de] has joined #wesnoth-dev
20170727 07:58:19-!- Kwandulin [~Kwandulin@p200300760F5F2D15BC28FCFF07A9F187.dip0.t-ipconnect.de] has quit [Ping timeout: 276 seconds]
20170727 08:17:12-!- mjs-de [~mjs-de@x4db69947.dyn.telefonica.de] has joined #wesnoth-dev
20170727 08:23:30-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170727 08:41:55-!- Kwandulin [~Kwandulin@p200300760F5F2D15BC28FCFF07A9F187.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170727 09:06:56-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170727 09:11:28-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 255 seconds]
20170727 09:12:58-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170727 09:16:21-!- Duthlet [~Duthlet@dslb-188-101-088-243.188.101.pools.vodafone-ip.de] has joined #wesnoth-dev
20170727 09:23:00-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170727 09:23:06-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170727 10:42:04-!- Coffee_irc [~david@202.168.58.116] has quit [Quit: Konversation terminated!]
20170727 10:55:13-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170727 10:59:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170727 11:47:13-!- Kwandulin [~Kwandulin@p200300760F5F2D15BC28FCFF07A9F187.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170727 11:58:15-!- mjs-de [~mjs-de@x4db69947.dyn.telefonica.de] has quit [Remote host closed the connection]
20170727 12:13:43-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 255 seconds]
20170727 12:18:30-!- midzer [~quassel@2001:41d0:a:2255::1] has quit [Ping timeout: 240 seconds]
20170727 12:22:27-!- midzer [~quassel@ks3360651.kimsufi.com] has joined #wesnoth-dev
20170727 12:27:19-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170727 12:39:26-!- sevu [~Shiki@p57803acb.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170727 12:40:26-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20170727 12:40:52< celticminstrel> ...oh yeah, there was one other thing that would be nice to get into 1.13.9.
20170727 12:41:00< celticminstrel> A means of deprecating preprocessor macros.
20170727 12:42:54-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170727 12:47:01-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Quit: I'll be back!]
20170727 12:47:05-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170727 12:55:31-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev
20170727 13:01:17-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20170727 13:29:03-!- gfgtdf [~chatzilla@x4e32b09a.dyn.telefonica.de] has joined #wesnoth-dev
20170727 13:32:25< gfgtdf> vultraz_iOS: what was teh exact reason why you changed gety()  getx()  to use window->get_size() instead of frameBuffer->  ?
20170727 13:33:03< vultraz_iOS> On a_r we don't have a framebuffer
20170727 13:33:06< vultraz_iOS> Anymore
20170727 13:33:25< vultraz_iOS> The change celmin committed was on a_r originally
20170727 13:33:33< vultraz_iOS> Is there a problem?
20170727 13:35:15< gfgtdf> vultraz_iOS: probably, i think the if(!window)  { return 0; } lines coudl be the reason why th test fail, since afaik the tests haev no windows but a framebuffer  for testiung.
20170727 13:35:40< vultraz_iOS> Well that's stupid
20170727 13:37:32< vultraz_iOS> The tests shouldn't even need a damn framebuffer
20170727 13:37:37< vultraz_iOS> Nor should the size matter
20170727 13:38:31< gfgtdf> vultraz_iOS: its probably the gui2 tests the test exactly whetehr the dialogs work for certain resolutions
20170727 13:39:06< JyrkiVesterinen> One thing to not is that the tests segfault even before the executable starts running the test cases.
20170727 13:39:27< JyrkiVesterinen> I noticed that the "running 154 test cases..." line wasn't printed to the console.
20170727 13:39:38< JyrkiVesterinen> s/not/note
20170727 13:40:00< gfgtdf> JyrkiVesterinen: yes it faild  during loadingscreen, mostlikeley becasue the loadingscreen doesn't fit on the window.
20170727 13:41:46< vultraz_iOS> Ftr the tests have failed since jyrki committed the fps counter changes
20170727 13:41:55< vultraz_iOS> That was before the backport
20170727 13:42:19< JyrkiVesterinen> As I have commented before, my FPS counter changes caused the test erxecutable to divide by zero. Not segfault.
20170727 13:42:19< gfgtdf> vultraz_iOS: yes but JyrkiVesterinen aid he fixed that one.
20170727 13:43:13-!- Kwandulin [~Kwandulin@p200300760F5F2D15BC28FCFF07A9F187.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170727 13:43:36< vultraz_iOS> I see
20170727 13:47:22-!- Bonobo [~Bonobo@202.168.58.116] has quit [Ping timeout: 258 seconds]
20170727 13:54:49-!- irker875 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170727 13:54:49< irker875> wesnoth: gfgtdf wesnoth:master 59947ae969f6 / src/pathfind/pathfind.cpp: fix units with high mp beeing able to step over unreachable https://github.com/wesnoth/wesnoth/commit/59947ae969f64157ab5d559ea8f3b96822c685c4
20170727 14:11:42< Ravana_> gfgtdf: does https://github.com/wesnoth/wesnoth/commit/59947ae969f64157ab5d559ea8f3b96822c685c4 support movetypes that are allowed to move on impassable?
20170727 14:12:31-!- Kwandulin2 [~Kwandulin@p200300760F5F2D156D0CD45C716420B7.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170727 14:15:35-!- Kwandulin [~Kwandulin@p200300760F5F2D15BC28FCFF07A9F187.dip0.t-ipconnect.de] has quit [Ping timeout: 246 seconds]
20170727 14:22:22< gfgtdf> Ravana_: no this just fixes the case where a uit has for example mountain ={UNREACHABLE} (=99) and you thne use debug :unit moves=300 it can step on mountains.
20170727 14:23:07< gfgtdf> Ravana_: that said i wonder whther we shoudl increase the value of UNREACHABLE
20170727 14:29:19-!- travis-ci [~travis-ci@ec2-54-204-122-90.compute-1.amazonaws.com] has joined #wesnoth-dev
20170727 14:29:20< travis-ci> wesnoth/wesnoth#14564 (master - 59947ae : gfgtdf): The build is still failing.
20170727 14:29:20< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/258154437
20170727 14:29:20-!- travis-ci [~travis-ci@ec2-54-204-122-90.compute-1.amazonaws.com] has left #wesnoth-dev []
20170727 14:31:34< Ravana_> so it should be done with unit movements_costs[0].impassable=1 ?
20170727 14:34:45-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20170727 14:37:52< gfgtdf> Ravana_: this commitis not related toa  specific terrain. It jsu menas that unit cannot step on hexes with movecosts >99 even if they have >99 moves left.
20170727 14:57:59-!- mjs-de [~mjs-de@x4db69947.dyn.telefonica.de] has joined #wesnoth-dev
20170727 15:06:16-!- horrowind [~Thunderbi@p2003008E6C0B261F964452FFFE0220ED.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170727 15:27:44-!- horrowind [~Thunderbi@p2003008E6C0B261F964452FFFE0220ED.dip0.t-ipconnect.de] has quit [Quit: horrowind]
20170727 15:31:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170727 15:42:38-!- gfgtdf_ [~chatzilla@x4e32b09a.dyn.telefonica.de] has joined #wesnoth-dev
20170727 15:46:22-!- gfgtdf [~chatzilla@x4e32b09a.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170727 15:46:33-!- gfgtdf_ is now known as gfgtdf
20170727 15:50:25-!- Kwandulin [~Kwandulin@p200300760F5F2D026D0CD45C716420B7.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170727 15:51:30-!- Kwandulin2 [~Kwandulin@p200300760F5F2D156D0CD45C716420B7.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20170727 15:58:01-!- iwaim [~iwaim@2001:2c0:40e:2002:0:4:14:80] has quit [Ping timeout: 246 seconds]
20170727 16:08:06-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170727 16:20:08-!- iwaim [~iwaim@rasteenie.alib.jp] has joined #wesnoth-dev
20170727 16:23:52-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170727 16:23:52< Appveyor> The Battle for Wesnoth (Visual Studio 2017) - Release gfgtdf 59947ae: fix units with high mp beeing able to step over unreachable Failed
20170727 16:23:52< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-106
20170727 16:23:56-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170727 16:31:52-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170727 16:32:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170727 16:32:47< gfgtdf> celmin: this https://github.com/wesnoth/wesnoth/commit/ac063ce8e76c1c0257f4a0fd7efdca49d331bf21#diff-75667a8e08274c09b228a14a38be79e0R68 <- doesn't work since event is const
20170727 16:33:54-!- JyrkiVesterinen [~jyrki@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170727 16:35:28-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170727 16:35:36-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170727 16:36:29-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170727 16:36:29< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release gfgtdf 59947ae: fix units with high mp beeing able to step over unreachable Failed
20170727 16:36:29< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-413
20170727 16:36:34-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170727 16:45:35-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170727 16:45:35< Appveyor> The Battle for Wesnoth (Visual Studio 2017) - Debug gfgtdf 59947ae: fix units with high mp beeing able to step over unreachable Failed
20170727 16:45:35< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-106
20170727 16:45:39-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170727 16:54:05-!- gfgtdf [~chatzilla@x4e32b09a.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170727 16:55:31-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170727 16:55:31< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug gfgtdf 59947ae: fix units with high mp beeing able to step over unreachable Failed
20170727 16:55:31< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-413
20170727 16:55:35-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170727 16:55:54-!- irker875 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170727 17:00:25-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170727 17:00:48-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170727 17:08:50-!- gfgtdf [~chatzilla@x4e32b09a.dyn.telefonica.de] has joined #wesnoth-dev
20170727 17:10:05-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170727 17:10:05< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release gfgtdf 59947ae: fix units with high mp beeing able to step over unreachable Failed
20170727 17:10:05< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-411
20170727 17:10:10-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170727 17:13:27-!- sevu [~Shiki@p57803acb.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20170727 17:16:06< JyrkiVesterinen> I got a backtrace of the unit test segfault.
20170727 17:16:08< JyrkiVesterinen> https://gist.github.com/jyrkive/30ec41535b1bcd199a381073d9ace062
20170727 17:18:28-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 240 seconds]
20170727 17:20:25-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170727 17:20:25< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug gfgtdf 59947ae: fix units with high mp beeing able to step over unreachable Failed
20170727 17:20:25< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-411
20170727 17:20:29-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170727 17:22:11< gfgtdf> JyrkiVesterinen: ye this is more or less the same as matthiaskrs stacktrace, did yu see my discusstion with vultraz eariler?
20170727 17:23:09-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170727 17:23:23< gfgtdf> JyrkiVesterinen: oh right you were there
20170727 17:23:48-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170727 17:24:50< gfgtdf> vultraz_iOS: any opinion on  partly reverting that commit (getx, gety) to try to fix the tests?
20170727 17:25:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170727 17:25:34-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170727 17:29:28-!- gfgtdf [~chatzilla@x4e32b09a.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20170727 17:30:35-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170727 17:31:15-!- gfgtdf [~chatzilla@x4e369b81.dyn.telefonica.de] has joined #wesnoth-dev
20170727 17:31:50-!- Kwandulin [~Kwandulin@p200300760F5F2D026D0CD45C716420B7.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170727 17:32:06-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170727 17:33:07< JyrkiVesterinen> I see one possible problem here. file_number_map ( https://github.com/wesnoth/wesnoth/blob/59947ae969f64157ab5d559ea8f3b96822c685c4/src/serialization/preprocessor.cpp#L46-L47 ) is accessed from multiple threads without synchronization.
20170727 17:33:13< JyrkiVesterinen> There is a race condition.
20170727 17:33:43-!- irker065 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170727 17:33:43< irker065> wesnoth: gfgtdf wesnoth:master 4dda789e8e80 / src/video.cpp: attempt to fix boost tests https://github.com/wesnoth/wesnoth/commit/4dda789e8e80d4768df629b58f2ed7e6e1ce2a18
20170727 17:34:11< gfgtdf> JyrkiVesterinen: why shoduol there be multiple thread accessing that ?
20170727 17:35:07< JyrkiVesterinen> There not only "should be", there *is*. I checked in the debugger: both thread 1 and thread 3 call get_file_code() that accesses the map.
20170727 17:35:27< gfgtdf> JyrkiVesterinen: yes but the actual bug is that they are both accesing that
20170727 17:35:56< gfgtdf> hmmjust noticed that my commit aboev won't work unless the compilation error in controller_base.cpp is solved.
20170727 17:36:11< JyrkiVesterinen> The threaded loading screen does some of the calls.
20170727 17:36:29< JyrkiVesterinen> I didn't capture the backtrace, but I can get it for you if you want.
20170727 17:37:34< gfgtdf> JyrkiVesterinen: no whgat probably happens is that 1) the loadingscreen fails to display, 2) the loaignscreen exits with an erros 3) the loading-thread gets detached and causes all types of erros, even if you woudl make file_number_map thread save it'D probably fail at some other point
20170727 17:38:30< gfgtdf> JyrkiVesterinen: this speicif case 'shoudl' be fised by tis code: https://github.com/wesnoth/wesnoth/blob/1.13.8/src/gui/dialogs/loading_screen.cpp#L208
20170727 17:38:56< JyrkiVesterinen> In any case, what I saw in my debugging run earlier was that a string stored in that map was corrupted, causing the segfault.
20170727 17:39:02< gfgtdf> which shodul baically exit wesnoth without calling any dtors. but somehow it doesn'T seem to work for the boost tests
20170727 17:39:18< JyrkiVesterinen> And a possible reason for that corruption is that thread 1 was in the process of editing the map.
20170727 17:40:44< JyrkiVesterinen> std::exit() does call destructors. You need std::abort() ( http://en.cppreference.com/w/cpp/utility/program/abort ) to skip them.
20170727 17:40:59-!- gfgtdf_ [~chatzilla@x4e369b81.dyn.telefonica.de] has joined #wesnoth-dev
20170727 17:42:06-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170727 17:43:32< irker065> wesnoth: gfgtdf wesnoth:master 1810b6ae2c4d / src/controller_base.cpp: fixup travis tests https://github.com/wesnoth/wesnoth/commit/1810b6ae2c4d9f8a583a910e8c3938da354172c1
20170727 17:43:37-!- gfgtdf [~chatzilla@x4e369b81.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170727 17:43:40-!- gfgtdf_ is now known as gfgtdf
20170727 17:44:25< gfgtdf> celmin: shodul shodul look at that and fif it properly ^ all i did was removign a line tht didn't compile
20170727 17:45:33< gfgtdf> JyrkiVesterinen: my internet connection sucks right now, did you say somthing after me ?
20170727 17:45:56< JyrkiVesterinen> ‎[20:39:18] ‎<‎JyrkiVesterinen‎>‎ And a possible reason for that corruption is that thread 1 was in the process of editing the map.
20170727 17:45:58< JyrkiVesterinen> ‎[20:40:44] ‎<‎JyrkiVesterinen‎>‎ std::exit() does call destructors. You need std::abort() ( http://en.cppreference.com/w/cpp/utility/program/abort ) to skip them.
20170727 17:48:06< gfgtdf> hmm will probably change it to abort then. Still that won't dfi the tests it will jsut make them fail without an erromessage.
20170727 17:50:15< JyrkiVesterinen> I did some more research. Std::quick_exit() is another way to exit the program without calling destructors.
20170727 17:50:17< JyrkiVesterinen> http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2007/n2440.htm
20170727 17:51:40< gfgtdf> JyrkiVesterinen: oh right ist seem to be made specifically for cases liek this
20170727 17:52:25< gfgtdf> let' first wait to my commit above
20170727 17:53:46< JyrkiVesterinen> No need. We already know that it doesn't compile.
20170727 17:53:47< JyrkiVesterinen> https://gist.github.com/jyrkive/177ee0fe08a4110f9ad08fb6bcb8a6ba
20170727 17:53:51< JyrkiVesterinen> GCC 6.4.0 here.
20170727 17:54:18-!- Kwandulin [~Kwandulin@p200300760F5F2D02E030852C3C985BE6.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170727 17:55:39< JyrkiVesterinen> Faulty commit: https://github.com/wesnoth/wesnoth/commit/ce74fe433097d250a738638b2cbe3ca878d59783
20170727 17:55:41< JyrkiVesterinen> I'll fix it.
20170727 17:56:38-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170727 17:58:38-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170727 17:58:59-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170727 18:01:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170727 18:02:22< gfgtdf> JyrkiVesterinen: ok
20170727 18:07:05< zookeeper> gfgtdf, of course we could bump UNREACHABLE from 99 to 999 if you are sure it wouldn't cause any problems, but... is there any need? has anyone ever needed to make a unit with >98 MP?
20170727 18:08:07-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170727 18:09:54< irker065> wesnoth: Jyrki Vesterinen wesnoth:master 5a297ed1d66d / src/scripting/lua_audio.cpp: Fix build with -Werror=address https://github.com/wesnoth/wesnoth/commit/5a297ed1d66dd8aa4186802df3fb34b9064cfca6
20170727 18:11:15-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170727 18:11:24< JyrkiVesterinen> Unit tests pass now. :) Thanks gfgtdf.
20170727 18:11:52-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170727 18:16:19< gfgtdf> JyrkiVesterinen: goot to know thx
20170727 18:17:23< gfgtdf> JyrkiVesterinen: isn't now track == nullptr and  !track->valid() exactly the same ?
20170727 18:17:59< gfgtdf> good*
20170727 18:18:14< JyrkiVesterinen> get_track() may return a null pointer.
20170727 18:18:47< JyrkiVesterinen> Attempting to call functions with a null pointer is undefined behavior, so it isn't safe to call track->valid() if track == nullptr.
20170727 18:18:49< gfgtdf> JyrkiVesterinen: right i was somehow confised by the diff
20170727 18:20:32< irker065> wesnoth: gfgtdf wesnoth:master e7488f6f7322 / src/gui/dialogs/loading_screen.cpp: use std::quick_exit in loading screen https://github.com/wesnoth/wesnoth/commit/e7488f6f73228ea5c8a617196bf15768ec739649
20170727 18:46:18-!- JyrkiVesterinen [~jyrki@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170727 18:49:45-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170727 19:07:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170727 19:19:09-!- travis-ci [~travis-ci@ec2-54-204-122-90.compute-1.amazonaws.com] has joined #wesnoth-dev
20170727 19:19:10< travis-ci> wesnoth/wesnoth#14566 (master - 1810b6a : gfgtdf): The build was fixed.
20170727 19:19:10< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/258242121
20170727 19:19:10-!- travis-ci [~travis-ci@ec2-54-204-122-90.compute-1.amazonaws.com] has left #wesnoth-dev []
20170727 19:25:27-!- mjs-de [~mjs-de@x4db69947.dyn.telefonica.de] has quit [Remote host closed the connection]
20170727 19:45:34-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170727 19:53:05-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds]
20170727 20:04:55-!- travis-ci [~travis-ci@ec2-54-81-180-164.compute-1.amazonaws.com] has joined #wesnoth-dev
20170727 20:04:56< travis-ci> wesnoth/wesnoth#14567 (master - 5a297ed : Jyrki Vesterinen): The build passed.
20170727 20:04:56< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/258250890
20170727 20:04:56-!- travis-ci [~travis-ci@ec2-54-81-180-164.compute-1.amazonaws.com] has left #wesnoth-dev []
20170727 20:08:15< gfgtdf> any opinion on makin require_campaign=yes the default in [campaign] ?
20170727 20:08:21< gfgtdf> making
20170727 20:09:12< gfgtdf> i have seen quite some campaigns that simply don't use they keys and give erros when you try to join them , also i wouldn't really break anything
20170727 20:10:06< gfgtdf> oh well i misread the wiki, yes is already the default
20170727 20:12:18< gfgtdf> hmm then why are so many people doing this wrong i wonder
20170727 20:15:03-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170727 20:20:47< DeFender1031> because the rules for when it's required and when it's not are tricky, arbitrary, and, were the game programmed properly, completely unnecessary?
20170727 20:20:51< zookeeper> gfgtdf, there's only one match for "require_campaign" in both 1.12 and 1.13 add-ons, The_Haunted_Woods (1.12)
20170727 20:21:11< gfgtdf> hmm that's strange
20170727 20:22:25< gfgtdf> maybe there coudl be a bug in there?
20170727 20:22:41< zookeeper> for sure
20170727 20:22:46-!- Kwandulin [~Kwandulin@p200300760F5F2D02E030852C3C985BE6.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170727 20:22:59< gfgtdf> do you have a little time to test it with me ?
20170727 20:23:16< zookeeper> maybe!
20170727 20:23:29< zookeeper> if it doesn't entail anything terribly laborious
20170727 20:23:45< gfgtdf> it mean loggin into the mp server and checking whether you can enter my games
20170727 20:24:14< gfgtdf> is 1.13.8 mp server ok for you ?
20170727 20:24:52< zookeeper> sure
20170727 20:27:03< gfgtdf> zookeeper: do you ahve "Return_from_Captivity" or "Dragon_Lair" installed ?
20170727 20:27:16< zookeeper> nope
20170727 20:28:10< gfgtdf> zookeeper: can you jopin the game that i opened ?
20170727 20:29:01< zookeeper> what the heck, why were you listed 4 times in the player list in the game lobby?
20170727 20:29:04< gfgtdf> zookeeper: did you get an erro when i started it ?
20170727 20:29:20< gfgtdf> zookeeper: no idea why i was listed 4 times
20170727 20:29:22< zookeeper> i don't think so
20170727 20:29:57< zookeeper> the first time i joined, it asked me to install the add-on, so i did, and the next time i checked, i was back in the lobby. then i clicked join again, and then it joined all right. except you were listed 4 times.
20170727 20:29:59< gfgtdf> zookeeper: so you see themap with the prisions ?
20170727 20:30:07< gfgtdf> zookeeper: ahh right this is 1.13
20170727 20:30:21< gfgtdf> zookeeper: well that works as expected then
20170727 20:30:51< gfgtdf> zookeeper: hmm
20170727 20:31:08< gfgtdf> zookeeper: let ym try womthign else
20170727 20:32:23-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20170727 20:33:02< gfgtdf> zookeeper: can you join that game, and if yes does it ask you to download the addon ?
20170727 20:33:33< zookeeper> it asked, yes
20170727 20:33:46< zookeeper> and same thing again, i just end up back in the lobby after the downloading and loading screens are done
20170727 20:34:06< zookeeper> clicking the join button does nothing if i don't have the game selected
20170727 20:34:27< zookeeper> now you're listed 5 times... progress!
20170727 20:34:34< gfgtdf> zookeeper: hmm well so it seems liek that specific bug was only on 1.12, but other bugs were noticed
20170727 20:34:50< gfgtdf> zookeeper: so you now downloaded both addons ?
20170727 20:35:29< zookeeper> it asked me to download something, twice
20170727 20:35:37< gfgtdf> ok
20170727 20:35:44< zookeeper> ...now suddenly _i_ am listed twice
20170727 20:35:56< zookeeper> oh wait
20170727 20:36:05< zookeeper> that's because you changed controlled of side 2, so i replaced one of your instances
20170727 20:36:48< zookeeper> so what do you see in the player list?
20170727 20:36:49< gfgtdf> zookeeper: now you see yourself 3 times ?
20170727 20:36:54< zookeeper> yes
20170727 20:36:58< gfgtdf> only you and me, once each
20170727 20:37:10< zookeeper> huh.
20170727 20:37:20< zookeeper> for me it's now me thrice followed by you thrice
20170727 20:37:43< zookeeper> and the first 3 reflect the controllers of the first 3 sides
20170727 20:37:48< gfgtdf> yes sounds like a bug.
20170727 20:37:53< zookeeper> change some controllers to ai or empty? :P
20170727 20:37:57-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20170727 20:38:22< gfgtdf> accdently pressed escape
20170727 20:38:41< zookeeper> when you set side 3 to vacant, the third item in the player list became empty
20170727 20:38:49< zookeeper> it was a pretty thin empty item
20170727 20:40:25< gfgtdf> zookeeper: yes i also see it now with my second client
20170727 20:41:15< gfgtdf> vultraz_iOS: do you know somethign about this ^
20170727 20:43:29-!- travis-ci [~travis-ci@ec2-54-81-180-164.compute-1.amazonaws.com] has joined #wesnoth-dev
20170727 20:43:30< travis-ci> wesnoth/wesnoth#14568 (master - e7488f6 : gfgtdf): The build failed.
20170727 20:43:30< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/258254929
20170727 20:43:30-!- travis-ci [~travis-ci@ec2-54-81-180-164.compute-1.amazonaws.com] has left #wesnoth-dev []
20170727 20:44:02< gfgtdf> zookeeper: ye the gui2 mp_waiting seems to literlly just ist all sides again: https://github.com/wesnoth/wesnoth/blob/1.13.8/src/gui/dialogs/multiplayer/mp_join_game.cpp#L430
20170727 20:44:07< gfgtdf> list*
20170727 20:44:38< zookeeper> ha
20170727 20:45:04< gfgtdf> this is obviosuly wrong, not onyl that user appear twice, it also doesn'T list observes or player haev have no side assigned yet
20170727 20:47:33< gfgtdf> zookeeper: ok i mae a bugreport: feel free to add additional information: https://github.com/wesnoth/wesnoth/issues/1867
20170727 20:48:45-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev
20170727 20:50:13< gfgtdf> ye for i'm done with mp testing for me unless you want to do further testing.
20170727 20:50:32< zookeeper> right, and so there were 6 names because there were 6 sides in the dragon lair scenario, even though only 3 were for human players
20170727 20:50:46< zookeeper> ...i guess because player_id for AI sides is the host's id, which was you
20170727 20:50:58< gfgtdf> zookeeper: right that makes sense
20170727 20:52:13< zookeeper> so yeah... that function is very very wrong :>
20170727 20:55:21< gfgtdf> well removing duplicates and ampty lines sould be trivial, not sure about observer though
20170727 20:57:19< zookeeper> well surely there's some kind of list of connected users that should be used instead of side data
20170727 21:00:01< gfgtdf> hmm there coudl be a total list of user and maybe the ahve soem current game attribute we can use to filter them
20170727 21:00:05< gfgtdf> not sure thzgh
20170727 21:07:24-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170727 21:12:24-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Ping timeout: 255 seconds]
20170727 21:13:25-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Read error: No route to host]
20170727 21:13:28-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170727 21:18:57-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds]
20170727 21:20:57-!- irker065 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170727 21:30:24-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170727 21:32:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170727 22:09:10-!- TadCarlucci [~lundberg@74.193.219.119] has joined #wesnoth-dev
20170727 22:09:23< TadCarlucci> src/controller_base.cpp: In member function ‘virtual void controller_base::handle_event(const SDL_Event&)’:
20170727 22:09:24< TadCarlucci> src/controller_base.cpp:67:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
20170727 22:09:24< TadCarlucci>    if(have_keyboard_focus()) {
20170727 22:09:24< TadCarlucci>    ^~
20170727 22:09:24< TadCarlucci> src/controller_base.cpp:74:2: note: here
20170727 22:09:25< TadCarlucci>   case SDL_KEYDOWN:
20170727 22:09:29< TadCarlucci>   ^~~~
20170727 22:10:29-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170727 22:11:21-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170727 22:14:49-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170727 22:17:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170727 22:17:37-!- Bonobo [~Bonobo@202.168.58.116] has joined #wesnoth-dev
20170727 22:18:44-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170727 22:18:57< vultraz_iOS> OH?
20170727 22:20:13 * TadCarlucci nods
20170727 22:20:46< TadCarlucci> Can't decide if it's intentional or a missing break statement. So punting to you.
20170727 22:21:52-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170727 22:22:06-!- TadCarlucci [~lundberg@74.193.219.119] has quit [Quit: Leaving]
20170727 22:27:55< gfgtdf> afaik celmin wrote that code and he has to look at it anyways since https://github.com/wesnoth/wesnoth/commit/1810b6ae2c4d9f8a583a910e8c3938da354172c1
20170727 22:28:09< vultraz_iOS> yeah celmin forgot the break
20170727 22:29:57-!- Bonobo [~Bonobo@202.168.58.116] has quit [Ping timeout: 240 seconds]
20170727 22:32:10-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170727 22:34:40-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Remote host closed the connection]
20170727 22:41:37-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Disconnected by services]
20170727 22:41:56-!- lobby_ [~wesnoth@wesnoth/bot/lobby] has joined #wesnoth-dev
20170727 22:41:56-!- Topic for #wesnoth-dev: 1.13.9 scheduled for sometime in August| Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Discord Server: https://discord.gg/tSmJS2E | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20170727 22:41:56-!- Topic set by vultraz_iOS [uid24821@wesnoth/developer/vultraz] [Sat Jul 22 21:46:13 2017]
20170727 22:41:56[Users #wesnoth-dev]
20170727 22:41:56[ aeth         ] [ crimson_penguin] [ esr          ] [ iwaim       ] [ nore     ] [ TC01       ] 
20170727 22:41:56[ AI0867       ] [ DDR            ] [ Gambit       ] [ janebot     ] [ nurupo   ] [ TC02       ] 
20170727 22:41:56[ AI0867_      ] [ deathisundead  ] [ gfgtdf       ] [ Jetrel_bot  ] [ oldlaptop] [ TheJJ      ] 
20170727 22:41:56[ aidanhs      ] [ DeFender       ] [ Greg-Boggs   ] [ lobby_      ] [ Polsaker ] [ timotei_   ] 
20170727 22:41:56[ Alkenrinnstet] [ DeFender1031   ] [ Greg_Boggs[m]] [ loonycyborg ] [ pydsigner] [ tomreyn    ] 
20170727 22:41:56[ APic         ] [ Duthlet        ] [ grzywacz     ] [ matthiaskrgr] [ Ravana__ ] [ vincent_c  ] 
20170727 22:41:56[ Appleman1234 ] [ elias          ] [ heirecka     ] [ mattsc      ] [ Rhonda   ] [ vultraz_iOS] 
20170727 22:41:56[ atarocch     ] [ EliDupree      ] [ higgins      ] [ midzer      ] [ shadowm  ] [ zookeeper  ] 
20170727 22:41:56[ ChipmunkV[m] ] [ Elsi           ] [ Ieuan        ] [ minzbonbon  ] [ Soliton  ] 
20170727 22:41:56[ clavi        ] [ Elvish_Hunter  ] [ Ivanovic     ] [ new_one     ] [ stikonas ] 
20170727 22:41:56-!- Irssi: #wesnoth-dev: Total of 58 nicks [0 ops, 0 halfops, 0 voices, 58 normal]
20170727 22:41:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170727 22:42:00-!- Channel #wesnoth-dev created Tue Jan 27 05:28:41 2009
20170727 22:42:02-!- Ravana__ is now known as Ravana_
20170727 22:42:06-!- Ravana_ [~Ravana@17-83-191-90.dyn.estpak.ee] has quit [Changing host]
20170727 22:42:06-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20170727 22:42:35-!- aeth_ [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20170727 22:42:40-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20170727 22:42:44-!- DeFender1031 [~DeFender1@217.132.16.231] has quit [Remote host closed the connection]
20170727 22:42:49-!- AI0867_ [~ai@wesnoth/developer/ai0867] has quit [Remote host closed the connection]
20170727 22:42:49-!- Irssi: Join to #wesnoth-dev was synced in 63 secs
20170727 22:42:52-!- shadowm [~ignacio@wesnoth/developer/shadowm] has quit [Remote host closed the connection]
20170727 22:42:53-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Disconnected by services]
20170727 22:43:00-!- aeth_ is now known as aeth
20170727 22:43:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170727 22:43:12-!- Ravana_ is now known as 3NAAA8DAC
20170727 22:43:22-!- 3NAAA8DAC is now known as Ravana_
20170727 22:43:39-!- shadowm [~ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20170727 22:50:37-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170727 22:51:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170727 22:57:55-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has quit [Ping timeout: 276 seconds]
20170727 23:07:43-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170727 23:17:37-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 246 seconds]
20170727 23:20:19-!- Greg-Boggs [~greg_bogg@c-73-37-6-51.hsd1.or.comcast.net] has joined #wesnoth-dev
20170727 23:35:52-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20170727 23:45:28< SigurdFD> gfgtdf: I'm getting a build error with the std:quick_exit commit
20170727 23:45:39< SigurdFD> src\gui\dialogs\loading_screen.cpp: In destructor 'virtual gui2::dialogs::loading_screen::~loading_screen()':
20170727 23:45:50< SigurdFD> src\gui\dialogs\loading_screen.cpp:208:3: error: 'quick_exit' is not a member of 'std'
20170727 23:45:56< SigurdFD> any ideas?
20170727 23:57:25-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
--- Log closed Fri Jul 28 00:00:56 2017