--- Log opened Sat Jul 29 00:00:28 2017
--- Day changed Sat Jul 29 2017
20170729 00:00:28-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170729 00:10:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170729 00:20:55-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20170729 00:24:50-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev
20170729 00:24:55-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Read error: Connection reset by peer]
20170729 00:35:03-!- irker791 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170729 00:35:03< irker791> wesnoth: Smok94 wesnoth:master e4552c7a758b / data/lua/wml-tags.lua: [store_unit_defense] tag https://github.com/wesnoth/wesnoth/commit/e4552c7a758b8cef7b794773df08762becdc904c
20170729 00:39:32-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev
20170729 00:40:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170729 01:23:38-!- travis-ci [~travis-ci@ec2-50-16-62-145.compute-1.amazonaws.com] has joined #wesnoth-dev
20170729 01:23:39< travis-ci> matthiaskrgr/wesnoth#1 (trusty_travis - 28c43cd : Matthias Krüger): The build passed.
20170729 01:23:39< travis-ci> Build details : https://travis-ci.org/matthiaskrgr/wesnoth/builds/258765147
20170729 01:23:39-!- travis-ci [~travis-ci@ec2-50-16-62-145.compute-1.amazonaws.com] has left #wesnoth-dev []
20170729 01:35:56-!- travis-ci [~travis-ci@ec2-50-16-62-145.compute-1.amazonaws.com] has joined #wesnoth-dev
20170729 01:35:57< travis-ci> wesnoth/wesnoth#14578 (master - e4552c7 : Smok94): The build passed.
20170729 01:35:57< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/258766859
20170729 01:35:57-!- travis-ci [~travis-ci@ec2-50-16-62-145.compute-1.amazonaws.com] has left #wesnoth-dev []
20170729 01:37:04-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dc67:74d9:26f3:57a8] has joined #wesnoth-dev
20170729 01:41:10-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dc67:74d9:26f3:57a8] has quit [Ping timeout: 240 seconds]
20170729 02:57:14-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20170729 03:00:51-!- horrowind [~Thunderbi@p2003008E6C0B2687964452FFFE0220ED.dip0.t-ipconnect.de] has quit [Quit: horrowind]
20170729 03:02:09< celticminstrel> ...oh yeah, ISTR a possible bug with << >> that we should probably fix...
20170729 03:02:23< celticminstrel> I'll see if I can reproduce it again...
20170729 03:10:59-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20170729 03:36:54-!- irker791 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170729 03:51:02< vultraz_iOS> celticminstrel: can you use pointers in an std::set?
20170729 03:51:07< vultraz_iOS> ie std::set<T*>
20170729 03:51:14< celticminstrel> Uh. Of course?
20170729 03:51:25< vultraz_iOS> how is comparison done?
20170729 03:51:25< celticminstrel> (Though maybe you want std::shared_ptr instead.)
20170729 03:51:40< celticminstrel> (Also you might want a custom comparator, otherwise they'll be sorted in the order they appear in memory.)
20170729 03:52:02< vultraz_iOS> alright
20170729 03:52:21< celticminstrel> Sorting them in address order would nullify some of the advantages of using a set at all.
20170729 03:52:54< celticminstrel> I assume you don't intend to add pointers to two distinct yet equal elements anyway.
20170729 03:53:04< vultraz_iOS> only reason to use a set here would be by-value removal
20170729 03:53:21< celticminstrel> Oh?
20170729 03:53:38< vultraz_iOS> pondering if i should uset a set for open_window_stack
20170729 03:53:44< celticminstrel> Oh.
20170729 03:54:13< celticminstrel> I don't see how that would make sense?
20170729 03:54:48< vultraz_iOS> so right now im beating my head over a fuckton of weird crashes here regarding the command console
20170729 03:54:53< celticminstrel> Currently it's a deque, because the most common operations are push_back and pop_back, so using a deque ensures these operations are always fast.
20170729 03:55:05< vultraz_iOS> no?
20170729 03:55:06< vultraz_iOS> it's a vector
20170729 03:55:21< celticminstrel> Really? Then it probably should be a deque (or std::stack which wraps a deque).
20170729 03:55:30< vultraz_iOS> anywya, i *might* have found some issue with the use of pop_back for modal dialogs
20170729 03:55:43< celticminstrel> (Or rather, wraps a deque by defaultm you can make it wrap a vector instead if you really want, but why would you.)
20170729 03:55:48< celticminstrel> ^default,
20170729 03:56:07< vultraz_iOS> what's the difference?
20170729 03:56:11< celticminstrel> push_back and pop_back are basically constant for std::deque.
20170729 03:56:25< celticminstrel> insert and removal are about O(log n) for std::set IIRC.
20170729 03:56:32< vultraz_iOS> between a stack and a deque
20170729 03:56:42< celticminstrel> For std::unordered_set I think it was O(n) for insert and delete.
20170729 03:57:26< celticminstrel> std::vector is generally constant O(1), but push_back is not guaranteed to be constant since it may need to copy the entire array to a new location if there's no space left in its current location.
20170729 03:57:49< celticminstrel> std::stack is a container adaptor class which by default wraps std::deque to give strict stack mechanics.
20170729 03:58:12< celticminstrel> So it inherents any complexity from the underlying container, ie std::deque.
20170729 03:58:41< celticminstrel> IOW, using std::stack is no different from std::deque in terms of efficiency, but it enforces correctness - ie, that you always only remove the last entry.
20170729 03:59:18< vultraz_iOS> but didn't we conclude that it's not guaranteed that the last open window was the last on the stack 
20170729 03:59:36< vultraz_iOS> that seems to potentially be the case here though ih ave no earthly idea why
20170729 03:59:40< celticminstrel> We did talk about that, but that was before Jyrki suggested that I don't place non-modal windows in the stack at all.
20170729 03:59:59< vultraz_iOS> I'm doing so
20170729 04:00:01< celticminstrel> If non-modal windows go in the stack, then yes, the order of opening may not be the exact reverse of the order of closing.
20170729 04:00:13< celticminstrel> Are you doing so? IIRC I changed it to not do so.
20170729 04:00:18< vultraz_iOS> you did not
20170729 04:00:27< vultraz_iOS> only not push tooltips
20170729 04:00:53< vultraz_iOS> ie, tooltips are not pushed to the stack
20170729 04:01:01< celticminstrel> Well, consider what the purpose of the stack is.
20170729 04:01:19< vultraz_iOS> I'm using it to implement smarter event filtering
20170729 04:01:26< celticminstrel> What was its original purpose again?
20170729 04:01:55< vultraz_iOS> stop floating label bleedthrough
20170729 04:02:05< vultraz_iOS> unnecessary on a_r
20170729 04:02:44< vultraz_iOS> anyway, it seems to fix some issues I'm having if i dont use pop_back for modals
20170729 04:03:07< vultraz_iOS> so i was considering a container that allows fast removal by value 
20170729 04:03:11< vultraz_iOS> just for syntax simplicity 
20170729 04:03:15< vultraz_iOS> what would you recommend
20170729 04:03:52< celticminstrel> Ah, you're right, it does include the modeless ATM.
20170729 04:03:59< celticminstrel> What's wrong with pop_back?
20170729 04:04:04< vultraz_iOS> i don't know
20170729 04:04:26< vultraz_iOS> somehow, it's causing weird-ass behavior when combined with various uses of the command console
20170729 04:04:28< vultraz_iOS> for example
20170729 04:04:44< vultraz_iOS> if modal uses pop back, and i enter an invalid command, i then can't reopen the console
20170729 04:04:50< celticminstrel> Oh good, I was about to ask for an example.
20170729 04:04:52< vultraz_iOS> because an if-is-modal check fails
20170729 04:04:57< vultraz_iOS> for some reason!
20170729 04:04:59< celticminstrel> Huh? Invalid command?
20170729 04:05:00< vultraz_iOS> i don't know why
20170729 04:05:13< vultraz_iOS> yes, an invalid command like "fwiojioejioej"
20170729 04:05:28< celticminstrel> Doesn't that just print an error to chat?
20170729 04:05:28< vultraz_iOS> i have no idea why a modal dialog would register here
20170729 04:05:31< vultraz_iOS> yes!
20170729 04:05:33< vultraz_iOS> exactly!
20170729 04:05:37< vultraz_iOS> so i have no idea!
20170729 04:05:44< celticminstrel> Okay, so..
20170729 04:06:03< vultraz_iOS> but if i use by-value removal from the stack it works..
20170729 04:06:18< vultraz_iOS> perhaps there's also some problem with using the last stack entry for my is_in_dialog tests...
20170729 04:06:30< vultraz_iOS> maybe i should test all of them
20170729 04:06:37< celticminstrel> Try (temporarily) commenting the bits that add and remove modeless windows.
20170729 04:07:06< celticminstrel> See if that fixes it in place of changing the pop_back.
20170729 04:07:06< vultraz_iOS> no need
20170729 04:07:09< vultraz_iOS> oh
20170729 04:07:18< vultraz_iOS> i can't do that, i need them in the stack
20170729 04:07:35< celticminstrel> You need the modeless dialogs in the stack?
20170729 04:07:40< vultraz_iOS> yes
20170729 04:07:47-!- deep-book-gk_ [~1wm_su@159.122.132.44] has joined #wesnoth-dev
20170729 04:08:05< vultraz_iOS> https://pastebin.com/vCdAL7Ju
20170729 04:08:06< celticminstrel> So my first suspicion here is that the modeless removal might be removing the wrong window.
20170729 04:08:18< celticminstrel> Though the code looks fine to me...
20170729 04:08:29< vultraz_iOS> i really don't know
20170729 04:08:45< vultraz_iOS> but not using pop_back in modal seems to fix my issues
20170729 04:08:54< vultraz_iOS> well, the crashes at least
20170729 04:09:01< vultraz_iOS> still haven't correctly filtered everything..
20170729 04:09:05< celticminstrel> That doesn't necessarily mean it's the right way to do it...
20170729 04:09:10-!- deep-book-gk_ [~1wm_su@159.122.132.44] has left #wesnoth-dev []
20170729 04:09:22< vultraz_iOS> well, isn't it safer anyway?
20170729 04:09:30< celticminstrel> Come to think of it, is that test even correct?
20170729 04:09:36< celticminstrel> True, it's safer, I guess.
20170729 04:10:21< vultraz_iOS> what im more broadly working on is refactoring the interaction between the UI and game handlers
20170729 04:10:27< celticminstrel> "We're in a dialog if a) the last window is modal or b) the distributor has a keyboard focus"
20170729 04:10:38< celticminstrel> What if we're in a modal dialog with a modeless dialog on top of it?
20170729 04:10:49< celticminstrel> The test would fail in that case.
20170729 04:11:00< vultraz_iOS> yeah that's why I think i need to do some more checks...
20170729 04:11:09< vultraz_iOS> validate ALL the stack members in some way
20170729 04:11:19< celticminstrel> (Admittedly that never happens ATM, though... unless your main game UI is a modal dialog, but in that case it shouldn't be considered in the dialog anyway...)
20170729 04:11:29< vultraz_iOS> it's modeless
20170729 04:12:10< celticminstrel> You can use a set, sure. I think the efficiency would decrease, but, well, for only a few entries in the list it probably wouldn't be noticeable.
20170729 04:12:18< vultraz_iOS> but anyway, you still haven't said which container you'd recommend for by-value removal from the stack
20170729 04:12:28< vultraz_iOS> oh
20170729 04:13:39< vultraz_iOS> any better one?
20170729 04:13:52< celticminstrel> pop_back is O(1); erase is IIRC O(log n), so if n is, say, 5, that gives 2.32
20170729 04:14:06< celticminstrel> If n is 20, you get 4.32.
20170729 04:14:53< vultraz_iOS> ms?
20170729 04:14:57< celticminstrel> No.
20170729 04:15:18< celticminstrel> The unit is unknown.
20170729 04:15:33< celticminstrel> But you can probably think of it as a multiple of the time it would be for the pop_back.
20170729 04:15:45< celticminstrel> Which should be pretty much instantaneous already.
20170729 04:16:27< celticminstrel> I guess in this case an std::set is better than std::unordered_set.
20170729 04:18:10< celticminstrel> unordered_set is actually constant on average, though...
20170729 04:18:38< celticminstrel> You'd need a custom hash and equality to take advantage of that, of course.
20170729 04:19:01< celticminstrel> Otherwise it would be better to think of it as linear, which is worse than std::set.
20170729 04:19:20< celticminstrel> The std::set would be logarithmic no matter what, even if you don't bother with a custom comparator.
20170729 04:30:41< celticminstrel> I suspect a good hash is not possible - you can't just use the address (because those are arbitrary and could be literally anything), and there isn't really any way I can think og to use the content of the window class to produce a unique hash.
20170729 04:32:14< celticminstrel> ^think og
20170729 04:32:17< celticminstrel> ^think of
20170729 04:33:12-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20170729 04:38:37-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20170729 04:43:38-!- Kwandulin [~Kwandulin@p200300760F5F2DE500B4A26A7AABADE5.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170729 05:04:11-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170729 05:30:24-!- mjs-de [~mjs-de@x4db689f5.dyn.telefonica.de] has joined #wesnoth-dev
20170729 06:31:41-!- Kwandulin [~Kwandulin@p200300760F5F2DE500B4A26A7AABADE5.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170729 06:33:03-!- Kwandulin [~Kwandulin@p200300760F5F2DE5A4C979CBBAD8B833.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170729 07:21:10-!- markus_ [~mjs-de@x55b64573.dyn.telefonica.de] has joined #wesnoth-dev
20170729 07:22:29-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170729 07:24:37-!- mjs-de [~mjs-de@x4db689f5.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170729 07:27:51-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170729 08:23:13-!- markus_ [~mjs-de@x55b64573.dyn.telefonica.de] has quit [Remote host closed the connection]
20170729 08:26:40-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170729 08:37:26-!- Duthlet [~Duthlet@dslb-188-101-088-243.188.101.pools.vodafone-ip.de] has joined #wesnoth-dev
20170729 08:50:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170729 09:02:45-!- Bonobo [~Bonobo@202.168.58.116] has quit [Read error: Connection reset by peer]
20170729 09:02:56-!- Bonobo [~Bonobo@202.168.58.116] has joined #wesnoth-dev
20170729 09:19:56-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170729 09:44:42-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170729 09:44:49-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170729 10:10:07-!- Bonobo [~Bonobo@202.168.58.116] has quit [Read error: Connection reset by peer]
20170729 10:11:44-!- Bonobo [~Bonobo@202.168.58.116] has joined #wesnoth-dev
20170729 10:14:57-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170729 10:22:24-!- horrowind [~Thunderbi@p2003008E6C0B2660964452FFFE0220ED.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170729 10:24:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170729 10:33:08-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Remote host closed the connection]
20170729 10:33:40-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20170729 10:37:18-!- horrowind [~Thunderbi@p2003008E6C0B2660964452FFFE0220ED.dip0.t-ipconnect.de] has quit [Quit: horrowind]
20170729 10:42:43-!- Kwandulin [~Kwandulin@p200300760F5F2DE5A4C979CBBAD8B833.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170729 11:04:02< vultraz_iOS> zookeeper: is https://github.com/wesnoth/wesnoth/pull/1839 now ready?
20170729 11:05:11< vultraz_iOS> if it is please squash and merge 
20170729 11:08:32-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170729 11:09:13-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20170729 11:10:14-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Remote host closed the connection]
20170729 11:10:15-!- wedge010 is now known as wedge009
20170729 11:25:49-!- mjs-de [~mjs-de@185.22.140.57] has joined #wesnoth-dev
20170729 11:26:20-!- gfgtdf [~chatzilla@x4e3698fb.dyn.telefonica.de] has joined #wesnoth-dev
20170729 11:29:02-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170729 11:36:38-!- mjs-de [~mjs-de@185.22.140.57] has quit [Remote host closed the connection]
20170729 12:04:39-!- Kwandulin [~Kwandulin@p200300760F5F2DE5A4C979CBBAD8B833.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170729 12:35:26-!- gfgtdf [~chatzilla@x4e3698fb.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 54.0.1/20170628075643]]
20170729 13:19:44< zookeeper> vultraz_iOS, was going to look at the latest version tonight
20170729 13:22:02< vultraz_iOS> good, good
20170729 13:24:22-!- atarocch [~atarocch@93.56.160.37] has quit [Ping timeout: 255 seconds]
20170729 13:36:16-!- atarocch [~atarocch@93.56.160.37] has joined #wesnoth-dev
20170729 13:41:23-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
20170729 13:41:52-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170729 13:59:00-!- trewe [~trewe@a83-132-197-192.cpe.netcabo.pt] has joined #wesnoth-dev
20170729 14:13:32-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20170729 14:49:00-!- Bonobo [~Bonobo@202.168.58.116] has quit [Ping timeout: 260 seconds]
20170729 15:08:28-!- horrowind [~Thunderbi@p2003008E6C0B2660964452FFFE0220ED.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170729 15:12:43-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170729 15:15:33-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170729 15:45:57-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170729 15:51:58-!- Kwandulin [~Kwandulin@p200300760F5F2DE5A4C979CBBAD8B833.dip0.t-ipconnect.de] has quit [Ping timeout: 255 seconds]
20170729 15:58:18-!- Kwandulin [~Kwandulin@p200300760F5F2D1389F7F86692B4FD0B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170729 16:06:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170729 16:48:18-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170729 16:55:17< celticminstrel> Huh... I thought there was a bug related to mixing concatenations of <<>> and "", but I can't seem to reproduce it now...
20170729 17:02:22-!- Kwandulin [~Kwandulin@p200300760F5F2D1389F7F86692B4FD0B.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170729 17:21:43-!- trewe [~trewe@a83-132-197-192.cpe.netcabo.pt] has quit [Quit: quit]
20170729 17:47:22-!- DeFender1031 [~DeFender1@217.132.16.231] has joined #wesnoth-dev
20170729 17:47:37-!- Kwandulin [~Kwandulin@p200300760F5F2D1389F7F86692B4FD0B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170729 17:56:29-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170729 17:57:08-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:c0b2:46be:b1a:420] has joined #wesnoth-dev
20170729 17:59:00-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170729 18:01:10-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:c0b2:46be:b1a:420] has quit [Ping timeout: 240 seconds]
20170729 18:01:42-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170729 18:09:34-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20170729 18:19:34-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170729 18:20:42-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:c0b2:46be:b1a:420] has joined #wesnoth-dev
20170729 18:21:18-!- irker163 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170729 18:21:18< irker163> wesnoth: sigurdfdragon wesnoth:master 69b447b5e758 / data/campaigns/Delfadors_Memoirs/scenarios/12_Terror_at_the_Ford_of_Parthyn.cfg: DM S12: Add loyal icon for the loyal units https://github.com/wesnoth/wesnoth/commit/69b447b5e75826cd3a6237362e6b3664f8974dce
20170729 18:21:18< irker163> wesnoth: sigurdfdragon wesnoth:master ee01350acf95 / data/campaigns/Delfadors_Memoirs/scenarios/ (3 files): DM: Clarify scenario objectives https://github.com/wesnoth/wesnoth/commit/ee01350acf9570c76998ad2afd9575d2a0065009
20170729 18:21:19< irker163> wesnoth: sigurdfdragon wesnoth:master 56e8b6749adc / data/campaigns/Delfadors_Memoirs/scenarios/07_Night_in_the_Swamp.cfg: DM S07: Adjust turns so time over event displays properly https://github.com/wesnoth/wesnoth/commit/56e8b6749adcefc78cc0a0d9a4aaf71e38b037c5
20170729 18:21:20< irker163> wesnoth: sigurdfdragon wesnoth:master f9928f84bd5c / data/campaigns/Delfadors_Memoirs/scenarios/07_Night_in_the_Swamp.cfg: DM S07: Fix typo https://github.com/wesnoth/wesnoth/commit/f9928f84bd5ce2701a9e74529ba705657728354d
20170729 18:21:21< irker163> wesnoth: sigurdfdragon wesnoth:master 2ef06716c66d / data/campaigns/Delfadors_Memoirs/scenarios/02_This_Valley_Belongs_to_Me.cfg: DM S02: Fix dialog based on feedback https://github.com/wesnoth/wesnoth/commit/2ef06716c66d066a29da9ee1cef4d37198fd0eef
20170729 18:21:22< irker163> wesnoth: sigurdfdragon wesnoth:master e54bae953f5f / data/campaigns/Delfadors_Memoirs/scenarios/20_Prince_of_Wesnoth.cfg: DM S20: Have Eldred look beaten instead of healed https://github.com/wesnoth/wesnoth/commit/e54bae953f5fefdc4da14979fc5441de17b07c0b
20170729 18:21:24< irker163> wesnoth: sigurdfdragon wesnoth:master 15d69d19e2e0 / data/campaigns/Delfadors_Memoirs/scenarios/21_Clash_at_the_Manor.cfg: DM S21: Fix grammar https://github.com/wesnoth/wesnoth/commit/15d69d19e2e0b7d1fd038cd8e56e8b09fbd288d3
20170729 18:21:26< irker163> wesnoth: sigurdfdragon wesnoth:master d2cec5eda702 / data/campaigns/Delfadors_Memoirs/scenarios/21_Clash_at_the_Manor.cfg: DM S21: Fix typo https://github.com/wesnoth/wesnoth/commit/d2cec5eda70204aef33589d2ec69e8ad4dd34679
20170729 18:21:56< DeFender1031> Hooray for The Big Ol' Wall O' Changes!
20170729 18:21:57-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:c0b2:46be:b1a:420] has quit [Remote host closed the connection]
20170729 18:24:28-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Ping timeout: 246 seconds]
20170729 18:25:26< SigurdFD> :D
20170729 18:27:01-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:c0b2:46be:b1a:420] has joined #wesnoth-dev
20170729 18:29:25-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:c0b2:46be:b1a:420] has quit [Remote host closed the connection]
20170729 18:30:02-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:c0b2:46be:b1a:420] has joined #wesnoth-dev
20170729 18:34:28-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:c0b2:46be:b1a:420] has quit [Ping timeout: 258 seconds]
20170729 18:34:34-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has quit []
20170729 19:13:06-!- celmin [~celticmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170729 19:19:21-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:c0b2:46be:b1a:420] has joined #wesnoth-dev
20170729 19:25:23-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:c0b2:46be:b1a:420] has quit [Remote host closed the connection]
20170729 19:40:58-!- trewe [~trewe@a83-132-197-192.cpe.netcabo.pt] has joined #wesnoth-dev
20170729 19:52:35-!- mjs-de [~mjs-de@185.22.140.246] has joined #wesnoth-dev
20170729 19:57:10-!- Kwandulin [~Kwandulin@p200300760F5F2D1389F7F86692B4FD0B.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170729 20:22:35-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170729 20:22:42-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170729 20:23:07-!- trewe [~trewe@a83-132-197-192.cpe.netcabo.pt] has quit [Ping timeout: 246 seconds]
20170729 20:44:40-!- trewe [~trewe@89-180-200-114.net.novis.pt] has joined #wesnoth-dev
20170729 21:00:32-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170729 21:11:32-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170729 21:11:38-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170729 21:23:43-!- irker163 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170729 21:24:10-!- mjs-de [~mjs-de@185.22.140.246] has quit [Remote host closed the connection]
20170729 21:32:09-!- _trewe [~trewe@a83-132-197-192.cpe.netcabo.pt] has joined #wesnoth-dev
20170729 21:34:32-!- trewe [~trewe@89-180-200-114.net.novis.pt] has quit [Ping timeout: 260 seconds]
20170729 21:35:38-!- _trewe [~trewe@a83-132-197-192.cpe.netcabo.pt] has quit [Client Quit]
20170729 21:43:43-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170729 21:58:51-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170729 22:07:57-!- Duthlet [~Duthlet@dslb-188-101-088-243.188.101.pools.vodafone-ip.de] has quit [Quit: leaving]
20170729 22:32:23-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170729 22:36:49-!- irker414 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170729 22:36:49< irker414> wesnoth: Charles Dang wesnoth:accelerated_rendering f49513f76e57 / src/gui/widgets/window.hpp: GUI2/Window: added getters for dispatcher and display mode https://github.com/wesnoth/wesnoth/commit/f49513f76e57a1d58f588e8e90cca91f3c86d911
20170729 22:36:50< irker414> wesnoth: Charles Dang wesnoth:accelerated_rendering 3202635f3743 / src/gui/widgets/ (window.cpp window.hpp): GUI2/Window: added display mode flag for modeless windows https://github.com/wesnoth/wesnoth/commit/3202635f37434934c64db5e8e47558b666420622
20170729 22:36:51< irker414> wesnoth: Charles Dang wesnoth:accelerated_rendering bbf63466e877 / src/gui/ (core/event/handler.cpp core/event/handler.hpp dialogs/modal_dialog.cpp): GUI2/Modal Dialog: don't use pop_back to remove window ptr from open window stac https://github.com/wesnoth/wesnoth/commit/bbf63466e877c9b57bc708e52f9ffdec61e65db1
20170729 22:36:53< irker414> wesnoth: Charles Dang wesnoth:accelerated_rendering 8a38015b396d / src/gui/dialogs/ (modeless_dialog.cpp modeless_dialog.hpp): GUI2/Modeless Dialog: minor cleanup, implement a TODO https://github.com/wesnoth/wesnoth/commit/8a38015b396d8abd3d8001bb875e259f145ee0a0
20170729 22:36:54< vultraz_iOS> celmin: ^ could you backport to master at you discretion
20170729 22:40:19< vultraz_iOS> (these are the general purpose commits_
20170729 22:40:20< vultraz_iOS> )
20170729 22:40:27< vultraz_iOS> more a_r-specific stuff will come
20170729 22:53:54< celmin> Will consider it after I take a look at them.
20170729 23:11:57-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Remote host closed the connection]
20170729 23:23:19-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev
20170729 23:32:44-!- travis-ci [~travis-ci@ec2-54-161-249-106.compute-1.amazonaws.com] has joined #wesnoth-dev
20170729 23:32:45< travis-ci> wesnoth/wesnoth#14581 (accelerated_rendering - 8a38015 : Charles Dang): The build failed.
20170729 23:32:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/258971902
20170729 23:32:45-!- travis-ci [~travis-ci@ec2-54-161-249-106.compute-1.amazonaws.com] has left #wesnoth-dev []
20170729 23:35:49-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170729 23:45:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170729 23:45:48-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20170729 23:53:57-!- deep-book-gk_ [~1wm_su@177.47.27.242] has joined #wesnoth-dev
20170729 23:56:00-!- deep-book-gk_ [~1wm_su@177.47.27.242] has left #wesnoth-dev []
--- Log closed Sun Jul 30 00:00:59 2017