--- Log opened Sun Jul 30 00:00:59 2017
20170730 00:22:10-!- Bonobo [~Bonobo@202.168.58.116] has joined #wesnoth-dev
20170730 00:22:30-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 240 seconds]
20170730 01:03:39-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev
20170730 01:07:01< vultraz_iOS> celmin: why the hell does this work o_o
20170730 01:07:02< vultraz_iOS> static std::unique_ptr<class sdl_event_handler> handler_ = nullptr;
20170730 01:07:30< vultraz_iOS> (class keyword in template specialization)
20170730 01:07:37< celmin> Huh?
20170730 01:07:39< vultraz_iOS> (or is it specification?)
20170730 01:07:58< vultraz_iOS> in leiu of a forward declaration
20170730 01:08:15< celmin> This is sort of a relic of the C world, but it does serve as a forward declaration.
20170730 01:08:37< vultraz_iOS> so should it be used or not?
20170730 01:08:45< vultraz_iOS> since it's a C ism
20170730 01:09:07< celmin> In C, struct names are in a separate namespace from typedef names, so you need to refer to them as "struct sdl_event_handler" instead of just "sdl_event_handler" (or "union SDL_Event" instead of just SDL_Event").
20170730 01:09:16 * celmin missed a quote there, whoops.
20170730 01:09:53< celmin> Because of this, it's a common idiom in C to typedef all structs to "export" them into the same namespace.
20170730 01:10:05< celmin> Something like "typedef struct thing thing".
20170730 01:10:23< celmin> Or even "typedef struct { … } thing" which gives a typedef name to an anonymous struct.
20170730 01:10:40< celmin> C++ changed that so that classes, structs, unions, and enums are automatically exported and thus essentially share the same namespace as all types.
20170730 01:11:16< celmin> However, for C compatibility it's still legal to use the tagged form, ie "class thing" instead of "thing"; and in some cases, this is actually useful because it also serves as a forward declaration of the class.
20170730 01:15:48-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170730 01:22:15-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:c0b2:46be:b1a:420] has joined #wesnoth-dev
20170730 01:41:17-!- irker414 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170730 01:42:55-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:c0b2:46be:b1a:420] has quit [Remote host closed the connection]
20170730 01:43:32-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:c0b2:46be:b1a:420] has joined #wesnoth-dev
20170730 01:47:34-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:c0b2:46be:b1a:420] has quit [Ping timeout: 246 seconds]
20170730 02:00:30-!- horrowind [~Thunderbi@p2003008E6C0B2660964452FFFE0220ED.dip0.t-ipconnect.de] has quit [Quit: horrowind]
20170730 02:46:37-!- deathisundead [~quassel@2601:40a:c300:73aa:d05f:dd29:bba4:e5c5] has joined #wesnoth-dev
20170730 02:46:37-!- deathisundead [~quassel@2601:40a:c300:73aa:d05f:dd29:bba4:e5c5] has quit [Changing host]
20170730 02:46:37-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20170730 03:27:52< vultraz_iOS> src/gui/widgets/window.hpp:740:25: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers]
20170730 03:27:52< vultraz_iOS>   const show_mode mode() const
20170730 03:27:54< vultraz_iOS> eh?
20170730 03:28:26< vultraz_iOS> celmin: is there some weird thing with returning enums?
20170730 03:28:37< celmin> ?
20170730 03:28:57< celmin> I don't think that has anything to do with enums.
20170730 03:29:08< celmin> It's simply meaningless to use const on a function return type.
20170730 03:29:09< vultraz_iOS> then what?
20170730 03:29:25< celmin> Or, to be more specific, it's meaningless to use value-const on a function return type.
20170730 03:29:42< celmin> Pointer-const and reference-const are, of course, perfectly meaningful.
20170730 03:30:19< vultraz_iOS> do i should remove the leading const?
20170730 03:30:21< celmin> A function return type is effectively const anyway. You can't assign to the location where the return value is stored.
20170730 03:30:22< celmin> Yes.
20170730 03:30:47< celmin> (FTR, "int* const" is value-const and would produce the same warning.)
20170730 03:31:50< vultraz_iOS> then why is the compiler pointing at the trailing const
20170730 03:32:04< celmin> ?
20170730 03:32:30< vultraz_iOS> the travis output
20170730 03:32:31< celmin> The trailing const would be a compile error if it's not meaningful.
20170730 03:32:33< celmin> Not a warning.
20170730 03:32:38< celmin> Maybe there's a bug in clang?
20170730 03:32:45< vultraz_iOS> it is an error :|
20170730 03:32:51< celmin> No it's not, it's a warning.
20170730 03:33:00< vultraz_iOS> "error"
20170730 03:33:01< vultraz_iOS> :|
20170730 03:33:08< celmin> It's a warning that was promoted to an error, but still a warning.
20170730 03:33:25< vultraz_iOS> i see
20170730 03:33:29< celmin> You can tell by the -Werror=ignored-qualifiers bit
20170730 03:33:43< vultraz_iOS> so just "show_mode mode() const"
20170730 03:33:46< celmin> Yeah.
20170730 03:33:56< celmin> It's meaningless to return a const value.
20170730 03:55:42-!- irker819 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170730 03:55:42< irker819> wesnoth: Charles Dang wesnoth:accelerated_rendering 89ce27a1fd60 / src/gui/widgets/window.hpp: GUI2/Window: attempt to satisfy Travis https://github.com/wesnoth/wesnoth/commit/89ce27a1fd603b6602b1727a0301c6f398d82973
20170730 03:55:43< irker819> wesnoth: Charles Dang wesnoth:accelerated_rendering 709af0897761 / src/gui/widgets/ (window.cpp window.hpp): GUI2/Window: removed now-unused members https://github.com/wesnoth/wesnoth/commit/709af0897761ae2c122afeebc1df27618c071ee9
20170730 03:55:44< irker819> wesnoth: Charles Dang wesnoth:accelerated_rendering 7258752003fe / src/gui/widgets/ (window.cpp window.hpp): GUI2/Window: minor cleanup https://github.com/wesnoth/wesnoth/commit/7258752003fefb207d09e86960990bd967e41646
20170730 03:55:46< vultraz_iOS> celmin: ^ please also consider the first and third commits for backport
20170730 03:56:11-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!]
20170730 03:57:04< vultraz_iOS> celticminstrel: 
20170730 03:58:01< celticminstrel> Yeah yeah, I saw.
20170730 03:58:03< vultraz_iOS> second is a_r-exclusive
20170730 04:02:35< celticminstrel> vultraz_iOS: In bbf6346 you should've also used the function in modeless_dialog, shouldn't you? I guess you did do that in the following commit, but it makes more sense to keep it in the same commit IMO.
20170730 04:03:44< vultraz_iOS> eh, probably
20170730 04:05:45< celticminstrel> Personally, I think initializing inline is better than initializing in the constructor initializers.
20170730 04:06:05< celticminstrel> IOW, the change in 7258752 isn't necessarily an improvement.
20170730 04:06:36< celticminstrel> The advantage of inline initialization is that it applies to all constructors (unless they also have an entry for that member in their initializer-list).
20170730 04:07:03< celticminstrel> I suppose it makes little difference in this case (there's only one constructor, right?), but still.
20170730 04:07:24< vultraz_iOS> yeah, one
20170730 04:07:31< vultraz_iOS> i thought ctor list was better
20170730 04:12:09< celticminstrel> Inline definitely has its place.
20170730 04:12:35< celticminstrel> I'll also point out that inline initialization was impossible before C++11, so someone thought it was something that needed adding. :P
20170730 04:12:50< irker819> wesnoth: Charles Dang wesnoth:master 9801a92b36eb / src/gui/widgets/ (window.cpp window.hpp): GUI2/Window: added getters for dispatcher and display mode, and flag for modeles https://github.com/wesnoth/wesnoth/commit/9801a92b36ebecea86a12cd4a1c873ee5b5b28ee
20170730 04:49:29-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20170730 04:53:18< vultraz_iOS> just that?
20170730 04:59:27-!- Bonobo [~Bonobo@202.168.58.116] has quit [Read error: Connection reset by peer]
20170730 04:59:47< celticminstrel> Well, that's three commits merged together.
20170730 05:00:49< celticminstrel> But I didn't really see any need to merge the others. TBH, those might've technically been unnecessary too, but whatever.
20170730 05:03:10-!- timotei__ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 240 seconds]
20170730 05:10:36-!- travis-ci [~travis-ci@ec2-54-156-123-11.compute-1.amazonaws.com] has joined #wesnoth-dev
20170730 05:10:37< travis-ci> wesnoth/wesnoth#14584 (accelerated_rendering - 7258752 : Charles Dang): The build is still failing.
20170730 05:10:37< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/259010637
20170730 05:10:37-!- travis-ci [~travis-ci@ec2-54-156-123-11.compute-1.amazonaws.com] has left #wesnoth-dev []
20170730 05:12:49-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170730 05:29:13-!- Bonobo [~Bonobo@202.168.58.116] has joined #wesnoth-dev
20170730 05:29:29-!- Kwandulin [~Kwandulin@p200300760F5F2D13816D78AAC0E8621E.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170730 05:30:22-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20170730 05:37:56-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20170730 05:53:44< vultraz_iOS> celmin: that's... two commits
20170730 06:56:47< irker819> wesnoth: Ignacio R. Morelle wesmere:master c5da2a71fb1a / static/bits/gallery.js wesmere/sass/home/_site_home.scss: home: Implement gallery fade-in when transitioning from a video to an image https://github.com/wesnoth/wesmere/commit/c5da2a71fb1af1340875d5e911ce00815451a892
20170730 06:58:37-!- timotei_ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 260 seconds]
20170730 07:38:43-!- Kwandulin2 [~Kwandulin@p200300760F5F2D13816D78AAC0E8621E.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170730 07:38:46-!- Kwandulin [~Kwandulin@p200300760F5F2D13816D78AAC0E8621E.dip0.t-ipconnect.de] has quit [Ping timeout: 255 seconds]
20170730 07:42:13-!- mjs-de [~mjs-de@b9168eab.cgn.dg-w.de] has joined #wesnoth-dev
20170730 07:44:54-!- mjs-de [~mjs-de@b9168eab.cgn.dg-w.de] has quit [Remote host closed the connection]
20170730 07:50:59-!- travis-ci [~travis-ci@ec2-54-156-123-11.compute-1.amazonaws.com] has joined #wesnoth-dev
20170730 07:51:00< travis-ci> wesnoth/wesnoth#14586 (master - 9801a92 : Charles Dang): The build has errored.
20170730 07:51:00< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/259013300
20170730 07:51:00-!- travis-ci [~travis-ci@ec2-54-156-123-11.compute-1.amazonaws.com] has left #wesnoth-dev []
20170730 08:03:27-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 240 seconds]
20170730 08:19:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170730 08:35:27-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20170730 08:40:22-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170730 09:08:20-!- Kwandulin2 [~Kwandulin@p200300760F5F2D13816D78AAC0E8621E.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170730 09:17:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20170730 09:17:41-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170730 09:22:07-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds]
20170730 09:54:51-!- Kwandulin [~Kwandulin@p200300760F5F2D133DE8AC36DF5A4964.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170730 09:58:55-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev
20170730 09:59:59-!- irker819 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170730 10:07:05-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170730 10:28:31-!- horrowind [~Thunderbi@p2003008E6C0B26DB964452FFFE0220ED.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170730 10:34:27-!- timotei_ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 260 seconds]
20170730 10:35:07-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20170730 10:44:12-!- timotei_ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 255 seconds]
20170730 11:10:47-!- Kwandulin [~Kwandulin@p200300760F5F2D133DE8AC36DF5A4964.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170730 11:29:00-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170730 11:30:51-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20170730 12:46:26-!- Kwandulin [~Kwandulin@p200300760F5F2D133DE8AC36DF5A4964.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170730 13:18:03-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170730 13:32:16-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170730 13:32:24-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170730 13:36:30-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20170730 13:40:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170730 13:48:40-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170730 14:02:14-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170730 14:12:36-!- horrowind [~Thunderbi@p2003008E6C0B26DB964452FFFE0220ED.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20170730 14:12:52-!- horrowind [~Thunderbi@p2003008E6C0B26DB964452FFFE0220ED.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170730 14:31:27-!- irker063 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170730 14:31:27< irker063> wesnoth: Jyrki Vesterinen wesnoth:master 13fe9db75536 / src/attack_prediction.cpp: We won't heal slow/poison if the opponent is already dead https://github.com/wesnoth/wesnoth/commit/13fe9db7553699b1819bb7ad7d7ed198899fdf59
20170730 14:35:32< matthiaskrgr> lol
20170730 14:36:07< JyrkiVesterinen> Attack prediction code is really complex and hard to get right... *sigh*
20170730 14:41:10-!- horrowind [~Thunderbi@p2003008E6C0B26DB964452FFFE0220ED.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20170730 14:41:23-!- horrowind [~Thunderbi@p2003008E6C0B26DB964452FFFE0220ED.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170730 14:54:41-!- Kwandulin [~Kwandulin@p200300760F5F2D133DE8AC36DF5A4964.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170730 15:06:08-!- celmin [~celticmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170730 15:19:20-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170730 15:19:27-!- janebot [~Gambot@grickit.us] has joined #wesnoth-dev
20170730 15:19:33-!- janebot [~Gambot@grickit.us] has quit [Changing host]
20170730 15:19:33-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170730 15:50:04< vultraz_iOS> celmin: you only did two commits yesterday not three
20170730 15:50:14< celmin> ???
20170730 15:50:33< vultraz_iOS> <celticminstrel> Well, that's three commits merged together.
20170730 15:50:46< celmin> I merged commits f49513f76e57, 3202635f3743, and 89ce27a1fd60.
20170730 15:51:35< vultraz_iOS> ah, I see
20170730 15:53:38< irker063> wesnoth: doofus-01 wesnoth:master 96860d94e5da / data/core/images/scenery/ (12 files): touch-ups to some _ancient_ scenery images, and adding a few variations https://github.com/wesnoth/wesnoth/commit/96860d94e5da499a9dde793addfd50d64a5f1d69
20170730 15:53:40< irker063> wesnoth: doofus-01 wesnoth:master 4208eda7bfb7 / data/campaigns/ (2 files in 2 dirs): editing some mainline scenarios that used images in previous commit, so there is https://github.com/wesnoth/wesnoth/commit/4208eda7bfb734d1ea07df07a948e1260775a5ff
20170730 15:53:42< irker063> wesnoth: doofus-01 wesnoth:master 816bd059a623 / data/campaigns/The_Rise_Of_Wesnoth/scenarios/ (16_The_Kalian.cfg 18_A_Spy_in_the_Woods.cfg): removing pine2.png image from middle of Kalian castle, where it was sitting on t https://github.com/wesnoth/wesnoth/commit/816bd059a623850200f47e0ddfbd1f31af098861
20170730 15:53:44< irker063> wesnoth: doofus-01 wesnoth:master e10c334df65c / data/core/images/items/coffin-open.png: a couple items images https://github.com/wesnoth/wesnoth/commit/e10c334df65c32ca30c8fa5fc9bd20091bf20ae2
20170730 15:53:46< irker063> wesnoth: doofus-01 wesnoth:master b7382e2df35d / data/core/images/items/spear-fancy.png: should have been in previous commit, squash https://github.com/wesnoth/wesnoth/commit/b7382e2df35d6ade53b3b889d6cc4faa715219d0
20170730 15:54:56< vultraz_iOS> celmin: anything on https://github.com/wesnoth/wesnoth/pull/1865 ?
20170730 15:58:57< celmin> Aww, that squash was not squashed...
20170730 15:59:08-!- Bonobo [~Bonobo@202.168.58.116] has quit [Ping timeout: 260 seconds]
20170730 16:00:11< celmin> vultraz_iOS: I suspect it may be quite wrong, but not sure.
20170730 16:00:24< celmin> Two things.
20170730 16:00:46< celmin> 1. I think I made a mistake implementing the idea "use utf8::size to get the length".
20170730 16:00:58< celmin> 2. I'm not confident that the idea is the right choice in the first place.
20170730 16:01:19< vultraz_iOS> i honestly don't really know what we're trying to do there anyway
20170730 16:01:35< celmin> It's fairly small, so it could probably still be merged post-1.13.9/
20170730 16:02:46< vultraz_iOS> alright
20170730 16:03:21-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 268 seconds]
20170730 16:08:03< vultraz_iOS> celmin: unrelated: do you think the in-game context menu should appear on mouse down (like current) or on mouse up (like every other app)
20170730 16:08:55-!- travis-ci [~travis-ci@ec2-54-81-253-82.compute-1.amazonaws.com] has joined #wesnoth-dev
20170730 16:08:56< travis-ci> wesnoth/wesnoth#14587 (master - 13fe9db : Jyrki Vesterinen): The build passed.
20170730 16:08:56< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/259097820
20170730 16:08:56-!- travis-ci [~travis-ci@ec2-54-81-253-82.compute-1.amazonaws.com] has left #wesnoth-dev []
20170730 16:11:10-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20170730 16:13:39< celmin> Mouse up makes more sense, I guess.
20170730 16:14:01< celmin> Showing it on mouse-up makes right-click-drag possible.
20170730 16:20:08< celmin> There's a set used in mp_join_game? I only see a map in the header file.
20170730 16:21:27< vultraz_iOS> eh?
20170730 16:21:42< vultraz_iOS> oh wait
20170730 16:21:45< vultraz_iOS> the set is in the OTHER dialog
20170730 16:22:07< celmin> mp_staging?
20170730 16:22:14< vultraz_iOS> yes
20170730 16:22:36< vultraz_iOS> mp_staging generates the player list from
20170730 16:22:37< vultraz_iOS> for(const auto& player : connect_engine_.connected_users()) {
20170730 16:22:41< vultraz_iOS> which is a set...
20170730 16:22:58< vultraz_iOS> but join_game is just for(const auto& side : get_scenario().child_range("side")) {
20170730 16:23:01< vultraz_iOS> HM
20170730 16:23:06< vultraz_iOS> ponder ponder ponder
20170730 16:24:41< vultraz_iOS> how do i fix this
20170730 16:25:42< vultraz_iOS> ponder ponder
20170730 16:26:07< vultraz_iOS> the network needs to send player data somewhere..
20170730 16:28:10-!- Kwandulin [~Kwandulin@p200300760F5F2D07D06056327A76D1DC.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170730 16:29:42< vultraz_iOS> i don't know where
20170730 16:41:46-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170730 16:41:53-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170730 17:01:21-!- travis-ci [~travis-ci@ec2-54-81-253-82.compute-1.amazonaws.com] has joined #wesnoth-dev
20170730 17:01:22< travis-ci> wesnoth/wesnoth#14588 (master - b7382e2 : doofus-01): The build passed.
20170730 17:01:22< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/259113305
20170730 17:01:22-!- travis-ci [~travis-ci@ec2-54-81-253-82.compute-1.amazonaws.com] has left #wesnoth-dev []
20170730 17:11:14< irker063> wesnoth: ln-zookeeper wesnoth:master f818745c7210 / data/core/ (50 files in 3 dirs): Revisions to gate/door terrains by doofus-01 (manual merge of PR #1839) https://github.com/wesnoth/wesnoth/commit/f818745c72102d8645068d91f8db2b80f8a16ad8
20170730 17:11:36< vultraz_iOS> \o/
20170730 17:31:57-!- Kwandulin [~Kwandulin@p200300760F5F2D07D06056327A76D1DC.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170730 17:34:19< irker063> wesnoth: Charles Dang wesnoth:master 6f1a13c3a65f / data/gui/widget/image_default.cfg: GUI2/Image: added tiled-to-size image definition https://github.com/wesnoth/wesnoth/commit/6f1a13c3a65f931a8069428cf986a7f2e566e8d9
20170730 17:34:22< irker063> wesnoth: Charles Dang wesnoth:master 05210ae1f2f8 / data/gui/widget/toggle_button_icon.cfg: GUI2: fixed some overlay drawing issues with icon toggle buttons https://github.com/wesnoth/wesnoth/commit/05210ae1f2f803d81cb8ee7b7a28b3d3a467da37
20170730 17:34:25< irker063> wesnoth: Charles Dang wesnoth:master 5a902900507e / data/gui/widget/image_default.cfg: GUI2/Image: added scaled-to-size definition https://github.com/wesnoth/wesnoth/commit/5a902900507e66f20150076fde912bf7c592ad55
20170730 17:34:28< irker063> wesnoth: Charles Dang wesnoth:master 02ed22b8f273 / data/gui/widget/toggle_button_icon.cfg: GUI2/Toggle Button: added medium-sized icon button definition https://github.com/wesnoth/wesnoth/commit/02ed22b8f273a7b4f3397ef8a6ee08b300487e59
20170730 17:34:31< irker063> wesnoth: Charles Dang wesnoth:master fd7877c26c9a / data/gui/window/addon_manager.cfg: GUI2/Addon Manager: removed some excessive borders in the low resolution definit https://github.com/wesnoth/wesnoth/commit/fd7877c26c9a7693615b74462dde9602e8d9028d
20170730 17:34:34< irker063> wesnoth: Charles Dang wesnoth:master e724bdf483f4 / src/gui/ (core/event/handler.cpp core/event/handler.hpp dialogs/modal_dialog.cpp): GUI2/Modal Dialog: don't use pop_back to remove window ptr from open window stac https://github.com/wesnoth/wesnoth/commit/e724bdf483f485e299bdc12a8b5b19c6d43b76de
20170730 17:34:37< irker063> wesnoth: Charles Dang wesnoth:master db44561d334c / src/gui/dialogs/ (modeless_dialog.cpp modeless_dialog.hpp): GUI2/Modeless Dialog: minor cleanup, implement a TODO https://github.com/wesnoth/wesnoth/commit/db44561d334c0a0b81543c21e2f57e6f50111f4d
20170730 17:34:40< irker063> wesnoth: Charles Dang wesnoth:master 2416f10dddae / src/gui/widgets/ (window.cpp window.hpp): GUI2/Window: minor cleanup https://github.com/wesnoth/wesnoth/commit/2416f10dddaebd1629e2da711b878b1082bb60e8
20170730 17:34:43< irker063> wesnoth: Charles Dang wesnoth:master 813c0a50f9fe / src/gui/ (core/event/handler.cpp dialogs/modal_dialog.cpp dialogs/modal_dialog.hpp): GUI2: made use of the great unique_ptr in a few places https://github.com/wesnoth/wesnoth/commit/813c0a50f9fe3a67d3988d82b3d64338e71b7515
20170730 17:34:46< irker063> wesnoth: Charles Dang wesnoth:master c29ea03212d9 / src/gui/dialogs/ (6 files): GUI2: removed superfluous build_window methods from a few dialogs https://github.com/wesnoth/wesnoth/commit/c29ea03212d90ac0764691025f457e6f285fdb64
20170730 17:34:49< irker063> wesnoth: Charles Dang wesnoth:master 42d146979a4e / src/gui/dialogs/ (loading_screen.cpp loading_screen.hpp): GUI2/Loading Screen: cleaned up some unused stuff https://github.com/wesnoth/wesnoth/commit/42d146979a4e14a7407b0806cd2a594f75d94c18
20170730 17:34:52< vultraz_iOS> more backporting /o/ \o\
20170730 17:37:36< vultraz_iOS> celmin: hopefully all these are acceptable
20170730 17:39:45< celmin>  …oh yeah, I just remembered something else we need for 1.14.
20170730 17:39:57< celmin> The new storyscreen still doesn't have feature-parity with the old.
20170730 17:57:19< vultraz_iOS> agh, damn
20170730 17:57:31< vultraz_iOS> now the commit message in e724bdf483f4 is inaccurate
20170730 17:57:35< vultraz_iOS> oh well
20170730 18:18:35-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!]
20170730 18:33:19-!- Kwandulin [~Kwandulin@p200300760F5F2D07D06056327A76D1DC.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170730 18:47:44-!- travis-ci [~travis-ci@ec2-54-81-253-82.compute-1.amazonaws.com] has joined #wesnoth-dev
20170730 18:47:45< travis-ci> wesnoth/wesnoth#14590 (master - 42d1469 : Charles Dang): The build was broken.
20170730 18:47:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/259132970
20170730 18:47:45-!- travis-ci [~travis-ci@ec2-54-81-253-82.compute-1.amazonaws.com] has left #wesnoth-dev []
20170730 18:48:15-!- deep-book-gk_ [~1wm_su@119.81.29.178] has joined #wesnoth-dev
20170730 18:49:06-!- deep-book-gk_ [~1wm_su@119.81.29.178] has left #wesnoth-dev []
20170730 18:59:17-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:150b:f1bc:b36d:ba51] has joined #wesnoth-dev
20170730 19:01:21-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:150b:f1bc:b36d:ba51] has quit [Read error: Connection timed out]
20170730 19:01:54-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:150b:f1bc:b36d:ba51] has joined #wesnoth-dev
20170730 19:05:25-!- Kwandulin2 [~Kwandulin@p200300760F5F2D07F471C6E7D988B543.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170730 19:06:44-!- Kwandulin [~Kwandulin@p200300760F5F2D07D06056327A76D1DC.dip0.t-ipconnect.de] has quit [Ping timeout: 255 seconds]
20170730 19:42:31-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:150b:f1bc:b36d:ba51] has quit [Remote host closed the connection]
20170730 20:03:29-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170730 20:03:36-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170730 20:05:21< celticminstrel> vultraz_iOS: Looks like Travis didn't like your commits.
20170730 20:06:21< celticminstrel> test_gui2.cpp:2183 probably needs a .get() or something.
20170730 20:06:51-!- Kwandulin2 [~Kwandulin@p200300760F5F2D07F471C6E7D988B543.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170730 20:11:51-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170730 20:11:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170730 20:18:23-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170730 20:31:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170730 20:34:39< Soliton> celticminstrel: btw, the issue with a shortcut of shift+; is not only that it is different on various keyboard layouts, it's that you can not produce it at all if you already need shift for ;.
20170730 20:35:56-!- irker063 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170730 20:38:38< celticminstrel> I guess that would be essentially "you don't have a Semicolon key"...
20170730 20:41:51< Soliton> if by that you mean "you don't have a key that you can press without modifiers to get a semicolon", sure.
20170730 20:42:59< celticminstrel> More like "no key that produces SDLK_SEMICOLON as the key code", but I guess it comes out about the same.
20170730 20:46:57-!- timotei_ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 260 seconds]
20170730 20:47:34-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20170730 21:00:24-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Read error: Connection reset by peer]
20170730 21:05:11-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev
20170730 21:05:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170730 21:18:12-!- deep-book-gk_ [~1wm_su@158.85.67.146] has joined #wesnoth-dev
20170730 21:20:01-!- deep-book-gk_ [~1wm_su@158.85.67.146] has left #wesnoth-dev []
20170730 21:30:45< matthiaskrgr> mh
20170730 21:30:51< matthiaskrgr> I'm getting build error with latest git
20170730 21:31:05< matthiaskrgr> ../src/tests/gui/test_gui2.cpp:157:9: error: no viable conversion from returned value of type 'const std::unique_ptr<window>' to function return type 'gui2::window *'
20170730 21:31:08< matthiaskrgr>         return dialog.window_;
20170730 21:31:10< matthiaskrgr>                ^~~~~~~~~~~~~~
20170730 21:39:18-!- irker359 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170730 21:39:18< irker359> wesnoth: Ignacio R. Morelle wesmere:master 945c12e65d18 / wesmere/sass/core/_site_layout_search.scss: sass: Force a color scheme on the search box https://github.com/wesnoth/wesmere/commit/945c12e65d18f2bbcb1664b6e2301a0210b2d42f
20170730 21:43:39-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170730 22:02:07< celticminstrel> Yeah, that's the same error as Travis.
20170730 22:05:43-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170730 22:12:45< irker359> wesnoth: Ignacio R. Morelle wesmere:master 0e602c574fc4 / wesmere/sass/ (_defs.scss mw/_ui.scss): sass/mw: No point in letting toolbar elements appear in the selection https://github.com/wesnoth/wesmere/commit/0e602c574fc413ddcd522d693558d1f2f70f5770
20170730 22:13:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 276 seconds]
20170730 22:19:54< celticminstrel> Oh yeah, ISTR there's a problem with my syntax highlighter still? Or at least, WML does not appear to be getting highlighted on the wiki ATM. Nor is WFL, for that matter. Lua is, though.
20170730 22:20:06< celticminstrel> shadowm: ^
20170730 22:27:13-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170730 22:55:52-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds]
20170730 22:59:56-!- Bonobo [~Bonobo@202.168.58.116] has joined #wesnoth-dev
20170730 23:09:53-!- ChipmunkV[m] [chipmunkvm@gateway/shell/matrix.org/x-hknnzorbiepidjyu] has quit [Ping timeout: 258 seconds]
20170730 23:10:39-!- Greg_Boggs[m] [gregboggsm@gateway/shell/matrix.org/x-uxsymmqkjcrkdkck] has quit [Ping timeout: 255 seconds]
20170730 23:27:43< irker359> wesnoth: Charles Dang wesnoth:master 8815965b2967 / src/tests/gui/test_gui2.cpp: Fixup tests for db44561d334c https://github.com/wesnoth/wesnoth/commit/8815965b2967db96494ccd50ed6817413be046fa
20170730 23:27:46< irker359> wesnoth: Charles Dang wesnoth:master c5dc04c90001 / src/ (controller_base.cpp mouse_handler_base.cpp mouse_handler_base.hpp): Handle context menus on mouse up instead of mouse down https://github.com/wesnoth/wesnoth/commit/c5dc04c90001b95fbd3e06be3a36680371a01e53
20170730 23:30:22-!- celmin [~celticmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170730 23:34:07-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20170730 23:36:49-!- Greg_Boggs[m] [gregboggsm@gateway/shell/matrix.org/x-zkczmesrhcosthrd] has joined #wesnoth-dev
20170730 23:44:13< shadowm> celticminstrel: Yeah, did you ever find out what was wrong with it?
20170730 23:44:34< celmin> I'm not sure if I ever got the information to help me figure it out...
20170730 23:44:54< shadowm> I don't remember how any of that works so I could use a memory refresher while I'm busy working on other things.
20170730 23:45:43< celmin> IIRC you need to add my wesnoth.py file into the folder with all the other syntax generators and then rebuild the database (which AFAIR involves running one of the python files in said folder).
20170730 23:46:09< celmin> …not entirely sure if that's what you were asking about though. >_>
20170730 23:46:17< shadowm> Database?
20170730 23:46:39< celmin> Maybe more like an index?
20170730 23:47:31< shadowm>     $wgPygmentizePath = "/home/wesnoth/mw-wesnoth-pygmentize/Pygments-2.1.3/pygmentize";
20170730 23:47:39< shadowm> Let's see if I can remember what the hell this is.
20170730 23:48:47< shadowm> -L lists stuff.
20170730 23:50:11< shadowm> https://pastebin.com/UNkwf5Dr -- Line 766.
20170730 23:50:22< shadowm> Other than the fact that there are two entries for wfl it seems okay to me?
20170730 23:52:01< celmin> That looks fine, yeah, but then why is it not colouring WML and WFL code? Should I try purging a page or something?
20170730 23:52:09< shadowm> 23:51:41 wesnoth@website:~/mw-wesnoth-pygmentize/Pygments-2.1.3$ ./pygmentize -l wml -o /srv/www/html/files/syntaxtest.html ~/addons-unpacked/1.12/After_the_Storm/_main.cfg
20170730 23:52:16-!- ChipmunkV[m] [chipmunkvm@gateway/shell/matrix.org/x-habyhfyswvfsxwzf] has joined #wesnoth-dev
20170730 23:52:22< shadowm> Produces this (look at it in source view): https://files.wesnoth.org/syntaxtest.html
20170730 23:52:34< shadowm> So it should be working just fine AFAICT.
20170730 23:54:11< celmin> Hmm, I see a lot of class=err though...
20170730 23:54:35< celmin> Still, that wouldn't explain colouring not happening at all.
20170730 23:58:09< celmin> Oh, the class=err is caused by actual invalid syntax which is hidden away from the parsed by an ifdef.
20170730 23:58:15< shadowm> How do I even make the extension spit out information about what it's doing?
20170730 23:58:21< shadowm> The MW extension, that is.
20170730 23:58:27< celmin> I'm not sure.
20170730 23:59:00< shadowm> https://wiki.wesnoth.org/User:Shadowmaster/WikiTest#Section_3_-_Block_Elements
20170730 23:59:08< celmin> It does look like your test file is correctly highlighted though it's hard to tell from just the source.
20170730 23:59:09< shadowm> The only thing I know for sure is that it's okay with Lua.
20170730 23:59:28< celmin> Yeah, I noticed that.
20170730 23:59:37< celmin> Wait, C++ doesn't work either?
20170730 23:59:43< shadowm> Oh maybe a newer version of the extension ignores the path to pygmentize/users its own/has a different way to set it.
--- Log closed Mon Jul 31 00:00:00 2017