--- Log opened Tue Aug 01 00:00:01 2017
20170801 00:09:24-!- horrowind [~Thunderbi@p2003008E6C0B26B4964452FFFE0220ED.dip0.t-ipconnect.de] has quit [Quit: horrowind]
20170801 00:18:55-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20170801 00:30:07-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170801 00:30:13-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170801 00:52:49-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170801 00:52:55-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170801 01:05:49-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170801 01:10:05-!- gfgtdf_ [~chatzilla@x4e32b12d.dyn.telefonica.de] has joined #wesnoth-dev
20170801 01:11:45-!- gfgtdf [~chatzilla@x4e36927a.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170801 01:11:59-!- gfgtdf_ is now known as gfgtdf
20170801 01:29:49-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170801 01:54:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170801 01:58:10-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170801 02:05:49-!- DeFender1031 [~DeFender1@217.132.16.231] has quit [Read error: Connection reset by peer]
20170801 02:06:50-!- DeFender1031 [~DeFender1@93-172-2-116.bb.netvision.net.il] has joined #wesnoth-dev
20170801 02:06:50-!- DeFender1031 [~DeFender1@93-172-2-116.bb.netvision.net.il] has quit [Read error: Connection reset by peer]
20170801 02:10:04-!- DeFender1031 [~DeFender1@93-172-2-116.bb.netvision.net.il] has joined #wesnoth-dev
20170801 02:10:12-!- https_GK1wmSU [~deep-book@77.234.42.183] has joined #wesnoth-dev
20170801 02:11:47-!- https_GK1wmSU [~deep-book@77.234.42.183] has left #wesnoth-dev []
20170801 02:29:50-!- irker804 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170801 02:29:51< irker804> wesnoth: Nobun wesnoth:master 3f287b909846 / utils/ (pywmlx/state/machine.py wmlxgettext): wmlxgettext: fix UTF-8 issue: #1785 (#1793) https://github.com/wesnoth/wesnoth/commit/3f287b9098462529acdd8d36c9d28fe2c92b0b9e
20170801 02:39:01-!- gfgtdf [~chatzilla@x4e32b12d.dyn.telefonica.de] has quit [Remote host closed the connection]
20170801 03:05:38-!- Bonobo [~Bonobo@129.127.113.237] has joined #wesnoth-dev
20170801 03:32:02-!- Bonobo [~Bonobo@129.127.113.237] has quit [Ping timeout: 260 seconds]
20170801 03:44:40-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20170801 04:12:56-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170801 04:19:51-!- clavi [~clavi@v22017034422546657.goodsrv.de] has quit [Quit: ZNC - http://znc.in]
20170801 04:24:58-!- clavi [~clavi@v22017034422546657.goodsrv.de] has joined #wesnoth-dev
20170801 04:26:28-!- Kwandulin [~Kwandulin@p200300760F5F2DDA49FA6E3993677FE7.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170801 04:47:37-!- Bonobo [~Bonobo@129.127.113.237] has joined #wesnoth-dev
20170801 05:30:05-!- irker804 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170801 05:32:51-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170801 05:32:57-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170801 05:37:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 268 seconds]
20170801 06:05:19-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170801 06:16:41-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20170801 06:22:45< zookeeper> pydsigner, uh, the commit link is just above my comment
20170801 06:26:57-!- Bonobo [~Bonobo@129.127.113.237] has quit [Ping timeout: 240 seconds]
20170801 06:52:41-!- Kwandulin [~Kwandulin@p200300760F5F2DDA49FA6E3993677FE7.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170801 07:01:59< pydsigner> zookeeper: I was working from email
20170801 07:02:18< zookeeper> right
20170801 07:21:11-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170801 07:25:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 246 seconds]
20170801 08:11:35-!- Duthlet [~Duthlet@dslb-188-101-088-243.188.101.pools.vodafone-ip.de] has joined #wesnoth-dev
20170801 08:29:45-!- Bonobo [~Bonobo@202.168.58.116] has joined #wesnoth-dev
20170801 09:09:26-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170801 09:13:52-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170801 09:33:15-!- Duthlet [~Duthlet@dslb-188-101-088-243.188.101.pools.vodafone-ip.de] has quit [Ping timeout: 240 seconds]
20170801 09:59:55-!- Kwandulin [~Kwandulin@p200300760F5F2DDA49FA6E3993677FE7.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170801 10:12:34-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20170801 10:24:23-!- Duthlet [~Duthlet@dslb-188-101-088-243.188.101.pools.vodafone-ip.de] has joined #wesnoth-dev
20170801 10:58:01-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170801 11:00:27-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20170801 11:02:18-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 258 seconds]
20170801 11:13:44-!- Kwandulin [~Kwandulin@p200300760F5F2DDA49FA6E3993677FE7.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170801 12:31:51< matthiaskrgr> hmm
20170801 12:32:17< matthiaskrgr> did someone already check wesnoth with clang analyzer? :)
20170801 12:33:55< JyrkiVesterinen> I recall that you ran clang analysis a while back and we fixed some issues it found.
20170801 12:34:14< matthiaskrgr> oh was it clang analyzer?
20170801 12:34:20< matthiaskrgr> I know I ran cppcheck 
20170801 12:34:43< JyrkiVesterinen> Oh, it was indeed cppcheck.
20170801 12:36:21-!- Kwandulin [~Kwandulin@p200300760F5F2DDA49FA6E3993677FE7.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170801 12:36:32< matthiaskrgr> ok this is gonna take some time... 
20170801 12:46:19-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170801 12:50:52-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170801 13:02:31-!- Greg_Boggs[m] [gregboggsm@gateway/shell/matrix.org/x-uopgfrerefmyzczi] has quit [Ping timeout: 246 seconds]
20170801 13:03:58-!- ChipmunkV[m] [chipmunkvm@gateway/shell/matrix.org/x-nlhxobgqgrybhsby] has quit [Ping timeout: 264 seconds]
20170801 13:41:16-!- Bonobo [~Bonobo@202.168.58.116] has quit [Ping timeout: 260 seconds]
20170801 13:42:42-!- Greg_Boggs[m] [gregboggsm@gateway/shell/matrix.org/x-bnngshgjkgcmadmn] has joined #wesnoth-dev
20170801 13:54:50-!- ChipmunkV[m] [chipmunkvm@gateway/shell/matrix.org/x-xptibfrpojcqmpmk] has joined #wesnoth-dev
20170801 13:58:47-!- Kwandulin [~Kwandulin@p200300760F5F2DDA49FA6E3993677FE7.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170801 14:19:20< matthiaskrgr> hm
20170801 14:19:29< matthiaskrgr> looks like the actual report html page could not be generated 
20170801 14:19:39< matthiaskrgr> but I got the messages in form of compiler warnings
20170801 14:26:41-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20170801 14:34:30-!- Duthlet [~Duthlet@dslb-188-101-088-243.188.101.pools.vodafone-ip.de] has quit [Ping timeout: 240 seconds]
20170801 14:38:41-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev
20170801 14:38:53-!- Duthlet [~Duthlet@dslb-188-106-144-202.188.106.pools.vodafone-ip.de] has joined #wesnoth-dev
20170801 14:53:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170801 15:03:13-!- Kwandulin [~Kwandulin@p200300760F5F2DDA49FA6E3993677FE7.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170801 15:05:37-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has quit [Remote host closed the connection]
20170801 15:20:45-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20170801 15:31:45-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170801 15:39:33-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170801 15:40:06-!- gfgtdf [~chatzilla@x4e32b12d.dyn.telefonica.de] has joined #wesnoth-dev
20170801 15:52:16-!- Kwandulin [~Kwandulin@p200300760F5F2DDA49FA6E3993677FE7.dip0.t-ipconnect.de] has quit [Ping timeout: 246 seconds]
20170801 15:52:30-!- Kwandulin [~Kwandulin@p200300760F5F2D72B5D47186E5AA2417.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170801 15:56:39-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170801 16:01:57< gfgtdf> Coffee_irc: any opinion on #1875 ?
20170801 16:02:54< gfgtdf> Coffee_irc: hmm probalby wn'T comlie as-is becasue unit::set_hidden is const hmm
20170801 16:02:57< gfgtdf> won't
20170801 16:05:05< gfgtdf> now it coudl work
20170801 16:05:53-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170801 16:06:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 268 seconds]
20170801 16:53:42-!- travis-ci [~travis-ci@ec2-54-81-146-210.compute-1.amazonaws.com] has joined #wesnoth-dev
20170801 16:53:43< travis-ci> gfgtdf/wesnoth#909 (fix_1565 - 3a150d3 : gfgtdf): The build failed.
20170801 16:53:43< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/259836383
20170801 16:53:43-!- travis-ci [~travis-ci@ec2-54-81-146-210.compute-1.amazonaws.com] has left #wesnoth-dev []
20170801 16:59:03-!- Kwandulin [~Kwandulin@p200300760F5F2D72B5D47186E5AA2417.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170801 17:08:23-!- horrowind [~Thunderbi@p2003008E6C0B264D964452FFFE0220ED.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170801 17:13:43-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170801 17:14:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170801 17:28:43-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170801 17:29:19-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170801 17:30:58-!- Coffee_irc [~david@202.168.58.116] has quit [Ping timeout: 246 seconds]
20170801 17:31:47-!- Kwandulin [~Kwandulin@p200300760F5F2D72B5D47186E5AA2417.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170801 17:32:58-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170801 17:33:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170801 17:40:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170801 17:41:15-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170801 17:42:03-!- Kwandulin [~Kwandulin@p200300760F5F2D72B5D47186E5AA2417.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170801 17:42:40-!- Kwandulin [~Kwandulin@p200300760F5F2D72B5D47186E5AA2417.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170801 17:44:49-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170801 17:46:15-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170801 17:49:23-!- boucman [~rosen@221.86.207.77.rev.sfr.net] has joined #wesnoth-dev
20170801 17:51:33-!- boucman [~rosen@221.86.207.77.rev.sfr.net] has quit [Changing host]
20170801 17:51:34-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170801 17:53:16-!- Coffee_irc [~david@14-203-55-103.tpgi.com.au] has joined #wesnoth-dev
20170801 17:58:15-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170801 18:00:25-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170801 18:02:35-!- flowerhack__ [uid6775@gateway/web/irccloud.com/x-hnwohferenvevgcf] has joined #wesnoth-dev
20170801 18:07:39-!- Kwandulin [~Kwandulin@p200300760F5F2D72B5D47186E5AA2417.dip0.t-ipconnect.de] has quit [Quit: [endlevel]]
20170801 18:10:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170801 18:14:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170801 18:14:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170801 18:14:35-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170801 18:34:10< Ravana_> https://wiki.wesnoth.org/LuaWML/Events#on_event.lua priority?
20170801 18:41:03< gfgtdf> Ravana_: defined the order in which the are exexzted
20170801 18:41:06< gfgtdf> they*
20170801 18:42:31< gfgtdf> Ravana_: it's optional though, unless you need to be executed before/after another known event it should be empty.
20170801 18:57:19-!- travis-ci [~travis-ci@ec2-54-162-207-198.compute-1.amazonaws.com] has joined #wesnoth-dev
20170801 18:57:20< travis-ci> gfgtdf/wesnoth#911 (fix_1565 - 9f354ea : gfgtdf): The build has errored.
20170801 18:57:20< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/259864887
20170801 18:57:20-!- travis-ci [~travis-ci@ec2-54-162-207-198.compute-1.amazonaws.com] has left #wesnoth-dev []
20170801 19:01:20-!- Greg_Boggs[m] [gregboggsm@gateway/shell/matrix.org/x-bnngshgjkgcmadmn] has quit [Quit: idle]
20170801 19:49:10-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170801 19:55:20-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170801 19:58:40< zookeeper> gfgtdf, hopefully you'll fix that vialos typo when merging
20170801 20:01:10< gfgtdf> yes i will
20170801 20:01:27< gfgtdf> zookeeper: any other opinion on that?
20170801 20:01:57< zookeeper> i don't know that part of the code, whatever it is
20170801 20:03:13< gfgtdf> its unit.xpp and  actions/move.xpp
20170801 20:08:19< gfgtdf> hmm #1857 is harder to fix than i though
20170801 20:10:51-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170801 20:19:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170801 20:29:10< Coffee_irc> gfgtdf: this is for the lua/movement animation issue?
20170801 20:29:21< gfgtdf> Coffee_irc: yes
20170801 20:29:27< Coffee_irc> hi
20170801 20:29:50< Coffee_irc> all I know is it needs to be fixed :P
20170801 20:30:07< Coffee_irc> I did all the rest of the problems and this remains
20170801 20:30:39< Coffee_irc> it is a bit wierd how it was done from the start with this tracking thing
20170801 20:31:05< Coffee_irc> I think it could be solved by adding another tracking variable
20170801 20:31:13< Coffee_irc> to replicate what happened before
20170801 20:31:25< Coffee_irc> this would be the easiest, but maybe a cludge solution
20170801 20:31:35< gfgtdf> Coffee_irc: how woudl that work?
20170801 20:31:43< Coffee_irc> however it did before
20170801 20:31:51< gfgtdf> before it casues laggy anomations
20170801 20:31:55< Coffee_irc> basically this is all about when to reset the animatinos
20170801 20:31:58< Coffee_irc> no
20170801 20:32:06< Coffee_irc> all the other issues are fixed separately
20170801 20:32:10< Coffee_irc> except maybe frame rate
20170801 20:32:25< Coffee_irc> should be no "laggy" movments or attacks now
20170801 20:32:41< gfgtdf> mybe laggy wasn't the corerct word
20170801 20:32:56< Coffee_irc> the only issue is the animation is reset
20170801 20:33:00< Coffee_irc> on movement
20170801 20:33:06< Coffee_irc> and you see the wrong frame
20170801 20:33:10< Coffee_irc> but it is smooth
20170801 20:33:34< gfgtdf> Coffee_irc: but ypu still doidnt explain what you mean by other tracking variable
20170801 20:33:52-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Remote host closed the connection]
20170801 20:34:09< Coffee_irc> it is non-obvious what that whole tracking thing does
20170801 20:34:48< Coffee_irc> as it is passed on to a function that passes to the 3rd spot of another function that says to restart the animation from the start_frame
20170801 20:35:07< Coffee_irc> all that needs to happen is that it is true for the start of a movement
20170801 20:35:15< Coffee_irc> and false when the movement has finished
20170801 20:35:23< Coffee_irc> and same for attacks/etc.
20170801 20:35:40< Coffee_irc> now the movement can be interrupted
20170801 20:35:44< Coffee_irc> say by ambush
20170801 20:35:51< Coffee_irc> and then it needs to start again with true
20170801 20:36:03< Coffee_irc> and set false until finished
20170801 20:36:33< Coffee_irc> that's it
20170801 20:37:33< Coffee_irc> a value of true will restart the animation from the "start_frame"
20170801 20:38:24< gfgtdf> "that says to restart the animation from the start_frame" from how i read the code this is wrong, i think the main reason of the tird parmater is _not_ to restart the animation, it's just to update the fake_unit that is used to diplay the unit for possible changes done by wml. 'restarting' is if i underood it correclty just a unwanted consequnce of resetting the unit.
20170801 20:38:49< Coffee_irc> yes, you are likely right about the details
20170801 20:39:12< Coffee_irc> but all that matters to fix the bug is supply the correct true/false values across
20170801 20:39:47< gfgtdf> yes that's what my pr is about.
20170801 20:39:58< Coffee_irc> just to say as well this has no impact on the position of the unit as it moves
20170801 20:40:58< Coffee_irc> oh ok
20170801 20:41:02< Coffee_irc> I can test the pr
20170801 20:41:06< Coffee_irc> haven't done this yet
20170801 20:41:18< gfgtdf> Coffee_irc: that'D be nice
20170801 20:41:20< gfgtdf> that'd
20170801 20:43:23< gfgtdf> Coffee_irc: but my question also about where you know there is maybe already something like the appearance_changed_ i added, i don't know the unit_animaction_component class but i don't want to add a dublicated variable for stuff that is already there.
20170801 20:43:43< Coffee_irc> there isn't one
20170801 20:43:47< Coffee_irc> I'm pretty sure
20170801 20:43:50< gfgtdf> ok
20170801 20:44:03< Coffee_irc> this is why the problem in the first place
20170801 20:49:57< Coffee_irc> wow, there's a lot of changes to the appearance_changed_ variable around the place in the pr
20170801 20:52:03< Coffee_irc> and it doesn't work :P
20170801 20:53:19< gfgtdf> hmm does it go away i you just always pass 'false' as third parmater to animator.proceed_to at move.cpp ?
20170801 20:54:25< gfgtdf> Coffee_irc: (replace `move_it_->appearance_changed()` with just `false`)
20170801 20:54:27< Coffee_irc> all I am testing with is just any map with a drake glider (animation acceleration off) and moving the unit
20170801 20:54:44< Coffee_irc> yes
20170801 20:54:50< Coffee_irc> it works with false being passes
20170801 20:54:53< Coffee_irc> *passed
20170801 20:55:15< Coffee_irc> bascially most of the time you want false to be passed
20170801 20:55:25< Coffee_irc> only at the start of a movement do you want true
20170801 20:55:41< Coffee_irc> and then it must be false for the remained of the movement/attack
20170801 20:55:48< Coffee_irc> *remainder
20170801 20:56:28< gfgtdf> you want 'true' whenever the unit has changed
20170801 20:56:41< Coffee_irc> well, I think this is what happened before
20170801 20:56:48-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170801 20:56:54< gfgtdf> no it didn,t before it returned tue whenever wml was called
20170801 20:57:00< Coffee_irc> so if you were in ambush it would restart again when moving the second part
20170801 20:57:05< gfgtdf> Coffee_irc: i made a new commit please try it now
20170801 20:58:06< gfgtdf> how its that replated to ambushing? ambusing shodu jsut end the movement, anlong with the movement animation.
20170801 20:58:13< gfgtdf> should*
20170801 20:58:30< Coffee_irc> gfgtdf: where does appearance_changed_ ever become false in your commit?
20170801 20:58:53< gfgtdf> in movec.pp wirght after the animator.proceed_to  call
20170801 20:59:03< Coffee_irc> oh, ok
20170801 20:59:32-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: Going to bed]
20170801 21:00:39< Coffee_irc> ok
20170801 21:00:42< Coffee_irc> looks good
20170801 21:01:30< gfgtdf> so it works now ?
20170801 21:01:35< Coffee_irc> well...
20170801 21:01:40< Coffee_irc> from my basic test yes
20170801 21:01:59< Coffee_irc> can you wait a bit before committing it though
20170801 21:02:01< Coffee_irc> ?
20170801 21:02:33< Coffee_irc> I'd like to just go through the functions where you are setting "appearance_changed_ = true;"
20170801 21:02:44< Coffee_irc> as this is new and you might not have picked them all up
20170801 21:03:14< Coffee_irc> but yeah, could be problem fully solved :)
20170801 21:03:32< Coffee_irc> also, not sure if this also applies to attack animations
20170801 21:03:49< gfgtdf> were there also issues with the attack animation ?
20170801 21:03:52< Coffee_irc> which I think it does
20170801 21:03:55< Coffee_irc> no
20170801 21:03:59< Coffee_irc> but there could be now :P
20170801 21:04:19< gfgtdf> why that? there were not changes to that attack code
20170801 21:04:34< Coffee_irc> oh, ok
20170801 21:04:55< Coffee_irc> because it is only in move.cpp that the animation is being reset with this check
20170801 21:05:33< Coffee_irc> gfgtdf: maybe you want to name that variable you set move_appearance_changed_ instead?
20170801 21:06:21< Coffee_irc> I'll check with ambush to see this works as intended as well briefly
20170801 21:07:48< Coffee_irc> seems all good
20170801 21:09:31< Coffee_irc> it's nice to see the animation working correctly at full speed for the first time actually
20170801 21:10:29< Coffee_irc> you can see it even at 3x flappping away
20170801 21:10:48< Coffee_irc> and the horseman gallopping
20170801 21:11:27< Coffee_irc> some extra fps and you'd even make it out at 4x or 16x
20170801 21:12:38< gfgtdf> Coffee_irc: ok th for testing 
20170801 21:12:42< gfgtdf> Coffee_irc: now that i disabled the 'apperacne_changed_' set for set_hidden i wonder whether whethe rit still behaved correctly if for some reason wml/lua changed the hidden status of the unit
20170801 21:12:52< Coffee_irc> yes
20170801 21:13:34< Coffee_irc> worst case scenario now is that some side case isn't picked up
20170801 21:13:45< Coffee_irc> and the animation will play from the wrong fame at the start
20170801 21:13:54< Coffee_irc> but I don't see that happening
20170801 21:14:14< Coffee_irc> as it will be reset at the start of a movement anyway
20170801 21:15:06< Coffee_irc> as the end state of the animation should be the same as the start state
20170801 21:15:15< Coffee_irc> for a cycle animation such as moving
20170801 21:17:21< gfgtdf> i think for nowi'll just merge that and think about that case later
20170801 21:17:40< Coffee_irc> gfgtdf: thanks for doing this
20170801 21:17:59< Coffee_irc> as I mentioned above even thee worst case scenario should be unnoticeable for players
20170801 21:18:06< Coffee_irc> this is good
20170801 21:19:37< Coffee_irc> this is probably the best I've seen the movement animations
20170801 21:19:55< Coffee_irc> which we never did justice to before properly
20170801 21:20:19-!- irker115 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170801 21:20:19< irker115> wesnoth: gfgtdf wesnoth:master 62ec3b3951bf / src/ (actions/move.cpp units/unit.cpp units/unit.hpp): Better tracking whether the unit was changed during movement. https://github.com/wesnoth/wesnoth/commit/62ec3b3951bfb7bf6331ad1e98f45ce99e5191d5
20170801 21:20:41< gfgtdf> ok lets think about mp sync stuff
20170801 21:23:32< gfgtdf> i want to fix #1857, i coudl do it easiyl by adding a wrapppper class for platurn_network_adapter, but having a class named platurn_network_adapter_adapter would be kinda ugly
20170801 21:24:51< Coffee_irc> I'm kind of thinking about whiteboard bugs myself
20170801 21:26:21< Coffee_irc> I'd like to solve issue #1592 and change the color of the line for future plans in the whiteboard to a lighter color to differentiate them from the curernt move plans
20170801 21:27:46< gfgtdf> sounds liek a good idea
20170801 21:27:52< Coffee_irc> once some of these bugs are solved like the animation bug above we might even have a pretty good 1.14.0 release
20170801 21:29:18< Coffee_irc> it's going to take me some time to solve these 2 things I think as I am also preoccupied with other things IRL
20170801 21:43:14-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20170801 21:46:41-!- travis-ci [~travis-ci@ec2-54-145-144-108.compute-1.amazonaws.com] has joined #wesnoth-dev
20170801 21:46:42< travis-ci> gfgtdf/wesnoth#912 (fix_1565 - dfaba93 : gfgtdf): The build has errored.
20170801 21:46:42< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/259938660
20170801 21:46:42-!- travis-ci [~travis-ci@ec2-54-145-144-108.compute-1.amazonaws.com] has left #wesnoth-dev []
20170801 21:46:51< vultraz_iOS>  the iOS PR passes travis
20170801 21:48:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170801 22:01:10-!- gfgtdf [~chatzilla@x4e32b12d.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 54.0.1/20170628075643]]
20170801 22:21:36-!- travis-ci [~travis-ci@ec2-54-145-144-108.compute-1.amazonaws.com] has joined #wesnoth-dev
20170801 22:21:37< travis-ci> gfgtdf/wesnoth#913 (fix_1565 - c111d14 : gfgtdf): The build has errored.
20170801 22:21:37< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/259944536
20170801 22:21:37-!- travis-ci [~travis-ci@ec2-54-145-144-108.compute-1.amazonaws.com] has left #wesnoth-dev []
20170801 22:24:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170801 22:28:10-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170801 22:30:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170801 22:33:08-!- Bonobo [~Bonobo@14-203-55-103.tpgi.com.au] has joined #wesnoth-dev
20170801 22:37:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170801 22:39:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170801 22:41:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20170801 22:44:18-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170801 22:59:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170801 22:59:48-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170801 23:03:09< vultraz_iOS> Once we reach RC stage I'm diverging master into the 1.14 branch, just a heads up. 
20170801 23:04:07-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 258 seconds]
20170801 23:11:38-!- Greg-Boggs [~greg_bogg@c-73-37-6-51.hsd1.or.comcast.net] has joined #wesnoth-dev
20170801 23:21:05-!- travis-ci [~travis-ci@ec2-54-81-141-113.compute-1.amazonaws.com] has joined #wesnoth-dev
20170801 23:21:06< travis-ci> wesnoth/wesnoth#14607 (master - 62ec3b3 : gfgtdf): The build has errored.
20170801 23:21:06< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/259953024
20170801 23:21:06-!- travis-ci [~travis-ci@ec2-54-81-141-113.compute-1.amazonaws.com] has left #wesnoth-dev []
20170801 23:24:30-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20170801 23:31:38-!- horrowind [~Thunderbi@p2003008E6C0B264D964452FFFE0220ED.dip0.t-ipconnect.de] has quit [Quit: horrowind]
20170801 23:42:24-!- Duthlet [~Duthlet@dslb-188-106-144-202.188.106.pools.vodafone-ip.de] has quit [Quit: leaving]
20170801 23:45:41-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170801 23:50:31-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
--- Log closed Wed Aug 02 00:00:02 2017