--- Log opened Sat Aug 12 00:00:15 2017
20170812 00:24:51-!- travis-ci [~travis-ci@ec2-54-211-209-2.compute-1.amazonaws.com] has joined #wesnoth-dev
20170812 00:24:52< travis-ci> wesnoth/wesnoth#14661 (master - 0fecb69 : Charles Dang): The build passed.
20170812 00:24:52< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/263692456
20170812 00:24:52-!- travis-ci [~travis-ci@ec2-54-211-209-2.compute-1.amazonaws.com] has left #wesnoth-dev []
20170812 00:43:57< celticminstrel> The wiki uses toplevel headings in a lot of pages. Why should this be disallowed all of a sudden?
20170812 01:37:23-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170812 01:49:45< shadowm> We had this discussion already.
20170812 01:50:07< shadowm> It doesn't take a huge amount of effort to fix them. (s/^=/==/; s/=$/==/;)
20170812 02:15:31-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170812 02:26:47-!- irker468 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170812 02:33:53-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170812 02:43:46-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Read error: Connection reset by peer]
20170812 02:49:35-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev
20170812 02:51:54-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170812 03:21:33-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170812 03:41:51-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170812 03:47:26< celticminstrel> Okay so... we already have a way to deprecate a Lua function and an ActionWML tag...
20170812 03:48:11< celticminstrel> Maybe there should be a way to deprecate a Lua table? Not sure if that's possible though...
20170812 03:49:10< celticminstrel> Oh, also there may be situations where certain ways of calling a function are deprecated, but the function itself remains.
20170812 03:57:13< celticminstrel> COMPLTELY RANDOM AND UNRELATED - I really dislike how Create has the buttons at the bottom while Staging has them at the top. Can't we make them both the same? I don't care which.
20170812 03:57:25< celticminstrel> Putting the Create buttons to the top is probably easier though.
20170812 04:01:29< celticminstrel> I suppose you could also make the player list a bit shorter though and put the buttons there.
20170812 04:02:20< vultraz_iOS> ?
20170812 04:02:54< celticminstrel> It's awkward to click Create and then have to cross the entire window to click I'm Ready.
20170812 04:03:11< vultraz_iOS> I don't know what you're talking about
20170812 04:03:17< vultraz_iOS> they're both in the bottom right
20170812 04:03:24< vultraz_iOS> on normal resolution
20170812 04:03:33< celticminstrel> Then it should be the case on all resolutions.
20170812 04:03:55< vultraz_iOS> true
20170812 04:03:59< vultraz_iOS> but you made it so
20170812 04:04:01< vultraz_iOS> so :P
20170812 04:04:16< celticminstrel> Hmm. Well, I suppose I could do the thing I said about the player list maybe.
20170812 04:05:16< celticminstrel> Ugh, my timer idea for TEXTINPUT events isn't going to work.
20170812 04:05:29< celticminstrel> Because as soon as you press a second key, the first one is never sent again.
20170812 04:06:57< celticminstrel> I think we're just gonna have to go back to not using TEXTINPUT for key handling.
20170812 04:07:07< celticminstrel> What was the apparent advantage of it, BTW?
20170812 04:07:47< vultraz_iOS> i don't know
20170812 04:07:51< vultraz_iOS> you were telling me
20170812 04:07:55< vultraz_iOS> :|
20170812 04:08:11< celticminstrel> Pretty sure the : hotkey was at the centre of it somehow.
20170812 04:08:21-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Remote host closed the connection]
20170812 04:08:23< vultraz_iOS> something to do with modifier keys
20170812 04:08:28< celticminstrel> Huh?
20170812 04:09:23< vultraz_iOS> we were talking about modifier keys
20170812 04:09:30< celticminstrel> What about them?
20170812 04:09:53< vultraz_iOS> i can't remember
20170812 04:09:59< vultraz_iOS> i was asking you why we needed TEXTINPUT
20170812 04:10:16< vultraz_iOS> and something something keycodes vs scancodes
20170812 04:10:30< vultraz_iOS> and i looked something up on the SDL forums
20170812 04:10:47-!- irker220 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170812 04:10:47< irker220> wesnoth: Celtic Minstrel wesnoth:master f83dcfb54951 / src/reports.cpp: Fixup improper plural in a166348f https://github.com/wesnoth/wesnoth/commit/f83dcfb549516efa29bab1f4a9dcca941a417cb6
20170812 04:10:47< irker220> wesnoth: Celtic Minstrel wesnoth:master 5c701f207b17 / src/hotkey/command_executor.cpp: Fix #1893 - inverted condition from 047120e2f https://github.com/wesnoth/wesnoth/commit/5c701f207b173f03b6abddc89d5165e20116f14a
20170812 04:10:48< vultraz_iOS> and it said something about how you can use the TEXTINPUT hack
20170812 04:11:05< celticminstrel> The trouble with the TEXTINPUT hack is there's no way to distinguish keydown and keyup.
20170812 04:12:13< vultraz_iOS> what IS the problem we're even trying to fix
20170812 04:12:15< vultraz_iOS> that's the thing
20170812 04:12:41< celticminstrel> The problem is literally that we can't distinguish between keydown and keyup for letter keys (and other similar keys).
20170812 04:12:54< celticminstrel> Which is necessary if they're bound to, for example, map scrolling.
20170812 04:13:49< vultraz_iOS> no, what is it we're doing that needs TEXTINPUT
20170812 04:15:17< vultraz_iOS> let's look at the problem again
20170812 04:15:19< vultraz_iOS> from the beginning
20170812 04:16:14< celticminstrel> I don't even remember.
20170812 04:16:23< celticminstrel> Only that it has something to do with :
20170812 04:18:27< vultraz_iOS> well we should figure out what we're doing, then
20170812 04:18:28< vultraz_iOS> :P
20170812 04:18:35< vultraz_iOS> or else we can't do it properly
20170812 04:22:05-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a45a:1241:faa:3426] has joined #wesnoth-dev
20170812 04:24:12-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev
20170812 04:28:47-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a45a:1241:faa:3426] has quit [Ping timeout: 255 seconds]
20170812 04:33:55-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170812 04:46:22< vultraz_iOS> celticminstrel: what would you think about handling end credits scrolling in a draw event callback instead of with a timer?
20170812 04:51:44-!- Kwandulin [~Kwandulin@p200300E453CC3B15595B13D6CDAE1E22.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170812 04:59:26< celticminstrel> Worth a try?
20170812 05:30:08-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170812 05:30:43-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a45a:1241:faa:3426] has joined #wesnoth-dev
20170812 05:34:50-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a45a:1241:faa:3426] has quit [Ping timeout: 240 seconds]
20170812 05:36:07-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20170812 05:49:08-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a45a:1241:faa:3426] has joined #wesnoth-dev
20170812 05:59:03-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a45a:1241:faa:3426] has quit [Remote host closed the connection]
20170812 06:08:14-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170812 06:08:15-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170812 06:19:05-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170812 06:21:48-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a45a:1241:faa:3426] has joined #wesnoth-dev
20170812 06:21:54-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170812 06:23:51-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a45a:1241:faa:3426] has quit [Remote host closed the connection]
20170812 06:24:58-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6d86:65cb:7869:a65b] has joined #wesnoth-dev
20170812 06:25:47< irker220> wesnoth: Ignacio R. Morelle wesnoth:wesmere-wmlunits 9db2ed630c4e / data/tools/ (unit_tree/helpers.py unit_tree/html_output.py unit_tree/overview.py wmlunits): wmlunits: More code clean-up https://github.com/wesnoth/wesnoth/commit/9db2ed630c4e56b94ce2d8421816392a45ee4ba2
20170812 06:25:50< irker220> wesnoth: Ignacio R. Morelle wesnoth:wesmere-wmlunits 5bcaaaf9f7af / data/tools/ (unit_tree/style.css wmlunits): wmlunits: style.css is not used anymore https://github.com/wesnoth/wesnoth/commit/5bcaaaf9f7af5cd84f9ff43618df08ca73650b83
20170812 06:26:09-!- mode/#wesnoth-dev [+o shadowm] by ChanServ
20170812 06:26:18-!- mode/#wesnoth-dev [+qz irker*!*@*] by shadowm
20170812 06:29:08-!- mode/#wesnoth-dev [-qoz irker*!*@* shadowm] by shadowm
20170812 06:38:50-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6d86:65cb:7869:a65b] has quit [Remote host closed the connection]
20170812 06:39:47-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6d86:65cb:7869:a65b] has joined #wesnoth-dev
20170812 06:49:58< shadowm> elias: Does anything generate units.wesnoth.org/index.html atm?
20170812 06:50:28< shadowm> Or is it just a hand-crafted document?
20170812 07:22:48< irker220> wesnoth: Ignacio R. Morelle wesmere:master 1129536130cb / static/ (docroot/addons/index.xml template_inside.xsl): static: Allow documents to define subsite homes to prepend to the navbar https://github.com/wesnoth/wesmere/commit/1129536130cb615b2b5797b18fb15e8db0c998e2
20170812 07:22:49< irker220> wesnoth: Ignacio R. Morelle wesmere:master f9967253da6a / static/template_inside.xsl: static: Allow embedding a custom stylesheet https://github.com/wesnoth/wesmere/commit/f9967253da6a97f29ffe46a3de81c8f8daba8c10
20170812 07:22:52< irker220> wesnoth: Ignacio R. Morelle wesmere:master 11a6f0c6b4bb / static/docroot/addons/index.xml: static: Remove some extraneous whitespace https://github.com/wesnoth/wesmere/commit/11a6f0c6b4bbd71fc2f81c2d0fecfdccb65835b0
20170812 07:53:22< irker220> wesnoth: Charles Dang wesnoth:master 721e2d7e9e24 / src/units/unit.cpp: Unit: fixed hp and xp colors having 0 alpha https://github.com/wesnoth/wesnoth/commit/721e2d7e9e24001e722e3a7d7df7955d89f72cdf
20170812 07:53:25< irker220> wesnoth: Charles Dang wesnoth:master ec042a4f4ef1 / src/units/ (animation.cpp animation_component.cpp drawer.cpp frame.cpp): Use shared_ptr::reset for clearing halo handlers https://github.com/wesnoth/wesnoth/commit/ec042a4f4ef10c574dbf46e41d3793edb64112c6
20170812 07:53:28< irker220> wesnoth: Charles Dang wesnoth:master 5364c50ee80d / src/font/ (text.cpp text.hpp): Font/Pango Text: minor cleanup https://github.com/wesnoth/wesnoth/commit/5364c50ee80d01f61adc6d495c93b324e98c9b0d
20170812 08:07:30-!- mjs-de [~mjs-de@x4e3064c7.dyn.telefonica.de] has joined #wesnoth-dev
20170812 08:14:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170812 08:27:34< vultraz_iOS> shadowm: could you silence irker again
20170812 08:31:48-!- mode/#wesnoth-dev [+o vultraz_iOS] by ChanServ
20170812 08:33:38-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6d86:65cb:7869:a65b] has quit [Remote host closed the connection]
20170812 08:36:55-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170812 08:39:00<@vultraz_iOS> ah fuck it, he's offline
20170812 08:39:20< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 7a7184451fe6 / src/sdl/window.cpp: SDL/Window: set render scaling method to linear https://github.com/wesnoth/wesnoth/commit/7a7184451fe661920b785ce301a06cf995c470ae
20170812 08:39:23-!- mode/#wesnoth-dev [-o vultraz_iOS] by vultraz_iOS
20170812 08:39:23< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering c6b5f049f7db / src/video.cpp: Video: enabled accelerated rendering with texture target access https://github.com/wesnoth/wesnoth/commit/c6b5f049f7db114663e36127ccd0b007ae2e68c3
20170812 08:39:26< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 8d56f1ebd768 / / (7 files in 4 dirs): GUI2/Canvas: refactor surface blitting out of drawing routines https://github.com/wesnoth/wesnoth/commit/8d56f1ebd768dc02167d7c5fac38914f3671b561
20170812 08:39:29< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 1da654145140 / src/gui/widgets/window.cpp: GUI2/Window: properly re-implement draw and restore code https://github.com/wesnoth/wesnoth/commit/1da65414514058ab6b6c7abdb60194b8d2819865
20170812 08:39:32< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 514aa409f5cd / src/ (47 files in 5 dirs): GUI2: removed dirty widget interface https://github.com/wesnoth/wesnoth/commit/514aa409f5cd3ed8be71375896292b232bf6b470
20170812 08:39:35< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering faca87943f5a / src/gui/widgets/ (window.cpp window.hpp): GUI2/Window: removed restore flag and restorer surface https://github.com/wesnoth/wesnoth/commit/faca87943f5a79b58fd07fb4d950588f670221a5
20170812 08:39:38< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 1005a824606f / src/gui/ (core/canvas.cpp core/canvas.hpp widgets/panel.cpp widgets/styled_widget.cpp): GUI2/Canvas: renamed blit function and removed surface argument https://github.com/wesnoth/wesnoth/commit/1005a824606f4fbb638d5b78062e20e1231609bc
20170812 08:39:41< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering aa4755c804f1 / src/gui/widgets/ (31 files): GUI2: removed framebuffer code from draw impl functions https://github.com/wesnoth/wesnoth/commit/aa4755c804f1e74c5932d8d7a7e42db30e4d35bd
20170812 08:39:44< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 8bc14a85a5d4 / src/font/text.cpp: Hack to get text to render right https://github.com/wesnoth/wesnoth/commit/8bc14a85a5d43f8dc618aeb6e993c7796a7a414c
20170812 08:39:47< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 2c53230a7b29 / src/gui/ (6 files in 2 dirs): GUI2: refactored viewport setting and re-added clip rect setting https://github.com/wesnoth/wesnoth/commit/2c53230a7b29f6f51a6020f7ae1a31024b512bba
20170812 08:39:50< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering a2b5d7a32b60 / src/gui/ (core/event/handler.cpp dialogs/lua_interpreter.cpp): Fixed some unused parameter warnings https://github.com/wesnoth/wesnoth/commit/a2b5d7a32b605d44a882cb56e06215582cb0b5bb
20170812 08:39:53< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 570c6a6a5292 / src/gui/widgets/window.cpp: Removed some debug output https://github.com/wesnoth/wesnoth/commit/570c6a6a52925a10d27e4387d235cd6a8ee105f1
20170812 08:39:56< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 015618cfa80e / src/gui/core/canvas.cpp: GUI2/Canvas: removed surface_lock objects https://github.com/wesnoth/wesnoth/commit/015618cfa80ec04008bba2cdfbf423c5db3ce49b
20170812 08:39:59< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering b1a166f5a42e / src/gui/core/event/handler.cpp: Small code simplification https://github.com/wesnoth/wesnoth/commit/b1a166f5a42e25473d81eb6d5225a7a123bcfebe
20170812 08:40:02< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering c050249864a8 / src/gui/core/canvas.cpp: GUI2/Canvas: add error logging if canvas texture creation fails https://github.com/wesnoth/wesnoth/commit/c050249864a882bae11626a8c1e814d5c1039771
20170812 08:40:05< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 55bcd0255fb0 / / (11 files in 7 dirs): Added SDL_Texture wrapper class and some utility functions https://github.com/wesnoth/wesnoth/commit/55bcd0255fb0724d50d4ad7cba20aa83c75d43b1
20170812 08:40:08< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering cee04cc080ca / src/gui/widgets/minimap.cpp: GUI2/Minimap: quick fix to get the minimap drawing again https://github.com/wesnoth/wesnoth/commit/cee04cc080cae5c18bbb5c5f199eb8211e8715c3
20170812 08:40:11< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering d7723e71c5f5 / / (5 files in 3 dirs): Moved renderer RAII helpers to their own file and added ones for clip rect and v https://github.com/wesnoth/wesnoth/commit/d7723e71c5f56d80cec06bbd7059873930f646d1
20170812 08:40:14< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 30686f1824d7 / src/video.cpp: CVideo: convert blit_surface to handle input as textures instead of blitting to  https://github.com/wesnoth/wesnoth/commit/30686f1824d7bec6664b24de09b9117da9de8233
20170812 08:40:17< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering ecfe7ba2bd36 / src/ (gui/widgets/widget.cpp sdl/rect.cpp): Use get_renderer() over *get_window() https://github.com/wesnoth/wesnoth/commit/ecfe7ba2bd360c4f0ee12e8c80fc984e75d73aa4
20170812 08:40:20< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering e055148024f7 / src/ (image.cpp image.hpp): Added a texture cache https://github.com/wesnoth/wesnoth/commit/e055148024f7f4ca2242d8a2e7245c41adeea38a
20170812 08:40:23< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 8243931ee8f6 / src/sdl/ (texture.cpp texture.hpp): Texture: converted internal handling to use a shared_ptr https://github.com/wesnoth/wesnoth/commit/8243931ee8f694b17b0cace419efed1fdeff6eaf
20170812 08:40:26< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 41a8f6732398 / src/gui/core/canvas.cpp: GUI2/Canvas: disable surface manip w/ accelerated rendering for stretch resize m https://github.com/wesnoth/wesnoth/commit/41a8f67323980394f11b5fde98f9018762db5a75
20170812 08:40:29< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering e054e5c8b27f / src/ (display.cpp sdl/utils.cpp sdl/utils.hpp): Enabled drawing of minimap in-game https://github.com/wesnoth/wesnoth/commit/e054e5c8b27f3f69c4599218c7d0192943772ccd
20170812 08:40:32< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 6fea8660da00 / src/ (7 files in 4 dirs): Moved GUI2's per-frame drawing trigger to global scope https://github.com/wesnoth/wesnoth/commit/6fea8660da00bad01255eb14e01d1aaf942445f5
20170812 08:40:35< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 3fa57d45f5ce / src/gui/widgets/minimap.cpp: GUI2/Miniap: draw any provided canvas data before the minimap https://github.com/wesnoth/wesnoth/commit/3fa57d45f5cedcd8dfe34e6878034d803e5e8734
20170812 08:40:38< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering bfb25386e10f / / (7 files in 6 dirs): Added static prototype for GUI2 in-game theme https://github.com/wesnoth/wesnoth/commit/bfb25386e10fd62e1d92ec40bd3709441ca16ba4
20170812 08:40:41< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 68b6547e0642 / / (19 files in 6 dirs): Decoupled drawing buffer code from display class https://github.com/wesnoth/wesnoth/commit/68b6547e06421beaa37af56ba77e365deffcb221
20170812 08:40:44< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering b7a263f8ecf8 / src/ (13 files in 6 dirs): Initial refactor for main-screen accelerated rendering https://github.com/wesnoth/wesnoth/commit/b7a263f8ecf82fca64f34be5f6b10011c271522b
20170812 08:40:47< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering dbac9db359a1 / src/gui/core/event/handler.cpp: GUI2: moved event handling into main context https://github.com/wesnoth/wesnoth/commit/dbac9db359a1493bf59b94299f64f43840e09f41
20170812 08:40:50< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 23891e721eb4 / src/units/drawer.cpp: Draw units under bars/orbs/etc https://github.com/wesnoth/wesnoth/commit/23891e721eb4a5a188c8d685329a43f5945529a1
20170812 08:40:53< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 23b0fdb9512f / src/ (video.cpp video.hpp): Video: expand render_copy to take flip arguments https://github.com/wesnoth/wesnoth/commit/23b0fdb9512f7bcb5269686686b763634fc1e35d
20170812 08:40:56< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 8dc4be673568 / src/gui/core/canvas.cpp: GUI2/Canvas: made use of CVideo::render_copy https://github.com/wesnoth/wesnoth/commit/8dc4be673568d92ad03917a380ea9a6efc030850
20170812 08:40:59< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering def99257725d / src/play_controller.cpp: Fixed play_controller not joining current event context https://github.com/wesnoth/wesnoth/commit/def99257725d5f7fecaa7dde4880af1e1b613d04
20170812 08:41:02< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering a376afa4dbb9 / src/units/drawer.cpp: Uint: fixed bad bar alpha on unit mouseover https://github.com/wesnoth/wesnoth/commit/a376afa4dbb9b0a64ab96de76b52ad3d587d71b0
20170812 08:41:05< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering e937e5609de9 / src/ (13 files in 4 dirs): Another huge chunk of progress https://github.com/wesnoth/wesnoth/commit/e937e5609de90bb041af47ea1c5fdc85dc20e208
20170812 08:41:08< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 9307697bde29 / src/ (13 files in 4 dirs): Removed draw() calls into the display class https://github.com/wesnoth/wesnoth/commit/9307697bde29f9ecdb42810735742991f3439df1
20170812 08:41:11< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 98720b9bb22b / src/ (events.cpp video.cpp video.hpp): Video: (almost) completely removed framebuffer surface https://github.com/wesnoth/wesnoth/commit/98720b9bb22b4aa157e75d7c5559b089e8279412
20170812 08:41:14< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 195aa9f1c38e / src/ (tests/utils/fake_display.cpp video.cpp video.hpp): Video: removed unused arguments from make_test_fake https://github.com/wesnoth/wesnoth/commit/195aa9f1c38ee1cf5b8f664c5a7abcc8833d5094
20170812 08:41:17< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering cf90f0a0a0fc / src/ (display.cpp display.hpp game_display.cpp units/drawer.cpp): Got a bunch more components drawing https://github.com/wesnoth/wesnoth/commit/cf90f0a0a0fc61553896aa585c3f5e72cf455a63
20170812 08:41:20< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 1cbc71e485f3 / src/display.cpp: Enabled more stuff drawing https://github.com/wesnoth/wesnoth/commit/1cbc71e485f376a55ee650226798075ffd1c0579
20170812 08:41:23< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering ab5725303ce0 / src/ (5 files in 2 dirs): Removed most call to raise_draw_event https://github.com/wesnoth/wesnoth/commit/ab5725303ce0f45a1f36d66bca88cd63465edd9f
20170812 08:41:26< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering ce33384068ec / src/units/drawer.cpp: Units: fixed bad HP/XP bars fill rect offset https://github.com/wesnoth/wesnoth/commit/ce33384068ec4c5e9275994a3be4fd27f6a4ed48
20170812 08:41:29< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 8049eade8cf6 / src/gui/core/canvas.cpp: GUI2/Canvas: fixed mirrored images being flipped on the wrong axis. https://github.com/wesnoth/wesnoth/commit/8049eade8cf6f429d0de76a1a9ec3c11724fd5a0
20170812 08:41:32< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 87ac6ce301fe / src/display.cpp: Cleaned up the implementation of display::scroll() https://github.com/wesnoth/wesnoth/commit/87ac6ce301fea79eb26e38a307b800a5b9e6cc6c
20170812 08:41:35< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 092d6566af17 / src/actions/move.cpp: Removed an unused variable https://github.com/wesnoth/wesnoth/commit/092d6566af17f1e73575b305b0abde92ec4ddf21
20170812 08:41:38< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 68a97138ce80 / src/ (image.cpp image.hpp): Extended implementation of the texture cache https://github.com/wesnoth/wesnoth/commit/68a97138ce806e75beb5c29defddce0115126efb
20170812 08:41:41< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering f1cdc98ab5bd / src/display.cpp: Trim ToD images to hex https://github.com/wesnoth/wesnoth/commit/f1cdc98ab5bd48cb2e8f27c47a3118f15c557004
20170812 08:41:44< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering ee099f09f6a5 / src/display.cpp: Temporarily disable map label position update on map scroll https://github.com/wesnoth/wesnoth/commit/ee099f09f6a5002360c6941df7dad86fcc64ce40
20170812 08:41:47< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering a3b8f23aaa55 / src/gui/core/ (canvas.cpp canvas_private.hpp): GUI2/Canvas: refactor surface use out of image rendering https://github.com/wesnoth/wesnoth/commit/a3b8f23aaa55559b4528468f97ca2672f3e3da96
20170812 08:41:50< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 0f8b06368b4e / / (13 files in 6 dirs): Some initial code (disabled for now) for setting up an OGL context https://github.com/wesnoth/wesnoth/commit/0f8b06368b4e149e2b3a12922cb5306f4a2e8fc9
20170812 08:41:53< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 7cb73db92ae3 / src/ (image.cpp image.hpp): Allowed IPFs to work again when using the texture cache https://github.com/wesnoth/wesnoth/commit/7cb73db92ae3c6442cecd2d9f5b228872b16a5be
20170812 08:41:56< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering e12200d17ec3 / src/gui/core/canvas.cpp: GUI2/Canvas: set clip rect when tiling images https://github.com/wesnoth/wesnoth/commit/e12200d17ec3e5a162ad6c5808875cc6a2d47e23
20170812 08:41:59< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 83b9625fc05b / data/gui/widget/window_default.cfg: GUI2/Window: draw background image first instead of last https://github.com/wesnoth/wesnoth/commit/83b9625fc05b86445bc0546f98e14403baa7b97f
20170812 08:42:02< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 7ffa72440177 / src/gui/dialogs/ (outro.cpp story_viewer.cpp): GUI2: removed some unnecessary calls to canvas::set_is_dirty https://github.com/wesnoth/wesnoth/commit/7ffa724401774acb2bb620006d24bae626f53b04
20170812 08:42:05< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 397051a920a5 / src/sdl/ (window.cpp window.hpp): SDL/Window: removed pixel format member and promoted renderer info wholly to cla https://github.com/wesnoth/wesnoth/commit/397051a920a5f0b2d37b7848774988ccd85a77c1
20170812 08:42:08< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 1a9b8f1a22e4 / src/sdl/ (render_utils.hpp texture.cpp): Added some inline wrappers for SDL_SetTexture* functions https://github.com/wesnoth/wesnoth/commit/1a9b8f1a22e472a75f951a947560a6effd0e31ac
20170812 08:42:11< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 97fe2c439075 / src/ (display.cpp game_display.cpp halo.cpp halo.hpp): Refactored halo code to bring it in line with new drawing methods https://github.com/wesnoth/wesnoth/commit/97fe2c4390757217ca3f8116baa67fbcf75216b8
20170812 08:42:14< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 88eff03e0dc9 / src/units/frame.cpp: Restored alpha handling of unit frames https://github.com/wesnoth/wesnoth/commit/88eff03e0dc935cc4d05b6dd70c733559543c9cc
20170812 08:42:17< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering bfcc6bf7f454 / src/gui/ (5 files in 3 dirs): GUI2/Window: removed empty undraw() function https://github.com/wesnoth/wesnoth/commit/bfcc6bf7f454a94e1cf38b766ce424064338f602
20170812 08:42:20< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering ceedc5cb8b70 / src/ (gui/core/canvas.cpp image.cpp image.hpp sdl/render_utils.hpp sdl/window.cpp): Split texture caches into linear and NN scaled versions https://github.com/wesnoth/wesnoth/commit/ceedc5cb8b706341070992c1a081b4c3c987480f
20170812 08:42:23< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 8dd72e2fbff7 / src/ (font/text.cpp font/text.hpp gui/core/canvas.cpp gui/widgets/styled_widget.hpp): Added a getter for a static pango_text object https://github.com/wesnoth/wesnoth/commit/8dd72e2fbff7b68841f2e0216c3eb4c4ae9ed953
20170812 08:42:26< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering f29a9ca910c0 / / (12 files in 5 dirs): Port floating textbox/command console to GUI2 https://github.com/wesnoth/wesnoth/commit/f29a9ca910c050dc36856a6e8ec64ae03817ca4c
20170812 08:42:29< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering c420971693a4 / src/floating_label.cpp: Floating Label: formatting update https://github.com/wesnoth/wesnoth/commit/c420971693a40605c00670ffab3fc182c9ecef15
20170812 08:42:32< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering d498f54ebdb4 / src/ (floating_label.cpp floating_label.hpp tooltips.cpp): Refactored floating_label implementation https://github.com/wesnoth/wesnoth/commit/d498f54ebdb40dc8466668470133de169ec3354c
20170812 08:42:35< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 246ae97fcd80 / src/display.cpp: Display: restrict render clip rect setter to map drawing scope only https://github.com/wesnoth/wesnoth/commit/246ae97fcd80549a323947187bea2e85ba219a56
20170812 08:42:38< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering d8f6c313c63e / src/image.cpp: Improved console output on IPF fail https://github.com/wesnoth/wesnoth/commit/d8f6c313c63ed485c544ac645e37bb04e6a57f43
20170812 08:42:41< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 9d38ce6edc7d / src/ (8 files in 3 dirs): Refactor and cleanup of the drawing dispatch system https://github.com/wesnoth/wesnoth/commit/9d38ce6edc7dc503a0c2a21fc75b1288297cf3ed
20170812 08:42:44< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 0768973520b4 / / (22 files in 6 dirs): Renamed drawing_buffer to drawing_queue https://github.com/wesnoth/wesnoth/commit/0768973520b4166faf4061e6c53cc9510014976f
20170812 08:42:47< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 9393c9951483 / src/display.cpp: Fixed halos drawing over fog and shroud (fixes #1406) https://github.com/wesnoth/wesnoth/commit/9393c9951483ecf8c43b39a834f2501d82d68142
20170812 08:42:50< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 95df21068153 / src/display.cpp: Restore map label position anchoring https://github.com/wesnoth/wesnoth/commit/95df2106815368764059404e293005f2b8f9f0ea
20170812 08:42:53< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 2c308addf318 / src/sdl/window.cpp: SDL/Window: throw exception if render-to-texture is not enabled https://github.com/wesnoth/wesnoth/commit/2c308addf3186631b469bafdda2a506eecc50eb4
20170812 08:42:56< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 1aa94cc4a910 / src/ (42 files in 10 dirs): Display: removed all the invalidated locations code https://github.com/wesnoth/wesnoth/commit/1aa94cc4a910e5f4ff8a294a35b303e94ea82a7d
20170812 08:42:59< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 99faf30ff674 / src/ (7 files in 4 dirs): Removed animation invalidation code https://github.com/wesnoth/wesnoth/commit/99faf30ff674edd9323459b2778e5a85f1bc52fa
20170812 08:43:02< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering c2bc7c5144cd / src/ (11 files in 7 dirs): Display: removed old drawing code and external draw calls https://github.com/wesnoth/wesnoth/commit/c2bc7c5144cd121d29ef6fbf917f39912be949eb
20170812 08:43:05< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering a011eb0e69a2 / src/units/ (drawer.cpp frame.cpp): Fixed some bad drawing offsets and sizes when zoomed in https://github.com/wesnoth/wesnoth/commit/a011eb0e69a21ecc63de10db2218c732a183578d
20170812 08:43:08< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering bc36f6276bcc / src/sdl/ (texture.cpp texture.hpp): SDL/Texture: made info struct take a texture ptr directly https://github.com/wesnoth/wesnoth/commit/bc36f6276bcce63026b89da30d83f0e022b06efd
20170812 08:43:11< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering cdde28469a48 / src/ (6 files in 2 dirs): Display: work on refactoring the main drawing system https://github.com/wesnoth/wesnoth/commit/cdde28469a48810fb4a265a162b5c403851bc001
20170812 08:43:14< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering fd745b8cfa05 / src/video.cpp: Video: don't render null textures https://github.com/wesnoth/wesnoth/commit/fd745b8cfa055a679cc2234846c1039e3eb4c33a
20170812 08:43:17< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering f47dac32e794 / src/ (8 files in 2 dirs): Removed external calls to display::redraw_everything() https://github.com/wesnoth/wesnoth/commit/f47dac32e7947408d9742a9b452195e026f4248f
20170812 08:43:20< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering acc5fb00465f / src/ (8 files in 5 dirs): Use CVideo singleton instead of resources::screen->video() https://github.com/wesnoth/wesnoth/commit/acc5fb00465f20df04c7d2bebea65494c7d54024
20170812 08:43:23< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 4c7510b83ff3 / src/help/help.cpp: Quick fix for crash when opening help browser https://github.com/wesnoth/wesnoth/commit/4c7510b83ff36a442ac84c6e0e50d2be63087dc3
20170812 08:43:26< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 4add8acc405b / src/ (display.cpp display.hpp): Display: header formatting and doc updates https://github.com/wesnoth/wesnoth/commit/4add8acc405bea1e29fbd06ee6f37c9ddeb57d25
20170812 08:43:29< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 34fa0ac4f2fc / src/ (display.hpp gui/core/event/handler.cpp): Marked sdl_handler::draw overrides as final https://github.com/wesnoth/wesnoth/commit/34fa0ac4f2fc085cc86375c7c17fc16551c33acd
20170812 08:43:32< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 029b648d378b / src/ (6 files): Display: cleaned up a bunch of now-unused/unnecessary members and functions https://github.com/wesnoth/wesnoth/commit/029b648d378b9dfe31d453bca432f848a83de68d
20170812 08:43:35< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 088d21d119b8 / src/display.cpp: Display: re-enable fps counter with :fps https://github.com/wesnoth/wesnoth/commit/088d21d119b8ad7b13eebbb80093029fea02d03b
20170812 08:43:38< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering d6473b84dfbb / src/gui/core/canvas.cpp: GUI2/Canvas: don't skip drawing if canvas texture is null https://github.com/wesnoth/wesnoth/commit/d6473b84dfbbbf213855fac813277cd8f87e89e8
20170812 08:43:41< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering cd16243d0e00 / src/ (display.cpp floating_label.cpp font/text.cpp font/text.hpp gui/core/canvas.cpp): Added a texture cache for pango_text render output https://github.com/wesnoth/wesnoth/commit/cd16243d0e00e7fab44d678a87c6b876ec52c092
20170812 08:43:44< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering c945a5ae0c84 / src/ (floating_label.cpp floating_label.hpp): Floating Label: header formatting updates https://github.com/wesnoth/wesnoth/commit/c945a5ae0c8444c750582fb9872d66bccb4bed7a
20170812 08:43:47< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 0f74213cd002 / src/ (font/text.cpp sdl/utils.cpp): Use pixel format enums for creating surfaces instead color mask values https://github.com/wesnoth/wesnoth/commit/0f74213cd0029521068c7adeaf5729b933209396
20170812 08:43:50< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 702148644675 / src/gui/core/canvas.cpp: GUI2/Canvas: handle text alpha as a render-time op https://github.com/wesnoth/wesnoth/commit/702148644675e02402877007474989a186706dfe
20170812 08:43:53< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 2d2c1187d11c / src/font/ (text.cpp text.hpp): Font/Pango Text: added option for text outline https://github.com/wesnoth/wesnoth/commit/2d2c1187d11c46cb7d8fb3bd096c4f0ba65c59da
20170812 08:43:56< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 015a4f1fa575 / src/sdl/ (texture.cpp texture.hpp): Some updates to the texture wrapper class https://github.com/wesnoth/wesnoth/commit/015a4f1fa575b1b0e71dc3240017cdc5af42d470
20170812 08:43:59< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 7f7d6e06db3a / src/image.cpp: Avoid temporary object when creating new textures from disk https://github.com/wesnoth/wesnoth/commit/7f7d6e06db3a07b08b8710a0e55bc4cf6a8cc491
20170812 08:44:02< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 4a575da941dc / src/floating_label.cpp: Floating Labels: use new pango_text functionality for generating text outline https://github.com/wesnoth/wesnoth/commit/4a575da941dce77845d409e16475610af768ab92
20170812 08:44:05< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering bea0b1d75a83 / src/ (display.cpp display.hpp): Display: avoid unnecessarily (potentially) creating millions of temp vectors https://github.com/wesnoth/wesnoth/commit/bea0b1d75a8335a88937997d1a5bec1df7a85e2d
20170812 08:44:08< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 8ddd210a749e / src/actions/vision.cpp: Comment out an unused parameter https://github.com/wesnoth/wesnoth/commit/8ddd210a749e22c80128d2de549eab8d2edc27ad
20170812 08:44:11< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering ef50c05d13cd / src/ (floating_label.cpp floating_label.hpp): Added RAII helper struct to manage a floating label's lifetime https://github.com/wesnoth/wesnoth/commit/ef50c05d13cd2612510c088bbe420122d8c07eeb
20170812 08:44:14< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 89086f466663 / src/ (8 files in 2 dirs): Another large batch of progress, primarily in game_display https://github.com/wesnoth/wesnoth/commit/89086f466663f3a406551be0f56af32d5946ddfd
20170812 08:44:17< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 6259957a054d / src/display.cpp: Display: simplified a few things https://github.com/wesnoth/wesnoth/commit/6259957a054d98cef5150cdcdd99f7b24b18973c
20170812 08:44:20< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 16105981fdb4 / src/sdl/texture.cpp: SDL/Texture: avoid unnecessary shared_ptr creation https://github.com/wesnoth/wesnoth/commit/16105981fdb48c5d515f4e919641b6be1177a4e5
20170812 08:44:23< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 641f626ab8d8 / src/display.cpp: Display: fixed moving units drawing under foreground terrains https://github.com/wesnoth/wesnoth/commit/641f626ab8d87bcbdb42fe1f283ab40cc38799e5
20170812 08:44:26< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering c0e8107be61c / src/floating_label.cpp: Floating Label: keep local pango_text object static https://github.com/wesnoth/wesnoth/commit/c0e8107be61c325e05c8cc914d98d433928ccef7
20170812 08:44:29< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering e65840f3e719 / src/ (controller_base.cpp controller_base.hpp): Controller Base: removed unused process_focus_keydown_event event https://github.com/wesnoth/wesnoth/commit/e65840f3e719ab1e83a31054fd9ca2418f3873e5
20170812 08:44:32< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering e99651287b59 / src/ (16 files in 5 dirs): Refactored handling of window/renderer size getters https://github.com/wesnoth/wesnoth/commit/e99651287b598eccd0cff2db3b1982b3e99288ac
20170812 08:44:35< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 264d2ad95781 / src/font/text.cpp: Font/Pango Text: fixed a weird crash in Cairo https://github.com/wesnoth/wesnoth/commit/264d2ad957811e0613b3b7f4fe4cab4617ab021b
20170812 08:44:38< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering a35397d8acab / src/display.hpp: Display: exit render_scaled_to_zoom early if passed texture is null https://github.com/wesnoth/wesnoth/commit/a35397d8acab75e4cac67af7d3e352833c51c38d
20170812 08:44:41< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering c005f1758937 / src/ (display.cpp display.hpp): Display: avoid temp vectors when rendering partial fog/shround images on hex https://github.com/wesnoth/wesnoth/commit/c005f175893734cad0e8e70c0de9baf340390a20
20170812 08:44:44< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering d2a31947d941 / src/halo.cpp: Halos: fixed incorrect drawing origin when at non-default zoom https://github.com/wesnoth/wesnoth/commit/d2a31947d941339c02c368eb871ee5304d6fa5d7
20170812 08:44:47< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 523ae56b178e / src/ (gui/core/canvas.cpp sdl/render_utils.hpp sdl/window.cpp): Moved SDL_SetRenderDrawColor wrapper to utils file and added a second overload https://github.com/wesnoth/wesnoth/commit/523ae56b178e8b51e624b6209c9b3f4283a41849
20170812 08:44:50< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 12130874310f / src/gui/core/ (canvas.cpp canvas.hpp): GUI2/Canvas: optimized cached texture management https://github.com/wesnoth/wesnoth/commit/12130874310f0740d376bcac8cb51a6d93c5ba4e
20170812 08:44:53< irker220> wesnoth: Sofartin wesnoth:accelerated_rendering 49fb7edb4611 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Updated Xcode project for macOS targets https://github.com/wesnoth/wesnoth/commit/49fb7edb461195791de654e2be8e9a4ef5842dd6
20170812 08:44:55< irker220> wesnoth: Jyrki Vesterinen wesnoth:accelerated_rendering 1402bb838040 / / (6 files in 3 dirs): Fix build with Visual Studio https://github.com/wesnoth/wesnoth/commit/1402bb838040748bff0c606ca172408302bc037c
20170812 08:44:57< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering c0bea347a9fa / src/sdl/render_utils.hpp: Allow render_target_setter to restore the last target when destroyed https://github.com/wesnoth/wesnoth/commit/c0bea347a9fa1ca49d85da414adcc2e0426190f4
20170812 08:45:00< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering c4e577451413 / src/ (minimap.cpp minimap.hpp): Added new minimap drawing method that works wholly with textures https://github.com/wesnoth/wesnoth/commit/c4e5774514136eec3401ff5e45b4065ff9afafe8
20170812 08:45:03< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 381b1b6995d3 / src/gui/core/ (canvas.cpp canvas.hpp): GUI2/Canvas: allow the default draw routine (shape drawing) to be overridden https://github.com/wesnoth/wesnoth/commit/381b1b6995d3f8511144a6d40786b2d15ac08e00
20170812 08:45:06< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering cae49252fe4d / src/gui/core/canvas.cpp: GUI2/CanvasL fixup 4ed729cf9c (use initializer list for move ctor) https://github.com/wesnoth/wesnoth/commit/cae49252fe4deaa4c4aae8f566dc6c9b67df1b22
20170812 08:45:09< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering d76fb3c21be9 / src/gui/widgets/ (minimap.cpp minimap.hpp): GUI2/Minimap: refactored drawing code https://github.com/wesnoth/wesnoth/commit/d76fb3c21be97c0330763e495946953be13c7cf6
20170812 08:45:12< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 23ae1a66c715 / src/gui/widgets/ (window.cpp window.hpp): GUI2/Window: removed now-unused members https://github.com/wesnoth/wesnoth/commit/23ae1a66c7158c3e7c198eb34508f5dd4b618e6a
20170812 08:45:15< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering fff5bdb328f5 / src/gui/dialogs/ (command_console.cpp command_console.hpp): GUI2/Command Console: small cleanup/fixup https://github.com/wesnoth/wesnoth/commit/fff5bdb328f581c244516ce1b2497f0912fa8e1c
20170812 08:45:18< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 7d105ecbabf2 / src/units/frame.cpp: Unit/Frame: fixed alpha mods being applied to all units of the same type https://github.com/wesnoth/wesnoth/commit/7d105ecbabf26f28faff483f520b311bc1e41606
20170812 08:45:21< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 2c67369c2aae / src/ (game_display.cpp game_display.hpp): Game Display: reimplemented more functionality in draw_movement_info https://github.com/wesnoth/wesnoth/commit/2c67369c2aae2abeffd3742d4002d4d910d5ecca
20170812 08:45:24< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering 55d0da69d971 / src/game_display.cpp: Game Display: formatting update https://github.com/wesnoth/wesnoth/commit/55d0da69d9719420ea50332459233fdd1beec264
20170812 08:45:27< irker220> wesnoth: Charles Dang wesnoth:accelerated_rendering c2391c1b5e06 / src/gui/core/ (canvas.cpp canvas.hpp): GUI2/Canvas: some refactoring to correctly reimplement the shape caching mechani https://github.com/wesnoth/wesnoth/commit/c2391c1b5e06b68916b5d29fb87795e9ee04b17d
20170812 08:51:26-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170812 08:55:22< zookeeper> vultraz_iOS, yes?
20170812 09:26:46< vultraz_iOS> zookeeper: nevermind
20170812 09:27:08< vultraz_iOS> was looking for someone that could silence irker earlier but then it turned out i needed a lot more time
20170812 09:36:00-!- Kwandulin [~Kwandulin@p200300E453CC3B15595B13D6CDAE1E22.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170812 09:40:10-!- gfgtdf [~chatzilla@x4e32b5d9.dyn.telefonica.de] has joined #wesnoth-dev
20170812 09:40:19-!- travis-ci [~travis-ci@ec2-54-204-238-85.compute-1.amazonaws.com] has joined #wesnoth-dev
20170812 09:40:20< travis-ci> wesnoth/wesnoth#14666 (accelerated_rendering - c2391c1 : Charles Dang): The build is still failing.
20170812 09:40:20< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/263774456
20170812 09:40:21-!- travis-ci [~travis-ci@ec2-54-204-238-85.compute-1.amazonaws.com] has left #wesnoth-dev []
20170812 09:40:41< gfgtdf> 20170812 04:02:54< celticminstrel> It's awkward to click Create and then have to cross the entire window to click I'm Ready.
20170812 09:41:14< gfgtdf> celticminstrel: usualyl you ahvew to wait for other players to join the game, so it's unlikeley that the mouse is still at the same position then
20170812 09:41:31-!- Kwandulin [~Kwandulin@p200300E453CC3B15595B13D6CDAE1E22.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170812 09:49:57-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170812 09:59:40-!- Kwandulin2 [~Kwandulin@p200300E453CC3B15ECF46D77D0B2DFAF.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170812 10:03:08-!- Kwandulin [~Kwandulin@p200300E453CC3B15595B13D6CDAE1E22.dip0.t-ipconnect.de] has quit [Ping timeout: 255 seconds]
20170812 10:07:48-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170812 10:09:33-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 240 seconds]
20170812 11:39:16-!- Kwandulin2 [~Kwandulin@p200300E453CC3B15ECF46D77D0B2DFAF.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170812 11:47:57-!- irker220 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170812 12:02:00-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170812 12:12:52-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170812 12:15:32-!- Kwandulin [~Kwandulin@p200300E453CC3B15ECF46D77D0B2DFAF.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170812 12:53:49-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6d86:65cb:7869:a65b] has joined #wesnoth-dev
20170812 12:56:10< celticminstrel> ...wait a second. vultraz_iOS, is there any reason why the campaign list can't be changed back to a listbox?
20170812 12:56:17-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6d86:65cb:7869:a65b] has quit [Remote host closed the connection]
20170812 12:56:34< celticminstrel> IIRC the reason it was made a tree view was just so the modifications can be added at the bottom, but from the code it looks like mods are now a dropdown instead.
20170812 12:57:00< celticminstrel> Also JyrkiVesterinen, since you here, do you understand why we need to use TEXTINPUT for some key event handling?
20170812 12:57:05< celticminstrel> ^since you're
20170812 12:57:09< vultraz_iOS> Mmmmmmmmmmmm yes perhaps
20170812 12:58:08< celticminstrel> vultraz_iOS: So is there a reason or not? Only thing I can think of is if you didn't want a header, but IIRC that's still possible with a listbox...
20170812 12:58:40< vultraz_iOS> I don't think there's a reason
20170812 12:58:53< vultraz_iOS> I left it as a tree I think in case we wanted to implemented that suggestion
20170812 12:58:59< vultraz_iOS> For uh
20170812 12:59:01< vultraz_iOS> The thing
20170812 12:59:03< celticminstrel> Which suggestion?
20170812 12:59:06< vultraz_iOS> With camoaugnchapers
20170812 12:59:09< vultraz_iOS> Campaign chapters
20170812 12:59:15< celticminstrel> Ohhh, okay, so there is a potential reason then.
20170812 12:59:20< celticminstrel> Alright.
20170812 12:59:35< celticminstrel> Well, being able to sort in tree views has applications to the lobby too, anyway.
20170812 12:59:59< celticminstrel> I think the lobby currently rebuilds the entire player list when you change the sorting order.
20170812 13:00:41-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 246 seconds]
20170812 13:01:26< vultraz_iOS> As long as the tree view uses the generator it should be possible
20170812 13:01:40-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Disconnected by services]
20170812 13:02:08< celticminstrel> Oh, hmm, good point...
20170812 13:02:17< celticminstrel> Does it use the generator?
20170812 13:02:30< gfgtdf> iirc it doesn't
20170812 13:02:34-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20170812 13:02:51< celticminstrel> If I reorder the nodes in the internal list, would that translate to the screen?
20170812 13:03:05< celticminstrel> (And are there reasons not to do that?)
20170812 13:03:18< celticminstrel> I don't see any generator stuff in tree_view_node.
20170812 13:04:19< celticminstrel> Looks like tree view nodes are held in a grid.
20170812 13:04:25< celticminstrel> Guessing a 1-wide, n-tall grid.
20170812 13:04:32< gfgtdf> celticminstrel: well the other cude refer to the nodes often by their position in the treeview (at lest that's what the lua trreewie api doe)
20170812 13:04:33< celticminstrel> So for sorting I'd need to swap those around, huh...
20170812 13:04:34< gfgtdf> s
20170812 13:04:41< JyrkiVesterinen> celticminstrel: Aginor knows by far the best why TEXTINPUT is used.
20170812 13:04:41< JyrkiVesterinen> https://github.com/wesnoth/wesnoth/issues/1644
20170812 13:05:27< JyrkiVesterinen> I believe it's about ensuring that anything that can be input with the keyboard can be used as a hotkey, and that it can be displayed correctly in the UI.
20170812 13:05:51< gfgtdf> JyrkiVesterinen: it's not clear to me what that iseu can oynl be solved by using textinput
20170812 13:06:11< JyrkiVesterinen> It's unclear to me as well.
20170812 13:06:45< gfgtdf> celticminstrel: also what  exactly do you mean by sorting the treeview?you men the subnodes of a specific node? or something that global to the whole treeview
20170812 13:07:16< celticminstrel> gfgtdf: Subnodes of a given node is the key point. Once you have that you can easily extend it to the whole tree view, if you want to,
20170812 13:08:15< vultraz_iOS> Somehow allowing anything that can be input as a hotkey seems wrong
20170812 13:08:36< celticminstrel> Why?
20170812 13:08:47< vultraz_iOS> I dunno
20170812 13:08:54< vultraz_iOS> It seems like there would be something you don't want
20170812 13:09:08< JyrkiVesterinen> Remember that : is such a character with German/Swedish/Finnish keyboard (you need to press Shift to produce it).
20170812 13:09:17< JyrkiVesterinen> And it's one of the default hotkeys, to boot.
20170812 13:10:02< vultraz_iOS> Well you need shift to produce it on the regular keyboard too
20170812 13:10:18< gfgtdf> I really dislike the chnge that change in 1.13.8  the commandlien hotkey from ö back to : on german layouts, but since i can chnge it in my preference i don't care that much
20170812 13:11:03< vultraz_iOS> i liked the key better as ;
20170812 13:11:07< vultraz_iOS> dunno why aginor reverted it
20170812 13:11:48< gfgtdf> it was ';' at some point ? what keyboard kayout do you use?
20170812 13:11:49< JyrkiVesterinen> ; wouldn't be a problem for us. It's Shift-, on a Finnish keyboard, as easy as :
20170812 13:11:59< vultraz_iOS> standard
20170812 13:12:03< vultraz_iOS> qwerty
20170812 13:12:07< vultraz_iOS> why would i have anything else
20170812 13:12:08< JyrkiVesterinen> https://en.wikipedia.org/wiki/QWERTY#United_States
20170812 13:12:32-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170812 13:13:23< gfgtdf> hmm didn't know : needs shift on us layout too.
20170812 13:13:26< celticminstrel> FTR, "qwerty" is insufficient to identify your keyboard.
20170812 13:13:37< vultraz_iOS> i see
20170812 13:13:38< celticminstrel> UK keyboards are also qwerty, but they have some different punctuation.
20170812 13:13:46< JyrkiVesterinen> Right. That Wikipedia article makes it clear. :P
20170812 13:14:02< celticminstrel> ISTR the double quote was in a weird place, for example.
20170812 13:14:57< vultraz_iOS> honestly i think we need to go back to the drawing board and examine this issue from the start
20170812 13:14:59< celticminstrel> Wikipedia says it's shift+2, which sounds reasonable.
20170812 13:15:20< vultraz_iOS> shift 2 is @ what are you talking about
20170812 13:15:30< celticminstrel> On a UK keyboard.
20170812 13:16:16< vultraz_iOS> on MY keyboard
20170812 13:16:43< vultraz_iOS> or do you mean " is shift 2 on a UK keyboard
20170812 13:17:40< celticminstrel> Yeah that.
20170812 13:17:45< vultraz_iOS> i see
20170812 13:17:46< vultraz_iOS> ok
20170812 13:18:34< vultraz_iOS> FTR https://github.com/wesnoth/wesnoth/issues/1644 was caused by an incorrect implementation of the GUI2 hotkey dialog by me
20170812 13:18:47< vultraz_iOS> in the GUI1 version it worked perfectly fine
20170812 13:19:47< celticminstrel> Okay, so "anything can be input" doesn't require TEXTINPUT, but "properly showing in the UI" might, I guess?
20170812 13:20:03< vultraz_iOS> this was the old code
20170812 13:20:05< vultraz_iOS> https://github.com/wesnoth/wesnoth/blob/585ce88d64d609da0500286e56367a510b2ad466/src/hotkey/hotkey_preferences_display.cpp#L64-L80
20170812 13:20:39< celticminstrel> Without TEXTINPUT though, it's impossible to reliably set : as a default hotkey. It can be set as a hotkey no problem, but would show as shift-; or shift-. or whatever.
20170812 13:20:48< JyrkiVesterinen> Note that Aginor's fix for 1644 was what introduced "treat TEXTINPUT events as hotkeys".
20170812 13:21:18< vultraz_iOS> celticminstrel: why?
20170812 13:21:31< celticminstrel> Uh. What do you mean, why?
20170812 13:21:44< vultraz_iOS> whyis that so
20170812 13:22:12< celticminstrel> : is typed differently on different keyboards. If you can only specify hotkeys by giving the keystroke, then obviously you can't specify : in a general way that works for all keyboards.
20170812 13:22:46< celticminstrel> So TEXTINPUT does allow us to specify that the hotkey is : on any keyboard.
20170812 13:22:50< celticminstrel> (By default.)
20170812 13:22:53< vultraz_iOS> SDLK_COLON
20170812 13:23:00< celticminstrel> Yeah, what about it?
20170812 13:23:08< vultraz_iOS> that's the representation :|
20170812 13:23:09< celticminstrel> That key probably doesn't exist on your keyboard.
20170812 13:23:34< vultraz_iOS> "Values of this type (also known as keycodes or keysyms) are mapped to the current layout of the keyboard and correlate to an SDL_Scancode. The scancode identifies the location of a key press and the corresponding SDL_Keycode gives that key press meaning in the context of the current keyboard layout.
20170812 13:23:34< vultraz_iOS> Values of this type are used to represent keyboard keys using the current layout of the keyboard. These values include Unicode values representing the unmodified character that would be generated by pressing the key, or other constants for those keys that do not generate characters."
20170812 13:23:46< celticminstrel> vultraz_iOS: The key you use to type a : is SDLK_SEMICOLON
20170812 13:23:57< celticminstrel> The key Jyrki uses to type a : is SDLK_PERIOD
20170812 13:24:20< vultraz_iOS> i cannot see why there's no way to say we want the SDLK_COLON
20170812 13:24:29< celticminstrel> SDLK_COLON is a key that would produce : if pressed without shift. Ergo, that key does not exist on your keyboard.
20170812 13:24:34< vultraz_iOS> and then leave it to the input device to produce that key
20170812 13:24:40< celticminstrel> Or at least on my keyboard. I dunno, maybe you do have one.
20170812 13:24:52< vultraz_iOS> I need shift + ; to make :
20170812 13:25:15< celticminstrel> What part of "SDLK_COLON does not exist on your keyboard" do you not understand? The quote you pasted even supports what I'm saying.
20170812 13:25:26< vultraz_iOS> yes
20170812 13:25:34< vultraz_iOS> I'm asking *why does that matter*
20170812 13:25:37< celticminstrel> "These values include Unicode values representing the unmodified character that would be generated by pressing the key" (emphasis mine, if you can see the bold formatting)
20170812 13:26:06< celticminstrel> Because if you set the hotkey to be SDLK_COLON, you won't be able to press the hotkey? Obviously?
20170812 13:26:47< celticminstrel> Your (and my) keyboard will never produce this key code.
20170812 13:26:54< vultraz_iOS> but *why*!
20170812 13:26:59< vultraz_iOS> obviously somehow I'm able to type :
20170812 13:27:05< celticminstrel> (I mean, maybe it would if I changed the keyboard layout to one that has a key that directly produces :)
20170812 13:27:06< celticminstrel> ...
20170812 13:27:08< celticminstrel> .....
20170812 13:27:10< celticminstrel> ......
20170812 13:27:13< celticminstrel> vultraz_iOS
20170812 13:27:26< celticminstrel> You type : as shift+;
20170812 13:27:36< vultraz_iOS> so why the hell is it not possible to catch the specific set of keys that produce :
20170812 13:27:41< celticminstrel> THERE IS NO KEY THAT PRODUCES : WITHOUT A MODIFIER KEY
20170812 13:27:48< vultraz_iOS> INCLUDING MODIFIER KEYS
20170812 13:27:55< vultraz_iOS> HOW IS THERE NO FUNCTION
20170812 13:27:57< celticminstrel> No-one said it wasn't possible.
20170812 13:28:10< celticminstrel> Modifier keys are included as part of the keydown and keyup events.
20170812 13:28:21< celticminstrel> So you can totally listen for shift+;
20170812 13:28:36< celticminstrel> BUT that won't be : on all keyboards, and may not even exist on some keyboards.
20170812 13:28:49< vultraz_iOS> what about using SDL_GetKeyboardState
20170812 13:29:02-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170812 13:29:06< celticminstrel> So, without TEXTINPUT, it's impossible to set up the DEFAULT hotkey to be : on all keyboards.
20170812 13:29:10-!- HTTP_____GK1wmSU [~DEEP-BOOK@a7.40.17c6.ip4.static.sl-reverse.com] has joined #wesnoth-dev
20170812 13:29:13< celticminstrel> GetKeyboardState doesn't help with this.
20170812 13:29:22< vultraz_iOS> ah, but : has no scancode
20170812 13:29:32< celticminstrel> It's queries the same thing that the key events give you.
20170812 13:29:48< celticminstrel> Yes, : has no scancode, indeed.
20170812 13:30:22-!- HTTP_____GK1wmSU [~DEEP-BOOK@a7.40.17c6.ip4.static.sl-reverse.com] has left #wesnoth-dev []
20170812 13:30:24< vultraz_iOS> it seems incredible to me there's no way to get a keyboard-independent representation  of a single hotkey
20170812 13:30:47< celticminstrel> ...
20170812 13:31:03< vultraz_iOS> like, if we want :, how is it not possible for SDL to just catch whatever combination of modifier keys produces that
20170812 13:31:15< vultraz_iOS> be it shift ; or shift . or whatever
20170812 13:31:15< celticminstrel> Well, that is what TEXTINPUT does.
20170812 13:31:23< celticminstrel> But TEXTINPUT isn't really a key event.
20170812 13:31:29< celticminstrel> It's "oh this character was typed".
20170812 13:31:37< celticminstrel> There's no down vs up.
20170812 13:32:04< celticminstrel> So that means you can't bind WASD to scroll the map, for example.
20170812 13:32:19< celticminstrel> It won't work properly because the game has no way to tell when to stop scrolling.
20170812 13:32:38< vultraz_iOS> so there's nothing to be done
20170812 13:32:38< celticminstrel> You could even get TEXTINPUT from mouse events.
20170812 13:32:51< celticminstrel> (If you have an onscreen keyboard.)
20170812 13:33:01< celticminstrel> Well, something has to be done.
20170812 13:33:11< vultraz_iOS> why not just use physical key position like we did before
20170812 13:33:13< gfgtdf> we coudl also just go it the scancode way but add some ifdefs in the default hotkey preferences file dpending on keyboard layout.
20170812 13:33:26< celticminstrel> The possibility of binding WASD was IIRC one of the big reasons why rebinding scroll was made possible at all.
20170812 13:33:35< celticminstrel> gfgtdf: No, not scancodes.
20170812 13:33:57< vultraz_iOS> just say whatever key is two spaces left of ENTER is the console key
20170812 13:34:15< celticminstrel> vultraz_iOS: Now that is impossible.
20170812 13:34:24< vultraz_iOS> why?
20170812 13:34:56< celticminstrel> There's no way to query the physical layout of the keyboard.
20170812 13:35:06< gfgtdf> celticminstrel: that'S exactly what scancodes do and that's exactly waht 1.13.7 did
20170812 13:36:14< celticminstrel> ...on second thoughts, I guess that's true, never mind. Still... why do you think this is a good idea?
20170812 13:36:48 * celticminstrel idly wonders if all keyboards can type : in a single keystroke (possibily with modifier(s)).
20170812 13:37:26< JyrkiVesterinen> It's an important enough character than I think so.
20170812 13:37:31< JyrkiVesterinen> *that
20170812 13:38:07< celticminstrel> IIRC it's not even one of the ones that used to be so uncommon that C decided to make a trigraph for it.
20170812 13:38:34 * vultraz_iOS idly wonders who the hell needs trigraphs in 2017
20170812 13:38:47< celticminstrel> Nobody, that's why they're deprecated/removed.
20170812 13:38:52 * celticminstrel forgot which.
20170812 13:38:58< vultraz_iOS> removed
20170812 13:39:03-!- Kwandulin [~Kwandulin@p200300E453CC3B15ECF46D77D0B2DFAF.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170812 13:39:16< vultraz_iOS> but digraphs are around
20170812 13:39:22< vultraz_iOS> (or is it bigraphs?)
20170812 13:39:29< celticminstrel> I don't get why those are needed, either, TBH.
20170812 13:47:01-!- sevu [~Shiki@p54854F38.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170812 13:49:19-!- travis-ci [~travis-ci@ec2-54-147-53-29.compute-1.amazonaws.com] has joined #wesnoth-dev
20170812 13:49:20< travis-ci> wesnoth/wesnoth#14668 (a_r - 5364c50 : Charles Dang): The build has errored.
20170812 13:49:20< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/263823689
20170812 13:49:21-!- travis-ci [~travis-ci@ec2-54-147-53-29.compute-1.amazonaws.com] has left #wesnoth-dev []
20170812 13:53:56-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170812 14:01:57-!- Bonobo [~Bonobo@203.220.138.162] has quit [Ping timeout: 240 seconds]
20170812 14:05:45-!- sevu [~Shiki@p54854F38.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20170812 14:07:51-!- amello [~amello@179.159.56.56] has joined #wesnoth-dev
20170812 14:08:27< celticminstrel> ...how am I supposed to swap two widgets in a grid by position? :|
20170812 14:08:44< celticminstrel> I mean I suppose I could use swap_child, but that's by id...
20170812 14:08:54< vultraz_iOS> by what position?
20170812 14:08:57< vultraz_iOS> pixel?
20170812 14:08:58< vultraz_iOS> cell?
20170812 14:08:59< celticminstrel> Row and column.
20170812 14:09:58< vultraz_iOS> hm
20170812 14:10:00< vultraz_iOS> not sure
20170812 14:10:06< vultraz_iOS> what are you trying to do
20170812 14:10:35< celticminstrel> I'm trying to sort it.
20170812 14:11:16< vultraz_iOS> i don't think that's the most productive use of time right now
20170812 14:11:24< vultraz_iOS> and especially not by touching the grid cells
20170812 14:11:48< celticminstrel> Trying to make tree views sortable.
20170812 14:18:03< vultraz_iOS> you could just recreate it
20170812 14:30:51-!- Kwandulin [~Kwandulin@p200300E453CC3B15ECF46D77D0B2DFAF.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170812 14:33:27-!- gfgtdf [~chatzilla@x4e32b5d9.dyn.telefonica.de] has quit [Remote host closed the connection]
20170812 14:43:16-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 246 seconds]
20170812 15:01:40< celticminstrel> Recreate the grid? Well, I suppose that is a possibility, yeah...
20170812 15:02:50-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170812 15:05:30< vultraz_iOS> the tree
20170812 15:09:41-!- amello [~amello@179.159.56.56] has quit [Quit: Leaving]
20170812 15:21:28< celticminstrel> That's a pain.
20170812 15:21:44< celticminstrel> But I guess it's possible too.
20170812 15:22:02< celticminstrel> Easier now that I know that it only contains the campaigns, in fact.
20170812 15:24:23< celticminstrel> Relatedly, I'm wondering if we should phase out boost::ptr_vector. It's harder to work with than a vector of shared_ptrs.
20170812 15:24:36< vultraz_iOS> pls do
20170812 15:24:52< celticminstrel> Not right now, mind you (it's a refactor and we're too close to release to refactor). But after we branch off 1.14, at least.
20170812 15:24:54< vultraz_iOS> I've been meaning to
20170812 15:25:04< vultraz_iOS> hey, im doing some refactoring right ow
20170812 15:25:05< vultraz_iOS> now
20170812 15:25:12< celticminstrel> ???
20170812 15:25:17< vultraz_iOS> well minor
20170812 15:25:22< vultraz_iOS> mostly cleanup
20170812 15:25:22< celticminstrel> What exactly?
20170812 15:25:26< celticminstrel> ...
20170812 15:25:49< vultraz_iOS> a cleaner way to get styled_widget resolution configs that having lines like this all over the place
20170812 15:25:51< vultraz_iOS> 	std::shared_ptr<const horizontal_scrollbar_definition::resolution>
20170812 15:25:51< vultraz_iOS> 	conf = std::static_pointer_cast<const horizontal_scrollbar_definition::
20170812 15:25:51< vultraz_iOS> 											   resolution>(config());
20170812 15:26:24< celticminstrel> So a template function?
20170812 15:28:19< vultraz_iOS> si si
20170812 15:34:12< celticminstrel> Wait wait wait why is ng::level::name a std::string
20170812 15:34:31< vultraz_iOS> should it not be
20170812 15:34:43< celticminstrel> Is that not the translated name?
20170812 15:34:49< celticminstrel> If it's translatable, shouldn't it be t_string?
20170812 15:34:52< vultraz_iOS> im not sure off the top of my head
20170812 15:35:03< celticminstrel> Is it converted from a t_string at some point, then?
20170812 15:35:03< vultraz_iOS> perhaps?
20170812 15:35:17< vultraz_iOS> i recall something is somewhere..
20170812 15:35:47< vultraz_iOS> in mp create perhaps?
20170812 15:35:49< vultraz_iOS> or one of the engines
20170812 15:35:51< celticminstrel> Well, as long as it holds the translated name and not the English name, I guess it doesn't matter that much.
20170812 15:41:06< vultraz_iOS> well this isn't much better..
20170812 15:41:07< vultraz_iOS> derived_resolution_definition_ptr<horizontal_scrollbar_definition> = cast_config<horizontal_scrollbar_definition>();
20170812 15:41:08< vultraz_iOS> :|
20170812 15:41:14< vultraz_iOS> maybe I should auto
20170812 15:42:10< vultraz_iOS> auto conf = cast_config<horizontal_scrollbar_definition>();
20170812 15:42:21< vultraz_iOS> maybe should call it cast_config_to
20170812 15:44:19< vultraz_iOS> hm
20170812 15:44:21< vultraz_iOS> qualifier error..
20170812 15:44:57< vultraz_iOS> i wonder how it worked before?
20170812 15:45:08< vultraz_iOS> oh of course
20170812 15:45:36< celticminstrel> Probably missing const
20170812 15:51:26-!- gfgtdf [~chatzilla@x4e32b5d9.dyn.telefonica.de] has joined #wesnoth-dev
20170812 15:53:25< gfgtdf> any conrete plans for the next 1.13 release?
20170812 15:56:18< vultraz_iOS> none yet
20170812 15:56:26< vultraz_iOS> we need to merge the iOS/touch PR
20170812 15:58:56< gfgtdf> vultraz_iOS: while i agree that it's not to ahev it rather sooner than later i don't see how it s related to a 1.13 release since it doesnt effect the 1.13.9 release for users.
20170812 15:59:16< gfgtdf> s/it's not to ahev /it's nice to have
20170812 15:59:43< vultraz_iOS> what do you mean?
20170812 16:00:01< celticminstrel> gfgtdf: The reason to have it in for 1.13.9 is because then we can start feature freeze or similar.
20170812 16:00:22< vultraz_iOS> it will make it easier for singalen to work and it will allow a more consistent experience between desktop and iOS versions for 1.14 and we want to start a feature freeze and split into branch 1.14 once beta is over
20170812 16:00:24< celticminstrel> Also, it does affect some PC/tablet users.
20170812 16:00:46< celticminstrel> Um, just FTR, you need the feature freeze before you release 1.14.
20170812 16:01:00< vultraz_iOS> yes?
20170812 16:01:02< vultraz_iOS> i just said that
20170812 16:01:09< celticminstrel> Okay.
20170812 16:01:16< vultraz_iOS> feature freeze and branch split once beta is over
20170812 16:01:16< celticminstrel> It wasn't clear to me that that's what you meant.
20170812 16:01:20< vultraz_iOS> then we have RC
20170812 16:01:30< vultraz_iOS> 1.13.9 is beta 2
20170812 16:01:32< celticminstrel> And when's string freeze again?
20170812 16:02:00< vultraz_iOS> same time
20170812 16:02:32< vultraz_iOS> as feature freeze
20170812 16:03:48< vultraz_iOS> let's try to get 1.14 out before the end of the year, hopefully
20170812 16:04:13< vultraz_iOS> as soon as it's out we focus hard on accelerated_rendering
20170812 16:04:28< vultraz_iOS> I'm hoping we can get 1.16 out within a year of 1.14
20170812 16:05:16< vultraz_iOS> getting a_r to work is priority 1
20170812 16:05:24< vultraz_iOS> once 1.14 is out
20170812 16:05:40< gfgtdf> celticminstrel: why was blocker removed from 1712 ?
20170812 16:06:13< vultraz_iOS> if its that editor bug it's not enough blocker material
20170812 16:06:31< celticminstrel> Is too
20170812 16:06:32< gfgtdf> vultraz_iOS: i meant the steam loing to server issue
20170812 16:06:51< gfgtdf> vultraz_iOS: and i disagree about the editor issue.
20170812 16:06:52< celticminstrel> gfgtdf: I removed it because I decided it was perhaps less important than I had originally believed.
20170812 16:07:14< celticminstrel> Basically, see my comment just before I removed the label.
20170812 16:07:41< gfgtdf> celticminstrel: hmm ok
20170812 16:08:31< celticminstrel> Okay, now I need to find where the level object is constructed so I can add a new member...
20170812 16:09:14< vultraz_iOS> create engine
20170812 16:09:19< gfgtdf> celticminstrel: create_engine::init_all_levels()
20170812 16:09:33< celticminstrel> Thanks.
20170812 16:14:50< gfgtdf> so without 1712, does this mean we don't have to mess wit the steam api at all? (in the client)
20170812 16:15:48< celticminstrel> Probably? IIRC save file syncing doesn't require the Steam API?
20170812 16:19:38-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170812 16:20:16-!- irker925 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170812 16:20:16< irker925> wesnoth: Charles Dang wesnoth:master 79ab196daaf8 / src/gui/ (21 files in 2 dirs): GUI2: cleaned up widget resolution config cast fetch code https://github.com/wesnoth/wesnoth/commit/79ab196daaf89cea9a4781a2b9ff72ac1958a1d7
20170812 16:20:22< vultraz_iOS> C L E A N U P
20170812 16:21:42< zookeeper> gfgtdf, oh right, so apply_to,set= was only undocumented
20170812 16:22:43< vultraz_iOS> Damn I really hurt my hand putting that commit together
20170812 16:22:53< vultraz_iOS> Cramped copy/paste
20170812 16:22:58< vultraz_iOS> Ouch
20170812 16:36:48-!- ChipmunkV[m] [chipmunkvm@gateway/shell/matrix.org/x-nzzdjtpfzojmccxp] has quit [Ping timeout: 240 seconds]
20170812 16:37:34-!- Greg_Boggs[m] [gregboggsm@gateway/shell/matrix.org/x-herccitxqdokewya] has quit [Ping timeout: 264 seconds]
20170812 16:42:21-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6d86:65cb:7869:a65b] has joined #wesnoth-dev
20170812 16:54:05-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6d86:65cb:7869:a65b] has quit [Remote host closed the connection]
20170812 16:55:46-!- amello [~amello@179.159.56.56] has joined #wesnoth-dev
20170812 17:00:23-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170812 17:25:49-!- amello [~amello@179.159.56.56] has quit [Quit: Leaving]
20170812 17:26:37-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit []
20170812 17:28:58-!- DeFender1031 [~DeFender1@93-172-23-172.bb.netvision.net.il] has joined #wesnoth-dev
20170812 17:36:58-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20170812 17:53:24-!- Greg_Boggs[m] [gregboggsm@gateway/shell/matrix.org/x-bhblaehuiaqqwyrx] has joined #wesnoth-dev
20170812 18:03:44-!- ChipmunkV[m] [chipmunkvm@gateway/shell/matrix.org/x-rleocmwruktqcvzk] has joined #wesnoth-dev
20170812 18:07:54-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170812 18:09:10 * celticminstrel wonders what zookeeper was talking about.
20170812 18:09:37< zookeeper> the experience thing thread on the forums
20170812 18:15:17< DeFender1031> < celticminstrel> Okay so... we already have a way to deprecate a Lua function and an ActionWML tag...
20170812 18:15:54< DeFender1031> Depending on the table and its exact semantics, you could replace it with a metatable which returns whatever member you're asking for IN ADDITION to printing a deprecation notice.
20170812 18:16:43< DeFender1031> As for "certain ways of calling a function", then have just that codebranch report itself as deprecated.
20170812 18:41:36< gfgtdf> celticminstrel: did you see https://forums.wesnoth.org/viewtopic.php?f=21&p=616182#p616182 ? it says that in order to remvoe all advancements you first ahev to replace then with apply_to="new_advancement" replace="dummy" and then delete it with apply_to="remove_advancement" types="dummy"
20170812 18:41:42< celticminstrel> vultraz_iOS: Okay, I guess that cleanup isn't huge for a refactor.
20170812 18:41:49< gfgtdf> celticminstrel: which sounds rather strnage to me. 
20170812 18:42:05< celticminstrel> DeFender1031: Oh yeah, that sure sounds like it'd work!
20170812 18:42:08< gfgtdf> celticminstrel: since you write that effect maybe may have an opinion on how to fix it ?
20170812 18:42:43< DeFender1031> celticminstrel, glad to be of help.
20170812 18:43:12< gfgtdf> wrote*
20170812 18:46:00< celticminstrel> gfgtdf: Which effect?
20170812 18:46:16< gfgtdf> new_advancement/remove_advancement
20170812 19:20:44-!- irker925 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170812 19:38:11-!- D33P-B00K [~PYATIBRAT@91.233.116.245] has joined #wesnoth-dev
20170812 19:39:21-!- D33P-B00K [~PYATIBRAT@91.233.116.245] has left #wesnoth-dev []
20170812 19:41:53< celticminstrel> vultraz_iOS: Why do the ID set on each tree node in the campaign list? Would it break if eg ID 0 was no longer AToTB?
20170812 19:41:57< celticminstrel> ^Why is
20170812 19:42:28< vultraz_iOS> Serves the same purpose as list row indices
20170812 19:43:01< celticminstrel> Sure, but why is it needed?
20170812 19:43:12< vultraz_iOS> To select the multi page pages
20170812 19:43:22< vultraz_iOS> The description area is a multi page
20170812 19:43:45< celticminstrel> Hmm...
20170812 19:50:45< vultraz_iOS> celticminstrel: as long as the nodes retain their IDs everything should worl
20170812 19:50:47< vultraz_iOS> k
20170812 20:08:22-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6d86:65cb:7869:a65b] has joined #wesnoth-dev
20170812 20:13:15-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6d86:65cb:7869:a65b] has quit [Ping timeout: 258 seconds]
20170812 20:24:10-!- Kwandulin [~Kwandulin@p200300E453CC3B15ECF46D77D0B2DFAF.dip0.t-ipconnect.de] has quit [Ping timeout: 246 seconds]
20170812 20:29:52< celticminstrel> ...why is the toggle button not large enough for its text? :|
20170812 20:30:42< celticminstrel> Is the crash when clicking cancel in the campaign selection something I introduced?
20170812 20:30:47< celticminstrel> It probably is, I guess.
20170812 20:31:31< celticminstrel> Yeah, it was indeed. Never mind then.
20170812 20:31:44< celticminstrel> (Still having the toggle button problem, but if you want I can push it anyway and let you neaten it up.)
20170812 20:34:07-!- amello [~amello@179.159.56.56] has joined #wesnoth-dev
20170812 20:43:43-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6d86:65cb:7869:a65b] has joined #wesnoth-dev
20170812 20:53:35< gfgtdf> celticminstrel: if you are reworking that campaigns dialog, any opinion on https://github.com/wesnoth/wesnoth/issues/1317 ? It basicalyl suggestes to hvae menubutton the that dialog to start the campagn frm a later capter by loading a stat-of-scenario save
20170812 20:54:08< gfgtdf> from a later scenario i meant
20170812 20:55:07< gfgtdf> of this would only be avaiable is there is such a start-of-scenario save
20170812 20:56:02< DeFender1031> What's better about this than loading from the load screen?
20170812 20:56:46< DeFender1031> Or, put another way, I can understand in CERTAIN GAMES where you want to have a level select screen for anyone who has progressed to later levels.
20170812 20:57:18< DeFender1031> However, those are games where each level is largely independant, and loading a level for one player will be the same as loading that same level for a different player
20170812 20:57:25< celticminstrel> I wouldn't say I'm reworking it, but...
20170812 20:57:25< gfgtdf> DeFender1031: the main reason was that its easier becasue it's often hard to find savegames there if they are old and you save often.
20170812 20:58:16< celticminstrel> It's true that it's easy to get lost amidst all the auto-saves, but I think a better solution to that would be better filtering in load game.
20170812 20:58:19< DeFender1031> In wesnoth, with recall lists and carryover and whatnot, a pre-scenario save is highly tied into a particular player's progress, and therefore has more to do with the savegames than with the campaigns.
20170812 20:58:34< DeFender1031> agreed.
20170812 20:58:35< celticminstrel> For example, filter to show only start-of-scenario saves, or only manual saves (not auto-saves).
20170812 20:58:47< DeFender1031> and filters to show ONLY a particular scenario.
20170812 20:58:50< celticminstrel> Not sure if the latter is actually possible ATM, though.
20170812 20:58:54< DeFender1031> er.
20170812 20:58:57< celticminstrel> Oh, yeah, or only a specific campaign.
20170812 20:58:58< DeFender1031> particular campaign.
20170812 20:59:04< DeFender1031> that's what I meant.
20170812 20:59:42< DeFender1031> but yeah, you want a "level select" screen equivalent, filtering the load list is probably the way to do it. Mixing it into campaign loading is mixing meanings IMO.
20170812 21:00:06< zookeeper> how many autosaves do you keep if it's easy to get lost in them? :p
20170812 21:00:29< DeFender1031> zookeeper, I don't know about anyone else, but I have my autosaves set to no limit.
20170812 21:00:42< zookeeper> D:
20170812 21:00:49< DeFender1031> WHat?
20170812 21:00:56< gfgtdf> zookeeper: i also save quite ofen manually during a turn.
20170812 21:01:12< DeFender1031> gfgtdf, and keep separate files for each of those saves?
20170812 21:02:20< gfgtdf> DeFender1031: i think i usulay use what preset in that dialog
20170812 21:02:30< DeFender1031> ah
20170812 21:03:17< DeFender1031> IIRC that's some name that's similar to the autosave name (i.e. contains the turn number) but not quite the same (i.e. doesn't contain the words "auto save").
20170812 21:03:30< gfgtdf> ye
20170812 21:04:28-!- mjs-de [~mjs-de@x4e3064c7.dyn.telefonica.de] has quit [Remote host closed the connection]
20170812 21:14:42-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6d86:65cb:7869:a65b] has quit [Remote host closed the connection]
20170812 21:34:34< celticminstrel> IT WORKS!!! \o/
20170812 21:34:47< celticminstrel> Sorting the campaigns in chronological order!
20170812 21:35:02< celticminstrel> I've rigged it so that campaigns that don't specify their chronology go to the end.
20170812 21:43:26< celticminstrel> vultraz_iOS: Do you want to neaten up the GUIWML for it or should I do so?
20170812 21:43:28< DeFender1031> sweet.
20170812 21:43:34< DeFender1031> I assume you've added a new key?
20170812 21:43:40< celticminstrel> (FTR, I also added alphabetical order.)
20170812 21:44:04< celticminstrel> Yeah. I actually included an end date as well, if we wanted to be able to sort by that.
20170812 21:44:12< celticminstrel> dates = "2 BW ... 1 BW"
20170812 21:44:18< celticminstrel> ^1 YW
20170812 21:44:18< DeFender1031> hmm...
20170812 21:44:21< celticminstrel> That's TRoW
20170812 21:44:54< DeFender1031> i'd have just gone for a straight number and had all of them be YW (or BW if negative)
20170812 21:45:11< DeFender1031> on the other hand, that'd kind of force one to give a date for UtBS
20170812 21:45:17< celticminstrel> Exactly.
20170812 21:45:19< DeFender1031> which I think is left intentionally ambiguous.
20170812 21:45:46< celticminstrel> I was also assuming there's no year 0.
20170812 21:45:55< celticminstrel> So 1 BW is followed by 1 YW.
20170812 21:46:02< celticminstrel> Thus TRoW covers three years, not four.
20170812 21:46:07< DeFender1031> Even so, I'd still think to have era=whatever, startyear=whatever, endyear=whatever rather than having a string that needs its own semantics.
20170812 21:46:30< DeFender1031> ugh, the old year 0 debate.
20170812 21:46:34< celticminstrel> Eh. I don't think it's a problem to have some parsing.
20170812 21:46:49< celticminstrel> But maybe separating start and end, I suppose.
20170812 21:47:02< DeFender1031> the problem with the parsing isn't the parsing, it's that it's yet another syntax that people need to get right if they're going to use it.
20170812 21:47:23< DeFender1031> separating the eras, start, and end will be more straightforward for people to use.
20170812 21:47:36< celticminstrel> I don't think there's any advantage to separating the epoch.
20170812 21:47:56< DeFender1031> well, the question is, are the accepted epochs built in?
20170812 21:47:59< celticminstrel> But I can see the advantage to separating start and end.
20170812 21:48:08< celticminstrel> ATM they are, I dunno if we want to be able to expand it later, though/
20170812 21:48:20< DeFender1031> like, I assume there's BW, YW, BF, and AF?
20170812 21:48:24< celticminstrel> Yeah.
20170812 21:48:34< celticminstrel> Actually, I didn't add a BF though. Should I?
20170812 21:48:52< celticminstrel> That would require knowing the date of UtBS in YW epoch, though.
20170812 21:48:55< DeFender1031> Probably a good idea, if someone wnats, for example, to create a campaign that documents the actual fall.
20170812 21:49:05< celticminstrel> Because certain BF years are equal to other YW years.
20170812 21:49:05< DeFender1031> not really.
20170812 21:49:26< celticminstrel> Actually, I guess that problem even exists already with AF...
20170812 21:49:44< DeFender1031> I think the system can just assume that anything that is naturally being measured as BF would come after anything that is naturally being measured as YW.
20170812 21:49:55< celticminstrel> I suppose.
20170812 21:50:15< DeFender1031> Does UtbS document how many years after the fall it happens?
20170812 21:50:27< DeFender1031> I know it doesn't document what year YW the fall itself happens.
20170812 21:50:31< celticminstrel> I dunno, I just picked 300 as an arbitrary number.
20170812 21:50:41< DeFender1031> ah.
20170812 21:50:47< DeFender1031> that's... not terrible.
20170812 21:51:01< celticminstrel> Maybe I could make it less even.
20170812 21:51:12< celticminstrel> And of course it can be tweaked later if someone wants to.
20170812 21:51:20< DeFender1031> Btw, I do actually have some ideas for a "The fall of wesnoth" campaign.
20170812 21:51:51< DeFender1031> But no way in hell I'm actually working on that any time soon...
20170812 21:52:16< DeFender1031> I haven't even had time to work TCoM lately, let alone starting ANOTHER campaign :P
20170812 21:53:28< celticminstrel> I have a sequel to my campaign in the works, but haven't been able to find the time to work on it.
20170812 21:53:38< celticminstrel> And I also need to update my existing campaign to 1.13...
20170812 21:53:49< celticminstrel> Or 1.14, depending on how long it takes.
20170812 21:54:05< celticminstrel> I've done some work on this, but there's still a lot of work to be done.
20170812 21:55:52< DeFender1031> I know the feeling
20170812 21:58:33-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170812 22:05:31< celticminstrel> Thinking about it, using a "before fall" epoch for a fall of Wesnoth campaign doesn't actually make sense.
20170812 22:05:44-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170812 22:05:53< celticminstrel> The whole reason there's a new epoch is because they lost track of the count under the previous epoch.
20170812 22:06:12< celticminstrel> So at some point, probably quite some time after the fall, they decided "this is now 1 AF".
20170812 22:06:37< celticminstrel> Thus, an inverse epoch to AF wouldn't be "before the fall". It would still be counting things that happened after the fall.
20170812 22:06:50< celticminstrel> DeFender1031: ^
20170812 22:07:00< celticminstrel> I mean it could still be BF if you want.
20170812 22:08:57< DeFender1031> So the reason I'd do it is simply so that a "the fall of wesnoth" or "the raising of the second sun" campaign could be created without having to tie those events down in relation to the rest of the history.
20170812 22:09:28< DeFender1031> Not because they'r using that name at that point, just so that its chronology is pinned to the later epoch instead of pinned to the earlier one
20170812 22:09:47< celticminstrel> Well, if you're okay with having an unspecified time gap between "1 BF" and "1 AF"...
20170812 22:10:08< DeFender1031> umm...what?
20170812 22:10:12< celticminstrel> People after the fall wouldn't be counting from the actual fall - the don't remember exactly how long ago that was.
20170812 22:10:21< celticminstrel> ^they
20170812 22:10:22< DeFender1031> ah... hmm
20170812 22:10:34< DeFender1031> I dunno
20170812 22:10:46< DeFender1031> I think they may remember how long ago the fall was, just not what year it happened.
20170812 22:10:58< celticminstrel> Hmm.
20170812 22:11:23< celticminstrel> I'm not sure how that would work, but maybe, I suppose...
20170812 22:12:33< DeFender1031> they lost all the history books and were more concerned with survival than record-keeping.
20170812 22:12:37-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20170812 22:12:45-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170812 22:12:53< DeFender1031> but they sure as hell know how long they have been struggling.
20170812 22:13:04< DeFender1031> That's how I read how things would happen, anyway.
20170812 22:13:20< DeFender1031> Others are certainly free to disagree with me, and wouldn't even be wrong to do so.
20170812 22:17:04-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20170812 22:21:54-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170812 22:26:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170812 22:37:52-!- ChipmunkV[m] [chipmunkvm@gateway/shell/matrix.org/x-rleocmwruktqcvzk] has quit [Ping timeout: 246 seconds]
20170812 22:38:09-!- Greg_Boggs[m] [gregboggsm@gateway/shell/matrix.org/x-bhblaehuiaqqwyrx] has quit [Ping timeout: 258 seconds]
20170812 22:38:33-!- irker941 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170812 22:38:33< irker941> wesnoth: Celtic Minstrel wesnoth:chronological 6d1e13602eb5 / / (29 files in 24 dirs): Enable sorting campaign list in chronological or lexicographical order https://github.com/wesnoth/wesnoth/commit/6d1e13602eb5c5e173b2a47d426713255580d07c
20170812 22:38:58< celticminstrel> Pushed to a branch to let Travis test before I push to master; I could open a PR if someone asks for it, but I wasn't planning to.
20170812 22:44:08< zookeeper> got a screenshot of what it looks like?
20170812 22:44:32< celticminstrel> Oh sure, give me a minute or three.
20170812 22:46:25< zookeeper> strikes me a bit odd that you'd hardcode the epochs in c++.
20170812 22:46:36< celticminstrel> Print screen was above home, I think?
20170812 22:46:43< celticminstrel> I don't have a print screen key. >_>
20170812 22:47:28< DeFender1031> zookeeper, I thought so too, until I realized that there's no good way to make them customizable, as they need to work cross-add-on.
20170812 22:48:08< DeFender1031> The only real way would be some arbitrary "epoch id" where any campaign with a higher epoch id would come later.
20170812 22:48:52< celticminstrel> Or give each epoch a rank.
20170812 22:49:15< celticminstrel> My reason was more just laziness than anything else TBH.
20170812 22:49:22< celticminstrel> It's a lot more work to make it customizable.
20170812 22:49:52< celticminstrel> I did have some vague ideas of how to do so, maybe with [epoch] tags somewhere.
20170812 22:50:02 * zookeeper waits to see it first before asking what's the deal with the epochs in the first place
20170812 22:50:16< celticminstrel> http://celmin.pwcsite.com/wesnoth/wesnoth_campaigns_chronological.png
20170812 22:50:34< celticminstrel> Should I give a second shot with it scrolled to the bottom?
20170812 22:51:02< zookeeper> ...is there something to see there?
20170812 22:51:18< celticminstrel> ...well, what the heck.
20170812 22:51:21< celticminstrel> http://celmin.pwcsite.com/wesnoth/wesnoth_campaigns_chronological2.png
20170812 22:51:30< celticminstrel> Basically just shows off how UtBS is last..
20170812 22:51:37< celticminstrel> And non-core ones after it.
20170812 22:51:45< DeFender1031> uhh... why is AToTB showing if RoW is selected?
20170812 22:52:01< celticminstrel> Good question.
20170812 22:52:29< celticminstrel> Should it remember the previously selected campaign when you resort? I guess probably it should?
20170812 22:52:29< DeFender1031> code not as complete as you thought?
20170812 22:52:30< zookeeper> so does "Dates" have a drop-down menu or is the arrow just a marker for which sorting criteria is selected?
20170812 22:53:03< celticminstrel> zookeeper: The latter. It's basically like a listbox header, so clicking it again reverses the order, and a third click reverts to default sorting (by rank).
20170812 22:56:53< zookeeper> oh right, the epoch stuff is just for parsing the year strings.
20170812 22:58:14< zookeeper> so is there both a start_year and end_year so campaigns with overlapping timespans can be reverse-sorted correctly, or something?
20170812 22:58:38< celticminstrel> Well, ATM I'm only using the start year; the end year was mostly just because that data was available, TBH.
20170812 22:58:52< celticminstrel> That said... I could totally use end year instead of start year for the reverse sorting, if you think that's appropriate.
20170812 22:59:06< zookeeper> i have no idea
20170812 22:59:48< DeFender1031> Might make some amount of sense...
20170812 23:00:14< DeFender1031> not sure.
20170812 23:00:34< DeFender1031> It'd be kinda cool to have a proper timelined view with scaled blocks representing each campaign but that would be insane to code.
20170812 23:02:40< celticminstrel> Heh.
20170812 23:03:22< celticminstrel> So it now remembers your selection when you change sorting order, but doesn't scroll so it remains visible. Not sure how to do this.
20170812 23:03:40< celticminstrel> It must be possible, right? It works for listboxes, after all. Unless it was part of the generator behaviour...
20170812 23:04:29< irker941> wesnoth: Ignacio R. Morelle wesmere:master 7d973956edcc / static/ (Makefile docroot/units/index.xml): static: Add a new index page for units.w.o https://github.com/wesnoth/wesmere/commit/7d973956edccca4c8374f597bacf338c6ff4c49e
20170812 23:04:53< DeFender1031> (I actually recently wrote code to do exactly that for my day job, though I doubt they'd be happy if I were to port that code to a GPL project...)
20170812 23:05:57< DeFender1031> No idea if scrolling is possible. I think vult would have to answer that.
20170812 23:08:18< zookeeper> if there's no intention of making the dates user-visible, then a simple chronological rank would do just fine, no need for all that date parsing complexity. and if you intend to make the dates user-visible, then it's very unclear what should happen to UtBS.
20170812 23:10:36< celticminstrel> I'm imagining the dates will be user-visible at some point.
20170812 23:10:46< celticminstrel> I didn't specifically have plans to do it though.
20170812 23:11:01-!- travis-ci [~travis-ci@ec2-54-147-53-29.compute-1.amazonaws.com] has joined #wesnoth-dev
20170812 23:11:02< travis-ci> wesnoth/wesnoth#14670 (chronological - 6d1e136 : Celtic Minstrel): The build failed.
20170812 23:11:02< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/263931152
20170812 23:11:02-!- travis-ci [~travis-ci@ec2-54-147-53-29.compute-1.amazonaws.com] has left #wesnoth-dev []
20170812 23:15:48-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6d86:65cb:7869:a65b] has joined #wesnoth-dev
20170812 23:20:30< zookeeper> yeah, i'm just thinking that if you set in stone the epochs now, they'll be harder to change if/when later we need to decide how they should actually work in terms of user visibility.
20170812 23:21:37< irker941> wesnoth: Celtic Minstrel wesnoth:chronological bc8f25add571 / / (29 files in 24 dirs): Enable sorting campaign list in chronological or lexicographical order https://github.com/wesnoth/wesnoth/commit/bc8f25add5714652857ab6249844c4d5706ef29d
20170812 23:24:26< DeFender1031> celticminstrel, I assume the lexico-order takes localization into account?
20170812 23:24:52< celticminstrel> Theoretically. I haven't tested to be sure it works, though.
20170812 23:25:03< celticminstrel> It uses the locale-dependent string compare, at least.
20170812 23:25:12< celticminstrel> So I'm pretty sure it would work.
20170812 23:25:14< zookeeper> for example, the whole point is that the UtBS date is unknown, so waving a "1999 AF" date in the campaign menu might not be such a good idea.
20170812 23:25:57< celticminstrel> I'm not setting the UtBS date in stone. It's currently just a arbitrary number in order to push it to the end.
20170812 23:26:29< zookeeper> the date doesn't matter. the fact that there has to be a date might.
20170812 23:26:58< celticminstrel> Well, perhaps there could be support for c. or something. >_>
20170812 23:26:59< DeFender1031> celticminstrel, I meant that it's comparing the post-translation strings for the sort.
20170812 23:27:26< celticminstrel> DeFender1031: I think it's using the same string that's actually displayed in the dialog.
20170812 23:28:01< DeFender1031> About UtBS, there could be a "UtBS" epoch where the start of UtBS is 0...
20170812 23:28:10< DeFender1031> That'd alleviate the need to set any kind of date...
20170812 23:28:18< DeFender1031> celticminstrel, that should be fine then.
20170812 23:29:58< zookeeper> you could allow something like date="1999^? AF" :p
20170812 23:30:22< zookeeper> (display as "? AF", treat as "1999 AF" for sorting purposes)
20170812 23:32:50 * zookeeper is off
20170812 23:36:57-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20170812 23:37:32-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6d86:65cb:7869:a65b] has quit [Remote host closed the connection]
20170812 23:49:42-!- Greg_Boggs[m] [gregboggsm@gateway/shell/matrix.org/x-mvkhbeyendioykkm] has joined #wesnoth-dev
--- Log closed Sun Aug 13 00:00:17 2017