--- Log opened Tue Aug 15 00:00:19 2017
20170815 00:00:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 255 seconds]
20170815 00:03:35-!- DDR [~david@ec2.happyspork.com] has joined #wesnoth-dev
20170815 00:03:35-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20170815 00:04:23-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev
20170815 00:04:23-!- Polsaker [~Polsaker@donger/wielder/Polsaker] has joined #wesnoth-dev
20170815 00:04:24-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has joined #wesnoth-dev
20170815 00:04:24-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20170815 00:06:26-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170815 00:11:34-!- Greg_Boggs[m] [gregboggsm@gateway/shell/matrix.org/x-ousxtyqtpfcghowj] has joined #wesnoth-dev
20170815 00:20:49< matthiaskrgr> https://travis-ci.org/wesnoth/wesnoth/jobs/264450590#L1949  :( 
20170815 00:21:29< vultraz_iOS> yeah i have a local fix
20170815 00:21:39< celticminstrel> Oh, you do? Nice.
20170815 00:21:47< vultraz_iOS> very simple fix
20170815 00:21:49< celticminstrel> Does it fix All Of The Errors?
20170815 00:21:57< celticminstrel> ISTR there were at least two distinct errors.
20170815 00:22:00< vultraz_iOS> not sure
20170815 00:22:05< vultraz_iOS> since i can't build completely
20170815 00:22:09< vultraz_iOS> since im working on something else
20170815 00:22:13< vultraz_iOS> but ill push what i have
20170815 00:22:17< matthiaskrgr> yay
20170815 00:22:45< celticminstrel> So that's the .str() suggestion from gfgtdf.
20170815 00:22:52< vultraz_iOS> yes
20170815 00:23:05< celticminstrel> IIRC there was also something in campaign_selection.cpp with a warning about constructor initialization order.
20170815 00:23:10< celticminstrel> Or maybe .hpp.
20170815 00:23:21-!- ChipmunkV[m] [chipmunkvm@gateway/shell/matrix.org/x-vdeknvzxijgfkraa] has joined #wesnoth-dev
20170815 00:24:43< celticminstrel> Yeah, I see it, it's here. https://github.com/wesnoth/wesnoth/blob/master/src/gui/dialogs/campaign_selection.hpp#L66
20170815 00:25:30< celticminstrel> So either move that line to the bottom OR move the corresponding constructor initializer to the top (or even just add =RANK at the end and remove the constructor initializer).
20170815 00:28:52< irker735> wesnoth: Charles Dang wesnoth:master 302d2353b73f / src/gui/dialogs/ (message.hpp network_transmission.hpp): GUI2/Dialogs: minor include cleanup of widget files in headers https://github.com/wesnoth/wesnoth/commit/302d2353b73fa0c81193cc65798a2e214576804f
20170815 00:28:55< irker735> wesnoth: Charles Dang wesnoth:master bac6f1fbb4b7 / src/gui/widgets/styled_widget.cpp: GUI2/Styled Widget: initialize use_markup from builder in second ctor https://github.com/wesnoth/wesnoth/commit/bac6f1fbb4b77260ef4f98edab4a99e1d460e9ac
20170815 00:28:57< irker735> wesnoth: Charles Dang wesnoth:master ae19f942ca83 / src/gui/core/ (window_builder.cpp window_builder.hpp): GUI2/Window Builder: added a type alias for the builder widget function https://github.com/wesnoth/wesnoth/commit/ae19f942ca83eceae751b8e5a7db35c83a9d0fb0
20170815 00:29:01< irker735> wesnoth: Charles Dang wesnoth:master d644124bb99d / src/gui/core/window_builder.cpp: GUI2/Window Builder: formatting cleanup https://github.com/wesnoth/wesnoth/commit/d644124bb99da613342b0a9534aaaae66f80f7fc
20170815 00:29:04< irker735> wesnoth: Charles Dang wesnoth:master 78002951ddc1 / projectfiles/CodeBlocks/wesnoth.cbp: Update CB projectfile for 25a0d09 https://github.com/wesnoth/wesnoth/commit/78002951ddc18c004648958d030189b78915ae18
20170815 00:29:07< irker735> wesnoth: Charles Dang wesnoth:master c0c29f8072ab / src/game_config.cpp: Fixup 74cff9647 https://github.com/wesnoth/wesnoth/commit/c0c29f8072ab92fd6513165b0cea61038097e01a
20170815 00:29:10< irker735> wesnoth: Charles Dang wesnoth:master d06c860ee375 / src/gui/dialogs/campaign_selection.hpp: GUI2/Campaign Selection: fixup initializer list https://github.com/wesnoth/wesnoth/commit/d06c860ee375ce3cfbaa1bd503fd94947230941a
20170815 00:30:32< vultraz_iOS> if you're going to use inline initialization at least be consistent
20170815 00:31:53< celticminstrel> There are reasons to mix inline and ctor initializers.
20170815 00:32:01< celticminstrel> None of them apply here, but still.
20170815 00:33:58 * vultraz_iOS is currently trying to convert all styled_widgets to use the second ctor
20170815 00:34:08< celticminstrel> Adding page_ids_() was pointless, but meh.
20170815 00:34:19< celticminstrel> (It's a vector, so it'll be default-initialized no matter what.)
20170815 00:35:00< vultraz_iOS> true
20170815 00:36:37-!- sevu|sleep [~Shiki@p54854662.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20170815 00:38:07< vultraz_iOS> I'm not sure I exactly like all the changes I'm making here...
20170815 00:38:20< celticminstrel> ?
20170815 00:38:54< vultraz_iOS> I'm having to pass references down though multiple levels of classes
20170815 00:40:27< celticminstrel> I don't see a problem with this.
20170815 00:40:53< vultraz_iOS> celticminstrel: I assume the restrictions on virtual functions being called from a ctor also apply to virtual functions called insider functions call by the ctor?
20170815 00:43:10< vultraz_iOS> Pretty sure so
20170815 01:07:54-!- travis-ci [~travis-ci@ec2-54-144-195-55.compute-1.amazonaws.com] has joined #wesnoth-dev
20170815 01:07:55< travis-ci> wesnoth/wesnoth#14690 (master - d06c860 : Charles Dang): The build is still failing.
20170815 01:07:55< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/264569825
20170815 01:07:55-!- travis-ci [~travis-ci@ec2-54-144-195-55.compute-1.amazonaws.com] has left #wesnoth-dev []
20170815 01:08:34< celticminstrel> Yeah.
20170815 01:09:08< celticminstrel> IIRC it's not an error to call them, but it won't do what you want.
20170815 01:09:33-!- Bonobo [~Bonobo@203.220.138.162] has joined #wesnoth-dev
20170815 01:09:43< celticminstrel> Essentially the issue is that, when the constructor is being run, it doesn't know yet whether this is the final class or if it's actually a subclass.
20170815 01:10:26< gfgtdf> its an error to call then if they are prueley virtual though (virtual f() = 0; in the base class)
20170815 01:10:31< gfgtdf> them*
20170815 01:11:34< celticminstrel> It's not an error (at least, a compile error) to call a pure virtual function.
20170815 01:11:51< celticminstrel> The only way you can do so is by bypassing virtual dispatch, of course.
20170815 01:12:11< celticminstrel> Either from a constructor or by qualifying it with the class name.
20170815 01:12:38< celticminstrel> By default, pure virtual functions are auto-supplied with an implementation that calls abort().
20170815 01:12:46< celticminstrel> So it's a runtime error.
20170815 01:14:00< celticminstrel> (Or maybe it was std::terminate()... same effect though.)
20170815 01:14:19< matthiaskrgr> vultraz_iOS: https://pastebin.com/rMdsV71K  
20170815 01:14:21< gfgtdf> i know that its  aruntime error on msvc but, if you read somehwre that the standard guarentees that it's no complier error then i'm intesrrested
20170815 01:14:56< celticminstrel> I can fix that, matthiaskrgr 
20170815 01:15:03< matthiaskrgr> ok ^^
20170815 01:15:15< celticminstrel> Vultraz just moved the type definition to after it's used.
20170815 01:16:21< irker735> wesnoth: Celtic Minstrel wesnoth:master 3e2b2b94502e / src/gui/dialogs/campaign_selection.hpp: Fixup d06c860ee375ce3cfbaa1bd503fd94947230941a https://github.com/wesnoth/wesnoth/commit/3e2b2b94502efba197b9def34124b61a2080c76f
20170815 01:18:39< celticminstrel> So just FTR, I'll be away for the rest of the week.
20170815 01:19:07< gfgtdf> what's currently stpping us from merging the ios pr ?
20170815 01:19:29< celticminstrel> vultraz_iOS's laziness about testing it on his tablet, I guess?
20170815 01:19:55< gfgtdf> ok
20170815 01:20:41< celticminstrel> BTW gfgtdf, do you have any idea of how to fix the two hotkey issues?
20170815 01:21:20< matthiaskrgr> huh
20170815 01:21:23< gfgtdf> celticminstrel: you mean #1864 ?
20170815 01:21:33< matthiaskrgr> I'm getting some warnings from cmake btw (3.9.0)
20170815 01:21:55< celticminstrel> gfgtdf: Yeah.
20170815 01:22:17< matthiaskrgr> https://pastebin.com/TV9BJse1      
20170815 01:26:22< gfgtdf> celticminstrel: well obviously we coudl go back to not using textinput for hotkeys... ,an alternative would be to make how hanldes those hotkeys dependent on  whi type of hotkey is used: for textinout hotkeys mkae scroll only scroll a small amount (since it fired repediateley), for others do it like it's done currently.
20170815 01:28:07< gfgtdf> celticminstrel: still i dont really remember why we switched to to useing textinpout in the first place
20170815 01:31:56-!- gfgtdf_ [~chatzilla@x4e3689a8.dyn.telefonica.de] has joined #wesnoth-dev
20170815 01:33:50-!- gfgtdf [~chatzilla@x4e368b92.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170815 01:33:51-!- gfgtdf_ is now known as gfgtdf
20170815 01:37:11< gfgtdf> celticminstrel: the prs description basically said 'This adds support for composed hotkeys' i'm still not sure what it means.
20170815 01:40:20< celticminstrel> gfgtdf: I tried something similar to what you said, but the problem is it still can't support pressing two hotkeys simultaneously.
20170815 01:40:34< celticminstrel> So, my solution works perfectly if you just want to scroll up or down or sideways.
20170815 01:40:43< celticminstrel> But as soon as you try to scroll diagonally, it breaks down.
20170815 01:41:20< gfgtdf> hmm that doesnt sound good.
20170815 01:41:48< celticminstrel> It makes sense if you think of how text input and key repeat works.
20170815 01:41:58< gfgtdf> yes
20170815 01:46:49< matthiaskrgr> mmh ok travis is also getting these linker errors 
20170815 01:47:01< matthiaskrgr> https://travis-ci.org/wesnoth/wesnoth/jobs/264578348#L2944  
20170815 01:48:02< matthiaskrgr> /home/matthias/LLVM/LLVM_dev/stage_2/build/bin/ld.lld: error: symbol 'irdya_date::read_date(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)' defined in src/libwesnoth-game.a(create_engine.cpp.o) has no type
20170815 01:51:22< gfgtdf> celticminstrel: https://github.com/wesnoth/wesnoth/blob/master/source_lists/wesnoth#L390
20170815 02:04:57< celticminstrel> :O
20170815 02:05:31< irker735> wesnoth: Celtic Minstrel wesnoth:master 658bbbf1dabb / source_lists/wesnoth: fixup Travis compile https://github.com/wesnoth/wesnoth/commit/658bbbf1dabbce0292fcc669d26ac8551f140573
20170815 02:06:38< celticminstrel> I guess that's not a good commit message, but whatever.
20170815 02:15:50< matthiaskrgr> hm does that require a clean rebuild? :/
20170815 02:16:00< celticminstrel> I doubt it?
20170815 02:16:04< matthiaskrgr> :(
20170815 02:16:12< celticminstrel> What's wrong now?
20170815 02:16:28< matthiaskrgr> ../src/tests/test_irdya_date.cpp:38:19: error: use of undeclared identifier 'EPOCH'; did you mean 'irdya_date::EPOCH'?
20170815 02:16:31< matthiaskrgr>         irdya_date first(EPOCH::WESNOTH, 12);
20170815 02:16:32< matthiaskrgr> in a couple of places
20170815 02:16:35< matthiaskrgr>                          ^~~~~
20170815 02:16:57< matthiaskrgr> ../src/tests/test_irdya_date.cpp:59:22: error: use of undeclared identifier 'BW_29'; did you mean 'BF_29'?
20170815 02:27:47< celticminstrel> Ah, okay.
20170815 02:28:08< celticminstrel> Just those two?
20170815 02:31:10< irker735> wesnoth: Celtic Minstrel wesnoth:master c60373611123 / src/tests/test_irdya_date.cpp: fixup unit tests https://github.com/wesnoth/wesnoth/commit/c60373611123b837c54a7daf111aa51ddf47d665
20170815 02:31:14< celticminstrel> I think that should get them all.
20170815 02:55:41-!- gfgtdf [~chatzilla@x4e3689a8.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 54.0.1/20170628075643]]
20170815 03:09:32-!- travis-ci [~travis-ci@ec2-54-82-199-33.compute-1.amazonaws.com] has joined #wesnoth-dev
20170815 03:09:33< travis-ci> wesnoth/wesnoth#14692 (master - 658bbbf : Celtic Minstrel): The build is still failing.
20170815 03:09:33< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/264587827
20170815 03:09:33-!- travis-ci [~travis-ci@ec2-54-82-199-33.compute-1.amazonaws.com] has left #wesnoth-dev []
20170815 03:17:54-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170815 03:35:03-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170815 03:39:37-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170815 03:42:18-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20170815 03:48:38-!- travis-ci [~travis-ci@ec2-50-17-108-208.compute-1.amazonaws.com] has joined #wesnoth-dev
20170815 03:48:39< travis-ci> wesnoth/wesnoth#14693 (master - c603736 : Celtic Minstrel): The build is still failing.
20170815 03:48:39< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/264592084
20170815 03:48:39-!- travis-ci [~travis-ci@ec2-50-17-108-208.compute-1.amazonaws.com] has left #wesnoth-dev []
20170815 04:02:51-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170815 04:06:03< irker735> wesnoth: Ignacio R. Morelle wesnoth:master 73857622fc54 / data/tools/unit_tree/html_output.py: wmlunits: Do not list abilities without name attributes https://github.com/wesnoth/wesnoth/commit/73857622fc548e5c61250e1a0b90bb1870fdec63
20170815 04:12:13-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170815 04:32:14< irker735> wesnoth: Ignacio R. Morelle wesnoth:master 3ba7c64010a6 / data/tools/unit_tree/html_output.py: wmlunits: Mark terrains with high movement costs properly https://github.com/wesnoth/wesnoth/commit/3ba7c64010a648b9f50bb52ec870fd3d918dcf00
20170815 05:09:59-!- travis-ci [~travis-ci@ec2-54-82-199-33.compute-1.amazonaws.com] has joined #wesnoth-dev
20170815 05:10:00< travis-ci> wesnoth/wesnoth#14694 (master - 7385762 : Ignacio R. Morelle): The build is still failing.
20170815 05:10:00< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/264608721
20170815 05:10:00-!- travis-ci [~travis-ci@ec2-54-82-199-33.compute-1.amazonaws.com] has left #wesnoth-dev []
20170815 05:23:20-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170815 05:24:38-!- Kwandulin [~Kwandulin@p200300E453CC3B84E1E632B10B9CFD51.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170815 05:27:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170815 05:33:29-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170815 05:35:27-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170815 05:47:44-!- travis-ci [~travis-ci@ec2-54-82-199-33.compute-1.amazonaws.com] has joined #wesnoth-dev
20170815 05:47:45< travis-ci> wesnoth/wesnoth#14695 (master - 3ba7c64 : Ignacio R. Morelle): The build is still failing.
20170815 05:47:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/264612883
20170815 05:47:45-!- travis-ci [~travis-ci@ec2-54-82-199-33.compute-1.amazonaws.com] has left #wesnoth-dev []
20170815 06:07:54-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170815 06:10:54-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170815 06:21:49-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20170815 06:24:58-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170815 07:11:38-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170815 07:15:59-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 246 seconds]
20170815 07:19:46-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 276 seconds]
20170815 07:33:35-!- irker735 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170815 08:26:23-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170815 08:38:05-!- Kwandulin [~Kwandulin@p200300E453CC3B84E1E632B10B9CFD51.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170815 08:59:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170815 09:03:59-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170815 09:09:19-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20170815 09:38:25-!- Kwandulin [~Kwandulin@p200300E453CC3B84E1E632B10B9CFD51.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170815 09:46:28-!- aidanhs [~aidanhs@81.4.110.234] has quit [Ping timeout: 240 seconds]
20170815 09:49:41-!- Kwandulin [~Kwandulin@p200300E453CC3B84E1E632B10B9CFD51.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170815 09:51:03-!- aidanhs [~aidanhs@81.4.110.234] has joined #wesnoth-dev
20170815 09:55:06-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170815 09:59:18-!- Kwandulin [~Kwandulin@p200300E453CC3B84E1E632B10B9CFD51.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170815 10:37:52-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170815 10:39:08-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20170815 10:47:11-!- Kwandulin [~Kwandulin@p200300E453CC3B84E1E632B10B9CFD51.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170815 10:48:09-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170815 10:52:10-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170815 10:56:22-!- higgins [~higgins@68.ip-149-56-14.net] has quit [Write error: Connection reset by peer]
20170815 11:20:14-!- higgins [~higgins@68.ip-149-56-14.net] has joined #wesnoth-dev
20170815 12:04:02-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170815 12:06:03-!- Kwandulin [~Kwandulin@p200300E453CC3B84E1E632B10B9CFD51.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170815 12:15:16-!- Bonobo [~Bonobo@203.220.138.162] has quit [Ping timeout: 240 seconds]
20170815 12:37:54-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170815 13:38:04-!- gfgtdf [~chatzilla@x4e3689a8.dyn.telefonica.de] has joined #wesnoth-dev
20170815 13:58:29-!- Kwandulin [~Kwandulin@p200300E453CC3B84E1E632B10B9CFD51.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170815 14:13:01-!- irker092 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170815 14:13:01< irker092> wesnoth: gfgtdf wesnoth:master c41e57ddb9f3 / src/units/unit.cpp: reset units variables mods table before applying modifications https://github.com/wesnoth/wesnoth/commit/c41e57ddb9f3264f472640bac2d8f46209847e66
20170815 14:17:51-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170815 14:21:38-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20170815 14:51:30-!- Kwandulin [~Kwandulin@p200300E453CC3B84E1E632B10B9CFD51.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170815 14:53:14-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170815 15:03:25-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170815 15:22:08-!- gfgtdf [~chatzilla@x4e3689a8.dyn.telefonica.de] has quit [Ping timeout: 246 seconds]
20170815 15:30:22-!- travis-ci [~travis-ci@ec2-54-144-195-55.compute-1.amazonaws.com] has joined #wesnoth-dev
20170815 15:30:23< travis-ci> wesnoth/wesnoth#14696 (master - c41e57d : gfgtdf): The build is still failing.
20170815 15:30:23< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/264761607
20170815 15:30:23-!- travis-ci [~travis-ci@ec2-54-144-195-55.compute-1.amazonaws.com] has left #wesnoth-dev []
20170815 15:43:19-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit []
20170815 15:44:34-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170815 15:56:37-!- Kwandulin [~Kwandulin@p200300E453CC3B84E1E632B10B9CFD51.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170815 16:01:44-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170815 16:04:43-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Client Quit]
20170815 16:08:40-!- JyrkiVesterinen [~jyrki@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170815 16:23:27-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170815 16:23:27< Appveyor> The Battle for Wesnoth (Visual Studio 2017) - Release gfgtdf c41e57d: reset units variables mods table before applying modifications Failed
20170815 16:23:27< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-125
20170815 16:23:31-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170815 16:29:49< Soliton> gfgtdf: i'll see about fixing replay.wesnoth.org/1.13 this week. haven't gotten so far as to see what changed yet though.
20170815 16:30:45-!- Kwandulin [~Kwandulin@p200300E453CC3B84E1E632B10B9CFD51.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170815 16:34:22-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170815 16:34:22< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release gfgtdf c41e57d: reset units variables mods table before applying modifications Failed
20170815 16:34:22< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-432
20170815 16:34:26-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170815 16:40:14-!- LowenGlam [uid1929@gateway/web/irccloud.com/x-ndwujprftpvttgkj] has quit [Quit: Connection closed for inactivity]
20170815 16:44:34< irker092> wesnoth: Jyrki Vesterinen wesnoth:master 78f0ef8d6cdd / src/utils/ (irdya_datetime.cpp irdya_datetime.hpp): Fix build of unit tests https://github.com/wesnoth/wesnoth/commit/78f0ef8d6cdd5536f8b5b3bca71b772fa0dcad28
20170815 16:45:17-!- JyrkiVesterinen [~jyrki@85-23-197-3.bb.dnainternet.fi] has quit [Quit: Rebooting]
20170815 16:45:32-!- mjs-de [~mjs-de@x4db67418.dyn.telefonica.de] has joined #wesnoth-dev
20170815 16:47:08-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170815 16:58:32< vultraz_iOS> i don't particularly like the change to save the viewport in the savefile
20170815 16:59:48< vultraz_iOS> would be a lot better to restore old scroll-to-leader behavior
20170815 17:00:36< vultraz_iOS> problem is again edge scrolling
20170815 17:00:47< vultraz_iOS> it means your viewport will now most often restore top-left
20170815 17:00:50< vultraz_iOS> to*
20170815 17:13:27-!- gfgtdf [~chatzilla@x4e3689a8.dyn.telefonica.de] has joined #wesnoth-dev
20170815 17:18:12< gfgtdf> 20170815 16:29:49< Soliton> gfgtdf: i'll see about fixing replay.wesnoth.org/1.13 this week. haven't gotten so far as to see what changed yet though.
20170815 17:19:45< gfgtdf> Soliton: it's just a guess but i'd think that it'S becasue the format of the replay stored savefiles has changes: the [side]s is now no longer at toplevel or replay_start, instead it's inside [scenario] or [snapshot]
20170815 17:20:32< gfgtdf> 20170815 17:00:47< vultraz_iOS> it means your viewport will now most often restore top-left
20170815 17:20:54< gfgtdf> vultraz_iOS: i didn't observe that oen yet, do you often scroll to top-left before saving the game ?
20170815 17:21:40< vultraz_iOS> eh tbf i should do more testing
20170815 17:31:26-!- clavi [~clavi@v22017034422546657.goodsrv.de] has quit [Quit: ZNC - http://znc.in]
20170815 17:33:21< Soliton> gfgtdf: i think it should work for new replays now. still trying to figure out how to easily regenerate stuff for the previous days. do you know since what day it's broken?
20170815 17:33:48< gfgtdf> Soliton: quite long probaby, maybe even 1.13.0
20170815 17:35:00< Soliton> yeah, looks like it.
20170815 17:36:17< gfgtdf> Soliton: it'd also be nice if it shows the modifications used, quierring the used modidfication should use the same way as queriing the era
20170815 17:36:38< Soliton> right, i'll check that out.
20170815 17:37:18< Soliton> do you have a replay that uses modifications?
20170815 17:38:41< gfgtdf> Soliton: you mean a link to the replays server or a local file?
20170815 17:39:13< Soliton> if you can upload a local file that was saved by wesnothd that's fine, too.
20170815 17:39:48< gfgtdf> i's prolbaly easier to quickly stasrt a mp game
20170815 17:41:25< Soliton> sure.
20170815 17:42:41< irker092> wesnoth: Charles Dang wesnoth:master 99d854ff219f / src/utils/ (irdya_datetime.cpp irdya_datetime.hpp): Irdya Datetime: formatting cleanup https://github.com/wesnoth/wesnoth/commit/99d854ff219f944c51d7f2f275aa988b1511c74b
20170815 17:42:42< gfgtdf> hmm i'm trying but #1887 comes in the way ...might take soem time
20170815 17:44:30< gfgtdf> ok just started and ended a game, now waiting for it to appear in replays.wesnoth.org
20170815 17:47:38< gfgtdf> Soliton: is it normal that it didn't epprar yet or did i do it wrongly?
20170815 17:49:23< Soliton> on what server did you play?
20170815 17:50:02< Soliton> trunk looks like.
20170815 17:50:05< gfgtdf> 1.13.8+dev
20170815 17:50:29< gfgtdf> vultraz_iOS: did you usea  tool for that commit ?
20170815 17:50:47< gfgtdf> vultraz_iOS: i don't liek how it puts the whole make_enum on one line.
20170815 17:50:50< gfgtdf> like*
20170815 17:50:56< vultraz_iOS> tool + manual
20170815 17:51:04< vultraz_iOS> i could have reverted that part
20170815 18:01:00-!- moongazer [~moongazer@59.95.138.238] has joined #wesnoth-dev
20170815 18:11:04< gfgtdf> Soliton: the replays nwo appears at http://replays.wesnoth.org/trunk/20170815/
20170815 18:11:15< gfgtdf> Soliton: but i can see neigher players nor modfications
20170815 18:11:32< Soliton> yes, i'm working on it...
20170815 18:11:53< Soliton> i only fixed the players for 1.13, didn't think about trunk.
20170815 18:12:43< gfgtdf> hmm ok i though they are ahndled by the same script.
20170815 18:14:22< Soliton> sure but now they have to be handled differently based on the version.
20170815 18:16:16-!- Kwandulin [~Kwandulin@p200300E453CC3B84E1E632B10B9CFD51.dip0.t-ipconnect.de] has quit [Ping timeout: 276 seconds]
20170815 18:18:00< Soliton> so i should display [modification] id=?
20170815 18:18:23< Soliton> wait there is another tag.
20170815 18:18:52< Soliton> [modification] name= i guess
20170815 18:19:34< gfgtdf> Soliton: i thought of [multiplayer]active_mods=, but name it problay better.
20170815 18:20:17< Soliton> oh, but then i have to figure out which one is active?
20170815 18:20:42< Soliton> sounds like active_mods it is.
20170815 18:20:44< gfgtdf> Soliton: i don't think so, [modification]s are problems exactly the same as [multiplayer]active_mods=
20170815 18:21:12< gfgtdf> Soliton: but i'm not 100% sure wher the [modification]s come from
20170815 18:21:15< gfgtdf> where*
20170815 18:21:33< Soliton> can there be several mods (active)?
20170815 18:21:44-!- travis-ci [~travis-ci@ec2-50-17-108-208.compute-1.amazonaws.com] has joined #wesnoth-dev
20170815 18:21:45< travis-ci> wesnoth/wesnoth#14697 (master - 78f0ef8 : Jyrki Vesterinen): The build was fixed.
20170815 18:21:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/264818108
20170815 18:21:46-!- travis-ci [~travis-ci@ec2-50-17-108-208.compute-1.amazonaws.com] has left #wesnoth-dev []
20170815 18:22:04< gfgtdf> Soliton: yes
20170815 18:22:24< Soliton> can you make a replay with several?
20170815 18:22:30< gfgtdf> Soliton: ok it comes form here https://github.com/wesnoth/wesnoth/blob/b4dc11ce36e282458e2891a36baddb6dab13186d/src/game_initialization/mp_game_utils.cpp#L112
20170815 18:22:34< gfgtdf> Soliton: ok
20170815 18:23:22< Soliton> so only the active ones should be there, ok.
20170815 18:24:02< Soliton> well, i can try [modification] name= but that's probably a bit more complicated.
20170815 18:24:32< Soliton> i'll continue later...
20170815 18:24:37< gfgtdf> Soliton:  ok i made one with multipel mods
20170815 18:24:49< Soliton> tranks.
20170815 18:25:37< Ravana_> when you use modification name, then it would also call for era name. Though, I would prefer both using id
20170815 18:26:36< gfgtdf> then it's problbl easier to use active_mods which is basicalyl acomme seperated list of thes modifications ids
20170815 18:26:58< gfgtdf> id's probably have the advantage of beeing language indenpendent.
20170815 18:27:24< gfgtdf> i never understood which parts og the wml are sended translated wnd which not.
20170815 18:27:36< gfgtdf> of*
20170815 18:29:47< gfgtdf> hmm thinking about it propably 'abc's game' is poblems the only string that is not sended in english
20170815 18:33:52< Soliton> ok, rebuilt with active_mods now: http://replays.wesnoth.org/trunk/20170815/
20170815 18:34:14 * Soliton goes home
20170815 18:34:22< gfgtdf> looks good
20170815 18:52:42-!- Kwandulin [~Kwandulin@p200300E453CC3BCFD036B4E3EF6AF7EF.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170815 19:03:15-!- Netsplit *.net <-> *.split quits: JyrkiVesterinen, higgins
20170815 19:03:44-!- Netsplit over, joins: JyrkiVesterinen
20170815 19:03:58-!- Netsplit over, joins: higgins
20170815 19:06:32-!- minzbonbon [~min@meta23.net] has quit [Ping timeout: 260 seconds]
20170815 19:08:41-!- minzbonbon [~min@meta23.net] has joined #wesnoth-dev
20170815 19:09:13-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170815 19:22:04-!- travis-ci [~travis-ci@ec2-54-198-114-94.compute-1.amazonaws.com] has joined #wesnoth-dev
20170815 19:22:05< travis-ci> wesnoth/wesnoth#14698 (master - 99d854f : Charles Dang): The build has errored.
20170815 19:22:05< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/264839084
20170815 19:22:05-!- travis-ci [~travis-ci@ec2-54-198-114-94.compute-1.amazonaws.com] has left #wesnoth-dev []
20170815 19:22:34-!- moongazer [~moongazer@59.95.138.238] has quit [Quit: Leaving]
20170815 19:24:39< irker092> wesnoth: Ignacio R. Morelle wesnoth:master 6cdfe9a7d2fe / data/tools/unit_tree/html_output.py: wmlunits: "Language" hasn't been in the main textdomain for two stable series https://github.com/wesnoth/wesnoth/commit/6cdfe9a7d2fe08e9a2aac86ef70dc65b452c260a
20170815 19:24:42< irker092> wesnoth: Ignacio R. Morelle wesnoth:master 5a675ec25d20 / data/tools/wmlunits: wmlunits: Psyco is a defunct project and it never supported Python 3 https://github.com/wesnoth/wesnoth/commit/5a675ec25d207fe376e22a1f0c1209e0597e3dad
20170815 19:26:18< vultraz_iOS> well this is fun
20170815 19:27:09< vultraz_iOS> need to figure out how to deal with the fact that the window builders are completely different from every other widget's builder
20170815 19:27:38< gfgtdf> why that ? what are you working on 
20170815 19:31:54< vultraz_iOS> gfgtdf: im trying to clean up the widget initialization process by using the second styled_widget ctor here: https://github.com/wesnoth/wesnoth/blob/master/src/gui/widgets/styled_widget.hpp#L47-L48
20170815 19:32:52-!- Kwandulin [~Kwandulin@p200300E453CC3BCFD036B4E3EF6AF7EF.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170815 19:35:38< vultraz_iOS> it seems mordante had intended it to be used with his "new" listbox impl but since he marked the no arg ctor as deprecated i assume he eventually intended to use it everywhere
20170815 19:35:47< vultraz_iOS> https://github.com/wesnoth/wesnoth/commit/3abebe12f3a566601baae1ea71049b2f4f4f6f87
20170815 19:39:17-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170815 19:40:52-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170815 19:43:41< gfgtdf> hmm ok
20170815 19:44:12< gfgtdf> vultraz_iOS: celmin said, that #1874 basically waits for you to test it.
20170815 19:44:22< vultraz_iOS> yeah...
20170815 19:44:25< vultraz_iOS> i should test it
20170815 19:44:30< vultraz_iOS> >_>
20170815 19:47:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170815 19:49:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170815 19:56:39-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170815 20:12:47< vultraz_iOS> yeah I pretty much have no idea how to handle this with the window
20170815 20:13:13< vultraz_iOS> the styled_widget takes a styled_widget builder
20170815 20:13:20< vultraz_iOS> most widget builders inherit from it
20170815 20:13:28< vultraz_iOS> but its stuff doesn't make sense for window
20170815 20:14:35< vultraz_iOS> i suppose i could make the styled_widget take an instance of builder_widget
20170815 20:14:41< vultraz_iOS> which is the very base class
20170815 20:18:07< vultraz_iOS> well, would kinda have to
20170815 20:18:41< vultraz_iOS> since the inheritance chain is widget -> styled_widget -> container_base -> panel -> window
20170815 20:20:59< vultraz_iOS> and window is a weird oddity here
20170815 20:21:49< vultraz_iOS> it keeps a builder_widget class in implementation:: so as to satisfy REGISTER_WIDGET
20170815 20:22:01< vultraz_iOS> er
20170815 20:22:04< vultraz_iOS> builder_window
20170815 20:22:13< vultraz_iOS> but the *real* builder_window class is free-standing
20170815 20:24:38< vultraz_iOS> which is rather misleading
20170815 20:24:48< vultraz_iOS> it means an invalid builder is registered to builder_widget_lookup()
20170815 20:56:34-!- travis-ci [~travis-ci@ec2-54-81-168-26.compute-1.amazonaws.com] has joined #wesnoth-dev
20170815 20:56:35< travis-ci> wesnoth/wesnoth#14699 (master - 5a675ec : Ignacio R. Morelle): The build has errored.
20170815 20:56:35< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/264872381
20170815 20:56:35-!- travis-ci [~travis-ci@ec2-54-81-168-26.compute-1.amazonaws.com] has left #wesnoth-dev []
20170815 21:20:10-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170815 21:20:41-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170815 21:25:05-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170815 21:29:55-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 255 seconds]
20170815 21:33:31-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170815 21:37:09-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev
20170815 22:07:22< irker092> wesnoth: Ignacio R. Morelle wesnoth:master 598575478678 / data/tools/wmlunits: wmlunits: Allow detecting wmlunits with the __WMLUNITS__ preprocessor symbol https://github.com/wesnoth/wesnoth/commit/598575478678da53523613bb00f0403e0747fddc
20170815 22:17:32-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Ping timeout: 255 seconds]
20170815 22:19:40-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20170815 22:21:01-!- mjs-de [~mjs-de@x4db67418.dyn.telefonica.de] has quit [Remote host closed the connection]
20170815 22:21:58-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170815 22:35:49-!- Bonobo [~Bonobo@203.220.138.162] has joined #wesnoth-dev
20170815 22:43:33< irker092> wesnoth: ln-zookeeper wesnoth:master 42cc852b1cb3 / data/campaigns/Under_the_Burning_Suns/images/units/quenoth/ (8 files): UtBS: New sprites for Quenoth Mystic and Flanker lines, by Kwandulin https://github.com/wesnoth/wesnoth/commit/42cc852b1cb34d77e476ae720621b5640db6d99d
20170815 22:53:55< shadowm> Well, it does seem like the issue with AtS and IftU becoming WML blackholes for wmlunits is actually caused by them defining more than one [campaign] entry.
20170815 22:54:30< shadowm> Because now that I made it so they only define a single dummy campaign when handled by wmlunits, there's no blackholing going on.
20170815 22:54:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170815 22:55:11< shadowm> elias: ^ (Although I get the feeling you're missing all these highlights.)
20170815 22:55:18< gfgtdf> zookeeper: is it somehow possible to group macors so tht i can undef them togetther? like #define A.B .... #enddef   #define A.C .... #enddef spo that #undef A will undef both A.B and A.C ?
20170815 22:55:30< shadowm> No.
20170815 22:56:32< gfgtdf> hmm will file a featurerequesst then.
20170815 22:58:05< gfgtdf> shadowm: do the macros get cleared  after processing a specific addon or coudl iut be that macros from a previousl addons are still defines when my addon is processed?
20170815 22:58:33< gfgtdf> shadowm: i'm taking in particular about multipler stuff where stuff is usualyl not hidden behing #ifdefs
20170815 22:59:09-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170815 23:00:52< gfgtdf> anyways made fr #1902
20170815 23:01:40< shadowm> I feel like you know the answer to your question already if you consider the existence of several "mod" add-ons in single-player for 1.12.
20170815 23:02:40< gfgtdf> shadowm: well they usualyl don't work my macros but by global [lua] tags, 
20170815 23:03:23< shadowm> I haven't looked at the C++ in a year and I don't intend to do so right now and hopefully never again.
20170815 23:04:09< gfgtdf> s/work my/work by 
20170815 23:22:22< zookeeper> gfgtdf, any specific usecase which you think would warrant such a feature?
20170815 23:22:40< zookeeper> it's not like having 10 #undefs in a row is bad code or anything
20170815 23:25:54< gfgtdf> zookeeper: well it's sureley annoying to have to write each macro twice, specially if 'twice'  here means in 2 different places/files. You have to keep track of all your macros used
20170815 23:25:55< zookeeper> i can't think of any reason not to allow #undef to handle regexes, though, or maybe just a wildcard (#undef foo*), except that inevitably someone is going to inadvertently going to use it... wrong.
20170815 23:26:29< gfgtdf> zookeeper: you know the ansewer to my answer above? (macros across addons) ?
20170815 23:26:40< gfgtdf> s/to my answer/to my question
20170815 23:30:32< zookeeper> actually, no
20170815 23:31:35< zookeeper> but, i guess they are cleared? i'd expect a flood of "redefine without undefine" warnings otherwise.
20170815 23:32:55< gfgtdf> unrelated issue: i get wanrings: Could not load music file '.../data/core/music/journeys_end.ogg': Failed loading libmodplug-1.dll: Das angegebene Modul wurde nicht gefunden. 
20170815 23:33:23< gfgtdf> ('module not found' is the translation of the german part)
20170815 23:36:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170815 23:36:55< vultraz_iOS> zookeeper: well they serve better than the old ones at least
20170815 23:38:44< zookeeper> vultraz_iOS, 
20170815 23:38:45< zookeeper> ?
20170815 23:38:55< vultraz_iOS> the sprites
20170815 23:38:58< zookeeper> oh
20170815 23:41:35-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170815 23:59:35-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
--- Log closed Wed Aug 16 00:00:21 2017