--- Log opened Sun Aug 20 00:00:19 2017
20170820 00:50:50-!- irker058 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170820 01:10:41-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170820 01:11:39-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:4928:ddf1:45b8:3f58] has quit [Remote host closed the connection]
20170820 01:14:27 * celticminstrel appears, accompanied by cicadas. >_>
20170820 01:22:30 * mattsc keeps an eye out for all them chaotic units
20170820 01:23:32< celticminstrel> ?
20170820 01:24:39< mattsc> cicadas chrip (or whatever they do) at evening twilight, don’t they?
20170820 01:24:45< mattsc> *chirp
20170820 01:25:21< celticminstrel> I think you're thinking of crickets.
20170820 01:25:41< mattsc> hmm …  maybe
20170820 01:25:50< celticminstrel> Mind you, crickets might've been better, since it's night here...
20170820 01:26:20< mattsc> summer’s almost over if it’s dark there already …
20170820 01:26:30< celticminstrel> EST?
20170820 01:26:44< celticminstrel> Though I guess it is almost over.
20170820 01:26:47< vultraz_iOS> celmin is more north
20170820 01:26:51< mattsc> your on standard time ??
20170820 01:26:58< celticminstrel> ...?
20170820 01:27:00< mattsc> *you’re  (grrr)
20170820 01:27:10< celticminstrel> By standard do you mean not DST?
20170820 01:27:26< mattsc> I mean EST vs. EDT, yes
20170820 01:27:29< celticminstrel> Also yes, more north assuming you're in the US (other than Alaska).
20170820 01:27:54< celticminstrel> Okay fine, EDT then.
20170820 01:28:24< mattsc> yeah, I guess you might be more south than I am …
20170820 01:29:02< mattsc> sunset here’s at 8:16 pm today, which is much earlier than it used to be
20170820 01:30:28< celticminstrel> Huh? I can't be more south unless you're in Alaska.
20170820 01:30:49< celticminstrel> I think.3
20170820 01:31:43< mattsc> I’m not in Alaska.
20170820 01:32:39< mattsc> Or anywhere in that country.  ;)
20170820 01:33:12< celticminstrel> Oh, well in that case I have no idea.
20170820 02:02:34< mattsc> Btw, this AI stuff is really too hard for me.  Here’s a situation from a game I just watched Fred play against the default AI:  http://imgur.com/a/jyMUy
20170820 02:03:42< mattsc> There are no other units, either own or enemy, that can get there, so what do we do?  Sure, let’s leave the village with the already-poisoned archer and attack the assassin from the grassland in the south.  (dull)
20170820 02:37:07< vultraz_iOS> celticminstrel: pls merge https://github.com/wesnoth/wesnoth/pull/1907
20170820 02:38:22-!- irker250 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170820 02:38:22< irker250> wesnoth: Sofartin wesnoth:master b441b375b480 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Fixed Xcode project build (#1907) https://github.com/wesnoth/wesnoth/commit/b441b375b480f2aff8385845b59a59e7e3c6ab6d
20170820 02:42:27< vultraz_iOS> goddammit
20170820 02:42:39< celticminstrel> Hey, you asked me to merge it so I merged it.
20170820 02:42:47< vultraz_iOS> no
20170820 02:42:49< vultraz_iOS> something else
20170820 02:43:03< vultraz_iOS> i can't even launch wesnoth in gdb for some reason
20170820 02:44:52< vultraz_iOS> and im getting a weird crash
20170820 02:44:53< vultraz_iOS> >_>
20170820 02:55:45-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:4928:ddf1:45b8:3f58] has joined #wesnoth-dev
20170820 02:58:43< vultraz_iOS> for some reason this line is causing a crash
20170820 02:58:44< vultraz_iOS> item_position_ = (item_position_ + step_size_ - 1) / step_size_;
20170820 02:58:45< vultraz_iOS> :|
20170820 02:59:03< celticminstrel> What is the type of item_position_?
20170820 02:59:23< vultraz_iOS> unsigned
20170820 02:59:49< celticminstrel> And step_size_ I assume is also an integer
20170820 03:00:00< celticminstrel> So the only possible way that that could crash is if "this" is null.
20170820 03:00:11< celticminstrel> In other words, the true cause of the crash is up a stack frame.
20170820 03:00:34< celticminstrel> Something is calling x->whatever_that_function_is() where x is null.
20170820 03:00:36< vultraz_iOS> and i can't launch the debugger :) :) :) :)
20170820 03:01:14< celticminstrel> Oh wait, there might be one other way that that could crash, I suppose. I'm not sure what happens when you divide by zero.
20170820 03:01:29< celticminstrel> Is there any chance that step_size_ is zero?
20170820 03:01:59< vultraz_iOS> possibly
20170820 03:02:49< celticminstrel> I think integer zero division might actually be a crash condition though.
20170820 03:03:02< celticminstrel> (IIRC it's even a compile error if you write something like "x / 0"?)
20170820 03:03:06< vultraz_iOS> HMM
20170820 03:03:43< vultraz_iOS> so it looks like unisgned foo = cfg["bar"] will result in 0?
20170820 03:04:03< celticminstrel> Well, it would if bar were null, probably.
20170820 03:04:10< celticminstrel> ie, the attribute did not exist
20170820 03:04:28< celticminstrel> Or if the attribute was something other than a number.
20170820 03:05:07< vultraz_iOS> crash fixed \o/
20170820 03:05:10< vultraz_iOS> praise the celmin
20170820 03:05:17< celticminstrel> \o/
20170820 03:05:45< vultraz_iOS> one would think division by 0 would throw an exception
20170820 03:06:20-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:4928:ddf1:45b8:3f58] has quit [Remote host closed the connection]
20170820 03:07:17< celticminstrel> Nope.
20170820 03:07:39< celticminstrel> Also, it depends on whether it's an integer or a floating-point number.
20170820 03:08:01< celticminstrel> It's a hardware exception for the former IIRC; in the latter case, it just yields NaN.
20170820 03:08:24< celticminstrel> Assuming it is a hardware exception, it's actually possible to catch it, though.
20170820 03:09:22< celticminstrel> I could be confused though. I know you can actually configure things so that floating-point division by zero causes a hardware exception instead of returning a NaN, so I might be mixing that up with integers.
20170820 03:11:11< celticminstrel> I notice wedge009 has been adding labels to issues. Thanks!
20170820 03:16:47-!- Bonobo [~Bonobo@203.220.138.162] has joined #wesnoth-dev
20170820 03:22:36-!- JyrkiVesterinen [~jyrki@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170820 03:24:24< JyrkiVesterinen> celticminstrel: Hardware exceptions can't be caught. On Unix, integer division by zero raises the SIGFPE signal, which crashes the process by default.
20170820 03:24:24< JyrkiVesterinen> (SIGFPE stands for "floating point exception". Lovely. Unix has way too much legacy cruft.)
20170820 03:25:00< JyrkiVesterinen> Catching the div-by-zero exception might be possible on Windows with SEH, but it's very complicated and I strongly don't recommend trying.
20170820 03:25:56< JyrkiVesterinen> Floating point division by zero gives you positive infinity if you divide a positive number by zero; negative infinity if the dividend is negative; and NaN if the dividend is zero.
20170820 03:27:45< JyrkiVesterinen> Except if you have configured the processor to raise a hardware exception in that situation.
20170820 03:35:23< vultraz_iOS> alright, i think that solves everything
20170820 03:35:53< vultraz_iOS> 453(+) 489(-) 
20170820 03:47:12-!- JyrkiVesterinen [~jyrki@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170820 03:56:05-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170820 04:27:42-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20170820 04:28:26-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170820 04:28:30-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Client Quit]
20170820 04:34:51< irker250> wesnoth: Charles Dang wesnoth:some_gui2_refactoring 12c904ccae73 / src/gui/widgets/settings.cpp: GUI2/Settings: minor formatting cleanup https://github.com/wesnoth/wesnoth/commit/12c904ccae734129f0b436f3b942c81a168c0bd6
20170820 04:34:54< irker250> wesnoth: Charles Dang wesnoth:some_gui2_refactoring 9275679a9971 / src/gui/core/ (window_builder.cpp window_builder.hpp): GUI2/Window Builder: added function to generate a single widget instance with it https://github.com/wesnoth/wesnoth/commit/9275679a997114c41d215254bd1725b1c5236021
20170820 04:34:57< irker250> wesnoth: Charles Dang wesnoth:some_gui2_refactoring 13f8359da59f / src/gui/ (69 files in 2 dirs): GUI2: refactored widget initialization process https://github.com/wesnoth/wesnoth/commit/13f8359da59f5cd065930df7e91592fc9a6c21b1
20170820 04:35:00< irker250> wesnoth: Charles Dang wesnoth:some_gui2_refactoring 4460647cf972 / src/gui/ (core/window_builder.cpp widgets/window.cpp widgets/window.hpp): GUI2/Window: pass definition pointer to ctor instead of individual arguments https://github.com/wesnoth/wesnoth/commit/4460647cf972cf029452f1158c88917f32b9fef4
20170820 04:35:03< irker250> wesnoth: Charles Dang wesnoth:some_gui2_refactoring d916218c0f71 / src/gui/core/ (register_widget.hpp window_builder.cpp window_builder.hpp): GUI2/Window Builder: renamed a function for clarity and used it in a few more pl https://github.com/wesnoth/wesnoth/commit/d916218c0f71ef459b7b67dba4b5b14070b72038
20170820 04:35:06< irker250> wesnoth: Charles Dang wesnoth:some_gui2_refactoring 7d71842b20f0 / src/gui/ (59 files in 2 dirs): GUI2: allow REGISTER_WIDGET to implement get_control_type overrides https://github.com/wesnoth/wesnoth/commit/7d71842b20f09407921d2866efd0fc628a8fb3fc
20170820 04:51:44-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170820 05:10:05-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170820 05:35:28-!- Kwandulin [~Kwandulin@p200300E453CC3B9EFD0F9F0C2C104A03.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170820 05:38:08-!- travis-ci [~travis-ci@ec2-54-242-193-104.compute-1.amazonaws.com] has joined #wesnoth-dev
20170820 05:38:09< travis-ci> wesnoth/wesnoth#14730 (some_gui2_refactoring - 7d71842 : Charles Dang): The build failed.
20170820 05:38:09< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/266428487
20170820 05:38:09-!- travis-ci [~travis-ci@ec2-54-242-193-104.compute-1.amazonaws.com] has left #wesnoth-dev []
20170820 05:58:10-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170820 05:58:41-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170820 06:43:42-!- Kwandulin2 [~Kwandulin@p200300E453CC3B9E9DB0E0DF0D35C999.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170820 06:44:28-!- Kwandulin [~Kwandulin@p200300E453CC3B9EFD0F9F0C2C104A03.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20170820 07:15:34-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:4928:ddf1:45b8:3f58] has joined #wesnoth-dev
20170820 07:15:47-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:4928:ddf1:45b8:3f58] has quit [Remote host closed the connection]
20170820 07:16:29-!- mjs-de [~mjs-de@x4e312c14.dyn.telefonica.de] has joined #wesnoth-dev
20170820 07:30:21-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170820 07:36:26 * zookeeper always thought that in the ToD images the sun goes left to right, but apparently it's right to left
20170820 07:41:11-!- markus_ [~mjs-de@x4db60819.dyn.telefonica.de] has joined #wesnoth-dev
20170820 07:41:15< zookeeper> also, it'd be mildly convenient if [time_area]/[time] could set the time to be illuminated/darkened, so if you have a lighthouse that lits up the surrounding hexes, you wouldn't need to change the actual ToD cycle for those locations but could keep the same schedule as on the rest of the map, only with illumination.
20170820 07:41:21-!- mjs-de [~mjs-de@x4e312c14.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170820 07:42:18< zookeeper> it's just very slightly odd that when it's night on the map, the locations around the lighthouse are dusk/dawn... whereas they really should be illuminated night.
20170820 07:42:30< zookeeper> but AFAICT there's no way to currently do that
20170820 07:48:13-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170820 07:51:33-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:4928:ddf1:45b8:3f58] has joined #wesnoth-dev
20170820 07:56:52-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:4928:ddf1:45b8:3f58] has quit [Ping timeout: 276 seconds]
20170820 08:21:58-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170820 09:51:22< JyrkiVesterinen> Regarding the static analysis results in #1877, it turned out that this one is pretty bad.
20170820 09:51:23< JyrkiVesterinen>                 if (!current_->get_chunk()) {
20170820 09:51:23< JyrkiVesterinen>                      ^~~~~~~~~~~~~~~~~~~~~
20170820 09:51:37< JyrkiVesterinen> "warning: Use of memory after it is freed"
20170820 09:52:06< JyrkiVesterinen> Debugging showed that it occurs in practice. The WML preprocessor relies on use-after-free.
20170820 09:52:37< JyrkiVesterinen> For some reason, setting current_ to nullptr after deleting it causes the game to crash on startup. I'm investigating.
20170820 10:00:07< wedge009> celticminstrel: Only if I see it doesn't have any and I can see where it should go. Wish I had more time for investigation and actual bug-fixing.
20170820 10:10:24< JyrkiVesterinen> Okay... turns out that the code actually doesn't cause an use-after-free, thanks to a rather horrifying solution.
20170820 10:10:25< JyrkiVesterinen> https://github.com/wesnoth/wesnoth/blob/b441b375b480f2aff8385845b59a59e7e3c6ab6d/src/serialization/preprocessor.cpp#L424
20170820 10:10:51< JyrkiVesterinen> The destructor removes the reference to the preprocessor and replaces it with a valid reference.
20170820 10:12:32< JyrkiVesterinen> I'll refactor the code to get rid of that.
20170820 10:14:37-!- irker250 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170820 10:29:46-!- sevu [~Shiki@p548552B5.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170820 10:30:25-!- irker527 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170820 10:30:25< irker527> wesnoth: Jyrki Vesterinen wesnoth:master 2c07b397f9d7 / src/ (9 files in 8 dirs): Address feedback from Clang static analyzer (#1877) https://github.com/wesnoth/wesnoth/commit/2c07b397f9d71bb2fad73ac2db9595eab7623cd4
20170820 10:31:05-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170820 10:36:18-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170820 10:45:05-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20170820 10:46:11-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20170820 10:53:18< matthiaskrgr> hrmm, asan should have caught that use after free though >:/ 
20170820 10:55:33-!- markus_ is now known as mjs-de
20170820 10:56:04< matthiaskrgr> ok so its a fn?
20170820 10:57:08-!- mjs-de [~mjs-de@x4db60819.dyn.telefonica.de] has quit [Remote host closed the connection]
20170820 11:30:44-!- Kwandulin2 [~Kwandulin@p200300E453CC3B9E9DB0E0DF0D35C999.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170820 12:00:58< matthiaskrgr> hm, #1877  auto closed  as 2c07b397f9d7 was committed, is that intended?
20170820 12:02:25-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170820 12:04:09< JyrkiVesterinen> matthiaskrgr: Yes, the old code worked fine. It just looked wrong. (And really, it's perfectly reasonable to assume that the destructor doesn't remove references to the object.)
20170820 12:04:22< JyrkiVesterinen> And yes, I closed #1877 on purpose.
20170820 12:04:53< matthiaskrgr> ok
20170820 12:54:25-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170820 13:07:00< DeFender1031> hey celticminstrel 
20170820 13:07:04< DeFender1031> Long time no see.
20170820 13:08:42< DeFender1031> I wanted to thank you last week for taking the whole deprecation thing I proposed and running with it. (I got an automated email informing me that you had mentioned me in a commit log.)
20170820 13:09:27< celticminstrel> It's not done yet, mind you.
20170820 13:09:35< DeFender1031> I know. Just lua.
20170820 13:09:40< DeFender1031> Still, thanks.
20170820 13:12:03< DeFender1031> I did want to say that I think that even l1 deprecation should be given a version number.
20170820 13:12:18< DeFender1031> Indicating the first one that meets the minimum deprecation period.
20170820 13:12:53< DeFender1031> So like, if it's currently version 1.13, even l1 deprecation should take 1.16 as its parameter.
20170820 13:13:18< DeFender1031> that way there's a record of how long it's been deprecated so one knows whether it can be removed outright if necessary or not.
20170820 13:14:31< celticminstrel> Okay.
20170820 13:14:48< celticminstrel> Should it affect the actual message?
20170820 13:14:58< celticminstrel> Or can it just be there to document it for people who may be considering removing it?
20170820 13:22:49-!- Kwandulin [~Kwandulin@p200300E453CC3B9E9DB0E0DF0D35C999.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170820 13:27:05-!- Kwandulin [~Kwandulin@p200300E453CC3B9E9DB0E0DF0D35C999.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170820 13:31:16-!- irker527 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170820 13:32:48-!- Kwandulin [~Kwandulin@p200300E453CC3B9E9DB0E0DF0D35C999.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170820 13:45:01-!- Kwandulin [~Kwandulin@p200300E453CC3B9E9DB0E0DF0D35C999.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170820 13:50:57-!- Kwandulin [~Kwandulin@p200300E453CC3B9E9DB0E0DF0D35C999.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170820 14:02:27< DeFender1031> celticminstrel, hard to say... Might want to have the message say something like "may be removed without warning as early as version x" if it's before that version and just "may be removed without warning at any time" if it's after that version?
20170820 14:03:25< celticminstrel> Okay.
20170820 14:06:56< DeFender1031> also, I think I meant "without further warning", as we're already showing a warning...
20170820 14:07:12-!- DeFender [~DeFender1@93-172-23-172.bb.netvision.net.il] has joined #wesnoth-dev
20170820 14:11:13-!- DeFender [~DeFender1@93-172-23-172.bb.netvision.net.il] has quit [Excess Flood]
20170820 14:11:28-!- DeFender1031 [~DeFender1@93-172-23-172.bb.netvision.net.il] has quit [Ping timeout: 258 seconds]
20170820 14:11:39-!- DeFender [~DeFender1@93-172-23-172.bb.netvision.net.il] has joined #wesnoth-dev
20170820 14:13:19-!- DeFender [~DeFender1@93-172-23-172.bb.netvision.net.il] has quit [Client Quit]
20170820 14:13:29-!- DeFender [~DeFender1@93-172-23-172.bb.netvision.net.il] has joined #wesnoth-dev
20170820 14:13:48< DeFender> <DeFender1031> also, I think I meant "without further warning", as we're already showing a warning...
20170820 14:14:15< DeFender> Oh, hmm... that did go through it seems.
20170820 14:17:29-!- DeFender [~DeFender1@93-172-23-172.bb.netvision.net.il] has quit [Remote host closed the connection]
20170820 14:17:48-!- DeFender [~DeFender1@93-172-23-172.bb.netvision.net.il] has joined #wesnoth-dev
20170820 14:18:31-!- mjs-de [~mjs-de@x4db60819.dyn.telefonica.de] has joined #wesnoth-dev
20170820 14:20:58-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170820 14:22:08-!- DoctorFender1031 [~DeFender1@93-172-23-172.bb.netvision.net.il] has joined #wesnoth-dev
20170820 14:25:19-!- DeFender [~DeFender1@93-172-23-172.bb.netvision.net.il] has quit [Remote host closed the connection]
20170820 14:33:21-!- Bonobo [~Bonobo@203.220.138.162] has quit [Ping timeout: 240 seconds]
20170820 15:26:29-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170820 15:46:51-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170820 15:46:58-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170820 15:48:49-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170820 15:59:40< celticminstrel> I know vultraz_iOS requested a review from me, but I'd like to see others review it too, such as JyrkiVesterinen or gfgtdf.
20170820 15:59:51 * celticminstrel is in the middle of reviewing it now, FTR.
20170820 15:59:57< JyrkiVesterinen> Review of what?
20170820 16:00:04< celticminstrel> PR 1910.
20170820 16:00:28< JyrkiVesterinen> OK. I can have a look later on.
20170820 16:07:52-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:4928:ddf1:45b8:3f58] has joined #wesnoth-dev
20170820 16:16:49< vultraz_iOS> celticminstrel: it's not necessary for anything
20170820 16:16:54< vultraz_iOS> I'm just doing some cleanup
20170820 16:17:11< vultraz_iOS> Since I noticed this was obviously something mordante had started
20170820 16:22:27-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:4928:ddf1:45b8:3f58] has quit [Remote host closed the connection]
20170820 16:30:43-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170820 16:55:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170820 16:55:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170820 17:08:18-!- Kwandulin [~Kwandulin@p200300E453CC3B9E9DB0E0DF0D35C999.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170820 17:18:48< celticminstrel> I see.
20170820 17:18:56< celticminstrel> Well, I like the general idea, but sorta question the timing.
20170820 17:21:58< vultraz_iOS> I'm not fully satisfied
20170820 17:22:25< vultraz_iOS> with the build_single_widget_instance interface
20170820 17:23:08< vultraz_iOS> i wonder if i should add an associative map by using std::type_index
20170820 17:23:47< celticminstrel> I entertained the thought of making it a placement new, taking the builder as the placement argument, but... I'm not sure that's really a good idea.
20170820 17:24:13< vultraz_iOS> specifically I don't like having to do foo<T>("id")
20170820 17:24:49< celticminstrel> Actually, I suppose it'd even be a little uglier, as you'd end up with new(make_builder<T>(stuff) some_widget(maybe_more_stuff), though it would allow widgets to have multiple constructors while still making use of the builder for all of them.
20170820 17:25:06< celticminstrel> Oh, that should be a double close parenthesis after stuff.
20170820 17:25:33< celticminstrel> I dunno, maybe you could narrow that down somehow.
20170820 17:25:58< celticminstrel> Maybe there's a way to do away with the make_builder<T> bit and just have new(builder arguments) some_widget(widget arguments).
20170820 17:26:26< celticminstrel> Though I don't think there's any way to explicitly pass template arguments to a new operator?
20170820 17:27:28< celticminstrel> It'd be great if template<typename T> T* operator new(arguments); worked, meaning that the expression "new thing" would resolve the template type parameter T to "thing", but I bet it doesn't.
20170820 17:27:37< JyrkiVesterinen> "new(builder arguments) some_widget<T>(widget arguments)"?
20170820 17:27:59< celticminstrel> I think that would be passing template arguments to the constructor, not the new operator.
20170820 17:36:47< vultraz_iOS> JyrkiVesterinen: part of the reason I kept it as a widget was because the most common use of that function is a dialog swapping out an individual widget, and the function that does that takes a pointer
20170820 17:37:08< vultraz_iOS> it seems weird to do return *foo, then take address-of on the result
20170820 17:37:29< JyrkiVesterinen> OK, fine.
20170820 17:37:36< vultraz_iOS> er...
20170820 17:37:42< vultraz_iOS> ptr
20170820 17:37:43< vultraz_iOS> yeah
20170820 17:38:48< vultraz_iOS> celticminstrel: how well supported is std::type_index?
20170820 17:43:41< celticminstrel> Not sure, but I can't find any evidence that MSVC 2013 supports it.
20170820 17:44:03< vultraz_iOS> :
20170820 17:44:05< vultraz_iOS> (
20170820 17:44:22< vultraz_iOS> woe!
20170820 17:44:29< celticminstrel> Wht do you need it for?
20170820 17:44:35< celticminstrel> Oh wait/
20170820 17:44:54< celticminstrel> https://msdn.microsoft.com/en-us/library/hh874825.aspx
20170820 17:45:05< celticminstrel> See if "Other Versions" includes 2013.
20170820 17:45:17-!- Kwandulin [~Kwandulin@p200300E453CC3B9E9DB0E0DF0D35C999.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170820 17:45:39< vultraz_iOS> 2013 and 2012
20170820 17:45:47-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170820 17:46:18< celticminstrel> So click it and see what it says, I guess?
20170820 17:47:15< vultraz_iOS> it's there
20170820 17:52:30< vultraz_iOS> ok, time to squash 
20170820 17:52:50-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 246 seconds]
20170820 17:53:07< vultraz_iOS> JyrkiVesterinen: for set_step_size, should I throw an exception or assert?
20170820 17:54:35< vultraz_iOS> (and if exception, is std::invalid_argument acceptable
20170820 17:56:00< JyrkiVesterinen> I prefer an exception, as the parameters are outside of the function's control.
20170820 17:56:12< JyrkiVesterinen> std::invalid_argument is exactly what I would use.
20170820 18:06:01-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170820 18:08:19-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170820 18:12:07-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170820 18:15:40-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170820 18:24:22-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:4928:ddf1:45b8:3f58] has joined #wesnoth-dev
20170820 18:32:00-!- irker812 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170820 18:32:00< irker812> wesnoth: Charles Dang wesnoth:some_gui2_refactoring a5cb8f1340b8 / src/gui/widgets/settings.cpp: GUI2/Settings: minor formatting cleanup https://github.com/wesnoth/wesnoth/commit/a5cb8f1340b833c2727eec5bd19bacee6c9e8212
20170820 18:32:00< irker812> wesnoth: Charles Dang wesnoth:some_gui2_refactoring 4e81236ca05c / src/gui/core/ (window_builder.cpp window_builder.hpp): GUI2/Window Builder: added function to generate a single widget instance with it https://github.com/wesnoth/wesnoth/commit/4e81236ca05c9d7341d7e85e02a3e9586ba226e6
20170820 18:32:01< irker812> wesnoth: Charles Dang wesnoth:some_gui2_refactoring ea15d450fd90 / src/gui/ (69 files in 2 dirs): GUI2: refactored widget initialization process https://github.com/wesnoth/wesnoth/commit/ea15d450fd9002f1c28924a037b8290b4f7dfc62
20170820 18:32:04< irker812> wesnoth: Charles Dang wesnoth:some_gui2_refactoring 971de6fb5bf3 / src/gui/widgets/ (scrollbar.hpp slider.cpp): GUI2: prevented Scrollbar (and by extension Slider) step size from being set to  https://github.com/wesnoth/wesnoth/commit/971de6fb5bf34383391e90c103c2ee49b17d1e0a
20170820 18:32:07< irker812> wesnoth: Charles Dang wesnoth:some_gui2_refactoring eddea4bc985f / src/gui/ (core/window_builder.cpp widgets/window.cpp widgets/window.hpp): GUI2/Window: pass definition pointer to ctor instead of individual arguments https://github.com/wesnoth/wesnoth/commit/eddea4bc985fe5ae69458f13a0ba45f5c1d9b7e3
20170820 18:32:10< irker812> wesnoth: Charles Dang wesnoth:some_gui2_refactoring 39dff1b9d4c1 / src/gui/core/ (register_widget.hpp window_builder.hpp): GUI2/Window Builder: removed build_widget function and used std::make_shared dir https://github.com/wesnoth/wesnoth/commit/39dff1b9d4c156a339b34e8233dfa6ff26fd3409
20170820 18:32:13< irker812> wesnoth: Charles Dang wesnoth:some_gui2_refactoring 820bcbf76a33 / src/gui/core/window_builder.hpp: GUI2/Window Builder: added comment clarifying Window how resolution options are  https://github.com/wesnoth/wesnoth/commit/820bcbf76a33e782d7d36aeaf146c4dd17194be6
20170820 18:32:16< irker812> wesnoth: Charles Dang wesnoth:some_gui2_refactoring 26df1bebf8d9 / src/gui/ (59 files in 2 dirs): GUI2: allow REGISTER_WIDGET to implement get_control_type overrides https://github.com/wesnoth/wesnoth/commit/26df1bebf8d918657e2c0bc0ff7507962f2085e1
20170820 18:32:19< irker812> wesnoth: Charles Dang wesnoth:some_gui2_refactoring 9e4931663983 / src/gui/ (core/event/distributor.cpp widgets/window.cpp): GUI2: don't use `0` to initialize nullptrs https://github.com/wesnoth/wesnoth/commit/9e49316639836b41fc5f037b4850d4301bda0ffe
20170820 18:32:23< vultraz_iOS> i think i addressed everything. split a few things up too
20170820 18:32:38< vultraz_iOS> still have to deal with tests
20170820 18:36:28-!- Kwandulin2 [~Kwandulin@p200300E453CC3B995C8F6250B94ACDBE.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170820 18:37:30-!- Kwandulin [~Kwandulin@p200300E453CC3B9E9DB0E0DF0D35C999.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20170820 18:40:19-!- sevu [~Shiki@p548552B5.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20170820 19:12:23-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:4928:ddf1:45b8:3f58] has quit [Remote host closed the connection]
20170820 19:22:02-!- mjs-de [~mjs-de@x4db60819.dyn.telefonica.de] has quit [Remote host closed the connection]
20170820 19:47:08-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 240 seconds]
20170820 19:48:36-!- travis-ci [~travis-ci@ec2-54-196-213-74.compute-1.amazonaws.com] has joined #wesnoth-dev
20170820 19:48:37< travis-ci> wesnoth/wesnoth#14734 (some_gui2_refactoring - 9e49316 : Charles Dang): The build is still failing.
20170820 19:48:37< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/266572047
20170820 19:48:37-!- travis-ci [~travis-ci@ec2-54-196-213-74.compute-1.amazonaws.com] has left #wesnoth-dev []
20170820 19:52:11-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170820 20:08:58-!- sevu [~Shiki@p548552B5.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170820 20:13:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170820 20:14:04-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170820 20:16:58-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170820 20:31:21-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 240 seconds]
20170820 20:33:55-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170820 20:35:54< irker812> wesnoth: ln-zookeeper wesnoth:master 20e6ee719077 / data/core/terrain.cfg: Added a terrain description for oasis, and other tweaks to the entry https://github.com/wesnoth/wesnoth/commit/20e6ee719077ee5e6df809a931c104df94b9ec06
20170820 20:41:43-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170820 20:41:50-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170820 20:42:00-!- stikonas [~stikonas@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170820 20:46:09< vultraz_iOS> celticminstrel: was leaving those commented out calls to remind me to deal with passing the builder to the list_view thingy if we ever do something with t
20170820 20:46:40< celticminstrel> Isn't it better to use prose comments for that?
20170820 20:51:13-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:4928:ddf1:45b8:3f58] has joined #wesnoth-dev
20170820 20:51:24-!- Kwandulin2 [~Kwandulin@p200300E453CC3B995C8F6250B94ACDBE.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170820 20:57:52< vultraz_iOS> eh
20170820 20:57:53< vultraz_iOS> maybe
20170820 20:59:49< irker812> wesnoth: Charles Dang wesnoth:some_gui2_refactoring 62c782b7cc02 / src/gui/ (core/event/distributor.cpp core/window_builder.cpp widgets/window.cpp): GUI2: don't use `0` to initialize nullptrs https://github.com/wesnoth/wesnoth/commit/62c782b7cc02132ec040e0716bb3d07bef2029db
20170820 20:59:52< irker812> wesnoth: Charles Dang wesnoth:some_gui2_refactoring 063484088ced / src/tests/gui/iterator.cpp: Fixup tests for ea15d45 https://github.com/wesnoth/wesnoth/commit/063484088ced52df0934e78d48d28f9fbef3e1db
20170820 21:05:13-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170820 21:08:26-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:4928:ddf1:45b8:3f58] has quit [Remote host closed the connection]
20170820 21:10:19-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:4928:ddf1:45b8:3f58] has joined #wesnoth-dev
20170820 21:13:14< sevu> 20170820 23:12:46 warning scripting/lua/user: Attempted to deprecate something that is not a table or function: wesnoth.debug -> wml.tostring, where wesnoth.debug = nil
20170820 21:13:34< sevu> ^ I get this in stderr when starting wesnoth (without addons)
20170820 21:14:13< vultraz_iOS> celticminstrel: 
20170820 21:14:49-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:4928:ddf1:45b8:3f58] has quit [Ping timeout: 246 seconds]
20170820 21:23:22< celticminstrel> sevu: Does it show up at the main menu?
20170820 21:27:40< sevu> no, you see it only when starting with a terminal
20170820 21:27:46< sevu> celticminstrel, 
20170820 21:27:58< celticminstrel> But I mean, you don't need to start a game to see it.
20170820 21:30:45< sevu> no
20170820 21:31:10< sevu> you don't need to
20170820 21:37:28< celticminstrel> I assume this isn't before https://github.com/wesnoth/wesnoth/commit/00443dd8a4d766c1d40d68a5c44279b7af332c8e
20170820 21:45:32-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170820 21:45:41< sevu> without that, and without the commit which is fixed up by this mentioned in the comments, it's fine
20170820 21:49:00< celticminstrel> Well, obviously, since that fixed up commit is what created the opportunity for such a message, but the fixup commit should've fixed it...
20170820 21:49:50< celticminstrel> Anyway, I'll look into it after I finish working on the mapgen branch.
20170820 21:54:11-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170820 22:02:02-!- stikonas [~stikonas@wesnoth/translator/stikonas] has quit [Quit: AtomicIRC: The nuclear option.]
20170820 22:03:53-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20170820 22:16:45-!- travis-ci [~travis-ci@ec2-50-17-98-76.compute-1.amazonaws.com] has joined #wesnoth-dev
20170820 22:16:46< travis-ci> wesnoth/wesnoth#14737 (some_gui2_refactoring - 0634840 : Charles Dang): The build is still failing.
20170820 22:16:46< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/266604366
20170820 22:16:46-!- travis-ci [~travis-ci@ec2-50-17-98-76.compute-1.amazonaws.com] has left #wesnoth-dev []
20170820 22:19:37-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170820 22:20:15-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:4928:ddf1:45b8:3f58] has joined #wesnoth-dev
20170820 22:24:49-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:4928:ddf1:45b8:3f58] has quit [Ping timeout: 246 seconds]
20170820 22:36:46-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:4928:ddf1:45b8:3f58] has joined #wesnoth-dev
20170820 22:42:39-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:4928:ddf1:45b8:3f58] has quit [Remote host closed the connection]
20170820 22:50:15< sevu> exist there sth like $unit for the opponent in attack event? like $second or $second_unit ?
20170820 22:50:21< vultraz_iOS> STILL FAILING, you say?
20170820 22:54:41< irker812> wesnoth: Charles Dang wesnoth:some_gui2_refactoring f223bdfcd5ed / src/tests/gui/iterator.cpp: Fixup tests for ea15d45 https://github.com/wesnoth/wesnoth/commit/f223bdfcd5ed3670f633d53ac4262ba1750a8295
20170820 23:09:13< mattsc> sevu: yes, it’s $second_unit: https://wiki.wesnoth.org/EventWML#Predefined_Events_With_Filters
20170820 23:10:49< sevu> Thanks!
20170820 23:20:20< vultraz_iOS> celticminstrel: do you happen to know how one would go about dynamic code generation with boost preprocessor
20170820 23:20:54< celticminstrel> Kinda?
20170820 23:21:15< celticminstrel> I've used Boost.Preprocessor before, mainly for exercises though (like reimplementing <type_traits>).
20170820 23:21:45< celticminstrel> Not sure if the term "dynamic code generation" really applies to what it does though.
20170820 23:21:54< celticminstrel> Perhaps you should be more specific about what you want to do.
20170820 23:23:04< vultraz_iOS> something I've wondered for awhile is whether all the preferences wrapper functions could be dynamically generated
20170820 23:23:53< celticminstrel> I suppose it might be possible?
20170820 23:24:30< celticminstrel> I'm not sure if you'd actually need Boost.Preprocessor for it, but I suppose its "container" types and "loop" structures could be helpful...
20170820 23:43:09-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:4928:ddf1:45b8:3f58] has joined #wesnoth-dev
20170820 23:47:39-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:4928:ddf1:45b8:3f58] has quit [Ping timeout: 255 seconds]
20170820 23:53:07-!- Bonobo [~Bonobo@203.220.138.162] has joined #wesnoth-dev
20170820 23:54:24-!- travis-ci [~travis-ci@ec2-54-196-213-74.compute-1.amazonaws.com] has joined #wesnoth-dev
20170820 23:54:25< travis-ci> wesnoth/wesnoth#14739 (some_gui2_refactoring - f223bdf : Charles Dang): The build is still failing.
20170820 23:54:25< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/266626000
20170820 23:54:25-!- travis-ci [~travis-ci@ec2-54-196-213-74.compute-1.amazonaws.com] has left #wesnoth-dev []
20170820 23:54:52< vultraz_iOS> STILL FAILING, YOU SAY
20170820 23:55:04< vultraz_iOS> oh wait that's the other one
--- Log closed Mon Aug 21 00:00:21 2017