--- Log opened Fri Aug 25 00:00:26 2017
20170825 00:02:09-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 248 seconds]
20170825 00:05:26-!- TC01 [~quassel@venus.arosser.com] has joined #wesnoth-dev
20170825 00:27:07-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has quit [Remote host closed the connection]
20170825 00:27:41-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has joined #wesnoth-dev
20170825 00:31:49-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has quit [Ping timeout: 246 seconds]
20170825 01:27:38-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170825 01:43:20-!- irker470 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170825 01:50:20-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170825 01:50:26-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170825 01:55:36-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170825 01:56:12-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has joined #wesnoth-dev
20170825 02:00:22-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has quit [Ping timeout: 246 seconds]
20170825 02:13:32-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170825 02:13:39-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170825 02:21:20-!- iwaim [~iwaim@2001:2c0:40e:2002:0:4:14:80] has quit [Ping timeout: 246 seconds]
20170825 02:21:43-!- iwaim [~iwaim@2001:2c0:40e:2002:0:4:14:80] has joined #wesnoth-dev
20170825 02:24:35-!- new_one [~new_one@2604:a880:1:20::22e:d001] has quit [Ping timeout: 255 seconds]
20170825 02:29:44-!- new_one [~new_one@2604:a880:1:20::22e:d001] has joined #wesnoth-dev
20170825 02:36:02-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has joined #wesnoth-dev
20170825 02:36:26-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has quit [Remote host closed the connection]
20170825 02:41:06-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170825 02:56:02-!- irker030 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170825 02:56:02< irker030> wesnoth: Charles Dang wesnoth:some_gui2_refactoring 7af8fda92db4 / src/gui/widgets/styled_widget.hpp: GUI2/Styled Widget: removed now-unnecessary friend declaration for the window cl https://github.com/wesnoth/wesnoth/commit/7af8fda92db43da34ed57e1acb5ade55d2bd35af
20170825 02:56:02< irker030> wesnoth: Charles Dang wesnoth:some_gui2_refactoring 7b9337293a17 / src/gui/widgets/ (listbox.cpp listbox.hpp): GUI2/Listbox: pass list grid builder directly to constructor https://github.com/wesnoth/wesnoth/commit/7b9337293a1772895b4e2629d7be441b72c1a5f5
20170825 02:56:03< irker030> wesnoth: Charles Dang wesnoth:some_gui2_refactoring ea08c0437a7c / src/gui/widgets/generator.cpp: GUI2/Generator: use static_assert to have actual compile-time assertions https://github.com/wesnoth/wesnoth/commit/ea08c0437a7c5c7ecdaa1ef587b5179ace943f98
20170825 02:56:05< irker030> wesnoth: Charles Dang wesnoth:some_gui2_refactoring ca5ac9bc9abe / src/gui/widgets/ (generator.cpp generator_private.hpp): GUI2/Generator: formatting cleanup https://github.com/wesnoth/wesnoth/commit/ca5ac9bc9abef367159a80a4b9b65af2a2acbd1b
20170825 02:56:08< irker030> wesnoth: Charles Dang wesnoth:some_gui2_refactoring a4dab46e0121 / src/gui/ (core/event/handler.cpp widgets/window.cpp widgets/window.hpp): GUI2/Window: handle CLOSE_WINDOW event with a signal handler https://github.com/wesnoth/wesnoth/commit/a4dab46e0121685d760028c18e54fd44455e8e81
20170825 02:58:19< vultraz_iOS> celticminstrel: i really don't know how to fix the tests
20170825 03:02:29< celticminstrel> What's wrong with them?
20170825 03:02:43< celticminstrel> My suggestion though is to figure out how to build them.
20170825 03:02:54< celticminstrel> I doubt it's really that hard.
20170825 03:03:11< vultraz_iOS> it is because codeblocks is a confusing, badly-designed POS
20170825 03:03:26< celticminstrel> Then... stop using it?
20170825 03:03:35< vultraz_iOS> im too lazy to migrate to VS
20170825 03:03:41< vultraz_iOS> even though i have VS installed >_<
20170825 03:03:48< celticminstrel> Then use VSCode with scons/CMake?
20170825 03:03:53< vultraz_iOS> also building with VS takes 4x as long
20170825 03:04:04< celticminstrel> (Or substitute VSCode with your code editor of choice.)
20170825 03:04:46< celticminstrel> With scons/CMake you can probably choose whether to use GCC, clang, or cl.exe.
20170825 03:04:50< vultraz_iOS> anyway, the problem was that copy ctor
20170825 03:04:56< vultraz_iOS> was deleted
20170825 03:05:01< vultraz_iOS> and for some reason it tries to do a copy
20170825 03:05:02< celticminstrel> Oh right.
20170825 03:05:16< celticminstrel> Did you try changing T to T& like I suggested?
20170825 03:05:21< celticminstrel> So that it doesn't copy.
20170825 03:05:24< vultraz_iOS> I could
20170825 03:05:33< celticminstrel> Well, try it.
20170825 03:05:44< vultraz_iOS> except it's constructing a new object
20170825 03:05:52< celticminstrel> Ah.
20170825 03:05:55< vultraz_iOS> T control(std::forward<T2>(args)...);
20170825 03:05:56< celticminstrel> What was the line, again?
20170825 03:05:58< vultraz_iOS> there's nothing TO copy
20170825 03:06:01< vultraz_iOS> 127
20170825 03:06:11< vultraz_iOS> tests/gui/iterator.cpp:127
20170825 03:06:27< celticminstrel> Yeah, there shouldn't be any copying going on there... unless args is pack containing a single T...
20170825 03:06:31< celticminstrel> ^is a
20170825 03:06:44< vultraz_iOS> but that's not the case
20170825 03:06:45< vultraz_iOS> test_control<gui2::grid>();
20170825 03:07:22< celticminstrel> Seriously though, find a way to build the tests yourself already.
20170825 03:08:40< celticminstrel> So how many instances of the error are there? Just one, or several?
20170825 03:08:48< vultraz_iOS> one IIRC
20170825 03:09:44< celticminstrel> Seems like args is an empty parameter pack?
20170825 03:09:55< celticminstrel> See line 181.
20170825 03:10:00< vultraz_iOS> yes
20170825 03:10:04< celticminstrel> Why are there no arguments passed there?
20170825 03:10:22< vultraz_iOS> because none are needed
20170825 03:13:16< celticminstrel> I kinda doubt this.
20170825 03:13:22< celticminstrel> Why do you believe none are needed?
20170825 03:15:21< vultraz_iOS> because
20170825 03:15:24< vultraz_iOS> none are needed :|
20170825 03:15:36< vultraz_iOS> the grid ctor takes two arguments but both have default arguments
20170825 03:15:37< celticminstrel> I'm pretty sure there's no way that can be true?
20170825 03:15:43< celticminstrel> Oh.
20170825 03:15:51< vultraz_iOS> values*
20170825 03:16:43< celticminstrel> And what about this error? https://travis-ci.org/wesnoth/wesnoth/jobs/267810786#L2200
20170825 03:16:48< celticminstrel> That's probably easier to fix, anyway.
20170825 03:17:06< celticminstrel> Maybe if you fix that, clang will give a more useful view of the other error.
20170825 03:19:51< irker030> wesnoth: Charles Dang wesnoth:some_gui2_refactoring 53ffc2dbb25c / src/tests/gui/visitor.cpp: More test fixup https://github.com/wesnoth/wesnoth/commit/53ffc2dbb25c8d37220226b31d4a579955db9296
20170825 03:22:56< vultraz_iOS> btw
20170825 03:23:02< vultraz_iOS> hotkeys are almost completely broken
20170825 03:23:10< celticminstrel> Ugh...
20170825 03:23:24< celticminstrel> IIRC they're working perfectly fine for me...
20170825 03:23:34< celticminstrel> What's your opinion on reverting #1003?
20170825 03:23:47< celticminstrel> Assuming it genuinely fixes the issues, mind you.
20170825 03:23:54< vultraz_iOS> or actually, most that use shift
20170825 03:24:20< celticminstrel> Presumably the ones that use textinput.
20170825 03:24:23< vultraz_iOS> also, even on master it seems select-all no longer selects all in gui2 textboxes
20170825 03:24:38< celticminstrel> Which is any key that types a character, either with shift or with no modifiers.
20170825 03:24:51< celticminstrel> Well okay, it probably excludes tab and enter.
20170825 03:24:53< vultraz_iOS> (well, i confirmed it happened when i tested the iOS pr, and it happens here on my branch)
20170825 03:25:01< vultraz_iOS> so i assume it's on master
20170825 03:25:05< celticminstrel> Is your branch up-to-date with master?
20170825 03:25:11< vultraz_iOS> the cursor moves to the beginning, but nothing is selected 
20170825 03:25:24< celticminstrel> I think that might actually be intended behaviour.
20170825 03:25:57< vultraz_iOS> celticminstrel: 8 commits behind
20170825 03:26:02< celticminstrel> 'kay
20170825 03:26:45< celticminstrel> Yeah, Ctrl+A is intended to be a synonym for Home.
20170825 03:26:47< vultraz_iOS> what kind of select-all behavior is go-to-beginning and slect nothng
20170825 03:26:51< vultraz_iOS> select
20170825 03:26:51< celticminstrel> https://github.com/wesnoth/wesnoth/blob/master/src/gui/widgets/text_box_base.cpp#L511
20170825 03:26:55< celticminstrel> emacs, probably
20170825 03:27:08< vultraz_iOS> blah
20170825 03:27:16< vultraz_iOS> ok so it's not a bug per-se
20170825 03:27:20< vultraz_iOS> still, I think we should change it
20170825 03:27:23< celticminstrel> Not a bug, no.
20170825 03:27:36< celticminstrel> I agree though, it's kinda pointless offering emacs bindings by default.
20170825 03:27:49< celticminstrel> Given that most people will, in fact, expect Ctrl+A to select all.
20170825 03:27:59< vultraz_iOS> is SDLK_a different from SDLK_A
20170825 03:28:16< celticminstrel> Eh? Do both even exist?
20170825 03:28:23< celticminstrel> There should be no difference in any case.
20170825 03:28:30< celticminstrel> Remember it's referencing keys.
20170825 03:29:04< celticminstrel> ...heh, the comments there.
20170825 03:29:09-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20170825 03:29:10< celticminstrel> "drop the styled_widget modifier"
20170825 03:29:16-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170825 03:29:23< celticminstrel> Pretty sure that wasn't supposed to be changed when I renamed that class. >_>
20170825 03:29:55< celticminstrel> If we're going to change the text navigation keys BTW, there are also a number of missing behaviours that people (at least on OSX) would expect.
20170825 03:30:04< celticminstrel> Such as navigation by words (alt+arrows).
20170825 03:30:24< celticminstrel> (I think ctrl+arrows typically does the same on Windows?)
20170825 03:30:56< vultraz_iOS> well that was an easy change
20170825 03:31:05< vultraz_iOS> celticminstrel: i have no idea about that
20170825 03:31:10< celticminstrel> If there were no conflict between emacs bindings and "native" bindings, I'd probably say to just leave them, but there are confilcts, so IMO it's kinda silly.
20170825 03:31:19< celticminstrel> I'll open an issue about this, see if anyone else has comments.
20170825 03:31:32< vultraz_iOS> seriously
20170825 03:31:43< vultraz_iOS> 99.999999% of people expect ctrl a to select all
20170825 03:32:45< vultraz_iOS> now what is this about SDLK_e..
20170825 03:32:50< vultraz_iOS> I'm not aware of a common binding with e..
20170825 03:33:31< Necrosporus> I think there is too many 9'th but yes, I'd rather have wesnoth use bindings, which are same between programs like kwrite and libreoffice and windows stuff
20170825 03:33:58< Necrosporus> just 99.9% would be a better estimate
20170825 03:35:17< Necrosporus> celticminstrel, it's also an option to make wesnoth recognize emacs and vim bindings after switching some options
20170825 03:35:25< celticminstrel> Yeah, true.
20170825 03:35:41< celticminstrel> Or just make the text navigation keys all rebindable. :P
20170825 03:35:58< vultraz_iOS> OAB
20170825 03:36:00< vultraz_iOS> :P
20170825 03:36:01< Necrosporus> And that too
20170825 03:36:09< celticminstrel> https://github.com/wesnoth/wesnoth/issues/1918
20170825 03:36:12< Necrosporus> celticminstrel, but also make it possible to switch them a mass
20170825 03:36:18< celticminstrel> vultraz_iOS: Given that we already have a huge list of hotkeys...
20170825 03:36:33< celticminstrel> I don't think it would matter too much to add a few more.
20170825 03:37:00< Necrosporus> > For example, Ctrl+arrow keys (Alt+arrows on Mac) is typically expected to navigate by words, 
20170825 03:37:02< Necrosporus> Actually now
20170825 03:37:05< Necrosporus> * no
20170825 03:37:21< celticminstrel> I know I'm used to that behaviour on Windows.
20170825 03:37:29< Necrosporus> I'd expect alt-arrows work like back and forth in browser
20170825 03:37:37< celticminstrel> ?
20170825 03:37:56< Necrosporus> I use alt + ← in web browser
20170825 03:37:56< celticminstrel> I said ctrl+arrows, unless you're on a Mac.
20170825 03:38:09< celticminstrel> And it has nothing to do with browsers.
20170825 03:38:15< Necrosporus> and what should alt-arrow do in GNU/Linux?
20170825 03:38:21< celticminstrel> Most likely nothing.
20170825 03:38:27< celticminstrel> Same for Windows.
20170825 03:38:42< Necrosporus> It could work for going to previous page
20170825 03:38:53< Necrosporus> When you create a game you have several pages
20170825 03:38:55< celticminstrel> But there generally isn't a previous page to go to.
20170825 03:39:15< celticminstrel> So if you want that kind of thing it would probably need to be done on a per-dialog basis.
20170825 03:39:22< celticminstrel> It could work in the help browser, at least.
20170825 03:39:46< Necrosporus> Perhaps
20170825 03:40:18< Necrosporus> >It is said that wesnoth got greenlight in Steam, whatever it means. Could you explain how does it benefits players and developers who never used and not going to used said Steam?
20170825 03:40:20< celticminstrel> IMO that's the only place where back/forward makes sense ATM.
20170825 03:40:34< Necrosporus> I have asked it on #wesnoth but nobody seems to pay attention to it anymore
20170825 03:40:37< celticminstrel> Does it even benefit people who won't use steam?
20170825 03:40:50< celticminstrel> Pretty sure it merely means another channel of distribution for the game.
20170825 03:40:51< Necrosporus> That's my question
20170825 03:41:00< celticminstrel> And thus a potentially wider audience.
20170825 03:41:36< Necrosporus> Perhaps. There are weird people who won't play a game if it's not present in steam. That's weird, but I have seen at least one
20170825 03:42:29< Necrosporus> Is 1.13.9 close?
20170825 03:42:42< Necrosporus> I was going to build development version of wesnoth, should I wait?
20170825 03:42:53< celticminstrel> I sure hope so, but with all the big refactors vultraz_iOS keeps insisting on doing, almost anything goes...
20170825 03:43:01< celticminstrel> BTW vultraz_iOS, are you going to merge that PR?
20170825 03:43:06< celticminstrel> The touch one, I mean.
20170825 03:43:08< Necrosporus> I didn't try 13th yet. Is there anything important compared to 12?
20170825 03:43:14< celticminstrel> ???
20170825 03:43:25< celticminstrel> There's tons of new stuff in 1.13.x.
20170825 03:43:43< Necrosporus> I know there is a new campaign but I have finished it
20170825 03:43:49< Necrosporus> When it was an addon
20170825 03:44:12< vultraz_iOS> celticminstrel: not yet. It's not ready.
20170825 03:45:46< Necrosporus> celticminstrel, https://wesnoth.org/ this page is missing a clearly visible source code repository link
20170825 03:45:59< celticminstrel> Don't tell me, tell shadowm.
20170825 03:46:38< vultraz_iOS> Necrosporus: what do you mean
20170825 03:46:40< vultraz_iOS> it's at the bottom
20170825 03:46:44< Necrosporus> shadowm, could you put link to github somewhere on the main page and clearly visible, maybe next to "source download" 
20170825 03:47:13< celticminstrel> SourceForge hosts the official source downloads BTW.
20170825 03:47:21< celticminstrel> By which I mean, packaged source downloads for each release.
20170825 03:48:10< vultraz_iOS> and one in the top right corner
20170825 03:48:40< Necrosporus> I see github link now, but it's a picture
20170825 03:48:58< Necrosporus> I think that link to source repository should be more pronounced, perhaps in the head line?
20170825 03:49:47< Necrosporus> There is line Download // Stable 1.12.6 // Development 1.13.8
20170825 03:49:58< Necrosporus> Another option is to add it somewhere there
20170825 03:50:05< vultraz_iOS> i think it's fine as it is
20170825 03:50:29< Necrosporus> I didn't find until I was told it's there
20170825 03:51:23< Necrosporus> Another question, why there is no real news page, just forum thread list?
20170825 03:51:39< vultraz_iOS> we decided it would be too much clutter
20170825 03:52:40< celticminstrel> BTW, even after disabling my adblocker, I still don't see the facebook link.
20170825 03:52:53< Necrosporus> Windows 371.3 MiB // macOS (10.7+) 408.2 MiB // Source 409.0 MiB // Source Repository (github) // Linux
20170825 03:53:02< Necrosporus> How about adding it?
20170825 03:53:03< celticminstrel> And I still think it's super-wierd that twitter is the only one that doesn't get a picture link.
20170825 03:53:13< celticminstrel> No.
20170825 03:53:18< celticminstrel> It doesn't make any sense there.
20170825 03:53:26< celticminstrel> GitHub is not a place to go to download the game.
20170825 03:53:53< celticminstrel> If you want to download the source for the purpose of building it and playing the game, you should be getting the source package from SourceForge.
20170825 03:53:56-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170825 03:54:07< celticminstrel> IOW the middle link there.
20170825 03:54:23< Necrosporus> celticminstrel, where else then? Imagine you a new user, you see "Open Source", think, "Oh, cool, I want to browse it and see bugtracker", where he should go?
20170825 03:54:28< vultraz_iOS> celticminstrel: seriously what are you seeing https://1drv.ms/i/s!As9hRC_GxjKKpiHC8R26iJdkBLBU
20170825 03:54:38< celticminstrel> If you want to build the game and help out, of course you want the github, but this page is more for potential players than developers, no?
20170825 03:55:12< celticminstrel> vultraz_iOS: That link gives me a blank white page.
20170825 03:55:46< vultraz_iOS> https://pawtnq.dm2301.livefilestore.com/y4mGMqmy_Cedn4VnXdXrUYHdL8YTTuXuL1bATyuvIrEG0vkQCUSv55hseEU5P7u40W7UuED8O5XphokCJ9T9NeT9Lz3mM2eYyuQqCUR7v5JsjTsU-D9X8hCbDROxlv_7F-n92TmDQEJ0mxogdhmE94u1Kw-4bFBBAl4qi0l5-ttJxOQg6jkCGkNoN-fiLnxsBDb2WGJcBleXy6st40Wcvhqlw/twitter.PNG?psid=1
20170825 03:55:50< vultraz_iOS> better?
20170825 03:56:07< Necrosporus> celticminstrel, OK, what if it was in this line: Home News Play Create Develop Forums About 
20170825 03:56:34< Necrosporus> And Develop link leads to https://github.com/wesnoth/wesnoth
20170825 03:57:58< Necrosporus> Also another suggestion for links to spy sites such as facebook
20170825 03:58:13< Necrosporus> It should be static picture loaded from wesnoth.org itself
20170825 03:58:24< vultraz_iOS> ???
20170825 03:58:28< celticminstrel> As for what I'm seeing: http://celmin.pwcsite.com/wesnoth/social_media_links.png
20170825 03:58:28< vultraz_iOS> why
20170825 03:58:36< Necrosporus> So that twitter.com is not getting a requiest from user's browser until he clicks on the link for example
20170825 03:58:44< vultraz_iOS> celticminstrel: good god
20170825 03:58:51< celticminstrel> What's with that response?
20170825 03:59:06< Necrosporus> celticminstrel, it's something in your browser
20170825 03:59:08< vultraz_iOS> celticminstrel: you're missing the facebook button too
20170825 03:59:16< Necrosporus> twitter link is a frame, it shows a picture for me
20170825 03:59:21< celticminstrel> Necrosporus does kinda have a point though, you shouldn't link to external images if you don't have to.
20170825 03:59:45< celticminstrel> Pretty sure these social media sites all allow you to store their image on your servers for the purpose of linking to them/
20170825 03:59:51< Necrosporus> My point is that I don't want "Big Brother" to know I visit wesnoth.org
20170825 03:59:59< celticminstrel> vultraz_iOS: Yes, that's exactly what I said earlier.
20170825 03:59:59< vultraz_iOS> oh come on
20170825 04:00:13< celticminstrel> I think I'm missing the facebook button because it's set up by some JavaScript.
20170825 04:00:59< celticminstrel> Whoa, I have a ton of CSS errors in the log. That probably explains the Twitter button issue.
20170825 04:02:15< celticminstrel> No JavaScript errors though.
20170825 04:02:22< vultraz_iOS> honestly i'm not sure how we handle the fb button
20170825 04:02:54< Necrosporus> Make it static picture from wesnoth.org which is a link to certain URL
20170825 04:03:09< vultraz_iOS> I don't think we'll be doing that
20170825 04:03:12< celticminstrel> I see 13 requests for resources not on wesnoth.org.
20170825 04:03:54< Necrosporus> Though good browser should block all external frames to social media by default
20170825 04:04:09< vultraz_iOS> oh come on
20170825 04:04:26< Necrosporus> I do not want facebook having my entire browser history
20170825 04:04:33< Necrosporus> While I do not even have a facebook page
20170825 04:04:53< vultraz_iOS> you sound like you've been reading RMS
20170825 04:05:13< Necrosporus> Yes, I was and he's right in many regards including this one
20170825 04:05:20< JyrkiVesterinen> Necrosporus: You can use uBlock Origin to block external frames to social media.
20170825 04:05:22< Necrosporus> Even though I do not agree with everything he says
20170825 04:05:30< vultraz_iOS> keep in mind i don't exactly disagree with you on the general principle 
20170825 04:05:47< vultraz_iOS> but i doubt facebook records *widget sources*
20170825 04:05:50< celticminstrel> So there's a request to fonts.googleapis.com for Montaga|Open Sans.
20170825 04:05:55< JyrkiVesterinen> I have both social media buttons (through Fanboy's Social Blocking list) and all third-party frames (except ones I have whitelisted) blocked.
20170825 04:06:21< celticminstrel> There's a request to platform.twitter.com for a widgets.js (what the heck is this).
20170825 04:06:44< vultraz_iOS> but please for the love of god, don't go spreading RMS-isms >_<
20170825 04:06:54< JyrkiVesterinen> AFAIK, Facebook is known to record browsing history through those buttons.
20170825 04:06:59< celticminstrel> There are five requests to youtube.com.
20170825 04:07:04< Necrosporus> The point is wehenever it's right or not, not about who said it
20170825 04:07:13< celticminstrel> Probably all resulting from the single embedded video.
20170825 04:07:19< vultraz_iOS> likely
20170825 04:07:46< celticminstrel> There are four requests to fonts.gstatic.com. What's with these incomprehensible URLs anyway?
20170825 04:07:59< celticminstrel> And there's one request to i.ytimg.com.
20170825 04:08:02< vultraz_iOS> *shrug*
20170825 04:08:09< celticminstrel> Which is frankly baffling.
20170825 04:08:23< vultraz_iOS> youtube image?
20170825 04:08:29< celticminstrel> Ooh, wait, it could be also a result of the youtube embed.
20170825 04:08:38< celticminstrel> Given that it's basically the thumbnail of the video.
20170825 04:08:47< Necrosporus> Well, embedded video is a good case, I guess, though if it's possible perhaps the site should display a frame which is filled with single picture which is downwloaded from wesnoth.org itself and only after a click it can load youtube page into same frame
20170825 04:08:59< vultraz_iOS> oh come ON
20170825 04:09:07< vultraz_iOS> seriously??
20170825 04:09:32< vultraz_iOS> I could agree with you on it being iffy for facebook to track people via widgets but now you want to throw out the yt embed?
20170825 04:09:36< celticminstrel> I figure at least the Google font requests could be migrated onto the Wesnoth server?
20170825 04:09:38< Necrosporus> To make sure browser (even without adblocks) sends no requests to external sites unless it's absolutely necessary
20170825 04:09:44< vultraz_iOS> do you just not like any advancement in the web from the past 10 years?
20170825 04:09:51< JyrkiVesterinen> Embedded YouTube videos are fine for me. YouTube is one of the sites for which I *have* granted permission to be embedded in a frame.
20170825 04:09:57< celticminstrel> I don't really know why the Twitter JS file is needed either.
20170825 04:10:15< Necrosporus> vultraz_iOS, but my solution could allow embedded video to work
20170825 04:10:28< Necrosporus> It just won't be a video until user clicks on it
20170825 04:10:34< vultraz_iOS> next you'll tell me it's an invasion of privacy that we automatically detect and direct players to the download for their OS or something
20170825 04:10:47< celticminstrel> Necrosporus's suggestion just means the requests to YouTube aren't sent until the user wants to watch the video.
20170825 04:11:17< Necrosporus> vultraz_iOS, it's not as long as it's possible and easy to download files for other platforms. For example my browser tells it's on windows, while it's not
20170825 04:11:26< celticminstrel> vultraz_iOS: Speaking of that, can it detect if your OS cannot run the game? Suppose for example that someone was running MacOS 10.5.
20170825 04:11:46-!- Bonobo [~Bonobo@203.220.138.162] has joined #wesnoth-dev
20170825 04:11:46< vultraz_iOS> Necrosporus: are you not on windows?
20170825 04:11:54< Necrosporus> Of course not
20170825 04:11:59< vultraz_iOS> of course not
20170825 04:12:09< vultraz_iOS> maybe im wrong, then
20170825 04:12:40< Necrosporus> Wesnoth.org offers me to download windows.exe file
20170825 04:12:53< celticminstrel> I'm pointing out all of this for a different reason than Necrosporus, I think. Basically it seems like it'd be more efficient to not have to wait for a third-party site to provide part of your website.
20170825 04:13:00< Necrosporus> But as long as links to files for other platforms are present and readily accessible it's fine with me
20170825 04:13:12< celticminstrel> So I think it would be better if the fonts were hosted on wesnoth.org.
20170825 04:13:18< vultraz_iOS> celticminstrel: i assume if so shadowm would have done so
20170825 04:13:25< vultraz_iOS> he spent a lot of time optimizing this page
20170825 04:14:01< celticminstrel> I imagine most of his optimization was about avoiding the DOMContentLoaded event. >_>
20170825 04:14:13< JyrkiVesterinen> I think it's actually faster to fetch the fonts from Google. They may already be in the browser cache thanks to having been loaded by another site.
20170825 04:14:17< celticminstrel> Abuse of which is the reason why many sites don't function until they have fully loaded.
20170825 04:14:23< celticminstrel> JyrkiVesterinen: I see. Okay then.
20170825 04:16:30-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20170825 04:30:58< irker030> wesnoth: Gregory A Lundberg wesnoth:master d0a8f0a85884 / src/utils/irdya_datetime.hpp: Fix warning: extra semicolon https://github.com/wesnoth/wesnoth/commit/d0a8f0a8588403741885a66e842ae9dde41bd340
20170825 04:36:01< Necrosporus> Is old wesnoth bugtracker still used?
20170825 04:36:07< Necrosporus> one on savannah
20170825 04:37:54< JyrkiVesterinen> No.
20170825 04:38:09< JyrkiVesterinen> Gna! has completely shut down, and we switched to GitHub issues.
20170825 04:39:04< Necrosporus> So they are not even readable?
20170825 04:40:19< JyrkiVesterinen> We migrated all open issues from Gna.
20170825 04:40:26< JyrkiVesterinen> The closed issues are gone, though.
20170825 04:41:00< vultraz_iOS> zookeeper has a record of them though
20170825 04:53:55-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has joined #wesnoth-dev
20170825 05:00:50-!- travis-ci [~travis-ci@ec2-54-211-163-253.compute-1.amazonaws.com] has joined #wesnoth-dev
20170825 05:00:51< travis-ci> wesnoth/wesnoth#14762 (some_gui2_refactoring - 53ffc2d : Charles Dang): The build is still failing.
20170825 05:00:52< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/268219916
20170825 05:00:52-!- travis-ci [~travis-ci@ec2-54-211-163-253.compute-1.amazonaws.com] has left #wesnoth-dev []
20170825 05:33:11-!- Kwandulin [~Kwandulin@p200300E453CC3B31E97C308960A36D2E.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170825 05:34:08-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170825 05:37:19< irker030> wesnoth: Charles Dang wesnoth:some_gui2_refactoring 001a2a523bdb / src/gui/widgets/text_box_base.cpp: GUI2/Text Box Base: made ctrl+a select all text https://github.com/wesnoth/wesnoth/commit/001a2a523bdbd099bd52e82b3cdfa63419d38712
20170825 05:37:22< irker030> wesnoth: Charles Dang wesnoth:some_gui2_refactoring 32c18f613446 / src/gui/dialogs/loading_screen.cpp: GUI2/Loading Screen: formatting cleanup https://github.com/wesnoth/wesnoth/commit/32c18f613446916f98be417877622b973176622e
20170825 05:37:26< irker030> wesnoth: Charles Dang wesnoth:some_gui2_refactoring 19af90ec7184 / src/gui/dialogs/ (5 files in 2 dirs): GUI2: require existence of all widgets added to tab order https://github.com/wesnoth/wesnoth/commit/19af90ec71843cfbd19fe46f6114b1a7388e02ba
20170825 05:37:28< irker030> wesnoth: Charles Dang wesnoth:some_gui2_refactoring cf8060c8a09e / src/gui/dialogs/ (9 files in 4 dirs): GUI2: use find_widget overload returning a pointer when applicable https://github.com/wesnoth/wesnoth/commit/cf8060c8a09e8edd06d81985ab7b57c429ab8452
20170825 05:37:31< irker030> wesnoth: Charles Dang wesnoth:some_gui2_refactoring c980ffc74feb / src/gui/dialogs/ (end_credits.cpp end_credits.hpp): GUI2/End Credits: use DRAW event hook to scroll text instead of a timer https://github.com/wesnoth/wesnoth/commit/c980ffc74febfd9f5e98a8120d756d78b3c121c3
20170825 05:37:34< irker030> wesnoth: Charles Dang wesnoth:some_gui2_refactoring 7c90666bcc1e / src/gui/widgets/listbox.cpp: GUI2/Listbox: cleaned up set/get_active_sorting_option functions https://github.com/wesnoth/wesnoth/commit/7c90666bcc1ea5a5015481d038dc1fa37a467a00
20170825 05:40:19-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170825 06:13:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170825 06:13:18-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170825 06:18:39-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20170825 06:45:23-!- travis-ci [~travis-ci@ec2-54-242-179-217.compute-1.amazonaws.com] has joined #wesnoth-dev
20170825 06:45:24< travis-ci> wesnoth/wesnoth#14765 (some_gui2_refactoring - 7c90666 : Charles Dang): The build is still failing.
20170825 06:45:24< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/268240679
20170825 06:45:24-!- travis-ci [~travis-ci@ec2-54-242-179-217.compute-1.amazonaws.com] has left #wesnoth-dev []
20170825 07:21:56-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Quit: Leaving]
20170825 07:28:10< irker030> wesnoth: Charles Dang wesnoth:some_gui2_refactoring 3c617e9632de / src/gui/widgets/listbox.cpp: Fixup 7c90666bcc1e https://github.com/wesnoth/wesnoth/commit/3c617e9632de10de8ac668e38bf89daab634e447
20170825 07:28:13< irker030> wesnoth: Charles Dang wesnoth:some_gui2_refactoring 0bda42e29003 / src/gui/dialogs/loading_screen.cpp: Fixup 32c18f613446 https://github.com/wesnoth/wesnoth/commit/0bda42e29003aa0bac8a0b51154c8600a24cb788
20170825 07:28:16< irker030> wesnoth: Charles Dang wesnoth:some_gui2_refactoring 0e0eec9b1866 / src/gui/widgets/listbox.cpp: Revert part of 7c90666bcc1e https://github.com/wesnoth/wesnoth/commit/0e0eec9b18664c56cc8ba0d6eea1aba9880f9ccf
20170825 07:28:19< irker030> wesnoth: Charles Dang wesnoth:some_gui2_refactoring cf039667d5ac / src/gui/widgets/chatbox.cpp: Fixup e8037aed5 https://github.com/wesnoth/wesnoth/commit/cf039667d5acd90c83e804a899b890961f35b091
20170825 07:29:43< irker030> wesnoth: Charles Dang wesnoth:some_gui2_refactoring 97374bb86731 / src/gui/dialogs/end_credits.cpp: Fixup c980ffc74feb https://github.com/wesnoth/wesnoth/commit/97374bb867311c3ed36320494cdb7e0eeb8c21bd
20170825 07:29:46< irker030> wesnoth: Charles Dang wesnoth:some_gui2_refactoring 23fad6d44ce7 / src/gui/widgets/listbox.cpp: Fixup cf039667d5ac https://github.com/wesnoth/wesnoth/commit/23fad6d44ce7762a6f13c47b65b988e247e6cb39
20170825 07:32:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170825 07:34:47-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170825 07:37:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 248 seconds]
20170825 07:43:43-!- Kwandulin [~Kwandulin@p200300E453CC3B31E97C308960A36D2E.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170825 08:08:41-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has quit [Remote host closed the connection]
20170825 08:17:03-!- Kwandulin [~Kwandulin@p200300E453CC3B31E97C308960A36D2E.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170825 08:39:11-!- Aginor [~andreas@unaffiliated/aginor] has joined #wesnoth-dev
20170825 08:39:34< Aginor> evening
20170825 08:41:10< vultraz_iOS> a wild Aginor appears!
20170825 08:42:56< Aginor> yeah, I've been mentioned on a hotkey related bug so I figured I could drop by
20170825 08:45:40< vultraz_iOS> we've been struggling with hotkey issues for months :(
20170825 08:46:10< zookeeper> quickly, unleash the swarm of bugs to pin him down before he can escape
20170825 08:46:37< vultraz_iOS> :P
20170825 08:47:04< Aginor> zerglings?
20170825 08:47:10< vultraz_iOS> zookeeper: you might want to mute irker in a few minutes
20170825 08:48:17< vultraz_iOS> Aginor: btw, you'll be pleased to know i have made much progress on accelerated_rendering
20170825 08:48:32< zookeeper> vultraz_iOS, just say when
20170825 08:48:38< vultraz_iOS> (not implying you need to test it or anything just saying)
20170825 08:49:03-!- mode/#wesnoth-dev [+o zookeeper] by ChanServ
20170825 08:49:18< Aginor> github needs faster servers
20170825 08:49:27< Aginor> cloning the servers now
20170825 08:49:32< Aginor> sources even
20170825 08:49:59< vultraz_iOS> i think github would object to you cloning their servers :P
20170825 08:53:51< vultraz_iOS> zookeeper: ok
20170825 08:54:08-!- mode/#wesnoth-dev [+q irker*!*@*] by zookeeper
20170825 08:56:42 * vultraz_iOS heads to dinner
20170825 09:05:04< Aginor> hmmm
20170825 09:05:18< Aginor> and I've managed to do a build
20170825 09:05:34< Aginor> onwards and upwards I guess
20170825 09:12:33< Aginor> yup, someone's certainly broken hotkeys
20170825 09:13:38-!- mode/#wesnoth-dev [-q irker*!*@*] by zookeeper
20170825 09:20:37< Aginor> command_executor.cpp:531 stops the execution of the hotkey after it's been correctly identified and matched
20170825 09:33:22< Aginor> I'm not quite sure what that line's trying to accomplish though
20170825 09:40:49< JyrkiVesterinen> Aginor: that line tries to stop IME input from being intrepreted as hotkeys.
20170825 09:41:59< Aginor> right...
20170825 09:42:28< Aginor> there's no guarantees that all entries in the event.text.text byte array is zeroed, so that check is likely to fail
20170825 09:42:53< Aginor> and you're trying to stop ö from being recognised?
20170825 09:43:35< JyrkiVesterinen> That might be related to why I get the issue. I test with MSVC debug builds, and Microsoft's debug heap manager fills uninitialized memory with magic patterns.
20170825 09:44:27< Aginor> it's a null-terminated string if memory serves
20170825 09:44:35< JyrkiVesterinen> No, Ö is supposed to work as a hotkey.
20170825 09:45:24< loonycyborg> Are hotkeys localized too?
20170825 09:45:38< loonycyborg> most of the world's keyboards won't be able to input it
20170825 09:45:40< JyrkiVesterinen> If I understand correctly, it's supposed to block it from being recognized as hotkeys if an IME gives multiple characters at one.
20170825 09:45:48< JyrkiVesterinen> (Not sure if that's even how IMEs work.)
20170825 09:46:51< Aginor> I'm not sure how that will work under windows
20170825 09:46:54< JyrkiVesterinen> Ö isn't a default hotkey, but players with a keyboard that have an Ö key (such as a Finnish keyboard) may want to manually set it as a hotkey.
20170825 09:47:17< Aginor> but under linux you'd only ever get one input with one character
20170825 09:47:51< JyrkiVesterinen> It would be best to discuss with celticminstrel, he introduced the check.
20170825 09:48:41< Aginor> I'd suggest reverting it and fix it in the matching functions instead
20170825 09:49:00< Aginor> this is spreading that logic over multiple places which makes it harder to debug and update
20170825 09:49:10< Aginor> but it's your decision
20170825 09:50:25< Aginor> just a heads up about matching on byte values in sdl events; they're a union type and events tend to be re-used and not fully zeroed out
20170825 09:50:43< Aginor> "event.text.text[31] == 0 " is always failing for me
20170825 10:02:26< Aginor> patch added to https://github.com/wesnoth/wesnoth/issues/1893
20170825 10:02:30< Aginor> fixes it for me
20170825 10:17:15< vultraz_iOS> does that fix hotkeys with shift?
20170825 10:17:47< Aginor> it used to work
20170825 10:17:54< Aginor> I wrote what I tested
20170825 10:18:17< vultraz_iOS> alright
20170825 10:18:22< vultraz_iOS> thanks for popping back in btw
20170825 10:22:41< irker030> wesnoth: Charles Dang wesnoth:some_gui2_refactoring 1fc988f49600 / src/gui/widgets/grid.hpp: GUI2/Grid: explicitly delete copy and move ctors https://github.com/wesnoth/wesnoth/commit/1fc988f4960055b09b9af989c4f115a7f3a1da5d
20170825 10:56:10-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
20170825 11:03:52-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20170825 11:10:54< Aginor> no worries
20170825 11:11:42< APic> Do not Panic.
20170825 11:11:45< APic> ☺
20170825 11:36:52-!- travis-ci [~travis-ci@ec2-54-242-179-217.compute-1.amazonaws.com] has joined #wesnoth-dev
20170825 11:36:53< travis-ci> wesnoth/wesnoth#14773 (some_gui2_refactoring - 1fc988f : Charles Dang): The build failed.
20170825 11:36:53< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/268310005
20170825 11:36:53-!- travis-ci [~travis-ci@ec2-54-242-179-217.compute-1.amazonaws.com] has left #wesnoth-dev []
20170825 12:04:40-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170825 12:12:31-!- atarocch [~atarocch@93.56.160.28] has joined #wesnoth-dev
20170825 12:13:29-!- atarocch [~atarocch@93.56.160.28] has quit [Client Quit]
20170825 12:32:58-!- Netsplit *.net <-> *.split quits: tomreyn, APic, nore, mattsc
20170825 12:33:20-!- Netsplit over, joins: APic, tomreyn, mattsc
20170825 12:34:08-!- Netsplit over, joins: nore
20170825 12:35:17-!- yaiyan [~yaiyan@46.101.48.31] has quit [Ping timeout: 260 seconds]
20170825 12:36:57-!- yaiyan [~yaiyan@46.101.48.31] has joined #wesnoth-dev
20170825 12:38:44-!- Kwandulin [~Kwandulin@p200300E453CC3B31E97C308960A36D2E.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170825 12:58:14-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20170825 13:10:02-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20170825 13:27:07-!- irker030 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170825 13:39:35-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170825 13:58:20-!- Kwandulin [~Kwandulin@p200300E453CC3B315C73524BA835DA88.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170825 14:13:34-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20170825 14:22:33-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20170825 14:45:45-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20170825 15:15:36-!- DeFender1031 [~DeFender1@93-172-23-172.bb.netvision.net.il] has quit [Quit: I'm not back now.]
20170825 15:20:49-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev
20170825 15:35:01-!- moongazer [~moongazer@117.222.44.67] has joined #wesnoth-dev
20170825 15:49:36-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170825 16:10:06-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170825 16:24:00-!- Kwandulin [~Kwandulin@p200300E453CC3B315C73524BA835DA88.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170825 16:43:33-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170825 16:47:42-!- Kwandulin [~Kwandulin@p200300E453CC3B315C73524BA835DA88.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170825 16:51:35-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170825 17:13:40-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170825 17:34:23-!- Bonobo [~Bonobo@203.220.138.162] has quit [Ping timeout: 248 seconds]
20170825 17:41:26-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170825 17:43:20-!- moongazer [~moongazer@117.222.44.67] has quit [Quit: Leaving]
20170825 17:48:22-!- Kwandulin [~Kwandulin@p200300E453CC3B315C73524BA835DA88.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170825 17:52:04-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170825 17:56:18-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Ping timeout: 240 seconds]
20170825 18:31:18-!- irker486 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170825 18:31:18< irker486> wesnoth: Jyrki Vesterinen wesnoth:some_gui2_refactoring f5c098b7cee3 / src/tests/gui/iterator.cpp: Attempt to fix build of unit tests on GCC 4.8 https://github.com/wesnoth/wesnoth/commit/f5c098b7cee3d3cf3b953b097faa266ad6828eed
20170825 18:53:31-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has joined #wesnoth-dev
20170825 18:57:57-!- gfgtdf [~chatzilla@x4e369c26.dyn.telefonica.de] has joined #wesnoth-dev
20170825 18:59:31-!- Kwandulin [~Kwandulin@p200300E453CC3B6F94315CD07A5B7E48.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170825 18:59:41< gfgtdf> Aginor: even though #1893 coudl be fixed by your commit, coudl you please explain what you mean by 'composed hotkeys ' at #1003 ? 
20170825 18:59:55-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has quit [Ping timeout: 276 seconds]
20170825 19:04:37-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170825 19:06:48< gfgtdf> Aginor: even if #1893 is fixed, the textbased input method still casus issues: 1) #1864 which is that using textcharacters for scrollign (like wasd) doesnt't work as expected (since it has no keyup events), 2) i cannot use 'dead keys' (like ^ (the default lua console hotkey) or `) for hotkeys.
20170825 19:15:21-!- moongazer [~moongazer@117.222.44.67] has joined #wesnoth-dev
20170825 19:16:36-!- moongazer [~moongazer@117.222.44.67] has quit [Max SendQ exceeded]
20170825 19:17:13-!- moongazer [~moongazer@117.222.44.67] has joined #wesnoth-dev
20170825 19:21:44-!- moongazer [~moongazer@117.222.44.67] has quit [Client Quit]
20170825 19:52:47< irker486> wesnoth: Jyrki Vesterinen wesnoth:some_gui2_refactoring 8da74b38b746 / src/tests/gui/ (iterator.cpp visitor.cpp): Attempt to fix build of unit tests on GCC 4.8 https://github.com/wesnoth/wesnoth/commit/8da74b38b746bf8efaf4d54f2b52eea2fd19c4b1
20170825 19:57:30-!- Kwandulin [~Kwandulin@p200300E453CC3B6F94315CD07A5B7E48.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170825 20:20:19-!- travis-ci [~travis-ci@ec2-54-163-185-254.compute-1.amazonaws.com] has joined #wesnoth-dev
20170825 20:20:20< travis-ci> wesnoth/wesnoth#14775 (some_gui2_refactoring - f5c098b : Jyrki Vesterinen): The build is still failing.
20170825 20:20:20< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/268472114
20170825 20:20:20-!- travis-ci [~travis-ci@ec2-54-163-185-254.compute-1.amazonaws.com] has left #wesnoth-dev []
20170825 20:28:32-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170825 20:33:29-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170825 20:41:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170825 20:41:12-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170825 20:55:56-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has joined #wesnoth-dev
20170825 21:00:49-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has quit [Ping timeout: 276 seconds]
20170825 21:16:51-!- gfgtdf [~chatzilla@x4e369c26.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20170825 21:23:45-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170825 21:27:37-!- mjs-de [~mjs-de@x5ce34c94.dyn.telefonica.de] has joined #wesnoth-dev
20170825 21:43:45-!- gfgtdf [~chatzilla@x4e369c26.dyn.telefonica.de] has joined #wesnoth-dev
20170825 21:48:41-!- travis-ci [~travis-ci@ec2-54-156-107-164.compute-1.amazonaws.com] has joined #wesnoth-dev
20170825 21:48:42< travis-ci> wesnoth/wesnoth#14777 (some_gui2_refactoring - 8da74b3 : Jyrki Vesterinen): The build was fixed.
20170825 21:48:42< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/268497245
20170825 21:48:42-!- travis-ci [~travis-ci@ec2-54-156-107-164.compute-1.amazonaws.com] has left #wesnoth-dev []
20170825 22:10:32-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20170825 22:16:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170825 22:27:26-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170825 22:30:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170825 22:45:20-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 248 seconds]
20170825 22:52:07-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170825 23:02:01-!- irker486 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170825 23:16:17-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170825 23:21:11-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170825 23:29:17-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170825 23:32:56-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170825 23:35:54-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170825 23:49:10-!- irker889 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170825 23:49:10< irker889> wesnoth: Charles Dang wesnoth:master da28824694bc / src/gui/widgets/settings.cpp: GUI2/Settings: minor formatting cleanup https://github.com/wesnoth/wesnoth/commit/da28824694bcd0086708a9f27cafaef8c78fb230
20170825 23:49:13< irker889> wesnoth: Charles Dang wesnoth:master d78158d2121f / src/gui/core/ (window_builder.cpp window_builder.hpp): GUI2/Window Builder: added function to generate a single widget instance with it https://github.com/wesnoth/wesnoth/commit/d78158d2121f72f6854eb3a40471a34429256db7
20170825 23:49:16< irker889> wesnoth: Charles Dang wesnoth:master a87132ab6b9b / src/gui/ (69 files in 2 dirs): GUI2: refactored widget initialization process https://github.com/wesnoth/wesnoth/commit/a87132ab6b9b87cab254c0429fcffe529b974876
20170825 23:49:19< irker889> wesnoth: Charles Dang wesnoth:master e0e76c4f1575 / src/gui/widgets/ (scrollbar.hpp slider.cpp): GUI2: prevented Scrollbar (and by extension Slider) step size from being set to  https://github.com/wesnoth/wesnoth/commit/e0e76c4f1575dc9dfd5f6856d079329bd48669eb
20170825 23:49:22< irker889> wesnoth: Charles Dang wesnoth:master b5c42234d2c2 / src/gui/ (core/window_builder.cpp widgets/window.cpp widgets/window.hpp): GUI2/Window: pass definition pointer to ctor instead of individual arguments https://github.com/wesnoth/wesnoth/commit/b5c42234d2c2ae4f98e7d8298b73746fd66bae27
20170825 23:49:25< irker889> wesnoth: Charles Dang wesnoth:master 7e5e7b8b17e7 / src/gui/core/ (register_widget.hpp window_builder.hpp): GUI2/Window Builder: removed build_widget function and used std::make_shared dir https://github.com/wesnoth/wesnoth/commit/7e5e7b8b17e7c665feb8830a3740ba9b71c6da1a
20170825 23:49:28< irker889> wesnoth: Charles Dang wesnoth:master 71f97044ccdb / src/gui/core/window_builder.hpp: GUI2/Window Builder: added comment clarifying Window how resolution options are  https://github.com/wesnoth/wesnoth/commit/71f97044ccdb0ea1b757e021fd38b6afdbfbfc4f
20170825 23:49:31< irker889> wesnoth: Charles Dang wesnoth:master bb5e283d402d / src/gui/ (59 files in 2 dirs): GUI2: allow REGISTER_WIDGET to implement get_control_type overrides https://github.com/wesnoth/wesnoth/commit/bb5e283d402d9f3de28eab8e325a06e09a7e4a0a
20170825 23:49:34< irker889> wesnoth: Charles Dang wesnoth:master 39043fb940d7 / src/gui/ (core/event/distributor.cpp core/window_builder.cpp widgets/window.cpp): GUI2: don't use `0` to initialize nullptrs https://github.com/wesnoth/wesnoth/commit/39043fb940d7acba7cea43e24dd1df3919a0d342
20170825 23:49:37< irker889> wesnoth: Charles Dang wesnoth:master 665246525f47 / src/tests/gui/iterator.cpp: Fixup tests for ea15d45 https://github.com/wesnoth/wesnoth/commit/665246525f4756cb35af4798a50c4a0598af13ea
20170825 23:49:40< irker889> wesnoth: Charles Dang wesnoth:master 86e853b5f962 / src/gui/widgets/status_label_helper.hpp: GUI2/Status Label Helper: minor cleanup and added documentation https://github.com/wesnoth/wesnoth/commit/86e853b5f962b4500b5a199d91e19faba58ff24a
20170825 23:49:43< irker889> wesnoth: Charles Dang wesnoth:master 573268a9b318 / src/gui/ (4 files in 4 dirs): GUI2/Status Label Helper: take source containing widget as a pointer https://github.com/wesnoth/wesnoth/commit/573268a9b3189d2e2bd275b26521237bdf065519
20170825 23:49:46< irker889> wesnoth: Charles Dang wesnoth:master 994742b90f7d / src/gui/dialogs/preferences_dialog.cpp: GUI2/Preferences Dialog: use standard status label value getters instead of lamb https://github.com/wesnoth/wesnoth/commit/994742b90f7d3909143556fa21c7d6b3e1dec653
20170825 23:49:49< irker889> wesnoth: Charles Dang wesnoth:master 943870656094 / src/gui/widgets/ (listbox.cpp listbox.hpp): GUI2/Listbox: move some common code for key handling to its own function https://github.com/wesnoth/wesnoth/commit/9438706560943ddbae968632b4660d278917bdfd
20170825 23:49:52< irker889> wesnoth: Charles Dang wesnoth:master 80f5af2e7915 / src/gui/widgets/listbox.cpp: GUI2/Listbox: fire NOTIFY_MODIFIED events where callback_value_changed_ is calle https://github.com/wesnoth/wesnoth/commit/80f5af2e79154d2576aeb053d54f47c3dd82fbfc
20170825 23:49:55< irker889> wesnoth: Charles Dang wesnoth:master e58bbd7a20df / src/ (22 files in 7 dirs): GUI2: use signal handlers for listbox event handling https://github.com/wesnoth/wesnoth/commit/e58bbd7a20dfe492e16d967bf9e5951a92dc5c1c
20170825 23:49:58< irker889> wesnoth: Charles Dang wesnoth:master d7de5a6ade12 / src/gui/widgets/ (listbox.cpp listbox.hpp): GUI2/Listbox: removed callback interface https://github.com/wesnoth/wesnoth/commit/d7de5a6ade129b4276c6396f16176ca754f97fe2
20170825 23:50:01< irker889> wesnoth: Charles Dang wesnoth:master 6b7b922bc7be / src/gui/widgets/toggle_button.cpp: GUI2/Toggle Button: fire NOTIFY_MODIFIED when setting value https://github.com/wesnoth/wesnoth/commit/6b7b922bc7becf897d144621518ce2f07819cf8e
20170825 23:50:04< irker889> wesnoth: Charles Dang wesnoth:master 6d4b092f570a / src/gui/auxiliary/field.hpp: GUI2/Field: minor mostly cosmetic cleanup https://github.com/wesnoth/wesnoth/commit/6d4b092f570a3fcc8fe0fcfb94d035aa4af881a4
20170825 23:50:07< irker889> wesnoth: Charles Dang wesnoth:master f7a2b5112e39 / src/gui/core/event/ (dispatcher.cpp dispatcher.hpp): GUI2/Dispatcher: changed dispatcher signals to take a widget reference as a firs https://github.com/wesnoth/wesnoth/commit/f7a2b5112e392784c79ba8321f61e6419ac2f375
20170825 23:50:10< irker889> wesnoth: Charles Dang wesnoth:master 2a1c1a81fcf1 / src/ (15 files in 7 dirs): GUI2: convert uses of 'state changed' callbacks to NOTIFY_MODIFIED signal handle https://github.com/wesnoth/wesnoth/commit/2a1c1a81fcf1972a2dbf58c7115b70e1b2a461d3
20170825 23:50:13< irker889> wesnoth: Charles Dang wesnoth:master d04c3f63f249 / src/gui/widgets/ (7 files): GUI2: removed state_changed callback interface from selected_item child classes https://github.com/wesnoth/wesnoth/commit/d04c3f63f2497522b126c3632f29307ef6528e4f
20170825 23:50:16< irker889> wesnoth: Charles Dang wesnoth:master 8331cdb64ca0 / src/gui/dialogs/ (unit_create.cpp unit_create.hpp): GUI2/Unit Create: show type details based on currently selected gender https://github.com/wesnoth/wesnoth/commit/8331cdb64ca05259dadbb458cbb4d4f8c212b21e
20170825 23:50:19< irker889> wesnoth: Charles Dang wesnoth:master b36e0476c6f1 / src/gui/core/event/dispatcher.hpp: GUI2/Dispatcher: added signal handler register helper for double click events https://github.com/wesnoth/wesnoth/commit/b36e0476c6f1e2ed58386b3ee680763eb3eeb332
20170825 23:50:22< irker889> wesnoth: Charles Dang wesnoth:master 20ecc9497fce / src/gui/dialogs/lobby/lobby.cpp: GUI2/MP Lobby: convert two uses of set_callback_mouse_left_double_click to signa https://github.com/wesnoth/wesnoth/commit/20ecc9497fce12783de0f1e0e31aa2efbf5176a0
20170825 23:50:25< irker889> wesnoth: Charles Dang wesnoth:master 2ee3425ad02c / src/gui/widgets/ (toggle_panel.cpp toggle_panel.hpp): GUI2/Toggle Panel: removed callback_mouse_left_double_click interface https://github.com/wesnoth/wesnoth/commit/2ee3425ad02c7f0f3b3410676bf004b673ace101
20170825 23:50:28< irker889> wesnoth: Charles Dang wesnoth:master 5428606cd1a4 / src/gui/widgets/text_box.cpp: GUI2/Text Box: set font size and style in ctor (fixes issue with password box) https://github.com/wesnoth/wesnoth/commit/5428606cd1a483107cffeb707e0cbfcd2520fcc1
20170825 23:50:31< irker889> wesnoth: Charles Dang wesnoth:master d92a528240e6 / src/gui/dialogs/preferences_dialog.cpp: GUI2/Preferences Dialog: added more explanatory comments about binding lambdas https://github.com/wesnoth/wesnoth/commit/d92a528240e62fa78ddde64d85215a003625dacc
20170825 23:50:34< irker889> wesnoth: Charles Dang wesnoth:master 84f3e79504d4 / data/gui/window/unit_advance.cfg: GUI2/Unit Advance: allowed text formatting in advancement name field (closes #19 https://github.com/wesnoth/wesnoth/commit/84f3e79504d4722c6e09a377703073dcd7b790af
20170825 23:50:37< irker889> wesnoth: Charles Dang wesnoth:master d6a6ec1ea5cb / src/gui/ (5 files in 5 dirs): Standardized my comment signature date format (using ISO 8601) https://github.com/wesnoth/wesnoth/commit/d6a6ec1ea5cb633e0ac7f67bfd7bb22fa9b23c03
20170825 23:50:40< irker889> wesnoth: Charles Dang wesnoth:master 5f1695a46c63 / src/gui/core/event/ (dispatcher.cpp dispatcher.hpp): GUI2/Dispatcher: removed inline specifier from [dis]connect_signal_* functions https://github.com/wesnoth/wesnoth/commit/5f1695a46c63a111871cf12447de8ac6d8e4970c
20170825 23:50:43< irker889> wesnoth: Charles Dang wesnoth:master 936a87ff1854 / src/gui/widgets/listbox.cpp: GUI2/Listbox: used std::less instead of custom comparison function https://github.com/wesnoth/wesnoth/commit/936a87ff1854211cc19370d2e2ec64f34f21b327
20170825 23:50:46< irker889> wesnoth: Charles Dang wesnoth:master 94ca31cb0a4b / src/gui/widgets/ (generator.hpp generator_private.hpp listbox.cpp listbox.hpp): GUI2: drop t-prefix from order_func typedef https://github.com/wesnoth/wesnoth/commit/94ca31cb0a4bc77a4584e4d18fe0675aa041c72c
20170825 23:50:49< irker889> wesnoth: Charles Dang wesnoth:master 407486bfc48c / src/gui/widgets/ (listbox.cpp listbox.hpp): GUI2/Listbox: formatting cleanup https://github.com/wesnoth/wesnoth/commit/407486bfc48c313a892f4501a5b52cca82ebd464
20170825 23:50:52< irker889> wesnoth: Charles Dang wesnoth:master 99c5cb0399ce / src/gui/widgets/styled_widget.hpp: GUI2/Styled Widget: removed now-unnecessary friend declaration for the window cl https://github.com/wesnoth/wesnoth/commit/99c5cb0399ce25f559f012dec0ee42f223988ac7
20170825 23:50:55< irker889> wesnoth: Charles Dang wesnoth:master b40d79d92dea / src/gui/widgets/ (listbox.cpp listbox.hpp): GUI2/Listbox: pass list grid builder directly to constructor https://github.com/wesnoth/wesnoth/commit/b40d79d92dea89ab9ee7ac73c102294ce2b852ad
20170825 23:50:58< irker889> wesnoth: Charles Dang wesnoth:master 357087770752 / src/gui/widgets/generator.cpp: GUI2/Generator: use static_assert to have actual compile-time assertions https://github.com/wesnoth/wesnoth/commit/357087770752f75336f65355a207bbb28e4cb3a9
20170825 23:51:01< irker889> wesnoth: Charles Dang wesnoth:master 23734c3aaa8c / src/gui/widgets/ (generator.cpp generator_private.hpp): GUI2/Generator: formatting cleanup https://github.com/wesnoth/wesnoth/commit/23734c3aaa8c48f092a52d02b7ec42bf941d7170
20170825 23:51:04< irker889> wesnoth: Charles Dang wesnoth:master 029e93601352 / src/gui/ (core/event/handler.cpp widgets/window.cpp widgets/window.hpp): GUI2/Window: handle CLOSE_WINDOW event with a signal handler https://github.com/wesnoth/wesnoth/commit/029e9360135260d37cf58d68e1d3301ed0dd3225
20170825 23:51:07< irker889> wesnoth: Charles Dang wesnoth:master 2cf5ce0154cd / src/tests/gui/visitor.cpp: More test fixup https://github.com/wesnoth/wesnoth/commit/2cf5ce0154cdcb38d2964f8b232a0b48c2d584ad
20170825 23:51:10< irker889> wesnoth: Charles Dang wesnoth:master 201fafd5ea2b / src/gui/widgets/text_box_base.cpp: GUI2/Text Box Base: made ctrl+a select all text https://github.com/wesnoth/wesnoth/commit/201fafd5ea2b55cc1b58f2b9632e7a1f1003510c
20170825 23:51:13< irker889> wesnoth: Charles Dang wesnoth:master 304702a03993 / src/gui/dialogs/loading_screen.cpp: GUI2/Loading Screen: formatting cleanup https://github.com/wesnoth/wesnoth/commit/304702a0399392b5f49b78fe66ef1334860c39aa
20170825 23:51:16< irker889> wesnoth: Charles Dang wesnoth:master 79abf8006bbc / src/gui/dialogs/ (5 files in 2 dirs): GUI2: require existence of all widgets added to tab order https://github.com/wesnoth/wesnoth/commit/79abf8006bbc631a18a0cb9f22fd1fa02b0dc6fc
20170825 23:51:19< irker889> wesnoth: Charles Dang wesnoth:master 92cfaf431ec3 / src/gui/dialogs/ (9 files in 4 dirs): GUI2: use find_widget overload returning a pointer when applicable https://github.com/wesnoth/wesnoth/commit/92cfaf431ec3fbf587e4b906c534a836280b4ea8
20170825 23:51:22< irker889> wesnoth: Charles Dang wesnoth:master 201417f76ddd / src/gui/dialogs/ (end_credits.cpp end_credits.hpp): GUI2/End Credits: use DRAW event hook to scroll text instead of a timer https://github.com/wesnoth/wesnoth/commit/201417f76ddd6267eaa63a143648b64a2058c323
20170825 23:51:25< irker889> wesnoth: Charles Dang wesnoth:master 4f159e2fd0cb / src/gui/widgets/listbox.cpp: GUI2/Listbox: cleaned up set/get_active_sorting_option functions https://github.com/wesnoth/wesnoth/commit/4f159e2fd0cb7f05ce4aed4e570bbaa52e3e2beb
20170825 23:51:28< irker889> wesnoth: Charles Dang wesnoth:master 8b9a2f550e57 / src/gui/widgets/ (listbox.cpp listbox.hpp): GUI2/Listbox: use an enum for update_visible_area_on_key_event's argument https://github.com/wesnoth/wesnoth/commit/8b9a2f550e5778bfc02db7d0371a14d173934cdd
20170825 23:51:31< irker889> wesnoth: Charles Dang wesnoth:master 17969718a7c0 / src/gui/widgets/listbox.cpp: GUI2/Listbox: pass list_item_clicked directly to generator w/o intermediary help https://github.com/wesnoth/wesnoth/commit/17969718a7c0273f5cf7e75974a1035b58dbaca4
20170825 23:51:34< irker889> wesnoth: Charles Dang wesnoth:master eff2fc60e6b3 / src/gui/widgets/grid.hpp: GUI2/Grid: explicitly delete copy and move ctors https://github.com/wesnoth/wesnoth/commit/eff2fc60e6b3c419fc44e80bc6000a1cd80be8df
20170825 23:51:37< irker889> wesnoth: Jyrki Vesterinen wesnoth:master cd68243e641a / src/tests/gui/ (iterator.cpp visitor.cpp): Attempt to fix build of unit tests on GCC 4.8 https://github.com/wesnoth/wesnoth/commit/cd68243e641a18d256840962f7993c373565ef24
20170825 23:52:39-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170825 23:53:03< Aginor> gfgtdf: : is a composed character, it's a multi-input sequence. It would also allow you to have '多' as input (random character from google translate) if you have the right composition set up for your keyboard.
20170825 23:53:29-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170825 23:53:58< vultraz_iOS> that ended up being a lot of refactoring after all
20170825 23:54:04< vultraz_iOS> (what i just merged)
20170825 23:54:20< Aginor> gfgtdf: I'm pretty sure that ~ and ` used to work when PR 1003 was merged. I haven't looked at what's happened since
20170825 23:55:20< Aginor> The only reason I looked at this is because I was brought in on the conversation
--- Log closed Sat Aug 26 00:00:27 2017