--- Log opened Sat Aug 26 00:00:27 2017
20170826 00:01:02< gfgtdf> Aginor: but : and  '多' also worked before pr #1003 right ? they were just storesd as shift+; or whetherver sequence is used to produce  多
20170826 00:02:27< gfgtdf> Aginor: also the part about ^ and ` not working does depend on the keyboard layout, since they are probably not dead characters in us keyboard layout.
20170826 00:14:38< gfgtdf> vultraz_iOS: do you know why dialog_callback_wrapper::forward (scripting/lua_gui2.cpp) is a member function instead of a free function ? I mena that code creates static dialog_callback_wrapper objects contain no data but are used to bind dialog_callback_wrapper::forward 
20170826 00:14:54< vultraz_iOS> no idea
20170826 00:16:54< vultraz_iOS> could probably jusy bind the callback directly
20170826 00:18:36< vultraz_iOS> gfgtdf: is the filter refactor ready to merge?
20170826 00:19:35< gfgtdf> vultraz_iOS: didn't work on it lateley, it works as-is but won't be a huge gain unless we change the evet code not to recreate filters everytime we evaluate them
20170826 00:20:04< vultraz_iOS> hm can that be done
20170826 00:20:33< gfgtdf> event code*
20170826 00:21:44< gfgtdf> vultraz_iOS: yes it can, 
20170826 00:49:42-!- mjs-de [~mjs-de@x5ce34c94.dyn.telefonica.de] has quit [Remote host closed the connection]
20170826 01:09:47-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170826 01:13:35< irker889> wesnoth: sigurdfdragon wesnoth:master d80d851e3fa5 / data/campaigns/Two_Brothers/scenarios/01_Rooting_Out_a_Mage.cfg: AToTB S1: Provide a hint for players https://github.com/wesnoth/wesnoth/commit/d80d851e3fa5afa793750e75792033ef747339b3
20170826 01:13:37< irker889> wesnoth: sigurdfdragon wesnoth:master d9324f407e68 / data/campaigns/tutorial/scenarios/02_Tutorial_part_2.cfg: T S2: Adjust suggestion to better match new beginner campaign order https://github.com/wesnoth/wesnoth/commit/d9324f407e689e8e01d68c44b4ea077bcb99b710
20170826 01:14:05-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Ping timeout: 240 seconds]
20170826 01:14:46< vultraz_iOS> gfgtdf: btw whatever happened to your slider refactor?
20170826 01:16:11-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has joined #wesnoth-dev
20170826 01:29:19-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has quit [Remote host closed the connection]
20170826 01:30:40-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has joined #wesnoth-dev
20170826 01:32:31-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has quit [Remote host closed the connection]
20170826 01:36:14-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has joined #wesnoth-dev
20170826 01:43:01-!- gfgtdf_ [~chatzilla@x4e36958f.dyn.telefonica.de] has joined #wesnoth-dev
20170826 01:45:05-!- gfgtdf [~chatzilla@x4e369c26.dyn.telefonica.de] has quit [Ping timeout: 248 seconds]
20170826 01:45:11-!- gfgtdf_ is now known as gfgtdf
20170826 01:54:16< gfgtdf> vultraz_iOS: hmm don't remember actually.
20170826 01:54:29< gfgtdf> vultraz_iOS: i have a local branch somehwere
20170826 01:54:37-!- gfgtdf [~chatzilla@x4e36958f.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 54.0.1/20170628075643]]
20170826 02:05:41-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has quit [Remote host closed the connection]
20170826 02:11:19-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170826 02:11:25-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170826 02:12:47-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170826 02:29:31< irker889> wesnoth: Gregory A Lundberg wesnoth:master f3413228d59b / src/gui/core/window_builder.hpp: Fix autodoc error: missing tparam name https://github.com/wesnoth/wesnoth/commit/f3413228d59bcf9f5cc662db3d6dc36f81daa282
20170826 02:37:28-!- 7GHAADXWB [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170826 02:37:38-!- Bonobo [~Bonobo@203.220.138.162] has joined #wesnoth-dev
20170826 02:38:51< vultraz_iOS> celticminstrel: please review Aginor's path
20170826 02:38:53< vultraz_iOS> atch
20170826 02:38:54< vultraz_iOS> PATCH
20170826 02:38:56< vultraz_iOS> >_<
20170826 02:40:27< celticminstrel> ???
20170826 02:40:43< vultraz_iOS> celticminstrel: Aginor fixed the single-hotkeys-not-working issue
20170826 02:40:46< vultraz_iOS> please review his patch
20170826 02:40:59-!- travis-ci [~travis-ci@ec2-54-156-107-164.compute-1.amazonaws.com] has joined #wesnoth-dev
20170826 02:41:00< travis-ci> wesnoth/wesnoth#14782 (master - f341322 : Gregory A Lundberg): The build was canceled.
20170826 02:41:00< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/268584680
20170826 02:41:00-!- travis-ci [~travis-ci@ec2-54-156-107-164.compute-1.amazonaws.com] has left #wesnoth-dev []
20170826 02:41:02< celticminstrel> I'm not seeing an open PR...
20170826 02:41:17< vultraz_iOS> he commented on https://github.com/wesnoth/wesnoth/issues/1893
20170826 02:41:20< vultraz_iOS> not as a PR
20170826 02:43:24< celticminstrel> Looks good at a glance.
20170826 02:43:54< irker889> wesnoth: Charles Dang wesnoth:master ccc9917dbb32 / src/gui/widgets/ (7 files): GUI2: updated some class names in comments https://github.com/wesnoth/wesnoth/commit/ccc9917dbb3268a8475f2f600c0afdd3949e4fb5
20170826 02:46:28-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20170826 02:52:38-!- 7GHAADXWB [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170826 03:21:48-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has joined #wesnoth-dev
20170826 03:24:29-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170826 03:28:03-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has quit [Remote host closed the connection]
20170826 04:37:46-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20170826 05:30:30-!- Kwandulin [~Kwandulin@p200300E453CC3B6F94315CD07A5B7E48.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170826 05:33:30-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170826 05:48:00-!- irker889 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170826 06:00:25-!- irker280 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170826 06:00:25< irker280> wesnoth: Charles Dang wesnoth:master 89625f13e873 / src/gui/widgets/ (scrollbar_container.cpp scrollbar_container.hpp): GUI2/Scrollbar Container: initial formatting cleanup https://github.com/wesnoth/wesnoth/commit/89625f13e873252c84546448dfa8f0ec4a5a5bb8
20170826 06:00:26< irker280> wesnoth: Charles Dang wesnoth:master 8afc90d5e074 / src/ (5 files in 3 dirs): Bunch of comment typo fixes https://github.com/wesnoth/wesnoth/commit/8afc90d5e0745fa8d25b1258ec94400a8dc4c5e2
20170826 06:00:27< irker280> wesnoth: Charles Dang wesnoth:master c9cc9e27acf7 / src/gui/widgets/ (slider.cpp slider.hpp): GUI2/Slider: formatting cleanup https://github.com/wesnoth/wesnoth/commit/c9cc9e27acf7eae9f3daa00f2611061d62f24429
20170826 06:00:29< irker280> wesnoth: Charles Dang wesnoth:master 15105c2dfd46 / src/gui/dialogs/preferences_dialog.cpp: GUI2/Preference Dialog: pass a value label generator directly to accl speed slid https://github.com/wesnoth/wesnoth/commit/15105c2dfd46d24dfb0e22db0f4c638e0064b3c1
20170826 06:00:31< irker280> wesnoth: Charles Dang wesnoth:master 683c95c53f0a / src/gui/widgets/ (slider.cpp slider.hpp): GUI2/Slider: improved some comments and naming related to value labels https://github.com/wesnoth/wesnoth/commit/683c95c53f0aa484a8d7bc0a1b7847a922e35087
20170826 06:05:37-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170826 06:46:32-!- Aginor [~andreas@unaffiliated/aginor] has left #wesnoth-dev []
20170826 06:49:34-!- zookeeper [~lmsnie@192.130.252.23] has joined #wesnoth-dev
20170826 06:49:39-!- zookeeper [~lmsnie@192.130.252.23] has quit [Changing host]
20170826 06:49:39-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170826 07:04:47-!- mjs-de [~mjs-de@x5ce34c94.dyn.telefonica.de] has joined #wesnoth-dev
20170826 07:08:16-!- Bonobo [~Bonobo@203.220.138.162] has quit [Ping timeout: 248 seconds]
20170826 07:09:00-!- Bonobo [~Bonobo@203.220.138.162] has joined #wesnoth-dev
20170826 07:29:26-!- vn971 [~vasya@92.243.181.36] has quit [Quit: Leaving.]
20170826 07:54:06-!- markus__ [~mjs-de@x55b633f4.dyn.telefonica.de] has joined #wesnoth-dev
20170826 07:57:00-!- mjs-de [~mjs-de@x5ce34c94.dyn.telefonica.de] has quit [Ping timeout: 252 seconds]
20170826 08:07:55-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170826 08:30:44-!- Aginor [~andreas@unaffiliated/aginor] has joined #wesnoth-dev
20170826 08:30:47< Aginor> 19:32 < Aginor> 20170826 00:02:27< gfgtdf> Aginor: also the part about ^ and `  not working does depend on the keyboard layout, since they are  probably not dead characters in us keyboard layout.
20170826 08:30:51< Aginor> 19:32 < Aginor> they are in the same class as ':' and are poor choises to begin  with
20170826 08:30:54< Aginor> 19:33 < Aginor> especially '`' since it's not naturally occuring as a  standalone character in many characters, if I use my native  swedish layout I have to type "shift+'," space to get it
20170826 08:30:58< Aginor> 19:42 < Aginor> as for using wasd for scrolling, I guess you have to look at  the key-repeat and deconstruct those events. It's not something  I considered
20170826 08:31:01< Aginor> 19:43 < Aginor> you can of course revert the text input change, it's reasonably  self contained
20170826 08:31:04< Aginor> 19:43 < Aginor> I only did it because people were requesting it :)
20170826 08:43:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170826 08:51:40-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170826 09:20:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170826 10:05:04-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170826 10:30:50-!- gfgtdf [~chatzilla@x4e36958f.dyn.telefonica.de] has joined #wesnoth-dev
20170826 10:31:45< gfgtdf> vultraz_iOS: i just tested #1906 (filter refactor) again and came to the conclusion that in it curren form it has no disavnatges even for filters that are just checked once, so i'm probably just going to merge it as-is
20170826 10:33:22< gfgtdf> i'll then make a feturerequest for the other part that i wanted to do so that i won't forget it
20170826 10:43:07< gfgtdf> vultraz_iOS: about the silders, i think the last problem i worked on wa the follwing: in mp create it can happen that the default value is not  multiple of 25 (let's say 88) so i wonererd whetehr i coudl make the slider range soemthing like 0-25-50-75-88-100-125 ...) where an extra valid position woudol be inserted at 88.
20170826 10:43:32< gfgtdf> vultraz_iOS: this somehow turnned out to be nontrivial to implement in a clean way.
20170826 10:43:41< gfgtdf> but it's till on my todo list
20170826 10:50:55< gfgtdf> still
20170826 11:35:35-!- irker280 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170826 11:52:50-!- Kwandulin [~Kwandulin@p200300E453CC3B6F94315CD07A5B7E48.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170826 12:13:24-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170826 12:25:10-!- Kwandulin [~Kwandulin@p200300E453CC3B6F94315CD07A5B7E48.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170826 12:27:58-!- gfgtdf [~chatzilla@x4e36958f.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 55.0.3/20170824053622]]
20170826 12:41:16-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170826 12:41:23-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170826 12:48:38-!- Duthlet [~Duthlet@ipservice-092-211-168-098.092.211.pools.vodafone-ip.de] has joined #wesnoth-dev
20170826 13:51:37-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170826 14:00:18-!- Kwandulin [~Kwandulin@p200300E453CC3B6F94315CD07A5B7E48.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170826 14:08:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170826 14:55:41-!- Kwandulin [~Kwandulin@p200300E453CC3B6F54DDFB465C42113D.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170826 15:07:08-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170826 15:07:15-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170826 15:26:16-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170826 15:31:31-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170826 15:36:47-!- irker976 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170826 15:36:47< irker976> wesnoth: Charles Dang wesnoth:master 6a0828eeaadc / src/gui/widgets/ (container_base.cpp container_base.hpp): GUI2/Container Base: removed unnecessary virtual function slated for removal https://github.com/wesnoth/wesnoth/commit/6a0828eeaadc9fb98ebf75e2faf14b7c8545ea14
20170826 15:36:47< irker976> wesnoth: Charles Dang wesnoth:master ca0a9b2010b9 / src/gui/widgets/ (grid.cpp grid.hpp): GUI2/Grid: refactor handling of cell widgets https://github.com/wesnoth/wesnoth/commit/ca0a9b2010b9784bb54674762f6796832feb68c4
20170826 15:36:48< irker976> wesnoth: Charles Dang wesnoth:master 74935c492d94 / src/gui/widgets/ (scrollbar_container.cpp scrollbar_container.hpp): GUI2/Scrollbar Container: manage content grid with a unique ptr https://github.com/wesnoth/wesnoth/commit/74935c492d9477d54d850c57dfee1e0ff534bac7
20170826 15:36:50< irker976> wesnoth: Charles Dang wesnoth:master 9bb6ab0eab10 / src/gui/widgets/scrollbar_container.hpp: GUI2/Scrollbar Container: marked destructor as virtual, as it should be https://github.com/wesnoth/wesnoth/commit/9bb6ab0eab103a7e250f718fcb2d6d8086a253b4
20170826 15:42:36-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170826 15:42:43-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170826 15:54:27-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Ping timeout: 260 seconds]
20170826 16:06:14-!- Kwandulin [~Kwandulin@p200300E453CC3B6F54DDFB465C42113D.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170826 16:09:35-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20170826 16:21:56-!- Appveyor [~Appveyor@67.225.139.254] has joined #wesnoth-dev
20170826 16:21:56< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release Charles Dang 9bb6ab0: GUI2/Scrollbar Container: marked destructor as virtual, as it should be Failed
20170826 16:21:56< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-443
20170826 16:22:00-!- Appveyor [~Appveyor@67.225.139.254] has left #wesnoth-dev []
20170826 16:27:37-!- markus__ is now known as mjs-de
20170826 16:32:47-!- celticminstrel is now known as celmin|away
20170826 16:46:22-!- Kwandulin [~Kwandulin@p200300E453CC3B6FDDD099500481A543.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170826 16:58:12-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170826 16:58:18-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170826 17:14:22-!- Bonobo [~Bonobo@203.220.138.162] has quit [Ping timeout: 276 seconds]
20170826 17:24:50-!- DeFender1031 [~DeFender1@93-172-23-172.bb.netvision.net.il] has joined #wesnoth-dev
20170826 17:33:53-!- Duthlet [~Duthlet@ipservice-092-211-168-098.092.211.pools.vodafone-ip.de] has quit [Ping timeout: 248 seconds]
20170826 17:41:47-!- Appveyor [~Appveyor@67.225.139.254] has joined #wesnoth-dev
20170826 17:41:47< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug Charles Dang 9bb6ab0: GUI2/Scrollbar Container: marked destructor as virtual, as it should be Failed
20170826 17:41:48< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-443
20170826 17:41:51-!- Appveyor [~Appveyor@67.225.139.254] has left #wesnoth-dev []
20170826 17:51:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20170826 17:51:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170826 17:54:43-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170826 17:55:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20170826 18:01:49-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 276 seconds]
20170826 18:19:34-!- Kwandulin [~Kwandulin@p200300E453CC3B6FDDD099500481A543.dip0.t-ipconnect.de] has quit [Ping timeout: 246 seconds]
20170826 18:28:19-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170826 18:31:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170826 18:33:35-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20170826 18:37:58-!- irker976 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170826 18:43:45-!- irker867 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170826 18:43:45< irker867> wesnoth: Jyrki Vesterinen wesnoth:master 1b7bc55f194f / src/gui/widgets/grid.hpp: Fix build with Visual Studio 2013 https://github.com/wesnoth/wesnoth/commit/1b7bc55f194fc407f18564476c918ea354aec106
20170826 18:45:19-!- stikonas2 [~stikonas@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170826 18:51:22-!- stikonas2 [~stikonas@wesnoth/translator/stikonas] has quit [Ping timeout: 264 seconds]
20170826 18:51:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 255 seconds]
20170826 18:53:28-!- Kwandulin [~Kwandulin@p200300E453CC3B65047A3873674F8289.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170826 19:01:09-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170826 19:15:34-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170826 19:22:07-!- mjs-de [~mjs-de@x55b633f4.dyn.telefonica.de] has quit [Ping timeout: 255 seconds]
20170826 19:22:43-!- mjs-de [~mjs-de@x55b633f4.dyn.telefonica.de] has joined #wesnoth-dev
20170826 19:34:12-!- gfgtdf [~chatzilla@x4e36958f.dyn.telefonica.de] has joined #wesnoth-dev
20170826 19:42:20-!- Kwandulin [~Kwandulin@p200300E453CC3B65047A3873674F8289.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170826 19:58:56-!- mjs-de [~mjs-de@x55b633f4.dyn.telefonica.de] has quit [Ping timeout: 246 seconds]
20170826 19:59:21-!- mjs-de [~mjs-de@x55b633f4.dyn.telefonica.de] has joined #wesnoth-dev
20170826 20:18:55-!- mjs-de [~mjs-de@x55b633f4.dyn.telefonica.de] has quit [Remote host closed the connection]
20170826 20:22:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170826 20:27:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 252 seconds]
20170826 20:28:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170826 20:33:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 248 seconds]
20170826 20:39:53-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170826 20:40:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170826 20:43:14-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170826 20:48:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170826 20:48:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170826 20:53:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20170826 20:53:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170826 21:08:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20170826 21:09:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170826 21:11:16-!- celmin|away is now known as celticminstrel
20170826 21:15:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds]
20170826 21:26:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170826 21:31:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds]
20170826 21:33:20-!- amello [~amello@179.159.56.56] has joined #wesnoth-dev
20170826 21:47:23-!- irker867 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170826 21:49:17-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20170826 21:49:44-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170826 21:51:59-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170826 22:02:07< vultraz_iOS> celticminstrel: you build with MSVC right?
20170826 22:02:09< vultraz_iOS> on windows right?
20170826 22:03:12< vultraz_iOS> celticminstrel: do you observe https://github.com/wesnoth/wesnoth/issues/1921
20170826 22:05:13-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170826 22:05:14< Appveyor> wesnoth - Release gfgtdf f5c4ae4: remvoe set_flat_tod from unit_filter ctor parmaters Failed
20170826 22:05:14< Appveyor> Details: https://ci.appveyor.com/project/gfgtdf/wesnoth/build/Wesnoth-VS2017-filter_refactor-10
20170826 22:05:17-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170826 22:14:23-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170826 22:14:23< Appveyor> wesnoth - Debug gfgtdf f5c4ae4: remvoe set_flat_tod from unit_filter ctor parmaters Failed
20170826 22:14:23< Appveyor> Details: https://ci.appveyor.com/project/gfgtdf/wesnoth/build/Wesnoth-VS2017-filter_refactor-10
20170826 22:14:27-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170826 22:19:36< celticminstrel> I haven't noticed anything like that.
20170826 22:19:57< vultraz_iOS> :|
20170826 22:20:02< vultraz_iOS> gdi
20170826 22:20:38< vultraz_iOS> i wonder what you're doing differently then
20170826 22:20:51< vultraz_iOS> do you use aquelia's build dependencies
20170826 22:22:06< celticminstrel> BTW, someone should try loading this in 1.13 https://github.com/Aethaeryn/wesnoth-umc/blob/master/Aethaeryns_Mod/maps/big-woods.map
20170826 22:22:17< celticminstrel> I think I'm using aquileia's dependencies, yes.
20170826 22:24:47< vultraz_iOS> well fuck
20170826 22:25:23< vultraz_iOS> celticminstrel: do merge https://github.com/wesnoth/wesnoth/pull/1920 if it looks alright
20170826 22:25:38< celticminstrel> I refuse.
20170826 22:26:24< vultraz_iOS> is it at least correct
20170826 22:27:01< celticminstrel> I guess? I'm not entirely sure if stod is reliable in this case though.
20170826 22:27:52< celticminstrel> Given that ver might be a string such as "10.7.5"?
20170826 22:27:58< celticminstrel> Or at least I'd assume it could be.
20170826 22:28:17< celticminstrel> I don't know if stod would throw an exception in that case or just grab as much as it can as a number.
20170826 22:28:21< vultraz_iOS> there should be a function to check version...
20170826 22:28:31< celticminstrel> Yeah, there should be.
20170826 22:28:40< vultraz_iOS> but i don't know mac and i guess you won't go near this
20170826 22:30:29< celticminstrel> This looks like what you'd need, I think. https://stackoverflow.com/a/26551063/1502810
20170826 22:37:00-!- DeFender [~DeFender1@93.172.30.106] has joined #wesnoth-dev
20170826 22:37:01-!- DeFender [~DeFender1@93.172.30.106] has quit [Read error: Connection reset by peer]
20170826 22:37:20-!- DeFender [~DeFender1@93.172.30.106] has joined #wesnoth-dev
20170826 22:39:23-!- travis-ci [~travis-ci@ec2-54-158-112-142.compute-1.amazonaws.com] has joined #wesnoth-dev
20170826 22:39:24< travis-ci> gfgtdf/wesnoth#939 (filter_refactor - f5c4ae4 : gfgtdf): The build was broken.
20170826 22:39:24< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/268767555
20170826 22:39:24-!- travis-ci [~travis-ci@ec2-54-158-112-142.compute-1.amazonaws.com] has left #wesnoth-dev []
20170826 22:40:24-!- DeFender1031 [~DeFender1@93-172-23-172.bb.netvision.net.il] has quit [Ping timeout: 268 seconds]
20170826 22:41:34< vultraz_iOS> only downside of msvc is it takes significantly longer to link than with gcc
20170826 22:42:23< vultraz_iOS> i don't know why
20170826 22:43:49-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170826 22:52:03< celticminstrel> What was the maximum number of players on a random map? Was it 6, 8, or 9?
20170826 22:53:37< gfgtdf> celticminstrel: you mean with defautl random map gernerator ?
20170826 22:53:38< vultraz_iOS>  9 iirc
20170826 22:54:13-!- travis-ci [~travis-ci@ec2-54-156-71-37.compute-1.amazonaws.com] has joined #wesnoth-dev
20170826 22:54:14< travis-ci> gfgtdf/wesnoth#941 (filter_refactor - 28e43da : gfgtdf): The build has errored.
20170826 22:54:14< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/268775280
20170826 22:54:14-!- travis-ci [~travis-ci@ec2-54-156-71-37.compute-1.amazonaws.com] has left #wesnoth-dev []
20170826 23:01:26-!- travis-ci [~travis-ci@ec2-54-156-81-218.compute-1.amazonaws.com] has joined #wesnoth-dev
20170826 23:01:27< travis-ci> gfgtdf/wesnoth#940 (filter_refactor - 65f7b50 : gfgtdf): The build has errored.
20170826 23:01:27< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/268774714
20170826 23:01:27-!- travis-ci [~travis-ci@ec2-54-156-81-218.compute-1.amazonaws.com] has left #wesnoth-dev []
20170826 23:03:35-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170826 23:03:35< Appveyor> wesnoth - Release gfgtdf 65f7b50: uiuiuzuzkj Failed
20170826 23:03:35< Appveyor> Details: https://ci.appveyor.com/project/gfgtdf/wesnoth/build/Wesnoth-VS2017-filter_refactor-11
20170826 23:03:39-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170826 23:05:29-!- gfgtdf [~chatzilla@x4e36958f.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20170826 23:22:19-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170826 23:28:21-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170826 23:31:05-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170826 23:31:21-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170826 23:31:21< Appveyor> wesnoth - Debug gfgtdf 65f7b50: uiuiuzuzkj Failed
20170826 23:31:21< Appveyor> Details: https://ci.appveyor.com/project/gfgtdf/wesnoth/build/Wesnoth-VS2017-filter_refactor-11
20170826 23:31:25-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170826 23:33:40-!- irker304 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170826 23:33:40< irker304> wesnoth: Celtic Minstrel wesnoth:lua_mapgen_stuff 79c963763e6a / data/lua/cave_map_generator.lua: Lua Cave Mapgen: Support comma-separated chamber locations https://github.com/wesnoth/wesnoth/commit/79c963763e6ad199232f567f1bf1e7441ee4711a
20170826 23:33:40< irker304> wesnoth: Celtic Minstrel wesnoth:lua_mapgen_stuff 22f210b9281c / data/ (4 files in 3 dirs): Lua mapgen: Use helper.rand for chamber locations https://github.com/wesnoth/wesnoth/commit/22f210b9281c67702d504c755737b64b78da5a11
20170826 23:33:41< irker304> wesnoth: Celtic Minstrel wesnoth:lua_mapgen_stuff 7d76cc2013e4 / data/lua/cave_map_generator.lua: Lua Cave Mapgen: Allow alternate clear and village terrains https://github.com/wesnoth/wesnoth/commit/7d76cc2013e41e80c3acb18829a2c92fdfbe0dfb
20170826 23:33:42< irker304> wesnoth: Celtic Minstrel wesnoth:lua_mapgen_stuff e5df75d4a906 / data/lua/cave_map_generator.lua: Lua Cave Mapgen: Allow a chamber's existence to depend on number of players https://github.com/wesnoth/wesnoth/commit/e5df75d4a906761799d5bc600de618831f48c732
20170826 23:33:43< irker304> wesnoth: Celtic Minstrel wesnoth:lua_mapgen_stuff 0aa7122f74e8 / data/multiplayer/scenarios/Random_Scenario_Cave.cfg: Add a multiplayer cave random map https://github.com/wesnoth/wesnoth/commit/0aa7122f74e83d8119052121e48e8d1853da26d9
20170826 23:33:44< irker304> wesnoth: Celtic Minstrel wesnoth:lua_mapgen_stuff 15767ecf839e / data/lua/mapgen_helper.lua: Lua cave mapgen: Maintain compatibility support for - in chamber locations https://github.com/wesnoth/wesnoth/commit/15767ecf839e398ce677c4f3b1377fd3cdfbe828
20170826 23:33:46< irker304> wesnoth: Celtic Minstrel wesnoth:lua_mapgen_stuff 2c61879be503 / data/ (3 files in 2 dirs): Support [road_cost] in [passage] https://github.com/wesnoth/wesnoth/commit/2c61879be5037112037daa996b9148501046f088
20170826 23:33:48< irker304> wesnoth: Celtic Minstrel wesnoth:lua_mapgen_stuff 0891c2498e21 / data/multiplayer/scenarios/Random_Scenario_Cave.cfg: Add a little more variety to the cave map (trees, swamp) https://github.com/wesnoth/wesnoth/commit/0891c2498e212b5c5a0a32f359c360f8f5383482
20170826 23:33:50< irker304> wesnoth: Celtic Minstrel wesnoth:lua_mapgen_stuff cd91afec7aee / data/ (lua/cave_map_generator.lua multiplayer/scenarios/Random_Scenario_Cave.cfg): Fix road patchiness, missing keeps, and boring tunnels https://github.com/wesnoth/wesnoth/commit/cd91afec7aee9fe08e308dfeaee15de5d384572d
20170826 23:33:52< irker304> wesnoth: Celtic Minstrel wesnoth:lua_mapgen_stuff 8867c391d5ad / data/ (lua/cave_map_generator.lua multiplayer/scenarios/Random_Scenario_Cave.cfg): Allow specifying chamber locations relative to any map edge or corner, or relati https://github.com/wesnoth/wesnoth/commit/8867c391d5ad63047b611718e1f98a04095a87c3
20170826 23:34:31-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has joined #wesnoth-dev
20170826 23:37:39< celticminstrel> FTR gfgtdf, I'm not convinced that your method of setting global variables will be sufficient for the user configuration.
20170826 23:38:15< celticminstrel> It means that the generator specifically needs to be written to consider the fact that configuration comes from two different sources.3
20170826 23:38:50< celticminstrel> On the other hand, if the user config function instead takes in the [generator] config and modifiers it, you'd be able to make a user config for any generator, any scenario.
20170826 23:39:42< celticminstrel> In particular, I don't think a general user config is actually possible for the cave map generator. The configuration options available would probably depend a lot on the chambers and passages defined by the WML.
20170826 23:40:05< celticminstrel> For example, in this cave map, I might want to add a "lake size" parameter which would adjust values in the [chamber] that defines the lake.
20170826 23:40:19-!- travis-ci [~travis-ci@ec2-54-156-71-37.compute-1.amazonaws.com] has joined #wesnoth-dev
20170826 23:40:20< travis-ci> gfgtdf/wesnoth#942 (filter_refactor - a1931e8 : gfgtdf): The build was broken.
20170826 23:40:20< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/268775488
20170826 23:40:20-!- travis-ci [~travis-ci@ec2-54-156-71-37.compute-1.amazonaws.com] has left #wesnoth-dev []
20170826 23:47:18< irker304> wesnoth: Celtic Minstrel wesnoth:lua_mapgen_stuff c4d16c57f998 / / (3 files in 2 dirs): Allow mapgen user_config functions to mutate the [generator] config https://github.com/wesnoth/wesnoth/commit/c4d16c57f998205674749aa134dd5507f0a148eb
20170826 23:53:42-!- amello [~amello@179.159.56.56] has quit [Quit: Leaving]
20170826 23:58:39-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has quit [Remote host closed the connection]
--- Log closed Sun Aug 27 00:00:29 2017