--- Log opened Sun Aug 27 00:00:29 2017
20170827 00:02:47-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170827 00:02:47< Appveyor> wesnoth - Release gfgtdf 28e43da: uiuiuzuzkj Failed
20170827 00:02:47< Appveyor> Details: https://ci.appveyor.com/project/gfgtdf/wesnoth/build/Wesnoth-VS2017-filter_refactor-12
20170827 00:02:51-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170827 00:06:49-!- travis-ci [~travis-ci@ec2-54-156-81-218.compute-1.amazonaws.com] has joined #wesnoth-dev
20170827 00:06:50< travis-ci> gfgtdf/wesnoth#943 (filter_refactor - f8743fe : gfgtdf): The build failed.
20170827 00:06:50< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/268779914
20170827 00:06:50-!- travis-ci [~travis-ci@ec2-54-156-81-218.compute-1.amazonaws.com] has left #wesnoth-dev []
20170827 00:18:03-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has joined #wesnoth-dev
20170827 00:28:50-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has quit [Remote host closed the connection]
20170827 00:31:53-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170827 00:31:53< Appveyor> wesnoth - Debug gfgtdf 28e43da: uiuiuzuzkj Failed
20170827 00:31:53< Appveyor> Details: https://ci.appveyor.com/project/gfgtdf/wesnoth/build/Wesnoth-VS2017-filter_refactor-12
20170827 00:31:58-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170827 00:52:49-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170827 01:03:07-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170827 01:03:07< Appveyor> wesnoth - Release gfgtdf a1931e8: remvoe set_flat_tod from unit_filter ctor parmaters Failed
20170827 01:03:07< Appveyor> Details: https://ci.appveyor.com/project/gfgtdf/wesnoth/build/Wesnoth-VS2017-filter_refactor-13
20170827 01:03:11-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170827 01:06:48-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170827 01:06:52-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 260 seconds]
20170827 01:09:04-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170827 01:29:01-!- Bonobo [~Bonobo@203.220.138.162] has joined #wesnoth-dev
20170827 01:30:04-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170827 01:30:04< Appveyor> wesnoth - Debug gfgtdf a1931e8: remvoe set_flat_tod from unit_filter ctor parmaters Failed
20170827 01:30:04< Appveyor> Details: https://ci.appveyor.com/project/gfgtdf/wesnoth/build/Wesnoth-VS2017-filter_refactor-13
20170827 01:30:08-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170827 01:32:31-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev
20170827 02:01:05-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170827 02:01:05< Appveyor> wesnoth - Release gfgtdf f8743fe: llkjlkjljkljljl Failed
20170827 02:01:05< Appveyor> Details: https://ci.appveyor.com/project/gfgtdf/wesnoth/build/Wesnoth-VS2017-filter_refactor-14
20170827 02:01:08-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170827 02:05:26< celticminstrel> For some reason the title [label] isn't showing up.
20170827 02:05:36< celticminstrel> Well, I guess I can compare to the other mapgen dialog.
20170827 02:21:17-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has joined #wesnoth-dev
20170827 02:28:29-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170827 02:28:29< Appveyor> wesnoth - Debug gfgtdf f8743fe: llkjlkjljkljljl Failed
20170827 02:28:29< Appveyor> Details: https://ci.appveyor.com/project/gfgtdf/wesnoth/build/Wesnoth-VS2017-filter_refactor-14
20170827 02:28:33-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170827 02:37:02-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has quit [Remote host closed the connection]
20170827 02:48:01-!- irker304 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170827 02:48:05-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20170827 02:48:21-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has joined #wesnoth-dev
20170827 02:51:13-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has quit [Remote host closed the connection]
20170827 02:59:41-!- travis-ci [~travis-ci@ec2-54-156-81-218.compute-1.amazonaws.com] has joined #wesnoth-dev
20170827 02:59:42< travis-ci> wesnoth/wesnoth#14794 (lua_mapgen_stuff - c4d16c5 : Celtic Minstrel): The build was fixed.
20170827 02:59:42< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/268785369
20170827 02:59:42-!- travis-ci [~travis-ci@ec2-54-156-81-218.compute-1.amazonaws.com] has left #wesnoth-dev []
20170827 03:20:56-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170827 03:34:41< JyrkiVesterinen> 20170826 22:41:34< vultraz_iOS> only downside of msvc is it takes significantly longer to link than with gcc
20170827 03:34:41< JyrkiVesterinen> 20170826 22:42:23< vultraz_iOS> i don't know why
20170827 03:34:53< JyrkiVesterinen> Likely because you have Link Time Code Generation enabled.
20170827 03:35:11< vultraz_iOS> What Now?
20170827 03:35:38< JyrkiVesterinen> Project -> wesnoth Properties... -> Linker -> Optimization.
20170827 03:36:06< JyrkiVesterinen> LTCG enables significant compiler optimizations, but at a cost of longer build times.
20170827 03:43:36< vultraz_iOS> JyrkiVesterinen: should is et this to Default?
20170827 03:43:52< vultraz_iOS> or Fast LCTG?
20170827 03:44:12< JyrkiVesterinen> Default, it fully disables LTCG.
20170827 03:45:59< JyrkiVesterinen> Fast LTCG is a compromise that implements the optimizations with a much lower link time penalty. But as long as you're only making local builds, you don't need LTCG.
20170827 03:46:32< JyrkiVesterinen> (But if we were to distribute MSVC builds in SourceForge or Steam, we'd definitely want to keep it enabled.)
20170827 03:47:28< JyrkiVesterinen> https://blogs.msdn.microsoft.com/vcblog/2014/11/12/speeding-up-the-incremental-developer-build-scenario/
20170827 03:59:52< celticminstrel> So um.
20170827 04:00:04< celticminstrel> This setting is stored in the project file, right?
20170827 04:00:16< JyrkiVesterinen> Unfortunately yes.
20170827 04:00:26< JyrkiVesterinen> So please don't commit it, vultraz.
20170827 04:00:49< celticminstrel> I wonder if it would work to put it in the user file.
20170827 04:01:44< JyrkiVesterinen> Personally I don't need to care because I use debug builds which have LTCG disabled anyway.
20170827 04:02:05< celticminstrel> Oh, it's only enabled for release builds in the project file?
20170827 04:02:11< celticminstrel> In that case, I guess I don't need to care either.
20170827 04:02:31< JyrkiVesterinen> Of course. Optimizing debug builds is a bad idea most of the time.
20170827 04:19:26< celticminstrel> I wonder what the reasoning is for the separation of wesnoth and wesnoth-lib textdomains.
20170827 04:29:04-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170827 04:29:10-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170827 04:42:49-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170827 04:53:26-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170827 05:08:46< celticminstrel> vultraz_iOS: What do I do to detect slider value changed? connect_signal_notify_modified?
20170827 05:09:02< vultraz_iOS> yes
20170827 05:20:12-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170827 05:20:18-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170827 05:30:28< celticminstrel> So I've got the dialog working, but the settings seem to be getting ignored. I guess it won't be done tonight after all.
20170827 05:31:12< celticminstrel> Also, for some reason the settings seem to get reset when I click create game?
20170827 05:31:24< celticminstrel> Does that spawn a new mapgen kernel or something?
20170827 05:34:53< vultraz_iOS> ?
20170827 05:35:59-!- irker165 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170827 05:35:59< irker165> wesnoth: Celtic Minstrel wesnoth:lua_mapgen_stuff 4cec0fe0182d / src/gui/dialogs/editor/generator_settings.cpp: Use variables for village density label https://github.com/wesnoth/wesnoth/commit/4cec0fe0182dc419a0ee55c587987d5b481f4610
20170827 05:35:59< irker165> wesnoth: Celtic Minstrel wesnoth:lua_mapgen_stuff aed8c7e884c3 / src/scripting/lua_gui2.cpp: Lua GUI2: Support sliders in set_dialog_callback https://github.com/wesnoth/wesnoth/commit/aed8c7e884c3b6a98fc4a9d66ca10a97627d22c9
20170827 05:36:00< irker165> wesnoth: Celtic Minstrel wesnoth:lua_mapgen_stuff 21568c893ad5 / data/ (lua/cave_map_generator.lua multiplayer/scenarios/Random_Scenario_Cave.cfg): Implement a settings dialog for the sample cave map generator https://github.com/wesnoth/wesnoth/commit/21568c893ad5ad64b18f88ed697db4e11f456492
20170827 05:36:02< celticminstrel> Basically, that settings dialog does not work. ^
20170827 05:36:12< celticminstrel> It does remember the settings if you close and reopen it.
20170827 05:36:16< vultraz_iOS> the generator settings?
20170827 05:36:23< vultraz_iOS> yeah it has some funky handling
20170827 05:36:24< celticminstrel> But the settings don't appear to be applied to the map.
20170827 05:36:33< celticminstrel> And once I start a game, the settings are lost.
20170827 05:36:48< celticminstrel> (I added some debug statements in cave_map_generator.lua to test this.)
20170827 05:37:10< celticminstrel> The weird thing is that the settings are passed to the generator when it's regenerated after changing the settings.
20170827 05:37:20< celticminstrel> But somehow it seems as if they don't actually take effect.
20170827 05:38:57-!- Kwandulin [~Kwandulin@p200300E453CC3B65047A3873674F8289.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170827 05:42:00-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170827 05:55:52-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20170827 06:54:04-!- mjs-de [~mjs-de@x55b633f4.dyn.telefonica.de] has joined #wesnoth-dev
20170827 06:58:20-!- molgrum [~molgrum@unaffiliated/molgrum] has quit [Ping timeout: 246 seconds]
20170827 07:54:17-!- markus_ [~mjs-de@x55b6444d.dyn.telefonica.de] has joined #wesnoth-dev
20170827 07:57:53-!- mjs-de [~mjs-de@x55b633f4.dyn.telefonica.de] has quit [Ping timeout: 248 seconds]
20170827 08:04:38-!- molgrum [~molgrum@unaffiliated/molgrum] has joined #wesnoth-dev
20170827 08:19:50-!- moongazer [~moongazer@117.198.83.62] has joined #wesnoth-dev
20170827 08:36:29-!- irker165 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170827 09:02:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170827 09:02:40-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170827 09:12:02-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has joined #wesnoth-dev
20170827 09:27:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170827 09:27:41-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170827 09:31:16-!- moongazer [~moongazer@117.198.83.62] has quit [Ping timeout: 240 seconds]
20170827 09:36:23-!- moongazer [~moongazer@117.198.89.160] has joined #wesnoth-dev
20170827 09:39:59-!- universecoder [~moongazer@117.198.89.26] has joined #wesnoth-dev
20170827 09:42:46-!- moongazer [~moongazer@117.198.89.160] has quit [Ping timeout: 240 seconds]
20170827 10:14:46-!- universecoder [~moongazer@117.198.89.26] has quit [Ping timeout: 264 seconds]
20170827 10:27:13-!- universecoder [~moongazer@1.187.8.162] has joined #wesnoth-dev
20170827 10:31:08-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
20170827 10:31:27-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170827 10:31:34-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Client Quit]
20170827 10:36:49-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 248 seconds]
20170827 10:38:37-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20170827 10:40:04-!- Kwandulin [~Kwandulin@p200300E453CC3B65047A3873674F8289.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170827 10:42:46-!- molgrum [~molgrum@unaffiliated/molgrum] has quit [Quit: ZNC - http://znc.in]
20170827 10:42:59-!- molgrum [~molgrum@unaffiliated/molgrum] has joined #wesnoth-dev
20170827 10:56:21-!- universecoder [~moongazer@1.187.8.162] has quit [Ping timeout: 240 seconds]
20170827 11:20:37-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has quit [Remote host closed the connection]
20170827 11:23:58-!- Duthlet [~Duthlet@ipservice-092-211-168-098.092.211.pools.vodafone-ip.de] has joined #wesnoth-dev
20170827 11:27:59-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 248 seconds]
20170827 11:29:40-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20170827 11:32:34-!- Kwandulin [~Kwandulin@p200300E453CC3B655C8A79BD01C5B106.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170827 11:40:58-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170827 12:16:03-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170827 12:16:03< Appveyor> wesnoth - Release gfgtdf 0e019d9: .ziopzo,zpopzoi Failed
20170827 12:16:03< Appveyor> Details: https://ci.appveyor.com/project/gfgtdf/wesnoth/build/Wesnoth-VS2017-filter_refactor-15
20170827 12:16:07-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170827 12:27:45-!- travis-ci [~travis-ci@ec2-54-156-71-37.compute-1.amazonaws.com] has joined #wesnoth-dev
20170827 12:27:46< travis-ci> gfgtdf/wesnoth#944 (filter_refactor - 0e019d9 : gfgtdf): The build is still failing.
20170827 12:27:46< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/268881835
20170827 12:27:46-!- travis-ci [~travis-ci@ec2-54-156-71-37.compute-1.amazonaws.com] has left #wesnoth-dev []
20170827 12:43:34-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170827 12:43:34< Appveyor> wesnoth - Debug gfgtdf 0e019d9: .ziopzo,zpopzoi Failed
20170827 12:43:34< Appveyor> Details: https://ci.appveyor.com/project/gfgtdf/wesnoth/build/Wesnoth-VS2017-filter_refactor-15
20170827 12:43:39-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170827 13:01:34-!- Kwandulin [~Kwandulin@p200300E453CC3B655C8A79BD01C5B106.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170827 13:07:45-!- amello [~amello@179.159.56.56] has joined #wesnoth-dev
20170827 13:15:37-!- travis-ci [~travis-ci@ec2-54-158-112-142.compute-1.amazonaws.com] has joined #wesnoth-dev
20170827 13:15:38< travis-ci> gfgtdf/wesnoth#945 (filter_refactor - 46db6b6 : gfgtdf): The build was fixed.
20170827 13:15:38< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/268886910
20170827 13:15:38-!- travis-ci [~travis-ci@ec2-54-158-112-142.compute-1.amazonaws.com] has left #wesnoth-dev []
20170827 13:21:19-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170827 13:55:20< celticminstrel> o.o
20170827 13:55:53< celticminstrel> I just fixed a minor semantic error that was only hit occasionally and all of a sudden it all works perfectly?
20170827 14:06:29-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170827 14:06:29< Appveyor> wesnoth - Release gfgtdf bfb8f96: rename variablename u to args in unit filters Failed
20170827 14:06:29< Appveyor> Details: https://ci.appveyor.com/project/gfgtdf/wesnoth/build/Wesnoth-VS2017-filter_refactor-17
20170827 14:06:33-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170827 14:10:29-!- irker010 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170827 14:10:29< irker010> wesnoth: Celtic Minstrel wesnoth:lua_mapgen_stuff 9cffcff7e812 / src/scripting/mapgen_lua_kernel.cpp: Make it optional for the map generator user_config to return the new settings https://github.com/wesnoth/wesnoth/commit/9cffcff7e812d469182d37fff11a9dead2ff4be3
20170827 14:10:29< irker010> wesnoth: Celtic Minstrel wesnoth:lua_mapgen_stuff b0bf38a730d3 / data/lua/cave_map_generator.lua: Fix issue with map generation occasionally failing https://github.com/wesnoth/wesnoth/commit/b0bf38a730d369bb0a365eb210a97bf97470e794
20170827 14:10:54-!- moongazer [~moongazer@59.95.139.81] has joined #wesnoth-dev
20170827 14:13:01-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170827 14:15:31-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170827 14:15:31< Appveyor> wesnoth - Debug gfgtdf bfb8f96: rename variablename u to args in unit filters Failed
20170827 14:15:31< Appveyor> Details: https://ci.appveyor.com/project/gfgtdf/wesnoth/build/Wesnoth-VS2017-filter_refactor-17
20170827 14:15:35-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170827 14:26:05-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170827 14:26:05< Appveyor> wesnoth - Release gfgtdf 1a5627d: rename variablename u to args in unit filters Failed
20170827 14:26:05< Appveyor> Details: https://ci.appveyor.com/project/gfgtdf/wesnoth/build/Wesnoth-VS2017-filter_refactor-18
20170827 14:26:09-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170827 14:29:55-!- Kwandulin [~Kwandulin@p200300E453CC3B655C8A79BD01C5B106.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170827 14:34:06-!- Oebele [~quassel@145.15.244.15] has joined #wesnoth-dev
20170827 14:34:54-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170827 14:34:54< Appveyor> wesnoth - Debug gfgtdf 1a5627d: rename variablename u to args in unit filters Failed
20170827 14:34:54< Appveyor> Details: https://ci.appveyor.com/project/gfgtdf/wesnoth/build/Wesnoth-VS2017-filter_refactor-18
20170827 14:34:58-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170827 14:45:08-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170827 14:45:08< Appveyor> wesnoth - Release gfgtdf c93369b: rename variablename u to args in unit filters Failed
20170827 14:45:09< Appveyor> Details: https://ci.appveyor.com/project/gfgtdf/wesnoth/build/Wesnoth-VS2017-filter_refactor-19
20170827 14:45:13-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170827 14:54:28-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170827 14:54:28< Appveyor> wesnoth - Debug gfgtdf c93369b: rename variablename u to args in unit filters Failed
20170827 14:54:28< Appveyor> Details: https://ci.appveyor.com/project/gfgtdf/wesnoth/build/Wesnoth-VS2017-filter_refactor-19
20170827 14:54:32-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170827 14:57:00-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has joined #wesnoth-dev
20170827 15:00:38-!- travis-ci [~travis-ci@ec2-54-156-81-218.compute-1.amazonaws.com] has joined #wesnoth-dev
20170827 15:00:39< travis-ci> gfgtdf/wesnoth#948 (filter_refactor - c93369b : gfgtdf): The build was broken.
20170827 15:00:39< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/268906113
20170827 15:00:39-!- travis-ci [~travis-ci@ec2-54-156-81-218.compute-1.amazonaws.com] has left #wesnoth-dev []
20170827 15:01:23-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has quit [Remote host closed the connection]
20170827 15:04:43-!- Oebele [~quassel@145.15.244.15] has quit [Remote host closed the connection]
20170827 15:13:10-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170827 15:46:11-!- Kwandulin [~Kwandulin@p200300E453CC3B655C8A79BD01C5B106.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170827 15:50:02-!- Kwandulin [~Kwandulin@p200300E453CC3B655C8A79BD01C5B106.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170827 16:10:31-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170827 16:22:55-!- Bonobo [~Bonobo@203.220.138.162] has quit [Ping timeout: 248 seconds]
20170827 16:32:52-!- Kwandulin [~Kwandulin@p200300E453CC3B655C8A79BD01C5B106.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170827 16:34:35-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170827 16:45:41-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170827 16:45:41< Appveyor> wesnoth - Release gfgtdf 65c7982: j7er67rj6589k8789k Failed
20170827 16:45:41< Appveyor> Details: https://ci.appveyor.com/project/gfgtdf/wesnoth/build/Wesnoth-VS2017-filter_refactor-20
20170827 16:45:45-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170827 16:54:30-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170827 16:54:30< Appveyor> wesnoth - Debug gfgtdf 65c7982: j7er67rj6589k8789k Failed
20170827 16:54:30< Appveyor> Details: https://ci.appveyor.com/project/gfgtdf/wesnoth/build/Wesnoth-VS2017-filter_refactor-20
20170827 16:54:34-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170827 17:01:09-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170827 17:10:17-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20170827 17:14:36-!- irker010 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170827 17:18:05-!- amello [~amello@179.159.56.56] has quit [Remote host closed the connection]
20170827 17:18:43-!- travis-ci [~travis-ci@ec2-54-87-5-59.compute-1.amazonaws.com] has joined #wesnoth-dev
20170827 17:18:44< travis-ci> gfgtdf/wesnoth#949 (filter_refactor - 65c7982 : gfgtdf): The build is still failing.
20170827 17:18:44< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/268938196
20170827 17:18:44-!- travis-ci [~travis-ci@ec2-54-87-5-59.compute-1.amazonaws.com] has left #wesnoth-dev []
20170827 17:32:38-!- Kwandulin [~Kwandulin@p200300E453CC3B65C5310E33A8DCFA13.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170827 18:01:41-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has joined #wesnoth-dev
20170827 18:06:10-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has quit [Ping timeout: 246 seconds]
20170827 18:22:18-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has joined #wesnoth-dev
20170827 18:38:16-!- moongazer [~moongazer@59.95.139.81] has quit [Quit: Leaving]
20170827 18:48:50-!- Kwandulin [~Kwandulin@p200300E453CC3B65C5310E33A8DCFA13.dip0.t-ipconnect.de] has quit [Ping timeout: 246 seconds]
20170827 18:57:33-!- travis-ci [~travis-ci@ec2-174-129-96-232.compute-1.amazonaws.com] has joined #wesnoth-dev
20170827 18:57:34< travis-ci> gfgtdf/wesnoth#950 (filter_refactor - ff883cd : gfgtdf): The build was fixed.
20170827 18:57:34< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/268955011
20170827 18:57:34-!- travis-ci [~travis-ci@ec2-174-129-96-232.compute-1.amazonaws.com] has left #wesnoth-dev []
20170827 19:05:54-!- irker321 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170827 19:05:54< irker321> wesnoth: Ignacio R. Morelle wesmere:develop 1ec14e5a09ca / wesmere/sass/wmlunits/_single_unit.scss: sass/wmlunits: Unfloat flex container for the unit page columns https://github.com/wesnoth/wesmere/commit/1ec14e5a09cacf1f22d670528e60aaeaef5155f4
20170827 19:26:14-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has quit [Remote host closed the connection]
20170827 19:49:42-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has joined #wesnoth-dev
20170827 20:00:04-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has quit [Remote host closed the connection]
20170827 20:05:48< irker321> wesnoth: gfgtdf wesnoth:master a6decea0fcfd / src/units/ (filter.cpp filter.hpp): refactor unit filters https://github.com/wesnoth/wesnoth/commit/a6decea0fcfd3b0af3520d2637cf085da7277eb5
20170827 20:05:50< irker321> wesnoth: gfgtdf wesnoth:master c6e5c57a85d7 / src/ (side_filter.cpp terrain/filter.cpp units/abilities.cpp units/filter.hpp): remove set_flat_tod from unit_filter ctor parmaters https://github.com/wesnoth/wesnoth/commit/c6e5c57a85d727a3063b08e67c4a9a735680b523
20170827 20:05:52< irker321> wesnoth: gfgtdf wesnoth:master dac782925af4 / src/ (ai/lua/lua_object.cpp scripting/lua_common.cpp variable.cpp variable.hpp): vconfig optimisation https://github.com/wesnoth/wesnoth/commit/dac782925af42226b71cc1d8c37f542fb6b492c0
20170827 20:05:54< irker321> wesnoth: gfgtdf wesnoth:master 31bb0ecde3cb / src/ (side_filter.cpp terrain/filter.cpp units/filter.hpp): don't always copy the underlying config on side filters https://github.com/wesnoth/wesnoth/commit/31bb0ecde3cb744059ba06f4922754ec99cdf419
20170827 20:05:56< irker321> wesnoth: gfgtdf wesnoth:master d2de54d84c8a / src/units/filter.cpp: rename variablename u to args in unit filters https://github.com/wesnoth/wesnoth/commit/d2de54d84c8aa312ebc5eafc2a0fccb531e088b3
20170827 20:05:58< irker321> wesnoth: gfgtdf wesnoth:master 4dcbf6e69bc2 / src/ (9 files in 5 dirs): Merge pull request #1906 from gfgtdf/filter_refactor https://github.com/wesnoth/wesnoth/commit/4dcbf6e69bc2db75e84c9bb00c20581452d1de85
20170827 20:17:21-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170827 20:33:03-!- travis-ci [~travis-ci@ec2-54-157-84-93.compute-1.amazonaws.com] has joined #wesnoth-dev
20170827 20:33:04< travis-ci> gfgtdf/wesnoth#951 (filter_refactor - 472d267 : gfgtdf): The build has errored.
20170827 20:33:04< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/268978817
20170827 20:33:04-!- travis-ci [~travis-ci@ec2-54-157-84-93.compute-1.amazonaws.com] has left #wesnoth-dev []
20170827 20:44:19-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170827 20:46:44-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170827 20:49:11-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170827 20:53:00-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170827 20:55:00< irker321> wesnoth: ln-zookeeper wesnoth:master 4da691b14669 / data/core/terrain-graphics/new-macros.cfg: Added optional frame duration arguments to water macros https://github.com/wesnoth/wesnoth/commit/4da691b146695ebc553148d5773db02e0ab56996
20170827 20:57:42-!- markus_ [~mjs-de@x55b6444d.dyn.telefonica.de] has quit [Remote host closed the connection]
20170827 20:58:17< zookeeper> src\units/filter.hpp(104): error C2610: 'unit_filter::unit_filter(unit_filter &&)' : is not a special member function which can be defaulted
20170827 20:58:18< zookeeper> src\units/filter.hpp(107): error C2610: 'unit_filter &unit_filter::operator =(unit_filter &&)' : is not a special member function which can be defaulted
20170827 20:59:11< vultraz_iOS> hm
20170827 20:59:16< vultraz_iOS> i don't get that
20170827 21:00:11< vultraz_iOS> ah, let me guess
20170827 21:00:15< vultraz_iOS> you're using msvc 2013?
20170827 21:00:25< zookeeper> yes
20170827 21:00:31< vultraz_iOS> of course, of course
20170827 21:00:54< vultraz_iOS> it doesn't support `=default` for some reason
20170827 21:02:39< vultraz_iOS> zookeeper: add a conditional for 2013 with the expansion of the move ctor and assignment operators like I did here: https://github.com/wesnoth/wesnoth/blob/master/src/gui/widgets/grid.hpp#L344-L353
20170827 21:02:58< vultraz_iOS> (obviously you don't need NOEXCEPT)
20170827 21:08:33< zookeeper> wtf is a "move ctor"?
20170827 21:08:47< vultraz_iOS> unit_filter(unit_filter &&)
20170827 21:08:51< vultraz_iOS> this is a move constructor
20170827 21:08:58< vultraz_iOS> unit_filter(const unit_filter&) 
20170827 21:09:00< zookeeper> oh, constructor
20170827 21:09:03< vultraz_iOS> this is a copy constructor
20170827 21:09:48< zookeeper> well, i have no idea what i'd need to actually put in it.
20170827 21:13:17< zookeeper> or maybe i do
20170827 21:14:48< vultraz_iOS> since it's a move ctor, you want to initialize the members with std::move(other.member) for non-trivial types like integers or strings
20170827 21:14:55< vultraz_iOS> or pointers
20170827 21:15:28< vultraz_iOS> not sure if you're supposed to then assig the other ptr to nullptr
20170827 21:16:58< zookeeper> too much trial and error
20170827 21:19:17< celticminstrel> MSVC does support =default.
20170827 21:19:23< celticminstrel> Even in 2013.
20170827 21:19:50< celticminstrel> However, MSVC 2013 doesn't fully understand move constructors and does not allow you to default them.
20170827 21:20:32< celticminstrel> Is this on master? Since I've basically finished my mapgen work, I could probably fix this.
20170827 21:21:05< celticminstrel> In fact I think my mapgen work could be merged in. I wanted to ask sigurd if he could maybe tweak a few parameters here and there, but as far as I can tell it's fully-functional.
20170827 21:22:04-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170827 21:26:27< zookeeper> yes
20170827 21:26:52< celticminstrel> Okay, give me several minutes to pull and compile and everything.
20170827 21:26:55-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20170827 21:27:01< zookeeper> awesome
20170827 21:35:10-!- Duthlet [~Duthlet@ipservice-092-211-168-098.092.211.pools.vodafone-ip.de] has quit [Quit: leaving]
20170827 21:44:22-!- gfgtdf [~chatzilla@x4e368ac9.dyn.telefonica.de] has joined #wesnoth-dev
20170827 21:46:56-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has joined #wesnoth-dev
20170827 22:04:35-!- boucman [~rosen@221.86.207.77.rev.sfr.net] has joined #wesnoth-dev
20170827 22:04:40-!- boucman [~rosen@221.86.207.77.rev.sfr.net] has quit [Changing host]
20170827 22:04:40-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170827 22:11:41-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 240 seconds]
20170827 22:16:51-!- amello [~amello@179.159.56.56] has joined #wesnoth-dev
20170827 22:23:24-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170827 22:25:55-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170827 22:33:48-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1df0:7030:91b8:9f4e] has quit [Remote host closed the connection]
20170827 22:39:05-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20170827 23:02:07-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170827 23:40:33< irker321> wesnoth: doofus-01 wesnoth:master 299414e385af / data/core/ (23 files in 2 dirs): ruined version of encampment terrain https://github.com/wesnoth/wesnoth/commit/299414e385af627ce0c25276834cb59ec404aace
20170827 23:48:25< irker321> wesnoth: Ignacio R. Morelle wesnoth:master 32169bfd2fd7 / data/tools/unit_tree/html_output.py: wmlunits: Skip race names consisting of nothing but whitespace https://github.com/wesnoth/wesnoth/commit/32169bfd2fd71aa0f1f3064f9d5b0a668c9775cd
20170827 23:48:28< irker321> wesnoth: Ignacio R. Morelle wesnoth:master 769565b59c8e / data/tools/unit_tree/html_output.py: wmlunits: Don't format the abilities placeholder dash as bold https://github.com/wesnoth/wesnoth/commit/769565b59c8ea17eb1584853de76444aed99d8f4
20170827 23:48:31< irker321> wesnoth: Ignacio R. Morelle wesnoth:master f1eb040c7649 / data/tools/unit_tree/html_output.py: wmlunits: Skip writing attack list sections when a unit has no attacks https://github.com/wesnoth/wesnoth/commit/f1eb040c7649d47304d239ca4eef40a07ff02e57
20170827 23:48:34< irker321> wesnoth: Ignacio R. Morelle wesnoth:master f28dafa7a436 / data/tools/unit_tree/ (html_output.py menu.js): wmlunits: Partial re-design of the navigation menu implementation https://github.com/wesnoth/wesnoth/commit/f28dafa7a436c46dfd9f0589157ed60ab15dd467
20170827 23:48:37< irker321> wesnoth: Ignacio R. Morelle wesnoth:master 065d17b0c9c2 / data/tools/unit_tree/html_output.py: wmlunits: Major structural rearrangement of the unit details view page https://github.com/wesnoth/wesnoth/commit/065d17b0c9c2ae178469d0c75b0c83bed5db8c9a
20170827 23:48:40< irker321> wesnoth: Ignacio R. Morelle wesmere:develop 4bb8c11eae04 / wesmere/sass/ (_defs.scss wmlunits.scss wmlunits/_common.scss): sass/wmlunits: Redesign of the navigation menu https://github.com/wesnoth/wesmere/commit/4bb8c11eae04165c634a07f2086a479f88148ef2
20170827 23:48:42< irker321> wesnoth: Ignacio R. Morelle wesmere:develop 5df158ec30bf / wesmere/ (mw/WesmereTemplate.php sass/mw/_ui.scss): mw: Add dropdown markers to toolbar buttons with an associated menu https://github.com/wesnoth/wesmere/commit/5df158ec30bf21cb0a822ee0604d3c942234df0b
20170827 23:48:44< irker321> wesnoth: Ignacio R. Morelle wesmere:develop 9f5229483e78 / wesmere/sass/wmlunits/_single_unit.scss: sass/wmlunits: Major structural rearrangement of the unit details view page https://github.com/wesnoth/wesmere/commit/9f5229483e786093b7b40ed0021bdd787f316f18
--- Log closed Mon Aug 28 00:00:30 2017