--- Log opened Tue Aug 29 00:00:03 2017
--- Day changed Tue Aug 29 2017
20170829 00:00:03< vultraz_iOS> that's something I'm trying to figure out
20170829 00:02:39-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds]
20170829 00:03:15-!- travis-ci [~travis-ci@ec2-54-158-231-197.compute-1.amazonaws.com] has joined #wesnoth-dev
20170829 00:03:16< travis-ci> wesnoth/wesnoth#14823 (master - c0223cd : Ignacio R. Morelle): The build has errored.
20170829 00:03:16< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/269382812
20170829 00:03:16-!- travis-ci [~travis-ci@ec2-54-158-231-197.compute-1.amazonaws.com] has left #wesnoth-dev []
20170829 00:03:25< vultraz_iOS> celticminstrel: thoguhts on the discussion about the wesnothd_connection_ptr?
20170829 00:03:36< celticminstrel> ???
20170829 00:04:14< vultraz_iOS> i removed the wesnothd_connecion_ptr wrapper
20170829 00:04:26< vultraz_iOS> but gfgtdf tells me it was needed for threading reasons
20170829 00:04:46< shadowm> SHUT UP TRAVIS
20170829 00:05:14< vultraz_iOS> what did travis ever do to you
20170829 00:05:48< celticminstrel> Eh? I don't get it. gfgtdf, please explain in detail.
20170829 00:06:14< vultraz_iOS> there are some logs from lastnight
20170829 00:07:00< vultraz_iOS> something about the best way to ensure the object persists for the lifetime of the worker thread
20170829 00:07:19< celticminstrel> I dunno, this seems like it might be helpful. https://www.justsoftwaresolutions.co.uk/threading/why-do-we-need-atomic_shared_ptr.html
20170829 00:07:21< vultraz_iOS> but the worker thread is terminated by destroying the outside object
20170829 00:07:35< vultraz_iOS> (also FTR the ptr works as a unique_ptr)
20170829 00:07:39< celticminstrel> I'll be back to talk about this a bit later.
20170829 00:13:05< Necrosporus>  from /home/build/soft/wesnoth-1.12.6/src/game.cpp:42:
20170829 00:13:05< Necrosporus>  gma message("NOTE: Use of this header (template_arity_spec.hpp) is deprecated")
20170829 00:13:42< gfgtdf> Necrosporus: it's probaly a boost header that includes another deprecated boost header
20170829 00:13:49< Necrosporus> Some boost headers say they are deprecated
20170829 00:14:07< gfgtdf> Necrosporus: the different parts of boost are often maintined independently so things liek this can happen.
20170829 00:14:30< Necrosporus> so it's boost error, not wesnoth's itself
20170829 00:15:43< gfgtdf> Necrosporus: that's just a guess though, to be sure it's probaly better to chack (via text search) whether we do not include that header explicitly.
20170829 00:17:26< Necrosporus> It is 1.12 anyway
20170829 00:47:29-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 248 seconds]
20170829 00:52:18-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20170829 00:56:21-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170829 01:00:21-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Ping timeout: 240 seconds]
20170829 01:02:01-!- gfgtdf [~chatzilla@x4e3635c1.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 55.0.3/20170824053622]]
20170829 01:15:19-!- Bonobo [~Bonobo@203.220.138.162] has joined #wesnoth-dev
20170829 01:52:56-!- RatArmy_ [~ratarmy@om126234114194.16.openmobile.ne.jp] has joined #wesnoth-dev
20170829 01:57:00-!- irker081 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170829 02:27:32< vultraz_iOS> blah
20170829 02:27:37< vultraz_iOS> my idea's not working :|
20170829 02:50:27< vultraz_iOS> Exception thrown at 0x013BD8B9 in wesnoth.exe: 0xC0000005: Access violation reading location 0xFFFFFFFC.
20170829 02:50:29< vultraz_iOS> hmmmmmmm
20170829 02:53:16< vultraz_iOS> not a nullptr
20170829 02:53:21< vultraz_iOS> deleted thingy?
20170829 02:56:55< vultraz_iOS> OH
20170829 02:56:59< vultraz_iOS> now it works \ o /
20170829 02:57:04< vultraz_iOS> praise be
20170829 02:58:34-!- Kwandulin [~Kwandulin@p200300E453CC3BB5B8EE449C5F4E48D4.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170829 03:02:24< celticminstrel> Yeah, if it were a nullptr it would've said "location 0x000000".
20170829 03:02:31< celticminstrel> (Possibly with more 0's.)
20170829 03:05:14-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170829 03:11:05< JyrkiVesterinen> Well, 0xFFFFFFFC is close enough that it can well be a nullptr with negative offset.
20170829 03:12:23< vultraz_iOS> I was accessing the back() member of a container with no members
20170829 03:12:45< celticminstrel> Yeah, don't do that. :P
20170829 03:13:38< celticminstrel> Also I didn't think of that, Jyrki.
20170829 03:13:40< JyrkiVesterinen> In debug builds you'd get a much more clear error message for that, BTW.
20170829 03:16:05-!- irker545 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170829 03:16:05< irker545> wesnoth: Charles Dang wesnoth:preprocessor_cleanup 34df48195a42 / src/serialization/preprocessor.cpp: Preprocessor: refactor streambuf management of preprocessor objects https://github.com/wesnoth/wesnoth/commit/34df48195a42fd83af200ef363383e47ef0b3f95
20170829 03:18:40< vultraz_iOS> er, opps, i appear to have just broken something in the last few minutes >_>
20170829 03:19:58< celticminstrel> So, vultraz_iOS removed the Ctrl+A = Home shortcut. I'm going to remove Ctrl+E = End. Should I leave in Ctrl+U = clear?
20170829 03:19:59< vultraz_iOS> ah there
20170829 03:20:27< celticminstrel> That one isn't an alias dor anything else.
20170829 03:20:37< celticminstrel> And doesn't have any other obvious meaning that I can think of.
20170829 03:21:47< JyrkiVesterinen> I'm in favor of removing it. There isn't much point in keeping only one Emacs shortcut.
20170829 03:21:47< irker545> wesnoth: Charles Dang wesnoth:preprocessor_cleanup 15084efb620d / src/serialization/preprocessor.cpp: Preprocessor: refactor streambuf management of preprocessor objects https://github.com/wesnoth/wesnoth/commit/15084efb620dc323af03c39adbc06656bda14815
20170829 03:21:50< irker545> wesnoth: Charles Dang wesnoth:preprocessor_cleanup 1cedead80fc8 / src/serialization/preprocessor.cpp: Preprocessor: explicitly specify streambuf in the std namespace for clarity https://github.com/wesnoth/wesnoth/commit/1cedead80fc853327aa0fcbf8fe716ecbfc40c4d
20170829 03:22:29< vultraz_iOS> fixed crash
20170829 03:23:26< celticminstrel> If I remove it, the equivalent operation becomes Ctrl+A followed by backspace or delete.
20170829 03:23:43< celticminstrel> So one more keystroke than before, which I guess isn't bad for what's probably a rare operation in the majority of cases.
20170829 03:24:02< celticminstrel> (Though it might be a common operation in chat fields... but in that case I'd expect escape to do it.)
20170829 03:24:38< irker545> wesnoth: Celtic Minstrel wesnoth:master 468c6e0f4947 / src/gui/widgets/text_box_base.cpp: GUI2 Textbox: Remove the other two emacs keybindings https://github.com/wesnoth/wesnoth/commit/468c6e0f494793d57b0b1264894cd7f0b0383fa2
20170829 03:26:29< vultraz_iOS> celticminstrel: could you take a look at 15084efb620d too
20170829 03:28:09< celticminstrel> Why a deque BTW?
20170829 03:28:20< vultraz_iOS> because plain queue doesn;t have pop_back
20170829 03:28:30< vultraz_iOS> only pop, which operates on the front of the queue 
20170829 03:28:33< celticminstrel> Well obviously.
20170829 03:28:39-!- Kwandulin [~Kwandulin@p200300E453CC3BB5B8EE449C5F4E48D4.dip0.t-ipconnect.de] has quit [Quit: [endlevel]]
20170829 03:28:45< celticminstrel> If you want push_back and pop_back, that's a stack, not a queue.
20170829 03:28:51< vultraz_iOS> ok
20170829 03:28:53< vultraz_iOS> oh*
20170829 03:28:56< vultraz_iOS> well then
20170829 03:29:00< celticminstrel> :P
20170829 03:29:08< vultraz_iOS> ill change it
20170829 03:29:14< celticminstrel> Stack has push (add to end) and pop (remove from end) and not much else.
20170829 03:29:27< celticminstrel> So if that's literally all you need, there may be a good reason to use a stack.
20170829 03:29:42< celticminstrel> (I think the only other thing it has is top, to get the last element without removing it.)
20170829 03:29:56< celticminstrel> (Oh and empty, of course.)
20170829 03:30:17< celticminstrel> What's \376?
20170829 03:30:24< vultraz_iOS> no idea
20170829 03:30:29< celticminstrel> Oh, you didn't write that, never mind.
20170829 03:30:38< celticminstrel> (Just moved it.)
20170829 03:31:48< celticminstrel> So I don't see any obvious problems with what you've done there.
20170829 03:32:02< celticminstrel> I was going to work with the preprocessor this weekend, BTW.
20170829 03:32:22< celticminstrel> Though I have a couple other things to get done first, I think.
20170829 03:32:43< vultraz_iOS> ah, you can't iterate over a stack
20170829 03:33:34< vultraz_iOS> bit of a problem, that
20170829 03:34:16< JyrkiVesterinen> You can just use a deque, then. A deque is a superset of a stack.
20170829 03:34:31< vultraz_iOS> yeah, ill stick with the deque 
20170829 03:36:04< celticminstrel> Only if you need to iterate over it non-destructively.
20170829 03:36:18< celticminstrel> If iterating over it also includes emptying it, you can still use a queue / stack.
20170829 03:36:29< vultraz_iOS> non-destructively 
20170829 03:36:45< celticminstrel> Okay
20170829 03:42:43-!- travis-ci [~travis-ci@ec2-54-158-231-197.compute-1.amazonaws.com] has joined #wesnoth-dev
20170829 03:42:44< travis-ci> wesnoth/wesnoth#14824 (preprocessor_cleanup - 34df481 : Charles Dang): The build has errored.
20170829 03:42:44< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/269430786
20170829 03:42:44-!- travis-ci [~travis-ci@ec2-54-158-231-197.compute-1.amazonaws.com] has left #wesnoth-dev []
20170829 03:43:42< irker545> wesnoth: Charles Dang wesnoth:preprocessor_cleanup f2647c4bec4e / src/serialization/ (preprocessor.cpp preprocessor.hpp): Preprocessor: reformat this absolute mess of a file https://github.com/wesnoth/wesnoth/commit/f2647c4bec4e0609808cec84e5b595231c7c9d1f
20170829 03:43:45< irker545> wesnoth: Charles Dang wesnoth:preprocessor_cleanup 13eff8cb39ad / src/serialization/preprocessor.cpp: Preprocessor: used emplace_back in one place https://github.com/wesnoth/wesnoth/commit/13eff8cb39adadeca3adfe1a3cb9324489075521
20170829 03:43:48< irker545> wesnoth: Charles Dang wesnoth:preprocessor_cleanup 213d785edeb2 / src/serialization/preprocessor.cpp: Preprocessor: refactor streambuf management of preprocessor objects https://github.com/wesnoth/wesnoth/commit/213d785edeb2be8f91bb166a2e9f1ac57323aa43
20170829 03:43:51< irker545> wesnoth: Charles Dang wesnoth:preprocessor_cleanup 050fe4cf0289 / src/serialization/preprocessor.cpp: Preprocessor: explicitly specify streambuf in the std namespace for clarity https://github.com/wesnoth/wesnoth/commit/050fe4cf0289ddae889cc451e0c725d6e4373528
20170829 03:44:05< vultraz_iOS> now let's see what travis says
20170829 03:46:04-!- travis-ci [~travis-ci@ec2-54-211-173-142.compute-1.amazonaws.com] has joined #wesnoth-dev
20170829 03:46:05< travis-ci> wesnoth/wesnoth#14826 (preprocessor_cleanup - 1cedead : Charles Dang): The build has errored.
20170829 03:46:05< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/269431766
20170829 03:46:05-!- travis-ci [~travis-ci@ec2-54-211-173-142.compute-1.amazonaws.com] has left #wesnoth-dev []
20170829 03:46:17< JyrkiVesterinen> Well, that was fast. ;)
20170829 03:46:42< vultraz_iOS> :P
20170829 03:46:45< celticminstrel> Speaking of Travis, it's also broken on master, right?
20170829 03:47:10< vultraz_iOS> jyrki fixed it i think
20170829 03:47:22< celticminstrel> His fix errored.
20170829 03:47:32< JyrkiVesterinen> Oh, right. Ubuntu is apparently having problems.
20170829 03:47:38< celticminstrel> But I guess it's not our fault probably.
20170829 03:47:42< JyrkiVesterinen> "E: Unable to correct problems, you have held broken packages."
20170829 04:02:58-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20170829 04:05:05-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170829 04:05:48-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Client Quit]
20170829 04:21:59-!- travis-ci [~travis-ci@ec2-54-211-173-142.compute-1.amazonaws.com] has joined #wesnoth-dev
20170829 04:22:00< travis-ci> wesnoth/wesnoth#14828 (master - 468c6e0 : Celtic Minstrel): The build has errored.
20170829 04:22:00< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/269432256
20170829 04:22:00-!- travis-ci [~travis-ci@ec2-54-211-173-142.compute-1.amazonaws.com] has left #wesnoth-dev []
20170829 04:24:30-!- travis-ci [~travis-ci@ec2-54-158-231-197.compute-1.amazonaws.com] has joined #wesnoth-dev
20170829 04:24:31< travis-ci> wesnoth/wesnoth#14829 (preprocessor_cleanup - 050fe4c : Charles Dang): The build has errored.
20170829 04:24:31< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/269435413
20170829 04:24:31-!- travis-ci [~travis-ci@ec2-54-158-231-197.compute-1.amazonaws.com] has left #wesnoth-dev []
20170829 05:02:14< JyrkiVesterinen> Update on limiting hexes/frame: my measurement shows that in the Dead Warer S1 at 1920x1080. updating the water causes a bit over 500 hexes to be redrawn.
20170829 05:02:29< JyrkiVesterinen> I think I'll add options to limit it to 300, 200 or 100 hexes.
20170829 05:09:13< Necrosporus> And what is with the rest of them, will water there be actually dead?
20170829 05:10:37< JyrkiVesterinen> No, their redraws will just be deferred to later frames.
20170829 05:43:05-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: Going to work]
20170829 06:31:13-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20170829 06:46:15-!- irker545 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170829 06:51:14-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170829 06:51:21-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170829 06:57:30-!- irker018 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170829 06:57:30< irker018> wesnoth: Charles Dang wesnoth:preprocessor_cleanup e862f99e8c43 / src/serialization/preprocessor.cpp: Preprocessor: moved output separator character to a static constant https://github.com/wesnoth/wesnoth/commit/e862f99e8c43f4893ac8df2858f4a8b1bfb3ee2c
20170829 07:09:53-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170829 07:15:33< irker018> wesnoth: Charles Dang wesnoth:preprocessor_cleanup 14c2bb6d44e8 / src/serialization/preprocessor.cpp: Preprocessor: moved output separator character to a static constant https://github.com/wesnoth/wesnoth/commit/14c2bb6d44e8aab8053f7d500f1544c9f97a5570
20170829 07:55:37-!- travis-ci [~travis-ci@ec2-54-158-231-197.compute-1.amazonaws.com] has joined #wesnoth-dev
20170829 07:55:38< travis-ci> wesnoth/wesnoth#14833 (preprocessor_cleanup - 14c2bb6 : Charles Dang): The build has errored.
20170829 07:55:38< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/269470694
20170829 07:55:38-!- travis-ci [~travis-ci@ec2-54-158-231-197.compute-1.amazonaws.com] has left #wesnoth-dev []
20170829 08:22:14-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 240 seconds]
20170829 08:22:18-!- Duthlet [~Duthlet@ipservice-092-211-168-098.092.211.pools.vodafone-ip.de] has joined #wesnoth-dev
20170829 08:55:01-!- Ivanovic [~ivanovic@p4FC53858.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170829 09:33:09-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20170829 10:15:46-!- irker018 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170829 10:21:40-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20170829 11:29:13-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170829 11:29:21-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170829 12:11:19-!- irker099 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170829 12:11:19< irker099> wesnoth: Charles Dang wesnoth:master 1a5e2ccfb7c1 / src/serialization/ (preprocessor.cpp preprocessor.hpp): Preprocessor: reformat this absolute mess of a file https://github.com/wesnoth/wesnoth/commit/1a5e2ccfb7c1aa783223885929a80febc799d224
20170829 12:11:20< irker099> wesnoth: Charles Dang wesnoth:master dbbc92bca917 / src/serialization/preprocessor.cpp: Preprocessor: used emplace_back in one place https://github.com/wesnoth/wesnoth/commit/dbbc92bca917705ca5de02eb3e1844165386eea3
20170829 12:11:21< irker099> wesnoth: Charles Dang wesnoth:master 613f1d9e7f8f / src/serialization/preprocessor.cpp: Preprocessor: refactor streambuf management of preprocessor objects https://github.com/wesnoth/wesnoth/commit/613f1d9e7f8f08da98f50aea7beaba5524868cc7
20170829 12:11:23< irker099> wesnoth: Charles Dang wesnoth:master 9d89083ea570 / src/serialization/preprocessor.cpp: Preprocessor: explicitly specify streambuf in the std namespace for clarity https://github.com/wesnoth/wesnoth/commit/9d89083ea570e01334feeecdc2815d99dfa51524
20170829 12:11:25< irker099> wesnoth: Charles Dang wesnoth:master 62d42738f3c6 / src/serialization/preprocessor.cpp: Preprocessor: moved output separator character to a static constant https://github.com/wesnoth/wesnoth/commit/62d42738f3c607fbbdae410de9a0d79572abe119
20170829 12:11:46-!- atarocch [~atarocch@46.29.219.220] has quit [Ping timeout: 246 seconds]
20170829 12:28:05-!- atarocch [~atarocch@93.56.160.28] has joined #wesnoth-dev
20170829 13:01:04-!- travis-ci [~travis-ci@ec2-54-158-231-197.compute-1.amazonaws.com] has joined #wesnoth-dev
20170829 13:01:05< travis-ci> wesnoth/wesnoth#14835 (master - 62d4273 : Charles Dang): The build has errored.
20170829 13:01:05< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/269558345
20170829 13:01:05-!- travis-ci [~travis-ci@ec2-54-158-231-197.compute-1.amazonaws.com] has left #wesnoth-dev []
20170829 13:05:03-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 248 seconds]
20170829 13:07:39-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20170829 13:13:02< matthiaskrgr> yup that broke linux build
20170829 13:13:27-!- Necrosporus is now known as Guest32462
20170829 13:13:27-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20170829 13:13:27-!- Guest32462 [~Necrospor@unaffiliated/necrosporus] has quit [Killed (weber.freenode.net (Nickname regained by services))]
20170829 13:13:27-!- Necrosporus_ is now known as Necrosporus
20170829 13:13:52< matthiaskrgr> https://pastebin.com/gAte3tEJ  
20170829 13:16:12-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20170829 13:16:12-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Killed (barjavel.freenode.net (Nickname regained by services))]
20170829 13:16:12-!- Necrosporus_ is now known as Necrosporus
20170829 13:20:23< AI0867> just when I was trying to submit a build to coverity
20170829 13:20:38< AI0867> do you have a commit that works?
20170829 13:21:12< JyrkiVesterinen> Latest commit believed to build: https://github.com/wesnoth/wesnoth/commit/468c6e0f494793d57b0b1264894cd7f0b0383fa2
20170829 13:22:04< JyrkiVesterinen> (Travis CI has been having trouble since yesterday evening, so it hasn't been checked.)
20170829 13:25:15< AI0867> building…
20170829 13:31:58-!- Bonobo [~Bonobo@203.220.138.162] has quit [Ping timeout: 276 seconds]
20170829 13:40:43-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Quit: Leaving]
20170829 13:49:24< AI0867> seems to work
20170829 13:57:57-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a969:afe5:b26d:2163] has joined #wesnoth-dev
20170829 13:59:39< AI0867> huh
20170829 13:59:41< AI0867> g++ -o build/release/game_display.o -c -std=c++11 -W -Wall -pthread -O3 -include boost-patched/bind/arg.hpp -D_REENTRANT -DHAVE_LIBDBUS -DHAVE_FRIBIDI -DHAVE_LIBPNG -DHAVE_HISTORY -DHAVE_CONFIG_H -D_X11 -DFIFODIR='"/var/run/wesnothd"' -DWESNOTH_PATH='"/usr/local/share/wesnoth"' -DLOCALEDIR='"translations"' -DHAS_RELATIVE_LOCALEDIR -Ibuild -Isrc -isystem /usr/include/SDL2 -isystem /usr/include/cairo -isystem /usr/include/glib-2.0 -isystem /usr/lib/
20170829 13:59:48< AI0867> In file included from src/units/types.hpp:22:0,
20170829 13:59:51< AI0867>                  from src/units/unit.hpp:19,
20170829 13:59:53< AI0867>                  from src/game_board.cpp:22:
20170829 13:59:56< AI0867> src/units/attack_type.hpp:39:54: internal compiler error: Segmentation fault
20170829 13:59:59< AI0867>   const t_string& name() const { return description_; }
20170829 14:00:05< AI0867> it worked fine without coverity wrapping it though
20170829 14:12:29-!- Duthlet [~Duthlet@ipservice-092-211-168-098.092.211.pools.vodafone-ip.de] has quit [Quit: leaving]
20170829 14:15:23-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20170829 14:20:23-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170829 14:20:41-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170829 14:31:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170829 14:46:39-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a969:afe5:b26d:2163] has quit [Remote host closed the connection]
20170829 14:47:04-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a969:afe5:b26d:2163] has joined #wesnoth-dev
20170829 14:49:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170829 14:52:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170829 14:55:25-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a969:afe5:b26d:2163] has quit [Remote host closed the connection]
20170829 14:55:58-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a969:afe5:b26d:2163] has joined #wesnoth-dev
20170829 15:00:07-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a969:afe5:b26d:2163] has quit [Ping timeout: 246 seconds]
20170829 15:02:43-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170829 15:13:51-!- irker099 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170829 15:50:32-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170829 15:57:21-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a969:afe5:b26d:2163] has joined #wesnoth-dev
20170829 16:06:51-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170829 16:10:11-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170829 16:17:13< JyrkiVesterinen> shadowm: there are, uh, quite visible FIXMEs in https://wiki.wesnoth.org/GUIToolkit
20170829 16:17:33< JyrkiVesterinen> How can they be fixed?
20170829 16:24:17< Ravana_> https://wiki.wesnoth.org/index.php?title=GUIToolkit&type=revision&diff=58873&oldid=57574
20170829 16:24:45< JyrkiVesterinen> So, second level. Thanks. :)
20170829 16:29:30< shadowm> Yeah, someone with admin privs will have to do that with the autogenerated pages too.
20170829 16:29:56< shadowm> They might as well not be protected anymore since I bet none of you have kept the GUI2 documentation comments in code up to date.
20170829 16:30:24< JyrkiVesterinen> I have at least documented the new widgets I have added.
20170829 16:30:48< shadowm> Has anyone taken care of regenerating the wiki pages, though?
20170829 16:31:01< JyrkiVesterinen> I don't think so.
20170829 16:31:50< shadowm> I certainly won't do it since I don't dev here anymore.
20170829 16:34:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170829 16:34:52-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a969:afe5:b26d:2163] has quit [Remote host closed the connection]
20170829 16:36:20< JyrkiVesterinen> Hey. I realized that the performance cost of animations can be halved.
20170829 16:36:21< JyrkiVesterinen> https://github.com/wesnoth/wesnoth/blob/62d42738f3c607fbbdae410de9a0d79572abe119/src/display.cpp#L2441-L2446
20170829 16:36:24-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a969:afe5:b26d:2163] has joined #wesnoth-dev
20170829 16:37:04< JyrkiVesterinen> Every invalidated hex will be redrawn in *two* consecutive frames. First because it's in invalidated_, then because it's in previous_invalidated_.
20170829 16:37:38< JyrkiVesterinen> It would be more efficient to stop doing that, at least for hexes which were invalidated because of animation frames.
20170829 16:50:55-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a969:afe5:b26d:2163] has quit [Remote host closed the connection]
20170829 16:55:31< shadowm> celticminstrel: There's no [issue=] bbCode and there won't be since the whole point is that the issue number should be visible at all times. Use [issue] instead.
20170829 16:56:23-!- Ivanovic [~ivanovic@p4FC53858.dip0.t-ipconnect.de] has quit [Changing host]
20170829 16:56:23-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20170829 16:59:36-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170829 17:17:03-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170829 17:26:43-!- Kwandulin [~Kwandulin@p200300E453CC3BB5B8EE449C5F4E48D4.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170829 17:26:55< JyrkiVesterinen> zookeeper: I implemented the option to limit hexes to redraw per frame.
20170829 17:26:58< JyrkiVesterinen> https://vgy.me/Yg1RQp
20170829 17:27:55< JyrkiVesterinen> Unfortunately, using it results in pretty bad glitches. In particular, [message] allows the engine to draw only one frame before showing up, and the result is this: https://vgy.me/hdaZGS
20170829 17:28:42< JyrkiVesterinen> I'm abandoning the effort. I'll look into fixing the double rendering issue I mentioned above, instead.
20170829 17:29:11< JyrkiVesterinen> In case someone wants to see it, I pushed the code here: https://github.com/jyrkive/wesnoth/commit/ba4ffb7d2411d66eaf022d3122b35bd57503312b
20170829 17:33:07-!- moongazer [~moongazer@2405:204:9309:2cf7:9c4b:c3ba:3d53:a768] has joined #wesnoth-dev
20170829 17:34:48-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170829 17:36:33-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a969:afe5:b26d:2163] has joined #wesnoth-dev
20170829 17:38:04< zookeeper> JyrkiVesterinen, ouch, that's a pretty bad glitch indeed :p
20170829 17:38:23< zookeeper> how well did it perform, though?
20170829 17:39:33< JyrkiVesterinen> At 200 hexes/frame, the engine was able to slow down. FPS went from ~500 to ~100 and CPU usage fell. And it didn't look any worse under normal conditions.
20170829 17:40:36< zookeeper> hmh, okay. and you don't think the [message] thing (and any others) are easily fixable somehow?
20170829 17:41:31< JyrkiVesterinen> They may be, but I'm not willing to look further. Your idea to randomize water animation start times is likely the easier way forward.
20170829 17:42:14-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a969:afe5:b26d:2163] has quit [Remote host closed the connection]
20170829 17:43:03< zookeeper> all right. do you think that previous_invalidated_ thing will result in a substantial animation performance boost in practise?
20170829 17:43:18< JyrkiVesterinen> Yes. Literally doubling it.
20170829 17:43:33< zookeeper> well, if that's right then it sounds pretty good :P
20170829 17:48:28-!- Kwandulin [~Kwandulin@p200300E453CC3BB5B8EE449C5F4E48D4.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170829 17:54:51-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a969:afe5:b26d:2163] has joined #wesnoth-dev
20170829 18:03:53-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20170829 18:14:08-!- moongazer [~moongazer@2405:204:9309:2cf7:9c4b:c3ba:3d53:a768] has quit [Ping timeout: 240 seconds]
20170829 18:22:35-!- moongazer [~moongazer@117.198.90.37] has joined #wesnoth-dev
20170829 18:22:58< moongazer> Hi! I just found an open source implementation of captain claw
20170829 18:23:00< moongazer> yayayya
20170829 18:23:12< moongazer> I have played that game more than this
20170829 18:23:22< moongazer> I have been studying the wesnoth code base for months:(
20170829 18:26:07-!- moongazer [~moongazer@117.198.90.37] has quit [Client Quit]
20170829 18:56:47< zookeeper> JyrkiVesterinen, so i guess my proposed simple change to the fps counter from yesterday is good to go in?
20170829 18:57:22< JyrkiVesterinen> Yes. It would be much more useful that the current counter.
20170829 18:57:45< JyrkiVesterinen> The current counter does technically measure FPS, but it turns out not to be a very useful value to know...
20170829 18:59:57-!- higgins [~higgins@68.ip-149-56-14.net] has quit [Quit: Leaving]
20170829 19:02:55-!- higgins [~higgins@68.ip-149-56-14.net] has joined #wesnoth-dev
20170829 19:05:42< zookeeper> JyrkiVesterinen, please proofread my commit description, though: The previous behavior caused the counter to often display a very high fps value due to an occasional long frame causing the delay between following frames to be very short. This makes the fps counter more useful and intuitive for benchmarking purposes by calculating the displayed value based on the worst of the sampled 
20170829 19:05:42< zookeeper> frametimes.
20170829 19:07:14< JyrkiVesterinen> Looks good. Just some nitpicking:
20170829 19:07:29< JyrkiVesterinen> FPS is an abbreviation and I prefer writing it in uppercase.
20170829 19:07:42< JyrkiVesterinen> "This makes" -> "This commit makes"
20170829 19:07:58< JyrkiVesterinen> "worst" -> "longest"
20170829 19:11:18-!- irker400 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170829 19:11:18< irker400> wesnoth: ln-zookeeper wesnoth:master 7534038e4859 / src/display.cpp: Based the FPS counter's displayed value on the longest frametime https://github.com/wesnoth/wesnoth/commit/7534038e485976f35ab8a20b791816a455138c8e
20170829 19:14:04-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a969:afe5:b26d:2163] has quit [Remote host closed the connection]
20170829 19:14:40-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a969:afe5:b26d:2163] has joined #wesnoth-dev
20170829 19:18:46-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a969:afe5:b26d:2163] has quit [Ping timeout: 246 seconds]
20170829 19:25:03< irker400> wesnoth: ln-zookeeper wesnoth:master 863f31c62822 / src/terrain/ (builder.cpp builder.hpp): Allow specifying the random shift range for terrain animation times https://github.com/wesnoth/wesnoth/commit/863f31c62822aa98cb3464f915aa371b60ea8e86
20170829 19:26:24-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a969:afe5:b26d:2163] has joined #wesnoth-dev
20170829 19:32:47-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170829 19:34:33< zookeeper> i'll see if i can get the water shifting in tonight
20170829 20:26:45< shadowm> Git is so slow to work with Wesnoth it's rather irritating.
20170829 20:27:01< shadowm> I lost the habit of working with humongous repositories.
20170829 20:27:11< irker400> wesnoth: Ignacio R. Morelle wesnoth:master 290cb4c2d2b2 / data/tools/unit_tree/ (helpers.py html_output.py): wmlunits: Use transparent/ portraits where available, and omit sprite bg https://github.com/wesnoth/wesnoth/commit/290cb4c2d2b24f5cd232fceae2eb6a9cf0325cbb
20170829 20:32:25< irker400> wesnoth: Ignacio R. Morelle wesmere:develop c3768cd24246 / wesmere/sass/wmlunits/ (_common.scss _single_unit.scss): sass/wmlunits: Can't be bothered to describe all these changes https://github.com/wesnoth/wesmere/commit/c3768cd24246cb8156df5b3b097233276fc11320
20170829 20:44:15-!- travis-ci [~travis-ci@ec2-54-198-49-14.compute-1.amazonaws.com] has joined #wesnoth-dev
20170829 20:44:16< travis-ci> wesnoth/wesnoth#14836 (master - 7534038 : ln-zookeeper): The build has errored.
20170829 20:44:16< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/269723944
20170829 20:44:16-!- travis-ci [~travis-ci@ec2-54-198-49-14.compute-1.amazonaws.com] has left #wesnoth-dev []
20170829 20:53:58-!- gfgtdf [~chatzilla@x4e3632bd.dyn.telefonica.de] has joined #wesnoth-dev
20170829 20:54:26< gfgtdf> vultraz_iOS: any new thoughts on the wesnothd_connection_ptr issue ?
20170829 20:55:20-!- travis-ci [~travis-ci@ec2-107-22-14-255.compute-1.amazonaws.com] has joined #wesnoth-dev
20170829 20:55:21< travis-ci> wesnoth/wesnoth#14837 (master - 863f31c : ln-zookeeper): The build has errored.
20170829 20:55:21< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/269728392
20170829 20:55:21-!- travis-ci [~travis-ci@ec2-107-22-14-255.compute-1.amazonaws.com] has left #wesnoth-dev []
20170829 21:24:16-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20170829 21:27:49-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170829 21:44:49-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a969:afe5:b26d:2163] has quit [Remote host closed the connection]
20170829 21:45:21-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a969:afe5:b26d:2163] has joined #wesnoth-dev
20170829 21:49:52-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a969:afe5:b26d:2163] has quit [Ping timeout: 276 seconds]
20170829 22:03:08-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 255 seconds]
20170829 22:42:25-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170829 23:02:26-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170829 23:14:03-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170829 23:14:19< vultraz_iOS> gfgtdf: if it can be done with an atomic ptr that might be better
20170829 23:28:48< DeFender> Every time I hear someone talk about an atomic pointer, the image in my head is: https://imgur.com/a/R0IzL
20170829 23:32:30< vultraz_iOS> heh
20170829 23:34:03-!- irker400 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170829 23:39:14< gfgtdf> vultraz_iOS: i don'T see how atomic pointers apply here, maybe you can exaplain?
20170829 23:39:26< vultraz_iOS> celmin mentioned them
20170829 23:39:33< vultraz_iOS> imnot familiar with their use
20170829 23:51:04-!- Bonobo [~Bonobo@203.220.138.162] has joined #wesnoth-dev
20170829 23:57:26-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170829 23:59:02-!- irker003 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170829 23:59:02< irker003> wesnoth: Ignacio R. Morelle wesmere:develop d2b3689d7a06 / wesmere/sass/wmlunits/_common.scss: sass/wmlunits: Add dropdown arrows https://github.com/wesnoth/wesmere/commit/d2b3689d7a06ce1c5c134543ded8fb89a3bbe520
--- Log closed Wed Aug 30 00:00:32 2017