--- Log opened Sun Sep 03 00:00:38 2017
20170903 00:15:50-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170903 00:19:57-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170903 00:26:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170903 00:29:44-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170903 01:13:41-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170903 01:14:13-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has joined #wesnoth-dev
20170903 01:18:30-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has quit [Ping timeout: 240 seconds]
20170903 01:20:45-!- irker958 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170903 01:34:07-!- Bonobo [~Bonobo@203.220.138.162] has joined #wesnoth-dev
20170903 01:57:32-!- gfgtdf_ [~chatzilla@x4e32b7a8.dyn.telefonica.de] has joined #wesnoth-dev
20170903 02:00:29-!- gfgtdf [~chatzilla@x4e32b4f9.dyn.telefonica.de] has quit [Ping timeout: 246 seconds]
20170903 02:00:41-!- gfgtdf_ is now known as gfgtdf
20170903 02:20:04-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170903 02:20:30< vultraz_iOS> gfgtdf: what was that pragma?
20170903 02:20:37< vultraz_iOS> #pragma optimize "off"
20170903 02:20:38< vultraz_iOS> ?
20170903 02:21:22< gfgtdf> `#pragma optimize( "", off ) `
20170903 02:21:45< gfgtdf> vultraz_iOS: this doesn't activate debug symbols though you have to do that is your projects settings
20170903 02:21:56< gfgtdf> vultraz_iOS: if you haven't already
20170903 02:32:05-!- gfgtdf [~chatzilla@x4e32b7a8.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 55.0.3/20170824053622]]
20170903 02:54:20-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170903 02:54:26-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170903 03:01:33-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has joined #wesnoth-dev
20170903 03:05:47-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has quit [Remote host closed the connection]
20170903 03:06:23-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has joined #wesnoth-dev
20170903 03:09:33-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has quit [Remote host closed the connection]
20170903 03:09:51-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has joined #wesnoth-dev
20170903 03:53:25-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20170903 03:58:46-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has quit [Remote host closed the connection]
20170903 03:59:21-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has joined #wesnoth-dev
20170903 04:03:22-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has quit [Ping timeout: 246 seconds]
20170903 04:03:36-!- Kwandulin [~Kwandulin@p200300E453CC3BF785ABA56242B2DB53.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170903 04:26:26< Necrosporus> In trunk it seems that there's something wrong with planning mode. Stoned icon of planned-moved unit is not always displayd
20170903 04:29:56-!- APic [apic@apic.name] has quit [Ping timeout: 246 seconds]
20170903 04:39:03-!- APic [~apic@apic.name] has joined #wesnoth-dev
20170903 05:12:51-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170903 05:33:46-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has joined #wesnoth-dev
20170903 05:39:49-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170903 06:01:46-!- irker777 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170903 06:01:46< irker777> wesnoth: Charles Dang wesnoth:master 41e674128f4c / data/gui/window/ (mp_join_game.cfg mp_staging.cfg): MP Join Game/MP Staging: use scaled to size for leader image definitions https://github.com/wesnoth/wesnoth/commit/41e674128f4c742664732460c85a8f6009a20f15
20170903 06:01:53< Necrosporus> Does wesnoth allow move bunch of units in same time?
20170903 06:01:57< vultraz_iOS> no
20170903 06:02:02< Necrosporus> Even in scripts?
20170903 06:02:07< Necrosporus> Or cutscene
20170903 06:02:16< Necrosporus> You know, an army moving syncronously
20170903 06:02:18< vultraz_iOS> no
20170903 06:03:02< Necrosporus> Then it would be nice if whoever edits Oath of Allegiance did something with many horsemen moving in cutscene, it's a bit annoying
20170903 06:03:51< Kwandulin> Yeah, it was a bane to playtest that scenario
20170903 06:04:31< vultraz_iOS> it's definitely something we want to add
20170903 06:05:34< Necrosporus> Perhaps, limit amount of horsement to just one, and then rematerialize the others at destination
20170903 06:05:51< Necrosporus> They also can all fake-move to same hex
20170903 06:05:57< Necrosporus> move as one unit
20170903 06:06:05< Necrosporus> Then move out of destination hex
20170903 06:07:09< Necrosporus> ctrl-key stopped working again
20170903 06:07:29< Kwandulin> Using a quick {FADE_TO_BLACK}, teleporting the units to the destination and fading in again might also work
20170903 06:07:44< Necrosporus> I mean, I cannot do any ctrl-shortcuts after something happened
20170903 06:07:54< Necrosporus> It could be related with OA cutscene
20170903 06:07:56< vultraz_iOS> Necrosporus: file a bug please
20170903 06:08:06< Kwandulin> Do you play with 2x speed? The duration of the cutscene feels "okay" then
20170903 06:08:11< Necrosporus> The problem is I do not know what could it be
20170903 06:08:27< Necrosporus> Nothing in logs either
20170903 06:08:37< Necrosporus> ctrl-shortcuts simply stopped working
20170903 06:08:51< vultraz_iOS> again, file a bug
20170903 06:09:00< vultraz_iOS> we've had some hotkey issues latest
20170903 06:09:02< vultraz_iOS> lately 
20170903 06:13:05-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has quit [Remote host closed the connection]
20170903 06:13:46< Necrosporus> Simply going through cutscene again did not reproduce the problem
20170903 06:14:26< Necrosporus> Oh, I see
20170903 06:14:49< Necrosporus> Ctrl-shortcuts stopped working when I tried to press a ctrl-shortcuts while non-latin layout was enabled
20170903 06:16:06< Necrosporus> And now it doesn't reproduce
20170903 06:19:14-!- mjs-de [~mjs-de@x4db6f407.dyn.telefonica.de] has joined #wesnoth-dev
20170903 06:36:20-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170903 06:52:23-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170903 07:24:06-!- Oebele [~quassel@92.110.163.84] has joined #wesnoth-dev
20170903 07:31:43-!- Bonobo [~Bonobo@203.220.138.162] has quit [Ping timeout: 248 seconds]
20170903 07:32:23-!- Bonobo [~Bonobo@61.68.158.162] has joined #wesnoth-dev
20170903 07:35:00< Necrosporus> By the way, since water is animated, should not water villages be animated too?
20170903 07:35:18< Necrosporus> There are waves going through water hexes, but not villages
20170903 07:38:08< Necrosporus> By the way, if Wesnoth is going in Steam does it mean some sort of multiplayer integration or something?
20170903 07:48:17-!- Oebele [~quassel@92.110.163.84] has quit [Remote host closed the connection]
20170903 07:54:24-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170903 07:57:25-!- markus_ [~mjs-de@x4e313418.dyn.telefonica.de] has joined #wesnoth-dev
20170903 08:00:38-!- mjs-de [~mjs-de@x4db6f407.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170903 08:16:35-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 240 seconds]
20170903 08:38:21-!- Bonobo [~Bonobo@61.68.158.162] has quit [Ping timeout: 240 seconds]
20170903 08:39:07-!- Bonobo [~Bonobo@61.68.158.162] has joined #wesnoth-dev
20170903 09:01:18-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170903 09:16:15-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170903 09:19:41-!- Bonobo [~Bonobo@61.68.158.162] has quit [Ping timeout: 240 seconds]
20170903 09:19:51-!- Bonobo [~Bonobo@61.68.158.162] has joined #wesnoth-dev
20170903 09:41:40-!- gfgtdf [~chatzilla@x4e32b7a8.dyn.telefonica.de] has joined #wesnoth-dev
20170903 09:43:22< gfgtdf> vultraz_iOS: did you made progress on the preprocessor issue ?
20170903 09:43:29< vultraz_iOS> no
20170903 09:43:34< vultraz_iOS> attempted to debug
20170903 09:43:40< vultraz_iOS> with a debug build
20170903 09:43:52< vultraz_iOS> results made no sense
20170903 09:44:59< gfgtdf> so you didn't try the pragma thing ?
20170903 09:45:09< vultraz_iOS> no
20170903 09:45:10< gfgtdf> also what exactly didn't amke sense?
20170903 09:45:48< vultraz_iOS> so i thought the problem was the `name` variable in preprocessor_data was empty
20170903 09:46:07< vultraz_iOS> but then i realized it's deliberately passed an empty string in all except 1 case
20170903 09:46:16< vultraz_iOS> and that 1 case is never empty
20170903 09:46:21< vultraz_iOS> so the problem is somewhere else
20170903 09:46:24< gfgtdf> you mean 'location' ?
20170903 09:46:39< vultraz_iOS> name is used to assign `location_`
20170903 09:47:36< gfgtdf> hm ok
20170903 09:58:28< gfgtdf> vultraz_iOS: so what i think what happens is that: before whena  preprocessor_file was added, the old code first 'added' the preprocessor_file and then the preprocessor_data (since it was added in the ctor ) but the new code, put the preprocessor_data first since the preprocessor_data is added in the preprocessor_file ctor whiel the preprocessor_file is then added _after_ the preprocessor_file cto
20170903 09:58:30< gfgtdf> r has completed
20170903 09:58:53< vultraz_iOS> hmmmmmm
20170903 09:59:00< vultraz_iOS> that... could very well be the problem
20170903 09:59:05< vultraz_iOS> gfgtdf: how would you solve this?
20170903 10:00:17< gfgtdf> vultraz_iOS: i don't know currently
20170903 10:00:43< vultraz_iOS> jyrki ^
20170903 10:02:25-!- Kwandulin [~Kwandulin@p200300E453CC3BF785ABA56242B2DB53.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170903 10:34:52-!- gfgtdf [~chatzilla@x4e32b7a8.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20170903 10:36:20-!- Kwandulin [~Kwandulin@p200300E453CC3BF785ABA56242B2DB53.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170903 10:36:29-!- Kwandulin [~Kwandulin@p200300E453CC3BF785ABA56242B2DB53.dip0.t-ipconnect.de] has quit [Client Quit]
20170903 10:36:45-!- Kwandulin [~Kwandulin@p200300E453CC3BF785ABA56242B2DB53.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170903 10:49:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170903 10:53:38-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev
20170903 10:53:58-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170903 10:54:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 248 seconds]
20170903 11:07:11-!- irker777 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170903 11:27:12-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170903 11:34:36-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170903 11:34:42-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170903 11:35:50-!- Duthlet [~Duthlet@ipservice-092-211-211-035.092.211.pools.vodafone-ip.de] has joined #wesnoth-dev
20170903 11:45:10-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20170903 11:48:25-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170903 11:51:00-!- irker803 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170903 11:51:00< irker803> wesnoth: loonycyborg wesnoth:master d729d0fe1c55 / src/server/server_base.cpp: Change strcpy to memcpy to properly do comparison with sequence of 4 NULLs https://github.com/wesnoth/wesnoth/commit/d729d0fe1c55d54c95b2727352ab148a9dff99ad
20170903 12:28:03-!- travis-ci [~travis-ci@ec2-54-196-48-8.compute-1.amazonaws.com] has joined #wesnoth-dev
20170903 12:28:04< travis-ci> wesnoth/wesnoth#14871 (master - d729d0f : loonycyborg): The build has errored.
20170903 12:28:04< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/271368715
20170903 12:28:04-!- travis-ci [~travis-ci@ec2-54-196-48-8.compute-1.amazonaws.com] has left #wesnoth-dev []
20170903 12:42:09< AI0867> zookeeper: more explanation added. Do you think that's sufficient?
20170903 12:43:49< zookeeper> AI0867, maybe. i guess i should try it out and see what it looks like in practise.
20170903 12:47:50-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20170903 12:54:46-!- Kwandulin [~Kwandulin@p200300E453CC3BF785ABA56242B2DB53.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170903 13:18:28-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170903 13:24:31-!- travis-ci [~travis-ci@ec2-54-81-246-52.compute-1.amazonaws.com] has joined #wesnoth-dev
20170903 13:24:32< travis-ci> spixi/wesnoth#18 (chart_engine - ce8b125 : Spixi): The build has errored.
20170903 13:24:32< travis-ci> Build details : https://travis-ci.org/spixi/wesnoth/builds/271383319
20170903 13:24:32-!- travis-ci [~travis-ci@ec2-54-81-246-52.compute-1.amazonaws.com] has left #wesnoth-dev []
20170903 13:28:18< Necrosporus> How do you choose which difficulty you should start a scenario on?
20170903 13:29:55< vultraz_iOS> what?
20170903 13:30:13< Necrosporus> You have started playing a new campaign
20170903 13:30:32< Necrosporus> How do you pick difficulty level? I mean easy/hard
20170903 13:31:03< DeFender1031> You click on the one you want?
20170903 13:31:22< DeFender1031> And then click "ok"?
20170903 13:31:45< DeFender1031> I think double-clicking on the one you want works too...
20170903 13:32:00< JyrkiVesterinen> Necrosporus: Like in any other game. Think about how much you have player Wesnoth, or turn-based strategy games in general, and how hard a difficulty level you'd be able to survive.
20170903 13:32:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170903 13:32:05-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 246 seconds]
20170903 13:34:56< Necrosporus> I have started playing on hard, but it seems to be too hard without safe-scumming. And if I start on medium, then there are too few enemies to level units
20170903 13:43:41-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has joined #wesnoth-dev
20170903 13:44:52< irker803> wesnoth: Charles Dang wesnoth:master 970c815fc4e9 / src/serialization/preprocessor.cpp: Preprocessor: fixed backtrace (fixes #1928) https://github.com/wesnoth/wesnoth/commit/970c815fc4e969616a25436fae0dcc8abff540fa
20170903 13:44:55< irker803> wesnoth: Charles Dang wesnoth:master e05c6e322a42 / src/serialization/preprocessor.cpp: Preprocessor: minor cleanup https://github.com/wesnoth/wesnoth/commit/e05c6e322a421f63938d3ac20ed82457058e7bfa
20170903 13:45:18< vultraz_iOS> gfgtdf: you were right
20170903 13:51:25< irker803> wesnoth: Charles Dang wesnoth:master 08a866dc20e6 / src/ (3 files in 2 dirs): Revert "Refactor out wesnothd_connection_ptr wrapper class" https://github.com/wesnoth/wesnoth/commit/08a866dc20e678602f65f0cdedb21fb28a0bfa8c
20170903 13:52:00< vultraz_iOS> agh, wrong bug number
20170903 14:02:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170903 14:02:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170903 14:11:05-!- Kwandulin [~Kwandulin@p200300E453CC3BF785ABA56242B2DB53.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170903 14:13:36-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170903 14:14:00< Kwandulin> Do I have to build Wesnoth in order to see the change of your commit, vultraz. (I am no tech guy so I can't compile BfW here). I think the change is only on the WML side and I changed the lines accordingly in my local version. Does that suffice?
20170903 14:14:06< Kwandulin> -. +?
20170903 14:17:08< vultraz_iOS> It should
20170903 14:17:20< vultraz_iOS> You might have gotten the wrong line
20170903 14:20:05-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Remote host closed the connection]
20170903 14:20:32< vultraz_iOS> Are you sure you changed the leader_image images
20170903 14:20:57-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170903 14:23:09-!- travis-ci [~travis-ci@ec2-54-81-246-52.compute-1.amazonaws.com] has joined #wesnoth-dev
20170903 14:23:10< travis-ci> wesnoth/wesnoth#14872 (master - e05c6e3 : Charles Dang): The build has errored.
20170903 14:23:10< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/271388424
20170903 14:23:10-!- travis-ci [~travis-ci@ec2-54-81-246-52.compute-1.amazonaws.com] has left #wesnoth-dev []
20170903 14:27:00< Kwandulin> Copied the whole files and it's not working here :<
20170903 14:27:23< Kwandulin> Certainly I am doing something wrong
20170903 14:27:23< vultraz_iOS> ;_;
20170903 14:27:27< vultraz_iOS> oh wait
20170903 14:27:30< vultraz_iOS> uhhh
20170903 14:27:33< vultraz_iOS> oh
20170903 14:27:36< vultraz_iOS> wait
20170903 14:27:41< vultraz_iOS> do you have latest master?
20170903 14:27:54< Kwandulin> 1.13.8
20170903 14:28:04< Kwandulin> Then that*s probably the problem
20170903 14:28:33< vultraz_iOS> ok, yeah
20170903 14:28:48< vultraz_iOS> copy data/gui/widgets/image.cfg from master to the same file in your data dir
20170903 14:31:21< Kwandulin> Yes it works!
20170903 14:32:24< Kwandulin> Sprites seem to be stretched, though, but that might be due to other stuff then
20170903 14:39:16-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has quit [Remote host closed the connection]
20170903 14:57:10-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has joined #wesnoth-dev
20170903 14:57:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170903 14:58:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170903 15:01:22-!- Bonobo [~Bonobo@61.68.158.162] has quit [Ping timeout: 246 seconds]
20170903 15:11:27-!- sevu [~Shiki@p54856C0A.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170903 15:25:28-!- gfgtdf [~chatzilla@x4e369076.dyn.telefonica.de] has joined #wesnoth-dev
20170903 15:35:26-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170903 15:36:29< irker803> wesnoth: Charles Dang wesnoth:master 1db294f227cc / src/actions/ (attack.cpp attack.hpp): Actions/Attack: formatting cleanup https://github.com/wesnoth/wesnoth/commit/1db294f227cccedd3a3a3a3de06a33414ae4890e
20170903 15:36:32< irker803> wesnoth: Charles Dang wesnoth:master e8c7d7222483 / src/actions/ (attack.cpp attack.hpp): Actions/Attack: deployed the great and mighty unique_ptr https://github.com/wesnoth/wesnoth/commit/e8c7d722248332f6180c65993a7b5a3821b11b96
20170903 15:36:35< irker803> wesnoth: Charles Dang wesnoth:master bc4af0d83207 / src/actions/attack.cpp: Actions/Attack: refactored out some reference-to-pointer mumbo-jumbo https://github.com/wesnoth/wesnoth/commit/bc4af0d8320703d1a907b4adb310d9aa7ffcb89f
20170903 15:36:38< irker803> wesnoth: Charles Dang wesnoth:master e52d532cae04 / src/attack_prediction.cpp: Attack Prediction: cleaned up a use of memset https://github.com/wesnoth/wesnoth/commit/e52d532cae046cadf9404a980323977a24f12669
20170903 15:36:52< celticminstrel> Nothing inherently wrong with references to pointers.
20170903 15:40:55< vultraz_iOS> it's confusing
20170903 15:41:05< celticminstrel> Not really?
20170903 15:41:17< vultraz_iOS> and there's no need in this case
20170903 15:41:18< celticminstrel> In some cases it might be exactly what's needed.
20170903 15:41:30< celticminstrel> I haven't looked at this case, so you could be right.
20170903 15:41:45< celticminstrel> unique_ptrs should generally be passed around by const-ref though.
20170903 15:41:57< vultraz_iOS> ?
20170903 15:42:06< celticminstrel> To avoid them evaporating into the ether. :P
20170903 15:42:30< celticminstrel> If you pass a unique_ptr by value, it's moved. The source no longer points to anything.
20170903 15:43:21< vultraz_iOS> what commit?
20170903 15:43:35< celticminstrel> I'm not talking about any particular commit ATM.
20170903 15:43:39< celticminstrel> Just generally.
20170903 16:16:23-!- travis-ci [~travis-ci@ec2-54-166-167-199.compute-1.amazonaws.com] has joined #wesnoth-dev
20170903 16:16:24< travis-ci> wesnoth/wesnoth#14874 (master - e52d532 : Charles Dang): The build has errored.
20170903 16:16:24< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/271410526
20170903 16:16:24-!- travis-ci [~travis-ci@ec2-54-166-167-199.compute-1.amazonaws.com] has left #wesnoth-dev []
20170903 16:23:43< irker803> wesnoth: Charles Dang wesnoth:master 19bbfedb32c8 / src/ (8 files in 5 dirs): Deployed unique_ptrs in a bunch more places https://github.com/wesnoth/wesnoth/commit/19bbfedb32c853edcabd1ebc17538fbaee5fe3c7
20170903 16:23:46< irker803> wesnoth: Charles Dang wesnoth:master 9e46216e4f54 / src/ (floating_label.cpp game_events/pump.cpp serialization/schema_validator.cpp): Convert a few cases of std::stack::push to std::stack::emplace https://github.com/wesnoth/wesnoth/commit/9e46216e4f54f71b525b2c53dacb707fcdead7d6
20170903 16:26:24< vultraz_iOS> ( wonder if maybe i should have kept a manual reset in `addons_client` to maintain destruction order)
20170903 16:26:32< JyrkiVesterinen> IMO, references to pointers are indeed confusing. Even if their features are needed, pointers to pointers are easier to understand.
20170903 16:27:35< JyrkiVesterinen> And unique_ptr shouldn't be passed around at all. Just pass the underlying raw pointer.
20170903 16:39:38-!- Kwandulin [~Kwandulin@p200300E453CC3BF785ABA56242B2DB53.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170903 16:45:38-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has quit [Remote host closed the connection]
20170903 17:10:53-!- travis-ci [~travis-ci@ec2-54-145-11-136.compute-1.amazonaws.com] has joined #wesnoth-dev
20170903 17:10:54< travis-ci> wesnoth/wesnoth#14876 (master - 9e46216 : Charles Dang): The build has errored.
20170903 17:10:54< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/271419712
20170903 17:10:54-!- travis-ci [~travis-ci@ec2-54-145-11-136.compute-1.amazonaws.com] has left #wesnoth-dev []
20170903 17:12:50-!- Kwandulin [~Kwandulin@p200300E453CC3BF7BC3B4476E50D3AE9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170903 17:27:44< sevu> I just got a segfault when one of my units died: https://bpaste.net/show/a8cbfb0cfdb5
20170903 17:28:04< sevu> maybe it's also more related to the fat that some dialog would have been triggered by that.
20170903 17:28:18< sevu> I'm at master minus the latest two commits
20170903 17:30:35< gfgtdf> considering that that's exactly the function that was changed by https://github.com/wesnoth/wesnoth/commit/bc4af0d8320703d1a907b4adb310d9aa7ffcb89f, you can probably blame vultraz_iOS 
20170903 17:46:12-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170903 17:49:19-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170903 17:49:58-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has joined #wesnoth-dev
20170903 17:50:02< zookeeper> AI0867, might seem like a minor issue, but i think when staring at the FPS figures, it's very distracting when the numbers keep jumping left and right when the number of numbers changes. any easy way to pad them so it wouldn't happen?
20170903 17:52:19< vultraz_iOS> Yay crashes!
20170903 17:53:47-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has quit [Remote host closed the connection]
20170903 17:58:34-!- Bonobo [~Bonobo@61.68.158.162] has joined #wesnoth-dev
20170903 18:20:27-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has joined #wesnoth-dev
20170903 18:23:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 252 seconds]
20170903 18:23:45-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170903 18:26:59-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has quit [Remote host closed the connection]
20170903 18:29:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170903 18:29:23-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 255 seconds]
20170903 18:32:41-!- Bonobo [~Bonobo@61.68.158.162] has quit [Ping timeout: 240 seconds]
20170903 18:39:33-!- Kwandulin2 [~Kwandulin@p200300E453CC3BB7BC3B4476E50D3AE9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170903 18:41:05-!- Kwandulin [~Kwandulin@p200300E453CC3BF7BC3B4476E50D3AE9.dip0.t-ipconnect.de] has quit [Ping timeout: 255 seconds]
20170903 18:46:25-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has joined #wesnoth-dev
20170903 18:50:40-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has quit [Remote host closed the connection]
20170903 18:53:50-!- Kwandulin2 [~Kwandulin@p200300E453CC3BB7BC3B4476E50D3AE9.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170903 19:24:44-!- irker803 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170903 19:29:44-!- sevu [~Shiki@p54856C0A.dip0.t-ipconnect.de] has quit [Quit: Verlassend]
20170903 19:38:21-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has joined #wesnoth-dev
20170903 20:06:44-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has quit [Remote host closed the connection]
20170903 20:07:02-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has joined #wesnoth-dev
20170903 20:07:12-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has quit [Remote host closed the connection]
20170903 20:16:09-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has joined #wesnoth-dev
20170903 20:22:41< mattsc> Hey zookeeper: is there any more AI work that you are aware of that should be done before 1.14?
20170903 20:23:00< mattsc> I am not, but I have been semi-unactive for so long I might be missing something.
20170903 20:25:22-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has quit [Remote host closed the connection]
20170903 20:32:43< zookeeper> mattsc, nothing critically important comes to mind
20170903 20:33:06-!- irker594 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170903 20:33:06< irker594> wesnoth: gfgtdf wesnoth:master c14f8160e556 / src/wesnothd_connection.hpp: add a comment about wesnothd_connection_ptr https://github.com/wesnoth/wesnoth/commit/c14f8160e556b5ff2185e8cf3bd3f60a54b98197
20170903 20:34:09-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170903 20:36:57< mattsc> zookeeper: okay, good
20170903 20:37:10-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170903 20:37:32< mattsc> I am desperately trying to get my Fred AI to a more generally usable state by then, but I am not sure that I’ll make it.
20170903 20:41:27< celticminstrel> By when?
20170903 20:41:37< celticminstrel> Oh, by 1.14.
20170903 20:42:29-!- The_Unforgiven [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20170903 20:42:30-!- The_Unforgiven_ [~quassel@2601:40a:c380:462:7c73:b82f:a889:9196] has joined #wesnoth-dev
20170903 20:52:19-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20170903 20:52:43< mattsc> celticminstrel: right.  It’s just really slow going (I am back to problems that I was not able to solve previously) and my time’s still quite limited.
20170903 20:55:55-!- The_Unforgiven_ [~quassel@2601:40a:c380:462:7c73:b82f:a889:9196] has quit [Ping timeout: 246 seconds]
20170903 20:55:55-!- The_Unforgiven [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Ping timeout: 246 seconds]
20170903 21:02:29-!- saran [~saran@91.228.34.14] has joined #wesnoth-dev
20170903 21:11:11-!- travis-ci [~travis-ci@ec2-54-145-11-136.compute-1.amazonaws.com] has joined #wesnoth-dev
20170903 21:11:12< travis-ci> wesnoth/wesnoth#14879 (master - c14f816 : gfgtdf): The build has errored.
20170903 21:11:12< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/271471183
20170903 21:11:12-!- travis-ci [~travis-ci@ec2-54-145-11-136.compute-1.amazonaws.com] has left #wesnoth-dev []
20170903 21:12:38-!- saran [~saran@91.228.34.14] has quit [Ping timeout: 240 seconds]
20170903 21:22:59-!- saran [~saran@91.228.34.14] has joined #wesnoth-dev
20170903 21:24:32-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170903 21:37:44-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170903 21:42:46-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20170903 21:43:29-!- Duthlet [~Duthlet@ipservice-092-211-211-035.092.211.pools.vodafone-ip.de] has quit [Quit: leaving]
20170903 21:43:32-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Ping timeout: 260 seconds]
20170903 22:15:02-!- markus_ [~mjs-de@x4e313418.dyn.telefonica.de] has quit [Remote host closed the connection]
20170903 22:23:28-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Remote host closed the connection]
20170903 22:24:33-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 248 seconds]
20170903 22:26:01-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev
20170903 22:40:13-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has joined #wesnoth-dev
20170903 22:42:28< vultraz_iOS> not sure why my change to get rid of the reference to pointers causes crashes
20170903 22:43:00-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170903 22:44:25-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has quit [Ping timeout: 246 seconds]
20170903 23:13:16< DeFender1031> could it be the transferring of ownership of the pointer from one instance to another, like celticminstrel said?
20170903 23:29:19< gfgtdf> vultraz_iOS: well with odl approach a change to the original pointer woudl also reflect to the parmater of unit_killed, but since your commit it passes the pointer by copy so if the original pointer would be changed, the parameter of unit_killed woudl will point to the old (possibly deleted object)
20170903 23:32:30< celticminstrel> I don't see any places where the function assigned to the two pointer arguments.
20170903 23:33:05-!- irker594 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170903 23:34:36< gfgtdf> celticminstrel: it doesn't, but the originaly objects maybe be changed by a different function. 
20170903 23:34:43< gfgtdf> original*
20170903 23:34:54< celticminstrel> Like?
20170903 23:35:15< celticminstrel> Can you see anything in the code that suggests removing the reference would cause problems?
20170903 23:36:41< gfgtdf> celticminstrel: yes
20170903 23:38:17< celticminstrel> Where?
20170903 23:39:36< gfgtdf> the prameters point to a_stats_/d_stats_ and those get changed rather often, now of you remove the references the paramters won't be updated automicailly.
20170903 23:40:44-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has joined #wesnoth-dev
20170903 23:40:55< celticminstrel> They're pointers. How will they not be updated automatically?
20170903 23:43:14< celticminstrel> I don't see a single reference to either variable where the removal of the reference would make a difference.
20170903 23:43:35< celticminstrel> The only type of reference that would fail with the change is if you did something like "attacker_stats = something new:.
20170903 23:43:39< celticminstrel> ^"
20170903 23:45:53-!- saran [~saran@91.228.34.14] has quit [Remote host closed the connection]
20170903 23:46:34-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has quit [Ping timeout: 264 seconds]
20170903 23:46:43-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
--- Log closed Mon Sep 04 00:00:39 2017