--- Log opened Mon Sep 04 00:00:39 2017
20170904 00:20:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170904 00:20:35-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170904 00:43:13-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170904 00:47:27-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Ping timeout: 248 seconds]
20170904 00:58:00-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170904 00:58:06-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170904 01:00:07-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 260 seconds]
20170904 01:07:37-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170904 01:07:44-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170904 01:18:13-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170904 01:20:20-!- gfgtdf_ [~chatzilla@x4e369333.dyn.telefonica.de] has joined #wesnoth-dev
20170904 01:23:05-!- gfgtdf [~chatzilla@x4e369076.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170904 01:23:16-!- gfgtdf_ is now known as gfgtdf
20170904 01:35:06-!- gfgtdf [~chatzilla@x4e369333.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 55.0.3/20170824053622]]
20170904 01:56:51 * celticminstrel wonders if zookeeper looked at doofus's alternate campaign wreaths.
20170904 02:14:56-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170904 02:16:56-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170904 02:35:12-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has joined #wesnoth-dev
20170904 02:54:45-!- Kwandulin [~Kwandulin@p200300E453CC3BB7BC3B4476E50D3AE9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170904 03:00:44-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20170904 03:27:28-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20170904 03:27:33-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170904 03:27:38-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has quit [Remote host closed the connection]
20170904 03:28:15-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170904 03:28:22-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Client Quit]
20170904 03:29:08-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170904 03:30:34-!- Kwandulin [~Kwandulin@p200300E453CC3BB7BC3B4476E50D3AE9.dip0.t-ipconnect.de] has quit [Quit: [endlevel]]
20170904 03:31:40-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Client Quit]
20170904 04:22:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170904 04:22:41-!- janebot_ [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170904 04:22:41-!- janebot_ is now known as janebot
20170904 04:33:52-!- Bonobo [~Bonobo@61.68.158.162] has joined #wesnoth-dev
20170904 04:39:09-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170904 05:34:54-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170904 05:37:46-!- irker075 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170904 05:37:46< irker075> wesnoth: Charles Dang wesnoth:master a3d5b9d60308 / src/actions/attack.cpp: Minor fixup to e8c7d72 https://github.com/wesnoth/wesnoth/commit/a3d5b9d603083ab0f3afcfbc9fc4c2432bb1623e
20170904 05:37:46< irker075> wesnoth: Charles Dang wesnoth:master f47d78ddb2d7 / src/actions/attack.cpp: Revert "Actions/Attack: refactored out some reference-to-pointer mumbo-jumbo" https://github.com/wesnoth/wesnoth/commit/f47d78ddb2d7126db3e25603ec67ce98cbd767a9
20170904 05:37:47< irker075> wesnoth: Charles Dang wesnoth:master 874ba1be7c51 / src/actions/attack.cpp: Actions/Attack: cleaned up a few minor things https://github.com/wesnoth/wesnoth/commit/874ba1be7c51065aa58728054805481a570757ed
20170904 06:07:01< zookeeper> vultraz_iOS, the campaign difficulty menu always uses the golden laurel when marking the levels on which you've beaten the campaign with. known?
20170904 06:07:23< vultraz_iOS> uhhh
20170904 06:07:25< vultraz_iOS> elaborate
20170904 06:07:50< zookeeper> the campaign difficulty menu shows a laurel on each difficulty level you've beaten.
20170904 06:08:00< zookeeper> as, i assume, it should.
20170904 06:08:09< zookeeper> but, it always uses the golden laurel.
20170904 06:08:14< vultraz_iOS> ah
20170904 06:08:18< vultraz_iOS> seems like oversight
20170904 06:08:20< vultraz_iOS> talk to celmin
20170904 06:08:53< zookeeper> also, credits don't work
20170904 06:09:42< vultraz_iOS> ?
20170904 06:09:47< vultraz_iOS> what do they not do
20170904 06:10:13< zookeeper> show any of the credits text, at least
20170904 06:11:06< vultraz_iOS> does for me
20170904 06:11:58< zookeeper> oh? i compiled yesterday.
20170904 06:12:06< shadowm> Let me guess: the issue where they stop working when you have too many credits entries (e.g. because of the number of add-ons with credits you've got installed) isn't fixed yet?
20170904 06:12:19< zookeeper> worth a try...
20170904 06:12:55< zookeeper> yeah, that's it
20170904 06:14:19< vultraz_iOS> jesus christ, man
20170904 06:14:23< vultraz_iOS> you have THAT many addons O_O
20170904 06:14:28< vultraz_iOS> it goes up to 60,000 pixels
20170904 06:14:39< shadowm> Too many credits *entries*.
20170904 06:14:59< shadowm> Mainline + a few add-ons could easily reach that limit.
20170904 06:15:07< vultraz_iOS> yes but jyrki fixed that
20170904 06:15:14< vultraz_iOS> but allowing up to 2 surfaces
20170904 06:15:52< zookeeper> i have 12 add-ons, a bunch of them without any credits even
20170904 06:18:04< zookeeper> (in fact, only 3 with credits)
20170904 06:19:25-!- travis-ci [~travis-ci@ec2-54-145-11-136.compute-1.amazonaws.com] has joined #wesnoth-dev
20170904 06:19:26< travis-ci> wesnoth/wesnoth#14881 (master - 874ba1b : Charles Dang): The build has errored.
20170904 06:19:26< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/271562302
20170904 06:19:26-!- travis-ci [~travis-ci@ec2-54-145-11-136.compute-1.amazonaws.com] has left #wesnoth-dev []
20170904 06:21:06< vultraz_iOS> the hell, then
20170904 06:38:20-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20170904 06:42:19< JyrkiVesterinen> zookeeper: If you exceed the now-doubled surface height limit, the game will now crash by throwing an unhandled exception.
20170904 06:42:35< JyrkiVesterinen> Credit text disappearing shouldn't be possible.
20170904 06:44:48-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170904 06:46:26< zookeeper> could i be missing some newer dll's or something?
20170904 06:46:42< zookeeper> or, rather, could that in any conceivable way cause the text to not show up
20170904 06:48:22< JyrkiVesterinen> Yes, it's actually a possible explanation.
20170904 06:48:45< JyrkiVesterinen> The surface splitting feature depends on Cairo detecting that the maximum surface size has been exceeded.
20170904 06:49:03< JyrkiVesterinen> That feature was introduced in Cairo 1.10; older versions fail silently.
20170904 06:50:58-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has joined #wesnoth-dev
20170904 06:58:55< zookeeper> all right
20170904 07:04:24< zookeeper> oh duh, i just realized i had some of those text-related local changes that i needed to make things compile...
20170904 07:04:51-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has quit [Remote host closed the connection]
20170904 07:06:15< zookeeper> and yeah that was it :>
20170904 07:06:42< zookeeper> false alarm
20170904 07:34:37< irker075> wesnoth: Jyrki Vesterinen wesnoth:1.12 4e16a5841dca / src/filesystem_boost.cpp: Fixed: filesystem::get_exe_dir() returned a wrong directory on Windows https://github.com/wesnoth/wesnoth/commit/4e16a5841dca7ca09d10dcb6b6c08db98dd00030
20170904 07:35:19< JyrkiVesterinen> (Wedge009 pushed that commit to 1.12, I didn't even know he was going to do that.)
20170904 07:35:40< wedge009> Aye, I did. Sorry, is that bad? I'd rather you get credit for it.
20170904 07:35:53< wedge009> https://github.com/wesnoth/wesnoth/issues/1929
20170904 07:36:41< JyrkiVesterinen> Well, I just wanted to clarify. Otherwise other developers might have assumed that I pushed it, asked me why, etc.
20170904 07:37:18< wedge009> How dare you fix stuff! :p
20170904 07:37:21< wedge009> Well, sure, okay.
20170904 08:04:31-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Quit: nurupo]
20170904 08:05:03-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20170904 08:10:24< zookeeper> do we have the means of easily rendering text monospaced? like if you want FPS counter values and labels to align nicely.
20170904 08:11:01< vultraz_iOS> not that label
20170904 08:12:10< zookeeper> there is some code for sans serif and monospace, but they're not explicitly getting set anywhere so i have no examples to work off of.
20170904 08:12:57-!- aeth_ [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20170904 08:14:37-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 240 seconds]
20170904 08:15:34< JyrkiVesterinen> Turn on Pango markup and wrap the text like this: <tt>05/10/20 ms</tt>
20170904 08:18:42< zookeeper> well, that was easy O.o
20170904 08:21:22< zookeeper> perfect, thanks
20170904 08:21:39-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20170904 08:21:39-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Killed (verne.freenode.net (Nickname regained by services))]
20170904 08:21:39-!- Necrosporus_ is now known as Necrosporus
20170904 08:23:45-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20170904 08:26:50< zookeeper> AI0867, i got the padding figured out
20170904 08:34:34< zookeeper> now, the question is, what all should the counter display. as nice as the current FPS-based-on-frame-durations thing is for gauging how well things perform, the actual rendered-FPS should be displayed too if it's now capped to the screen refresh rate.
20170904 08:35:47< JyrkiVesterinen> Wesnoth itself doesn't cap the rendered-FPS. The graphics compositor (on Windows, the Desktop Window Manager) does it.
20170904 08:36:01< zookeeper> oh? right, i thought you had wesnoth itself do it.
20170904 08:36:22< JyrkiVesterinen> And Wesnoth doesn't know what the rendered-FPS is.
20170904 08:36:59< zookeeper> so wesnoth still might actually mindlessly render 333 frames per second, even if only a fifth will end up on-screen?
20170904 08:37:06< JyrkiVesterinen> Yes.
20170904 08:37:09< zookeeper> righty
20170904 08:38:15< zookeeper> why/how doesn't it max out a single core then?
20170904 08:38:35< zookeeper> that was discussed a while ago and i feel like i should remember some details
20170904 08:39:12< JyrkiVesterinen> Because Wesnoth does have its own capper. It introduces a delay to every frame, while trying to not miss any display frames.
20170904 08:40:32< AI0867> zookeeper: sure, I can do that
20170904 08:41:03< zookeeper> AI0867, scroll further down :p
20170904 08:41:22< AI0867> oh, I see
20170904 08:41:46< zookeeper> JyrkiVesterinen, i somehow managed to form an impression that that was one of the things improved recently, but i guess not
20170904 08:42:16< JyrkiVesterinen> Wesnoth's capper is indeed what I rewrote. The old capper was way too aggressive and had other issues as well.
20170904 08:42:41< JyrkiVesterinen> The capper rewrite is tha main reason for the recent performance improvement.
20170904 08:43:17< AI0867> JyrkiVesterinen: so what is the behaviour now?
20170904 08:43:51< JyrkiVesterinen> Old one: subtract the frametime of the previous frame from 20 ms, wait the resulting time.
20170904 08:44:35< JyrkiVesterinen> New one: divide 1000 ms by the screen refresh rate. From the resulting frame budget, subtract the longest time among the last 50 frames. Wait the resulting time.
20170904 08:44:55-!- sevu [~Shiki@p54854F2F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170904 08:45:27< JyrkiVesterinen> Also, the new capper increases timer granularity to 1 ms on Windows. The old one was overshooting all the time, as the game might have asked to sleep for 1 ms and end up sleeping for 15 ms instead.
20170904 08:46:32< AI0867> So if one frame takes 50 ms, no sleeping happens in the following 50 frames?
20170904 08:47:07< JyrkiVesterinen> Yes. One frame takes 50 ms -> don't hold back for the next 50 frames, render as fast as possible.
20170904 08:47:46< AI0867> and on the test scenario I can easily cause a frame to take 40+ ms, even though the min and avg are (say) 11 and 16 ms
20170904 08:47:53< zookeeper> is that useful? why not still cap to screen refresh rate even after a slow frame?
20170904 08:48:13< zookeeper> like, sure, render the _next_ frame ASAP, but after that why go faster than the refresh rate?
20170904 08:48:46< AI0867> because the frame after that *might* take 30 ms to render, and you want it in 20 ms
20170904 08:49:01< AI0867> so any waiting will increase the delay
20170904 08:49:32< AI0867> we now basically make the assumption that laggy rendering happens in bursts of up to 50 frames
20170904 08:49:53< AI0867> or rather, bursts with up to 49 regular frames in between
20170904 08:50:28< zookeeper> well if the current frame took longer than 1000ms/refreshrate, then you wouldn't delay before drawing the next frame. if the next frame again takes longer, then you wouldn't delay after that, etc. i don't see the problem, but it's easy to see how i might be missing something :p
20170904 08:52:03< JyrkiVesterinen> zookeeper: The problem is that frametimes vary wildly because of software rendering. It might easily be that there is a slow frame, then 10 fast frames, then a slow frame again.
20170904 08:52:49< AI0867> in the case of 30-10-10-10-30, with a 20 ms budget, just looking at the previous frame causes the first and the last frame to be late, while looking at the past 50, causes just the first one to be late
20170904 08:52:50< JyrkiVesterinen> The only ways to avoid missing all slow frames are to either use a short delay on every frame, or somehow predict how long the next frame will take.
20170904 08:54:14< zookeeper> right, because a fast frame would cause a long delay, and if the next frame is a slow one then it'd be drawn late
20170904 08:55:34< zookeeper> makes sense
20170904 08:58:45< AI0867> but to get back to the earlier discussion, the FPS we are showing is the theoretical FPS, ignoring the fact that we may actually be sleeping?
20170904 08:59:59< JyrkiVesterinen> Yes. It ignores both sleeping and the fact that the compositor doesn't blit all the frames (and the display isn't even physically capable of showing them all).
20170904 09:00:16< JyrkiVesterinen> Having a meeting now, will be back after ~15 minutes.
20170904 09:00:16< AI0867> I don't think any FPS counters take the display into account
20170904 09:00:34< AI0867> or even the compositor
20170904 09:00:44< AI0867> just how often they managed to fill the buffer that second
20170904 09:11:59< zookeeper> might be enough to display that (as the average from the sampling period, which for the FPS counter is 10 frames now) and the worst value extrapolated from the slowest frame. does one have any particular reason to care about the theoretical best value?
20170904 09:22:42< JyrkiVesterinen> Right, it's possible to add a separate buffer for frametimes plus sleeping.
20170904 09:23:07< JyrkiVesterinen> And indeed, shortest frametimes aren't a very useful data point.
20170904 09:24:48-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20170904 09:24:48-!- Necrosporus is now known as Guest94048
20170904 09:24:48-!- Guest94048 [~Necrospor@unaffiliated/necrosporus] has quit [Killed (rajaniemi.freenode.net (Nickname regained by services))]
20170904 09:24:48-!- Necrosporus_ is now known as Necrosporus
20170904 09:46:31-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20170904 09:55:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170904 09:59:45< AI0867> or we could simply keep a pair of variables: unix timestamp + number of frames rendered since last update of the timestamp. Everytime a second passes, the number becomes the "actual FPS" and the counter is reset
20170904 10:00:17< AI0867> I might do that later today
20170904 10:00:37< AI0867> zookeeper: do you have your modified version somewhere where I can see it?
20170904 10:00:48< AI0867> or you could simply push it to master
20170904 10:01:19< zookeeper> yeah i guess i can do that
20170904 10:07:46< irker075> wesnoth: ln-zookeeper wesnoth:master d9f673ad653f / src/display.cpp: More detailed FPS counter showing min/avg/max FPS and frametime values https://github.com/wesnoth/wesnoth/commit/d9f673ad653fadfbeabd6706e6436d6900a12645
20170904 10:07:47< zookeeper> there
20170904 10:26:45< irker075> wesnoth: Severin Glöckner wesnoth:master 72d903440bb5 / data/campaigns/tutorial/scenarios/02_Tutorial_part_2.cfg: Tutorial part 2: resolving conflicting attack_end events https://github.com/wesnoth/wesnoth/commit/72d903440bb5c292141843355a71ad852c645b58
20170904 10:29:10< irker075> wesnoth: gfgtdf wesnoth:master c5454373b733 / src/game_config_manager.cpp: prevent crash in case of faulty WML in mainline content (#1899) https://github.com/wesnoth/wesnoth/commit/c5454373b7337a9a56fddf995b35154779950ce0
20170904 10:29:13-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20170904 10:29:28< vultraz_iOS> huh, that was by gfgtdf?
20170904 10:29:32< vultraz_iOS> i thought shiki
20170904 10:29:33< vultraz_iOS> oh well
20170904 10:30:03< irker075> wesnoth: Gregory A Lundberg wesnoth:master b7a42c495f6f / src/ (5 files in 3 dirs): Coverity Fixes - Uninitalized SDL_UserEvent timestamp field https://github.com/wesnoth/wesnoth/commit/b7a42c495f6ffdc56e64490d0b6cc861571c8f1d
20170904 10:31:35< JyrkiVesterinen> AI0867: why a Unix timestamp? std::chrono::time_point would be a more modern option.
20170904 10:32:25< vultraz_iOS> AI0867? that commit is by tad
20170904 10:32:47< JyrkiVesterinen> I was referring to this:
20170904 10:32:48< JyrkiVesterinen> 20170904 09:59:45< AI0867> or we could simply keep a pair of variables: unix timestamp + number of frames rendered since last update of the timestamp. Everytime a second passes, the number becomes the "actual FPS" and the counter is reset
20170904 10:32:51< vultraz_iOS> oh
20170904 10:47:58-!- gfgtdf [~chatzilla@x4e369333.dyn.telefonica.de] has joined #wesnoth-dev
20170904 10:58:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170904 11:00:07-!- travis-ci [~travis-ci@ec2-54-159-57-52.compute-1.amazonaws.com] has joined #wesnoth-dev
20170904 11:00:08< travis-ci> wesnoth/wesnoth#14883 (master - d9f673a : ln-zookeeper): The build has errored.
20170904 11:00:08< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/271625611
20170904 11:00:08-!- travis-ci [~travis-ci@ec2-54-159-57-52.compute-1.amazonaws.com] has left #wesnoth-dev []
20170904 11:08:04-!- atarocch [~atarocch@93.56.164.28] has quit [Remote host closed the connection]
20170904 11:09:17-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20170904 11:18:13-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20170904 11:18:19-!- aeth_ [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 246 seconds]
20170904 11:19:16-!- travis-ci [~travis-ci@ec2-54-145-11-136.compute-1.amazonaws.com] has joined #wesnoth-dev
20170904 11:19:17< travis-ci> wesnoth/wesnoth#14884 (master - c545437 : gfgtdf): The build has errored.
20170904 11:19:17< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/271632209
20170904 11:19:17-!- travis-ci [~travis-ci@ec2-54-145-11-136.compute-1.amazonaws.com] has left #wesnoth-dev []
20170904 11:26:35< gfgtdf> travsi said i did a commit? Or is travis just really slow
20170904 11:27:53< JyrkiVesterinen> c545373b is this commit: https://github.com/wesnoth/wesnoth/commit/c5454373b7337a9a56fddf995b35154779950ce0
20170904 11:28:06-!- travis-ci [~travis-ci@ec2-54-145-11-136.compute-1.amazonaws.com] has joined #wesnoth-dev
20170904 11:28:07< travis-ci> wesnoth/wesnoth#14885 (master - b7a42c4 : Gregory A Lundberg): The build has errored.
20170904 11:28:07< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/271632450
20170904 11:28:07-!- travis-ci [~travis-ci@ec2-54-145-11-136.compute-1.amazonaws.com] has left #wesnoth-dev []
20170904 11:28:13< JyrkiVesterinen> Vultraz merged it earlier today.
20170904 11:29:07< vultraz_iOS> less than an hour ago
20170904 11:45:47< sevu> gfgtdf, I set you as author for the PR from yesterday
20170904 12:15:49< AI0867> JyrkiVesterinen: sure, but we just need second-level accuracy here. Doesn't matter much which one we use
20170904 12:16:21< JyrkiVesterinen> I just wouldn't use Unix timestamps for anything unless we need one for some reason.
20170904 12:32:37< gfgtdf> ok
20170904 12:50:35< irker075> wesnoth: Charles Dang wesnoth:preprocessor_cleanup 3a44f582c8fe / src/serialization/preprocessor.cpp: [WIP] Preprocessor: move all relevant handling of contextual data into a pod str https://github.com/wesnoth/wesnoth/commit/3a44f582c8fe0bd579b1cd50c253a7ee0cc2615a
20170904 13:00:10-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170904 13:02:47< Necrosporus> I have found a way to crash wesnoth 1.12.6
20170904 13:03:36< JyrkiVesterinen> Have you checked if it works in 1.13?
20170904 13:06:50< Necrosporus> Well, for that I would need to know why it happens
20170904 13:07:13< JyrkiVesterinen> ...can't you just repeat the same steps with a 1.13 build?
20170904 13:09:14< Necrosporus> It doesn't happen
20170904 13:09:34< Necrosporus> JyrkiVesterinen, well, ok in 1.13 it doesn't crash
20170904 13:09:45< Necrosporus> But it does involve loading a save file
20170904 13:10:03< JyrkiVesterinen> OK. In that case I think we don't care much about the crash.
20170904 13:10:12< JyrkiVesterinen> Another 1.12 release is very unlikely.
20170904 13:14:29< Necrosporus> Weird, in 1.13 after I use droid command AI would ask what advancement I want anyway instead of selecting it itself
20170904 13:15:11< Necrosporus> I mean, I got a turn, then I use :droid and then AI would attack and get level and ask me what I wanted to pick
20170904 13:15:34< JyrkiVesterinen> mattsc: Do you know anything about that? ^
20170904 13:16:18-!- atarocch [~atarocch@93.56.164.28] has quit [Remote host closed the connection]
20170904 13:21:38-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20170904 13:36:24-!- travis-ci [~travis-ci@ec2-54-145-11-136.compute-1.amazonaws.com] has joined #wesnoth-dev
20170904 13:36:25< travis-ci> wesnoth/wesnoth#14886 (preprocessor_cleanup - 3a44f58 : Charles Dang): The build has errored.
20170904 13:36:25< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/271674066
20170904 13:36:25-!- travis-ci [~travis-ci@ec2-54-145-11-136.compute-1.amazonaws.com] has left #wesnoth-dev []
20170904 13:40:38< mattsc> JyrkiVesterinen: no, nothing at all, sorry.  Sounds like something that gfgtdf might know about, maybe.
20170904 13:45:03-!- atarocch [~atarocch@93.56.164.28] has quit [Ping timeout: 248 seconds]
20170904 13:45:31< irker075> wesnoth: Severin Glöckner wesnoth:master 45e8712ecd66 / data/campaigns/tutorial/scenarios/02_Tutorial_part_2.cfg: Tutorial: This event didn't fit the sorceress. https://github.com/wesnoth/wesnoth/commit/45e8712ecd662a4944445fe7f1b7b1299b4bb463
20170904 13:57:22< Necrosporus> Shouldn't there be some advancements of the leader in tutorial?
20170904 13:57:40< Necrosporus> Since in real game it's important to advance the leader
20170904 13:57:49< gfgtdf> Necrosporus: we coudl probably change that, but then when you droid a side some people might still want that the some important decisitions is left to them
20170904 13:58:22< Necrosporus> Why do you think people want to droid a side?
20170904 13:58:41< Necrosporus> In my case I wanted to see who will win
20170904 13:58:42< gfgtdf> Necrosporus: becasiue they have a insane advantage that even the ai coudl win the scenairo.
20170904 13:59:10< Necrosporus> In my case I was using it while analysing my last mp game
20170904 13:59:25< Necrosporus> In 1.12 this command crashes the game... weird
20170904 13:59:31< Necrosporus> I have saved from replay
20170904 14:00:00< Necrosporus> Then loaded and tried to use droid command
20170904 14:00:42< Necrosporus> gfgtdf, I think either AI should deside itself or it should be an option in preferences
20170904 14:01:39< Necrosporus> Another thing, when I load mp game save in normal way the game complains
20170904 14:01:55< gfgtdf> Necrosporus: that's probably also 1.12 specific
20170904 14:02:09< Necrosporus> What?
20170904 14:02:15< Necrosporus> Complain? Nope
20170904 14:02:25< gfgtdf> it still complains in 1.13 ?
20170904 14:02:56< Necrosporus> Wait...
20170904 14:03:08< Necrosporus> The problem is that I do not have any mp saves from 1.13
20170904 14:03:41< gfgtdf> Necrosporus: yopu can easily create one.
20170904 14:04:57< Necrosporus> OK, it doesn't complain if I save from local mp game and then load normally
20170904 14:11:20-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20170904 14:16:04< irker075> wesnoth: Charles Dang wesnoth:master 5dd7a16133e3 / src/ai/default/attack.cpp: Fixup 19bbfed (forgot to remove a now-unused variable) https://github.com/wesnoth/wesnoth/commit/5dd7a16133e3a076bde012010687b11bf93b8f8d
20170904 14:30:26-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170904 14:33:56< JyrkiVesterinen> I figured out #1941: https://github.com/wesnoth/wesnoth/issues/1941#issuecomment-326977242
20170904 14:35:53< Necrosporus> {TALK_ABOUT_LOC 18,13 ( _ "Don’t forget about that last village near the channel. The orcs will capture it if they try to sneak around via the ford! It will be hard to dislodge them if they do.")}
20170904 14:35:53< Necrosporus> Maybe this one shouldn't trigger if you have captured that image by the time or already have troops near it?
20170904 14:36:08-!- gfgtdf [~chatzilla@x4e369333.dyn.telefonica.de] has quit [Remote host closed the connection]
20170904 14:36:15< Necrosporus> I did see this message, while I was already protecting that bank
20170904 14:37:37< irker075> wesnoth: Charles Dang wesnoth:master d827a326e16e / src/ai/default/attack.cpp: Fixup 19bbfed again (fixs bug #1941) https://github.com/wesnoth/wesnoth/commit/d827a326e16e62c6dfce90ac8378831f2897f62a
20170904 14:39:58-!- shiki [~Shiki@p54854F2F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170904 14:39:58-!- sevu [~Shiki@p54854F2F.dip0.t-ipconnect.de] has quit [Disconnected by services]
20170904 14:40:00-!- shiki [~Shiki@p54854F2F.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20170904 14:40:14-!- sevu [~Shiki@p54854F2F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170904 14:40:19< vultraz_iOS> GDI
20170904 14:43:52< Necrosporus> message= _ "That... was foolish. Next time I should be more careful."
20170904 14:43:59< Necrosporus> Leader death dialog in tutorial
20170904 14:44:06< Necrosporus> So... There is a next time?
20170904 14:44:14-!- travis-ci [~travis-ci@ec2-54-145-11-136.compute-1.amazonaws.com] has joined #wesnoth-dev
20170904 14:44:15< travis-ci> wesnoth/wesnoth#14889 (master - 45e8712 : Severin Glöckner): The build has errored.
20170904 14:44:15< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/271695405
20170904 14:44:15-!- travis-ci [~travis-ci@ec2-54-145-11-136.compute-1.amazonaws.com] has left #wesnoth-dev []
20170904 14:44:16< Necrosporus> When the leader died
20170904 14:48:05< Necrosporus> By the way, while units of one side can move through each other, there's no way to swap two units without having a vacant cell
20170904 14:48:19< Necrosporus> Maybe it should be possible?
20170904 14:48:33< Necrosporus> logically the should be able to switch places
20170904 14:52:03-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20170904 14:57:20< sevu> I think that won't happen... makes things more complicated
20170904 14:57:52< sevu> As for the talk_about_loc, will change that next
20170904 14:58:29< sevu> thanks for reporting, feel free to tell if you find more of such things
20170904 14:59:31< sevu> about the message when dying, I think it's ok, because you maybe want to try it again. What would be an alternative text?
20170904 15:00:21< Necrosporus> sevu, I mean it's a bit illogical that dying student says that
20170904 15:00:33< Necrosporus> The student is dead, orcs are real ,right?
20170904 15:00:40< Necrosporus> by the plot of tutorial
20170904 15:01:03< Necrosporus> or they were some illusory orcs conjured by Delfador?
20170904 15:01:38< Necrosporus> Another thing, I cannot see games of others in multiplayer wesnoth-master
20170904 15:02:12< Necrosporus> vultraz_iOS, was it fixed recently or not? It seems that not only the server won't log me out it won't also show gaes or create new ones
20170904 15:02:28< vultraz_iOS> it was fixed in master
20170904 15:02:38< Necrosporus> OK, will update them
20170904 15:02:52< Necrosporus> is master supposed to be able to play with .8 ?
20170904 15:04:43< sevu> I don't see it as completely wrong, but if you have a better suggestion, why not.
20170904 15:06:43< sevu> I think it's compatible with .8, thought I don't know for sure
20170904 15:13:25< Necrosporus> "That... was foolish. Next time you should be more careful."
20170904 15:13:39< Necrosporus> sevu, simples is s/I/you/
20170904 15:13:53< Necrosporus> There is no other time for this particular student, but it could be for player?
20170904 15:14:23< Necrosporus> That's smallest edit I can think of
20170904 15:16:46< sevu> No need to be small, but sounds good. 
20170904 15:29:47< sevu> Ran out of memory. Aborted. <--- what?
20170904 15:33:21-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170904 15:35:39-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has joined #wesnoth-dev
20170904 15:36:28-!- travis-ci [~travis-ci@ec2-54-145-11-136.compute-1.amazonaws.com] has joined #wesnoth-dev
20170904 15:36:29< travis-ci> wesnoth/wesnoth#14890 (master - 5dd7a16 : Charles Dang): The build has errored.
20170904 15:36:29< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/271709063
20170904 15:36:29-!- travis-ci [~travis-ci@ec2-54-145-11-136.compute-1.amazonaws.com] has left #wesnoth-dev []
20170904 15:39:20< zookeeper> the message is just fine as-is. s/I/you makes it worse.
20170904 15:43:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170904 15:52:58< irker075> wesnoth: Severin Glöckner wesnoth:master 92d74f744c04 / data/campaigns/tutorial/scenarios/02_Tutorial_part_2.cfg: Tutorial: Don't show this message if the village has already been captured. https://github.com/wesnoth/wesnoth/commit/92d74f744c049e3d1b13a9a5d105fd310d55593c
20170904 15:54:50< Soliton> Necrosporus: master and latest dev version will connect to different servers.
20170904 16:03:30-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170904 16:05:21-!- gfgtdf [~chatzilla@x4e369333.dyn.telefonica.de] has joined #wesnoth-dev
20170904 16:17:02-!- atarocch [~atarocch@93.56.164.28] has quit [Remote host closed the connection]
20170904 16:18:08-!- Kwandulin [~Kwandulin@p200300E453CC3BB7BC3B4476E50D3AE9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170904 16:19:04-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20170904 16:30:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170904 16:30:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170904 16:33:15< irker075> wesnoth: Charles Dang wesnoth:master 7cef972836a8 / src/ai/default/attack.cpp: Second attempt to fix bug #1941 https://github.com/wesnoth/wesnoth/commit/7cef972836a82decf6ab2fe923d7dd665dd4c758
20170904 16:38:42< celticminstrel> I think this might actually be a good place to use the aliasing constructor of shared_ptr.
20170904 16:39:01< celticminstrel> Basically make bc and prev_def both be shared_ptr instead of a unique_ptr and raw ptr respectively.
20170904 16:39:35< celticminstrel> Mind you, if that commit works, then I'm also fine with just leaving it like that.
20170904 16:41:21< JyrkiVesterinen> I prefer that unique_ptr is used whenever possible and shared_ptr only when necessary.
20170904 16:43:41< vultraz_iOS> yeah
20170904 16:43:46< vultraz_iOS> it makes code easier to read
20170904 16:43:47< DeFender1031> I think I has the solution! Any time anyone needs to pass a pointer to a function, the function should should take as its parameter a unique_ptr which points to address of the unique_ptr being passed in. Pointerception! (hastagNotHelping)
20170904 16:43:53< vultraz_iOS> since you know something is supposed to be unique
20170904 16:44:16< celticminstrel> ...
20170904 16:44:31< celticminstrel> I don't really think it makes the code any easier to read, but whatever.
20170904 16:45:05< DeFender1031> celticminstrel, maybe not easier to read, but it certainly documents and enforces the expectation.
20170904 16:46:44< JyrkiVesterinen> What is supposed to be unique is the ownership of the battle_context. In this case, the context is owned first by bc, then by old_bc.
20170904 16:57:17-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has quit [Remote host closed the connection]
20170904 17:10:47< sevu> Are red, green, blue= for [print] deprecated or did this change? Just asking because I came along in the wiki.
20170904 17:12:13< celticminstrel> ISTR that there was a move to unify how colors are represented in various WML tags.
20170904 17:12:29< celticminstrel> So it's probably still deprecated, though I dunno if the deprecated message is being shown.
20170904 17:12:47< celticminstrel> It may have to be added back using the new functions.
20170904 17:14:23< sevu> with new functions you mean replacing red,blue,green= with color= ?
20170904 17:14:50< sevu> s/ red,blue,green/ red,green,blue/
20170904 17:15:53< DeFender1031> sevu, actually, because of how wml works, "red,green,blue" are valid in any order, so long as the parameters are given in the same order...
20170904 17:16:24< sevu> true, I remember
20170904 17:16:28< DeFender1031> you could also just as easily do "green,y,red,blue,x="
20170904 17:16:36< DeFender1031> (Though please don't. :P)
20170904 17:17:02< sevu> Still happy that nobody ever got the idea to use y,x=
20170904 17:20:53< sevu> I grepped for red,green,blue - they are used in a number of places which all can be sed replaced to color
20170904 17:28:09-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170904 17:28:15-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170904 17:32:47-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 246 seconds]
20170904 17:33:18-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20170904 17:44:30-!- travis-ci [~travis-ci@ec2-54-226-232-136.compute-1.amazonaws.com] has joined #wesnoth-dev
20170904 17:44:31< travis-ci> wesnoth/wesnoth#14892 (master - 7cef972 : Charles Dang): The build has errored.
20170904 17:44:31< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/271758424
20170904 17:44:31-!- travis-ci [~travis-ci@ec2-54-226-232-136.compute-1.amazonaws.com] has left #wesnoth-dev []
20170904 17:45:41< DeFender1031> sevu, "y,blue,type=" :P
20170904 17:54:01-!- Bonobo [~Bonobo@61.68.158.162] has quit [Ping timeout: 240 seconds]
20170904 17:54:26-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has joined #wesnoth-dev
20170904 17:57:02-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20170904 17:59:20-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has quit [Remote host closed the connection]
20170904 18:00:13-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has joined #wesnoth-dev
20170904 18:05:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20170904 18:05:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170904 18:05:34-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has quit [Remote host closed the connection]
20170904 18:06:54-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has joined #wesnoth-dev
20170904 18:10:21-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has quit [Remote host closed the connection]
20170904 18:10:54-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has joined #wesnoth-dev
20170904 18:12:43-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has quit [Remote host closed the connection]
20170904 18:13:00-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has joined #wesnoth-dev
20170904 18:14:04-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has quit [Remote host closed the connection]
20170904 18:14:36-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has joined #wesnoth-dev
20170904 18:15:15-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has quit [Remote host closed the connection]
20170904 18:15:23-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has joined #wesnoth-dev
20170904 18:30:53-!- higgins` [~higgins@68.ip-149-56-14.net] has joined #wesnoth-dev
20170904 18:36:53-!- Elsi_ [~Elsi@luwin.ulrar.net] has joined #wesnoth-dev
20170904 18:37:42-!- Netsplit *.net <-> *.split quits: higgins, Greg_Boggs[m], Elsi, ChipmunkV[m]
20170904 18:40:34-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has quit [Remote host closed the connection]
20170904 18:41:08-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has joined #wesnoth-dev
20170904 18:42:07-!- TC01 [~quassel@venus.arosser.com] has quit [Quit: No Ping reply in 180 seconds.]
20170904 18:42:37-!- TC01 [~quassel@venus.arosser.com] has joined #wesnoth-dev
20170904 18:45:16-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has quit [Ping timeout: 246 seconds]
20170904 18:46:43-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170904 18:48:44-!- Kwandulin [~Kwandulin@p200300E453CC3BB7BC3B4476E50D3AE9.dip0.t-ipconnect.de] has quit [Ping timeout: 255 seconds]
20170904 18:48:48-!- ChipmunkV[m] [chipmunkvm@gateway/shell/matrix.org/x-vibkotsnnyvbulds] has joined #wesnoth-dev
20170904 18:48:54-!- Greg_Boggs[m] [gregboggsm@gateway/shell/matrix.org/x-thqefrojydydnprm] has joined #wesnoth-dev
20170904 18:49:59-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170904 19:06:54< irker075> wesnoth: Ignacio R. Morelle wesnoth:master 5124b2b6269a / data/tools/addon_manager/html.py: wam: Full refactor/reformatting of the HTML writer module https://github.com/wesnoth/wesnoth/commit/5124b2b6269acf207feed654aa45d766823e02af
20170904 19:06:57< irker075> wesnoth: Ignacio R. Morelle wesnoth:master 10b175a73feb / data/tools/addon_manager/html.py: wam: Percent-encode add-on tarball names https://github.com/wesnoth/wesnoth/commit/10b175a73feb704d625a6cd108a8d29d23f91e2e
20170904 19:11:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 246 seconds]
20170904 19:11:59-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170904 19:25:03-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170904 19:25:48< irker075> wesnoth: Charles Dang wesnoth:master 9efe22989af6 / src/units/types.cpp: Unit/Type: formatting cleanup https://github.com/wesnoth/wesnoth/commit/9efe22989af60b1fb2d3ab30a988aa3b55fb1fd8
20170904 19:25:51< irker075> wesnoth: Charles Dang wesnoth:master 23e68633dac0 / src/units/map.hpp: Units/Map: added an empty() function https://github.com/wesnoth/wesnoth/commit/23e68633dac026324c48573d21553e3ef508f261
20170904 19:25:54< irker075> wesnoth: Charles Dang wesnoth:master 2eacb4e1c3c9 / src/ (25 files in 12 dirs): Use !std::string::empty() for string-is-not-empty comparisons https://github.com/wesnoth/wesnoth/commit/2eacb4e1c3c9a14d85aa1602ddc6b248441ed7fa
20170904 19:25:57< irker075> wesnoth: Charles Dang wesnoth:master 542f65d2a7bb / src/ (20 files in 11 dirs): Use std::string::empty() for string-is-empty comparisons https://github.com/wesnoth/wesnoth/commit/542f65d2a7bb10dee0de7f3933fcf218c49a8d38
20170904 19:26:00< irker075> wesnoth: Charles Dang wesnoth:master f38f6ae51a16 / src/ (4 files in 4 dirs): Use !container::empty() for container-is-not-empty checks https://github.com/wesnoth/wesnoth/commit/f38f6ae51a16e1ed8ffcfad4d9a657360ee65c59
20170904 19:26:03< irker075> wesnoth: Charles Dang wesnoth:master 311223f32e65 / src/ (7 files in 6 dirs): Use container::empty() for container-is-empty checks https://github.com/wesnoth/wesnoth/commit/311223f32e65061fd8aac5869c599f8f756958b2
20170904 19:26:06< irker075> wesnoth: Charles Dang wesnoth:master 1de824c36ed0 / src/ (7 files in 6 dirs): Convert remaining NULLs to nullptrs https://github.com/wesnoth/wesnoth/commit/1de824c36ed0b8ca6191712ca479c9803ebd2e0a
20170904 19:26:16-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170904 19:38:43< sevu> when installing wesnoth, is there a reason why data/tools becomes installed, but not utils in the top level directory?
20170904 19:38:56-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has joined #wesnoth-dev
20170904 19:39:27< sevu> talking about scons / cmake install
20170904 19:48:26< irker075> wesnoth: Ignacio R. Morelle wesnoth:master 49bf9debbf7e / data/tools/addon_manager/html.py: wam: Add forum links provided by the add-ons server to the web index https://github.com/wesnoth/wesnoth/commit/49bf9debbf7e6805c1bfc834378fbf82f531b96b
20170904 20:03:10-!- stikonas_ is now known as stikonas
20170904 20:14:25-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has quit [Remote host closed the connection]
20170904 20:15:01-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has joined #wesnoth-dev
20170904 20:18:12< vultraz_iOS> seems it's possible to crash the game with the fps counter active
20170904 20:18:59< JyrkiVesterinen> Let me guess: minimum frametime reaches 0 ms and the code divides by zero?
20170904 20:19:29< vultraz_iOS> im not sure
20170904 20:19:34-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has quit [Ping timeout: 264 seconds]
20170904 20:19:34< vultraz_iOS> i just scroll the map in DID S1
20170904 20:20:20< vultraz_iOS> but yeah, since it happens at time of lag, probably
20170904 20:20:44< matthiaskrgr> vultraz_iOS: https://pastebin.com/UxxUp0Ey  
20170904 20:21:14< vultraz_iOS> ah, so it is
20170904 20:23:08< irker075> wesnoth: Ignacio R. Morelle wesmere:develop 13bbc4f946b1 / static/docroot/errors/500.xml: static: "Tweeting at At" doesn't sound right https://github.com/wesnoth/wesmere/commit/13bbc4f946b1eea45c882fbb11e2765a0182c99b
20170904 20:23:09< JyrkiVesterinen> Oh, right. Division by zero is UB, not a guaranteed crash.
20170904 20:23:10< irker075> wesnoth: Ignacio R. Morelle wesmere:develop 24992a3ea0a8 / static/Makefile static/docroot/errors/503.xml wesmere/img/misc/503-ladoc.png: static: Add generic 503 page https://github.com/wesnoth/wesmere/commit/24992a3ea0a8c1aeb5cdecd7d24d58bc633a848f
20170904 20:23:12< irker075> wesnoth: Ignacio R. Morelle wesmere:develop e819106262a9 / static/docroot/index.php wesmere/mw/skin.json wesmere/sass/_version.scss: Bump version https://github.com/wesnoth/wesmere/commit/e819106262a911d0c0ffb9b6bb924573659525fc
20170904 20:33:34-!- travis-ci [~travis-ci@ec2-54-196-188-78.compute-1.amazonaws.com] has joined #wesnoth-dev
20170904 20:33:35< travis-ci> wesnoth/wesnoth#14894 (master - 1de824c : Charles Dang): The build has errored.
20170904 20:33:35< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/271807566
20170904 20:33:35-!- travis-ci [~travis-ci@ec2-54-196-188-78.compute-1.amazonaws.com] has left #wesnoth-dev []
20170904 20:46:52< irker075> wesnoth: Jyrki Vesterinen wesnoth:master 3692cfa86b3e / changelog players_changelog src/display.cpp src/display.hpp: Redraw invalidated hexes once, not twice https://github.com/wesnoth/wesnoth/commit/3692cfa86b3e9eb89f1184c9f4b1820237e5cfa1
20170904 20:47:14< JyrkiVesterinen> This was easier than I thought. :)
20170904 21:12:44-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170904 21:14:53-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170904 21:15:26-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has joined #wesnoth-dev
20170904 21:15:56-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has quit [Remote host closed the connection]
20170904 21:16:04-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170904 21:17:03-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170904 21:17:39-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has joined #wesnoth-dev
20170904 21:19:06< shadowm> loonycyborg: Is there a particular reason you've not deleted the tarballs and xdeltas (not the checksums, I already said those have to remain) for previous development versions from files.w.o every time you've uploaded a new release?
20170904 21:19:25-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170904 21:19:54< loonycyborg> Is it really necessary to rm them?
20170904 21:20:19< loonycyborg> we have shortage of hdd space?
20170904 21:20:48< loonycyborg> I'm little unclear on our deletion policy
20170904 21:21:11< loonycyborg> I could forget if you told me
20170904 21:22:34-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:71c2:6ad9:4b46:83bc] has quit [Ping timeout: 264 seconds]
20170904 21:28:30< shadowm> loonycyborg: You know how the daily backup has to copy everything from scratch every time?
20170904 21:28:51< shadowm> I'll let you figure out the rest yourself.
20170904 21:29:06< loonycyborg> does it cover f.w.o?
20170904 21:29:13< shadowm> No.
20170904 21:29:14< shadowm> It covers everything.
20170904 21:29:42< shadowm> The only exceptions are specific known paths that contain either worthless garbage or temporary files. files.w.o does not belong in either category.
20170904 21:29:54< loonycyborg> I kinda though it would be incremental backup
20170904 21:30:11< loonycyborg> but anyway
20170904 21:30:21< loonycyborg> you want only development releases removed?
20170904 21:30:25< loonycyborg> or stable too?
20170904 21:31:06< shadowm> Tarballs and xdeltas for all non-current releases. The latest stable is current, so it ought to stay where it is.
20170904 21:31:35< loonycyborg> I suppose keeping them there isn't necessary since they're on sourceforge and can be reconstructed from git
20170904 21:31:41< shadowm> The reason I said development is that I know there's only files for the latest stable because I was in charge of that anyway.
20170904 21:31:57< loonycyborg> so
20170904 21:32:02< shadowm> They are there for packagers who receive that email you send every time there's a release.
20170904 21:32:21< shadowm> Instructing them on using git archive isn't necessarily productive or easy.
20170904 21:32:48< loonycyborg> I meant only previous versions
20170904 21:33:15< loonycyborg> so only last dev release and last stable release should be kept?
20170904 21:33:31< shadowm> Yes, because those are the current releases.
20170904 21:34:19< shadowm> In the event that we end up with three release branches then of course the same rule applies to the latest release from each branch, etc.
20170904 21:37:38-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170904 21:40:42< loonycyborg> shadowm: I removed them
20170904 21:45:23-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170904 21:46:13< zookeeper> oh, duh, divisions by zero indeed.
20170904 21:47:11-!- travis-ci [~travis-ci@ec2-54-226-232-136.compute-1.amazonaws.com] has joined #wesnoth-dev
20170904 21:47:12< travis-ci> wesnoth/wesnoth#14895 (master - 3692cfa : Jyrki Vesterinen): The build has errored.
20170904 21:47:12< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/271832074
20170904 21:47:12-!- travis-ci [~travis-ci@ec2-54-226-232-136.compute-1.amazonaws.com] has left #wesnoth-dev []
20170904 21:55:38-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170904 21:57:57-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170904 21:59:38-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170904 22:00:47-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20170904 22:15:23-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170904 22:39:26-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170904 22:53:12-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds]
20170904 22:56:03-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170904 23:07:54-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170904 23:17:19-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170904 23:46:54-!- irker075 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170904 23:47:03-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 252 seconds]
20170904 23:47:56-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20170904 23:58:11< Necrosporus> It seems that I cannot see games created by other wesnoth players in wesnoth-master from yesterday
20170904 23:59:55< Necrosporus> Am I doing something wrong?
--- Log closed Tue Sep 05 00:00:04 2017