--- Log opened Sun Sep 10 00:00:06 2017
--- Day changed Sun Sep 10 2017
20170910 00:00:06-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170910 00:01:55< zookeeper> anyway, you can do the same save-load-save thing in any scenario and you see some differences in the AI WML. those look like they wouldn't cause behavioral differences, but probably worth fixing anyway.
20170910 00:07:42< zookeeper> huh.
20170910 00:08:45< zookeeper> https://github.com/wesnoth/wesnoth/blob/master/data/ai/dev/idle_ai.cfg <- if i actually use that in the scenario, then that solves the problem
20170910 00:09:19< zookeeper> but in addition to what the comment there says, i guess the same thing happens when loading too?
20170910 00:11:07< zookeeper> the differences in the savefiles still seem to be the same, but the AI actually stays idle after loading.
20170910 00:11:24< zookeeper> anyways, off to bed ->
20170910 00:15:42-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 252 seconds]
20170910 00:18:33-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:c468:4d81:e3fa:1f05] has quit [Remote host closed the connection]
20170910 00:19:10-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:c468:4d81:e3fa:1f05] has joined #wesnoth-dev
20170910 00:21:15-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:c468:4d81:e3fa:1f05] has quit [Remote host closed the connection]
20170910 00:21:27-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170910 00:21:42-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170910 01:05:51-!- gfgtdf [~chatzilla@x4e36940a.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 55.0.3/20170824053622]]
20170910 01:26:50< celticminstrel> zookeeper, the stuff that's filled in if missing is basically just the [engine] tag for Lua, and the default aspect values.
20170910 01:34:50-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170910 02:54:52-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:14dc:e253:8d27:2c5a] has joined #wesnoth-dev
20170910 02:58:58-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:14dc:e253:8d27:2c5a] has quit [Ping timeout: 246 seconds]
20170910 03:00:49-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170910 03:07:23-!- Kwandulin [~Kwandulin@p200300E453CC3B09CCA57AB3091B92C5.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170910 03:09:16-!- irker213 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170910 03:09:16< irker213> wesnoth: Charles Dang wesnoth:master 10c7972de0ae / src/ (attack_prediction.cpp version.cpp): Used `assert(false)` instead of `assert(0)` https://github.com/wesnoth/wesnoth/commit/10c7972de0ae0aad3ea01afe6ffacf6e4f3e3c46
20170910 03:44:07-!- sevu [~Shiki@p54855FCD.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170910 03:50:18-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170910 03:50:23< sevu> Hey, check out the add-on server in master
20170910 03:53:08< vultraz_iOS> yes
20170910 03:53:09< vultraz_iOS> I know
20170910 03:54:31-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Ping timeout: 240 seconds]
20170910 04:22:24< sevu> Another thing is, when you want to place a unit with debug
20170910 04:22:55< sevu> there is the search box, but after every 1-2 letters it loses focus
20170910 04:23:12< vultraz_iOS> what??
20170910 04:23:38< sevu> shift + c in a scenario
20170910 04:23:55< vultraz_iOS> GAHHH
20170910 04:23:59< vultraz_iOS> FFS
20170910 04:24:02< vultraz_iOS> MORE BUGS
20170910 04:24:08< vultraz_iOS> MORE GODDAMN BUGS
20170910 04:24:19< sevu> it must be a new one
20170910 04:24:33< sevu> 4 days ago it must have been working
20170910 04:24:33< vultraz_iOS> yes
20170910 04:24:43< vultraz_iOS> bloody hell >_<
20170910 04:24:59< vultraz_iOS> i give up
20170910 04:25:08< vultraz_iOS> i try to do one thing and everything breaks
20170910 04:25:30< sevu> that's life
20170910 04:26:19< Kwandulin> Dunno, I got the feeling that Wesnoth is made great steps forward the last few weeks. The new dev release is already getting me excited
20170910 04:26:31< Kwandulin> -is
20170910 04:30:09< celticminstrel> What should I call the variable that indicates that a hotkey requires separate press and release?
20170910 04:32:06 * celticminstrel currently favours something containing the word "state" but hasn't quite decided exactly what.
20170910 04:32:28< vultraz_iOS> dual_state
20170910 04:32:58-!- travis-ci [~travis-ci@ec2-54-196-223-164.compute-1.amazonaws.com] has joined #wesnoth-dev
20170910 04:32:59< travis-ci> wesnoth/wesnoth#14943 (master - c298e70 : Jyrki Vesterinen): The build passed.
20170910 04:32:59< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/273591272
20170910 04:32:59-!- travis-ci [~travis-ci@ec2-54-196-223-164.compute-1.amazonaws.com] has left #wesnoth-dev []
20170910 04:35:48< DeFender1031> celticminstrel, I always favor the word "toggle" for such scenarios.
20170910 04:36:12< vultraz_iOS> or that
20170910 04:53:40< irker213> wesnoth: Gregory A Lundberg wesnoth:master b260cdc39983 / src/gui/dialogs/unit_list.cpp: Fix Coverity Warning: dead code https://github.com/wesnoth/wesnoth/commit/b260cdc3998348eb284377a048fe4d57f3407839
20170910 04:57:13-!- Kwandulin2 [~Kwandulin@pD9FD53A4.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170910 04:59:41-!- Kwandulin [~Kwandulin@p200300E453CC3B09CCA57AB3091B92C5.dip0.t-ipconnect.de] has quit [Ping timeout: 246 seconds]
20170910 05:02:24-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20170910 05:14:22-!- travis-ci [~travis-ci@ec2-54-196-21-106.compute-1.amazonaws.com] has joined #wesnoth-dev
20170910 05:14:23< travis-ci> wesnoth/wesnoth#14944 (master - 1eed7fb : gfgtdf): The build passed.
20170910 05:14:23< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/273594684
20170910 05:14:23-!- travis-ci [~travis-ci@ec2-54-196-21-106.compute-1.amazonaws.com] has left #wesnoth-dev []
20170910 05:30:30< shadowm> Well, this is great.
20170910 05:30:43< shadowm> https://pastebin.com/Dn7DET0G
20170910 05:31:10< shadowm> loonycyborg: Is this by any chance a side-effect of your decision to make campaignd use simple_wml?
20170910 05:32:04< shadowm> I guess I'll make a dummy .pbl to fulfill that support request.
20170910 05:33:07-!- sevu [~Shiki@p54855FCD.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20170910 05:36:14< vultraz_iOS> looks like this month really is lose-your-pbl month
20170910 05:42:00-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170910 05:56:25-!- travis-ci [~travis-ci@ec2-54-196-21-106.compute-1.amazonaws.com] has joined #wesnoth-dev
20170910 05:56:26< travis-ci> wesnoth/wesnoth#14945 (master - b6a70df : Jyrki Vesterinen): The build passed.
20170910 05:56:26< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/273608048
20170910 05:56:26-!- travis-ci [~travis-ci@ec2-54-196-21-106.compute-1.amazonaws.com] has left #wesnoth-dev []
20170910 06:01:01< loonycyborg> shadowm: perhaps, that sounds like something simple_wml would do
20170910 06:01:25< vultraz_iOS> why is simple_wml even a thing
20170910 06:01:53< loonycyborg> ask dave
20170910 06:02:02< vultraz_iOS> hey, you're the server guy
20170910 06:02:07< vultraz_iOS> if you wanted you could make it use JSON
20170910 06:02:46< JyrkiVesterinen> I think such huge refactoring wouldn't be good use of anyone's time...
20170910 06:03:45< loonycyborg> this is side effect of me making wesnothd and campaignd share a lot of code
20170910 06:05:01< loonycyborg> I dunno, I could add support for this shared layer using client's wml
20170910 06:05:11< loonycyborg> or maybe even drop simple_wml everywhere
20170910 06:19:39< shadowm> Or you could fix wesnoth_addon_manager since you know Python. :p
20170910 06:20:37< shadowm> Even if it's not an approach I personally approve, the easiest fix for the problem at hand is to make wam use whatever WML format campaignd expects.
20170910 06:23:39-!- TC01 [~quassel@venus.arosser.com] has quit [Ping timeout: 252 seconds]
20170910 06:24:18-!- TC01 [~quassel@venus.arosser.com] has joined #wesnoth-dev
20170910 06:30:44< shadowm> https://bugzilla.libsdl.org/show_bug.cgi?id=2749#c9 ... Almost 3 years later.
20170910 06:31:34< shadowm> I hope someone here feels inclined to test. I don't even know if the original bug on our side is in GitHub.
20170910 06:32:29< shadowm> Looks like it isn't. Excellent.
20170910 06:33:28< shadowm> (Also I love how they answered my question by ignoring it.)
20170910 06:46:34< vultraz_iOS> shadowm: was it that bug that invalid utf8 could crash the game?
20170910 06:46:48< vultraz_iOS> and the test case was the lenny face?
20170910 07:01:00-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170910 07:01:06-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170910 07:16:23-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20170910 07:39:36-!- travis-ci [~travis-ci@ec2-54-196-223-164.compute-1.amazonaws.com] has joined #wesnoth-dev
20170910 07:39:37< travis-ci> wesnoth/wesnoth#14947 (master - ac40b01 : Alexander van Gessel): The build passed.
20170910 07:39:37< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/273622435
20170910 07:39:37-!- travis-ci [~travis-ci@ec2-54-196-223-164.compute-1.amazonaws.com] has left #wesnoth-dev []
20170910 07:53:59-!- irker213 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170910 08:00:18-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170910 08:24:56-!- mjs-de [~mjs-de@x4e3163ce.dyn.telefonica.de] has joined #wesnoth-dev
20170910 08:51:52-!- Kwandulin2 [~Kwandulin@pD9FD53A4.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170910 09:12:48-!- travis-ci [~travis-ci@ec2-54-196-223-164.compute-1.amazonaws.com] has joined #wesnoth-dev
20170910 09:12:49< travis-ci> wesnoth/wesnoth#14949 (master - 6e9a719 : Alexander van Gessel): The build passed.
20170910 09:12:49< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/273641174
20170910 09:12:49-!- travis-ci [~travis-ci@ec2-54-196-223-164.compute-1.amazonaws.com] has left #wesnoth-dev []
20170910 09:17:25-!- Kwandulin [~Kwandulin@p200300E453CC3B09CCA57AB3091B92C5.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170910 09:36:42-!- Kwandulin [~Kwandulin@p200300E453CC3B09CCA57AB3091B92C5.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170910 09:53:06-!- Kwandulin [~Kwandulin@p200300E453CC3B09CCA57AB3091B92C5.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170910 10:04:49-!- moongazer [~moongazer@103.208.58.215] has joined #wesnoth-dev
20170910 10:05:31-!- moongazer [~moongazer@103.208.58.215] has quit [Max SendQ exceeded]
20170910 10:06:02-!- moongazer [~moongazer@103.208.58.215] has joined #wesnoth-dev
20170910 10:09:59-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170910 10:16:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170910 10:28:44< Kwandulin> Why are images/scenery not included as embellishments in the editor? Would make map design so much easier
20170910 10:36:19< zookeeper> because it would mean adding 100+ new terrains, probably
20170910 10:37:05< zookeeper> well, not that much since a lot of those are animation frames
20170910 10:38:49< zookeeper> the whole embellishments/items separation is a bit dubious to begin with. i mean, if you have gameplay-irrelevant decoration terrains, why don't you have one for every image that one might want to place on a map for decoration purposes?
20170910 10:39:50< zookeeper> ...because it'd be madness, that's not what terrain types are really for. but why have a handful of embellishment terrains in the first place, then?
20170910 10:40:33< zookeeper> (and of course functionally, embellishments have the massive drawback that they take up the top layer so you can't even use them everywhere you might want)
20170910 10:45:59< zookeeper> anyway, the embellishment terrains exist so if/since we need to have some kind of criteria for what should qualify, i'd say that embellishment terrains should only include landscaping that can actually be used in large areas without it looking silly. lilies, desert plants; fine, makes sense. shipwrecks, trapdoors, signposts; not really.
20170910 10:46:35< vultraz_iOS> let's not forget the map editor already allows you to place all the images/items and images/scene images in Scenario mode
20170910 10:46:42< vultraz_iOS> s/scene/scenery
20170910 10:46:42< zookeeper> the latter are singular "items" rather than an accentuation of the underlying terrain
20170910 10:47:04< Kwandulin> Mhh, right. It's just very tedious to design a map without those. One has to look into the images/scenery folder, look copypaste the filename, go into notepad++ and paste it there, then go into BfW to get the right coordinates, then return to notepad++ and include the coordinates. Then save the map, start the scenario and look how it looks ingame. It's super inefficient
20170910 10:48:13< Ravana_> I understand addon can add items to map editor anyways
20170910 10:48:25< zookeeper> and as an addition to what i said, of course also things like fences and gates which need TerrainGraphicsWML to look right in the first place.
20170910 10:49:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170910 10:50:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170910 10:52:52< Kwandulin> The scenario editor is bad. It lets you place items that are >72x72, so the images don't even show correctly in the game. Also the file is super bloated as every [item] tag has 4 empty keys included
20170910 10:56:01< zookeeper> yeah, the scenario editor is what it is...
20170910 11:02:24< vultraz_iOS> not.. very good
20170910 11:02:37< vultraz_iOS> the technology isn't there yet
20170910 11:02:55-!- moongazer [~moongazer@103.208.58.215] has quit [Ping timeout: 248 seconds]
20170910 11:04:01< zookeeper> i'm pretty sure the technology for good scenario editors exists :p
20170910 11:04:23< vultraz_iOS> *our* technology isn't there yet
20170910 11:05:54-!- travis-ci [~travis-ci@ec2-54-196-21-106.compute-1.amazonaws.com] has joined #wesnoth-dev
20170910 11:05:55< travis-ci> wesnoth/wesnoth#14953 (master - e584517 : Charles Dang): The build was canceled.
20170910 11:05:55< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/273661939
20170910 11:05:55-!- travis-ci [~travis-ci@ec2-54-196-21-106.compute-1.amazonaws.com] has left #wesnoth-dev []
20170910 11:06:40< zookeeper> as long as the scenario editor exists in whatever state, i guess suggestions for alternative ways to add item images aren't going to be very popular.
20170910 11:06:57< vultraz_iOS> what we need is live editing
20170910 11:07:12< vultraz_iOS> we can't have that as long as we use a preprocessor, saldy
20170910 11:07:13< vultraz_iOS> sadly
20170910 11:07:58< vultraz_iOS> im not even sure how one implements it
20170910 11:12:28< Kwandulin> It'd be useful to save to currently marked location into the clipboard
20170910 11:16:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170910 11:16:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170910 11:17:09< zookeeper> if we had no scenario editor at all, then my suggestion might be to support image items directly in the map format. add an imagepath+anchorsymbol in the map header, then use the anchor to denote hexes on which to place the image.
20170910 11:18:36< zookeeper> ought to be pretty simple to implement that and then an editor tool for it.
20170910 11:27:01-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170910 11:27:04-!- travis-ci [~travis-ci@ec2-54-196-21-106.compute-1.amazonaws.com] has joined #wesnoth-dev
20170910 11:27:05< travis-ci> wesnoth/wesnoth#14948 (master - 8e9874d : Jyrki Vesterinen): The build passed.
20170910 11:27:05< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/273628003
20170910 11:27:05-!- travis-ci [~travis-ci@ec2-54-196-21-106.compute-1.amazonaws.com] has left #wesnoth-dev []
20170910 11:52:13-!- markus_ [~mjs-de@x4e308dad.dyn.telefonica.de] has joined #wesnoth-dev
20170910 11:56:00-!- mjs-de [~mjs-de@x4e3163ce.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170910 12:06:31-!- sevu [~Shiki@p54855FCD.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170910 12:09:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170910 12:09:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170910 12:20:49-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170910 13:04:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170910 13:05:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170910 13:20:57-!- moongazer [~moongazer@103.208.58.201] has joined #wesnoth-dev
20170910 13:38:48-!- Kwandulin [~Kwandulin@p200300E453CC3B09CCA57AB3091B92C5.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170910 13:39:36-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170910 14:05:09-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20170910 14:36:11-!- Kwandulin [~Kwandulin@p200300E453CC3B09CCA57AB3091B92C5.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170910 15:10:19< sevu> 20170910 15:50:28 warning unit: Unknown attribute 'previous_recruits' discarded.
20170910 15:10:41< sevu> I never saw this in 1.13 in stderr. No Idea what was it
20170910 15:15:22< shadowm> 2
20170910 15:17:47< celticminstrel> Where is previous_recruits even used?
20170910 15:18:13< celticminstrel> There is a list in units/unit.cpp of allowed attributes in a [unit] tag; if some other attribute appears, that message is printed.
20170910 15:18:44< celticminstrel> Something is probably using a previous_recruits variable internally. (Might even be an addon maybe?)
20170910 15:20:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20170910 15:21:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170910 15:50:31-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170910 15:50:58< sevu> It's in savefiles.
20170910 15:51:48< sevu> On the c++ side it's carryover / teambuilder and game_initialization
20170910 16:08:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170910 16:08:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170910 16:14:41-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a9ff:ccf5:16e:ac90] has joined #wesnoth-dev
20170910 16:37:22-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a9ff:ccf5:16e:ac90] has quit [Remote host closed the connection]
20170910 16:42:51-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170910 16:42:58-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170910 17:02:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170910 17:02:46-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a9ff:ccf5:16e:ac90] has joined #wesnoth-dev
20170910 17:03:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170910 17:04:28-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a9ff:ccf5:16e:ac90] has quit [Remote host closed the connection]
20170910 17:05:30-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a9ff:ccf5:16e:ac90] has joined #wesnoth-dev
20170910 17:11:39< celticminstrel> It works! :O \o/ I'll push it for review immediately.
20170910 17:13:03-!- irker262 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170910 17:13:03< irker262> wesnoth: Celtic Minstrel wesnoth:master 686885b980b7 / src/gui/dialogs/hotkey_bind.cpp: Fix issue with binding mouse or joystick hotkeys https://github.com/wesnoth/wesnoth/commit/686885b980b73fe388e7cdef6b9773864e5b679d
20170910 17:13:09< irker262> wesnoth: Celtic Minstrel wesnoth:fix_1864 417ccdca4ea8 / src/hotkey/ (command_executor.cpp hotkey_command.cpp hotkey_command.hpp hotkey_item.cpp): fix #1864 https://github.com/wesnoth/wesnoth/commit/417ccdca4ea8a3a6813463b67273a156a279e01b
20170910 17:15:21< celticminstrel> PR 1976
20170910 17:23:06-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a9ff:ccf5:16e:ac90] has quit [Remote host closed the connection]
20170910 17:30:13-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170910 17:41:50-!- travis-ci [~travis-ci@ec2-54-196-21-106.compute-1.amazonaws.com] has joined #wesnoth-dev
20170910 17:41:51< travis-ci> wesnoth/wesnoth#14962 (master - b260cdc : Gregory A Lundberg): The build has errored.
20170910 17:41:51< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/273764628
20170910 17:41:51-!- travis-ci [~travis-ci@ec2-54-196-21-106.compute-1.amazonaws.com] has left #wesnoth-dev []
20170910 17:48:17-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a9ff:ccf5:16e:ac90] has joined #wesnoth-dev
20170910 17:54:39-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a9ff:ccf5:16e:ac90] has quit [Remote host closed the connection]
20170910 17:55:23-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170910 17:55:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170910 17:58:30-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a9ff:ccf5:16e:ac90] has joined #wesnoth-dev
20170910 18:12:24-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20170910 18:15:07-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a9ff:ccf5:16e:ac90] has quit [Remote host closed the connection]
20170910 18:31:29-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a9ff:ccf5:16e:ac90] has joined #wesnoth-dev
20170910 18:31:31-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a9ff:ccf5:16e:ac90] has quit [Remote host closed the connection]
20170910 18:40:12< irker262> wesnoth: Charles Dang wesnoth:master 085257f77f88 / src/gui/widgets/ (listbox.cpp toggle_panel.cpp): GUI2: revert toggle panel change from acea15c312 https://github.com/wesnoth/wesnoth/commit/085257f77f88fec3fa02891f469928f2b9a321b2
20170910 18:44:37< irker262> wesnoth: Jyrki Vesterinen wesnoth:master 59f514684d9c / src/gui/widgets/toggle_panel.cpp: Correct the year https://github.com/wesnoth/wesnoth/commit/59f514684d9ccf1c84c90c90fa5c727e2532cae1
20170910 18:45:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170910 18:45:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170910 18:59:30-!- travis-ci [~travis-ci@ec2-184-72-174-68.compute-1.amazonaws.com] has joined #wesnoth-dev
20170910 18:59:31< travis-ci> wesnoth/wesnoth#14964 (master - 686885b : Celtic Minstrel): The build passed.
20170910 18:59:31< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/273897249
20170910 18:59:31-!- travis-ci [~travis-ci@ec2-184-72-174-68.compute-1.amazonaws.com] has left #wesnoth-dev []
20170910 19:01:41-!- moongazer [~moongazer@103.208.58.201] has quit [Quit: Leaving]
20170910 19:07:43-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170910 19:07:58-!- vn971 [~vasya@95.31.7.253] has joined #wesnoth-dev
20170910 19:13:52-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170910 19:17:07< vn971> Hi all) I intended to join and not report a bug / proposal, but apparently I can't.
20170910 19:17:38< vn971> So here's the thing. How can I launch wesnoth with a custom file tree root (say, custom data dir)?
20170910 19:17:58< Ravana_> see wesnoth --help
20170910 19:17:59< vn971> I know there is a CLI argument for that, but it doesn't work, and strangely so:
20170910 19:18:21-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a9ff:ccf5:16e:ac90] has joined #wesnoth-dev
20170910 19:23:52< vn971> sorry, it took some time. Here's the log:  https://gist.github.com/vn971/2039138b9bc68f41cf6489abf7870667
20170910 19:24:55< vn971> as seen in the log, I'm using a custom "root" directory where all wesnoth is placed. I provide a --data-dir as necessary. Still, wesnoth tells it can't find fonts.cfg even though it's there.
20170910 19:25:12< vn971> * wesnoth says
20170910 19:28:04< vn971> I know I have a funny user-specific directory in the log that says "1.12" in reality, the last directory name is "git", and it's a symlink to "1.12". Anyway, this should not have any effect because it's a user dir. I can test with a clean one, too.
20170910 19:35:34< shadowm> vn971: Use /opt/wesnoth-git/usr/share/wesnoth instead.
20170910 19:36:04< shadowm> The data dir just happens to have a subdir called data/.
20170910 19:39:45< vn971> shadowm: wow, indeed it works.) Thanks!
20170910 19:40:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170910 19:40:40< vn971> Also, now that I've figured this out, I have a proposal/question. Would it make sense for wesnoth to load a _relative_ directory as "data dir" by default, not absolute?
20170910 19:40:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170910 19:41:12< shadowm> It already tries to autodetect the data dir from the current working dir if that's what you mean.
20170910 19:41:18< vn971> ../share/wesnoth  instead of  /usr/share/wesnoth
20170910 19:41:28< shadowm> It can also be told to do that if you want.
20170910 19:41:53< vn971> shadowm: see above, I mean these two specific locations. It seems that wesnoth uses the absolute one.
20170910 19:42:32< shadowm> If you pass ../share/wesnoth to it, it will use ../share/wesnoth.
20170910 19:43:54< vn971> shadowm: why not use `../share/wesnoth` by default?
20170910 19:44:56< shadowm> The default non-auto path is defined at compile time based on several parameters (the exact names depend on whether you're using CMake or SCons).
20170910 19:45:21< shadowm> If you want to change it to suit a non-standard install you can do so.
20170910 19:45:55< vn971> shadowm: would it make sense to change that for everyone, or not really?
20170910 19:46:05< shadowm> It really should be using <prefix>/share/wesnoth by default anyway?
20170910 19:46:16-!- Kwandulin [~Kwandulin@p200300E453CC3B09CCA57AB3091B92C5.dip0.t-ipconnect.de] has quit [Ping timeout: 246 seconds]
20170910 19:46:17< shadowm> If it isn't then odds are someone broke something.
20170910 19:46:43< vultraz_iOS> celticminstrel: status on Lua mapgen fixes?
20170910 19:46:44< shadowm> The assumption here is that the prefix is /opt/wesnoth-git/usr.
20170910 19:46:49< vultraz_iOS> will they be done this week?
20170910 19:47:05< shadowm> If it is something else and you manually moved the files there, then of course nothing of this will work correctly.
20170910 19:47:39< vn971> shadowm: if I launch wesnoth from /opt/wesnoth-git/usr/bin/wesnoth, the default data-dir will be /usr/share/wesnoth
20170910 19:47:59< shadowm> It shouldn't be.
20170910 19:48:24< shadowm> Unless /usr was the prefix defined at compile-time and you manually moved the files to /opt/wesnoth-git/usr.
20170910 19:48:33< vn971> shadowm: I did a pacman install with a --root prefix. It changes the "root" for all installed files (basically moving all files).
20170910 19:48:56< vn971> shadowm: I moved the files (basically).
20170910 19:48:58< shadowm> I don't remember what that means. Is it a Gentoo or Arch thing?
20170910 19:49:18< shadowm> In either case, the correct procedure is to rebuild Wesnoth with the correct prefix.
20170910 19:49:27< vn971> shadowm: Arch one. Allows me to have wesnoth-1.12 and wesnoth-1.13 on the same system.
20170910 19:49:36< vn971> shadowm: OK, gotcha.
20170910 19:49:53< vn971> but wait
20170910 19:50:12< vn971> it's still strange (to me) that the compile-time constant is an absolute path, not relative.
20170910 19:50:22< shadowm> If you absolutely want it to try additional guesses with system paths as a last resort for unusual configurations like yours (where the compile-time prefix doesn't match reality), you can submit a patch.
20170910 19:50:46< vn971> but if everyone understands what I'm talking about and you disagree, it's OK. I mean, I think you know it well.
20170910 19:50:46< shadowm> I for one don't even know if what you're proposing is standard on Linux.
20170910 19:51:18< shadowm> I don't disagree, I just don't get to have an opinion on it and that's not just because I'm not an active dev. :p
20170910 19:51:22< vn971> shadowm: it's not standard, I presume. But using relative paths is standard.
20170910 19:51:22< JyrkiVesterinen> As far as I know, on GNU/Linux it's standard that compiled-in paths are absolute.
20170910 19:53:56< shadowm> Anyway, the current algorithm first tries to see if you are trying to run Wesnoth from a build directory in the source tree, then tries the compiled-in default that is supposed to refer to a system path. If you want it to try more system paths I'd say the current order should continue to be used first.
20170910 19:55:58< shadowm> Primarily because the packager's judgment ought to be trusted to avoid ending up with a data dir version mismatch bug in some unusual configuration.
20170910 20:02:40< vn971> I studied a number of files on my system, generally binary/executable files access absolute paths "/usr/share" rather than relative "../share"
20170910 20:02:52< vn971> So I just had a wrong impression on how it works by default.
20170910 20:03:18< vn971> Thanks for explaining! I'm also glad wesnoth-1.13 now works alongside the main multiplayer one.:)
20170910 20:08:19-!- travis-ci [~travis-ci@ec2-54-166-68-16.compute-1.amazonaws.com] has joined #wesnoth-dev
20170910 20:08:20< travis-ci> wesnoth/wesnoth#14965 (fix_1864 - 417ccdc : Celtic Minstrel): The build failed.
20170910 20:08:20< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/273897292
20170910 20:08:20-!- travis-ci [~travis-ci@ec2-54-166-68-16.compute-1.amazonaws.com] has left #wesnoth-dev []
20170910 20:12:01-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a9ff:ccf5:16e:ac90] has quit [Remote host closed the connection]
20170910 20:14:39-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170910 20:19:22-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a9ff:ccf5:16e:ac90] has joined #wesnoth-dev
20170910 20:21:57< celticminstrel> ...heh, is vultraz_iOS living in the future? :P
20170910 20:22:04< vultraz_iOS> yes
20170910 20:22:09< vultraz_iOS> the year is 2019
20170910 20:22:17< vultraz_iOS> donald trump has not been impeached yet
20170910 20:25:06< celticminstrel> I don't get it.
20170910 20:25:38< celticminstrel> Anyway, I may or may not get to the mapgen stuff today, but ATM I don't expect it to be ready in what's left of the day.
20170910 20:25:51< vultraz_iOS> as long as it's readyby sunday
20170910 20:26:03< celticminstrel> It's Sunday now.
20170910 20:26:46< vultraz_iOS> next sunday
20170910 20:27:03< celticminstrel> Oh, next Sunday, okay. If it's next Sunday it could probably be ready.
20170910 20:27:08< celticminstrel> Provided I actually work on it.
20170910 20:27:35< vultraz_iOS> did you think the release was today?
20170910 20:27:52< celticminstrel> Apparently.
20170910 20:28:10< vultraz_iOS> now who's in the future :P
20170910 20:28:28< celticminstrel> Hey, I'm not the one claiming it's 2019.
20170910 20:50:57< vultraz_iOS> yes but you're claiming it's
20170910 20:50:59< vultraz_iOS>  synday
20170910 20:51:00< vultraz_iOS> sunday
20170910 20:51:46< vultraz_iOS> celticminstrel: i looked it up for you
20170910 20:52:25< vultraz_iOS> celticminstrel: for formula is: 20  + ((value - 2) *  2)
20170910 20:52:30< irker262> wesnoth: Celtic Minstrel wesnoth:fix_1864 c2598d393516 / src/hotkey/ (hotkey_command.hpp hotkey_item.cpp): Travis fixup https://github.com/wesnoth/wesnoth/commit/c2598d39351665b9f4f71f8a2b4e463cd248d936
20170910 20:52:30< vultraz_iOS> s/for/the
20170910 20:56:09< celticminstrel> I'm claiming it's Sunday because it is Sunday.
20170910 20:56:52< vultraz_iOS> sandayyyy
20170910 20:57:04< celticminstrel> Are you planning to fix 1962?
20170910 20:57:45< vultraz_iOS> ?
20170910 20:57:55< vultraz_iOS> i can't repro it
20170910 20:58:07< celticminstrel> Do you understand what exactly the issue is?
20170910 20:58:18< vultraz_iOS> oh wait
20170910 20:58:20< vultraz_iOS> new steps
20170910 20:58:21< vultraz_iOS> hmm
20170910 20:58:24< vultraz_iOS> lemme try again
20170910 21:03:06-!- aeth_ [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20170910 21:05:35-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 240 seconds]
20170910 21:05:48-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a9ff:ccf5:16e:ac90] has quit [Remote host closed the connection]
20170910 21:06:17-!- aeth_ is now known as aeth
20170910 21:16:53-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a9ff:ccf5:16e:ac90] has joined #wesnoth-dev
20170910 21:20:52-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a9ff:ccf5:16e:ac90] has quit [Remote host closed the connection]
20170910 21:21:01-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20170910 21:26:01-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170910 21:26:07-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170910 21:28:49-!- markus_ [~mjs-de@x4e308dad.dyn.telefonica.de] has quit [Remote host closed the connection]
20170910 21:34:18-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a9ff:ccf5:16e:ac90] has joined #wesnoth-dev
20170910 21:34:30-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a9ff:ccf5:16e:ac90] has quit [Remote host closed the connection]
20170910 21:35:13-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a9ff:ccf5:16e:ac90] has joined #wesnoth-dev
20170910 21:39:40-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a9ff:ccf5:16e:ac90] has quit [Ping timeout: 246 seconds]
20170910 21:40:43-!- travis-ci [~travis-ci@ec2-54-166-68-16.compute-1.amazonaws.com] has joined #wesnoth-dev
20170910 21:40:44< travis-ci> wesnoth/wesnoth#14968 (master - 59f5146 : Jyrki Vesterinen): The build passed.
20170910 21:40:44< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/273917515
20170910 21:40:44-!- travis-ci [~travis-ci@ec2-54-166-68-16.compute-1.amazonaws.com] has left #wesnoth-dev []
20170910 21:40:48-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a9ff:ccf5:16e:ac90] has joined #wesnoth-dev
20170910 21:43:32-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:a9ff:ccf5:16e:ac90] has quit [Remote host closed the connection]
20170910 21:46:16-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170910 22:15:41-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 246 seconds]
20170910 22:40:51-!- travis-ci [~travis-ci@ec2-54-166-68-16.compute-1.amazonaws.com] has joined #wesnoth-dev
20170910 22:40:52< travis-ci> wesnoth/wesnoth#14969 (fix_1864 - c2598d3 : Celtic Minstrel): The build was fixed.
20170910 22:40:52< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/273948047
20170910 22:40:52-!- travis-ci [~travis-ci@ec2-54-166-68-16.compute-1.amazonaws.com] has left #wesnoth-dev []
20170910 23:29:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170910 23:49:43-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170910 23:50:29-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170910 23:55:28-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170910 23:55:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170910 23:57:26-!- irker262 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
--- Log closed Mon Sep 11 00:00:48 2017