--- Log opened Thu Sep 14 00:00:52 2017
20170914 00:03:46< celticminstrel> Did you consider maybe the fact that it has a PR open (without WIP or anything similar) might mean it's ready?
20170914 00:07:40-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170914 00:07:58-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170914 00:08:24< vultraz> I did.
20170914 00:08:31< vultraz> But I wasn't sure
20170914 00:09:41-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170914 00:10:08-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170914 00:10:31< celticminstrel> Was there a way to make impassable terrains see-through?
20170914 00:11:23< celticminstrel> vision_alias, I guess?
20170914 00:12:37< celticminstrel> Should we add vision_alias=flat to the gate terrains?
20170914 00:12:41< celticminstrel> zookeeper: ^
20170914 00:13:43< celticminstrel> Also unrelatedly, the terrain.cfg keeps getting longer and longer. I wonder if we should split it into smaller chunks. It's currently 2,855 lines.
20170914 00:13:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170914 00:14:21-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170914 00:14:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170914 00:18:02< celticminstrel> vultraz: What do you think of the idea of dropping in a playlist file that can be opened in VLC or iTunes? (Presumably others too.)
20170914 00:18:28< celticminstrel> Like just drop it into the music dir or something.
20170914 00:18:30< vultraz> Not a bad idea.
20170914 00:18:48< celticminstrel> Presumably it's exclude the really short ones though.
20170914 00:18:53< celticminstrel> Like victory and defeat.
20170914 00:19:00< celticminstrel> I mean, it wouldn't have to, though.
20170914 00:19:58< vultraz> did you see west's latest MM upload?
20170914 00:20:17< celticminstrel> Yeah, it's what prompted that. :P
20170914 00:20:27< celticminstrel> It's easy to create such a file in VLC, but you'd then need to edit it in a text file to strip out the absolute path names.
20170914 00:24:11 * DeFender1031 has nearly all of the wesnoth music on his usual playlist already.
20170914 00:24:47< DeFender1031> The music is one of the best things about the game.
20170914 00:25:05< vultraz> true, we have a great music selection
20170914 00:26:10< DeFender1031> Especially if you inlude the add-on packs.
20170914 00:26:24< DeFender1031> (Which are also on my aforementioned playlist.)
20170914 00:27:27< vultraz> the one regret I have about our music is we have nothing with choral vocals
20170914 00:34:14< celticminstrel> Probably because you need an actual choir for that to sound good.
20170914 00:35:16< vultraz> and $$$
20170914 00:35:56< celticminstrel> Well obviously you need money to hire a choir to sing for you.
20170914 00:43:23< DeFender1031> Is that so?
20170914 00:44:08< DeFender1031> I'm pretty sure some of the add-on music has chorals, no?
20170914 00:45:59< DeFender1031> Since there's no way for me to search aside from listening to all of it, what's likely going to happen is that one day several months from now, I'll be like "remember when you said that thing, well check out this track!" :P
20170914 00:46:16< DeFender1031> (Unless, of course, I'm wrong, in which case there is no such track.)
20170914 00:51:19-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170914 00:55:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170914 01:03:47< shadowm> I'm sure I've heard some synthetic chorals in UMC music, actually.
20170914 01:04:00< shadowm> Not a fan of that kind of thing because it's so jarringly obvious.
20170914 01:07:00< celticminstrel> Basically, if you don't hire a choire, all you can do with voice is "ah" and maybe "ooh".
20170914 01:07:04< celticminstrel> ^choir
20170914 01:07:43< celticminstrel> Sure there's also more sophisticated vocal synthesis (eg Vocaloid), but that generally still sounds synthetic despite being based on actual samples.
20170914 01:07:44< shadowm> And it still sounds fake most of the time.
20170914 01:08:17< shadowm> Unless the musician spends an absurd amount of effort on making them less so, but that doesn't come without practice either.
20170914 01:08:21< celticminstrel> Well, it's less likely to sound fake than a Vocaloid track, if you're using a sampled choir "ah" track.
20170914 01:12:59-!- sigurdfd [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has quit []
20170914 01:37:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170914 01:38:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170914 01:48:40< shadowm> celticminstrel: I have a feeling you're familiarized with this, based on a cursory glance at the commit history for that file's counterpart in master: https://pastebin.com/sbRXe296 (this is 1.12)
20170914 01:48:57< shadowm> Any chance to have a backport to 1.12, or should I just disable strict for my own builds?
20170914 01:51:08< shadowm> Also, am I allowed to say that this is the stupidest warning I've ever seen be added to GCC?
20170914 01:51:14< vultraz> backport probably not possible.
20170914 01:51:19< shadowm> Why?
20170914 01:51:59< shadowm> Is it because you're working with an overly narrow definition of "backport" that implies zero effort through git cherry-pick, or some more elaborate reason?
20170914 01:52:45< vultraz> 1.12 compiler requirements are lower or at least different than master's and it was already hard enough detecting which supported the fallthrough attribute. Not worth the effort to do that on 1.12.
20170914 01:54:50< shadowm> I'll just add -Wno-implicit-fallthrough to my compiler flags then.
20170914 01:55:45< shadowm> (Which, I might add, would've been my preferred course of action to begin with.)
20170914 02:03:51< vultraz> It would have been a lot simpler if we didn't support GCC 4.x and MSVC 2013
20170914 02:06:23-!- travis-ci [~travis-ci@ec2-23-23-55-237.compute-1.amazonaws.com] has joined #wesnoth-dev
20170914 02:06:24< travis-ci> wesnoth/wesnoth#14999 (master - f444ee8 : Celtic Minstrel): The build passed.
20170914 02:06:24< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/275264699
20170914 02:06:24-!- travis-ci [~travis-ci@ec2-23-23-55-237.compute-1.amazonaws.com] has left #wesnoth-dev []
20170914 02:17:38< pydsigner> vultraz: just think of 3:17 as the leadup to the drop :P
20170914 02:17:53< vultraz> but there's no drop
20170914 02:18:20< vultraz> the point of a drop is that when the drop drops it drops
20170914 02:18:28< pydsigner> Different genre
20170914 02:18:45< vultraz> but this is a non-drop since at the drop there is no drop
20170914 02:27:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170914 02:28:01< DeFender1031> Would you just drop it already? :P
20170914 02:28:18< DeFender1031> (I have no idea what that is actually about.)
20170914 02:28:20< pydsigner> Don't do that, West's plugins might break again D:
20170914 02:28:28< pydsigner> DeFender1031: the new menu track
20170914 02:28:49< pydsigner> DeFender1031: https://soundcloud.com/mattiaswestlund/return-to-wesnoth-wip
20170914 02:29:16< DeFender1031> Ooh!
20170914 02:29:21< DeFender1031> This is really nice!
20170914 02:29:59< DeFender1031> I didn't realize a new track was being created for the menu. I had thought that the change from 1.12 to 1.13 was it.
20170914 02:30:27< vultraz> the board decided to commission a new track now that we allow CC works
20170914 02:31:11< DeFender1031> :D
20170914 02:32:06< vultraz> if you're wondering why big projects like this new track and the website happened, it's commissions.
20170914 02:34:09< vultraz> those new animation frames for the Knight? commission
20170914 02:34:22< vultraz> the iOS port work? contract
20170914 02:34:23< DeFender1031> Sure. Once people are being paid to do stuff, you can get all sorts of fancy things.
20170914 02:34:38< DeFender1031> Where's wesnoth getting its funding?
20170914 02:35:15< vultraz> we're dipping into our reserves. once the iOS port is up we'll get our revenue stream back
20170914 02:35:37< vultraz> but we have enough funds to pay for this stuff right now
20170914 02:35:42< DeFender1031> hmm...
20170914 02:36:22< DeFender1031> I'm surprised that the iOS port was popular enough to generate a significant amount.
20170914 02:37:08< DeFender1031> The interface is not the most comfortable to use on touchscreens.
20170914 02:38:15< DeFender1031> It seems strange that people would pay money for a worse experience than the free version on a different platform.
20170914 02:38:35< DeFender1031> (Not that I'm complaining.)
20170914 02:40:04< vultraz> the new version will be a lot better.
20170914 02:59:50-!- irker836 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170914 03:00:54< celticminstrel> shadowm, vultraz: Backport might be possible, but ony for gcc / clang; IIRC it wouldn't work on MSVC. (Basically the fallthrough attribute is available as a nonstandard extension on gcc/clang. Possibly only one of the two, can't remember.)
20170914 03:01:24< celticminstrel> Something like __attribute__((fallthrough));
20170914 03:04:24< vultraz> Really, we have better things to do
20170914 03:23:11-!- RatArmy_ [~ratarmy@om126234114194.16.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170914 03:55:48-!- RatArmy_ [~ratarmy@om126234114194.16.openmobile.ne.jp] has joined #wesnoth-dev
20170914 03:58:13-!- RatArmy_ [~ratarmy@om126234114194.16.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170914 04:09:59-!- RatArmy_ [~ratarmy@om126234114194.16.openmobile.ne.jp] has joined #wesnoth-dev
20170914 04:10:29< Necrosporus> I got wesnot master frozen
20170914 04:10:30-!- RatArmy_ [~ratarmy@om126234114194.16.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170914 04:11:37< Necrosporus> Seems to be reproduciable
20170914 04:11:54< Necrosporus> ... And preventing me from finishing campaign scenario
20170914 04:13:28< vultraz> file a bug
20170914 04:13:41< vultraz> please
20170914 04:15:36< Necrosporus> Would it be wrong if I just write steps to reproduce here instead?
20170914 04:17:35< vultraz> yes. they'll get lost.
20170914 04:18:38-!- RatArmy_ [~ratarmy@om126234114194.16.openmobile.ne.jp] has joined #wesnoth-dev
20170914 04:21:26-!- RatArmy_ [~ratarmy@om126234114194.16.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170914 04:23:02-!- RatArmy_ [~ratarmy@150.100.253.58] has joined #wesnoth-dev
20170914 04:25:41-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20170914 04:41:41-!- RatArmy_ [~ratarmy@150.100.253.58] has quit [Ping timeout: 240 seconds]
20170914 04:58:41-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170914 05:02:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds]
20170914 05:04:46-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170914 05:21:54-!- mjs-de [~mjs-de@x5ce3e1fb.dyn.telefonica.de] has joined #wesnoth-dev
20170914 05:24:40< wedge009> celticminstrel: Not sure what you're discussing but I had trouble with fallthrough in the past, which is why I had to add https://github.com/wesnoth/wesnoth/blob/master/src/global.hpp#L75
20170914 05:31:27-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170914 05:34:53-!- ancestral [~anonymous@174-30-255-129.mpls.qwest.net] has joined #wesnoth-dev
20170914 06:01:24-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170914 06:21:59-!- ancestral [~anonymous@174-30-255-129.mpls.qwest.net] has quit [Quit: ancestral]
20170914 06:26:39-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20170914 06:31:24-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170914 06:38:10< zookeeper> celmin, i don't think the closed gates should be see-through. i mean, sure, the iron gates are just bars so you "should" see through it, but then it'd work differently than the wooden doors and vision is one of those semi-abstract things anyway that isn't based on actual line of sight. so i'd prefer if they just stayed impassable WRT vision too.
20170914 06:40:43< DeFender1031> perhaps having two versions makes sense?
20170914 06:41:58< zookeeper> as for terrain.cfg, yeah it's big but i don't really see how it could be split without making working with the terrains more awkward. the only entries that could logically be separated would be the terrain archetypes, and those take up just about 200 lines, so...
20170914 06:43:08< zookeeper> it's not like it wouldn't be terrible if we split them according to editor groups and had the definitions spread out across 10+ files without it even being obvious where each one is.
20170914 06:43:14< DeFender1031> that much for just making a nearly-identical terrain with one property changed?!
20170914 06:44:49< zookeeper> DeFender1031, unless i'm not seeing something you're seeing, you suggested something and are rebuking it 2 minutes later? :p
20170914 06:45:31< zookeeper> but yes, i don't think it makes sense to make duplicates of a terrain whenever someone could conceivably want to use it with one property changed
20170914 06:47:03-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170914 06:51:13-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds]
20170914 06:51:18-!- mjs-de [~mjs-de@x5ce3e1fb.dyn.telefonica.de] has quit [Remote host closed the connection]
20170914 06:55:48< DeFender1031> No, I was just surprised that making a duplicate would be that much work
20170914 06:56:18< zookeeper> umm...
20170914 06:56:30< zookeeper> maybe read again
20170914 06:56:48< DeFender1031> But you make a good point about not making duplicates of a terrain whenever someone could conceivably want one property changed.
20170914 06:56:55< DeFender1031> huh?
20170914 06:57:20< zookeeper> i never said anything about how much working it would be to make duplicates
20170914 06:57:26< zookeeper> s/working/work
20170914 06:57:59< DeFender1031> oh, was all of that stuff about splitting stuff not about making suplicates?
20170914 07:00:31< DeFender1031> Whatever. Anyway, this does raise a larger point about terrains though, (and built-in types of things in general, such as units, movement types, etc.) which is that it'd be nice if there were a way for add-ons to modify built-in things via ID.
20170914 07:00:48< zookeeper> sure
20170914 07:00:54< zookeeper> at least on a per-scenario basis
20170914 07:02:07< DeFender1031> if it's only, per-scenario and someone wanted the change for an entire campaign, it could get annoying, though still workable with macros.
20170914 07:02:20< DeFender1031> I'd think that it'd be allowed both globally and per-scenario
20170914 07:02:39< zookeeper> it's not more annoying than just having a macro call or an include in every scenario
20170914 07:02:50< DeFender1031> also, modifying a unit type for just one scenario could get weird, since units carry their definitions around with them.
20170914 07:03:23< DeFender1031> True, but you'd have to remember to do so, and boilerplate macros tend to clutter things up.
20170914 07:03:42< zookeeper> if you allow it globally then chances are that soon you'll have a whole bunch of add-ons which break stuff globally, in subtle and not-so-subtle ways.
20170914 07:03:46< DeFender1031> I also tend to take the approach of "why not allow it everywhere that it makes sense?"
20170914 07:04:02< DeFender1031> you already have that problem.
20170914 07:04:18< DeFender1031> add-on creators need to be responsible and put their crap only inside their own defineds.
20170914 07:04:22< DeFender1031> defines*
20170914 07:05:00< DeFender1031> on the other hand, this one may be even more ripe for accidental global breakage than others, so perhaps you have a point.
20170914 07:05:52< DeFender1031> still, i've often wished I could modify core stuff on the fly, but had to recreate nearly the entire definition myself.
20170914 07:06:37< DeFender1031> another thing that would be nice, though I don't even know WHAT it might look like, would be some way to add terrain codes to existing terrain graphics rules.
20170914 07:07:55< DeFender1031> the only way that I could think of to do that though would require a complete reworking of how the entire terrain graphics system works to assign "classes" to each terrain type rather than using the 4-letter-code-with-wildcards system, so it's likely not going to happen any time soon if ever.
20170914 07:32:02< zookeeper> DeFender1031, or the existing rules could just use wildcarding more liberally, so if one wants their custom terrain to look exactly like desert mountains, they only need to make the first 2-3 characters of their terrain code match.
20170914 07:37:04< DeFender1031> that'd be a simpler way to do it, though it still presents the same problem.
20170914 07:37:17< DeFender1031> It isn't intuitive or fully expansible.
20170914 07:39:38< DeFender1031> (Speaking completely theoretically, since this will never happen) classes would probably be much simpler to manage. You'd assign one or more classes to a certain terrain, and assign rules to those classes and the interactions thereof, in a manner somewhat similar to css.
20170914 07:40:38< DeFender1031> And if you want a new type to look similar to or to interact similarly with an existing type, just give it the right class, and it'll work.
20170914 07:41:15< DeFender1031> So you'd have, like, a wall class, which would indicate that other wall types should extend into it as walls do.
20170914 07:41:36< DeFender1031> or a chasm class, which would indicate chasm transitions.
20170914 07:41:38< DeFender1031> etc.
20170914 07:41:52< DeFender1031> and then specific classes for the specific terrains, aka grass or lava.
20170914 07:42:03< DeFender1031> but whatever, it's a pipe dream.
20170914 07:42:08< DeFender1031>  anyway, bbl.
20170914 07:45:19-!- lipkab [~the_new_l@195.56.169.82] has quit [Quit: Leaving]
20170914 07:58:56-!- atarocch [~atarocch@93.56.164.28] has quit [Ping timeout: 240 seconds]
20170914 08:30:42-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20170914 08:30:42-!- Necrosporus is now known as Guest9809
20170914 08:30:42-!- Necrosporus_ is now known as Necrosporus
20170914 08:34:26-!- Guest9809 [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 240 seconds]
20170914 08:35:19-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170914 08:39:39-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 252 seconds]
20170914 09:38:55-!- atarocch [atarocch@nat/redhat/x-gulmfwzkesmzucph] has joined #wesnoth-dev
20170914 09:41:53-!- RatArmy_ [~ratarmy@om126212248021.14.openmobile.ne.jp] has joined #wesnoth-dev
20170914 10:31:31-!- irker227 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170914 10:31:31< irker227> wesnoth: Charles Dang wesnoth:master 6a169dcd9210 / src/gui/widgets/styled_widget.cpp: GUI2/Styled Widget: fixed most tooltips not showing (fixes #1998) https://github.com/wesnoth/wesnoth/commit/6a169dcd921086c21ea9732707a3606259ed4553
20170914 10:31:32< irker227> wesnoth: Charles Dang wesnoth:master 85f37e261092 / src/gui/dialogs/addon/manager.cpp: Addon Manager: fixed missing widget errors in low-res mode (fixes #1993) https://github.com/wesnoth/wesnoth/commit/85f37e261092230bc6e8f794352e044d2b2d1062
20170914 10:31:33< irker227> wesnoth: Charles Dang wesnoth:master 8c04946464c1 / src/gui/dialogs/addon/manager.cpp: Addon Manager: disabled Esc exiting https://github.com/wesnoth/wesnoth/commit/8c04946464c122907d97ae2c2ad4bb5b865a0fa5
20170914 10:31:35< irker227> wesnoth: Charles Dang wesnoth:master 3f69fb43b0f8 / src/gui/dialogs/addon/manager.cpp: Addon Manager: fixed exit to desktop when canceling client ops (fixes #1995) https://github.com/wesnoth/wesnoth/commit/3f69fb43b0f89780777725c6bfaaf10cefc631ec
20170914 10:31:37< vultraz> Necrosporus: ^
20170914 10:33:42-!- atarocch [atarocch@nat/redhat/x-gulmfwzkesmzucph] has quit [Ping timeout: 260 seconds]
20170914 11:45:52-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170914 12:11:50-!- nkr [~nkr@179.99.202.71] has joined #wesnoth-dev
20170914 12:19:11-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170914 12:28:15-!- atarocch [atarocch@nat/redhat/x-ryujoudilfuqxcho] has joined #wesnoth-dev
20170914 12:29:10-!- gfgtdf [~chatzilla@x4e368261.dyn.telefonica.de] has joined #wesnoth-dev
20170914 12:30:22< gfgtdf> zookeeper: if i write [filter] x="", y="" [/filter], (or more pracical [filter] x="$some_nonexistent_variable.x", y="$some_nonexistent_variable.x" [/filter]) should it match all units or no units ?
20170914 12:35:09-!- fabi_ [~fabi@2a02:810c:c840:2e65:5102:933:b9b:674d] has quit [Quit: Konversation terminated!]
20170914 12:39:11< Necrosporus> Do you think maybe double-click on addon should display its description instead of installing it?
20170914 12:39:13< zookeeper> gfgtdf, umm... not sure
20170914 12:39:46< Necrosporus> gfgtdf, it should produce an error in console and perhaps interrupt scenario
20170914 12:39:58< Necrosporus> In second case
20170914 12:40:08< zookeeper> gfgtdf, doesn't seem like there's very strong reason for it to be either way, so i'd default to "whichever it has always been" (if it has always been the same, anyway)
20170914 12:40:35< Necrosporus> in first case it should output a warning about incorrect value and not match any units
20170914 12:40:48< Necrosporus> Or perhaps error the scenario and fall to console
20170914 12:41:07< gfgtdf> Necrosporus: the engine disstinguish betwen the 2 cases i meantion above.
20170914 12:41:34< Necrosporus> In both case it should not match units and return an error
20170914 12:41:52< Necrosporus> But in first case the error is non-numerical value
20170914 12:42:00< Necrosporus> in second case non-existant variable
20170914 12:42:10< Necrosporus> Type error
20170914 12:42:17< Necrosporus> x,y are supposed to be numbers
20170914 12:42:31< Necrosporus> If you pass non-numbers, then it should be an error
20170914 12:43:39< Necrosporus> By the way, I have noticed that in an old scenario which was from 1.10 era when it's simply moved to 1.13 addon directory then some coordinates are offset compared to what they were
20170914 12:44:32< zookeeper> gfgtdf, in master i seem to get same result from x="" and x="$some_nonexistent_variable.x"; that is, it matches all
20170914 12:44:54< zookeeper> but maybe you didn't mean that the behavior is currently different, only that it can be
20170914 12:45:25< Necrosporus> zookeeper, and there are no errors?
20170914 12:46:04< zookeeper> gfgtdf, in 1.12, neither matches any units
20170914 12:46:33< gfgtdf> zookeeper: yes in 1.12 it iirc matches none (both cases) this is also the reason for #1992 (changed bavuour caused an infinite [whiel] loop in his wml), i think i'll change it to match no units, considering how location ranges/sets work i also think this makes the most sense
20170914 12:47:16< zookeeper> any idea if it was an intentional change?
20170914 12:47:51< zookeeper> for what it's worth, 1.10 seems to have the same behavior as 1.12
20170914 12:48:06< zookeeper> (i've only tested using a [store_unit], for what that's worth)
20170914 12:48:24< Necrosporus> Generally you want to have to make as few changes as possible when porting from 1.10 or 1.12 to 1.1{3,4}
20170914 12:48:56< Necrosporus> So I suggest to revert it
20170914 12:49:23< Necrosporus> Also if you kill units for example, it's better to kill none than all of them perhaps?
20170914 12:50:08< zookeeper> gfgtdf, anyway, i have no objections to fixing/changing/reverting that.
20170914 12:50:18< irker227> wesnoth: gfgtdf wesnoth:master 85b36d6f8530 / src/units/filter.cpp: fix changes bahaviour of [filter]x="" [/filter] https://github.com/wesnoth/wesnoth/commit/85b36d6f8530912c0bd9dd3ce2aa61936a4e1519
20170914 12:50:40< gfgtdf> zookeeper, Necrosporus ^
20170914 12:50:58< zookeeper> great
20170914 12:54:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170914 13:08:16< irker227> wesnoth: Alexander van Gessel wesnoth:coverity-badge 20588830d519 / README.md: Add coverity badge to README.md https://github.com/wesnoth/wesnoth/commit/20588830d519b98d706479ca2c3c1ea573254236
20170914 13:09:24< AI0867> huh, the webinterface made the branch directly on the official repo
20170914 13:09:51< vultraz> is that a problem
20170914 13:11:37< Necrosporus> What is coverity?
20170914 13:12:14< AI0867> no, I just expected it to use my own fork
20170914 13:12:21< AI0867> static analysis tool
20170914 13:14:23< AI0867> https://scan.coverity.com/projects/wesnoth?tab=overview ← see here
20170914 13:14:31< AI0867> if you want access, you can request it there
20170914 13:16:57-!- nkr [~nkr@179.99.202.71] has quit [Read error: Connection reset by peer]
20170914 13:26:39-!- nkr [~nkr@179.99.202.71] has joined #wesnoth-dev
20170914 13:26:58< nkr> Hello
20170914 13:29:57< Necrosporus> I have read that there were changes in [terrain_mask] in 1.13 but I cant see them anywhere in https://wiki.wesnoth.org/TerrainMaskWML page
20170914 13:30:02< vultraz> hello
20170914 13:30:36< vultraz> Necrosporus: IIRC just get rid of the border and usage keys
20170914 13:32:15< Necrosporus> Ah, so border_size is assumed to be always 1?
20170914 13:32:54< vultraz> I can't remember what changes we made exactly, but something like that
20170914 13:33:28< Necrosporus> They seem to break some old scenarios I have digged out from 1.10
20170914 13:34:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20170914 13:34:13-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170914 13:38:05-!- stikonas_ is now known as stikonas
20170914 13:38:06< Necrosporus> vultraz, seems that terrain_masks which had border=0 are broken
20170914 13:38:21< vultraz> can you still pass border=1?
20170914 13:38:26< vultraz> I really can't remember
20170914 13:38:40< Necrosporus> Masks with border=1 look OK
20170914 13:39:06< Necrosporus> Shouldn't changes like that be documented right when they are made?
20170914 13:39:23-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170914 13:39:34< Necrosporus> Is there any overview of changes of 1.13 over 1.12 which are relevant to UMC?
20170914 13:40:19< vultraz> ah wait
20170914 13:41:05< vultraz> Necrosporus: ok I *think* what you need to do is remove the border_size key from the *map* data (or it might just be ignored) and use the border=yes/no key in [terrain_mask]
20170914 13:41:06< Necrosporus> https://forums.wesnoth.org/viewtopic.php?f=21&t=44917 btw
20170914 13:41:51< gfgtdf> Necrosporus: where exactly do you the ahve border=1 ? in the map data or in the terrain_mask tag ?
20170914 13:42:10< gfgtdf> Necrosporus: the border= key i map data was remvoed at some point
20170914 13:42:44< vultraz> it's border_size in the data but yeah, that's useless now
20170914 13:45:09< Necrosporus> So, if you are modifying whole map then you want to make use of border, but if you are modifying only part in the middle then you prefer border=no to keep mask two dimensions smaller?
20170914 13:47:22< Necrosporus> What is the point of border key?
20170914 13:48:12< Necrosporus> is there similar change in map data format ?
20170914 14:13:08< Necrosporus> attack_prediction.cpp:1763: double {anonymous}::calculate_probability_of_debuff(double, bool, double, double, bool, double): Assertion `prob_touched >= 0.0 && prob_touched <= 1.0' failed. Aborted
20170914 14:13:36< JyrkiVesterinen> Can you get a backtrace?
20170914 14:14:02< Necrosporus> If I find a way to reproduce, but might be related to units which have 50 moves
20170914 14:14:09< Necrosporus> and that I used droid command
20170914 14:14:47< JyrkiVesterinen> If you can find a way to reproduce, it'd be even more useful if you uploaded a save file and steps to reproduce.
20170914 14:17:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170914 14:17:18-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: Going home]
20170914 14:17:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170914 14:24:53-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev
20170914 14:25:41< vn971> Hi all. I have a question. Suppose 4 players play "Isar's cross", and one of them disconnects. What should wesnoth do?
20170914 14:26:13< vn971> Currently, it assigns the side to the room host, I think. But shouldn't it be better the ally of the DC player?
20170914 14:27:11< gfgtdf> vn971: i thought currently the host get a message what i want's to do that also icludes assigning that side side the allied player?
20170914 14:27:12< vn971> after all, he already might know some of the planned moves, not to mention that the enemy shouldn't have view on your "fog-shrouded" units.
20170914 14:27:57< vn971> gfgtdf: ah, so it's not silently? I watch online MP games sometimes and I often see sides being re-assigned over again after DC.
20170914 14:28:19< vn971> I mean, the first one that feels like automatic and then another change according to "ally" status.
20170914 14:28:31< Necrosporus> vn971, no, when user disconnects you can assign side to AI to idle to yourself or to other player
20170914 14:28:36< gfgtdf> vn971: no the hosts geta  message what he wants to do with thea side.
20170914 14:28:36< vn971> Maybe I'm wrong on that though.
20170914 14:29:01< vn971> Necrosporus: gfgtdf: OK, sorry for the confusion then. Allright.
20170914 14:29:05< gfgtdf> vn971: also the server doesn't know abot alliances, in paticular sinec they might change during the game via [modify_side]
20170914 14:29:09< gfgtdf> about*
20170914 14:29:32< vn971> gfgtdf: yeah, they can. OK, clear.
20170914 14:30:26-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170914 14:36:20< nkr> Can I compile wesnoth in VS2017?
20170914 14:38:26< gfgtdf> yes
20170914 14:39:35< nkr> Are there specific project files for that or VC12 ones will do?
20170914 14:49:58< Necrosporus> Though why would you want to use VS if there is GCC?
20170914 14:50:26< nkr> Do you code on windows?
20170914 14:51:06< Necrosporus> No, but when I need to compile code for windows I use Dev-C++ or separate version of mingw
20170914 14:51:26< Necrosporus> dev-c++ seems to be easier to install though
20170914 14:51:31< nkr> I havent tried that before
20170914 14:52:15-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 248 seconds]
20170914 14:52:38< nkr> It might be a good idea
20170914 14:52:43< nkr> What do you use on windows gfgtdf ?
20170914 14:53:36< gfgtdf> i used vs2015 but three is no reson to use that over vs2017
20170914 14:54:19< gfgtdf> we have ci builds that check whether wesnoth can be compiled with all common compliers, including vs2017
20170914 14:56:03< nkr> I see
20170914 14:58:06< nkr> Should I convert the project?
20170914 15:00:28< gfgtdf> nkr: yes iirc vs ofewrs an option to vonert vs12 projects to vc15 projects, but if you do that please copy the projectfiles folder first (from vc12 to vc15 for example )
20170914 15:00:57< nkr> Let me try that real quick
20170914 15:09:41< nkr> Nice its compiling :)
20170914 15:10:15< Necrosporus> I have tried to install Strange Legacy addon in 1.13 and got  Caught general 'N5boost16exception_detail10clone_implINS0_19error_info_injectorINS_9iostreams10gzip_errorEEEEE' exception: gzip error: iostream error
20170914 15:10:24< Necrosporus> Second attempt succeeded though
20170914 15:10:38< nkr> Is there a project roadmap somewhere?
20170914 15:11:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170914 15:12:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170914 15:13:08< gfgtdf> nkr: there may exist sucha  thing, not sure though. but if you want to work on something you can just look at the isue tacker
20170914 15:14:01< DeFender1031> Necrosporus, Caught general "Q17exception89name_is89very_veryM3186_63long_and_hardACK520_Qto_read153what_even153Tis_that_errorEEEEE' exception: exception names shouldn't be allowed to be that long error: brain overload error
20170914 15:16:25< gfgtdf> Necrosporus: pobably something went wrong with downloading the addon whihc creates a corrupt zip archieve, if you can reprpouce it and give a stacktrace of where the exception is thrown, we might be able to catch it properly.
20170914 15:17:38< Necrosporus> As I said the second attempt succeeded and it has installed successfully, so I don't know if it's reproducable
20170914 15:27:53-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20170914 15:28:08< irker227> wesnoth: Alexander van Gessel wesnoth:coverity-badge a78d02bd37d9 / README.md: Link badge to coverity page instead https://github.com/wesnoth/wesnoth/commit/a78d02bd37d955bbbedc28c6a706e25dd77d374c
20170914 15:32:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170914 15:33:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170914 15:36:18< Necrosporus> Can we make automatic builds with debug options?
20170914 15:37:48-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170914 15:41:56-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20170914 15:46:08-!- nkr [~nkr@179.99.202.71] has quit [Ping timeout: 240 seconds]
20170914 15:47:45-!- nkr [~nkr@179.99.202.71] has joined #wesnoth-dev
20170914 15:48:13< nkr> gfgtdf, compilation worked
20170914 15:48:21< gfgtdf> nice
20170914 15:50:12-!- vn971 [~vasya@94.158.103.15] has quit [Quit: Leaving.]
20170914 15:55:52-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170914 15:58:18-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev
20170914 16:12:32< AI0867> I've created the coverity@wesnoth.org mailing list, which should forward all coverity notifications as jenkins now submits a daily build
20170914 16:13:18< AI0867> weirdly, coverity failed earlier today. It just succeeded, but decided to mark all defects as fixed
20170914 16:15:46< loonycyborg> I thought we don't have any mailing lists anymore
20170914 16:19:22< Necrosporus> By the way,  can you describe your methods of tracking down bugs in the code in some page if it doesn't exist yet? 
20170914 16:20:13< Necrosporus> Such as how to read stack trace (not just produce it), which sorts of logs are to enable, how to debug in lua console or in test scenario and so on
20170914 16:20:41< Necrosporus> I know there is wesnoth --help but it's just quick reference 
20170914 16:22:11< JyrkiVesterinen> For me, the debugger is a very important tool.
20170914 16:22:12< JyrkiVesterinen> https://www.youtube.com/watch?v=C0vDKXIq_9A
20170914 16:22:44< JyrkiVesterinen> In short, the process is to follow how the code runs, and look for anything unexpected.
20170914 16:23:06< JyrkiVesterinen> "Why on Earth did it suddenly call this method?"
20170914 16:26:17< gfgtdf> zookeeper: hm it seems liek even with my last commit that filter still retunrs true for all units
20170914 16:27:40< nkr> gfgtdf, ive found some missing translations in the portuguese locale
20170914 16:31:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170914 16:31:17< gfgtdf> nkr: afaik the msvc build  doesnt complie the tanlations
20170914 16:31:35< nkr> Im playing the current version
20170914 16:31:44< nkr> Not the one I compiled
20170914 16:31:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170914 16:31:54< nkr> its missing in production hee
20170914 16:31:55< nkr> hehe
20170914 16:32:07-!- senkwich [~senkwich@cpe-24-28-70-56.austin.res.rr.com] has quit [Quit: ZNC 1.6.5 - http://znc.in]
20170914 16:33:41-!- senkwich [~senkwich@cpe-24-28-70-56.austin.res.rr.com] has joined #wesnoth-dev
20170914 16:35:59-!- nkr is now known as nkr__
20170914 16:36:22< Necrosporus> If your unit has more than 100 movement points it can walk in unwalkable terrains. Is it intentional?
20170914 16:38:38-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170914 16:40:23< Kwandulin> Yeah, the movement cost for unwalkable tiles is 99, iirc
20170914 16:40:34-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170914 16:41:23-!- nkr [Elite20292@gateway/shell/elitebnc/x-krnubqurpovzvgds] has joined #wesnoth-dev
20170914 16:41:55-!- nkr__ [~nkr@179.99.202.71] has quit [Quit: Leaving]
20170914 16:45:22-!- atarocch [atarocch@nat/redhat/x-ryujoudilfuqxcho] has quit [Ping timeout: 264 seconds]
20170914 16:48:17< AI0867> loonycyborg: we do. I set up a proxmox VM specifically so we could have a commits mailinglist again
20170914 16:48:30< AI0867> is the old wesnoth-dev mailinglist gone?
20170914 16:48:35< loonycyborg> oh nice
20170914 16:48:40< AI0867> if so, I can resurrect it @wesnoth.org
20170914 16:48:47< loonycyborg> I think it was on gna!
20170914 16:49:03< AI0867> is that finally dead? I've been gone for 3 years
20170914 16:50:11< loonycyborg> yes
20170914 16:53:21< zookeeper> AI0867, hosting our own mailing lists? would that be a lot of work to maintain?
20170914 16:54:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170914 16:54:13< AI0867> the commits mailinglist has been up since we moved to github
20170914 16:54:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170914 16:54:26< AI0867> I run a few lists on my own server
20170914 16:55:22< shadowm> AI0867: Did you even read anything I said the other day about the web interface?
20170914 16:56:29< shadowm> It's completely broken because wesnoth.org sends a HSTS header, so at least Firefox expects to be able to use TLS with that domain regardless of the port number you use, once you've accessed https://wesnoth.org.
20170914 16:57:49< shadowm> Also the idea of hiding its existence behind a nonstandard port is more of a liability than a help in this case. I'd prefer if it was accessible from the main Apache instance somehow and without any kluges.
20170914 16:58:07< AI0867> um, I don't think so?
20170914 16:58:32< shadowm> What do you mean I don't think so?
20170914 16:58:48< AI0867> you're telling me things I don't remember reading
20170914 16:59:38< AI0867> and I agree, but HTTP port 1580 is how it was set up by someone back then
20170914 17:00:04< shadowm> I thought *you* set it up?
20170914 17:00:12< AI0867> I don't know how to change the main web VM to proxy this properly
20170914 17:00:30< shadowm> I tried the other day and it started giving me 503s instead.
20170914 17:00:30< AI0867> I set up a webserver. Someone else fixed a port forward
20170914 17:01:07< shadowm> Is there a particular time and day you'd be available to help me figure out the lighttpd side of things?
20170914 17:01:30< shadowm> (Not now. I'm busy.)
20170914 17:02:51< shadowm> Also while I was fiddling with that I discovered that the mailman config has to be entirely changed if the domain changes from wesnoth.org to say mail.wesnoth.org.
20170914 17:02:52< irker227> wesnoth: gfgtdf wesnoth:master 905f1eb39155 / src/units/filter.cpp:  fix changed bahaviour of [filter]x="" [/filter] https://github.com/wesnoth/wesnoth/commit/905f1eb391550c0228d6f4068396813259a84bcd
20170914 17:03:02< gfgtdf> Necrosporus: second attempt ^
20170914 17:03:10< shadowm> Otherwise it looks up the config for the new domain and doesn't find any mailing list.
20170914 17:05:49< AI0867> tomorrow could work. do you have a time in mind?
20170914 17:08:54< shadowm> Any time between 1 pm and 3 am UTC-03.
20170914 17:09:03-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170914 17:10:25< AI0867> I'm at +2 right now, so that's 1800-0800 for me
20170914 17:10:35< loonycyborg> AI0867: do mailing list you set up have web interface or archive?
20170914 17:10:43< AI0867> both
20170914 17:11:01< loonycyborg> and where is that for wesnoth-commits that you made?
20170914 17:11:06< AI0867> but as shadowm points out, they're based on port forwarding inside proxmox, and currently HTTP only
20170914 17:11:29< AI0867> http://wesnoth.org:1580/listinfo/dev
20170914 17:12:19< vultraz> What is this about commits?
20170914 17:14:17< AI0867> github sends an email to commits@wesnoth.org for every commit or push event (not sure which). This is a mailinglist that you can subscribe to
20170914 17:14:51< irker227> wesnoth: Jyrki Vesterinen wesnoth:master 79554179e90d / src/ (5 files in 3 dirs): Fix #1987: halo remained after killing an unit with the context menu https://github.com/wesnoth/wesnoth/commit/79554179e90d950b44381978c59835d7f021f777
20170914 17:15:46< vultraz> Why would you want such a thing
20170914 17:16:05< AI0867> it was a thing gna! did for us, until we moved the repo away
20170914 17:16:14< AI0867> it was a feature some people wanted to keep
20170914 17:17:41< vultraz> We didn't move any repo away from GNA... but beside the point. I suppose if someone finds it useful.
20170914 17:18:58< AI0867> wesnoth used to have a subversion repository, hosted by gna.org
20170914 17:19:46< vultraz> I though that was sourceforge... meh.
20170914 17:22:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170914 17:22:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170914 17:24:39< vultraz> I assume you just set up a commits ml?
20170914 17:29:47< AI0867> when we moved, yes.
20170914 17:30:26< AI0867> we briefly moved to sourceforge, but everybody (except maybe the person who did the svn→git conversion) hated it, so we moved to github
20170914 17:31:23< AI0867> and our releases have always been hosted by sourceforge, as they have the bandwidth and diskspace
20170914 17:32:06< vultraz> did we? I don't remember sf in the interim.
20170914 17:32:18< vultraz> just an immediate move to GH
20170914 17:32:24< shadowm> You remember all wrong.
20170914 17:32:27< shadowm> vultraz.
20170914 17:32:35< vultraz> but that wasn't my question
20170914 17:32:38< AI0867> it didn't last very long, but it was long enough to write the sourceforge-irker pipeline
20170914 17:32:49< AI0867> because for some reason, their git hooks don't allow web access, just mail
20170914 17:33:00< vultraz> My question is what MLs you have running right now that GNA is gone.
20170914 17:33:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170914 17:33:13< AI0867> http://wesnoth.org:1580/listinfo
20170914 17:34:42< vultraz> doesn't load
20170914 17:36:10< vultraz> shadowm: well what else is new
20170914 17:37:16-!- vn971 [~vasya@94.158.103.15] has quit [Ping timeout: 255 seconds]
20170914 17:38:09-!- gfgtdf [~chatzilla@x4e368261.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20170914 17:38:28< AI0867> as shadowm, not on firefox
20170914 17:38:37< AI0867> commits, coverity, and now dev
20170914 17:39:06< vultraz> wait, you set the dev list back up?
20170914 17:39:08< shadowm> He uses Chrome.
20170914 17:39:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170914 17:47:40-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20170914 17:50:46-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 255 seconds]
20170914 17:53:50-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170914 17:59:42-!- vn971 [~vasya@0896414046.static.corbina.ru] has joined #wesnoth-dev
20170914 18:09:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170914 18:16:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170914 18:17:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170914 19:36:23< irker227> wesnoth: gfgtdf wesnoth:master d5148f2532e4 / src/scripting/lua_common.cpp: fix missing linebreak in erromessage https://github.com/wesnoth/wesnoth/commit/d5148f2532e4b6c38456f3d5f2fbfac75656fa1f
20170914 19:38:11-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170914 19:38:45< irker227> wesnoth: Charles Dang wesnoth:master b6847141f282 / data/gui/window/addon_manager.cfg: Addon Manager: enable markup in details title https://github.com/wesnoth/wesnoth/commit/b6847141f28201f017ac6539d4b09e5284ded290
20170914 19:48:26-!- gfgtdf [~chatzilla@x4e368261.dyn.telefonica.de] has joined #wesnoth-dev
20170914 19:48:51< gfgtdf> vultraz: did you see the reprot in the forum about mising compability for old wml marku in the gui2 flg dialog ?
20170914 19:49:11< vultraz> Vaguely
20170914 19:49:14< vultraz> I'll look more
20170914 19:51:27< gfgtdf> Necrosporus: will you test issue #1992 ?
20170914 19:51:33< gfgtdf> Necrosporus: (again?)
20170914 20:07:34-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170914 20:15:04< vultraz> When in hell did multiplayer_side support the old description syntax..
20170914 20:42:30-!- travis-ci [~travis-ci@ec2-54-166-152-25.compute-1.amazonaws.com] has joined #wesnoth-dev
20170914 20:42:31< travis-ci> wesnoth/wesnoth#15004 (coverity-badge - 2058883 : Alexander van Gessel): The build passed.
20170914 20:42:31< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/275461201
20170914 20:42:31-!- travis-ci [~travis-ci@ec2-54-166-152-25.compute-1.amazonaws.com] has left #wesnoth-dev []
20170914 21:00:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170914 21:02:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170914 21:03:56-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20170914 21:18:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170914 21:20:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170914 21:38:27-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 252 seconds]
20170914 21:44:57-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Read error: Connection reset by peer]
20170914 21:45:09-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170914 21:51:48-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170914 22:13:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170914 22:13:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170914 22:26:47< irker227> wesnoth: Ignacio R. Morelle wesnoth:1.12 ea4f9a4ba2e6 / src/ (5 files in 2 dirs): campaignd: Add wrapper for atomic commits of crucial files https://github.com/wesnoth/wesnoth/commit/ea4f9a4ba2e6d49d67097368fc8b083d3402c629
20170914 22:26:50< irker227> wesnoth: Ignacio R. Morelle wesnoth:1.12 17197cff8162 / src/campaign_server/campaign_server.cpp: campaignd: Increase verbosity of filesystem::io_exception exceptions https://github.com/wesnoth/wesnoth/commit/17197cff8162842f4887e009976a990b4179521d
20170914 22:39:21< gfgtdf> shadowm: #818 is marked as 'backport' but i don't see similar code on master, am i missing something ?
20170914 22:42:21< shadowm> Yes.
20170914 22:46:49< shadowm> How to cmake.
20170914 22:46:58< shadowm> How do I cmake in master.
20170914 22:47:17< shadowm>   GetSources("campaignd campaignd_SRC)
20170914 22:47:22< shadowm> And this refers to...?
20170914 22:48:15< shadowm> How do I add a source file to the CMake recipe in master?
20170914 22:48:38< shadowm> Or the SCons recipe for that matter.
20170914 22:48:40< shadowm> What is this.
20170914 22:48:59< vultraz> shadowm: wesnoth/source_lists
20170914 22:49:14< vultraz> AFAIK scons and cmake share that
20170914 22:49:24< shadowm> vultraz you're the goddamn release manager.
20170914 22:49:31< shadowm> Don't go "as far as I know" on me.
20170914 22:49:40< shadowm> You're supposed to know this crap with absolute 100% certainty.
20170914 22:49:44< vultraz> I know nothing about cmake or scons 
20170914 22:49:51< shadowm> You're still in charge.
20170914 22:49:54< shadowm> Right?
20170914 22:50:02< vultraz> I'm almost certain the point of that change was so they shared source lists
20170914 22:50:15< vultraz> but as you love to point out, I don't remember shit so why take my word for it
20170914 22:50:17< vultraz> :|
20170914 22:50:36< shadowm> Why not try harder to remember stuff then :|
20170914 22:50:57< shadowm> Also I just said that today in response to your factually wrong version of the repository move story.
20170914 22:52:08< vultraz> oh, come on, you've frequently said similar things with what comes across as haughty derision of the "geez this idiot can't remember shit" variety
20170914 22:52:29< shadowm> It's usually not that you can't remember stuff.
20170914 22:53:52< shadowm> It's usually that you can't be bothered to understand or thoroughly research stuff.
20170914 22:55:13< shadowm> Now, picture this hypothetical scenario: I'm a new contributor, I don't know any of you people. I want to contribute code and I ask that question and I notice that the person responding to me is a project admin.
20170914 22:55:28< shadowm> How am I supposed to feel about there being a sliver of doubt in what you're telling me?
20170914 22:58:09-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170914 22:58:11< vultraz> You would rightly feel hesitant about the effectiveness of the leadership and the quality of the project. 
20170914 22:58:35-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170914 22:58:36< vultraz> But also please keep in mind that I've left certain areas of the project to the people who actually know how to work with them.
20170914 23:00:06< vultraz> I'm giving you the info I have - that sources_list is the place to add new files - and telling you, honestly, that I'm almost sure cmake and scons share that folder.
20170914 23:00:59< shadowm> Yep, much appreciated. Thanks.
20170914 23:02:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Read error: No route to host]
20170914 23:03:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170914 23:04:43< shadowm> vultraz: The icon for updating an installed add-on on the add-ons manager is an upwards pointing arrow. You do realize this is normally understood to signify an *upload* rather than a download, right?
20170914 23:04:58< vultraz> hmmm...
20170914 23:05:10< shadowm> Wait, is this the publish functionality?
20170914 23:05:20< shadowm> It says Update.
20170914 23:05:44< shadowm> And it brings up the confirmation dialog for downloads when I click on it "the add-on blah blah alreayd installed, will lose VCS information in it if i continue".
20170914 23:06:12< vultraz> the blue up arrow is update
20170914 23:06:16< vultraz> the green up arrow is publish
20170914 23:06:31< vultraz> I can see how this would be confusing ... 
20170914 23:06:38< shadowm> Yeah, but the blue arrow brings up the confirmation dialog I mentioned.
20170914 23:07:10< vultraz> well... isn't it supposed to? updating overwrites local content
20170914 23:07:21< shadowm> No, because I'm publishing TO the server, right?
20170914 23:07:45< vultraz> that's the green arrow
20170914 23:07:59< shadowm> Sigh okay I see.
20170914 23:08:34< shadowm> You must use a down arrow for anything that is a download and an up arrow for uploads, that's the universal convention.
20170914 23:08:50< shadowm> The colour is irrelevant (especially since not everyone sees colours the same way).
20170914 23:09:13-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170914 23:09:14< vultraz> ok, so blue *down* arrow for update?
20170914 23:09:31< shadowm> If by update you mean "download the latest version onto my machine", yes.
20170914 23:09:39-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170914 23:09:45< vultraz> ok
20170914 23:09:49< shadowm> If by update you mean "upload the version on my machine onto the server" then no.
20170914 23:09:53< vultraz> former
20170914 23:11:38< vultraz> aghh
20170914 23:12:15< vultraz> where the hell did i put that
20170914 23:13:08< vultraz> i might have thrown it out
20170914 23:13:46< vultraz> why would i do that
20170914 23:14:01-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170914 23:14:31< irker227> wesnoth: Ignacio R. Morelle wesnoth:master 28c51796362e / / (4 files in 2 dirs): campaignd: Add wrapper for atomic commits of crucial files https://github.com/wesnoth/wesnoth/commit/28c51796362e83dcb6232713c1f7ba6c3f3a3f53
20170914 23:14:34< irker227> wesnoth: Ignacio R. Morelle wesnoth:master a380128ade75 / src/campaign_server/campaign_server.cpp: campaignd: Increase verbosity of filesystem::io_exception exceptions https://github.com/wesnoth/wesnoth/commit/a380128ade758dc2b359d44e24b218e60d11e98b
20170914 23:16:44< vultraz> (that reminds me, i was going to do some formatting to the licensing prompt)
20170914 23:20:44< vultraz>  Cannot open include file: 'unistd.h': No such file or directory
20170914 23:21:45< vultraz> shadowm: is this a non-windows file?
20170914 23:22:36< shadowm> Wha. Are you trying to build campaignd on Windows?
20170914 23:23:05< vultraz> well it's part of the VS (which I'm now using) solution
20170914 23:23:19< vultraz> so it gets tangentially built 
20170914 23:23:21< shadowm> Oh joy.
20170914 23:23:28< shadowm> Give me a moment.
20170914 23:23:46< shadowm> In fact, let me see if I'm even able to crossbuild this anymore.
20170914 23:26:11< shadowm> Okay, fixed.
20170914 23:26:14< irker227> wesnoth: Ignacio R. Morelle wesnoth:1.12 ba972248dbe4 / src/campaign_server/fs_commit.cpp: campaignd: Missed moving a POSIX include into the Windows block https://github.com/wesnoth/wesnoth/commit/ba972248dbe47fa5b65a337d977d70133baf1ab8
20170914 23:26:21< irker227> wesnoth: Ignacio R. Morelle wesnoth:master 6cec22a8e113 / src/campaign_server/fs_commit.cpp: campaignd: Missed moving a POSIX include into the Windows block https://github.com/wesnoth/wesnoth/commit/6cec22a8e113ab3d5dd8f8be4ae2705056e05069
20170914 23:29:32< irker227> wesnoth: Charles Dang wesnoth:master cb99d90dc096 / projectfiles/VC12/campaignd.vcxproj: Updated MSVC campaignd projectfile for 28c51796362e https://github.com/wesnoth/wesnoth/commit/cb99d90dc096775411622423200d92270a386176
20170914 23:34:02< vultraz> shadowm: would it be possible to have the licensing terms in an external text file that campaignd reads?
20170914 23:35:46< shadowm> Yes.
20170914 23:36:03< shadowm> Or in the config.
20170914 23:36:17< shadowm> I don't know. Depends on exactly what you want to have, really.
20170914 23:37:15< vultraz> was just thinking of a cfg file in data/.
20170914 23:37:29< shadowm> campaignd can't see data/.
20170914 23:37:37< shadowm> It's simply not within its reach in our set-up.
20170914 23:37:43< vultraz> I see
20170914 23:38:05< shadowm> All the configurable stuff is within the server.cfg.
20170914 23:39:15< vultraz> where be this?
20170914 23:39:30< shadowm> On the server.
20170914 23:39:39< vultraz> I see.
20170914 23:39:58< vultraz> meh, I'll just commit this formatting change and worry about possibly moving it later.
20170914 23:40:16< shadowm> It looks like this if you're curious: https://pastebin.com/H5qeJmZT
20170914 23:40:53< shadowm> If you want a new feature added I may consider it (just be warned that my C++11 is rusty).
20170914 23:41:38< irker227> wesnoth: Charles Dang wesnoth:master 615c57b8163d / src/campaign_server/campaign_server.cpp: Campaign Server: reformat licensing terms prompt https://github.com/wesnoth/wesnoth/commit/615c57b8163dc6df8075baf98bc944c29cddb4b6
20170914 23:42:27< shadowm> That's going to include all the leading whitespace into the message?
20170914 23:42:42< vultraz> is it?
20170914 23:42:47< shadowm> I don't know?
20170914 23:42:49< shadowm> I'm asking you.
20170914 23:43:04< vultraz> I don't know. I can't test it.
20170914 23:43:09< shadowm> AFAIK that's a raw string literal and that means *everything in it* goes into it.
20170914 23:43:29< vultraz> I'll fix it if it's weird when the updated campaignd is deployed.
20170914 23:43:30< shadowm> And GUI2 did not strip leading or trailing whitespace from lines last time I checked.
20170914 23:43:46< shadowm> Okay, if you really want I'll test it now.
20170914 23:45:34< vultraz> would be much appreciated 
20170914 23:48:42-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170914 23:50:02< shadowm> https://cdn.discordapp.com/attachments/259976436490829825/358036662959472640/unknown.png
20170914 23:50:09< shadowm> Like I told you. Raw string literal, includes everything.
20170914 23:51:07< shadowm> vultraz: Please also add a colon at the end of that initial paragraph.
20170914 23:51:15< shadowm> Although, really.
20170914 23:51:30< shadowm> How about I revise instead?
20170914 23:51:37< vultraz> sure.
20170914 23:51:54< vultraz> Do you think the paths should be italicized?
20170914 23:52:16< shadowm> I mean, sure, but I don't think the server enables markup on these messages, does it?
20170914 23:52:17< celticminstrel> Is this string translatable? Can it be somehow made so?
20170914 23:52:21< shadowm> It is not.
20170914 23:52:37< celticminstrel> IMO it really should be, but that might be difficult...
20170914 23:52:39< shadowm> None of the campaignd messages are translatable. Feel free to work on that (it *is* doable, btw).
20170914 23:53:07< celticminstrel> I guess we'd need to send the language code to the server and have it look up a message based on that.
20170914 23:53:12< shadowm> No, not really.
20170914 23:53:16-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170914 23:53:23< vultraz> well since it ends up in GUI2 as long as the prompt has markup enabled it will be parsed. I think.
20170914 23:53:36< celticminstrel> I mean sure you could bake the message into the client, but...
20170914 23:53:37< shadowm> Just let the server send the untranslated messages, use N_() markers in the code, and have the client try to see if they are translatable.
20170914 23:54:14< shadowm> Also, this is a bit of a moot point if vultraz decides the message should be in the server configuration instead.
20170914 23:54:21< celticminstrel> This is problematic if someone decides to set up a custom campaignd though. Not that I think that's likely, but...
20170914 23:54:42< shadowm> More to the point, I think scaring people with a text wall in English is the best approach in this case.
20170914 23:54:46< celticminstrel> Putting it in the server configuration seems like a decent idea, but again... ideally it would be translatable.
20170914 23:54:53< shadowm> They *have* to read PblWML on the wiki to get here anyway.
20170914 23:55:28< irker227> wesnoth: ln-zookeeper wesnoth:master fe250f02f453 / changelog players_changelog: Updated changelogs https://github.com/wesnoth/wesnoth/commit/fe250f02f4538e181ee9e608233022599f7e03c8
20170914 23:56:52-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170914 23:57:07-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6999:1ab2:4947:32b3] has joined #wesnoth-dev
20170914 23:59:20< shadowm> vultraz: Does the prompt have markup enabled?
--- Log closed Fri Sep 15 00:00:15 2017