--- Log opened Sun Sep 17 00:00:58 2017
20170917 00:17:46< celticminstrel> EliDupree: You can probably just use the line "ilua.strict = false" to disable that behaviour; or if you prefer not to disable it, I think you could use "rawget(_G, some_var)" to bypass it for a single test.
20170917 00:20:03< celticminstrel> I thought we reverted the empty tags thing?
20170917 00:20:55< celticminstrel> gfgtdf: Have you checked to make sure all your work is recorded in the changelog?
20170917 00:25:34< gfgtdf> celticminstrel: hmm i think i didn't do that much changes since last time, postly some bugfixes
20170917 00:25:51< celticminstrel> I see.
20170917 00:26:00< celticminstrel> Wouldn't hurt to check though.
20170917 00:27:17< gfgtdf> ye the empty tag things was reverted, also i do reccomend not to disable strict lua, it even found some bugs in mainline when we added it.
20170917 00:32:02-!- irker677 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170917 00:32:02< irker677> wesnoth: gfgtdf wesnoth:master 260a57f07e98 / changelog: Update changelog https://github.com/wesnoth/wesnoth/commit/260a57f07e98c583c4dfc3b3e11d80b8c4896bad
20170917 00:32:37-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170917 00:32:58< vultraz> EliDupree: put it high up in your lua load order
20170917 00:33:39< EliDupree> my what?
20170917 00:44:47< gfgtdf> EliDupree: you can also create a metatable to raw global access like "globals = set_metatable { __index = function(...) return rawget(...) end}" if you havea lot of raw global accesses
20170917 00:45:15< EliDupree> No, I only had the one, and I removed it
20170917 00:46:08< vultraz> There's always at least a [lua] tag included from _main.cfg
20170917 00:46:28< vultraz> Where you usually put wesnoth.require calls
20170917 00:46:43< vultraz> You can out global variables there for example
20170917 00:46:53< vultraz> Either in the lua tag or any files it includes
20170917 00:47:23< EliDupree> I already explained why that doesn't work in my situation, but anyway, the problem is resolved so I don't need anymore help
20170917 01:02:25< vultraz> Alright
20170917 01:11:16-!- gfgtdf [~chatzilla@x4e368c66.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 55.0.3/20170824053622]]
20170917 01:19:45< celticminstrel> Fun fact: the ... in gfgtdf's code is valid Lua and would give the intended result.
20170917 01:20:06< celticminstrel> (Though I'd rather write out the args explicitly as (k, v).)
20170917 01:41:07< irker677> wesnoth: Severin Glöckner wesnoth:master 8c2bdba598f3 / doc/man/wesnoth.6: manpage, small corrections https://github.com/wesnoth/wesnoth/commit/8c2bdba598f30329760e8b86808afc4a3ce663c3
20170917 01:41:14< sevu> doofus-01 terrain changes are not in the changelog yet. He added a ruined encampment and did _something_ with the gates
20170917 01:42:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170917 01:56:49< irker677> wesnoth: Severin Glöckner wesnoth:master fa8ca31f7cbb / data/campaigns/The_South_Guard/scenarios/03_A_Desparate_Errand.cfg: TSG S3: Ethiliel is a shyde (#2005) https://github.com/wesnoth/wesnoth/commit/fa8ca31f7cbbf70c7d2f00145c3a030bc536693d
20170917 02:01:37< celticminstrel> I'll include doofus in my commit scan then, I guess.
20170917 02:02:23< celticminstrel> What category would that go under?
20170917 02:02:58< sevu> Graphics
20170917 02:04:50< sevu> new terrain: ruined encampment or alike
20170917 02:05:30-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:89ac:a80a:ec93:cba5] has joined #wesnoth-dev
20170917 02:10:56-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:89ac:a80a:ec93:cba5] has quit [Remote host closed the connection]
20170917 02:19:45-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:89ac:a80a:ec93:cba5] has joined #wesnoth-dev
20170917 02:19:51< vultraz> Well I actually could preside over a release now
20170917 02:20:10< celticminstrel> I'm still scanning commits for potential changelog entries though.
20170917 02:20:56-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:89ac:a80a:ec93:cba5] has quit [Remote host closed the connection]
20170917 02:21:07< vultraz> But I'm sitting on a couch in Tokyo airport and really feel too lazy
20170917 02:25:00< vultraz> So you can changelog
20170917 02:26:00< celticminstrel> vultraz: Can you remember anything you've done recently that may need an entry?
20170917 02:26:13< celticminstrel> I only saw one, maybe two things that seemed worth noting.
20170917 02:26:21< vultraz> Have you gotten all the improvements to the addon manager?
20170917 02:26:24< celticminstrel> (Considering only your commits.)
20170917 02:26:25< vultraz> Stuff like
20170917 02:26:45< vultraz> No longer closes when canceling client ops like install?
20170917 02:27:14< vultraz> The new Publishable filter
20170917 02:27:24< vultraz> Whole bunch of fixes
20170917 02:27:36< celticminstrel> I don't have any of these.
20170917 02:28:06-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170917 02:46:33< irker677> wesnoth: Celtic Minstrel wesnoth:master 703b597275d2 / changelog: Update changelog on behalf of @Vultraz and @doofus-01 https://github.com/wesnoth/wesnoth/commit/703b597275d2c983040d2ac29489e253732cb7e5
20170917 02:46:35< irker677> wesnoth: Celtic Minstrel wesnoth:master a4f3f687d14d / changelog: Fix spelling in changelog https://github.com/wesnoth/wesnoth/commit/a4f3f687d14d9d448ed75cafbe58d0fb868a9ab7
20170917 02:51:25-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170917 02:53:20-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170917 02:56:06< sevu> merging #1939 for 1.13.9?
20170917 03:00:45< celticminstrel> I guess we can leave that up to zookeeper?
20170917 03:01:41< sevu> yeah
20170917 03:12:03< sevu> * Gates have now new terrain codes which grant more control for map makers; the old codes are now deprecated. (#1839 )
20170917 03:12:53< celticminstrel> So it's already there?
20170917 03:12:58< celticminstrel> Or you're telling me to add it?
20170917 03:13:24< sevu> could you add it ?
20170917 03:14:32< celticminstrel> And what category would that go it?
20170917 03:16:14< sevu> as well to Graphics, to the other terrain 
20170917 03:18:13-!- sigurdfd [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20170917 03:21:08< irker677> wesnoth: Celtic Minstrel wesnoth:master 15302a54e89d / changelog: One more changelog entry https://github.com/wesnoth/wesnoth/commit/15302a54e89d0feccaebe8be0b6b1e2183972693
20170917 03:30:09< sevu> #1914 and #1778 maybe
20170917 03:30:38< sevu> other than that I don't find anything anymore
20170917 03:40:24< irker677> wesnoth: sigurdfdragon wesnoth:master 8d2124104edf / players_changelog: Rewrap players changelog to 80 columns https://github.com/wesnoth/wesnoth/commit/8d2124104edf0447fdc7ebf09efbb56b37f083fb
20170917 03:41:33< celticminstrel> ...didn't I just do that.
20170917 03:41:52< celticminstrel> Oh wait, that was the other changelog.
20170917 03:43:18-!- sevu [~Shiki@p54854C9E.dip0.t-ipconnect.de] has quit [Quit: Verlassend]
20170917 03:48:43-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170917 03:57:57< vultraz> I wish we could stop doing that
20170917 04:03:00< celticminstrel> I really don't think there's a problem with it.
20170917 04:06:50-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:104f:9c9a:4bca:f3d4] has joined #wesnoth-dev
20170917 04:10:24< DeFender1031> doing what?
20170917 04:10:57-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:104f:9c9a:4bca:f3d4] has quit [Ping timeout: 246 seconds]
20170917 04:15:13< vultraz> 80 character line limit in the changelog like we're all using Linux terminals
20170917 04:19:42< DeFender1031> Aren't we? :P
20170917 04:20:04< DeFender1031> Also, why not just have that done automatically?
20170917 04:22:01< shadowm> Because Linux terminals are well-known for being limited to 80x25: https://cdn.discordapp.com/attachments/318827821567049737/358829795116580874/unknown.png
20170917 04:24:14-!- sigurdfd [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has quit []
20170917 04:37:27< celticminstrel> vultraz: http://steamcommunity.com/workshop/filedetails/discussion/729138129/1470841629665938447
20170917 04:38:17< vultraz> Alright
20170917 05:22:03-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20170917 05:34:37-!- Coffee_irc [~david@61.68.88.11] has quit [Ping timeout: 260 seconds]
20170917 05:35:03-!- Coffee_irc [~david@203.63.42.216] has joined #wesnoth-dev
20170917 06:03:59-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170917 06:13:40-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170917 06:14:35-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170917 06:41:59-!- irker677 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170917 06:59:58-!- mjs-de [~mjs-de@x4db5a0b4.dyn.telefonica.de] has joined #wesnoth-dev
20170917 07:07:40-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:49c6:3ede:260e:857c] has joined #wesnoth-dev
20170917 07:16:04-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170917 07:21:43-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170917 07:26:44< Bhoren> hi
20170917 07:32:26-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170917 07:45:11-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20170917 07:59:26-!- irker343 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170917 07:59:26< irker343> wesnoth: Jyrki Vesterinen wesnoth:master 12661c6e8a36 / src/gui/widgets/scrollbar_container.cpp: Version dialog: fix library versions not showing up with some languages https://github.com/wesnoth/wesnoth/commit/12661c6e8a36aba6bf7dc5a5191fff571499db78
20170917 08:01:03-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170917 09:25:30< Kwandulin> Mhhh, :debug next_level ends a MP campaign
20170917 09:35:41-!- louis94 [~~louis94@121.83-247-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20170917 09:38:51-!- louis94 [~~louis94@121.83-247-81.adsl-dyn.isp.belgacom.be] has quit [Client Quit]
20170917 09:40:06-!- louis94 [~~louis94@121.83-247-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20170917 10:07:08-!- louis94 [~~louis94@121.83-247-81.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 240 seconds]
20170917 10:09:42-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170917 10:21:03-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170917 10:50:07-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170917 10:57:37-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170917 10:57:56-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170917 10:58:18< vultraz> alright what's the status on everything?
20170917 10:58:42< vultraz> did celmin get all the changelogs updated?
20170917 10:59:30-!- irker343 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170917 11:04:54< vultraz> zookeeper: did you get all the utbs stuff done you wanted?
20170917 11:07:57< vultraz> ok seriously is literally no one around right now
20170917 11:08:08< zookeeper> kinda sorta. there's still a bunch of balancing issues i should figure out some kind of solution to, but it's hard.
20170917 11:08:31< vultraz> alright. that can be for 1.13.10
20170917 11:08:40< zookeeper> well, there's one remaining thing i might as well put in
20170917 11:09:46< vultraz> please merge the stone terrain
20170917 11:09:55< vultraz> stone floor
20170917 11:10:46< zookeeper> of course
20170917 11:10:56< vultraz> anyway you guys still have time to fix stuff
20170917 11:11:35< vultraz> am writing this from 5 miles in the sky and sadly the internet kindaaaa sucks :P
20170917 11:12:00< vultraz> so im not dealing with the release and tagging right now even though i still have like
20170917 11:12:41< zookeeper> oh. wonders of the modern world, indeed.
20170917 11:13:03< vultraz> get what you want merged, someone ask jyrki or someone to merge tad's coverity fix PRs if they're done
20170917 11:13:35< vultraz> get celmin to implement that auto-redraw on recall PR and look into the urgent-yet-random lua issue
20170917 11:14:01< vultraz> anything else postpone
20170917 11:14:37-!- irker485 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170917 11:14:37< irker485> wesnoth: Sofartin wesnoth:master 2e8ef7a7a79c / data/core/about_i18n.cfg: Add new Czech translators https://github.com/wesnoth/wesnoth/commit/2e8ef7a7a79c061663f3e5976382b98464ed69ef
20170917 11:14:49< vultraz> (just merged that, im assuming the data is right)
20170917 11:15:05< vultraz> if loonycyborg can run the pot update soon too that would be great.
20170917 11:16:24< vultraz> once i get to the states ill push that stacked widget fix
20170917 11:16:48< vultraz> needs some polish but i mostly have it running local
20170917 11:17:14< zookeeper> just don't run the pot update _yet_
20170917 11:17:35< vultraz> zookeeper: and yes, indeed. it is nice to have in-flight internet. just wish it were a bit faster. and didn't cost $$
20170917 11:18:09< vultraz> but still, this way i get to command all my minions from the heavens :3
20170917 11:18:40< vultraz> (jk. you guys aren't minions :P )
20170917 11:18:52< vultraz> but seriously, get those things done.
20170917 11:19:43< vultraz> let loony known when he should run the update but just get it in. and some pre-release testing would be good too.
20170917 11:20:38< loonycyborg> afaik they used to even forbid to use phones on planes in the past
20170917 11:20:56< vultraz> did they?
20170917 11:20:56< loonycyborg> for fears of interfering with plane's electronics
20170917 11:21:04< vultraz> oh yeah
20170917 11:21:13< loonycyborg> this is why phones still have "airplane mode"
20170917 11:21:14< vultraz> well they kinda still do somewhat? at least for takeoff and landing
20170917 11:21:39< DeFender1031> I read somewhere that that explanation was utter BS and it was actually so that people wouldn't be distracted and not listening to the flight attendants.
20170917 11:21:54< vultraz> i believe i also heard something like that
20170917 11:22:09< vultraz> i mean, sadly, who actually pays attention to the safety demo xD
20170917 11:22:34< DeFender1031> I do. Those things are usually hilarious
20170917 11:22:48< vultraz> united's (what Im on right now) is rather boring
20170917 11:23:01< vultraz> other airlines' are more fun :/
20170917 11:24:33< vultraz> DeFender1031: and half the time it's just a live demo and no video
20170917 11:24:35< vultraz> so
20170917 11:24:58< DeFender1031> Eh, I usually fly international...
20170917 11:25:04< DeFender1031> Those are always videos.
20170917 11:25:14< vultraz> nope
20170917 11:25:16< vultraz> not always
20170917 11:25:19-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:49c6:3ede:260e:857c] has quit [Quit: Leaving]
20170917 11:25:23< DeFender1031> O_o
20170917 11:25:33< vultraz> only if the plane actually has seatback screens
20170917 11:25:43< DeFender1031> To canada doesn't count.
20170917 11:26:01< vultraz> just where do you think i live xD
20170917 11:26:12< DeFender1031> ...
20170917 11:26:16< DeFender1031> Wait, you're canadian?
20170917 11:26:23< vultraz> No! xD
20170917 11:26:31< vultraz> that's celmin
20170917 11:26:48< DeFender1031> Are you not in the US?
20170917 11:26:53< vultraz> nope
20170917 11:26:55< vultraz> i live in micronesia
20170917 11:26:59< vultraz> in the middle of the pacific
20170917 11:27:08< vultraz> meaning to get to the us i fly a fuckton of international :P
20170917 11:27:14< DeFender1031> Huh. Why did I think you were in the US?
20170917 11:27:21< DeFender1031> Yeah, you would.
20170917 11:27:22< vultraz> Im from the US tho
20170917 11:27:29< DeFender1031> Maybe that's why
20170917 11:27:48< vultraz> it's a nice, pleasant 30-40 hour journey :3
20170917 11:28:15< DeFender1031> Are you closer to australia than mainland US?
20170917 11:28:22< vultraz> probably.
20170917 11:28:33< DeFender1031> Dang.
20170917 11:28:44< vultraz> as we speak im flying from tokyo to DC.
20170917 11:28:52< DeFender1031> So then I'm very confused. You have international flights on planes without screens?
20170917 11:28:58< vultraz> yes.
20170917 11:29:32< DeFender1031> Are they small planes or just crap old planes?
20170917 11:29:42< vultraz> no
20170917 11:29:42< DeFender1031> Ah, DC.
20170917 11:29:52< vultraz> right now im on a 777
20170917 11:29:55< vultraz> which does have a screen
20170917 11:29:58< vultraz> but it sucks 
20170917 11:30:09< DeFender1031> Say hi to it for me.
20170917 11:30:19< vultraz> earlier i was flying from guam to tokyo
20170917 11:30:21< vultraz> on a 777
20170917 11:30:26< vultraz> without screens
20170917 11:30:42< DeFender1031> Is DC your destination?
20170917 11:30:49< vultraz> United has this thing where you can stream entertainment to your tablet/laptop/phone via their app
20170917 11:31:03< vultraz> so screens aren't really necessary 
20170917 11:31:10< vultraz> do other airlines not do that
20170917 11:31:15< vultraz> (no it isn't)
20170917 11:31:23< vultraz> (and damn this turbulence)
20170917 11:32:21< vultraz> DeFender1031: actually, older planes will be the ones WITH screens
20170917 11:32:46< vultraz> older and/or less recently remodeled 
20170917 11:32:59< DeFender1031> Huh. I didn't realize we'd passed the window of planes having screens and had begun to revert to not.
20170917 11:33:13< DeFender1031> I was on a dreamliner in april and they had screens...
20170917 11:33:29< vultraz> i mean yeah, some newer ones do
20170917 11:33:33< vultraz> it's not really consistent
20170917 11:34:07< DeFender1031> It reminds me of the window where cell phones were getting smaller.
20170917 11:34:16< vultraz> like why the hell does this plane have suck-ass 10 year old screens while the other one didn't and instead had a seatback mount for your tablets
20170917 11:34:36< vultraz> (which is something i hadn't seen before)
20170917 11:35:16< vultraz> might have something to do with the united/continental merger in the late 2010s
20170917 11:35:30< vultraz> they ended up with a mixed fleet of planes
20170917 11:35:58< vultraz> and they might have prioritized updates to some
20170917 11:36:17< vultraz> i dunno if they're actually *removing* screens or some just never had them or idk
20170917 11:36:28< vultraz> almost every flight has the personal streaming which is better anyway
20170917 11:36:34< irker485> wesnoth: ln-zookeeper wesnoth:master 5027d5460037 / / (4 files in 2 dirs): UtBS: Changed lvl1 Quenoth Scout's bolas to a sling (no slows) https://github.com/wesnoth/wesnoth/commit/5027d54600372c07e0d8adf6a7328c5958398363
20170917 11:36:47< vultraz> unless you weren't in economy the seatback screens were shit :P
20170917 11:37:17< wedge009> vultraz: Didn't think you would actually be on-line while in-flight, but if you're paying for it that makes sense.
20170917 11:37:49< vultraz> bumpy bumpy bumpy :|
20170917 11:38:40< wedge009> loonycyborg: DeFender1031: vultraz: Regarding phone usage in-flight, it's a case of being better safe than sorry. While modern jets are probably hardened against most EMI, with the myriad of phones around there's bound to be some new-fangled phone that does something special. And there have been cases of air crashes caused malfunctions due to phone usage.
20170917 11:39:28< vultraz> yeah
20170917 11:39:39< wedge009> vultraz: DeFender1031: I travel enough to know most of what they say during the video/demonstrations, but I still pay a bit of attention. They still have to do it every flight regardless because there's always going to be someone new to flying.
20170917 11:39:52< vultraz> yeah
20170917 11:39:53< vultraz> same
20170917 11:40:00< vultraz> i do pay attention myself
20170917 11:40:11< vultraz> but i travel enough that i know it all by now :P
20170917 11:40:20< DeFender1031> wedge009, and new to seatbelts, apparently :P
20170917 11:40:35< vultraz> indeed :P
20170917 11:41:08< vultraz> anyway just have a few minutes left before my internet time runs out and i don't really want to put more $ into it
20170917 11:41:09< wedge009> vultraz: The one time I travelled where the plane had tablets instead of traditional built-in screens, while the screen itself was nice, the reception was awful and wireless connection kept dropping out.
20170917 11:41:28< vultraz> it happens sometimes
20170917 11:41:29< vultraz> :(
20170917 11:41:47< wedge009> DeFender1031: There's more than just seatbelts, obviously.
20170917 11:41:48< vultraz> i mean it is satellite internet so if there are clouds or smth it could be spotty
20170917 11:41:49< Necrosporus> What is WFL?
20170917 11:41:54< DeFender1031> vultraz, in case you cut out before I can say it later, have a pleasant remaining journey.
20170917 11:42:14< vultraz> i shall enjoy the next 7.5 hours of flying :P
20170917 11:42:16< DeFender1031> Necrosporus, Wesnoth Formula Language.
20170917 11:42:18< wedge009> Crossed the date line yet?
20170917 11:42:22< vultraz> dunno
20170917 11:42:36< DeFender1031> vultraz, "enjoy" sounds like too strong a word...
20170917 11:42:44< DeFender1031> (At least, *I* hate flying.*
20170917 11:42:44< vultraz> xD
20170917 11:42:46< DeFender1031> )*
20170917 11:42:51< vultraz> I love flying
20170917 11:42:53< wedge009> vultraz: I meant local wireless. Couldn't have a consistent connection to the local flight entertainment, movie kept dropping out.
20170917 11:42:56< vultraz> the more flying the better
20170917 11:43:01< wedge009> I enjoy flying too, usually.
20170917 11:43:03< DeFender1031> vultraz, how tall are you?
20170917 11:43:15< vultraz> wedge009: oh yeah that happened to me this past february
20170917 11:43:26< Necrosporus> DeFender1031, maybe in changelog it could be change to something known to people who are not wesnoth devs?
20170917 11:43:30< vultraz> DeFender1031: bit under 6 ft. 5'10 thereabouts?
20170917 11:43:33< vultraz> i dunno exactly
20170917 11:43:38< vultraz> could be lower
20170917 11:43:40< wedge009> Don't get that with traditional built-in screens.
20170917 11:43:46< vultraz> so let's say between 5'8 and 6'
20170917 11:43:49< vultraz> somewhere there
20170917 11:43:51< Necrosporus> s/WFL/WFL (Wesnoth Formula Language)/
20170917 11:43:52< DeFender1031> vultraz, that might have something to do with it... I'm over 6 feet
20170917 11:43:56< vultraz> ahh
20170917 11:44:03< wedge009> Yeah, one of the few advantages of being small.
20170917 11:44:05< vultraz> yeah you need business class :P
20170917 11:44:20< vultraz> or economy plus 
20170917 11:44:20< DeFender1031> And nor am I the thinnest of gentlemen.
20170917 11:44:39< wedge009> I'm 161cm/5'3", so I'm usually fine with economy.
20170917 11:44:40< vultraz> definitely need business class then :P
20170917 11:44:50< vultraz> o_o
20170917 11:44:57< wedge009> That said, I did fly business class once. It was nice.
20170917 11:44:58< vultraz> this surprises me
20170917 11:45:00< DeFender1031> Sure, I've got a spare $6000 for every time I fly, no problem.
20170917 11:45:15< vultraz> :P
20170917 11:45:22< wedge009> Mum's friend works for Air Mauritius, we got business class seats one time.
20170917 11:45:44< DeFender1031> Someday, I'll be a billionaire.
20170917 11:46:06< wedge009> I've had friends fly first class on those loyalty schemes and what-not. I don't know how that works.
20170917 11:46:07< vultraz> or get a job that sends you places
20170917 11:46:10< vultraz> acquire air miles
20170917 11:46:18< vultraz> use miles for free flying
20170917 11:46:18< wedge009> Heh, I always fly economy for work.
20170917 11:46:35< wedge009> But then, that's only domestic.
20170917 11:46:43< vultraz> what is?
20170917 11:46:52< wedge009> My work flights.
20170917 11:46:56< vultraz> ah
20170917 11:46:58< vultraz> sucks
20170917 11:47:02< vultraz> thou need international!
20170917 11:47:04< vultraz> :P
20170917 11:47:14< wedge009> Nah, Sydney to Melbourne and Sydney to Brisbane is only just over an hour.
20170917 11:47:25< vultraz> sadly the reward miles system is rigged in favor of those who fly a ton
20170917 11:47:33< vultraz> anyway im out here
20170917 11:47:39< vultraz> cya guys later
20170917 11:47:43< DeFender1031> vultraz, wouldn't want a job that sends me places... I hate flying. :P
20170917 11:47:45< wedge009> Get some sleep.
20170917 11:47:57< DeFender1031> Alright, see ya on the other side.
20170917 11:48:53-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170917 11:53:03-!- markus_ [~mjs-de@x4e3136f4.dyn.telefonica.de] has joined #wesnoth-dev
20170917 11:56:32-!- mjs-de [~mjs-de@x4db5a0b4.dyn.telefonica.de] has quit [Ping timeout: 255 seconds]
20170917 12:02:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170917 12:18:26-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170917 12:40:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170917 12:40:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170917 12:52:52< Necrosporus> vultraz, by live demo do you mean girls in uniform?
20170917 12:52:55< irker485> wesnoth: Gregory A Lundberg wesnoth:master c6f523f8cd7b / src/ (6 files in 4 dirs): Fix Coverity Uninitialized Scalar Warnings https://github.com/wesnoth/wesnoth/commit/c6f523f8cd7ba3636f68e08aff6087f8a4b021d6
20170917 12:53:22< irker485> wesnoth: Gregory A Lundberg wesnoth:master 7c3d78951403 / src/display.cpp: Fix Coverity divide-by-zero warning https://github.com/wesnoth/wesnoth/commit/7c3d78951403ddf656b15cdf2ae83354a76dc177
20170917 12:53:34< irker485> wesnoth: Gregory A Lundberg wesnoth:master 0bd159b8b707 / src/gui/widgets/tree_view_node.cpp: Fix Coverity null dereferenced warning https://github.com/wesnoth/wesnoth/commit/0bd159b8b70707e24cf70f5db7b4e8ecd5910fdf
20170917 12:55:56-!- gfgtdf [~chatzilla@x4e368c66.dyn.telefonica.de] has joined #wesnoth-dev
20170917 12:56:42< gfgtdf> JyrkiVesterinen: why did you merge all there ors? there are obvious disagreement in the discusson
20170917 12:57:00< JyrkiVesterinen> Because Vultraz asked me to, see the IRC logs.
20170917 12:57:25< Necrosporus> wedge009, the thing is some prohibit not just use of phones (even if you put them in airplane mode) but even of digital cameras and stuff like that, which has negligible emission
20170917 12:57:28< gfgtdf> then why can vultraz do it himself?
20170917 12:57:33< gfgtdf> can't
20170917 12:58:22< JyrkiVesterinen> He wanted someone to review the PRs first and didn't have time to do it himself.
20170917 12:58:42< JyrkiVesterinen> (Especially because the time he could use the Internet in the airplane was limited.)
20170917 12:59:36< gfgtdf> JyrkiVesterinen: so you did revieww the prs?  why do you think throws domain_error  is better than assret for a case that is not supposed  to be possible? tads reason was basically 'i don't like assert' and i honestly don't think that's enough.
20170917 13:00:26< JyrkiVesterinen> I did review them. The only nitpick I have is stylistic issues (missing line breaks and superfluous spaces - not something that would have made me reject them).
20170917 13:01:06< gfgtdf> JyrkiVesterinen: so you agree that asserts shodul generally be replaces with thowing uncaught exceptions ?
20170917 13:01:30< JyrkiVesterinen> I don't care about the difference between asserting and throwing an exception. Both give the result we need: they alert us if the supposed-to-be-impossible condition actually happens.
20170917 13:01:50< gfgtdf> JyrkiVesterinen: so why did you merge then if you see no advantage in them ?
20170917 13:01:56< JyrkiVesterinen> If tad_carlucci strongly prefers exceptions, then that's that. I'm not going to start a fight about it.
20170917 13:02:25< gfgtdf> i will
20170917 13:03:16< gfgtdf> AI0867: does jenkins now start build coverty?
20170917 13:04:50< irker485> wesnoth: Jyrki Vesterinen wesnoth:master c4d556475e51 / projectfiles/VC12/ (wesnoth.vcxproj wesnoth.vcxproj.filters): Add sdl/userevent.hpp to the Visual Studio project https://github.com/wesnoth/wesnoth/commit/c4d556475e519d63f6b785eba9a47a9ff2dafe23
20170917 13:05:53< JyrkiVesterinen> gfgtdf: If you want to change the exceptions to asserts, feel free. As you're a more active developer, your opinion has more weight than tad's.
20170917 13:08:06-!- Bhoren [~Bhoren___@2a01:e0a:c:2150:b2de:a734:f830:ea2b] has joined #wesnoth-dev
20170917 13:09:38-!- RatArmy_ [~ratarmy@om126212248021.14.openmobile.ne.jp] has quit [Remote host closed the connection]
20170917 13:10:08< loonycyborg> gfgtdf: yes, jenkins does build coverity
20170917 13:20:24< gfgtdf> zookeeper: is it correct that in animationwml as it happens in flag="ab[1~4].png:100" only positive numbers behind the : make sense?
20170917 13:22:46< zookeeper> gfgtdf, yeah, negative values for frame durations wouldn't really make sense.
20170917 13:23:09< gfgtdf> zookeeper: and 0 doesn't eigher right ?
20170917 13:23:58< zookeeper> uh, not sure. why do you ask?
20170917 13:26:49< gfgtdf> i ahv a commit that addsa  std::max<1, duration> to that to prevent a possible crash.
20170917 13:28:40< zookeeper> well, that seems fine to me
20170917 13:28:53< irker485> wesnoth: gfgtdf wesnoth:master 6858f300237e / src/display.cpp: fix crash on missing team flag data https://github.com/wesnoth/wesnoth/commit/6858f300237ee89302f43faa4ddd5893b0cc0b48
20170917 13:35:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170917 13:36:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170917 13:49:55-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170917 13:54:03< Soliton> how does the sdl user events commit improve any initialization issues? it seems to initialize less than before.
20170917 14:01:20< JyrkiVesterinen> Hmm... I think you're right. I guess tad_carlucci missed that default initialization doesn't do anything, and I never thought aboutit.
20170917 14:01:43< gfgtdf> Soliton: it adds a cpp stuct that does ht einitlisation
20170917 14:02:03< gfgtdf> Soliton: src/sdl/userevent.hpp
20170917 14:02:19< Soliton> it adds a class that does mostly no initialization.
20170917 14:02:26< gfgtdf> hmm yes you are right
20170917 14:02:28< zookeeper> err. was it an intentional change that i can no longer unselect a unit by right-clicking on an empty hex?
20170917 14:02:33< Soliton> adding the class was a good idea, of course.
20170917 14:02:47< zookeeper> because now i'm constantly getting the context menu in my face, because i've always deselected with a right-click, i think.
20170917 14:02:47< JyrkiVesterinen> zookeeper: when did it change?
20170917 14:02:53< gfgtdf> Soliton: bach when last che it did though, so he maybe rmeoved that ?
20170917 14:03:10< zookeeper> JyrkiVesterinen, in the last two weeks i guess
20170917 14:03:31< Soliton> gfgtdf: i've just looked at the change for the first time so no idea about that.
20170917 14:03:51< JyrkiVesterinen> Hmm, it's such a large window that it's a bit hard to tell which commit exactly caused it.
20170917 14:03:54< gfgtdf> Soliton: when that commit were made there was a "memset (this, 0, sizeof(SDL_UserEvent));" in the efault ctor, for some reason it was removed
20170917 14:04:21< Soliton> the description sounded like that was the idea.
20170917 14:04:37< Soliton> maybe some refactoring mishap then.
20170917 14:05:25< zookeeper> JyrkiVesterinen, i do recall seeing people talk something about deselecting, so there was probably a PR or issue for something related to it.
20170917 14:14:40-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170917 14:34:12-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:104f:9c9a:4bca:f3d4] has joined #wesnoth-dev
20170917 14:36:45< irker485> wesnoth: ln-zookeeper wesnoth:master c7cda91250fa / data/campaigns/The_South_Guard/scenarios/03_A_Desparate_Errand.cfg: TSG S03: Upped the difficulty considerably (should still be easy) https://github.com/wesnoth/wesnoth/commit/c7cda91250fac85ab371ec9ed3593e6c11381deb
20170917 14:37:49< irker485> wesnoth: Jyrki Vesterinen wesnoth:master dca021e9ad0a / src/sdl/userevent.hpp: Initialize sdl::UserEvent to all zeroes https://github.com/wesnoth/wesnoth/commit/dca021e9ad0a53d5c7424d94fbfb9fdcc3b6b7b9
20170917 14:40:01-!- timotei_ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 248 seconds]
20170917 14:41:38< zookeeper> using the recruitment_instructions aspect somehow causes the enemy leader to not recruit a lot of units. urgh.
20170917 14:50:03< celticminstrel> How are you using it?
20170917 15:02:08-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20170917 15:17:32-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170917 15:23:25< zookeeper> celticminstrel, in the way i just committed
20170917 15:24:22-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170917 15:29:58-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20170917 15:42:13< celticminstrel> zookeeper: You're using recruit tags, so the AI will only follow those recruit tags and nothing else. If you want it to fall back to regular recruiting you need an additional recruit tag with no filters (probably just with importance and nothing else).
20170917 15:42:52< celticminstrel> Either that, or you need number in the third recruit tag...
20170917 15:43:06< celticminstrel> (If the goal is for them to recruit mostly bandits and a few undead.)
20170917 15:43:19 * celticminstrel checks the docs...
20170917 15:43:38< zookeeper> celticminstrel, i don't see why those [recruit] tags would cause it to spend several turns not recruiting anything
20170917 15:43:58< zookeeper> if it has enough bats and skeletons, it should skip those and end up recruiting outlaws, AFAICT
20170917 15:44:05< celticminstrel> Yeah, I think what you need is number=-1 in the third recruit tag... though TBH it'd make more sense for that to be the default rather than 1...
20170917 15:44:27< zookeeper> right. i'll try that a bit later.
20170917 15:44:43< celticminstrel> Oh wait, it says that's the default. I misread. :|
20170917 15:44:54< celticminstrel> Still, I guess it wouldn't hurt to try it.
20170917 15:45:40< celticminstrel> I also notice you're using recruitment_pattern. I don't recall how well that mixes with recruitment_instructions.
20170917 15:46:03< zookeeper> uh, i'm not?
20170917 15:46:18 * celticminstrel looks again.
20170917 15:46:32< celticminstrel> Oh, duh, you removed the recruitment_pattern. >_>
20170917 15:47:28< celticminstrel> I think that config will make them recruit a bat or skeleton whenever possible, wouldn't it?
20170917 15:48:23-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:104f:9c9a:4bca:f3d4] has quit [Remote host closed the connection]
20170917 15:48:56-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:104f:9c9a:4bca:f3d4] has joined #wesnoth-dev
20170917 15:51:29< zookeeper> no, the limits prevent it
20170917 15:52:38< celticminstrel> Ah, right, duh.
20170917 15:53:03-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:104f:9c9a:4bca:f3d4] has quit [Ping timeout: 246 seconds]
20170917 15:55:51-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:104f:9c9a:4bca:f3d4] has joined #wesnoth-dev
20170917 15:56:22-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:104f:9c9a:4bca:f3d4] has quit [Remote host closed the connection]
20170917 15:56:56-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:104f:9c9a:4bca:f3d4] has joined #wesnoth-dev
20170917 16:00:15-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:104f:9c9a:4bca:f3d4] has quit [Remote host closed the connection]
20170917 16:00:29-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170917 16:01:27-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170917 16:02:03-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:104f:9c9a:4bca:f3d4] has joined #wesnoth-dev
20170917 16:06:13-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170917 16:06:17-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:104f:9c9a:4bca:f3d4] has quit [Ping timeout: 255 seconds]
20170917 16:22:39-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:104f:9c9a:4bca:f3d4] has joined #wesnoth-dev
20170917 16:25:25-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:104f:9c9a:4bca:f3d4] has quit [Remote host closed the connection]
20170917 16:30:02< EliDupree> ...yeah, lua wesnoth.log ("err", "foo", true) doesn't display in the command line OR in the chat!
20170917 16:30:48< EliDupree> wait a minute
20170917 16:31:06< EliDupree> It does when I paste it into the console directly, but it doesn't in my scripts…?
20170917 16:33:20< celticminstrel> ?
20170917 16:34:47< zookeeper> celticminstrel, so, no further ideas about the recruitment issue?
20170917 16:35:19< EliDupree> Okay, so there was an error in the error handling code in my xpcall call, so maybe that has something to do with it
20170917 16:36:48< EliDupree> wait, no
20170917 16:39:57< EliDupree> I guess there's just a quirk where debug.backtrace() in that position lists its own line, which makes sense
20170917 16:40:03< AI0867> 15:03 < gfgtdf> AI0867: does jenkins now start build coverty? ← yes
20170917 16:40:06-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170917 16:40:33< AI0867> one of the jenkins builds is now a coverity build, which is submitted to coverity
20170917 16:40:43< EliDupree> Below that, the rest of the backtrace clearly indicates that the error was "attempts to call a nil value (field "set_variable")" on a line where I did wesnoth.set_variable – that SHOULDN'T be nil
20170917 16:40:56< AI0867> you can subscribe to coverity@wesnoth.org to get all related mail
20170917 16:41:07< EliDupree> Is there some point in preload/etc. where wesnoth.set_variable isn't initialized yet or something?
20170917 16:42:40< EliDupree> Or... ooh!
20170917 16:43:34< EliDupree> I deliberately made set_variable nil in unsynced contexts to try to prevent synchronization errors
20170917 16:43:38< EliDupree> haha
20170917 16:45:29< EliDupree> Or actually, I wrote a comment saying that setting variables in filter functions/theme items/etc seemed to be causing memory errors, that's why I prevented it
20170917 16:50:02< EliDupree> Anyway, never mind all that, I found it! I found the regression –
20170917 16:50:30< EliDupree> When wml_message was reimplemented using wesnoth.log, it ceased to accept translatable strings
20170917 16:51:14< EliDupree> And now just silently fails when passed a translatable string, even though it works perfectly if you apply tostring() to the translatable string first.
20170917 16:53:55< celticminstrel> Sorry, no further ideas.
20170917 16:55:15< celticminstrel> EliDupree: The only time set_variable should be nil is if you're in a map generation script (or a plugin script).
20170917 16:56:13< celticminstrel> As for strings, ugh, maybe we should actually just make a luaW_tostring that accepts translatable strings...
20170917 16:57:05< EliDupree> Doesn't the builtin tostring already do that? I've been using it to turn tstrings into strings all over the place
20170917 16:57:42< celticminstrel> I'm talking about the C API here.
20170917 16:57:48< celticminstrel> The Lua tostring() function indeed does that.
20170917 16:57:57< EliDupree> oh I see
20170917 16:58:15< EliDupree> You're talking about how to implement having wesnoth.log accept tstrings directly
20170917 16:58:20< celticminstrel> Right.
20170917 16:59:07< celticminstrel> It's easy to do (just take the argument as a tstring instead of a string), but since we've had this exact problem a number of times before, I'm wondering if we should do it a little differently.
20170917 17:06:53-!- louis94 [~~louis94@121.83-247-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20170917 17:12:43< zookeeper> celticminstrel, "importance=1: (integer) Priority of the recruitment. The AI first recruits units with the highest importance, until the specified limits are reached. If gold is lacking or the castle is full, only the most important units are recruited, all other [recruit] jobs are dropped."
20170917 17:12:44< zookeeper> maybe the other [recruit] jobs are dropped even if the more important ones are skipped because of [limit]s? although i don't remember that happening in HttT where i used almost identical code...
20170917 17:14:59< zookeeper> hmh. in fact yes it does happen there too.
20170917 17:16:27< zookeeper> maybe blocker=no doesn't work, or something.
20170917 17:17:17< zookeeper> what a horrible night to have a bug.
20170917 17:18:31< celticminstrel> Hmm. I'm not sure, but maybe the importance key is meant to ensure the AI saves gold for important units? I'm guessing it'd work if all the jobs are the same importance (or remove the importance keys to use the default).
20170917 17:18:48< celticminstrel> IIRC it processes [recruit] / [total] / [pattern] tags in order.
20170917 17:19:01< celticminstrel> ...though I should probably double-check on the latter two.
20170917 17:21:46< zookeeper> it doesn't depend on the amount of gold
20170917 17:22:37< celticminstrel> "If gold is lacking or the castle is full..."
20170917 17:22:42< zookeeper> it does seem like if it's allowed to recruit bats and skeletons (for example after i kill the existing ones), then it recruits those and happily recruits outlaws after that (on the same turn), but then on the next turn when it's not allowed any more bats and skellies, it just doesn't recruit anything.
20170917 17:26:40-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170917 17:27:03< celticminstrel> That doesn't seem right; if a job fails because of limits I'd expect it to move to the next one.
20170917 17:33:46< zookeeper> so would i :p
20170917 17:34:11< zookeeper> of course there could be another cause, but behaviorally it seems to fit that description.
20170917 17:38:11< zookeeper> hrhm. the assassin micro AI has a subtle problem: if i completely surround the target unit with my own other units, the assassins can't attack it, but when a non-assassin kills one of my units and opens up a path to the target, the assassins won't take the opportunity.
20170917 17:38:19< zookeeper> presumably because the micro AI runs before the regular AI
20170917 17:38:53< zookeeper> i don't expect that to be a big problem, but just something i noticed
20170917 17:39:01-!- irker485 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170917 17:39:03< celticminstrel> IIRC the micro AIs install candidate actions, so it shouldn't be a strict ordering or anything.
20170917 17:40:59< zookeeper> anyway, i'm much more interested in whether we can somehow fix the recruit problem before the release...
20170917 17:41:28< celticminstrel> Well, does it work if the tasks are all of the same importance?
20170917 17:41:28< zookeeper> i'd be content with a workaround, but haven't found one yet
20170917 17:41:51< zookeeper> umm, let me check... i'd expect that to not guarantee recruitment of bats and skeletons though
20170917 17:42:14< celticminstrel> It'd probably not recruit them if there's insufficient gold, at least.
20170917 17:43:33< zookeeper> nope, didn't work (i used importance=3 on all 3 [recruit]s)
20170917 17:51:58< zookeeper> huh
20170917 17:53:47< zookeeper> i just inverted https://github.com/wesnoth/wesnoth/blob/master/src/ai/default/recruitment.cpp#L1396 by removing the ! and now it... seems to work correctly?
20170917 17:54:50< zookeeper> that is, now i get the old behavior only by using blocker=yes as one would expect, but with blocker=no it does recruit outlaws even when it's not allowed to recruit bats and skeletons
20170917 17:55:01< JyrkiVesterinen> ...how does that line use the indexing operator? Why not '!job["blocker"].to_bool(true)'?
20170917 17:55:25< JyrkiVesterinen> Oh, right. Needs a dereference for that.
20170917 17:56:36< celticminstrel> Hmm.
20170917 17:57:04< celticminstrel> Yeah, removing the ! there sounds correct.
20170917 17:57:09< zookeeper> \o/
20170917 17:57:13< celticminstrel> "if this is not a blocker, return true"
20170917 17:57:28< celticminstrel> Wait.
20170917 17:57:36< celticminstrel> Yeah.
20170917 17:57:49< celticminstrel> if(!job["blocker"]) return true
20170917 17:58:11< zookeeper> i've always wanted to be a c++ game engine AI programmer wizard person
20170917 17:58:14 * celticminstrel checks where it's called.
20170917 17:58:41< celticminstrel> Yeah, it looks correct.
20170917 17:59:03< celticminstrel> JyrkiVesterinen: I think I'd personally prefer (*job)["blocker"] in that scenario though.
20170917 17:59:13< JyrkiVesterinen> Yes, me too.
20170917 18:02:31< zookeeper> i can commit it if there's nothing insightful to add to the commit message beyond "fixes blocker=no"
20170917 18:02:36< zookeeper> otherwise, feel free to
20170917 18:02:47< zookeeper> (well, feel free to in any case, really)
20170917 18:02:53< celticminstrel> Hmm.
20170917 18:03:09< celticminstrel> The default is blocker=yes
20170917 18:03:18< celticminstrel> However, behaviour-wise it was as if the default is blocker=no
20170917 18:03:37< celticminstrel> Should we make the default blocker=no?
20170917 18:05:36< zookeeper> no, behaviour-wise it was as if it was always blocker=yes
20170917 18:06:01< zookeeper> you couldn't get blocker=no behaviour no matter what you did
20170917 18:06:08< celticminstrel> Are you sure? Did you try setting them to blocker=yes?
20170917 18:06:37< zookeeper> yeah, same behaviour whether it was yes, no, or absent
20170917 18:06:41< celticminstrel> Huh, weird.
20170917 18:06:48< celticminstrel> Okay then.
20170917 18:07:01< zookeeper> i'll double-check
20170917 18:07:51< celticminstrel> Don't forget to recompile with the ! added back in.
20170917 18:08:16< zookeeper> yep, confirmed
20170917 18:08:27< zookeeper> yeah, i did :P
20170917 18:12:35-!- irker971 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170917 18:12:35< irker971> wesnoth: Celtic Minstrel wesnoth:master 078cc87ab128 / src/ai/default/recruitment.cpp: Fix blocker=no in AI [recruitment_instructions] https://github.com/wesnoth/wesnoth/commit/078cc87ab128e49daf0694dadecde77daf3bb05a
20170917 18:13:12< zookeeper> yay
20170917 18:35:49-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170917 19:06:49< irker971> wesnoth: doofus-01 wesnoth:master d63fe4a96e1f / data/core/ (64 files in 4 dirs): stone tile floor terrain (#1939) https://github.com/wesnoth/wesnoth/commit/d63fe4a96e1f0a72b0f0f8b4d6d646a2bafffec6
20170917 19:19:38< zookeeper> well, of course that breaks some transitions, like floors<->cave...
20170917 19:24:01< celticminstrel> Changelog entry?
20170917 19:24:49< zookeeper> needs to be added
20170917 19:45:36-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170917 19:46:21-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170917 19:51:02< zookeeper> i think the stone floor's transitions with other flat terrains are more important than their transitions with stuff like castle-chasm corners, so i think i'll just revert the base layer part for now...
20170917 20:29:37-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170917 20:33:28-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170917 20:33:40-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170917 20:35:03< irker971> wesnoth: ln-zookeeper wesnoth:master f25e642257f2 / changelog: Updated changelog https://github.com/wesnoth/wesnoth/commit/f25e642257f240b31a9cc4e011f38a440a3e30d4
20170917 20:41:11-!- travis-ci [~travis-ci@ec2-54-167-99-251.compute-1.amazonaws.com] has joined #wesnoth-dev
20170917 20:41:12< travis-ci> wesnoth/wesnoth#15039 (master - 0bd159b : Gregory A Lundberg): The build has errored.
20170917 20:41:12< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/276502236
20170917 20:41:12-!- travis-ci [~travis-ci@ec2-54-167-99-251.compute-1.amazonaws.com] has left #wesnoth-dev []
20170917 20:44:20-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170917 21:30:51< EliDupree> Observations about wesnoth.game_events.mouse_action:
20170917 21:30:51< EliDupree> – it triggers on every mousedown on a hex, of the left OR right mouse button, including ones that invoke the context menu.
20170917 21:30:51< EliDupree> – it also triggers on mouseup, but only if it wasn't on the same hex as the mousedown, and only for the left button.
20170917 21:30:51< EliDupree> – it also triggers whenever one of your units completes a move that you made using the mouse, right after the moveto event. This doesn't include continuations of multi-turn movement.
20170917 21:30:51< EliDupree> – it also triggers when a move is undone, at the beginning of the motion, even if you used the hotkey rather than using the mouse at all.
20170917 21:30:52< EliDupree> – it also triggers exactly once at the start of the game, the same way wesnoth.game_events.on_event seems to trigger once for each event type at the start of the game. It also triggers at the beginning of each turn, although that could just be a symptom of it being triggered by something else.
20170917 21:30:54< EliDupree> – if you select a unit, it comes BEFORE the select event.
20170917 21:30:56< EliDupree> – the x and y arguments are always the current position of the mouse, even if it was triggered by something unrelated to the mouse. If the mouse isn't on the map, they are both -999.
20170917 21:30:58< EliDupree> – during the callback, if you call wesnoth.get_selected_tile, it returns the unit that was selected BEFORE the mouse event in question. This means you can't distinguish between a left-click and a right-click on the currently selected unit.
20170917 21:31:01< EliDupree> – I have not yet investigated its behavior for observers in multiplayer games.
20170917 21:34:35-!- louis94 [~~louis94@121.83-247-81.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 240 seconds]
20170917 21:38:41< EliDupree> … It's still going to be useful to me because it can function as an additional input to the sophisticated logic I already built that uses the report_countdown theme item to poll the current time, current mouse position, and currently selected unit, in order to guess what types of input the user was giving, but I have no idea how this behavior could possibly be used to implement any ordinary feature
20170917 21:40:12-!- markus_ [~mjs-de@x4e3136f4.dyn.telefonica.de] has quit [Remote host closed the connection]
20170917 21:41:04-!- Bhoren [~Bhoren___@2a01:e0a:c:2150:b2de:a734:f830:ea2b] has quit [Quit: Leaving]
20170917 21:44:52-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170917 21:49:19-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Ping timeout: 248 seconds]
20170917 21:52:39-!- louis94 [~~louis94@121.83-247-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20170917 22:04:52< EliDupree> – it ALWAYS triggers on right-mousedown, even off the map.
20170917 22:04:52< EliDupree> – left-clicking off the map doesn't trigger it, unless you clicked on the minimap. Left-clicking on the minimap triggers it with the coordinates of the mini-hex you clicked on. Right-clicking on the minimap triggers it with (-999, -999).
20170917 22:04:52< EliDupree> – left-mouseup off the map always triggers it with (-999, -999), unless the mousedown and mouseup were very close to each other, OR both the mousedown and mouseup were on the minimap, in which case it doesn't trigger. (If both mousedown and mouseup were, for instance, in different blank parts of the right sidebar, it can still trigger.)
20170917 22:08:42< celticminstrel> This kinda sounds totally useless.
20170917 22:10:49< EliDupree> Preeeettttty much
20170917 22:11:53-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170917 22:14:43< irker971> wesnoth: ln-zookeeper wesnoth:master c7365a20efa6 / data/core/terrain-graphics.cfg: Fixed transition issues with floor terrains, and some reformatting https://github.com/wesnoth/wesnoth/commit/c7365a20efa60de1a3d7231557a0cd428f621354
20170917 22:17:35< gfgtdf> EliDupree: that wasn't really tested he idea was to 1) Be able to create some 'user mouse input' option during events, 2) To create sosphicated ui things, like different hex mouseover images depending on thr hex
20170917 22:18:29< gfgtdf> EliDupree: i think it'D prbably make more sense if it only fired for leftmouse button.
20170917 22:19:06< EliDupree> yeah, that's exactly what I'd want out of it
20170917 22:19:34< EliDupree> Or have a third argument indicating the type of mouse action
20170917 22:20:18-!- sevu [~Shiki@p548569FA.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170917 22:22:29-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:4cee:1166:ab5b:253f] has joined #wesnoth-dev
20170917 22:26:09< gfgtdf> EliDupree: can you create c++ stacktraces ?
20170917 22:26:41< EliDupree> If it only fired on left click, it would be pretty useful, and the only awkward thing would be that you can't tell whether the click initiated a move (you might not want to make your UI thing happen if the click ALSO made a regular move). Probably the ideal would be to have something like web events' event.preventDefault(), although I'd understand if that's not practical to implement. Anyway, the main useful thing would be to get it to 
20170917 22:26:41< EliDupree> only fire on left clicks in the first place
20170917 22:27:34< EliDupree> Do you mean stack traces for when it fires in unwanted circumstances? I could run wesnoth in the debugger but I'm not sure how I would pause it at the right time…
20170917 22:27:51< gfgtdf> EliDupree: yes that'S what i meant
20170917 22:28:09< EliDupree> oh  I could set a breakpoint in select_hex_callback()
20170917 22:28:25< EliDupree> lemme try that
20170917 22:29:58< celticminstrel> The mouse action event should precede the move event and offer the possibility of cancelling it.
20170917 22:31:46< EliDupree> Bactrace from trigger at the end of a move: https://pastebin.com/nvDKiibn
20170917 22:32:29< EliDupree> From trigger on undo: https://pastebin.com/9V2fsRR4
20170917 22:33:09< gfgtdf> EliDupree: the first one sounds looks liek a regular leftclick action
20170917 22:33:24< gfgtdf> EliDupree: the second one shoudl be fixed
20170917 22:33:54< EliDupree> That is from the trigger on the end of the move, which happens IN ADDITION to the trigger when you actually click to make the move.
20170917 22:34:23< EliDupree> From trigger on end-turn: https://pastebin.com/JgE3TcyK
20170917 22:34:31< gfgtdf> EliDupree: oh ok
20170917 22:34:39< gfgtdf> EliDupree: ye it shouldn't be liek this
20170917 22:34:49< gfgtdf> EliDupree: you can give one form right-click?
20170917 22:34:53< EliDupree> sure
20170917 22:35:32< EliDupree> Right-clicked in the right sidebar: https://pastebin.com/UTBiqYN6
20170917 22:36:09< EliDupree> Mouseup in right sidebar: https://pastebin.com/9HxFP95n
20170917 22:38:02< EliDupree> Left-click on minimap: https://pastebin.com/r3xyYZYU
20170917 22:38:24< gfgtdf> ok thy that shodul be enough
20170917 22:38:59< gfgtdf> EliDupree: so leftclick on minimap is unexpected?
20170917 22:39:03< EliDupree> "n" next unit hotkey https://pastebin.com/xmpwndk8
20170917 22:39:34< EliDupree> I certainly wouldn't think of that as a possible form of mouseclick when I was designing a UI
20170917 22:40:01< EliDupree> It seems like it COULD be useful to detect minimap clicks, but only if you could distinguish them from main-map clicks
20170917 22:42:59< EliDupree> It would actually be nice to detect off-map clicks as well, which it currently doesn't do (but would be distinguishable just fine under the current system because you could just check whether the coordinates were -999)
20170917 22:44:14< gfgtdf> we shoild remvoe those magic values and just pas nil in that case ai thin, but that'S not that important
20170917 22:44:25< EliDupree> true
20170917 22:49:50< irker971> wesnoth: gfgtdf wesnoth:master 3198baa67429 / src/mouse_events.cpp: attempt to fix wesnoth.game_events.on_mouse_action callback https://github.com/wesnoth/wesnoth/commit/3198baa6742919d1180ca89455d9a6c466b3c7d6
20170917 22:50:59< gfgtdf> EliDupree: this ^ could fix it
20170917 22:55:43< EliDupree> uh, you put the callback in select_or_action instead of select_hex and move_action? But select_or_action also appears in the problematic end-of-move trigger
20170917 22:56:13-!- travis-ci [~travis-ci@ec2-54-242-46-198.compute-1.amazonaws.com] has joined #wesnoth-dev
20170917 22:56:14< travis-ci> wesnoth/wesnoth#15046 (master - f25e642 : ln-zookeeper): The build was broken.
20170917 22:56:14< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/276609097
20170917 22:56:14-!- travis-ci [~travis-ci@ec2-54-242-46-198.compute-1.amazonaws.com] has left #wesnoth-dev []
20170917 22:56:20< EliDupree> As well as the minimap trigger, although that's less of a problem
20170917 22:58:26< gfgtdf> EliDupree: but you also want to fire it one in the end of the move scneairo (instead just twice as it currently does)
20170917 22:58:55< EliDupree> Shouldn't it fire when you click, not after the move?
20170917 22:58:58< gfgtdf> EliDupree: the problam with the current solution si that it won't work if you reasigned the mouse hotkey (the preverences allow you to seperate 'move' from 'select')
20170917 22:59:37< gfgtdf> EliDupree: yes it does select_or_action  is the function that appeart whe you lick so select_or_action  triggers the clickevent but also the move
20170917 22:59:48< gfgtdf> with the new solution i mean
20170917 23:00:03< EliDupree> select_or_action triggers twice when I move a unit
20170917 23:00:33< gfgtdf> EliDupree: hmm why that can you give me  stacktrace?
20170917 23:01:01< EliDupree> beginning-of-move click: https://pastebin.com/Bzdptm56
20170917 23:02:03< EliDupree> end-of-move trigger for the same move, in case it matters: https://pastebin.com/JiRj7xNz
20170917 23:02:50< gfgtdf> EliDupree: this stacktrace doesn't show that  select_or_action  is called twice, it just menas that one select_or_action calle might trigger 2 lua callback  calls
20170917 23:02:58< EliDupree> oh
20170917 23:03:22< EliDupree> Right, and your change could reduce that down to 1
20170917 23:04:30< EliDupree> I didn't think of the fact that we'd still be *in* that part of the stack rather than reentering it
20170917 23:04:36-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:4cee:1166:ab5b:253f] has quit [Read error: Connection reset by peer]
20170917 23:05:09-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170917 23:05:21< EliDupree> Okay, your change probably makes the feature much more usable, assuming that it doesn't add any new problem cases.
20170917 23:12:27-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170917 23:15:08< EliDupree> A quick lua script to test the callback with, in case that's useful: https://pastebin.com/YHFr0GgK
20170917 23:23:17-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds]
20170917 23:25:50-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:4cee:1166:ab5b:253f] has joined #wesnoth-dev
20170917 23:32:44-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:4cee:1166:ab5b:253f] has quit [Remote host closed the connection]
20170917 23:33:18-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:4cee:1166:ab5b:253f] has joined #wesnoth-dev
20170917 23:37:30-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:4cee:1166:ab5b:253f] has quit [Ping timeout: 246 seconds]
20170917 23:41:14-!- travis-ci [~travis-ci@ec2-54-82-27-113.compute-1.amazonaws.com] has joined #wesnoth-dev
20170917 23:41:15< travis-ci> wesnoth/wesnoth#15042 (master - dca021e : Jyrki Vesterinen): The build has errored.
20170917 23:41:15< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/276524596
20170917 23:41:15-!- travis-ci [~travis-ci@ec2-54-82-27-113.compute-1.amazonaws.com] has left #wesnoth-dev []
20170917 23:50:27-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20170917 23:55:52-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170917 23:56:41-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170917 23:57:15-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:4cee:1166:ab5b:253f] has joined #wesnoth-dev
--- Log closed Mon Sep 18 00:00:00 2017