--- Log opened Sun Sep 24 00:00:08 2017
20170924 00:02:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170924 00:02:33-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170924 01:22:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170924 01:53:51-!- Coffee_irc [~david@203.63.42.216] has quit [Ping timeout: 252 seconds]
20170924 01:54:33-!- Coffee_irc [~david@220-244-175-26.static.tpgi.com.au] has joined #wesnoth-dev
20170924 02:01:48-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Read error: Connection reset by peer]
20170924 02:04:48-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20170924 02:14:41-!- irker706 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170924 02:37:33< Necrosporus> celticminstrel, given it has stuff such as [if] and [set_variable] ...
20170924 02:37:54-!- irker106 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170924 02:37:54< irker106> wesnoth: doofus-01 wesnoth:master 563d080fec78 / data/core/terrain.cfg: adding hide_help key to gates terrains (#2036) https://github.com/wesnoth/wesnoth/commit/563d080fec785729c9bcddbb22bec00dd6125755
20170924 02:42:48-!- sigurdfd [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20170924 03:17:59-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170924 03:22:38< JyrkiVesterinen> sevu: Are you sure you got those crashes on exit with SDL 2.0.5?
20170924 03:22:59< JyrkiVesterinen> I saw a crash on exit myself... with SDL 2.0.6.
20170924 03:23:22< JyrkiVesterinen> (And I decided to ignore it for now because it's a much smaller problem than crash on startup.)
20170924 03:41:26< celticminstrel> Necrosporus: Well that's a subset of WML though.
20170924 04:14:06-!- sigurdfd [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has quit []
20170924 04:18:14-!- The_Unforgiven [~quassel@2601:40a:c380:462:54c:9dc7:50c9:f0c6] has joined #wesnoth-dev
20170924 04:18:14-!- The_Unforgiven [~quassel@2601:40a:c380:462:54c:9dc7:50c9:f0c6] has quit [Changing host]
20170924 04:18:14-!- The_Unforgiven [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20170924 04:42:49-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170924 04:43:34< vultraz> Zookeeper: sorry I haven’t found the cause of the bug yet
20170924 04:43:37< vultraz> I’ll keep looking
20170924 04:44:13-!- vultraz changed the topic of #wesnoth-dev to: 1.13.10 tagging pending me fixing the right click bug | Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Discord Server: https://discord.gg/tSmJS2E | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20170924 04:44:49-!- JyrkiVesterinen changed the topic of #wesnoth-dev to: 1.13.10 tagging pending vultraz fixing the right click bug | Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Discord Server: https://discord.gg/tSmJS2E | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20170924 04:45:02< JyrkiVesterinen> Please don't use the first person in channel topic.
20170924 05:47:10< celticminstrel> Heh.
20170924 05:56:28< Necrosporus> What right click bug?
20170924 05:56:51< Necrosporus> For me right click when unit is selected causes menu to appear and unit gets deselected
20170924 05:57:15< Necrosporus> Is it not what is expected?
20170924 05:57:56< JyrkiVesterinen> Right-clicking shouldn't make the context menu appear if a unit is selected.
20170924 05:58:00< JyrkiVesterinen> It's annoying.
20170924 06:00:23< Necrosporus> Do you have any idea how to track down resize issues?
20170924 06:00:42< JyrkiVesterinen> Not really.
20170924 06:00:52-!- celticminstrel is now known as celmin|sleep
20170924 06:00:57< JyrkiVesterinen> And I'd guess a bug in Openbox or SDL anyway.
20170924 06:01:12< JyrkiVesterinen> Wesnoth doesn't have any code to determine how large the window is.
20170924 06:01:22< JyrkiVesterinen> It's SDL's reponsibility.
20170924 06:01:34< Necrosporus> But wesnoth does change interface theme when window is resized
20170924 06:02:13< Necrosporus> Also Wesnoth 1.12 doesn't have this problem (it has different problem)
20170924 06:02:26< JyrkiVesterinen> Wesnoth 1.12 uses SDL1.
20170924 06:03:49< Necrosporus> JyrkiVesterinen, for example when I change resolution via context menu, first window is shrunk to new size, it happens immediately. Then after a second window content follows
20170924 06:04:14< Necrosporus> For vn window content doesn't follow
20170924 06:04:31< Necrosporus> For me it does, but after Full Screen -> Back doesn't
20170924 06:05:16< JyrkiVesterinen> Wesnoth peeks for resize events.
20170924 06:05:17< JyrkiVesterinen> https://github.com/wesnoth/wesnoth/blob/master/src/events.cpp#L732-L741
20170924 06:05:36< JyrkiVesterinen> When SDL sends a resize event, Wesnoth reacts by resizing window content.
20170924 06:05:48< JyrkiVesterinen> And obviously it relies on SDL giving a correct window size.
20170924 06:06:34< Necrosporus> Can I check whenever wesnoth gets resize event at all?
20170924 06:06:46< Necrosporus> Like ./wesnoth --debug-window=sdl
20170924 06:06:56< Necrosporus> * --log-debug
20170924 06:06:59< Necrosporus> Whatever
20170924 06:07:35< JyrkiVesterinen> There doesn't seem to be any log output about it.
20170924 06:07:44< Necrosporus> Pulling window border does trigger resize
20170924 06:08:37-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170924 06:08:51< Necrosporus> Also there is something about window resize required when window is first created
20170924 06:09:10< Necrosporus> For me when profile is cleared window created in maximized state
20170924 06:09:35< Necrosporus> But wesnoth draws in 1024x768
20170924 06:09:57< Necrosporus> Which of course different from window size in both dimensions
20170924 06:10:45< Necrosporus> What code determines what window dimensions are when wesnoth window first appears on screen?
20170924 06:11:18< JyrkiVesterinen> Wesnoth indeed prints the window size on launch: https://github.com/wesnoth/wesnoth/blob/master/src/video.cpp#L234
20170924 06:11:22< JyrkiVesterinen> But not on resize.
20170924 06:13:20< Necrosporus> I guess I can add printf("resize happened") into first code patch and recompile my local copy
20170924 06:13:25< JyrkiVesterinen> This function queries window size: https://github.com/wesnoth/wesnoth/blob/master/src/sdl/window.cpp#L80-L86
20170924 06:13:32< Necrosporus> Or how do you properly print stuff in console?
20170924 06:13:59< JyrkiVesterinen> You can also see that there is an alternative implementation (get_output_size()) right below it. But get_size() is used most of the time.
20170924 06:15:07< JyrkiVesterinen> The proper way to print to colsole is with log streams. Example: https://github.com/wesnoth/wesnoth/blob/master/src/video.cpp#L117
20170924 06:15:12< JyrkiVesterinen> *console
20170924 06:16:52-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170924 06:18:42< Necrosporus> When I first start wesnoth after clearing prefs i get Setting mode to 1024x768 \n Checking lua scripts... ok
20170924 06:20:04< JyrkiVesterinen> Expected behavior. 1024x768 is the default size on first launch.
20170924 06:20:31< Necrosporus> then why window is maximized?
20170924 06:20:56< Necrosporus> You said you can't reproduce my first start problem. Do you have window maximized?
20170924 06:21:09< JyrkiVesterinen> Default window state is maximized, yes.
20170924 06:21:38< JyrkiVesterinen> The idea is that the window being maximized causes a resize immediately after setting the mode to 1024x768.
20170924 06:21:52< JyrkiVesterinen> Then it will set the size to whatever the screen allows.
20170924 06:21:56< Necrosporus> Apparently resize dowsn't happen
20170924 06:22:05< JyrkiVesterinen> It all works for me, both on Windows and on GNU/Linux.
20170924 06:23:05-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20170924 06:23:15< Necrosporus> It could be difference in build options
20170924 06:23:49< JyrkiVesterinen> To me, it sounds like something is broken in your system.
20170924 06:24:23-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170924 06:24:28< Necrosporus> It could be. But we can't simply dismiss the problem. It happens to vn971 also, and his system is completely different
20170924 06:24:54< JyrkiVesterinen> Right. The problem is that I'm unable to investigate the problem because I can't reproduce it.
20170924 06:25:08< JyrkiVesterinen> And we don't really have any other active GNU/Linux developers. :(
20170924 06:27:07< Necrosporus> Why it doesn't use LOG_DP << "stuff", but  std::cerr << "Setting mode to " << w << "x" << h << std::endl;
20170924 06:27:33< JyrkiVesterinen> It should use log streams, yes.
20170924 06:28:02< JyrkiVesterinen> It's old code. I suppose that whoever wrote it was unaware of log streams (or maybe they didn't even exist at that point).
20170924 06:28:22< Necrosporus> What log options are needed to print LOG_DP ?
20170924 06:28:47-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170924 06:28:55< JyrkiVesterinen> https://github.com/wesnoth/wesnoth/blob/master/src/video.cpp#L28-L29
20170924 06:29:10< JyrkiVesterinen> And the #include "log.hpp" in line 20.
20170924 06:29:44< JyrkiVesterinen> I'm not sure if you can specify the same log domain in multiple files. If not, you can always create your own log domain.
20170924 06:31:48< Necrosporus> I think I can use std::cerr for this, since it's my temporary copy
20170924 06:32:14< JyrkiVesterinen> Yes, I think it's fine in local test builds.
20170924 06:32:25< Necrosporus>   std::cerr << "SDL_Window resized" << std::endl; CVideo::get_singleton().update_framebuffer();
20170924 06:32:31< Necrosporus> I guess I add it here
20170924 06:40:28< Necrosporus> And now half of wesnoth is being rebuilt even though I did only pull last Jyrki sdl fixes and changed one file...
20170924 06:40:55< JyrkiVesterinen> My SDL fixes changed sdl/surface.hpp, which is a widely used header.
20170924 06:45:58< Necrosporus> There is 100 hardcoded. Is it maximum length of sdl even queue?
20170924 06:46:10< JyrkiVesterinen> No.
20170924 06:47:16< JyrkiVesterinen> It's just assumed that the next 100 events are enough. Remember, even if there are more events between the currently-processed events and the resize event, the resize event will be handled when it falls to the window.
20170924 07:11:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170924 07:11:18-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170924 07:23:30< zookeeper> i might or might not pop in here occasionally, but i'll probably be mostly offline for about three days.
20170924 07:25:19-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170924 07:27:52-!- The_Unforgiven [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Remote host closed the connection]
20170924 07:36:03-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20170924 07:41:29< Necrosporus> JyrkiVesterinen, I get multiple window resized message after every change in resolution, except when it doesn't work
20170924 07:41:52< JyrkiVesterinen> Not really surprising.
20170924 07:42:09< JyrkiVesterinen> So, it looks like SDL doesn't notify us about the resize.
20170924 07:42:16< Necrosporus> I get two or three events when go to fullscreen
20170924 07:42:25< JyrkiVesterinen> I don't know if there is anything Wesnoth can do about it. :(
20170924 07:42:35< Necrosporus> but seems like none when going back... not sure, since I don't add a timestamp
20170924 07:43:15< Necrosporus> subsequent fullscreen and back doesn't produce resized messages
20170924 07:43:52< Necrosporus> JyrkiVesterinen, it could be problem with even parsing though
20170924 07:44:07< JyrkiVesterinen> But we don't have our own event parsing code.
20170924 07:44:15< JyrkiVesterinen> We use SDL's API for that.
20170924 07:45:13< Necrosporus> I  mean, are you completely sure this code is correct? https://github.com/wesnoth/wesnoth/blob/master/src/events.cpp#L732-L741
20170924 07:45:31< Necrosporus> I did put diagnostic inside the inner block
20170924 07:45:50< JyrkiVesterinen> Yes. I simply can't see what could possibly be wrong with it.
20170924 07:46:14< JyrkiVesterinen> SDL_WINDOWEVENT_RESIZED whould be the only event SDL can send to notify us about window resize.
20170924 07:47:02< Necrosporus> Why does it send like 2-7 such events in one time?
20170924 07:47:14< Necrosporus> And in others none at all
20170924 07:48:04< Necrosporus> I need to add code which prints screen dimensions
20170924 07:48:08< JyrkiVesterinen> I'd guess that it's SDL's or the window manager's fault.
20170924 07:50:47< Necrosporus> Will cerr << window::get_size() << std:endl; work?
20170924 07:51:10< Necrosporus> Or I need to process SDLPoint somehow
20170924 07:51:23< JyrkiVesterinen> SDL_Point doesn't have support for being printed to streams.
20170924 07:51:29< JyrkiVesterinen> You need to process it.
20170924 07:54:09< Necrosporus> How do I get window dimensions?
20170924 07:54:27< Necrosporus> I guess it's a bit more tricky than I though
20170924 07:54:42< JyrkiVesterinen> window::get_size()?
20170924 07:54:52< JyrkiVesterinen> I don't quite get whay you're trying to ask.
20170924 07:54:57< JyrkiVesterinen> *what
20170924 07:55:29< Necrosporus> I want to get something like "1280x800" as a string which would be current size of wesnoth window
20170924 07:55:45< Necrosporus> so I can print it with std::cerr
20170924 07:56:02< Necrosporus> Can you write whole code please
20170924 07:56:33< Necrosporus> I can use C, but not C++
20170924 07:57:11< JyrkiVesterinen> SDL_Point size = window->get_size();
20170924 07:57:31< JyrkiVesterinen> std::cerr << size.x << "x" << size.y << std::endl;
20170924 07:57:49< JyrkiVesterinen> Assuming that you're in a context where the window is directly accessible.
20170924 07:58:22< Necrosporus> In function 'void events::peek_for_resize()': src/events.cpp:740:17: error: 'window' has not been declared
20170924 07:58:39< Necrosporus> I think this assumption is wrong in case of this block of code
20170924 07:59:45< Necrosporus> Perhaps I need some function to get current window
20170924 08:00:01< JyrkiVesterinen> CVideo::get_singleton().get_window()->get_size();
20170924 08:00:18< JyrkiVesterinen> That should work anywhere if video.hpp is #included.
20170924 08:00:38< Necrosporus> It is included in event.cpp
20170924 08:01:15< JyrkiVesterinen> So use that code to fetch the window size.
20170924 08:05:52< Necrosporus> *** Error in `./wesnoth': free(): invalid pointer: 0x00007fe6b1ff6000 ***
20170924 08:06:02< Necrosporus> Perhaps I should have freed that size variable
20170924 08:07:23< Necrosporus> OK, results from fresh start: Setting mode to 1024x768 happens. No window resize.
20170924 08:07:56< Necrosporus> Then I click demaxmize button in header and I get SDL_Window resized: 1280x768 repeated 8 times
20170924 08:08:31-!- mjs-de [~mjs-de@b9168ef2.cgn.dg-w.de] has joined #wesnoth-dev
20170924 08:08:33< Necrosporus> Size of window itself becomes 1024x768 though
20170924 08:08:35-!- hrubymar10_irc [~hrubymar1@gateway/tor-sasl/hrubymar10irc/x-94850683] has joined #wesnoth-dev
20170924 08:09:04< JyrkiVesterinen> So, looks like SDL gets a wrong window size from somewhere.
20170924 08:09:04< Necrosporus> Then I move window a little and get ten messages SDL_Window resized: 1024x768
20170924 08:09:14< JyrkiVesterinen> Looks like a bug in the window manager or SDL.
20170924 08:09:34< Necrosporus> Then content in the window starts to look OK
20170924 08:10:29< Necrosporus> Clcicking maximize button gives SDL_Window resized: 1280x768 again, while correct value is 1280x755
20170924 08:12:41< Necrosporus> Clicking fullscreen gives SDL_Window resized: 1280x800 two times, but then clibcking it again doesn't produce new messages 
20170924 08:13:42< Necrosporus> Also I get segmentation fault on exit, which didn't happen before for me, so  it''s either your sdl fixes or my new code
20170924 08:15:05-!- hrubymar10_irc [~hrubymar1@gateway/tor-sasl/hrubymar10irc/x-94850683] has quit [Quit: hrubymar10_irc]
20170924 08:16:55< Necrosporus> Next restart set window to 1280x800, but demaximazing button set window into correct 1280x755 finally
20170924 08:18:43< JyrkiVesterinen> Are you still using SDL 2.0.5?
20170924 08:18:48< Necrosporus> JyrkiVesterinen, anyway maybe fixing bug with incorrect resolution after return from screen will fix this too?
20170924 08:18:48< Necrosporus> Yes
20170924 08:18:58< JyrkiVesterinen> I saw a crash on exit myself, but it was with SDL 2.0.6.
20170924 08:19:31< Necrosporus> I get info display: called SDL_Quit()
20170924 08:19:31< Necrosporus> Segmentation fault
20170924 08:19:31< Necrosporus>  when clcicking close button
20170924 08:19:51< JyrkiVesterinen> It's very unlikely that fixing the dropdown showing a wrong value after returning from fullscreen would fix your issues.
20170924 08:20:15< JyrkiVesterinen> From what I can tell, the only problem with the dropdown is that it doesn't query the new window size after returning from fullscreen.
20170924 08:20:46< Necrosporus> Maybe something in wesnoth then queries dropdown and assumes incorrect res
20170924 08:21:06< Necrosporus> Dropdown menu is supposed to set resolution
20170924 08:21:28< JyrkiVesterinen> Only a complete idiot would attempt to determine the window size from the screen resolution dropdown.
20170924 08:21:41< JyrkiVesterinen> To start with, the dropdown only exists if settings window is open.
20170924 08:22:11-!- irker106 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170924 08:24:23< Necrosporus> Anyway, display logdomain doesn't produce anything interesting at all
20170924 08:25:03< Necrosporus> info display: detected a new display format when wesnoth starts and info display: called SDL_Quit() when ends
20170924 08:25:52< Necrosporus> JyrkiVesterinen, my old debug build (near 1.13.9 tag) doesn't segfault at exit
20170924 08:30:46< Necrosporus> I did remove my event.cpp modifications and it still segfaults
20170924 08:31:44-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev
20170924 08:33:19-!- hrubymar10_irc [~hrubymar1@gateway/tor-sasl/hrubymar10irc/x-94850683] has joined #wesnoth-dev
20170924 08:33:33< Necrosporus> $ git status
20170924 08:33:33< Necrosporus> HEAD detached from 1.13.9
20170924 08:33:35< Necrosporus> weird
20170924 08:33:57< JyrkiVesterinen> Detached HEAD doesn't disappear automatically.
20170924 08:34:13< JyrkiVesterinen> Use "git checkout master" if you want to check out post-1.13.9 changes.
20170924 08:34:53< DeFender1031> Well that's morbid...
20170924 08:35:06< Necrosporus> But my binary was already saying 1.13.10 in info
20170924 08:35:20< JyrkiVesterinen> Well, I don't know what you did.
20170924 08:35:45< Necrosporus> git pull and scons rebuild, I have also modified a file... 
20170924 08:36:33< Necrosporus> My build was saying Battle for Wesnoth v1.13.10 (563d080-Modified)
20170924 08:36:37< JyrkiVesterinen> Git pull checks out the latest changes even with detached HEAD?
20170924 08:36:49< Necrosporus> I do not know
20170924 08:38:27-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170924 08:41:26< vn971> JyrkiVesterinen: I think not.
20170924 08:42:17< Necrosporus> It seemed to do so
20170924 08:42:36< Necrosporus> and command git checkout master brought my local state to 9 commits behind
20170924 08:42:48< Necrosporus> subsequent git pull finally fixed it
20170924 08:45:52< vn971> Necrosporus: `git checkout master` just checks out your current _local_ master, which may be 9 commits behind, 9 commits in front, or actually anywhere else. Now, when you're on "master", `git pull` will fetch _remote_ repo and bring your local master to the remote one.
20170924 08:46:18< Necrosporus> Then why have I got 1.13.10 at all?
20170924 08:46:39< Necrosporus> I did use git checkout 1.13.9 or something when it was tagged
20170924 08:46:53-!- gfgtdf [~chatzilla@x4e368753.dyn.telefonica.de] has joined #wesnoth-dev
20170924 08:47:44< Necrosporus> gfgtdf, hello
20170924 08:47:50< gfgtdf> hi
20170924 08:47:58< vn971> IDK. Why did you have "563d080-Modified", is that a normal wesnoth message? Maybe you had current git status to "detached from 1.13.9", but actual files from the next commit? Like what you get if you do "cherry-pic --no-commit"? I don't know. Better not investigate that but solve the actual current problem, if any.:)
20170924 08:49:38< Necrosporus> I have made git status say that all is clear
20170924 08:50:14< gfgtdf> Necrosporus: do you know what happend to yout github issues ? https://github.com/wesnoth/wesnoth/issues/2030 gives me 'page not found'
20170924 08:50:16< Necrosporus> ./wesnoth \n Battle for Wesnoth v1.13.10 (563d080-Clean) I get this now
20170924 08:53:05< Necrosporus> Perhaps I need a clean rebuild?
20170924 08:53:26< Necrosporus> Or not
20170924 08:53:35< Necrosporus> it is correct number of last commit
20170924 08:54:09< Necrosporus> Either way current master segfaults for me or sometimes it prints large memory map and says *** Error in `./wesnoth': free(): invalid pointer: 0x00007f9ca7948000 ***
20170924 08:54:26< JyrkiVesterinen> On exit?
20170924 08:54:59< JyrkiVesterinen> I'm not getting a segfault on exit with my local Windows debug build.
20170924 08:55:40< Necrosporus> Yes
20170924 08:55:56< JyrkiVesterinen> Fortunately crash on exit isn't a big problem...
20170924 08:56:01< Necrosporus> I have undone my event cpp modifications
20170924 08:56:09< Necrosporus> But it could be indication of other problem
20170924 09:00:30-!- hrubymar10_irc [~hrubymar1@gateway/tor-sasl/hrubymar10irc/x-94850683] has quit [Quit: hrubymar10_irc]
20170924 09:02:14-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit []
20170924 09:02:30-!- hrubymar10_irc [~hrubymar1@gateway/tor-sasl/hrubymar10irc/x-94850683] has joined #wesnoth-dev
20170924 09:10:36< gfgtdf> JyrkiVesterinen: considering your latest commit, i'd reccomend just to put these changes in #if SDL_VERSION_ATLEAST blocks
20170924 09:10:46< JyrkiVesterinen> Why?
20170924 09:11:18< gfgtdf> JyrkiVesterinen: some peopel reported crashes on sd 2.0.6 that coudlbe rlated to your commts
20170924 09:11:46< JyrkiVesterinen> On 2.0.6? Do you mean 2.0.5?
20170924 09:12:04< gfgtdf> yes
20170924 09:12:06< gfgtdf> 2.0.5
20170924 09:12:31< JyrkiVesterinen> All right, I'll add such blocks.
20170924 09:12:37-!- hrubymar10_irc [~hrubymar1@gateway/tor-sasl/hrubymar10irc/x-94850683] has quit [Quit: hrubymar10_irc]
20170924 09:12:40< gfgtdf> JyrkiVesterinen: also, in your commit message you claim it's a bug in the SDL side, you you have a link to their bugtracker?
20170924 09:12:47< JyrkiVesterinen> No.
20170924 09:12:49< gfgtdf> those that bug i mean
20170924 09:12:56< gfgtdf> to that bug*
20170924 09:14:00< gfgtdf> hm ok
20170924 09:26:11-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170924 09:35:26< JyrkiVesterinen> Uh, to wrap them to such checks I need to add more files to the project.
20170924 09:35:57< JyrkiVesterinen> Fiirst: I can't use SDL_VERSION_ATLEAST because it checks the version the game was *compiled* with.
20170924 09:36:14< JyrkiVesterinen> SDL's behavior depends on which version is used at *runtime*.
20170924 09:36:32< JyrkiVesterinen> To query the version, I need to use SDL_GetVersion().
20170924 09:37:10< JyrkiVesterinen> And given that I want to use it in two places, I wanted to add a wrapper that returns SDL version as a version_info object.
20170924 09:37:27< JyrkiVesterinen> My first instinct was to add it to sdl/utils.hpp.
20170924 09:38:18< JyrkiVesterinen> Unfortunately, it doesn't work because utils.hpp depends on surface.hpp, and one function that needs it "surface::free_surface()" is there.
20170924 09:38:23< JyrkiVesterinen> Circular dependency.
20170924 09:41:24< JyrkiVesterinen> Hmm... actually, on second thought nothing blocks me from moving surface::free_surface() to surface.cpp.
20170924 09:55:27< loonycyborg> JyrkiVesterinen: which linux distro you're using btw? is it using wayland already?
20170924 09:55:49< JyrkiVesterinen> I use siduction, which is based on Debian Sid.
20170924 09:55:53< JyrkiVesterinen> It uses X.
20170924 09:56:21< loonycyborg> I sometimes test wesnoth w/ wayland on fedora and it kinda doesn't work
20170924 09:56:34< loonycyborg> like before it crashed entire gnome shell
20170924 09:56:46< loonycyborg> now it creates screen with white noise
20170924 09:58:09< loonycyborg> I'm running wesnoth/wayland by setting env var SDL_VIDEODRIVER=wayland
20170924 09:58:50< loonycyborg> it wasn't a priority for me to look into it though
20170924 09:59:07< loonycyborg> since wesnoth won't be good enough wayland app atm anyway
20170924 09:59:19< loonycyborg> it doesn't do client side decorations
20170924 10:00:41< loonycyborg> from what I gather sdl developers are waiting for libdeco to handle it in general way
20170924 10:02:35-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170924 10:04:31< Necrosporus> What does it mean? Like window itself drawing its border instead of letting window manager do it?
20170924 10:04:36< Necrosporus> Doesn't sound like a good idea
20170924 10:05:12< JyrkiVesterinen> Indeed, Wayland requires each window to draw its own borders.
20170924 10:07:22< Necrosporus> I get "Team: teamname^South" in MP interface
20170924 10:07:44< Necrosporus> While other team looks normal "Team: North"
20170924 10:10:53< loonycyborg> no, it doesn't, kde and gnome have different opinions on how it should be done
20170924 10:11:08< loonycyborg> and there's a protocol to choose which of the ways particular app will use
20170924 10:11:23< loonycyborg> and afaik gnome doesn't support server side decos yet
20170924 10:11:37< loonycyborg> while kde went with server side decos for everything
20170924 10:11:51< JyrkiVesterinen> AFAIK, Wayland developers themselves rooted for client-side decorations.
20170924 10:12:39< loonycyborg> I'm not sure about that
20170924 10:12:46< JyrkiVesterinen> KDE attempts to come up with a protocol for server-side decorations that would work with all desktop environments, but such a protocol is not a part of the Wayland specification.
20170924 10:13:13< loonycyborg> well the spec is common work, they'll accept patches from kde people
20170924 10:13:17< JyrkiVesterinen> And IIRC Gnome developers are also opposed to server-side decorations.
20170924 10:14:14< Necrosporus> X11 is better than wayland it seems
20170924 10:14:20< loonycyborg> but I can see how csd could work too
20170924 10:14:39< Necrosporus> When they decided to improve X11 they removed features which were what made X11 a good thing
20170924 10:14:39< loonycyborg> like this aspect is handled by the toolkit anyway
20170924 10:14:52< JyrkiVesterinen> Necrosporus: Indeed, looks like Wayland is nowhere near as good as it was originally hyped. :(
20170924 10:15:30< loonycyborg> I disagree, wayland is basically how things are already, it just removes vestigal unused parts of X11
20170924 10:16:13< loonycyborg> and this is root of the issue, while some x11 roadblocks are removed
20170924 10:16:15< Necrosporus> Such as network transparency?
20170924 10:16:23< loonycyborg> it might be unclear where to move further
20170924 10:17:09< JyrkiVesterinen> Indeed, network transparency is pretty much impossible with modern software such as web browsers. Or games, for that matter.
20170924 10:17:30< loonycyborg> they'll work too slowly through x11 forwarding
20170924 10:17:46< loonycyborg> I once tried wesnoth and it was noticeably slowed down
20170924 10:17:57< JyrkiVesterinen> Exactly. It's essentially video streaming.
20170924 10:18:04< loonycyborg> there are alternatives for that though
20170924 10:18:07< loonycyborg> like vnc
20170924 10:19:48-!- mjs-de [~mjs-de@b9168ef2.cgn.dg-w.de] has quit [Remote host closed the connection]
20170924 10:20:43< Necrosporus> Also tooltip says "Gender: null" while it should say "random"
20170924 10:22:09< Necrosporus> There are  two more things with MP
20170924 10:22:33< Necrosporus> when I left a created but not started game my account still stays in it
20170924 10:24:17< Necrosporus> Also gender tooltip is not translated
20170924 10:29:20< Necrosporus> And yet another bug. Pressing Esc in MP dialog drops the game to main screen not just leaves current game
20170924 10:33:43-!- irker421 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170924 10:33:43< irker421> wesnoth: Jyrki Vesterinen wesnoth:master 33fe9823553c / src/ (sdl/surface.cpp sdl/surface.hpp sdl/utils.cpp sdl/utils.hpp video.cpp): Disable dbd6695da9da224f4700ffa4994a712f35efa7b5 and bc911f8c466f61c6edeab1db529 https://github.com/wesnoth/wesnoth/commit/33fe9823553c13532f191236960f5c8f63676493
20170924 10:35:43-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170924 10:50:45-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170924 11:13:47-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170924 11:39:50-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170924 11:43:17< Necrosporus> JyrkiVesterinen, another player on GNU/Linux was able to reproduce window resize thing
20170924 11:43:31< JyrkiVesterinen> I see.
20170924 11:43:46< JyrkiVesterinen> Still, as long as I can't reproduce, I can't really do anything.
20170924 11:43:46< Necrosporus> I mean 3rd one
20170924 11:44:43< Necrosporus> The question is why you can't reproduce then... hmph
20170924 11:45:08< JyrkiVesterinen> Or alternatively, why some players *can* reproduce.
20170924 11:45:26< Necrosporus> 4 linux users, only you can't reproduce
20170924 11:45:54< JyrkiVesterinen> Your analysis suggests that the window manager is just giving incorrect window dimensions and sometimes neglecting to notify that the window has resized to begin with.
20170924 11:46:07< Necrosporus> Possibly
20170924 11:46:18< Necrosporus> I can ask another player who can reproduce to try my patch
20170924 11:47:05< Necrosporus> or you can suggest some better debug method
20170924 11:47:34< Necrosporus> Or other places in code where diagnostic print could be inserted
20170924 11:47:34< JyrkiVesterinen> Run the game under GDB, put a breakpoint somewhere, print values of variables.
20170924 11:47:47< JyrkiVesterinen> That would be a better debug method.
20170924 11:47:47-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20170924 11:48:17< Necrosporus> What variables, where to put breakpoints?
20170924 11:48:22< JyrkiVesterinen> But I think it would be more fruitful to debug SDL instead of Wesnoth.
20170924 11:49:02< Necrosporus> by the way, I have finished building last master with your fix
20170924 11:49:35< Necrosporus> Anyway, I have found a rather perculiar bug
20170924 11:49:43< Necrosporus> Seems to 100% reproducable
20170924 11:49:59< JyrkiVesterinen> For example, you could put a breakpoint to https://github.com/wesnoth/wesnoth/blob/master/src/events.cpp#L738
20170924 11:50:37< JyrkiVesterinen> http://wiki.libsdl.org/SDL_WindowEvent says that a resize event has the new width in data1 and height in data2.
20170924 11:50:49< Necrosporus> Doesn't segfault on exit anymore
20170924 11:51:19< JyrkiVesterinen> Likewise, within update_framebuffer() you could check the dimensions of the new framebuffer that SDL gives.
20170924 11:51:52< JyrkiVesterinen> Really, the art of debugging is trying to find anything and everything that is wrong.
20170924 11:52:09< JyrkiVesterinen> And ultimately the point where things *start* going wrong.
20170924 11:52:56< JyrkiVesterinen> And I can't really give you a comprehensive list of things that need to be checked. There is just too much.
20170924 11:53:06< JyrkiVesterinen> And I don't even know the internals of SDL.
20170924 11:55:42< Necrosporus> OK, thanks. I will try to do something from what you suggested a bit later. For now what do you think about the other bug:
20170924 11:56:00< Necrosporus> 1) Join a game in wesnoth MP server (somebody else has to create it)
20170924 11:56:03< Necrosporus> 2) Leave this game
20170924 11:56:18< Necrosporus> 3) Notice that you are still in game but you can join as observer
20170924 11:56:56< Necrosporus> 3) A teamname becomes untranslated such as "teamname^South"
20170924 11:57:19< Necrosporus> 4) gender tooltip now says "null" ,which is also untranslated
20170924 11:58:58< JyrkiVesterinen> Multiplayer is gfgtdf's area. I don't really have much to say about it.
20170924 11:59:53< JyrkiVesterinen> Also, that bug isn't very severe. Depending on how risky the fix would be, we maybe shouldn't even push the fix right before a development release.
20170924 12:04:58-!- hrubymar10_irc [~hrubymar1@gateway/tor-sasl/hrubymar10irc/x-94850683] has joined #wesnoth-dev
20170924 12:16:00< Necrosporus> Interesting. Now I somehow can create SP campaigns in MP mode
20170924 12:16:24< Necrosporus> Other player can even play them
20170924 12:17:26< Necrosporus> Though I can't take control of AI side sadly
20170924 12:17:46< Necrosporus> Would be cool if it was possible to play SP campaigns against other player instead of AI
20170924 12:22:17< Necrosporus> Got error while parsing formula, min(list) list is empty in two brothers
20170924 12:25:50-!- hrubymar10_irc [~hrubymar1@gateway/tor-sasl/hrubymar10irc/x-94850683] has quit [Quit: hrubymar10_irc]
20170924 12:28:47-!- hrubymar10_irc [~hrubymar1@gateway/tor-sasl/hrubymar10irc/x-94850683] has joined #wesnoth-dev
20170924 12:43:52-!- hrubymar10_irc [~hrubymar1@gateway/tor-sasl/hrubymar10irc/x-94850683] has quit [Remote host closed the connection]
20170924 12:45:04-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20170924 12:47:23-!- hrubymar10_irc [~hrubymar1@gateway/tor-sasl/hrubymar10irc/x-94850683] has joined #wesnoth-dev
20170924 12:50:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170924 12:56:42< Necrosporus> Weirdly when there were three sides I was able to take one
20170924 12:57:38-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170924 13:02:27< Necrosporus> Another segfault
20170924 13:06:43-!- vn971 [~vasya@94.158.103.15] has quit [Quit: Leaving.]
20170924 13:24:29< Necrosporus> OK, it was less reproduceable than I thought
20170924 13:29:30< celmin|sleep> FTR I'm pretty sure it is possible to declare the same logdomain in multiple files.
20170924 13:33:58-!- irker421 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170924 13:34:11-!- celmin|sleep is now known as celticminstrel
20170924 13:38:14< Necrosporus> Is wesnoth excessively buggy or it's me?
20170924 13:38:32< Necrosporus> I run into bugs every now and then
20170924 13:39:06< celticminstrel> It's probably excessively buggy. Certain people can't seem to stop refactoring stuff.
20170924 13:39:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170924 13:40:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170924 13:40:30< DeFender1031> refactoring stuff tends to mean a lot more bugs in the short term, but less long term.
20170924 13:41:02< DeFender1031> (Unless a given section is refactored yet again before it passes that singularity.)
20170924 13:42:01< Necrosporus> So, I got a segfault in current master
20170924 13:42:18< Necrosporus> Condition was: another player created a game which required addon
20170924 13:42:36< Necrosporus> I have clicked it and while addon was downloading the other player quit
20170924 13:42:50< Necrosporus> then I have seen game disappearing and then segfault
20170924 13:43:01< Necrosporus> not sure if reproduciable
20170924 13:43:51< Necrosporus> celticminstrel, an example
20170924 13:51:57-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170924 14:04:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170924 14:04:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170924 14:09:08-!- mjs-de [~mjs-de@x4db6fee8.dyn.telefonica.de] has joined #wesnoth-dev
20170924 14:46:37-!- hrubymar10_irc is now known as hrubymar10_irc[a
20170924 14:47:15-!- hrubymar10_irc[a [~hrubymar1@gateway/tor-sasl/hrubymar10irc/x-94850683] has quit [Quit: hrubymar10_irc[a]
20170924 14:59:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170924 15:00:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170924 15:00:26-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170924 15:07:25-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has quit [Quit: [endlevel]]
20170924 15:11:43< vultraz> Necrosporus: I contacted GH. I'll let you know if they respond
20170924 15:13:48< Necrosporus> nice. Now there is a question. Which text editor to use to edit WML code. I have found one, but it doesn't seem to have wml lexer
20170924 15:14:05< Necrosporus> Should I try and write one?
20170924 15:14:53< vultraz> Kate has a WML parser shadowm (?) wrote years ago. But most people just use whatever editor they prefer. I use VScode personally
20170924 15:18:29< Necrosporus> KWrite is nice, yes
20170924 15:18:43< Necrosporus> problem is that it requires kde
20170924 15:26:19< DeFender1031> I use KATE for all my coding anyway...
20170924 15:29:01-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20170924 15:34:51< Necrosporus> Spaces or Tabs?
20170924 15:52:23-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170924 15:52:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170924 15:53:24< JyrkiVesterinen> Most WML uses spaces, but some (especially GUI dialogs) use tabs.
20170924 15:59:23< shadowm> It's Kate, not KATE, just like it's Wine, not WINE.
20170924 15:59:48< shadowm> Even if they were acronyms at first, the devs no longer write them as such so it's only fair for users to do the same.
20170924 16:00:25< shadowm> Also I did not write the Kate highlighting schema, I only made some significant improvements to it and maintained it for a while.
20170924 16:00:39< shadowm> Also Kate doesn't require KDE.
20170924 16:01:23< shadowm> It only requires KDE Frameworks, as opposed to the desktop environment (Plasma) and supporting infrastructure.
20170924 16:04:11-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Quit: I'll be back!]
20170924 16:09:05< gfgtdf> Necrosporus: maybe you coudl contact github on why your account weas blocked? It's quit annoying to have missing issues on github.
20170924 16:09:29< vultraz> gfgtdf: i already contacted them
20170924 16:09:37< vultraz> they said he has to contact them himself
20170924 16:10:54< gfgtdf> hmm ok
20170924 16:12:43< DeFender1031> shadowm, I'm a diehard acronymist, what can I say? :P
20170924 16:14:21< gfgtdf> vultraz: so you are currently working on the right-click thing ?
20170924 16:14:36< vultraz> trying to
20170924 16:27:24-!- Bhoren [~Bhoren___@2a01:e0a:c:2150:b2de:a734:f830:ea2b] has joined #wesnoth-dev
20170924 16:27:58-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170924 16:32:09-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170924 16:44:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170924 16:45:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170924 16:46:37-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170924 17:23:35-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170924 17:38:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170924 17:39:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170924 17:50:41-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170924 18:08:39-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20170924 18:19:27-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 252 seconds]
20170924 18:32:54-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Quit: I'll be back!]
20170924 18:37:39-!- mjs-de [~mjs-de@x4db6fee8.dyn.telefonica.de] has quit [Remote host closed the connection]
20170924 18:46:34-!- Ivanovic [~ivanovic@p4FC53858.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170924 18:47:03-!- Ivanovic [~ivanovic@p4FC53858.dip0.t-ipconnect.de] has quit [Changing host]
20170924 18:47:03-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20170924 18:51:39-!- louis94 [~~louis94@121.83-247-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20170924 18:58:25-!- Ivanovic_ [~ivanovic@p4FC53858.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170924 19:01:15-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 252 seconds]
20170924 19:01:30-!- Ivanovic [~ivanovic@p579FB4C7.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170924 19:02:24< celticminstrel> So I realize it's rather early to ask this, but any idea when 1.13.11 can be scheduled?
20170924 19:03:10-!- Ivanovic [~ivanovic@p579FB4C7.dip0.t-ipconnect.de] has quit [Changing host]
20170924 19:03:10-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20170924 19:03:12< Kwandulin> When can we ordinary mortals get a whiff of 1.13.9/10?
20170924 19:03:28-!- Ivanovic_ [~ivanovic@p4FC53858.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20170924 19:04:47< gfgtdf> Kwandulin: sure, you can eigehr build yourself or download it.
20170924 19:05:10< gfgtdf> Kwandulin: vultraz will want'S to adda  patch to it though so you might not get the final version
20170924 19:06:02< Kwandulin> gfgtdf: cant build on my own (no tech guy here). Where can I download? You said something about jenkyns or appveyor earlier? Is there a download link?
20170924 19:06:26< Necrosporus> Kwandulin, what OS you are running?
20170924 19:06:37< Kwandulin> Necrosporus: Windows 10
20170924 19:06:43< gfgtdf> Kwandulin: depends on whihc OS you use, i perosnally only know how to download windows binaries but there might be linux binaried too
20170924 19:07:02< Necrosporus> Kwandulin, then you need to download from three places and combine
20170924 19:07:17< gfgtdf> Kwandulin: first you need the data files from git
20170924 19:07:28< Necrosporus> https://github.com/wesnoth/wesnoth/archive/master.zip
20170924 19:07:52< gfgtdf> Kwandulin: second the exe file from jenkins
20170924 19:08:09< gfgtdf> Kwandulin: third the .dll files from your previousl wesntoh installation
20170924 19:08:57< Necrosporus> Kwandulin, exe file from here https://ci.appveyor.com/project/wesnoth/wesnoth-605wt
20170924 19:09:07< Necrosporus> select artifacts 
20170924 19:09:44< Necrosporus> Dll from here https://github.com/aquileia/external/tree/VC15 (I'm not sure if it should be VC14 or VC15)
20170924 19:10:04< celticminstrel> Note that "previous Wesnoth installation" should be taken to mean 1.13.8 here.
20170924 19:10:10< gfgtdf> vc15 is correct
20170924 19:10:22< Necrosporus> I'm not sure
20170924 19:10:35< gfgtdf> also note that "previous Wesnoth installation" doesnt apply when you do it Necrosporuss way
20170924 19:10:37< Kwandulin> Uhm . . . dont we do that sourceforge thing anymore?
20170924 19:10:49< Necrosporus> another person who also running windows was not able to run Wesnoth using dll from 1.13.8
20170924 19:10:55< gfgtdf> Kwandulin: we ahve but 1.13.10 isn'T released yet
20170924 19:11:10< Necrosporus> But dll from quileai worked
20170924 19:11:22< gfgtdf> Necrosporus: that probably becasue he tried to do it with an appveyor build.
20170924 19:11:24< Necrosporus> Also not that you need only dll files from there
20170924 19:11:39< celticminstrel> Oh yeah, the official builds are MinGW.
20170924 19:11:43< Necrosporus> * note
20170924 19:11:53< celticminstrel> So the aquileia dlls will not work with any official build.
20170924 19:12:07< celticminstrel> I'm guessing they won't work with the jenkins builds, either.
20170924 19:12:41< Necrosporus>  http://baldras.wesnoth.org:8080/job/Wesnoth/ Jenkins is here
20170924 19:13:09< Necrosporus> You need to select MinGW on Debian 32
20170924 19:13:40< Necrosporus> Kwandulin, so you need to pair exe file and set of dll files
20170924 19:13:53< Necrosporus> depending on where you get them you select different locations
20170924 19:15:06< celticminstrel> Also I guess it's .so files for Linux... and you probably don't actually need to worry about them since they're usually installed in system locations.
20170924 19:15:49< celticminstrel> Or was he trying to get a Windows build, maybe I'm just confused here.
20170924 19:15:58< celticminstrel> Yeah okay, sorry.
20170924 19:16:03< celticminstrel> Ignore that, then.
20170924 19:20:37-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...]
20170924 19:20:39< Necrosporus> celticminstrel, if he wants Linux then the easiest way is to install scons or cmake (scons seems to be easier) and let it do the job
20170924 19:20:58-!- Ivanovic [~ivanovic@p579FB4C7.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170924 19:21:03< Necrosporus> The problem is that Kwandulin using windows
20170924 19:21:12< celticminstrel> That wouldn't really work, you know.
20170924 19:21:22< celticminstrel> You need to also install all the other dependencies.
20170924 19:21:32-!- Ivanovic [~ivanovic@p579FB4C7.dip0.t-ipconnect.de] has quit [Changing host]
20170924 19:21:32-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20170924 19:21:39< celticminstrel> And you need the header files, ie the -devel version of each dependency.
20170924 19:22:07< celticminstrel> Maybe some libraries (or some package managers) don't separate those, but some certainly do.
20170924 19:22:28< celticminstrel> That said, the exact same procedure would also work on Windows FTR.
20170924 19:22:57< celticminstrel> Install MinGW or MSVC. Install scons. Obtain the dependencies. Let scons do all the work.
20170924 19:23:05< celticminstrel> Possibly fiddle with %PATH% as well.
20170924 19:23:33< celticminstrel> (Though I wonder if scons+cl has ever actually been tested...)
20170924 19:25:22< Necrosporus> Would clang work?
20170924 19:25:30< Necrosporus> There is windows clang build
20170924 19:26:16< celticminstrel> clang should work with MinGW, or clang-cl with MSVC, I'd guess.
20170924 19:26:51< celticminstrel> (clang-cl is basically a wrapper for clang that uses cl's command-line argument syntax.)
20170924 19:27:06< celticminstrel> (And it means you can use the MSVC dlls.)
20170924 19:28:37< Necrosporus> Why are DLLs from aquilea and DLLs from wesnoth installer different?
20170924 19:28:50< Necrosporus> How does it happen that which set of them work depend on exe file?
20170924 19:29:06< celticminstrel> Unlike Linux, Windows does not have one unified C runtime.
20170924 19:29:06< Necrosporus> I though windows dll loading api should not depend on compiler
20170924 19:29:34< celticminstrel> Each version of MSVC is bundled with its own C and C++ runtime libraries, and MinGW provides yet another C and C++ runtime library.
20170924 19:29:42< Necrosporus> That sucks. So if you use MSVC libc you need to build all the stuff with it?
20170924 19:30:04< celticminstrel> Yes, if you're using the MSVC 2013 libc, all your libs need to be built against the MSVC 2013 libc.
20170924 19:30:28< Necrosporus> What about dll-files which come bundled with windows?
20170924 19:30:37< Necrosporus> Like kernel32.dll or whatever
20170924 19:30:44< celticminstrel> This problem does actually slightly exist on Linux, but only for the C++ runtime not the C runtime - there's GNU's libstdc++ and LLVM's libc++.
20170924 19:31:05< celticminstrel> I'm not quite sure, but kernel32.dll and such are probably the WinAPI runtime, not the C runtime.
20170924 19:31:24< Necrosporus> But they are still dll
20170924 19:31:29< celticminstrel> Sure.
20170924 19:31:43< Necrosporus> Ah, I see. Some dll files use C runtime
20170924 19:31:46< celticminstrel> But you can't just mix and match just any dlls.
20170924 19:31:55< celticminstrel> They need to be binary compatible.
20170924 19:31:56< Necrosporus> They have to be recompiled to use same runtime as main exe?
20170924 19:32:05< celticminstrel> Right, that's pretty much it.
20170924 19:33:12< celticminstrel> It's particularly bad because Microsoft doesn't maintain backwards binary compatibility with its C runtimes.
20170924 19:33:34< celticminstrel> So the MSVC 2013 runtime and the MSVC 2015 runtime are not compatible.
20170924 19:33:49< celticminstrel> They might've finally realized how bad this is with MSVC 2017 though, from what I've heard...
20170924 19:34:01< JyrkiVesterinen> They started providing binary compatibility starting from VS2015.
20170924 19:34:05< celticminstrel> Ah, okay.
20170924 19:34:11< JyrkiVesterinen> VS2015 and VS2017 DLLs are binary compatible.
20170924 19:34:19< celticminstrel> Also I'm pretty sure they've always done it for WinAPI.
20170924 19:34:44< celticminstrel> But of course that doesn't help much if you want to be cross-platform...
20170924 19:36:50< celticminstrel> ...well, from a certain perspective, "they started at MSVC 2017" is still correct, since that's the first one that's backwards compatible with another version... >_>
20170924 19:37:57< JyrkiVesterinen> VS2015 is the version where they did the refactoring that allowed backwards compatibility.
20170924 19:38:17< celticminstrel> I see.
20170924 19:43:12-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170924 19:48:22-!- hrubymar10_irc [~hrubymar1@gateway/tor-sasl/hrubymar10irc/x-94850683] has joined #wesnoth-dev
20170924 19:54:50< shadowm> kernel32.dll is the kernel services component of the Win32 API, yes.
20170924 19:55:32< shadowm> On Windows NT/2000/XP and later it's actually a wrapper around core Windows services that do not provide the same API and ABI compatibility guarantees that the Win32 API does.
20170924 19:56:55< shadowm> The C and C++ runtimes provided by MSVC++ are actually built around the Win32 API themselves, so you have at least four layers of abstraction before you get to the implementation of any system calls involved.
20170924 20:10:02-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170924 20:48:37-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170924 20:51:54-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev
20170924 20:59:09< Necrosporus> Application -> mslibc -> msw32api -> nativeapi -> syscall ?
20170924 21:12:26-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170924 21:13:05-!- louis94 [~~louis94@121.83-247-81.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 240 seconds]
20170924 21:13:26-!- sevu [~Shiki@p548558FE.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170924 21:16:42-!- gfgtdf_ [~chatzilla@x4e368753.dyn.telefonica.de] has joined #wesnoth-dev
20170924 21:18:23-!- gfgtdf [~chatzilla@x4e368753.dyn.telefonica.de] has quit [Ping timeout: 248 seconds]
20170924 21:18:37-!- gfgtdf_ is now known as gfgtdf
20170924 21:44:39-!- hrubymar10_irc [~hrubymar1@gateway/tor-sasl/hrubymar10irc/x-94850683] has quit [Quit: hrubymar10_irc]
20170924 21:44:40-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20170924 21:59:48-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit []
20170924 22:05:48-!- louis94 [~~louis94@121.83-247-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20170924 22:05:49-!- Bhoren [~Bhoren___@2a01:e0a:c:2150:b2de:a734:f830:ea2b] has quit [Quit: Leaving]
20170924 22:27:08-!- louis94 [~~louis94@121.83-247-81.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 240 seconds]
20170924 22:33:58-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170924 22:34:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20170924 22:34:47-!- louis94 [~~louis94@91.138-200-80.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20170924 23:05:05-!- louis94 [~~louis94@91.138-200-80.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 240 seconds]
20170924 23:19:59-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170924 23:20:32-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170924 23:22:59-!- gfgtdf [~chatzilla@x4e368753.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 55.0.3/20170824053622]]
20170924 23:34:50< sevu> I tried latest master ( with the new fix ), still with sdl 2.0.5 - I can't quit game from the title screen - freezes
20170924 23:38:28< sevu> hmmm - when I click quit -> yes ... (no in the editor)
20170924 23:38:41< sevu> 's/no/now/'
20170924 23:56:39-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170924 23:58:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
--- Log closed Mon Sep 25 00:00:09 2017