--- Log opened Wed Sep 27 00:00:11 2017
20170927 00:24:58-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170927 00:35:22-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170927 00:35:28-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170927 00:53:35-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Ping timeout: 240 seconds]
20170927 01:00:52-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170927 02:27:35-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170927 02:38:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170927 02:59:25-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170927 04:06:49-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170927 04:23:14-!- vn9711 [~vasya@94.158.103.15] has joined #wesnoth-dev
20170927 04:23:47-!- allefant [~allefant@allegro/developer/allefant] has joined #wesnoth-dev
20170927 04:25:28-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20170927 04:25:42-!- Jetrel_ec2 [~Jetrel@ec2.happyspork.com] has joined #wesnoth-dev
20170927 04:26:02-!- Appleman1234_ [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev
20170927 04:29:54-!- Netsplit *.net <-> *.split quits: heirecka, molgrum, vn971, elias, nurupo, Jetrel_bot, Appleman1234
20170927 04:29:54-!- Jetrel_ec2 is now known as Jetrel_bot
20170927 04:30:18-!- Netsplit over, joins: nurupo
20170927 04:31:18-!- Netsplit over, joins: molgrum
20170927 04:32:08-!- Netsplit over, joins: heirecka
20170927 04:36:42-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170927 05:37:37-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170927 06:28:04-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20170927 06:46:32-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20170927 07:44:24-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170927 08:45:32-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170927 09:07:49-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20170927 09:30:04-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170927 09:52:24-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170927 10:39:43-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20170927 10:45:58-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
20170927 10:46:30-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170927 10:52:43< vn9711> I'm getting _a lot_ of those crashes recently: > /build/wesnoth/src/wesnoth/src/flg_manager.cpp:565: int mp::flg_manager::leader_index(const string&) const: Assertion `it != choosable_leaders_.end()' failed.
20170927 10:52:53< vn9711> really, shouldn't we fix it?
20170927 10:54:05< vn9711> I mean, it happens real ofthen. If I understand it correnctly, it might have something to do with the way I choose leaders for sides. I often set all leaders _before_ anyone actually joins. It's on CreepWars map, and I set all of them to "Mirror".
20170927 10:55:32< JyrkiVesterinen> Which version are you using?
20170927 10:55:34< vn9711> it happens exactly when somebody joins, if I understand it correctly.
20170927 10:55:40< vn9711> JyrkiVesterinen: 12...
20170927 10:56:09< JyrkiVesterinen> In that case, it's very likely that it has already been fixed.
20170927 10:56:24< JyrkiVesterinen> The equivalent function in master doesn't contain any assertions.
20170927 11:00:58< vn9711> JyrkiVesterinen: so a 1.12 fix is not deemed appropriate?
20170927 11:01:31< JyrkiVesterinen> There will be another 1.12 release only if a security bug is found in 1.12 before we release 1.14.
20170927 11:01:47< JyrkiVesterinen> And even if it happens, such a release will be short-lived.
20170927 11:02:04< JyrkiVesterinen> To be blunt, we donät care about bugs which don't occur in master.
20170927 11:02:08< JyrkiVesterinen> *don't
20170927 11:18:52-!- louis94 [~~louis94@91.138-200-80.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20170927 11:22:29-!- louis94 [~~louis94@91.138-200-80.adsl-dyn.isp.belgacom.be] has quit [Client Quit]
20170927 12:06:01-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170927 12:13:13< vn9711> OK, clear.
20170927 12:57:12-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170927 13:02:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170927 13:23:27< Necrosporus> Is there a rule to use singular or plural to race name?
20170927 13:23:57< Necrosporus> orc, dwarf, elf, human and so on have singular race name, but bats have plural
20170927 13:51:40-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170927 14:06:38< AI0867> then, probably, there isn't
20170927 14:10:06-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20170927 14:59:58-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170927 15:02:57-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20170927 15:09:08-!- louis94 [~~louis94@91.138-200-80.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20170927 15:49:43-!- sevu [~Shiki@p5485450F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170927 15:52:15-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20170927 16:10:35< Necrosporus> It was quite quiet today though
20170927 16:10:57< Necrosporus> No updates in issues for last 21 hours
20170927 16:40:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170927 16:40:16< Necrosporus> JyrkiVesterinen, so, you have suggested to track window events in SDL rather than in wesnoth. I know you said GDB is better, but for now debug print would be easier to understand for me. Now looking in SDL code, suggest that it has something to do with https://hg.libsdl.org/SDL/file/973151a33ec5/src/events/SDL_windowevents.c#l128
20170927 16:41:28< JyrkiVesterinen> I think that adding a debug print there would just confirm the same thing, that SDL is sending incorrect (and sometimes missing) resize events.
20170927 16:41:33< Necrosporus> So, what if I add a line like fprintf(stderr, "..."); which prints window dimensions every time 
20170927 16:41:34-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170927 16:41:51< JyrkiVesterinen> I just responded to that. :P
20170927 16:42:01< Necrosporus> JyrkiVesterinen, then we will know that wesnoth is fine?
20170927 16:42:29< JyrkiVesterinen> Yes, I think so.
20170927 16:42:40< Necrosporus> But, there are events such as SDL_WINDOW_MAXIMIZED
20170927 16:42:54< Necrosporus> Should they automatically call resize events?
20170927 16:43:04< Necrosporus> Maybe wesnoth have to track them separately
20170927 16:43:40< JyrkiVesterinen> SDL is supposed to send a resize event whenever the window size changes, including when the window is maximized.
20170927 16:44:16< JyrkiVesterinen> Judging from that function, SDL is either relying on the WM to send such a resize event, or generates those events themselves somewhere else.
20170927 16:44:47-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170927 16:50:12-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20170927 16:52:14< Necrosporus> So if I want debug build I should add CFLAGS=-g to libsdl?
20170927 16:53:25< Necrosporus> I mean ./configure
20170927 16:53:53< JyrkiVesterinen> Yes.
20170927 16:57:48-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170927 17:03:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170927 17:03:36< Necrosporus> OK, my debug print works
20170927 17:04:37< Necrosporus> It doesn't print anything when I switch resolution in drop-down even though windows is resized and widgets accomodate
20170927 17:05:03< Necrosporus> It does print stuff when I resize window by grabbing its corner though
20170927 17:05:24< Necrosporus> SDL_WINDOWEVENT_RESIZED: 801x600
20170927 17:05:24< Necrosporus> SDL_WINDOWEVENT_RESIZED: 802x600
20170927 17:05:24< Necrosporus> SDL_WINDOWEVENT_RESIZED: 802x601
20170927 17:06:17< Necrosporus> My print is fprintf(stderr,"SDL_WINDOWEVENT_RESIZED: %dx%d\n",data1, data2); after window->h = data2;
20170927 17:07:54< Necrosporus> Clicking fullscreen does print stuff though
20170927 17:11:33< Necrosporus> Maximize button produces SDL_WINDOWEVENT_RESIZED: 1280x768 (which is incorrect)
20170927 17:19:28-!- allefant is now known as elias
20170927 17:25:50-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170927 17:27:36< Necrosporus> Now a perhaps-stupid question. How do I set a breakpoint to my debug print?
20170927 17:27:48< Necrosporus> break expects line number?
20170927 17:28:07< JyrkiVesterinen> break SDL_windowsevents.c:138
20170927 17:29:08< Necrosporus> how do I get to gdb console while program is running? Or I need to put break before using `run`?
20170927 17:29:36< JyrkiVesterinen> I always add the breakpoints before using run.
20170927 17:31:40< Necrosporus> (gdb) break SDL_windowsevents.c:138
20170927 17:31:40< Necrosporus> No symbol table is loaded.  Use the "file" command.
20170927 17:31:40< Necrosporus> Make breakpoint pending on future shared library load? (y or [n]) y
20170927 17:31:49< Necrosporus> gdb --args env LD_PRELOAD=../SDL2-2.0.5/build/.libs/libSDL2-2.0.so.0.4.1 ./wesnoth
20170927 17:32:09< Necrosporus> I guess I need to tell it to load symbols from library file as well as from executable itself
20170927 17:33:47< JyrkiVesterinen> Oh, right. Dynamically linked libraries are significantly harder to debug than programs.
20170927 17:34:34< Necrosporus> I did use gdb only to get backtrace before, btw
20170927 17:34:57< JyrkiVesterinen> I have used GDB for more advanced debugging, but never tried to debug DLLs with it.
20170927 17:35:21< Necrosporus> didn't you find a bug in SDL 2.0.6 just recently?
20170927 17:36:15< JyrkiVesterinen> I found it by looking into SDL's behavior and recent changes.
20170927 17:38:13< JyrkiVesterinen> I stepped into the surface assignment operator, and noticed that the blit map became null right after calling SDL_FreeSurface().
20170927 17:38:45< JyrkiVesterinen> After that, I used GitHub's blame feature to check if there were any recent changes to SDL_FreeSurface(), and immediately noticed the problematic commit.
20170927 17:39:23< JyrkiVesterinen> In general, regressions are easier to investigate, because looking at recent commits is an option.
20170927 17:44:59< Necrosporus> (gdb) break SDL_OnWindowResized 
20170927 17:44:59< Necrosporus> Cannot access memory at address 0x1251a4
20170927 17:45:07< Necrosporus> hmph
20170927 17:46:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170927 17:46:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170927 17:51:38< Necrosporus> JyrkiVesterinen, https://pastebin.com/AXyZkXer does this help?
20170927 17:52:29< JyrkiVesterinen> The only thing that backtrace tells is that SDL_OnWindowResized() *can* be called that way.
20170927 17:54:04< JyrkiVesterinen> Actually useful information would be stuff like "how exactly does SDL detect that a window has been resized", and the obvious follow-up "does the WM give correct window dimensions to SDL, or does SDL screw them up itself".
20170927 17:54:55< JyrkiVesterinen> *incorrect
20170927 18:01:03-!- louis94 [~~louis94@91.138-200-80.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 248 seconds]
20170927 18:02:09-!- louis94 [~~louis94@91.138-200-80.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20170927 18:10:20< Necrosporus> https://hg.libsdl.org/SDL/file/007dfe83abf8/src/video/x11/SDL_x11events.c#l872
20170927 18:21:28-!- mjs-de [~mjs-de@x4e30f780.dyn.telefonica.de] has joined #wesnoth-dev
20170927 18:21:51-!- louis94 [~~louis94@91.138-200-80.adsl-dyn.isp.belgacom.be] has quit [Read error: Connection reset by peer]
20170927 20:19:19-!- mjs-de [~mjs-de@x4e30f780.dyn.telefonica.de] has quit [Remote host closed the connection]
20170927 20:51:05-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 240 seconds]
20170927 20:56:14-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20170927 21:10:47-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20170927 21:12:26-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Remote host closed the connection]
20170927 21:30:45-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20170927 21:55:47-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170927 22:09:41-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 240 seconds]
20170927 22:10:10-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20170927 22:20:41-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Ping timeout: 240 seconds]
20170927 22:28:07-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20170927 22:40:29-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170927 23:00:48< sevu> Is a 1.14.0 release before Christmas realistic?
20170927 23:04:07< pydsigner> Wow that's less than 3 months away
20170927 23:06:15< sevu> though it are still 3 months
20170927 23:15:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170927 23:19:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170927 23:51:41-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20170927 23:54:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170927 23:55:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
--- Log closed Thu Sep 28 00:00:13 2017