--- Log opened Mon Oct 16 00:00:36 2017
20171016 00:35:03-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20171016 00:38:07-!- irker774 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20171016 00:50:33-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20171016 02:27:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20171016 03:34:09-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20171016 04:22:20-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171016 04:22:28-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171016 05:34:43-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20171016 06:13:58-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20171016 06:34:31-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20171016 06:46:49< Necrosporus> I have found a easy way to jump between 1.12 and 1.13 addon directories in shell: cd ${PWD/3/2}
20171016 06:49:06< Necrosporus> also works as cp -ivr Some_Addon ${PWD/2/3}
20171016 09:15:30-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20171016 10:23:57-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20171016 11:19:35-!- atarocch [~atarocch@93.56.164.28] has quit [Ping timeout: 240 seconds]
20171016 11:25:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171016 11:32:26-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20171016 11:54:53-!- atarocch [~atarocch@93.56.164.28] has quit [Remote host closed the connection]
20171016 11:59:46-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20171016 12:21:15-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20171016 12:41:01-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20171016 12:59:04-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20171016 13:07:04-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20171016 13:37:33-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20171016 14:17:18-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20171016 14:21:15-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20171016 14:30:13-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20171016 14:44:08-!- celticminstrel is now known as celmin|snooze
20171016 15:11:41-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171016 15:11:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20171016 15:29:38< vultraz> zookeeper: can i merge the sconces?
20171016 15:30:22< zookeeper> i haven't looked at them yet. there's no compatibility breakage, right, they're just a new overlay terrain?
20171016 15:30:31< vultraz> yes.
20171016 15:30:41< vultraz> i was considering hiding the lit stone walls, though
20171016 15:30:56< vultraz> but that's unrelated
20171016 15:31:44< zookeeper> i guess it's ok then? i've been very distracted lately so i've been slow to look at PR's and stuff.
20171016 15:32:32< zookeeper> someone should definitely tell doofus to stop messing up the columns in terrain-graphics.cfg though. he _always_ messes them up.
20171016 15:32:39-!- stikonas_ is now known as stikonas
20171016 15:33:52< vultraz> going to squash and manually push
20171016 15:36:09< vultraz> ah ya know what, I'll fix the indent while I'm at it
20171016 15:36:54< zookeeper> \o/
20171016 15:37:42< zookeeper> there's a lot of misaligned stuff from his past PR's, too, so maybe better to do a separate alignment run afterwards. maybe.
20171016 15:38:52< vultraz> I already ran wmlindent and fixed those a few weeks ago
20171016 15:39:13< vultraz> BTW, we should really decide whether #arg values should be indented
20171016 15:39:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20171016 15:40:24< vultraz> (well, ok, there might be some addition indent fixes rolled into this but meh)
20171016 15:41:18< zookeeper> IIRC if you indent them then the whitespace is rolled into the value
20171016 15:41:42< vultraz> well that's not good
20171016 15:42:13< zookeeper> well if you trim the whitespace, then you can't include whitespace in the value, and that wouldn't be good either.
20171016 15:42:34< zookeeper> unless you include quotes in the value, which you might not want to do in all cases
20171016 15:44:12< zookeeper> i don't think it's a big problem. you already have to understand what you're doing, for example whether to have your macro's #enddef on a separate line or not depending on how the macro is intended to be used.
20171016 15:45:01< zookeeper> in this case, the #arg value starts immediately after the linebreak, and that's as simple and straightforward as it can be
20171016 15:45:17< vultraz> we should tell wmlindent not to indent them, then
20171016 15:45:25< zookeeper> oh, does it do that now?
20171016 15:46:09< zookeeper> that would indeed be a problem :P
20171016 15:46:21-!- irker299 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171016 15:46:21< irker299> wesnoth: Charles Dang wesnoth:master 32dcbd62a5e3 / src/hotkey/hotkey_command.cpp: Hotkey Command: formatting cleanup https://github.com/wesnoth/wesnoth/commit/32dcbd62a5e35e1b46cceedb09054b8546c94d6f
20171016 15:46:24< irker299> wesnoth: doofus-01 wesnoth:master 2a7947544856 / data/core/ (40 files in 5 dirs): New Sconce/Torches overlay terrain by doofus-01 https://github.com/wesnoth/wesnoth/commit/2a7947544856a72934299692a495518f6830031f
20171016 15:50:13< celmin|snooze> It's probably safer not to indent #arg yeah
20171016 15:52:11-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20171016 15:52:32< celmin|snooze> I still need to add #deprecated too... :|
20171016 15:55:00< vultraz> you do, yes
20171016 15:56:14< irker299> wesnoth: gfgtdf wesnoth:master f5911b653a72 / src/units/filter.cpp: fix filters using this_unit in [hides] https://github.com/wesnoth/wesnoth/commit/f5911b653a7281825b01b587c94aff06d0b07bb4
20171016 15:56:28< vultraz> merged since you greenlit
20171016 15:56:46< celmin|snooze> Heh, greenlit
20171016 15:59:11< vultraz> zookeeper: are we going to remove the old UtBS codepath for 1.14?
20171016 16:01:49< celmin|snooze> I still think the sun and moon split was cool though.
20171016 16:18:42< vultraz> blah, my hotkey command code cleanup isn't working
20171016 16:18:53< celmin|snooze> ?
20171016 16:19:12< vultraz> various cleanups I was working on
20171016 16:19:58< vultraz> oh wait, just needed to sub 1
20171016 16:19:59< vultraz> ok
20171016 16:20:15< vultraz> still, I'm not sure having hotkey_command be copied is optimal..
20171016 16:23:27< irker299> wesnoth: Charles Dang wesnoth:master 64493b256fcd / data/core/terrain.cfg: Hide Lit Stone Walls terrain https://github.com/wesnoth/wesnoth/commit/64493b256fcdc8cceb8a88286513534efaf93f10
20171016 16:25:17< vultraz> ya know, I must say, the new sconces look much better than the old torche
20171016 16:25:18< vultraz> s
20171016 16:25:41< celmin|snooze> Let's see, it has three strings in it, so it could be a tad slow, but not that bad, I'd think.
20171016 16:26:18< celmin|snooze> One of those strings is pretty short.
20171016 16:26:24< celmin|snooze> The other two are fairly long, though.
20171016 16:27:05< vultraz> (context: one of my changes is to throw out ptr_vector)
20171016 16:27:39< vultraz> I was attempting to store them in the vector directly and use move assignment for vector::erase, but for some reason the compiler *demands* a copy assignment operator
20171016 16:28:03< celmin|snooze> Are we still talking about hotkey_command?
20171016 16:28:10< celmin|snooze> Because that had a copy assignment operator.
20171016 16:28:15< celmin|snooze> ^has
20171016 16:28:22< vultraz> no it doesn't?
20171016 16:28:35< celmin|snooze> Yes it does.
20171016 16:28:49< vultraz> where?
20171016 16:29:06< celmin|snooze> The default copy assignment operator.
20171016 16:29:24< celmin|snooze> Which is automatically added to any class that doesn't declare some other copy assignment operator.
20171016 16:29:38< vultraz> it was deleted for some reason because of the t_string member
20171016 16:29:38< celmin|snooze> Unless it contains some data that cannot be copy-assigned.
20171016 16:29:47< celmin|snooze> Oh.
20171016 16:30:01< celmin|snooze> Then what you need to do is ensure t_string has a copy assignment operator.
20171016 16:30:30< vultraz> it does
20171016 16:30:45< celmin|snooze> ...okay, now I'm a little confused...
20171016 16:30:54< vultraz> "has either no appropriate copy assignment operator or overload resolution was ambiguous"
20171016 16:31:04< celmin|snooze> Hmm.
20171016 16:31:33< vultraz> what is mystifying is even if I specified a noexcept move assignment op vector wasn't satisfied
20171016 16:32:07< celmin|snooze> So that quote refers to t_string, right?
20171016 16:32:29< vultraz> yes
20171016 16:32:37< celmin|snooze> Does it have more than one assignment operator?
20171016 16:32:52< celmin|snooze> What's the exact parameter type of the copy assignment operator?
20171016 16:33:16< celmin|snooze> (Note: "copy assignment operator" does mean the type needs to be some variation on t_string.)
20171016 16:33:17< vultraz> t_string?
20171016 16:33:21< celmin|snooze> ...
20171016 16:33:25< celmin|snooze> EXACT TYPE
20171016 16:33:32< celmin|snooze> ...
20171016 16:33:34< vultraz> I mean are you asking about the t_string class
20171016 16:33:39< celmin|snooze> Oh.
20171016 16:33:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171016 16:33:41< celmin|snooze> Yes of course.
20171016 16:33:47< celmin|snooze> t_string is the problem here.
20171016 16:33:58< vultraz> t_string(const t_string&);
20171016 16:34:08< celmin|snooze> 'kay
20171016 16:34:33< celmin|snooze> Not the ideal way of doing it IMO, but that's fine.
20171016 16:35:07< celmin|snooze> So "no appropriate copy assignment operator" seems impossible.
20171016 16:35:19< celmin|snooze> Which suggests "overload resolution was ambiguous".
20171016 16:37:07< vultraz> I can define a default copy assignment operator in hotkey_command to make the compiler happy ftr
20171016 16:37:33< celmin|snooze> Eh?
20171016 16:37:44< celmin|snooze> As in, explicitly defaulting the copy assignment operator works?
20171016 16:37:53< celmin|snooze> Like with =default
20171016 16:37:55< vultraz> hotkey_command& operator=(const hotkey_command&) = default;
20171016 16:38:01< celmin|snooze> Weird.
20171016 16:38:09< celmin|snooze> But if it works, then sure, I guess.
20171016 16:38:17< vultraz> but do we want this thing to be copied?
20171016 16:38:27< vultraz> i mean, the vector can have over 200 of these objects
20171016 16:38:51< celmin|snooze> Isn't this vector populated just once?
20171016 16:39:28< vultraz> erasure happens in remove_wml_hotkey
20171016 16:39:38< celmin|snooze> Oh right, WML hotkeys exist.
20171016 16:40:43< vultraz> yes. yes they do :P
20171016 16:41:05< vultraz> I've been pondering an alternative container
20171016 16:41:40< vultraz> nothing occurs to me
20171016 17:00:18< vultraz> celmin|snooze: should we add a move ctor/assignment thingy to t_string
20171016 17:01:36< celmin|snooze> Adding a move constructor is probably a good idea.
20171016 17:01:52< celmin|snooze> Then change the assignment operator to use copy and swap idiom.
20171016 17:02:15< celmin|snooze> Which means its signature becomes "t_string& operator=(t_string other);"
20171016 17:02:21< vultraz> or maybe not, since all it has is a shared_ptr...
20171016 17:02:37< celmin|snooze> Huh?
20171016 17:02:47< celmin|snooze> What are you even talking about, it has two std::strings...
20171016 17:02:49< vultraz> t_string only has 1 member
20171016 17:03:02< vultraz> a t_string_base shared_ptr
20171016 17:03:06< celmin|snooze> ...
20171016 17:04:32< celmin|snooze> That's... actually quite weird.
20171016 17:04:45< celmin|snooze> Why doesn't it just inherit from t_string_base? It would give the exact same effect.
20171016 17:05:04< vultraz> I don't know
20171016 17:05:05< celmin|snooze> As far as I can tell by only looking at the header.
20171016 17:05:25< vultraz> it's like t_string is a ptr
20171016 17:05:35< celmin|snooze> But it also says "never null".
20171016 17:05:47< celmin|snooze> Which is why I said inheritance would give the exact same effect.
20171016 17:07:30< vultraz> but why use inheritance at all here
20171016 17:07:33< vultraz> i mean
20171016 17:07:36< celmin|snooze> No idea.
20171016 17:07:36< vultraz> why can't they be one class
20171016 17:07:45< celmin|snooze> Yeah, no idea.
20171016 17:07:54< celmin|snooze> Ask whoever wrote it in the first place.
20171016 17:09:00< vultraz> interesting
20171016 17:09:08< celmin|snooze> ?
20171016 17:09:10< vultraz> t_string_base is used directly in the preprocessor parser
20171016 17:09:17< celmin|snooze> :O
20171016 17:09:22< celmin|snooze> Why?
20171016 17:10:06< vultraz> I... really don't know
20171016 17:10:20< vultraz> maybe for this?
20171016 17:10:28< vultraz> 				if(buffer.translatable()) {
20171016 17:10:29< vultraz> 					cfg[*curvar] = t_string(buffer);
20171016 17:10:29< vultraz> 				} else {
20171016 17:10:29< vultraz> 					cfg[*curvar] = buffer.value();
20171016 17:10:29< vultraz> 				}
20171016 17:10:38< vultraz> (buffer is the t_string_base)
20171016 17:10:51< vultraz> this is in parser::parse_variable()
20171016 17:10:53< celmin|snooze> Hmm.
20171016 17:11:29< celmin|snooze> That seems like it's necessary to distinguish between translatable and non-translatable strings in the parser?
20171016 17:11:41< vultraz> perhaps
20171016 17:11:53< vultraz> that would make sense
20171016 17:12:07< vultraz> and you can't just use a string since then you don't know if it's translatable 
20171016 17:12:08< vultraz> still
20171016 17:12:14< vultraz> t_string could use inheritance 
20171016 17:13:01< celmin|snooze> Possibly private inheritance then.
20171016 17:15:46< vultraz> oooo a union
20171016 17:15:57< vultraz> rare, these are
20171016 17:16:48< vultraz> another union!
20171016 17:17:32< celmin|snooze> ???
20171016 17:18:02< vultraz> t_string_base uses unions
20171016 17:18:09< celmin|snooze> BTW, unions are to std::varint what structs are to std::tuple.
20171016 17:18:12< celmin|snooze> ^variant
20171016 17:18:21< celmin|snooze> (Or sorry, it's still boost::variant I guess.)
20171016 17:18:37< vultraz> I don't follow
20171016 17:18:44< vultraz> i mean, I understand what a union is
20171016 17:18:48< vultraz> but i don't follow your analogy 
20171016 17:19:21< celmin|snooze> A C struct is literally a tuple where each element is referred to by name, rather than number.
20171016 17:19:33< vultraz> I see
20171016 17:19:40< celmin|snooze> A union is a variant where each element is referred to by name, rather than type.
20171016 17:20:08< celmin|snooze> (Should've probably said "A C union" too, as C++ unions can contain functions and stuff.)
20171016 17:20:34< vultraz> no idea what it's actually doing here, though
20171016 17:20:35< vultraz> https://github.com/wesnoth/wesnoth/blob/master/src/tstring.cpp#L181
20171016 17:21:05< celmin|snooze> Ah, here it's being used as a reinterpret_cast.
20171016 17:21:28< vultraz> O_O
20171016 17:21:46< vultraz> why not use reinterpret_cast then?
20171016 17:21:59< celmin|snooze> ISTR that produced warnings or something? I can't recall exactly.
20171016 17:22:34< vultraz> checks log...
20171016 17:22:50< JyrkiVesterinen> reinterpret_cast is tehcnically not guaranteed to produce the expected result. This kind of copying is the only truly safe method.
20171016 17:23:04< vultraz> ah yes
20171016 17:23:04< celmin|snooze> (FTR I'm pretty sure I wrote that code.)
20171016 17:23:10< vultraz> you did
20171016 17:23:14< JyrkiVesterinen> Still, I'd rather use reinterpret_cast. In practice it works everywhere, and it's easier to understand.
20171016 17:24:17< vultraz> I'm not even sure what it's supposed to be doing...
20171016 17:24:47< JyrkiVesterinen> Interpret four bytes as an integer and store them as count.
20171016 17:25:05< vultraz> isn't that just... 4?
20171016 17:25:10< celmin|snooze> ...what?
20171016 17:25:27< celmin|snooze> It reads four bytes of the string and interprets them as a 32-bit integer.
20171016 17:25:42< vultraz> oh
20171016 17:25:46< celmin|snooze> (Which is exactly the same thing Jyrki said.)
20171016 17:27:57< zookeeper> vultraz, yeah. although, i didn't realize before that that means dropping UtBS savefile compatibility between 1.13.10 and 1.13.11 or whatever.
20171016 17:33:01< vultraz> hm. inheriting from t_string_base requires some changes...
20171016 17:39:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20171016 17:40:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171016 17:55:51-!- travis-ci [~travis-ci@ec2-54-159-151-101.compute-1.amazonaws.com] has joined #wesnoth-dev
20171016 17:55:52< travis-ci> wesnoth/wesnoth#15308 (master - 2a79475 : doofus-01): The build has errored.
20171016 17:55:52< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/288628780
20171016 17:55:52-!- travis-ci [~travis-ci@ec2-54-159-151-101.compute-1.amazonaws.com] has left #wesnoth-dev []
20171016 18:01:02< vultraz> celmin|snooze: actually i think we want public inheritance here
20171016 18:06:40< vultraz> ..hmm
20171016 18:06:56< vultraz> actually, ya know, there's literally no reason I can see for these classes not to be one class
20171016 18:07:17< vultraz> t_string itself offers *no* additional functionality I can see
20171016 18:07:29< vultraz> all it is is management of that pointer
20171016 18:11:18< vultraz> ahh, I see...
20171016 18:11:29< vultraz> the purpose was to allowed shared tstring
20171016 18:11:31< vultraz> s
20171016 18:16:25< celmin|snooze> The only reason I suggested private inheritance is that it more closely mirrors the current situation, which is that if you have a t_string you can't access the functions in t_string_base.
20171016 18:16:39< celmin|snooze> What do you mea by "shared tstrings"?
20171016 18:18:19< vultraz> multiple tstrings referring to the same base string
20171016 18:20:32-!- Gfgtdf [1f12fedc@gateway/web/freenode/ip.31.18.254.220] has joined #wesnoth-dev
20171016 18:25:08< Gfgtdf> My hides  pr: while it does improve the situation it does not compleley fix the provlem which seemed to be that the filter is applied on the temporary unit in the drawing  code where $thiaunit doesnt work because that unit is not really on the map 
20171016 18:29:54-!- Gfgtdf [1f12fedc@gateway/web/freenode/ip.31.18.254.220] has quit [Ping timeout: 260 seconds]
20171016 18:30:29< Necrosporus> https://forums.wesnoth.org/viewtopic.php?p=618324#p618324 Since this code looks correct, but doesn't work, could it be engine bug?
20171016 18:30:46< celmin|snooze> Ah.
20171016 18:31:06< celmin|snooze> Well, the current setup does look like it would support a CoW idiom...
20171016 18:31:16< celmin|snooze> Maybe it already does, I dunno.
20171016 18:31:49< celmin|snooze> gfgtdf: So um... maybe there shouldn't be a temporary unit in the drawing code?
20171016 18:33:51< vultraz> CoW?
20171016 18:40:35< shadowm> Copy on write probably.
20171016 18:40:54< celmin|snooze> ^
20171016 18:47:33-!- mjs-de [~mjs-de@x4e304123.dyn.telefonica.de] has joined #wesnoth-dev
20171016 19:31:09-!- mjs-de [~mjs-de@x4e304123.dyn.telefonica.de] has quit [Remote host closed the connection]
20171016 19:44:46-!- irker299 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20171016 19:46:52-!- sigurdfd [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20171016 20:22:30-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20171016 20:34:10-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20171016 20:43:38-!- louis94 [~~louis94@241.67-65-87.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20171016 20:44:11< vultraz> *pokes celmin|snooze about https://github.com/wesnoth/wesnoth/pull/993 *
20171016 20:49:29-!- louis94 [~~louis94@241.67-65-87.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 246 seconds]
20171016 20:59:59< sigurdfd> should objective hints only be shown on easy difficulty? There's some in AOI that are shown on all difficulties?
20171016 21:00:52< vultraz> depends
20171016 21:02:07< vultraz> there's isn't a catch-all rule
20171016 21:02:31< sigurdfd> hmm... ok.
20171016 21:03:54< vultraz> for example we want certain beginner hints to be easy-only but other times we just want to offer a general scenario hint
20171016 21:04:36< sigurdfd> ok. given that, I think the hint layout in AOI should be good
20171016 21:13:58< celmin|snooze> vultraz: I haven't addressed any of sigurdfd's issues.
20171016 21:14:09< vultraz> :(
20171016 21:14:13< celmin|snooze> I simply haven't found time to work on it at all recently.
20171016 21:14:18< vultraz> i see
20171016 21:14:22< vultraz> alright
20171016 21:18:33< sigurdfd> vultraz: I think I've figured out how to go about cutscene deployment.
20171016 21:19:02< sigurdfd> zookeeper: any issue with that ^ ? It'll touch about 35 scenarios in mainline
20171016 21:19:06-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20171016 21:19:35< zookeeper> uh what?
20171016 21:19:39< vultraz> 35 is good
20171016 21:19:55< sigurdfd> adding theme=Cutscene_Minimal to 35 scenarios
20171016 21:19:55< vultraz> zookeeper: he's deploying the cutscene themes
20171016 21:20:15< sigurdfd> and a few that I've thought of that would use [change_theme]
20171016 21:20:31< zookeeper> umm, okay i guess? remind me, does the theme still feature the right-side unit info panel?
20171016 21:20:35< sigurdfd> should I post it as a PR first?
20171016 21:20:53< sigurdfd> no, it won't
20171016 21:21:29< zookeeper> hmh. i wonder if that's a problem in any scenario, not being able to see the stats/types/etc of some of the speakers?
20171016 21:22:04< celmin|snooze> Any reasons to ever use non-minimal cutscene?
20171016 21:22:07< sigurdfd> I'm aiming to deploy it in dialog only scenarios
20171016 21:22:19< zookeeper> well of course in dialog only scenarios :P
20171016 21:22:22< celmin|snooze> Not that I have any idea what the difference is.
20171016 21:22:22< sigurdfd> hmmmm...
20171016 21:22:55< sigurdfd> Cutscene has Menu and End turn at top of screen. Cutscene Minimal has nothing
20171016 21:23:23< sigurdfd> both have very striped down right-click commands if wml errors are thrown
20171016 21:23:44< celmin|snooze> I suppose you can still exit cutscene minimal by pressing Esc though?
20171016 21:23:50< celmin|snooze> Or even with a right-click?
20171016 21:24:11< sigurdfd> ...with cutscene_minimal only having Quit to Titlescreen and End_Turn in the right click
20171016 21:24:18< celmin|snooze> I see.
20171016 21:24:35< sigurdfd> and regular cutscene having a few more
20171016 21:24:45< sigurdfd> yes, esc still works
20171016 21:24:45< zookeeper> anyway, in principle if you use a cutscene theme in dialog-only scenarios, then i suppose it can't go terribly wrong. unless there's a technical problem of some kind :p
20171016 21:25:52< sigurdfd> Almost all the cases automatically advance to the next scenario, so minimal would work well.
20171016 21:26:32< sigurdfd> I could change the few that don't auto-advance (there's at least 2 in NR), mostly by adding linger=no
20171016 21:26:39< vultraz> if it doesn't advance i think that's when you're supposed to use cutscene?
20171016 21:26:51< sigurdfd> yes
20171016 21:31:22< sigurdfd> I think I'll post it as a PR first
20171016 21:34:04< sigurdfd> celmin|snooze: The only use case for non-minimal cutscene I can think of would be for scenarios without combat or need to see unit stats that would take more than one turn.
20171016 22:04:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171016 22:09:38-!- irker218 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171016 22:09:38< irker218> wesnoth: sigurdfdragon wesnoth:master 349459a5f370 / data/campaigns/An_Orcish_Incursion/scenarios/05_Linaera_the_Quick.cfg: AOI S05: Fix facing https://github.com/wesnoth/wesnoth/commit/349459a5f370ae2664c6c414bf97d54e75b7b086
20171016 22:19:00< irker218> wesnoth: Ignacio R. Morelle wesnoth:master a3f3bd934cfb / data/core/about.cfg: Update admin section of the credits https://github.com/wesnoth/wesnoth/commit/a3f3bd934cfbb70826aeebbb79fc429a6f3f0af2
20171016 22:20:37< shadowm> celmin|snooze: Not a fan of the fact that 238d70ee22bcfaaaa22bb31ceebe6d8b478e3a7b wasn't accompanied by a fix for data/tools/about_cfg_to_wiki .
20171016 22:20:50< shadowm> The credits generated by the tool are completely missing the translation credits right now.
20171016 22:23:16< irker218> wesnoth: Ignacio R. Morelle wesnoth:master 4e6cdc60c92d / data/tools/about_cfg_to_wiki: Add localization credits to wiki extraction tool https://github.com/wesnoth/wesnoth/commit/4e6cdc60c92d6d6bc6f190527192d6e796389dd5
20171016 22:30:22-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 252 seconds]
20171016 22:34:46-!- atarocch [~atarocch@93.56.164.28] has quit [Ping timeout: 252 seconds]
20171016 22:36:18-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20171016 22:39:10< irker218> wesnoth: Ignacio R. Morelle wesnoth:master ec49b83bf95d / data/tools/about_cfg_to_wiki: Minor stylistic changes to credit entries https://github.com/wesnoth/wesnoth/commit/ec49b83bf95d53f5f273ebce7f5ea93a30c3f52b
20171016 22:45:43< irker218> wesnoth: Ignacio R. Morelle wesmere:develop a4d292ba5734 / wesmere/sass/mw/_links.scss: sass/mw: Only use file type icons for http/https and ftp links https://github.com/wesnoth/wesmere/commit/a4d292ba57345eced159cf1c401fe2b9a4ce8666
20171016 22:47:14< irker218> wesnoth: Ignacio R. Morelle wesmere:master 98bf612f7fc9 / wesmere/sass/mw/_links.scss: sass/mw: Only use file type icons for http/https and ftp links https://github.com/wesnoth/wesmere/commit/98bf612f7fc947bf82e8eb6dee0fcb612cd022b6
20171016 22:52:46< irker218> wesnoth: Ignacio R. Morelle wesnoth:master 9e9f341dcd4e / data/core/about.cfg: Move i18n managers list below release managers https://github.com/wesnoth/wesnoth/commit/9e9f341dcd4e4af7ab0454f597f67e478bda59a1
20171016 22:55:02< irker218> wesnoth: Ignacio R. Morelle wesnoth:master 394b16697ffc / data/tools/about_cfg_to_wiki: s/Translations/Translators/ seems more appropriate https://github.com/wesnoth/wesnoth/commit/394b16697ffc019b505903006e2c01019cc08fc7
20171016 23:12:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171016 23:12:20-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171016 23:25:28-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20171016 23:34:58-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20171016 23:37:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20171016 23:37:14-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171016 23:43:43< sigurdfd> having thought about it, the main difference between Cutscene & Cutscene_Minimal seems to be how the scenario should feel, which seems important enough.
--- Log closed Tue Oct 17 00:00:37 2017