--- Log opened Fri Oct 27 00:00:20 2017 --- Day changed Fri Oct 27 2017 20171027 00:00:20< vultraz> I mean, I don't mind if you don't and delegate, but just letting them sit if you have no intention to work on them isn't good 20171027 00:01:52< celticminstrel> If I assigned an issue to myself it does signal intent to work on it at some point, though if someone else wanted to take over for one I probably wouldn't mind. 20171027 00:02:05< vultraz> (i just took over one issue) 20171027 00:02:26< celticminstrel> BTW, please assign labels when you see a new issue posted. 20171027 00:02:53< celticminstrel> Or periodically go through these and label them. https://github.com/wesnoth/wesnoth/issues?utf8=%E2%9C%93&q=is%3Aissue%20no%3Alabel%20 20171027 00:03:07< celticminstrel> (Yes there's a point in labelling closed issues.) 20171027 00:04:47-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev 20171027 00:09:15< vultraz> I would appreciate if you'd work on some of the simpler things like https://github.com/wesnoth/wesnoth/issues/1964 20171027 00:24:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20171027 00:24:35-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20171027 00:35:08-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection] 20171027 00:40:41-!- user03 [~user03@ip72-200-48-223.no.no.cox.net] has joined #wesnoth-dev 20171027 00:43:04-!- user03 [~user03@ip72-200-48-223.no.no.cox.net] has quit [Client Quit] 20171027 00:58:22< irker658> wesnoth: Gregory A Lundberg wesnoth:master 2d0b2464d824 / src/editor/palette/unit_palette.cpp: Suppress warning about const variable https://github.com/wesnoth/wesnoth/commit/2d0b2464d8247e58f060a4bae7a390b158c43c26 20171027 01:20:48-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev 20171027 01:21:31-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection] 20171027 01:50:46< irker658> wesnoth: Gregory A Lundberg wesnoth:master 0cb203e9c02d / src/ (gui/dialogs/message.cpp gui/widgets/label.cpp menu_events.cpp): Suppress unchecked return warning https://github.com/wesnoth/wesnoth/commit/0cb203e9c02dc666b067e92bd67264946b814d3e 20171027 01:54:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20171027 02:51:06-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20171027 02:51:12-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20171027 03:24:35-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3555:df8f:725e:454d] has joined #wesnoth-dev 20171027 03:30:28-!- travis-ci [~travis-ci@ec2-54-221-85-41.compute-1.amazonaws.com] has joined #wesnoth-dev 20171027 03:30:29< travis-ci> wesnoth/wesnoth#15383 (master - 0cb203e : Gregory A Lundberg): The build passed. 20171027 03:30:29< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/293457813 20171027 03:30:29-!- travis-ci [~travis-ci@ec2-54-221-85-41.compute-1.amazonaws.com] has left #wesnoth-dev [] 20171027 03:58:23-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3555:df8f:725e:454d] has quit [Remote host closed the connection] 20171027 04:15:06< irker658> wesnoth: galegosimpatico wesnoth:master 48ec4cd6f7f1 / src/gui/widgets/text_box_base.cpp: Reconfigure 'select all' for texts in macOS. https://github.com/wesnoth/wesnoth/commit/48ec4cd6f7f1dad9f131a91328e464952429a603 20171027 04:27:32< irker658> wesnoth: Charles Dang wesnoth:master ea0f4ab6ddb8 / src/gui/widgets/ (addon_list.cpp addon_list.hpp): Addon List: catch user_exit exceptions when performing addon ops https://github.com/wesnoth/wesnoth/commit/ea0f4ab6ddb86c633da1fef541ca5b53ca46a2d1 20171027 04:27:35< irker658> wesnoth: Charles Dang wesnoth:master 5ac959e78322 / src/gui/dialogs/addon/manager.cpp: Addon Manager: don't reload addon list after Update All if nothing changed https://github.com/wesnoth/wesnoth/commit/5ac959e78322868b75633ca9a98af67efd023f46 20171027 04:27:38< irker658> wesnoth: Charles Dang wesnoth:master 78ffabd25495 / src/gui/widgets/addon_list.cpp: Addon List: some minor code cleanup and formatting https://github.com/wesnoth/wesnoth/commit/78ffabd25495113e7b2ccc7368205e22ffc4d5ee 20171027 04:53:32-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.] 20171027 04:57:51-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev 20171027 05:04:18-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev 20171027 05:41:19-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection] 20171027 05:46:23-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .] 20171027 06:29:17-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev 20171027 06:38:52-!- senkwich [~senkwich@cpe-24-28-70-56.austin.res.rr.com] has quit [Ping timeout: 252 seconds] 20171027 06:42:10-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3555:df8f:725e:454d] has joined #wesnoth-dev 20171027 06:48:46-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3555:df8f:725e:454d] has quit [Ping timeout: 252 seconds] 20171027 07:47:28-!- irker658 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20171027 07:57:33-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20171027 08:39:36-!- irker711 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20171027 08:39:36< irker711> wesnoth: galegosimpatico wesnoth:master d98d7aa80c5c / / (5 files in 3 dirs): Fix visual bug in the announces system. https://github.com/wesnoth/wesnoth/commit/d98d7aa80c5c63fce78649ea0ad3271df371c04d 20171027 09:00:50-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20171027 09:01:36-!- Coffee_irc [~david@203.63.75.127] has joined #wesnoth-dev 20171027 09:05:55-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3555:df8f:725e:454d] has joined #wesnoth-dev 20171027 09:10:22-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3555:df8f:725e:454d] has quit [Ping timeout: 258 seconds] 20171027 09:31:23-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .] 20171027 10:40:33-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev 20171027 10:55:01-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:f1b5:aa62:94d6:9f05] has joined #wesnoth-dev 20171027 11:09:35-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20171027 11:21:58-!- shadowm [~ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 264 seconds] 20171027 11:22:07-!- shadowm [~ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev 20171027 11:22:34-!- Elvish_Hunter [~elvish_hu@wesnoth/developer/elvish-hunter] has quit [Ping timeout: 264 seconds] 20171027 11:22:58-!- Elvish_Hunter [~elvish_hu@wesnoth/developer/elvish-hunter] has joined #wesnoth-dev 20171027 11:29:11-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 20171027 11:39:58-!- irker711 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20171027 11:43:07-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev 20171027 11:46:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20171027 11:57:46-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev 20171027 11:58:31-!- senkwich [~senkwich@cpe-24-28-70-56.austin.res.rr.com] has joined #wesnoth-dev 20171027 12:29:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20171027 12:30:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20171027 12:43:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 255 seconds] 20171027 12:44:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20171027 13:07:41-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev 20171027 13:12:15-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Ping timeout: 258 seconds] 20171027 13:19:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20171027 13:44:45-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 20171027 13:48:26-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity] 20171027 13:49:47-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev 20171027 14:03:36-!- DeFender1031 [~DeFender1@46-116-196-40.bb.netvision.net.il] has quit [Quit: I'm not back now.] 20171027 14:12:40-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .] 20171027 14:14:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20171027 15:04:05-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev 20171027 15:28:22-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3555:df8f:725e:454d] has joined #wesnoth-dev 20171027 15:51:18-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3555:df8f:725e:454d] has quit [Remote host closed the connection] 20171027 15:51:43-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3555:df8f:725e:454d] has joined #wesnoth-dev 20171027 15:59:33-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3555:df8f:725e:454d] has quit [Remote host closed the connection] 20171027 16:00:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20171027 16:14:37-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3555:df8f:725e:454d] has joined #wesnoth-dev 20171027 16:15:33-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3555:df8f:725e:454d] has quit [Remote host closed the connection] 20171027 16:16:05-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3555:df8f:725e:454d] has joined #wesnoth-dev 20171027 16:23:38-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection] 20171027 16:41:53-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev 20171027 16:48:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20171027 16:51:35-!- JyrkiVesterinen [~jyrki@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev 20171027 17:16:42-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3555:df8f:725e:454d] has quit [Remote host closed the connection] 20171027 17:17:19-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3555:df8f:725e:454d] has joined #wesnoth-dev 20171027 17:17:24-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3555:df8f:725e:454d] has quit [Remote host closed the connection] 20171027 17:17:39-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3555:df8f:725e:454d] has joined #wesnoth-dev 20171027 17:17:40-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3555:df8f:725e:454d] has quit [Remote host closed the connection] 20171027 17:33:32-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3555:df8f:725e:454d] has joined #wesnoth-dev 20171027 17:43:46-!- irker123 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20171027 17:43:46< irker123> wesnoth: pentarctagon wesnoth:master 757762b1e684 / CMakeLists.txt SConstruct: Add support for PGO builds. https://github.com/wesnoth/wesnoth/commit/757762b1e684c510fd2ba1af516b2865c1f4cc53 20171027 17:43:46< irker123> wesnoth: pentarctagon wesnoth:master e594815cfb37 / .gitignore: Add pgo_data to .gitignore. https://github.com/wesnoth/wesnoth/commit/e594815cfb37154efe2c32b13bbf3c246d8e526f 20171027 17:45:24-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3555:df8f:725e:454d] has quit [Remote host closed the connection] 20171027 17:53:53-!- gfgtdf [~chatzilla@x4e3631bf.dyn.telefonica.de] has joined #wesnoth-dev 20171027 17:53:59< gfgtdf> shadowm: yes i ment sp 20171027 17:54:55-!- gfgtdf [~chatzilla@x4e3631bf.dyn.telefonica.de] has quit [Client Quit] 20171027 17:58:43-!- gfgtdf [~chatzilla@x4e3631bf.dyn.telefonica.de] has joined #wesnoth-dev 20171027 18:00:06< gfgtdf> tad, vultraz: f7bea59fe9bb1 is likeley to casue OOS. since *randomness::generator is the synced rng, for unsynced stuff, liek selecting musuc tracks, use randomness::rng::default_instance instead 20171027 18:02:03< JyrkiVesterinen> What? 20171027 18:02:14< JyrkiVesterinen> I definitely didn't expect the default RNG to be synced. 20171027 18:02:50< JyrkiVesterinen> Would it be possible to make randomness::generator an unsynced RNG instead? The way it is, it's very likely to confuse developers. 20171027 18:04:14< gfgtdf> JyrkiVesterinen: well randomness::generator as made exactly to havea synced rng, and the comment above also explcitily synced it's synced (in fact it's not always synced it tried to be samert and detect wheter a synced rng shodul be used or not, but it was not designed for things like selecting music tracks) 20171027 18:04:34< gfgtdf> s/as/was 20171027 18:14:00< vultraz> damn OOS >_< 20171027 18:29:28< irker123> wesnoth: Jyrki Vesterinen wesnoth:master 0c137c79cffa / / (6 files in 5 dirs): Globally suppress -Wmaybe-uninitialized https://github.com/wesnoth/wesnoth/commit/0c137c79cffa4476529a3b38324822f43f26b327 20171027 18:33:18< gfgtdf> vultraz: even if it doesnt casu OOS it will make some actions things nonundoable that previosuly could be undone. 20171027 18:33:23< gfgtdf> cause* 20171027 18:37:59< vultraz> I swear, our damn system is so fragile it’s ridiculous 20171027 18:40:54< irker123> wesnoth: Jyrki Vesterinen wesnoth:master 2452007c1504 / src/attack_prediction.cpp: Use unsynced RNG for Monte Carlo combat simulation https://github.com/wesnoth/wesnoth/commit/2452007c1504f95952aabd02dac6e2e2d1861e0e 20171027 18:42:05< gfgtdf> JyrkiVesterinen: i dont' think the old code prediction code woudl casue OOS, randomness::generator uses an unsycned rng if it called by ai code. Still there migth be corner cases though. 20171027 18:44:43-!- JyrkiVesterinen [~jyrki@85-23-197-3.bb.dnainternet.fi] has quit [Quit: Rebooting] 20171027 18:44:49< gfgtdf> JyrkiVesterinen: in fact i think this oynl changes how it behaved if wesnoth.simulate_combat was called from non-ai code and it using the synced rng there migth even be better (not sure exactly) 20171027 18:46:29-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev 20171027 18:46:44< gfgtdf> JyrkiVesterinen: you saw my last post ? 20171027 18:47:08< JyrkiVesterinen> That combat simulation was already unlikely to cause OOS? 20171027 18:47:43-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20171027 18:47:50< gfgtdf> JyrkiVesterinen: in fact i think this oynl changes how it behaved if wesnoth.simulate_combat was called from non-ai code and it using the synced rng there migth even be better (not sure exactly) 20171027 18:48:42< JyrkiVesterinen> Well, it can be called from non-AI code to determine the best weapon to attack with, or to view the predicted result when a human player attacks. 20171027 19:01:57-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev 20171027 19:07:13-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3555:df8f:725e:454d] has joined #wesnoth-dev 20171027 19:23:02< vultraz> gfgtdf: should i revert that change to [options] format in savefiles? 20171027 19:24:18< gfgtdf> i don't remember it exactly what it was but it it breaks variables in containers i'd say yes. 20171027 19:26:19-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:f1b5:aa62:94d6:9f05] has quit [Quit: Leaving] 20171027 19:26:35< vultraz> well i don't know since i didn't test that 20171027 19:42:45< AI0867> 23:38 < vultraz> AI0867: manage the coverity build, do you? ← yes 20171027 19:43:07< vultraz> Access, may I have? 20171027 19:46:23-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .] 20171027 20:11:43-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3555:df8f:725e:454d] has quit [Remote host closed the connection] 20171027 20:12:15-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3555:df8f:725e:454d] has joined #wesnoth-dev 20171027 20:12:54< AI0867> vultraz: you already do 20171027 20:13:16< AI0867> as of 2 days ago 20171027 20:16:59-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3555:df8f:725e:454d] has quit [Ping timeout: 258 seconds] 20171027 20:48:29-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3555:df8f:725e:454d] has joined #wesnoth-dev 20171027 21:35:27-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3555:df8f:725e:454d] has quit [Remote host closed the connection] 20171027 21:37:58< vultraz> AI0867: oh, thanks :D 20171027 21:41:34-!- irker123 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20171027 21:45:34-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection] 20171027 21:48:56-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3555:df8f:725e:454d] has joined #wesnoth-dev 20171027 21:52:25-!- irker952 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20171027 21:52:25< irker952> wesnoth: sigurdfdragon wesnoth:master ca853a060765 / data/campaigns/ (24 files in 9 dirs): Campaigns: Deploy Cutscene_Minimal theme for dialog only scenarios https://github.com/wesnoth/wesnoth/commit/ca853a06076582a8108b0752cfb22327ddc8362d 20171027 22:13:35-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3555:df8f:725e:454d] has quit [Remote host closed the connection] 20171027 22:15:21-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3555:df8f:725e:454d] has joined #wesnoth-dev 20171027 22:27:02-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3555:df8f:725e:454d] has quit [Remote host closed the connection] 20171027 22:34:08-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds] 20171027 22:53:21-!- gfgtdf [~chatzilla@x4e3631bf.dyn.telefonica.de] has quit [Read error: Connection reset by peer] 20171027 22:59:33-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20171027 23:11:53-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 246 seconds] 20171027 23:18:36-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev 20171027 23:59:46-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3555:df8f:725e:454d] has joined #wesnoth-dev --- Log closed Sat Oct 28 00:00:28 2017