--- Log opened Mon Oct 02 00:00:18 2017 20171002 00:20:24-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth 20171002 02:11:31-!- ArneBab [~quassel@freenet/developer/arnebab] has joined #wesnoth 20171002 02:15:29-!- ArneBab_ [~quassel@freenet/developer/arnebab] has quit [Ping timeout: 248 seconds] 20171002 02:26:30-!- Narrat [~Narrat@p2E5112AC.dip0.t-ipconnect.de] has quit [Quit: They say a little knowledge is a dangerous thing, but it's not one half so bad as a lot of ignorance.] 20171002 02:34:59-!- sigurdfd [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth 20171002 03:15:34< wesnoth-discord-> @Pentarctagon I added an upload-time check for validity of an addon's icon path back in 1.13.2 or something 20171002 03:15:59< wesnoth-discord-> whether it actually works well - ie, whether image::exists is a strict enough check - remains to be seen 20171002 03:16:02< wesnoth-discord-> but it's there 20171002 03:16:11< wesnoth-discord-> and an addon cannot be uploaded if it doesn't pass that check 20171002 03:16:28< Necrosporus> There are image path functions 20171002 03:16:48< wesnoth-discord-> hmmm 20171002 03:16:51< wesnoth-discord-> yes, true 20171002 03:16:56< celticminstrel> Does image::exists also test for image arguments to IPFs? 20171002 03:16:56< wesnoth-discord-> I hadn't really considered those 20171002 03:16:56< Necrosporus> Are they allowed in addon icon? If they are, then their erroneous application still causes errors 20171002 03:17:07< wesnoth-discord-> I suppose I could write a complex validity check 20171002 03:17:20< celticminstrel> I'd actually expect image::exists to ignore anything after the ~ 20171002 03:18:05< Necrosporus> A complex check could be simple, actually try to execute image path function and see if it works 20171002 03:18:48< wesnoth-discord-> partly 20171002 03:18:54< Necrosporus> Though, maybe ~BLIT should be symmetric? 20171002 03:19:30< Necrosporus> Like image1~BLIT(image2) == image2~BLIT(image1)... wait, nevermind 20171002 03:19:35< wesnoth-discord-> @Vultraz image::exists wouldn't be enough, would it? It exists on the machine of the person uploading, but the point is that it wouldn't exist on most other people's. 20171002 03:19:53< celticminstrel> Ah, good point. 20171002 03:20:57< Necrosporus> Should bar.png~BLIT(foo.png) automatically crop foo.png to match bar dimensions? 20171002 03:21:12< wesnoth-discord-> no 20171002 03:21:17< Necrosporus> or expand bar.png to match foo.png? 20171002 03:21:32< Necrosporus> well, whoever blits can use CROP probably 20171002 03:21:37< wesnoth-discord-> yes 20171002 03:22:05< Necrosporus> Does your check only apply to core? 20171002 03:22:26< Necrosporus> Or at least data 20171002 03:22:43< Necrosporus> Whenever image exist in data/, so if it exists, but in addon check should fail 20171002 03:27:06< wesnoth-discord-> i don't know 20171002 03:27:09< wesnoth-discord-> i never considered 20171002 03:28:37< Necrosporus> 1.12 server has many missing icons, 1.13 seems to have very few at the moment, perhaps even none 20171002 03:30:18< wesnoth-discord-> it has a few 20171002 03:30:32< wesnoth-discord-> it doesn't get reported in the error log until you actually scroll down over it 20171002 03:30:41< wesnoth-discord-> Water Era, for example 20171002 03:31:05< wesnoth-discord-> water era was the reason i added the check 20171002 03:31:24< wesnoth-discord-> 😛 20171002 03:31:56< Necrosporus> Problem is that BLIT erorrs do not say in what addon icon they occur 20171002 03:32:37< Necrosporus> If image is missing completely, then error message says what addon it is 20171002 03:33:06< Necrosporus> if image is present but image path functions are erroneous you just get complains about them without indication which addon caused it 20171002 03:33:15< wesnoth-discord-> yeah, I'll work on something 20171002 03:33:17< wesnoth-discord-> just not right now 20171002 03:35:32< wesnoth-discord-> because im busy as all hell 20171002 04:05:38-!- Blukunfando [~bkf@59.red-80-58-131.staticip.rima-tde.net] has quit [Read error: Connection reset by peer] 20171002 04:22:20-!- sigurdfd [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has quit [] 20171002 04:22:55-!- cyphase [~cyphase@unaffiliated/cyphase] has quit [Ping timeout: 248 seconds] 20171002 04:37:29-!- cyphase [~cyphase@unaffiliated/cyphase] has joined #wesnoth 20171002 04:54:02-!- cyphase [~cyphase@unaffiliated/cyphase] has quit [Ping timeout: 260 seconds] 20171002 05:06:02-!- cyphase [~cyphase@unaffiliated/cyphase] has joined #wesnoth 20171002 05:06:40-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has joined #wesnoth 20171002 05:41:24-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth 20171002 05:50:20-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20171002 06:45:56-!- Haudegen [~quassel@178.115.237.87] has joined #wesnoth 20171002 08:59:13-!- Kwandulin [~Kwandulin@pD9FD50F1.dip0.t-ipconnect.de] has quit [Quit: [endlevel]] 20171002 09:05:12-!- vladimirslavik [vslavik@nat/redhat/x-dzyiyartjbdstbkl] has joined #wesnoth 20171002 11:58:53-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity] 20171002 12:36:38-!- Haudegen [~quassel@178.115.237.87] has quit [Read error: Connection reset by peer] 20171002 12:59:16-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20171002 13:51:43-!- Haudegen [~quassel@212-186-77-29.static.upcbusiness.at] has joined #wesnoth 20171002 14:11:48-!- Haudegen [~quassel@212-186-77-29.static.upcbusiness.at] has quit [Ping timeout: 246 seconds] 20171002 14:14:04-!- Haudegen [~quassel@212-186-77-29.static.upcbusiness.at] has joined #wesnoth 20171002 15:00:07-!- sevu [~Shiki@p54854DEF.dip0.t-ipconnect.de] has joined #wesnoth 20171002 15:17:52-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth 20171002 15:47:01-!- Haudegen [~quassel@212-186-77-29.static.upcbusiness.at] has quit [Remote host closed the connection] 20171002 16:00:47-!- Kranix [~magnus@xd520f683.cust.hiper.dk] has joined #wesnoth 20171002 16:01:01-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth 20171002 16:37:29-!- sevu [~Shiki@p54854DEF.dip0.t-ipconnect.de] has quit [Quit: Verlassend] 20171002 17:09:48-!- octalot [~steve@178.165.129.172.wireless.dyn.drei.com] has joined #wesnoth 20171002 17:34:14-!- sevu [~Shiki@p54854DEF.dip0.t-ipconnect.de] has joined #wesnoth 20171002 17:43:14-!- sevu [~Shiki@p54854DEF.dip0.t-ipconnect.de] has quit [Quit: Verlassend] 20171002 18:10:18-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20171002 18:19:08-!- vladimirslavik [vslavik@nat/redhat/x-dzyiyartjbdstbkl] has quit [Quit: Leaving] 20171002 18:44:35-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20171002 18:44:41-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth 20171002 19:49:53-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20171002 19:50:00-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth 20171002 20:03:23-!- sigurdfd [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth 20171002 20:04:09-!- claymore [~claymore@unaffiliated/claymore] has joined #wesnoth 20171002 20:04:43-!- Guest9528 [~quassel@178.115.237.87] has joined #wesnoth 20171002 20:05:29-!- TheJJ [~rofl@ipbcc36896.dynamic.kabel-deutschland.de] has quit [Remote host closed the connection] 20171002 20:20:32-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth 20171002 20:29:04-!- Guest9528 [~quassel@178.115.237.87] has quit [Remote host closed the connection] 20171002 20:31:12-!- TheJJ [~rofl@ipbcc36896.dynamic.kabel-deutschland.de] has joined #wesnoth 20171002 20:31:16-!- sevu [~Shiki@p54854DEF.dip0.t-ipconnect.de] has joined #wesnoth 20171002 20:35:35-!- TheJJ [~rofl@ipbcc36896.dynamic.kabel-deutschland.de] has quit [Ping timeout: 240 seconds] 20171002 20:38:38-!- TheRuralJuror [~quassel@178.115.237.87] has joined #wesnoth 20171002 20:43:41-!- claymore [~claymore@unaffiliated/claymore] has quit [Quit: Leaving] 20171002 20:45:11-!- TheJJ [~rofl@ipbcc36896.dynamic.kabel-deutschland.de] has joined #wesnoth 20171002 21:48:45-!- Kranix [~magnus@xd520f683.cust.hiper.dk] has quit [Quit: Konversation terminated!] 20171002 21:52:33-!- cyphase [~cyphase@unaffiliated/cyphase] has quit [Ping timeout: 248 seconds] 20171002 21:58:07-!- cyphase [~cyphase@unaffiliated/cyphase] has joined #wesnoth 20171002 22:01:08-!- APic [apic@apic.name] has quit [Quit: Scheduled Downtime. See You later, Gals and/or Pals. ☺] 20171002 22:08:06-!- cyphase [~cyphase@unaffiliated/cyphase] has quit [Ping timeout: 240 seconds] 20171002 22:13:33-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20171002 22:15:33-!- cyphase [~cyphase@unaffiliated/cyphase] has joined #wesnoth 20171002 22:33:31-!- TheRuralJuror [~quassel@178.115.237.87] has quit [Remote host closed the connection] 20171002 22:33:58-!- Haudegen [~quassel@178.115.237.87] has joined #wesnoth 20171002 22:34:06-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds] 20171002 22:43:45-!- Haudegen [~quassel@178.115.237.87] has quit [Ping timeout: 248 seconds] 20171002 22:44:21-!- cyphase [~cyphase@unaffiliated/cyphase] has quit [Ping timeout: 240 seconds] 20171002 22:52:10-!- cyphase [~cyphase@unaffiliated/cyphase] has joined #wesnoth 20171002 22:55:55-!- ACTPic [apic@apic.name] has joined #wesnoth 20171002 23:02:57-!- ACTPic [apic@apic.name] has quit [Quit: leaving] 20171002 23:08:56-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth 20171002 23:38:06-!- cyphase [~cyphase@unaffiliated/cyphase] has quit [Ping timeout: 240 seconds] --- Log closed Tue Oct 03 00:00:19 2017