--- Log opened Sun Nov 05 00:00:05 2017
20171105 00:09:58-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 264 seconds]
20171105 00:15:29-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Ping timeout: 248 seconds]
20171105 00:16:02-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20171105 00:27:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds]
20171105 00:27:51-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171105 00:28:10-!- stikonas_ is now known as stikonas
20171105 01:20:13-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20171105 02:02:12-!- gfgtdf_ [~chatzilla@x4e3693d3.dyn.telefonica.de] has joined #wesnoth-dev
20171105 02:04:17-!- gfgtdf [~chatzilla@x4e363411.dyn.telefonica.de] has quit [Ping timeout: 248 seconds]
20171105 02:04:22-!- gfgtdf_ is now known as gfgtdf
20171105 02:18:01-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Ping timeout: 240 seconds]
20171105 02:19:05-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20171105 02:26:11-!- gfgtdf [~chatzilla@x4e3693d3.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 56.0.2/20171024165158]]
20171105 02:26:25-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171105 02:26:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 255 seconds]
20171105 02:46:26-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20171105 02:46:44-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171105 03:21:26-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20171105 04:02:53-!- fabi [~fabi@2a02:810c:c840:2e65:1157:3c8c:fe50:712d] has joined #wesnoth-dev
20171105 04:02:53-!- fabi [~fabi@2a02:810c:c840:2e65:1157:3c8c:fe50:712d] has quit [Changing host]
20171105 04:02:53-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20171105 04:03:48-!- irker148 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171105 04:03:48< irker148> wesnoth: Ignacio R. Morelle wesmere:master e8813c778f44 / wesmere/sass/mw/_links.scss: sass/mw: Force not displaying icons for w.o links https://github.com/wesnoth/wesmere/commit/e8813c778f4416dfc9ab8e79eeaf978e871f1db1
20171105 04:30:15-!- celmin [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20171105 04:30:15-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Disconnected by services]
20171105 04:30:15-!- celmin is now known as celticminstrel
20171105 04:35:27-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Ping timeout: 240 seconds]
20171105 04:36:44-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20171105 05:24:35-!- celticminstrel is now known as celmin|sleep
20171105 05:29:37-!- APic [apic@apic.name] has quit [Ping timeout: 248 seconds]
20171105 05:44:16-!- APic [apic@apic.name] has joined #wesnoth-dev
20171105 06:15:09-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20171105 06:44:12< irker148> wesnoth: Charles Dang wesnoth:master 21545b5a2e20 / src/gui/widgets/ (chatbox.cpp chatbox.hpp): GUI2/Chatbox: code cleanup/minor refactoring https://github.com/wesnoth/wesnoth/commit/21545b5a2e20305b6c3da52cb997f57797d29550
20171105 07:23:13-!- Bonobo [~Bonobo@14-203-49-124.tpgi.com.au] has joined #wesnoth-dev
20171105 07:29:38-!- travis-ci [~travis-ci@ec2-54-157-32-40.compute-1.amazonaws.com] has joined #wesnoth-dev
20171105 07:29:39< travis-ci> wesnoth/wesnoth#15495 (master - 21545b5 : Charles Dang): The build was broken.
20171105 07:29:39< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/297458907
20171105 07:29:39-!- travis-ci [~travis-ci@ec2-54-157-32-40.compute-1.amazonaws.com] has left #wesnoth-dev []
20171105 07:35:08-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171105 07:35:17-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171105 07:36:09< irker148> wesnoth: Charles Dang wesnoth:master 744608882b19 / src/gui/widgets/chatbox.hpp: Fixup 21545b5 for GCC https://github.com/wesnoth/wesnoth/commit/744608882b19ed32b255304792095e3d5e710413
20171105 07:49:57-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20171105 08:11:01-!- Bonobo [~Bonobo@14-203-49-124.tpgi.com.au] has quit [Ping timeout: 240 seconds]
20171105 08:12:07-!- Bonobo [~Bonobo@14-203-49-124.tpgi.com.au] has joined #wesnoth-dev
20171105 09:16:21-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20171105 09:58:06-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20171105 11:03:52-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20171105 11:23:42< irker148> wesnoth: Charles Dang wesnoth:master 961c8c05d3bd / data/gui/window/lobby_main.cfg: MP Lobby: cleaned up WML layout https://github.com/wesnoth/wesnoth/commit/961c8c05d3bd6704293f359cef201b6bc6069916
20171105 11:23:43-!- Bonobo [~Bonobo@14-203-49-124.tpgi.com.au] has quit [Ping timeout: 248 seconds]
20171105 12:05:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171105 12:29:44-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20171105 12:42:33< vn971> Writing addons is hard. At least not as easy as hoped it would. I've spent about a day (cumulative) writing random unit generation. // It accumulates all units reachable from current era recruitables, then tries to find someone close by cost (a bit randomized).
20171105 12:43:28< irker148> wesnoth: Alexander van Gessel wesnoth:master cdec9b2a7a0e / src/editor/ (4 files in 2 dirs): Remove an unnecessary layer of indirection https://github.com/wesnoth/wesnoth/commit/cdec9b2a7a0ea4d46231b92141ef75568411ab58
20171105 12:43:30< irker148> wesnoth: Alexander van Gessel wesnoth:master 8b1902e8642e / src/editor/toolkit/editor_toolkit.cpp: Switch to default destructor, removing very old TODO https://github.com/wesnoth/wesnoth/commit/8b1902e8642e046840128979eff453e576388fde
20171105 12:43:31< vn971> though honestly, big part of the time is learning Lua. Once you get more familiar, it becomes more easy. Also, familarity with wesnoth Lua interface helps once you get it.
20171105 12:43:32< irker148> wesnoth: Alexander van Gessel wesnoth:master 2fec0073825e / src/game_events/action_wml.cpp: Add warning about additional characters being ignored https://github.com/wesnoth/wesnoth/commit/2fec0073825eb827a09a3c6c6d18979182de07d0
20171105 12:43:34< irker148> wesnoth: Alexander van Gessel wesnoth:master c705047bfac8 / / (8 files in 6 dirs): Merge branch 'master' of github.com:wesnoth/wesnoth https://github.com/wesnoth/wesnoth/commit/c705047bfac848081dd185cdd706aa2262f35cc6
20171105 12:46:19< Ravana_> I did my version of that by generating all suitable units, and then hardcoding them for each release
20171105 12:54:19< vn971> :D
20171105 12:54:51< vn971> well, honestly, I've done it too because wesnoth-1.12 does not give you access to all Era data.
20171105 12:56:02< vn971> But for wesnoth-1.13, I've managed to access the Era faction fields, and accumulate everything programmatically. This has the benefit that it'll work on all eras. So it'll behave differently if you start the game with "Default" or "Default + Khalifate".
20171105 12:56:13< vn971> It would be _a lot_ faster to inline everything...
20171105 13:03:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20171105 13:04:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171105 13:06:23< vultraz> AI0867: could you handle this? https://github.com/wesnoth/wesnoth/issues/2171
20171105 13:14:47< AI0867> vultraz: I have no idea what's going on there, beyond that it has something to do with lua
20171105 13:15:03< vultraz> damn
20171105 13:15:06< vultraz> alright, thanks for looking
20171105 13:20:23< Ravana_> vn971: btw, I decided I am not going back to windows on that computer, so I just moved pbl file and uploaded your xp mod changes to 1.13
20171105 13:22:37< vn971> Ravana_: but they were already uploaded, weren't they?
20171105 13:22:50< Ravana_> they werent
20171105 13:23:08< vn971> Ravana_: ah, my mistake then. Cool.:)
20171105 13:23:45< irker148> wesnoth: Charles Dang wesnoth:master 3b9e73f7d2f4 / changelog src/game_initialization/create_engine.cpp: Create Engine: exclude campaigns from the has-sides check https://github.com/wesnoth/wesnoth/commit/3b9e73f7d2f47a2d3a1599f147b7f098b3bd85a7
20171105 13:35:21< irker148> wesnoth: Charles Dang wesnoth:master 2277926c0673 / src/game_config_manager.cpp: Game Config Manager: utilize unique_ptrs over shared_ptrs https://github.com/wesnoth/wesnoth/commit/2277926c0673e12f28d54c90f7e7321e93a456a5
20171105 13:56:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20171105 13:56:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171105 14:13:19-!- vn971 [~vasya@94.158.103.15] has quit [Quit: Leaving.]
20171105 14:45:19< irker148> wesnoth: Alexander van Gessel wesnoth:blur-refactor 23c888620e7a / src/sdl/utils.cpp: Replace hand-written circular buffer with the boost one https://github.com/wesnoth/wesnoth/commit/23c888620e7a775f1e2db21dd4fe43e7c56ee7cf
20171105 14:45:21< irker148> wesnoth: Alexander van Gessel wesnoth:blur-refactor 23af2a3273ca / data/scenario-test.cfg: Add larger blur testcase https://github.com/wesnoth/wesnoth/commit/23af2a3273ca93309f5f587cd7d54815ce14fe68
20171105 14:45:23< irker148> wesnoth: Alexander van Gessel wesnoth:blur-refactor 0df5fe8705fe / src/sdl/utils.cpp: Properly size circular buffer https://github.com/wesnoth/wesnoth/commit/0df5fe8705fe1270616ca4dfd1456e1e45f3ed61
20171105 14:45:25< irker148> wesnoth: Alexander van Gessel wesnoth:blur-refactor 7894b6044ca3 / src/sdl/utils.cpp: Get rid of avg, which is now redundant https://github.com/wesnoth/wesnoth/commit/7894b6044ca390280cf77b504369a759d4e27c63
20171105 14:45:27< irker148> wesnoth: Alexander van Gessel wesnoth:blur-refactor d08b94faf1f5 / src/sdl/utils.cpp: Add comments explaining how the blurring works https://github.com/wesnoth/wesnoth/commit/d08b94faf1f5da718fb855e4827adc0cec71bf37
20171105 14:45:46< celmin|sleep> ...why the heck is it even looking for that file?
20171105 14:45:53< celmin|sleep> (re: 2171)
20171105 14:46:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20171105 14:46:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171105 14:49:45-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20171105 14:51:13-!- celmin|sleep is now known as celticminstrel
20171105 14:59:57< irker148> wesnoth: Alexander van Gessel wesnoth:blur-refactor e5c14866bf1f / src/sdl/utils.hpp: Improve doxygen comments https://github.com/wesnoth/wesnoth/commit/e5c14866bf1f64ab45259691f7615966a9db1c35
20171105 15:01:05< AI0867> celticminstrel: that's gdb looking for the file to provide the relevant source
20171105 15:01:13< AI0867> it's not what's causing the crash
20171105 15:02:52-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev
20171105 15:03:54< celticminstrel> Ah.
20171105 15:04:03< celticminstrel> Okay then.
20171105 15:10:40< vn971> hmm, I don't get something. In OS Lua console, this code works fine: `a = a or {}`.  In wesnoth lua console, it doesn't, somewhy.
20171105 15:10:58< vn971> And I even have a feeling it worked previously (though I may be wrong).
20171105 15:11:03< celticminstrel> Probably because of ilua.
20171105 15:11:10< vn971> ilua?
20171105 15:11:15< celticminstrel> Yeah.
20171105 15:11:22< vn971> ok, I'll google for it.
20171105 15:11:34< celticminstrel> Searching Wesnoth source repo would work too.
20171105 15:11:58< celticminstrel> The gist of it is that Wesnoth installs a metatable on _G which raises an error if you access a variable that hadn't previously been assigned.
20171105 15:12:09< zookeeper> AI0867, i take it that your blur refactor doesn't actually change the pixel-level blur behavior at all?
20171105 15:13:02< vn971> hm, I see this repo: https://github.com/ilua/ilua    (with last commit in 2010). Probably that's it.
20171105 15:13:29< celticminstrel> Yeah.
20171105 15:13:38< celticminstrel> ilua.lua, that is.
20171105 15:13:49< celticminstrel> Oh, right, that's the actual repo/
20171105 15:14:02< celticminstrel> Wesnoth might've customized it a little though.
20171105 15:14:16 * celticminstrel for some reason thought you have posted the link to Wesnoth's copy.
20171105 15:14:23< AI0867> zookeeper: it shouldn't. I did serious testing and had far more asserts in that code during development, and the basic algorithm remains the same
20171105 15:14:46< vn971> well, OK. I wonder whether such impact is good though. I mean, `v = v or {}` feels pretty much standard.
20171105 15:15:41< zookeeper> AI0867, okay. since you're now familiar with the code, you wouldn't just happen to easily be able to make it work so that the rgb contribution of a source pixel depends on its alpha? :p (as in, rgb of fully transparent pixels wouldn't bleed into the end result)
20171105 15:16:08< celticminstrel> Well, if you really need that behaviour, you can use the rawget function, but I think you could also probably refactor it to not access the variable before it's assigned.
20171105 15:16:48< celticminstrel> And that idiom will still work on non-global variables, such as function parameters.
20171105 15:16:58< celticminstrel> (AFAIK function parameters are a significant use of it.)
20171105 15:17:02< vn971> Yup, I checked just now. In wesnoth-1.12, you can write `a = a or {}` and it'll work.
20171105 15:17:14< celticminstrel> Right, because ilua was introduced in 1.13.
20171105 15:17:32< celticminstrel> IIRC it's also possible to globally disable ilua. Personally I wouldn't recommend it though.
20171105 15:17:42< vn971> In wesnoth-1.13, you get an error.
20171105 15:17:42< celticminstrel> I think "ilua._strict = false" should do it.
20171105 15:18:05< celticminstrel> Or if not that. something very similar.
20171105 15:19:13< vn971> celticminstrel: should ilua be used when you run something NOT interactive?
20171105 15:19:23< vn971> celticminstrel: like an addon?
20171105 15:19:25< celticminstrel> Yes?
20171105 15:19:43< celticminstrel> Pretty sure the point was to make it easier to catch a certain class of logic errors.
20171105 15:19:56< vn971> celticminstrel: well why? It breaks compatibility with lua, and "ilua" stands for "interactive lua".
20171105 15:20:49-!- Bonobo [~Bonobo@14-203-49-124.tpgi.com.au] has joined #wesnoth-dev
20171105 15:21:20< vn971> celticminstrel: anyway, I just don't understand how should I initialize something if it wasn't already. I guess the answer is "don't do that at all, and use `require` instead", right?
20171105 15:21:30< celticminstrel> ...
20171105 15:21:42< celticminstrel> You don't understand how to initialize something?
20171105 15:21:58< vn971> y
20171105 15:22:02< celticminstrel> a = 6
20171105 15:22:19< celticminstrel> x = {}
20171105 15:22:20< vn971> I have >= lua file, and I want to keep addon-specific functions in a separate namespace.
20171105 15:22:43< celticminstrel> >=?
20171105 15:22:45< vn971> Therefore I use   myAddonName = {}  -- global
20171105 15:22:45< vn971> myAddonName.myFunctionFromFile1 = ...
20171105 15:23:02< vn971> sorry, >= 1. More than one lua file.
20171105 15:23:30< vn971> now if two files use the same code I posted above, you'll get wrong stuff.
20171105 15:23:40< celticminstrel> Okay, so probably what you need is rawget.
20171105 15:23:45< vn971> myAddonName = {}; myAddonName.something = ...     I mean.
20171105 15:23:52< celticminstrel> And then just use the same idiom, just with the addition of rawget.
20171105 15:25:38< vn971> celticminstrel: I don't see how to solve the problem with rawget. I want to initialize a variable, not a field.
20171105 15:25:51< celticminstrel> v = v or {}
20171105 15:25:52< celticminstrel> becomes
20171105 15:25:59< celticminstrel> v = rawget(_G, v) or {}
20171105 15:26:00< celticminstrel> I think.
20171105 15:26:24< AI0867> zookeeper: hmm, I'd have to pre-multiply everything by alpha, and then divide the result by alpha afterwards
20171105 15:26:24< celticminstrel> ...I wonder if you can write _G._G._G._G._G ad infinitum, or is _G a magic name...
20171105 15:26:57< celticminstrel> Whoa, it really works.
20171105 15:26:58< AI0867> not sure if that would give quite the desired result though
20171105 15:27:35< celticminstrel> Global variables are essentially fields in _G.
20171105 15:27:44< celticminstrel> I guess _G is also a field in _G, heh.
20171105 15:28:01< vn971> _G.test123 = rawget(_G, test123) or {}   ---->  variable test123 must be assigned before being used
20171105 15:28:13< zookeeper> AI0867, just asking, since that's always been a problem with the blur implementation.
20171105 15:28:30< celticminstrel> Oh sorry, quote the second instance of the variable name.
20171105 15:28:33< AI0867> struct A;struct A{A* a; A(){a = this;}}; A b; b.a->a->a->a->a....
20171105 15:29:27< AI0867> zookeeper: I can try, but I'll do so on a new branch
20171105 15:30:31< vn971> celticminstrel: I think it works now. Thanks!  Should I write this in plugins, too?
20171105 15:30:40< celticminstrel> Plugins?
20171105 15:31:02< vn971> celticminstrel: won't I be in trouble if the magical _G name changes, or smth like that?
20171105 15:31:07< vn971> Sorry, addons
20171105 15:31:28< celticminstrel> The magical _G name shouldn't change. If it does, someone is doing something bad.
20171105 15:31:36< vn971> also, I don't see _G being documented anywhere. Maybe it is, but I didn't see that.
20171105 15:31:43< zookeeper> AI0867, awesome!
20171105 15:32:51< celticminstrel> Found it here: https://www.lua.org/manual/5.3/manual.html#2.2
20171105 15:33:16< celticminstrel> It's possible for it to be assigned to, but this is bad behaviour.
20171105 15:33:45< celticminstrel> I wonder if there's a way to prevent that...
20171105 15:34:13< celticminstrel> C++ code can easily fetch _G and compare it to the real globals table to see if they differ.
20171105 15:41:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20171105 15:42:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171105 15:47:24< vn971> celticminstrel: since it's a Lua mainline feature, I think it's safe to use it. Thanks for the reference.
20171105 15:47:51-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20171105 15:49:05< celticminstrel> Yeah, it should be safe, but what I was trying to get across is that a badly-behaved add-on could assign to _G and break things.
20171105 15:49:12< celticminstrel> Like _G = {}
20171105 15:55:56< JyrkiVesterinen> One way to prevent it would be to run each addon in a different environment.
20171105 15:56:17< JyrkiVesterinen> That way, each addon would be able to override _G, but other addons wouldn't even see the change.
20171105 15:57:27-!- travis-ci [~travis-ci@ec2-54-196-12-218.compute-1.amazonaws.com] has joined #wesnoth-dev
20171105 15:57:28< travis-ci> wesnoth/wesnoth#15500 (blur-refactor - d08b94f : Alexander van Gessel): The build passed.
20171105 15:57:28< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/297569376
20171105 15:57:28-!- travis-ci [~travis-ci@ec2-54-196-12-218.compute-1.amazonaws.com] has left #wesnoth-dev []
20171105 16:21:51-!- Bonobo [~Bonobo@14-203-49-124.tpgi.com.au] has quit [Ping timeout: 248 seconds]
20171105 16:28:39-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171105 16:28:46-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171105 16:33:02-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171105 16:36:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 255 seconds]
20171105 16:42:30-!- travis-ci [~travis-ci@ec2-54-196-12-218.compute-1.amazonaws.com] has joined #wesnoth-dev
20171105 16:42:31< travis-ci> wesnoth/wesnoth#15501 (blur-refactor - e5c1486 : Alexander van Gessel): The build passed.
20171105 16:42:31< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/297573952
20171105 16:42:31-!- travis-ci [~travis-ci@ec2-54-196-12-218.compute-1.amazonaws.com] has left #wesnoth-dev []
20171105 16:44:51-!- stikonas_ is now known as stikonas
20171105 16:52:04< irker148> wesnoth: Ignacio R. Morelle wesmere:master 08aca52a5ad1 / static/docroot/index.php: Update 1.13.10 macOS package info https://github.com/wesnoth/wesmere/commit/08aca52a5ad1a56e0f6de33d70401d7c139fbe86
20171105 16:57:54-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20171105 17:20:29< AI0867> zookeeper: see PR #2173
20171105 17:24:55< zookeeper> sweet
20171105 17:27:00< irker148> wesnoth: Alexander van Gessel wesnoth:blur-refactor 6f83ef15cb9c / src/sdl/utils.cpp: Further refactoring of blur algorithm https://github.com/wesnoth/wesnoth/commit/6f83ef15cb9c80652c9a2da13f82248cb2f9251d
20171105 17:40:40-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:9ce:700d:40b9:2fcb] has joined #wesnoth-dev
20171105 17:47:16-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:9ce:700d:40b9:2fcb] has quit [Remote host closed the connection]
20171105 18:13:31-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:9ce:700d:40b9:2fcb] has joined #wesnoth-dev
20171105 18:18:54-!- travis-ci [~travis-ci@ec2-54-157-32-40.compute-1.amazonaws.com] has joined #wesnoth-dev
20171105 18:18:55< travis-ci> AI0867/wesnoth#49 (blur-alpha - 067bfad : Alexander van Gessel): The build passed.
20171105 18:18:55< travis-ci> Build details : https://travis-ci.org/AI0867/wesnoth/builds/297613940
20171105 18:18:55-!- travis-ci [~travis-ci@ec2-54-157-32-40.compute-1.amazonaws.com] has left #wesnoth-dev []
20171105 18:40:10-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:9ce:700d:40b9:2fcb] has quit [Remote host closed the connection]
20171105 18:42:29-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20171105 19:28:29-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20171105 19:29:42-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:9ce:700d:40b9:2fcb] has joined #wesnoth-dev
20171105 19:33:34-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:9ce:700d:40b9:2fcb] has quit [Remote host closed the connection]
20171105 19:36:34-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:9ce:700d:40b9:2fcb] has joined #wesnoth-dev
20171105 19:56:00-!- EliDupree2 [~quassel@2604:a880:400:d0::9bb:2001] has joined #wesnoth-dev
20171105 20:00:49-!- matth1askrgr [matthiaskr@gateway/shell/panicbnc/x-nbwckfzlplmbhlyq] has joined #wesnoth-dev
20171105 20:03:10-!- matth1askrgr [matthiaskr@gateway/shell/panicbnc/x-nbwckfzlplmbhlyq] has quit [Changing host]
20171105 20:03:10-!- matth1askrgr [matthiaskr@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20171105 20:03:10-!- matth1askrgr [matthiaskr@unaffiliated/matthiaskrgr] has quit [Changing host]
20171105 20:03:10-!- matth1askrgr [matthiaskr@gateway/shell/panicbnc/x-nbwckfzlplmbhlyq] has joined #wesnoth-dev
20171105 20:03:22-!- Elsi_ [~Elsi@luwin.ulrar.net] has joined #wesnoth-dev
20171105 20:11:47-!- Netsplit *.net <-> *.split quits: irker148
20171105 20:11:50-!- Netsplit *.net <-> *.split quits: matthiaskrgr, EliDupree, madmax28, Elsi
20171105 20:12:01-!- matth1askrgr is now known as matthiaskrgr
20171105 20:14:49-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:9ce:700d:40b9:2fcb] has quit [Remote host closed the connection]
20171105 20:32:17< vn971> Hmm.. Where can I read how multiplayer addons loading works? I have a problem: I wrote an addon that kinda works offline. But when I to play with a client that does not have the addon, the client gets a message like this: https://pointsgame.net/vn971/temp/2017.11.05_23:32:01_16893e8.png
20171105 20:58:06< Ravana_> only wml files are sent from host in multiplayer
20171105 20:58:20< vn971> Ravana_: you mean *.cfg files ?
20171105 20:58:53< vn971> Ravana_: can I hack it then and store my lua files in ABCDE.lua.cfg ?
20171105 20:59:21< Ravana_> usually yes. host preprocesses stuff, and sents result to others, no matter if it was preprocessed from cfg or lua files
20171105 21:00:18< Ravana_> you can see EoHS for how to include lua so that for testing environment it still loads with dofile
20171105 21:00:19< vn971> Ravana_: but host wouldn't be able to preprocess lua masked as cfg, right?
20171105 21:00:34< vn971> EoHS?
20171105 21:00:35< Ravana_> with << >> it would
20171105 21:00:43< Ravana_> era of high sorcery
20171105 21:00:46-!- Gfg [50bb653e@gateway/web/freenode/ip.80.187.101.62] has joined #wesnoth-dev
20171105 21:01:07< vn971> Ravana_: thx, I'll look into that if it won't work without it.
20171105 21:02:09< vn971> A question though: would it make sense to raise an issue and ask to actually send *.lua files to clients?
20171105 21:02:50< Gfg> i wonder wheter we shoud implemt auto installing of addons if a safefile is loaded(similar to how 1.13 dies it when joining mp games)
20171105 21:02:52< vn971> If *.cfg files are being sent because they're small, then the same reasoning applies to *.lua. Also, they both are "code".
20171105 21:04:07< Ravana_> files aren't sent
20171105 21:04:14< Ravana_> resulting text is
20171105 21:10:23< vn971> Ravana_: Ok.. So, do you have any ideas why loading didn't work for my addon? The only place where it is referenced is:  [lua]
20171105 21:10:24< vn971>  code = << wesnoth.dofile "~add-ons/DCrW/lua/do_creep_respawn.lua.cfg" >>
20171105 21:10:24< vn971> [/lua]
20171105 21:11:08< Ravana_> if you dofile, then you need lua file
20171105 21:11:18< vn971> Guessing by the screenshot above, the file wasn't pre-processed and inlined into any "parent" text. So wesnoth tries to access the file as-is.
20171105 21:11:26< Ravana_> I don't remember specifics, just that EoHS has that loading code
20171105 21:11:39< Ravana_> yes, <<>> stops preprocessing
20171105 21:11:57< vn971> Ravana_: ah, forgot to look at EoHS.(  Sry, will now look.
20171105 21:15:19-!- Gfg [50bb653e@gateway/web/freenode/ip.80.187.101.62] has quit [Ping timeout: 260 seconds]
20171105 21:25:01< vn971> Ravana_: that's hard. This addon uses files that are both valid cfg and valid lua. No usages of `wesnoth.dofile` are made at all (well, I guess that's obvious keeping the constraints in mind).
20171105 21:31:50< vn971> Ravana_: is there a reason why we preprocess everything into 1 file, and send 1 file only? Can we send many, and just allow referencing them?
20171105 21:40:03< Ravana_> are you talking about 1.12 or 1.13 now
20171105 21:40:18< Ravana_> (sent that to my highlight log channel before accidentally)
20171105 21:41:12< vn971> Ravana_: 1.13
20171105 21:41:37< Ravana_> then all files are collected from addons server
20171105 21:42:35< Ravana_> no idea if version consistency check was implemented there
20171105 21:53:14-!- NicolasF[m] [nicolasfma@gateway/shell/matrix.org/x-adtdkdwzbjywulrw] has quit [Ping timeout: 255 seconds]
20171105 21:53:27-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds]
20171105 21:54:14-!- ChipmunkV[m] [chipmunkvm@gateway/shell/matrix.org/x-yqjqqwfivaeettti] has quit [Ping timeout: 255 seconds]
20171105 21:54:22-!- Greg_Boggs[m] [gregboggsm@gateway/shell/matrix.org/x-gluxuffnylhoypjd] has quit [Ping timeout: 248 seconds]
20171105 21:56:47-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20171105 21:57:59< vultraz> AI0867: should the blur stuff be merged?
20171105 22:02:58-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171105 22:03:06-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171105 22:04:24-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20171105 22:09:29-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20171105 22:12:00-!- sevu [~Shiki@p54854262.dip0.t-ipconnect.de] has joined #wesnoth-dev
20171105 22:12:31< sevu> 20171105 22:59:14 error ai/actions: Error #2001 (move_result::E_EMPTY_MOVE) in partial move by side 2 from location 13,11 to location 13,11
20171105 22:13:12< sevu> This is a bit strange, because there were no special abilities or effects which stop you from moving or alike, and the location is the same
20171105 22:13:46< sevu> I don't know when exactly I got this, just saw it in the logs
20171105 22:26:50-!- Greg_Boggs[m] [gregboggsm@gateway/shell/matrix.org/x-qdxuuuhvkosaqjul] has joined #wesnoth-dev
20171105 22:28:56< vn971> Does anybody remember, what does that mean?:  Mandatory WML child missing yet untested for
20171105 22:28:56< vn971> I found it in config.cpp (only occurence), but it's not clear what it means.
20171105 22:29:52< vn971> I mean, I got the text above from wesnoth. Trying to understand what it means, I fould it in code. But still not clear what exactly wesnoth thinks is wrong.
20171105 22:43:46-!- Gfg [50bb653e@gateway/web/freenode/ip.80.187.101.62] has joined #wesnoth-dev
20171105 22:44:44< Gfg> It means weshoth has found in the c++ code and you should report it
20171105 22:45:28-!- madmax28 [madmax28ma@gateway/shell/matrix.org/x-wnjbnsmdlqucvaoe] has joined #wesnoth-dev
20171105 22:45:28-!- ChipmunkV[m] [chipmunkvm@gateway/shell/matrix.org/x-yohxpdsfkatfwgqt] has joined #wesnoth-dev
20171105 22:45:29< Gfg> But in order to fix it we epigher need a 100% way to reproduce it or a c++ stacktrace
20171105 22:45:35-!- NicolasF[m] [nicolasfma@gateway/shell/matrix.org/x-hpwmyzyllqntucdj] has joined #wesnoth-dev
20171105 22:55:39-!- Gfg [50bb653e@gateway/web/freenode/ip.80.187.101.62] has quit [Ping timeout: 260 seconds]
20171105 23:10:58< vn971> I bisected the problem to find out it's part of my lua code. If I comment it out, there is no such error. Since the code was for wesnoth-1.13 anyway, I left it commented out for now. So I blame something about my code (and probably bad error reporting), not cpp. At least that's how far I can understand the problem.
20171105 23:15:32< sevu> I saw this as well a few time but never figured out what it was. Sounds like you just found a 100% way to reproduce it
20171105 23:19:10-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20171105 23:25:46< vn971> sevu: oh, that's also bad, because it may be hard to share the reproducable case. I have a not-very-small addon (Creep Wars), I must join with _2_ players and play with each other on lobby for this to repro. Probably there are simpler ways, but that's the simplest I know of.
20171105 23:26:09< vn971> sevu: should I report it, anyway? Will somebody load the addon etc in order to repro?
20171105 23:26:14-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20171105 23:26:43< vn971> offline play doesn't produce any such error.
20171105 23:29:06< sevu> Maybe fill a bug report an look what others say. I think I saw his on offline gamees
20171105 23:32:43< vn971> Anyway, there's another question I wanted to ask. Is `helper.rand()` safe against OOS? The problem is, it doesn't look like it. I use it in a loop, sometimes over a hundred times, to do some calculation. May it be that using it so intensively might lead to errors?
20171105 23:33:08-!- sevu [~Shiki@p54854262.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20171105 23:36:23-!- sevu [~Shiki@p54854262.dip0.t-ipconnect.de] has joined #wesnoth-dev
--- Log closed Mon Nov 06 00:00:06 2017