--- Log opened Thu Nov 09 00:00:10 2017
20171109 00:12:56-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20171109 00:47:04-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20171109 00:51:35-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171109 00:56:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 268 seconds]
20171109 01:03:58< celticminstrel> Random thought apropos of nothing (while reviewing PR 2181): That "return_misformed()" macro could actually be rewritten so that uses look like "return misformed". :O
20171109 01:04:21< celticminstrel> Like, #define misformed lua_settop(L, initial_top), false
20171109 01:04:29 * celticminstrel isn't actually recommending it though.
20171109 01:12:48-!- irker333 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20171109 01:30:54-!- Bonobo [~Bonobo@14-203-49-124.tpgi.com.au] has joined #wesnoth-dev
20171109 01:46:10-!- irker165 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171109 01:46:10< irker165> wesnoth: Celtic Minstrel wesnoth:master 6cda13bec680 / CONTRIBUTING.md: Please remember to add labels, everyone! https://github.com/wesnoth/wesnoth/commit/6cda13bec680d76263df874e7ad77f066b29f68b
20171109 02:23:28< vultraz> celticminstrel: if you have a do() { continue; } while(cond); loop, is `cond`ever checked?
20171109 02:25:58< DeFender> http://en.cppreference.com/w/cpp/language/continue says yes
20171109 02:26:22< DeFender> that's not something I've ever thought of before though.
20171109 02:26:36< DeFender> (Though, given how rarely I find the need to use a continue...)
20171109 02:26:49< shadowm> It's `do`, not `do()`. `do()` is not a function.
20171109 02:26:58< vultraz> yeah, that
20171109 02:27:06< shadowm> (And since `do` is a keyword you can't have it as a symbol name anyway.)
20171109 02:45:01-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171109 02:45:08-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171109 02:48:39-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20171109 02:50:07-!- irker165 [~irker@uruz.ai0867.net] has quit [Ping timeout: 248 seconds]
20171109 02:50:08-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 248 seconds]
20171109 02:50:08-!- yaiyan [~yaiyan@46.101.48.31] has quit [Ping timeout: 248 seconds]
20171109 02:50:08-!- wedge010 is now known as wedge009
20171109 02:51:14-!- Jetrel_bot [~Jetrel@ec2.happyspork.com] has quit [Ping timeout: 248 seconds]
20171109 02:51:44-!- APic [apic@apic.name] has quit [Ping timeout: 248 seconds]
20171109 02:51:45-!- galegosimpatico [~uprego@unaffiliated/ushiu] has quit [Ping timeout: 248 seconds]
20171109 02:52:53-!- Jetrel_bot [~Jetrel@ec2.happyspork.com] has joined #wesnoth-dev
20171109 02:53:01< celticminstrel> vultraz: Yes it's checked.
20171109 02:53:20-!- galegosimpatico [~uprego@216.red-83-46-196.dynamicip.rima-tde.net] has joined #wesnoth-dev
20171109 02:53:40< celticminstrel> Oh, I missed the continue... still, I'd expect it to still be checked.
20171109 03:04:38-!- yaiyan [~yaiyan@46.101.48.31] has joined #wesnoth-dev
20171109 03:08:52-!- travis-ci [~travis-ci@ec2-54-167-128-82.compute-1.amazonaws.com] has joined #wesnoth-dev
20171109 03:08:53< travis-ci> wesnoth/wesnoth#15532 (master - 6cda13b : Celtic Minstrel): The build passed.
20171109 03:08:53< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/299420345
20171109 03:08:53-!- travis-ci [~travis-ci@ec2-54-167-128-82.compute-1.amazonaws.com] has left #wesnoth-dev []
20171109 03:10:40-!- APic [apic@apic.name] has joined #wesnoth-dev
20171109 03:14:56-!- ChipmunkV[m] [chipmunkvm@gateway/shell/matrix.org/x-jywvfblkqwrywmip] has quit [Ping timeout: 250 seconds]
20171109 03:15:59-!- NicolasF[m] [nicolasfma@gateway/shell/matrix.org/x-lwocmwkdvkievdpj] has quit [Ping timeout: 255 seconds]
20171109 03:16:21-!- madmax28 [madmax28ma@gateway/shell/matrix.org/x-lrjqsyfqnhosjweq] has quit [Ping timeout: 255 seconds]
20171109 03:16:31-!- Greg_Boggs[m] [gregboggsm@gateway/shell/matrix.org/x-jzgkfqawlxaydirl] has quit [Ping timeout: 240 seconds]
20171109 03:19:17< vultraz> celticminstrel: how would I go about copying a range of children from a config o another?
20171109 03:19:19< vultraz> to*
20171109 03:19:58< vultraz> maybe append_children..
20171109 03:22:22< vultraz> yeah that works
20171109 03:22:32< vultraz> this could potentially be a large config, though
20171109 03:23:14< vultraz> hmm
20171109 03:23:20< vultraz> add_child has a move thingy...
20171109 03:24:53< vultraz> new function time!
20171109 03:25:18-!- Bonobo [~Bonobo@14-203-49-124.tpgi.com.au] has quit [Ping timeout: 268 seconds]
20171109 03:25:28-!- Bonobo [~Bonobo@14-203-49-124.tpgi.com.au] has joined #wesnoth-dev
20171109 03:34:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20171109 03:45:39-!- Guest44240 [~beencubed@103.89.244.62] has joined #wesnoth-dev
20171109 03:56:23-!- TheJJ_ [~rofl@ipbcc36896.dynamic.kabel-deutschland.de] has joined #wesnoth-dev
20171109 03:56:39-!- TheJJ [~rofl@ipbcc36896.dynamic.kabel-deutschland.de] has quit [Quit: No Ping reply in 180 seconds.]
20171109 04:00:56-!- Guest44240 [~beencubed@103.89.244.62] has quit [Quit: BitchX: not a flotation device]
20171109 05:19:36-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20171109 05:39:55-!- ChipmunkV[m] [chipmunkvm@gateway/shell/matrix.org/x-lvlmfjygdujrrluf] has joined #wesnoth-dev
20171109 05:59:28-!- madmax28 [madmax28ma@gateway/shell/matrix.org/x-wxbpwacljtcpcbba] has joined #wesnoth-dev
20171109 05:59:35-!- NicolasF[m] [nicolasfma@gateway/shell/matrix.org/x-mgiapvcvpkfwpgxs] has joined #wesnoth-dev
20171109 05:59:35-!- Greg_Boggs[m] [gregboggsm@gateway/shell/matrix.org/x-avgynjmadsfkhfzb] has joined #wesnoth-dev
20171109 06:02:04-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20171109 06:14:21-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20171109 06:17:03< mattsc> JyrkiVesterinen: I figured out how to add random.cpp to Xcode, just a stupid oversight on my part, so I removed my comment from the randomness commit.
20171109 06:17:21-!- Bonobo [~Bonobo@14-203-49-124.tpgi.com.au] has quit [Ping timeout: 268 seconds]
20171109 06:17:58< JyrkiVesterinen> Randomness commt? I don't recall making randomness-related commits for some time.
20171109 06:18:40< mattsc> JyrkiVesterinen: Oops, that wasn’t you.  Sorry!
20171109 06:19:44< mattsc> Is GregoryLundberg here under some other name?  If so, ^
20171109 06:20:05< JyrkiVesterinen> Yes, his username here is TadCarlucci.
20171109 06:20:22< mattsc> Oh, right, I even knew that.  Thanks.
20171109 06:22:55-!- Netsplit *.net <-> *.split quits: madmax28
20171109 06:26:51-!- irker290 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171109 06:26:51< irker290> wesnoth: mattsc wesnoth:master 8d2a3d369b60 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update Xcode project https://github.com/wesnoth/wesnoth/commit/8d2a3d369b600dc3bd48c1786cb6c46983fca968
20171109 06:32:11-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20171109 06:32:13-!- madmax28 [madmax28ma@gateway/shell/matrix.org/x-oxhemshmrugjkrcv] has joined #wesnoth-dev
20171109 06:34:03< irker290> wesnoth: mattsc wesnoth:master 3b2077fdc3a2 / data/ai/lua/ai_helper.lua: Fast Micro AI ai_helper functions: fix rarely occurring bug https://github.com/wesnoth/wesnoth/commit/3b2077fdc3a2edb05028f33b4951aeca8c931aa7
20171109 06:36:07-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20171109 07:09:53-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Ping timeout: 255 seconds]
20171109 07:10:27-!- Elsi_ [~Elsi@luwin.ulrar.net] has quit [Ping timeout: 246 seconds]
20171109 07:42:29-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20171109 07:42:34-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20171109 08:45:53-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20171109 08:52:25< vn971> Question regarding Lua API. Can I set a permanent terrain label on a tile? I can't find a function for that https://wiki.wesnoth.org/LuaWML#WML_variables
20171109 08:54:29< vn971> What I see a "float label" here, but it's a temporal thing and disappears soon: https://wiki.wesnoth.org/LuaWML:Display#wesnoth.float_label
20171109 08:55:15< vn971> I also see "add_tile_overlay", but it only places an image as far as I see: https://wiki.wesnoth.org/LuaWML:Tiles#wesnoth.add_tile_overlay
20171109 08:55:27< vn971> So.. How do I just set text for a hex?
20171109 08:59:20< vn971> UPD: there seems to be a wesnoth.wml_actions.print  though it's not documented on the wiki. I found it by using auto-completion on 1.13.
20171109 09:05:57< JyrkiVesterinen> Do you mean wesnoth.wml_actions.label?
20171109 09:06:17< JyrkiVesterinen> AFAIK, the entire WML API is available via wesnoth.wml_actions.
20171109 09:06:25< JyrkiVesterinen> https://wiki.wesnoth.org/LuaWML/Events#wesnoth.wml_actions
20171109 09:06:48< zookeeper> and print is for the kind of text that appears for a while in the middle of the screen
20171109 09:16:55< vn971> JyrkiVesterinen: yes, it's actually label. Well anyway, once I found out wesnoth.wml_actions and tab autocompletion, everything else is easy.
20171109 09:18:27< vn971> You're right, it kinda _is_ documented. You just can't find it by Ctrl F on the page.:D But the wml_actions field contains lots of useful methods, yes.
20171109 09:18:47< vn971> And it is documented.
20171109 09:19:41< vn971> OK, another question. Is this method really "good": https://wiki.wesnoth.org/LuaWML:Sides#helper.all_teams
20171109 09:20:39< vn971> it says "all teams", the reader might interpret the method as if it returns "teams". Like the insides of a [team] tag, for example. In fact, this method seems to return _sides_.
20171109 09:21:03< vn971> if it returns side data, then it should be called "all_sides", shouldn't it? Or am I missing something?
20171109 09:22:31< JyrkiVesterinen> Yeah, I think it's indeed incorrectly named.
20171109 09:22:42< JyrkiVesterinen> Hard to change now because backwards compatibility.
20171109 09:30:09< vn971> JyrkiVesterinen: deprecate maybe?
20171109 09:30:41< JyrkiVesterinen> I'm not really messing with Lua APIs. I'm an engine developer.
20171109 09:31:46< vn971> OK, question goes to Lua API developers, then, I think.
20171109 09:31:59-!- Elsi [~Elsi@luwin.ulrar.net] has joined #wesnoth-dev
20171109 09:34:06-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20171109 09:35:30-!- amir|2 [~amir@212-88-19-7.hdsl.highway.telekom.at] has joined #wesnoth-dev
20171109 09:36:11< amir|2> anyone got a hint on where i can find the wesnoth code responsible for reading replays? I'm digging through the code right now and it's not easy to find
20171109 09:36:49< JyrkiVesterinen> The code has multiple layers.
20171109 09:36:59< JyrkiVesterinen> First, there is the low-level WML parser in https://github.com/wesnoth/wesnoth/tree/master/src/serialization
20171109 09:38:42< JyrkiVesterinen> And the high-level replay representation is this class: https://github.com/wesnoth/wesnoth/blob/master/src/savegame.hpp#L256-L267
20171109 09:39:33< amir|2> thank you very much! 
20171109 09:45:55< amir|2> am i right that the WML tree ends up in the elements member of the class parser?
20171109 09:47:25< JyrkiVesterinen> I think so. (I'm not really familiar with the WML parser, I haven't needed to make changes to it apart from minor refactoring.)
20171109 09:47:39< amir|2> ic. thx
20171109 09:54:51-!- APic [apic@apic.name] has quit [Quit: leaving]
20171109 10:12:29< irker290> wesnoth: Charles Dang wesnoth:master 192fbdc17355 / src/ (config.cpp config.hpp): Config: added function to move children from one config to another https://github.com/wesnoth/wesnoth/commit/192fbdc17355d6a26e5c4b966190cf8f18dda57e
20171109 10:15:27-!- APic [apic@apic.name] has joined #wesnoth-dev
20171109 10:29:56-!- vladimirslavik [vslavik@nat/redhat/x-okxkazluunpljucg] has joined #wesnoth-dev
20171109 10:34:30< JyrkiVesterinen> vultraz: config::append_children_by_move() isn't safe.
20171109 10:34:41< vultraz> ??
20171109 10:34:46< vultraz> but why
20171109 10:34:55< JyrkiVesterinen> For move construction, the C++ standard only guarantees that the source container will remain in valid state.
20171109 10:35:23< JyrkiVesterinen> It's unspecified whether the source config will become empty, stay as it is, or even contain garbage data.
20171109 10:36:12< JyrkiVesterinen> In other words, it isn't safe to use a config object after having moved children out of it with append_:children_by_move().
20171109 10:37:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171109 10:37:48-!- amir|2 [~amir@212-88-19-7.hdsl.highway.telekom.at] has quit [Ping timeout: 252 seconds]
20171109 10:38:46< vultraz> JyrkiVesterinen: do you mean the destination config will remain valid?
20171109 10:39:17< JyrkiVesterinen> The destination will be fine, yes.
20171109 10:39:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20171109 10:41:00< vultraz> so essentially, it's unsafe to move *part* of an ibject??
20171109 10:41:01< JyrkiVesterinen> If you don't care about what happens to the source config, then warn about it in the function declaration by receiving it as a rvalue reference.
20171109 10:41:33< JyrkiVesterinen> Essentially, it's unsafe to move from anything you intend to use afterwards.
20171109 10:42:08< vultraz> :/
20171109 10:43:08< vultraz> well that rather throws a spanner in the idea...
20171109 10:43:53< vultraz> how should I implement this function instead?
20171109 10:44:07< JyrkiVesterinen> What do you plan to use it for?
20171109 10:46:47< vultraz> hmm. well I had intended it for moving the gamelist and user data the server sends and in to a local config. But... on second though, at that point the whole response constitutes the data I want... so I could just use `std::swap`
20171109 10:47:52< JyrkiVesterinen> Swapping with an empty config sounds like a good option, indeed.
20171109 10:48:32< vultraz> so I guess I don't need this
20171109 10:48:44< vultraz> might be useful to have, though, if it could be implemented properly
20171109 10:49:13< JyrkiVesterinen> The proper implementation depends on whether the source config is supposed to be usable afterwards.
20171109 10:49:25< JyrkiVesterinen> If not, just receive it as an rvalue reference.
20171109 10:49:42< vultraz> that was what i had intended
20171109 10:50:27< vultraz> it was supposed to be a "move certain parts of this config to another config, and leave the rest as-is" function
20171109 10:50:44< JyrkiVesterinen> Specifying a parameter as an rvalue reference is used as a sign "Danger! Only call this if you don't need the value any more!"
20171109 10:51:27< JyrkiVesterinen> Likewise, a C++ programmer does not expect an object to be in an unspecified state after passing it to a function that receives it as an *lvalue* reference.
20171109 10:52:39< JyrkiVesterinen> That's also why conversion to rvalue reference isn't implicit and you need std::move() for it. Calling std::move() and using the same variable aftwerwards is a huge code smell.
20171109 10:53:13< JyrkiVesterinen> All this exists to protect programmers from accidentally trashing objects they need.
20171109 10:55:59< vultraz> this whole "never use something you moved a component from" just.... honestly isn't something one would expect. if you move the whole object, yeah, makes sense not to use it after. but a component? 
20171109 10:56:01< vultraz> blah
20171109 10:56:34< vultraz> doesn't seem great design to have hidden idiosyncrasies like this that require a deep-dive to SO or someone who's read the standard to know :|
20171109 10:56:41< JyrkiVesterinen> The component is a part of the object as well.
20171109 10:57:05< JyrkiVesterinen> After calling append_children_by_move(), cfg.values_ and cfg.ordered_children_ are still fine.
20171109 10:57:13< JyrkiVesterinen> But cfg.children_ is not.
20171109 10:57:25< vultraz> I see
20171109 10:57:30< JyrkiVesterinen> And of course the config isn't safe to use in that state.
20171109 10:58:25< JyrkiVesterinen> You can just do cfg.children_.clear() and restore the config to a valid state if you still want to use it.
20171109 10:58:42< vultraz> might as well just revert the commit
20171109 11:00:13-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit []
20171109 11:02:49-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20171109 11:02:55-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20171109 11:09:36-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20171109 11:28:28-!- amir|2 [~amir@public.metalab.wien.funkfeuer.at] has joined #wesnoth-dev
20171109 11:53:52-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20171109 12:07:44-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20171109 12:12:40-!- galegosimpatico [~uprego@216.red-83-46-196.dynamicip.rima-tde.net] has quit [Changing host]
20171109 12:12:40-!- galegosimpatico [~uprego@unaffiliated/ushiu] has joined #wesnoth-dev
20171109 12:15:11-!- Bonobo [~Bonobo@14-203-49-124.tpgi.com.au] has joined #wesnoth-dev
20171109 12:16:33-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Quit: I'll be back!]
20171109 12:24:04< vn971> Question. Is there a way to store something that could be extracted back on game reloads?
20171109 12:24:59< vn971> As far as I observe and read, global variables aren't preserved.  > The global environment is not preserved over save/load cycles.  Therefore, storing values in the global environment is generally a bad idea.
20171109 12:24:59< JyrkiVesterinen> https://wiki.wesnoth.org/PersistenceWML
20171109 12:31:51< vn971> JyrkiVesterinen: thank you! That seems to be it. Though it's more powerful than just recording something in the scope of a game. Also, I'm not really sure it's immediately appliable since I'll have to distinguish data from different game saves. So ideally it should belong to the game save itself.
20171109 12:32:39< vn971> Actually, for my exact purpose right now, I can re-calculate the data because I found a wesnoth Lua API that is suitable for my task. So it's not urgent for me.
20171109 12:33:39< JyrkiVesterinen> In general, when possible, recalculating is a better idea than saving. Otherwise there is a possibility of conflicting data.
20171109 12:34:12< Soliton> how do you lose variables on reload anyway?
20171109 12:35:03< JyrkiVesterinen> I assume he means Lua variables.
20171109 12:35:41< vn971> Soliton: JyrkiVesterinen: I've actually meant global variables, those that are `wesnoth.set_variable("", 2)`  (or the WML alternative)
20171109 12:36:03< vn971> I don't see those when I reload a game.
20171109 12:38:01< vn971> Ah, interesting.. I think I understood, why. I store variables via "addonname_kills_" .. team_name. For example, "addonname_kills_West". Now, team names are not preserved between game reloads. So when I reload, I try to access field "addonname_kills_Team 1".
20171109 12:38:52< vn971> That's the behavior for wesnoth-1.12, anyway.
20171109 12:50:01< Soliton> sounds like the team name thing might be a bug.
20171109 12:54:06-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20171109 12:55:06< mattsc> All: so I did some more testing and I cannot save the game from _any_ replay in 1.13.
20171109 12:55:30< vultraz> *blinks*
20171109 12:55:37< mattsc> I deleted the cache and preferences file just to make sure those were not what’s causing this.
20171109 12:56:02< mattsc> The ‘save game’ menu option is not there and the keyboard shortcut does not work either.
20171109 12:56:32< mattsc> If anybody could confirm that quickly, that would be great.
20171109 12:56:43< mattsc> Either way, I’ll file a bug report later.
20171109 13:01:00< vn971> mattsc: yes, there just doesn't seem to be a "save game" action. Only "save replay" (the replay itself).
20171109 13:01:55< mattsc> vn971: Thanks!  Yes, that is what I am seeing also.
20171109 13:02:11< mattsc> I presume that this is unintended?
20171109 13:04:54< vn971> mattsc: I'm not sure, but having an option to save the game for future play seems natural. So I think it's good to fill a bug/feature request. (Note: I'm not really a wesnoth developer, only a bug reporter and a beginning addon writer.)
20171109 13:06:15< mattsc> vn971: I was talking mostly tongue in cheek there.  This is definitely a bug and it is a regression from 1.12.  :)
20171109 13:06:30< mattsc> I’ll file the bug report in a little while.
20171109 13:06:51< mattsc> Currently busy with other (non-BfW) stuff
20171109 13:09:37< irker290> wesnoth: Charles Dang wesnoth:master e41534d11443 / src/ (4 files in 3 dirs): MP: wait at the loading screen until initial lobby data is fetched https://github.com/wesnoth/wesnoth/commit/e41534d114437b26c735915f530df2cbc28e6c15
20171109 13:24:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171109 13:25:02< Soliton> that looks dubios. a goto over ~200 lines that could easily be avoided and a new global variable which is cleared each time.
20171109 13:26:05< vultraz> could be avoided by moving the checks to the front of the loop, yes
20171109 13:28:00< vultraz> what's wrong with a global variable
20171109 13:30:35< Soliton> global state is bad. more state you have to consider everywhere. always use the smallest scope possible.
20171109 13:31:05< vultraz> i used global to avoid having to then pass it down through two other functions
20171109 13:33:21< Soliton> so instead of showing the actual data flow you hide it behind a global variable. screw the next guy reading that code.
20171109 13:35:34< vultraz> grumble grumble 
20171109 13:37:39< vultraz> and what's wrong with a goto
20171109 13:42:28< Soliton> it's rarely the right choice and can easily be avoided here.
20171109 13:42:37< Soliton> it can be useful sometimes though.
20171109 13:42:42< irker290> wesnoth: Charles Dang wesnoth:master a77c40f10517 / src/sound.cpp: Guard against even MORE nullptr dereference (should fix #2153 again) https://github.com/wesnoth/wesnoth/commit/a77c40f10517a3774e7d333e5b474f7cf288fa7e
20171109 13:42:45< irker290> wesnoth: Charles Dang wesnoth:master 21395a792588 / changelog src/image_modifications.cpp: Fixed the opacity IPF resetting to 0 if the value given was 100% or greater (fix https://github.com/wesnoth/wesnoth/commit/21395a792588fec26ff6e90d7e72ff8828f367b7
20171109 13:42:47< vultraz> fine, fine, I'll use a lambda
20171109 13:44:18-!- sevu [~Shiki@p5485507F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20171109 13:45:52< vultraz> Or just move it
20171109 13:47:42< zookeeper> for someone who likes the "bad design" catch-all, it's odd that you'd ask what's wrong with a goto :p
20171109 14:10:19-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20171109 14:19:11-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Quit: Leaving]
20171109 14:31:18-!- vslavik [vslavik@nat/redhat/x-jftwkjpjrchzancr] has joined #wesnoth-dev
20171109 14:34:02-!- vladimirslavik [vslavik@nat/redhat/x-okxkazluunpljucg] has quit [Ping timeout: 260 seconds]
20171109 14:37:01-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20171109 15:10:48-!- Bonobo [~Bonobo@14-203-49-124.tpgi.com.au] has quit [Ping timeout: 240 seconds]
20171109 15:21:39-!- vslavik__ [vslavik@nat/redhat/x-jqjfnjyutmepkhkv] has joined #wesnoth-dev
20171109 15:22:41-!- sevu [~Shiki@p5485507F.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20171109 15:24:20-!- vslavik [vslavik@nat/redhat/x-jftwkjpjrchzancr] has quit [Ping timeout: 268 seconds]
20171109 15:25:18-!- travis-ci [~travis-ci@ec2-54-163-105-137.compute-1.amazonaws.com] has joined #wesnoth-dev
20171109 15:25:19< travis-ci> wesnoth/wesnoth#15538 (master - 21395a7 : Charles Dang): The build has errored.
20171109 15:25:19< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/299642585
20171109 15:25:19-!- travis-ci [~travis-ci@ec2-54-163-105-137.compute-1.amazonaws.com] has left #wesnoth-dev []
20171109 15:27:30-!- vslavik__ is now known as vladimirslavik
20171109 15:27:41-!- vladimirslavik [vslavik@nat/redhat/x-jqjfnjyutmepkhkv] has quit [Changing host]
20171109 15:27:41-!- vladimirslavik [vslavik@wesnoth/translator/VladimirSlavik] has joined #wesnoth-dev
20171109 15:31:54-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20171109 16:09:18-!- sevu [~Shiki@p5485507F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20171109 16:43:11-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20171109 16:44:07-!- irker290 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20171109 16:56:13-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20171109 17:20:09-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171109 17:21:37-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20171109 17:44:36-!- amir|2 [~amir@public.metalab.wien.funkfeuer.at] has quit [Ping timeout: 252 seconds]
20171109 18:03:29-!- sevu [~Shiki@p5485507F.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20171109 18:35:47-!- vladimirslavik [vslavik@wesnoth/translator/VladimirSlavik] has quit [Quit: Leaving]
20171109 19:00:23-!- vn971 [~vasya@94.158.103.15] has quit [Quit: Leaving.]
20171109 19:05:51-!- irker313 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171109 19:05:51< irker313> wesnoth: Nils Kneuper wesnoth:master 2c5a2ea20da6 / / (9 files in 8 dirs): updated Italian translation https://github.com/wesnoth/wesnoth/commit/2c5a2ea20da632f0e06ffaea20a22775330c5787
20171109 19:32:14-!- amir|2 [~amir@80-110-85-32.cgn.dynamic.surfer.at] has joined #wesnoth-dev
20171109 19:42:04-!- atarocch [~atarocch@93.56.164.28] has quit [Quit: Leaving]
20171109 19:42:32-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20171109 19:48:06-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20171109 19:48:20-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171109 20:08:02-!- mjs-de [~mjs-de@x4db60b88.dyn.telefonica.de] has joined #wesnoth-dev
20171109 20:15:07-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20171109 20:15:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171109 20:18:19-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20171109 20:21:30-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20171109 20:23:43< irker313> wesnoth: Charles Dang wesnoth:master 5d423ae66b42 / src/sound.cpp: Fixup a77c40f10517 https://github.com/wesnoth/wesnoth/commit/5d423ae66b42a62c7931ea932836448bbcc14be8
20171109 20:24:37-!- mjs-de [~mjs-de@x4db60b88.dyn.telefonica.de] has quit [Remote host closed the connection]
20171109 20:42:53< amir|2> how do i get the name of the wml tag from a config object? i user parser.cpp to read replays
20171109 20:44:43< vultraz> for(const auto& p : cfg.all_children_range()) { std::string key =p.key; }
20171109 20:45:12< amir|2> thx!
20171109 20:49:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20171109 20:50:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171109 21:05:44< amir|2> I've got a fully working tool to convert WML to XML: https://github.com/kallaballa/WesnothReplayToXML
20171109 21:06:06< amir|2> It uses some code from BfW that i ripped out for parsing
20171109 21:07:04-!- travis-ci [~travis-ci@ec2-107-21-136-112.compute-1.amazonaws.com] has joined #wesnoth-dev
20171109 21:07:05< travis-ci> wesnoth/wesnoth#15539 (master - 2c5a2ea : Nils Kneuper): The build failed.
20171109 21:07:05< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/299811925
20171109 21:07:05-!- travis-ci [~travis-ci@ec2-107-21-136-112.compute-1.amazonaws.com] has left #wesnoth-dev []
20171109 21:07:52< JyrkiVesterinen> Nice. And it didn't even take long. :)
20171109 21:08:10< JyrkiVesterinen> Albeit I see that you have copied a lot of code, including stuff like text rendering code.
20171109 21:09:46< amir|2> yes.. i'll have to isolate what i really need
20171109 21:09:51< amir|2> it's a bit quick and dirty
20171109 21:13:42< irker313> wesnoth: Charles Dang wesnoth:master ecb72d5ec458 / src/ (9 files in 5 dirs): Made use of T::emplace over T::insert where possible https://github.com/wesnoth/wesnoth/commit/ecb72d5ec45863eea4961a9301660715cf470ebc
20171109 21:34:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171109 21:35:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171109 21:46:03-!- amir|2 [~amir@80-110-85-32.cgn.dynamic.surfer.at] has quit [Ping timeout: 252 seconds]
20171109 21:55:24-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20171109 22:14:34-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20171109 22:18:53< irker313> wesnoth: Gregory A Lundberg wesnoth:GL_lua_next d26c4dcfc186 / src/scripting/ (lua_common.cpp lua_formula_bridge.cpp lua_kernel_base.cpp): Respect lua_next constraints https://github.com/wesnoth/wesnoth/commit/d26c4dcfc186ac23292b6f92dea1062e514d91f7
20171109 22:18:55< irker313> wesnoth: Gregory A Lundberg wesnoth:GL_lua_next 37cc0c82f284 / src/scripting/lua_kernel_base.cpp: Do not lua_next on userdata. https://github.com/wesnoth/wesnoth/commit/37cc0c82f284adc6c3a2f378f57788bc749a6824
20171109 22:20:44-!- iceiceice [~chris@209.133.79.7] has joined #wesnoth-dev
20171109 22:20:44-!- iceiceice [~chris@209.133.79.7] has quit [Changing host]
20171109 22:20:44-!- iceiceice [~chris@unaffiliated/iceiceice] has joined #wesnoth-dev
20171109 22:22:49< irker313> wesnoth: Gregory A Lundberg wesnoth:GL_lua_next ddc9e6e69dcd / src/scripting/ (lua_common.cpp lua_formula_bridge.cpp lua_kernel_base.cpp): Respect lua_next constraints https://github.com/wesnoth/wesnoth/commit/ddc9e6e69dcd7faeb24d6c58f17e17031bb5b478
20171109 22:22:51< irker313> wesnoth: Gregory A Lundberg wesnoth:GL_lua_next 2be2a519732a / src/scripting/lua_kernel_base.cpp: Do not lua_next on userdata. https://github.com/wesnoth/wesnoth/commit/2be2a519732a1b85cadb71670521d3ef1943e317
20171109 22:24:10-!- travis-ci [~travis-ci@ec2-54-163-105-137.compute-1.amazonaws.com] has joined #wesnoth-dev
20171109 22:24:11< travis-ci> wesnoth/wesnoth#15540 (master - 5d423ae : Charles Dang): The build passed.
20171109 22:24:11< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/299844545
20171109 22:24:11-!- travis-ci [~travis-ci@ec2-54-163-105-137.compute-1.amazonaws.com] has left #wesnoth-dev []
20171109 22:29:38-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171109 22:44:14-!- amir|2 [~amir@212-88-19-7.hdsl.highway.telekom.at] has joined #wesnoth-dev
20171109 22:53:47< irker313> wesnoth: Gregory A Lundberg wesnoth:GL_lua_next dd7c233ae089 / src/scripting/ (lua_common.cpp lua_formula_bridge.cpp lua_kernel_base.cpp): Respect lua_next constraints https://github.com/wesnoth/wesnoth/commit/dd7c233ae089c270666f9a85f9721ff9a22b432b
20171109 22:53:49< irker313> wesnoth: Gregory A Lundberg wesnoth:GL_lua_next dbbbba7ad3f2 / src/scripting/lua_kernel_base.cpp: Do not lua_next on userdata. https://github.com/wesnoth/wesnoth/commit/dbbbba7ad3f21b77c167b7ca542507a5c920fb4b
20171109 23:08:45-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20171109 23:10:55-!- travis-ci [~travis-ci@ec2-54-163-105-137.compute-1.amazonaws.com] has joined #wesnoth-dev
20171109 23:10:56< travis-ci> wesnoth/wesnoth#15541 (master - ecb72d5 : Charles Dang): The build has errored.
20171109 23:10:56< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/299865461
20171109 23:10:56-!- travis-ci [~travis-ci@ec2-54-163-105-137.compute-1.amazonaws.com] has left #wesnoth-dev []
20171109 23:40:14-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20171109 23:47:51-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
--- Log closed Fri Nov 10 00:00:12 2017