--- Log opened Fri Nov 10 00:00:12 2017 20171110 00:12:02-!- Bonobo [~Bonobo@14-203-49-124.tpgi.com.au] has joined #wesnoth-dev 20171110 00:13:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection] 20171110 00:17:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20171110 00:18:22-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection] 20171110 00:18:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20171110 00:36:36-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection] 20171110 00:37:57-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20171110 00:39:43-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection] 20171110 00:40:17-!- travis-ci [~travis-ci@ec2-107-21-136-112.compute-1.amazonaws.com] has joined #wesnoth-dev 20171110 00:40:18< travis-ci> wesnoth/wesnoth#15546 (GL_lua_next - dbbbba7 : Gregory A Lundberg): The build was broken. 20171110 00:40:18< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/299909029 20171110 00:40:18-!- travis-ci [~travis-ci@ec2-107-21-136-112.compute-1.amazonaws.com] has left #wesnoth-dev [] 20171110 00:41:50-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20171110 00:47:22-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection] 20171110 00:57:03< irker313> wesnoth: Charles Dang wesnoth:master b5e33ec62689 / src/game_initialization/multiplayer.cpp: MP: removed on-connection handing of unused join_game signal https://github.com/wesnoth/wesnoth/commit/b5e33ec626895df86aec81a5186fa2a7f1794864 20171110 00:57:06< irker313> wesnoth: Charles Dang wesnoth:master ef23e40d6b93 / src/game_initialization/multiplayer.cpp: MP: clean up e41534d1144 to make Soliton happy https://github.com/wesnoth/wesnoth/commit/ef23e40d6b930d6a15fc6a1488c63eb15a595009 20171110 01:03:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20171110 01:05:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20171110 01:19:52-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20171110 01:25:29-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20171110 01:29:31-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds] 20171110 01:46:14< irker313> wesnoth: Gregory A Lundberg wesnoth:GL_lua_next 29e93dabcafd / src/scripting/ (lua_common.cpp lua_formula_bridge.cpp lua_kernel_base.cpp): Respect lua_next constraints https://github.com/wesnoth/wesnoth/commit/29e93dabcafda8ce16471e2c0ed930251003c4c3 20171110 01:46:16< irker313> wesnoth: Gregory A Lundberg wesnoth:GL_lua_next 89753bfda2cf / src/scripting/lua_kernel_base.cpp: Do not lua_next on userdata. https://github.com/wesnoth/wesnoth/commit/89753bfda2cf419891786c753b06ad6705696d84 20171110 02:01:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20171110 02:05:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20171110 02:05:48< irker313> wesnoth: Charles Dang wesnoth:master 71b32cec1618 / data/gui/window/lobby_main.cfg: Lobby Main: tweak player list entry borders https://github.com/wesnoth/wesnoth/commit/71b32cec1618e21d873cf07faf70cf63c2ff79c5 20171110 02:14:13-!- travis-ci [~travis-ci@ec2-54-205-237-128.compute-1.amazonaws.com] has joined #wesnoth-dev 20171110 02:14:14< travis-ci> wesnoth/wesnoth#15548 (master - ef23e40 : Charles Dang): The build failed. 20171110 02:14:14< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/299947893 20171110 02:14:14-!- travis-ci [~travis-ci@ec2-54-205-237-128.compute-1.amazonaws.com] has left #wesnoth-dev [] 20171110 02:25:09< irker313> wesnoth: Charles Dang wesnoth:master 68f4d6b290a5 / src/server/server.cpp: Revert a part of ecb72d5 https://github.com/wesnoth/wesnoth/commit/68f4d6b290a58485d0d8a1324742f02f911e25a4 20171110 02:26:52-!- TadCarlucci [~lundberg@74.193.219.119] has joined #wesnoth-dev 20171110 02:27:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20171110 02:29:44< TadCarlucci> Anyone looking at why Travis is unhappy with ecb72d5 in src/server/server.cpp(812) no member 'emplace'? I get clean compiles. 20171110 02:30:43< vultraz> TadCarlucci: so did i, but since travis doesn't like it i just reverted the change to that line 20171110 02:31:12< vultraz> the container is a boost::multi_index, so emplace was probably added in a newer version than it uses, I guess 20171110 02:31:15< TadCarlucci> How odd 20171110 02:31:49< TadCarlucci> And that is the only place we use boost::multi_index? 20171110 02:32:02< celticminstrel> Is it? I don't really know. 20171110 02:32:08< vultraz> no 20171110 02:32:28< celticminstrel> Wasn't it also used for the location map? Or was that a std::multimap? 20171110 02:32:29< vultraz> we use it in quite a few places 20171110 02:32:47< TadCarlucci> Or it's the only place we're looking for emplace on the multi-index, I s'pose. 20171110 02:38:13< irker313> wesnoth: Gregory A Lundberg wesnoth:GL_lua_next 7f98defccde2 / src/scripting/ (lua_common.cpp lua_formula_bridge.cpp lua_kernel_base.cpp): Respect lua_next constraints https://github.com/wesnoth/wesnoth/commit/7f98defccde2d335644342d8ef2336447552974e 20171110 02:38:15< irker313> wesnoth: Gregory A Lundberg wesnoth:GL_lua_next 858240862d1b / src/scripting/lua_kernel_base.cpp: Do not lua_next on userdata. https://github.com/wesnoth/wesnoth/commit/858240862d1b095546c8c026b29e7181f9ac1bb7 20171110 02:39:07< celticminstrel> vultraz: Any chance of changing the "early 2017" release date listed on the Greenlight page? 20171110 02:41:21< TadCarlucci> probably a couple other places say that, too. I seem to recall someone asking on the forum about that 20171110 02:42:59-!- TadCarlucci [~lundberg@74.193.219.119] has quit [Quit: Leaving] 20171110 02:43:40< vultraz> done 20171110 03:10:55-!- Bonobo [~Bonobo@14-203-49-124.tpgi.com.au] has quit [Ping timeout: 248 seconds] 20171110 03:11:52-!- Bonobo [~Bonobo@14-203-49-124.tpgi.com.au] has joined #wesnoth-dev 20171110 03:32:23< irker313> wesnoth: Charles Dang wesnoth:master 457d42f200e0 / / (4 files in 3 dirs): Removed unused sort_list and iconize_list MP preferences https://github.com/wesnoth/wesnoth/commit/457d42f200e0e9ded91ba9f0c53a17750dc5f8ce 20171110 03:42:55-!- Bonobo [~Bonobo@14-203-49-124.tpgi.com.au] has quit [Ping timeout: 248 seconds] 20171110 03:43:23-!- Bonobo [~Bonobo@14-203-49-124.tpgi.com.au] has joined #wesnoth-dev 20171110 03:49:19-!- Bonobo [~Bonobo@14-203-49-124.tpgi.com.au] has quit [Ping timeout: 248 seconds] 20171110 03:49:47-!- Bonobo [~Bonobo@14-203-49-124.tpgi.com.au] has joined #wesnoth-dev 20171110 03:59:12-!- travis-ci [~travis-ci@ec2-54-211-69-243.compute-1.amazonaws.com] has joined #wesnoth-dev 20171110 03:59:13< travis-ci> wesnoth/wesnoth#15552 (master - 68f4d6b : Charles Dang): The build was fixed. 20171110 03:59:13< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/299971359 20171110 03:59:13-!- travis-ci [~travis-ci@ec2-54-211-69-243.compute-1.amazonaws.com] has left #wesnoth-dev [] 20171110 04:45:05-!- travis-ci [~travis-ci@ec2-54-211-69-243.compute-1.amazonaws.com] has joined #wesnoth-dev 20171110 04:45:06< travis-ci> wesnoth/wesnoth#15553 (GL_lua_next - 8582408 : Gregory A Lundberg): The build passed. 20171110 04:45:06< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/299973898 20171110 04:45:06-!- travis-ci [~travis-ci@ec2-54-211-69-243.compute-1.amazonaws.com] has left #wesnoth-dev [] 20171110 04:51:28-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.] 20171110 05:36:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20171110 05:40:47-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds] 20171110 06:03:18-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev 20171110 06:08:49-!- travis-ci [~travis-ci@ec2-54-196-119-170.compute-1.amazonaws.com] has joined #wesnoth-dev 20171110 06:08:50< travis-ci> wesnoth/wesnoth#15555 (master - 457d42f : Charles Dang): The build is still failing. 20171110 06:08:50< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/299986123 20171110 06:08:50-!- travis-ci [~travis-ci@ec2-54-196-119-170.compute-1.amazonaws.com] has left #wesnoth-dev [] 20171110 06:38:51-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20171110 06:42:00-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .] 20171110 07:25:13-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev 20171110 08:09:06-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20171110 08:18:56-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20171110 08:23:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds] 20171110 08:42:12-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev 20171110 08:43:53< vn971> Question to Lua experts: can I access `ai.ai_algorithm` field for a side? `side.ai` and `side.__cfg.ai` seem to be "nil" (even for AI sides). 20171110 08:45:20< vn971> // `side.controller` is still "ai". I just would like to access the algo name. 20171110 08:46:20< amir|2> i don't know the answer but i've written a function the prints tables recursivley for another project: https://github.com/kallaballa/Neurocid/blob/master/lua/ncutils.lua 20171110 08:46:33< amir|2> the function's name is tprint 20171110 08:47:58< vn971> amir|2: well, that won't be useful in my particular case. Thx anyway. 20171110 08:48:00-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20171110 09:13:26-!- irker313 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20171110 09:31:43-!- vladimirslavik [~vslavik@95.82.135.184] has joined #wesnoth-dev 20171110 09:47:55-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20171110 09:48:02-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20171110 10:07:18-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20171110 10:11:43-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds] 20171110 10:32:30< vn971> Where do people usually put addon documentation? What are the best practices? 20171110 10:32:30< vn971> // I'm talking about the docs that a user can see from inside the game. 20171110 10:40:03< zookeeper> you mean like special rules for the scenario and the like? 20171110 10:49:42< zookeeper> "add-on documentation" can mean all sorts of things, because... you know, different kinds of add-ons. 20171110 10:53:12< vn971> zookeeper: yes, I understand your concerns/remarks. I mean scenario description if it's a scenario, or MP Mod description if it's a "mod". (I'm interested in both.) 20171110 10:56:10< zookeeper> well, scenario descriptions can go in the scenario description, but if the scenario has some special mechanics the players would want to be able to review in-game, then the objectives would be a good place for that, and/or a right-click help menu if there's a lot of information. 20171110 10:56:36< zookeeper> doesn't the MP mod list have tooltips to put detailed descriptions in? that would seem like the appropriate place, although of course depending on the mod you might want to still have a message at scenario start or even a right-click help menu. 20171110 10:57:41< zookeeper> i think a lot of scenarios just have a message at startup which describes how things work, but i think you should always have the information available on-demand via aforementioned kinds of ways. 20171110 10:58:16-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 20171110 11:02:03< Soliton> utbs does not have the dehydration mechanic info available on-demand, btw. 20171110 11:02:58< zookeeper> ah, true 20171110 11:03:49< Soliton> i can give some more feedback on the new version if you want. 20171110 11:06:14< vultraz> Soliton: are you satisfied with my changes to that file? 20171110 11:06:34< Soliton> vultraz: yes, looks good. 20171110 11:07:03< Soliton> if someone could check whether wesnoth crashes for them in the last scenario of utbs when Kaleh attacks Eloh that'd be nice. 20171110 11:08:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20171110 11:08:33< zookeeper> Soliton, oh sure, that would be good. not sure how much room there is for big unit changes anymore, but still. 20171110 11:11:58< Soliton> the new unit stats seem fairly nice. i think the sun singer's health is a bit over the top. 20171110 11:12:25< Soliton> i haven't looked too closely though. 20171110 11:13:29< Soliton> in the 3rd scenario Garak's berserk didn't work afaict. 20171110 11:13:50< zookeeper> 50hp, yeah... i have no idea why it's that high 20171110 11:13:55< Soliton> neither on offense nor defense iirc. 20171110 11:14:27< zookeeper> yeah it's actually originally intended to only work against the undead champions/leaders i think, that limitation is just... not mentioned 20171110 11:15:34< zookeeper> the garak stuff is so awkward, but i still have no concrete ideas of how to reshape it 20171110 11:15:53< Soliton> ah, ok. 20171110 11:16:51< Soliton> i think formation might not have worked as expected when there are 3 units together or wasn't displayed correctly. i'd need to check that carefully again though. 20171110 11:17:32< vultraz> garak stuff? 20171110 11:19:37< zookeeper> vultraz, dueling the undead champions, dying in a forced manner no matter what, having a deathwish for no reason 20171110 11:20:23< vultraz> so a writing issue 20171110 11:20:26< zookeeper> of course he still needs to die, but i'd much prefer if i could think of some way to do it in a more appealing manner without all that cheesiness and awkwardness 20171110 11:20:33< zookeeper> writing and scenario design both 20171110 11:20:45< Soliton> in scenario 6a there is mention of poison not being usually used by the elves but now they have regular level 2 units that use poison. 20171110 11:20:58< vultraz> zookeeper: that's s3? 20171110 11:21:01< zookeeper> yes 20171110 11:21:05< vultraz> I'll take a look at it 20171110 11:21:08< zookeeper> Soliton, oh, good catch 20171110 11:23:24< Soliton> it might be nice to somehow explain somewhere that the dust devil and perhaps Kromph don't trigger most events. or give a hint when another unit would have triggered an event. 20171110 11:24:04< Soliton> you're at least quite likely to explore odd locations with the dust devil. 20171110 11:24:25-!- irker610 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20171110 11:24:25< irker610> wesnoth: ln-zookeeper wesnoth:master ec388ebe5595 / data/campaigns/Under_the_Burning_Suns/scenarios/06a_In_the_Tunnels_of_Trolls.cfg: UtBS S06a: Remove mention of use of poison not usually being tolerated https://github.com/wesnoth/wesnoth/commit/ec388ebe559549c1eedf8864f9257c83210709c8 20171110 11:24:38< zookeeper> ran into anything specific that those units didn't trigger? 20171110 11:25:24< Soliton> well, that event you just changed for example. 20171110 11:25:25< zookeeper> most of the exploration moveto stuff should be triggerable by at least the dust devil (someone else will just do the talking), but i suppose there might be a lot of other things that won't be 20171110 11:25:38< zookeeper> oh... yeah 20171110 11:26:05< Soliton> especially in that scenario you can't run around freely with most units. 20171110 11:27:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20171110 11:27:53< Soliton> ah, scenario 4 is quite brutal in the flooding timing if you're not really careful when to trigger the next flooding. i've played on the hardest difficulty. 20171110 11:28:19< Soliton> i think giving the occasional dirt terrain or so in the 1-hex tunnels would make that less frustrating. 20171110 11:29:34< Soliton> i've probably recruited one turn too much but that's something that's quite difficult to judge if you haven't played that scenario recently. 20171110 11:31:10< zookeeper> scenario 4, flooding? 20171110 11:31:51< Soliton> sorry, 8. 20171110 11:31:55< zookeeper> thought so :P 20171110 11:33:42< Soliton> about the ring from sceanrio 4... it'd be nice if Elyssa gave it back when she leaves you. 20171110 11:34:49< zookeeper> right, i guess that's a possibility 20171110 11:36:49< vultraz> zookeeper: man, this is cheesy 20171110 11:37:02< Soliton> the quenoth youth stuff is cool. maybe the XP bar should go to purple when there is just the standard AMLA left. i think it didn't but i only got to that point in the last scenario. 20171110 11:41:05< vultraz> zookeeper: just spitballing here... what if Garak reveals he was seriously wounded in the meteor strike in S1 and can go no further 20171110 11:41:17< vultraz> then we rework the scenario to be less cheesy 20171110 11:41:53< zookeeper> well, that's an idea i haven't thought of, it might work. 20171110 11:42:38< zookeeper> although it's kind of awkward that you can heal people that are 1hp from dying, but somehow this one guy is mysteriously so mortally wounded even at full hp :P 20171110 11:42:58< zookeeper> Soliton, i think i didn't find a way to make the bar purple at that point 20171110 11:43:10< vultraz> zookeeper: gameplay vs story :P 20171110 11:43:43< zookeeper> Soliton, how many advancements have you gotten up until scenario 8 or wherever you are? 20171110 11:44:04< zookeeper> err... all of them, i suppose, judging from the xp bar thing :P 20171110 11:44:44< vultraz> zookeeper: it'd be nice to give the lich guys some more personality than... generic fighting dudes 20171110 11:44:48< Soliton> got the last one for Nym in scenario 11, i think. 20171110 11:45:21< vultraz> or here's a random idea. make one of them tell garak they can tell he is dying, and that for a thousand years two have always faced each other at this spot. now garak will take his place 20171110 11:46:38-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev 20171110 11:47:14< zookeeper> Soliton, right. so maybe the xp requirement should be just a little bit higher, so it would be less likely to actually get all the advancements? it might seem a bit pointless after all, if you usually end up getting everything and only the order in which you get them changes. 20171110 11:48:14< amir|2> is it possible that the parser.cpp code is kinda lossy? when i use it to parse a replay i can't find a current_player attribute anywhere 20171110 11:48:27< vultraz> amir|2: no 20171110 11:48:35< vultraz> zookeeper: and maybe make it the ruins of a former area 20171110 11:48:36< vultraz> arena 20171110 11:48:41< vultraz> so it makes sense for champions to be there 20171110 11:48:47< zookeeper> vultraz, umm, yeah maybe that could be part of it too. and/or garak actually gets poisoned/cursed/possessed/whatever immediately at scenario start because he just happened to be right there in the way when the undead first appear. 20171110 11:50:48< vultraz> amir|2: keep in mind the configs the game handles do not always match those you see in the files 20171110 11:50:55< amir|2> so my traversal code must be at fault. i use cfg.all_children_range() to iterate over nodes and cfg.attribute_range() to iterate over attributes. am i missing something? u can see the code here (line 808-833): https://github.com/kallaballa/WML2XML/blob/master/src/serialization/parser.cpp 20171110 11:53:05< vultraz> not to mention the files read don't contain every key 20171110 11:53:19< vultraz> obviously 20171110 11:54:06< amir|2> but i have files that contain current_player but i can't find it in the config. also the name of the player doesn't show in any other attr 20171110 11:54:20< vn971> zookeeper: well, my scenario is available without user downloads (require_era=no) so I have to show the documentation while being in game already. 20171110 11:54:44< vultraz> hmmm 20171110 11:55:09< vn971> I'll go for "objectives". 20171110 11:55:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20171110 11:56:33< JyrkiVesterinen> amir|2: You're printing attibutes for a wrong config object. 20171110 11:56:46< JyrkiVesterinen> print_attr(cfg); should be print_attr(child.cfg); 20171110 11:58:15< amir|2> oh. -.- 20171110 11:58:16< amir|2> thx! 20171110 12:00:22-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 264 seconds] 20171110 12:02:54< vultraz> zookeeper: the S3 map is very boring :/ 20171110 12:03:07< zookeeper> well that's the smallest problem. 20171110 12:03:45< vultraz> i shall draw you a new map 20171110 12:05:29< amir|2> i fixed the attribute printing bug but still i can't find any attribute containing the name of the player. could it be that it is discarded because it's only a replay and doesn't need the player's name? 20171110 12:05:53< vultraz> what the hell, the editor brushes suddenly don't work 20171110 12:11:05< amir|2> nvm... i misunderstood the data structures 20171110 12:54:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20171110 12:57:43< Soliton> zookeeper: well, i was playing on highest difficulty so got a lot of XP and was specifically farming XP so reaching everything in the last level (which i didn't manage with Kaleh) seems fine. 20171110 13:01:25-!- travis-ci [~travis-ci@ec2-54-196-119-170.compute-1.amazonaws.com] has joined #wesnoth-dev 20171110 13:01:26< travis-ci> wesnoth/wesnoth#15556 (master - ec388eb : ln-zookeeper): The build has errored. 20171110 13:01:26< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/300119009 20171110 13:01:26-!- travis-ci [~travis-ci@ec2-54-196-119-170.compute-1.amazonaws.com] has left #wesnoth-dev [] 20171110 13:09:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20171110 13:09:42-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20171110 13:20:17< vn971> Another question if you don't mind. In Lua, methods like `wesnoth.get_units` can return units. Now, can I modify max_hitpoints of the returned units? wiki says "No" and experiments on wesnoth-1.13 say "No". The question is - why? Is that on purpose? Should I add an [object] to the unit in order to modify its max_hitpoints? 20171110 13:25:11< JyrkiVesterinen> Use add_modification() if you want to change maximum hitpoints. 20171110 13:25:12< JyrkiVesterinen> https://wiki.wesnoth.org/LuaWML/Units#wesnoth.add_modification 20171110 13:30:13< vn971> JyrkiVesterinen: well yes, that's basically [object]. OK cool, just wanted to check out that I don't miss anything. Thanks! 20171110 13:31:11-!- Bonobo [~Bonobo@14-203-49-124.tpgi.com.au] has quit [Ping timeout: 248 seconds] 20171110 13:53:59< zookeeper> Soliton, oh okay. yeah, makes sense. 20171110 14:03:55-!- DeFender [~DeFender1@46-116-196-40.bb.netvision.net.il] has quit [Quit: I'm not back now.] 20171110 14:13:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20171110 14:24:59-!- irker610 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20171110 14:30:43< vn971> hmm. On wesnoth-1.12, this filter doesn't actually filter anything on `max_moves`: wesnoth.get_units { canrecruit = true, max_moves = 0 } 20171110 14:31:17< vn971> I can't understand why it's gives the wrong stuff without any errors. 20171110 14:32:44< vn971> * same on wesnoth-1.13. The code above discards my `max_moves` filtering and returns an array of all units that satisfy other criteria. 20171110 14:33:08< zookeeper> i'm not seeing max_moves on https://wiki.wesnoth.org/StandardUnitFilter 20171110 14:34:03< vn971> zookeeper: oops, indeed. Thanks. Is it OK that there was no error either? 20171110 14:34:16< vn971> (It might be, IDK.) 20171110 14:34:17< zookeeper> yes 20171110 14:34:26< vn971> zookeeper: ok, thx again. 20171110 14:34:33< zookeeper> so what you want is put that in a [filter_wml] subtag 20171110 14:34:52< Ravana_> or formula 20171110 14:35:50< vn971> I assumed that the `get_units` filter operates on `unit` fields. But it's clearly documented to be a "single unit filter", so no problems. 20171110 14:36:32< vn971> zookeeper: since I'm in Lua, I'd just prefer to have an inner `if unit.max_moves == 0 then ...` 20171110 14:45:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20171110 15:04:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20171110 15:19:08-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .] 20171110 15:19:18-!- amir|2 [~amir@212-88-19-7.hdsl.highway.telekom.at] has quit [Ping timeout: 252 seconds] 20171110 15:52:18-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20171110 15:53:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20171110 16:33:44-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Read error: Connection reset by peer] 20171110 16:34:18-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20171110 17:10:39-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity] 20171110 17:27:10-!- amir|2 [~amir@public.metalab.wien.funkfeuer.at] has joined #wesnoth-dev 20171110 17:27:37< amir|2> what kind of statistics generatable from replays would _you_ like to see? 20171110 17:30:28< Ravana_> common modifications per scenario 20171110 17:30:49< amir|2> thx. nice idea 20171110 17:31:47< Ravana_> that question would likely get more responses from non-dev channel 20171110 17:40:10< amir|2> i'll ask there 20171110 18:00:23-!- amir|2 [~amir@public.metalab.wien.funkfeuer.at] has quit [Read error: No route to host] 20171110 18:07:33-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev 20171110 19:15:41-!- vladimirslavik [~vslavik@95.82.135.184] has quit [Quit: Leaving] 20171110 20:02:13-!- sigurdfd [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev 20171110 20:35:10-!- mjs-de [~mjs-de@x4e304825.dyn.telefonica.de] has joined #wesnoth-dev 20171110 21:26:31-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .] 20171110 21:27:07-!- mjs-de [~mjs-de@x4e304825.dyn.telefonica.de] has quit [Remote host closed the connection] 20171110 21:41:19-!- Bonobo [~Bonobo@14-203-49-124.tpgi.com.au] has joined #wesnoth-dev 20171110 22:35:17-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev 20171110 23:10:27-!- gfgtdf [~chatzilla@x4e368da8.dyn.telefonica.de] has joined #wesnoth-dev 20171110 23:11:31-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds] 20171110 23:20:42-!- sigurdfd [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has quit [] 20171110 23:45:50-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] --- Log closed Sat Nov 11 00:00:13 2017