--- Log opened Sun Nov 12 00:00:14 2017
20171112 00:07:01-!- Rhonda [~rhonda@anguilla.debian.or.at] has quit [Ping timeout: 240 seconds]
20171112 00:07:09-!- Rhonda [~rhonda@anguilla.debian.or.at] has joined #wesnoth-dev
20171112 00:17:14-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20171112 00:23:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 258 seconds]
20171112 00:23:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171112 00:42:15-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20171112 01:32:44-!- celmin|away is now known as celticminstrel
20171112 02:09:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20171112 02:15:31-!- irker221 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171112 02:15:31< irker221> wesnoth: doofus-01 wesnoth:master 75a52bd9c60c / data/core/ (147 files in 5 dirs): Three carpet terrains  (#2114) https://github.com/wesnoth/wesnoth/commit/75a52bd9c60c0e65ac3a52e8fe6f79280242cbb0
20171112 02:51:27-!- gfgtdf_ [~chatzilla@x4e32b4d1.dyn.telefonica.de] has joined #wesnoth-dev
20171112 02:54:50-!- gfgtdf [~chatzilla@x4e3633a4.dyn.telefonica.de] has quit [Ping timeout: 268 seconds]
20171112 02:54:52-!- gfgtdf_ is now known as gfgtdf
20171112 03:10:10-!- gfgtdf [~chatzilla@x4e32b4d1.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 56.0.2/20171024165158]]
20171112 03:36:43< irker221> wesnoth: sigurdfdragon wesnoth:master 9629b59d4a35 / data/campaigns/Heir_To_The_Throne/scenarios/20b_Underground_Channels.cfg: HttT S20b: Set time areas for inside and outside of caves https://github.com/wesnoth/wesnoth/commit/9629b59d4a355938f90fec805432eb685cbf8c22
20171112 03:36:45< irker221> wesnoth: sigurdfdragon wesnoth:master 2fe0ebe48cad / data/campaigns/Heir_To_The_Throne/scenarios/20b_Underground_Channels.cfg: HttT S20b: Fix punctuation https://github.com/wesnoth/wesnoth/commit/2fe0ebe48cad3a6803a50cb502719d1551130c91
20171112 03:36:47< irker221> wesnoth: sigurdfdragon wesnoth:master 28dad5b425bf / data/campaigns/Heir_To_The_Throne/scenarios/20b_Underground_Channels.cfg: HttT S20b: Fix team name https://github.com/wesnoth/wesnoth/commit/28dad5b425bf0004947cb90d3e56b3ea9b902a74
20171112 03:36:49< irker221> wesnoth: sigurdfdragon wesnoth:master 1f77738ef33f / data/campaigns/Heir_To_The_Throne/scenarios/20b_Underground_Channels.cfg: HttT S20b: Adjust Saurian gold & income now that there is underground time https://github.com/wesnoth/wesnoth/commit/1f77738ef33f4f8c4098964b857e3383957d33c7
20171112 03:36:51< irker221> wesnoth: sigurdfdragon wesnoth:master 61c33f9c4c17 / data/campaigns/Heir_To_The_Throne/scenarios/19c_Cliffs_of_Thoria.cfg: HttT S19c: Give player a head start on leveling the sergeant https://github.com/wesnoth/wesnoth/commit/61c33f9c4c170d75d37a5586f089810f4603690a
20171112 03:40:55-!- travis-ci [~travis-ci@ec2-107-22-87-194.compute-1.amazonaws.com] has joined #wesnoth-dev
20171112 03:40:56< travis-ci> wesnoth/wesnoth#15566 (master - 75a52bd : doofus-01): The build has errored.
20171112 03:40:56< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/300797868
20171112 03:40:56-!- travis-ci [~travis-ci@ec2-107-22-87-194.compute-1.amazonaws.com] has left #wesnoth-dev []
20171112 04:29:29-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20171112 04:37:35< irker221> wesnoth: Charles Dang wesnoth:master a2327fa1993c / src/editor/ (4 files in 2 dirs): Revert "Remove an unnecessary layer of indirection" https://github.com/wesnoth/wesnoth/commit/a2327fa1993c9ce84f1cf1c3a3c442f1a4e8eca2
20171112 04:37:37< vultraz> AI0867: ^
20171112 04:53:52< irker221> wesnoth: Charles Dang wesnoth:master 87ca6135b1a9 / src/editor/controller/editor_controller.cpp: Editor: don't refer to 'this map' in quit prompt if current map is not modified https://github.com/wesnoth/wesnoth/commit/87ca6135b1a9071097e8330a09e7c443fad3a16e
20171112 05:00:34< irker221> wesnoth: Charles Dang wesnoth:master 417134a94291 / data/campaigns/Eastern_Invasion/maps/Throne_Room.map: EI: further improvements to throne room map https://github.com/wesnoth/wesnoth/commit/417134a9429105191ff9aa20800533f98d603ed0
20171112 05:08:43< celticminstrel> Just FTR vultraz, you can probably in theory change it to a reference-to-pointer if that makes you feel a bit better.
20171112 05:08:55< celticminstrel> And AI0867 I guess.
20171112 05:09:08< vultraz> I'm not sure why it doesn't use ** 
20171112 05:09:14< celticminstrel> Huh?
20171112 05:09:16< vultraz> it uses const T* const * const 
20171112 05:09:30< celticminstrel> Huh.
20171112 05:09:37< celticminstrel> That seems a bit...
20171112 05:10:34< celticminstrel> Well, the final *const can most likely be replaced by a reference, but I wonder if you could do even more...
20171112 05:10:57< celticminstrel> *const is semantically identical to a reference.
20171112 05:11:14< celticminstrel> (Though obviously it's syntactically different.)
20171112 05:15:05< celticminstrel> So for a first step you can probably change "const brush*const*const" to "const brush*const&".
20171112 05:17:09< celticminstrel> I see, so basically the actual brush objects are held in an array in editor_toolkit, with a pointer to the current brush, and then the mouse_actions require a reference to that pointer. It does make sense, I guess.
20171112 05:17:37< celticminstrel> I can't think of a better way to do it off the top of my head.
20171112 05:17:55< celticminstrel> In any case, all those consts just means that you can't modify anything about the brush from the mouse_action.
20171112 05:18:31< celticminstrel> Hmmmmmm...
20171112 05:20:16< celticminstrel> The mouse_actions are basically referencing a piece of the editor_toolkit. All mouse_actions that have a brush will have the exact same value for that member (assuming there's only a single editor_toolkit, no idea if that's true).
20171112 05:21:14< celticminstrel> Anyway, I think changing "const brush*const*const" to "const brush*const&" seems like a good idea, but I'll let you and AI0867 make the final decision on that, I guess.
20171112 06:00:36-!- celticminstrel is now known as celmin|sleep
20171112 07:29:04-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20171112 08:06:40-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20171112 08:30:26-!- irker221 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20171112 08:40:52< vultraz> zookeeper: did i ever impalement a way to hide map borders?
20171112 08:44:16< zookeeper> i doubt it
20171112 08:45:23< zookeeper> but if you want to, i can tell you how it should work internally.
20171112 08:55:04-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20171112 08:58:03< vn971> zookeeper: thank you!
20171112 08:58:03< vn971> If anything, I've added mentions of pango here: https://wiki.wesnoth.org/index.php?title=Referencewml&diff=59010&oldid=58713  hope it's all right.
20171112 08:58:30-!- amir|2 [~amir@212-88-19-7.hdsl.highway.telekom.at] has quit [Ping timeout: 252 seconds]
20171112 09:00:33-!- amir|2 [~amir@212-88-19-7.hdsl.highway.telekom.at] has joined #wesnoth-dev
20171112 10:10:56< AI0867> vultraz: could you explain where removing that layer of indirection broke things? I don't see how a const pointer to const pointer to const could be used for selection
20171112 10:12:22< vultraz> AI0867: i don't know
20171112 10:12:26< vultraz> it just did
20171112 10:13:34< vultraz> AI0867: i think what happens was the tool pointed to the initial value of `brush_`, in this case, `brushes_[0]`
20171112 10:14:04< vultraz> in editor_toolkit, it's just a `brush*` pointer
20171112 10:14:07< vultraz> so it can change
20171112 10:14:27< vultraz> the selection tool needed a const pointer to the pointer in the toolkit class
20171112 10:15:02< vultraz> so when that pointer changed by selecting different brushes, and then the selection tool's ptr was dereferenced twice, you ended up with the right brush
20171112 10:15:53< vultraz> so with your change, instead of pointing to the thing that changed, it pointed to the initial brush
20171112 10:23:50< AI0867> ah, I had gotten the ownership backwards
20171112 10:24:05< AI0867> now I see what happened
20171112 10:25:06< AI0867> I had originally intended to refactor the editor_toolkit's brush bits too, so they might not have been in the orignal state when I was looking at the editor actions
20171112 10:31:10-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20171112 10:34:49< AI0867> celmin|sleep: I agree, but I'm trying to see if there isn't a better solution
20171112 10:42:52< amir|2> I'm not done with importing all the data but for now some intermediate results: http://185.203.117.150:8000/playerscnt.html http://185.203.117.150:8000/mapscnt.html
20171112 11:17:00-!- aeth_ [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20171112 11:17:31-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 240 seconds]
20171112 11:28:13-!- amir|2 [~amir@212-88-19-7.hdsl.highway.telekom.at] has quit [Read error: No route to host]
20171112 11:36:02-!- amir|2 [~amir@212-88-19-7.hdsl.highway.telekom.at] has joined #wesnoth-dev
20171112 11:37:28< amir|2> I just plotted the data. poth player count and scenario count are pretty much logarithmic :)
20171112 12:15:55-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20171112 12:18:42-!- amir|2 [~amir@212-88-19-7.hdsl.highway.telekom.at] has quit [Ping timeout: 252 seconds]
20171112 12:27:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171112 12:47:06-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20171112 13:02:15-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20171112 13:02:23-!- amir|2 [~amir@public.metalab.wien.funkfeuer.at] has joined #wesnoth-dev
20171112 13:06:32-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20171112 13:08:13< vultraz> zookeeper: btw, you said last year you were going to consider if we should replace the fake shroud terrain with the one from AtS/IftU
20171112 13:20:58< zookeeper> i did?
20171112 13:21:07< vultraz> you did
20171112 13:21:14< vultraz> because the current fake shroud is useless
20171112 13:21:23< vultraz> i wanted to replace it with a fake shroud that looked like shroud
20171112 13:23:26< zookeeper> yeah, i totally agree. however, a lot of map makers (for reasons completely beyond me) prefer to use a lot of void, and i'm not sure if shroud is used similarly a lot. so i'm not sure if you'd get some protestation or not.
20171112 13:23:48< vultraz> shrug
20171112 13:23:50< vultraz> let them complain
20171112 13:24:10< zookeeper> i wonder if there should be some kind of small telltale sign to make it possible to distinquish between real shroud and fake shroud.
20171112 13:25:09< vultraz> don't think so
20171112 13:28:10< zookeeper> i'll look at it in a while, have to do some eating and stuff first
20171112 13:33:45< amir|2> for isar's blasphemy i had to choose void because the ai would sometimes still be attracted to units in another section. somehow it (used to?) regard fake shroud as walkable
20171112 13:34:32-!- irker816 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171112 13:34:32< irker816> wesnoth: pentarctagon wesnoth:master c9c0a9e76292 / CMakeLists.txt: Add extra_flags to cmake. https://github.com/wesnoth/wesnoth/commit/c9c0a9e7629271b66567469257ef7490f805a126
20171112 14:18:46< AI0867> celmin|sleep: Replacing const brush * const * const → const brush * const * has been giving me some issues
20171112 14:19:05< AI0867> the editor kept segfaulting, and debugging showed that somehow the pointer reference was modified somewhere
20171112 14:19:27< AI0867> I added debug prints to every stage and now the pointer reference no longer changes...
20171112 14:19:51< JyrkiVesterinen> Use a watchpoint?
20171112 14:23:24< AI0867> I've had serious trouble getting those to work in the past
20171112 14:49:50-!- vn971 [~vasya@94.158.103.15] has quit [Quit: Leaving.]
20171112 15:32:49 * celmin|sleep assumes you mean const brush*const&
20171112 15:33:43< celmin|sleep> AI0867: The reason the change broke things is because, although it's const, it points to an area that's changed externallt.
20171112 15:33:46< celmin|sleep> ^externally
20171112 15:39:47-!- celmin|sleep is now known as celticminstrel
20171112 15:48:52< AI0867> celticminstrel: yes, I've figured that part out. However, in my local code the actions now hold a const reference to the pointer member of editor_toolkit
20171112 16:06:57< AI0867> ah, I see I made a typo earlier. I meant: const brush*const*const → const brush*const&
20171112 16:07:20< AI0867> shouldn't those effectively be the same, just with different syntax?
20171112 16:21:01< celticminstrel> Yes.
20171112 16:21:16< celticminstrel> Which is why I'm confused that you say it's causing segfaults.
20171112 16:33:39< AI0867> as am I
20171112 16:43:20-!- irker816 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20171112 16:45:19-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20171112 16:58:21-!- mjs-de [~mjs-de@x4e30246c.dyn.telefonica.de] has joined #wesnoth-dev
20171112 17:21:28-!- irker263 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171112 17:21:28< irker263> wesnoth: Jyrki Vesterinen wesnoth:master f065b91708ac / src/display.cpp: Stop creating invisible pseudo-haloes for [item]s https://github.com/wesnoth/wesnoth/commit/f065b91708ace35e325e753b1c84e9b2075ba153
20171112 17:21:28< irker263> wesnoth: Jyrki Vesterinen wesnoth:master 80d42597b8eb / src/halo.cpp: Remove new_haloes https://github.com/wesnoth/wesnoth/commit/80d42597b8eb701e3cef40c7890fcb0bc402450e
20171112 17:28:16-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20171112 17:30:37< irker263> wesnoth: mattsc wesnoth:master e0899d5b81a5 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update Xcode project https://github.com/wesnoth/wesnoth/commit/e0899d5b81a583ca814b477c01f7a04e395e7242
20171112 17:38:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171112 17:38:41-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171112 18:12:50-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20171112 18:20:13-!- EliDupree2 [~quassel@2604:a880:400:d0::9bb:2001] has quit [Remote host closed the connection]
20171112 18:20:41-!- EliDupree [~quassel@2604:a880:400:d0::9bb:2001] has joined #wesnoth-dev
20171112 18:37:06-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20171112 19:29:57-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20171112 19:54:05-!- aeth_ [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 240 seconds]
20171112 19:56:04-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20171112 19:59:00-!- mjs-de [~mjs-de@x4e30246c.dyn.telefonica.de] has quit [Remote host closed the connection]
20171112 19:59:07-!- atarocch [~atarocch@93.56.164.28] has quit [Ping timeout: 268 seconds]
20171112 20:10:40-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20171112 20:14:27-!- amir|2 [~amir@public.metalab.wien.funkfeuer.at] has quit [Ping timeout: 252 seconds]
20171112 20:37:48-!- irker263 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20171112 21:20:05-!- amir|2 [~amir@212-88-19-7.hdsl.highway.telekom.at] has joined #wesnoth-dev
20171112 21:46:56< AI0867> celticminstrel, JyrkiVesterinen: well, the watchpoint never triggered. Here's a condensed version of my (last) gdb session: https://pastebin.com/9zvAMJ4x
20171112 21:55:35-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: Going to bed]
20171112 22:33:47< celticminstrel> Not sure how to interpret that...
20171112 22:43:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171112 22:43:42-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171112 22:44:16-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20171112 23:07:10-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:e192:d792:db8c:eb3e] has joined #wesnoth-dev
20171112 23:28:43-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20171112 23:33:21-!- irker724 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171112 23:33:22< irker724> wesnoth: doofus-01 wesnoth:master e02c4a140db7 / data/core/images/terrain/interior/regular-rug/ (7 files): adjust outer edges to avoid borders overlapping interior https://github.com/wesnoth/wesnoth/commit/e02c4a140db7c3f530e073e1328ddc851f17f84c
20171112 23:33:23< irker724> wesnoth: doofus-01 wesnoth:master 58ff9c42c86e / data/core/ (images/terrain/interior/carpet_mask.png terrain-graphics/new-macros.cfg): hack to keep carpets from spilling into castles https://github.com/wesnoth/wesnoth/commit/58ff9c42c86efd62f0598388c174e61ee990ded2
20171112 23:33:25< irker724> wesnoth: doofus-01 wesnoth:master a59965c591fe / data/core/images/terrain/interior/regular-rug/ (8 files): clipping upper tips of diagonal borders to deal with overlap https://github.com/wesnoth/wesnoth/commit/a59965c591feeeb90c75e659c65211997cd0c9f6
20171112 23:41:09-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:e192:d792:db8c:eb3e] has quit [Quit: Leaving]
20171112 23:49:45-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 268 seconds]
20171112 23:49:58< irker724> wesnoth: Charles Dang wesnoth:master 25eb7a69be47 / src/editor/controller/editor_controller.cpp: Fixed context menus not working in the editor (fixes #2183) https://github.com/wesnoth/wesnoth/commit/25eb7a69be475176420d5b8f424d66fefcbe38b4
20171112 23:51:17< vultraz> celticminstrel: is tad's lua_next PR good to merge?
20171112 23:56:10-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
--- Log closed Mon Nov 13 00:00:15 2017