--- Log opened Mon Nov 13 00:00:15 2017
20171113 00:32:29< irker724> wesnoth: doofus-01 wesnoth:master 0857a5a01ec1 / data/core/terrain-graphics/new-macros.cfg: changing castle-wall layering when next to Xos https://github.com/wesnoth/wesnoth/commit/0857a5a01ec1903ca19d178e5de762d9d37d66b9
20171113 01:08:07-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171113 01:08:14-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171113 01:18:21< irker724> wesnoth: Charles Dang wesnoth:master b56fb67c4fb8 / src/gui/widgets/ (listbox.cpp listbox.hpp scrollbar_container.cpp): GUI2: moved some listbox-specific code out of scrollbar_container and into listb https://github.com/wesnoth/wesnoth/commit/b56fb67c4fb8508fe4b528e37780eefd8655866c
20171113 01:30:30< irker724> wesnoth: doofus-01 wesnoth:master 70e1447366ea / data/core/terrain-graphics/new-macros.cfg: more changes to castle to wall layering https://github.com/wesnoth/wesnoth/commit/70e1447366ea6bbb69aa3249d6c30babf72309ab
20171113 01:49:00< irker724> wesnoth: Gregory A Lundberg wesnoth:master fc21ebf1bebe / src/scripting/ (lua_common.cpp lua_formula_bridge.cpp lua_kernel_base.cpp): Respect lua_next constraints https://github.com/wesnoth/wesnoth/commit/fc21ebf1bebe1681bfff8075cde3e4143e6ace0b
20171113 01:49:02< irker724> wesnoth: Gregory A Lundberg wesnoth:master 44526a4bade4 / src/scripting/lua_kernel_base.cpp: Do not lua_next on userdata. https://github.com/wesnoth/wesnoth/commit/44526a4bade418c03f6bdfc085bacd15ab619398
20171113 01:49:03< celticminstrel> vultraz: ^
20171113 01:49:12< vultraz> \o/
20171113 01:50:46< vultraz> might be worth a changelog entry
20171113 02:35:15-!- travis-ci [~travis-ci@ec2-54-162-155-110.compute-1.amazonaws.com] has joined #wesnoth-dev
20171113 02:35:16< travis-ci> wesnoth/wesnoth#15578 (master - b56fb67 : Charles Dang): The build passed.
20171113 02:35:16< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/301156199
20171113 02:35:16-!- travis-ci [~travis-ci@ec2-54-162-155-110.compute-1.amazonaws.com] has left #wesnoth-dev []
20171113 02:40:06< vultraz> celticminstrel: what's the concat WFL again?
20171113 03:13:50-!- travis-ci [~travis-ci@ec2-54-205-116-35.compute-1.amazonaws.com] has joined #wesnoth-dev
20171113 03:13:51< travis-ci> wesnoth/wesnoth#15580 (master - 44526a4 : Gregory A Lundberg): The build passed.
20171113 03:13:51< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/301164190
20171113 03:13:51-!- travis-ci [~travis-ci@ec2-54-205-116-35.compute-1.amazonaws.com] has left #wesnoth-dev []
20171113 03:21:34< celticminstrel> vultraz: Same as Lua
20171113 03:26:18-!- sigurdfd [sigurdfd@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20171113 03:28:34< vultraz> hmm ok 
20171113 03:28:38< vultraz> nod nod nod
20171113 03:31:40< irker724> wesnoth: josteph wesnoth:master 408163e5984a / data/campaigns/Two_Brothers/scenarios/03_Guarded_Castle.cfg: AToTB S03: Tweak hint to not assume the AI will make mistakes https://github.com/wesnoth/wesnoth/commit/408163e5984ac0022b919cdb6053c863a875e047
20171113 03:36:08< irker724> wesnoth: sigurdfdragon wesnoth:master b8c90c0fad5d / data/campaigns/Heir_To_The_Throne/scenarios/19c_Cliffs_of_Thoria.cfg: Fixup 61c33f9 https://github.com/wesnoth/wesnoth/commit/b8c90c0fad5d11cffa9249ef0bda2fb9f440eb8b
20171113 03:43:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20171113 04:20:21 * vultraz is working on greatly reducing the number of button definitons
20171113 04:20:38< celticminstrel> Why?
20171113 04:20:52< celticminstrel> It sounds like an enormous waste of time TBH.
20171113 04:22:29< vultraz> :|
20171113 04:22:38< vultraz> why you gotta be so negative all the time
20171113 04:22:54< celticminstrel> I don't think I'm negative all the time. Sometimes, sure.
20171113 04:35:04< vultraz> anyway, I'm doing it since it's ridiculous to have to replicate a whole button definition just for one overlay
20171113 04:35:15< celticminstrel> Eh?
20171113 04:36:16< vultraz> right now, for every button variant, even if it's just a different overlay, we have to create a new button definition in WML
20171113 04:36:33< celticminstrel> I'm not even quite sure what you mean by overlay here.
20171113 04:36:45< vultraz> button icons
20171113 04:36:52< celticminstrel> Well no, that's too mild. I have no idea what you— ah okay.
20171113 04:37:23< celticminstrel> Okay, yeah, I guess that's true then.
20171113 04:37:47< celticminstrel> You could make a subclass of button that has its "overlay" specified by the label key or something?
20171113 04:38:24< celticminstrel> Not sure, maybe you could even just make an "icon-button" definition that has its "overlay" specified by an extra icon key.
20171113 04:38:54< celticminstrel> But I think GUI2 is set to ignore unknown keys (or worse, error).
20171113 04:39:31< celticminstrel> Oh, but you could have an "icon-button" definition that has its "overlay" specified by the label key, right?
20171113 04:39:48< celticminstrel> Or maybe you've thought of something even better, I dunno.
20171113 04:39:51< vultraz> yes, im essentially doing that
20171113 04:40:14< celticminstrel> The icon technically is the button's label in any case.
20171113 04:41:36< vultraz> hm..
20171113 04:41:50< vultraz> i actually hadn't considered that?
20171113 04:41:51< vultraz> hmmmm
20171113 04:42:04< celticminstrel> I thought you just said that was what you were doing. >_>
20171113 04:42:15< vultraz> i was just going with a special definition that draws an image over the base and an "overlay" WFL variable
20171113 04:42:17< celticminstrel> But I guess "essentially" can carry a lot of hidden meaning.
20171113 04:42:28< vultraz> and the usecases have an overlay= key
20171113 04:42:51< celticminstrel> I just want to point out that "overlay" is a terrible name for this.
20171113 04:43:29< celticminstrel> There is some sense in extending the button schema to allow a separate icon key, though - in theory, one might want a button that has both text and an icon.
20171113 04:43:50< vultraz> it could be done
20171113 04:44:04< celticminstrel> I don't think Wesnoth has any use case for such things, but I'm sure add-on devs could find a use for it.
20171113 04:44:28< vultraz> anyway, right now just working on converting all special button definitions into a single definition with an overlay= key
20171113 04:44:33< vultraz> (key name subject to change)
20171113 04:44:38< celticminstrel> I don't actually fully understand what you meant with the special definition and the WFL variable, not that it matters.
20171113 04:44:51< celticminstrel> As for the key name, I strongly recommend "icon".
20171113 04:45:00< vultraz> probably
20171113 04:45:13< vultraz> I also need to figure out how to manipulate strings in WFL
20171113 04:45:51< vultraz> such as insert another string in the middle..
20171113 04:46:05< celticminstrel> https://wiki.wesnoth.org/Wesnoth_Formula_Language#Strings https://wiki.wesnoth.org/Wesnoth_Formula_Language#String_Functions
20171113 04:46:08< vultraz> ie, if the key has foo/bar.png but I want to process it as foo/bar-active.png
20171113 04:46:14< celticminstrel> We can actually remove the concatenate function, I guess...
20171113 04:46:46< celticminstrel> For inserting a prefix prior to the file extension I think I would recommend the replace function.
20171113 04:47:25< celticminstrel> Though you could also do it with substring and concatenation.
20171113 04:47:35< celticminstrel> Well okay, we can't remove the concatenate function until 1.15 though.
20171113 04:47:40< vultraz> why?
20171113 04:47:47< vultraz> oh, its not new
20171113 04:47:53< celticminstrel> Unless we can prove no-one uses it, I suppose.
20171113 04:47:59< vultraz> could grep
20171113 04:48:03< celticminstrel> Which frankly wouldn't surprise me.
20171113 04:48:16< vultraz> ok,so...
20171113 04:48:42< vultraz> replace('foo/bar.png', -4, 0, '-active') would equal 'foo/bar-active.png'?
20171113 04:48:48< celticminstrel> Regardless of whether you use replace or substring, you'll also need find_string.
20171113 04:49:25< celticminstrel> I think that would work, with the caveat that I'm not sure if replace can handle a zero lengthy.
20171113 04:49:28< celticminstrel> ^-y
20171113 04:49:37< celticminstrel> Go ahead and try it in-game in the formula console?
20171113 04:50:31< vultraz> could you maybe add me an insert function?
20171113 04:51:00< celticminstrel> Can you at least try and see if it works first?
20171113 04:51:13< vultraz> i can't open wesnoth right now
20171113 04:51:17< celticminstrel> ...
20171113 04:51:20< vultraz> button wml in shambles
20171113 04:51:59< celticminstrel> Well, anyway, adding an insert isn't a terrible idea. Maybe I'll do it, or you could probably even do it yourself by basically copying and tweaking the replace function.
20171113 04:52:24< celticminstrel> You'd probably want to use string::insert rather than string::replace, mind you.
20171113 04:53:27< celticminstrel> I think maybe I should also add find_glob and find_re/find_regex/
20171113 04:53:54< celticminstrel> And similarly, variants of contains_string.
20171113 05:01:41-!- sigurdfd [sigurdfd@dynamic-acs-72-23-110-196.zoominternet.net] has quit []
20171113 05:02:45< vultraz> celticminstrel: I'll leave that all to you
20171113 05:02:59< vultraz> including deprecating/removing concatenate 
20171113 05:14:15< vultraz> celticminstrel: this look good? name = "(replace(overlay, find_string('.'), 0, '-active'))"
20171113 05:14:49< celticminstrel> Somewhat?
20171113 05:15:06< celticminstrel> I think that would actually give you foo/bar.-activepng though
20171113 05:15:35< vultraz> hmm
20171113 05:15:37< vultraz> I'll have to see
20171113 05:15:37< celticminstrel> Might beed to use 1 as the length and include the period in the replacement.
20171113 05:15:41< celticminstrel> ^need
20171113 05:15:45< celticminstrel> Yeah, sure.
20171113 05:16:25< vultraz> should probably add an if-not-empty check..
20171113 05:16:43< vultraz> "(if(overlay != '', replace(overlay, find_string('.'), 0, '-active')))"
20171113 05:56:02-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20171113 06:03:38-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20171113 06:40:20-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20171113 06:49:10-!- irker724 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20171113 06:50:23-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20171113 06:57:40-!- nore [~ncourant@sas.eleves.ens.fr] has quit [Quit: WeeChat 1.8]
20171113 07:02:42< Ivanovic> celticminstrel: yes, people ficing typos should add this entry to the typo fix script as well
20171113 07:03:22< Ivanovic> and also run the pofix.py script on the whole po/ folder to fix all cases
20171113 07:22:56-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20171113 07:31:04< vultraz> alright, I have this mostly working
20171113 07:31:16< vultraz> now to see if i can unify this with the procedural button drawing..
20171113 08:10:41-!- nore [~ncourant@sas.eleves.ens.fr] has joined #wesnoth-dev
20171113 08:23:49-!- atarocch [~atarocch@93.56.164.28] has quit [Remote host closed the connection]
20171113 08:25:41-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20171113 08:29:19-!- vladimirslavik [~vslavik@95.82.135.184] has joined #wesnoth-dev
20171113 08:42:51-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171113 08:42:58-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171113 10:32:14-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20171113 10:47:35-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 240 seconds]
20171113 10:59:57-!- amir|2 [~amir@212-88-19-7.hdsl.highway.telekom.at] has quit [Ping timeout: 252 seconds]
20171113 11:16:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171113 11:46:13-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20171113 11:50:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20171113 11:50:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171113 11:56:53-!- amir|2 [~amir@public.metalab.wien.funkfeuer.at] has joined #wesnoth-dev
20171113 12:25:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20171113 12:26:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171113 12:26:35-!- Rhonda [~rhonda@anguilla.debian.or.at] has quit [Changing host]
20171113 12:26:35-!- Rhonda [~rhonda@wesnoth/developer/rhonda] has joined #wesnoth-dev
20171113 12:47:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 250 seconds]
20171113 12:47:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171113 12:59:32-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20171113 13:21:45-!- amir|2 [~amir@public.metalab.wien.funkfeuer.at] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/]
20171113 13:21:57-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev
20171113 13:22:02-!- amir|2 [~amir@public.metalab.wien.funkfeuer.at] has joined #wesnoth-dev
20171113 14:43:48-!- amir|2 [~amir@public.metalab.wien.funkfeuer.at] has quit [Ping timeout: 252 seconds]
20171113 14:58:23-!- gfgtdf [~chatzilla@x4e3686b9.dyn.telefonica.de] has joined #wesnoth-dev
20171113 14:58:41< gfgtdf> the latest appveyor buidl is 5 days old (f1749c8d9b7a7a684cb00dd3d038cca473a52660) does anyone kow why that is ?
20171113 15:06:40< JyrkiVesterinen> gfgtdf: "Scheduled builds are not enabled for your account. Please contact AppVeyor support to enable this feature."
20171113 15:07:04< JyrkiVesterinen> Looks like AppVeyor has blocked our account from scheduling builds...
20171113 15:11:39< gfgtdf> seems liek we are not the onle ones with that problem see https://help.appveyor.com/discussions/questions/13126-can-i-have-scheduled-builds-enabled and https://webcache.googleusercontent.com/search?q=cache:xbbxDVmpsIAJ:https://help.appveyor.com/discussions/problems/9724-scheduled-builds-are-not-enabled-for-your-account-please-contact-appveyor-support-to-enable-this-feature+&cd=1&hl=de&ct=clnk&gl=d
20171113 15:11:41< gfgtdf> e&client=firefox-b
20171113 15:12:14< gfgtdf> like*
20171113 15:12:28< gfgtdf> (second link it cut off but it'll still work)
20171113 15:12:59< gfgtdf> is*
20171113 15:14:06-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: Going home]
20171113 15:19:46< gfgtdf> JyrkiVesterinen : ok this seems to be the casue https://www.appveyor.com/blog/2017/11/08/sheduled-builds-for-free-accounts/
20171113 15:44:47-!- amir|2 [~amir@80-110-85-87.cgn.dynamic.surfer.at] has joined #wesnoth-dev
20171113 15:52:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20171113 16:18:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171113 16:30:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 250 seconds]
20171113 16:30:49-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171113 16:37:19-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 248 seconds]
20171113 16:37:29-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171113 16:46:24-!- Emerald_Witch [uid1929@gateway/web/irccloud.com/x-nzprahpndpvhqwsl] has joined #wesnoth-dev
20171113 16:54:15< EliDupree> "There is some sense in extending the button schema to allow a separate icon key, though - in theory, one might want a button that has both text and an icon.
20171113 16:54:15< EliDupree> I don't think Wesnoth has any use case for such things, but I'm sure add-on devs could find a use for it."
20171113 16:54:15< EliDupree> -- EoHS already has a button with multiple icons on it as well as text, using set_dialog_canvas
20171113 17:08:31-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20171113 17:09:48-!- stikonas_ is now known as stikonas
20171113 17:14:36-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20171113 17:18:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20171113 17:27:51< Oebele> er
20171113 17:33:30-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20171113 17:34:47-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171113 17:40:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171113 17:46:28< gfgtdf> JyrkiVesterinen: maybe you could their support? you proablbly need to explain them why we use sceduled build intead of build on each push though.
20171113 17:46:45< JyrkiVesterinen> Sure, I can contact their support.
20171113 17:47:51< JyrkiVesterinen> And if they ask why we're using scheduled builds, then I can simply tell the truth. And while I'm at it, I can also ask if granting me admin access to the GitHub proect would allow AppVeyor to set up the push hook and whether additional steps would be needed.
20171113 17:47:59< JyrkiVesterinen> *project
20171113 17:49:04< gfgtdf> hmm on my wesnoth fork the apopvyor builds on push without me needing to do anything, no idea why it didn't work wit main repo
20171113 17:49:09< gfgtdf> zookeeper: any opinioon on https://github.com/wesnoth/wesnoth/issues/2147 = what is whether we shoudl continue using force_lock_setting as a default for lock_faction
20171113 17:49:26< JyrkiVesterinen> Because you have admin access to your own fork, obviously.
20171113 17:53:56< gfgtdf> JyrkiVesterinen: did you see my link eariler (https://www.appveyor.com/blog/2017/11/08/sheduled-builds-for-free-accounts/) ?
20171113 17:54:05< JyrkiVesterinen> Yes, I saw it.
20171113 17:54:40-!- sigurdfd [sigurdfd@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20171113 18:13:04-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:b889:358e:5f1b:13eb] has joined #wesnoth-dev
20171113 18:24:33< JyrkiVesterinen> I contacted their support: https://help.appveyor.com/discussions/problems/9801-please-enable-scheduled-builds-for-battle-for-wesnoth
20171113 18:31:57< gfgtdf> ok thx
20171113 18:37:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20171113 18:38:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171113 18:38:49< gfgtdf> JyrkiVesterinen: do you know whether it's possibel to disable unit tests on my appevory build without disabling them in in main repo (meaing without changin that you appear in my pr) ?
20171113 18:39:07< JyrkiVesterinen> I'm not aware of any way.
20171113 18:44:57-!- aeth_ [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20171113 18:47:19< zookeeper> gfgtdf, oh wow, i shouldn't have applied force_lock_settings=yes to DF...
20171113 18:47:41-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 240 seconds]
20171113 18:48:14< gfgtdf> zookeeper: well it does make sense that things like time etc are blocked, it's just that force_locksettings does more.
20171113 18:48:23< zookeeper> yeah
20171113 18:49:57< zookeeper> i don't see why lock_faction shouldn't default to force_lock_settings, really. if/when one wants to lock settings but not factions, they can just have force_lock_settings,lock_faction=yes,no, right?
20171113 18:50:16-!- aeth_ is now known as aeth
20171113 18:51:11< zookeeper> oh, right, you said as much in the comments.
20171113 18:51:32-!- vslavik [~vslavik@95.82.135.184] has joined #wesnoth-dev
20171113 18:52:17< gfgtdf> zookeeper: yes one could, (except that lock_faction= is a [side] attribute, so it'd look a littel differnt)
20171113 18:53:08< zookeeper> well, yeah
20171113 18:54:08-!- vladimirslavik [~vslavik@95.82.135.184] has quit [Ping timeout: 240 seconds]
20171113 18:54:36-!- amir|2 [~amir@80-110-85-87.cgn.dynamic.surfer.at] has quit [Ping timeout: 252 seconds]
20171113 18:54:43-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20171113 18:55:13-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171113 18:59:45-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds]
20171113 19:00:23< zookeeper> wtf. "local game" in the titlescreen MP menu takes me to a connect dialog. after which it apparently doesn't connect anywhere, but proceeds to the local game creation screen as usual.
20171113 19:00:43< zookeeper> (my build is a few days old)
20171113 19:00:51-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171113 19:01:04< JyrkiVesterinen> I guess you don't have this commit, then: https://github.com/wesnoth/wesnoth/commit/a324534a6a0e38f65570c7e8093d48703ffb1223
20171113 19:01:05< gfgtdf> zookeeper: iirc this was eported and fixed already
20171113 19:01:16< zookeeper> ah, okay.
20171113 19:03:21< zookeeper> color_lock,faction_lock,leader_lock... nothing else, i think?
20171113 19:06:08< gfgtdf> yes that shudl be it, it take as you 'll change this values and we'll not change bahvour of the engine?
20171113 19:06:53< zookeeper> yeah i'd think that's the way it should be.
20171113 19:07:23< zookeeper> or at least i don't immediately see any reason why it should be changed
20171113 19:07:35< gfgtdf> hmm somehow the sp campaigns are now visible in the mp create screen too
20171113 19:08:09< gfgtdf> hmm on a second though ... why not
20171113 19:08:21< JyrkiVesterinen> That was intentional: https://github.com/wesnoth/wesnoth/commit/aeb33fb7629451d4fe475586f5fa6472ba75b7c5
20171113 19:10:23-!- irker036 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171113 19:10:24< irker036> wesnoth: ln-zookeeper wesnoth:master 34c6fcd0fde0 / changelog data/multiplayer/scenarios/2p_Dark_Forecast.cfg: Dark Forecast: Fix broken leader/faction/color selection, fixes #2147 https://github.com/wesnoth/wesnoth/commit/34c6fcd0fde008991c2061cb4c8fca27fd14c7c5
20171113 19:15:27< zookeeper> i'm not sure how good of an idea color unlocking is though, in scenarios where there are AI sides that don't show up in the setup. if you pick your color, you might end up with the same one the AI sides use.
20171113 19:17:29< zookeeper> of course you could have some code that sets a unique color for the AI side when the scenario starts, but... might be more convenient for everyone to just lock the colors.
20171113 19:26:15-!- travis-ci [~travis-ci@ec2-54-162-155-110.compute-1.amazonaws.com] has joined #wesnoth-dev
20171113 19:26:16< travis-ci> gfgtdf/wesnoth#977 (depcheck - 9922660 : gfgtdf): The build failed.
20171113 19:26:16< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/301532054
20171113 19:26:16-!- travis-ci [~travis-ci@ec2-54-162-155-110.compute-1.amazonaws.com] has left #wesnoth-dev []
20171113 19:30:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20171113 19:31:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171113 19:35:35< JyrkiVesterinen> All right, scheduled builds were enabled for us and I set them up again. :)
20171113 19:41:35< gfgtdf> ok thx :)
20171113 19:47:29< irker036> wesnoth: gfgtdf wesnoth:master 6713070cc5a4 / src/game_initialization/create_engine.cpp: fix crash when selecting a random scenario in mp create https://github.com/wesnoth/wesnoth/commit/6713070cc5a418515733131665e9315816d9e032
20171113 19:54:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20171113 19:54:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171113 19:55:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20171113 19:55:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171113 19:57:39-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20171113 19:57:45-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171113 20:01:14< gfgtdf> actuall having sp scenario there too might come in handy for me for technical reason when fixing the mp depcheck
20171113 20:29:51-!- gfgtdf [~chatzilla@x4e3686b9.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 56.0.2/20171024165158]]
20171113 20:57:15< sigurdfd> zookeeper: Any issues with anything I said last time or the TSG PR?
20171113 20:59:07< zookeeper> urgh, my laziness has reached entirely new heights lately... yeah, i'll take a look
20171113 21:00:35-!- travis-ci [~travis-ci@ec2-54-221-59-202.compute-1.amazonaws.com] has joined #wesnoth-dev
20171113 21:00:36< travis-ci> wesnoth/wesnoth#15584 (master - 34c6fcd : ln-zookeeper): The build has errored.
20171113 21:00:36< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/301564813
20171113 21:00:36-!- travis-ci [~travis-ci@ec2-54-221-59-202.compute-1.amazonaws.com] has left #wesnoth-dev []
20171113 21:08:35< JyrkiVesterinen> vultraz: I received some advice about setting up the Appveyor webhooks manually. Would you do it?
20171113 21:08:52< JyrkiVesterinen> (I can't do it because it requires admin rights to the repository.)
20171113 21:09:21< JyrkiVesterinen> The webhooks should be added for the events "Push" and "Pull Request", and the URLs are
20171113 21:09:27< JyrkiVesterinen> https://ci.appveyor.com/api/github/webhook?id=nv5jnof3lk3j6kg6
20171113 21:09:36< JyrkiVesterinen> https://ci.appveyor.com/api/github/webhook?id=6017w5c9nhfxsuo5
20171113 21:09:43< JyrkiVesterinen> https://ci.appveyor.com/api/github/webhook?id=ssd5s7hli7u1hkl8
20171113 21:24:47< zookeeper> sigurdfd, added a comment. i'm kind of annoyed that there's no especially simple and convenient way to make a unit not move...
20171113 21:25:28< sigurdfd> I could use passive_leader=yes, but if anyone reached Mbrin, he wouln'd attack them.
20171113 21:25:28-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20171113 21:26:04< sigurdfd> since it seems unlikely they would get to him, I could use that\
20171113 21:27:52< zookeeper> well, yeah, i guess that would work
20171113 21:31:31< Ravana_> wouldn't you consider unit.max_moves=0 simple?
20171113 21:33:46< zookeeper> i'm not sure if i would trust it to not break in some future situation. plus, it also has the drawback of revealing the exception to the player.
20171113 21:46:55-!- travis-ci [~travis-ci@ec2-54-205-116-35.compute-1.amazonaws.com] has joined #wesnoth-dev
20171113 21:46:56< travis-ci> wesnoth/wesnoth#15585 (master - 6713070 : gfgtdf): The build has errored.
20171113 21:46:56< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/301582983
20171113 21:46:56-!- travis-ci [~travis-ci@ec2-54-205-116-35.compute-1.amazonaws.com] has left #wesnoth-dev []
20171113 21:47:58-!- travis-ci [~travis-ci@ec2-54-162-155-110.compute-1.amazonaws.com] has joined #wesnoth-dev
20171113 21:47:59< travis-ci> gfgtdf/wesnoth#978 (depcheck - 350c4f0 : gfgtdf): The build is still failing.
20171113 21:47:59< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/301599633
20171113 21:47:59-!- travis-ci [~travis-ci@ec2-54-162-155-110.compute-1.amazonaws.com] has left #wesnoth-dev []
20171113 21:51:48-!- ChipmunkV[m] [chipmunkvm@gateway/shell/matrix.org/x-lvlmfjygdujrrluf] has quit [Ping timeout: 255 seconds]
20171113 21:51:49-!- loonycyborg [~loonycybo@wesnoth/developer/loonycyborg] has quit [Ping timeout: 255 seconds]
20171113 21:53:10-!- loonycyborg [~loonycybo@wesnoth/developer/loonycyborg] has joined #wesnoth-dev
20171113 21:58:24-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20171113 21:59:32-!- Greg_Boggs[m] [gregboggsm@gateway/shell/matrix.org/x-avgynjmadsfkhfzb] has quit [Ping timeout: 252 seconds]
20171113 21:59:53-!- NicolasF[m] [nicolasfma@gateway/shell/matrix.org/x-mgiapvcvpkfwpgxs] has quit [Ping timeout: 248 seconds]
20171113 22:00:08-!- desttinghim[m] [desttinghi@gateway/shell/matrix.org/x-nuyhtagyligdrfxc] has quit [Ping timeout: 276 seconds]
20171113 22:00:09-!- madmax28 [madmax28ma@gateway/shell/matrix.org/x-oxhemshmrugjkrcv] has quit [Ping timeout: 250 seconds]
20171113 22:08:46-!- NicolasF[m] [nicolasfma@gateway/shell/matrix.org/x-irlxcmeeuzxuizty] has joined #wesnoth-dev
20171113 22:09:07-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171113 22:09:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20171113 22:24:48-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20171113 22:25:19-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171113 22:27:24-!- desttinghim[m] [desttinghi@gateway/shell/matrix.org/x-nrosppzdjckunmdl] has joined #wesnoth-dev
20171113 22:27:24-!- ChipmunkV[m] [chipmunkvm@gateway/shell/matrix.org/x-datkkzpphgwxsyuj] has joined #wesnoth-dev
20171113 22:27:25-!- madmax28 [madmax28ma@gateway/shell/matrix.org/x-fegpdabcozblcthw] has joined #wesnoth-dev
20171113 22:27:31-!- Greg_Boggs[m] [gregboggsm@gateway/shell/matrix.org/x-kcgbtxwalejbubcr] has joined #wesnoth-dev
20171113 22:29:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 246 seconds]
20171113 22:49:37-!- boucman [~rosen@221.86.207.77.rev.sfr.net] has joined #wesnoth-dev
20171113 22:49:44-!- boucman [~rosen@221.86.207.77.rev.sfr.net] has quit [Changing host]
20171113 22:49:44-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20171113 22:56:46-!- irker036 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20171113 23:01:08-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20171113 23:01:21-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171113 23:01:41-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171113 23:04:08-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20171113 23:05:35-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds]
20171113 23:09:51-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 248 seconds]
20171113 23:25:19-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171113 23:27:04-!- sigurdfd [sigurdfd@dynamic-acs-72-23-110-196.zoominternet.net] has quit []
20171113 23:28:16-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20171113 23:47:41-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:b889:358e:5f1b:13eb] has quit [Quit: Leaving]
20171113 23:54:42-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20171113 23:55:32-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
--- Log closed Tue Nov 14 00:00:17 2017