--- Log opened Tue Nov 14 00:00:17 2017
20171114 00:16:34-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20171114 00:17:05-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171114 00:21:19-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds]
20171114 00:48:33-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20171114 00:49:06-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171114 00:52:58-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20171114 01:09:24-!- travis-ci [~travis-ci@ec2-54-162-155-110.compute-1.amazonaws.com] has joined #wesnoth-dev
20171114 01:09:25< travis-ci> gfgtdf/wesnoth#979 (depcheck - bee1208 : gfgtdf): The build is still failing.
20171114 01:09:25< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/301688912
20171114 01:09:25-!- travis-ci [~travis-ci@ec2-54-162-155-110.compute-1.amazonaws.com] has left #wesnoth-dev []
20171114 01:09:31-!- stikonas_ is now known as stikonas
20171114 01:24:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20171114 01:38:18-!- sevu [~Shiki@141.57.75.127] has joined #wesnoth-dev
20171114 01:53:31-!- sevu [~Shiki@141.57.75.127] has quit [Quit: Verlassend]
20171114 02:09:56-!- irker875 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171114 02:09:56< irker875> wesnoth: Charles Dang wesmere:master 01edf20cc8a0 / static/docroot/index.php: Update macOS build link for 1.13.10 https://github.com/wesnoth/wesmere/commit/01edf20cc8a02277d89614daf631e836d6cd4c86
20171114 02:19:41< vultraz> celticminstrel: replace works with 0 index, but we should still have an insert function
20171114 02:19:45< vultraz> 0 size*
20171114 02:47:06< vultraz> celticminstrel: thoughts on deploying a helper macro in formula/function.cpp, like so? https://pastebin.com/Ftnd01zh
20171114 02:50:26< vultraz> though it would mean `fdb` and `variables` seem undeclared just from reading
20171114 02:52:16< vultraz> yeah, I think I'll keep `execute` outside the macro
20171114 02:58:58< celticminstrel> The macro name is misleading. It doesn't actually register the function, just defines it.
20171114 02:59:38< celticminstrel> It's registered separately down at the bottom of the file, and that probably can't be changed.
20171114 03:00:36< vultraz> what would you call it?
20171114 03:00:43< vultraz> DEFINE_FORMULA_FUNCTION?
20171114 03:03:03< celticminstrel> https://pastebin.com/rJfLaePV
20171114 03:03:17< celticminstrel> Tweaked it a little so that the function body can follow the macro instead of being embedded in it.
20171114 03:03:25< celticminstrel> And yeah, DEFINE is good.
20171114 03:03:47 * celticminstrel notes that the tweak is untested, but should work unless there are syntax errors.
20171114 03:05:10< celticminstrel> Note that there are three different files that define formula functions, so the macro should probably go in the header.
20171114 03:08:14< celticminstrel> If you want you can even add a constant (equal to 0 IIRC) for the case of unlimited arguments.
20171114 03:08:35< celticminstrel> It'd be a little more explanatory than DEFINE_FORMULA_FUNCTION(some_function, 2, 0)
20171114 03:08:51 * celticminstrel pokes vultraz 
20171114 03:08:55< vultraz> hm?
20171114 03:09:07< vultraz> constant?
20171114 03:09:07 * celticminstrel points at the paste.
20171114 03:09:12< vultraz> i saw the paste, using it
20171114 03:09:32< vultraz> hmmm... some classes have additional members :/
20171114 03:09:59< celticminstrel> #define DEFINE_FORMULA_FUNCTION(name, min_args, max_args, ...)
20171114 03:10:09< celticminstrel> And add __VA_ARGS__ near the end.
20171114 03:10:21< vultraz> oh dear, this is getting into territory I know nothing about
20171114 03:10:49< celticminstrel> Then you'll have DEFINE_FORMULA_FUNCTION(debug, 0, 1,) with an extra comma, which is a bit ugly, but could be worth it.
20171114 03:11:02< celticminstrel> What I described really isn't anything special.
20171114 03:11:40< celticminstrel> It's not that much different from what you had with the execute_body. The only real difference is that it's safe to include commas in the macro argument.
20171114 03:12:08< celticminstrel> You can probably just put the __VA_ARGS__ where you have execute_body before.
20171114 03:12:34< celticminstrel> Then you define it as DEFINE_FORMULA_FUNCTION(my_function, 0, 2, extra declarations here) { execute body here }
20171114 03:13:15< celticminstrel> Actually, you might not need that extra comma if the ... is empty.
20171114 03:13:22< celticminstrel> I'd try without it first, because it's ugly.
20171114 03:27:13< vultraz> celticminstrel: I'm confused
20171114 03:27:31< vultraz> are you saying #define DEFINE_FORMULA_FUNCTION(name, min_args, max_args, ...,__VA_ARGS)?
20171114 03:43:11< celticminstrel> No. It's a little confusing, but basically if you use ... in the header, then the name __VA_ARGS__ used within the definition expands to the extra arguments. I'll edit the paste again if you like?
20171114 03:44:02< celticminstrel> Unrelatedly, I kinda like how pastebin has extended the maximum expiry time.
20171114 03:45:48< celticminstrel> Something like this: https://pastebin.com/gWkvxipL
20171114 03:55:41< celticminstrel> Thinking about it, I feel that the __tab_enum implementations done well could require major refactoring and thus be best put off until 1.15.
20171114 03:57:34 * celticminstrel pokes vultraz again?
20171114 03:57:44< vultraz>  hm?
20171114 03:57:55 * celticminstrel points at paste number two.
20171114 03:58:21< vultraz> i saw, thanks
20171114 03:58:30< vultraz> but what is this about a constant?
20171114 03:58:33< celticminstrel> Also I'd kinda like to add more string functions, so if you could finish your thing quickly that'd be great.
20171114 03:58:58< vultraz> i think it wants a comma
20171114 03:59:01< celticminstrel> Ah, I was thinking it'd make more sense to write something like DEFINE_FORMULA_FUNCTION(fcn, 2, UNLIMITED) rather than DEFINE_FORMULA_FUNCTION(fcn, 2, 0).
20171114 03:59:17< vultraz> you use -1
20171114 03:59:24< celticminstrel> Come to think of it... it's not really an issue, but if you want a shorter name you could go with DEFINE_WFL_FUNCTION.
20171114 03:59:29< celticminstrel> Ah, sure, then that.
20171114 04:00:44< vultraz> yeah, it doesn't like your paste
20171114 04:00:53< celticminstrel> What doesn't it like?
20171114 04:01:25< vultraz> I'm not sure..
20171114 04:01:40< vultraz> oh, wait
20171114 04:01:50< vultraz> is the lack of closing ) deliberate there?
20171114 04:02:01< celticminstrel> Where?
20171114 04:02:22< vultraz> in the debug function in your paste
20171114 04:02:23< celticminstrel> BTW, glancing at documentation, it looks like you do need an extra trailing comma in eg DEFINE_FORMULA_FUNCTION(debug,0,1,)
20171114 04:02:38< celticminstrel> I wasn't sure about that.
20171114 04:02:50< celticminstrel> Maybe that's the problem you're getting?
20171114 04:03:26< vultraz> hm, no..
20171114 04:03:36< celticminstrel> Oh, wait, no, it says that restriction was lifted later.
20171114 04:04:05< celticminstrel> On the other hand, I have no idea what C++2a is, so maybe we still need it.
20171114 04:04:14< vultraz> whole lot of Error	C2334	unexpected token(s) preceding ':'; skipping apparent function body
20171114 04:04:44< celticminstrel> Unexpected tokens preceding a colon... and the line they point to are the macro invocations?
20171114 04:05:11< celticminstrel> Ah, I see, I got confused and added an extraneous semicolon to the constructor.
20171114 04:05:19< celticminstrel> Sorry about that.
20171114 04:05:25< celticminstrel> That's probably the cause.
20171114 04:05:43< celticminstrel> (Line 5 in the paste.)
20171114 04:06:14< vultraz> that was it
20171114 04:11:25-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171114 04:15:59-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds]
20171114 04:17:39< celticminstrel> Hmm, getting a dynamic link error in freetype. Hopefully a full rebuild will fix it...
20171114 04:39:39-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171114 04:39:47-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171114 05:08:39< vultraz> i can move one of these extra functions to an anon namespace
20171114 05:10:16< vultraz> actually can move all of them
20171114 05:12:00< vultraz> so no need for v_a args
20171114 05:13:53< vultraz> or, actually, no
20171114 05:18:41< vultraz> or wait, i can
20171114 05:20:02< vultraz> i just need to pass the class bit it uses
20171114 05:20:35< vultraz>  1 file changed, 1043 insertions(+), 1263 deletions(-)
20171114 05:29:01-!- TC01 [~quassel@venus.arosser.com] has quit [Ping timeout: 240 seconds]
20171114 05:43:39< celticminstrel> What, vultraz?
20171114 05:43:52-!- TC01 [~quassel@venus.arosser.com] has joined #wesnoth-dev
20171114 05:44:11< vultraz> celticminstrel: didn't need the extra args thing
20171114 05:44:12< irker875> wesnoth: Charles Dang wesnoth:master e50a63927bd1 / src/formula/ (function.cpp function.hpp): WFL/Formula: cleaned up formatting and greatly reduced code duplication https://github.com/wesnoth/wesnoth/commit/e50a63927bd13d823ebb6ee777cd064e6077212e
20171114 05:44:19< vultraz> celticminstrel: ^ done
20171114 05:44:47< celticminstrel> Okay, I can probably add some functions tomorrow then.
20171114 05:45:00< celticminstrel> Bit late to do it tonight.
20171114 05:45:20< vultraz> thanks for the help
20171114 05:45:22< celticminstrel> May not be able to test them though, unless I can figure out why it's loading the wrong freetype.
20171114 05:45:37< celticminstrel> Bah, you mixed in reformatting changes. :(
20171114 05:46:21< vultraz> yes
20171114 05:46:28< celticminstrel> Also, uhh, you kinda forgot two-thirds of the job?
20171114 05:46:34< vultraz> did i?
20171114 05:46:47< celticminstrel> Like you missed a whole bunch of functions.
20171114 05:46:55< celticminstrel> Like I said earlier, there are WFL functions defined in three separate files.
20171114 05:47:06< vultraz> will have to get to those
20171114 05:47:30< celticminstrel> At least it won't conflict with me adding new functions, in case you don't get to it before I get to that.
20171114 05:48:04< vultraz> I'm going to now do some minor refactoring
20171114 05:48:18< celticminstrel> This part of the diff looks slightly suspicious: https://github.com/wesnoth/wesnoth/commit/e50a63927bd13d823ebb6ee777cd064e6077212e?w=1#diff-b0529598aa9852df4c0ad0b19384f7d3L101
20171114 05:48:48< vultraz> it's down on 102
20171114 05:49:23< celticminstrel> Ahhh, I see what you did now. Alright.
20171114 05:50:14< celticminstrel> I'm surprised it's not highlighting switch as a keyword.
20171114 05:51:30< celticminstrel> I had a sudden thought on how to implement recursion in WFL - define a function called "recurse" which takes any number of arguments and passes them on to the currently-running function.
20171114 05:51:44< celticminstrel> Which would mean a reference to the currently-running function needs to be stored somewhere, of course.
20171114 05:52:46< celticminstrel> Maybe it wouldn't be too much extra work to allow use of the function's name instead; not sure.
20171114 05:59:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171114 05:59:45< celticminstrel> Also vultraz, any reason why you didn't use the macro for the action functions?
20171114 05:59:50< celticminstrel> safe_call and set_var
20171114 06:00:32< celticminstrel> In any case, apart from the useless formatting changes (which should've been deferred to a separate commit), that looks fine.
20171114 06:01:08< celticminstrel> Wait, why are you token-pasting the comma and the min_args / max_args? :S
20171114 06:01:29< celticminstrel> Line 32 of function.hpp probably needs no ##
20171114 06:01:34< celticminstrel> (Just #name)
20171114 06:03:05< celticminstrel> Personally I'd suggest moving the "namespace wfl" line to follow the macros, as the namespace means nothing to a macro declaration.
20171114 06:04:11-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 250 seconds]
20171114 06:04:34< celticminstrel> Anyway, good night.
20171114 06:08:10-!- celticminstrel is now known as celmin|sleep
20171114 06:12:24-!- travis-ci [~travis-ci@ec2-54-80-194-27.compute-1.amazonaws.com] has joined #wesnoth-dev
20171114 06:12:25< travis-ci> wesnoth/wesnoth#15589 (master - e50a639 : Charles Dang): The build failed.
20171114 06:12:25< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/301789159
20171114 06:12:25-!- travis-ci [~travis-ci@ec2-54-80-194-27.compute-1.amazonaws.com] has left #wesnoth-dev []
20171114 06:37:31-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171114 06:37:38-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171114 06:57:16< vultraz> *pokes matthiaskrgr *
20171114 07:31:54-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20171114 07:41:49-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20171114 07:47:59-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171114 07:52:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 258 seconds]
20171114 09:36:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171114 09:40:47-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds]
20171114 10:13:41-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171114 10:13:50-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171114 10:43:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171114 10:47:51-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20171114 11:19:31-!- irker875 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20171114 11:23:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20171114 11:24:37-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171114 11:29:03-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds]
20171114 11:53:20-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20171114 12:02:45-!- zookeeper_ [~lmsnie@95.175.104.86] has joined #wesnoth-dev
20171114 12:03:12-!- vslavik [~vslavik@95.82.135.184] has quit [Remote host closed the connection]
20171114 12:03:29-!- vslavik [~vslavik@95.82.135.184] has joined #wesnoth-dev
20171114 12:04:47-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 248 seconds]
20171114 12:41:24-!- vn971 [~vasya@94.158.103.15] has quit [Remote host closed the connection]
20171114 13:27:16-!- zookeeper_ is now known as zookeeper
20171114 13:27:19-!- zookeeper [~lmsnie@95.175.104.86] has quit [Changing host]
20171114 13:27:19-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20171114 13:52:38-!- DeFender [~DeFender1@89-139-219-165.bb.netvision.net.il] has joined #wesnoth-dev
20171114 13:52:38-!- DeFender [~DeFender1@89-139-219-165.bb.netvision.net.il] has quit [Read error: Connection reset by peer]
20171114 13:55:06-!- DeFender [~DeFender1@89-139-219-165.bb.netvision.net.il] has joined #wesnoth-dev
20171114 13:55:11-!- DeFender1031 [~DeFender1@46-116-196-40.bb.netvision.net.il] has quit [Ping timeout: 248 seconds]
20171114 13:55:42-!- irker051 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171114 13:55:42< irker051> wesnoth: Charles Dang wesnoth:master 608de6a42df8 / src/ (5 files in 2 dirs): WFL/Formula: some minor code refactoring and build fix from e50a63927bd1 https://github.com/wesnoth/wesnoth/commit/608de6a42df8ead850248e35f4b3990489d04523
20171114 14:50:43< JyrkiVesterinen> Update: AppVeyor's build-on-push is working now. :)
20171114 14:50:53< JyrkiVesterinen> I disabled scheduled builds, we no longer need them.
20171114 14:51:28< vultraz> \o/
20171114 15:00:42< vultraz> celticmintrel: any chance custom WFL functions (those defined with def()) can have access to state variables, instead of only their arguments?
20171114 15:06:45-!- travis-ci [~travis-ci@ec2-54-211-165-202.compute-1.amazonaws.com] has joined #wesnoth-dev
20171114 15:06:46< travis-ci> wesnoth/wesnoth#15591 (master - 608de6a : Charles Dang): The build has errored.
20171114 15:06:46< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/301950556
20171114 15:06:46-!- travis-ci [~travis-ci@ec2-54-211-165-202.compute-1.amazonaws.com] has left #wesnoth-dev []
20171114 15:12:29-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20171114 15:53:52< irker051> wesnoth: gfgtdf wesnoth:master 138faa946499 / src/game_initialization/create_engine.cpp: give an error if two mods/era with the same id exist. https://github.com/wesnoth/wesnoth/commit/138faa9464994f6f17e494a848b28f72203eea60
20171114 16:24:47< AI0867> vultraz: that broke the build for me
20171114 16:36:26< irker051> wesnoth: Alexander van Gessel wesnoth:master 133eb2af6906 / src/formula/function.hpp: Don't concatenate int arguments https://github.com/wesnoth/wesnoth/commit/133eb2af69069ecbb6863d215921dbea2af5d6e0
20171114 16:36:28< irker051> wesnoth: Alexander van Gessel wesnoth:master ee10e333daa5 / src/formula/function.cpp: Fix unused variable warning https://github.com/wesnoth/wesnoth/commit/ee10e333daa594798f3b2c93d3114be4e3bc3ad3
20171114 16:36:30< irker051> wesnoth: Alexander van Gessel wesnoth:master 5c0ec4cf87b3 / src/ (6 files in 3 dirs): Merge branch 'master' of github.com:wesnoth/wesnoth https://github.com/wesnoth/wesnoth/commit/5c0ec4cf87b334e6c7318d1273398a2fb89b8144
20171114 16:57:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171114 16:59:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20171114 17:05:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171114 17:06:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20171114 17:09:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171114 17:10:27-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20171114 17:10:27< Appveyor> wesnoth - Release gfgtdf 8f8cb27: 77ijiikjkjkjh Failed
20171114 17:10:27< Appveyor> Details: https://ci.appveyor.com/project/gfgtdf/wesnoth/build/Wesnoth-VS2017-depcheck-53
20171114 17:10:31-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20171114 17:22:15-!- travis-ci [~travis-ci@ec2-54-197-49-236.compute-1.amazonaws.com] has joined #wesnoth-dev
20171114 17:22:16< travis-ci> wesnoth/wesnoth#15592 (master - 138faa9 : gfgtdf): The build failed.
20171114 17:22:16< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/302005916
20171114 17:22:16-!- travis-ci [~travis-ci@ec2-54-197-49-236.compute-1.amazonaws.com] has left #wesnoth-dev []
20171114 17:43:43-!- travis-ci [~travis-ci@ec2-54-80-194-27.compute-1.amazonaws.com] has joined #wesnoth-dev
20171114 17:43:44< travis-ci> gfgtdf/wesnoth#980 (depcheck - 8f8cb27 : gfgtdf): The build has errored.
20171114 17:43:44< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/302031417
20171114 17:43:44-!- travis-ci [~travis-ci@ec2-54-80-194-27.compute-1.amazonaws.com] has left #wesnoth-dev []
20171114 17:48:28-!- atarocch [~atarocch@93.56.164.28] has quit [Read error: Connection reset by peer]
20171114 17:48:45-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20171114 17:49:56-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20171114 17:52:17< irker051> wesnoth: pentarctagon wesnoth:master 52f84df4b559 / src/SConscript: Minor code cleanup. https://github.com/wesnoth/wesnoth/commit/52f84df4b5593e7edf2223f52da6e5fe158bfaa0
20171114 17:52:18< irker051> wesnoth: pentarctagon wesnoth:master fd00a4be81be / src/SConscript: wesnoth_objects -> libwesnoth_objects https://github.com/wesnoth/wesnoth/commit/fd00a4be81be0d0525b6784f30489d3c06f686a5
20171114 17:52:20< irker051> wesnoth: pentarctagon wesnoth:master 3b81f0695326 / src/SConscript: Remove a list of 1. https://github.com/wesnoth/wesnoth/commit/3b81f06953265b993bdb16c0e47e70614757c94a
20171114 17:55:38< matthiaskrgr> 15:46 < vultraz> [07:57:16] *pokes matthiaskrgr *
20171114 17:56:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171114 17:56:21< matthiaskrgr> sorry, I didn't get that :/     the tech guys have some internet censorship at my uni so I cant accesss my bouncer from uni network 
20171114 18:04:22-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20171114 18:06:27-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20171114 18:14:28< matthiaskrgr> but I can confirm that it builds now for me \o/
20171114 18:15:49-!- gfgtdf [~chatzilla@x4e368ba5.dyn.telefonica.de] has joined #wesnoth-dev
20171114 18:16:19< gfgtdf> JyrkiVesterinen: you ahve an idea about https://github.com/wesnoth/wesnoth/issues/2197 ? s it a known issue or somethign with an obvious casue ?
20171114 18:19:57< JyrkiVesterinen> My guess would be that it's a regression from https://github.com/wesnoth/wesnoth/commit/8e388c1b3557f436cd524fb35572e40c739043ba
20171114 18:20:38< JyrkiVesterinen> It's known to have caused https://github.com/wesnoth/wesnoth/issues/2132 at least.
20171114 18:21:15-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20171114 18:31:59-!- travis-ci [~travis-ci@ec2-54-211-165-202.compute-1.amazonaws.com] has joined #wesnoth-dev
20171114 18:32:00< travis-ci> wesnoth/wesnoth#15593 (master - 5c0ec4c : Alexander van Gessel): The build has errored.
20171114 18:32:00< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/302028081
20171114 18:32:00-!- travis-ci [~travis-ci@ec2-54-211-165-202.compute-1.amazonaws.com] has left #wesnoth-dev []
20171114 18:48:57< irker051> wesnoth: Jyrki Vesterinen wesnoth:master 468437666ebe / src/formula/function.cpp: Use std::move() instead of std::forward() https://github.com/wesnoth/wesnoth/commit/468437666ebe178096426233bfacca6cf4a3a61a
20171114 19:03:23-!- travis-ci [~travis-ci@ec2-54-80-194-27.compute-1.amazonaws.com] has joined #wesnoth-dev
20171114 19:03:24< travis-ci> gfgtdf/wesnoth#981 (depcheck - 2de899d : gfgtdf): The build is still failing.
20171114 19:03:24< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/302052274
20171114 19:03:24-!- travis-ci [~travis-ci@ec2-54-80-194-27.compute-1.amazonaws.com] has left #wesnoth-dev []
20171114 19:22:10< gfgtdf> AI0867: i assigned https://github.com/wesnoth/wesnoth/issues/2197 to you for now, see the last comment for the reason.
20171114 19:49:56-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:ce3:2771:1cd8:fe37] has joined #wesnoth-dev
20171114 20:48:11-!- DeFender [~DeFender1@89-139-219-165.bb.netvision.net.il] has quit [Remote host closed the connection]
20171114 20:48:29-!- DeFender [~DeFender1@89-139-219-165.bb.netvision.net.il] has joined #wesnoth-dev
20171114 20:58:58-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:ce3:2771:1cd8:fe37] has quit [Quit: Leaving]
20171114 21:10:35-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20171114 21:19:15< AI0867> gfgtdf: two of your code links are missing line numbers
20171114 21:19:52-!- vslavik [~vslavik@95.82.135.184] has quit [Quit: Leaving]
20171114 21:19:59< AI0867> also, I no longer remember the context of that commit from 2013, and I couldn't find GNA bug #16350
20171114 21:21:17< gfgtdf> i added the lein numbers
20171114 21:23:20< gfgtdf> AI0867: this si what i have locally about #16350: https://pastebin.com/vFwTYPY9
20171114 21:23:28< gfgtdf> is*
20171114 21:26:17< AI0867> okay, so that commit is the bottom item
20171114 21:40:46-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171114 21:40:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171114 21:51:49-!- irker051 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20171114 21:53:15-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20171114 21:54:28< AI0867> JyrkiVesterinen: isn't std::move unnecessary when the argument is already an rvalue-ref?
20171114 21:58:10< gfgtdf> AI0867: it isn't
20171114 22:00:43-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20171114 22:00:49-!- gfgtdf [~chatzilla@x4e368ba5.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20171114 22:01:20< vultraz> AI0867: what did you do
20171114 22:01:59< AI0867> gfgtdf: ah, okay
20171114 22:02:09< AI0867> vultraz: ?
20171114 22:02:18< vultraz> https://github.com/wesnoth/wesnoth/commit/133eb2af69069ecbb6863d215921dbea2af5d6e0
20171114 22:02:22< vultraz> i had fixed that!
20171114 22:03:02< AI0867> the code I pulled was broken, so I fixed it
20171114 22:03:08-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20171114 22:03:34< vultraz> what do you mean broken
20171114 22:03:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171114 22:03:46< vultraz> it had that change
20171114 22:04:14< vultraz> look: https://github.com/wesnoth/wesnoth/commit/608de6a42df8ead850248e35f4b3990489d04523
20171114 22:04:20< AI0867> yes, I see
20171114 22:04:31< AI0867> I didn't have that commit in my working copy when I was fixing it though
20171114 22:04:45< AI0867> there were 9 hours between the breakage and the fix
20171114 22:04:50< AI0867> I pulled somewhere in those 9 hours
20171114 22:07:59-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds]
20171114 22:10:39-!- gfgtdf [~chatzilla@x4e368ba5.dyn.telefonica.de] has joined #wesnoth-dev
20171114 22:11:46-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20171114 22:11:46< Appveyor> wesnoth - Release gfgtdf 0327606: gfcjfghjfghjfgh Failed
20171114 22:11:46< Appveyor> Details: https://ci.appveyor.com/project/gfgtdf/wesnoth/build/Wesnoth-VS2017-depcheck-57
20171114 22:11:51-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20171114 22:17:18-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171114 22:34:36-!- Appveyor [~Appveyor@67.225.139.254] has joined #wesnoth-dev
20171114 22:34:36< Appveyor> wesnoth - Release gfgtdf 2d9cfbc: hguzut667u Failed
20171114 22:34:36< Appveyor> Details: https://ci.appveyor.com/project/gfgtdf/wesnoth/build/Wesnoth-VS2017-depcheck-58
20171114 22:34:40-!- Appveyor [~Appveyor@67.225.139.254] has left #wesnoth-dev []
20171114 22:43:24-!- travis-ci [~travis-ci@ec2-54-197-49-236.compute-1.amazonaws.com] has joined #wesnoth-dev
20171114 22:43:25< travis-ci> wesnoth/wesnoth#15593 (master - 5c0ec4c : Alexander van Gessel): The build passed.
20171114 22:43:25< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/302028081
20171114 22:43:25-!- travis-ci [~travis-ci@ec2-54-197-49-236.compute-1.amazonaws.com] has left #wesnoth-dev []
20171114 22:49:39< vultraz> AI0867: *please, please* either rebase before pushing or git pull before making any changes so this doesn't happen again
20171114 22:52:16-!- Appveyor [~Appveyor@67.225.139.254] has joined #wesnoth-dev
20171114 22:52:16< Appveyor> wesnoth - Debug gfgtdf 2d9cfbc: hguzut667u Failed
20171114 22:52:16< Appveyor> Details: https://ci.appveyor.com/project/gfgtdf/wesnoth/build/Wesnoth-VS2017-depcheck-58
20171114 22:52:20-!- Appveyor [~Appveyor@67.225.139.254] has left #wesnoth-dev []
20171114 22:52:25< vultraz> and if a build breaks, always pull again before attempting a fix
20171114 23:06:36< matthiaskrgr> or use branches instead of master
20171114 23:06:39 * matthiaskrgr hides 
20171114 23:17:51-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20171114 23:17:51< Appveyor> wesnoth - Release gfgtdf 8586af6: kl"jkl"jk"kjl" Failed
20171114 23:17:51< Appveyor> Details: https://ci.appveyor.com/project/gfgtdf/wesnoth/build/Wesnoth-VS2017-depcheck-59
20171114 23:17:56-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20171114 23:25:55-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 250 seconds]
20171114 23:26:09-!- travis-ci [~travis-ci@ec2-54-197-49-236.compute-1.amazonaws.com] has joined #wesnoth-dev
20171114 23:26:10< travis-ci> gfgtdf/wesnoth#984 (depcheck - 0327606 : gfgtdf): The build is still failing.
20171114 23:26:10< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/302173603
20171114 23:26:10-!- travis-ci [~travis-ci@ec2-54-197-49-236.compute-1.amazonaws.com] has left #wesnoth-dev []
20171114 23:37:11-!- Appveyor [~Appveyor@67.225.139.254] has joined #wesnoth-dev
20171114 23:37:11< Appveyor> wesnoth - Debug gfgtdf 8586af6: kl"jkl"jk"kjl" Failed
20171114 23:37:11< Appveyor> Details: https://ci.appveyor.com/project/gfgtdf/wesnoth/build/Wesnoth-VS2017-depcheck-59
20171114 23:37:15-!- Appveyor [~Appveyor@67.225.139.254] has left #wesnoth-dev []
20171114 23:37:18-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20171114 23:40:39-!- irker896 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171114 23:40:39< irker896> wesnoth: gfgtdf wesnoth:master 320255868d4e / src/scripting/lua_fileops.cpp: fix 2198 : dead condition  found by cppcheck https://github.com/wesnoth/wesnoth/commit/320255868d4eb6fe583cd2afcfedd136a97ad3e6
20171114 23:46:14-!- travis-ci [~travis-ci@ec2-54-197-49-236.compute-1.amazonaws.com] has joined #wesnoth-dev
20171114 23:46:15< travis-ci> gfgtdf/wesnoth#985 (depcheck - 2d9cfbc : gfgtdf): The build has errored.
20171114 23:46:15< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/302184211
20171114 23:46:16-!- travis-ci [~travis-ci@ec2-54-197-49-236.compute-1.amazonaws.com] has left #wesnoth-dev []
20171114 23:49:37< vultraz> gfgtdf: i can't confirm filtering on eras is broken
20171114 23:49:49< gfgtdf> vultraz: only tested for modifications yet
20171114 23:50:00< vultraz> yeah, i can see in the code why mods don't work
20171114 23:52:07< vultraz> but eras should work the same as always
20171114 23:52:14< vultraz> "default" matches default era
20171114 23:58:37< AI0867> 23:49 < vultraz> AI0867: *please, please* either rebase before pushing or git pull before making any changes so this doesn't happen again ← you're treating this like it's a huge problem. Nothing actually broke. git merged everything perfectly and I didn't even notice what had happened until later
20171114 23:59:08< irker896> wesnoth: Charles Dang wesnoth:master fcb62858f31f / src/game_initialization/lobby_data.cpp: MP Lobby: allow filtering by active mod names (fixes #2195) https://github.com/wesnoth/wesnoth/commit/fcb62858f31f59e6c2af021300b315dd3c7c9fa2
20171114 23:59:15< AI0867> 00:06 < matthiaskrgr> or use branches instead of master ← that doesn't help with fixing master
--- Log closed Wed Nov 15 00:00:18 2017