--- Log opened Wed Nov 15 00:00:18 2017
20171115 00:02:03< vultraz> gfgtdf: could you please use get_window() instead of adding more window& parameters (in #2193)
20171115 00:02:18< vultraz> and there's a stray void cast for some reason?
20171115 00:03:24< gfgtdf> the lines below were added later. (then squashed commit)
20171115 00:04:54< AI0867> (yet another reason to be reluctant in squashing commits ;) )
20171115 00:05:03< vultraz> ............................
20171115 00:05:49< vultraz> you really hate rebasing and squashing, don't you
20171115 00:06:09< AI0867> it's perfectly fine for tidying up history in a branch
20171115 00:06:30< AI0867> but I dislike doing it just to fake a linear history
20171115 00:07:53< AI0867> it reminds me of the hg "revision numbers" which are just as fake
20171115 00:09:31< AI0867> (but the previous parenthesised comment was in jest, as the smiley should clarify)
20171115 00:18:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20171115 00:18:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171115 00:23:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 268 seconds]
20171115 00:37:29< gfgtdf> vultraz: any opinion om making mp_create use a stacked_widget/multipage of 5 different listboxes instead of one that is recreated everytime the a new type is selected?
20171115 00:38:26< gfgtdf> vultraz: my current problem is that during the 'recreation' of that list, the select game callback is called once for the first entry during the creation of that list
20171115 00:39:15< gfgtdf> vultraz: (listbox calls the selected callback when the first entry is added if there were no entries before, since it changes the selection from 'nothing' to '0')
20171115 00:39:41< vultraz> why is that bad?
20171115 00:41:29< gfgtdf> becasue that trigges the depcheck whether that scenario is compatible with the current setup.
20171115 00:41:58< vultraz> that's desired behavior
20171115 00:42:12< vultraz> when switching types you're selecting a new game
20171115 00:43:18< gfgtdf> but not the first one in that list
20171115 00:44:01< vultraz> you mean it's fired twice?
20171115 00:44:06< gfgtdf> no
20171115 00:44:17< vultraz> then I don't understand
20171115 00:44:41< gfgtdf> vultraz: currently mp_create_game::display_games_of_type(window& window, ng::level::TYPE type, const std::string& level) always triggers the select event for the first game of type type', but it shodul just select the level 'leve' which is usualyl not the first one in the list
20171115 00:45:40< vultraz> is there any reason we should preserve the selected index from the previous selection?
20171115 00:45:56< vultraz> I think I specifically chose not to
20171115 00:46:50< gfgtdf> well currently it just uses the lement at the same position, which doenst relal make sense to me eogher, but that's unrelated issue
20171115 00:47:22< vultraz> I specifically chose to select the first game when selecting a new category 
20171115 00:48:10< gfgtdf> vultraz: that not what i oberved 
20171115 00:48:36< vultraz> hmmm
20171115 00:48:50< vultraz> oh, I see...
20171115 00:48:54< vultraz> hmmmm
20171115 00:49:02< vultraz> I must be misremembering, then
20171115 00:49:12< vultraz> yes, just confirmed
20171115 00:49:58< gfgtdf> vultraz: but thi isnt relal m problem, my probem is that i call 'mp_create_game::display_games_of_type' to selct a specific game if the dephekc forces me to select that game
20171115 00:50:19< vultraz> why?
20171115 00:50:23< vultraz> that's not for selecting games ;|
20171115 00:50:25< vultraz> :| *
20171115 00:50:36< vultraz> that's for changing categories
20171115 00:50:40< celmin|sleep> [Nov 14@10:00:42am] vultraz: celticmintrel: any chance custom WFL functions (those defined with def()) can have access to state variables, instead of only their arguments?
20171115 00:50:40< celmin|sleep> Please clarify.
20171115 00:50:44< gfgtdf> that's the oynl function we have for selecting game,s and it has excetly the interface for otoit
20171115 00:50:55< gfgtdf> for it*
20171115 00:51:48< gfgtdf> ny other self written function woudl also need to recreate that list and have the same probem
20171115 00:51:56< gfgtdf> any*
20171115 00:52:32< vultraz> I think you can just select the appropriate listbox row and then do on_game_select
20171115 00:52:43< vultraz> or even better, make listbox::select_row fire a NOTIFY_MODIFIED event
20171115 00:52:53< gfgtdf> vultraz: the item i want might of another game type then the onyl currently shown
20171115 00:53:00< vultraz> how is that possible
20171115 00:53:34< gfgtdf> becasu we have difeent types campaign, random_maps, campaigns, user_maps
20171115 00:54:50< vultraz> ehh... ok, i guess i can see how you might end up with a game in a different category 
20171115 00:55:37< gfgtdf> the depcheck is comeplteley indpendent on those categories.
20171115 00:55:44 * vultraz curses
20171115 00:55:52< vultraz> alright, I'll think of something
20171115 00:56:00< vultraz> having 5 listboxes is completely unacceptable
20171115 00:56:12< gfgtdf> vultraz: why that?
20171115 00:56:22< vultraz> celmin|sleep: why are you telling me to remove semicolons?
20171115 00:56:35< vultraz> gfgtdf: because it's an ugly hack and not a proper solution
20171115 00:56:38< gfgtdf> vultraz: it woudl really change apperaance or memory usage i'd say.
20171115 00:56:58< vultraz> and i don't want to have to think up proper management of 5 different listbox IDs
20171115 00:56:59< gfgtdf> wouldn't
20171115 00:57:11< vultraz> or maybe it would work with one, i dunno
20171115 00:57:18< vultraz> still, I really don't like the idea
20171115 00:57:41< gfgtdf> vultraz: recalculating a lists content is aan ungly hack, in partucular it usualy forces a fully relayout when you select a differnt tpye, and how a specific type is shown does usualyl dpeend on which list was previousl selected
20171115 00:58:12< vultraz> yes, I fucking hate how it causes the listbox to change size
20171115 00:58:20< gfgtdf> i do like the idea, but i'm little layzy to do it bow.,
20171115 00:58:24< gfgtdf> now*
20171115 00:59:01< vultraz> the entire damn layout algorithm was never intended to handle dynamic content
20171115 00:59:17< vultraz> and it's times like this where it bites us in the ass
20171115 01:00:26< vultraz> true, using a multipage would alllow each listbox to maintain its own selection 
20171115 01:00:30< vultraz> and a constant size throughout
20171115 01:00:50< vultraz> but I still really don't like the idea >_<
20171115 01:01:47< vultraz> celmin|sleep: I'm talking about lifting this weird restriction: "It's important to remember that the function body has access to no variables other than its parameters."
20171115 01:03:55< celmin|sleep> vultraz: I'm telling you to remove semicolons because those are macro definitions.
20171115 01:04:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20171115 01:04:46< celmin|sleep> Ah, lifting that restriction seems like it would be difficult. Of course it's not impossible, though.
20171115 01:05:00< vultraz>  But why
20171115 01:05:37< celmin|sleep> Maybe what we could do is add an implicit self parameter to functions that don't explicitly declare one...
20171115 01:06:05< celmin|sleep> I can't recall exactly why it's hard off the top of my head.
20171115 01:06:10-!- celmin|sleep is now known as celticminstrel
20171115 01:06:21< celticminstrel> There's something about how functions are implemented.
20171115 01:08:01< gfgtdf> hmm what i just said migth be wrong, it seems like it doesnt happen during creation of the first element bu later
20171115 01:08:55< gfgtdf> vultraz: so seem to be a lter point when the first elemnt is selected and tha event is fored
20171115 01:11:01< vultraz> I don’t understand why the first element would be selected...
20171115 01:11:34< vultraz> Since you said it tries to keep the index..
20171115 01:11:35< vultraz> Or..
20171115 01:11:54-!- travis-ci [~travis-ci@ec2-54-80-194-27.compute-1.amazonaws.com] has joined #wesnoth-dev
20171115 01:11:55< travis-ci> gfgtdf/wesnoth#987 (depcheck - 64f6644 : gfgtdf): The build has errored.
20171115 01:11:55< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/302219735
20171115 01:11:55-!- travis-ci [~travis-ci@ec2-54-80-194-27.compute-1.amazonaws.com] has left #wesnoth-dev []
20171115 01:11:56< vultraz> Actually, did I make it default to 1 if the last index was out of range .
20171115 01:12:05< vultraz> Or 0 rather
20171115 01:13:48< gfgtdf> if i coudl debug this i woudl already know what's ging on...
20171115 01:19:00< gfgtdf> ok seens it was on_filter_change that called select game after the list is creates
20171115 01:19:28< celticminstrel> vultraz: So yeah, remove those semicolons please. The semicolons are used when the macro is invoked.
20171115 01:20:45< gfgtdf> which semicolon are you currently talking about ?=
20171115 01:21:14< celticminstrel> The ones I commented on the commit about.
20171115 01:31:08< vultraz> celticminstrel: could you do that as part of your additions
20171115 01:31:15< vultraz> I'd rather not make changes to that file twice
20171115 01:31:18< vultraz> it's a huge rebuild
20171115 01:31:27< celticminstrel> ...
20171115 01:31:32< celticminstrel> Well UI guess.
20171115 01:31:36< celticminstrel> ^-U
20171115 01:35:36< vultraz> gfgtdf: tbh i think listbox::select_row should fire a NOTIFY_MODIFIED event and i should try to get rid of manual callback calling
20171115 01:44:58< gfgtdf> vultraz: listbox does use NOTIFY_MODIFIED  already
20171115 01:45:26< vultraz> yes
20171115 01:45:30< vultraz> but not in select_row
20171115 01:45:58< gfgtdf> vultraz: if you make the setter fire the callbacks (NOTIFY_MODIFIED) you'll get infinite recursion of you want to change the selected item from within a callback 
20171115 01:46:11< vultraz> hm, yes
20171115 01:46:13< vultraz> true
20171115 01:46:16< vultraz> i had that problem before...
20171115 01:46:24< vultraz> god dammit
20171115 01:46:33< vultraz> nothing is ever simple, is it
20171115 01:47:27< gfgtdf> vultraz: i reecntly added a fire_event parmater to the selectable::set_value to fix a similar issue. 
20171115 01:47:52< vultraz> yeah, i sa
20171115 01:47:53< vultraz> w
20171115 01:53:59-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20171115 01:53:59< Appveyor> wesnoth - Release gfgtdf 45f2300: fix mod_list not found in mp create Failed
20171115 01:53:59< Appveyor> Details: https://ci.appveyor.com/project/gfgtdf/wesnoth/build/Wesnoth-VS2017-depcheck-62
20171115 01:54:03-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20171115 02:24:20-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171115 02:24:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171115 02:25:18-!- Appveyor [~Appveyor@67.225.139.254] has joined #wesnoth-dev
20171115 02:25:18< Appveyor> wesnoth - Release gfgtdf cdd226c: hjklhjklhjklhjl Failed
20171115 02:25:18< Appveyor> Details: https://ci.appveyor.com/project/gfgtdf/wesnoth/build/Wesnoth-VS2017-depcheck-63
20171115 02:25:22-!- Appveyor [~Appveyor@67.225.139.254] has left #wesnoth-dev []
20171115 02:44:28< irker896> wesnoth: Charles Dang wesnoth:master 184cdd8afcba / README.md: Fixed our README license badge linking to its own icon https://github.com/wesnoth/wesnoth/commit/184cdd8afcbaf5db9c70d0293d2472cd71c2095a
20171115 02:46:06-!- travis-ci [~travis-ci@ec2-54-80-194-27.compute-1.amazonaws.com] has joined #wesnoth-dev
20171115 02:46:07< travis-ci> gfgtdf/wesnoth#988 (depcheck - 6600949 : gfgtdf): The build failed.
20171115 02:46:07< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/302256504
20171115 02:46:07-!- travis-ci [~travis-ci@ec2-54-80-194-27.compute-1.amazonaws.com] has left #wesnoth-dev []
20171115 02:47:16-!- Appveyor [~Appveyor@67.225.139.254] has joined #wesnoth-dev
20171115 02:47:16< Appveyor> wesnoth - Debug gfgtdf cdd226c: hjklhjklhjklhjl Failed
20171115 02:47:16< Appveyor> Details: https://ci.appveyor.com/project/gfgtdf/wesnoth/build/Wesnoth-VS2017-depcheck-63
20171115 02:47:21-!- Appveyor [~Appveyor@67.225.139.254] has left #wesnoth-dev []
20171115 02:50:07-!- gfgtdf [~chatzilla@x4e368ba5.dyn.telefonica.de] has quit [Ping timeout: 248 seconds]
20171115 03:00:58-!- travis-ci [~travis-ci@ec2-54-211-165-202.compute-1.amazonaws.com] has joined #wesnoth-dev
20171115 03:00:59< travis-ci> gfgtdf/wesnoth#989 (depcheck - 45f2300 : gfgtdf): The build failed.
20171115 03:00:59< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/302258332
20171115 03:00:59-!- travis-ci [~travis-ci@ec2-54-211-165-202.compute-1.amazonaws.com] has left #wesnoth-dev []
20171115 03:18:43-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171115 03:23:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20171115 03:24:16-!- travis-ci [~travis-ci@ec2-54-161-217-166.compute-1.amazonaws.com] has joined #wesnoth-dev
20171115 03:24:17< travis-ci> gfgtdf/wesnoth#990 (depcheck - cdd226c : gfgtdf): The build failed.
20171115 03:24:17< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/302267930
20171115 03:24:17-!- travis-ci [~travis-ci@ec2-54-161-217-166.compute-1.amazonaws.com] has left #wesnoth-dev []
20171115 03:52:12-!- travis-ci [~travis-ci@ec2-54-161-217-166.compute-1.amazonaws.com] has joined #wesnoth-dev
20171115 03:52:13< travis-ci> gfgtdf/wesnoth#991 (depcheck - 33fdb5b : gfgtdf): The build has errored.
20171115 03:52:13< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/302276235
20171115 03:52:13-!- travis-ci [~travis-ci@ec2-54-161-217-166.compute-1.amazonaws.com] has left #wesnoth-dev []
20171115 04:18:38< irker896> wesnoth: Celtic Minstrel wesnoth:master f759e4ecd10c / src/ (ai/formula/function_table.cpp formula/function.hpp): Remove the useless (and dangerous) semicolons from the WFL macro definitions https://github.com/wesnoth/wesnoth/commit/f759e4ecd10cfbf2d4077e69ed4811bf2c7c3c79
20171115 04:18:58< vultraz> blah
20171115 04:19:09< vultraz> I do not like the feedback my MP lobby changes are getting
20171115 04:20:18< vultraz> I'm going to have to decide between what looks aesthetically pleasing and what's useful for people to look at >_<
20171115 04:20:21< vultraz> er
20171115 04:20:29< vultraz> useful for people looking for games
20171115 04:21:51< vultraz> before, yes, the data was visible, but it was also jumbled, ugly, and hard to understand
20171115 04:24:14< celticminstrel> Where was this feedback again
20171115 04:24:42< vultraz> https://forums.wesnoth.org/viewtopic.php?f=6&t=47302
20171115 04:28:18< vultraz> everyone seems to have something they want immediately visible
20171115 04:28:54< vultraz> no concern for how it looks aesthetically >_<
20171115 04:29:52< celticminstrel> Functionality is more important than aesthetics.
20171115 04:30:03< vultraz> sometimes
20171115 04:30:06< celticminstrel> If for some reason you need to choose between the two, go for functionality.
20171115 04:30:13< celticminstrel> Of course, you can often get both.
20171115 04:32:24< vultraz> I wonder if i should scrap the inline join/observe buttons
20171115 04:32:54< vultraz> i feel inclined to
20171115 04:32:55< celticminstrel> I forget, were there join/observe buttons out of line too?
20171115 04:33:02< vultraz> yes
20171115 04:33:03< celticminstrel> If so, the inline ones are kinda redundant.
20171115 04:33:06< vultraz> and join is also double click
20171115 04:33:20< vultraz> only unique functionality is inline observe
20171115 04:33:23< celticminstrel> Double-click could also bring up a quick dialog letting you choose between join and observe.
20171115 04:33:35< vultraz> no, ni
20171115 04:33:37< vultraz> no*
20171115 04:36:00< vultraz> then there are complains I can do nothing about..
20171115 04:36:14< vultraz> like knowing if a mod is game-changing or not
20171115 04:36:22< vultraz> no damn thing I can do about that
20171115 04:39:29< vultraz> or the mods list thing gfg brought up
20171115 04:40:18< vultraz> i thought having mods inline would work, then i discovered it's possible to have a lot of mods and because of our half-broken UI toolkit that doesn't get properly truncated, and even if it did, data would still be lost
20171115 04:40:23< vultraz> what the hell am i supposed to do
20171115 04:41:22< vultraz> Idk, I feel rather salty here >_<
20171115 04:42:01< vultraz> It feels like I put effort into making a streamlined experience and the feedback is that people actually want everything shoved in there with the ability to brew their coffee and view a map of china
20171115 04:43:56< celticminstrel> You could allow everyone to choose what information they want shown in the list.
20171115 04:44:04< celticminstrel> Options are not always bad.
20171115 04:44:17< celticminstrel> (Personally I think they're usually not bad, but that's beside the point.)
20171115 04:44:28< vultraz> options are often bad
20171115 04:44:33< vultraz> is my opinion
20171115 04:44:40< vultraz> I prefer controlling the user experience
20171115 04:44:53< celticminstrel> Ugh.
20171115 04:45:00< vultraz> which I guess makes me very 21st century silicon valley-esq :P
20171115 04:45:17< vultraz> but either way, something like that is a whole lot of work to implement
20171115 04:49:45-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171115 04:53:59-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 255 seconds]
20171115 05:03:00< vultraz> anyway, I'll deal with it
20171115 05:03:06< vultraz> will think of something...
20171115 05:03:10-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20171115 05:06:49< celticminstrel> This is kind of a mess, but I'll try to finish it by tomorrow. If not, I'm not sure if I'll be able to get back into it again...
20171115 05:10:10< vultraz> what is?
20171115 05:10:27< celticminstrel> ai/formula/function_table.cpp
20171115 05:10:44< vultraz> what are you doing to it?
20171115 05:10:54< celticminstrel> Same thing you did in formula/function.cpp
20171115 05:11:57< vultraz> i see
20171115 05:12:26-!- travis-ci [~travis-ci@ec2-54-161-217-166.compute-1.amazonaws.com] has joined #wesnoth-dev
20171115 05:12:27< travis-ci> wesnoth/wesnoth#15610 (master - f759e4e : Celtic Minstrel): The build has errored.
20171115 05:12:27< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/302302055
20171115 05:12:27-!- travis-ci [~travis-ci@ec2-54-161-217-166.compute-1.amazonaws.com] has left #wesnoth-dev []
20171115 05:13:17-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20171115 05:35:10-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20171115 06:38:03-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171115 06:42:39-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds]
20171115 06:50:28-!- Bonobo [~Bonobo@14-203-49-124.tpgi.com.au] has joined #wesnoth-dev
20171115 07:18:57-!- irker896 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20171115 07:28:52-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20171115 07:57:24-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Read error: Connection reset by peer]
20171115 07:57:42-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20171115 08:06:09-!- atarocch [~atarocch@93.56.164.28] has quit [Remote host closed the connection]
20171115 08:07:54-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20171115 08:17:21-!- atarocch [~atarocch@93.56.164.28] has quit [Remote host closed the connection]
20171115 08:17:49-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20171115 08:20:05-!- atarocch [~atarocch@93.56.164.28] has quit [Remote host closed the connection]
20171115 08:20:37-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20171115 08:21:41-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20171115 08:24:34-!- atarocch [~atarocch@93.56.164.28] has quit [Remote host closed the connection]
20171115 08:25:02-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20171115 08:26:20-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171115 08:30:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 258 seconds]
20171115 08:49:21-!- atarocch [~atarocch@93.56.164.28] has quit [Remote host closed the connection]
20171115 08:49:54-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20171115 09:21:07-!- sevu [~Shiki@141.57.75.194] has joined #wesnoth-dev
20171115 10:02:25-!- sevu [~Shiki@141.57.75.194] has quit [Remote host closed the connection]
20171115 10:14:38-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171115 10:18:41-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20171115 10:54:03-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20171115 11:25:02-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171115 11:29:35-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds]
20171115 11:40:46-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20171115 11:40:46< Appveyor> wesnoth - Release gfgtdf 97a2328: fix unisgned comparision warning Failed
20171115 11:40:46< Appveyor> Details: https://ci.appveyor.com/project/gfgtdf/wesnoth/build/Wesnoth-VS2017-depcheck-65
20171115 11:40:51-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20171115 11:42:43-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20171115 12:02:45-!- Appveyor [~Appveyor@67.225.139.254] has joined #wesnoth-dev
20171115 12:02:45< Appveyor> wesnoth - Debug gfgtdf 97a2328: fix unisgned comparision warning Failed
20171115 12:02:45< Appveyor> Details: https://ci.appveyor.com/project/gfgtdf/wesnoth/build/Wesnoth-VS2017-depcheck-65
20171115 12:02:49-!- Appveyor [~Appveyor@67.225.139.254] has left #wesnoth-dev []
20171115 12:08:26-!- travis-ci [~travis-ci@ec2-54-196-121-106.compute-1.amazonaws.com] has joined #wesnoth-dev
20171115 12:08:27< travis-ci> gfgtdf/wesnoth#992 (depcheck - 97a2328 : gfgtdf): The build failed.
20171115 12:08:27< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/302430205
20171115 12:08:27-!- travis-ci [~travis-ci@ec2-54-196-121-106.compute-1.amazonaws.com] has left #wesnoth-dev []
20171115 12:46:24-!- irker799 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171115 12:46:24< irker799> wesnoth: sigurdfdragon wesnoth:master 431fc60e1bca / data/campaigns/The_South_Guard/scenarios/03_A_Desparate_Errand.cfg: TSG S03: Have elves be on their own side when appearing https://github.com/wesnoth/wesnoth/commit/431fc60e1bca97d8f7725c5f15b936761a599b35
20171115 12:46:24< irker799> wesnoth: sigurdfdragon wesnoth:master 08ea513130b8 / data/campaigns/The_South_Guard/scenarios/ (07b_Pebbles_in_the_Flood.cfg 08b_The_Tides_of_War.cfg): TSG: Remove redundant title in unit names https://github.com/wesnoth/wesnoth/commit/08ea513130b8d9cda9afe7c5a74830fa4352744c
20171115 12:46:24< irker799> wesnoth: sigurdfdragon wesnoth:master 0119f487a8ee / data/campaigns/The_South_Guard/scenarios/07b_Pebbles_in_the_Flood.cfg: TSG S07b: Make it explict when the defenses of Westin are strengthened https://github.com/wesnoth/wesnoth/commit/0119f487a8ee5c0d5b2068f062baad9647d55c64
20171115 12:46:25< irker799> wesnoth: sigurdfdragon wesnoth:master 78d3cb63911b / data/campaigns/The_South_Guard/scenarios/07b_Pebbles_in_the_Flood.cfg: TSG S07b: Fix erroneous dialog https://github.com/wesnoth/wesnoth/commit/78d3cb63911bb2889bf55b934c75416310ec6db4
20171115 12:46:27< irker799> wesnoth: sigurdfdragon wesnoth:master cc38b24c42de / data/campaigns/The_South_Guard/maps/07b_Pebbles_in_the_Flood.map: TSG S07b: Have undead use encampments instead of castle https://github.com/wesnoth/wesnoth/commit/cc38b24c42de452d1f9582c5d692b65a2c3ce4a7
20171115 12:46:29< irker799> wesnoth: sigurdfdragon wesnoth:master 84e205382f12 / data/campaigns/The_South_Guard/scenarios/07b_Pebbles_in_the_Flood.cfg: TSG S07b: Prevent Mal M'Brin from leaving his keep https://github.com/wesnoth/wesnoth/commit/84e205382f12baff59e2ac1efea49f92a5ebc60e
20171115 13:19:01-!- Appveyor [~Appveyor@67.225.139.254] has joined #wesnoth-dev
20171115 13:19:01< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release gfgtdf 879fae6: fix unisgned comparision warning Failed
20171115 13:19:01< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-539
20171115 13:19:06-!- Appveyor [~Appveyor@67.225.139.254] has left #wesnoth-dev []
20171115 14:01:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171115 14:14:49-!- travis-ci [~travis-ci@ec2-54-226-57-192.compute-1.amazonaws.com] has joined #wesnoth-dev
20171115 14:14:50< travis-ci> wesnoth/wesnoth#15614 (master - 84e2053 : sigurdfdragon): The build passed.
20171115 14:14:50< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/302464176
20171115 14:14:50-!- travis-ci [~travis-ci@ec2-54-226-57-192.compute-1.amazonaws.com] has left #wesnoth-dev []
20171115 14:34:27-!- travis-ci [~travis-ci@ec2-54-226-57-192.compute-1.amazonaws.com] has joined #wesnoth-dev
20171115 14:34:28< travis-ci> gfgtdf/wesnoth#993 (depcheck - b7783a4 : gfgtdf): The build has errored.
20171115 14:34:28< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/302482862
20171115 14:34:28-!- travis-ci [~travis-ci@ec2-54-226-57-192.compute-1.amazonaws.com] has left #wesnoth-dev []
20171115 14:35:49< Soliton> vultraz: it might be more useful to get good filtering of games implemented. f.e. it's less important if you can see all mods when you can filter out games with mods you don't like or just show games with the mod you want to play.
20171115 14:37:48< vultraz> right now you *can* filter on everything, but only by text via the filter box
20171115 14:38:09< vultraz> (all the relevant data is stored in one long string and the filter text looked for within >_< )
20171115 14:38:24< vultraz> but it might be nice to have a dedicated filter settings dialog, perhaps..
20171115 14:38:54< Soliton> well, that's already pretty good. you can probably not do negative filters with that though.
20171115 14:39:18< vultraz> there is an INvert Filter button
20171115 14:40:07< Soliton> ok, then you can already do a lot of simple stuff.
20171115 15:20:43-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171115 15:20:50-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171115 15:23:06-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20171115 15:29:47-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171115 15:29:55-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171115 15:36:15-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20171115 15:48:42-!- irker799 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20171115 15:58:23-!- Bonobo [~Bonobo@14-203-49-124.tpgi.com.au] has quit [Ping timeout: 248 seconds]
20171115 16:04:10-!- gfgtdf [~Daniel@x4e36910e.dyn.telefonica.de] has joined #wesnoth-dev
20171115 16:08:00< gfgtdf> vultraz: #2193 is ready to merge but it still crashes sometimes when you click on a game in that list tghat toggles a depcheck confirmation and then click no.
20171115 16:08:21< gfgtdf> vultraz: it doesn't seem to happen if you select an element of that list with a mouse.
20171115 16:09:58< gfgtdf> vultraz: do you know whether there is a known issue when changin a listboxs selection from a the callback, tht only happens if you change the selection by mouse ?
20171115 16:19:17< gfgtdf> oh i think i found the casue, hmm
20171115 16:46:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171115 16:58:14-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20171115 17:13:26-!- gfgtdf [~Daniel@x4e36910e.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20171115 17:20:07-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20171115 17:31:38-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20171115 17:32:07-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171115 17:32:58-!- travis-ci [~travis-ci@ec2-54-196-121-106.compute-1.amazonaws.com] has joined #wesnoth-dev
20171115 17:32:59< travis-ci> gfgtdf/wesnoth#994 (depcheck - 7617863 : gfgtdf): The build passed.
20171115 17:32:59< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/302547318
20171115 17:32:59-!- travis-ci [~travis-ci@ec2-54-196-121-106.compute-1.amazonaws.com] has left #wesnoth-dev []
20171115 17:36:25-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20171115 17:36:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171115 17:37:57-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Ping timeout: 240 seconds]
20171115 17:40:33-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20171115 17:50:10-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20171115 18:04:03-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20171115 18:18:31-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171115 18:19:59-!- amir|2 [~amir@public.metalab.wien.funkfeuer.at] has joined #wesnoth-dev
20171115 18:20:47< amir|2> how do i determine the winner of a game from a replay... any ideas?
20171115 18:21:49-!- travis-ci [~travis-ci@ec2-54-226-57-192.compute-1.amazonaws.com] has joined #wesnoth-dev
20171115 18:21:50< travis-ci> gfgtdf/wesnoth#995 (depcheck - bdcada3 : gfgtdf): The build has errored.
20171115 18:21:50< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/302550686
20171115 18:21:50-!- travis-ci [~travis-ci@ec2-54-226-57-192.compute-1.amazonaws.com] has left #wesnoth-dev []
20171115 18:52:25-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20171115 18:58:27-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20171115 19:04:26-!- irker245 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171115 19:04:26< irker245> wesnoth: Jyrki Vesterinen wesnoth:master 18e208e07c54 / data/gui/ (4 files in 2 dirs): Revert "GUI2: removed GUI_FORCE_WIDGET_SIZE macro in favor of fixed_width/fixed_ https://github.com/wesnoth/wesnoth/commit/18e208e07c544d922d845bfadbd74192772de19a
20171115 19:04:26< irker245> wesnoth: Jyrki Vesterinen wesnoth:master 506ee85d2d72 / / (7 files in 4 dirs): Revert "GUI2: implemented fixed_width and fixed_height keys for all widgets" https://github.com/wesnoth/wesnoth/commit/506ee85d2d72822b7c428302794e946d29ebb5e2
20171115 19:04:26< irker245> wesnoth: Jyrki Vesterinen wesnoth:master 7d1991a8d83c / src/gui/widgets/size_lock.cpp: Fix #2153: crash in MP lobby chat with low horizontal window size https://github.com/wesnoth/wesnoth/commit/7d1991a8d83cb8f34286644495351f0535c3c7d6
20171115 19:04:27< irker245> wesnoth: Jyrki Vesterinen wesnoth:master b0c139c16a56 / data/gui/widget/chatbox.cfg: Chatbox tabs can no longer shrink vertically https://github.com/wesnoth/wesnoth/commit/b0c139c16a56251f1cd09a6c65cc5591f8028e58
20171115 19:08:38-!- travis-ci [~travis-ci@ec2-54-161-217-166.compute-1.amazonaws.com] has joined #wesnoth-dev
20171115 19:08:39< travis-ci> gfgtdf/wesnoth#996 (depcheck - 4cc854e : gfgtdf): The build has errored.
20171115 19:08:39< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/302579857
20171115 19:08:39-!- travis-ci [~travis-ci@ec2-54-161-217-166.compute-1.amazonaws.com] has left #wesnoth-dev []
20171115 19:39:13-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20171115 19:42:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171115 19:48:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20171115 19:53:57-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:8891:c43f:25db:2d8b] has joined #wesnoth-dev
20171115 19:54:39-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20171115 19:55:38< vultraz> Gfgtdf : did you make sure to set handled/half to true in the callback if it changes category and thus removes the clicked row.
20171115 19:56:42-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171115 20:50:42-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20171115 21:01:30-!- travis-ci [~travis-ci@ec2-54-226-57-192.compute-1.amazonaws.com] has joined #wesnoth-dev
20171115 21:01:31< travis-ci> wesnoth/wesnoth#15620 (master - b0c139c : Jyrki Vesterinen): The build has errored.
20171115 21:01:31< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/302643958
20171115 21:01:31-!- travis-ci [~travis-ci@ec2-54-226-57-192.compute-1.amazonaws.com] has left #wesnoth-dev []
20171115 21:07:37-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20171115 21:07:42-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!]
20171115 21:08:43-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20171115 21:08:58-!- fabi [~fabi@2a02:810c:c840:2e65:1854:7422:e130:fa62] has joined #wesnoth-dev
20171115 21:08:58-!- fabi [~fabi@2a02:810c:c840:2e65:1854:7422:e130:fa62] has quit [Changing host]
20171115 21:08:58-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20171115 21:09:18-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171115 21:11:47-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20171115 21:16:19-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:8891:c43f:25db:2d8b] has quit [Remote host closed the connection]
20171115 21:25:46-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...]
20171115 21:26:22-!- Ivanovic [~ivanovic@p579FBEDC.dip0.t-ipconnect.de] has joined #wesnoth-dev
20171115 21:26:22-!- Ivanovic [~ivanovic@p579FBEDC.dip0.t-ipconnect.de] has quit [Changing host]
20171115 21:26:22-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20171115 21:52:18-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171115 21:53:09-!- amir|2 [~amir@public.metalab.wien.funkfeuer.at] has quit [Ping timeout: 252 seconds]
20171115 21:57:45-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20171115 21:57:51-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171115 21:58:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20171115 21:58:20-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171115 22:01:22-!- sigurdfd [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20171115 22:02:05-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20171115 22:06:18-!- irker245 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20171115 22:13:59-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171115 22:14:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171115 22:22:40-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20171115 22:27:41-!- vultraz changed the topic of #wesnoth-dev to: 1.13.11 (1.14 Beta 3) scheduled for Sunday, Nov. 19th, 00:01 AM | Wesnoth Developers Channel | >>> Want to help? Go here: https://r.wesnoth.org/t42911 (and thanks!) <<< | Discord Server: https://discord.gg/tSmJS2E | Logs: http://irclogs.wesnoth.org | Bug tracker: https://bugs.wesnoth.org
20171115 22:49:16-!- irker700 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171115 22:49:16< irker700> wesnoth: gfgtdf wesnoth:master 2f1c1e38362f / src/ (5 files in 2 dirs): fix mp depckeck https://github.com/wesnoth/wesnoth/commit/2f1c1e38362ff8336b15dc622d5a8ea5ea04e0d9
20171115 22:49:16< irker700> wesnoth: gfgtdf wesnoth:master fe253d5779ac / src/ (4 files in 3 dirs): small create_engine simplification https://github.com/wesnoth/wesnoth/commit/fe253d5779ac75be4901762873f57dde20f1b430
20171115 22:49:17< irker700> wesnoth: gfgtdf wesnoth:master 775970f9209a / src/gui/ (9 files in 2 dirs): fix recrision in gui2 mp create depckeck https://github.com/wesnoth/wesnoth/commit/775970f9209a423f0f0d383c0d7634ae722f825b
20171115 22:49:18< irker700> wesnoth: gfgtdf wesnoth:master d20dcc2caad7 / src/gui/dialogs/multiplayer/ (mp_create_game.cpp mp_create_game.hpp): fix mod_list/eras not found in mp create https://github.com/wesnoth/wesnoth/commit/d20dcc2caad7d1ca39bbeab18ca36e9daed45996
20171115 22:49:19< irker700> wesnoth: gfgtdf wesnoth:master 7617863d95e1 / src/gui/dialogs/multiplayer/mp_create_game.cpp: fix unisgned comparision warning https://github.com/wesnoth/wesnoth/commit/7617863d95e19278ef24f8088e522c35f2237fbe
20171115 22:49:20< irker700> wesnoth: gfgtdf wesnoth:master bdcada31bba1 / src/gui/dialogs/multiplayer/mp_create_game.cpp: mp create: add debug output https://github.com/wesnoth/wesnoth/commit/bdcada31bba193e828be62d92fb32d92152c09ad
20171115 22:49:22< irker700> wesnoth: gfgtdf wesnoth:master 4cc854e9ea88 / src/gui/dialogs/multiplayer/mp_create_game.cpp: fix ub in mp create https://github.com/wesnoth/wesnoth/commit/4cc854e9ea88fe60ef963264fc4675d3d163c1f9
20171115 22:49:24< irker700> wesnoth: gfgtdf wesnoth:master 320bdd9d4057 / src/ (13 files in 4 dirs): Merge pull request #2193 from gfgtdf/depcheck https://github.com/wesnoth/wesnoth/commit/320bdd9d4057736c8862ed5c4565316c35fd6821
20171115 23:28:06-!- yaiyan [~yaiyan@46.101.48.31] has quit [Ping timeout: 246 seconds]
20171115 23:29:57-!- yaiyan [~yaiyan@46.101.48.31] has joined #wesnoth-dev
20171115 23:42:16-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20171115 23:53:47< irker700> wesnoth: Alexander van Gessel wesnoth:master ca0b5033f06a / data/campaigns/Heir_To_The_Throne/utils/abilities.cfg: Don't break recall/traitless-recruit undo (Fixes #2196) https://github.com/wesnoth/wesnoth/commit/ca0b5033f06ad83868dc569e973897083042f90b
20171115 23:54:41-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 248 seconds]
--- Log closed Thu Nov 16 00:00:15 2017