--- Log opened Sat Nov 18 00:00:22 2017
20171118 00:03:59-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20171118 00:15:14-!- Bonobo [~Bonobo@14-203-49-124.tpgi.com.au] has joined #wesnoth-dev
20171118 00:16:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20171118 00:16:47-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171118 00:18:37-!- travis-ci [~travis-ci@ec2-54-234-76-147.compute-1.amazonaws.com] has joined #wesnoth-dev
20171118 00:18:38< travis-ci> gfgtdf/wesnoth#997 (master - 4e8dedb : gfgtdf): The build is still failing.
20171118 00:18:38< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/303781467
20171118 00:18:38-!- travis-ci [~travis-ci@ec2-54-234-76-147.compute-1.amazonaws.com] has left #wesnoth-dev []
20171118 00:18:59-!- irker853 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20171118 00:21:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 255 seconds]
20171118 00:27:28-!- sigurdfd [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20171118 00:32:35-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20171118 00:46:00-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20171118 00:46:22< celticminstrel> VSCode seems like it'll be tolerable, provided I can set it to a bright theme or something.
20171118 00:50:25< vultraz> bright theme?
20171118 00:50:29< vultraz> bright themes are bad for your eyes
20171118 00:53:45< vultraz> celticminstrel: but yes. ctrl K, ctrl T
20171118 01:22:24< celticminstrel> Yeah, already found it, thanks.
20171118 01:22:52< celticminstrel> I really don't like those multistroke chords though...
20171118 01:49:25-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171118 01:49:33-!- janebot [~Gambot@grickit.us] has joined #wesnoth-dev
20171118 01:49:44-!- janebot [~Gambot@grickit.us] has quit [Changing host]
20171118 01:49:44-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171118 02:18:47-!- travis-ci [~travis-ci@ec2-54-234-76-147.compute-1.amazonaws.com] has joined #wesnoth-dev
20171118 02:18:48< travis-ci> gfgtdf/wesnoth#998 (master - 2e6e0db : gfgtdf): The build was fixed.
20171118 02:18:48< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/303809425
20171118 02:18:48-!- travis-ci [~travis-ci@ec2-54-234-76-147.compute-1.amazonaws.com] has left #wesnoth-dev []
20171118 02:38:55-!- gfgtdf_ [~chatzilla@x4e36316e.dyn.telefonica.de] has joined #wesnoth-dev
20171118 02:40:47-!- gfgtdf [~chatzilla@x4e36953f.dyn.telefonica.de] has quit [Ping timeout: 255 seconds]
20171118 02:40:50-!- gfgtdf_ is now known as gfgtdf
20171118 02:48:49-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20171118 03:30:09-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 248 seconds]
20171118 03:38:35-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev
20171118 04:22:59-!- gfgtdf [~chatzilla@x4e36316e.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.5.0/20171107091003]]
20171118 04:55:07-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171118 04:55:14-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171118 05:02:29-!- sigurdfd [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has quit []
20171118 06:41:33-!- TadCarlucci [~lundberg@74.193.219.119] has joined #wesnoth-dev
20171118 06:42:24-!- TadCarlucci [~lundberg@74.193.219.119] has quit [Client Quit]
20171118 07:22:03-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20171118 07:23:43-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 248 seconds]
20171118 07:26:23-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 248 seconds]
20171118 07:27:53-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20171118 08:14:24-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20171118 08:15:07-!- celticminstrel is now known as celmin|sleep
20171118 08:18:39-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 248 seconds]
20171118 08:18:40-!- wedge010 is now known as wedge009
20171118 08:38:52-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20171118 09:22:27-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20171118 10:00:00-!- vultraz changed the topic of #wesnoth-dev to: 1.13.11 (1.14 Beta 3) postponed until bug #2203 is fixed | Wesnoth Developers Channel | >>> Want to help? Go here: https://r.wesnoth.org/t42911 (and thanks!) <<< | Discord Server: https://discord.gg/tSmJS2E | Logs: http://irclogs.wesnoth.org | Bug tracker: https://bugs.wesnoth.org
20171118 10:04:49-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20171118 10:06:51-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20171118 10:09:10-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20171118 10:45:51-!- mjs-de [~mjs-de@x4db6c844.dyn.telefonica.de] has joined #wesnoth-dev
20171118 11:27:33-!- amir|2 [~amir@public.metalab.wien.funkfeuer.at] has joined #wesnoth-dev
20171118 11:31:35< amir|2> Could some please enlighten me on the connection of .po files default.cfg and cpp code?
20171118 11:31:56< amir|2> i try to add a menu item to the in-game "Menu"
20171118 11:57:54< vultraz> What?
20171118 11:58:43< amir|2> i can see that there are translations in po files and i can see that menus are defined in cfg files and somehow they gotta be referenced in cpp code
20171118 11:58:48< amir|2> but i don't get how
20171118 11:59:17< amir|2> e.g.: where is the in-game menu defined
20171118 12:08:47< vultraz> oh, yeah, that's pretty complicated
20171118 12:09:09< vultraz> data/themes/default.cfg defines the *hotkey ids* that show up in the various menus
20171118 12:09:48< vultraz> then you need to look in src/hotkey/hotkey_command.cfg for all the built-in hotkey types
20171118 12:16:32-!- iwaim_ [~iwaim@2001:2c0:40e:2002:eca0:5e6a:f5c1:effb] has joined #wesnoth-dev
20171118 12:16:51-!- iwaim [~iwaim@2001:2c0:40e:2002:0:4:14:80] has quit [Ping timeout: 246 seconds]
20171118 12:28:48-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20171118 12:31:32-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 268 seconds]
20171118 12:31:33-!- wedge010 is now known as wedge009
20171118 12:35:36-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20171118 13:08:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171118 13:08:27-!- mjs-de [~mjs-de@x4db6c844.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20171118 13:25:51-!- Bonobo [~Bonobo@14-203-49-124.tpgi.com.au] has quit [Ping timeout: 248 seconds]
20171118 13:34:28-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20171118 13:34:56-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 248 seconds]
20171118 13:34:56-!- wedge010 is now known as wedge009
20171118 13:36:15< amir|2> thx
20171118 13:39:51-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20171118 14:08:58-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20171118 14:14:01-!- TadCarlucci [~lundberg@74.193.219.119] has joined #wesnoth-dev
20171118 14:15:21< TadCarlucci> Soap__, ping. Go easy on me, the first pot of the day is still brewing.
20171118 14:22:54< amir|2> that's what i did, but the item still doesn't show up: https://gist.github.com/kallaballa/663bb68a804dfdbb5410598d0ce74b16
20171118 14:22:57< amir|2> what did i miss?
20171118 14:30:19< TadCarlucci> vultraz, you awake?
20171118 14:32:24< vultraz> Yes, and arguing with people on twitter
20171118 14:32:26< vultraz> What’s up?
20171118 14:38:41< vultraz> TadCarlucci:
20171118 14:42:19< amir|2> I found the problem... i used the wrong category. adding it to HKCAT_SCENARIO did the trick
20171118 14:42:33< amir|2> so.. how do i bind c++ code to the hotkey?
20171118 14:43:41< TadCarlucci> vultraz, Ah, well, I decided to write my thoughts in an issue. I'll be getting on it once other jobs in the queue (coffee and breakfast, mainly) complete.
20171118 14:43:45< Soap__> TadCarlucci: I'll try to :P
20171118 14:44:01< JyrkiVesterinen> amir|2: https://github.com/wesnoth/wesnoth/blob/master/src/hotkey/command_executor.cpp#L75
20171118 14:44:05< Soap__> TadCarlucci: I get the .mo generation stuff and will fix that
20171118 14:44:16< Soap__> what I still dont quite get is the installation thing
20171118 14:44:19< amir|2> JyrkiVesterinen: thx!
20171118 14:45:03< Soap__> on unix, standard FHS strongly recommends /usr/share/locale for i18n
20171118 14:46:37< Soap__> (which what GNUInstallDirs does)
20171118 14:47:10< Soap__> but it seems like LOCALE_INSTALL before my change never got written into any executables
20171118 14:47:13< TadCarlucci> Soap__, I know but we don't want to turn a small cleanup into a monster PITA when we're counting down to a release. Let's revert that portion, then we can hash out the problem when we have more time, and can some more eyes on it earlier.
20171118 14:47:53< Soap__> oh, so I am right?
20171118 14:48:00< Soap__> the current installation is not FHS-y?
20171118 14:48:44< Soap__> ok, let me put the stuff back in place
20171118 14:49:48< TadCarlucci> I openned an Issue, be sure to reference it in the PR. Once you're done, open a new Issue on the translation subject and we'll work it out in a later release cycle
20171118 14:53:42-!- mjs-de [~mjs-de@x4db6c844.dyn.telefonica.de] has joined #wesnoth-dev
20171118 15:00:50< amir|2> do i need to handle quit_confirmation::blockers?
20171118 15:01:55< amir|2> i mean in a surrender dialog
20171118 15:02:21< Soap__> TadCarlucci: https://github.com/wesnoth/wesnoth/compare/master...SoapGentoo:locale-fixes
20171118 15:02:35< Soap__> before I burn the planet with all the travis builds :D
20171118 15:04:48< TadCarlucci> A read-through looks good. How about you do a diff to the HEAD just before 1725 merged and proof-read the net changes which actually applied?
20171118 15:05:25< TadCarlucci> Mainly when I do that I'm looking for a missed change for the revert
20171118 15:06:39< vultraz> TadCarlucci: btw, do you ever intend to hang out on our discord?
20171118 15:07:44< Soap__> TadCarlucci: https://github.com/wesnoth/wesnoth/compare/e8cd3df79a13bc5874173d33848041aade1cc037...SoapGentoo:locale-fixes
20171118 15:07:57< Soap__> looks good to me
20171118 15:08:05< Soap__> but remember, its not a 1:1 revert
20171118 15:08:14< Soap__> I wanted to keep some of the GNUInstallDir stuff
20171118 15:08:45< TadCarlucci> On travis: my build farm does g++ vs clang++ and release vs debug and scons vs cmake and I get all 8 runs in the time travis does 2 or 3 so I'll feed the PR into my farm before I merge
20171118 15:09:10< TadCarlucci> Both changesets look good to me. Push up your PR and I'll start the local build here
20171118 15:11:31< Soap__> TadCarlucci: https://github.com/wesnoth/wesnoth/pull/2212
20171118 15:12:31< TadCarlucci> vultraz, When I'm on Windows I have Discord available. There was an issue with it on Arch Linux and I took it off and have never replaced it. Remeber, I'm a greyed-white neck-beard and often don't see the improvement of all this new-fangled glittery stuff
20171118 15:14:02< Soap__> TadCarlucci: why does wesnoth even use scons?
20171118 15:14:08< Soap__> shouldnt cmake cover all use cases?
20171118 15:14:20< Soap__> I say this because I consider scons quite a nightmare to work with
20171118 15:15:50< TadCarlucci> Soap__, religion. It was asked a month or so ago why we don't drop cmake and I killed it because so many editors and ides support cmake and not scons
20171118 15:15:59< JyrkiVesterinen> TadCarlucci: Does anything block you from simply using Discord via the website (like I do when I'm on GNU/Linux)?
20171118 15:16:28< Soap__> scons is awful - a fully updated tree takes O(n²) time to check if it needs updating
20171118 15:16:44< Soap__> TadCarlucci: have you checked out meson?
20171118 15:16:50< JyrkiVesterinen> IMHO, SCons is far superior to CMake from a developer's point of view.
20171118 15:16:58< Soap__> JyrkiVesterinen: thats exactly the problem
20171118 15:17:12< JyrkiVesterinen> Python is a much better programming language to work with than CMake's custom language.
20171118 15:17:15< Soap__> scons is a downstream nightmare
20171118 15:17:21< Soap__> JyrkiVesterinen: have a look at meson
20171118 15:17:39< Soap__> it has a python-esquey syntax without being as broken as scons
20171118 15:18:41< TadCarlucci> See? Religion. Personally, I just accept it and try to keep both working so everyone is happy.
20171118 15:19:00< Soap__> well, meson vs scons is like science vs religion :P
20171118 15:19:56 * TadCarlucci hums "Don't know, don't care" but the Sound of Music is what's in his head, so you can't tell.
20171118 15:23:33< TadCarlucci> You young'ns can argue it out. I'll just sit here and remember how great it was when Autotools et al. appeared.
20171118 15:23:59< amir|2> I've got the surrender hotkey and dialog working.... how do i access units of the current game
20171118 15:24:19< Soap__> TadCarlucci: tbh, I still prefer Autotools over CMake
20171118 15:24:34< Soap__> mainly because Automake shoves all the GNU conventions down your throat
20171118 15:24:48< Soap__> which for better or worse, means we dont have to hack up every var
20171118 15:24:48< TadCarlucci> Soap__, I tend to hand-write my Makefiles and sleep happy
20171118 15:25:08< amir|2> TadCarlucci: lol
20171118 15:26:03< Soap__> Automake 1.15 is fine
20171118 15:26:12< Soap__> back in the 1.5 days it was awful
20171118 15:26:27< Soap__> but nowadays most of the weird corner cases bugs are gone
20171118 15:29:38< TadCarlucci> Well, back-in-the-day it was a mess getting it to work on all the unixen. SVr4, AIX, SunOS, Solarus, BSD, all those Linux packages. My life is so much easier now-a-days when all I care about is Arch and that the wife's Window 10 box stays running.
20171118 15:31:36< Soap__> TadCarlucci: I agree, (although the issue for that was mainly autoconf, not automake)
20171118 15:31:46< Soap__> I prefer it because it presents a uniform interface
20171118 15:31:52< Soap__> everyeone knows ./configure
20171118 15:32:00< Soap__> every handwritten makefile is different
20171118 15:37:56< vultraz> I avoid all that by not using Linux :P
20171118 15:38:27< Soap__> vultraz: you need build systems that generalise across OSes
20171118 15:38:42< Soap__> and only cmake and meson really do
20171118 15:39:05< amir|2> any hint on how to access units of the current game to implement the surrender feature?
20171118 15:39:54< vultraz> amir|2: look at the unit list dialog
20171118 15:40:00< vultraz> should be some reference there
20171118 15:40:06< amir|2> thx!
20171118 15:42:21-!- DeFender1031 [~DeFender1@89-139-219-165.bb.netvision.net.il] has joined #wesnoth-dev
20171118 15:43:29< JyrkiVesterinen> https://github.com/wesnoth/wesnoth/blob/master/src/game_board.hpp#L98
20171118 15:52:46< vultraz> " * As seen in the examples above the iterator doesn't look like a iterator in
20171118 15:52:46< vultraz>  * the C++ standard library. The iterator is more designed after the iterator
20171118 15:52:46< vultraz>  * design of the Gang of Four [GoF]."
20171118 15:53:00< vultraz> leave it to mordante to make you read a book to understand his code -_-
20171118 16:08:41< amir|2> lol
20171118 16:10:32< amir|2> i tried getting the gameboard by using resources.hpp... but those are forward declarations.. how do i do it correctly?
20171118 16:11:41-!- iwaim_ [~iwaim@2001:2c0:40e:2002:eca0:5e6a:f5c1:effb] has quit [Ping timeout: 255 seconds]
20171118 16:12:04-!- iwaim_ [~iwaim@rasteenie.alib.jp] has joined #wesnoth-dev
20171118 16:13:16< JyrkiVesterinen> vultraz: Well, that book is quite important for software development. For example, I had to buy it during my education (and still have it, in fact).
20171118 16:13:25< amir|2> oh.. my mistake
20171118 16:13:59< vultraz> I see
20171118 16:14:19< TadCarlucci> Soap__, Looks good for in-tree (defaults) SCons and CMake agree the .mo files are built and not remaking without cause nor poluting ~/po directory. Let me do my out-of-tree farm and if it agrees, I'll merge. Travis and Appveyor will be happy because this doesn't change executables
20171118 16:14:24< JyrkiVesterinen> amir|2: resources::gameboard is indeed a perfectly valid way to obtain a reference to the gameboard.
20171118 16:14:42< amir|2> i know.. i forgot the game_board header
20171118 16:18:56-!- mjs-de [~mjs-de@x4db6c844.dyn.telefonica.de] has quit [Remote host closed the connection]
20171118 16:20:24< amir|2> is there an alternative way to find the current side index except using display
20171118 16:21:34< Soap__> TadCarlucci: k
20171118 16:22:01< Soap__> TadCarlucci: also imo, the HAS_RELATIVE_LOCALEDIR should be removed
20171118 16:22:14< Soap__> using relative lookups in C is super brittle
20171118 16:22:34< Soap__> because it always depends on the value of $PWD
20171118 16:23:09< JyrkiVesterinen> It's very important on Windows in my opinion.
20171118 16:23:28< TadCarlucci> Soap__, JyrkiVesterinen yes to both.
20171118 16:23:29< Soap__> JyrkiVesterinen: the windows lookup uses a different macro path
20171118 16:23:39< Soap__> windows is the only exception really
20171118 16:23:45< Soap__> on unix its too dodgy
20171118 16:23:51< JyrkiVesterinen> Directories being relative allow the game to be run from a USB drive whose drive letter can change (when the player plays on different PCs).
20171118 16:23:51 * TadCarlucci chuckles
20171118 16:23:53< Soap__> I've seen too many failures with it
20171118 16:24:12< TadCarlucci> Windows is **ALWAYS** the exception, even if its to 'did it wrong'
20171118 16:24:29< Soap__> TadCarlucci: well, its 90% "did it wrong" :P
20171118 16:24:53< Soap__> UTF-16, how it does absolute vs relative, case insensitive WinAPI, ...
20171118 16:24:55< JyrkiVesterinen> AFAIK, the lead designer of Windows NT (Dave Cutler) disliked the Unix design and therefore ended up doing everything he could in a different way.
20171118 16:25:05< JyrkiVesterinen> So, it was largely intentional.
20171118 16:26:31< Soap__> JyrkiVesterinen: like how every OS under the sun can generally be used with UTF-8, except windows
20171118 16:26:41< TadCarlucci> Then after they'd done everything they could to be different, they added the Posix layer and fix it, and fixed it, until now we have WSL and can run Linux binaries and ignore Windows even when running windows.
20171118 16:27:00< JyrkiVesterinen> Well, they were trying to be forward-compatible with Unicode.
20171118 16:27:15< JyrkiVesterinen> In early 1990s, UTF-16 looked like the most future-proof option.
20171118 16:27:17< Soap__> how about adding u8_blabla APIs then?
20171118 16:27:27< Soap__> admittedly, java also made the same mistake
20171118 16:28:35< TadCarlucci> Windowns and *A and *W alternates to functions so they have Unicode (UTF-16) instead of Unicode (UTF-8)
20171118 16:28:45< TadCarlucci> s/and/has/
20171118 16:28:59< JyrkiVesterinen> *A is ANSI, with locale-specific code pages.
20171118 16:29:21< TadCarlucci> Yep and glad we don't have that as the ONLY option any more.
20171118 16:30:17< Soap__> yes, windows doesnt have true UTF-8
20171118 16:30:48< TadCarlucci> What I meant we, painful as it is, Windows has Unicode and you just have to learn to adapt because it's not UTF-8. Makes it a pain but it's what it is.
20171118 16:31:07< amir|2> how do i kill a unit... take_hit?
20171118 16:31:37< TadCarlucci> amin what context
20171118 16:31:48< TadCarlucci> amir|2, in what context?
20171118 16:32:07< amir|2> i get the unit map from game_board and i want to kill some units
20171118 16:32:15< amir|2> cpp context
20171118 16:32:20< Soap__> TadCarlucci: but then every windows-facing interface needs to convert std::string to std::wstring on the fly?
20171118 16:32:39< Soap__> (Never mind that std::wstring is an awful ill-defined contract)
20171118 16:34:16< TadCarlucci> Soap__, dunno. Haven't done any serious Windows work for over a decade. Nowadays, if I do, it's web-facing and UTF-8 and en_US only.
20171118 16:34:27< JyrkiVesterinen> amir|2: Here is one implementation: https://github.com/wesnoth/wesnoth/blob/d98d7aa80c5c63fce78649ea0ad3271df371c04d/src/synced_commands.cpp#L539
20171118 16:34:42< JyrkiVesterinen> The highlighted line is the one that actually removes the unit from the map.
20171118 16:35:48< JyrkiVesterinen> Soap__: Yes, you need to convert to wstring if you need to call Windows APIs directly for some reason. The need to call them is quite rare, though.
20171118 16:36:22-!- irker455 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171118 16:36:22< irker455> wesnoth: David Seifert wesnoth:master 0f2b585fc5b2 / CMakeLists.txt po/CMakeLists.txt: Bring back `LOCALEDIR` https://github.com/wesnoth/wesnoth/commit/0f2b585fc5b2660fc1ddf420415e35ea8f3a587f
20171118 16:36:56< amir|2> JyrkiVesterinen: that does erase them from the board which != kill
20171118 16:37:28< JyrkiVesterinen> The entire function is the full kill operation. Triggering WML events, animations and the like.
20171118 16:37:48< Soap__> TadCarlucci: neither have I luckily, but sometimes people want to use my stuff on windows, and there's one ugly call site that needs horrible macro conditionals :/
20171118 16:37:53< amir|2> oohh
20171118 16:40:00< TadCarlucci> Soap__, we be done. start any Issues you'd like for future work on deployment for the Linux side, whenever. I'm outa here to ta-ta the sick wife who's been glaring at me since breakfast ...
20171118 16:40:14-!- TadCarlucci [~lundberg@74.193.219.119] has quit [Quit: Leaving]
20171118 16:47:16< amir|2> it works! :D
20171118 16:52:00< irker455> wesnoth: Celtic Minstrel wesnoth:master 9e20250e9301 / src/ (7 files in 3 dirs): Finish deploying DEFINE_WFL_FUNCTION macro https://github.com/wesnoth/wesnoth/commit/9e20250e9301a6c6a5450bf576761f5d4fc2ce32
20171118 16:52:02< irker455> wesnoth: Celtic Minstrel wesnoth:master 48178adb9f77 / src/formula/function.cpp: Add string insert function for WFL https://github.com/wesnoth/wesnoth/commit/48178adb9f77803197a7665a70427a4df801b4c8
20171118 16:52:32< celmin|sleep> vultraz: Please test the insert function and add a changelog entry.
20171118 16:52:36-!- celmin|sleep is now known as celticminstrel
20171118 16:53:59< amir|2> here is the commit: https://github.com/kallaballa/wesnoth/commit/bd4a8b993b17aa714425d439af451e98a7d98f77
20171118 16:54:01< amir|2> what do you think?
20171118 16:55:50< amir|2> shoud i do a pull request?
20171118 16:59:07< celticminstrel> I have a feeling it might not be sufficient, but it's definitely a good start and should be able to work for 99% of scenarios.
20171118 16:59:21< JyrkiVesterinen> I see a couple minor issues in your code.
20171118 16:59:48< celticminstrel> I'm not sure if there exist scenarios where you don't lose even after you have no units left, though.
20171118 16:59:57< celticminstrel> Still, it's probably possible?
20171118 16:59:59< JyrkiVesterinen> Instead of the doSurrender variable, just do "if(!blocker_->prompt_()) { return; }"
20171118 17:01:40< JyrkiVesterinen> And move "resources::screen->redraw_minimap()", "resources::whiteboard->on_kill_unit()" and "actions::recalculate_fog(dying_side)" to after the loop.
20171118 17:02:30< Ravana_> surrender event must be possible to filter from wml
20171118 17:07:43< matthiaskrgr> new compiler warnings
20171118 17:07:48< matthiaskrgr> ../src/formula/function.cpp:455:39: warning: comparison of integers of different signs: 'int' and 'std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::size_type' (aka 'unsigned long') [-Wsign-compare]
20171118 17:07:52< matthiaskrgr>         } else if(static_cast<size_t>(offset >= result.size())) {
20171118 17:07:55< matthiaskrgr>                                       ~~~~~~ ^  ~~~~~~~~~~~~~
20171118 17:08:29< celticminstrel> It's just a misplaced parenthesis.
20171118 17:08:35< matthiaskrgr> ok
20171118 17:08:36< celticminstrel> Should be (offset)
20171118 17:08:43< amir|2> celticminstrel: i mosty care about ladder games. for those it should work
20171118 17:08:53< amir|2> JyrkiVesterinen: gonna fix it
20171118 17:10:44< irker455> wesnoth: Jyrki Vesterinen wesnoth:master c6806139967e / src/formula/function.cpp: Fix misplaced parenthesis https://github.com/wesnoth/wesnoth/commit/c6806139967e1eae9388126f52545743bcc54528
20171118 17:11:28< amir|2> is it possible to explicitly state the fact that someone surrendered in replay files?
20171118 17:27:45-!- amir|2 [~amir@public.metalab.wien.funkfeuer.at] has quit [Ping timeout: 252 seconds]
20171118 17:34:15-!- amir|2 [~amir@public.metalab.wien.funkfeuer.at] has joined #wesnoth-dev
20171118 17:35:40< amir|2> and another question... how do i end the turn of a side? i tried it via gameboard::end_turn but that didn't have an effect
20171118 17:59:49-!- mjs-de [~mjs-de@x4db6c844.dyn.telefonica.de] has joined #wesnoth-dev
20171118 18:09:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20171118 18:11:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171118 18:30:13-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20171118 18:38:23-!- sigurdfd [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20171118 18:39:40< irker455> wesnoth: sigurdfdragon wesnoth:master 44f42b0fc5fc / utils/pofix.py: Update pofix.py https://github.com/wesnoth/wesnoth/commit/44f42b0fc5fc150688ae7b32fd7af8638d87a2f5
20171118 19:01:42< irker455> wesnoth: sigurdfdragon wesnoth:master 22492fc1b55b / data/campaigns/Delfadors_Memoirs/scenarios/19_Showdown_in_the_Northern_Swamp.cfg: DM S19: Have either undead or Delfador be able to kill Iliah-Malal https://github.com/wesnoth/wesnoth/commit/22492fc1b55ba0c1a49164e1d02aa6d884bc80b0
20171118 19:01:44< irker455> wesnoth: sigurdfdragon wesnoth:master 8ba4e33e7ab1 / data/campaigns/Delfadors_Memoirs/scenarios/19_Showdown_in_the_Northern_Swamp.cfg: DM S19: Fix dialog https://github.com/wesnoth/wesnoth/commit/8ba4e33e7ab176daa37dafc7363c4b1e1529a2c0
20171118 19:01:46< irker455> wesnoth: sigurdfdragon wesnoth:master 7c276059ea4a / changelog players_changelog: Update changelogs https://github.com/wesnoth/wesnoth/commit/7c276059ea4a3d1f5f7080f60457a06bc321749e
20171118 19:03:14-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:954c:4d11:4bb8:ec08] has joined #wesnoth-dev
20171118 19:13:09< irker455> wesnoth: Jyrki Vesterinen wesnoth:rewrite-link-handling 6af2c1f9a63f / src/font/ (pango/hyperlink.hpp text.cpp text.hpp): Rewrite the link detection code https://github.com/wesnoth/wesnoth/commit/6af2c1f9a63f9fde134988a28e9b43ac283f377e
20171118 19:22:27-!- sigurdfd [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has quit [Read error: Connection reset by peer]
20171118 19:23:05-!- sigurdfd [sigurdfd@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20171118 20:06:51-!- sigurdfd [sigurdfd@dynamic-acs-72-23-110-196.zoominternet.net] has quit []
20171118 20:14:07< irker455> wesnoth: Jyrki Vesterinen wesnoth:master 2ad0715d7f01 / src/commandline_options.cpp: Update --help text about FPS-related options https://github.com/wesnoth/wesnoth/commit/2ad0715d7f013903d1bb97088f038a96a8df2a5c
20171118 20:14:09< irker455> wesnoth: Jyrki Vesterinen wesnoth:master 01835123fe76 / src/wesnoth.cpp: Windows: if a CMD switch immediately exits, wait for an Enter press https://github.com/wesnoth/wesnoth/commit/01835123fe76788130525c9e15738636c478207b
20171118 20:19:30-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20171118 20:21:19-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:954c:4d11:4bb8:ec08] has quit [Remote host closed the connection]
20171118 20:41:17-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:954c:4d11:4bb8:ec08] has joined #wesnoth-dev
20171118 20:44:16< amir|2> i fixed the issues: https://github.com/kallaballa/wesnoth/commit/35612859ccbfac194072cec1d87369c1066058dd
20171118 20:50:38-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:954c:4d11:4bb8:ec08] has quit [Remote host closed the connection]
20171118 20:51:13-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:954c:4d11:4bb8:ec08] has joined #wesnoth-dev
20171118 20:51:23< amir|2> created a pull request: https://github.com/wesnoth/wesnoth/pull/2215
20171118 20:51:41< vultraz> thanks, we'll review it :)
20171118 20:52:27< amir|2> thx!
20171118 20:54:33-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20171118 20:55:33-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:954c:4d11:4bb8:ec08] has quit [Ping timeout: 246 seconds]
20171118 21:05:03-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:954c:4d11:4bb8:ec08] has joined #wesnoth-dev
20171118 21:07:25-!- travis-ci [~travis-ci@ec2-54-205-121-100.compute-1.amazonaws.com] has joined #wesnoth-dev
20171118 21:07:26< travis-ci> wesnoth/wesnoth#15657 (rewrite-link-handling - 6af2c1f : Jyrki Vesterinen): The build failed.
20171118 21:07:26< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/304061925
20171118 21:07:26-!- travis-ci [~travis-ci@ec2-54-205-121-100.compute-1.amazonaws.com] has left #wesnoth-dev []
20171118 21:12:25-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171118 21:12:33-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171118 21:13:08< zookeeper> amir|2, why did you decide to have it kill all the player's units?
20171118 21:13:49< amir|2> zookeeper: because that's the safest way to insure a losing condition is met.
20171118 21:14:03< amir|2> Soliton proposed it and i think it's a good idea
20171118 21:15:21< zookeeper> okay. it does seem like something that's likely to mess up things in special scenarios where you have some special unkillable units on your side, or simply due to all die events presumably triggering.
20171118 21:15:53-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:954c:4d11:4bb8:ec08] has quit [Remote host closed the connection]
20171118 21:18:10-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20171118 21:18:17< amir|2> i lack your oversight. do you have a better idea? or a scenario where i can test that?
20171118 21:20:12-!- Bonobo [~Bonobo@14-203-49-124.tpgi.com.au] has joined #wesnoth-dev
20171118 21:21:41< zookeeper> well, couldn't you just add a new [command] (as in the stuff you see inside [replay] in saves/replays), and then handle that wherever all the other move/recruit/etc commands are handled?
20171118 21:23:12< zookeeper> basically just a command that says "this side surrenders"... i don't know how the code works, but that would seem like the straightforward non-hacky way to do it, plus it'd automatically be easily detectable in replays.
20171118 21:23:48< zookeeper> i just don't see why you'd need to kill all units to make the lose condition code notice the side loses, if you could just make the lose condition code notice the side surrenders
20171118 21:23:56< amir|2> i didn't know about that way of handling things. could you give me a few pointers into the code?
20171118 21:24:57< amir|2> so you mean instead of "check_victory" kind of "set_victory" 
20171118 21:28:19< amir|2> i'm currently reading through "check_victory()" code to understand how to manually trigger a victory
20171118 21:30:21< zookeeper> sorry, i don't know the code
20171118 21:33:17< amir|2> that code looks really complicated. maybe the way i did it is safer after all
20171118 21:39:06-!- amir|2 [~amir@public.metalab.wien.funkfeuer.at] has quit [Ping timeout: 252 seconds]
20171118 22:06:50-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20171118 22:08:51-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:954c:4d11:4bb8:ec08] has joined #wesnoth-dev
20171118 22:10:53-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:954c:4d11:4bb8:ec08] has quit [Remote host closed the connection]
20171118 23:14:38-!- irker455 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20171118 23:15:59-!- markus_ [~mjs-de@x4db5e0e0.dyn.telefonica.de] has joined #wesnoth-dev
20171118 23:19:27-!- mjs-de [~mjs-de@x4db6c844.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20171118 23:30:15-!- markus_ [~mjs-de@x4db5e0e0.dyn.telefonica.de] has quit [Remote host closed the connection]
20171118 23:56:14-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.]
20171118 23:56:28-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20171118 23:58:56-!- TadCarlucci [~lundberg@74.193.219.119] has joined #wesnoth-dev
20171118 23:59:21-!- TadCarlucci [~lundberg@74.193.219.119] has quit [Client Quit]
--- Log closed Sun Nov 19 00:00:23 2017