--- Log opened Wed Nov 22 00:00:27 2017
20171122 00:07:44-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20171122 00:08:10-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171122 00:12:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20171122 00:21:56-!- amello [~amello@179.159.56.56] has joined #wesnoth-dev
20171122 00:41:02-!- amello [~amello@179.159.56.56] has quit [Quit: Leaving]
20171122 00:51:15-!- stikonas_ is now known as stikonas
20171122 00:58:13-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20171122 01:06:55-!- irker231 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171122 01:06:55< irker231> wesnoth: Charles Dang wesnoth:master 2cc3f99651c9 / src/ (gui/widgets/grid.hpp hotkey/hotkey_command.cpp hotkey/hotkey_command.hpp): Hotkeys: cleanup and simplification of hotkey_command list https://github.com/wesnoth/wesnoth/commit/2cc3f99651c9de13eb36ab0c490996a8dd47e50e
20171122 01:28:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 255 seconds]
20171122 01:46:38-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 258 seconds]
20171122 01:47:06-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20171122 02:22:51-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20171122 02:22:51< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release Charles Dang 2cc3f99: Hotkeys: cleanup and simplification of hotkey_command list Failed
20171122 02:22:51< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-633
20171122 02:22:56-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20171122 02:30:31-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20171122 02:30:31< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug Charles Dang 2cc3f99: Hotkeys: cleanup and simplification of hotkey_command list Failed
20171122 02:30:31< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-633
20171122 02:30:36-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20171122 02:34:27-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 240 seconds]
20171122 02:46:10-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev
20171122 03:13:51-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 240 seconds]
20171122 03:15:34-!- fabi [~fabi@2a02:810c:c840:2e65:cd0e:9a39:36b3:6a56] has joined #wesnoth-dev
20171122 03:15:34-!- fabi [~fabi@2a02:810c:c840:2e65:cd0e:9a39:36b3:6a56] has quit [Changing host]
20171122 03:15:34-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20171122 04:02:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171122 04:07:23-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 268 seconds]
20171122 04:07:39-!- irker231 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20171122 04:21:01-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20171122 05:05:04-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20171122 05:18:56-!- irker178 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171122 05:18:56< irker178> wesnoth: pentarctagon wesnoth:master a4a1cec63734 / CMakeLists.txt: Remove -rdynamic from the linker. https://github.com/wesnoth/wesnoth/commit/a4a1cec6373433bd88616bc239bcad72541ffa2a
20171122 05:27:31-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20171122 05:27:54-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20171122 05:27:54< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release pentarctagon a4a1cec: Remove -rdynamic from the linker. Failed
20171122 05:27:54< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-634
20171122 05:27:58-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20171122 05:34:56-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20171122 05:34:56< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug pentarctagon a4a1cec: Remove -rdynamic from the linker. Failed
20171122 05:34:56< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-634
20171122 05:35:01-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20171122 05:50:59-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171122 05:53:33-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20171122 05:55:11-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds]
20171122 06:42:57< irker178> wesnoth: Jyrki Vesterinen wesnoth:master 722f319c50fe / src/hotkey/hotkey_command.hpp: Make hotkeys copyable again https://github.com/wesnoth/wesnoth/commit/722f319c50fe513bd09a402480ff50ab6bed0c99
20171122 06:43:54-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20171122 07:23:53-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20171122 07:39:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171122 07:43:28-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20171122 08:45:30-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 268 seconds]
20171122 09:13:00-!- vladimirslavik [vslavik@nat/redhat/x-jusxiyfdjmdigtak] has joined #wesnoth-dev
20171122 09:23:06< irker178> wesnoth: Charles Dang wesnoth:master 111ca0351010 / src/ (wesnothd_connection.cpp wesnothd_connection.hpp): Wesnothd Connection: formatting cleanup https://github.com/wesnoth/wesnoth/commit/111ca03510101d448bbdb2b3b966c7a1661b338b
20171122 09:27:49-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171122 09:32:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20171122 09:40:53-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20171122 10:09:19-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20171122 10:22:55-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Ping timeout: 248 seconds]
20171122 10:44:22-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20171122 10:44:49-!- atarocch [~atarocch@93.56.164.28] has quit [Read error: Connection reset by peer]
20171122 10:46:21-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20171122 11:16:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171122 11:20:35-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20171122 11:44:40-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20171122 11:51:12< AI0867> I'm suddenly getting compilation errors relating to string_view
20171122 11:51:34< AI0867> and I'm really not sure what's going on in src/serialization/string_view.hpp
20171122 11:51:44< AI0867> the boost code is copied there, but also used?
20171122 11:52:31< AI0867> and the copy has a fix for throw-in-ternary issues, but I'm now getting issues from the boost version of that same expression
20171122 11:52:50< AI0867> from a variable declared as utils::string_view
20171122 11:53:12< JyrkiVesterinen> The game forwards to Boost's string_view if you have a new enough version of Boost.
20171122 11:53:20< JyrkiVesterinen> Otherwise it uses the in-tree copy.
20171122 11:54:02< JyrkiVesterinen> https://github.com/wesnoth/wesnoth/blob/master/src/serialization/string_view.hpp#L24-L33
20171122 11:54:43< AI0867> okay, well my compiler (gcc 6.3.0) does not like boost::string_view.at
20171122 11:54:57< AI0867> and it started disliking it... today
20171122 11:55:01< AI0867> I have no idea why
20171122 11:55:37< JyrkiVesterinen> That must be because https://github.com/wesnoth/wesnoth/commit/89ad1b26764150bdf1c2248cf21c4b1499dc8ed7 increased the use of string_view.
20171122 11:56:23< AI0867> it's complaining in src/font/text.cpp
20171122 11:59:41-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 255 seconds]
20171122 12:02:21-!- Bonobo [~Bonobo@14-203-49-124.tpgi.com.au] has quit [Ping timeout: 240 seconds]
20171122 12:03:47-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20171122 12:11:23< AI0867> well, with boost 1.62 and gcc 6.3.0, that commit breaks the build for me
20171122 12:11:30< AI0867> any ideas?
20171122 12:12:18< JyrkiVesterinen> TBH, I guess it's GNU's or Boost's fault and not ours...
20171122 12:21:59< JyrkiVesterinen> The implementation of boost::string_view::at() was changed in Boost 1.64: https://github.com/boostorg/utility/commit/38121f2af336fc7b081752d19c70660a90722fe5
20171122 12:22:34< JyrkiVesterinen> So, one option would be to change utils/string_view.hpp to use the in-tree copy with all Boost versions older than 1.64.
20171122 12:23:33-!- amir|2 [~amir@public.metalab.wien.funkfeuer.at] has joined #wesnoth-dev
20171122 12:23:33-!- amir|2 [~amir@public.metalab.wien.funkfeuer.at] has quit [Client Quit]
20171122 12:23:34-!- irker178 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20171122 12:25:29-!- amir|2 [~amir@public.metalab.wien.funkfeuer.at] has joined #wesnoth-dev
20171122 12:31:01-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20171122 12:33:28< amir|2> i opened the pull request: https://github.com/wesnoth/wesnoth/pull/2215 and after lots of small changes i think it's doing it correctly. but now it consists of a bunch of commits. is it okay if i close the pull request and create a new one that has all changes in one commit?
20171122 12:33:56< JyrkiVesterinen> Yes, it's okay.
20171122 12:38:16< zookeeper> of course you can also reset that branch and redo everything and force-push to update the current PR.
20171122 12:45:39-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20171122 12:47:27< amir|2> oh.. didn't know that... already closed
20171122 12:52:21-!- amir|2 [~amir@public.metalab.wien.funkfeuer.at] has quit [Ping timeout: 252 seconds]
20171122 12:55:51< vn971> amir|2: yeah, you can squash your branch and force-push. That's the conventional way to do it (if you wanna do it at all).
20171122 13:44:18-!- amir|2 [~amir@public.metalab.wien.funkfeuer.at] has joined #wesnoth-dev
20171122 13:45:07< amir|2> fixed the PR: https://github.com/wesnoth/wesnoth/pull/2231
20171122 13:45:24< amir|2> i wasn't able to fix the original PR so i created a new one
20171122 13:50:48< vn971> amir|2: yeah, you can squash your branch and force-push. That's the conventional way to do it (if you really want to change your commits).
20171122 14:02:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171122 14:11:54< vn971> Guys, can somebody please drop a line of how `wesnoth.remove_fog` should work? I'm trying to get it to work, and nothing works.
20171122 14:12:12-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20171122 14:12:12< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release kallaballa 9a1e6b3: implemented a surrender dialog that records a surrender command in replays and quits the game Failed
20171122 14:12:13< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-637
20171122 14:12:16-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20171122 14:13:08< vn971> I've spent a LOT time trying to figure it out already, tested all combinations I could think of. The fog just doesn't go away. wesnoth version is `v1.13.10+dev (1a983277-Clean)`
20171122 14:14:13< vn971> There is an issue I tried to raise, but it's completely flooded and no working solution is found there, yet.  https://github.com/wesnoth/wesnoth/issues/2227
20171122 14:14:37< vultraz> I'll look at it
20171122 14:14:40< vultraz> perhaps the tag is broken
20171122 14:15:20< vn971> vultraz: Thank you!
20171122 14:21:18< AI0867> JyrkiVesterinen: the problem is that the compiler cannot figure out that BOOST_THROW_EXCEPTION is a throw expression, which means the workaround of "throw exception(), correctly_typed_value" is needed
20171122 14:21:29< AI0867> and I see that boost 1.64 indeed has that workaround
20171122 14:21:34< AI0867> so I'll bump the required boost version
20171122 14:21:49< JyrkiVesterinen> Thank you. :)
20171122 14:24:45< vultraz> vn971: tag is indeed broken
20171122 14:25:44< vn971> vultraz: phew, I was beginning to feel insane after the very tense discussion on the issue. Thanks for helping.
20171122 14:31:47< vultraz> vn971: can you test something for me? replace data/lua/wml_tags.lua:918 with:
20171122 14:31:48< vultraz> wesnoth.remove_fog(sides[i].side, locs, cfg.multiturn or false)
20171122 14:32:19< vn971> vultraz: hm wait, I managed to get it work.
20171122 14:32:36< vultraz> and use wml_actions.lift_fog, or just pass false as that third parameter
20171122 14:33:13< vn971> vultraz: Gregory wrote an update that actually works: https://github.com/wesnoth/wesnoth/issues/2227#issuecomment-346363174
20171122 14:33:30< vultraz> hmmm
20171122 14:34:14< vn971> or no. No, I could be frong.
20171122 14:34:19< vn971> vultraz: will test now.
20171122 14:34:36< vultraz> vn971: you can try gregory's code but use false as param 3
20171122 14:35:16< vn971> vultraz: BTW, why does the code say `sides[i].side`  isn't it the same as saying `i`  ?
20171122 14:35:30< vultraz> not necessairily 
20171122 14:35:37< vultraz> necessarily 
20171122 14:37:58< amir|2> i think i found something fishy: in the comments of: https://github.com/wesnoth/wesnoth/blob/master/src/playmp_controller.cpp#L449 it says that send_data won't work if the undo stack isn't empty but if you look at https://github.com/wesnoth/wesnoth/blob/master/src/playturn.cpp#L82 that case is handled there
20171122 14:38:36-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20171122 14:38:36< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug kallaballa 9a1e6b3: implemented a surrender dialog that records a surrender command in replays and quits the game Failed
20171122 14:38:36< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-637
20171122 14:38:41-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20171122 14:39:31-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20171122 14:44:53< Soliton> amir|2: it says "because undoable moves won't be sended" which seems quite correct. (apart from the grammatical error)
20171122 14:45:45< amir|2> oh. ic
20171122 14:53:15-!- irker038 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171122 14:53:15< irker038> wesnoth: Alexander van Gessel wesnoth:master 0cbab6eeedff / src/serialization/string_view.hpp: Bump minimum boost version for external string_view https://github.com/wesnoth/wesnoth/commit/0cbab6eeedff676a57191440c0b2b89b923bfaad
20171122 14:54:18< vn971> vultraz: hmm, it works, but it's kinda strange. I'm not sure what to test, exactly. It's really weird, sometimes fogs clears and after some commands it manages to return. I'm not sure yet.
20171122 14:58:04< vultraz> > not >=?
20171122 15:02:18-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20171122 15:10:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20171122 15:12:20-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20171122 15:13:23< AI0867> vultraz: hmm, I may have misread things
20171122 15:27:56< vn971> vultraz: I've reverted the code and re-tested `remove_fog`, it seems to work. What exactly should I test with the modified line? (cfg.multiturn or false)  Or is it not important then?
20171122 15:29:14< vultraz> vn971: did your test involve remove_fog with third argument false?
20171122 15:29:25< irker038> wesnoth: Alexander van Gessel wesnoth:master ca03818fa897 / src/serialization/string_view.hpp: >= 1.64, not > 1.64 https://github.com/wesnoth/wesnoth/commit/ca03818fa897a558d9ad5d9c3729404f5959029f
20171122 15:29:49< vultraz> And it worked as you expected?
20171122 15:30:17< vn971> vultraz: I executed the function with the first parameter `false`, but I didn't know what to test exactly. Like end turn and see what happens, or what exactly.
20171122 15:30:25< vn971> * the third parameter `false`
20171122 15:30:40< vultraz> Did it do what you were trying to do
20171122 15:33:33< vultraz> I’m not sure where you’re trying to remove fog
20171122 15:34:01< vultraz> I’m just wondering if using the third parameter false gave you the behavior you wanted
20171122 15:58:22-!- vladimirslavik [vslavik@nat/redhat/x-jusxiyfdjmdigtak] has quit [Quit: Leaving]
20171122 15:59:10-!- Appveyor [~Appveyor@67.225.139.254] has joined #wesnoth-dev
20171122 15:59:10< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release kallaballa feff5cc: made surrender a non-undoable command Failed
20171122 15:59:10< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-636
20171122 15:59:14-!- Appveyor [~Appveyor@67.225.139.254] has left #wesnoth-dev []
20171122 16:03:51< amir|2> can i trigger a server message from a non-turn-having side?
20171122 16:10:02< vultraz> amir|2: what do you mean
20171122 16:10:37< amir|2> if a side which turn it isn't surrenders i'd like to have a server message "$player surrenderd"
20171122 16:10:56< amir|2> ofc i also want it for a side which turn it is
20171122 16:12:35< vultraz> hmm
20171122 16:12:41< vultraz> im sure there is but i can't thin right now
20171122 16:12:42< vultraz> think
20171122 16:12:44< vultraz> im sick >_<
20171122 16:15:07< amir|2> vultraz: hope you get better soon
20171122 16:15:12< vultraz> thanks
20171122 16:18:21< Soliton> the server decides when to send a server message.
20171122 16:19:01< Soliton> so change the server code so it recognizes your new surrender command and issues some message.
20171122 16:20:20< amir|2> do you maybe have a pointer on where to look?
20171122 16:25:02< amir|2> I mean where does the server get notice of issued commands?
20171122 16:25:13< vultraz> im not sure
20171122 16:28:16-!- TadCarlucci [~lundberg@74.193.219.119] has joined #wesnoth-dev
20171122 16:28:30-!- TadCarlucci [~lundberg@74.193.219.119] has quit [Client Quit]
20171122 16:28:31< vn971> vultraz: OK, I've tried both your modification and the stock lift_fog. Both do not work. If I use a code like this: wesnoth.remove_fog(1, {{4,16}}, false)  then fog gets away. However, if I end turn, the fog always persists. So it never dissolves by itself. As if I set "permanent" to true.
20171122 16:28:46< vultraz> hm
20171122 16:28:48< vultraz> ok
20171122 16:28:56< vultraz> i'm sorry, im useless right now
20171122 16:35:24-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20171122 16:35:24< Appveyor> The Battle for Wesnoth (Visual Studio 2017) - Release kallaballa feff5cc: made surrender a non-undoable command Failed
20171122 16:35:24< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-337
20171122 16:35:27-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20171122 16:36:17< vn971> vultraz: NP. I only wanted permanent fog-clearing anyway. Thanks anyway!
20171122 16:41:48< vn971> vultraz: wow, that's "cool". I've now set the `wml_actions.lift_fog` line to `wesnoth.remove_fog(sides[i].side, locs, false)`   And guess what, the fog still doesn't go away.
20171122 16:42:18< vultraz> yeah, that's what i expected
20171122 16:42:19< vultraz> i think
20171122 16:43:56< vn971> ah, sry. I'm testing different things. I already invoke `remove_fog` directly, not via [lift_fog]. So if it didn't work before, it shouldn't when I change the body of [lift_fog] method, too, of course. So just nvm.
20171122 16:47:33< zookeeper> the whole lava expansion thing in HttT:SoF seems a bit pointless.
20171122 16:57:09-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20171122 17:02:36< amir|2> i think i found it: game::process_turn and game::is_legal_command seem to be the key sections
20171122 17:03:29-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171122 17:14:20-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20171122 17:14:20< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug kallaballa feff5cc: made surrender a non-undoable command Failed
20171122 17:14:20< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-636
20171122 17:14:24-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20171122 17:16:40-!- travis-ci [~travis-ci@ec2-54-156-107-164.compute-1.amazonaws.com] has joined #wesnoth-dev
20171122 17:16:41< travis-ci> wesnoth/wesnoth#15708 (master - 0cbab6e : Alexander van Gessel): The build has errored.
20171122 17:16:41< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/305845920
20171122 17:16:41-!- travis-ci [~travis-ci@ec2-54-156-107-164.compute-1.amazonaws.com] has left #wesnoth-dev []
20171122 17:28:10< amir|2> how do i get a side number from a wesnothd::player?
20171122 17:44:42< Soliton> players can have multiple sides.
20171122 17:45:26< Soliton> just mentioning the player name in the server message should be enough.
20171122 17:45:58< Soliton> what happens now when a player surrenders?
20171122 17:46:09< Soliton> or does a specific side surrender?
20171122 17:47:07-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Read error: Connection reset by peer]
20171122 17:47:44-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20171122 17:48:09-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20171122 17:51:31< Soliton> zookeeper: did you also look at Delfador's concentration thing? does that work for you?
20171122 17:52:27-!- Appveyor [~Appveyor@67.225.139.254] has joined #wesnoth-dev
20171122 17:52:27< Appveyor> The Battle for Wesnoth (Visual Studio 2017) - Debug kallaballa feff5cc: made surrender a non-undoable command Failed
20171122 17:52:27< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-337
20171122 17:52:31-!- Appveyor [~Appveyor@67.225.139.254] has left #wesnoth-dev []
20171122 17:52:42< zookeeper> Soliton, nah, didn't check that yet
20171122 18:00:16-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:8c4d:7ea1:2c5a:dd8d] has joined #wesnoth-dev
20171122 18:01:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20171122 18:01:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171122 18:06:22-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 264 seconds]
20171122 18:12:31< zookeeper> Soliton, concentrating seems to work for me in master.
20171122 18:13:16< Soliton> ok, thanks.
20171122 18:14:41< vn971> Am I right that in wesnoth-1.13 there was a lot of re-writes from raw WML tags to Lua functions that provide these tags? So that previously there only was a tag, but now for many methods a Lua implementation is written, and the tag itself is re-written in Lua so only the Lua API reamins (for those functions/tags)?
20171122 18:17:18< amir|2> sooo.. i've got it almost working only problem left is that the surrender command somehow gets sent twice... any idea why?
20171122 18:18:29< zookeeper> a lot of the WML tag handlers were ported from the engine code to lua, yes.
20171122 18:23:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171122 18:29:36-!- irker038 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20171122 18:57:19-!- vn971 [~vasya@94.158.103.15] has quit [Quit: Leaving.]
20171122 18:57:50< amir|2> i figured it out... now it's working flawlessly as far as i can see
20171122 19:13:36-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev
20171122 19:24:21< Soliton> amir|2: sides_[sn.to_int()]  you need to check that sn.to_int() is between 0 and sides_.size(). better yet call your key from_side and you don't need to change anything.
20171122 19:27:15-!- amir|2 [~amir@public.metalab.wien.funkfeuer.at] has quit [Ping timeout: 252 seconds]
20171122 19:33:14-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20171122 20:10:04-!- mjs-de [~mjs-de@x4e30c4fd.dyn.telefonica.de] has joined #wesnoth-dev
20171122 20:21:02-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20171122 20:37:59-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:8c4d:7ea1:2c5a:dd8d] has quit [Remote host closed the connection]
20171122 20:42:12-!- amir|2 [~amir@80-110-66-140.cgn.dynamic.surfer.at] has joined #wesnoth-dev
20171122 20:50:18-!- amir|2 [~amir@80-110-66-140.cgn.dynamic.surfer.at] has quit [Ping timeout: 252 seconds]
20171122 21:13:41-!- mjs-de [~mjs-de@x4e30c4fd.dyn.telefonica.de] has quit [Remote host closed the connection]
20171122 21:51:45-!- sigurdfd [sigurdfd@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20171122 22:14:41-!- Bonobo [~Bonobo@14-203-49-124.tpgi.com.au] has joined #wesnoth-dev
20171122 22:14:52-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20171122 22:19:02-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20171122 22:38:43-!- irker712 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171122 22:38:43< irker712> wesnoth: sigurdfdragon wesnoth:master 64d3aa1ab69c / data/campaigns/Secrets_of_the_Ancients/utils/sota-utils.cfg: SotA: Fix and improve freeze/thaw unit implementation https://github.com/wesnoth/wesnoth/commit/64d3aa1ab69cf5269b19d2c695a659a3bfc3efd9
20171122 22:52:35-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20171122 22:56:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171122 23:02:36-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171122 23:03:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 268 seconds]
20171122 23:03:57-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Ping timeout: 240 seconds]
20171122 23:06:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171122 23:07:11-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 248 seconds]
20171122 23:08:20-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20171122 23:13:17-!- atarocch [~atarocch@93.56.164.28] has quit [Remote host closed the connection]
20171122 23:23:41-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20171122 23:36:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20171122 23:43:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171122 23:44:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20171122 23:46:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171122 23:46:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20171122 23:50:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
--- Log closed Thu Nov 23 00:00:29 2017