--- Log opened Mon Nov 27 00:00:34 2017
20171127 00:06:17-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20171127 00:14:54-!- test123 [de9af24c@gateway/web/freenode/ip.222.154.242.76] has joined #wesnoth-dev
20171127 00:21:07-!- test123 [de9af24c@gateway/web/freenode/ip.222.154.242.76] has quit [Quit: Page closed]
20171127 00:26:35-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20171127 00:27:58-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20171127 00:29:12-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20171127 00:31:24< mattsc> Ugh!  I am getting a consistent and reproducible “formula type error” from my AI code when using wesnoth.simulate_combat with an attacker that has backstab.
20171127 00:31:44< mattsc> But I don’t seem to be able to set up a simple testcase that produces the same error.
20171127 00:36:37-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20171127 00:52:38< irker651> wesnoth: Severin Glöckner wesnoth:master e0cebdd402d3 / / (12 files in 9 dirs): desktop_entry: include high resolution icons https://github.com/wesnoth/wesnoth/commit/e0cebdd402d370faa3e853423409b8360ce56e3e
20171127 00:56:02-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20171127 01:02:13-!- Bonobo [~Bonobo@220-244-175-160.static.tpgi.com.au] has joined #wesnoth-dev
20171127 01:05:26-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20171127 01:07:13-!- 7GHABC9JD [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20171127 01:33:53< mattsc> Well, the problem originates here: https://github.com/wesnoth/wesnoth/blob/master/data/core/macros/abilities.cfg#L291
20171127 01:34:33< mattsc> It appears that in an AI environment, ‘self’, ‘loc’ and ‘other’ are null and therefore produce an error message.
20171127 01:35:07< mattsc> Or at least in the Lua AI environment that I am using.
20171127 01:35:26< mattsc> I have no idea what to do about that, so I’ll submit a bug report sometime soon.
20171127 01:38:55-!- TadCarlucci [~lundberg@74.193.219.119] has joined #wesnoth-dev
20171127 01:39:35-!- 7GHABC9JD [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20171127 02:01:36-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20171127 02:08:19< mattsc> I think I also found a problem with wesnoth.get_time_of_day and the fearless trait, but I need a bit more investigation of that.
20171127 02:09:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20171127 02:32:45< mattsc> Woot — now I have a way of reproducing the backstab problem with minimal effort.
20171127 02:57:56< celticminstrel> mattsc: Just FTR, that's WFL, not Lua.
20171127 02:58:42< celticminstrel> So loc is self.loc
20171127 02:58:57< celticminstrel> So self and other are null, which is quite weird.
20171127 02:59:28< celticminstrel> Unless of course you're only saying at least one is null but you're not sure which.
20171127 02:59:33< mattsc> celticminstrel: yeah; do you want me to describe here quickly how to reproduce it?
20171127 03:00:08< celticminstrel> Uh, sure I guess. I won't be able to try it today though.
20171127 03:00:12< celticminstrel> My build doesn't work ATM.
20171127 03:00:13< mattsc> I do not know which one is null.
20171127 03:00:27< mattsc> I thought it has to be at least two of them, but I think I might have been mistaken about that.
20171127 03:00:32< celticminstrel> Hmm.
20171127 03:01:15< mattsc> The error I am getting is this: https://pastebin.com/ahasjq2K
20171127 03:01:52< celticminstrel> Okay.
20171127 03:01:57< celticminstrel> So...
20171127 03:02:36< celticminstrel> It's the direction that's null.
20171127 03:02:51< celticminstrel> So, other.facing is null, which means other is null.
20171127 03:03:24< celticminstrel> other should refer to the same unit as $other_unit would, but maybe that's not entirely working correctly in the AI context for some reason.
20171127 03:03:53< celticminstrel> (I know it has to be the direction that's null because it said "expected string"; the direction is a string, but the location is not.)
20171127 03:04:24< mattsc> Well, it seems to be working in the default AI context; when running MP games of Knalgans against each other, the error does not occur
20171127 03:04:34< mattsc> Ah, I see.
20171127 03:05:08< mattsc> I only get the problem (so far, at least) in Lua AI context when using wesnoth.simulate_combat
20171127 03:06:27< mattsc> Easiest way to reproduce is to use the Fast Micro AI.  Change this line:
20171127 03:06:28< mattsc> https://github.com/wesnoth/wesnoth/blob/master/data/ai/micro_ais/scenarios/fast.cfg#L51
20171127 03:06:43< mattsc> so that it only scatters Thieves over the map.
20171127 03:07:17< mattsc> Then start the Fast MAI from the CL with the ‘-tfast’ option.  The console is going to be spammed by those error messages.
20171127 03:07:44< mattsc> spammed with?  Something like that.
20171127 03:08:34< celticminstrel> Okay, so maybe wesnoth.simulate_combat isn't passing the other unit to some function...?
20171127 03:08:56< mattsc> Hmm, possibly.
20171127 03:31:23< mattsc> It does seem to work if you call wesnoth.simulate_combat while the player is in control though.
20171127 03:44:33< celticminstrel> Is the second unit definitely being passed in the wesnoth.simulate_unit call, and is definitely not null?
20171127 03:50:37-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has joined #wesnoth-dev
20171127 03:57:16< mattsc> I know for sure that the second unit is not null and that it contains at least an id field.  I would have to check that it is a valid proxy unit, but I am almost entirely certain of that.
20171127 03:57:57< mattsc> Because if it weren’t, simulate_combat itself would complain.
20171127 03:58:04< mattsc> I think.
20171127 04:00:39-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20171127 04:10:42-!- Greg-Boggs [~greg_bogg@c-73-96-181-202.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20171127 04:25:41< mattsc> Yep, the second unit is definitely a valid unit unit the map.
20171127 04:25:59< mattsc> s/unit unit/unit on
20171127 04:37:04< mattsc> BTW, the problem with fearless and wesnoth.get_time_of_day turned out to be a hitch in my own code, so all good there.
20171127 04:37:51< mattsc> I’m off now.  Not sure when I’ll be back next, but I’ll read the logs.
20171127 04:39:41-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20171127 04:56:00-!- irker651 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20171127 05:00:09-!- irker818 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171127 05:00:09< irker818> wesnoth: Charles Dang wesnoth:master 9b988f27f77a / src/hotkey/ (command_executor.cpp command_executor.hpp): Hotkey/Command Executor: removed get_video() member in favor of singleton https://github.com/wesnoth/wesnoth/commit/9b988f27f77a726972863155aa8637aec7adc402
20171127 05:42:47< irker818> wesnoth: Charles Dang wesnoth:master e8655af1b419 / src/ (display.cpp display.hpp): Display: one (hopefully) significant optimization and one minor one https://github.com/wesnoth/wesnoth/commit/e8655af1b419a1e728a8d2fa50eaef5206386c9e
20171127 06:22:06-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20171127 07:03:47-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20171127 08:02:10-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20171127 08:26:28-!- atarocch [~atarocch@93.56.164.28] has quit [Remote host closed the connection]
20171127 08:27:06-!- atarocch [~atarocch@93.56.164.28] has joined #wesnoth-dev
20171127 09:24:31-!- vladimirslavik [vslavik@nat/redhat/x-vhychnxrujxmlace] has joined #wesnoth-dev
20171127 09:26:48-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20171127 10:56:46-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20171127 11:23:59< vn971> Hi, does anyone understand what "+" means here: https://wiki.wesnoth.org/Preprocessorref#.23ifver_and_.23ifnver
20171127 11:23:59< vn971> How is this   #ifver WESNOTH_VERSION >= 1.9.7+   different from this   #ifver WESNOTH_VERSION >= 1.9.7   ?
20171127 11:47:01-!- irker818 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20171127 11:47:07-!- irker111 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171127 11:47:07< irker111> wesnoth: Jeffrey 'Sigurd' Westcoat wesnoth:master aceabbe018e7 / data/core/macros/items.cfg: Macros: Tweak sceptre damage for story reasons (#2220) https://github.com/wesnoth/wesnoth/commit/aceabbe018e7be95a0bcf467109a7d14c1b62b55
20171127 11:53:50-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Ping timeout: 255 seconds]
20171127 11:55:28-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20171127 11:58:55-!- kallaballa [~amir@public.metalab.wien.funkfeuer.at] has joined #wesnoth-dev
20171127 11:59:32-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20171127 12:04:11< JyrkiVesterinen> vn971: The + is the special version suffix.
20171127 12:04:29< JyrkiVesterinen> For example, right now Git master builds have the version number 1.13.10+dev.
20171127 12:04:41< JyrkiVesterinen> It's considered newer than 1.13.10.
20171127 12:09:27< zookeeper> so the difference in his examples is that #ifver WESNOTH_VERSION >= 1.9.7+ would not match 1.9.7?
20171127 12:09:44< JyrkiVesterinen> Indeed.
20171127 12:14:44< zookeeper> okay.
20171127 12:25:49-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20171127 12:44:16-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171127 12:44:22-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171127 13:11:13< kallaballa> could anyone please confirm this issue: https://github.com/wesnoth/wesnoth/issues/2235
20171127 13:50:11< TadCarlucci> kallaballa, Marked 2235 Invalid and Closed. Cannot reproduce.
20171127 14:07:43< kallaballa> TadCarlucci: wierd... i'm using master and i do have the problem.. creating a video right now
20171127 14:14:18< kallaballa> TadCarlucci: look: https://185.203.117.150:60443/owncloud/public.php?service=files&t=5989fd9d204aa8c30a025adf3173fa21
20171127 14:14:22< kallaballa> that's current master
20171127 14:23:20< TadCarlucci> Can't do video. What I did: 3 terminals. (1) wesnothd (2) and (3) wesnoth. (2) starts Aethermaw (3) joins (2) recruits and clicks End Turn (3) begins recruits but does not End Turn (2) closes Wesnoth window (3) gets desktop notice, popup to give control to AI or away a human and messages on-screen when AI takes control.
20171127 14:24:34< TadCarlucci> I note that I tested your PR and have sequencing issues if I quit (2) before (1) cleared the greeting and started moving but that's another issue.
20171127 14:24:41< kallaballa> just try:  Alice creates. Bob joins. Alice leaves... without any recruiting or the likes
20171127 14:24:55< TadCarlucci> Hang on.
20171127 14:25:17< kallaballa> i fixed the sequencing issue in the PR... but right now i'm talking about master
20171127 14:29:01< TadCarlucci> OK. Clicked "I'm ready" then when greeting appears clicked "X" to close window. (3) sees notice, flash of msgs on scree, dialog and messages return when dial closed.
20171127 14:29:20< TadCarlucci> The only "bug" I see is I don't like that dialogs remove the on-screen messages
20171127 14:30:01< kallaballa> Ah! that's the problem... that's why i don't see the server messages on-screen anymore
20171127 14:30:44< kallaballa> but pity you can't watch the video, because the never show up in my case to begin with
20171127 14:30:52< kallaballa> *they
20171127 14:33:10< TadCarlucci> I belive you can reprodcue the "where'd the messages go?" with any messages and any dialog. It bugs the hell out of me when I'm debugging Lua and my debug prints disappear when the dialog appears.
20171127 14:34:40< TadCarlucci> I probably could watch the video but it came up with http instead of https and when I ignored that it was MKV which I don't have installed. To much work.
20171127 14:39:44< TadCarlucci> OK. I tried openning the Chat Log dialog before the active side quit. Yes, that prevented all the messages and other dialogs until you close it. Then everything proceeded as it should.
20171127 14:41:10-!- vladimirslavik [vslavik@nat/redhat/x-vhychnxrujxmlace] has quit [Remote host closed the connection]
20171127 14:41:34< TadCarlucci> The other choices would be surprise (and piss off) the player by closing the MP chat dialog or change to allow multiple pop-up dialogs. And, of course, display the on-screen messages on-screen right away even though there is a dialog.
20171127 14:43:31< kallaballa> I didn't open the chat log before the side quits. i did it after
20171127 14:45:10< kallaballa> can you open webm?
20171127 14:45:10-!- vladimirslavik [vslavik@nat/redhat/x-uomhucrugriillid] has joined #wesnoth-dev
20171127 14:45:24< kallaballa> i think we can save a lot of talk if you could watch that
20171127 14:47:06-!- irker111 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20171127 14:51:11-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20171127 14:54:22-!- irker640 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171127 14:54:22< irker640> wesnoth: mattsc wesnoth:master b7efaadec486 / data/ai/micro_ais/engines/priority_target_engine.lua: Protect Unit Micro AI: fix typo/bug in AI aspect change https://github.com/wesnoth/wesnoth/commit/b7efaadec486bd40bb273abee4c6bf858f5d71f3
20171127 15:01:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171127 15:25:27-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20171127 16:17:47-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:9c61:e0c1:8c88:ef3e] has joined #wesnoth-dev
20171127 16:18:35-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:9c61:e0c1:8c88:ef3e] has quit [Remote host closed the connection]
20171127 16:36:44-!- travis-ci [~travis-ci@ec2-54-167-122-141.compute-1.amazonaws.com] has joined #wesnoth-dev
20171127 16:36:45< travis-ci> wesnoth/wesnoth#15814 (master - b7efaad : mattsc): The build has errored.
20171127 16:36:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/307933331
20171127 16:36:45-!- travis-ci [~travis-ci@ec2-54-167-122-141.compute-1.amazonaws.com] has left #wesnoth-dev []
20171127 17:31:51-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171127 17:34:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20171127 17:34:22-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171127 17:35:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20171127 17:40:15-!- Bonobo [~Bonobo@220-244-175-160.static.tpgi.com.au] has quit [Ping timeout: 248 seconds]
20171127 17:43:54-!- vladimirslavik [vslavik@nat/redhat/x-uomhucrugriillid] has quit [Quit: Leaving]
20171127 17:44:20-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20171127 17:54:45-!- irker640 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20171127 18:00:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20171127 18:01:09-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171127 18:01:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20171127 18:14:04-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171127 18:14:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171127 18:18:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171127 18:33:11-!- kallaballa [~amir@public.metalab.wien.funkfeuer.at] has quit [Ping timeout: 240 seconds]
20171127 18:39:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20171127 18:43:18-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171127 18:43:46-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20171127 19:02:39-!- mjs-de [~mjs-de@vpw.wh.stwdo.de] has joined #wesnoth-dev
20171127 19:13:10< vn971> JyrkiVesterinen sorry for the late reply (I see you aren't even there already). I still can't figure out all the possible differences (">=1", ">1", ">=1+", ">1+"), but I guess I know that for my simple use case ">=1.0" is enough.
20171127 19:26:54-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171127 19:31:21-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20171127 19:39:15-!- irker693 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171127 19:39:15< irker693> wesnoth: Charles Dang wesnoth:master eba94b3e2202 / src/ (16 files in 5 dirs): Cleaned up unnecessary drawing calls https://github.com/wesnoth/wesnoth/commit/eba94b3e22022ebb3f455723a60ef6b6518284fa
20171127 20:00:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171127 20:04:54-!- zookeeper_ [~lmsnie@95.175.104.66] has joined #wesnoth-dev
20171127 20:08:44-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 276 seconds]
20171127 20:19:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171127 20:44:59-!- kallaballa [~amir@194-166-158-138.hdsl.highway.telekom.at] has joined #wesnoth-dev
20171127 21:11:17-!- mjs-de [~mjs-de@vpw.wh.stwdo.de] has quit [Remote host closed the connection]
20171127 21:16:49< irker693> wesnoth: lundberg wesnoth:master a05d48e80d55 / packaging/windows/ (wesnoth.rc wesnothd.rc): Fix copyright defect and add missing icon https://github.com/wesnoth/wesnoth/commit/a05d48e80d5510cdf27ed4a46f9a0e20760ccc86
20171127 21:18:07-!- kallaballa [~amir@194-166-158-138.hdsl.highway.telekom.at] has quit [Ping timeout: 260 seconds]
20171127 21:19:25-!- zookeeper_ is now known as zookeeper
20171127 21:19:44-!- zookeeper [~lmsnie@95.175.104.66] has quit [Changing host]
20171127 21:19:44-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20171127 21:58:10-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20171127 22:23:14-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20171127 22:35:43-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 248 seconds]
20171127 22:44:12-!- iceiceice [~chris@209.133.79.7] has joined #wesnoth-dev
20171127 22:44:12-!- iceiceice [~chris@209.133.79.7] has quit [Changing host]
20171127 22:44:12-!- iceiceice [~chris@unaffiliated/iceiceice] has joined #wesnoth-dev
20171127 23:14:02-!- sigurdfd [sigurdfd@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20171127 23:22:03-!- Bonobo [~Bonobo@220-244-175-160.static.tpgi.com.au] has joined #wesnoth-dev
20171127 23:38:43< irker693> wesnoth: Charles Dang wesnoth:master b73e8dd73fb2 / src/gui/widgets/window.cpp: GUI2/Window: don't constantly send useless DRAW events to the queue https://github.com/wesnoth/wesnoth/commit/b73e8dd73fb2edcebcdd87ca506daaf68f6af534
20171127 23:43:17-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20171127 23:48:09-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20171127 23:48:09< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release Alexander van Gessel 5b008d2: Replace from_int with iteration Failed
20171127 23:48:09< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-750
20171127 23:48:13-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20171127 23:55:26-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20171127 23:55:26< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug Alexander van Gessel 5b008d2: Replace from_int with iteration Failed
20171127 23:55:26< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-750
20171127 23:55:30-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
--- Log closed Tue Nov 28 00:00:35 2017