--- Log opened Tue Nov 28 00:00:35 2017
20171128 00:22:18-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20171128 00:27:50-!- Appveyor [~Appveyor@67.225.139.254] has joined #wesnoth-dev
20171128 00:27:51< Appveyor> The Battle for Wesnoth (Visual Studio 2017) - Release Alexander van Gessel 5b008d2: Replace from_int with iteration Failed
20171128 00:27:51< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-446
20171128 00:27:54-!- Appveyor [~Appveyor@67.225.139.254] has left #wesnoth-dev []
20171128 00:56:03-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20171128 00:59:52-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20171128 00:59:52< Appveyor> The Battle for Wesnoth (Visual Studio 2017) - Debug Alexander van Gessel 5b008d2: Replace from_int with iteration Failed
20171128 00:59:52< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-446
20171128 00:59:56-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20171128 01:02:27-!- Jetrel_bot [~Jetrel@ec2.happyspork.com] has quit [Ping timeout: 240 seconds]
20171128 01:04:07-!- Jetrel_bot [~Jetrel@ec2.happyspork.com] has joined #wesnoth-dev
20171128 01:07:11-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20171128 01:17:08< irker693> wesnoth: sigurdfdragon wesnoth:master 4bafb736f00e / data/campaigns/Delfadors_Memoirs/scenarios/19_Showdown_in_the_Northern_Swamp.cfg: DM S19: Rebalance scenario for a more exciting battle https://github.com/wesnoth/wesnoth/commit/4bafb736f00ebd721c507ef874d41b5ff7bd77cf
20171128 01:17:10< irker693> wesnoth: sigurdfdragon wesnoth:master 3213e63efe97 / data/campaigns/Delfadors_Memoirs/scenarios/19_Showdown_in_the_Northern_Swamp.cfg: DM S19: Fix carryover report https://github.com/wesnoth/wesnoth/commit/3213e63efe97e41745b98e409e6e1262767865d3
20171128 01:27:58-!- Appveyor [~Appveyor@67.225.139.254] has joined #wesnoth-dev
20171128 01:27:58< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release Alexander van Gessel 5b008d2: Replace from_int with iteration Failed
20171128 01:27:58< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-745
20171128 01:28:02-!- Appveyor [~Appveyor@67.225.139.254] has left #wesnoth-dev []
20171128 01:28:50< irker693> wesnoth: sigurdfdragon wesnoth:master a593e9753fd8 / changelog players_changelog: Update changelogs https://github.com/wesnoth/wesnoth/commit/a593e9753fd8baf4c7156ecd027b27323e7e3482
20171128 01:54:00-!- Appveyor [~Appveyor@67.225.139.254] has joined #wesnoth-dev
20171128 01:54:01< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug Alexander van Gessel 5b008d2: Replace from_int with iteration Failed
20171128 01:54:01< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-745
20171128 01:54:04-!- Appveyor [~Appveyor@67.225.139.254] has left #wesnoth-dev []
20171128 02:07:26-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171128 02:12:05-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 276 seconds]
20171128 02:28:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20171128 02:36:01-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 240 seconds]
20171128 02:37:08-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20171128 02:46:19-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171128 02:46:28-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171128 04:16:59-!- sigurdfd [sigurdfd@dynamic-acs-72-23-110-196.zoominternet.net] has quit []
20171128 04:20:13-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20171128 04:31:33-!- irker693 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20171128 04:40:51-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20171128 04:51:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171128 04:56:31-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds]
20171128 05:33:21-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 248 seconds]
20171128 05:35:10-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20171128 05:52:07-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20171128 06:16:53-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20171128 06:55:02-!- irker050 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171128 06:55:02< irker050> wesnoth: Charles Dang wesnoth:event_handler_list_refactor_pass_2 9bf24847a808 / src/game_events/ (6 files): Game Events: throw out custom handler_list implementation https://github.com/wesnoth/wesnoth/commit/9bf24847a808422c4762db666ca46e336a17cc4c
20171128 06:55:05< irker050> wesnoth: Charles Dang wesnoth:event_handler_list_refactor_pass_2 eada9522ef24 / src/game_events/manager.cpp: test a thing https://github.com/wesnoth/wesnoth/commit/eada9522ef247663f31646b05ab3564e8299fc0c
20171128 06:55:08< irker050> wesnoth: Charles Dang wesnoth:event_handler_list_refactor_pass_2 2ef6915a4ce4 / src/game_events/manager.cpp: Re-add validation check https://github.com/wesnoth/wesnoth/commit/2ef6915a4ce48ee049e0eda23365eba2d7a20ed5
20171128 06:55:11< irker050> wesnoth: Charles Dang wesnoth:event_handler_list_refactor_pass_2 3230d1178f23 / src/game_events/ (6 files): Attempt refactoring 1 https://github.com/wesnoth/wesnoth/commit/3230d1178f23d90a4b2c9da3e26b7917c6d30a14
20171128 06:55:25< vultraz> now let's see if travis runs on that
20171128 06:56:06< vultraz> indeed it does
20171128 07:25:38-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20171128 07:33:22-!- amir [~amir@194-166-158-138.hdsl.highway.telekom.at] has joined #wesnoth-dev
20171128 07:33:46-!- amir is now known as Guest14493
20171128 07:39:29-!- Guest14493 [~amir@194-166-158-138.hdsl.highway.telekom.at] has quit [Ping timeout: 250 seconds]
20171128 07:55:20-!- Guest14493 [~amir@194-166-158-138.hdsl.highway.telekom.at] has joined #wesnoth-dev
20171128 08:04:31-!- zookeeper [~lmsnie@95.175.104.100] has joined #wesnoth-dev
20171128 08:04:44-!- zookeeper [~lmsnie@95.175.104.100] has quit [Changing host]
20171128 08:04:44-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20171128 08:06:20-!- Guest14493 [~amir@194-166-158-138.hdsl.highway.telekom.at] has quit [Ping timeout: 276 seconds]
20171128 08:28:37-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171128 08:32:47-!- Guest14493 [~amir@194-166-158-138.hdsl.highway.telekom.at] has joined #wesnoth-dev
20171128 08:33:03-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds]
20171128 08:38:10-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-nbwckfzlplmbhlyq] has quit [Ping timeout: 264 seconds]
20171128 08:49:29-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-brurkxrzbntvsext] has joined #wesnoth-dev
20171128 08:49:35-!- Guest14493 [~amir@194-166-158-138.hdsl.highway.telekom.at] has quit [Ping timeout: 240 seconds]
20171128 08:49:53-!- matthiaskrgr is now known as Guest63406
20171128 08:53:54< irker050> wesnoth: Charles Dang wesnoth:event_handler_list_refactor_pass_2 60793c7aa6db / src/game_events/manager.cpp: C'est fou >_< https://github.com/wesnoth/wesnoth/commit/60793c7aa6dbf66d6f823ad2287148d1902c7bf3
20171128 08:58:10-!- Guest14493 [~amir@194-166-158-138.hdsl.highway.telekom.at] has joined #wesnoth-dev
20171128 09:38:12-!- vladimirslavik [vslavik@nat/redhat/x-maqwpgyjgikwqmdw] has joined #wesnoth-dev
20171128 10:11:27-!- Guest14493 [~amir@194-166-158-138.hdsl.highway.telekom.at] has quit [Ping timeout: 240 seconds]
20171128 10:16:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171128 10:17:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171128 10:20:27-!- travis-ci [~travis-ci@ec2-54-90-68-208.compute-1.amazonaws.com] has joined #wesnoth-dev
20171128 10:20:28< travis-ci> wesnoth/wesnoth#15823 (event_handler_list_refactor_pass_2 - 60793c7 : Charles Dang): The build passed.
20171128 10:20:28< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/308322594
20171128 10:20:28-!- travis-ci [~travis-ci@ec2-54-90-68-208.compute-1.amazonaws.com] has left #wesnoth-dev []
20171128 10:34:07-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20171128 10:43:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171128 11:08:50< irker050> wesnoth: Charles Dang wesnoth:event_handler_list_refactor_pass_2 2045b6739e0f / src/ (8 files in 2 dirs): Game Events: refactored event handler storage https://github.com/wesnoth/wesnoth/commit/2045b6739e0f4e5443ea680870412f2a5b9a6518
20171128 11:23:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20171128 11:39:45-!- Jetrel_bot [~Jetrel@ec2.happyspork.com] has quit [Ping timeout: 248 seconds]
20171128 11:40:45-!- DDR [~david@ec2.happyspork.com] has quit [Ping timeout: 258 seconds]
20171128 11:42:17-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Ping timeout: 258 seconds]
20171128 11:44:23-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev
20171128 11:46:17-!- DDR [~david@ec2.happyspork.com] has joined #wesnoth-dev
20171128 11:48:44-!- crimson_penguin [~crimson_p@ec2.happyspork.com] has joined #wesnoth-dev
20171128 11:48:44-!- crimson_penguin [~crimson_p@ec2.happyspork.com] has quit [Changing host]
20171128 11:48:44-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20171128 11:50:21-!- Jetrel_bot [~Jetrel@ec2.happyspork.com] has joined #wesnoth-dev
20171128 12:01:03-!- vn971 [~vasya@94.158.103.15] has quit [Ping timeout: 248 seconds]
20171128 12:03:42-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev
20171128 12:05:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171128 12:09:11-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20171128 12:49:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171128 12:49:41-!- janebot [~Gambot@grickit.us] has joined #wesnoth-dev
20171128 12:49:44-!- janebot [~Gambot@grickit.us] has quit [Changing host]
20171128 12:49:44-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171128 13:10:23-!- Bonobo [~Bonobo@220-244-175-160.static.tpgi.com.au] has quit [Ping timeout: 248 seconds]
20171128 13:37:13-!- Guest63406 [matthiaskr@gateway/shell/panicbnc/x-brurkxrzbntvsext] has quit [Changing host]
20171128 13:37:13-!- Guest63406 [matthiaskr@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20171128 13:37:13-!- Guest63406 [matthiaskr@unaffiliated/matthiaskrgr] has quit [Changing host]
20171128 13:37:13-!- Guest63406 [matthiaskr@gateway/shell/panicbnc/x-brurkxrzbntvsext] has joined #wesnoth-dev
20171128 13:37:24-!- Guest63406 is now known as matthiaskrgr
20171128 14:10:41-!- irker050 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20171128 14:30:53-!- Guest14493 [~amir@public.metalab.wien.funkfeuer.at] has joined #wesnoth-dev
20171128 14:40:53-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Remote host closed the connection]
20171128 14:42:15-!- fabi [~fabi@2a02:810c:c840:2e65:44f0:40c1:a4da:b30e] has joined #wesnoth-dev
20171128 14:42:15-!- fabi [~fabi@2a02:810c:c840:2e65:44f0:40c1:a4da:b30e] has quit [Changing host]
20171128 14:42:15-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20171128 15:05:18-!- Guest14493 [~amir@public.metalab.wien.funkfeuer.at] has quit [Read error: Connection reset by peer]
20171128 15:23:04-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .]
20171128 16:20:29-!- sevu [~Shiki@p5485565E.dip0.t-ipconnect.de] has joined #wesnoth-dev
20171128 16:27:17-!- vladimirslavik [vslavik@nat/redhat/x-maqwpgyjgikwqmdw] has quit [Quit: Leaving]
20171128 16:27:51< vn971> hmm. If I have a commit hash, how do I get the wesnoth version it's being introduced in? Use case: I want to update the wiki by adding a new method. I know the commit when it was introduced.
20171128 16:31:55< Soliton> git describe <commit hash>  will probably tell you.
20171128 16:33:23< vn971> Soliton: indeed. Thx. (Also, I've already re-checked how wesnoth is build, and found out the src/wesconfig.h thing.)
20171128 16:36:57-!- sevu [~Shiki@p5485565E.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20171128 16:58:37-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20171128 17:00:56-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20171128 17:05:38< AI0867> to whoever configured appveyor: the appveyor folks disabled daily builds to reduce their load. Replacing it with build-on-push on our master might not be in their best interest. Also, the builds mainly seem to be failing, and I don't see how I can get much useful information out of them.
20171128 17:06:15< JyrkiVesterinen> Their intention was to avoid dead projects being built every day for all eternity.
20171128 17:06:33< JyrkiVesterinen> Most of the failing builds are from pull requests.
20171128 17:06:59< JyrkiVesterinen> In particular, adding a new file but not mentioning it in the VS project file will cause linking errors.
20171128 17:07:57< JyrkiVesterinen> Finally, I have configured Appveyor not to report here if a build succeeds. Other project members complained that the constant success reports were too annoying.
20171128 17:12:08< Soliton> do PRs get built because they have the same appveyor config? i suppose that can't easily be changed so PRs are only built if specifically requested?
20171128 17:13:25< JyrkiVesterinen> It is possible to set up a branch whitelist so that only those branches get built.
20171128 17:13:31-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171128 17:15:01< Soliton> does travis also builds all PRs?
20171128 17:15:10< JyrkiVesterinen> Yes.
20171128 17:16:33< Soliton> so i guess the annoyance is mainly that appveyor is a another/separate thing to travis and more likely to fail because it's harder to update the VS project files.
20171128 17:17:19< JyrkiVesterinen> Also because it may report a failure up to six times (once for each combination of VS2013/2015/2017 and Debug/Release).
20171128 17:18:23< Soliton> that can't be combined into one report?
20171128 17:19:01< JyrkiVesterinen> No. Travis CI has built-in support for IRC reports, but on AppVeyor we're using a custom script for IRC reports.
20171128 17:19:17< JyrkiVesterinen> The six builds run independently (and in parallel) and have no idea about each other.
20171128 17:23:17-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20171128 17:44:11< AI0867> we have access to the commit id, right? We could coalesce them elsewhere
20171128 17:47:06< JyrkiVesterinen> At least I can't really imagine any easy way to do that.
20171128 17:48:41< vn971> Q: how can I access a unit inside a "die" event, if the said unit could already be teleported to a different location in another "die" event? Is there an easy way?
20171128 17:49:44< AI0867> have a microservice listen to the reports and report on 1) first failure 2) last result 3) timeout
20171128 17:50:08< JyrkiVesterinen> I have never written microservices, so someone else would have to do it.
20171128 18:01:12-!- travis-ci [~travis-ci@ec2-54-87-114-186.compute-1.amazonaws.com] has joined #wesnoth-dev
20171128 18:01:13< travis-ci> AI0867/wesnoth#55 (gender-refactor - 218dd64 : Alexander van Gessel): The build has errored.
20171128 18:01:14< travis-ci> Build details : https://travis-ci.org/AI0867/wesnoth/builds/308503129
20171128 18:01:14-!- travis-ci [~travis-ci@ec2-54-87-114-186.compute-1.amazonaws.com] has left #wesnoth-dev []
20171128 18:04:21-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20171128 18:09:40< vn971> If anything, the "unit" variable doesn't hold any meaningful data either: https://wiki.wesnoth.org/EventWML#Predefined_Events_With_Filters   I guess internally, it may rely on x1, y1 (which is why it stops working after xy coordinate change).
20171128 18:16:34< vn971> I wonder, is it a rare enough case to raise a feature request: support id1, id2 in addition to x1,x2,y1,y2, and make the "unit" and "secondary_unit" use id-s instead of x,y-s ?
20171128 18:38:54-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20171128 18:40:57-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171128 18:54:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171128 18:54:12-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171128 18:54:19-!- sevu [~Shiki@p5485565E.dip0.t-ipconnect.de] has joined #wesnoth-dev
20171128 19:03:59-!- sevu [~Shiki@p5485565E.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20171128 19:09:17-!- irker560 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171128 19:09:17< irker560> wesnoth: Charles Dang wesnoth:event_handler_list_refactor_pass_2 3bd40136a39f / src/game_events/handlers.cpp: Minor cleanup to 2045b6739e0f4e544 https://github.com/wesnoth/wesnoth/commit/3bd40136a39f813f430e742163b6e29ffe8ff626
20171128 19:09:50< vn971> hmm, I got that kind of thing:    Thread 1 "wesnoth" received signal SIGABRT, Aborted.    0x00007ffff37c88a0 in raise () from /usr/lib/libc.so.6
20171128 19:10:08< vn971> should I add `bt`, `bt full` and raise an issue?
20171128 19:10:20< JyrkiVesterinen> Please do.
20171128 19:10:37< vn971> actually, I don't remember exactly, but I think I left my wesnoth instance playing vs itself (AI vs AI).   OK, cool then.
20171128 19:22:23< vn971> Raised. It could be the probability bug again (src/attack_prediction.cpp:1766, Assertion `prob_stay_alive >= 0.0 && prob_stay_alive <= 1.0' failed.)
20171128 19:22:55< JyrkiVesterinen> "prob_stay_alive=-2.2204460492503131e-16"
20171128 19:22:55< vultraz> assigned to jyrki
20171128 19:23:17< JyrkiVesterinen> Yes, your full backtrace shows that the probability to stay alive is slightly negative.
20171128 19:28:44-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20171128 19:29:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171128 19:30:13< vn971> BTW, if I had an AI vs AI match, should there be auto saves?  (Because there are none. If they should be, I'll raise a bug.)
20171128 19:31:59< vn971> And another question (sorry, I'm a bit in a mood). Does it make sense to include an AI-vs-AI battle into standard wesnoth tests? Like those run by travis/AppVeyor/whatever.
20171128 19:34:01-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 276 seconds]
20171128 19:36:07-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171128 19:38:19-!- sevu [~Shiki@p5485565E.dip0.t-ipconnect.de] has joined #wesnoth-dev
20171128 19:39:20< irker560> wesnoth: Jyrki Vesterinen wesnoth:master f62b62b7008b / src/attack_prediction.cpp: Fix #2251: possible crash when AI invokes attack prediction https://github.com/wesnoth/wesnoth/commit/f62b62b7008bceec3b05cd0a92689600e7690eb9
20171128 19:43:54< vn971> JyrkiVesterinen: would it make sense to have an assertion "probability >= 0.00000000001" ?
20171128 19:44:15< vn971> before making it positive.
20171128 19:44:36< JyrkiVesterinen> You mean -0.00000000001 (negative)?
20171128 19:46:56< vn971> JyrkiVesterinen: ah, yes, indeed. (my mistake)
20171128 19:47:23< vn971> the negative
20171128 19:47:54< JyrkiVesterinen> Indeed, having such an assertion might make sense. But it has a performance cost, and attack prediction needs to be fast.
20171128 19:48:06< matthiaskrgr> multithread it \o/ 
20171128 19:48:30 * matthiaskrgr has actually no idea how the prediction works 
20171128 19:49:39< JyrkiVesterinen> The affected function is just a kind of side-effect that calculates the probability of being slowed/poisoned after the fight, not the actual prediction.
20171128 19:49:47< JyrkiVesterinen> (But it's almost as complex anyway.)
20171128 19:50:01< vn971> JyrkiVesterinen: is there an easy way to measure performance implications?
20171128 19:50:31< JyrkiVesterinen> Yes. Any profiler.
20171128 19:59:59< vn971> JyrkiVesterinen: well, I meant to say that, if you're interested, I think it would really make sense to measure. And if there is no considerable performance impact, add the assertion. I can't do it myself though as I don't code CPP.
20171128 20:02:29< JyrkiVesterinen> I'm not really willing to do that. Bug reports about issues those assertions have detected have been rare enough that I'm now confident that they aren't going to find anything more than rounding errors at this point.
20171128 20:14:01-!- timotei_ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 240 seconds]
20171128 20:16:20-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20171128 20:23:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171128 20:29:54< vn971> JyrkiVesterinen: OK, as you say. Obviously you're more informed on this.
20171128 20:33:51-!- Bonobo [~Bonobo@220-244-175-160.static.tpgi.com.au] has joined #wesnoth-dev
20171128 20:35:24-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20171128 20:50:27-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Ping timeout: 258 seconds]
20171128 20:50:50-!- DDR [~david@ec2.happyspork.com] has quit [Ping timeout: 258 seconds]
20171128 20:54:32-!- Jetrel_bot [~Jetrel@ec2.happyspork.com] has quit [Quit: ZNC - http://znc.in]
20171128 20:56:13-!- Jetrel_bot [~Jetrel@ec2.happyspork.com] has joined #wesnoth-dev
20171128 20:56:37-!- DDR [~david@ec2.happyspork.com] has joined #wesnoth-dev
20171128 20:57:48-!- crimson_penguin [~crimson_p@ec2.happyspork.com] has joined #wesnoth-dev
20171128 20:57:48-!- crimson_penguin [~crimson_p@ec2.happyspork.com] has quit [Changing host]
20171128 20:57:48-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20171128 21:04:11< irker560> wesnoth: Charles Dang wesnoth:master 056d7ac8f88c / src/ (8 files in 2 dirs): Game Events: refactored event handler storage https://github.com/wesnoth/wesnoth/commit/056d7ac8f88ca4614b22d10894235a93c1637eb2
20171128 21:04:14< irker560> wesnoth: Charles Dang wesnoth:master 230dce9fec1f / src/game_events/handlers.cpp: Minor cleanup to 2045b6739e0f4e544 https://github.com/wesnoth/wesnoth/commit/230dce9fec1fc24fc2bf8e3e5c9943e2d161988c
20171128 21:44:04-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171128 21:44:13-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171128 22:40:16-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171128 22:40:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 264 seconds]
20171128 23:04:08-!- sevu [~Shiki@p5485565E.dip0.t-ipconnect.de] has quit [Disconnected by services]
20171128 23:04:08-!- shiki [~Shiki@p54856D2C.dip0.t-ipconnect.de] has joined #wesnoth-dev
20171128 23:06:26-!- doggone [~doggone@unaffiliated/doggone] has joined #wesnoth-dev
20171128 23:10:44-!- Appveyor [~Appveyor@67.225.139.254] has joined #wesnoth-dev
20171128 23:10:44< Appveyor> The Battle for Wesnoth (Visual Studio 2017) - Release Alexander van Gessel 383f81c: Change code style Failed
20171128 23:10:44< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-457
20171128 23:10:48-!- Appveyor [~Appveyor@67.225.139.254] has left #wesnoth-dev []
20171128 23:12:50-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20171128 23:37:11-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds]
20171128 23:43:12-!- Appveyor [~Appveyor@67.225.139.254] has joined #wesnoth-dev
20171128 23:43:12< Appveyor> The Battle for Wesnoth (Visual Studio 2017) - Debug Alexander van Gessel 383f81c: Change code style Failed
20171128 23:43:12< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-457
20171128 23:43:16-!- Appveyor [~Appveyor@67.225.139.254] has left #wesnoth-dev []
--- Log closed Wed Nov 29 00:00:37 2017