--- Log opened Sun Dec 03 00:00:45 2017 20171203 00:20:02-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:2050:fe90:ba22:120d] has quit [Remote host closed the connection] 20171203 00:25:20-!- Bonobo [~Bonobo@203.63.76.34] has joined #wesnoth-dev 20171203 01:13:15-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:2050:fe90:ba22:120d] has joined #wesnoth-dev 20171203 01:14:39-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:2050:fe90:ba22:120d] has quit [Remote host closed the connection] 20171203 01:23:12-!- travis-ci [~travis-ci@ec2-54-226-247-183.compute-1.amazonaws.com] has joined #wesnoth-dev 20171203 01:23:13< travis-ci> wesnoth/wesnoth#15890 (appveyor-collector - 01e77a6 : Alexander van Gessel): The build was fixed. 20171203 01:23:13< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/310654616 20171203 01:23:13-!- travis-ci [~travis-ci@ec2-54-226-247-183.compute-1.amazonaws.com] has left #wesnoth-dev [] 20171203 01:42:09-!- stikonas_ is now known as stikonas 20171203 01:47:08-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20171203 01:47:22-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20171203 02:09:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20171203 02:10:57-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds] 20171203 02:14:03-!- irker675 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20171203 02:21:51-!- gfgtdf_ [~chatzilla@x4e3633e1.dyn.telefonica.de] has joined #wesnoth-dev 20171203 02:23:53-!- gfgtdf [~chatzilla@x4e36969f.dyn.telefonica.de] has quit [Ping timeout: 255 seconds] 20171203 02:24:01-!- gfgtdf_ is now known as gfgtdf 20171203 02:25:02-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20171203 02:35:05< mattsc> celticminstrel: I’m not sure If I am interpreting you last comment on Issue 2247 correctly. If one uses simulate_combat() with a proxy_unit, then the location in the proxy table is the same as that of the unit on the map. 20171203 02:35:27< mattsc> However, it does have to work with a private copy of a unit that is still on the map. 20171203 02:35:44< mattsc> In that latter case, the coordinates can (and often are) different for the private unit. 20171203 02:36:44< celticminstrel> I meant a reference to the unit that's still on the map. 20171203 02:36:51< mattsc> _And_ it has to work with a private unit that has been extracted from the map. 20171203 02:37:26< mattsc> Okay, so yes, I agree then. It has to work in both of those cases. Or all three, if you include the proxy unit itself. 20171203 04:05:26< mattsc> gfgtdf: in my experience, operations on private units are usually significantly faster than the equivalent oepration on proxy units. At least in 1.12. 20171203 04:05:47< gfgtdf> hmm ok 20171203 04:05:49< mattsc> Also, anything involving calls to wesnoth.* is slow. 20171203 04:06:12< mattsc> “Slow” in the context of when you are trying to do the same thing over and over many thousands of times. 20171203 04:06:30< gfgtdf> but those calsl are the same for private and on-map units i'd think ? 20171203 04:07:23< mattsc> That’s probably true, yes. So I avoid as many of them as possible. Or do them only a few times and cache the results, or … 20171203 04:08:17< mattsc> I also set up another table ‘unit_info’ with only a subset of the most vital information. Accessing that turns out to be faster than accessing privtae units. 20171203 04:08:32< mattsc> Might just be the size of the table, I don’t know. 20171203 04:16:41-!- mesilliac_ [~mesilliac@p4FED30FE.dip0.t-ipconnect.de] has joined #wesnoth-dev 20171203 04:20:25-!- mesilliac [~mesilliac@p2E58415E.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds] 20171203 04:20:26-!- mesilliac_ is now known as mesilliac 20171203 04:21:05-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:2050:fe90:ba22:120d] has joined #wesnoth-dev 20171203 04:34:17-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20171203 04:34:25-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20171203 04:42:01-!- gfgtdf [~chatzilla@x4e3633e1.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.5.0/20171107091003]] 20171203 04:48:32-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:2050:fe90:ba22:120d] has quit [Remote host closed the connection] 20171203 06:37:09-!- TadCarlucci [~lundberg@74.193.219.119] has quit [Quit: Leaving] 20171203 06:37:35-!- TadCarlucci [~lundberg@74.193.219.119] has joined #wesnoth-dev 20171203 06:59:46< vultraz> Pokes celticminstrel 20171203 07:42:56-!- irker439 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20171203 07:42:56< irker439> wesnoth/wesnoth:appveyor-collector Alexander van Gessel 01e77a6206 Switch AppVeyor notifications to webhook vs2017/Debug Failed 20171203 07:42:57< irker439> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-appveyor-collector-524 20171203 07:45:02-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev 20171203 08:20:10-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20171203 08:37:13-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20171203 08:47:09< irker439> wesnoth/wesnoth:appveyor-collector Alexander van Gessel 01e77a6206 Switch AppVeyor notifications to webhook 1/6 Failed 20171203 08:47:10< irker439> Details vs2017/Debug: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-appveyor-collector-524 20171203 09:34:09-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev 20171203 09:54:43-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev 20171203 10:03:01-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:1929:97b7:d860:954a] has joined #wesnoth-dev 20171203 11:32:20-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .] 20171203 11:44:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20171203 12:23:10-!- irker439 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20171203 13:10:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20171203 14:21:09 * celticminstrel pokes vultraz 20171203 14:21:14-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:1929:97b7:d860:954a] has quit [Quit: Leaving] 20171203 14:23:03< vultraz> celticminstrel: nevermind, i abandoned the thing 20171203 14:26:28< celticminstrel> Oh fun. 20171203 14:27:07< vultraz> though the specific part involved asking whether we should add an as_string function since you can't concatenate wfl integers into strings 20171203 14:29:31< vultraz> i tried to do it but it sadly didn't work 20171203 14:31:22< celticminstrel> That's surprising, it should be super-easy to add one. 20171203 14:31:27< celticminstrel> As to whether we should, hmm... 20171203 14:31:57< celticminstrel> We do have the [n] syntax inside WFL strings for interpolating values into the string. 20171203 14:32:14< vultraz> if you have an integer var you cannot do something like 20171203 14:32:17< celticminstrel> So it's not really necessary to have an as_string, but I guess it wouldn't hurt either. 20171203 14:32:39< vultraz> key = "('foo/img.png~O(' .. alpha .. ')')" 20171203 14:33:12< celticminstrel> But you can do 'foo/img.png~O([alpha])' 20171203 14:34:13< vultraz> oh? 20171203 14:34:19< vultraz> this isn't documented.. 20171203 14:34:56< celticminstrel> https://wiki.wesnoth.org/Wesnoth_Formula_Language#Strings 20171203 14:35:35< vultraz> oh 20171203 14:35:44< vultraz> nevermind 20171203 14:36:13< vultraz> the string has to be part of a formula right? 20171203 14:36:26< vultraz> what am i saying, obviously >_< 20171203 14:36:32< vultraz> or else the [] will be aliteral 20171203 14:54:56-!- Bonobo [~Bonobo@203.63.76.34] has quit [Ping timeout: 255 seconds] 20171203 15:01:26-!- irker829 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20171203 15:01:26< irker829> wesnoth/wesnoth:master Alexander van Gessel 5df42342f7 Switch AppVeyor notifications to webhook All builds passed 20171203 15:27:57-!- Jetrel_bot [~Jetrel@ec2.happyspork.com] has quit [Ping timeout: 240 seconds] 20171203 15:29:57-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Ping timeout: 240 seconds] 20171203 15:30:08-!- DDR [~david@ec2.happyspork.com] has quit [Ping timeout: 258 seconds] 20171203 15:32:47-!- Jetrel_bot [~Jetrel@ec2.happyspork.com] has joined #wesnoth-dev 20171203 15:35:09-!- crimson_penguin [~crimson_p@ec2.happyspork.com] has joined #wesnoth-dev 20171203 15:35:09-!- crimson_penguin [~crimson_p@ec2.happyspork.com] has quit [Changing host] 20171203 15:35:09-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev 20171203 15:36:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20171203 15:38:23-!- DDR [~david@ec2.happyspork.com] has joined #wesnoth-dev 20171203 17:11:18< irker829> wesnoth/wesnoth:master Alexander van Gessel 5df42342f7 Switch AppVeyor notifications to webhook All builds passed 20171203 17:34:00-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity] 20171203 17:57:00-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:65cd:9652:84a1:3071] has joined #wesnoth-dev 20171203 18:12:13-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:65cd:9652:84a1:3071] has quit [Remote host closed the connection] 20171203 18:13:40-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:65cd:9652:84a1:3071] has joined #wesnoth-dev 20171203 18:14:44-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 255 seconds] 20171203 18:16:34-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20171203 18:37:16-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!] 20171203 18:39:43-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Ping timeout: 250 seconds] 20171203 18:40:18-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20171203 18:43:23-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:65cd:9652:84a1:3071] has quit [Remote host closed the connection] 20171203 19:09:05-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:65cd:9652:84a1:3071] has joined #wesnoth-dev 20171203 19:09:45-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:65cd:9652:84a1:3071] has quit [Remote host closed the connection] 20171203 19:10:20-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:65cd:9652:84a1:3071] has joined #wesnoth-dev 20171203 19:10:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20171203 19:10:30-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20171203 19:21:33-!- stikonas_ is now known as stikonas 20171203 20:08:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds] 20171203 20:15:35-!- irker829 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20171203 20:17:52-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:65cd:9652:84a1:3071] has quit [Remote host closed the connection] 20171203 20:18:35-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:65cd:9652:84a1:3071] has joined #wesnoth-dev 20171203 20:18:36-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:65cd:9652:84a1:3071] has quit [Remote host closed the connection] 20171203 20:21:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20171203 20:28:22< Soliton> TadCarlucci: any reason why you closed my pull request? 20171203 20:30:13< TadCarlucci> damnit it was supposed to merge and close 20171203 20:30:35-!- irker372 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20171203 20:30:35< irker372> wesnoth: soliton- wesnoth:master c3e9e816e963 / .travis.yml: Fix shell injection https://github.com/wesnoth/wesnoth/commit/c3e9e816e963456b04907bd37161a73437a212a4 20171203 20:30:38< TadCarlucci> sorry 20171203 20:30:47< Soliton> ah, no worries. 20171203 21:03:55-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:65cd:9652:84a1:3071] has joined #wesnoth-dev 20171203 21:19:51-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev 20171203 21:20:13-!- vultraz [uid24821@wesnoth/developer/vultraz] has left #wesnoth-dev [] 20171203 21:20:27-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev 20171203 21:30:54< irker372> wesnoth: pentarctagon wesnoth:master 49b6ede463c0 / CMakeLists.txt SConstruct src/CMakeLists.txt src/SConscript: Move most strict warning flags to the default build flags. https://github.com/wesnoth/wesnoth/commit/49b6ede463c0b34cffc68991a71907ed3e0d7726 20171203 21:33:09-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20171203 22:18:34-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:65cd:9652:84a1:3071] has quit [Remote host closed the connection] 20171203 22:21:18-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection] 20171203 22:23:11< irker372> wesnoth: Gregory A Lundberg wesnoth:master dcfdcfd9867a / src/tests/test_util.cpp: Remove unneeded casts https://github.com/wesnoth/wesnoth/commit/dcfdcfd9867a9bb594170b0357123dfb06bc1af3 20171203 22:31:45-!- Bonobo [~Bonobo@203.63.76.34] has joined #wesnoth-dev 20171203 22:32:08< irker372> wesnoth: Alexander van Gessel wesnoth:appveyor-collector 4c571c745b73 / utils/appveyor/irc-notify.py: Remove appveyor custom IRC notify script https://github.com/wesnoth/wesnoth/commit/4c571c745b7379021c14a3a082cf3711ccf4a7e4 20171203 22:33:02-!- atarocch [~atarocch@93.56.164.28] has quit [Quit: Leaving] 20171203 22:36:01< irker372> wesnoth: pentarctagon wesnoth:master 817e9dbb3363 / SConstruct: Remove the scons workaround for Travis only having SDL 2.0.2 https://github.com/wesnoth/wesnoth/commit/817e9dbb336313bb55191729df8941234e27072d 20171203 22:50:10< irker372> wesnoth: Gregory A Lundberg wesnoth:master bb7cf37e0446 / src/tests/test_util.cpp: Fix fix in dcfdcfd https://github.com/wesnoth/wesnoth/commit/bb7cf37e04463368891b576467738287d5266282 20171203 22:53:17-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 255 seconds] 20171203 22:59:37-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20171203 22:59:48-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20171203 23:19:17-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20171203 23:21:15-!- markus__ [~mjs-de@x4e302ffe.dyn.telefonica.de] has joined #wesnoth-dev 20171203 23:22:05-!- markus_ [~mjs-de@x4e35b624.dyn.telefonica.de] has quit [Ping timeout: 255 seconds] 20171203 23:28:09-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Remote host closed the connection] 20171203 23:30:27-!- markus__ [~mjs-de@x4e302ffe.dyn.telefonica.de] has quit [Remote host closed the connection] --- Log closed Mon Dec 04 00:00:47 2017