--- Log opened Sat Dec 09 00:00:54 2017
20171209 00:15:21-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20171209 00:51:58-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20171209 00:53:22-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20171209 00:57:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 268 seconds]
20171209 03:27:49-!- irker033 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171209 03:27:49< irker033> wesnoth: Gregory A Lundberg wesnoth:master b7881a0e6e49 / / (5 files in 3 dirs): Force linking all widgets https://github.com/wesnoth/wesnoth/commit/b7881a0e6e49d5a78f79625e11d916f745185ffd
20171209 03:34:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20171209 04:03:33-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20171209 04:29:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171209 04:30:08-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171209 05:05:49-!- Netsplit *.net <-> *.split quits: TadCarlucci, Soliton, crimson_penguin, senkwich, Gambit, wedge009, NicolasF[m], madmax28, esr, Necrosporus,  (+45 more, use /NETSPLIT to show all of them)
20171209 05:31:25-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Quit: Reconnecting]
20171209 05:39:59-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20171209 05:39:59-!- Netsplit over, joins: Soliton, Rhonda, nore, tomreyn, celticminstrel, JyrkiVesterinen, wedge009, TadCarlucci, minzbonbon, janebot (+38 more)
20171209 06:42:14-!- Greg-Boggs [~greg_bogg@c-73-11-32-127.hsd1.or.comcast.net] has joined #wesnoth-dev
20171209 06:46:11-!- Greg-Boggs [~greg_bogg@c-73-11-32-127.hsd1.or.comcast.net] has quit [Ping timeout: 240 seconds]
20171209 06:50:49-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:8452:ba50:fa5b:cdb0] has joined #wesnoth-dev
20171209 06:53:02-!- irker364 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171209 06:53:03< irker364> wesnoth/wesnoth:master Gregory A Lundberg b7881a0e6e Force linking all widgets AppVeyor: All builds passed
20171209 06:55:06-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:8452:ba50:fa5b:cdb0] has quit [Ping timeout: 240 seconds]
20171209 07:19:30< irker364> wesnoth: newfrenchy83 wesnoth:master 23e358fa07ac / / (4 files in 4 dirs): add major_amla option in amlas (#2268) https://github.com/wesnoth/wesnoth/commit/23e358fa07ac9a757d23fd08f884dccfc43f3c54
20171209 07:31:31< celticminstrel> vultraz: You there?
20171209 07:31:47< vultraz> Yes
20171209 07:31:52< celticminstrel> PR 2231
20171209 07:32:10< celticminstrel> Reopen?
20171209 07:33:27 * celticminstrel pokes vultraz 
20171209 07:33:41< celticminstrel> I'm not entirely clear on what's going on there.
20171209 07:33:50< celticminstrel> It looks like it got merged and then reverted?
20171209 07:37:03< irker364> wesnoth: Celtic Minstrel wesnoth:fix_2280 114b5c74fdb3 / src/gui/dialogs/lua_interpreter.cpp: Fix #2280 (lua console formatting can be broken) https://github.com/wesnoth/wesnoth/commit/114b5c74fdb30297a7647708aa3f521c6d21602a
20171209 07:37:14< vultraz> don't reopen
20171209 07:37:24< celticminstrel> Why? What's going on there?
20171209 07:37:29< vultraz> but we should figure out how to intagrate the feature
20171209 07:37:49< vultraz> it was manually merged but when i tested i found the design bad
20171209 07:38:32< celticminstrel> Argh, wrong issue number...
20171209 07:39:20< celticminstrel> Bad how?
20171209 07:39:54< irker364> wesnoth: Celtic Minstrel wesnoth:fix_2280 168d86c94925 / src/gui/dialogs/lua_interpreter.cpp: Fix #2281 (lua console formatting can be broken) https://github.com/wesnoth/wesnoth/commit/168d86c94925cc7b262e07fe77943aac26a6dd80
20171209 07:42:30< vultraz> What is the difference between Surrender and Quit and Quit without  Surrender
20171209 07:42:33< vultraz> You’re quitting
20171209 07:42:34-!- higgins [~higgins@68.ip-149-56-14.net] has quit [Quit: Leaving]
20171209 07:43:04< vultraz> Though thinking about it, maybe Surrender is supposed to kill all units?
20171209 07:43:05< celticminstrel> I think it's something to do with tracking the result of the match?
20171209 07:43:21< celticminstrel> I'm not entirely sure, but I recall someone explaining this at some point.
20171209 07:43:31< celticminstrel> Maybe Soliton knows the answer.
20171209 07:43:51< vultraz> Also making it the quit prompt is a bit awkward
20171209 07:44:07< vultraz> I need to rethink exactly how the feature should be handled
20171209 07:45:51-!- higgins [~higgins@68.ip-149-56-14.net] has joined #wesnoth-dev
20171209 07:47:32-!- higgins [~higgins@68.ip-149-56-14.net] has quit [Excess Flood]
20171209 07:53:37-!- higgins [~higgins@68.ip-149-56-14.net] has joined #wesnoth-dev
20171209 08:09:50-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20171209 08:15:24-!- zacklocx[m] [zacklocxma@gateway/shell/matrix.org/x-wqrmqqzpxdymkimk] has joined #wesnoth-dev
20171209 08:24:14-!- celticminstrel is now known as celmin|sleep
20171209 08:26:46-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20171209 08:31:53-!- desttinghim[m] [desttinghi@gateway/shell/matrix.org/x-blhypglrdexrdiaf] has joined #wesnoth-dev
20171209 08:39:20-!- zookeeper_ [~lmsnie@dsl-tkubng21-58c01d-248.dhcp.inet.fi] has joined #wesnoth-dev
20171209 08:41:11-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20171209 08:43:23-!- mjs-de [~mjs-de@x5ce4a688.dyn.telefonica.de] has joined #wesnoth-dev
20171209 08:51:56-!- zookeeper_ is now known as zookeeper
20171209 08:52:09-!- zookeeper [~lmsnie@dsl-tkubng21-58c01d-248.dhcp.inet.fi] has quit [Changing host]
20171209 08:52:09-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20171209 08:53:14-!- vn971 [~vasya@94.158.103.15] has quit [Quit: Leaving.]
20171209 09:01:16-!- zacklocx[m] [zacklocxma@gateway/shell/matrix.org/x-wqrmqqzpxdymkimk] has quit [Read error: Connection reset by peer]
20171209 09:01:16-!- desttinghim[m] [desttinghi@gateway/shell/matrix.org/x-blhypglrdexrdiaf] has quit [Remote host closed the connection]
20171209 09:03:12-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20171209 09:07:45-!- NicolasF[m] [nicolasfma@gateway/shell/matrix.org/x-nciaigmnmgjelsna] has joined #wesnoth-dev
20171209 09:13:18-!- travis-ci [~travis-ci@ec2-54-144-6-16.compute-1.amazonaws.com] has joined #wesnoth-dev
20171209 09:13:20< travis-ci> wesnoth/wesnoth#15961 (fix_2280 - 168d86c : Celtic Minstrel): The build passed.
20171209 09:13:20< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/313870024
20171209 09:13:20-!- travis-ci [~travis-ci@ec2-54-144-6-16.compute-1.amazonaws.com] has left #wesnoth-dev []
20171209 09:15:23-!- NicolasF[m] [nicolasfma@gateway/shell/matrix.org/x-nciaigmnmgjelsna] has quit [Remote host closed the connection]
20171209 09:20:34-!- NicolasF[m] [nicolasfma@gateway/shell/matrix.org/x-ottszefrngwetzul] has joined #wesnoth-dev
20171209 09:22:33< zookeeper> i wasn't aware there was still something unclear about how the surrender feature should work.
20171209 09:27:58-!- vn971 [~vasya@185.79.102.52] has joined #wesnoth-dev
20171209 09:29:12-!- vn971 [~vasya@185.79.102.52] has quit [Client Quit]
20171209 09:42:14-!- madmax28 [madmax28ma@gateway/shell/matrix.org/x-pdtcjgssxsychdtw] has joined #wesnoth-dev
20171209 09:42:14-!- desttinghim[m] [desttinghi@gateway/shell/matrix.org/x-arqqehamsydzxxko] has joined #wesnoth-dev
20171209 09:42:14-!- ChipmunkV[m] [chipmunkvm@gateway/shell/matrix.org/x-xateckeymfwessib] has joined #wesnoth-dev
20171209 09:42:14-!- zacklocx[m] [zacklocxma@gateway/shell/matrix.org/x-uiiwpucftfypauyf] has joined #wesnoth-dev
20171209 09:42:21-!- Greg_Boggs[m] [gregboggsm@gateway/shell/matrix.org/x-kuprdrwgbyntnpcp] has joined #wesnoth-dev
20171209 09:42:36-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20171209 10:18:22< irker364> wesnoth/wesnoth:master newfrenchy83 23e358fa07 add major_amla option in amlas (#2268) AppVeyor: vs2017/Debug Failed
20171209 10:18:23< irker364> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-594
20171209 10:20:59-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:21d7:8e0f:2a8e:9094] has joined #wesnoth-dev
20171209 11:16:10< irker364> wesnoth/wesnoth:master newfrenchy83 23e358fa07 add major_amla option in amlas (#2268) AppVeyor: 1/6 builds failed
20171209 11:16:11< irker364> Details vs2017/Debug: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-594
20171209 11:45:48-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20171209 12:23:48-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20171209 12:25:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171209 12:28:17-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:21d7:8e0f:2a8e:9094] has quit [Quit: Leaving]
20171209 13:44:08-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20171209 13:51:21-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20171209 14:03:03< mattsc> celmin|sleep, TadCarlucci: I don’t know what I need to do about #2279.  If the question is just whether Xcode compiles, it does without changes (except that #2277 is still open, but that’s unrelated).
20171209 14:16:14-!- irker364 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20171209 14:20:31-!- mjs-de [~mjs-de@x5ce4a688.dyn.telefonica.de] has quit [Remote host closed the connection]
20171209 14:37:41< TadCarlucci> mattsc If 2279 is good to go with XCode then you don't need to do anything. The test for 2279 is simply can you run the game. When I test if 2279 is not working, the vertical scroll bar widget is not linked and the game crashes to desktop during start-up and I never make it to the main titlescreen.
20171209 14:39:12< mattsc> TadCarlucci: okay, cool, all is working then.  I did start the game and loaded a game and started a campaign.
20171209 14:39:35< TadCarlucci> mattsc, As to 2277 I don't know how to fix it and can't test it other than to make Travis happy. IF it's just removing the undefines and praying, I can git it a shot I guess.
20171209 14:39:44-!- irker161 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171209 14:39:44< irker161> wesnoth/wesnoth:fix_2280 Celtic Minstrel 114b5c74fd Fix #2280 (lua console formatting can be AppVeyor: All builds passed
20171209 14:41:02< mattsc> TadCarlucci: yeah, I don’t know what how to fix it either, but I can test whatever somebody comes up with.  I think singalen is looking into it though, so that’s good.
20171209 14:41:47< mattsc> The other OS X problem is the crash in the editor when trying to load a map that’s been around for at least couple releases.  I have found where that originates, but again don’t know what to do about it.
20171209 14:42:16< mattsc> I should probably pull that out of the release forum thread and make it into an issue.
20171209 14:42:41< mattsc> In fact, it might be worth making that a blocker at this time.
20171209 14:45:26< TadCarlucci> mattsc, Um .. yes.
20171209 14:59:21-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171209 14:59:28-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171209 15:06:10< celmin|sleep> mattsc: Wasn't there already an issue for that? I recall linking it from the release thread.
20171209 15:11:33< mattsc> celmin|sleep: there is?
20171209 15:12:44< mattsc> Ah, there is a link _before_ my post in the release thread:  https://github.com/wesnoth/wesnoth/issues/1975
20171209 15:13:22< mattsc> That looks slightly different though.  Currently the games crashes as soon as you hit the “load map” item.
20171209 15:15:07< celmin|sleep> Yeah, that's not it.
20171209 15:15:50< celmin|sleep> https://github.com/wesnoth/wesnoth/issues/2094
20171209 15:16:08< mattsc> Right, just saw that.
20171209 15:17:18< mattsc> Yeah, that’s probably it.  I tried and I get that crash too.
20171209 15:18:07< mattsc> Anybody opposed to me marking this a blocker?  I think this is pretty serious.
20171209 15:18:20< celmin|sleep> Sure, I guess.
20171209 15:18:35< celmin|sleep> I originally thought it was just a 10.7 thing, but I guess not.
20171209 15:18:47< celmin|sleep> (That was before the issue was created and other people besides me started getting it.)
20171209 15:20:49< mattsc> Right, it’s now happening for me on 10.12 both with the official package and with my own build.
20171209 15:23:10< celmin|sleep> Doesn't your own build actually use the same libs as the official package?
20171209 15:23:53-!- DeFender1031 [~DeFender1@89-138-239-68.bb.netvision.net.il] has joined #wesnoth-dev
20171209 15:27:46-!- celmin|sleep is now known as celticminstrel
20171209 15:29:19< mattsc> I don’t remember.  It did not at some point, but I might have changed that.
20171209 15:31:12< JyrkiVesterinen> celticminstrel: Are you working on #2285? I'm planning to fix it.
20171209 15:33:56< celticminstrel> JyrkiVesterinen: I am not.
20171209 15:34:01< celticminstrel> Go for it.
20171209 15:34:37< celticminstrel> Why is UserEvent of non-trivial type...
20171209 15:34:55< celticminstrel> Pretty sure it's supposed to be.
20171209 15:35:01< celticminstrel> Which is why memset is being used.
20171209 15:37:02< JyrkiVesterinen> My guess would be the presence of the default constructor.
20171209 15:37:37< JyrkiVesterinen> According to Wikipedia's definition, a trivial default constructor is a requirement for trivial classes/structs.
20171209 15:39:09< TadCarlucci> mattsc, celticminstrel I beleive you should be seeing that crash THREE places: When selecting a campaign, sorting by Name // When in the file dialog, sorting directory entries, as you noted // In the MP lobby, sorting players by name
20171209 15:40:23< TadCarlucci> celticminstrel, The mere use of memset should have been a Red Flag on the code. GCC 8 catching it is a good call.
20171209 15:40:32< celticminstrel> So wait, are you saying that you can't use memset because you're using memset?
20171209 15:40:45< JyrkiVesterinen> TadCarlucci: Isn't that memset your code?
20171209 15:41:07< JyrkiVesterinen> celticminstrel: Indeed.
20171209 15:41:19< celticminstrel> :|
20171209 15:41:40< TadCarlucci> TBH I don't recall .. if so I probably held my nose and did it because I didn't see any other way 
20171209 15:41:46< JyrkiVesterinen> I'll make the constructor private and add a create() function that calls memset *after* constructing the object.
20171209 15:42:00< JyrkiVesterinen> That way the type should remain trivial.
20171209 15:42:29< celticminstrel> Private stuff doesn't make it non-trivial?
20171209 15:42:35< celticminstrel> Or maybe just private data, I guess.
20171209 15:42:39< TadCarlucci> What are we memset()'ing. If it's an SDL struct, then that makes sense to memset because it's C code
20171209 15:42:50< mattsc> TadCarlucci: I don’t get the crash in the lobby, but there'
20171209 15:43:05< mattsc> s nobody there except for me at the moment, so that might be it  :P
20171209 15:43:26< TadCarlucci> mattsc, Those are the tree places our icompare appears in the code.
20171209 15:43:28< JyrkiVesterinen> TadCarlucci: the UserEvent class inherits the SDL struct.
20171209 15:43:36< JyrkiVesterinen> The class memset()s itself.
20171209 15:43:57< mattsc> TadCarlucci: maybe there’s no sort attempted if there’s only one entry?
20171209 15:43:58< TadCarlucci> So demote the struct to a member and mashal the values.
20171209 15:44:10< mattsc> Anwyays, I got to go.  Will be back in a few hours.
20171209 15:44:20< JyrkiVesterinen> OK, I'll do that.
20171209 15:44:41-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20171209 15:45:13< TadCarlucci> JyrkiVesterinen, If it's my code the only reason I didn't is I was afraid something else would break if I dropped the inheritance and I just wanted a bug gone.
20171209 15:45:44< JyrkiVesterinen> Inheritance is easier to implement than composition.
20171209 15:46:02< TadCarlucci> ISTR it now. It was uninitialized members coming from Coverity
20171209 15:46:38< JyrkiVesterinen> Just earlier this week I added a MediaStreamProxy class to a music player I develop in my spare time... and that class *inherits* MediaStream instead of having it as a member variable.
20171209 15:48:04< TadCarlucci> Sometimes the best we can do is hold our noses and pray it doesn't come back to haunt us. And sometimes, it does.
20171209 16:16:47-!- tad_carlucci [~lundberg@74.193.219.119] has joined #wesnoth-dev
20171209 16:32:05< irker161> wesnoth: Jyrki Vesterinen wesnoth:master b710af17163e / src/ (21 files in 13 dirs): Fix #2285: GCC-dev compiler warnings https://github.com/wesnoth/wesnoth/commit/b710af17163e307232682297c986c569082c1ff9
20171209 16:37:09-!- DeFender1031 [~DeFender1@89-138-239-68.bb.netvision.net.il] has quit [Remote host closed the connection]
20171209 16:37:27-!- DeFender1031 [~DeFender1@89-138-239-68.bb.netvision.net.il] has joined #wesnoth-dev
20171209 17:09:06-!- tad_carlucci [~lundberg@74.193.219.119] has quit [Quit: Leaving]
20171209 17:20:12-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:6453:1232:f2ec:7f40] has joined #wesnoth-dev
20171209 17:41:25-!- DeFender1031 [~DeFender1@89-138-239-68.bb.netvision.net.il] has quit [Remote host closed the connection]
20171209 17:41:43-!- DeFender1031 [~DeFender1@89-138-239-68.bb.netvision.net.il] has joined #wesnoth-dev
20171209 17:46:09-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:6453:1232:f2ec:7f40] has quit [Remote host closed the connection]
20171209 17:49:56-!- DeFender1031 [~DeFender1@89-138-239-68.bb.netvision.net.il] has quit [Remote host closed the connection]
20171209 17:50:14-!- DeFender1031 [~DeFender1@89-138-239-68.bb.netvision.net.il] has joined #wesnoth-dev
20171209 18:03:25< irker161> wesnoth/wesnoth:master Celtic Minstrel 83af0e54c6 Fix #2281 (lua console formatting can be AppVeyor: All builds passed
20171209 18:17:32-!- DeFender1031 [~DeFender1@89-138-239-68.bb.netvision.net.il] has quit [Remote host closed the connection]
20171209 18:17:52-!- DeFender1031 [~DeFender1@89-138-239-68.bb.netvision.net.il] has joined #wesnoth-dev
20171209 18:25:40-!- mjs-de [~mjs-de@x4e3080ee.dyn.telefonica.de] has joined #wesnoth-dev
20171209 18:37:13-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20171209 19:43:43-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:6453:1232:f2ec:7f40] has joined #wesnoth-dev
20171209 19:58:48< fabi> Is any of the Wesnoth fonts a cursive one, looking like handwritten?
20171209 20:06:24-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20171209 20:16:06-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171209 20:16:18-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171209 20:18:27-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:6453:1232:f2ec:7f40] has quit [Remote host closed the connection]
20171209 20:29:48-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:6453:1232:f2ec:7f40] has joined #wesnoth-dev
20171209 20:29:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20171209 20:29:59-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171209 20:39:59< zookeeper> vultraz, i hope you realize there's something _actually_ wrong with your map edges screenshot. namely the fact that the background beyond the borders is black.
20171209 20:40:29< vultraz> Deliberate
20171209 20:40:37< zookeeper> elaborate, you mean? :p
20171209 20:40:47< zookeeper> or not
20171209 20:41:07< zookeeper> or if you mean it's deliberate, then you need to elaborate, because that makes no sense.
20171209 20:42:16< vultraz> The aesthetic is supposed to be that you have a cutscene map and use the fake shroud to nicely have the map fade into the background
20171209 20:42:29< zookeeper> ...what the hell
20171209 20:43:00< zookeeper> am i wrong in guessing that you just came up with that some time ago and this is the first time you mention it to anyone?
20171209 20:43:59< vultraz> Shadowm came up with it.
20171209 20:44:13< vultraz> We adopted his cutscene themes remember
20171209 20:44:23< vultraz> What’s the big problem
20171209 20:47:27< zookeeper> well, it sure sounds like you changed thing X (background beyond map edges) so it looks bad and then you want thing Y changed (map edges on cutscene maps) to "fix" the supposed problem without ever explaining the whole picture of what you want and why.
20171209 20:48:30< zookeeper> it's completely unclear to me why on cutscene maps, fake shroud edges would look better than regular borders.
20171209 20:48:46< zookeeper> not to mention you can't even get straight horizontal lines with fake shroud.
20171209 20:51:27< vultraz> The fake shroud is only for indoor or dungeon maps
20171209 20:51:31< vultraz> Otherwise it just cuts off
20171209 20:51:33< vultraz> But that’s fine
20171209 20:52:08< zookeeper> you want outdoor cutscene maps to just cut off instead of having any kind of border?
20171209 20:52:32< vultraz> That’s how he does it and it’s fine
20171209 20:53:18< vultraz> Would be more work than it’s worth to deal with that
20171209 20:55:42< zookeeper> that principle doesn't apply to whatever problem you think there currently is?
20171209 20:55:52< zookeeper> i still don't know what that problem is.
20171209 20:56:20 * fabi makes popcorn
20171209 20:58:33< zookeeper> i'd just want an explanation of why a reasonable person would come to the conclusion that there's something wrong with the standard map border aesthetics on cutscene maps.
20171209 21:00:09< vultraz> Look at that picture
20171209 21:00:13< vultraz> It looks like shit
20171209 21:00:22< vultraz> And we used to be able to hide map borders
20171209 21:00:34< vultraz> That changed when you made them work with tg wml
20171209 21:00:53< zookeeper> that picture is irrelevant because it looks like shit because you made it that way :p
20171209 21:01:21< vultraz> Normally I wouldn’t care about doing anything to the god-awful theme system but in this case I want that aesthetic so I have to implement a way to hide them
20171209 21:02:45< zookeeper> ...so you have no such explanation, you just decided you want some other kind of aesthetic?
20171209 21:03:05< vultraz> Shadowm did it, I like it, I’m sticking with it
20171209 21:04:03-!- irker161 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20171209 21:04:36< fabi> :-)
20171209 21:10:56-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171209 21:11:09-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171209 21:16:43-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:6453:1232:f2ec:7f40] has quit [Remote host closed the connection]
20171209 21:17:53-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:6453:1232:f2ec:7f40] has joined #wesnoth-dev
20171209 21:32:00-!- irker917 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171209 21:32:00< irker917> wesnoth/wesnoth:master doofus-01 b1fc51e182 revisions to scorpion attack animations AppVeyor: All builds passed
20171209 21:32:05< celticminstrel> I'm not actually sure what "code-complete" means, actually...
20171209 21:32:07-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:6453:1232:f2ec:7f40] has quit [Remote host closed the connection]
20171209 21:32:13< celticminstrel> ...oh I said actually twice. >_>
20171209 21:35:42< matthiaskrgr> actually yes 
20171209 21:36:45-!- mjs-de [~mjs-de@x4e3080ee.dyn.telefonica.de] has quit [Remote host closed the connection]
20171209 21:37:07-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:6453:1232:f2ec:7f40] has joined #wesnoth-dev
20171209 21:47:34-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20171209 21:51:50-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:6453:1232:f2ec:7f40] has quit [Remote host closed the connection]
20171209 21:56:44< celticminstrel> vultraz: Is #2217 an argument for merging the iOS work before 1.14?
20171209 22:04:57-!- sigurdfd [sigurdfd@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20171209 22:05:26-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20171209 22:05:38-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20171209 22:20:28< sigurdfd> zookeeper: Hi. Apologies for having to leave the other day.
20171209 22:21:09< sigurdfd> To rephrase the cave mine walls thing: With the change, some of the 11 maps in mainline may be stylistically broken.
20171209 22:21:41< sigurdfd> Before I went to make any changes, I wanted to double-check that hewn wall was gone. I agree hewn doesn't really offer anything much over regular cave.
20171209 22:22:04< sigurdfd> After further review, I think the following are the only ones that may need changed:
20171209 22:22:37< sigurdfd> NR 02_02 & 05a_02 (only 2 occurrences each, so minor it's better to remove them, and the minewall over chasm is odd) TSG S07a (a few more , but same ideas as the NR ones)
20171209 22:22:40< sigurdfd> HttT S06 (minor impact, could be removed) & SotA S07 (still considering it)
20171209 22:22:48< sigurdfd> and that would be it
20171209 22:26:30< sigurdfd> any issues with changing the mine to regular cave for TSG S07a & HttT 06?
20171209 22:34:50 * zookeeper looks
20171209 22:36:21< zookeeper> what do you think is the problem with HttT 06?
20171209 22:36:54< zookeeper> it's a cave with a few bits of reinforcement, looks okay enough to me (although i've been meaning to tweak it a bit myself, i guess i never finished it)
20171209 22:38:35< sigurdfd> that's a bitt of a toss-up, if it was straight Xu, it might call less attetion to itself? the touch in the upper right part of the cave doesn't reealy need to be there
20171209 22:40:21< zookeeper> well, sure, it could all just as well be Xu there
20171209 22:42:53< zookeeper> but i don't really see a problem, it's just some visual variety, kind of the same as in TSG S07a
20171209 22:43:31-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:6453:1232:f2ec:7f40] has joined #wesnoth-dev
20171209 22:44:38< zookeeper> a mostly natural cave with some extra room carved out (or whatever) that requires support, if you feel like they warrant an explanation. of course the exact patterns might not make much sense realistically (if such a word is even remotely usable in this context).
20171209 22:48:09< sigurdfd> it seems like the word usable in this context.
20171209 22:52:46< sigurdfd> it's all stylistic. HttT06 could go either way. I think TSG 07a would look better with staight Xu.
20171209 22:56:12-!- stikonas_ is now known as stikonas
20171209 23:16:35< sigurdfd> zookeeper: since it's such a toss-up I'm dropping HttT S06 from consideration. Would you be fine with me doing the TSG 07a change?
20171209 23:17:01< zookeeper> if you feel you must, then sure go ahead
20171209 23:27:11< sigurdfd> ok, thanks. That takes care of that.
20171209 23:53:52-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:6453:1232:f2ec:7f40] has quit [Remote host closed the connection]
20171209 23:55:19-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:6453:1232:f2ec:7f40] has joined #wesnoth-dev
--- Log closed Sun Dec 10 00:00:55 2017