--- Log opened Mon Dec 11 00:00:56 2017 20171211 01:08:44-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:5826:e375:90e9:482e] has joined #wesnoth-dev 20171211 01:15:07-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:5826:e375:90e9:482e] has quit [Ping timeout: 250 seconds] 20171211 01:22:32< irker303> wesnoth/wesnoth:master Charles Dang 7707fd1b2b jweiodjiowjeionwoi AppVeyor: 1/6 builds failed 20171211 01:22:33< irker303> Details vs2013/Debug: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-918 20171211 01:43:46-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:5826:e375:90e9:482e] has joined #wesnoth-dev 20171211 01:57:52-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:5826:e375:90e9:482e] has quit [Remote host closed the connection] 20171211 02:21:35-!- Greg-Boggs [~greg_bogg@73.11.32.127] has joined #wesnoth-dev 20171211 02:42:33-!- Greg-Boggs [~greg_bogg@73.11.32.127] has quit [Remote host closed the connection] 20171211 02:49:02-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:5826:e375:90e9:482e] has joined #wesnoth-dev 20171211 02:51:02-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:5826:e375:90e9:482e] has quit [Remote host closed the connection] 20171211 03:15:21< irker303> wesnoth/wesnoth:master Charles Dang 0c1b3d25ca GUI2: cleaned up and restructured initia AppVeyor: vs2013/Release Failed 20171211 03:15:22< irker303> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-919 20171211 03:15:48< vultraz> Y U FAIL 20171211 03:16:18< vultraz> looks like AV is having trouble.. 20171211 03:49:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20171211 03:50:01< irker303> wesnoth: Charles Dang wesnoth:master 6759f41b1efd / / (32 files in 11 dirs): GUI2: cleaned up and restructured initialization process https://github.com/wesnoth/wesnoth/commit/6759f41b1efd85651e365af73eb3b39c1183a5d1 20171211 04:09:38-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:5826:e375:90e9:482e] has joined #wesnoth-dev 20171211 04:15:35-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:5826:e375:90e9:482e] has quit [Ping timeout: 276 seconds] 20171211 04:25:30-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:5826:e375:90e9:482e] has joined #wesnoth-dev 20171211 04:46:34-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:5826:e375:90e9:482e] has quit [Remote host closed the connection] 20171211 05:04:16-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev 20171211 05:31:47-!- celmin|sleep [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.] 20171211 05:52:08-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20171211 06:42:14-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .] 20171211 06:50:17-!- irker303 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20171211 07:06:27-!- fabi_ [~fabi@2a02:810c:c840:2e65:7858:53fa:7438:b315] has joined #wesnoth-dev 20171211 07:10:38-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 260 seconds] 20171211 07:26:43-!- irker801 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20171211 07:26:43< irker801> wesnoth/wesnoth:master Charles Dang 6759f41b1e GUI2: cleaned up and restructured initia AppVeyor: All builds passed 20171211 07:33:31-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev 20171211 08:03:27-!- NicolasF[m] [nicolasfma@gateway/shell/matrix.org/x-ottszefrngwetzul] has left #wesnoth-dev ["User left"] 20171211 08:15:23< irker801> wesnoth/wesnoth:master Charles Dang 0c1b3d25ca GUI2: cleaned up and restructured initia AppVeyor: 1/2 builds failed 20171211 08:15:24< irker801> Details vs2013/Release: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-919 20171211 09:10:12-!- vladimirslavik [vslavik@nat/redhat/x-zugsqjmmpzomfnob] has joined #wesnoth-dev 20171211 09:52:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20171211 09:52:43-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20171211 10:34:54-!- Soap__ [~Soap__@gentoo/developer/soap] has quit [Quit: leaving] 20171211 10:40:10-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .] 20171211 10:48:41< vn971> Hi all. What is the logic behind showing scenario "name" in multiplayer lobby list? As I observe it, wesnoth currently tries to do the following: if it has a scenario with the same ID as remote scenario ID, it loads _your_ scenario name. If it cannot find a scenario with the same ID, it loads _remote_ scenario name. 20171211 10:48:41< vn971> The question is -- why? Why not always load remote scenario name? 20171211 10:51:02< vn971> Currently, I have surprising (unexpected) behavior because of this: I do not change scenario ID because I don't need to (and because changing ID makes wesnoth lose "focus" on last chosen scenario). But I do change name to include version. Now, when I enter multiplayer lobby, I see everybody else playing the version I have locally, even if it's not true (they are actually playing different versions, but wesnoth has loaded the name fr 20171211 10:51:03< vn971> om my local install because it noticed the same ID). 20171211 10:51:41< vn971> so, why not just always load remote scenario name? 20171211 10:52:22< vn971> If the reason for the current behavior is not obvious/known, I'd raise a bug (a bit later). 20171211 10:55:17< vultraz> Hmmmmm...... 20171211 10:55:29< vultraz> You do have a point 20171211 10:55:43< vultraz> I’ll have to take a look at the code again and consider 20171211 10:55:55< vultraz> It used to be that only local names were considered 20171211 10:56:42< vultraz> If you didn’t have an addon installed it would show something like Unknown Scenario: scenario_id 20171211 10:57:15< vultraz> But I improved things so you can fetch the name remotely when you don’t have it installed 20171211 10:57:38< vultraz> I didn’t consider that maybe it be best to always use the remote version 🤔 20171211 10:58:09< Soliton> so now anyone can pretend to host a scenario i know with their own config? i wouldn't call that an improvement. 20171211 11:01:20< vn971> Soliton: as I understand it, that's the current state of things. I thought that's even intentional. So you'd like to have a visual distinguishment for known scenarios/eras/mods and unknown ones, and refuse remote data if your client knows those scenarios/eras/mods itself? 20171211 11:02:17< Soliton> no need to refuse but the user should be aware that it's an unknown or modified scenario. 20171211 11:02:28< Soliton> that's how it used to be. 20171211 11:03:11< vn971> Soliton: well if there is no refusal, then there's no point. I can host a different Era with the same ID, can't I? If you'll fetch my source then all the ID's won't matter. They're not secure hashes or anything like that. 20171211 11:06:16< vn971> Hw, on another topic: seems like I encountered an MP bug. 1. I started hosting a game (created a room). 2. I've connected to the room with another client. 3. I've killed the other client. 4. The first client still shows as if there are two players inside the room (for 5+ minutes already). 20171211 11:06:27< Soliton> what does "If you'll fetch my source" mean? 20171211 11:06:43< vn971> I'll search recently open bugs and open a new one on github for the last thing I wrote. 20171211 11:07:11< irker801> wesnoth/wesnoth:master doofus-01 9cc6665020 north-facing defend animation AppVeyor: All builds passed 20171211 11:08:59< vn971> Soliton: I just don't know the internals of how it works. I thought that wesnoth produces one huge WML file that gets sent to other clients no matter what. Also, the code inside this huge WML can access your local data (addons) if it wants to. If that is the case, then having or not having an addon locally won't matter if you accept the huge WML thing from remote host. 20171211 11:10:30< Soliton> are we now talking about already having started some scenario? i thought we're talking about the lobby. 20171211 11:12:43< vn971> Soliton: I meant to explain why the current situation, the old one and the proposed one do not differ security-wise (as I think). 20171211 11:15:07< Soliton> if the game tells you that some scenario some guy hosts is the same as what you have installed then you know what you get. 20171211 11:16:02< Soliton> if there however is no way to distinguish those scenarios you have installed from some other scenario that maybe has the same name then you have no idea what you're getting when joining that game. 20171211 11:17:02< Soliton> there is no executing WML from remote hosts in the lobby or whatever you're talking about. 20171211 11:17:15< Soliton> well, last time i checked anyway. 20171211 11:21:33< vultraz> Soliton: the lobby still marks a scenario as unknown/uninstalled 20171211 11:21:55< vultraz> it just doesn't throw that ugly-ass "Unknown Scenario: incomprehensible_scenario_id" message at you in place of a name 20171211 11:22:21< vultraz> scenarios are now marked with an "(S)" in the lobby 20171211 11:22:21< Soliton> ok, cool. 20171211 11:22:26< vultraz> which is red if you don't have it 20171211 11:23:21< Soliton> would be good if that is explained somewhere in help if there is no tooltip or anything that explains that. 20171211 11:24:10< vultraz> the tooltip mentions content needs to be downloaded 20171211 11:29:33< Soliton> what happens to scenarios that have a known ID but are modified compared to my local version? 20171211 11:36:39< vultraz> OOS probably 20171211 11:37:10< Soliton> no. 20171211 11:37:23< Soliton> i meant how it's displayed in the lobby though. 20171211 11:37:51< vultraz> no different 20171211 11:40:27< Soliton> https://github.com/wesnoth/wesnoth/blob/master/src/game_initialization/lobby_data.cpp#L365 is info_stream not displayed in the GUI? 20171211 11:40:38< vultraz> no 20171211 11:40:45< Soliton> sad. 20171211 11:40:50< vultraz> .......... 20171211 11:40:57< vultraz> *resist urge to make biting remark* 20171211 11:41:01< vultraz> that's the filtering text 20171211 11:41:32< zookeeper> what does the S in "(S)" stand for? 20171211 11:41:39< vultraz> Scenario 20171211 11:41:42< zookeeper> okay 20171211 11:41:45< vultraz> C is for Campaign 20171211 11:44:18< vultraz> zookeeper: https://forums.wesnoth.org/download/file.php?id=77654&mode=view 20171211 11:45:41-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has joined #wesnoth-dev 20171211 12:19:19< Soliton> vultraz: feel to remark what you want to say. if it's about the GUI design i care fairly little though. you can do what you want provided the info is visible some way. 20171211 12:19:50< Soliton> feel free* 20171211 12:20:11< vultraz> Though recent criticism has been that I made certain bits not visible enough 20171211 12:39:29-!- vn971 [~vasya@94.158.103.15] has quit [Ping timeout: 268 seconds] 20171211 12:42:58-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev 20171211 13:48:47-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20171211 13:48:58-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20171211 14:07:25-!- irker801 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20171211 14:19:27-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has quit [Ping timeout: 240 seconds] 20171211 14:47:30-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity] 20171211 15:21:58-!- JyrkiVesterinen [~JyrkiVest@195-192-251-124.s1networks.fi] has quit [Quit: .] 20171211 15:38:26-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev 20171211 16:46:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20171211 16:51:13-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds] 20171211 16:52:05-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20171211 17:05:57-!- esr [~esr@wesnoth/developer/esr] has quit [Ping timeout: 240 seconds] 20171211 17:08:50-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev 20171211 17:08:50-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has quit [Changing host] 20171211 17:08:50-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev 20171211 17:19:54-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev 20171211 17:19:54-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Killed (livingstone.freenode.net (Nickname regained by services))] 20171211 17:19:54-!- Necrosporus_ is now known as Necrosporus 20171211 17:33:38-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev 20171211 17:37:31-!- irker440 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20171211 17:37:31< irker440> wesnoth: Gregory A Lundberg wesnoth:master 1253da81e6f1 / src/tests/gui/test_gui2.cpp: Fix warning: missing prototype https://github.com/wesnoth/wesnoth/commit/1253da81e6f1b3735ea9edafc84310a427531c26 20171211 17:38:19-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20171211 18:00:29-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection] 20171211 18:22:16-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev 20171211 18:31:54-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20171211 18:45:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20171211 19:10:15-!- mjs-de [~mjs-de@vpw.wh.stwdo.de] has joined #wesnoth-dev 20171211 19:27:29-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20171211 19:27:39-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20171211 20:32:03-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity] 20171211 20:37:39-!- irker440 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20171211 21:02:41-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20171211 21:03:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 250 seconds] 20171211 21:13:18-!- irker390 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20171211 21:13:18< irker390> wesnoth/wesnoth:master Gregory A Lundberg 1253da81e6 Fix warning: missing prototype AppVeyor: All builds passed 20171211 21:19:46-!- mjs-de [~mjs-de@vpw.wh.stwdo.de] has quit [Ping timeout: 240 seconds] 20171211 21:22:41-!- mjs-de [~mjs-de@vpw.wh.stwdo.de] has joined #wesnoth-dev 20171211 21:24:58-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .] 20171211 21:25:42-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev 20171211 21:40:04-!- mjs-de [~mjs-de@vpw.wh.stwdo.de] has quit [Remote host closed the connection] 20171211 21:50:34-!- Grickit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev 20171211 21:55:07-!- yaiyan_ [~yaiyan@46.101.48.31] has joined #wesnoth-dev 20171211 21:56:31-!- Netsplit *.net <-> *.split quits: Elvish_Hunter, yaiyan, aidanhs, Gambit 20171211 21:59:23-!- Netsplit over, joins: aidanhs 20171211 21:59:53-!- Netsplit over, joins: Elvish_Hunter 20171211 22:32:08-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 255 seconds] 20171211 22:43:31-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection] 20171211 22:48:47-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20171211 22:50:26-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20171211 23:16:04-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20171211 23:16:17-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20171211 23:24:51-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20171211 23:33:44-!- Appleman1234 [~quassel@124x38x163x22.ap124.ftth.ucom.ne.jp] has joined #wesnoth-dev 20171211 23:55:41-!- midzer [~quassel@2001:41d0:a:2255::1] has quit [Ping timeout: 258 seconds] 20171211 23:55:55-!- midzer [~quassel@2001:41d0:a:2255::1] has joined #wesnoth-dev 20171211 23:56:51-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has quit [Ping timeout: 258 seconds] 20171211 23:57:01-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has joined #wesnoth-dev 20171211 23:57:14-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-brurkxrzbntvsext] has quit [Ping timeout: 258 seconds] 20171211 23:57:37-!- EliDupree [~quassel@2604:a880:400:d0::9bb:2001] has quit [Ping timeout: 258 seconds] 20171211 23:57:51-!- EliDupree [~quassel@2604:a880:400:d0::9bb:2001] has joined #wesnoth-dev 20171211 23:59:41-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Ping timeout: 260 seconds] 20171211 23:59:48-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev --- Log closed Tue Dec 12 00:00:58 2017