--- Log opened Sun Dec 17 00:00:04 2017
20171217 00:02:03-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20171217 00:33:43-!- gfgtdf [~chatzilla@x4e368761.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.5.2/20171206101620]]
20171217 00:46:59-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171217 00:47:14-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171217 01:11:28-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Ping timeout: 248 seconds]
20171217 01:12:10-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20171217 01:27:36-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20171217 01:56:15< celticminstrel> Hmm. I need a way in the preprocessor to distinguish between wesnoth and wesnothd (or campaignd), any suggestions?
20171217 02:00:13< celticminstrel> Just FTR, I mean the C preprocessor, not the WML preprocessor.
20171217 02:23:56< celticminstrel> Also, in the WML preprocessor code, how do I get the name of the current file being parsed? This is in the place where it's handling preprocessor commands, I think in preprocessor_data::get_chunk.
20171217 02:24:23 * celticminstrel pokes vultraz in case he knows, since ISTR him poking around with the preprocessor at some point... or was taht gfgtdf...
20171217 02:24:25< celticminstrel> ^that
20171217 02:45:08< celticminstrel> Well, I made a guess, hope it works.
20171217 03:03:00< celticminstrel> My guess appears to be correct. It works.
20171217 03:03:05< celticminstrel> Just need to test the other use case.
20171217 03:14:50< vultraz> celticminstrel: not preprocessor_file
20171217 03:14:50< vultraz> ?
20171217 03:15:17< celticminstrel> I used get_filename(parent_.loc) or something like that.
20171217 03:15:56< vultraz> I see
20171217 03:15:56< vultraz> ok
20171217 03:16:00< vultraz> whatever works
20171217 03:16:06< vultraz> as for the other thing, there is no such way
20171217 03:16:09< vultraz> that i know of
20171217 03:18:28-!- irker961 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171217 03:18:29< irker961> wesnoth: Charles Dang wesnoth:master a8663601ef60 / src/server/ (ban.hpp game.cpp player_connection.hpp server.hpp): Wesnothd: move some function declarations to more logical places https://github.com/wesnoth/wesnoth/commit/a8663601ef6032033fcb4c4a0d103ee666af574a
20171217 03:25:05< irker961> wesnoth: Celtic Minstrel wesnoth:deprecation 5ad12ee72433 / / (8 files in 4 dirs): Move deprecation to wesnoth-lib since the preprocessor will depend on it https://github.com/wesnoth/wesnoth/commit/5ad12ee724335c1afefc8ad38deceb734706d31e
20171217 03:25:07< irker961> wesnoth: Celtic Minstrel wesnoth:deprecation 2557dddac7bf / / (3 files in 2 dirs): Add #deprecated preprocessor directive for marking macros deprecated https://github.com/wesnoth/wesnoth/commit/2557dddac7bf617707024f7bb8c6f4d894aa2dfc
20171217 03:37:33< celticminstrel> So yeah, https://github.com/wesnoth/wesnoth/pull/2297
20171217 03:41:04< celticminstrel> That thing I kept intending to do but never seemed to find the time for.
20171217 03:41:12< celticminstrel> Admittedly it's only 99% done, but still.
20171217 03:41:28< celticminstrel> BTW, there's a comment saying there's a feature request for nested macro definitions, but what would that even mean?
20171217 04:05:31< vultraz> No idea
20171217 04:05:33< vultraz> Disregard
20171217 04:05:44< vultraz> We want to move away from the preprocessor in the future anyway
20171217 04:09:14< celticminstrel> Even if we want to move away from it, I think it would be extremely difficult to do away with it altogether.
20171217 04:09:43< celticminstrel> For the nested macros, the only thing I can think of is that it would be a local definition only valid within the containing macro definition.
20171217 04:09:54< vultraz> It’s the only way to do live editing
20171217 04:10:01< celticminstrel> ???
20171217 04:10:26< celticminstrel> I have no idea how that has anything to do with this.
20171217 04:10:30< vultraz> We can’t have live editing with our current preprocessed design
20171217 04:10:34< celticminstrel> Why not?
20171217 04:12:22< vultraz> How could it work?
20171217 04:13:02< celticminstrel> Presumably you'd be editing the preprocessed WML or something. Or even the data structures that were generated from the WML.
20171217 04:13:55< vultraz> By live editing I being able to edit the wml file and have the changes immediately reflect in-game
20171217 04:14:05< vultraz> No quit to titlescreen and f5
20171217 04:14:10< vultraz> No restarting wesnoth
20171217 04:14:14< vultraz> No back to turn 1
20171217 04:14:36< celticminstrel> Ah.
20171217 04:14:50< celticminstrel> I'm pretty sure the preprocessor is far from the only barrier to that.
20171217 04:15:13< vultraz>  But it’s a major one
20171217 04:15:39< celticminstrel> Eh, I'm not sure TBH. It's likely not the biggest obstacle.
20171217 04:16:05< vultraz> Also I’m pretty sure doing away with the preprocessor would speed up loadin*times
20171217 04:16:12< celticminstrel> And I'm not even sure it's an obstacle at all.
20171217 04:16:52< celticminstrel> Your idea of live editing is pretty ambitious though.
20171217 04:17:41< celticminstrel> As far as I can tell, the best way to sum it up is "the game watches the WML files for changes; if detected, it saves the game, reloads the WML, and then reloads the game".
20171217 04:18:21< celticminstrel> And even that probably wouldn't work very reliably.
20171217 04:18:32< celticminstrel> (Depending on what sort of changes you made to the WML.)
20171217 04:19:16< vultraz> No, no, no. No reload. I mean as soon as a file is saved, if the changes are valid, you should be able to immediately see them in game. If you add an [item] tag, the item will immediately appear
20171217 04:19:40< vultraz> It’s possible. Anura can do it. Why can’t we.
20171217 04:19:42< celticminstrel> And how do you propose to do that without a reload?
20171217 04:20:40< vultraz> Well, no user-visible reload
20171217 04:20:46< celticminstrel> I never said user-visible.
20171217 04:20:52< vultraz> I see
20171217 04:21:10< celticminstrel> The word "it" in my statement refers to the Wesnoth engine, implying that it would do the reload itself automatically.
20171217 04:21:50< vultraz> Yes
20171217 04:22:46< celticminstrel> So basically, if you can get it to work reliably for a regular (user-visible reload), it shouldn't be too difficult to move to doing it automatically.
20171217 04:23:24< celticminstrel> And I'm not convinced the preprocessor is a significant barrier to this.
20171217 04:23:28< vultraz> The way the game caches data would need to totally be changed, though
20171217 04:23:35< celticminstrel> Why?
20171217 04:23:55< celticminstrel> (Asking because I don't know, not because I disagree.)
20171217 04:25:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20171217 04:28:00-!- travis-ci [~travis-ci@ec2-54-205-153-94.compute-1.amazonaws.com] has joined #wesnoth-dev
20171217 04:28:01< travis-ci> wesnoth/wesnoth#16012 (master - a866360 : Charles Dang): The build was fixed.
20171217 04:28:01< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/317558122
20171217 04:28:01-!- travis-ci [~travis-ci@ec2-54-205-153-94.compute-1.amazonaws.com] has left #wesnoth-dev []
20171217 04:28:22< irker961> wesnoth: jostephd wesnoth:master f76420ba2a56 / src/gui/widgets/unit_preview_pane.cpp: Translate damage types in the unit_preview_pane tooltip. (#2296) https://github.com/wesnoth/wesnoth/commit/f76420ba2a568448f45b451f07a7a1807affcb5f
20171217 04:34:56 * celticminstrel pokes vultraz?
20171217 04:35:38< vultraz> Im not entirely sure
20171217 04:35:42< vultraz> We’d have to analyze
20171217 05:02:53-!- travis-ci [~travis-ci@ec2-54-205-153-94.compute-1.amazonaws.com] has joined #wesnoth-dev
20171217 05:02:54< travis-ci> wesnoth/wesnoth#16013 (deprecation - 2557ddd : Celtic Minstrel): The build was broken.
20171217 05:02:54< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/317559168
20171217 05:02:54-!- travis-ci [~travis-ci@ec2-54-205-153-94.compute-1.amazonaws.com] has left #wesnoth-dev []
20171217 05:02:56-!- celticminstrel is now known as celmin|sleep
20171217 05:03:10< celmin|sleep> ...fun!
20171217 05:03:28< celmin|sleep> Maybe because of the $(...) thing, I wouldn't be surprised if some tests depend on it.
20171217 05:07:20< irker961> wesnoth/wesnoth:deprecation Celtic Minstrel 2557dddac7 Add #deprecated preprocessor directive f AppVeyor: vs2017/Release Failed
20171217 05:07:21< irker961> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-deprecation-649
20171217 05:18:22-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171217 05:18:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171217 05:28:12< vultraz> celmin|sleep: undefined reference
20171217 05:28:15< vultraz> in link
20171217 05:28:46< vultraz> undefined reference to `deprecated_message
20171217 06:15:21< irker961> wesnoth/wesnoth:deprecation Celtic Minstrel 2557dddac7 Add #deprecated preprocessor directive f AppVeyor: 3/6 builds failed
20171217 06:15:22< irker961> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-deprecation-649
20171217 06:15:23< irker961> Details vs2013/Release: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-deprecation-955
20171217 06:15:24< irker961> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-deprecation-948
20171217 06:21:25-!- mrvar203 [~pplhfidg@ool-4351d03b.dyn.optonline.net] has joined #wesnoth-dev
20171217 06:21:26-!- mrvar203 [~pplhfidg@ool-4351d03b.dyn.optonline.net] has quit [Remote host closed the connection]
20171217 06:21:34-!- verya378 [~dqwwuhq@c-73-129-197-134.hsd1.md.comcast.net] has joined #wesnoth-dev
20171217 06:21:35-!- verya378 [~dqwwuhq@c-73-129-197-134.hsd1.md.comcast.net] has quit [Remote host closed the connection]
20171217 06:52:57< irker961> wesnoth/wesnoth:master Celtic Minstrel d139af21c9 Add #deprecated preprocessor directive f AppVeyor: vs2015/Release Failed
20171217 06:52:58< irker961> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-949
20171217 08:02:16-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20171217 08:05:08< irker961> wesnoth/wesnoth:master Celtic Minstrel d139af21c9 Add #deprecated preprocessor directive f AppVeyor: 3/6 builds failed
20171217 08:05:09< irker961> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-949
20171217 08:05:10< irker961> Details vs2013/Release: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-956
20171217 08:05:11< irker961> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-650
20171217 08:16:35-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20171217 08:43:02< irker961> wesnoth/wesnoth:master josteph 60a8b449d5 Translate damage types in the unit_previ AppVeyor: All builds passed
20171217 08:58:51-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171217 08:59:00-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171217 09:06:23-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20171217 09:13:14-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20171217 09:20:04-!- kei476 [~wbspree@c-73-167-20-4.hsd1.ma.comcast.net] has joined #wesnoth-dev
20171217 09:20:06-!- kei476 [~wbspree@c-73-167-20-4.hsd1.ma.comcast.net] has quit [Remote host closed the connection]
20171217 09:21:49-!- ishr6 [~wdwyqi@ip70-185-46-48.ph.ph.cox.net] has joined #wesnoth-dev
20171217 09:21:50-!- ishr6 [~wdwyqi@ip70-185-46-48.ph.ph.cox.net] has quit [Remote host closed the connection]
20171217 09:25:44-!- gattabefa907 [~zniux@c-73-12-139-116.hsd1.ca.comcast.net] has joined #wesnoth-dev
20171217 09:25:49-!- gattabefa907 [~zniux@c-73-12-139-116.hsd1.ca.comcast.net] has quit [Remote host closed the connection]
20171217 09:37:10-!- mjs-de [~mjs-de@x5ce3bb71.dyn.telefonica.de] has joined #wesnoth-dev
20171217 09:46:26-!- gelos652 [erdzfa@2600:3c01::f03c:91ff:fecc:400] has joined #wesnoth-dev
20171217 09:46:28-!- gelos652 [erdzfa@2600:3c01::f03c:91ff:fecc:400] has quit [Remote host closed the connection]
20171217 09:46:34-!- hugos55 [~jrfcpgs@70.15.140.166.res-cmts.dun.ptd.net] has joined #wesnoth-dev
20171217 09:46:36-!- hugos55 [~jrfcpgs@70.15.140.166.res-cmts.dun.ptd.net] has quit [Remote host closed the connection]
20171217 09:49:14-!- ther161 [~nyfkmqwc@dsl-197-245-89-156.voxdsl.co.za] has joined #wesnoth-dev
20171217 09:49:32-!- ther161 [~nyfkmqwc@dsl-197-245-89-156.voxdsl.co.za] has quit [Remote host closed the connection]
20171217 09:51:35-!- centrifug376 [~xamrphf@107.196.57.118] has joined #wesnoth-dev
20171217 09:51:36-!- centrifug376 [~xamrphf@107.196.57.118] has quit [Remote host closed the connection]
20171217 09:53:09-!- sweetlo980 [iplvj@2600:3c01::f03c:91ff:fecc:400] has joined #wesnoth-dev
20171217 09:53:23-!- sweetlo980 [iplvj@2600:3c01::f03c:91ff:fecc:400] has quit [Remote host closed the connection]
20171217 09:56:04-!- BER64 [~avinri@c-73-150-115-176.hsd1.nj.comcast.net] has joined #wesnoth-dev
20171217 09:56:05-!- BER64 [~avinri@c-73-150-115-176.hsd1.nj.comcast.net] has quit [Remote host closed the connection]
20171217 10:07:33-!- supernatu459 [~fndxb@68.225.111.101] has joined #wesnoth-dev
20171217 10:07:36-!- supernatu459 [~fndxb@68.225.111.101] has quit [Remote host closed the connection]
20171217 10:13:28-!- fiorell262 [~yzmhlgg@c-73-224-115-181.hsd1.fl.comcast.net] has joined #wesnoth-dev
20171217 10:13:42-!- fiorell262 [~yzmhlgg@c-73-224-115-181.hsd1.fl.comcast.net] has quit [Remote host closed the connection]
20171217 11:13:00-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20171217 11:27:11< irker961> wesnoth/wesnoth:master jostephd f76420ba2a Translate damage types in the unit_previ AppVeyor: All builds passed
20171217 11:28:19-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20171217 11:28:35-!- vultraz [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20171217 11:29:34-!- fabi_ [~fabi@2a02:810c:c840:2e65:61b6:40d:beab:9172] has joined #wesnoth-dev
20171217 11:33:48-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Ping timeout: 272 seconds]
20171217 11:56:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171217 11:56:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20171217 11:56:57-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171217 11:59:08-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20171217 11:59:50-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171217 12:26:54-!- stikonas_ is now known as stikonas
20171217 13:00:57-!- Bonobo [~Bonobo@110-175-146-248.tpgi.com.au] has quit [Ping timeout: 264 seconds]
20171217 13:15:52-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20171217 13:28:49-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20171217 13:34:43< zookeeper> celmin|sleep, nested macro definitions sounds to me like... well, macro definitions that exist only in the enclosing macro's local scope.
20171217 13:34:53< zookeeper> what else could it be?
20171217 14:16:31-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20171217 15:02:37-!- irker961 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20171217 15:27:55< celmin|sleep> That's what I thought too.
20171217 15:30:20< celmin|sleep> No comments yet on my PR, huh.
20171217 15:33:59-!- celmin|sleep is now known as celticminstrel
20171217 16:02:54-!- markus_ [~mjs-de@x4db5f3f2.dyn.telefonica.de] has joined #wesnoth-dev
20171217 16:06:08-!- mjs-de [~mjs-de@x5ce3bb71.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20171217 17:54:13< Soliton> celticminstrel: seems fine on a quick look. if you need a preprocessor symbol to distinguish building wesnothd/campaignd or whatever that should be doable.
20171217 18:01:31-!- Bonobo [~Bonobo@110-175-146-248.tpgi.com.au] has joined #wesnoth-dev
20171217 19:07:45-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 248 seconds]
20171217 19:43:16-!- atarocch [~atarocch@93.56.164.28] has quit [Ping timeout: 255 seconds]
20171217 20:02:47-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171217 20:03:23-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20171217 20:03:28-!- stikonas_ is now known as stikonas
20171217 20:23:01-!- fabi [~fabi@2a02:810c:c840:2e65:b0e9:679d:1263:5c26] has joined #wesnoth-dev
20171217 20:23:01-!- fabi [~fabi@2a02:810c:c840:2e65:b0e9:679d:1263:5c26] has quit [Changing host]
20171217 20:23:01-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20171217 20:24:13-!- fabi_ [~fabi@2a02:810c:c840:2e65:61b6:40d:beab:9172] has quit [Ping timeout: 255 seconds]
20171217 21:19:13< celticminstrel> Soliton: Well, some way to solve the issue of the WFL engine not being linked into the server, yeah. Not entirely sure if a preprocessor symbol will be sufficient though, since the preprocessor and other stuff is first combined into a .a which is then linked to both wesnoth and wesnothd.
20171217 21:22:59-!- Oebele [~quassel@143.177.58.202] has joined #wesnoth-dev
20171217 21:25:11-!- irker247 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171217 21:25:11< irker247> wesnoth: Gregory A Lundberg wesnoth:master 035324231500 / data/campaigns/Descent_Into_Darkness/scenarios/07_A_Small_Favor.cfg: DiD S07: Fix Taylor talks to himself https://github.com/wesnoth/wesnoth/commit/035324231500557b1c24ecd6ea7c066dc0c0d3a5
20171217 21:50:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20171217 21:50:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171217 21:50:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20171217 21:50:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171217 22:19:55-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171217 22:20:04-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171217 22:23:43-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20171217 22:24:46-!- Tad_Carlucci [~lundberg@74.193.219.119] has joined #wesnoth-dev
20171217 22:26:40-!- TadCarlucci [~lundberg@74.193.219.119] has quit [Ping timeout: 268 seconds]
20171217 22:32:24-!- hello [4b52ccf3@gateway/web/freenode/ip.75.82.204.243] has joined #wesnoth-dev
20171217 22:32:44-!- hello [4b52ccf3@gateway/web/freenode/ip.75.82.204.243] has quit [Client Quit]
20171217 22:54:22-!- Oebele [~quassel@143.177.58.202] has quit [Remote host closed the connection]
20171217 23:30:19-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
--- Log closed Mon Dec 18 00:00:05 2017