--- Log opened Mon Dec 25 00:00:14 2017
20171225 00:36:35-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20171225 01:38:20-!- vultraz [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20171225 01:56:34< Ravana_> now that I implemented :lua as menu action, time to see if 1.13.10 supports it without
20171225 02:00:13< Ravana_> seems it is indeed needed there too
20171225 02:12:56< Ravana_> not sure why 1.13.10 should fail with :lua H = H or {}
20171225 02:15:31-!- celmin|xmas is now known as celticminstrel
20171225 02:16:03< celticminstrel> ???
20171225 02:16:51< celticminstrel> Oh, maybe you're running into ilua strict mode?
20171225 02:18:25< Ravana_> no idea what that is
20171225 02:26:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20171225 02:31:41< Ravana_> I see for that specific use solution 2 is good, but for rest of code I should care for solution 4
20171225 02:34:49< celticminstrel> Basically, accessing a global variable that hasn't previously been assigned to is an error.
20171225 02:35:58< Ravana_> wanted to use that line to load "lua/helper.lua" if it did not exist already
20171225 02:38:02< celticminstrel> Well, the canonical way to do that is wesnoth.require.
20171225 02:38:18< celticminstrel> Which loads it if it hasn't been loaded already, otherwise uses the cached version.
20171225 02:39:27< Ravana_> I see
20171225 02:39:41< Ravana_> any similar solution to check if set_wml_tag_metatable is done?
20171225 02:43:12< celticminstrel> In 1.13 you don't actually need set_wml_tag_metatable anymore.
20171225 02:43:26< celticminstrel> It's already done for you and stored at... wml.tag IIRC.
20171225 02:43:40< celticminstrel> (Probably not documented yet though...)
20171225 02:44:53< celticminstrel> Yeah, wml.tag it is, so if you like the common short form you can just write "T = wml.tag".
20171225 02:45:31< Ravana_> ok
20171225 02:49:45< Ravana_> that seems to force different code on 1.12 and 1.13 though, since T fails on 1.13 and wml.tag fails on 1.12, so neither can be allowed to be called
20171225 02:58:28< celticminstrel> Well, you could always use wesnoth.compare_versions to run different code depending on the version, I guess...
20171225 02:59:07< celticminstrel> But, set_wml_tag_metatable does work on 1.13.
20171225 02:59:28< Ravana_> yes, staying with that while 1.12 exists
20171225 02:59:33< celticminstrel> You just can't easily check if some other script has already set it, but I wouldn't expect that to matter.
20171225 03:37:04< Ravana_> is there already interface for checking Lua globals, like [inspect] for WML variables?
20171225 03:42:00< Ravana_> been designing mpsafe debug commands https://pastebin.com/rrxkvvW9
20171225 03:44:01< celticminstrel> Lua globals are essentially keys in the _G table, so you could iterate over that if you want a list of globals.
20171225 03:44:14< celticminstrel> Of course, that'll include packages such as "wesnoth" and "string".
20171225 03:50:17< Ravana_> yes, that is what I will be doing if there isn't one already
20171225 03:51:11< celticminstrel> Yeah, I don't know of anything currently that does that.
20171225 04:09:15< Ravana_> I guess I could generate list of keys that appear in empty scenario, and hardcode those to be excluded
20171225 04:12:33-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20171225 04:24:29-!- celticminstrel is now known as celmin|sleep
20171225 04:36:45-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:d9ae:f8d4:a49:c178] has joined #wesnoth-dev
20171225 04:45:41-!- Greg-Boggs [~greg_bogg@2601:1c2:1a80:1c20:d9ae:f8d4:a49:c178] has quit [Remote host closed the connection]
20171225 05:47:57-!- irker002 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171225 05:47:57< irker002> wesnoth/wesnoth:master doofus-01 e9b0f5b747 base sprites for Quenoth scouts AppVeyor: vs2013/Debug Failed
20171225 05:47:57< irker002> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-978
20171225 06:18:46< irker002> wesnoth/wesnoth:master doofus-01 e9b0f5b747 base sprites for Quenoth scouts AppVeyor: 1/6 builds failed
20171225 06:18:47< irker002> Details vs2013/Debug: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-978
20171225 06:26:44-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev
20171225 06:50:52-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171225 06:51:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171225 07:00:40-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171225 07:00:50-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171225 07:21:45-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20171225 08:24:38-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20171225 09:13:37-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:2963:ab36:5e20:6e57] has joined #wesnoth-dev
20171225 09:19:00-!- irker002 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20171225 10:07:26-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20171225 10:12:44-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20171225 10:28:43-!- Oebele [~quassel@92-110-163-84.cable.dynamic.v4.ziggo.nl] has joined #wesnoth-dev
20171225 11:17:41-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20171225 11:58:01 * vn971 managed to get WML dialogs to work (from Lua). It seems very hard to do just from the general documentation, but this help example https://wiki.wesnoth.org/LuaWML:Display#wesnoth.show_dialog   is a real savior. Overall, it started working (for me), which is really great.
20171225 11:59:59-!- Oebele [~quassel@92-110-163-84.cable.dynamic.v4.ziggo.nl] has quit [Ping timeout: 248 seconds]
20171225 12:24:36-!- Bhoren [~Bhoren_wh@2a01:e0a:c:2150:2963:ab36:5e20:6e57] has quit [Quit: Leaving]
20171225 12:45:33-!- stikonas [~stikonas@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171225 12:45:48-!- stikonas [~stikonas@wesnoth/translator/stikonas] has quit [Client Quit]
20171225 13:09:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171225 13:21:48-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171225 13:21:55-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171225 13:25:57-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20171225 13:35:08-!- Oebele [~quassel@92-110-163-84.cable.dynamic.v4.ziggo.nl] has joined #wesnoth-dev
20171225 13:45:46-!- mjs-de [~mjs-de@185.22.140.20] has joined #wesnoth-dev
20171225 13:59:19-!- Oebele [~quassel@92-110-163-84.cable.dynamic.v4.ziggo.nl] has quit [Remote host closed the connection]
20171225 14:00:09-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20171225 14:01:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 272 seconds]
20171225 14:02:08-!- Oebele [~quassel@92-110-163-84.cable.dynamic.v4.ziggo.nl] has joined #wesnoth-dev
20171225 14:06:04-!- celmin|sleep is now known as celticminstrel
20171225 14:06:51-!- mjs-de [~mjs-de@185.22.140.20] has quit [Remote host closed the connection]
20171225 14:18:50-!- shangul [~shangul@unaffiliated/shangul] has joined #wesnoth-dev
20171225 14:19:27< shangul> vn971, Hi
20171225 14:19:39< vn971> shangul: hi)
20171225 14:31:11< shangul> vn971, what's happening to the game?
20171225 14:31:15< shangul> vn971, start a new one?
20171225 14:36:34< vn971> damn, sorry, I've got seriously distracted offline.
20171225 14:38:43< shangul> vn971, you could start again
20171225 15:06:58-!- vn971 [~vasya@94.158.103.15] has quit [Quit: Leaving.]
20171225 16:00:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171225 16:00:36-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171225 16:35:46-!- irker470 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171225 16:35:46< irker470> wesnoth: Jyrki Vesterinen wesnoth:master 70b468070b71 / data/lua/wml/kill.lua: Work around unit halo not disappearing with [kill] animate=yes https://github.com/wesnoth/wesnoth/commit/70b468070b71616aa3663088b6ad171391d0c4f0
20171225 16:37:51-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: .]
20171225 16:47:02-!- Greg-Boggs [~greg_bogg@c-73-11-32-127.hsd1.or.comcast.net] has joined #wesnoth-dev
20171225 16:51:31-!- Greg-Boggs [~greg_bogg@c-73-11-32-127.hsd1.or.comcast.net] has quit [Ping timeout: 260 seconds]
20171225 16:54:14-!- octalot [~steve@178.165.131.1.wireless.dyn.drei.com] has joined #wesnoth-dev
20171225 17:31:08-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171225 17:31:20-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171225 17:31:50-!- stikonas_ is now known as stikonas
20171225 17:32:15-!- Oebele [~quassel@92-110-163-84.cable.dynamic.v4.ziggo.nl] has quit [Ping timeout: 248 seconds]
20171225 17:37:25-!- Oebele [~quassel@92-110-163-84.cable.dynamic.v4.ziggo.nl] has joined #wesnoth-dev
20171225 17:43:34-!- octalot [~steve@178.165.131.1.wireless.dyn.drei.com] has quit [Ping timeout: 268 seconds]
20171225 17:47:51-!- travis-ci [~travis-ci@ec2-54-147-195-59.compute-1.amazonaws.com] has joined #wesnoth-dev
20171225 17:47:52< travis-ci> wesnoth/wesnoth#16037 (master - 70b4680 : Jyrki Vesterinen): The build has errored.
20171225 17:47:52< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/321430451
20171225 17:47:52-!- travis-ci [~travis-ci@ec2-54-147-195-59.compute-1.amazonaws.com] has left #wesnoth-dev []
20171225 17:48:08< celticminstrel> jyrki: Yeah, a different fix would definitely be better, maybe automatically releasing it once the animation has finished or something? I dunno.
20171225 17:48:38-!- octalot [~steve@178.165.131.1.wireless.dyn.drei.com] has joined #wesnoth-dev
20171225 17:53:09-!- Oebele [~quassel@92-110-163-84.cable.dynamic.v4.ziggo.nl] has quit [Ping timeout: 264 seconds]
20171225 18:21:41-!- vn971 [~vasya@94.158.103.15] has joined #wesnoth-dev
20171225 18:34:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171225 18:34:36-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171225 19:34:08< vn971> Is there a way to remove a trait from a unit? I use `transform_unit` on Leader, and I want to erase the "quick" trait.
20171225 19:36:27-!- irker470 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20171225 19:40:11-!- octalot [~steve@178.165.131.1.wireless.dyn.drei.com] has quit [Ping timeout: 252 seconds]
20171225 19:53:08< celticminstrel> vn971: I think the underlying Lua call used by [remove_object] might be able to do it, but not sure.
20171225 19:53:19-!- celticminstrel is now known as celmin|xmas
20171225 19:55:21< vn971> celmin|xmas: thanks, will try that. Currently already wrote an ugly hack to transform everyone to Peasant in prestart, and then revert back to normal on "turn 1". This won't work if I make my [multiplayer] scenario be a [modification], because my prestart would be too late then. So I do need a good solution, yes.
20171225 19:56:39-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has joined #wesnoth-dev
20171225 19:58:30< JyrkiVesterinen> celmin|xmas: All right, the animation releasing the reference came to my mind as well.
20171225 19:58:37< JyrkiVesterinen> I'll implement that later this week.
20171225 20:01:50-!- irker230 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171225 20:01:50< irker230> wesnoth/wesnoth:master Jyrki Vesterinen 70b468070b Work around unit halo not disappearing w AppVeyor: All builds passed
20171225 20:08:17-!- shangul [~shangul@unaffiliated/shangul] has quit [Remote host closed the connection]
20171225 20:45:28< vn971> Hm. I get an error like this if I create [set_menu_item] without `id` on wesnoth-1.13:  20171225 23:43:10 error scripting/lua: lua/wml-tags.lua:711: bad argument #1 to 'set_menu_item' (string expected, got nil)
20171225 20:45:55< vn971> how can I fix it, are there standard conventions to do that that I should copy-paste?
20171225 20:46:07-!- kri695 [~arvbz@c-73-46-208-14.hsd1.fl.comcast.net] has joined #wesnoth-dev
20171225 20:46:21< kri695> ▄▄▄▄▄▄▄▄▄▄▄▄▄ HAPPY NIGGER MAS!! IF YOU WANT JOIN A CELEBRATION THAT IS NIGGER FREE PLEASE JOIN #/JOIN RIGHT HERE ON THIS NETWORK!! sfslkdp: shadowm tomreyn midzer minzbonbon vn971 janebot madmax28 stikonas elias AI0867 crimson_penguin DeFender1031 celmin|xmas ChipmunkV[m] Gambit EliDupree TC01 pydsigner higgins` za
20171225 20:46:21-!- kri695 [~arvbz@c-73-46-208-14.hsd1.fl.comcast.net] has quit [Killed (Sigyn (Spam is off topic on freenode.))]
20171225 20:46:57< JyrkiVesterinen> Thank you, Sigyn. :)
20171225 20:47:24< vn971> if not, I'd write a separate `assert` statement, or maybe a code like `cfg.id or error("set_menu_item.id not set")`
20171225 20:47:57< vn971> yeah, it was a relief to see it disappear soon.
20171225 20:49:54< JyrkiVesterinen> I think Lua's assert() function is the preferred way to raise errors.
20171225 20:55:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171225 20:55:14-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171225 20:55:48< vn971> JyrkiVesterinen: hmm, I've grepped the code, and the answer was easy to find. I seems that this is actually preferred:
20171225 20:55:48< vn971> local message = tostring(cfg.message or
20171225 20:55:48< vn971> 	helper.wml_error "[chat] missing required message= attribute."
20171225 20:55:48< vn971> )
20171225 20:56:08< vn971> used a lot. Will use it if/when I'll raise a PR.
20171225 20:56:10< Gambit> Hmm that particular spammer should be reported to network opers
20171225 20:56:13< JyrkiVesterinen> OK, I see.
20171225 20:56:49< JyrkiVesterinen> Gambit: Sigyn already booted it from freenode, so it seems fine now.
20171225 20:57:18< Gambit> Hopefully they nuke that channel too
20171225 21:02:45-!- JyrkiVesterinen [~JyrkiVest@85-23-197-3.bb.dnainternet.fi] has quit [Quit: Going to bed]
20171225 21:22:28-!- octalot [~steve@178.165.131.1.wireless.dyn.drei.com] has joined #wesnoth-dev
20171225 22:09:32-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20171225 22:09:46-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20171225 22:15:01< vn971> // wow, gfgtdf-s "PYR-no-preparation-turn" addon is a real quality code. The first wesnoth addon code I really enjoy reading.
20171225 22:20:29< Ravana_> it has been useful for me as well
20171225 23:01:46-!- irker230 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20171225 23:24:29-!- irker162 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20171225 23:24:29< irker162> wesnoth/wesnoth:master doofus-01 1e7b65d9d3 remove specific mention of horses AppVeyor: All builds passed
--- Log closed Tue Dec 26 00:00:15 2017